mount.cifs: don't leak passwords with verbose option
authorJeff Layton <jlayton@redhat.com>
Fri, 25 Sep 2009 11:07:40 +0000 (07:07 -0400)
committerKarolin Seeger <kseeger@samba.org>
Thu, 1 Oct 2009 12:29:22 +0000 (14:29 +0200)
commit0597b97d159b22314f2b485145df7b82af717f0d
tree02220a0b6bc35b22a656c6297f34823c60c0c227
parente3dd6f99a4a7b87399bb5cfe4d3e06ac4d78c81f
mount.cifs: don't leak passwords with verbose option

When running mount.cifs with the --verbose option, it'll print out the
option string that it passes to the kernel...including the mount
password if there is one. Print a placeholder string instead to help
ensure that this info can't be used for nefarious purposes.

Also, the --verbose option printed the option string before it was
completely assembled anyway. This patch should also make sure that
the complete option string is printed out.

Finally, strndup passwords passed in on the command line to ensure that
they aren't shown by --verbose as well. Passwords used this way can
never be truly kept private from other users on the machine of course,
but it's simple enough to do it this way for completeness sake.

Reported-by: Ronald Volgers <r.c.volgers@student.utwente.nl>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Acked-by: Steve French <sfrench@us.ibm.com>
client/mount.cifs.c