s4-smbtorture: restructure test_OpenPrinter_server in RPC-SPOOLSS a bit.
[ira/wip.git] / source4 / torture / rpc / spoolss.c
index c16def09d2026e6cd0089c7c6f6bf7779567bdc3..3cfe02089285e513069f36a4f2e1c2c312471a26 100644 (file)
@@ -1,21 +1,22 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
    test suite for spoolss rpc operations
 
    Copyright (C) Tim Potter 2003
    Copyright (C) Stefan Metzmacher 2005
    Copyright (C) Jelmer Vernooij 2007
-   
+   Copyright (C) Guenther Deschner 2009
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
@@ -74,28 +75,30 @@ struct test_spoolss_context {
 
 #define COMPARE_STRING_ARRAY(tctx, c,r,e)
 
-static bool test_OpenPrinter_server(struct torture_context *tctx, struct dcerpc_pipe *p, struct test_spoolss_context *ctx)
+static bool test_OpenPrinter_server(struct torture_context *tctx,
+                                   struct dcerpc_pipe *p,
+                                   struct policy_handle *server_handle)
 {
        NTSTATUS status;
        struct spoolss_OpenPrinter op;
 
-       op.in.printername       = talloc_asprintf(ctx, "\\\\%s", dcerpc_server_name(p));
+       op.in.printername       = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        op.in.datatype          = NULL;
        op.in.devmode_ctr.devmode= NULL;
        op.in.access_mask       = 0;
-       op.out.handle           = &ctx->server_handle;
+       op.out.handle           = server_handle;
 
        torture_comment(tctx, "Testing OpenPrinter(%s)\n", op.in.printername);
 
-       status = dcerpc_spoolss_OpenPrinter(p, ctx, &op);
+       status = dcerpc_spoolss_OpenPrinter(p, tctx, &op);
        torture_assert_ntstatus_ok(tctx, status, "dcerpc_spoolss_OpenPrinter failed");
-       torture_assert_werr_ok(tctx, op.out.result, "dcerpc_spoolss_OpenPrinter failed"); 
+       torture_assert_werr_ok(tctx, op.out.result, "dcerpc_spoolss_OpenPrinter failed");
 
        return true;
 }
 
-static bool test_EnumPorts(struct torture_context *tctx, 
-                          struct dcerpc_pipe *p, 
+static bool test_EnumPorts(struct torture_context *tctx,
+                          struct dcerpc_pipe *p,
                           struct test_spoolss_context *ctx)
 {
        NTSTATUS status;
@@ -126,7 +129,7 @@ static bool test_EnumPorts(struct torture_context *tctx,
                        /* TODO: do some more checks here */
                        continue;
                }
-               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER, 
+               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER,
                        "EnumPorts unexpected return code");
 
                blob = data_blob_talloc(ctx, NULL, needed);
@@ -148,7 +151,7 @@ static bool test_EnumPorts(struct torture_context *tctx,
        for (i=1;i<ARRAY_SIZE(levels);i++) {
                int level = levels[i];
                int old_level = levels[i-1];
-               torture_assert_int_equal(tctx, ctx->port_count[level], ctx->port_count[old_level], 
+               torture_assert_int_equal(tctx, ctx->port_count[level], ctx->port_count[old_level],
                        "EnumPorts invalid value");
        }
        /* if the array sizes are not the same we would maybe segfault in the following code */
@@ -235,8 +238,8 @@ static bool test_GetPrintProcessorDirectory(struct torture_context *tctx,
 }
 
 
-static bool test_GetPrinterDriverDirectory(struct torture_context *tctx, 
-                                          struct dcerpc_pipe *p, 
+static bool test_GetPrinterDriverDirectory(struct torture_context *tctx,
+                                          struct dcerpc_pipe *p,
                                           struct test_spoolss_context *ctx)
 {
        NTSTATUS status;
@@ -278,9 +281,9 @@ static bool test_GetPrinterDriverDirectory(struct torture_context *tctx,
                torture_comment(tctx, "Testing GetPrinterDriverDirectory level %u\n", r.in.level);
 
                status = dcerpc_spoolss_GetPrinterDriverDirectory(p, ctx, &r);
-               torture_assert_ntstatus_ok(tctx, status, 
+               torture_assert_ntstatus_ok(tctx, status,
                        "dcerpc_spoolss_GetPrinterDriverDirectory failed");
-               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER, 
+               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER,
                        "GetPrinterDriverDirectory unexpected return code");
 
                blob = data_blob_talloc(ctx, NULL, needed);
@@ -297,24 +300,33 @@ static bool test_GetPrinterDriverDirectory(struct torture_context *tctx,
        return true;
 }
 
-static bool test_EnumPrinterDrivers(struct torture_context *tctx, 
+static bool test_EnumPrinterDrivers(struct torture_context *tctx,
                                    struct dcerpc_pipe *p,
                                    struct test_spoolss_context *ctx)
 {
        NTSTATUS status;
        struct spoolss_EnumPrinterDrivers r;
        uint16_t levels[] = { 1, 2, 3, 4, 5, 6 };
-       int i, j;
+       int i, j, a;
+       const char *architectures[] = {
+               SPOOLSS_ARCHITECTURE_NT_X86,
+               SPOOLSS_ARCHITECTURE_ALL
+       };
 
        for (i=0;i<ARRAY_SIZE(levels);i++) {
+       for (a=0;a<ARRAY_SIZE(architectures);a++) {
                int level = levels[i];
                DATA_BLOB blob;
                uint32_t needed;
                uint32_t count;
                union spoolss_DriverInfo *info;
 
-               r.in.server             = "";
-               r.in.environment        = SPOOLSS_ARCHITECTURE_NT_X86;
+               /* FIXME: gd, come back and fix "" as server, and handle
+                * priority of returned error codes in torture test and samba 3
+                * server */
+
+               r.in.server             = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
+               r.in.environment        = architectures[a];
                r.in.level              = level;
                r.in.buffer             = NULL;
                r.in.offered            = 0;
@@ -322,41 +334,58 @@ static bool test_EnumPrinterDrivers(struct torture_context *tctx,
                r.out.count             = &count;
                r.out.info              = &info;
 
-               torture_comment(tctx, "Testing EnumPrinterDrivers level %u\n", r.in.level);
+               torture_comment(tctx, "Testing EnumPrinterDrivers level %u (%s)\n", r.in.level, r.in.environment);
 
                status = dcerpc_spoolss_EnumPrinterDrivers(p, ctx, &r);
-               torture_assert_ntstatus_ok(tctx, status, 
+               torture_assert_ntstatus_ok(tctx, status,
                                           "dcerpc_spoolss_EnumPrinterDrivers failed");
                if (W_ERROR_IS_OK(r.out.result)) {
                        /* TODO: do some more checks here */
                        continue;
                }
-               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER, 
-                       "EnumPrinterDrivers failed");
-
-               blob = data_blob_talloc(ctx, NULL, needed);
-               data_blob_clear(&blob);
-               r.in.buffer = &blob;
-               r.in.offered = needed;
+               if (W_ERROR_EQUAL(r.out.result, WERR_INSUFFICIENT_BUFFER)) {
+                       blob = data_blob_talloc(ctx, NULL, needed);
+                       data_blob_clear(&blob);
+                       r.in.buffer = &blob;
+                       r.in.offered = needed;
 
-               status = dcerpc_spoolss_EnumPrinterDrivers(p, ctx, &r);
-               torture_assert_ntstatus_ok(tctx, status, "dcerpc_spoolss_EnumPrinterDrivers failed");
+                       status = dcerpc_spoolss_EnumPrinterDrivers(p, ctx, &r);
+                       torture_assert_ntstatus_ok(tctx, status, "dcerpc_spoolss_EnumPrinterDrivers failed");
+               }
 
                torture_assert_werr_ok(tctx, r.out.result, "EnumPrinterDrivers failed");
 
+               /* don't do cross-architecture comparison */
+               if (strequal(r.in.environment, SPOOLSS_ARCHITECTURE_ALL)) {
+                       continue;
+               }
+
                ctx->driver_count[level]        = count;
                ctx->drivers[level]             = info;
        }
+       }
 
        for (i=1;i<ARRAY_SIZE(levels);i++) {
                int level = levels[i];
                int old_level = levels[i-1];
+
+               /* don't do cross-architecture comparison */
+               if (strequal(r.in.environment, SPOOLSS_ARCHITECTURE_ALL)) {
+                       continue;
+               }
+
                torture_assert_int_equal(tctx, ctx->driver_count[level], ctx->driver_count[old_level],
                        "EnumPrinterDrivers invalid value");
        }
 
        for (i=0;i<ARRAY_SIZE(levels);i++) {
                int level = levels[i];
+
+               /* don't do cross-architecture comparison */
+               if (strequal(r.in.environment, SPOOLSS_ARCHITECTURE_ALL)) {
+                       continue;
+               }
+
                for (j=0;j<ctx->driver_count[level];j++) {
                        union spoolss_DriverInfo *cur = &ctx->drivers[level][j];
                        union spoolss_DriverInfo *ref = &ctx->drivers[6][j];
@@ -418,8 +447,8 @@ static bool test_EnumPrinterDrivers(struct torture_context *tctx,
        return true;
 }
 
-static bool test_EnumMonitors(struct torture_context *tctx, 
-                             struct dcerpc_pipe *p, 
+static bool test_EnumMonitors(struct torture_context *tctx,
+                             struct dcerpc_pipe *p,
                              struct test_spoolss_context *ctx)
 {
        NTSTATUS status;
@@ -450,7 +479,7 @@ static bool test_EnumMonitors(struct torture_context *tctx,
                        /* TODO: do some more checks here */
                        continue;
                }
-               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER, 
+               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER,
                        "EnumMonitors failed");
 
                blob = data_blob_talloc(ctx, NULL, needed);
@@ -470,7 +499,7 @@ static bool test_EnumMonitors(struct torture_context *tctx,
        for (i=1;i<ARRAY_SIZE(levels);i++) {
                int level = levels[i];
                int old_level = levels[i-1];
-               torture_assert_int_equal(tctx, ctx->monitor_count[level], ctx->monitor_count[old_level], 
+               torture_assert_int_equal(tctx, ctx->monitor_count[level], ctx->monitor_count[old_level],
                                         "EnumMonitors invalid value");
        }
 
@@ -493,7 +522,7 @@ static bool test_EnumMonitors(struct torture_context *tctx,
        return true;
 }
 
-static bool test_EnumPrintProcessors(struct torture_context *tctx, 
+static bool test_EnumPrintProcessors(struct torture_context *tctx,
                                     struct dcerpc_pipe *p,
                                     struct test_spoolss_context *ctx)
 {
@@ -510,7 +539,7 @@ static bool test_EnumPrintProcessors(struct torture_context *tctx,
                union spoolss_PrintProcessorInfo *info;
 
                r.in.servername = "";
-               r.in.environment = "Windows NT x86";
+               r.in.environment = SPOOLSS_ARCHITECTURE_NT_X86;
                r.in.level = level;
                r.in.buffer = NULL;
                r.in.offered = 0;
@@ -526,7 +555,7 @@ static bool test_EnumPrintProcessors(struct torture_context *tctx,
                        /* TODO: do some more checks here */
                        continue;
                }
-               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER, 
+               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER,
                        "EnumPrintProcessors unexpected return code");
 
                blob = data_blob_talloc(ctx, NULL, needed);
@@ -619,7 +648,7 @@ static bool test_EnumPrintProcDataTypes(struct torture_context *tctx,
 }
 
 
-static bool test_EnumPrinters(struct torture_context *tctx, 
+static bool test_EnumPrinters(struct torture_context *tctx,
                              struct dcerpc_pipe *p,
                              struct test_spoolss_context *ctx)
 {
@@ -652,7 +681,7 @@ static bool test_EnumPrinters(struct torture_context *tctx,
                        /* TODO: do some more checks here */
                        continue;
                }
-               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER, 
+               torture_assert_werr_equal(tctx, r.out.result, WERR_INSUFFICIENT_BUFFER,
                        "EnumPrinters unexpected return code");
 
                blob = data_blob_talloc(ctx, NULL, needed);
@@ -688,7 +717,7 @@ static bool test_EnumPrinters(struct torture_context *tctx,
                                COMPARE_UINT32(tctx, cur->info0, ref->info2, cjobs);
                                /*COMPARE_UINT32(tctx, cur->info0, ref->info2, total_jobs);
                                COMPARE_UINT32(tctx, cur->info0, ref->info2, total_bytes);
-                               COMPARE_SPOOLSS_TIME(cur->info0, ref->info2, spoolss_Time time);                
+                               COMPARE_SPOOLSS_TIME(cur->info0, ref->info2, spoolss_Time time);
                                COMPARE_UINT32(tctx, cur->info0, ref->info2, global_counter);
                                COMPARE_UINT32(tctx, cur->info0, ref->info2, total_pages);
                                COMPARE_UINT32(tctx, cur->info0, ref->info2, version);
@@ -745,8 +774,8 @@ static bool test_EnumPrinters(struct torture_context *tctx,
        return true;
 }
 
-static bool test_GetPrinter(struct torture_context *tctx, 
-                           struct dcerpc_pipe *p, 
+static bool test_GetPrinter(struct torture_context *tctx,
+                           struct dcerpc_pipe *p,
                     struct policy_handle *handle)
 {
        NTSTATUS status;
@@ -754,7 +783,7 @@ static bool test_GetPrinter(struct torture_context *tctx,
        uint16_t levels[] = {0, 1, 2, 3, 4, 5, 6, 7, 8};
        int i;
        uint32_t needed;
-       
+
        for (i=0;i<ARRAY_SIZE(levels);i++) {
                r.in.handle = handle;
                r.in.level = levels[i];
@@ -766,7 +795,7 @@ static bool test_GetPrinter(struct torture_context *tctx,
 
                status = dcerpc_spoolss_GetPrinter(p, tctx, &r);
                torture_assert_ntstatus_ok(tctx, status, "GetPrinter failed");
-               
+
                if (W_ERROR_EQUAL(r.out.result, WERR_INSUFFICIENT_BUFFER)) {
                        DATA_BLOB blob = data_blob_talloc(tctx, NULL, needed);
                        data_blob_clear(&blob);
@@ -774,7 +803,7 @@ static bool test_GetPrinter(struct torture_context *tctx,
                        r.in.offered = needed;
                        status = dcerpc_spoolss_GetPrinter(p, tctx, &r);
                }
-               
+
                torture_assert_ntstatus_ok(tctx, status, "GetPrinter failed");
 
                torture_assert_werr_ok(tctx, r.out.result, "GetPrinter failed");
@@ -784,8 +813,8 @@ static bool test_GetPrinter(struct torture_context *tctx,
 }
 
 
-static bool test_ClosePrinter(struct torture_context *tctx, 
-                             struct dcerpc_pipe *p, 
+static bool test_ClosePrinter(struct torture_context *tctx,
+                             struct dcerpc_pipe *p,
                              struct policy_handle *handle)
 {
        NTSTATUS status;
@@ -802,9 +831,9 @@ static bool test_ClosePrinter(struct torture_context *tctx,
        return true;
 }
 
-static bool test_GetForm(struct torture_context *tctx, 
-                        struct dcerpc_pipe *p, 
-                        struct policy_handle *handle, 
+static bool test_GetForm(struct torture_context *tctx,
+                        struct dcerpc_pipe *p,
+                        struct policy_handle *handle,
                         const char *form_name,
                         uint32_t level)
 {
@@ -842,8 +871,8 @@ static bool test_GetForm(struct torture_context *tctx,
        return true;
 }
 
-static bool test_EnumForms(struct torture_context *tctx, 
-                          struct dcerpc_pipe *p, 
+static bool test_EnumForms(struct torture_context *tctx,
+                          struct dcerpc_pipe *p,
                           struct policy_handle *handle, bool print_server)
 {
        NTSTATUS status;
@@ -903,9 +932,9 @@ static bool test_EnumForms(struct torture_context *tctx,
        return true;
 }
 
-static bool test_DeleteForm(struct torture_context *tctx, 
-                           struct dcerpc_pipe *p, 
-                           struct policy_handle *handle, 
+static bool test_DeleteForm(struct torture_context *tctx,
+                           struct dcerpc_pipe *p,
+                           struct policy_handle *handle,
                            const char *form_name)
 {
        NTSTATUS status;
@@ -923,8 +952,8 @@ static bool test_DeleteForm(struct torture_context *tctx,
        return true;
 }
 
-static bool test_AddForm(struct torture_context *tctx, 
-                        struct dcerpc_pipe *p, 
+static bool test_AddForm(struct torture_context *tctx,
+                        struct dcerpc_pipe *p,
                         struct policy_handle *handle, bool print_server)
 {
        struct spoolss_AddForm r;
@@ -977,6 +1006,50 @@ static bool test_AddForm(struct torture_context *tctx,
 
        if (!print_server) ret &= test_GetForm(tctx, p, handle, form_name, 1);
 
+       {
+               struct spoolss_EnumForms e;
+               union spoolss_FormInfo *info;
+               uint32_t needed;
+               uint32_t count;
+               bool found = false;
+
+               e.in.handle = handle;
+               e.in.level = 1;
+               e.in.buffer = NULL;
+               e.in.offered = 0;
+               e.out.needed = &needed;
+               e.out.count = &count;
+               e.out.info = &info;
+
+               torture_comment(tctx, "Testing EnumForms level 1\n");
+
+               status = dcerpc_spoolss_EnumForms(p, tctx, &e);
+               torture_assert_ntstatus_ok(tctx, status, "EnumForms failed");
+
+               if (print_server && W_ERROR_EQUAL(e.out.result, WERR_BADFID))
+                       torture_fail(tctx, "EnumForms on the PrintServer isn't supported by test server (NT4)");
+
+               if (W_ERROR_EQUAL(e.out.result, WERR_INSUFFICIENT_BUFFER)) {
+                       int j;
+                       DATA_BLOB blob = data_blob_talloc(tctx, NULL, needed);
+                       data_blob_clear(&blob);
+                       e.in.buffer = &blob;
+                       e.in.offered = needed;
+
+                       status = dcerpc_spoolss_EnumForms(p, tctx, &e);
+
+                       torture_assert(tctx, info, "No forms returned");
+
+                       for (j = 0; j < count; j++) {
+                               if (strequal(form_name, info[j].info1.form_name)) {
+                                       found = true;
+                                       break;
+                               }
+                       }
+               }
+               torture_assert(tctx, found, "Newly added form not found in enum call");
+       }
+
        if (!test_DeleteForm(tctx, p, handle, form_name)) {
                ret = false;
        }
@@ -984,7 +1057,7 @@ static bool test_AddForm(struct torture_context *tctx,
        return ret;
 }
 
-static bool test_EnumPorts_old(struct torture_context *tctx, 
+static bool test_EnumPorts_old(struct torture_context *tctx,
                               struct dcerpc_pipe *p)
 {
        NTSTATUS status;
@@ -993,7 +1066,7 @@ static bool test_EnumPorts_old(struct torture_context *tctx,
        uint32_t count;
        union spoolss_PortInfo *info;
 
-       r.in.servername = talloc_asprintf(tctx, "\\\\%s", 
+       r.in.servername = talloc_asprintf(tctx, "\\\\%s",
                                          dcerpc_server_name(p));
        r.in.level = 2;
        r.in.buffer = NULL;
@@ -1023,13 +1096,13 @@ static bool test_EnumPorts_old(struct torture_context *tctx,
        return true;
 }
 
-static bool test_AddPort(struct torture_context *tctx, 
+static bool test_AddPort(struct torture_context *tctx,
                         struct dcerpc_pipe *p)
 {
        NTSTATUS status;
        struct spoolss_AddPort r;
 
-       r.in.server_name = talloc_asprintf(tctx, "\\\\%s", 
+       r.in.server_name = talloc_asprintf(tctx, "\\\\%s",
                                           dcerpc_server_name(p));
        r.in.unknown = 0;
        r.in.monitor_name = "foo";
@@ -1054,43 +1127,63 @@ static bool test_AddPort(struct torture_context *tctx,
        return true;
 }
 
-static bool test_GetJob(struct torture_context *tctx, 
-                       struct dcerpc_pipe *p, 
+static bool test_GetJob(struct torture_context *tctx,
+                       struct dcerpc_pipe *p,
                        struct policy_handle *handle, uint32_t job_id)
 {
        NTSTATUS status;
        struct spoolss_GetJob r;
+       union spoolss_JobInfo info;
        uint32_t needed;
+       uint32_t levels[] = {1, 2 /* 3, 4 */};
+       uint32_t i;
 
        r.in.handle = handle;
        r.in.job_id = job_id;
-       r.in.level = 1;
+       r.in.level = 0;
        r.in.buffer = NULL;
        r.in.offered = 0;
        r.out.needed = &needed;
+       r.out.info = &info;
 
-       torture_comment(tctx, "Testing GetJob\n");
+       torture_comment(tctx, "Testing GetJob level %d\n", r.in.level);
 
        status = dcerpc_spoolss_GetJob(p, tctx, &r);
-       torture_assert_ntstatus_ok(tctx, status, "GetJob failed");
+       torture_assert_werr_equal(tctx, r.out.result, WERR_UNKNOWN_LEVEL, "Unexpected return code");
 
-       if (W_ERROR_EQUAL(r.out.result, WERR_INSUFFICIENT_BUFFER)) {
-               DATA_BLOB blob = data_blob_talloc(tctx, NULL, needed);
-               data_blob_clear(&blob);
-               r.in.buffer = &blob;
-               r.in.offered = needed;
+       for (i = 0; i < ARRAY_SIZE(levels); i++) {
+
+               torture_comment(tctx, "Testing GetJob level %d\n", r.in.level);
+
+               needed = 0;
+
+               r.in.level = levels[i];
+               r.in.offered = 0;
+               r.in.buffer = NULL;
 
                status = dcerpc_spoolss_GetJob(p, tctx, &r);
+               torture_assert_ntstatus_ok(tctx, status, "GetJob failed");
+
+               if (W_ERROR_EQUAL(r.out.result, WERR_INSUFFICIENT_BUFFER)) {
+                       DATA_BLOB blob = data_blob_talloc(tctx, NULL, needed);
+                       data_blob_clear(&blob);
+                       r.in.buffer = &blob;
+                       r.in.offered = needed;
+
+                       status = dcerpc_spoolss_GetJob(p, tctx, &r);
+                       torture_assert_ntstatus_ok(tctx, status, "GetJob failed");
 
+               }
                torture_assert(tctx, r.out.info, "No job info returned");
+               torture_assert_werr_ok(tctx, r.out.result, "GetJob failed");
        }
 
        return true;
 }
 
-static bool test_SetJob(struct torture_context *tctx, 
-                       struct dcerpc_pipe *p, 
-                       struct policy_handle *handle, uint32_t job_id, 
+static bool test_SetJob(struct torture_context *tctx,
+                       struct dcerpc_pipe *p,
+                       struct policy_handle *handle, uint32_t job_id,
                        enum spoolss_JobControl command)
 {
        NTSTATUS status;
@@ -1101,7 +1194,38 @@ static bool test_SetJob(struct torture_context *tctx,
        r.in.ctr        = NULL;
        r.in.command    = command;
 
-       torture_comment(tctx, "Testing SetJob\n");
+       switch (command) {
+       case SPOOLSS_JOB_CONTROL_PAUSE:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_PAUSE\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_RESUME:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_RESUME\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_CANCEL:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_CANCEL\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_RESTART:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_RESTART\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_DELETE:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_DELETE\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_SEND_TO_PRINTER:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_SEND_TO_PRINTER\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_LAST_PAGE_EJECTED:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_LAST_PAGE_EJECTED\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_RETAIN:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_RETAIN\n");
+               break;
+       case SPOOLSS_JOB_CONTROL_RELEASE:
+               torture_comment(tctx, "Testing SetJob: SPOOLSS_JOB_CONTROL_RELEASE\n");
+               break;
+       default:
+               torture_comment(tctx, "Testing SetJob\n");
+               break;
+       }
 
        status = dcerpc_spoolss_SetJob(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "SetJob failed");
@@ -1122,6 +1246,7 @@ static bool test_AddJob(struct torture_context *tctx,
        r.in.handle = handle;
        r.in.offered = 0;
        r.out.needed = &needed;
+       r.in.buffer = r.out.buffer = NULL;
 
        torture_comment(tctx, "Testing AddJob\n");
 
@@ -1137,8 +1262,8 @@ static bool test_AddJob(struct torture_context *tctx,
 }
 
 
-static bool test_EnumJobs(struct torture_context *tctx, 
-                         struct dcerpc_pipe *p, 
+static bool test_EnumJobs(struct torture_context *tctx,
+                         struct dcerpc_pipe *p,
                          struct policy_handle *handle)
 {
        NTSTATUS status;
@@ -1177,8 +1302,12 @@ static bool test_EnumJobs(struct torture_context *tctx,
                for (j = 0; j < count; j++) {
 
                        test_GetJob(tctx, p, handle, info[j].info1.job_id);
-                       test_SetJob(tctx, p, handle, info[j].info1.job_id, SPOOLSS_JOB_CONTROL_PAUSE);
-                       test_SetJob(tctx, p, handle, info[j].info1.job_id, SPOOLSS_JOB_CONTROL_RESUME);
+
+                       /* FIXME - gd */
+                       if (!torture_setting_bool(tctx, "samba3", false)) {
+                               test_SetJob(tctx, p, handle, info[j].info1.job_id, SPOOLSS_JOB_CONTROL_PAUSE);
+                               test_SetJob(tctx, p, handle, info[j].info1.job_id, SPOOLSS_JOB_CONTROL_RESUME);
+                       }
                }
 
        } else {
@@ -1188,8 +1317,8 @@ static bool test_EnumJobs(struct torture_context *tctx,
        return true;
 }
 
-static bool test_DoPrintTest(struct torture_context *tctx, 
-                            struct dcerpc_pipe *p, 
+static bool test_DoPrintTest(struct torture_context *tctx,
+                            struct dcerpc_pipe *p,
                             struct policy_handle *handle)
 {
        bool ret = true;
@@ -1224,7 +1353,7 @@ static bool test_DoPrintTest(struct torture_context *tctx,
                sp.in.handle            = handle;
 
                status = dcerpc_spoolss_StartPagePrinter(p, tctx, &sp);
-               torture_assert_ntstatus_ok(tctx, status, 
+               torture_assert_ntstatus_ok(tctx, status,
                                           "dcerpc_spoolss_StartPagePrinter failed");
                torture_assert_werr_ok(tctx, sp.out.result, "StartPagePrinter failed");
 
@@ -1263,8 +1392,8 @@ static bool test_DoPrintTest(struct torture_context *tctx,
        return ret;
 }
 
-static bool test_PausePrinter(struct torture_context *tctx, 
-                             struct dcerpc_pipe *p, 
+static bool test_PausePrinter(struct torture_context *tctx,
+                             struct dcerpc_pipe *p,
                              struct policy_handle *handle)
 {
        NTSTATUS status;
@@ -1296,8 +1425,8 @@ static bool test_PausePrinter(struct torture_context *tctx,
        return true;
 }
 
-static bool test_ResumePrinter(struct torture_context *tctx, 
-                              struct dcerpc_pipe *p, 
+static bool test_ResumePrinter(struct torture_context *tctx,
+                              struct dcerpc_pipe *p,
                               struct policy_handle *handle)
 {
        NTSTATUS status;
@@ -1329,9 +1458,9 @@ static bool test_ResumePrinter(struct torture_context *tctx,
        return true;
 }
 
-static bool test_GetPrinterData(struct torture_context *tctx, 
-                               struct dcerpc_pipe *p, 
-                               struct policy_handle *handle, 
+static bool test_GetPrinterData(struct torture_context *tctx,
+                               struct dcerpc_pipe *p,
+                               struct policy_handle *handle,
                                const char *value_name)
 {
        NTSTATUS status;
@@ -1364,9 +1493,9 @@ static bool test_GetPrinterData(struct torture_context *tctx,
        return true;
 }
 
-static bool test_GetPrinterDataEx(struct torture_context *tctx, 
-                                 struct dcerpc_pipe *p, 
-                                 struct policy_handle *handle, 
+static bool test_GetPrinterDataEx(struct torture_context *tctx,
+                                 struct dcerpc_pipe *p,
+                                 struct policy_handle *handle,
                                  const char *key_name,
                                  const char *value_name)
 {
@@ -1381,6 +1510,7 @@ static bool test_GetPrinterDataEx(struct torture_context *tctx,
        r.in.offered = 0;
        r.out.type = &type;
        r.out.needed = &needed;
+       r.out.buffer = NULL;
 
        torture_comment(tctx, "Testing GetPrinterDataEx\n");
 
@@ -1406,7 +1536,7 @@ static bool test_GetPrinterDataEx(struct torture_context *tctx,
        return true;
 }
 
-static bool test_EnumPrinterData(struct torture_context *tctx, struct dcerpc_pipe *p, 
+static bool test_EnumPrinterData(struct torture_context *tctx, struct dcerpc_pipe *p,
                                 struct policy_handle *handle)
 {
        NTSTATUS status;
@@ -1443,11 +1573,11 @@ static bool test_EnumPrinterData(struct torture_context *tctx, struct dcerpc_pip
                status = dcerpc_spoolss_EnumPrinterData(p, tctx, &r);
 
                torture_assert_ntstatus_ok(tctx, status, "EnumPrinterData failed");
-               
+
                test_GetPrinterData(tctx, p, handle, r.out.value_name);
 
-               test_GetPrinterDataEx(tctx, 
-                       p, handle, "PrinterDriverData", 
+               test_GetPrinterDataEx(tctx,
+                       p, handle, "PrinterDriverData",
                        r.out.value_name);
 
                r.in.enum_index++;
@@ -1457,12 +1587,13 @@ static bool test_EnumPrinterData(struct torture_context *tctx, struct dcerpc_pip
        return true;
 }
 
-static bool test_EnumPrinterDataEx(struct torture_context *tctx, 
-                                  struct dcerpc_pipe *p, 
+static bool test_EnumPrinterDataEx(struct torture_context *tctx,
+                                  struct dcerpc_pipe *p,
                                   struct policy_handle *handle)
 {
        NTSTATUS status;
        struct spoolss_EnumPrinterDataEx r;
+       struct spoolss_PrinterEnumValues *info;
        uint32_t needed;
        uint32_t count;
 
@@ -1471,6 +1602,7 @@ static bool test_EnumPrinterDataEx(struct torture_context *tctx,
        r.in.offered = 0;
        r.out.needed = &needed;
        r.out.count = &count;
+       r.out.info = &info;
 
        torture_comment(tctx, "Testing EnumPrinterDataEx\n");
 
@@ -1478,7 +1610,6 @@ static bool test_EnumPrinterDataEx(struct torture_context *tctx,
        torture_assert_ntstatus_ok(tctx, status, "EnumPrinterDataEx failed");
 
        r.in.offered = needed;
-       r.out.buffer = talloc_array(tctx, uint8_t, needed);
 
        status = dcerpc_spoolss_EnumPrinterDataEx(p, tctx, &r);
 
@@ -1488,9 +1619,9 @@ static bool test_EnumPrinterDataEx(struct torture_context *tctx,
 }
 
 
-static bool test_DeletePrinterData(struct torture_context *tctx, 
-                                  struct dcerpc_pipe *p, 
-                                  struct policy_handle *handle, 
+static bool test_DeletePrinterData(struct torture_context *tctx,
+                                  struct dcerpc_pipe *p,
+                                  struct policy_handle *handle,
                                   const char *value_name)
 {
        NTSTATUS status;
@@ -1508,14 +1639,14 @@ static bool test_DeletePrinterData(struct torture_context *tctx,
        return true;
 }
 
-static bool test_SetPrinterData(struct torture_context *tctx, 
-                               struct dcerpc_pipe *p, 
+static bool test_SetPrinterData(struct torture_context *tctx,
+                               struct dcerpc_pipe *p,
                                struct policy_handle *handle)
 {
        NTSTATUS status;
        struct spoolss_SetPrinterData r;
        const char *value_name = "spottyfoot";
-       
+
        r.in.handle = handle;
        r.in.value_name = value_name;
        r.in.type = REG_SZ;
@@ -1538,8 +1669,8 @@ static bool test_SetPrinterData(struct torture_context *tctx,
        return true;
 }
 
-static bool test_SecondaryClosePrinter(struct torture_context *tctx, 
-                                      struct dcerpc_pipe *p, 
+static bool test_SecondaryClosePrinter(struct torture_context *tctx,
+                                      struct dcerpc_pipe *p,
                                       struct policy_handle *handle)
 {
        NTSTATUS status;
@@ -1570,7 +1701,7 @@ static bool test_SecondaryClosePrinter(struct torture_context *tctx,
        torture_assert_ntstatus_equal(tctx, status, NT_STATUS_NET_WRITE_FAULT,
                        "ERROR: Allowed close on secondary connection");
 
-       torture_assert_int_equal(tctx, p2->last_fault_code, DCERPC_FAULT_CONTEXT_MISMATCH, 
+       torture_assert_int_equal(tctx, p2->last_fault_code, DCERPC_FAULT_CONTEXT_MISMATCH,
                                 "Unexpected fault code");
 
        talloc_free(p2);
@@ -1578,7 +1709,7 @@ static bool test_SecondaryClosePrinter(struct torture_context *tctx,
        return true;
 }
 
-static bool test_OpenPrinter_badname(struct torture_context *tctx, 
+static bool test_OpenPrinter_badname(struct torture_context *tctx,
                                     struct dcerpc_pipe *p, const char *name)
 {
        NTSTATUS status;
@@ -1630,8 +1761,8 @@ static bool test_OpenPrinter_badname(struct torture_context *tctx,
        return ret;
 }
 
-static bool test_OpenPrinter(struct torture_context *tctx, 
-                            struct dcerpc_pipe *p, 
+static bool test_OpenPrinter(struct torture_context *tctx,
+                            struct dcerpc_pipe *p,
                             const char *name)
 {
        NTSTATUS status;
@@ -1657,8 +1788,10 @@ static bool test_OpenPrinter(struct torture_context *tctx,
                ret = false;
        }
 
-       if (!test_SecondaryClosePrinter(tctx, p, &handle)) {
-               ret = false;
+       if (!torture_setting_bool(tctx, "samba3", false)) {
+               if (!test_SecondaryClosePrinter(tctx, p, &handle)) {
+                       ret = false;
+               }
        }
 
        if (!test_ClosePrinter(tctx, p, &handle)) {
@@ -1668,8 +1801,8 @@ static bool test_OpenPrinter(struct torture_context *tctx,
        return ret;
 }
 
-static bool call_OpenPrinterEx(struct torture_context *tctx, 
-                              struct dcerpc_pipe *p, 
+static bool call_OpenPrinterEx(struct torture_context *tctx,
+                              struct dcerpc_pipe *p,
                               const char *name, struct policy_handle *handle)
 {
        struct spoolss_OpenPrinterEx r;
@@ -1677,10 +1810,10 @@ static bool call_OpenPrinterEx(struct torture_context *tctx,
        NTSTATUS status;
 
        if (name && name[0]) {
-               r.in.printername = talloc_asprintf(tctx, "\\\\%s\\%s", 
+               r.in.printername = talloc_asprintf(tctx, "\\\\%s\\%s",
                                                   dcerpc_server_name(p), name);
        } else {
-               r.in.printername = talloc_asprintf(tctx, "\\\\%s", 
+               r.in.printername = talloc_asprintf(tctx, "\\\\%s",
                                                   dcerpc_server_name(p));
        }
 
@@ -1704,14 +1837,14 @@ static bool call_OpenPrinterEx(struct torture_context *tctx,
        status = dcerpc_spoolss_OpenPrinterEx(p, tctx, &r);
 
        torture_assert_ntstatus_ok(tctx, status, "OpenPrinterEx failed");
-       
+
        torture_assert_werr_ok(tctx, r.out.result, "OpenPrinterEx failed");
 
        return true;
 }
 
-static bool test_OpenPrinterEx(struct torture_context *tctx, 
-                              struct dcerpc_pipe *p, 
+static bool test_OpenPrinterEx(struct torture_context *tctx,
+                              struct dcerpc_pipe *p,
                               const char *name)
 {
        struct policy_handle handle;
@@ -1757,14 +1890,16 @@ static bool test_OpenPrinterEx(struct torture_context *tctx,
                ret = false;
        }
 
-       if (!test_SecondaryClosePrinter(tctx, p, &handle)) {
-               ret = false;
+       if (!torture_setting_bool(tctx, "samba3", false)) {
+               if (!test_SecondaryClosePrinter(tctx, p, &handle)) {
+                       ret = false;
+               }
        }
 
        if (!test_ClosePrinter(tctx, p, &handle)) {
                ret = false;
        }
-       
+
        return ret;
 }
 
@@ -1815,10 +1950,17 @@ static bool test_EnumPrinters_old(struct torture_context *tctx, struct dcerpc_pi
 
                for (j=0;j<count;j++) {
                        if (r.in.level == 1) {
-                               /* the names appear to be comma-separated name lists? */
-                               char *name = talloc_strdup(tctx, info[j].info1.name);
-                               char *comma = strchr(name, ',');
-                               if (comma) *comma = 0;
+                               char *unc = talloc_strdup(tctx, info[j].info1.name);
+                               char *slash, *name;
+                               name = unc;
+                               if (unc[0] == '\\' && unc[1] == '\\') {
+                                       unc +=2;
+                               }
+                               slash = strchr(unc, '\\');
+                               if (slash) {
+                                       slash++;
+                                       name = slash;
+                               }
                                if (!test_OpenPrinter(tctx, p, name)) {
                                        ret = false;
                                }
@@ -1833,8 +1975,8 @@ static bool test_EnumPrinters_old(struct torture_context *tctx, struct dcerpc_pi
 }
 
 #if 0
-static bool test_GetPrinterDriver2(struct dcerpc_pipe *p, 
-                                  struct policy_handle *handle, 
+static bool test_GetPrinterDriver2(struct dcerpc_pipe *p,
+                                  struct policy_handle *handle,
                                   const char *driver_name)
 {
        NTSTATUS status;
@@ -1866,15 +2008,15 @@ static bool test_GetPrinterDriver2(struct dcerpc_pipe *p,
                r.in.offered = needed;
                status = dcerpc_spoolss_GetPrinterDriver2(p, tctx, &r);
        }
-               
+
        if (!NT_STATUS_IS_OK(status)) {
-               printf("GetPrinterDriver2 failed - %s\n", 
+               printf("GetPrinterDriver2 failed - %s\n",
                       nt_errstr(status));
                return false;
        }
 
        if (!W_ERROR_IS_OK(r.out.result)) {
-               printf("GetPrinterDriver2 failed - %s\n", 
+               printf("GetPrinterDriver2 failed - %s\n",
                       win_errstr(r.out.result));
                return false;
        }
@@ -1883,7 +2025,7 @@ static bool test_GetPrinterDriver2(struct dcerpc_pipe *p,
 }
 #endif
 
-static bool test_EnumPrinterDrivers_old(struct torture_context *tctx, 
+static bool test_EnumPrinterDrivers_old(struct torture_context *tctx,
                                        struct dcerpc_pipe *p)
 {
        struct spoolss_EnumPrinterDrivers r;
@@ -1898,7 +2040,7 @@ static bool test_EnumPrinterDrivers_old(struct torture_context *tctx,
                union spoolss_DriverInfo *info;
 
                r.in.server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
-               r.in.environment = "Windows NT x86";
+               r.in.environment = SPOOLSS_ARCHITECTURE_NT_X86;
                r.in.level = levels[i];
                r.in.buffer = NULL;
                r.in.offered = 0;
@@ -1933,41 +2075,6 @@ static bool test_EnumPrinterDrivers_old(struct torture_context *tctx,
        return true;
 }
 
-/** Test that makes sure that calling ReplyOpenPrinter()
- * on Samba 4 will cause an irpc broadcast call.
- */
-static bool test_ReplyOpenPrinter(struct torture_context *tctx, 
-                                 struct dcerpc_pipe *pipe)
-{
-       struct spoolss_ReplyOpenPrinter r;
-       struct spoolss_ReplyClosePrinter s;
-       struct policy_handle h;
-
-       r.in.server_name = "earth";
-       r.in.printer_local = 2;
-       r.in.type = REG_DWORD;
-       r.in.bufsize = 0;
-       r.in.buffer = NULL;
-       r.out.handle = &h;
-
-       torture_assert_ntstatus_ok(tctx, 
-                       dcerpc_spoolss_ReplyOpenPrinter(pipe, tctx, &r),
-                       "spoolss_ReplyOpenPrinter call failed");
-
-       torture_assert_werr_ok(tctx, r.out.result, "error return code");
-
-       s.in.handle = &h;
-       s.out.handle = &h;
-
-       torture_assert_ntstatus_ok(tctx,
-                       dcerpc_spoolss_ReplyClosePrinter(pipe, tctx, &s),
-                       "spoolss_ReplyClosePrinter call failed");
-
-       torture_assert_werr_ok(tctx, r.out.result, "error return code");
-
-       return true;
-}
-
 bool torture_rpc_spoolss(struct torture_context *torture)
 {
        NTSTATUS status;
@@ -1982,7 +2089,7 @@ bool torture_rpc_spoolss(struct torture_context *torture)
 
        ctx = talloc_zero(torture, struct test_spoolss_context);
 
-       ret &= test_OpenPrinter_server(torture, p, ctx);
+       ret &= test_OpenPrinter_server(torture, p, &ctx->server_handle);
 
        ret &= test_GetPrinterData(torture, p, &ctx->server_handle, "W3SvcInstalled");
        ret &= test_GetPrinterData(torture, p, &ctx->server_handle, "BeepEnabled");
@@ -2013,7 +2120,7 @@ bool torture_rpc_spoolss(struct torture_context *torture)
        ret &= test_OpenPrinter_badname(torture, p, "\\\\\\");
        ret &= test_OpenPrinter_badname(torture, p, "\\\\\\__INVALID_PRINTER__");
        ret &= test_OpenPrinter_badname(torture, p, talloc_asprintf(torture, "\\\\%s\\", dcerpc_server_name(p)));
-       ret &= test_OpenPrinter_badname(torture, p, 
+       ret &= test_OpenPrinter_badname(torture, p,
                                        talloc_asprintf(torture, "\\\\%s\\__INVALID_PRINTER__", dcerpc_server_name(p)));
 
 
@@ -2021,7 +2128,6 @@ bool torture_rpc_spoolss(struct torture_context *torture)
        ret &= test_EnumPorts_old(torture, p);
        ret &= test_EnumPrinters_old(torture, p);
        ret &= test_EnumPrinterDrivers_old(torture, p);
-       ret &= test_ReplyOpenPrinter(torture, p);
 
        return ret;
 }