s4-smbtorture: re-arrange netlogon LogonControl test.
[ira/wip.git] / source4 / torture / rpc / netlogon.c
index d4cad6e57a374350b4df0026404ed718cbbe622e..897283470fa7d3d96344ed863ed3a19eb2c258d5 100644 (file)
@@ -6,6 +6,7 @@
    Copyright (C) Andrew Tridgell 2003
    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2003-2004
    Copyright (C) Tim Potter      2003
+   Copyright (C) Matthias Dieter Wallnöfer            2009
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 */
 
 #include "includes.h"
-#include "torture/torture.h"
 #include "lib/events/events.h"
-#include "auth/auth.h"
-#include "auth/gensec/gensec.h"
 #include "lib/cmdline/popt_common.h"
 #include "torture/rpc/rpc.h"
-#include "torture/rpc/netlogon.h"
 #include "../lib/crypto/crypto.h"
 #include "libcli/auth/libcli_auth.h"
 #include "librpc/gen_ndr/ndr_netlogon_c.h"
 #include "librpc/gen_ndr/ndr_lsa_c.h"
 #include "param/param.h"
+#include "libcli/security/security.h"
+#include "lib/ldb/include/ldb.h"
+#include "lib/util/util_ldb.h"
+#include "lib/ldb_wrap.h"
 
 #define TEST_MACHINE_NAME "torturetest"
+#define TEST_MACHINE_DNS_SUFFIX "torturedomain"
 
 static bool test_LogonUasLogon(struct torture_context *tctx, 
                               struct dcerpc_pipe *p)
@@ -73,15 +75,15 @@ static bool test_LogonUasLogoff(struct torture_context *tctx,
        return true;
 }
 
-static bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context *tctx,
+bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context *tctx,
                                  struct cli_credentials *credentials,
-                                 struct creds_CredentialState **creds_out)
+                                 struct netlogon_creds_CredentialState **creds_out)
 {
        NTSTATUS status;
        struct netr_ServerReqChallenge r;
        struct netr_ServerAuthenticate a;
        struct netr_Credential credentials1, credentials2, credentials3;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
        const struct samr_Password *mach_password;
        const char *machine_name;
 
@@ -90,13 +92,10 @@ static bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context
 
        torture_comment(tctx, "Testing ServerReqChallenge\n");
 
-       creds = talloc(tctx, struct creds_CredentialState);
-       torture_assert(tctx, creds != NULL, "memory allocation");
-
        r.in.server_name = NULL;
        r.in.computer_name = machine_name;
        r.in.credentials = &credentials1;
-       r.out.credentials = &credentials2;
+       r.out.return_credentials = &credentials2;
 
        generate_random_buffer(credentials1.data, sizeof(credentials1.data));
 
@@ -105,14 +104,18 @@ static bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context
 
        a.in.server_name = NULL;
        a.in.account_name = talloc_asprintf(tctx, "%s$", machine_name);
-       a.in.secure_channel_type = SEC_CHAN_BDC;
+       a.in.secure_channel_type = cli_credentials_get_secure_channel_type(credentials);
        a.in.computer_name = machine_name;
        a.in.credentials = &credentials3;
-       a.out.credentials = &credentials3;
+       a.out.return_credentials = &credentials3;
+
+       creds = netlogon_creds_client_init(tctx, a.in.account_name,
+                                          a.in.computer_name,
+                                          &credentials1, &credentials2, 
+                                          mach_password, &credentials3, 
+                                          0);
+       torture_assert(tctx, creds != NULL, "memory allocation");
 
-       creds_client_init(creds, &credentials1, &credentials2, 
-                         mach_password, &credentials3, 
-                         0);
 
        torture_comment(tctx, "Testing ServerAuthenticate\n");
 
@@ -121,12 +124,14 @@ static bool test_SetupCredentials(struct dcerpc_pipe *p, struct torture_context
        /* This allows the tests to continue against the more fussy windows 2008 */
        if (NT_STATUS_EQUAL(status, NT_STATUS_DOWNGRADE_DETECTED)) {
                return test_SetupCredentials2(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS, 
-                                             credentials, SEC_CHAN_BDC, creds_out);
+                                             credentials,
+                                             cli_credentials_get_secure_channel_type(credentials),
+                                             creds_out);
        }
 
        torture_assert_ntstatus_ok(tctx, status, "ServerAuthenticate");
 
-       torture_assert(tctx, creds_client_check(creds, &credentials3), 
+       torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3), 
                       "Credential chaining failed");
 
        *creds_out = creds;
@@ -137,29 +142,26 @@ bool test_SetupCredentials2(struct dcerpc_pipe *p, struct torture_context *tctx,
                            uint32_t negotiate_flags,
                            struct cli_credentials *machine_credentials,
                            int sec_chan_type,
-                           struct creds_CredentialState **creds_out)
+                           struct netlogon_creds_CredentialState **creds_out)
 {
        NTSTATUS status;
        struct netr_ServerReqChallenge r;
        struct netr_ServerAuthenticate2 a;
        struct netr_Credential credentials1, credentials2, credentials3;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
        const struct samr_Password *mach_password;
        const char *machine_name;
-       const char *plain_pass;
 
        mach_password = cli_credentials_get_nt_hash(machine_credentials, tctx);
        machine_name = cli_credentials_get_workstation(machine_credentials);
 
        torture_comment(tctx, "Testing ServerReqChallenge\n");
 
-       creds = talloc(tctx, struct creds_CredentialState);
-       torture_assert(tctx, creds != NULL, "memory allocation");
 
        r.in.server_name = NULL;
        r.in.computer_name = machine_name;
        r.in.credentials = &credentials1;
-       r.out.credentials = &credentials2;
+       r.out.return_credentials = &credentials2;
 
        generate_random_buffer(credentials1.data, sizeof(credentials1.data));
 
@@ -173,18 +175,22 @@ bool test_SetupCredentials2(struct dcerpc_pipe *p, struct torture_context *tctx,
        a.in.negotiate_flags = &negotiate_flags;
        a.out.negotiate_flags = &negotiate_flags;
        a.in.credentials = &credentials3;
-       a.out.credentials = &credentials3;
+       a.out.return_credentials = &credentials3;
+
+       creds = netlogon_creds_client_init(tctx, a.in.account_name,
+                                          a.in.computer_name, 
+                                          &credentials1, &credentials2, 
+                                          mach_password, &credentials3, 
+                                          negotiate_flags);
 
-       creds_client_init(creds, &credentials1, &credentials2, 
-                         mach_password, &credentials3, 
-                         negotiate_flags);
+       torture_assert(tctx, creds != NULL, "memory allocation");
 
        torture_comment(tctx, "Testing ServerAuthenticate2\n");
 
        status = dcerpc_netr_ServerAuthenticate2(p, tctx, &a);
        torture_assert_ntstatus_ok(tctx, status, "ServerAuthenticate2");
 
-       torture_assert(tctx, creds_client_check(creds, &credentials3), 
+       torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3), 
                "Credential chaining failed");
 
        torture_comment(tctx, "negotiate_flags=0x%08x\n", negotiate_flags);
@@ -197,13 +203,13 @@ bool test_SetupCredentials2(struct dcerpc_pipe *p, struct torture_context *tctx,
 static bool test_SetupCredentials3(struct dcerpc_pipe *p, struct torture_context *tctx,
                            uint32_t negotiate_flags,
                            struct cli_credentials *machine_credentials,
-                           struct creds_CredentialState **creds_out)
+                           struct netlogon_creds_CredentialState **creds_out)
 {
        NTSTATUS status;
        struct netr_ServerReqChallenge r;
        struct netr_ServerAuthenticate3 a;
        struct netr_Credential credentials1, credentials2, credentials3;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
        struct samr_Password mach_password;
        uint32_t rid;
        const char *machine_name;
@@ -214,13 +220,10 @@ static bool test_SetupCredentials3(struct dcerpc_pipe *p, struct torture_context
 
        torture_comment(tctx, "Testing ServerReqChallenge\n");
 
-       creds = talloc(tctx, struct creds_CredentialState);
-       torture_assert(tctx, creds != NULL, "memory allocation");
-
        r.in.server_name = NULL;
        r.in.computer_name = machine_name;
        r.in.credentials = &credentials1;
-       r.out.credentials = &credentials2;
+       r.out.return_credentials = &credentials2;
 
        generate_random_buffer(credentials1.data, sizeof(credentials1.data));
 
@@ -231,23 +234,27 @@ static bool test_SetupCredentials3(struct dcerpc_pipe *p, struct torture_context
 
        a.in.server_name = NULL;
        a.in.account_name = talloc_asprintf(tctx, "%s$", machine_name);
-       a.in.secure_channel_type = SEC_CHAN_BDC;
+       a.in.secure_channel_type = cli_credentials_get_secure_channel_type(machine_credentials);
        a.in.computer_name = machine_name;
        a.in.negotiate_flags = &negotiate_flags;
        a.in.credentials = &credentials3;
-       a.out.credentials = &credentials3;
+       a.out.return_credentials = &credentials3;
        a.out.negotiate_flags = &negotiate_flags;
        a.out.rid = &rid;
 
-       creds_client_init(creds, &credentials1, &credentials2, 
-                         &mach_password, &credentials3,
-                         negotiate_flags);
+       creds = netlogon_creds_client_init(tctx, a.in.account_name,
+                                          a.in.computer_name,
+                                          &credentials1, &credentials2, 
+                                          &mach_password, &credentials3,
+                                          negotiate_flags);
+       
+       torture_assert(tctx, creds != NULL, "memory allocation");
 
        torture_comment(tctx, "Testing ServerAuthenticate3\n");
 
        status = dcerpc_netr_ServerAuthenticate3(p, tctx, &a);
        torture_assert_ntstatus_ok(tctx, status, "ServerAuthenticate3");
-       torture_assert(tctx, creds_client_check(creds, &credentials3), "Credential chaining failed");
+       torture_assert(tctx, netlogon_creds_client_check(creds, &credentials3), "Credential chaining failed");
 
        torture_comment(tctx, "negotiate_flags=0x%08x\n", negotiate_flags);
        
@@ -269,7 +276,9 @@ static bool test_SetPassword(struct torture_context *tctx,
        NTSTATUS status;
        struct netr_ServerPasswordSet r;
        const char *password;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
+       struct netr_Authenticator credential, return_authenticator;
+       struct samr_Password new_password;
 
        if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
                return false;
@@ -277,24 +286,27 @@ static bool test_SetPassword(struct torture_context *tctx,
 
        r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.account_name = talloc_asprintf(tctx, "%s$", TEST_MACHINE_NAME);
-       r.in.secure_channel_type = SEC_CHAN_BDC;
+       r.in.secure_channel_type = cli_credentials_get_secure_channel_type(machine_credentials);
        r.in.computer_name = TEST_MACHINE_NAME;
+       r.in.credential = &credential;
+       r.in.new_password = &new_password;
+       r.out.return_authenticator = &return_authenticator;
 
        password = generate_random_str(tctx, 8);
-       E_md4hash(password, r.in.new_password.hash);
+       E_md4hash(password, new_password.hash);
 
-       creds_des_encrypt(creds, &r.in.new_password);
+       netlogon_creds_des_encrypt(creds, &new_password);
 
        torture_comment(tctx, "Testing ServerPasswordSet on machine account\n");
        torture_comment(tctx, "Changing machine account password to '%s'\n", 
                        password);
 
-       creds_client_authenticator(creds, &r.in.credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        status = dcerpc_netr_ServerPasswordSet(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet");
 
-       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                torture_comment(tctx, "Credential chaining failed\n");
        }
 
@@ -307,12 +319,12 @@ static bool test_SetPassword(struct torture_context *tctx,
        torture_comment(tctx, 
                "Changing machine account password to '%s' (same as previous run)\n", password);
 
-       creds_client_authenticator(creds, &r.in.credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        status = dcerpc_netr_ServerPasswordSet(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet (2)");
 
-       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                torture_comment(tctx, "Credential chaining failed\n");
        }
 
@@ -325,6 +337,82 @@ static bool test_SetPassword(struct torture_context *tctx,
        return true;
 }
 
+/*
+  try a change password for our machine account
+*/
+static bool test_SetPassword_flags(struct torture_context *tctx,
+                                  struct dcerpc_pipe *p,
+                                  struct cli_credentials *machine_credentials,
+                                  uint32_t negotiate_flags)
+{
+       NTSTATUS status;
+       struct netr_ServerPasswordSet r;
+       const char *password;
+       struct netlogon_creds_CredentialState *creds;
+       struct netr_Authenticator credential, return_authenticator;
+       struct samr_Password new_password;
+
+       if (!test_SetupCredentials2(p, tctx, negotiate_flags,
+                                   machine_credentials,
+                                   cli_credentials_get_secure_channel_type(machine_credentials),
+                                   &creds)) {
+               return false;
+       }
+
+       r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
+       r.in.account_name = talloc_asprintf(tctx, "%s$", TEST_MACHINE_NAME);
+       r.in.secure_channel_type = cli_credentials_get_secure_channel_type(machine_credentials);
+       r.in.computer_name = TEST_MACHINE_NAME;
+       r.in.credential = &credential;
+       r.in.new_password = &new_password;
+       r.out.return_authenticator = &return_authenticator;
+
+       password = generate_random_str(tctx, 8);
+       E_md4hash(password, new_password.hash);
+
+       netlogon_creds_des_encrypt(creds, &new_password);
+
+       torture_comment(tctx, "Testing ServerPasswordSet on machine account\n");
+       torture_comment(tctx, "Changing machine account password to '%s'\n",
+                       password);
+
+       netlogon_creds_client_authenticator(creds, &credential);
+
+       status = dcerpc_netr_ServerPasswordSet(p, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet");
+
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
+               torture_comment(tctx, "Credential chaining failed\n");
+       }
+
+       /* by changing the machine password twice we test the
+          credentials chaining fully, and we verify that the server
+          allows the password to be set to the same value twice in a
+          row (match win2k3) */
+       torture_comment(tctx,
+               "Testing a second ServerPasswordSet on machine account\n");
+       torture_comment(tctx,
+               "Changing machine account password to '%s' (same as previous run)\n", password);
+
+       netlogon_creds_client_authenticator(creds, &credential);
+
+       status = dcerpc_netr_ServerPasswordSet(p, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet (2)");
+
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
+               torture_comment(tctx, "Credential chaining failed\n");
+       }
+
+       cli_credentials_set_password(machine_credentials, password, CRED_SPECIFIED);
+
+       torture_assert(tctx,
+               test_SetupCredentials(p, tctx, machine_credentials, &creds),
+               "ServerPasswordSet failed to actually change the password");
+
+       return true;
+}
+
+
 /*
   generate a random password for password change tests
 */
@@ -354,9 +442,11 @@ static bool test_SetPassword2(struct torture_context *tctx,
        struct netr_ServerPasswordSet2 r;
        const char *password;
        DATA_BLOB new_random_pass;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
        struct samr_CryptPassword password_buf;
        struct samr_Password nt_hash;
+       struct netr_Authenticator credential, return_authenticator;
+       struct netr_CryptPassword new_password;
 
        if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
                return false;
@@ -364,25 +454,28 @@ static bool test_SetPassword2(struct torture_context *tctx,
 
        r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.account_name = talloc_asprintf(tctx, "%s$", TEST_MACHINE_NAME);
-       r.in.secure_channel_type = SEC_CHAN_BDC;
+       r.in.secure_channel_type = cli_credentials_get_secure_channel_type(machine_credentials);
        r.in.computer_name = TEST_MACHINE_NAME;
+       r.in.credential = &credential;
+       r.in.new_password = &new_password;
+       r.out.return_authenticator = &return_authenticator;
 
        password = generate_random_str(tctx, 8);
        encode_pw_buffer(password_buf.data, password, STR_UNICODE);
-       creds_arcfour_crypt(creds, password_buf.data, 516);
+       netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
 
-       memcpy(r.in.new_password.data, password_buf.data, 512);
-       r.in.new_password.length = IVAL(password_buf.data, 512);
+       memcpy(new_password.data, password_buf.data, 512);
+       new_password.length = IVAL(password_buf.data, 512);
 
        torture_comment(tctx, "Testing ServerPasswordSet2 on machine account\n");
        torture_comment(tctx, "Changing machine account password to '%s'\n", password);
 
-       creds_client_authenticator(creds, &r.in.credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        status = dcerpc_netr_ServerPasswordSet2(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet2");
 
-       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                torture_comment(tctx, "Credential chaining failed\n");
        }
 
@@ -399,22 +492,22 @@ static bool test_SetPassword2(struct torture_context *tctx,
                 */
                password = "";
                encode_pw_buffer(password_buf.data, password, STR_UNICODE);
-               creds_arcfour_crypt(creds, password_buf.data, 516);
+               netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
                
-               memcpy(r.in.new_password.data, password_buf.data, 512);
-               r.in.new_password.length = IVAL(password_buf.data, 512);
+               memcpy(new_password.data, password_buf.data, 512);
+               new_password.length = IVAL(password_buf.data, 512);
                
                torture_comment(tctx, 
                        "Testing ServerPasswordSet2 on machine account\n");
                torture_comment(tctx, 
                        "Changing machine account password to '%s'\n", password);
                
-               creds_client_authenticator(creds, &r.in.credential);
+               netlogon_creds_client_authenticator(creds, &credential);
                
                status = dcerpc_netr_ServerPasswordSet2(p, tctx, &r);
                torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet2");
                
-               if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+               if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                        torture_comment(tctx, "Credential chaining failed\n");
                }
                
@@ -427,20 +520,20 @@ static bool test_SetPassword2(struct torture_context *tctx,
        /* now try a random password */
        password = generate_random_str(tctx, 8);
        encode_pw_buffer(password_buf.data, password, STR_UNICODE);
-       creds_arcfour_crypt(creds, password_buf.data, 516);
+       netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
 
-       memcpy(r.in.new_password.data, password_buf.data, 512);
-       r.in.new_password.length = IVAL(password_buf.data, 512);
+       memcpy(new_password.data, password_buf.data, 512);
+       new_password.length = IVAL(password_buf.data, 512);
 
        torture_comment(tctx, "Testing second ServerPasswordSet2 on machine account\n");
        torture_comment(tctx, "Changing machine account password to '%s'\n", password);
 
-       creds_client_authenticator(creds, &r.in.credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        status = dcerpc_netr_ServerPasswordSet2(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet2 (2)");
 
-       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                torture_comment(tctx, "Credential chaining failed\n");
        }
 
@@ -453,12 +546,12 @@ static bool test_SetPassword2(struct torture_context *tctx,
        torture_comment(tctx, 
                "Changing machine account password to '%s' (same as previous run)\n", password);
 
-       creds_client_authenticator(creds, &r.in.credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        status = dcerpc_netr_ServerPasswordSet2(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet (3)");
 
-       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                torture_comment(tctx, "Credential chaining failed\n");
        }
 
@@ -473,20 +566,20 @@ static bool test_SetPassword2(struct torture_context *tctx,
        /* now try a random stream of bytes for a password */
        set_pw_in_buffer(password_buf.data, &new_random_pass);
 
-       creds_arcfour_crypt(creds, password_buf.data, 516);
+       netlogon_creds_arcfour_crypt(creds, password_buf.data, 516);
 
-       memcpy(r.in.new_password.data, password_buf.data, 512);
-       r.in.new_password.length = IVAL(password_buf.data, 512);
+       memcpy(new_password.data, password_buf.data, 512);
+       new_password.length = IVAL(password_buf.data, 512);
 
        torture_comment(tctx, 
                "Testing a third ServerPasswordSet2 on machine account, with a compleatly random password\n");
 
-       creds_client_authenticator(creds, &r.in.credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        status = dcerpc_netr_ServerPasswordSet2(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "ServerPasswordSet (3)");
 
-       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                torture_comment(tctx, "Credential chaining failed\n");
        }
 
@@ -507,7 +600,7 @@ static bool test_GetPassword(struct torture_context *tctx,
                             struct cli_credentials *machine_credentials)
 {
        struct netr_ServerPasswordGet r;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
        struct netr_Authenticator credential;
        NTSTATUS status;
        struct netr_Authenticator return_authenticator;
@@ -517,11 +610,11 @@ static bool test_GetPassword(struct torture_context *tctx,
                return false;
        }
 
-       creds_client_authenticator(creds, &credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.account_name = talloc_asprintf(tctx, "%s$", TEST_MACHINE_NAME);
-       r.in.secure_channel_type = SEC_CHAN_BDC;
+       r.in.secure_channel_type = cli_credentials_get_secure_channel_type(machine_credentials);
        r.in.computer_name = TEST_MACHINE_NAME;
        r.in.credential = &credential;
        r.out.return_authenticator = &return_authenticator;
@@ -538,7 +631,7 @@ static bool test_GetTrustPasswords(struct torture_context *tctx,
                                   struct cli_credentials *machine_credentials)
 {
        struct netr_ServerTrustPasswordsGet r;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
        struct netr_Authenticator credential;
        NTSTATUS status;
        struct netr_Authenticator return_authenticator;
@@ -548,11 +641,11 @@ static bool test_GetTrustPasswords(struct torture_context *tctx,
                return false;
        }
 
-       creds_client_authenticator(creds, &credential);
+       netlogon_creds_client_authenticator(creds, &credential);
 
        r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.account_name = talloc_asprintf(tctx, "%s$", TEST_MACHINE_NAME);
-       r.in.secure_channel_type = SEC_CHAN_BDC;
+       r.in.secure_channel_type = cli_credentials_get_secure_channel_type(machine_credentials);
        r.in.computer_name = TEST_MACHINE_NAME;
        r.in.credential = &credential;
        r.out.return_authenticator = &return_authenticator;
@@ -570,11 +663,14 @@ static bool test_GetTrustPasswords(struct torture_context *tctx,
 */
 bool test_netlogon_ops(struct dcerpc_pipe *p, struct torture_context *tctx,
                              struct cli_credentials *credentials, 
-                             struct creds_CredentialState *creds)
+                             struct netlogon_creds_CredentialState *creds)
 {
        NTSTATUS status;
        struct netr_LogonSamLogon r;
        struct netr_Authenticator auth, auth2;
+       union netr_LogonLevel logon;
+       union netr_Validation validation;
+       uint8_t authoritative;
        struct netr_NetworkInfo ninfo;
        DATA_BLOB names_blob, chal, lm_resp, nt_resp;
        int i;
@@ -618,25 +714,30 @@ bool test_netlogon_ops(struct dcerpc_pipe *p, struct torture_context *tctx,
        ninfo.identity_info.logon_id_high = 0;
        ninfo.identity_info.workstation.string = cli_credentials_get_workstation(credentials);
 
+       logon.network = &ninfo;
+
        r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.computer_name = cli_credentials_get_workstation(credentials);
        r.in.credential = &auth;
        r.in.return_authenticator = &auth2;
        r.in.logon_level = 2;
-       r.in.logon.network = &ninfo;
+       r.in.logon = &logon;
+       r.out.validation = &validation;
+       r.out.authoritative = &authoritative;
 
        d_printf("Testing LogonSamLogon with name %s\n", ninfo.identity_info.account_name.string);
        
        for (i=2;i<3;i++) {
                ZERO_STRUCT(auth2);
-               creds_client_authenticator(creds, &auth);
+               netlogon_creds_client_authenticator(creds, &auth);
                
                r.in.validation_level = i;
                
                status = dcerpc_netr_LogonSamLogon(p, tctx, &r);
                torture_assert_ntstatus_ok(tctx, status, "LogonSamLogon failed");
                
-               torture_assert(tctx, creds_client_check(creds, &r.out.return_authenticator->cred), 
+               torture_assert(tctx, netlogon_creds_client_check(creds, 
+                                                                &r.out.return_authenticator->cred), 
                        "Credential chaining failed");
        }
 
@@ -664,7 +765,7 @@ static bool test_SamLogon(struct torture_context *tctx,
                          struct dcerpc_pipe *p,
                          struct cli_credentials *credentials)
 {
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
 
        if (!test_SetupCredentials(p, tctx, credentials, &creds)) {
                return false;
@@ -685,27 +786,39 @@ static bool test_DatabaseSync(struct torture_context *tctx,
 {
        NTSTATUS status;
        struct netr_DatabaseSync r;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
        const uint32_t database_ids[] = {SAM_DATABASE_DOMAIN, SAM_DATABASE_BUILTIN, SAM_DATABASE_PRIVS}; 
        int i;
+       struct netr_DELTA_ENUM_ARRAY *delta_enum_array = NULL;
+       struct netr_Authenticator credential, return_authenticator;
 
        if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
                return false;
        }
 
+       ZERO_STRUCT(return_authenticator);
+
        r.in.logon_server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.computername = TEST_MACHINE_NAME;
        r.in.preferredmaximumlength = (uint32_t)-1;
-       ZERO_STRUCT(r.in.return_authenticator);
+       r.in.return_authenticator = &return_authenticator;
+       r.out.delta_enum_array = &delta_enum_array;
+       r.out.return_authenticator = &return_authenticator;
 
        for (i=0;i<ARRAY_SIZE(database_ids);i++) {
-               r.in.sync_context = 0;
+
+               uint32_t sync_context = 0;
+
                r.in.database_id = database_ids[i];
+               r.in.sync_context = &sync_context;
+               r.out.sync_context = &sync_context;
 
                torture_comment(tctx, "Testing DatabaseSync of id %d\n", r.in.database_id);
 
                do {
-                       creds_client_authenticator(creds, &r.in.credential);
+                       netlogon_creds_client_authenticator(creds, &credential);
+
+                       r.in.credential = &credential;
 
                        status = dcerpc_netr_DatabaseSync(p, tctx, &r);
                        if (NT_STATUS_EQUAL(status, STATUS_MORE_ENTRIES))
@@ -717,18 +830,16 @@ static bool test_DatabaseSync(struct torture_context *tctx,
                        }
                        torture_assert_ntstatus_ok(tctx, status, "DatabaseSync");
 
-                       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+                       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                                torture_comment(tctx, "Credential chaining failed\n");
                        }
 
-                       r.in.sync_context = r.out.sync_context;
-
-                       if (r.out.delta_enum_array &&
-                           r.out.delta_enum_array->num_deltas > 0 &&
-                           r.out.delta_enum_array->delta_enum[0].delta_type == NETR_DELTA_DOMAIN &&
-                           r.out.delta_enum_array->delta_enum[0].delta_union.domain) {
+                       if (delta_enum_array &&
+                           delta_enum_array->num_deltas > 0 &&
+                           delta_enum_array->delta_enum[0].delta_type == NETR_DELTA_DOMAIN &&
+                           delta_enum_array->delta_enum[0].delta_union.domain) {
                                sequence_nums[r.in.database_id] = 
-                                       r.out.delta_enum_array->delta_enum[0].delta_union.domain->sequence_num;
+                                       delta_enum_array->delta_enum[0].delta_union.domain->sequence_num;
                                torture_comment(tctx, "\tsequence_nums[%d]=%llu\n",
                                       r.in.database_id, 
                                       (unsigned long long)sequence_nums[r.in.database_id]);
@@ -749,7 +860,10 @@ static bool test_DatabaseDeltas(struct torture_context *tctx,
 {
        NTSTATUS status;
        struct netr_DatabaseDeltas r;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
+       struct netr_Authenticator credential;
+       struct netr_Authenticator return_authenticator;
+       struct netr_DELTA_ENUM_ARRAY *delta_enum_array = NULL;
        const uint32_t database_ids[] = {0, 1, 2}; 
        int i;
 
@@ -761,20 +875,22 @@ static bool test_DatabaseDeltas(struct torture_context *tctx,
        r.in.computername = TEST_MACHINE_NAME;
        r.in.preferredmaximumlength = (uint32_t)-1;
        ZERO_STRUCT(r.in.return_authenticator);
+       r.out.return_authenticator = &return_authenticator;
+       r.out.delta_enum_array = &delta_enum_array;
 
        for (i=0;i<ARRAY_SIZE(database_ids);i++) {
                r.in.database_id = database_ids[i];
-               r.in.sequence_num = sequence_nums[r.in.database_id];
+               r.in.sequence_num = &sequence_nums[r.in.database_id];
 
-               if (r.in.sequence_num == 0) continue;
+               if (*r.in.sequence_num == 0) continue;
 
-               r.in.sequence_num -= 1;
+               *r.in.sequence_num -= 1;
 
                torture_comment(tctx, "Testing DatabaseDeltas of id %d at %llu\n", 
-                      r.in.database_id, (unsigned long long)r.in.sequence_num);
+                      r.in.database_id, (unsigned long long)*r.in.sequence_num);
 
                do {
-                       creds_client_authenticator(creds, &r.in.credential);
+                       netlogon_creds_client_authenticator(creds, &credential);
 
                        status = dcerpc_netr_DatabaseDeltas(p, tctx, &r);
                        if (NT_STATUS_EQUAL(status, 
@@ -788,17 +904,549 @@ static bool test_DatabaseDeltas(struct torture_context *tctx,
 
                        torture_assert_ntstatus_ok(tctx, status, "DatabaseDeltas");
 
-                       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+                       if (!netlogon_creds_client_check(creds, &return_authenticator.cred)) {
                                torture_comment(tctx, "Credential chaining failed\n");
                        }
 
-                       r.in.sequence_num++;
+                       (*r.in.sequence_num)++;
                } while (NT_STATUS_EQUAL(status, STATUS_MORE_ENTRIES));
        }
 
        return true;
 }
 
+static bool test_DatabaseRedo(struct torture_context *tctx,
+                             struct dcerpc_pipe *p,
+                             struct cli_credentials *machine_credentials)
+{
+       NTSTATUS status;
+       struct netr_DatabaseRedo r;
+       struct netlogon_creds_CredentialState *creds;
+       struct netr_Authenticator credential;
+       struct netr_Authenticator return_authenticator;
+       struct netr_DELTA_ENUM_ARRAY *delta_enum_array = NULL;
+       struct netr_ChangeLogEntry e;
+       struct dom_sid null_sid, *sid;
+       int i,d;
+
+       ZERO_STRUCT(null_sid);
+
+       sid = dom_sid_parse_talloc(tctx, "S-1-5-21-1111111111-2222222222-333333333-500");
+
+       {
+
+       struct {
+               uint32_t rid;
+               uint16_t flags;
+               uint8_t db_index;
+               uint8_t delta_type;
+               struct dom_sid sid;
+               const char *name;
+               NTSTATUS expected_error;
+               uint32_t expected_num_results;
+               uint8_t expected_delta_type_1;
+               uint8_t expected_delta_type_2;
+               const char *comment;
+       } changes[] = {
+
+               /* SAM_DATABASE_DOMAIN */
+
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_MODIFY_COUNT,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_SYNCHRONIZATION_REQUIRED,
+                       .expected_num_results   = 0,
+                       .comment                = "NETR_DELTA_MODIFY_COUNT"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = 0,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DOMAIN,
+                       .comment                = "NULL DELTA"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_DOMAIN,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DOMAIN,
+                       .comment                = "NETR_DELTA_DOMAIN"
+               },
+               {
+                       .rid                    = DOMAIN_RID_ADMINISTRATOR,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_USER,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_USER,
+                       .comment                = "NETR_DELTA_USER by rid 500"
+               },
+               {
+                       .rid                    = DOMAIN_RID_GUEST,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_USER,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_USER,
+                       .comment                = "NETR_DELTA_USER by rid 501"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_USER,
+                       .sid                    = *sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_USER,
+                       .comment                = "NETR_DELTA_USER by sid and flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_USER,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_USER,
+                       .comment                = "NETR_DELTA_USER by null_sid and flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_NAME_INCLUDED,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_USER,
+                       .sid                    = null_sid,
+                       .name                   = "administrator",
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_USER,
+                       .comment                = "NETR_DELTA_USER by name 'administrator'"
+               },
+               {
+                       .rid                    = DOMAIN_RID_ADMINS,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_GROUP,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 2,
+                       .expected_delta_type_1  = NETR_DELTA_GROUP,
+                       .expected_delta_type_2  = NETR_DELTA_GROUP_MEMBER,
+                       .comment                = "NETR_DELTA_GROUP by rid 512"
+               },
+               {
+                       .rid                    = DOMAIN_RID_ADMINS,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_DOMAIN,
+                       .delta_type             = NETR_DELTA_GROUP_MEMBER,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 2,
+                       .expected_delta_type_1  = NETR_DELTA_GROUP,
+                       .expected_delta_type_2  = NETR_DELTA_GROUP_MEMBER,
+                       .comment                = "NETR_DELTA_GROUP_MEMBER by rid 512"
+               },
+
+
+               /* SAM_DATABASE_BUILTIN */
+
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_MODIFY_COUNT,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_SYNCHRONIZATION_REQUIRED,
+                       .expected_num_results   = 0,
+                       .comment                = "NETR_DELTA_MODIFY_COUNT"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_DOMAIN,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DOMAIN,
+                       .comment                = "NETR_DELTA_DOMAIN"
+               },
+               {
+                       .rid                    = DOMAIN_RID_ADMINISTRATOR,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_USER,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_USER,
+                       .comment                = "NETR_DELTA_USER by rid 500"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_USER,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_USER,
+                       .comment                = "NETR_DELTA_USER"
+               },
+               {
+                       .rid                    = 544,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_ALIAS,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 2,
+                       .expected_delta_type_1  = NETR_DELTA_ALIAS,
+                       .expected_delta_type_2  = NETR_DELTA_ALIAS_MEMBER,
+                       .comment                = "NETR_DELTA_ALIAS by rid 544"
+               },
+               {
+                       .rid                    = 544,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_ALIAS_MEMBER,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 2,
+                       .expected_delta_type_1  = NETR_DELTA_ALIAS,
+                       .expected_delta_type_2  = NETR_DELTA_ALIAS_MEMBER,
+                       .comment                = "NETR_DELTA_ALIAS_MEMBER by rid 544"
+               },
+               {
+                       .rid                    = 544,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = 0,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DOMAIN,
+                       .comment                = "NULL DELTA by rid 544"
+               },
+               {
+                       .rid                    = 544,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = 0,
+                       .sid                    = *dom_sid_parse_talloc(tctx, "S-1-5-32-544"),
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DOMAIN,
+                       .comment                = "NULL DELTA by rid 544 sid S-1-5-32-544 and flags"
+               },
+               {
+                       .rid                    = 544,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_ALIAS,
+                       .sid                    = *dom_sid_parse_talloc(tctx, "S-1-5-32-544"),
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 2,
+                       .expected_delta_type_1  = NETR_DELTA_ALIAS,
+                       .expected_delta_type_2  = NETR_DELTA_ALIAS_MEMBER,
+                       .comment                = "NETR_DELTA_ALIAS by rid 544 and sid S-1-5-32-544 and flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_BUILTIN,
+                       .delta_type             = NETR_DELTA_ALIAS,
+                       .sid                    = *dom_sid_parse_talloc(tctx, "S-1-5-32-544"),
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_ALIAS,
+                       .comment                = "NETR_DELTA_ALIAS by sid S-1-5-32-544 and flags"
+               },
+
+               /* SAM_DATABASE_PRIVS */
+
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = 0,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_ACCESS_DENIED,
+                       .expected_num_results   = 0,
+                       .comment                = "NULL DELTA"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_MODIFY_COUNT,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_SYNCHRONIZATION_REQUIRED,
+                       .expected_num_results   = 0,
+                       .comment                = "NETR_DELTA_MODIFY_COUNT"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_POLICY,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_POLICY,
+                       .comment                = "NETR_DELTA_POLICY"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_POLICY,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_POLICY,
+                       .comment                = "NETR_DELTA_POLICY by null sid and flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_POLICY,
+                       .sid                    = *dom_sid_parse_talloc(tctx, "S-1-5-32"),
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_POLICY,
+                       .comment                = "NETR_DELTA_POLICY by sid S-1-5-32 and flags"
+               },
+               {
+                       .rid                    = DOMAIN_RID_ADMINISTRATOR,
+                       .flags                  = 0,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_ACCOUNT,
+                       .sid                    = null_sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_SYNCHRONIZATION_REQUIRED, /* strange */
+                       .expected_num_results   = 0,
+                       .comment                = "NETR_DELTA_ACCOUNT by rid 500"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_ACCOUNT,
+                       .sid                    = *dom_sid_parse_talloc(tctx, "S-1-1-0"),
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_ACCOUNT,
+                       .comment                = "NETR_DELTA_ACCOUNT by sid S-1-1-0 and flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED |
+                                                 NETR_CHANGELOG_IMMEDIATE_REPL_REQUIRED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_ACCOUNT,
+                       .sid                    = *dom_sid_parse_talloc(tctx, "S-1-1-0"),
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_ACCOUNT,
+                       .comment                = "NETR_DELTA_ACCOUNT by sid S-1-1-0 and 2 flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED |
+                                                 NETR_CHANGELOG_NAME_INCLUDED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_ACCOUNT,
+                       .sid                    = *dom_sid_parse_talloc(tctx, "S-1-1-0"),
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_INVALID_PARAMETER,
+                       .expected_num_results   = 0,
+                       .comment                = "NETR_DELTA_ACCOUNT by sid S-1-1-0 and invalid flags"
+               },
+               {
+                       .rid                    = DOMAIN_RID_ADMINISTRATOR,
+                       .flags                  = NETR_CHANGELOG_SID_INCLUDED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_ACCOUNT,
+                       .sid                    = *sid,
+                       .name                   = NULL,
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_ACCOUNT,
+                       .comment                = "NETR_DELTA_ACCOUNT by rid 500, sid and flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_NAME_INCLUDED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_SECRET,
+                       .sid                    = null_sid,
+                       .name                   = "IsurelydontexistIhope",
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_DELETE_SECRET,
+                       .comment                = "NETR_DELTA_SECRET by name 'IsurelydontexistIhope' and flags"
+               },
+               {
+                       .rid                    = 0,
+                       .flags                  = NETR_CHANGELOG_NAME_INCLUDED,
+                       .db_index               = SAM_DATABASE_PRIVS,
+                       .delta_type             = NETR_DELTA_SECRET,
+                       .sid                    = null_sid,
+                       .name                   = "G$BCKUPKEY_P",
+                       .expected_error         = NT_STATUS_OK,
+                       .expected_num_results   = 1,
+                       .expected_delta_type_1  = NETR_DELTA_SECRET,
+                       .comment                = "NETR_DELTA_SECRET by name 'G$BCKUPKEY_P' and flags"
+               }
+       };
+
+       ZERO_STRUCT(return_authenticator);
+
+       r.in.logon_server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
+       r.in.computername = TEST_MACHINE_NAME;
+       r.in.return_authenticator = &return_authenticator;
+       r.out.return_authenticator = &return_authenticator;
+       r.out.delta_enum_array = &delta_enum_array;
+
+       for (d=0; d<3; d++) {
+
+               const char *database;
+
+               switch (d) {
+               case 0:
+                       database = "SAM";
+                       break;
+               case 1:
+                       database = "BUILTIN";
+                       break;
+               case 2:
+                       database = "LSA";
+                       break;
+               default:
+                       break;
+               }
+
+               torture_comment(tctx, "Testing DatabaseRedo\n");
+
+               if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
+                       return false;
+               }
+
+               for (i=0;i<ARRAY_SIZE(changes);i++) {
+
+                       if (d != changes[i].db_index) {
+                               continue;
+                       }
+
+                       netlogon_creds_client_authenticator(creds, &credential);
+
+                       r.in.credential = &credential;
+
+                       e.serial_number1        = 0;
+                       e.serial_number2        = 0;
+                       e.object_rid            = changes[i].rid;
+                       e.flags                 = changes[i].flags;
+                       e.db_index              = changes[i].db_index;
+                       e.delta_type            = changes[i].delta_type;
+
+                       switch (changes[i].flags & (NETR_CHANGELOG_NAME_INCLUDED | NETR_CHANGELOG_SID_INCLUDED)) {
+                       case NETR_CHANGELOG_SID_INCLUDED:
+                               e.object.object_sid             = changes[i].sid;
+                               break;
+                       case NETR_CHANGELOG_NAME_INCLUDED:
+                               e.object.object_name            = changes[i].name;
+                               break;
+                       default:
+                               break;
+                       }
+
+                       r.in.change_log_entry = e;
+
+                       torture_comment(tctx, "Testing DatabaseRedo with database %s and %s\n",
+                               database, changes[i].comment);
+
+                       status = dcerpc_netr_DatabaseRedo(p, tctx, &r);
+                       if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) {
+                               return true;
+                       }
+
+                       torture_assert_ntstatus_equal(tctx, status, changes[i].expected_error, changes[i].comment);
+                       if (delta_enum_array) {
+                               torture_assert_int_equal(tctx,
+                                       delta_enum_array->num_deltas,
+                                       changes[i].expected_num_results,
+                                       changes[i].comment);
+                               if (delta_enum_array->num_deltas > 0) {
+                                       torture_assert_int_equal(tctx,
+                                               delta_enum_array->delta_enum[0].delta_type,
+                                               changes[i].expected_delta_type_1,
+                                               changes[i].comment);
+                               }
+                               if (delta_enum_array->num_deltas > 1) {
+                                       torture_assert_int_equal(tctx,
+                                               delta_enum_array->delta_enum[1].delta_type,
+                                               changes[i].expected_delta_type_2,
+                                               changes[i].comment);
+                               }
+                       }
+
+                       if (!netlogon_creds_client_check(creds, &return_authenticator.cred)) {
+                               torture_comment(tctx, "Credential chaining failed\n");
+                               if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
+                                       return false;
+                               }
+                       }
+               }
+       }
+       }
+
+       return true;
+}
 
 /*
   try a netlogon AccountDeltas
@@ -809,20 +1457,33 @@ static bool test_AccountDeltas(struct torture_context *tctx,
 {
        NTSTATUS status;
        struct netr_AccountDeltas r;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
+
+       struct netr_AccountBuffer buffer;
+       uint32_t count_returned = 0;
+       uint32_t total_entries = 0;
+       struct netr_UAS_INFO_0 recordid;
+       struct netr_Authenticator return_authenticator;
 
        if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
                return false;
        }
 
+       ZERO_STRUCT(return_authenticator);
+
        r.in.logon_server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.computername = TEST_MACHINE_NAME;
-       ZERO_STRUCT(r.in.return_authenticator);
-       creds_client_authenticator(creds, &r.in.credential);
+       r.in.return_authenticator = &return_authenticator;
+       netlogon_creds_client_authenticator(creds, &r.in.credential);
        ZERO_STRUCT(r.in.uas);
        r.in.count=10;
        r.in.level=0;
        r.in.buffersize=100;
+       r.out.buffer = &buffer;
+       r.out.count_returned = &count_returned;
+       r.out.total_entries = &total_entries;
+       r.out.recordid = &recordid;
+       r.out.return_authenticator = &return_authenticator;
 
        /* w2k3 returns "NOT IMPLEMENTED" for this call */
        status = dcerpc_netr_AccountDeltas(p, tctx, &r);
@@ -839,7 +1500,17 @@ static bool test_AccountSync(struct torture_context *tctx, struct dcerpc_pipe *p
 {
        NTSTATUS status;
        struct netr_AccountSync r;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
+
+       struct netr_AccountBuffer buffer;
+       uint32_t count_returned = 0;
+       uint32_t total_entries = 0;
+       uint32_t next_reference = 0;
+       struct netr_UAS_INFO_0 recordid;
+       struct netr_Authenticator return_authenticator;
+
+       ZERO_STRUCT(recordid);
+       ZERO_STRUCT(return_authenticator);
 
        if (!test_SetupCredentials(p, tctx, machine_credentials, &creds)) {
                return false;
@@ -847,12 +1518,18 @@ static bool test_AccountSync(struct torture_context *tctx, struct dcerpc_pipe *p
 
        r.in.logon_server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.computername = TEST_MACHINE_NAME;
-       ZERO_STRUCT(r.in.return_authenticator);
-       creds_client_authenticator(creds, &r.in.credential);
-       ZERO_STRUCT(r.in.recordid);
+       r.in.return_authenticator = &return_authenticator;
+       netlogon_creds_client_authenticator(creds, &r.in.credential);
+       r.in.recordid = &recordid;
        r.in.reference=0;
        r.in.level=0;
        r.in.buffersize=100;
+       r.out.buffer = &buffer;
+       r.out.count_returned = &count_returned;
+       r.out.total_entries = &total_entries;
+       r.out.next_reference = &next_reference;
+       r.out.recordid = &recordid;
+       r.out.return_authenticator = &return_authenticator;
 
        /* w2k3 returns "NOT IMPLEMENTED" for this call */
        status = dcerpc_netr_AccountSync(p, tctx, &r);
@@ -884,28 +1561,161 @@ static bool test_GetDcName(struct torture_context *tctx,
        return true;
 }
 
+static const char *function_code_str(TALLOC_CTX *mem_ctx,
+                                    enum netr_LogonControlCode function_code)
+{
+       switch (function_code) {
+       case NETLOGON_CONTROL_QUERY:
+               return "NETLOGON_CONTROL_QUERY";
+       case NETLOGON_CONTROL_REPLICATE:
+               return "NETLOGON_CONTROL_REPLICATE";
+       case NETLOGON_CONTROL_SYNCHRONIZE:
+               return "NETLOGON_CONTROL_SYNCHRONIZE";
+       case NETLOGON_CONTROL_PDC_REPLICATE:
+               return "NETLOGON_CONTROL_PDC_REPLICATE";
+       case NETLOGON_CONTROL_REDISCOVER:
+               return "NETLOGON_CONTROL_REDISCOVER";
+       case NETLOGON_CONTROL_TC_QUERY:
+               return "NETLOGON_CONTROL_TC_QUERY";
+       case NETLOGON_CONTROL_TRANSPORT_NOTIFY:
+               return "NETLOGON_CONTROL_TRANSPORT_NOTIFY";
+       case NETLOGON_CONTROL_FIND_USER:
+               return "NETLOGON_CONTROL_FIND_USER";
+       case NETLOGON_CONTROL_CHANGE_PASSWORD:
+               return "NETLOGON_CONTROL_CHANGE_PASSWORD";
+       case NETLOGON_CONTROL_TC_VERIFY:
+               return "NETLOGON_CONTROL_TC_VERIFY";
+       case NETLOGON_CONTROL_FORCE_DNS_REG:
+               return "NETLOGON_CONTROL_FORCE_DNS_REG";
+       case NETLOGON_CONTROL_QUERY_DNS_REG:
+               return "NETLOGON_CONTROL_QUERY_DNS_REG";
+       case NETLOGON_CONTROL_BACKUP_CHANGE_LOG:
+               return "NETLOGON_CONTROL_BACKUP_CHANGE_LOG";
+       case NETLOGON_CONTROL_TRUNCATE_LOG:
+               return "NETLOGON_CONTROL_TRUNCATE_LOG";
+       case NETLOGON_CONTROL_SET_DBFLAG:
+               return "NETLOGON_CONTROL_SET_DBFLAG";
+       case NETLOGON_CONTROL_BREAKPOINT:
+               return "NETLOGON_CONTROL_BREAKPOINT";
+       default:
+               return talloc_asprintf(mem_ctx, "unknown function code: %d",
+                                      function_code);
+       }
+}
+
+
 /*
   try a netlogon LogonControl 
 */
 static bool test_LogonControl(struct torture_context *tctx, 
-                             struct dcerpc_pipe *p)
+                             struct dcerpc_pipe *p,
+                             struct cli_credentials *machine_credentials)
+
 {
        NTSTATUS status;
        struct netr_LogonControl r;
-       union netr_CONTROL_QUERY_INFORMATION info;
-       int i;
+       union netr_CONTROL_QUERY_INFORMATION query;
+       int i,f;
+       enum netr_SchannelType secure_channel_type = SEC_CHAN_NULL;
+
+       uint32_t function_codes[] = {
+               NETLOGON_CONTROL_QUERY,
+               NETLOGON_CONTROL_REPLICATE,
+               NETLOGON_CONTROL_SYNCHRONIZE,
+               NETLOGON_CONTROL_PDC_REPLICATE,
+               NETLOGON_CONTROL_REDISCOVER,
+               NETLOGON_CONTROL_TC_QUERY,
+               NETLOGON_CONTROL_TRANSPORT_NOTIFY,
+               NETLOGON_CONTROL_FIND_USER,
+               NETLOGON_CONTROL_CHANGE_PASSWORD,
+               NETLOGON_CONTROL_TC_VERIFY,
+               NETLOGON_CONTROL_FORCE_DNS_REG,
+               NETLOGON_CONTROL_QUERY_DNS_REG,
+               NETLOGON_CONTROL_BACKUP_CHANGE_LOG,
+               NETLOGON_CONTROL_TRUNCATE_LOG,
+               NETLOGON_CONTROL_SET_DBFLAG,
+               NETLOGON_CONTROL_BREAKPOINT
+       };
+
+       if (machine_credentials) {
+               secure_channel_type = cli_credentials_get_secure_channel_type(machine_credentials);
+       }
+
+       torture_comment(tctx, "testing LogonControl with secure channel type: %d\n",
+               secure_channel_type);
 
        r.in.logon_server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.function_code = 1;
-       r.out.info = &info;
+       r.out.query = &query;
 
-       for (i=1;i<4;i++) {
+       for (f=0;f<ARRAY_SIZE(function_codes); f++) {
+       for (i=1;i<5;i++) {
+
+               r.in.function_code = function_codes[f];
                r.in.level = i;
 
-               torture_comment(tctx, "Testing LogonControl level %d\n", i);
+               torture_comment(tctx, "Testing LogonControl function code %s (%d) level %d\n",
+                               function_code_str(tctx, r.in.function_code), r.in.function_code, r.in.level);
 
                status = dcerpc_netr_LogonControl(p, tctx, &r);
                torture_assert_ntstatus_ok(tctx, status, "LogonControl");
+
+               switch (r.in.level) {
+               case 1:
+                       switch (r.in.function_code) {
+                       case NETLOGON_CONTROL_REPLICATE:
+                       case NETLOGON_CONTROL_SYNCHRONIZE:
+                       case NETLOGON_CONTROL_PDC_REPLICATE:
+                       case NETLOGON_CONTROL_BREAKPOINT:
+                       case NETLOGON_CONTROL_BACKUP_CHANGE_LOG:
+                               if ((secure_channel_type == SEC_CHAN_BDC) ||
+                                   (secure_channel_type == SEC_CHAN_WKSTA)) {
+                                       torture_assert_werr_equal(tctx, r.out.result, WERR_ACCESS_DENIED,
+                                               "LogonControl returned unexpected error code");
+                               } else {
+                                       torture_assert_werr_equal(tctx, r.out.result, WERR_NOT_SUPPORTED,
+                                               "LogonControl returned unexpected error code");
+                               }
+                               break;
+
+                       case NETLOGON_CONTROL_REDISCOVER:
+                       case NETLOGON_CONTROL_TC_QUERY:
+                       case NETLOGON_CONTROL_TRANSPORT_NOTIFY:
+                       case NETLOGON_CONTROL_FIND_USER:
+                       case NETLOGON_CONTROL_CHANGE_PASSWORD:
+                       case NETLOGON_CONTROL_TC_VERIFY:
+                       case NETLOGON_CONTROL_FORCE_DNS_REG:
+                       case NETLOGON_CONTROL_QUERY_DNS_REG:
+                       case NETLOGON_CONTROL_SET_DBFLAG:
+                               torture_assert_werr_equal(tctx, r.out.result, WERR_NOT_SUPPORTED,
+                                       "LogonControl returned unexpected error code");
+                               break;
+                       case NETLOGON_CONTROL_TRUNCATE_LOG:
+                               if ((secure_channel_type == SEC_CHAN_BDC) ||
+                                   (secure_channel_type == SEC_CHAN_WKSTA)) {
+                                       torture_assert_werr_equal(tctx, r.out.result, WERR_ACCESS_DENIED,
+                                               "LogonControl returned unexpected error code");
+                               } else {
+                                       torture_assert_werr_ok(tctx, r.out.result,
+                                               "LogonControl returned unexpected result");
+                               }
+                               break;
+                       default:
+                               torture_assert_werr_ok(tctx, r.out.result,
+                                       "LogonControl returned unexpected result");
+                               break;
+                       }
+                       break;
+               case 2:
+                       torture_assert_werr_equal(tctx, r.out.result, WERR_NOT_SUPPORTED,
+                               "LogonControl returned unexpected error code");
+                       break;
+               default:
+                       torture_assert_werr_equal(tctx, r.out.result, WERR_UNKNOWN_LEVEL,
+                               "LogonControl returned unexpected error code");
+                       break;
+               }
+       }
        }
 
        return true;
@@ -928,6 +1738,7 @@ static bool test_GetAnyDCName(struct torture_context *tctx,
 
        status = dcerpc_netr_GetAnyDCName(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "GetAnyDCName");
+       torture_assert_werr_ok(tctx, r.out.result, "GetAnyDCName");
 
        if (dcname) {
            torture_comment(tctx, "\tDC is at '%s'\n", dcname);
@@ -941,7 +1752,9 @@ static bool test_GetAnyDCName(struct torture_context *tctx,
   try a netlogon LogonControl2
 */
 static bool test_LogonControl2(struct torture_context *tctx, 
-                              struct dcerpc_pipe *p)
+                              struct dcerpc_pipe *p,
+                              struct cli_credentials *machine_credentials)
+
 {
        NTSTATUS status;
        struct netr_LogonControl2 r;
@@ -1024,30 +1837,44 @@ static bool test_DatabaseSync2(struct torture_context *tctx,
 {
        NTSTATUS status;
        struct netr_DatabaseSync2 r;
-       struct creds_CredentialState *creds;
+       struct netr_DELTA_ENUM_ARRAY *delta_enum_array = NULL;
+       struct netr_Authenticator return_authenticator, credential;
+
+       struct netlogon_creds_CredentialState *creds;
        const uint32_t database_ids[] = {0, 1, 2}; 
        int i;
 
        if (!test_SetupCredentials2(p, tctx, NETLOGON_NEG_AUTH2_FLAGS, 
                                    machine_credentials,
-                                   SEC_CHAN_BDC, &creds)) {
+                                   cli_credentials_get_secure_channel_type(machine_credentials),
+                                   &creds)) {
                return false;
        }
 
+       ZERO_STRUCT(return_authenticator);
+
        r.in.logon_server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.computername = TEST_MACHINE_NAME;
        r.in.preferredmaximumlength = (uint32_t)-1;
-       ZERO_STRUCT(r.in.return_authenticator);
+       r.in.return_authenticator = &return_authenticator;
+       r.out.return_authenticator = &return_authenticator;
+       r.out.delta_enum_array = &delta_enum_array;
 
        for (i=0;i<ARRAY_SIZE(database_ids);i++) {
-               r.in.sync_context = 0;
+
+               uint32_t sync_context = 0;
+
                r.in.database_id = database_ids[i];
+               r.in.sync_context = &sync_context;
+               r.out.sync_context = &sync_context;
                r.in.restart_state = 0;
 
                torture_comment(tctx, "Testing DatabaseSync2 of id %d\n", r.in.database_id);
 
                do {
-                       creds_client_authenticator(creds, &r.in.credential);
+                       netlogon_creds_client_authenticator(creds, &credential);
+
+                       r.in.credential = &credential;
 
                        status = dcerpc_netr_DatabaseSync2(p, tctx, &r);
                        if (NT_STATUS_EQUAL(status, STATUS_MORE_ENTRIES))
@@ -1060,11 +1887,10 @@ static bool test_DatabaseSync2(struct torture_context *tctx,
 
                        torture_assert_ntstatus_ok(tctx, status, "DatabaseSync2");
 
-                       if (!creds_client_check(creds, &r.out.return_authenticator.cred)) {
+                       if (!netlogon_creds_client_check(creds, &r.out.return_authenticator->cred)) {
                                torture_comment(tctx, "Credential chaining failed\n");
                        }
 
-                       r.in.sync_context = r.out.sync_context;
                } while (NT_STATUS_EQUAL(status, STATUS_MORE_ENTRIES));
        }
 
@@ -1076,16 +1902,23 @@ static bool test_DatabaseSync2(struct torture_context *tctx,
   try a netlogon LogonControl2Ex
 */
 static bool test_LogonControl2Ex(struct torture_context *tctx, 
-                                struct dcerpc_pipe *p)
+                                struct dcerpc_pipe *p,
+                                struct cli_credentials *machine_credentials)
+
 {
        NTSTATUS status;
        struct netr_LogonControl2Ex r;
+       union netr_CONTROL_DATA_INFORMATION data;
+       union netr_CONTROL_QUERY_INFORMATION query;
        int i;
 
+       data.domain = lp_workgroup(tctx->lp_ctx);
+
        r.in.logon_server = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
 
        r.in.function_code = NETLOGON_CONTROL_REDISCOVER;
-       r.in.data.domain = lp_workgroup(tctx->lp_ctx);
+       r.in.data = &data;
+       r.out.query = &query;
 
        for (i=1;i<4;i++) {
                r.in.level = i;
@@ -1097,8 +1930,10 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
                torture_assert_ntstatus_ok(tctx, status, "LogonControl");
        }
 
+       data.domain = lp_workgroup(tctx->lp_ctx);
+
        r.in.function_code = NETLOGON_CONTROL_TC_QUERY;
-       r.in.data.domain = lp_workgroup(tctx->lp_ctx);
+       r.in.data = &data;
 
        for (i=1;i<4;i++) {
                r.in.level = i;
@@ -1110,8 +1945,10 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
                torture_assert_ntstatus_ok(tctx, status, "LogonControl");
        }
 
+       data.domain = lp_workgroup(tctx->lp_ctx);
+
        r.in.function_code = NETLOGON_CONTROL_TRANSPORT_NOTIFY;
-       r.in.data.domain = lp_workgroup(tctx->lp_ctx);
+       r.in.data = &data;
 
        for (i=1;i<4;i++) {
                r.in.level = i;
@@ -1123,8 +1960,10 @@ static bool test_LogonControl2Ex(struct torture_context *tctx,
                torture_assert_ntstatus_ok(tctx, status, "LogonControl");
        }
 
+       data.debug_level = ~0;
+
        r.in.function_code = NETLOGON_CONTROL_SET_DBFLAG;
-       r.in.data.debug_level = ~0;
+       r.in.data = &data;
 
        for (i=1;i<4;i++) {
                r.in.level = i;
@@ -1283,7 +2122,7 @@ static bool test_netr_DsRGetDCName(struct torture_context *tctx,
        struct netr_DsRGetDCNameInfo *info = NULL;
 
        r.in.server_unc         = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
-       r.in.domain_name        = talloc_asprintf(tctx, "%s", lp_realm(tctx->lp_ctx));
+       r.in.domain_name        = lp_dnsdomain(tctx->lp_ctx);
        r.in.domain_guid        = NULL;
        r.in.site_guid          = NULL;
        r.in.flags              = DS_RETURN_DNS_NAME;
@@ -1308,7 +2147,7 @@ static bool test_netr_DsRGetDCNameEx(struct torture_context *tctx,
        struct netr_DsRGetDCNameInfo *info = NULL;
 
        r.in.server_unc         = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
-       r.in.domain_name        = talloc_asprintf(tctx, "%s", lp_realm(tctx->lp_ctx));
+       r.in.domain_name        = lp_dnsdomain(tctx->lp_ctx);
        r.in.domain_guid        = NULL;
        r.in.site_name          = NULL;
        r.in.flags              = DS_RETURN_DNS_NAME;
@@ -1335,7 +2174,7 @@ static bool test_netr_DsRGetDCNameEx2(struct torture_context *tctx,
        r.in.server_unc         = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.client_account     = NULL;
        r.in.mask               = 0x00000000;
-       r.in.domain_name        = talloc_asprintf(tctx, "%s", lp_realm(tctx->lp_ctx));
+       r.in.domain_name        = lp_dnsdomain(tctx->lp_ctx);
        r.in.domain_guid        = NULL;
        r.in.site_name          = NULL;
        r.in.flags              = DS_RETURN_DNS_NAME;
@@ -1441,55 +2280,352 @@ static bool test_netr_DsRAddressToSitenamesExW(struct torture_context *tctx,
        return true;
 }
 
+static bool test_netr_ServerGetTrustInfo(struct torture_context *tctx,
+                                        struct dcerpc_pipe *p,
+                                        struct cli_credentials *machine_credentials)
+{
+       NTSTATUS status;
+       struct netr_ServerGetTrustInfo r;
+
+       struct netr_Authenticator a;
+       struct netr_Authenticator return_authenticator;
+       struct samr_Password new_owf_password;
+       struct samr_Password old_owf_password;
+       struct netr_TrustInfo *trust_info;
+
+       struct netlogon_creds_CredentialState *creds;
+
+       if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS,
+                                   machine_credentials, &creds)) {
+               return false;
+       }
+
+       netlogon_creds_client_authenticator(creds, &a);
+
+       r.in.server_name                = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
+       r.in.account_name               = talloc_asprintf(tctx, "%s$", TEST_MACHINE_NAME);
+       r.in.secure_channel_type        = cli_credentials_get_secure_channel_type(machine_credentials);
+       r.in.computer_name              = TEST_MACHINE_NAME;
+       r.in.credential                 = &a;
+
+       r.out.return_authenticator      = &return_authenticator;
+       r.out.new_owf_password          = &new_owf_password;
+       r.out.old_owf_password          = &old_owf_password;
+       r.out.trust_info                = &trust_info;
+
+       status = dcerpc_netr_ServerGetTrustInfo(p, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status, "failed");
+       torture_assert(tctx, netlogon_creds_client_check(creds, &return_authenticator.cred), "Credential chaining failed");
+
+       return true;
+}
+
+
 static bool test_GetDomainInfo(struct torture_context *tctx, 
                               struct dcerpc_pipe *p,
                               struct cli_credentials *machine_credentials)
 {
        NTSTATUS status;
        struct netr_LogonGetDomainInfo r;
-       struct netr_DomainQuery1 q1;
+       struct netr_WorkstationInformation q1;
        struct netr_Authenticator a;
-       struct creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds;
+       struct netr_OsVersion os;
+       union netr_WorkstationInfo query;
+       union netr_DomainInfo info;
+       const char* const attrs[] = { "dNSHostName", "operatingSystem",
+               "operatingSystemServicePack", "operatingSystemVersion",
+               "servicePrincipalName", NULL };
+       char *url;
+       struct ldb_context *sam_ctx = NULL;
+       struct ldb_message **res;
+       struct ldb_message_element *spn_el;
+       int ret, i;
+       char *version_str;
+       const char *old_dnsname = NULL;
+       char **spns = NULL;
+       int num_spns = 0;
+       char *temp_str;
+
+       torture_comment(tctx, "Testing netr_LogonGetDomainInfo\n");
 
        if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS, 
                                    machine_credentials, &creds)) {
                return false;
        }
 
-       ZERO_STRUCT(r);
+       /* We won't double-check this when we are over 'local' transports */
+       if (dcerpc_server_name(p)) {
+               /* Set up connection to SAMDB on DC */
+               url = talloc_asprintf(tctx, "ldap://%s", dcerpc_server_name(p));
+               sam_ctx = ldb_wrap_connect(tctx, tctx->ev, tctx->lp_ctx, url,
+                                          NULL,
+                                          cmdline_credentials,
+                                          0);
+               
+               torture_assert(tctx, sam_ctx, "Connection to the SAMDB on DC failed!");
+       }
 
-       creds_client_authenticator(creds, &a);
+       torture_comment(tctx, "Testing netr_LogonGetDomainInfo 1st call (no variation of DNS hostname)\n");
+       netlogon_creds_client_authenticator(creds, &a);
 
+       ZERO_STRUCT(r);
        r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.computer_name = TEST_MACHINE_NAME;
-       r.in.level = 1;
        r.in.credential = &a;
+       r.in.level = 1;
        r.in.return_authenticator = &a;
+       r.in.query = &query;
        r.out.return_authenticator = &a;
+       r.out.info = &info;
+
+       ZERO_STRUCT(os);
+       os.os.MajorVersion = 123;
+       os.os.MinorVersion = 456;
+       os.os.BuildNumber = 789;
+       os.os.CSDVersion = "Service Pack 10";
+       os.os.ServicePackMajor = 10;
+       os.os.ServicePackMinor = 1;
+       os.os.SuiteMask = NETR_VER_SUITE_SINGLEUSERTS;
+       os.os.ProductType = NETR_VER_NT_SERVER;
+       os.os.Reserved = 0;
+
+       version_str = talloc_asprintf(tctx, "%d.%d (%d)", os.os.MajorVersion,
+               os.os.MinorVersion, os.os.BuildNumber);
 
-       r.in.query.query1 = &q1;
        ZERO_STRUCT(q1);
-       
-       /* this should really be the fully qualified name */
-       q1.workstation_domain = TEST_MACHINE_NAME;
-       q1.workstation_site = "Default-First-Site-Name";
-       q1.blob2.length = 0;
-       q1.blob2.size = 0;
-       q1.blob2.data = NULL;
-       q1.product.string = "product string";
+       q1.dns_hostname = talloc_asprintf(tctx, "%s.%s", TEST_MACHINE_NAME,
+               TEST_MACHINE_DNS_SUFFIX);
+       q1.sitename = "Default-First-Site-Name";
+       q1.os_version.os = &os;
+       q1.os_name.string = talloc_asprintf(tctx,
+                                           "Tortured by Samba4 RPC-NETLOGON: %s",
+                                           timestring(tctx, time(NULL)));
+
+       /* The workstation handles the "servicePrincipalName" and DNS hostname
+          updates */
+       q1.workstation_flags = NETR_WS_FLAG_HANDLES_SPN_UPDATE;
+
+       query.workstation_info = &q1;
+
+       if (sam_ctx) {
+               /* Gets back the old DNS hostname in AD */
+               ret = gendb_search(sam_ctx, tctx, NULL, &res, attrs,
+                                  "(sAMAccountName=%s$)", TEST_MACHINE_NAME);
+               old_dnsname =
+                       ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL);
+               
+               /* Gets back the "servicePrincipalName"s in AD */
+               spn_el = ldb_msg_find_element(res[0], "servicePrincipalName");
+               if (spn_el != NULL) {
+                       for (i=0; i < spn_el->num_values; i++) {
+                               spns = talloc_realloc(tctx, spns, char *, i + 1);
+                               spns[i] = (char *) spn_el->values[i].data;
+                       }
+                       num_spns = i;
+               }
+       }
 
-       torture_comment(tctx, "Testing netr_LogonGetDomainInfo\n");
+       status = dcerpc_netr_LogonGetDomainInfo(p, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status, "netr_LogonGetDomainInfo");
+       torture_assert(tctx, netlogon_creds_client_check(creds, &a.cred), "Credential chaining failed");
+
+       msleep(250);
+
+       if (sam_ctx) {
+               /* AD workstation infos entry check */
+               ret = gendb_search(sam_ctx, tctx, NULL, &res, attrs,
+                                  "(sAMAccountName=%s$)", TEST_MACHINE_NAME);
+               torture_assert(tctx, ret == 1, "Test machine account not found in SAMDB on DC! Has the workstation been joined?");
+               torture_assert_str_equal(tctx,
+                                        ldb_msg_find_attr_as_string(res[0], "operatingSystem", NULL),
+                                        q1.os_name.string, "'operatingSystem' wrong!");
+               torture_assert_str_equal(tctx,
+                                        ldb_msg_find_attr_as_string(res[0], "operatingSystemServicePack", NULL),
+                                        os.os.CSDVersion, "'operatingSystemServicePack' wrong!");
+               torture_assert_str_equal(tctx,
+                                        ldb_msg_find_attr_as_string(res[0], "operatingSystemVersion", NULL),
+                                        version_str, "'operatingSystemVersion' wrong!");
+
+               if (old_dnsname != NULL) {
+                       /* If before a DNS hostname was set then it should remain
+                          the same in combination with the "servicePrincipalName"s.
+                          The DNS hostname should also be returned by our
+                          "LogonGetDomainInfo" call (in the domain info structure). */
+                       
+                       torture_assert_str_equal(tctx,
+                                                ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL),
+                                                old_dnsname, "'DNS hostname' was not set!");
+                       
+                       spn_el = ldb_msg_find_element(res[0], "servicePrincipalName");
+                       torture_assert(tctx, ((spns != NULL) && (spn_el != NULL)),
+                                      "'servicePrincipalName's not set!");
+                       torture_assert(tctx, spn_el->num_values == num_spns,
+                                      "'servicePrincipalName's incorrect!");
+                       for (i=0; (i < spn_el->num_values) && (i < num_spns); i++)
+                               torture_assert_str_equal(tctx,
+                                                        (char *) spn_el->values[i].data,
+                               spns[i], "'servicePrincipalName's incorrect!");
+
+                       torture_assert_str_equal(tctx,
+                                                info.domain_info->dns_hostname.string,
+                                                old_dnsname,
+                                                "Out 'DNS hostname' doesn't match the old one!");
+               } else {
+                       /* If no DNS hostname was set then also now none should be set,
+                          the "servicePrincipalName"s should remain empty and no DNS
+                          hostname should be returned by our "LogonGetDomainInfo"
+                          call (in the domain info structure). */
+                       
+                       torture_assert(tctx,
+                                      ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL) == NULL,
+                                      "'DNS hostname' was set!");
+                       
+                       spn_el = ldb_msg_find_element(res[0], "servicePrincipalName");
+                       torture_assert(tctx, ((spns == NULL) && (spn_el == NULL)),
+                                      "'servicePrincipalName's were set!");
+                       
+                       torture_assert(tctx,
+                                      info.domain_info->dns_hostname.string == NULL,
+                                      "Out 'DNS host name' was set!");
+               }
+       }
+
+       /* Checks "workstation flags" */
+       torture_assert(tctx,
+               info.domain_info->workstation_flags
+               == NETR_WS_FLAG_HANDLES_SPN_UPDATE,
+               "Out 'workstation flags' don't match!");
+
+
+       torture_comment(tctx, "Testing netr_LogonGetDomainInfo 2nd call (variation of DNS hostname)\n");
+       netlogon_creds_client_authenticator(creds, &a);
+
+       /* Wipe out the osVersion, and prove which values still 'stick' */
+       q1.os_version.os = NULL;
+
+       /* Change also the DNS hostname to test differences in behaviour */
+       q1.dns_hostname = talloc_asprintf(tctx, "%s.newdomain",
+               TEST_MACHINE_NAME);
+
+       /* Let the DC handle the "servicePrincipalName" and DNS hostname
+          updates */
+       q1.workstation_flags = 0;
+
+       status = dcerpc_netr_LogonGetDomainInfo(p, tctx, &r);
+       torture_assert_ntstatus_ok(tctx, status, "netr_LogonGetDomainInfo");
+       torture_assert(tctx, netlogon_creds_client_check(creds, &a.cred), "Credential chaining failed");
+
+       msleep(250);
+
+       if (sam_ctx) {
+               /* AD workstation infos entry check */
+               ret = gendb_search(sam_ctx, tctx, NULL, &res, attrs,
+                                  "(sAMAccountName=%s$)", TEST_MACHINE_NAME);
+               torture_assert(tctx, ret == 1, "Test machine account not found in SAMDB on DC! Has the workstation been joined?");
+               torture_assert_str_equal(tctx,
+                                        ldb_msg_find_attr_as_string(res[0], "operatingSystem", NULL),
+                                        q1.os_name.string, "'operatingSystem' should stick!");
+               torture_assert(tctx,
+                              ldb_msg_find_attr_as_string(res[0], "operatingSystemServicePack", NULL) == NULL,
+                              "'operatingSystemServicePack' shouldn't stick!");
+               torture_assert(tctx,
+                              ldb_msg_find_attr_as_string(res[0], "operatingSystemVersion", NULL) == NULL,
+                              "'operatingSystemVersion' shouldn't stick!");
+               
+               /* The DNS host name should have been updated now by the server */
+               torture_assert_str_equal(tctx,
+                                        ldb_msg_find_attr_as_string(res[0], "dNSHostName", NULL),
+                                        q1.dns_hostname, "'DNS host name' didn't change!");
+               
+               /* Find the two "servicePrincipalName"s which the DC should have been
+                  updated (HOST/<Netbios name> and HOST/<FQDN name>) - see MS-NRPC
+                  3.5.4.3.9 */
+               spn_el = ldb_msg_find_element(res[0], "servicePrincipalName");
+               torture_assert(tctx, spn_el != NULL,
+                              "There should exist 'servicePrincipalName's in AD!");
+               temp_str = talloc_asprintf(tctx, "HOST/%s", TEST_MACHINE_NAME);
+               for (i=0; i < spn_el->num_values; i++)
+                       if (strcmp((char *) spn_el->values[i].data, temp_str) == 0)
+                               break;
+               torture_assert(tctx, i != spn_el->num_values,
+                              "'servicePrincipalName' HOST/<Netbios name> not found!");
+               temp_str = talloc_asprintf(tctx, "HOST/%s", q1.dns_hostname);
+               for (i=0; i < spn_el->num_values; i++)
+                       if (strcmp((char *) spn_el->values[i].data, temp_str) == 0)
+                               break;
+               torture_assert(tctx, i != spn_el->num_values,
+                              "'servicePrincipalName' HOST/<FQDN name> not found!");
+               
+               /* Check that the out DNS hostname was set properly */
+               torture_assert_str_equal(tctx, info.domain_info->dns_hostname.string,
+                                        old_dnsname, "Out 'DNS hostname' doesn't match the old one!");
+       }
+
+       /* Checks "workstation flags" */
+       torture_assert(tctx,
+               info.domain_info->workstation_flags == 0,
+               "Out 'workstation flags' don't match!");
+
+
+       torture_comment(tctx, "Testing netr_LogonGetDomainInfo 3rd call (verification of DNS hostname and check for trusted domains)\n");
+       netlogon_creds_client_authenticator(creds, &a);
+
+       /* The workstation handles the "servicePrincipalName" and DNS hostname
+          updates */
+       q1.workstation_flags = NETR_WS_FLAG_HANDLES_SPN_UPDATE;
 
        status = dcerpc_netr_LogonGetDomainInfo(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "netr_LogonGetDomainInfo");
-       torture_assert(tctx, creds_client_check(creds, &a.cred), "Credential chaining failed");
+       torture_assert(tctx, netlogon_creds_client_check(creds, &a.cred), "Credential chaining failed");
+
+       msleep(250);
+
+       /* Now the in/out DNS hostnames should be the same */
+       torture_assert_str_equal(tctx,
+               info.domain_info->dns_hostname.string,
+               query.workstation_info->dns_hostname,
+               "In/Out 'DNS hostnames' don't match!");
+
+       /* Checks "workstation flags" */
+       torture_assert(tctx,
+               info.domain_info->workstation_flags
+               == NETR_WS_FLAG_HANDLES_SPN_UPDATE,
+               "Out 'workstation flags' don't match!");
+
+       /* Checks for trusted domains */
+       torture_assert(tctx,
+               (info.domain_info->trusted_domain_count != 0)
+               && (info.domain_info->trusted_domains != NULL),
+               "Trusted domains have been requested!");
+
+
+       torture_comment(tctx, "Testing netr_LogonGetDomainInfo 4th call (check for trusted domains)\n");
+       netlogon_creds_client_authenticator(creds, &a);
 
-       torture_comment(tctx, "Testing netr_LogonGetDomainInfo 2nd call\n");
-       creds_client_authenticator(creds, &a);
+       /* The workstation handles the "servicePrincipalName" and DNS hostname
+          updates and requests inbound trusts */
+       q1.workstation_flags = NETR_WS_FLAG_HANDLES_SPN_UPDATE
+               | NETR_WS_FLAG_HANDLES_INBOUND_TRUSTS;
 
        status = dcerpc_netr_LogonGetDomainInfo(p, tctx, &r);
        torture_assert_ntstatus_ok(tctx, status, "netr_LogonGetDomainInfo");
-       torture_assert(tctx, creds_client_check(creds, &a.cred), "Credential chaining failed");
+       torture_assert(tctx, netlogon_creds_client_check(creds, &a.cred), "Credential chaining failed");
+
+       msleep(250);
+
+       /* Checks "workstation flags" */
+       torture_assert(tctx,
+               info.domain_info->workstation_flags
+               == (NETR_WS_FLAG_HANDLES_SPN_UPDATE
+                       | NETR_WS_FLAG_HANDLES_INBOUND_TRUSTS),
+               "Out 'workstation flags' don't match!");
+
+       /* Checks for trusted domains */
+       torture_assert(tctx,
+               (info.domain_info->trusted_domain_count != 0)
+               && (info.domain_info->trusted_domains != NULL),
+               "Trusted domains have been requested!");
 
        return true;
 }
@@ -1509,14 +2645,18 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
 {
        NTSTATUS status;
        struct netr_LogonGetDomainInfo r;
-       struct netr_DomainQuery1 q1;
+       struct netr_WorkstationInformation q1;
        struct netr_Authenticator a;
 #define ASYNC_COUNT 100
-       struct creds_CredentialState *creds;
-       struct creds_CredentialState *creds_async[ASYNC_COUNT];
+       struct netlogon_creds_CredentialState *creds;
+       struct netlogon_creds_CredentialState *creds_async[ASYNC_COUNT];
        struct rpc_request *req[ASYNC_COUNT];
        int i;
        int *async_counter = talloc(tctx, int);
+       union netr_WorkstationInfo query;
+       union netr_DomainInfo info;
+
+       torture_comment(tctx, "Testing netr_LogonGetDomainInfo - async count %d\n", ASYNC_COUNT);
 
        if (!test_SetupCredentials3(p, tctx, NETLOGON_NEG_AUTH2_ADS_FLAGS, 
                                    machine_credentials, &creds)) {
@@ -1526,30 +2666,27 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
        ZERO_STRUCT(r);
        r.in.server_name = talloc_asprintf(tctx, "\\\\%s", dcerpc_server_name(p));
        r.in.computer_name = TEST_MACHINE_NAME;
-       r.in.level = 1;
        r.in.credential = &a;
+       r.in.level = 1;
        r.in.return_authenticator = &a;
+       r.in.query = &query;
        r.out.return_authenticator = &a;
+       r.out.info = &info;
 
-       r.in.query.query1 = &q1;
        ZERO_STRUCT(q1);
-       
-       /* this should really be the fully qualified name */
-       q1.workstation_domain = TEST_MACHINE_NAME;
-       q1.workstation_site = "Default-First-Site-Name";
-       q1.blob2.length = 0;
-       q1.blob2.size = 0;
-       q1.blob2.data = NULL;
-       q1.product.string = "product string";
+       q1.dns_hostname = talloc_asprintf(tctx, "%s.%s", TEST_MACHINE_NAME,
+               TEST_MACHINE_DNS_SUFFIX);
+       q1.sitename = "Default-First-Site-Name";
+       q1.os_name.string = "UNIX/Linux or similar";
 
-       torture_comment(tctx, "Testing netr_LogonGetDomainInfo - async count %d\n", ASYNC_COUNT);
+       query.workstation_info = &q1;
 
        *async_counter = 0;
 
        for (i=0;i<ASYNC_COUNT;i++) {
-               creds_client_authenticator(creds, &a);
+               netlogon_creds_client_authenticator(creds, &a);
 
-               creds_async[i] = (struct creds_CredentialState *)talloc_memdup(creds, creds, sizeof(*creds));
+               creds_async[i] = (struct netlogon_creds_CredentialState *)talloc_memdup(creds, creds, sizeof(*creds));
                req[i] = dcerpc_netr_LogonGetDomainInfo_send(p, tctx, &r);
 
                req[i]->async.callback = async_callback;
@@ -1567,7 +2704,7 @@ static bool test_GetDomainInfo_async(struct torture_context *tctx,
                torture_assert_ntstatus_ok(tctx, status, "netr_LogonGetDomainInfo_async");
                torture_assert_ntstatus_ok(tctx, r.out.result, "netr_LogonGetDomainInfo_async"); 
 
-               torture_assert(tctx, creds_client_check(creds_async[i], &a.cred), 
+               torture_assert(tctx, netlogon_creds_client_check(creds_async[i], &a.cred), 
                        "Credential chaining failed at async");
        }
 
@@ -1663,13 +2800,37 @@ static bool test_ManyGetDCName(struct torture_context *tctx,
        return true;
 }
 
+static bool test_SetPassword_with_flags(struct torture_context *tctx,
+                                       struct dcerpc_pipe *p,
+                                       struct cli_credentials *machine_credentials)
+{
+       uint32_t flags[] = { 0, NETLOGON_NEG_STRONG_KEYS };
+       struct netlogon_creds_CredentialState *creds;
+       int i;
+
+       if (!test_SetupCredentials2(p, tctx, 0,
+                                   machine_credentials,
+                                   cli_credentials_get_secure_channel_type(machine_credentials),
+                                   &creds)) {
+               torture_skip(tctx, "DC does not support negotiation of 64bit session keys");
+       }
+
+       for (i=0; i < ARRAY_SIZE(flags); i++) {
+               torture_assert(tctx,
+                       test_SetPassword_flags(tctx, p, machine_credentials, flags[i]),
+                       talloc_asprintf(tctx, "failed to test SetPassword negotiating with 0x%08x flags", flags[i]));
+       }
+
+       return true;
+}
+
 struct torture_suite *torture_rpc_netlogon(TALLOC_CTX *mem_ctx)
 {
        struct torture_suite *suite = torture_suite_create(mem_ctx, "NETLOGON");
        struct torture_rpc_tcase *tcase;
        struct torture_test *test;
 
-       tcase = torture_suite_add_machine_rpc_iface_tcase(suite, "netlogon", 
+       tcase = torture_suite_add_machine_bdc_rpc_iface_tcase(suite, "netlogon",
                                                  &ndr_table_netlogon, TEST_MACHINE_NAME);
 
        torture_rpc_tcase_add_test(tcase, "LogonUasLogon", test_LogonUasLogon);
@@ -1682,15 +2843,13 @@ struct torture_suite *torture_rpc_netlogon(TALLOC_CTX *mem_ctx)
        torture_rpc_tcase_add_test_creds(tcase, "GetDomainInfo", test_GetDomainInfo);
        torture_rpc_tcase_add_test_creds(tcase, "DatabaseSync", test_DatabaseSync);
        torture_rpc_tcase_add_test_creds(tcase, "DatabaseDeltas", test_DatabaseDeltas);
+       torture_rpc_tcase_add_test_creds(tcase, "DatabaseRedo", test_DatabaseRedo);
        torture_rpc_tcase_add_test_creds(tcase, "AccountDeltas", test_AccountDeltas);
        torture_rpc_tcase_add_test_creds(tcase, "AccountSync", test_AccountSync);
        torture_rpc_tcase_add_test(tcase, "GetDcName", test_GetDcName);
        torture_rpc_tcase_add_test(tcase, "ManyGetDCName", test_ManyGetDCName);
-       torture_rpc_tcase_add_test(tcase, "LogonControl", test_LogonControl);
        torture_rpc_tcase_add_test(tcase, "GetAnyDCName", test_GetAnyDCName);
-       torture_rpc_tcase_add_test(tcase, "LogonControl2", test_LogonControl2);
        torture_rpc_tcase_add_test_creds(tcase, "DatabaseSync2", test_DatabaseSync2);
-       torture_rpc_tcase_add_test(tcase, "LogonControl2Ex", test_LogonControl2Ex);
        torture_rpc_tcase_add_test(tcase, "DsrEnumerateDomainTrusts", test_DsrEnumerateDomainTrusts);
        torture_rpc_tcase_add_test(tcase, "NetrEnumerateTrustedDomains", test_netr_NetrEnumerateTrustedDomains);
        torture_rpc_tcase_add_test(tcase, "NetrEnumerateTrustedDomainsEx", test_netr_NetrEnumerateTrustedDomainsEx);
@@ -1702,6 +2861,50 @@ struct torture_suite *torture_rpc_netlogon(TALLOC_CTX *mem_ctx)
        torture_rpc_tcase_add_test(tcase, "DsrGetDcSiteCoverageW", test_netr_DsrGetDcSiteCoverageW);
        torture_rpc_tcase_add_test(tcase, "DsRAddressToSitenamesW", test_netr_DsRAddressToSitenamesW);
        torture_rpc_tcase_add_test(tcase, "DsRAddressToSitenamesExW", test_netr_DsRAddressToSitenamesExW);
+       torture_rpc_tcase_add_test_creds(tcase, "ServerGetTrustInfo", test_netr_ServerGetTrustInfo);
+
+       return suite;
+}
+
+struct torture_suite *torture_rpc_netlogon_s3(TALLOC_CTX *mem_ctx)
+{
+       struct torture_suite *suite = torture_suite_create(mem_ctx, "NETLOGON-S3");
+       struct torture_rpc_tcase *tcase;
+
+       tcase = torture_suite_add_machine_bdc_rpc_iface_tcase(suite, "netlogon",
+                                                 &ndr_table_netlogon, TEST_MACHINE_NAME);
+
+       torture_rpc_tcase_add_test_creds(tcase, "SamLogon", test_SamLogon);
+       torture_rpc_tcase_add_test_creds(tcase, "SetPassword", test_SetPassword);
+       torture_rpc_tcase_add_test_creds(tcase, "SetPassword_with_flags", test_SetPassword_with_flags);
+       torture_rpc_tcase_add_test_creds(tcase, "SetPassword2", test_SetPassword2);
+       torture_rpc_tcase_add_test(tcase, "NetrEnumerateTrustedDomains", test_netr_NetrEnumerateTrustedDomains);
+
+       return suite;
+}
+
+struct torture_suite *torture_rpc_netlogon_admin(TALLOC_CTX *mem_ctx)
+{
+       struct torture_suite *suite = torture_suite_create(mem_ctx, "NETLOGON-ADMIN");
+       struct torture_rpc_tcase *tcase;
+
+       tcase = torture_suite_add_machine_bdc_rpc_iface_tcase(suite, "netlogon",
+                                                 &ndr_table_netlogon, TEST_MACHINE_NAME);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl", test_LogonControl);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl2", test_LogonControl2);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl2Ex", test_LogonControl2Ex);
+
+       tcase = torture_suite_add_machine_workstation_rpc_iface_tcase(suite, "netlogon",
+                                                 &ndr_table_netlogon, TEST_MACHINE_NAME);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl", test_LogonControl);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl2", test_LogonControl2);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl2Ex", test_LogonControl2Ex);
+
+       tcase = torture_suite_add_rpc_iface_tcase(suite, "netlogon",
+                                                 &ndr_table_netlogon);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl", test_LogonControl);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl2", test_LogonControl2);
+       torture_rpc_tcase_add_test_creds(tcase, "LogonControl2Ex", test_LogonControl2Ex);
 
        return suite;
 }