s4:dcesrv_samr - Add more checks for invalid levels
[ira/wip.git] / source4 / rpc_server / samr / dcesrv_samr.c
index ec60ac7a45378d28e2e1e40086ceac3862e9ba50..0b102b5e791f6751a222e7166e53680c74522cbf 100644 (file)
@@ -6,6 +6,7 @@
    Copyright (C) Andrew Tridgell 2004
    Copyright (C) Volker Lendecke 2004
    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2004-2005
+   Copyright (C) Matthias Dieter Wallnöfer 2009
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -29,7 +30,7 @@
 #include "system/time.h"
 #include "lib/ldb/include/ldb.h"
 #include "lib/ldb/include/ldb_errors.h"
-#include "dsdb/common/flags.h"
+#include "../libds/common/flags.h"
 #include "dsdb/samdb/samdb.h"
 #include "libcli/ldap/ldap_ndr.h"
 #include "libcli/security/security.h"
@@ -164,7 +165,7 @@ static NTSTATUS dcesrv_samr_Connect(struct dcesrv_call_state *dce_call, TALLOC_C
 
        ZERO_STRUCTP(r->out.connect_handle);
 
-       c_state = talloc(dce_call->conn, struct samr_connect_state);
+       c_state = talloc(mem_ctx, struct samr_connect_state);
        if (!c_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -397,7 +398,7 @@ static NTSTATUS dcesrv_samr_OpenDomain(struct dcesrv_call_state *dce_call, TALLO
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       d_state = talloc(c_state, struct samr_domain_state);
+       d_state = talloc(mem_ctx, struct samr_domain_state);
        if (!d_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -737,9 +738,12 @@ static NTSTATUS dcesrv_samr_QueryDomainInfo(struct dcesrv_call_state *dce_call,
        switch (r->in.level) {
        case 1: 
        {
-               static const char * const attrs2[] = { "minPwdLength", "pwdHistoryLength",
-                                                      "pwdProperties", "maxPwdAge",
-                                                      "minPwdAge", NULL };
+               static const char * const attrs2[] = { "minPwdLength",
+                                                      "pwdHistoryLength",
+                                                      "pwdProperties",
+                                                      "maxPwdAge",
+                                                      "minPwdAge",
+                                                      NULL };
                attrs = attrs2;
                break;
        }
@@ -793,11 +797,14 @@ static NTSTATUS dcesrv_samr_QueryDomainInfo(struct dcesrv_call_state *dce_call,
                break;
        }
        case 9:
+       {
                attrs = NULL;
-               break;          
+               break;
+       }
        case 11:
        {
-               static const char * const attrs2[] = { "oEMInformation", "forceLogoff", 
+               static const char * const attrs2[] = { "oEMInformation",
+                                                      "forceLogoff",
                                                       "modifiedCount", 
                                                       "lockoutDuration", 
                                                       "lockOutObservationWindow", 
@@ -823,6 +830,10 @@ static NTSTATUS dcesrv_samr_QueryDomainInfo(struct dcesrv_call_state *dce_call,
                attrs = attrs2;
                break;
        }
+       default:
+       {
+               return NT_STATUS_INVALID_INFO_CLASS;
+       }
        }
 
        /* some levels don't need a search */
@@ -876,9 +887,9 @@ static NTSTATUS dcesrv_samr_QueryDomainInfo(struct dcesrv_call_state *dce_call,
        case 13:
                return dcesrv_samr_info_DomInfo13(d_state, mem_ctx, dom_msgs, 
                                                  &info->info13);
+       default:
+               return NT_STATUS_INVALID_INFO_CLASS;
        }
-
-       return NT_STATUS_INVALID_INFO_CLASS;
 }
 
 
@@ -944,7 +955,7 @@ static NTSTATUS dcesrv_samr_SetDomainInfo(struct dcesrv_call_state *dce_call, TA
 
        /* modify the samdb record */
        ret = ldb_modify(sam_ctx, msg);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                DEBUG(1,("Failed to modify record %s: %s\n",
                         ldb_dn_get_linearized(d_state->domain_dn),
                         ldb_errstring(sam_ctx)));
@@ -1035,7 +1046,7 @@ static NTSTATUS dcesrv_samr_CreateDomainGroup(struct dcesrv_call_state *dce_call
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1223,8 +1234,13 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
                return NT_STATUS_INVALID_PARAMETER;
        }
 
+       /*
+        * Start a transaction, so we can query and do a subsequent atomic
+        * modify
+        */
+
        ret = ldb_transaction_start(d_state->sam_ctx);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                DEBUG(0,("Failed to start a transaction for user creation: %s\n",
                         ldb_errstring(d_state->sam_ctx)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
@@ -1267,7 +1283,8 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
                cn_name[cn_name_len - 1] = '\0';
                container = "CN=Computers";
                obj_class = "computer";
-               samdb_msg_add_int(d_state->sam_ctx, mem_ctx, msg, "primaryGroupID", DOMAIN_RID_DOMAIN_MEMBERS);
+               samdb_msg_add_int(d_state->sam_ctx, mem_ctx, msg,
+                       "primaryGroupID", DOMAIN_RID_DOMAIN_MEMBERS);
 
        } else if (r->in.acct_flags == ACB_SVRTRUST) {
                if (cn_name[cn_name_len - 1] != '$') {
@@ -1277,24 +1294,25 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
                cn_name[cn_name_len - 1] = '\0';
                container = "OU=Domain Controllers";
                obj_class = "computer";
-               samdb_msg_add_int(d_state->sam_ctx, mem_ctx, msg, "primaryGroupID", DOMAIN_RID_DCS);
+               samdb_msg_add_int(d_state->sam_ctx, mem_ctx, msg,
+                       "primaryGroupID", DOMAIN_RID_DCS);
        } else {
                ldb_transaction_cancel(d_state->sam_ctx);
                return NT_STATUS_INVALID_PARAMETER;
        }
 
        /* add core elements to the ldb_message for the user */
-       msg->dn = ldb_dn_copy(mem_ctx, d_state->domain_dn);
+       msg->dn = ldb_dn_copy(msg, d_state->domain_dn);
        if ( ! ldb_dn_add_child_fmt(msg->dn, "CN=%s,%s", cn_name, container)) {
                ldb_transaction_cancel(d_state->sam_ctx);
                return NT_STATUS_FOOBAR;
        }
 
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "sAMAccountName", account_name);
-       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "objectClass", obj_class);
-       
-       /* Start a transaction, so we can query and do a subsequent atomic modify */
-       
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "sAMAccountName",
+               account_name);
+       samdb_msg_add_string(d_state->sam_ctx, mem_ctx, msg, "objectClass",
+               obj_class);
+
        /* create the user */
        ret = ldb_add(d_state->sam_ctx, msg);
        switch (ret) {
@@ -1321,7 +1339,7 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                ldb_transaction_cancel(d_state->sam_ctx);
                return NT_STATUS_NO_MEMORY;
@@ -1332,7 +1350,7 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
        a_state->account_dn = talloc_steal(a_state, msg->dn);
 
        /* retrieve the sid and account control bits for the user just created */
-       ret = gendb_search_dn(d_state->sam_ctx, a_state,
+       ret = gendb_search_dn(d_state->sam_ctx, mem_ctx,
                              msg->dn, &msgs, attrs);
 
        if (ret != 1) {
@@ -1357,7 +1375,7 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
                                  UF_INTERDOMAIN_TRUST_ACCOUNT | 
                                  UF_WORKSTATION_TRUST_ACCOUNT | 
                                  UF_SERVER_TRUST_ACCOUNT));
-       user_account_control |= samdb_acb2uf(r->in.acct_flags);
+       user_account_control |= ds_acb2uf(r->in.acct_flags);
 
        talloc_free(msg);
        msg = ldb_msg_new(mem_ctx);
@@ -1377,7 +1395,7 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
 
        /* modify the samdb record */
        ret = samdb_replace(a_state->sam_ctx, mem_ctx, msg);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                DEBUG(0,("Failed to modify account record %s to set userAccountControl: %s\n",
                         ldb_dn_get_linearized(msg->dn),
                         ldb_errstring(d_state->sam_ctx)));
@@ -1388,7 +1406,7 @@ static NTSTATUS dcesrv_samr_CreateUser2(struct dcesrv_call_state *dce_call, TALL
        }
 
        ret = ldb_transaction_commit(d_state->sam_ctx);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                DEBUG(0,("Failed to commit transaction to add and modify account record %s: %s\n",
                         ldb_dn_get_linearized(msg->dn),
                         ldb_errstring(d_state->sam_ctx)));
@@ -1450,7 +1468,8 @@ static NTSTATUS dcesrv_samr_EnumDomainUsers(struct dcesrv_call_state *dce_call,
        struct ldb_result *res;
        int ret, num_filtered_entries, i, first;
        struct samr_SamEntry *entries;
-       const char * const attrs[] = { "objectSid", "sAMAccountName", "userAccountControl", NULL };
+       const char * const attrs[] = { "objectSid", "sAMAccountName",
+               "userAccountControl", NULL };
        struct samr_SamArray *sam;
 
        *r->out.resume_handle = 0;
@@ -1601,7 +1620,7 @@ static NTSTATUS dcesrv_samr_CreateDomAlias(struct dcesrv_call_state *dce_call, T
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -1766,7 +1785,8 @@ static NTSTATUS dcesrv_samr_GetAliasMembership(struct dcesrv_call_state *dce_cal
 
                        memberdn = 
                                samdb_search_string(d_state->sam_ctx,
-                                                   mem_ctx, NULL, "distinguishedName",
+                                                   mem_ctx, NULL,
+                                                   "distinguishedName",
                                                    "(objectSid=%s)",
                                                    ldap_encode_ndr_dom_sid(mem_ctx, 
                                                                            r->in.sids->sids[i].sid));
@@ -1873,7 +1893,7 @@ static NTSTATUS dcesrv_samr_LookupNames(struct dcesrv_call_state *dce_call, TALL
                        continue;
                }
 
-               rtype = samdb_atype_map(atype);
+               rtype = ds_atype_map(atype);
                
                if (rtype == SID_NAME_UNKNOWN) {
                        status = STATUS_SOME_UNMAPPED;
@@ -1933,7 +1953,8 @@ static NTSTATUS dcesrv_samr_LookupRids(struct dcesrv_call_state *dce_call, TALLO
 
                ids[i] = SID_NAME_UNKNOWN;
 
-               sid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rids[i]);
+               sid = dom_sid_add_rid(mem_ctx, d_state->domain_sid,
+                       r->in.rids[i]);
                if (sid == NULL) {
                        names[i].string = NULL;
                        status = STATUS_SOME_UNMAPPED;
@@ -1959,7 +1980,7 @@ static NTSTATUS dcesrv_samr_LookupRids(struct dcesrv_call_state *dce_call, TALLO
                        continue;
                }
 
-               ids[i] = samdb_atype_map(atype);
+               ids[i] = ds_atype_map(atype);
                
                if (ids[i] == SID_NAME_UNKNOWN) {
                        status = STATUS_SOME_UNMAPPED;
@@ -2028,7 +2049,7 @@ static NTSTATUS dcesrv_samr_OpenGroup(struct dcesrv_call_state *dce_call, TALLOC
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -2076,7 +2097,8 @@ static NTSTATUS dcesrv_samr_QueryGroupInfo(struct dcesrv_call_state *dce_call, T
 
        a_state = h->data;
        
-       ret = ldb_search(a_state->sam_ctx, mem_ctx, &res, a_state->account_dn, LDB_SCOPE_SUBTREE, attrs, "objectClass=*");
+       ret = ldb_search(a_state->sam_ctx, mem_ctx, &res, a_state->account_dn,
+               LDB_SCOPE_SUBTREE, attrs, "objectClass=*");
        
        if (ret == LDB_ERR_NO_SUCH_OBJECT) {
                return NT_STATUS_NO_SUCH_GROUP;
@@ -2177,7 +2199,7 @@ static NTSTATUS dcesrv_samr_SetGroupInfo(struct dcesrv_call_state *dce_call, TAL
 
        /* modify the samdb record */
        ret = ldb_modify(g_state->sam_ctx, msg);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                /* we really need samdb.c to return NTSTATUS */
                return NT_STATUS_UNSUCCESSFUL;
        }
@@ -2208,8 +2230,9 @@ static NTSTATUS dcesrv_samr_AddGroupMember(struct dcesrv_call_state *dce_call, T
        d_state = a_state->domain_state;
 
        membersid = dom_sid_add_rid(mem_ctx, d_state->domain_sid, r->in.rid);
-       if (membersid == NULL)
+       if (membersid == NULL) {
                return NT_STATUS_NO_MEMORY;
+       }
 
        /* In native mode, AD can also nest domain groups. Not sure yet
         * whether this is also available via RPC. */
@@ -2218,7 +2241,7 @@ static NTSTATUS dcesrv_samr_AddGroupMember(struct dcesrv_call_state *dce_call, T
                                 "(&(objectSid=%s)(objectclass=user))",
                                 ldap_encode_ndr_dom_sid(mem_ctx, membersid));
 
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -2242,9 +2265,11 @@ static NTSTATUS dcesrv_samr_AddGroupMember(struct dcesrv_call_state *dce_call, T
 
        mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
 
-       if (samdb_msg_add_addval(d_state->sam_ctx, mem_ctx, mod, "member",
-                                memberdn) != 0)
+       ret = samdb_msg_add_addval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                                               memberdn);
+       if (ret != LDB_SUCCESS) {
                return NT_STATUS_UNSUCCESSFUL;
+       }
 
        ret = ldb_modify(a_state->sam_ctx, mod);
        switch (ret) {
@@ -2257,7 +2282,6 @@ static NTSTATUS dcesrv_samr_AddGroupMember(struct dcesrv_call_state *dce_call, T
        default:
                return NT_STATUS_UNSUCCESSFUL;
        }
-
 }
 
 
@@ -2278,10 +2302,11 @@ static NTSTATUS dcesrv_samr_DeleteDomainGroup(struct dcesrv_call_state *dce_call
        a_state = h->data;
 
        ret = ldb_delete(a_state->sam_ctx, a_state->account_dn);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                return NT_STATUS_UNSUCCESSFUL;
        }
 
+       talloc_free(h);
        ZERO_STRUCTP(r->out.group_handle);
 
        return NT_STATUS_OK;
@@ -2320,7 +2345,7 @@ static NTSTATUS dcesrv_samr_DeleteGroupMember(struct dcesrv_call_state *dce_call
                                 "(&(objectSid=%s)(objectclass=user))",
                                 ldap_encode_ndr_dom_sid(mem_ctx, membersid));
 
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -2344,8 +2369,9 @@ static NTSTATUS dcesrv_samr_DeleteGroupMember(struct dcesrv_call_state *dce_call
 
        mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
 
-       if (samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod, "member",
-                                memberdn) != 0) {
+       ret = samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                                               memberdn);
+       if (ret != LDB_SUCCESS) {
                return NT_STATUS_NO_MEMORY;
        }
 
@@ -2360,7 +2386,6 @@ static NTSTATUS dcesrv_samr_DeleteGroupMember(struct dcesrv_call_state *dce_call
        default:
                return NT_STATUS_UNSUCCESSFUL;
        }
-
 }
 
 
@@ -2501,7 +2526,7 @@ static NTSTATUS dcesrv_samr_OpenAlias(struct dcesrv_call_state *dce_call, TALLOC
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       a_state = talloc(d_state, struct samr_account_state);
+       a_state = talloc(mem_ctx, struct samr_account_state);
        if (!a_state) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -2628,7 +2653,7 @@ static NTSTATUS dcesrv_samr_SetAliasInfo(struct dcesrv_call_state *dce_call, TAL
 
        /* modify the samdb record */
        ret = ldb_modify(a_state->sam_ctx, msg);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                /* we really need samdb.c to return NTSTATUS */
                return NT_STATUS_UNSUCCESSFUL;
        }
@@ -2658,6 +2683,7 @@ static NTSTATUS dcesrv_samr_DeleteDomAlias(struct dcesrv_call_state *dce_call, T
                return NT_STATUS_UNSUCCESSFUL;
        }
 
+       talloc_free(h);
        ZERO_STRUCTP(r->out.alias_handle);
 
        return NT_STATUS_OK;
@@ -2696,8 +2722,8 @@ static NTSTATUS dcesrv_samr_AddAliasMember(struct dcesrv_call_state *dce_call, T
                         ret, dom_sid_string(mem_ctx, r->in.sid)));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               status = samdb_create_foreign_security_principal(d_state->sam_ctx, mem_ctx, 
-                                                                r->in.sid, &memberdn);
+               status = samdb_create_foreign_security_principal(
+                       d_state->sam_ctx, mem_ctx, r->in.sid, &memberdn);
                if (!NT_STATUS_IS_OK(status)) {
                        return status;
                }
@@ -2717,12 +2743,15 @@ static NTSTATUS dcesrv_samr_AddAliasMember(struct dcesrv_call_state *dce_call, T
 
        mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
 
-       if (samdb_msg_add_addval(d_state->sam_ctx, mem_ctx, mod, "member",
-                                ldb_dn_alloc_linearized(mem_ctx, memberdn)) != 0)
+       ret = samdb_msg_add_addval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                ldb_dn_alloc_linearized(mem_ctx, memberdn));
+       if (ret != LDB_SUCCESS) {
                return NT_STATUS_UNSUCCESSFUL;
+       }
 
-       if (ldb_modify(a_state->sam_ctx, mod) != 0)
+       if (ldb_modify(a_state->sam_ctx, mod) != LDB_SUCCESS) {
                return NT_STATUS_UNSUCCESSFUL;
+       }
 
        return NT_STATUS_OK;
 }
@@ -2739,6 +2768,7 @@ static NTSTATUS dcesrv_samr_DeleteAliasMember(struct dcesrv_call_state *dce_call
        struct samr_domain_state *d_state;
        struct ldb_message *mod;
        const char *memberdn;
+       int ret;
 
        DCESRV_PULL_HANDLE(h, r->in.alias_handle, SAMR_HANDLE_ALIAS);
 
@@ -2759,11 +2789,12 @@ static NTSTATUS dcesrv_samr_DeleteAliasMember(struct dcesrv_call_state *dce_call
 
        mod->dn = talloc_reference(mem_ctx, a_state->account_dn);
 
-       if (samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod, "member",
-                                memberdn) != 0)
+       ret = samdb_msg_add_delval(d_state->sam_ctx, mem_ctx, mod, "member",
+                                                                memberdn);
+       if (ret != LDB_SUCCESS)
                return NT_STATUS_UNSUCCESSFUL;
 
-       if (ldb_modify(a_state->sam_ctx, mod) != 0)
+       if (ldb_modify(a_state->sam_ctx, mod) != LDB_SUCCESS)
                return NT_STATUS_UNSUCCESSFUL;
 
        return NT_STATUS_OK;
@@ -2932,13 +2963,14 @@ static NTSTATUS dcesrv_samr_DeleteUser(struct dcesrv_call_state *dce_call, TALLO
        a_state = h->data;
 
        ret = ldb_delete(a_state->sam_ctx, a_state->account_dn);
-       if (ret != 0) {
+       if (ret != LDB_SUCCESS) {
                DEBUG(1, ("Failed to delete user: %s: %s\n", 
                          ldb_dn_get_linearized(a_state->account_dn), 
                          ldb_errstring(a_state->sam_ctx)));
                return NT_STATUS_UNSUCCESSFUL;
        }
 
+       talloc_free(h);
        ZERO_STRUCTP(r->out.user_handle);
 
        return NT_STATUS_OK;
@@ -2971,15 +3003,21 @@ static NTSTATUS dcesrv_samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TA
        switch (r->in.level) {
        case 1:
        {
-               static const char * const attrs2[] = {"sAMAccountName", "displayName",
-                                                     "primaryroupID", "description",
-                                                     "comment", NULL};
+               static const char * const attrs2[] = {"sAMAccountName",
+                                                     "displayName",
+                                                     "primaryroupID",
+                                                     "description",
+                                                     "comment",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 2:
        {
-               static const char * const attrs2[] = {"comment", "countryCode", "codePage", NULL};
+               static const char * const attrs2[] = {"comment",
+                                                     "countryCode",
+                                                     "codePage",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
@@ -3000,13 +3038,15 @@ static NTSTATUS dcesrv_samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TA
                                                      "logonHours",
                                                      "badPwdCount",
                                                      "logonCount",
-                                                     "userAccountControl", NULL};
+                                                     "userAccountControl",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 4:
        {
-               static const char * const attrs2[] = {"logonHours", NULL};
+               static const char * const attrs2[] = {"logonHours",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
@@ -3036,73 +3076,92 @@ static NTSTATUS dcesrv_samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TA
        }
        case 6:
        {
-               static const char * const attrs2[] = {"sAMAccountName", "displayName", NULL};
+               static const char * const attrs2[] = {"sAMAccountName",
+                                                     "displayName",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 7:
        {
-               static const char * const attrs2[] = {"sAMAccountName", NULL};
+               static const char * const attrs2[] = {"sAMAccountName",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 8:
        {
-               static const char * const attrs2[] = {"displayName", NULL};
+               static const char * const attrs2[] = {"displayName",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 9:
        {
-               static const char * const attrs2[] = {"primaryGroupID", NULL};
+               static const char * const attrs2[] = {"primaryGroupID",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 10:
        {
-               static const char * const attrs2[] = {"homeDirectory", "homeDrive", NULL};
+               static const char * const attrs2[] = {"homeDirectory",
+                                                     "homeDrive",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 11:
        {
-               static const char * const attrs2[] = {"scriptPath", NULL};
+               static const char * const attrs2[] = {"scriptPath",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 12:
        {
-               static const char * const attrs2[] = {"profilePath", NULL};
+               static const char * const attrs2[] = {"profilePath",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 13:
        {
-               static const char * const attrs2[] = {"description", NULL};
+               static const char * const attrs2[] = {"description",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 14:
        {
-               static const char * const attrs2[] = {"userWorkstations", NULL};
+               static const char * const attrs2[] = {"userWorkstations",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 16:
        {
-               static const char * const attrs2[] = {"userAccountControl", "pwdLastSet", NULL};
+               static const char * const attrs2[] = {"userAccountControl",
+                                                     "pwdLastSet",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
        case 17:
        {
-               static const char * const attrs2[] = {"accountExpires", NULL};
+               static const char * const attrs2[] = {"accountExpires",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
+       case 18:
+       {
+               return NT_STATUS_NOT_SUPPORTED;
+       }
        case 20:
        {
-               static const char * const attrs2[] = {"userParameters", NULL};
+               static const char * const attrs2[] = {"userParameters",
+                                                     NULL};
                attrs = attrs2;
                break;
        }
@@ -3134,6 +3193,17 @@ static NTSTATUS dcesrv_samr_QueryUserInfo(struct dcesrv_call_state *dce_call, TA
                attrs = attrs2;
                break;
        }
+       case 23:
+       case 24:
+       case 25:
+       case 26:
+       {
+               return NT_STATUS_NOT_SUPPORTED;
+       }
+       default:
+       {
+               return NT_STATUS_INVALID_INFO_CLASS;
+       }
        }
 
        /* pull all the user attributes */
@@ -3342,6 +3412,7 @@ static NTSTATUS dcesrv_samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALL
                break;
 
        case 6:
+               SET_STRING(msg, info6.account_name,     "samAccountName");
                SET_STRING(msg, info6.full_name,        "displayName");
                break;
 
@@ -3391,68 +3462,77 @@ static NTSTATUS dcesrv_samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALL
                break;
 
        case 21:
-#define IFSET(bit) if (bit & r->in.info->info21.fields_present)        
+#define IFSET(bit) if (bit & r->in.info->info21.fields_present)
                IFSET(SAMR_FIELD_ACCT_EXPIRY)
-                       SET_UINT64(msg, info21.acct_expiry,    "accountExpires");       
+                       SET_UINT64(msg, info21.acct_expiry,    "accountExpires");
                IFSET(SAMR_FIELD_ACCOUNT_NAME)         
                        SET_STRING(msg, info21.account_name,   "samAccountName");
                IFSET(SAMR_FIELD_FULL_NAME) 
                        SET_STRING(msg, info21.full_name,      "displayName");
-               IFSET(SAMR_FIELD_DESCRIPTION)
-                       SET_STRING(msg, info21.description,    "description");
-               IFSET(SAMR_FIELD_COMMENT)
-                       SET_STRING(msg, info21.comment,        "comment");
-               IFSET(SAMR_FIELD_LOGON_SCRIPT)
-                       SET_STRING(msg, info21.logon_script,   "scriptPath");
-               IFSET(SAMR_FIELD_PROFILE_PATH)
-                       SET_STRING(msg, info21.profile_path,   "profilePath");
                IFSET(SAMR_FIELD_HOME_DIRECTORY)
                        SET_STRING(msg, info21.home_directory, "homeDirectory");
                IFSET(SAMR_FIELD_HOME_DRIVE)
                        SET_STRING(msg, info21.home_drive,     "homeDrive");
+               IFSET(SAMR_FIELD_LOGON_SCRIPT)
+                       SET_STRING(msg, info21.logon_script,   "scriptPath");
+               IFSET(SAMR_FIELD_PROFILE_PATH)
+                       SET_STRING(msg, info21.profile_path,   "profilePath");
+               IFSET(SAMR_FIELD_DESCRIPTION)
+                       SET_STRING(msg, info21.description,    "description");
                IFSET(SAMR_FIELD_WORKSTATIONS)
                        SET_STRING(msg, info21.workstations,   "userWorkstations");
-               IFSET(SAMR_FIELD_LOGON_HOURS)
-                       SET_LHOURS(msg, info21.logon_hours,    "logonHours");
-               IFSET(SAMR_FIELD_ACCT_FLAGS)
-                       SET_AFLAGS(msg, info21.acct_flags,     "userAccountControl");
+               IFSET(SAMR_FIELD_COMMENT)
+                       SET_STRING(msg, info21.comment,        "comment");
                IFSET(SAMR_FIELD_PARAMETERS)   
                        SET_PARAMETERS(msg, info21.parameters, "userParameters");
+               IFSET(SAMR_FIELD_PRIMARY_GID)
+                       SET_UINT(msg, info21.primary_gid,      "primaryGroupID");
+               IFSET(SAMR_FIELD_ACCT_FLAGS)
+                       SET_AFLAGS(msg, info21.acct_flags,     "userAccountControl");
+               IFSET(SAMR_FIELD_LOGON_HOURS)
+                       SET_LHOURS(msg, info21.logon_hours,    "logonHours");
                IFSET(SAMR_FIELD_COUNTRY_CODE)
                        SET_UINT  (msg, info21.country_code,   "countryCode");
                IFSET(SAMR_FIELD_CODE_PAGE)
-                       SET_UINT  (msg, info21.code_page,      "codePage");     
+                       SET_UINT  (msg, info21.code_page,      "codePage");
 #undef IFSET
                break;
 
        case 23:
 #define IFSET(bit) if (bit & r->in.info->info23.info.fields_present)
                IFSET(SAMR_FIELD_ACCT_EXPIRY)
-                       SET_UINT64(msg, info23.info.acct_expiry,  "accountExpires");    
+                       SET_UINT64(msg, info23.info.acct_expiry,    "accountExpires");
                IFSET(SAMR_FIELD_ACCOUNT_NAME)         
-                       SET_STRING(msg, info23.info.account_name, "samAccountName");
-               IFSET(SAMR_FIELD_FULL_NAME)         
-                       SET_STRING(msg, info23.info.full_name,    "displayName");
-               IFSET(SAMR_FIELD_DESCRIPTION)  
-                       SET_STRING(msg, info23.info.description,  "description");
-               IFSET(SAMR_FIELD_COMMENT)      
-                       SET_STRING(msg, info23.info.comment,      "comment");
-               IFSET(SAMR_FIELD_LOGON_SCRIPT) 
-                       SET_STRING(msg, info23.info.logon_script, "scriptPath");
-               IFSET(SAMR_FIELD_PROFILE_PATH)      
-                       SET_STRING(msg, info23.info.profile_path, "profilePath");
-               IFSET(SAMR_FIELD_WORKSTATIONS)  
-                       SET_STRING(msg, info23.info.workstations, "userWorkstations");
-               IFSET(SAMR_FIELD_LOGON_HOURS)  
-                       SET_LHOURS(msg, info23.info.logon_hours,  "logonHours");
-               IFSET(SAMR_FIELD_ACCT_FLAGS)     
-                       SET_AFLAGS(msg, info23.info.acct_flags,   "userAccountControl");
-               IFSET(SAMR_FIELD_PARAMETERS)     
+                       SET_STRING(msg, info23.info.account_name,   "samAccountName");
+               IFSET(SAMR_FIELD_FULL_NAME)
+                       SET_STRING(msg, info23.info.full_name,      "displayName");
+               IFSET(SAMR_FIELD_HOME_DIRECTORY)
+                       SET_STRING(msg, info23.info.home_directory, "homeDirectory");
+               IFSET(SAMR_FIELD_HOME_DRIVE)
+                       SET_STRING(msg, info23.info.home_drive,     "homeDrive");
+               IFSET(SAMR_FIELD_LOGON_SCRIPT)
+                       SET_STRING(msg, info23.info.logon_script,   "scriptPath");
+               IFSET(SAMR_FIELD_PROFILE_PATH)
+                       SET_STRING(msg, info23.info.profile_path,   "profilePath");
+               IFSET(SAMR_FIELD_DESCRIPTION)
+                       SET_STRING(msg, info23.info.description,    "description");
+               IFSET(SAMR_FIELD_WORKSTATIONS)
+                       SET_STRING(msg, info23.info.workstations,   "userWorkstations");
+               IFSET(SAMR_FIELD_COMMENT)
+                       SET_STRING(msg, info23.info.comment,        "comment");
+               IFSET(SAMR_FIELD_PARAMETERS)
                        SET_PARAMETERS(msg, info23.info.parameters, "userParameters");
-               IFSET(SAMR_FIELD_COUNTRY_CODE) 
-                       SET_UINT  (msg, info23.info.country_code, "countryCode");
-               IFSET(SAMR_FIELD_CODE_PAGE)    
-                       SET_UINT  (msg, info23.info.code_page,    "codePage");
+               IFSET(SAMR_FIELD_PRIMARY_GID)
+                       SET_UINT(msg, info23.info.primary_gid,      "primaryGroupID");
+               IFSET(SAMR_FIELD_ACCT_FLAGS)
+                       SET_AFLAGS(msg, info23.info.acct_flags,     "userAccountControl");
+               IFSET(SAMR_FIELD_LOGON_HOURS)
+                       SET_LHOURS(msg, info23.info.logon_hours,    "logonHours");
+               IFSET(SAMR_FIELD_COUNTRY_CODE)
+                       SET_UINT  (msg, info23.info.country_code,   "countryCode");
+               IFSET(SAMR_FIELD_CODE_PAGE)
+                       SET_UINT  (msg, info23.info.code_page,      "codePage");
+
                IFSET(SAMR_FIELD_NT_PASSWORD_PRESENT) {
                        status = samr_set_password(dce_call,
                                                   a_state->sam_ctx,
@@ -3484,31 +3564,38 @@ static NTSTATUS dcesrv_samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALL
        case 25:
 #define IFSET(bit) if (bit & r->in.info->info25.info.fields_present)
                IFSET(SAMR_FIELD_ACCT_EXPIRY)
-                       SET_UINT64(msg, info25.info.acct_expiry,  "accountExpires");    
+                       SET_UINT64(msg, info25.info.acct_expiry,    "accountExpires");
                IFSET(SAMR_FIELD_ACCOUNT_NAME)         
-                       SET_STRING(msg, info25.info.account_name, "samAccountName");
-               IFSET(SAMR_FIELD_FULL_NAME)         
-                       SET_STRING(msg, info25.info.full_name,    "displayName");
-               IFSET(SAMR_FIELD_DESCRIPTION)  
-                       SET_STRING(msg, info25.info.description,  "description");
-               IFSET(SAMR_FIELD_COMMENT)      
-                       SET_STRING(msg, info25.info.comment,      "comment");
-               IFSET(SAMR_FIELD_LOGON_SCRIPT) 
-                       SET_STRING(msg, info25.info.logon_script, "scriptPath");
-               IFSET(SAMR_FIELD_PROFILE_PATH)      
-                       SET_STRING(msg, info25.info.profile_path, "profilePath");
-               IFSET(SAMR_FIELD_WORKSTATIONS)  
-                       SET_STRING(msg, info25.info.workstations, "userWorkstations");
-               IFSET(SAMR_FIELD_LOGON_HOURS)  
-                       SET_LHOURS(msg, info25.info.logon_hours,  "logonHours");
-               IFSET(SAMR_FIELD_ACCT_FLAGS)     
-                       SET_AFLAGS(msg, info25.info.acct_flags,   "userAccountControl");
-               IFSET(SAMR_FIELD_PARAMETERS)     
+                       SET_STRING(msg, info25.info.account_name,   "samAccountName");
+               IFSET(SAMR_FIELD_FULL_NAME)
+                       SET_STRING(msg, info25.info.full_name,      "displayName");
+               IFSET(SAMR_FIELD_HOME_DIRECTORY)
+                       SET_STRING(msg, info25.info.home_directory, "homeDirectory");
+               IFSET(SAMR_FIELD_HOME_DRIVE)
+                       SET_STRING(msg, info25.info.home_drive,     "homeDrive");
+               IFSET(SAMR_FIELD_LOGON_SCRIPT)
+                       SET_STRING(msg, info25.info.logon_script,   "scriptPath");
+               IFSET(SAMR_FIELD_PROFILE_PATH)
+                       SET_STRING(msg, info25.info.profile_path,   "profilePath");
+               IFSET(SAMR_FIELD_DESCRIPTION)
+                       SET_STRING(msg, info25.info.description,    "description");
+               IFSET(SAMR_FIELD_WORKSTATIONS)
+                       SET_STRING(msg, info25.info.workstations,   "userWorkstations");
+               IFSET(SAMR_FIELD_COMMENT)
+                       SET_STRING(msg, info25.info.comment,        "comment");
+               IFSET(SAMR_FIELD_PARAMETERS)
                        SET_PARAMETERS(msg, info25.info.parameters, "userParameters");
-               IFSET(SAMR_FIELD_COUNTRY_CODE) 
-                       SET_UINT  (msg, info25.info.country_code, "countryCode");
-               IFSET(SAMR_FIELD_CODE_PAGE)    
-                       SET_UINT  (msg, info25.info.code_page,    "codePage");
+               IFSET(SAMR_FIELD_PRIMARY_GID)
+                       SET_UINT(msg, info25.info.primary_gid,      "primaryGroupID");
+               IFSET(SAMR_FIELD_ACCT_FLAGS)
+                       SET_AFLAGS(msg, info25.info.acct_flags,     "userAccountControl");
+               IFSET(SAMR_FIELD_LOGON_HOURS)
+                       SET_LHOURS(msg, info25.info.logon_hours,    "logonHours");
+               IFSET(SAMR_FIELD_COUNTRY_CODE)
+                       SET_UINT  (msg, info25.info.country_code,   "countryCode");
+               IFSET(SAMR_FIELD_CODE_PAGE)
+                       SET_UINT  (msg, info25.info.code_page,      "codePage");
+
                IFSET(SAMR_FIELD_NT_PASSWORD_PRESENT) {
                        status = samr_set_password_ex(dce_call,
                                                      a_state->sam_ctx,
@@ -3548,14 +3635,16 @@ static NTSTATUS dcesrv_samr_SetUserInfo(struct dcesrv_call_state *dce_call, TALL
        }
 
        /* modify the samdb record */
-       ret = ldb_modify(a_state->sam_ctx, msg);
-       if (ret != 0) {
-               DEBUG(1,("Failed to modify record %s: %s\n",
-                        ldb_dn_get_linearized(a_state->account_dn),
-                        ldb_errstring(a_state->sam_ctx)));
-
-               /* we really need samdb.c to return NTSTATUS */
-               return NT_STATUS_UNSUCCESSFUL;
+       if (msg->num_elements > 0) {
+               ret = ldb_modify(a_state->sam_ctx, msg);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(1,("Failed to modify record %s: %s\n",
+                                ldb_dn_get_linearized(a_state->account_dn),
+                                ldb_errstring(a_state->sam_ctx)));
+
+                       /* we really need samdb.c to return NTSTATUS */
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
        }
 
        return NT_STATUS_OK;
@@ -3574,14 +3663,15 @@ static NTSTATUS dcesrv_samr_GetGroupsForUser(struct dcesrv_call_state *dce_call,
        struct ldb_message **res;
        const char * const attrs[2] = { "objectSid", NULL };
        struct samr_RidWithAttributeArray *array;
-       int count;
+       int i, count;
 
        DCESRV_PULL_HANDLE(h, r->in.user_handle, SAMR_HANDLE_USER);
 
        a_state = h->data;
        d_state = a_state->domain_state;
 
-       count = samdb_search_domain(a_state->sam_ctx, mem_ctx, d_state->domain_dn, &res,
+       count = samdb_search_domain(a_state->sam_ctx, mem_ctx,
+                                   d_state->domain_dn, &res,
                                    attrs, d_state->domain_sid,
                                    "(&(member=%s)(grouptype=%d)(objectclass=group))",
                                    ldb_dn_get_linearized(a_state->account_dn),
@@ -3596,29 +3686,34 @@ static NTSTATUS dcesrv_samr_GetGroupsForUser(struct dcesrv_call_state *dce_call,
        array->count = 0;
        array->rids = NULL;
 
-       if (count > 0) {
-               int i;
-               array->rids = talloc_array(mem_ctx, struct samr_RidWithAttribute,
-                                           count);
-
-               if (array->rids == NULL)
-                       return NT_STATUS_NO_MEMORY;
+       array->rids = talloc_array(mem_ctx, struct samr_RidWithAttribute,
+                                           count + 1);
+       if (array->rids == NULL)
+               return NT_STATUS_NO_MEMORY;
 
-               for (i=0; i<count; i++) {
-                       struct dom_sid *group_sid;
+       /* Adds the primary group */
+       array->rids[0].rid = samdb_search_uint(a_state->sam_ctx, mem_ctx,
+                                              ~0, a_state->account_dn,
+                                              "primaryGroupID", NULL);
+       array->rids[0].attributes = SE_GROUP_MANDATORY
+                       | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED;
+       array->count += 1;
 
-                       group_sid = samdb_result_dom_sid(mem_ctx, res[i],
-                                                        "objectSid");
-                       if (group_sid == NULL) {
-                               DEBUG(0, ("Couldn't find objectSid attrib\n"));
-                               continue;
-                       }
+       /* Adds the additional groups */
+       for (i = 0; i < count; i++) {
+               struct dom_sid *group_sid;
 
-                       array->rids[array->count].rid =
-                               group_sid->sub_auths[group_sid->num_auths-1];
-                       array->rids[array->count].attributes = SE_GROUP_MANDATORY | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED;
-                       array->count += 1;
+               group_sid = samdb_result_dom_sid(mem_ctx, res[i], "objectSid");
+               if (group_sid == NULL) {
+                       DEBUG(0, ("Couldn't find objectSid attrib\n"));
+                       continue;
                }
+
+               array->rids[i + 1].rid =
+                       group_sid->sub_auths[group_sid->num_auths-1];
+               array->rids[i + 1].attributes = SE_GROUP_MANDATORY
+                       | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED;
+               array->count += 1;
        }
 
        *r->out.rids = array;
@@ -3637,12 +3732,13 @@ static NTSTATUS dcesrv_samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call,
        struct samr_domain_state *d_state;
        struct ldb_message **res;
        int ldb_cnt, count, i;
-       const char * const attrs[] = { "objectSid", "sAMAccountName", "displayName",
-                                      "description", "userAccountControl", "pwdLastSet", NULL };
+       const char * const attrs[] = { "objectSid", "sAMAccountName",
+               "displayName", "description", "userAccountControl",
+               "pwdLastSet", NULL };
        struct samr_DispEntryFull *entriesFull = NULL;
        struct samr_DispEntryFullGroup *entriesFullGroup = NULL;
        struct samr_DispEntryAscii *entriesAscii = NULL;
-       struct samr_DispEntryGeneral * entriesGeneral = NULL;
+       struct samr_DispEntryGeneral *entriesGeneral = NULL;
        const char *filter;
 
        DCESRV_PULL_HANDLE(h, r->in.domain_handle, SAMR_HANDLE_DOMAIN);
@@ -3686,8 +3782,8 @@ static NTSTATUS dcesrv_samr_QueryDisplayInfo(struct dcesrv_call_state *dce_call,
        switch (r->in.level) {
        case 1:
                entriesGeneral = talloc_array(mem_ctx,
-                                               struct samr_DispEntryGeneral,
-                                               ldb_cnt);
+                                            struct samr_DispEntryGeneral,
+                                            ldb_cnt);
                break;
        case 2:
                entriesFull = talloc_array(mem_ctx,
@@ -3887,12 +3983,12 @@ static NTSTATUS dcesrv_samr_GetUserPwInfo(struct dcesrv_call_state *dce_call, TA
 
        a_state = h->data;
 
-       r->out.info->min_password_length = samdb_search_uint(a_state->sam_ctx, mem_ctx, 0,
-                                                            a_state->domain_state->domain_dn, "minPwdLength",
-                                                            NULL);
-       r->out.info->password_properties = samdb_search_uint(a_state->sam_ctx, mem_ctx, 0,
-                                                            a_state->account_dn,
-                                                            "pwdProperties", NULL);
+       r->out.info->min_password_length = samdb_search_uint(a_state->sam_ctx,
+               mem_ctx, 0, a_state->domain_state->domain_dn, "minPwdLength",
+               NULL);
+       r->out.info->password_properties = samdb_search_uint(a_state->sam_ctx,
+               mem_ctx, 0, a_state->account_dn, "pwdProperties", NULL);
+
        return NT_STATUS_OK;
 }
 
@@ -4104,7 +4200,9 @@ static NTSTATUS dcesrv_samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TAL
 
        ZERO_STRUCTP(r->out.info);
 
-       sam_ctx = samdb_connect(mem_ctx, dce_call->event_ctx, dce_call->conn->dce_ctx->lp_ctx, dce_call->conn->auth_state.session_info); 
+       sam_ctx = samdb_connect(mem_ctx, dce_call->event_ctx,
+                                        dce_call->conn->dce_ctx->lp_ctx,
+                                        dce_call->conn->auth_state.session_info);
        if (sam_ctx == NULL) {
                return NT_STATUS_INVALID_SYSTEM_SERVICE;
        }
@@ -4113,19 +4211,25 @@ static NTSTATUS dcesrv_samr_GetDomPwInfo(struct dcesrv_call_state *dce_call, TAL
        ret = gendb_search_dn(sam_ctx, 
                           mem_ctx, NULL, &msgs, attrs);
        if (ret <= 0) {
+               talloc_free(sam_ctx);
+
                return NT_STATUS_NO_SUCH_DOMAIN;
        }
        if (ret > 1) {
                talloc_free(msgs);
+               talloc_free(sam_ctx);
+
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       r->out.info->min_password_length = samdb_result_uint(msgs[0], "minPwdLength", 0);
-       r->out.info->password_properties = samdb_result_uint(msgs[0], "pwdProperties", 1);
+       r->out.info->min_password_length = samdb_result_uint(msgs[0],
+               "minPwdLength", 0);
+       r->out.info->password_properties = samdb_result_uint(msgs[0],
+               "pwdProperties", 1);
 
        talloc_free(msgs);
+       talloc_unlink(mem_ctx, sam_ctx);
 
-       talloc_free(sam_ctx);
        return NT_STATUS_OK;
 }
 
@@ -4273,12 +4377,57 @@ static NTSTATUS dcesrv_samr_SetDsrmPassword(struct dcesrv_call_state *dce_call,
 
 
 /* 
-  samr_ValidatePassword 
+  samr_ValidatePassword
+
+  For now the call checks the password complexity (if active) and the minimum
+  password length on level 2 and 3. Level 1 is ignored for now.
 */
-static NTSTATUS dcesrv_samr_ValidatePassword(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx,
-                                     struct samr_ValidatePassword *r)
+static NTSTATUS dcesrv_samr_ValidatePassword(struct dcesrv_call_state *dce_call,
+                                            TALLOC_CTX *mem_ctx,
+                                            struct samr_ValidatePassword *r)
 {
-       DCESRV_FAULT(DCERPC_FAULT_OP_RNG_ERROR);
+       struct samr_GetDomPwInfo r2;
+       struct samr_PwInfo pwInfo;
+       DATA_BLOB password;
+       enum samr_ValidationStatus res;
+       NTSTATUS status;
+
+       (*r->out.rep) = talloc_zero(mem_ctx, union samr_ValidatePasswordRep);
+
+       r2.in.domain_name = NULL;
+       r2.out.info = &pwInfo;
+       status = dcesrv_samr_GetDomPwInfo(dce_call, mem_ctx, &r2);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       switch (r->in.level) {
+       case NetValidateAuthentication:
+               /* we don't support this yet */
+               return NT_STATUS_NOT_SUPPORTED;
+       break;
+       case NetValidatePasswordChange:
+               password = data_blob_const(r->in.req->req2.password.string,
+                                          r->in.req->req2.password.length);
+               res = samdb_check_password(&password,
+                                          pwInfo.password_properties,
+                                          pwInfo.min_password_length);
+               (*r->out.rep)->ctr2.status = res;
+       break;
+       case NetValidatePasswordReset:
+               password = data_blob_const(r->in.req->req3.password.string,
+                                          r->in.req->req3.password.length);
+               res = samdb_check_password(&password,
+                                          pwInfo.password_properties,
+                                          pwInfo.min_password_length);
+               (*r->out.rep)->ctr3.status = res;
+       break;
+       default:
+               return NT_STATUS_INVALID_INFO_CLASS;
+       break;
+       }
+
+       return NT_STATUS_OK;
 }