s4-dsdb: change samdb_replace() to dsdb_replace() and allow for dsdb_flags
[ira/wip.git] / source4 / libnet / libnet_samsync_ldb.c
index 89123932319aaae2a5c36c4369227dcd9dc2d9d4..e9db4a909cb97dfe15940efc13eea092a3c9fe4d 100644 (file)
@@ -9,7 +9,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 
 #include "includes.h"
 #include "libnet/libnet.h"
-#include "libcli/ldap/ldap.h"
+#include "libcli/ldap/ldap_ndr.h"
 #include "dsdb/samdb/samdb.h"
 #include "auth/auth.h"
+#include "../lib/util/util_ldb.h"
 #include "librpc/gen_ndr/ndr_misc.h"
-#include "db_wrap.h"
+#include "ldb_wrap.h"
 #include "libcli/security/security.h"
 #include "librpc/rpc/dcerpc.h"
+#include "param/param.h"
 
 struct samsync_ldb_secret {
        struct samsync_ldb_secret *prev, *next;
@@ -51,7 +52,7 @@ struct samsync_ldb_state {
        const struct libnet_SamSync_state *samsync_state;
 
        struct dom_sid *dom_sid[3];
-       struct ldb_context *sam_ldb, *remote_ldb;
+       struct ldb_context *sam_ldb, *remote_ldb, *pdb;
        struct ldb_dn *base_dn[3];
        struct samsync_ldb_secret *secrets;
        struct samsync_ldb_trusted_domain *trusted_domains;
@@ -79,7 +80,7 @@ static NTSTATUS samsync_ldb_add_foreignSecurityPrincipal(TALLOC_CTX *mem_ctx,
                *error_string = talloc_asprintf(mem_ctx, 
                                                "Failed to find DN for "
                                                "ForeignSecurityPrincipal container under %s",
-                                               ldb_dn_linearize(mem_ctx, state->base_dn[SAM_DATABASE_DOMAIN]));
+                                               ldb_dn_get_linearized(state->base_dn[SAM_DATABASE_DOMAIN]));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
        
@@ -89,9 +90,9 @@ static NTSTATUS samsync_ldb_add_foreignSecurityPrincipal(TALLOC_CTX *mem_ctx,
        }
 
        /* add core elements to the ldb_message for the alias */
-       msg->dn = ldb_dn_build_child(mem_ctx, "CN", sidstr, basedn);
-       if (msg->dn == NULL)
-               return NT_STATUS_NO_MEMORY;
+       msg->dn = basedn;
+       if ( ! ldb_dn_add_child_fmt(msg->dn, "CN=%s", sidstr))
+               return NT_STATUS_UNSUCCESSFUL;
        
        samdb_msg_add_string(state->sam_ldb, mem_ctx, msg,
                             "objectClass",
@@ -100,11 +101,11 @@ static NTSTATUS samsync_ldb_add_foreignSecurityPrincipal(TALLOC_CTX *mem_ctx,
        *fsp_dn = msg->dn;
 
        /* create the alias */
-       ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+       ret = ldb_add(state->sam_ldb, msg);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to create foreignSecurityPrincipal "
                                                "record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn),
+                                               ldb_dn_get_linearized(msg->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -128,11 +129,14 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
        }
 
        if (database == SAM_DATABASE_DOMAIN) {
+               struct ldb_dn *partitions_basedn;
                const char *domain_attrs[] =  {"nETBIOSName", "nCName", NULL};
                struct ldb_message **msgs_domain;
                int ret_domain;
 
-               ret_domain = gendb_search(state->sam_ldb, mem_ctx, NULL, &msgs_domain, domain_attrs,
+               partitions_basedn = samdb_partitions_dn(state->sam_ldb, mem_ctx);
+
+               ret_domain = gendb_search(state->sam_ldb, mem_ctx, partitions_basedn, &msgs_domain, domain_attrs,
                                          "(&(&(nETBIOSName=%s)(objectclass=crossRef))(ncName=*))", 
                                          domain_name);
                if (ret_domain == -1) {
@@ -146,7 +150,7 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
                        return NT_STATUS_NO_SUCH_DOMAIN;                
                }
 
-               state->base_dn[database] = samdb_result_dn(state, msgs_domain[0], "nCName", NULL);
+               state->base_dn[database] = samdb_result_dn(state->sam_ldb, state, msgs_domain[0], "nCName", NULL);
 
                if (state->dom_sid[database]) {
                        /* Update the domain sid with the incoming
@@ -162,23 +166,25 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
                }
 
                if (state->samsync_state->domain_guid) {
-                       NTSTATUS nt_status;
                        struct ldb_val v;
-                       nt_status = ndr_push_struct_blob(&v, msg, state->samsync_state->domain_guid,
-                                                        (ndr_push_flags_fn_t)ndr_push_GUID);
-                       if (!NT_STATUS_IS_OK(nt_status)) {
+                       NTSTATUS status;
+                       status = GUID_to_ndr_blob(state->samsync_state->domain_guid, msg, &v);
+                       if (!NT_STATUS_IS_OK(status)) {
                                *error_string = talloc_asprintf(mem_ctx, "ndr_push of domain GUID failed!");
-                               return nt_status;
+                               return status;
                        }
                        
-                       ldb_msg_add_value(msg, "objectGUID", &v);
+                       ldb_msg_add_value(msg, "objectGUID", &v, NULL);
                }
        } else if (database == SAM_DATABASE_BUILTIN) {
                /* work out the builtin_dn - useful for so many calls its worth
                   fetching here */
                const char *dnstring = samdb_search_string(state->sam_ldb, mem_ctx, NULL,
                                                           "distinguishedName", "objectClass=builtinDomain");
-               state->base_dn[database] = ldb_dn_explode(state, dnstring);
+               state->base_dn[database] = ldb_dn_new(state, state->sam_ldb, dnstring);
+               if ( ! ldb_dn_validate(state->base_dn[database])) {
+                       return NT_STATUS_INTERNAL_ERROR;
+               }
        } else {
                /* PRIVs DB */
                return NT_STATUS_INVALID_PARAMETER;
@@ -190,7 +196,7 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
        }
 
        samdb_msg_add_string(state->sam_ldb, mem_ctx, 
-                            msg, "oEMInformation", domain->comment.string);
+                            msg, "oEMInformation", domain->oem_information.string);
 
        samdb_msg_add_int64(state->sam_ldb, mem_ctx, 
                            msg, "forceLogoff", domain->force_logoff_time);
@@ -216,7 +222,7 @@ static NTSTATUS samsync_ldb_handle_domain(TALLOC_CTX *mem_ctx,
 
        /* TODO: Account lockout, password properties */
        
-       ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+       ret = dsdb_replace(state->sam_ldb, msg, 0);
 
        if (ret) {
                return NT_STATUS_INTERNAL_ERROR;
@@ -241,7 +247,7 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
        struct ldb_message **remote_msgs = NULL;
        int ret, i;
        uint32_t acb;
-       BOOL add = False;
+       bool add = false;
        const char *attrs[] = { NULL };
        /* we may change this to a global search, then fill in only the things not in ldap later */
        const char *remote_attrs[] = { "userPrincipalName", "servicePrincipalName", 
@@ -269,7 +275,7 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               add = True;
+               add = true;
        } else if (ret > 1) {
                *error_string = talloc_asprintf(mem_ctx, "More than one user with SID: %s in local LDB", 
                                                dom_sid_string(mem_ctx, user_sid));
@@ -292,7 +298,7 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                } else if (ret == 0) {
                        *error_string = talloc_asprintf(mem_ctx, "User exists in samsync but not in remote LDAP domain! (base: %s, SID: %s)", 
-                                                       ldb_dn_linearize(mem_ctx, state->base_dn[database]),
+                                                       ldb_dn_get_linearized(state->base_dn[database]),
                                                        dom_sid_string(mem_ctx, user_sid));
                        return NT_STATUS_NO_SUCH_USER;
                } else if (ret > 1) {
@@ -354,27 +360,33 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_MEMORY; 
        } 
        
-       /* Passwords.  Ensure there is no plaintext stored against
-        * this entry, as we only have hashes */
-       samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
-                            "sambaPassword"); 
+       if (!add) {
+               /* Passwords.  Ensure there is no plaintext stored against
+                * this entry, as we only have hashes */
+               samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
+                                    "userPassword"); 
+       }
        if (user->lm_password_present) {
                samdb_msg_add_hash(state->sam_ldb, mem_ctx, msg,  
-                                  "lmPwdHash", &user->lmpassword);
-       } else {
+                                  "dBCSPwd", &user->lmpassword);
+       } else if (!add) {
                samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
-                                    "lmPwdHash"); 
+                                    "dBCSPwd"); 
        }
        if (user->nt_password_present) {
                samdb_msg_add_hash(state->sam_ldb, mem_ctx, msg,  
-                                  "ntPwdHash", &user->ntpassword);
-       } else {
+                                  "unicodePwd", &user->ntpassword);
+       } else if (!add) {
                samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
-                                    "ntPwdHash"); 
+                                    "unicodePwd"); 
        }
            
        ADD_OR_DEL(string, "comment", comment.string);
-       ADD_OR_DEL(string, "userParameters", parameters.string);
+
+       if (samdb_msg_add_parameters(state->sam_ldb, mem_ctx, msg, "userParameters", &user->parameters) != 0) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
        ADD_OR_DEL(uint, "countryCode", country_code);
        ADD_OR_DEL(uint, "codePage", code_page);
 
@@ -413,32 +425,39 @@ static NTSTATUS samsync_ldb_handle_user(TALLOC_CTX *mem_ctx,
                samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, 
                                     "objectClass", obj_class);
                if (!msg->dn) {
-                       msg->dn = ldb_dn_string_compose(mem_ctx, state->base_dn[database],
-                                                       "CN=%s, CN=%s", cn_name, container);
+                       msg->dn = ldb_dn_copy(mem_ctx, state->base_dn[database]);
+                       ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=%s", cn_name, container);
                        if (!msg->dn) {
                                return NT_STATUS_NO_MEMORY;             
                        }
                }
 
-               ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+               ret = ldb_add(state->sam_ldb, msg);
                if (ret != 0) {
                        struct ldb_dn *first_try_dn = msg->dn;
                        /* Try again with the default DN */
-                       msg->dn = talloc_steal(msg, msgs[0]->dn);
-                       ret = samdb_add(state->sam_ldb, mem_ctx, msg);
-                       if (ret != 0) {
-                               *error_string = talloc_asprintf(mem_ctx, "Failed to create user record.  Tried both %s and %s: %s",
-                                                               ldb_dn_linearize(mem_ctx, first_try_dn),
-                                                               ldb_dn_linearize(mem_ctx, msg->dn),
+                       if (!remote_msgs) {
+                               *error_string = talloc_asprintf(mem_ctx, "Failed to create user record.  Tried %s: %s",
+                                                               ldb_dn_get_linearized(first_try_dn),
                                                                ldb_errstring(state->sam_ldb));
                                return NT_STATUS_INTERNAL_DB_CORRUPTION;
+                       } else {
+                               msg->dn = talloc_steal(msg, remote_msgs[0]->dn);
+                               ret = ldb_add(state->sam_ldb, msg);
+                               if (ret != 0) {
+                                       *error_string = talloc_asprintf(mem_ctx, "Failed to create user record.  Tried both %s and %s: %s",
+                                                                       ldb_dn_get_linearized(first_try_dn),
+                                                                       ldb_dn_get_linearized(msg->dn),
+                                                                       ldb_errstring(state->sam_ldb));
+                                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+                               }
                        }
                }
        } else {
-               ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+               ret = dsdb_replace(state->sam_ldb, msg, 0);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to modify user record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -477,10 +496,10 @@ static NTSTATUS samsync_ldb_delete_user(TALLOC_CTX *mem_ctx,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       ret = samdb_delete(state->sam_ldb, mem_ctx, msgs[0]->dn);
+       ret = ldb_delete(state->sam_ldb, msgs[0]->dn);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to delete user record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msgs[0]->dn),
+                                               ldb_dn_get_linearized(msgs[0]->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -502,7 +521,7 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
        struct ldb_message *msg;
        struct ldb_message **msgs;
        int ret;
-       BOOL add = False;
+       bool add = false;
        const char *attrs[] = { NULL };
 
        msg = ldb_msg_new(mem_ctx);
@@ -519,7 +538,7 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
                *error_string = talloc_asprintf(mem_ctx, "gendb_search failed: %s", ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               add = True;
+               add = true;
        } else if (ret > 1) {
                *error_string = talloc_asprintf(mem_ctx, "More than one group/alias with SID: %s", 
                                                dom_sid_string(mem_ctx, 
@@ -560,24 +579,24 @@ static NTSTATUS samsync_ldb_handle_group(TALLOC_CTX *mem_ctx,
        if (add) {
                samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, 
                                     "objectClass", obj_class);
-               msg->dn = ldb_dn_string_compose(mem_ctx, state->base_dn[database],
-                                               "CN=%s, CN=%s", cn_name, container);
+               msg->dn = ldb_dn_copy(mem_ctx, state->base_dn[database]);
+               ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=%s", cn_name, container);
                if (!msg->dn) {
                        return NT_STATUS_NO_MEMORY;             
                }
 
-               ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+               ret = ldb_add(state->sam_ldb, msg);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to create group record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
        } else {
-               ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+               ret = dsdb_replace(state->sam_ldb, msg, 0);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to modify group record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -616,10 +635,10 @@ static NTSTATUS samsync_ldb_delete_group(TALLOC_CTX *mem_ctx,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
        
-       ret = samdb_delete(state->sam_ldb, mem_ctx, msgs[0]->dn);
+       ret = ldb_delete(state->sam_ldb, msgs[0]->dn);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to delete group record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msgs[0]->dn),
+                                               ldb_dn_get_linearized(msgs[0]->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -683,16 +702,16 @@ static NTSTATUS samsync_ldb_handle_group_member(TALLOC_CTX *mem_ctx,
                } else if (ret > 1) {
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                } else {
-                       samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_linearize(mem_ctx, msgs[0]->dn));
+                       samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_alloc_linearized(mem_ctx, msgs[0]->dn));
                }
                
                talloc_free(msgs);
        }
        
-       ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+       ret = dsdb_replace(state->sam_ldb, msg, 0);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify group record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn),
+                                               ldb_dn_get_linearized(msg->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -714,7 +733,7 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
        struct ldb_message *msg;
        struct ldb_message **msgs;
        int ret;
-       BOOL add = False;
+       bool add = false;
        const char *attrs[] = { NULL };
 
        msg = ldb_msg_new(mem_ctx);
@@ -731,7 +750,7 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
                *error_string = talloc_asprintf(mem_ctx, "gendb_search failed: %s", ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        } else if (ret == 0) {
-               add = True;
+               add = true;
        } else if (ret > 1) {
                *error_string = talloc_asprintf(mem_ctx, "More than one group/alias with SID: %s", 
                                                dom_sid_string(mem_ctx, 
@@ -774,24 +793,24 @@ static NTSTATUS samsync_ldb_handle_alias(TALLOC_CTX *mem_ctx,
        if (add) {
                samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, 
                                     "objectClass", obj_class);
-               msg->dn = ldb_dn_string_compose(mem_ctx, state->base_dn[database],
-                                               "CN=%s, CN=%s", cn_name, container);
+               msg->dn = ldb_dn_copy(mem_ctx, state->base_dn[database]);
+               ldb_dn_add_child_fmt(msg->dn, "CN=%s,CN=%s", cn_name, container);
                if (!msg->dn) {
                        return NT_STATUS_NO_MEMORY;             
                }
 
-               ret = samdb_add(state->sam_ldb, mem_ctx, msg);
+               ret = ldb_add(state->sam_ldb, msg);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to create alias record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
        } else {
-               ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+               ret = dsdb_replace(state->sam_ldb, msg, 0);
                if (ret != 0) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to modify alias record %s: %s",
-                                                       ldb_dn_linearize(mem_ctx, msg->dn),
+                                                       ldb_dn_get_linearized(msg->dn),
                                                        ldb_errstring(state->sam_ldb));
                        return NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -825,10 +844,10 @@ static NTSTATUS samsync_ldb_delete_alias(TALLOC_CTX *mem_ctx,
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
-       ret = samdb_delete(state->sam_ldb, mem_ctx, msgs[0]->dn);
+       ret = ldb_delete(state->sam_ldb, msgs[0]->dn);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to delete alias record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msgs[0]->dn),
+                                               ldb_dn_get_linearized(msgs[0]->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -902,15 +921,15 @@ static NTSTATUS samsync_ldb_handle_alias_member(TALLOC_CTX *mem_ctx,
                } else {
                        alias_member_dn = msgs[0]->dn;
                }
-               samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_linearize(mem_ctx, alias_member_dn));
+               samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "member", ldb_dn_alloc_linearized(mem_ctx, alias_member_dn));
        
                talloc_free(msgs);
        }
 
-       ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+       ret = dsdb_replace(state->sam_ldb, msg, 0);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify group record %s: %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn),
+                                               ldb_dn_get_linearized(msg->dn),
                                                ldb_errstring(state->sam_ldb));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
@@ -928,53 +947,42 @@ static NTSTATUS samsync_ldb_handle_account(TALLOC_CTX *mem_ctx,
        struct netr_DELTA_ACCOUNT *account = delta->delta_union.account;
 
        struct ldb_message *msg;
-       struct ldb_message **msgs;
-       struct ldb_dn *privilege_dn;
        int ret;
-       const char *attrs[] = { NULL };
        int i;
+       char *dnstr, *sidstr;
 
        msg = ldb_msg_new(mem_ctx);
        if (msg == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       /* search for the account, by sid, in the top basedn */
-       ret = gendb_search(state->sam_ldb, mem_ctx, state->base_dn[SAM_DATABASE_DOMAIN], &msgs, attrs,
-                          "(objectSid=%s)", ldap_encode_ndr_dom_sid(mem_ctx, sid)); 
+       sidstr = dom_sid_string(msg, sid);
+       NT_STATUS_HAVE_NO_MEMORY_AND_FREE(sidstr, msg);
 
-       if (ret == -1) {
-               *error_string = talloc_asprintf(mem_ctx, "gendb_search failed: %s", ldb_errstring(state->sam_ldb));
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
-       } else if (ret == 0) {
-               NTSTATUS nt_status;
-               nt_status = samsync_ldb_add_foreignSecurityPrincipal(mem_ctx, state,
-                                                                    sid,
-                                                                    &privilege_dn,
-                                                                    error_string);
-               privilege_dn = talloc_steal(msg, privilege_dn);
-               if (!NT_STATUS_IS_OK(nt_status)) {
-                       return nt_status;
-               }
-       } else if (ret > 1) {
-               *error_string = talloc_asprintf(mem_ctx, "More than one account with SID: %s", 
-                                               dom_sid_string(mem_ctx, sid));
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
-       } else {
-               privilege_dn = talloc_steal(msg, msgs[0]->dn);
-       }
+       dnstr = talloc_asprintf(msg, "sid=%s", sidstr);
+       NT_STATUS_HAVE_NO_MEMORY_AND_FREE(dnstr, msg);
 
-       msg->dn = privilege_dn;
+       msg->dn = ldb_dn_new(msg, state->pdb, dnstr);
+       NT_STATUS_HAVE_NO_MEMORY_AND_FREE(msg->dn, msg);
 
        for (i=0; i< account->privilege_entries; i++) {
-               samdb_msg_add_string(state->sam_ldb, mem_ctx, msg, "privilege",
+               samdb_msg_add_string(state->pdb, mem_ctx, msg, "privilege",
                                     account->privilege_name[i].string);
        }
 
-       ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+       ret = dsdb_replace(state->pdb, msg, 0);
+       if (ret == LDB_ERR_NO_SUCH_OBJECT) {
+               if (samdb_msg_add_dom_sid(state->pdb, msg, msg, "objectSid", sid) != LDB_SUCCESS) {
+                       talloc_free(msg);
+                       return NT_STATUS_NO_MEMORY;
+               }
+               samdb_msg_add_string(state->pdb, msg, msg, "comment", "added via samsync");
+               ret = ldb_add(state->pdb, msg);         
+       }
+
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify privilege record %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn));
+                                               ldb_dn_get_linearized(msg->dn));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -1018,12 +1026,12 @@ static NTSTATUS samsync_ldb_delete_account(TALLOC_CTX *mem_ctx,
        }
 
        samdb_msg_add_delete(state->sam_ldb, mem_ctx, msg,  
-                            "privilage"); 
+                            "privilege");
 
-       ret = samdb_replace(state->sam_ldb, mem_ctx, msg);
+       ret = dsdb_replace(state->sam_ldb, msg, 0);
        if (ret != 0) {
                *error_string = talloc_asprintf(mem_ctx, "Failed to modify privilege record %s",
-                                               ldb_dn_linearize(mem_ctx, msg->dn));
+                                               ldb_dn_get_linearized(msg->dn));
                return NT_STATUS_INTERNAL_DB_CORRUPTION;
        }
 
@@ -1031,13 +1039,13 @@ static NTSTATUS samsync_ldb_delete_account(TALLOC_CTX *mem_ctx,
 }
 
 static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,             
-                                     void *private,                    
+                                     void *private_data,
                                      enum netr_SamDatabaseID database,
                                      struct netr_DELTA_ENUM *delta,
                                      char **error_string)
 {
        NTSTATUS nt_status = NT_STATUS_OK;
-       struct samsync_ldb_state *state = talloc_get_type(private, struct samsync_ldb_state);
+       struct samsync_ldb_state *state = talloc_get_type(private_data, struct samsync_ldb_state);
 
        *error_string = NULL;
        switch (delta->delta_type) {
@@ -1151,11 +1159,11 @@ static NTSTATUS libnet_samsync_ldb_fn(TALLOC_CTX *mem_ctx,
 }
 
 static NTSTATUS libnet_samsync_ldb_init(TALLOC_CTX *mem_ctx,           
-                                       void *private,
+                                       void *private_data,
                                        struct libnet_SamSync_state *samsync_state,
                                        char **error_string)
 {
-       struct samsync_ldb_state *state = talloc_get_type(private, struct samsync_ldb_state);
+       struct samsync_ldb_state *state = talloc_get_type(private_data, struct samsync_ldb_state);
        const char *server = dcerpc_server_name(samsync_state->netlogon_pipe);
        char *ldap_url;
 
@@ -1176,9 +1184,12 @@ static NTSTATUS libnet_samsync_ldb_init(TALLOC_CTX *mem_ctx,
                }
                ldap_url = talloc_asprintf(state, "ldap://%s", server);
                
-               state->remote_ldb = ldb_wrap_connect(mem_ctx, ldap_url, 
+               state->remote_ldb = ldb_wrap_connect(mem_ctx, 
+                                                    state->samsync_state->machine_net_ctx->event_ctx,
+                                                    state->samsync_state->machine_net_ctx->lp_ctx, 
+                                                    ldap_url, 
                                                     NULL, state->samsync_state->machine_net_ctx->cred,
-                                                    0, NULL);
+                                                    0);
                if (!state->remote_ldb) {
                        *error_string = talloc_asprintf(mem_ctx, "Failed to connect to remote LDAP server at %s (used to extract additional data in SamSync replication)", ldap_url);
                        return NT_STATUS_NO_LOGON_SERVERS;
@@ -1202,8 +1213,20 @@ NTSTATUS libnet_samsync_ldb(struct libnet_context *ctx, TALLOC_CTX *mem_ctx, str
        state->secrets         = NULL;
        state->trusted_domains = NULL;
 
-       state->sam_ldb         = ldb_wrap_connect(mem_ctx, lp_sam_url(), r->in.session_info,
-                                                 ctx->cred, 0, NULL);
+       state->sam_ldb         = samdb_connect(mem_ctx, 
+                                              ctx->event_ctx,
+                                              ctx->lp_ctx, 
+                                              r->in.session_info);
+       if (!state->sam_ldb) {
+               return NT_STATUS_INTERNAL_DB_ERROR;
+       }
+
+       state->pdb             = privilege_connect(mem_ctx, 
+                                                  ctx->event_ctx,
+                                                  ctx->lp_ctx);
+       if (!state->pdb) {
+               return NT_STATUS_INTERNAL_DB_ERROR;
+       }
 
        r2.out.error_string    = NULL;
        r2.in.binding_string   = r->in.binding_string;