Merge commit 'release-4-0-0alpha15' into master4-tmp
[ira/wip.git] / source4 / libnet / libnet_become_dc.c
index b7205dca594ff1a9218dc36c8dd192f95bb999eb..4d845ca1f088a837f5913692a0171178cf195b6d 100644 (file)
@@ -21,9 +21,9 @@
 #include "libnet/libnet.h"
 #include "libcli/composite/composite.h"
 #include "libcli/cldap/cldap.h"
-#include "lib/ldb/include/ldb.h"
-#include "lib/ldb/include/ldb_errors.h"
-#include "lib/ldb_wrap.h"
+#include <ldb.h>
+#include <ldb_errors.h>
+#include "ldb_wrap.h"
 #include "dsdb/samdb/samdb.h"
 #include "../libds/common/flags.h"
 #include "librpc/gen_ndr/ndr_drsuapi_c.h"
@@ -34,6 +34,7 @@
 #include "librpc/gen_ndr/ndr_drsuapi.h"
 #include "auth/gensec/gensec.h"
 #include "param/param.h"
+#include "lib/tsocket/tsocket.h"
 
 /*****************************************************************************
  * Windows 2003 (w2k3) does the following steps when changing the server role
@@ -700,6 +701,7 @@ struct libnet_BecomeDC_state {
                struct libnet_BecomeDC_state *s;
                struct dcerpc_binding *binding;
                struct dcerpc_pipe *pipe;
+               struct dcerpc_binding_handle *drsuapi_handle;
                DATA_BLOB gensec_skey;
                struct drsuapi_DsBind bind_r;
                struct GUID bind_guid;
@@ -709,6 +711,8 @@ struct libnet_BecomeDC_state {
                struct policy_handle bind_handle;
        } drsuapi1, drsuapi2, drsuapi3;
 
+       void *ndr_struct_ptr;
+
        struct libnet_BecomeDC_Domain domain;
        struct libnet_BecomeDC_Forest forest;
        struct libnet_BecomeDC_SourceDSA source_dsa;
@@ -729,20 +733,15 @@ struct libnet_BecomeDC_state {
        struct libnet_BecomeDC_PrepareDB _pp;
        struct libnet_BecomeDC_StoreChunk _sc;
        struct libnet_BecomeDC_Callbacks callbacks;
+
+       bool rodc_join;
 };
 
 static int32_t get_dc_function_level(struct loadparm_context *lp_ctx)
 {
-       /* per default we are (Windows) 2008 compatible */
-       return lp_parm_int(lp_ctx, NULL, "ads", "dc function level",
-               DS_DC_FUNCTION_2008);
-}
-
-static int32_t get_min_function_level(struct loadparm_context *lp_ctx)
-{
-       /* per default it is (Windows) 2003 Native compatible */
-       return lp_parm_int(lp_ctx, NULL, "ads", "min function level",
-               DS_DOMAIN_FUNCTION_2003);
+       /* per default we are (Windows) 2008 R2 compatible */
+       return lpcfg_parm_int(lp_ctx, NULL, "ads", "dc function level",
+                          DS_DOMAIN_FUNCTION_2008_R2);
 }
 
 static void becomeDC_recv_cldap(struct tevent_req *req);
@@ -751,9 +750,11 @@ static void becomeDC_send_cldap(struct libnet_BecomeDC_state *s)
 {
        struct composite_context *c = s->creq;
        struct tevent_req *req;
+       struct tsocket_address *dest_address;
+       int ret;
 
-       s->cldap.io.in.dest_address     = s->source_dsa.address;
-       s->cldap.io.in.dest_port        = lp_cldap_port(s->libnet->lp_ctx);
+       s->cldap.io.in.dest_address     = NULL;
+       s->cldap.io.in.dest_port        = 0;
        s->cldap.io.in.realm            = s->domain.dns_name;
        s->cldap.io.in.host             = s->dest_dsa.netbios_name;
        s->cldap.io.in.user             = NULL;
@@ -763,8 +764,17 @@ static void becomeDC_send_cldap(struct libnet_BecomeDC_state *s)
        s->cldap.io.in.version          = NETLOGON_NT_VERSION_5 | NETLOGON_NT_VERSION_5EX;
        s->cldap.io.in.map_response     = true;
 
+       ret = tsocket_address_inet_from_strings(s, "ip",
+                                               s->source_dsa.address,
+                                               lpcfg_cldap_port(s->libnet->lp_ctx),
+                                               &dest_address);
+       if (ret != 0) {
+               c->status = map_nt_error_from_unix_common(errno);
+               if (!composite_is_ok(c)) return;
+       }
+
        c->status = cldap_socket_init(s, s->libnet->event_ctx,
-                                     NULL, NULL, &s->cldap.sock);//TODO
+                                     NULL, dest_address, &s->cldap.sock);
        if (!composite_is_ok(c)) return;
 
        req = cldap_netlogon_send(s, s->cldap.sock, &s->cldap.io);
@@ -780,9 +790,7 @@ static void becomeDC_recv_cldap(struct tevent_req *req)
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
 
-       c->status = cldap_netlogon_recv(req,
-                                       lp_iconv_convenience(s->libnet->lp_ctx),
-                                       s, &s->cldap.io);
+       c->status = cldap_netlogon_recv(req, s, &s->cldap.io);
        talloc_free(req);
        if (!composite_is_ok(c)) {
                DEBUG(0,("Failed to send, receive or parse CLDAP reply from server %s for our host %s: %s\n", 
@@ -794,7 +802,7 @@ static void becomeDC_recv_cldap(struct tevent_req *req)
        s->cldap.netlogon = s->cldap.io.out.netlogon.data.nt5_ex;
 
        s->domain.dns_name              = s->cldap.netlogon.dns_domain;
-       s->domain.netbios_name          = s->cldap.netlogon.domain;
+       s->domain.netbios_name          = s->cldap.netlogon.domain_name;
        s->domain.guid                  = s->cldap.netlogon.domain_uuid;
 
        s->forest.dns_name              = s->cldap.netlogon.forest;
@@ -805,6 +813,15 @@ static void becomeDC_recv_cldap(struct tevent_req *req)
 
        s->dest_dsa.site_name           = s->cldap.netlogon.client_site;
 
+       DEBUG(0,("CLDAP response: forest=%s dns=%s netbios=%s server_site=%s  client_site=%s\n",
+                s->forest.dns_name, s->domain.dns_name, s->domain.netbios_name,
+                s->source_dsa.site_name, s->dest_dsa.site_name));
+       if (!s->dest_dsa.site_name || strcmp(s->dest_dsa.site_name, "") == 0) {
+               DEBUG(0,("Got empty client site - using server site name %s\n",
+                        s->source_dsa.site_name));
+               s->dest_dsa.site_name = s->source_dsa.site_name;
+       }
+
        becomeDC_connect_ldap1(s);
 }
 
@@ -895,14 +912,6 @@ static NTSTATUS becomeDC_ldap1_crossref_behavior_version(struct libnet_BecomeDC_
        }
 
        s->forest.crossref_behavior_version = ldb_msg_find_attr_as_uint(r->msgs[0], "msDs-Behavior-Version", 0);
-       if (s->forest.crossref_behavior_version <
-                        get_min_function_level(s->libnet->lp_ctx)) {
-               talloc_free(r);
-               DEBUG(0,("The servers function level %u is below 'ads:min function level' of %u\n", 
-                        s->forest.crossref_behavior_version, 
-                        get_min_function_level(s->libnet->lp_ctx)));
-               return NT_STATUS_NOT_SUPPORTED;
-       }
        if (s->forest.crossref_behavior_version >
                        get_dc_function_level(s->libnet->lp_ctx)) {
                talloc_free(r);
@@ -940,14 +949,6 @@ static NTSTATUS becomeDC_ldap1_domain_behavior_version(struct libnet_BecomeDC_st
        }
 
        s->domain.behavior_version = ldb_msg_find_attr_as_uint(r->msgs[0], "msDs-Behavior-Version", 0);
-       if (s->domain.behavior_version <
-                       get_min_function_level(s->libnet->lp_ctx)) {
-               talloc_free(r);
-               DEBUG(0,("The servers function level %u is below 'ads:min function level' of %u\n", 
-                        s->forest.crossref_behavior_version, 
-                        get_min_function_level(s->libnet->lp_ctx)));
-               return NT_STATUS_NOT_SUPPORTED;
-       }
        if (s->domain.behavior_version >
                        get_dc_function_level(s->libnet->lp_ctx)) {
                talloc_free(r);
@@ -1040,7 +1041,8 @@ static NTSTATUS becomeDC_ldap1_infrastructure_fsmo(struct libnet_BecomeDC_state
                NULL
        };
 
-       ret = dsdb_wellknown_dn(s->ldap1.ldb, s, samdb_base_dn(s->ldap1.ldb),
+       ret = dsdb_wellknown_dn(s->ldap1.ldb, s,
+                               ldb_get_default_basedn(s->ldap1.ldb),
                                DS_GUID_INFRASTRUCTURE_CONTAINER,
                                &basedn);
        if (ret != LDB_SUCCESS) {
@@ -1071,7 +1073,7 @@ static NTSTATUS becomeDC_ldap1_infrastructure_fsmo(struct libnet_BecomeDC_state
                return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       s->infrastructure_fsmo.dns_name = samdb_result_string(r->msgs[0], "dnsHostName", NULL);
+       s->infrastructure_fsmo.dns_name = ldb_msg_find_attr_as_string(r->msgs[0], "dnsHostName", NULL);
        if (!s->infrastructure_fsmo.dns_name) return NT_STATUS_INVALID_NETWORK_RESPONSE;
        talloc_steal(s, s->infrastructure_fsmo.dns_name);
 
@@ -1131,7 +1133,7 @@ static NTSTATUS becomeDC_ldap1_rid_manager_fsmo(struct libnet_BecomeDC_state *s)
                return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       reference_dn_str        = samdb_result_string(r->msgs[0], "rIDManagerReference", NULL);
+       reference_dn_str        = ldb_msg_find_attr_as_string(r->msgs[0], "rIDManagerReference", NULL);
        if (!reference_dn_str) return NT_STATUS_INVALID_NETWORK_RESPONSE;
 
        basedn = ldb_dn_new(s, s->ldap1.ldb, reference_dn_str);
@@ -1149,7 +1151,7 @@ static NTSTATUS becomeDC_ldap1_rid_manager_fsmo(struct libnet_BecomeDC_state *s)
                return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       s->rid_manager_fsmo.ntds_dn_str = samdb_result_string(r->msgs[0], "fSMORoleOwner", NULL);
+       s->rid_manager_fsmo.ntds_dn_str = ldb_msg_find_attr_as_string(r->msgs[0], "fSMORoleOwner", NULL);
        if (!s->rid_manager_fsmo.ntds_dn_str) return NT_STATUS_INVALID_NETWORK_RESPONSE;
        talloc_steal(s, s->rid_manager_fsmo.ntds_dn_str);
 
@@ -1173,7 +1175,7 @@ static NTSTATUS becomeDC_ldap1_rid_manager_fsmo(struct libnet_BecomeDC_state *s)
                return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       s->rid_manager_fsmo.dns_name    = samdb_result_string(r->msgs[0], "dnsHostName", NULL);
+       s->rid_manager_fsmo.dns_name    = ldb_msg_find_attr_as_string(r->msgs[0], "dnsHostName", NULL);
        if (!s->rid_manager_fsmo.dns_name) return NT_STATUS_INVALID_NETWORK_RESPONSE;
        talloc_steal(s, s->rid_manager_fsmo.dns_name);
 
@@ -1258,11 +1260,11 @@ static NTSTATUS becomeDC_ldap1_computer_object(struct libnet_BecomeDC_state *s)
                return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       s->dest_dsa.computer_dn_str     = samdb_result_string(r->msgs[0], "distinguishedName", NULL);
+       s->dest_dsa.computer_dn_str     = ldb_msg_find_attr_as_string(r->msgs[0], "distinguishedName", NULL);
        if (!s->dest_dsa.computer_dn_str) return NT_STATUS_INVALID_NETWORK_RESPONSE;
        talloc_steal(s, s->dest_dsa.computer_dn_str);
 
-       s->dest_dsa.user_account_control = samdb_result_uint(r->msgs[0], "userAccountControl", 0);
+       s->dest_dsa.user_account_control = ldb_msg_find_attr_as_uint(r->msgs[0], "userAccountControl", 0);
 
        talloc_free(r);
        return NT_STATUS_OK;
@@ -1296,7 +1298,7 @@ static NTSTATUS becomeDC_ldap1_server_object_1(struct libnet_BecomeDC_state *s)
                return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       server_reference_dn_str = samdb_result_string(r->msgs[0], "serverReference", NULL);
+       server_reference_dn_str = ldb_msg_find_attr_as_string(r->msgs[0], "serverReference", NULL);
        if (server_reference_dn_str) {
                server_reference_dn     = ldb_dn_new(r, s->ldap1.ldb, server_reference_dn_str);
                NT_STATUS_HAVE_NO_MEMORY(server_reference_dn);
@@ -1315,7 +1317,7 @@ static NTSTATUS becomeDC_ldap1_server_object_1(struct libnet_BecomeDC_state *s)
        }
 
        /* if the server object is already for the dest_dsa, then we don't need to create it */
-       s->dest_dsa.server_dn_str       = samdb_result_string(r->msgs[0], "distinguishedName", NULL);
+       s->dest_dsa.server_dn_str       = ldb_msg_find_attr_as_string(r->msgs[0], "distinguishedName", NULL);
        if (!s->dest_dsa.server_dn_str) return NT_STATUS_INVALID_NETWORK_RESPONSE;
        talloc_steal(s, s->dest_dsa.server_dn_str);
 
@@ -1350,7 +1352,7 @@ static NTSTATUS becomeDC_ldap1_server_object_2(struct libnet_BecomeDC_state *s)
                return NT_STATUS_INVALID_NETWORK_RESPONSE;
        }
 
-       server_reference_bl_dn_str = samdb_result_string(r->msgs[0], "serverReferenceBL", NULL);
+       server_reference_bl_dn_str = ldb_msg_find_attr_as_string(r->msgs[0], "serverReferenceBL", NULL);
        if (!server_reference_bl_dn_str) {
                /* if no back link is present, we're done for this function */
                talloc_free(r);
@@ -1358,7 +1360,7 @@ static NTSTATUS becomeDC_ldap1_server_object_2(struct libnet_BecomeDC_state *s)
        }
 
        /* if the server object is already for the dest_dsa, then we don't need to create it */
-       s->dest_dsa.server_dn_str       = samdb_result_string(r->msgs[0], "serverReferenceBL", NULL);
+       s->dest_dsa.server_dn_str       = ldb_msg_find_attr_as_string(r->msgs[0], "serverReferenceBL", NULL);
        if (s->dest_dsa.server_dn_str) {
                /* if a back link is present, we know that the server object is present */
                talloc_steal(s, s->dest_dsa.server_dn_str);
@@ -1421,7 +1423,7 @@ static NTSTATUS becomeDC_ldap1_server_object_modify(struct libnet_BecomeDC_state
 {
        int ret;
        struct ldb_message *msg;
-       uint32_t i;
+       unsigned int i;
 
        /* make a 'modify' msg, and only for serverReference */
        msg = ldb_msg_new(s);
@@ -1547,12 +1549,12 @@ static void becomeDC_drsuapi_connect_send(struct libnet_BecomeDC_state *s,
                 *       configuration partition works fine, but it fails for
                 *       the domain partition.
                 */
-               if (lp_parm_bool(s->libnet->lp_ctx, NULL, "become_dc",
+               if (lpcfg_parm_bool(s->libnet->lp_ctx, NULL, "become_dc",
                                 "force krb5", true))
                {
                        krb5_str = "krb5,";
                }
-               if (lp_parm_bool(s->libnet->lp_ctx, NULL, "become_dc",
+               if (lpcfg_parm_bool(s->libnet->lp_ctx, NULL, "become_dc",
                                 "print", false))
                {
                        print_str = "print,";
@@ -1566,6 +1568,10 @@ static void becomeDC_drsuapi_connect_send(struct libnet_BecomeDC_state *s,
                if (!composite_is_ok(c)) return;
        }
 
+       if (DEBUGLEVEL >= 10) {
+               drsuapi->binding->flags |= DCERPC_DEBUG_PRINT_BOTH;
+       }
+
        creq = dcerpc_pipe_connect_b_send(s, drsuapi->binding, &ndr_table_drsuapi,
                                          s->libnet->cred, s->libnet->event_ctx,
                                          s->libnet->lp_ctx);
@@ -1574,8 +1580,8 @@ static void becomeDC_drsuapi_connect_send(struct libnet_BecomeDC_state *s,
 
 static void becomeDC_drsuapi_bind_send(struct libnet_BecomeDC_state *s,
                                       struct becomeDC_drsuapi *drsuapi,
-                                      void (*recv_fn)(struct rpc_request *req));
-static void becomeDC_drsuapi1_bind_recv(struct rpc_request *req);
+                                      void (*recv_fn)(struct tevent_req *subreq));
+static void becomeDC_drsuapi1_bind_recv(struct tevent_req *subreq);
 
 static void becomeDC_drsuapi1_connect_recv(struct composite_context *req)
 {
@@ -1586,6 +1592,8 @@ static void becomeDC_drsuapi1_connect_recv(struct composite_context *req)
        c->status = dcerpc_pipe_connect_b_recv(req, s, &s->drsuapi1.pipe);
        if (!composite_is_ok(c)) return;
 
+       s->drsuapi1.drsuapi_handle = s->drsuapi1.pipe->binding_handle;
+
        c->status = gensec_session_key(s->drsuapi1.pipe->conn->security_state.generic_state,
                                       &s->drsuapi1.gensec_skey);
        if (!composite_is_ok(c)) return;
@@ -1595,11 +1603,11 @@ static void becomeDC_drsuapi1_connect_recv(struct composite_context *req)
 
 static void becomeDC_drsuapi_bind_send(struct libnet_BecomeDC_state *s,
                                       struct becomeDC_drsuapi *drsuapi,
-                                      void (*recv_fn)(struct rpc_request *req))
+                                      void (*recv_fn)(struct tevent_req *subreq))
 {
        struct composite_context *c = s->creq;
-       struct rpc_request *req;
        struct drsuapi_DsBindInfo28 *bind_info28;
+       struct tevent_req *subreq;
 
        GUID_from_string(DRSUAPI_DS_BIND_GUID_W2K3, &drsuapi->bind_guid);
 
@@ -1650,8 +1658,11 @@ static void becomeDC_drsuapi_bind_send(struct libnet_BecomeDC_state *s,
        drsuapi->bind_r.in.bind_info = &drsuapi->bind_info_ctr;
        drsuapi->bind_r.out.bind_handle = &drsuapi->bind_handle;
 
-       req = dcerpc_drsuapi_DsBind_send(drsuapi->pipe, s, &drsuapi->bind_r);
-       composite_continue_rpc(c, req, recv_fn, s);
+       subreq = dcerpc_drsuapi_DsBind_r_send(s, c->event_ctx,
+                                             drsuapi->drsuapi_handle,
+                                             &drsuapi->bind_r);
+       if (composite_nomem(subreq, c)) return;
+       tevent_req_set_callback(subreq, recv_fn, s);
 }
 
 static WERROR becomeDC_drsuapi_bind_recv(struct libnet_BecomeDC_state *s,
@@ -1693,26 +1704,17 @@ static WERROR becomeDC_drsuapi_bind_recv(struct libnet_BecomeDC_state *s,
 
 static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s);
 
-static void becomeDC_drsuapi1_bind_recv(struct rpc_request *req)
+static void becomeDC_drsuapi1_bind_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
        WERROR status;
 
-       bool print = false;
-
-       if (req->p->conn->flags & DCERPC_DEBUG_PRINT_OUT) {
-               print = true;
-       }
-
-       c->status = dcerpc_ndr_request_recv(req);
+       c->status = dcerpc_drsuapi_DsBind_r_recv(subreq, s);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
-       if (print) {
-               NDR_PRINT_OUT_DEBUG(drsuapi_DsBind, &s->drsuapi1.bind_r);
-       }
-
        status = becomeDC_drsuapi_bind_recv(s, &s->drsuapi1);
        if (!W_ERROR_IS_OK(status)) {
                composite_error(c, werror_to_ntstatus(status));
@@ -1722,19 +1724,18 @@ static void becomeDC_drsuapi1_bind_recv(struct rpc_request *req)
        becomeDC_drsuapi1_add_entry_send(s);
 }
 
-static void becomeDC_drsuapi1_add_entry_recv(struct rpc_request *req);
+static void becomeDC_drsuapi1_add_entry_recv(struct tevent_req *subreq);
 
 static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 {
        struct composite_context *c = s->creq;
-       struct rpc_request *req;
        struct drsuapi_DsAddEntry *r;
        struct drsuapi_DsReplicaObjectIdentifier *identifier;
        uint32_t num_attrs, i = 0;
        struct drsuapi_DsReplicaAttribute *attrs;
-       struct smb_iconv_convenience *iconv_convenience = lp_iconv_convenience(s->libnet->lp_ctx);
        enum ndr_err_code ndr_err;
        bool w2k3;
+       struct tevent_req *subreq;
 
        /* choose a random invocationId */
        s->dest_dsa.invocation_id = GUID_random();
@@ -1762,7 +1763,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
        if (composite_nomem(identifier->dn, c)) return;
 
        /* allocate attribute array */
-       num_attrs       = 11;
+       num_attrs       = 12;
        attrs           = talloc_array(r, struct drsuapi_DsReplicaAttribute, num_attrs);
        if (composite_nomem(attrs, c)) return;
 
@@ -1831,7 +1832,8 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                                               NULL);
                if (composite_nomem(v, c)) return;
 
-               ndr_err = ndr_push_struct_blob(&vd[0], vd, iconv_convenience, v,(ndr_push_flags_fn_t)ndr_push_security_descriptor);
+               ndr_err = ndr_push_struct_blob(&vd[0], vd, v,
+               (ndr_push_flags_fn_t)ndr_push_security_descriptor);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
@@ -1839,7 +1841,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_ntSecurityDescriptor;
+               attrs[i].attid                  = DRSUAPI_ATTID_ntSecurityDescriptor;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -1865,14 +1867,14 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_objectClass;
+               attrs[i].attid                  = DRSUAPI_ATTID_objectClass;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
                i++;
        }
 
-       /* objectCategory: CN=NTDS-DSA,CN=Schema,... */
+       /* objectCategory: CN=NTDS-DSA,CN=Schema,... or CN=NTDS-DSA-RO,CN=Schema,... */
        {
                struct drsuapi_DsAttributeValue *vs;
                DATA_BLOB *vd;
@@ -1886,12 +1888,18 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                v[0].guid               = GUID_zero();
                v[0].sid                = s->zero_sid;
-               v[0].dn                 = talloc_asprintf(vd, "CN=NTDS-DSA,%s",
+
+               if (s->rodc_join) {
+                   v[0].dn             = talloc_asprintf(vd, "CN=NTDS-DSA-RO,%s",
+                                                         s->forest.schema_dn_str);
+               } else {
+                   v[0].dn             = talloc_asprintf(vd, "CN=NTDS-DSA,%s",
                                                          s->forest.schema_dn_str);
+               }
                if (composite_nomem(v[0].dn, c)) return;
 
-               ndr_err = ndr_push_struct_blob(&vd[0], vd, iconv_convenience, &v[0], 
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[0], vd, &v[0], 
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
@@ -1899,7 +1907,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_objectCategory;
+               attrs[i].attid                  = DRSUAPI_ATTID_objectCategory;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -1925,7 +1933,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_invocationId;
+               attrs[i].attid                  = DRSUAPI_ATTID_invocationId;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -1956,22 +1964,22 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                v[2].sid                = s->zero_sid;
                v[2].dn                 = s->forest.schema_dn_str;
 
-               ndr_err = ndr_push_struct_blob(&vd[0], vd, iconv_convenience, &v[0],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[0], vd, &v[0],
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
                }
 
-               ndr_err = ndr_push_struct_blob(&vd[1], vd, iconv_convenience, &v[1],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[1], vd, &v[1],
+               (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
                }
 
-               ndr_err = ndr_push_struct_blob(&vd[2], vd, iconv_convenience, &v[2],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[2], vd, &v[2],
+                  (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
@@ -1981,7 +1989,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                vs[1].blob              = &vd[1];
                vs[2].blob              = &vd[2];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_hasMasterNCs;
+               attrs[i].attid                  = DRSUAPI_ATTID_hasMasterNCs;
                attrs[i].value_ctr.num_values   = 3;
                attrs[i].value_ctr.values       = vs;
 
@@ -2012,22 +2020,22 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                v[2].sid                = s->zero_sid;
                v[2].dn                 = s->forest.schema_dn_str;
 
-               ndr_err = ndr_push_struct_blob(&vd[0], vd, iconv_convenience, &v[0],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[0], vd, &v[0],
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
                }
 
-               ndr_err = ndr_push_struct_blob(&vd[1], vd, iconv_convenience, &v[1],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[1], vd, &v[1],
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
                }
 
-               ndr_err = ndr_push_struct_blob(&vd[2], vd, iconv_convenience, &v[2],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[2], vd, &v[2],
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
@@ -2037,7 +2045,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                vs[1].blob              = &vd[1];
                vs[2].blob              = &vd[2];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_msDS_hasMasterNCs;
+               attrs[i].attid                  = DRSUAPI_ATTID_msDS_hasMasterNCs;
                attrs[i].value_ctr.num_values   = 3;
                attrs[i].value_ctr.values       = vs;
 
@@ -2060,8 +2068,8 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                v[0].sid                = s->zero_sid;
                v[0].dn                 = s->forest.schema_dn_str;
 
-               ndr_err = ndr_push_struct_blob(&vd[0], vd, iconv_convenience, &v[0],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[0], vd, &v[0],
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
@@ -2069,7 +2077,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_dMDLocation;
+               attrs[i].attid                  = DRSUAPI_ATTID_dMDLocation;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -2092,8 +2100,8 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                v[0].sid                = s->zero_sid;
                v[0].dn                 = s->domain.dn_str;
 
-               ndr_err = ndr_push_struct_blob(&vd[0], vd, iconv_convenience, &v[0],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[0], vd, &v[0],
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
@@ -2101,7 +2109,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_msDS_HasDomainNCs;
+               attrs[i].attid                  = DRSUAPI_ATTID_msDS_HasDomainNCs;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -2126,7 +2134,7 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_msDS_Behavior_Version;
+               attrs[i].attid                  = DRSUAPI_ATTID_msDS_Behavior_Version;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -2147,11 +2155,15 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                vd[0] = data_blob_talloc(vd, NULL, 4);
                if (composite_nomem(vd[0].data, c)) return;
 
-               SIVAL(vd[0].data, 0, SYSTEM_FLAG_DISALLOW_MOVE_ON_DELETE);
+               if (s->rodc_join) {
+                   SIVAL(vd[0].data, 0, SYSTEM_FLAG_CONFIG_ALLOW_RENAME);
+               } else {
+                   SIVAL(vd[0].data, 0, SYSTEM_FLAG_DISALLOW_MOVE_ON_DELETE);
+               }
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_systemFlags;
+               attrs[i].attid                  = DRSUAPI_ATTID_systemFlags;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -2174,8 +2186,8 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
                v[0].sid                = s->zero_sid;
                v[0].dn                 = s->dest_dsa.computer_dn_str;
 
-               ndr_err = ndr_push_struct_blob(&vd[0], vd, iconv_convenience, &v[0],
-                                              (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
+               ndr_err = ndr_push_struct_blob(&vd[0], vd, &v[0],
+                       (ndr_push_flags_fn_t)ndr_push_drsuapi_DsReplicaObjectIdentifier3);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        c->status = ndr_map_error2ntstatus(ndr_err);
                        if (!composite_is_ok(c)) return;
@@ -2183,7 +2195,32 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
 
                vs[0].blob              = &vd[0];
 
-               attrs[i].attid                  = DRSUAPI_ATTRIBUTE_serverReference;
+               attrs[i].attid                  = DRSUAPI_ATTID_serverReference;
+               attrs[i].value_ctr.num_values   = 1;
+               attrs[i].value_ctr.values       = vs;
+
+               i++;
+       }
+
+       /* options:... */
+       if (s->rodc_join) {
+               struct drsuapi_DsAttributeValue *vs;
+               DATA_BLOB *vd;
+
+               vs = talloc_array(attrs, struct drsuapi_DsAttributeValue, 1);
+               if (composite_nomem(vs, c)) return;
+
+               vd = talloc_array(vs, DATA_BLOB, 1);
+               if (composite_nomem(vd, c)) return;
+
+               vd[0] = data_blob_talloc(vd, NULL, 4);
+               if (composite_nomem(vd[0].data, c)) return;
+
+               SIVAL(vd[0].data, 0, DS_NTDSDSA_OPT_DISABLE_OUTBOUND_REPL);
+
+               vs[0].blob              = &vd[0];
+
+               attrs[i].attid                  = DRSUAPI_ATTID_options;
                attrs[i].value_ctr.num_values   = 1;
                attrs[i].value_ctr.values       = vs;
 
@@ -2203,73 +2240,147 @@ static void becomeDC_drsuapi1_add_entry_send(struct libnet_BecomeDC_state *s)
        r->in.req->req2.first_object.object.attribute_ctr.num_attributes= num_attrs;
        r->in.req->req2.first_object.object.attribute_ctr.attributes    = attrs;
 
-       r->out.level_out        = talloc(s, int32_t);
+       r->out.level_out        = talloc(s, uint32_t);
        r->out.ctr              = talloc(s, union drsuapi_DsAddEntryCtr);
 
-       req = dcerpc_drsuapi_DsAddEntry_send(s->drsuapi1.pipe, r, r);
-       composite_continue_rpc(c, req, becomeDC_drsuapi1_add_entry_recv, s);
+       s->ndr_struct_ptr = r;
+       subreq = dcerpc_drsuapi_DsAddEntry_r_send(s, c->event_ctx,
+                                                 s->drsuapi1.drsuapi_handle, r);
+       if (composite_nomem(subreq, c)) return;
+       tevent_req_set_callback(subreq, becomeDC_drsuapi1_add_entry_recv, s);
 }
 
 static void becomeDC_drsuapi2_connect_recv(struct composite_context *req);
 static NTSTATUS becomeDC_prepare_db(struct libnet_BecomeDC_state *s);
 
-static void becomeDC_drsuapi1_add_entry_recv(struct rpc_request *req)
+static void becomeDC_drsuapi1_add_entry_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
-       struct drsuapi_DsAddEntry *r = talloc_get_type(req->ndr.struct_ptr,
+       struct drsuapi_DsAddEntry *r = talloc_get_type_abort(s->ndr_struct_ptr,
                                       struct drsuapi_DsAddEntry);
        char *binding_str;
-       bool print = false;
 
-       if (req->p->conn->flags & DCERPC_DEBUG_PRINT_OUT) {
-               print = true;
-       }
+       s->ndr_struct_ptr = NULL;
 
-       c->status = dcerpc_ndr_request_recv(req);
+       c->status = dcerpc_drsuapi_DsAddEntry_r_recv(subreq, r);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
-       if (print) {
-               NDR_PRINT_OUT_DEBUG(drsuapi_DsAddEntry, r);
-       }
-
        if (!W_ERROR_IS_OK(r->out.result)) {
                composite_error(c, werror_to_ntstatus(r->out.result));
                return;
        }
 
        if (*r->out.level_out == 3) {
-               if (r->out.ctr->ctr3.count != 1) {
-                       WERROR status;
-
-                       if (r->out.ctr->ctr3.level != 1) {
-                               composite_error(c, NT_STATUS_INVALID_NETWORK_RESPONSE);
-                               return;
-                       }
-
-                       if (!r->out.ctr->ctr3.error) {
+               WERROR status;
+               union drsuapi_DsAddEntry_ErrData *err_data = r->out.ctr->ctr3.err_data;
+
+               /* check for errors */
+               status = err_data ? err_data->v1.status : WERR_OK;
+               if (!W_ERROR_IS_OK(status)) {
+                       struct drsuapi_DsAddEntryErrorInfo_Attr_V1 *attr_err;
+                       struct drsuapi_DsAddEntry_AttrErrListItem_V1 *attr_err_li;
+                       struct drsuapi_DsAddEntryErrorInfo_Name_V1 *name_err;
+                       struct drsuapi_DsAddEntryErrorInfo_Referr_V1 *ref_err;
+                       struct drsuapi_DsAddEntry_RefErrListItem_V1 *ref_li;
+
+                       if (r->out.ctr->ctr3.err_ver != 1) {
                                composite_error(c, NT_STATUS_INVALID_NETWORK_RESPONSE);
                                return;
                        }
 
-                       status = r->out.ctr->ctr3.error->info1.status;
+                       DEBUG(0,("DsAddEntry (R3) of '%s' failed: "
+                                "Errors: dir_err = %d, status = %s;\n",
+                                r->in.req->req3.first_object.object.identifier->dn,
+                                err_data->v1.dir_err,
+                                win_errstr(err_data->v1.status)));
 
-                       if (!r->out.ctr->ctr3.error->info1.info) {
+                       if (!err_data->v1.info) {
+                               DEBUG(0, ("DsAddEntry (R3): no error info returned!\n"));
                                composite_error(c, werror_to_ntstatus(status));
                                return;
                        }
 
-                       /* see if we can get a more detailed error */
-                       switch (r->out.ctr->ctr3.error->info1.level) {
-                       case 1:
-                               status = r->out.ctr->ctr3.error->info1.info->error1.status;
+                       /* dump more detailed error */
+                       switch (err_data->v1.dir_err) {
+                       case DRSUAPI_DIRERR_ATTRIBUTE:
+                               /* Dump attribute errors */
+                               attr_err = &err_data->v1.info->attr_err;
+                               DEBUGADD(0,(" Attribute Error: object = %s, count = %d;\n",
+                                           attr_err->id->dn,
+                                           attr_err->count));
+                               attr_err_li = &attr_err->first;
+                               for (; attr_err_li; attr_err_li = attr_err_li->next) {
+                                       struct drsuapi_DsAddEntry_AttrErr_V1 *err = &attr_err_li->err_data;
+                                       DEBUGADD(0,(" Error: err = %s, problem = 0x%08X, attid = 0x%08X;\n",
+                                                   win_errstr(err->extended_err),
+                                                   err->problem,
+                                                   err->attid));
+                                       /* TODO: should we print attribute value here? */
+                               }
+                               break;
+                       case DRSUAPI_DIRERR_NAME:
+                               /* Dump Name resolution error */
+                               name_err = &err_data->v1.info->name_err;
+                               DEBUGADD(0,(" Name Error: err = %s, problem = 0x%08X, id_matched = %s;\n",
+                                           win_errstr(name_err->extended_err),
+                                           name_err->problem,
+                                           name_err->id_matched->dn));
+                               break;
+                       case DRSUAPI_DIRERR_REFERRAL:
+                               /* Dump Referral errors */
+                               ref_err = &err_data->v1.info->referral_err;
+                               DEBUGADD(0,(" Referral Error: extended_err = %s\n",
+                                           win_errstr(ref_err->extended_err)));
+                               ref_li = &ref_err->refer;
+                               for (; ref_li; ref_li = ref_li->next) {
+                                       struct drsuapi_DsaAddressListItem_V1 *addr;
+                                       DEBUGADD(0,(" Referral: id_target = %s, ref_type = 0x%04X,",
+                                                   ref_li->id_target->dn,
+                                                   ref_li->ref_type));
+                                       if (ref_li->is_choice_set) {
+                                               DEBUGADD(0,(" choice = 0x%02X, ",
+                                                           ref_li->choice));
+                                       }
+                                       DEBUGADD(0,(" add_list ("));
+                                       for (addr = ref_li->addr_list; addr; addr = addr->next) {
+                                               DEBUGADD(0,("%s", addr->address->string));
+                                               if (addr->next) {
+                                                       DEBUGADD(0,(", "));
+                                               }
+                                       }
+                                       DEBUGADD(0,(");\n"));
+                               }
                                break;
-                       case 4:
-                       case 5:
-                       case 6:
-                       case 7:
-                               status = r->out.ctr->ctr3.error->info1.info->errorX.status;
+                       case DRSUAPI_DIRERR_SECURITY:
+                               /* Dump Security error. */
+                               DEBUGADD(0,(" Security Error: extended_err = %s, problem = 0x%08X\n",
+                                           win_errstr(err_data->v1.info->security_err.extended_err),
+                                           err_data->v1.info->security_err.problem));
+                               break;
+                       case DRSUAPI_DIRERR_SERVICE:
+                               /* Dump Service error. */
+                               DEBUGADD(0,(" Service Error: extended_err = %s, problem = 0x%08X\n",
+                                           win_errstr(err_data->v1.info->service_err.extended_err),
+                                           err_data->v1.info->service_err.problem));
+                               break;
+                       case DRSUAPI_DIRERR_UPDATE:
+                               /* Dump Update error. */
+                               DEBUGADD(0,(" Update Error: extended_err = %s, problem = 0x%08X\n",
+                                           win_errstr(err_data->v1.info->update_err.extended_err),
+                                           err_data->v1.info->update_err.problem));
+                               break;
+                       case DRSUAPI_DIRERR_SYSTEM:
+                               /* System error. */
+                               DEBUGADD(0,(" System Error: extended_err = %s, problem = 0x%08X\n",
+                                           win_errstr(err_data->v1.info->system_err.extended_err),
+                                           err_data->v1.info->system_err.problem));
+                               break;
+                       case DRSUAPI_DIRERR_OK: /* mute compiler warnings */
+                       default:
+                               DEBUGADD(0,(" Unknown DIRERR error class returned!\n"));
                                break;
                        }
 
@@ -2277,13 +2388,34 @@ static void becomeDC_drsuapi1_add_entry_recv(struct rpc_request *req)
                        return;
                }
 
+               if (1 != r->out.ctr->ctr3.count) {
+                       DEBUG(0,("DsAddEntry - Ctr3: something very wrong had happened - "
+                                "method succeeded but objects returned are %d (expected 1).\n",
+                                r->out.ctr->ctr3.count));
+                       composite_error(c, NT_STATUS_INVALID_NETWORK_RESPONSE);
+               }
+
                s->dest_dsa.ntds_guid   = r->out.ctr->ctr3.objects[0].guid;
+
        } else if (*r->out.level_out == 2) {
-               if (r->out.ctr->ctr2.count != 1) {
-                       composite_error(c, werror_to_ntstatus(r->out.ctr->ctr2.error.status));
+               if (DRSUAPI_DIRERR_OK != r->out.ctr->ctr2.dir_err) {
+                       DEBUG(0,("DsAddEntry failed with: dir_err = %d, extended_err = %s\n",
+                                r->out.ctr->ctr2.dir_err,
+                                win_errstr(r->out.ctr->ctr2.extended_err)));
+                       composite_error(c, werror_to_ntstatus(r->out.ctr->ctr2.extended_err));
                        return;
                }
 
+               if (1 != r->out.ctr->ctr2.count) {
+                       DEBUG(0,("DsAddEntry: something very wrong had happened - "
+                                "method succeeded but objects returned are %d (expected 1). "
+                                "Errors: dir_err = %d, extended_err = %s\n",
+                                r->out.ctr->ctr2.count,
+                                r->out.ctr->ctr2.dir_err,
+                                win_errstr(r->out.ctr->ctr2.extended_err)));
+                       composite_error(c, NT_STATUS_INVALID_NETWORK_RESPONSE);
+               }
+
                s->dest_dsa.ntds_guid   = r->out.ctr->ctr2.objects[0].guid;
        } else {
                composite_error(c, NT_STATUS_INVALID_NETWORK_RESPONSE);
@@ -2307,6 +2439,10 @@ static void becomeDC_drsuapi1_add_entry_recv(struct rpc_request *req)
        talloc_free(binding_str);
        if (!composite_is_ok(c)) return;
 
+       if (DEBUGLEVEL >= 10) {
+               s->drsuapi2.binding->flags |= DCERPC_DEBUG_PRINT_BOTH;
+       }
+
        /* w2k3 uses the same assoc_group_id as on the first connection, so we do */
        s->drsuapi2.binding->assoc_group_id     = s->drsuapi1.pipe->assoc_group_id;
 
@@ -2325,7 +2461,7 @@ static NTSTATUS becomeDC_prepare_db(struct libnet_BecomeDC_state *s)
        return s->callbacks.prepare_db(s->callbacks.private_data, &s->_pp);
 }
 
-static void becomeDC_drsuapi2_bind_recv(struct rpc_request *req);
+static void becomeDC_drsuapi2_bind_recv(struct tevent_req *subreq);
 
 static void becomeDC_drsuapi2_connect_recv(struct composite_context *req)
 {
@@ -2336,6 +2472,8 @@ static void becomeDC_drsuapi2_connect_recv(struct composite_context *req)
        c->status = dcerpc_pipe_connect_b_recv(req, s, &s->drsuapi2.pipe);
        if (!composite_is_ok(c)) return;
 
+       s->drsuapi2.drsuapi_handle = s->drsuapi2.pipe->binding_handle;
+
        c->status = gensec_session_key(s->drsuapi2.pipe->conn->security_state.generic_state,
                                       &s->drsuapi2.gensec_skey);
        if (!composite_is_ok(c)) return;
@@ -2345,27 +2483,18 @@ static void becomeDC_drsuapi2_connect_recv(struct composite_context *req)
 
 static void becomeDC_drsuapi3_connect_recv(struct composite_context *req);
 
-static void becomeDC_drsuapi2_bind_recv(struct rpc_request *req)
+static void becomeDC_drsuapi2_bind_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
        char *binding_str;
        WERROR status;
 
-       bool print = false;
-
-       if (req->p->conn->flags & DCERPC_DEBUG_PRINT_OUT) {
-               print = true;
-       }
-
-       c->status = dcerpc_ndr_request_recv(req);
+       c->status = dcerpc_drsuapi_DsBind_r_recv(subreq, s);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
-       if (print) {
-               NDR_PRINT_OUT_DEBUG(drsuapi_DsBind, &s->drsuapi2.bind_r);
-       }
-
        status = becomeDC_drsuapi_bind_recv(s, &s->drsuapi2);
        if (!W_ERROR_IS_OK(status)) {
                composite_error(c, werror_to_ntstatus(status));
@@ -2380,6 +2509,10 @@ static void becomeDC_drsuapi2_bind_recv(struct rpc_request *req)
        talloc_free(binding_str);
        if (!composite_is_ok(c)) return;
 
+       if (DEBUGLEVEL >= 10) {
+               s->drsuapi3.binding->flags |= DCERPC_DEBUG_PRINT_BOTH;
+       }
+
        /* w2k3 uses the same assoc_group_id as on the first connection, so we do */
        s->drsuapi3.binding->assoc_group_id     = s->drsuapi1.pipe->assoc_group_id;
        /* w2k3 uses the concurrent multiplex feature on the 3rd connection, so we do */
@@ -2399,6 +2532,8 @@ static void becomeDC_drsuapi3_connect_recv(struct composite_context *req)
        c->status = dcerpc_pipe_connect_b_recv(req, s, &s->drsuapi3.pipe);
        if (!composite_is_ok(c)) return;
 
+       s->drsuapi3.drsuapi_handle = s->drsuapi3.pipe->binding_handle;
+
        c->status = gensec_session_key(s->drsuapi3.pipe->conn->security_state.generic_state,
                                       &s->drsuapi3.gensec_skey);
        if (!composite_is_ok(c)) return;
@@ -2410,16 +2545,16 @@ static void becomeDC_drsuapi_pull_partition_send(struct libnet_BecomeDC_state *s
                                                 struct becomeDC_drsuapi *drsuapi_h,
                                                 struct becomeDC_drsuapi *drsuapi_p,
                                                 struct libnet_BecomeDC_Partition *partition,
-                                                void (*recv_fn)(struct rpc_request *req))
+                                                void (*recv_fn)(struct tevent_req *subreq))
 {
        struct composite_context *c = s->creq;
-       struct rpc_request *req;
        struct drsuapi_DsGetNCChanges *r;
+       struct tevent_req *subreq;
 
        r = talloc(s, struct drsuapi_DsGetNCChanges);
        if (composite_nomem(r, c)) return;
 
-       r->out.level_out = talloc(r, int32_t);
+       r->out.level_out = talloc(r, uint32_t);
        if (composite_nomem(r->out.level_out, c)) return;
        r->in.req = talloc(r, union drsuapi_DsGetNCChangesRequest);
        if (composite_nomem(r->in.req, c)) return;
@@ -2463,8 +2598,12 @@ static void becomeDC_drsuapi_pull_partition_send(struct libnet_BecomeDC_state *s
         * are needed for it. Or the same KRB5 TGS is needed on both
         * connections.
         */
-       req = dcerpc_drsuapi_DsGetNCChanges_send(drsuapi_p->pipe, r, r);
-       composite_continue_rpc(c, req, recv_fn, s);
+       s->ndr_struct_ptr = r;
+       subreq = dcerpc_drsuapi_DsGetNCChanges_r_send(s, c->event_ctx,
+                                                     drsuapi_p->drsuapi_handle,
+                                                     r);
+       if (composite_nomem(subreq, c)) return;
+       tevent_req_set_callback(subreq, recv_fn, s);
 }
 
 static WERROR becomeDC_drsuapi_pull_partition_recv(struct libnet_BecomeDC_state *s,
@@ -2566,7 +2705,7 @@ static WERROR becomeDC_drsuapi_pull_partition_recv(struct libnet_BecomeDC_state
        return WERR_OK;
 }
 
-static void becomeDC_drsuapi3_pull_schema_recv(struct rpc_request *req);
+static void becomeDC_drsuapi3_pull_schema_recv(struct tevent_req *subreq);
 
 static void becomeDC_drsuapi3_pull_schema_send(struct libnet_BecomeDC_state *s)
 {
@@ -2582,6 +2721,9 @@ static void becomeDC_drsuapi3_pull_schema_send(struct libnet_BecomeDC_state *s)
                                        | DRSUAPI_DRS_FULL_SYNC_IN_PROGRESS
                                        | DRSUAPI_DRS_NEVER_SYNCED
                                        | DRSUAPI_DRS_USE_COMPRESSION;
+       if (s->rodc_join) {
+           s->schema_part.replica_flags &= ~DRSUAPI_DRS_WRIT_REP;
+       }
 
        s->schema_part.store_chunk      = s->callbacks.schema_chunk;
 
@@ -2591,28 +2733,21 @@ static void becomeDC_drsuapi3_pull_schema_send(struct libnet_BecomeDC_state *s)
 
 static void becomeDC_drsuapi3_pull_config_send(struct libnet_BecomeDC_state *s);
 
-static void becomeDC_drsuapi3_pull_schema_recv(struct rpc_request *req)
+static void becomeDC_drsuapi3_pull_schema_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
-       struct drsuapi_DsGetNCChanges *r = talloc_get_type(req->ndr.struct_ptr,
+       struct drsuapi_DsGetNCChanges *r = talloc_get_type_abort(s->ndr_struct_ptr,
                                           struct drsuapi_DsGetNCChanges);
        WERROR status;
 
-       bool print = false;
-
-       if (req->p->conn->flags & DCERPC_DEBUG_PRINT_OUT) {
-               print = true;
-       }
+       s->ndr_struct_ptr = NULL;
 
-       c->status = dcerpc_ndr_request_recv(req);
+       c->status = dcerpc_drsuapi_DsGetNCChanges_r_recv(subreq, r);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
-       if (print) {
-               NDR_PRINT_OUT_DEBUG(drsuapi_DsGetNCChanges, r);
-       }
-
        status = becomeDC_drsuapi_pull_partition_recv(s, &s->drsuapi2, &s->drsuapi3, &s->schema_part, r);
        if (!W_ERROR_IS_OK(status)) {
                composite_error(c, werror_to_ntstatus(status));
@@ -2630,7 +2765,7 @@ static void becomeDC_drsuapi3_pull_schema_recv(struct rpc_request *req)
        becomeDC_drsuapi3_pull_config_send(s);
 }
 
-static void becomeDC_drsuapi3_pull_config_recv(struct rpc_request *req);
+static void becomeDC_drsuapi3_pull_config_recv(struct tevent_req *subreq);
 
 static void becomeDC_drsuapi3_pull_config_send(struct libnet_BecomeDC_state *s)
 {
@@ -2646,6 +2781,9 @@ static void becomeDC_drsuapi3_pull_config_send(struct libnet_BecomeDC_state *s)
                                        | DRSUAPI_DRS_FULL_SYNC_IN_PROGRESS
                                        | DRSUAPI_DRS_NEVER_SYNCED
                                        | DRSUAPI_DRS_USE_COMPRESSION;
+       if (s->rodc_join) {
+           s->schema_part.replica_flags &= ~DRSUAPI_DRS_WRIT_REP;
+       }
 
        s->config_part.store_chunk      = s->callbacks.config_chunk;
 
@@ -2653,28 +2791,21 @@ static void becomeDC_drsuapi3_pull_config_send(struct libnet_BecomeDC_state *s)
                                             becomeDC_drsuapi3_pull_config_recv);
 }
 
-static void becomeDC_drsuapi3_pull_config_recv(struct rpc_request *req)
+static void becomeDC_drsuapi3_pull_config_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
-       struct drsuapi_DsGetNCChanges *r = talloc_get_type(req->ndr.struct_ptr,
+       struct drsuapi_DsGetNCChanges *r = talloc_get_type_abort(s->ndr_struct_ptr,
                                           struct drsuapi_DsGetNCChanges);
        WERROR status;
 
-       bool print = false;
-
-       if (req->p->conn->flags & DCERPC_DEBUG_PRINT_OUT) {
-               print = true;
-       }
+       s->ndr_struct_ptr = NULL;
 
-       c->status = dcerpc_ndr_request_recv(req);
+       c->status = dcerpc_drsuapi_DsGetNCChanges_r_recv(subreq, r);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
-       if (print) {
-               NDR_PRINT_OUT_DEBUG(drsuapi_DsGetNCChanges, r);
-       }
-
        status = becomeDC_drsuapi_pull_partition_recv(s, &s->drsuapi2, &s->drsuapi3, &s->config_part, r);
        if (!W_ERROR_IS_OK(status)) {
                composite_error(c, werror_to_ntstatus(status));
@@ -2692,7 +2823,7 @@ static void becomeDC_drsuapi3_pull_config_recv(struct rpc_request *req)
        becomeDC_connect_ldap2(s);
 }
 
-static void becomeDC_drsuapi3_pull_domain_recv(struct rpc_request *req);
+static void becomeDC_drsuapi3_pull_domain_recv(struct tevent_req *subreq);
 
 static void becomeDC_drsuapi3_pull_domain_send(struct libnet_BecomeDC_state *s)
 {
@@ -2708,6 +2839,9 @@ static void becomeDC_drsuapi3_pull_domain_send(struct libnet_BecomeDC_state *s)
                                        | DRSUAPI_DRS_FULL_SYNC_IN_PROGRESS
                                        | DRSUAPI_DRS_NEVER_SYNCED
                                        | DRSUAPI_DRS_USE_COMPRESSION;
+       if (s->rodc_join) {
+           s->schema_part.replica_flags &= ~DRSUAPI_DRS_WRIT_REP;
+       }
 
        s->domain_part.store_chunk      = s->callbacks.domain_chunk;
 
@@ -2718,30 +2852,24 @@ static void becomeDC_drsuapi3_pull_domain_send(struct libnet_BecomeDC_state *s)
 static void becomeDC_drsuapi_update_refs_send(struct libnet_BecomeDC_state *s,
                                              struct becomeDC_drsuapi *drsuapi,
                                              struct libnet_BecomeDC_Partition *partition,
-                                             void (*recv_fn)(struct rpc_request *req));
-static void becomeDC_drsuapi2_update_refs_schema_recv(struct rpc_request *req);
+                                             void (*recv_fn)(struct tevent_req *subreq));
+static void becomeDC_drsuapi2_update_refs_schema_recv(struct tevent_req *subreq);
 
-static void becomeDC_drsuapi3_pull_domain_recv(struct rpc_request *req)
+static void becomeDC_drsuapi3_pull_domain_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
-       struct drsuapi_DsGetNCChanges *r = talloc_get_type(req->ndr.struct_ptr,
+       struct drsuapi_DsGetNCChanges *r = talloc_get_type_abort(s->ndr_struct_ptr,
                                           struct drsuapi_DsGetNCChanges);
        WERROR status;
-       bool print = false;
 
-       if (req->p->conn->flags & DCERPC_DEBUG_PRINT_OUT) {
-               print = true;
-       }
+       s->ndr_struct_ptr = NULL;
 
-       c->status = dcerpc_ndr_request_recv(req);
+       c->status = dcerpc_drsuapi_DsGetNCChanges_r_recv(subreq, r);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
-       if (print) {
-               NDR_PRINT_OUT_DEBUG(drsuapi_DsGetNCChanges, r);
-       }
-
        status = becomeDC_drsuapi_pull_partition_recv(s, &s->drsuapi2, &s->drsuapi3, &s->domain_part, r);
        if (!W_ERROR_IS_OK(status)) {
                composite_error(c, werror_to_ntstatus(status));
@@ -2763,13 +2891,13 @@ static void becomeDC_drsuapi3_pull_domain_recv(struct rpc_request *req)
 static void becomeDC_drsuapi_update_refs_send(struct libnet_BecomeDC_state *s,
                                              struct becomeDC_drsuapi *drsuapi,
                                              struct libnet_BecomeDC_Partition *partition,
-                                             void (*recv_fn)(struct rpc_request *req))
+                                             void (*recv_fn)(struct tevent_req *subreq))
 {
        struct composite_context *c = s->creq;
-       struct rpc_request *req;
        struct drsuapi_DsReplicaUpdateRefs *r;
        const char *ntds_guid_str;
        const char *ntds_dns_name;
+       struct tevent_req *subreq;
 
        r = talloc(s, struct drsuapi_DsReplicaUpdateRefs);
        if (composite_nomem(r, c)) return;
@@ -2790,36 +2918,34 @@ static void becomeDC_drsuapi_update_refs_send(struct libnet_BecomeDC_state *s,
        r->in.req.req1.options          = DRSUAPI_DRS_ADD_REF | DRSUAPI_DRS_DEL_REF;
 
        /* I think this is how we mark ourselves as a RODC */
-       if (!lp_parm_bool(s->libnet->lp_ctx, NULL, "repl", "RODC", false)) {
+       if (!lpcfg_parm_bool(s->libnet->lp_ctx, NULL, "repl", "RODC", false)) {
                r->in.req.req1.options |= DRSUAPI_DRS_WRIT_REP;
        }
 
-       req = dcerpc_drsuapi_DsReplicaUpdateRefs_send(drsuapi->pipe, r, r);
-       composite_continue_rpc(c, req, recv_fn, s);
+       s->ndr_struct_ptr = r;
+       subreq = dcerpc_drsuapi_DsReplicaUpdateRefs_r_send(s, c->event_ctx,
+                                                          drsuapi->drsuapi_handle,
+                                                          r);
+       if (composite_nomem(subreq, c)) return;
+       tevent_req_set_callback(subreq, recv_fn, s);
 }
 
-static void becomeDC_drsuapi2_update_refs_config_recv(struct rpc_request *req);
+static void becomeDC_drsuapi2_update_refs_config_recv(struct tevent_req *subreq);
 
-static void becomeDC_drsuapi2_update_refs_schema_recv(struct rpc_request *req)
+static void becomeDC_drsuapi2_update_refs_schema_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
-       struct drsuapi_DsReplicaUpdateRefs *r = talloc_get_type(req->ndr.struct_ptr,
+       struct drsuapi_DsReplicaUpdateRefs *r = talloc_get_type_abort(s->ndr_struct_ptr,
                                           struct drsuapi_DsReplicaUpdateRefs);
-       bool print = false;
 
-       if (req->p->conn->flags & DCERPC_DEBUG_PRINT_OUT) {
-               print = true;
-       }
+       s->ndr_struct_ptr = NULL;
 
-       c->status = dcerpc_ndr_request_recv(req);
+       c->status = dcerpc_drsuapi_DsReplicaUpdateRefs_r_recv(subreq, r);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
-       if (print) {
-               NDR_PRINT_OUT_DEBUG(drsuapi_DsReplicaUpdateRefs, r);
-       }
-
        if (!W_ERROR_IS_OK(r->out.result)) {
                composite_error(c, werror_to_ntstatus(r->out.result));
                return;
@@ -2831,17 +2957,20 @@ static void becomeDC_drsuapi2_update_refs_schema_recv(struct rpc_request *req)
                                          becomeDC_drsuapi2_update_refs_config_recv);
 }
 
-static void becomeDC_drsuapi2_update_refs_domain_recv(struct rpc_request *req);
+static void becomeDC_drsuapi2_update_refs_domain_recv(struct tevent_req *subreq);
 
-static void becomeDC_drsuapi2_update_refs_config_recv(struct rpc_request *req)
+static void becomeDC_drsuapi2_update_refs_config_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
-       struct drsuapi_DsReplicaUpdateRefs *r = talloc_get_type(req->ndr.struct_ptr,
+       struct drsuapi_DsReplicaUpdateRefs *r = talloc_get_type(s->ndr_struct_ptr,
                                           struct drsuapi_DsReplicaUpdateRefs);
 
-       c->status = dcerpc_ndr_request_recv(req);
+       s->ndr_struct_ptr = NULL;
+
+       c->status = dcerpc_drsuapi_DsReplicaUpdateRefs_r_recv(subreq, r);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
        if (!W_ERROR_IS_OK(r->out.result)) {
@@ -2855,15 +2984,18 @@ static void becomeDC_drsuapi2_update_refs_config_recv(struct rpc_request *req)
                                          becomeDC_drsuapi2_update_refs_domain_recv);
 }
 
-static void becomeDC_drsuapi2_update_refs_domain_recv(struct rpc_request *req)
+static void becomeDC_drsuapi2_update_refs_domain_recv(struct tevent_req *subreq)
 {
-       struct libnet_BecomeDC_state *s = talloc_get_type(req->async.private_data,
+       struct libnet_BecomeDC_state *s = tevent_req_callback_data(subreq,
                                          struct libnet_BecomeDC_state);
        struct composite_context *c = s->creq;
-       struct drsuapi_DsReplicaUpdateRefs *r = talloc_get_type(req->ndr.struct_ptr,
+       struct drsuapi_DsReplicaUpdateRefs *r = talloc_get_type(s->ndr_struct_ptr,
                                           struct drsuapi_DsReplicaUpdateRefs);
 
-       c->status = dcerpc_ndr_request_recv(req);
+       s->ndr_struct_ptr = NULL;
+
+       c->status = dcerpc_drsuapi_DsReplicaUpdateRefs_r_recv(subreq, r);
+       TALLOC_FREE(subreq);
        if (!composite_is_ok(c)) return;
 
        if (!W_ERROR_IS_OK(r->out.result)) {
@@ -2881,7 +3013,7 @@ static NTSTATUS becomeDC_ldap2_modify_computer(struct libnet_BecomeDC_state *s)
 {
        int ret;
        struct ldb_message *msg;
-       uint32_t i;
+       unsigned int i;
        uint32_t user_account_control = UF_SERVER_TRUST_ACCOUNT |
                                        UF_TRUSTED_FOR_DELEGATION;
 
@@ -2896,8 +3028,9 @@ static NTSTATUS becomeDC_ldap2_modify_computer(struct libnet_BecomeDC_state *s)
        msg->dn = ldb_dn_new(msg, s->ldap2.ldb, s->dest_dsa.computer_dn_str);
        NT_STATUS_HAVE_NO_MEMORY(msg->dn);
 
-       ret = ldb_msg_add_fmt(msg, "userAccountControl", "%u", user_account_control);
-       if (ret != 0) {
+       ret = samdb_msg_add_uint(s->ldap2.ldb, msg, msg, "userAccountControl",
+                                user_account_control);
+       if (ret != LDB_SUCCESS) {
                talloc_free(msg);
                return NT_STATUS_NO_MEMORY;
        }
@@ -2925,7 +3058,8 @@ static NTSTATUS becomeDC_ldap2_move_computer(struct libnet_BecomeDC_state *s)
        struct ldb_dn *old_dn;
        struct ldb_dn *new_dn;
 
-       ret = dsdb_wellknown_dn(s->ldap2.ldb, s, samdb_base_dn(s->ldap2.ldb),
+       ret = dsdb_wellknown_dn(s->ldap2.ldb, s,
+                               ldb_get_default_basedn(s->ldap2.ldb),
                                DS_GUID_DOMAIN_CONTROLLERS_CONTAINER,
                                &new_dn);
        if (ret != LDB_SUCCESS) {
@@ -3017,6 +3151,9 @@ struct composite_context *libnet_BecomeDC_send(struct libnet_context *ctx, TALLO
        /* Callback function pointers */
        s->callbacks = r->in.callbacks;
 
+        /* RODC join*/
+        s->rodc_join = r->in.rodc_join;
+
        becomeDC_send_cldap(s);
        return c;
 }