s4:ldif_handlers Allow a binary nTsecurityDescriptor when parsing LDIF
[ira/wip.git] / source4 / lib / ldb-samba / ldif_handlers.c
index fb9ac8f8da3e48aceb30a7240de88d183585e2ae..606d4df76114bea0606da3c4aecd3081c39ee5f5 100644 (file)
@@ -3,6 +3,7 @@
 
    Copyright (C) Andrew Tridgell 2005
    Copyright (C) Andrew Bartlett 2006-2007
+   Copyright (C) Matthias Dieter Wallnöfer 2009
      ** NOTE! The following LGPL license applies to the ldb
      ** library. This does NOT imply that all of Samba is released
      ** under the LGPL
@@ -22,7 +23,9 @@
 */
 
 #include "includes.h"
-#include "lib/ldb/include/ldb_includes.h"
+#include "lib/ldb/include/ldb.h"
+#include "lib/ldb/include/ldb_module.h"
+#include "ldb_handlers.h"
 #include "dsdb/samdb/samdb.h"
 #include "librpc/gen_ndr/ndr_security.h"
 #include "librpc/gen_ndr/ndr_misc.h"
@@ -38,7 +41,7 @@ static int ldif_read_objectSid(struct ldb_context *ldb, void *mem_ctx,
 {
        enum ndr_err_code ndr_err;
        struct dom_sid *sid;
-       sid = dom_sid_parse_talloc(mem_ctx, (const char *)in->data);
+       sid = dom_sid_parse_length(mem_ctx, in);
        if (sid == NULL) {
                return -1;
        }
@@ -64,22 +67,21 @@ static int ldif_write_objectSid(struct ldb_context *ldb, void *mem_ctx,
        if (sid == NULL) {
                return -1;
        }
-       ndr_err = ndr_pull_struct_blob(in, sid, NULL, sid,
-                                      (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+       ndr_err = ndr_pull_struct_blob_all(in, sid, NULL, sid,
+                                          (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(sid);
                return -1;
        }
-       out->data = (uint8_t *)dom_sid_string(mem_ctx, sid);
+       *out = data_blob_string_const(dom_sid_string(mem_ctx, sid));
        talloc_free(sid);
        if (out->data == NULL) {
                return -1;
        }
-       out->length = strlen((const char *)out->data);
        return 0;
 }
 
-static bool ldb_comparision_objectSid_isString(const struct ldb_val *v)
+static bool ldif_comparision_objectSid_isString(const struct ldb_val *v)
 {
        if (v->length < 3) {
                return false;
@@ -93,27 +95,29 @@ static bool ldb_comparision_objectSid_isString(const struct ldb_val *v)
 /*
   compare two objectSids
 */
-static int ldb_comparison_objectSid(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_comparison_objectSid(struct ldb_context *ldb, void *mem_ctx,
                                    const struct ldb_val *v1, const struct ldb_val *v2)
 {
-       if (ldb_comparision_objectSid_isString(v1) && ldb_comparision_objectSid_isString(v2)) {
-               return strcmp((const char *)v1->data, (const char *)v2->data);
-       } else if (ldb_comparision_objectSid_isString(v1)
-                  && !ldb_comparision_objectSid_isString(v2)) {
+       if (ldif_comparision_objectSid_isString(v1) && ldif_comparision_objectSid_isString(v2)) {
+               return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
+       } else if (ldif_comparision_objectSid_isString(v1)
+                  && !ldif_comparision_objectSid_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectSid(ldb, mem_ctx, v1, &v) != 0) {
-                       return -1;
+                       /* Perhaps not a string after all */
+                       return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
                }
                ret = ldb_comparison_binary(ldb, mem_ctx, &v, v2);
                talloc_free(v.data);
                return ret;
-       } else if (!ldb_comparision_objectSid_isString(v1)
-                  && ldb_comparision_objectSid_isString(v2)) {
+       } else if (!ldif_comparision_objectSid_isString(v1)
+                  && ldif_comparision_objectSid_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectSid(ldb, mem_ctx, v2, &v) != 0) {
-                       return -1;
+                       /* Perhaps not a string after all */
+                       return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
                }
                ret = ldb_comparison_binary(ldb, mem_ctx, v1, &v);
                talloc_free(v.data);
@@ -125,15 +129,49 @@ static int ldb_comparison_objectSid(struct ldb_context *ldb, void *mem_ctx,
 /*
   canonicalise a objectSid
 */
-static int ldb_canonicalise_objectSid(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_canonicalise_objectSid(struct ldb_context *ldb, void *mem_ctx,
                                      const struct ldb_val *in, struct ldb_val *out)
 {
-       if (ldb_comparision_objectSid_isString(in)) {
-               return ldif_read_objectSid(ldb, mem_ctx, in, out);
+       if (ldif_comparision_objectSid_isString(in)) {
+               if (ldif_read_objectSid(ldb, mem_ctx, in, out) != 0) {
+                       /* Perhaps not a string after all */
+                       return ldb_handler_copy(ldb, mem_ctx, in, out);
+               }
+               return 0;
        }
        return ldb_handler_copy(ldb, mem_ctx, in, out);
 }
 
+static int extended_dn_read_SID(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
+{
+       struct dom_sid sid;
+       enum ndr_err_code ndr_err;
+       if (ldif_comparision_objectSid_isString(in)) {
+               if (ldif_read_objectSid(ldb, mem_ctx, in, out) == 0) {
+                       return 0;
+               }
+       }
+       
+       /* Perhaps not a string after all */
+       *out = data_blob_talloc(mem_ctx, NULL, in->length/2+1);
+
+       if (!out->data) {
+               return -1;
+       }
+
+       (*out).length = strhex_to_str((char *)out->data, out->length,
+                                    (const char *)in->data, in->length);
+
+       /* Check it looks like a SID */
+       ndr_err = ndr_pull_struct_blob_all(out, mem_ctx, NULL, &sid,
+                                          (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               return -1;
+       }
+       return 0;
+}
+
 /*
   convert a ldif formatted objectGUID to a NDR formatted blob
 */
@@ -144,7 +182,7 @@ static int ldif_read_objectGUID(struct ldb_context *ldb, void *mem_ctx,
        NTSTATUS status;
        enum ndr_err_code ndr_err;
 
-       status = GUID_from_string((const char *)in->data, &guid);
+       status = GUID_from_data_blob(in, &guid);
        if (!NT_STATUS_IS_OK(status)) {
                return -1;
        }
@@ -165,8 +203,8 @@ static int ldif_write_objectGUID(struct ldb_context *ldb, void *mem_ctx,
 {
        struct GUID guid;
        enum ndr_err_code ndr_err;
-       ndr_err = ndr_pull_struct_blob(in, mem_ctx, NULL, &guid,
-                                      (ndr_pull_flags_fn_t)ndr_pull_GUID);
+       ndr_err = ndr_pull_struct_blob_all(in, mem_ctx, NULL, &guid,
+                                          (ndr_pull_flags_fn_t)ndr_pull_GUID);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                return -1;
        }
@@ -178,48 +216,72 @@ static int ldif_write_objectGUID(struct ldb_context *ldb, void *mem_ctx,
        return 0;
 }
 
-static bool ldb_comparision_objectGUID_isString(const struct ldb_val *v)
+static bool ldif_comparision_objectGUID_isString(const struct ldb_val *v)
 {
-       struct GUID guid;
-       NTSTATUS status;
+       if (v->length != 36 && v->length != 38) return false;
 
-       if (v->length < 33) return false;
-
-       /* see if the input if null-terninated (safety check for the below) */
-       if (v->data[v->length] != '\0') return false;
+       /* Might be a GUID string, can't be a binary GUID (fixed 16 bytes) */
+       return true;
+}
 
-       status = GUID_from_string((const char *)v->data, &guid);
-       if (!NT_STATUS_IS_OK(status)) {
-               return false;
+static int extended_dn_read_GUID(struct ldb_context *ldb, void *mem_ctx,
+                             const struct ldb_val *in, struct ldb_val *out)
+{
+       struct GUID guid;
+       enum ndr_err_code ndr_err;
+       if (in->length == 36 && ldif_read_objectGUID(ldb, mem_ctx, in, out) == 0) {
+               return 0;
        }
 
-       return true;
+       /* Try as 'hex' form */
+       if (in->length != 32) {
+               return -1;
+       }
+               
+       *out = data_blob_talloc(mem_ctx, NULL, in->length/2+1);
+       
+       if (!out->data) {
+               return -1;
+       }
+       
+       (*out).length = strhex_to_str((char *)out->data, out->length,
+                                     (const char *)in->data, in->length);
+       
+       /* Check it looks like a GUID */
+       ndr_err = ndr_pull_struct_blob_all(out, mem_ctx, NULL, &guid,
+                                          (ndr_pull_flags_fn_t)ndr_pull_GUID);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               return -1;
+       }
+       return 0;
 }
 
 /*
   compare two objectGUIDs
 */
-static int ldb_comparison_objectGUID(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_comparison_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                                     const struct ldb_val *v1, const struct ldb_val *v2)
 {
-       if (ldb_comparision_objectGUID_isString(v1) && ldb_comparision_objectGUID_isString(v2)) {
-               return strcmp((const char *)v1->data, (const char *)v2->data);
-       } else if (ldb_comparision_objectGUID_isString(v1)
-                  && !ldb_comparision_objectGUID_isString(v2)) {
+       if (ldif_comparision_objectGUID_isString(v1) && ldif_comparision_objectGUID_isString(v2)) {
+               return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
+       } else if (ldif_comparision_objectGUID_isString(v1)
+                  && !ldif_comparision_objectGUID_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectGUID(ldb, mem_ctx, v1, &v) != 0) {
-                       return -1;
+                       /* Perhaps it wasn't a valid string after all */
+                       return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
                }
                ret = ldb_comparison_binary(ldb, mem_ctx, &v, v2);
                talloc_free(v.data);
                return ret;
-       } else if (!ldb_comparision_objectGUID_isString(v1)
-                  && ldb_comparision_objectGUID_isString(v2)) {
+       } else if (!ldif_comparision_objectGUID_isString(v1)
+                  && ldif_comparision_objectGUID_isString(v2)) {
                struct ldb_val v;
                int ret;
                if (ldif_read_objectGUID(ldb, mem_ctx, v2, &v) != 0) {
-                       return -1;
+                       /* Perhaps it wasn't a valid string after all */
+                       return ldb_comparison_binary(ldb, mem_ctx, v1, v2);
                }
                ret = ldb_comparison_binary(ldb, mem_ctx, v1, &v);
                talloc_free(v.data);
@@ -231,11 +293,15 @@ static int ldb_comparison_objectGUID(struct ldb_context *ldb, void *mem_ctx,
 /*
   canonicalise a objectGUID
 */
-static int ldb_canonicalise_objectGUID(struct ldb_context *ldb, void *mem_ctx,
+static int ldif_canonicalise_objectGUID(struct ldb_context *ldb, void *mem_ctx,
                                       const struct ldb_val *in, struct ldb_val *out)
 {
-       if (ldb_comparision_objectGUID_isString(in)) {
-               return ldif_read_objectGUID(ldb, mem_ctx, in, out);
+       if (ldif_comparision_objectGUID_isString(in)) {
+               if (ldif_read_objectGUID(ldb, mem_ctx, in, out) != 0) {
+                       /* Perhaps it wasn't a valid string after all */
+                       return ldb_handler_copy(ldb, mem_ctx, in, out);
+               }
+               return 0;
        }
        return ldb_handler_copy(ldb, mem_ctx, in, out);
 }
@@ -248,18 +314,34 @@ static int ldif_read_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ctx
                                          const struct ldb_val *in, struct ldb_val *out)
 {
        struct security_descriptor *sd;
+
        enum ndr_err_code ndr_err;
 
-       sd = sddl_decode(mem_ctx, (const char *)in->data, NULL);
+       sd = talloc(mem_ctx, struct security_descriptor);
        if (sd == NULL) {
                return -1;
        }
+
+       ndr_err = ndr_pull_struct_blob(in, sd, NULL, sd,
+                                      (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               /* If this does not parse, then it is probably SDDL, and we should try it that way */
+               
+               struct dom_sid *sid = samdb_domain_sid(ldb);
+               talloc_free(sd);
+               sd = sddl_decode(mem_ctx, (const char *)in->data, sid);
+               if (sd == NULL) {
+                       return -1;
+               }
+       }
+
        ndr_err = ndr_push_struct_blob(out, mem_ctx, NULL, sd,
                                       (ndr_push_flags_fn_t)ndr_push_security_descriptor);
        talloc_free(sd);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                return -1;
        }
+
        return 0;
 }
 
@@ -276,8 +358,9 @@ static int ldif_write_ntSecurityDescriptor(struct ldb_context *ldb, void *mem_ct
        if (sd == NULL) {
                return -1;
        }
+       /* We can't use ndr_pull_struct_blob_all because this contains relative pointers */
        ndr_err = ndr_pull_struct_blob(in, sd, NULL, sd,
-                                      (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
+                                          (ndr_pull_flags_fn_t)ndr_pull_security_descriptor);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(sd);
                return -1;
@@ -301,7 +384,7 @@ static int ldif_canonicalise_objectCategory(struct ldb_context *ldb, void *mem_c
 {
        struct ldb_dn *dn1 = NULL;
        const struct dsdb_schema *schema = dsdb_get_schema(ldb);
-       const struct dsdb_class *class;
+       const struct dsdb_class *sclass;
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
        if (!tmp_ctx) {
                return LDB_ERR_OPERATIONS_ERROR;
@@ -314,13 +397,13 @@ static int ldif_canonicalise_objectCategory(struct ldb_context *ldb, void *mem_c
                }
                return LDB_SUCCESS;
        }
-       dn1 = ldb_dn_new(tmp_ctx, ldb, (char *)in->data);
+       dn1 = ldb_dn_from_ldb_val(tmp_ctx, ldb, in);
        if ( ! ldb_dn_validate(dn1)) {
                const char *lDAPDisplayName = talloc_strndup(tmp_ctx, (char *)in->data, in->length);
-               class = dsdb_class_by_lDAPDisplayName(schema, lDAPDisplayName);
-               if (class) {
+               sclass = dsdb_class_by_lDAPDisplayName(schema, lDAPDisplayName);
+               if (sclass) {
                        struct ldb_dn *dn = ldb_dn_new(mem_ctx, ldb,  
-                                                      class->defaultObjectCategory);
+                                                      sclass->defaultObjectCategory);
                        *out = data_blob_string_const(ldb_dn_alloc_casefold(mem_ctx, dn));
                        talloc_free(tmp_ctx);
 
@@ -383,12 +466,25 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        enum ndr_err_code ndr_err;
        char *string, *line, *p, *oid;
 
-       blob = talloc_zero(mem_ctx, struct prefixMapBlob);
+       TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
+
+       if (tmp_ctx == NULL) {
+               return -1;
+       }
+
+       blob = talloc_zero(tmp_ctx, struct prefixMapBlob);
        if (blob == NULL) {
+               talloc_free(blob);
                return -1;
        }
+
+       blob->version = PREFIX_MAP_VERSION_DSDB;
        
-       string = (const char *)in->data;
+       string = talloc_strndup(mem_ctx, (const char *)in->data, in->length);
+       if (string == NULL) {
+               talloc_free(blob);
+               return -1;
+       }
 
        line = string;
        while (line && line[0]) {
@@ -396,23 +492,29 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                if (p) {
                        p[0] = '\0';
                } else {
-                       p=strchr(string, '\n');
+                       p=strchr(line, '\n');
                        if (p) {
                                p[0] = '\0';
                        }
                }
+               /* allow a traling seperator */
+               if (line == p) {
+                       break;
+               }
                
                blob->ctr.dsdb.mappings = talloc_realloc(blob, 
                                                         blob->ctr.dsdb.mappings, 
                                                         struct drsuapi_DsReplicaOIDMapping,
                                                         blob->ctr.dsdb.num_mappings+1);
                if (!blob->ctr.dsdb.mappings) {
+                       talloc_free(tmp_ctx);
                        return -1;
                }
 
-               blob->ctr.dsdb.mappings[blob->ctr.dsdb.num_mappings].id_prefix = strtoul(p, &oid, 10);
+               blob->ctr.dsdb.mappings[blob->ctr.dsdb.num_mappings].id_prefix = strtoul(line, &oid, 10);
 
                if (oid[0] != ':') {
+                       talloc_free(tmp_ctx);
                        return -1;
                }
 
@@ -424,8 +526,9 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
 
                blob->ctr.dsdb.num_mappings++;
 
+               /* Now look past the terminator we added above */
                if (p) {
-                       line = p++;
+                       line = p + 1;
                } else {
                        line = NULL;
                }
@@ -435,7 +538,7 @@ static int ldif_read_prefixMap(struct ldb_context *ldb, void *mem_ctx,
                                       lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
                                       blob,
                                       (ndr_push_flags_fn_t)ndr_push_prefixMapBlob);
-       talloc_free(blob);
+       talloc_free(tmp_ctx);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                return -1;
        }
@@ -450,16 +553,17 @@ static int ldif_write_prefixMap(struct ldb_context *ldb, void *mem_ctx,
 {
        struct prefixMapBlob *blob;
        enum ndr_err_code ndr_err;
+       char *string;
        uint32_t i;
 
        blob = talloc(mem_ctx, struct prefixMapBlob);
        if (blob == NULL) {
                return -1;
        }
-       ndr_err = ndr_pull_struct_blob(in, blob, 
-                                      lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
-                                      blob,
-                                      (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
+       ndr_err = ndr_pull_struct_blob_all(in, blob, 
+                                          lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
+                                          blob,
+                                          (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(blob);
                return -1;
@@ -467,25 +571,25 @@ static int ldif_write_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        if (blob->version != PREFIX_MAP_VERSION_DSDB) {
                return -1;
        }
-       out->data = talloc_strdup(mem_ctx, "");
-       if (out->data == NULL) {
+       string = talloc_strdup(mem_ctx, "");
+       if (string == NULL) {
                return -1;
        }
 
        for (i=0; i < blob->ctr.dsdb.num_mappings; i++) {
                if (i > 0) {
-                       out->data = talloc_asprintf_append(out->data, ";"); 
+                       string = talloc_asprintf_append(string, ";"); 
                }
-               out->data = talloc_asprintf_append(out->data, "%u: %s", 
+               string = talloc_asprintf_append(string, "%u:%s", 
                                                   blob->ctr.dsdb.mappings[i].id_prefix,
                                                   blob->ctr.dsdb.mappings[i].oid.oid);
-               if (out->data == NULL) {
+               if (string == NULL) {
                        return -1;
                }
        }
 
        talloc_free(blob);
-       out->length = strlen((const char *)out->data);
+       *out = data_blob_string_const(string);
        return 0;
 }
 
@@ -540,46 +644,101 @@ static int ldif_comparison_prefixMap(struct ldb_context *ldb, void *mem_ctx,
        return ret;
 }
 
-#define LDB_SYNTAX_SAMBA_SID                   "LDB_SYNTAX_SAMBA_SID"
-#define LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR   "LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR"
-#define LDB_SYNTAX_SAMBA_GUID                  "LDB_SYNTAX_SAMBA_GUID"
-#define LDB_SYNTAX_SAMBA_OBJECT_CATEGORY       "LDB_SYNTAX_SAMBA_OBJECT_CATEGORY"
-#define LDB_SYNTAX_SAMBA_PREFIX_MAP    "LDB_SYNTAX_SAMBA_PREFIX_MAP"
+/* Canonicalisation of two 32-bit integers */
+static int ldif_canonicalise_int32(struct ldb_context *ldb, void *mem_ctx,
+                       const struct ldb_val *in, struct ldb_val *out)
+{
+       char *end;
+       int32_t i = (int32_t) strtol((char *)in->data, &end, 0);
+       if (*end != 0) {
+               return -1;
+       }
+       out->data = (uint8_t *) talloc_asprintf(mem_ctx, "%d", i);
+       if (out->data == NULL) {
+               return -1;
+       }
+       out->length = strlen((char *)out->data);
+       return 0;
+}
+
+/* Comparison of two 32-bit integers */
+static int ldif_comparison_int32(struct ldb_context *ldb, void *mem_ctx,
+                       const struct ldb_val *v1, const struct ldb_val *v2)
+{
+       return (int32_t) strtol((char *)v1->data, NULL, 0)
+        - (int32_t) strtol((char *)v2->data, NULL, 0);
+}
+
+static int extended_dn_write_hex(struct ldb_context *ldb, void *mem_ctx,
+                                const struct ldb_val *in, struct ldb_val *out)
+{
+       *out = data_blob_string_const(data_blob_hex_string(mem_ctx, in));
+       if (!out->data) {
+               return -1;
+       }
+       return 0;
+}
 
 static const struct ldb_schema_syntax samba_syntaxes[] = {
        {
-               .name           = LDB_SYNTAX_SAMBA_SID,
-               .ldif_read_fn   = ldif_read_objectSid,
-               .ldif_write_fn  = ldif_write_objectSid,
-               .canonicalise_fn= ldb_canonicalise_objectSid,
-               .comparison_fn  = ldb_comparison_objectSid
+               .name             = LDB_SYNTAX_SAMBA_SID,
+               .ldif_read_fn     = ldif_read_objectSid,
+               .ldif_write_fn    = ldif_write_objectSid,
+               .canonicalise_fn  = ldif_canonicalise_objectSid,
+               .comparison_fn    = ldif_comparison_objectSid
+       },{
+               .name             = LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR,
+               .ldif_read_fn     = ldif_read_ntSecurityDescriptor,
+               .ldif_write_fn    = ldif_write_ntSecurityDescriptor,
+               .canonicalise_fn  = ldb_handler_copy,
+               .comparison_fn    = ldb_comparison_binary
+       },{
+               .name             = LDB_SYNTAX_SAMBA_GUID,
+               .ldif_read_fn     = ldif_read_objectGUID,
+               .ldif_write_fn    = ldif_write_objectGUID,
+               .canonicalise_fn  = ldif_canonicalise_objectGUID,
+               .comparison_fn    = ldif_comparison_objectGUID
        },{
-               .name           = LDB_SYNTAX_SAMBA_SECURITY_DESCRIPTOR,
-               .ldif_read_fn   = ldif_read_ntSecurityDescriptor,
-               .ldif_write_fn  = ldif_write_ntSecurityDescriptor,
-               .canonicalise_fn= ldb_handler_copy,
-               .comparison_fn  = ldb_comparison_binary
+               .name             = LDB_SYNTAX_SAMBA_OBJECT_CATEGORY,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldb_handler_copy,
+               .canonicalise_fn  = ldif_canonicalise_objectCategory,
+               .comparison_fn    = ldif_comparison_objectCategory
        },{
-               .name           = LDB_SYNTAX_SAMBA_GUID,
-               .ldif_read_fn   = ldif_read_objectGUID,
-               .ldif_write_fn  = ldif_write_objectGUID,
-               .canonicalise_fn= ldb_canonicalise_objectGUID,
-               .comparison_fn  = ldb_comparison_objectGUID
+               .name             = LDB_SYNTAX_SAMBA_PREFIX_MAP,
+               .ldif_read_fn     = ldif_read_prefixMap,
+               .ldif_write_fn    = ldif_write_prefixMap,
+               .canonicalise_fn  = ldif_canonicalise_prefixMap,
+               .comparison_fn    = ldif_comparison_prefixMap
+       },{
+               .name             = LDB_SYNTAX_SAMBA_INT32,
+               .ldif_read_fn     = ldb_handler_copy,
+               .ldif_write_fn    = ldb_handler_copy,
+               .canonicalise_fn  = ldif_canonicalise_int32,
+               .comparison_fn    = ldif_comparison_int32
+       }
+};
+
+static const struct ldb_dn_extended_syntax samba_dn_syntax[] = {
+       {
+               .name             = "SID",
+               .read_fn          = extended_dn_read_SID,
+               .write_clear_fn   = ldif_write_objectSid,
+               .write_hex_fn     = extended_dn_write_hex
        },{
-               .name           = LDB_SYNTAX_SAMBA_OBJECT_CATEGORY,
-               .ldif_read_fn   = ldb_handler_copy,
-               .ldif_write_fn  = ldb_handler_copy,
-               .canonicalise_fn= ldif_canonicalise_objectCategory,
-               .comparison_fn  = ldif_comparison_objectCategory
+               .name             = "GUID",
+               .read_fn          = extended_dn_read_GUID,
+               .write_clear_fn   = ldif_write_objectGUID,
+               .write_hex_fn     = extended_dn_write_hex
        },{
-               .name           = LDB_SYNTAX_SAMBA_PREFIX_MAP,
-               .ldif_read_fn   = ldif_read_prefixMap,
-               .ldif_write_fn  = ldif_write_prefixMap,
-               .canonicalise_fn= ldif_canonicalise_prefixMap,
-               .comparison_fn  = ldif_comparison_prefixMap
+               .name             = "WKGUID",
+               .read_fn          = ldb_handler_copy,
+               .write_clear_fn   = ldb_handler_copy,
+               .write_hex_fn     = ldb_handler_copy
        }
 };
 
+/* TODO: Should be dynamic at some point */
 static const struct {
        const char *name;
        const char *syntax;
@@ -598,22 +757,38 @@ static const struct {
        { "fRSReplicaSetGUID",          LDB_SYNTAX_SAMBA_GUID },
        { "netbootGUID",                LDB_SYNTAX_SAMBA_GUID },
        { "objectCategory",             LDB_SYNTAX_SAMBA_OBJECT_CATEGORY },
-       { "member",                     LDB_SYNTAX_DN },
-       { "memberOf",                   LDB_SYNTAX_DN },
-       { "nCName",                     LDB_SYNTAX_DN },
-       { "schemaNamingContext",        LDB_SYNTAX_DN },
-       { "configurationNamingContext", LDB_SYNTAX_DN },
-       { "rootDomainNamingContext",    LDB_SYNTAX_DN },
-       { "defaultNamingContext",       LDB_SYNTAX_DN },
-       { "subRefs",                    LDB_SYNTAX_DN },
-       { "dMDLocation",                LDB_SYNTAX_DN },
-       { "serverReference",            LDB_SYNTAX_DN },
-       { "masteredBy",                 LDB_SYNTAX_DN },
-       { "msDs-masteredBy",            LDB_SYNTAX_DN },
-       { "fSMORoleOwner",              LDB_SYNTAX_DN },
        { "prefixMap",                  LDB_SYNTAX_SAMBA_PREFIX_MAP }
 };
 
+const struct ldb_schema_syntax *ldb_samba_syntax_by_name(struct ldb_context *ldb, const char *name)
+{
+       uint32_t j;
+       const struct ldb_schema_syntax *s = NULL;
+       
+       for (j=0; j < ARRAY_SIZE(samba_syntaxes); j++) {
+               if (strcmp(name, samba_syntaxes[j].name) == 0) {
+                       s = &samba_syntaxes[j];
+                       break;
+               }
+       }
+       return s;
+}
+
+const struct ldb_schema_syntax *ldb_samba_syntax_by_lDAPDisplayName(struct ldb_context *ldb, const char *name)
+{
+       uint32_t j;
+       const struct ldb_schema_syntax *s = NULL;
+
+       for (j=0; j < ARRAY_SIZE(samba_attributes); j++) {
+               if (strcmp(samba_attributes[j].name, name) == 0) {
+                       s = ldb_samba_syntax_by_name(ldb, samba_attributes[j].syntax);
+                       break;
+               }
+       }
+       
+       return s;
+}
+
 /*
   register the samba ldif handlers
 */
@@ -623,15 +798,9 @@ int ldb_register_samba_handlers(struct ldb_context *ldb)
 
        for (i=0; i < ARRAY_SIZE(samba_attributes); i++) {
                int ret;
-               uint32_t j;
                const struct ldb_schema_syntax *s = NULL;
 
-               for (j=0; j < ARRAY_SIZE(samba_syntaxes); j++) {
-                       if (strcmp(samba_attributes[i].syntax, samba_syntaxes[j].name) == 0) {
-                               s = &samba_syntaxes[j];
-                               break;
-                       }
-               }
+               s = ldb_samba_syntax_by_name(ldb, samba_attributes[i].syntax);
 
                if (!s) {
                        s = ldb_standard_syntax_by_name(ldb, samba_attributes[i].syntax);
@@ -641,11 +810,21 @@ int ldb_register_samba_handlers(struct ldb_context *ldb)
                        return -1;
                }
 
-               ret = ldb_schema_attribute_add_with_syntax(ldb, samba_attributes[i].name, 0, s);
+               ret = ldb_schema_attribute_add_with_syntax(ldb, samba_attributes[i].name, LDB_ATTR_FLAG_FIXED, s);
                if (ret != LDB_SUCCESS) {
                        return ret;
                }
        }
 
+       for (i=0; i < ARRAY_SIZE(samba_dn_syntax); i++) {
+               int ret;
+               ret = ldb_dn_extended_add_syntax(ldb, LDB_ATTR_FLAG_FIXED, &samba_dn_syntax[i]);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
+
+               
+       }
+
        return LDB_SUCCESS;
 }