s4-kdc: Migrate to tsocket_address.
[ira/wip.git] / source4 / kdc / kdc.c
index 1cfe9852f0532a22fd396f60cce0ecb558ea1408..6a9df0bf02f88b3a3d6cb636320f18e3c325f8f6 100644 (file)
@@ -28,6 +28,7 @@
 #include "smbd/process_model.h"
 #include "lib/events/events.h"
 #include "lib/socket/socket.h"
+#include "lib/tsocket/tsocket.h"
 #include "system/network.h"
 #include "../lib/util/dlinklist.h"
 #include "lib/messaging/irpc.h"
@@ -43,9 +44,9 @@
 
 /* Disgusting hack to get a mem_ctx and lp_ctx into the hdb plugin, when 
  * used as a keytab */
-TALLOC_CTX *kdc_mem_ctx;
-struct tevent_context *kdc_ev_ctx;
-struct loadparm_context *kdc_lp_ctx;
+TALLOC_CTX *hdb_samba4_mem_ctx;
+struct tevent_context *hdb_samba4_ev_ctx;
+struct loadparm_context *hdb_samba4_lp_ctx;
 
 /* hold all the info needed to send a reply */
 struct kdc_reply {
@@ -58,8 +59,8 @@ typedef bool (*kdc_process_fn_t)(struct kdc_server *kdc,
                                 TALLOC_CTX *mem_ctx, 
                                 DATA_BLOB *input, 
                                 DATA_BLOB *reply,
-                                struct socket_address *peer_addr, 
-                                struct socket_address *my_addr, 
+                                struct tsocket_address *peer_addr,
+                                struct tsocket_address *my_addr,
                                 int datagram);
 
 /* hold information about one kdc socket */
@@ -130,6 +131,8 @@ static void kdc_recv_handler(struct kdc_socket *kdc_socket)
        size_t nread, dsize;
        struct socket_address *src;
        struct socket_address *my_addr;
+       struct tsocket_address *tsrcaddr;
+       struct tsocket_address *tmyaddr;
        int ret;
 
        status = socket_pending(kdc_socket->sock, &dsize);
@@ -162,13 +165,27 @@ static void kdc_recv_handler(struct kdc_socket *kdc_socket)
                return;
        }
 
+       ret = tsocket_address_bsd_from_sockaddr(tmp_ctx, src->sockaddr,
+                               src->sockaddrlen, &tsrcaddr);
+       if (ret < 0) {
+               talloc_free(tmp_ctx);
+               return;
+       }
+
+       ret = tsocket_address_bsd_from_sockaddr(tmp_ctx, my_addr->sockaddr,
+                               my_addr->sockaddrlen, &tmyaddr);
+       if (ret < 0) {
+               talloc_free(tmp_ctx);
+               return;
+       }
 
        /* Call krb5 */
        ret = kdc_socket->process(kdc_socket->kdc, 
                                  tmp_ctx, 
                                  &blob,  
                                  &reply,
-                                 src, my_addr,
+                                 tsrcaddr,
+                                 tmyaddr,
                                  1 /* Datagram */);
        if (!ret) {
                talloc_free(tmp_ctx);
@@ -229,6 +246,8 @@ static NTSTATUS kdc_tcp_recv(void *private_data, DATA_BLOB blob)
        DATA_BLOB input, reply;
        struct socket_address *src_addr;
        struct socket_address *my_addr;
+       struct tsocket_address *tsrcaddr;
+       struct tsocket_address *tmyaddr;
 
        talloc_steal(tmp_ctx, blob.data);
 
@@ -244,6 +263,20 @@ static NTSTATUS kdc_tcp_recv(void *private_data, DATA_BLOB blob)
                return NT_STATUS_NO_MEMORY;
        }
 
+       ret = tsocket_address_bsd_from_sockaddr(tmp_ctx, src_addr->sockaddr,
+                               src_addr->sockaddrlen, &tsrcaddr);
+       if (ret < 0) {
+               talloc_free(tmp_ctx);
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       ret = tsocket_address_bsd_from_sockaddr(tmp_ctx, my_addr->sockaddr,
+                               my_addr->sockaddrlen, &tmyaddr);
+       if (ret < 0) {
+               talloc_free(tmp_ctx);
+               return NT_STATUS_NO_MEMORY;
+       }
+
        /* Call krb5 */
        input = data_blob_const(blob.data + 4, blob.length - 4); 
 
@@ -251,8 +284,8 @@ static NTSTATUS kdc_tcp_recv(void *private_data, DATA_BLOB blob)
                               tmp_ctx,
                               &input,
                               &reply,
-                              src_addr,
-                              my_addr,
+                              tsrcaddr,
+                              tmyaddr,
                               0 /* Not datagram */);
        if (!ret) {
                talloc_free(tmp_ctx);
@@ -319,25 +352,37 @@ static bool kdc_process(struct kdc_server *kdc,
                        TALLOC_CTX *mem_ctx, 
                        DATA_BLOB *input, 
                        DATA_BLOB *reply,
-                       struct socket_address *peer_addr, 
-                       struct socket_address *my_addr,
+                       struct tsocket_address *peer_addr,
+                       struct tsocket_address *my_addr,
                        int datagram_reply)
 {
-       int ret;        
+       int ret;
+       char *pa;
+       struct sockaddr_storage ss;
        krb5_data k5_reply;
        krb5_data_zero(&k5_reply);
 
        krb5_kdc_update_time(NULL);
 
-       DEBUG(10,("Received KDC packet of length %lu from %s:%d\n", 
-                 (long)input->length - 4, peer_addr->addr, peer_addr->port));
+       ret = tsocket_address_bsd_sockaddr(peer_addr, (struct sockaddr *) &ss,
+                               sizeof(struct sockaddr_storage));
+       if (ret < 0) {
+               return false;
+       }
+       pa = tsocket_address_string(peer_addr, mem_ctx);
+       if (pa == NULL) {
+               return false;
+       }
+
+       DEBUG(10,("Received KDC packet of length %lu from %s\n",
+                               (long)input->length - 4, pa));
 
        ret = krb5_kdc_process_krb5_request(kdc->smb_krb5_context->krb5_context, 
                                            kdc->config,
                                            input->data, input->length,
                                            &k5_reply,
-                                           peer_addr->addr,
-                                           peer_addr->sockaddr,
+                                           pa,
+                                           (struct sockaddr *) &ss,
                                            datagram_reply);
        if (ret == -1) {
                *reply = data_blob(NULL, 0);
@@ -345,7 +390,7 @@ static bool kdc_process(struct kdc_server *kdc,
        }
        if (k5_reply.length) {
                *reply = data_blob_talloc(mem_ctx, k5_reply.data, k5_reply.length);
-               krb5_free_data_contents(kdc->smb_krb5_context->krb5_context, &k5_reply);
+               krb5_data_free(&k5_reply);
        } else {
                *reply = data_blob(NULL, 0);    
        }
@@ -355,9 +400,9 @@ static bool kdc_process(struct kdc_server *kdc,
 /*
   called when we get a new connection
 */
-static void kdc_tcp_generic_accept(struct stream_connection *conn, kdc_process_fn_t process_fn)
+static void kdc_tcp_accept(struct stream_connection *conn)
 {
-       struct kdc_server *kdc = talloc_get_type(conn->private_data, struct kdc_server);
+       struct kdc_socket *kdc_socket = talloc_get_type(conn->private_data, struct kdc_socket);
        struct kdc_tcp_connection *kdcconn;
 
        kdcconn = talloc_zero(conn, struct kdc_tcp_connection);
@@ -366,8 +411,8 @@ static void kdc_tcp_generic_accept(struct stream_connection *conn, kdc_process_f
                return;
        }
        kdcconn->conn    = conn;
-       kdcconn->kdc     = kdc;
-       kdcconn->process = process_fn;
+       kdcconn->kdc     = kdc_socket->kdc;
+       kdcconn->process = kdc_socket->process;
        conn->private_data    = kdcconn;
 
        kdcconn->packet = packet_init(kdcconn);
@@ -385,11 +430,6 @@ static void kdc_tcp_generic_accept(struct stream_connection *conn, kdc_process_f
        packet_set_serialise(kdcconn->packet);
 }
 
-static void kdc_tcp_accept(struct stream_connection *conn)
-{
-       kdc_tcp_generic_accept(conn, kdc_process);
-}
-
 static const struct stream_server_ops kdc_tcp_stream_ops = {
        .name                   = "kdc_tcp",
        .accept_connection      = kdc_tcp_accept,
@@ -397,112 +437,47 @@ static const struct stream_server_ops kdc_tcp_stream_ops = {
        .send_handler           = kdc_tcp_send
 };
 
-static void kpasswdd_tcp_accept(struct stream_connection *conn)
-{
-       kdc_tcp_generic_accept(conn, kpasswdd_process);
-}
-
-static const struct stream_server_ops kpasswdd_tcp_stream_ops = {
-       .name                   = "kpasswdd_tcp",
-       .accept_connection      = kpasswdd_tcp_accept,
-       .recv_handler           = kdc_tcp_recv_handler,
-       .send_handler           = kdc_tcp_send
-};
-
 /*
   start listening on the given address
 */
-static NTSTATUS kdc_add_socket(struct kdc_server *kdc, const char *address,
-                              uint16_t kdc_port, uint16_t kpasswd_port)
+static NTSTATUS kdc_add_socket(struct kdc_server *kdc,
+                              const struct model_ops *model_ops,
+                              const char *name,
+                              const char *address,
+                              uint16_t port,
+                              kdc_process_fn_t process)
 {
-       const struct model_ops *model_ops;
        struct kdc_socket *kdc_socket;
-       struct kdc_socket *kpasswd_socket;
-       struct socket_address *kdc_address, *kpasswd_address;
+       struct socket_address *socket_address;
        NTSTATUS status;
 
        kdc_socket = talloc(kdc, struct kdc_socket);
        NT_STATUS_HAVE_NO_MEMORY(kdc_socket);
 
-       kpasswd_socket = talloc(kdc, struct kdc_socket);
-       NT_STATUS_HAVE_NO_MEMORY(kpasswd_socket);
-
        status = socket_create("ip", SOCKET_TYPE_DGRAM, &kdc_socket->sock, 0);
        if (!NT_STATUS_IS_OK(status)) {
                talloc_free(kdc_socket);
                return status;
        }
 
-       status = socket_create("ip", SOCKET_TYPE_DGRAM, &kpasswd_socket->sock, 0);
-       if (!NT_STATUS_IS_OK(status)) {
-               talloc_free(kpasswd_socket);
-               return status;
-       }
-
        kdc_socket->kdc = kdc;
        kdc_socket->send_queue = NULL;
-       kdc_socket->process = kdc_process;
+       kdc_socket->process = process;
 
        talloc_steal(kdc_socket, kdc_socket->sock);
 
        kdc_socket->fde = event_add_fd(kdc->task->event_ctx, kdc, 
-                                      socket_get_fd(kdc_socket->sock), EVENT_FD_READ,
-                                      kdc_socket_handler, kdc_socket);
-
-       kdc_address = socket_address_from_strings(kdc_socket, kdc_socket->sock->backend_name, 
-                                                 address, kdc_port);
-       NT_STATUS_HAVE_NO_MEMORY(kdc_address);
-
-       status = socket_listen(kdc_socket->sock, kdc_address, 0, 0);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0,("Failed to bind to %s:%d UDP for kdc - %s\n", 
-                        address, kdc_port, nt_errstr(status)));
-               talloc_free(kdc_socket);
-               return status;
-       }
-
-       kpasswd_socket->kdc = kdc;
-       kpasswd_socket->send_queue = NULL;
-       kpasswd_socket->process = kpasswdd_process;
-
-       talloc_steal(kpasswd_socket, kpasswd_socket->sock);
-
-       kpasswd_socket->fde = event_add_fd(kdc->task->event_ctx, kdc, 
-                                          socket_get_fd(kpasswd_socket->sock), EVENT_FD_READ,
-                                          kdc_socket_handler, kpasswd_socket);
+                                          socket_get_fd(kdc_socket->sock), EVENT_FD_READ,
+                                          kdc_socket_handler, kdc_socket);
        
-       kpasswd_address = socket_address_from_strings(kpasswd_socket, kpasswd_socket->sock->backend_name, 
-                                                     address, kpasswd_port);
-       NT_STATUS_HAVE_NO_MEMORY(kpasswd_address);
+       socket_address = socket_address_from_strings(kdc_socket, kdc_socket->sock->backend_name, 
+                                                     address, port);
+       NT_STATUS_HAVE_NO_MEMORY_AND_FREE(socket_address, kdc_socket);
 
-       status = socket_listen(kpasswd_socket->sock, kpasswd_address, 0, 0);
+       status = socket_listen(kdc_socket->sock, socket_address, 0, 0);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0,("Failed to bind to %s:%d UDP for kpasswd - %s\n", 
-                        address, kpasswd_port, nt_errstr(status)));
-               talloc_free(kpasswd_socket);
-               return status;
-       }
-
-       /* within the kdc task we want to be a single process, so
-          ask for the single process model ops and pass these to the
-          stream_setup_socket() call. */
-       model_ops = process_model_startup(kdc->task->event_ctx, "single");
-       if (!model_ops) {
-               DEBUG(0,("Can't find 'single' process model_ops\n"));
-               talloc_free(kdc_socket);
-               return NT_STATUS_INTERNAL_ERROR;
-       }
-
-       status = stream_setup_socket(kdc->task->event_ctx, 
-                                    kdc->task->lp_ctx,
-                                    model_ops, 
-                                    &kdc_tcp_stream_ops, 
-                                    "ip", address, &kdc_port, 
-                                    lp_socket_options(kdc->task->lp_ctx), 
-                                    kdc);
-       if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0,("Failed to bind to %s:%u TCP - %s\n",
-                        address, kdc_port, nt_errstr(status)));
+               DEBUG(0,("Failed to bind to %s:%d UDP for %s - %s\n", 
+                        address, port, name, nt_errstr(status)));
                talloc_free(kdc_socket);
                return status;
        }
@@ -510,13 +485,13 @@ static NTSTATUS kdc_add_socket(struct kdc_server *kdc, const char *address,
        status = stream_setup_socket(kdc->task->event_ctx, 
                                     kdc->task->lp_ctx,
                                     model_ops, 
-                                    &kpasswdd_tcp_stream_ops, 
-                                    "ip", address, &kpasswd_port, 
+                                    &kdc_tcp_stream_ops, 
+                                    "ip", address, &port, 
                                     lp_socket_options(kdc->task->lp_ctx), 
-                                    kdc);
+                                    kdc_socket);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("Failed to bind to %s:%u TCP - %s\n",
-                        address, kpasswd_port, nt_errstr(status)));
+                        address, port, nt_errstr(status)));
                talloc_free(kdc_socket);
                return status;
        }
@@ -531,18 +506,41 @@ static NTSTATUS kdc_add_socket(struct kdc_server *kdc, const char *address,
 static NTSTATUS kdc_startup_interfaces(struct kdc_server *kdc, struct loadparm_context *lp_ctx,
                                       struct interface *ifaces)
 {
+       const struct model_ops *model_ops;
        int num_interfaces;
        TALLOC_CTX *tmp_ctx = talloc_new(kdc);
        NTSTATUS status;
        int i;
 
+       /* within the kdc task we want to be a single process, so
+          ask for the single process model ops and pass these to the
+          stream_setup_socket() call. */
+       model_ops = process_model_startup(kdc->task->event_ctx, "single");
+       if (!model_ops) {
+               DEBUG(0,("Can't find 'single' process model_ops\n"));
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
        num_interfaces = iface_count(ifaces);
        
        for (i=0; i<num_interfaces; i++) {
                const char *address = talloc_strdup(tmp_ctx, iface_n_ip(ifaces, i));
-               status = kdc_add_socket(kdc, address, lp_krb5_port(lp_ctx), 
-                                       lp_kpasswd_port(lp_ctx));
-               NT_STATUS_NOT_OK_RETURN(status);
+               uint16_t kdc_port = lp_krb5_port(lp_ctx);
+               uint16_t kpasswd_port = lp_kpasswd_port(lp_ctx);
+
+               if (kdc_port) {
+                       status = kdc_add_socket(kdc, model_ops,
+                                       "kdc", address, kdc_port,
+                                       kdc_process);
+                       NT_STATUS_NOT_OK_RETURN(status);
+               }
+
+               if (kpasswd_port) {
+                       status = kdc_add_socket(kdc, model_ops,
+                                       "kpasswd", address, kpasswd_port,
+                                       kpasswdd_process);
+                       NT_STATUS_NOT_OK_RETURN(status);
+               }
        }
 
        talloc_free(tmp_ctx);
@@ -550,15 +548,6 @@ static NTSTATUS kdc_startup_interfaces(struct kdc_server *kdc, struct loadparm_c
        return NT_STATUS_OK;
 }
 
-static struct krb5plugin_windc_ftable windc_plugin_table = {
-       .minor_version = KRB5_WINDC_PLUGING_MINOR,
-       .init = samba_kdc_plugin_init,
-       .fini = samba_kdc_plugin_fini,
-       .pac_generate = samba_kdc_get_pac,
-       .pac_verify = samba_kdc_reget_pac,
-       .client_access = samba_kdc_check_client_access,
-};
-
 
 static NTSTATUS kdc_check_generic_kerberos(struct irpc_message *msg, 
                                 struct kdc_check_generic_kerberos *r)
@@ -611,7 +600,7 @@ static NTSTATUS kdc_check_generic_kerberos(struct irpc_message *msg,
        }
 
        ret = krb5_make_principal(kdc->smb_krb5_context->krb5_context, &principal, 
-                                 lp_realm(kdc->task->lp_ctx), 
+                                 lp_realm(kdc->task->lp_ctx),
                                  "krbtgt", lp_realm(kdc->task->lp_ctx), 
                                  NULL);
 
@@ -659,12 +648,6 @@ static NTSTATUS kdc_check_generic_kerberos(struct irpc_message *msg,
 }
 
 
-static struct hdb_method hdb_samba4 = {
-       .interface_version = HDB_INTERFACE_VERSION,
-       .prefix = "samba4:",
-       .create = hdb_samba4_create
-};
-
 /*
   startup the kdc task
 */
@@ -677,10 +660,10 @@ static void kdc_task_init(struct task_server *task)
 
        switch (lp_server_role(task->lp_ctx)) {
        case ROLE_STANDALONE:
-               task_server_terminate(task, "kdc: no KDC required in standalone configuration");
+               task_server_terminate(task, "kdc: no KDC required in standalone configuration", false);
                return;
        case ROLE_DOMAIN_MEMBER:
-               task_server_terminate(task, "kdc: no KDC required in member server configuration");
+               task_server_terminate(task, "kdc: no KDC required in member server configuration", false);
                return;
        case ROLE_DOMAIN_CONTROLLER:
                /* Yes, we want a KDC */
@@ -690,7 +673,7 @@ static void kdc_task_init(struct task_server *task)
        load_interfaces(task, lp_interfaces(task->lp_ctx), &ifaces);
 
        if (iface_count(ifaces) == 0) {
-               task_server_terminate(task, "kdc: no network interfaces configured");
+               task_server_terminate(task, "kdc: no network interfaces configured", false);
                return;
        }
 
@@ -698,7 +681,7 @@ static void kdc_task_init(struct task_server *task)
 
        kdc = talloc(task, struct kdc_server);
        if (kdc == NULL) {
-               task_server_terminate(task, "kdc: out of memory");
+               task_server_terminate(task, "kdc: out of memory", true);
                return;
        }
 
@@ -710,7 +693,7 @@ static void kdc_task_init(struct task_server *task)
        if (ret) {
                DEBUG(1,("kdc_task_init: krb5_init_context failed (%s)\n", 
                         error_message(ret)));
-               task_server_terminate(task, "kdc: krb5_init_context failed");
+               task_server_terminate(task, "kdc: krb5_init_context failed", true);
                return; 
        }
 
@@ -719,39 +702,48 @@ static void kdc_task_init(struct task_server *task)
        ret = krb5_kdc_get_config(kdc->smb_krb5_context->krb5_context, 
                                  &kdc->config);
        if(ret) {
-               task_server_terminate(task, "kdc: failed to get KDC configuration");
+               task_server_terminate(task, "kdc: failed to get KDC configuration", true);
                return;
        }
-
        kdc->config->logf = kdc->smb_krb5_context->logf;
        kdc->config->db = talloc(kdc, struct HDB *);
        if (!kdc->config->db) {
-               task_server_terminate(task, "kdc: out of memory");
+               task_server_terminate(task, "kdc: out of memory", true);
                return;
        }
        kdc->config->num_db = 1;
                
-       status = kdc_hdb_samba4_create(kdc, task->event_ctx, task->lp_ctx, 
-                                   kdc->smb_krb5_context->krb5_context, 
-                                   &kdc->config->db[0], NULL);
+       status = hdb_samba4_create_kdc(kdc, task->event_ctx, task->lp_ctx, 
+                                      kdc->smb_krb5_context->krb5_context, 
+                                      &kdc->config->db[0]);
        if (!NT_STATUS_IS_OK(status)) {
-               task_server_terminate(task, "kdc: hdb_ldb_create (setup KDC database) failed");
+               task_server_terminate(task, "kdc: hdb_samba4_create_kdc (setup KDC database) failed", true);
                return; 
        }
 
+       /* Register hdb-samba4 hooks for use as a keytab */
+
+       kdc->hdb_samba4_context = talloc(kdc, struct hdb_samba4_context);
+       if (!kdc->hdb_samba4_context) {
+               task_server_terminate(task, "kdc: out of memory", true);
+               return; 
+       }
+
+       kdc->hdb_samba4_context->ev_ctx = task->event_ctx;
+       kdc->hdb_samba4_context->lp_ctx = task->lp_ctx;
 
-       /* Register hdb-samba4 hooks */
        ret = krb5_plugin_register(kdc->smb_krb5_context->krb5_context, 
                                   PLUGIN_TYPE_DATA, "hdb",
                                   &hdb_samba4);
        if(ret) {
-               task_server_terminate(task, "kdc: failed to register hdb keytab");
+               task_server_terminate(task, "kdc: failed to register hdb keytab", true);
                return;
        }
 
        ret = krb5_kt_register(kdc->smb_krb5_context->krb5_context, &hdb_kt_ops);
        if(ret) {
-               task_server_terminate(task, "kdc: failed to register hdb keytab");
+               task_server_terminate(task, "kdc: failed to register hdb keytab", true);
                return;
        }
 
@@ -760,27 +752,23 @@ static void kdc_task_init(struct task_server *task)
                                   PLUGIN_TYPE_DATA, "windc",
                                   &windc_plugin_table);
        if(ret) {
-               task_server_terminate(task, "kdc: failed to register hdb keytab");
+               task_server_terminate(task, "kdc: failed to register hdb keytab", true);
                return;
        }
 
        krb5_kdc_windc_init(kdc->smb_krb5_context->krb5_context);
 
-       kdc_mem_ctx = kdc->smb_krb5_context;
-       kdc_ev_ctx = task->event_ctx;
-       kdc_lp_ctx = task->lp_ctx;
-
        /* start listening on the configured network interfaces */
        status = kdc_startup_interfaces(kdc, task->lp_ctx, ifaces);
        if (!NT_STATUS_IS_OK(status)) {
-               task_server_terminate(task, "kdc failed to setup interfaces");
+               task_server_terminate(task, "kdc failed to setup interfaces", true);
                return;
        }
 
        status = IRPC_REGISTER(task->msg_ctx, irpc, KDC_CHECK_GENERIC_KERBEROS, 
                               kdc_check_generic_kerberos, kdc);
        if (!NT_STATUS_IS_OK(status)) {
-               task_server_terminate(task, "nbtd failed to setup monitoring");
+               task_server_terminate(task, "nbtd failed to setup monitoring", true);
                return;
        }