s4:dsdb/schema: add dsdb_syntax_UNICODE_validate_ldb()
[ira/wip.git] / source4 / dsdb / schema / schema_syntax.c
index 1989db069942b0ef9bcd5457ab39351558cfd703..b3f8891adeec68a9d7c76220ce5bfc02144e6800 100644 (file)
@@ -75,6 +75,26 @@ static WERROR dsdb_syntax_FOOBAR_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_FOOBAR;
 }
 
+static WERROR dsdb_syntax_FOOBAR_validate_ldb(struct ldb_context *ldb,
+                                             const struct dsdb_schema *schema,
+                                             const struct dsdb_attribute *attr,
+                                             const struct ldb_message_element *in)
+{
+       return WERR_FOOBAR;
+}
+
+static WERROR dsdb_syntax_ALLOW_validate_ldb(struct ldb_context *ldb,
+                                            const struct dsdb_schema *schema,
+                                            const struct dsdb_attribute *attr,
+                                            const struct ldb_message_element *in)
+{
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       return WERR_OK;
+}
+
 static WERROR dsdb_syntax_BOOL_drsuapi_to_ldb(struct ldb_context *ldb, 
                                              const struct dsdb_schema *schema,
                                              const struct dsdb_attribute *attr,
@@ -162,6 +182,35 @@ static WERROR dsdb_syntax_BOOL_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_BOOL_validate_ldb(struct ldb_context *ldb,
+                                           const struct dsdb_schema *schema,
+                                           const struct dsdb_attribute *attr,
+                                           const struct ldb_message_element *in)
+{
+       uint32_t i;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       for (i=0; i < in->num_values; i++) {
+               int t, f;
+
+               t = strncmp("TRUE",
+                           (const char *)in->values[i].data,
+                           in->values[i].length);
+               f = strncmp("FALSE",
+                           (const char *)in->values[i].data,
+                           in->values[i].length);
+
+               if (t != 0 && f != 0) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+       }
+
+       return WERR_OK;
+}
+
 static WERROR dsdb_syntax_INT32_drsuapi_to_ldb(struct ldb_context *ldb, 
                                               const struct dsdb_schema *schema,
                                               const struct dsdb_attribute *attr,
@@ -244,6 +293,53 @@ static WERROR dsdb_syntax_INT32_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_INT32_validate_ldb(struct ldb_context *ldb,
+                                            const struct dsdb_schema *schema,
+                                            const struct dsdb_attribute *attr,
+                                            const struct ldb_message_element *in)
+{
+       uint32_t i;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       for (i=0; i < in->num_values; i++) {
+               long v;
+               char buf[sizeof("-2147483648")];
+               char *end = NULL;
+
+               ZERO_STRUCT(buf);
+               if (in->values[i].length >= sizeof(buf)) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               memcpy(buf, in->values[i].data, in->values[i].length);
+               errno = 0;
+               v = strtol(buf, &end, 10);
+               if (errno != 0) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+               if (end && end[0] != '\0') {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               if (attr->rangeLower) {
+                       if ((int32_t)v < (int32_t)*attr->rangeLower) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+
+               if (attr->rangeUpper) {
+                       if ((int32_t)v > (int32_t)*attr->rangeUpper) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+       }
+
+       return WERR_OK;
+}
+
 static WERROR dsdb_syntax_INT64_drsuapi_to_ldb(struct ldb_context *ldb, 
                                               const struct dsdb_schema *schema,
                                               const struct dsdb_attribute *attr,
@@ -324,6 +420,52 @@ static WERROR dsdb_syntax_INT64_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_INT64_validate_ldb(struct ldb_context *ldb,
+                                            const struct dsdb_schema *schema,
+                                            const struct dsdb_attribute *attr,
+                                            const struct ldb_message_element *in)
+{
+       uint32_t i;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       for (i=0; i < in->num_values; i++) {
+               long long v;
+               char buf[sizeof("-9223372036854775808")];
+               char *end = NULL;
+
+               ZERO_STRUCT(buf);
+               if (in->values[i].length >= sizeof(buf)) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+               memcpy(buf, in->values[i].data, in->values[i].length);
+
+               errno = 0;
+               v = strtoll(buf, &end, 10);
+               if (errno != 0) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+               if (end && end[0] != '\0') {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               if (attr->rangeLower) {
+                       if ((int64_t)v < (int64_t)*attr->rangeLower) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+
+               if (attr->rangeUpper) {
+                       if ((int64_t)v > (int64_t)*attr->rangeUpper) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+       }
+
+       return WERR_OK;
+}
 static WERROR dsdb_syntax_NTTIME_UTC_drsuapi_to_ldb(struct ldb_context *ldb, 
                                                    const struct dsdb_schema *schema,
                                                    const struct dsdb_attribute *attr,
@@ -418,6 +560,54 @@ static WERROR dsdb_syntax_NTTIME_UTC_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_NTTIME_UTC_validate_ldb(struct ldb_context *ldb,
+                                                 const struct dsdb_schema *schema,
+                                                 const struct dsdb_attribute *attr,
+                                                 const struct ldb_message_element *in)
+{
+       uint32_t i;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       for (i=0; i < in->num_values; i++) {
+               time_t t;
+               char buf[sizeof("090826075717Z")];
+
+               ZERO_STRUCT(buf);
+               if (in->values[i].length >= sizeof(buf)) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+               memcpy(buf, in->values[i].data, in->values[i].length);
+
+               errno = 0;
+               t = ldb_string_utc_to_time(buf);
+               if (errno != 0) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               if (attr->rangeLower) {
+                       if ((int32_t)t < (int32_t)*attr->rangeLower) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+
+               if (attr->rangeUpper) {
+                       if ((int32_t)t > (int32_t)*attr->rangeLower) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+
+               /*
+                * TODO: verify the comment in the
+                * dsdb_syntax_NTTIME_UTC_drsuapi_to_ldb() function!
+                */
+       }
+
+       return WERR_OK;
+}
+
 static WERROR dsdb_syntax_NTTIME_drsuapi_to_ldb(struct ldb_context *ldb, 
                                                const struct dsdb_schema *schema,
                                                const struct dsdb_attribute *attr,
@@ -488,13 +678,17 @@ static WERROR dsdb_syntax_NTTIME_ldb_to_drsuapi(struct ldb_context *ldb,
        for (i=0; i < in->num_values; i++) {
                NTTIME v;
                time_t t;
+               int ret;
 
                out->value_ctr.values[i].blob   = &blobs[i];
 
                blobs[i] = data_blob_talloc(blobs, NULL, 8);
                W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
 
-               t = ldb_string_to_time((const char *)in->values[i].data);
+               ret = ldb_val_to_time(&in->values[i], &t);
+               if (ret != LDB_SUCCESS) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
                unix_to_nt_time(&v, t);
                v /= 10000000;
 
@@ -504,6 +698,42 @@ static WERROR dsdb_syntax_NTTIME_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_NTTIME_validate_ldb(struct ldb_context *ldb,
+                                             const struct dsdb_schema *schema,
+                                             const struct dsdb_attribute *attr,
+                                             const struct ldb_message_element *in)
+{
+       uint32_t i;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       for (i=0; i < in->num_values; i++) {
+               time_t t;
+               int ret;
+
+               ret = ldb_val_to_time(&in->values[i], &t);
+               if (ret != LDB_SUCCESS) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               if (attr->rangeLower) {
+                       if ((int32_t)t < (int32_t)*attr->rangeLower) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+
+               if (attr->rangeUpper) {
+                       if ((int32_t)t > (int32_t)*attr->rangeLower) {
+                               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+                       }
+               }
+       }
+
+       return WERR_OK;
+}
+
 static WERROR dsdb_syntax_DATA_BLOB_drsuapi_to_ldb(struct ldb_context *ldb, 
                                                   const struct dsdb_schema *schema,
                                                   const struct dsdb_attribute *attr,
@@ -572,6 +802,110 @@ static WERROR dsdb_syntax_DATA_BLOB_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_DATA_BLOB_validate_one_val(struct ldb_context *ldb,
+                                                    const struct dsdb_schema *schema,
+                                                    const struct dsdb_attribute *attr,
+                                                    const struct ldb_val *val)
+{
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       if (attr->rangeLower) {
+               if ((uint32_t)val->length < (uint32_t)*attr->rangeLower) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+       }
+
+       if (attr->rangeUpper) {
+               if ((uint32_t)val->length > (uint32_t)*attr->rangeUpper) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+       }
+
+       return WERR_OK;
+}
+
+static WERROR dsdb_syntax_DATA_BLOB_validate_ldb(struct ldb_context *ldb,
+                                                const struct dsdb_schema *schema,
+                                                const struct dsdb_attribute *attr,
+                                                const struct ldb_message_element *in)
+{
+       uint32_t i;
+       WERROR status;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       for (i=0; i < in->num_values; i++) {
+               if (in->values[i].length == 0) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               status = dsdb_syntax_DATA_BLOB_validate_one_val(ldb,
+                                                               schema,
+                                                               attr,
+                                                               &in->values[i]);
+               if (!W_ERROR_IS_OK(status)) {
+                       return status;
+               }
+       }
+
+       return WERR_OK;
+}
+
+static WERROR _dsdb_syntax_auto_OID_drsuapi_to_ldb(struct ldb_context *ldb,
+                                                  const struct dsdb_schema *schema,
+                                                  const struct dsdb_attribute *attr,
+                                                  const struct drsuapi_DsReplicaAttribute *in,
+                                                  TALLOC_CTX *mem_ctx,
+                                                  struct ldb_message_element *out)
+{
+       uint32_t i;
+
+       out->flags      = 0;
+       out->name       = talloc_strdup(mem_ctx, attr->lDAPDisplayName);
+       W_ERROR_HAVE_NO_MEMORY(out->name);
+
+       out->num_values = in->value_ctr.num_values;
+       out->values     = talloc_array(mem_ctx, struct ldb_val, out->num_values);
+       W_ERROR_HAVE_NO_MEMORY(out->values);
+
+       for (i=0; i < out->num_values; i++) {
+               uint32_t v;
+               const struct dsdb_class *c;
+               const struct dsdb_attribute *a;
+               const char *str = NULL;
+
+               if (in->value_ctr.values[i].blob == NULL) {
+                       return WERR_FOOBAR;
+               }
+
+               if (in->value_ctr.values[i].blob->length != 4) {
+                       return WERR_FOOBAR;
+               }
+
+               v = IVAL(in->value_ctr.values[i].blob->data, 0);
+
+               if ((c = dsdb_class_by_governsID_id(schema, v))) {
+                       str = talloc_strdup(out->values, c->lDAPDisplayName);
+               } else if ((a = dsdb_attribute_by_attributeID_id(schema, v))) {
+                       str = talloc_strdup(out->values, a->lDAPDisplayName);
+               } else {
+                       WERROR werr;
+                       werr = dsdb_schema_pfm_oid_from_attid(schema->prefixmap, v, out->values, &str);
+                       W_ERROR_NOT_OK_RETURN(werr);
+               }
+               W_ERROR_HAVE_NO_MEMORY(str);
+
+               /* the values need to be reversed */
+               out->values[out->num_values - (i + 1)] = data_blob_string_const(str);
+       }
+
+       return WERR_OK;
+}
+
 static WERROR _dsdb_syntax_OID_obj_drsuapi_to_ldb(struct ldb_context *ldb, 
                                                  const struct dsdb_schema *schema,
                                                  const struct dsdb_attribute *attr,
@@ -707,6 +1041,60 @@ static WERROR _dsdb_syntax_OID_oid_drsuapi_to_ldb(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR _dsdb_syntax_auto_OID_ldb_to_drsuapi(struct ldb_context *ldb,
+                                                  const struct dsdb_schema *schema,
+                                                  const struct dsdb_attribute *attr,
+                                                  const struct ldb_message_element *in,
+                                                  TALLOC_CTX *mem_ctx,
+                                                 struct drsuapi_DsReplicaAttribute *out)
+{
+        uint32_t i;
+        DATA_BLOB *blobs;
+
+        out->attid= attr->attributeID_id;
+        out->value_ctr.num_values= in->num_values;
+        out->value_ctr.values= talloc_array(mem_ctx,
+                                            struct drsuapi_DsAttributeValue,
+                                            in->num_values);
+        W_ERROR_HAVE_NO_MEMORY(out->value_ctr.values);
+
+        blobs = talloc_array(mem_ctx, DATA_BLOB, in->num_values);
+        W_ERROR_HAVE_NO_MEMORY(blobs);
+
+        for (i=0; i < in->num_values; i++) {
+               const struct dsdb_class *obj_class;
+               const struct dsdb_attribute *obj_attr;
+               struct ldb_val *v;
+
+               out->value_ctr.values[i].blob= &blobs[i];
+
+               blobs[i] = data_blob_talloc(blobs, NULL, 4);
+               W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
+
+               /* in DRS windows puts the classes in the opposite
+                  order to the order used in ldap */
+               v = &in->values[(in->num_values-1)-i];
+
+               if ((obj_class = dsdb_class_by_lDAPDisplayName_ldb_val(schema, v))) {
+                       SIVAL(blobs[i].data, 0, obj_class->governsID_id);
+               } else if ((obj_attr = dsdb_attribute_by_lDAPDisplayName_ldb_val(schema, v))) {
+                       SIVAL(blobs[i].data, 0, obj_attr->attributeID_id);
+               } else {
+                       uint32_t attid;
+                       WERROR werr;
+                       werr = dsdb_schema_pfm_make_attid(schema->prefixmap,
+                                                         (const char *)v->data,
+                                                         &attid);
+                       W_ERROR_NOT_OK_RETURN(werr);
+                       SIVAL(blobs[i].data, 0, attid);
+               }
+
+        }
+
+
+        return WERR_OK;
+}
+
 static WERROR _dsdb_syntax_OID_obj_ldb_to_drsuapi(struct ldb_context *ldb,
                                                  const struct dsdb_schema *schema,
                                                  const struct dsdb_attribute *attr,
@@ -735,7 +1123,10 @@ static WERROR _dsdb_syntax_OID_obj_ldb_to_drsuapi(struct ldb_context *ldb,
                blobs[i] = data_blob_talloc(blobs, NULL, 4);
                W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
 
-               obj_class = dsdb_class_by_lDAPDisplayName(schema, (const char *)in->values[i].data);
+               /* in DRS windows puts the classes in the opposite
+                  order to the order used in ldap */
+               obj_class = dsdb_class_by_lDAPDisplayName(schema,
+                                                         (const char *)in->values[(in->num_values-1)-i].data);
                if (!obj_class) {
                        return WERR_FOOBAR;
                }
@@ -832,18 +1223,19 @@ static WERROR dsdb_syntax_OID_drsuapi_to_ldb(struct ldb_context *ldb,
                                             TALLOC_CTX *mem_ctx,
                                             struct ldb_message_element *out)
 {
-       uint32_t i;
-
        switch (attr->attributeID_id) {
        case DRSUAPI_ATTRIBUTE_objectClass:
        case DRSUAPI_ATTRIBUTE_subClassOf:
        case DRSUAPI_ATTRIBUTE_auxiliaryClass:
+       case DRSUAPI_ATTRIBUTE_systemAuxiliaryClass:
        case DRSUAPI_ATTRIBUTE_systemPossSuperiors:
        case DRSUAPI_ATTRIBUTE_possSuperiors:
                return _dsdb_syntax_OID_obj_drsuapi_to_ldb(ldb, schema, attr, in, mem_ctx, out);
        case DRSUAPI_ATTRIBUTE_systemMustContain:
        case DRSUAPI_ATTRIBUTE_systemMayContain:        
        case DRSUAPI_ATTRIBUTE_mustContain:
+       case DRSUAPI_ATTRIBUTE_rDNAttId:
+       case DRSUAPI_ATTRIBUTE_transportAddressAttribute:
        case DRSUAPI_ATTRIBUTE_mayContain:
                return _dsdb_syntax_OID_attr_drsuapi_to_ldb(ldb, schema, attr, in, mem_ctx, out);
        case DRSUAPI_ATTRIBUTE_governsID:
@@ -852,41 +1244,9 @@ static WERROR dsdb_syntax_OID_drsuapi_to_ldb(struct ldb_context *ldb,
                return _dsdb_syntax_OID_oid_drsuapi_to_ldb(ldb, schema, attr, in, mem_ctx, out);
        }
 
-       out->flags      = 0;
-       out->name       = talloc_strdup(mem_ctx, attr->lDAPDisplayName);
-       W_ERROR_HAVE_NO_MEMORY(out->name);
-
-       out->num_values = in->value_ctr.num_values;
-       out->values     = talloc_array(mem_ctx, struct ldb_val, out->num_values);
-       W_ERROR_HAVE_NO_MEMORY(out->values);
-
-       for (i=0; i < out->num_values; i++) {
-               uint32_t v;
-               const char *name;
-               char *str;
-
-               if (in->value_ctr.values[i].blob == NULL) {
-                       return WERR_FOOBAR;
-               }
-
-               if (in->value_ctr.values[i].blob->length != 4) {
-                       return WERR_FOOBAR;
-               }
-
-               v = IVAL(in->value_ctr.values[i].blob->data, 0);
-
-               name = dsdb_lDAPDisplayName_by_id(schema, v);
-               if (!name) {
-                       return WERR_FOOBAR;
-               }
-
-               str = talloc_strdup(out->values, name);
-               W_ERROR_HAVE_NO_MEMORY(str);
-
-               out->values[i] = data_blob_string_const(str);
-       }
-
-       return WERR_OK;
+       DEBUG(0,(__location__ ": Unknown handling for attributeID_id for %s\n",
+                attr->lDAPDisplayName));
+       return _dsdb_syntax_auto_OID_drsuapi_to_ldb(ldb, schema, attr, in, mem_ctx, out);
 }
 
 static WERROR dsdb_syntax_OID_ldb_to_drsuapi(struct ldb_context *ldb, 
@@ -896,9 +1256,6 @@ static WERROR dsdb_syntax_OID_ldb_to_drsuapi(struct ldb_context *ldb,
                                             TALLOC_CTX *mem_ctx,
                                             struct drsuapi_DsReplicaAttribute *out)
 {
-       uint32_t i;
-       DATA_BLOB *blobs;
-
        if (attr->attributeID_id == 0xFFFFFFFF) {
                return WERR_FOOBAR;
        }
@@ -907,12 +1264,15 @@ static WERROR dsdb_syntax_OID_ldb_to_drsuapi(struct ldb_context *ldb,
        case DRSUAPI_ATTRIBUTE_objectClass:
        case DRSUAPI_ATTRIBUTE_subClassOf:
        case DRSUAPI_ATTRIBUTE_auxiliaryClass:
+       case DRSUAPI_ATTRIBUTE_systemAuxiliaryClass:
        case DRSUAPI_ATTRIBUTE_systemPossSuperiors:
        case DRSUAPI_ATTRIBUTE_possSuperiors:
                return _dsdb_syntax_OID_obj_ldb_to_drsuapi(ldb, schema, attr, in, mem_ctx, out);
        case DRSUAPI_ATTRIBUTE_systemMustContain:
        case DRSUAPI_ATTRIBUTE_systemMayContain:        
        case DRSUAPI_ATTRIBUTE_mustContain:
+       case DRSUAPI_ATTRIBUTE_rDNAttId:
+       case DRSUAPI_ATTRIBUTE_transportAddressAttribute:
        case DRSUAPI_ATTRIBUTE_mayContain:
                return _dsdb_syntax_OID_attr_ldb_to_drsuapi(ldb, schema, attr, in, mem_ctx, out);
        case DRSUAPI_ATTRIBUTE_governsID:
@@ -921,30 +1281,10 @@ static WERROR dsdb_syntax_OID_ldb_to_drsuapi(struct ldb_context *ldb,
                return _dsdb_syntax_OID_oid_ldb_to_drsuapi(ldb, schema, attr, in, mem_ctx, out);
        }
 
-       out->attid                      = attr->attributeID_id;
-       out->value_ctr.num_values       = in->num_values;
-       out->value_ctr.values           = talloc_array(mem_ctx,
-                                                      struct drsuapi_DsAttributeValue,
-                                                      in->num_values);
-       W_ERROR_HAVE_NO_MEMORY(out->value_ctr.values);
-
-       blobs = talloc_array(mem_ctx, DATA_BLOB, in->num_values);
-       W_ERROR_HAVE_NO_MEMORY(blobs);
-
-       for (i=0; i < in->num_values; i++) {
-               uint32_t v;
-
-               out->value_ctr.values[i].blob   = &blobs[i];
-
-               blobs[i] = data_blob_talloc(blobs, NULL, 4);
-               W_ERROR_HAVE_NO_MEMORY(blobs[i].data);
+       DEBUG(0,(__location__ ": Unknown handling for attributeID_id for %s\n",
+                attr->lDAPDisplayName));
 
-               v = strtol((const char *)in->values[i].data, NULL, 10);
-
-               SIVAL(blobs[i].data, 0, v);
-       }
-
-       return WERR_OK;
+       return _dsdb_syntax_auto_OID_ldb_to_drsuapi(ldb, schema, attr, in, mem_ctx, out);
 }
 
 static WERROR dsdb_syntax_UNICODE_drsuapi_to_ldb(struct ldb_context *ldb, 
@@ -1028,6 +1368,74 @@ static WERROR dsdb_syntax_UNICODE_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_UNICODE_validate_one_val(struct ldb_context *ldb,
+                                                  const struct dsdb_schema *schema,
+                                                  const struct dsdb_attribute *attr,
+                                                  const struct ldb_val *val)
+{
+       void *dst = NULL;
+       size_t size;
+       bool ok;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       ok = convert_string_talloc_convenience(ldb,
+                                              schema->iconv_convenience,
+                                              CH_UNIX, CH_UTF16,
+                                              val->data,
+                                              val->length,
+                                              (void **)&dst,
+                                              &size, false);
+       TALLOC_FREE(dst);
+       if (!ok) {
+               return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+       }
+
+       if (attr->rangeLower) {
+               if ((size/2) < *attr->rangeLower) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+       }
+
+       if (attr->rangeUpper) {
+               if ((size/2) > *attr->rangeUpper) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+       }
+
+       return WERR_OK;
+}
+
+static WERROR dsdb_syntax_UNICODE_validate_ldb(struct ldb_context *ldb,
+                                              const struct dsdb_schema *schema,
+                                              const struct dsdb_attribute *attr,
+                                              const struct ldb_message_element *in)
+{
+       WERROR status;
+       uint32_t i;
+
+       if (attr->attributeID_id == 0xFFFFFFFF) {
+               return WERR_FOOBAR;
+       }
+
+       for (i=0; i < in->num_values; i++) {
+               if (in->values[i].length == 0) {
+                       return WERR_DS_INVALID_ATTRIBUTE_SYNTAX;
+               }
+
+               status = dsdb_syntax_UNICODE_validate_one_val(ldb,
+                                                             schema,
+                                                             attr,
+                                                             &in->values[i]);
+               if (!W_ERROR_IS_OK(status)) {
+                       return status;
+               }
+       }
+
+       return WERR_OK;
+}
 
 WERROR dsdb_syntax_one_DN_drsuapi_to_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb, 
                                         const struct dsdb_syntax *syntax, 
@@ -1074,20 +1482,21 @@ WERROR dsdb_syntax_one_DN_drsuapi_to_ldb(TALLOC_CTX *mem_ctx, struct ldb_context
                W_ERROR_HAVE_NO_MEMORY(dn);
        }
 
-       status = GUID_to_ndr_blob(&id3.guid, tmp_ctx, &guid_blob);
-       if (!NT_STATUS_IS_OK(status)) {
-               talloc_free(tmp_ctx);
-               return ntstatus_to_werror(status);
-       }
+       if (!GUID_all_zero(&id3.guid)) {
+               status = GUID_to_ndr_blob(&id3.guid, tmp_ctx, &guid_blob);
+               if (!NT_STATUS_IS_OK(status)) {
+                       talloc_free(tmp_ctx);
+                       return ntstatus_to_werror(status);
+               }
        
-       ret = ldb_dn_set_extended_component(dn, "GUID", &guid_blob);
-       if (ret != LDB_SUCCESS) {
-               talloc_free(tmp_ctx);
-               return WERR_FOOBAR;
+               ret = ldb_dn_set_extended_component(dn, "GUID", &guid_blob);
+               if (ret != LDB_SUCCESS) {
+                       talloc_free(tmp_ctx);
+                       return WERR_FOOBAR;
+               }
+               talloc_free(guid_blob.data);
        }
        
-       talloc_free(guid_blob.data);
-       
        if (id3.__ndr_size_sid) {
                DATA_BLOB sid_blob;
                ndr_err = ndr_push_struct_blob(&sid_blob, tmp_ctx, iconv_convenience, &id3.sid,
@@ -1183,7 +1592,7 @@ static WERROR dsdb_syntax_DN_ldb_to_drsuapi(struct ldb_context *ldb,
 
                ZERO_STRUCT(id3);
 
-               status = dsdb_get_extended_dn_guid(dn, &id3.guid);
+               status = dsdb_get_extended_dn_guid(dn, &id3.guid, "GUID");
                if (!NT_STATUS_IS_OK(status) &&
                    !NT_STATUS_EQUAL(status, NT_STATUS_OBJECT_NAME_NOT_FOUND)) {
                        talloc_free(tmp_ctx);
@@ -1367,7 +1776,7 @@ static WERROR dsdb_syntax_DN_BINARY_ldb_to_drsuapi(struct ldb_context *ldb,
 
                ZERO_STRUCT(id3);
 
-               status = dsdb_get_extended_dn_guid(dsdb_dn->dn, &id3.guid);
+               status = dsdb_get_extended_dn_guid(dsdb_dn->dn, &id3.guid, "GUID");
                if (!NT_STATUS_IS_OK(status) &&
                    !NT_STATUS_EQUAL(status, NT_STATUS_OBJECT_NAME_NOT_FOUND)) {
                        talloc_free(tmp_ctx);
@@ -1404,7 +1813,35 @@ static WERROR dsdb_syntax_DN_BINARY_ldb_to_drsuapi(struct ldb_context *ldb,
        return WERR_OK;
 }
 
+static WERROR dsdb_syntax_DN_STRING_drsuapi_to_ldb(struct ldb_context *ldb,
+                                                  const struct dsdb_schema *schema,
+                                                  const struct dsdb_attribute *attr,
+                                                  const struct drsuapi_DsReplicaAttribute *in,
+                                                  TALLOC_CTX *mem_ctx,
+                                                  struct ldb_message_element *out)
+{
+       return dsdb_syntax_DN_BINARY_drsuapi_to_ldb(ldb,
+                                                   schema,
+                                                   attr,
+                                                   in,
+                                                   mem_ctx,
+                                                   out);
+}
 
+static WERROR dsdb_syntax_DN_STRING_ldb_to_drsuapi(struct ldb_context *ldb,
+                                                  const struct dsdb_schema *schema,
+                                                  const struct dsdb_attribute *attr,
+                                                  const struct ldb_message_element *in,
+                                                  TALLOC_CTX *mem_ctx,
+                                                  struct drsuapi_DsReplicaAttribute *out)
+{
+       return dsdb_syntax_DN_BINARY_ldb_to_drsuapi(ldb,
+                                                   schema,
+                                                   attr,
+                                                   in,
+                                                   mem_ctx,
+                                                   out);
+}
 
 static WERROR dsdb_syntax_PRESENTATION_ADDRESS_drsuapi_to_ldb(struct ldb_context *ldb, 
                                                              const struct dsdb_schema *schema,
@@ -1515,6 +1952,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.8",
                .drsuapi_to_ldb         = dsdb_syntax_BOOL_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_BOOL_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_BOOL_validate_ldb,
                .equality               = "booleanMatch",
                .comment                = "Boolean" 
        },{
@@ -1524,6 +1962,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.9",
                .drsuapi_to_ldb         = dsdb_syntax_INT32_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_INT32_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_INT32_validate_ldb,
                .equality               = "integerMatch",
                .comment                = "Integer",
                .ldb_syntax             = LDB_SYNTAX_SAMBA_INT32
@@ -1534,6 +1973,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.10",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .equality               = "octetStringMatch",
                .comment                = "Octet String",
        },{
@@ -1543,6 +1983,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.17",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .equality               = "octetStringMatch",
                .comment                = "Octet String - Security Identifier (SID)",
                .ldb_syntax             = LDB_SYNTAX_SAMBA_SID
@@ -1553,6 +1994,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.2",
                .drsuapi_to_ldb         = dsdb_syntax_OID_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_OID_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_ALLOW_validate_ldb,
                .equality               = "caseIgnoreMatch", /* Would use "objectIdentifierMatch" but most are ldap attribute/class names */
                .comment                = "OID String",
                .ldb_syntax             = LDB_SYNTAX_DIRECTORY_STRING
@@ -1563,6 +2005,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.9",
                .drsuapi_to_ldb         = dsdb_syntax_INT32_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_INT32_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_INT32_validate_ldb,
                .ldb_syntax             = LDB_SYNTAX_SAMBA_INT32
        },{
        /* not used in w2k3 forest */
@@ -1572,6 +2015,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.6",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .equality               = "numericStringMatch",
                .substring              = "numericStringSubstringsMatch",
                .comment                = "Numeric String",
@@ -1583,6 +2027,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.5",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .ldb_syntax             = LDB_SYNTAX_OCTET_STRING,
        },{
                .name                   = "String(Teletex)",
@@ -1591,6 +2036,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.4",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .equality               = "caseIgnoreMatch",
                .substring              = "caseIgnoreSubstringsMatch",
                .comment                = "Case Insensitive String",
@@ -1602,6 +2048,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.5",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
                .equality               = "caseExactIA5Match",
                .comment                = "Printable String",
                .ldb_syntax             = LDB_SYNTAX_OCTET_STRING,
@@ -1612,6 +2059,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.11",
                .drsuapi_to_ldb         = dsdb_syntax_NTTIME_UTC_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_NTTIME_UTC_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_NTTIME_UTC_validate_ldb,
                .equality               = "generalizedTimeMatch",
                .comment                = "UTC Time",
        },{
@@ -1621,6 +2069,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.11",
                .drsuapi_to_ldb         = dsdb_syntax_NTTIME_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_NTTIME_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_NTTIME_validate_ldb,
                .equality               = "generalizedTimeMatch",
                .comment                = "Generalized Time",
                .ldb_syntax             = LDB_SYNTAX_UTC_TIME,
@@ -1632,6 +2081,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.3",
                .drsuapi_to_ldb         = dsdb_syntax_FOOBAR_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_FOOBAR_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_FOOBAR_validate_ldb,
        },{
                .name                   = "String(Unicode)",
                .ldap_oid               = LDB_SYNTAX_DIRECTORY_STRING,
@@ -1639,6 +2089,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.12",
                .drsuapi_to_ldb         = dsdb_syntax_UNICODE_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_UNICODE_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_UNICODE_validate_ldb,
                .equality               = "caseIgnoreMatch",
                .substring              = "caseIgnoreSubstringsMatch",
                .comment                = "Directory String",
@@ -1649,6 +2100,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.16",
                .drsuapi_to_ldb         = dsdb_syntax_INT64_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_INT64_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_INT64_validate_ldb,
                .equality               = "integerMatch",
                .comment                = "Large Integer",
                .ldb_syntax             = LDB_SYNTAX_INTEGER,
@@ -1659,6 +2111,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.15",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
        },{
                .name                   = "Object(DS-DN)",
                .ldap_oid               = LDB_SYNTAX_DN,
@@ -1667,6 +2120,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.1",
                .drsuapi_to_ldb         = dsdb_syntax_DN_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DN_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_ALLOW_validate_ldb,
                .equality               = "distinguishedNameMatch",
                .comment                = "Object(DS-DN) == a DN",
        },{
@@ -1677,6 +2131,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.7",
                .drsuapi_to_ldb         = dsdb_syntax_DN_BINARY_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DN_BINARY_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_ALLOW_validate_ldb,
                .equality               = "octetStringMatch",
                .comment                = "OctetString: Binary+DN",
        },{
@@ -1688,6 +2143,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.7",
                .drsuapi_to_ldb         = dsdb_syntax_DN_BINARY_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DN_BINARY_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_ALLOW_validate_ldb,
                .equality               = "caseIgnoreMatch",
                .ldb_syntax             = LDB_SYNTAX_DN,
        },{
@@ -1704,6 +2160,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.10",
                .drsuapi_to_ldb         = dsdb_syntax_DATA_BLOB_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_DATA_BLOB_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_DATA_BLOB_validate_ldb,
        },{
                .name                   = "Object(Presentation-Address)",
                .ldap_oid               = "1.3.6.1.4.1.1466.115.121.1.43",
@@ -1712,6 +2169,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.13",
                .drsuapi_to_ldb         = dsdb_syntax_PRESENTATION_ADDRESS_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_PRESENTATION_ADDRESS_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_ALLOW_validate_ldb,
                .comment                = "Presentation Address",
                .ldb_syntax             = LDB_SYNTAX_DIRECTORY_STRING,
        },{
@@ -1723,6 +2181,7 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .attributeSyntax_oid    = "2.5.5.14",
                .drsuapi_to_ldb         = dsdb_syntax_FOOBAR_drsuapi_to_ldb,
                .ldb_to_drsuapi         = dsdb_syntax_FOOBAR_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_FOOBAR_validate_ldb,
                .ldb_syntax             = LDB_SYNTAX_DIRECTORY_STRING,
        },{
        /* not used in w2k3 schema */
@@ -1731,8 +2190,9 @@ static const struct dsdb_syntax dsdb_syntaxes[] = {
                .oMSyntax               = 127,
                .oMObjectClass          = OMOBJECTCLASS("\x2a\x86\x48\x86\xf7\x14\x01\x01\x01\x0c"),
                .attributeSyntax_oid    = "2.5.5.14",
-               .drsuapi_to_ldb         = dsdb_syntax_DN_BINARY_drsuapi_to_ldb,
-               .ldb_to_drsuapi         = dsdb_syntax_DN_BINARY_ldb_to_drsuapi,
+               .drsuapi_to_ldb         = dsdb_syntax_DN_STRING_drsuapi_to_ldb,
+               .ldb_to_drsuapi         = dsdb_syntax_DN_STRING_ldb_to_drsuapi,
+               .validate_ldb           = dsdb_syntax_ALLOW_validate_ldb,
                .equality               = "octetStringMatch",
                .comment                = "OctetString: String+DN",
        }
@@ -1826,3 +2286,17 @@ WERROR dsdb_attribute_ldb_to_drsuapi(struct ldb_context *ldb,
 
        return sa->syntax->ldb_to_drsuapi(ldb, schema, sa, in, mem_ctx, out);
 }
+
+WERROR dsdb_attribute_validate_ldb(struct ldb_context *ldb,
+                                  const struct dsdb_schema *schema,
+                                  const struct ldb_message_element *in)
+{
+       const struct dsdb_attribute *sa;
+
+       sa = dsdb_attribute_by_lDAPDisplayName(schema, in->name);
+       if (!sa) {
+               return WERR_DS_ATTRIBUTE_TYPE_UNDEFINED;
+       }
+
+       return sa->syntax->validate_ldb(ldb, schema, sa, in);
+}