s4/drs: Refactor to be more SAMBA.Coding style compliant
[ira/wip.git] / source4 / dsdb / schema / schema_init.c
index b6a7cf7cc8aa893501cb04b6c48e7d2d0ecc4ae1..de370e0b23a8223a0fd9af05028034416ce5a6b2 100644 (file)
@@ -28,6 +28,9 @@
 #include "librpc/gen_ndr/ndr_drsuapi.h"
 #include "librpc/gen_ndr/ndr_drsblobs.h"
 #include "param/param.h"
+#include "lib/ldb/include/ldb_module.h"
+#include "../lib/util/asn1.h"
+
 
 struct dsdb_schema *dsdb_new_schema(TALLOC_CTX *mem_ctx, struct smb_iconv_convenience *iconv_convenience)
 {
@@ -41,102 +44,106 @@ struct dsdb_schema *dsdb_new_schema(TALLOC_CTX *mem_ctx, struct smb_iconv_conven
 }
 
 
-WERROR dsdb_load_oid_mappings_drsuapi(struct dsdb_schema *schema, const struct drsuapi_DsReplicaOIDMapping_Ctr *ctr)
+WERROR dsdb_load_prefixmap_from_drsuapi(struct dsdb_schema *schema,
+                                       const struct drsuapi_DsReplicaOIDMapping_Ctr *ctr)
 {
-       uint32_t i,j;
+       WERROR werr;
+       const char *schema_info;
+       struct dsdb_schema_prefixmap *pfm;
 
-       schema->prefixes = talloc_array(schema, struct dsdb_schema_oid_prefix, ctr->num_mappings);
-       W_ERROR_HAVE_NO_MEMORY(schema->prefixes);
+       werr = dsdb_schema_pfm_from_drsuapi_pfm(ctr, true, schema, &pfm, &schema_info);
+       W_ERROR_NOT_OK_RETURN(werr);
 
-       for (i=0, j=0; i < ctr->num_mappings; i++) {
-               if (ctr->mappings[i].oid.oid == NULL) {
-                       return WERR_INVALID_PARAM;
-               }
+       /* set loaded prefixMap */
+       talloc_free(schema->prefixmap);
+       schema->prefixmap = pfm;
 
-               if (strncasecmp(ctr->mappings[i].oid.oid, "ff", 2) == 0) {
-                       if (ctr->mappings[i].id_prefix != 0) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       /* the magic value should be in the last array member */
-                       if (i != (ctr->num_mappings - 1)) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       if (ctr->mappings[i].oid.__ndr_size != 21) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       schema->schema_info = talloc_strdup(schema, ctr->mappings[i].oid.oid);
-                       W_ERROR_HAVE_NO_MEMORY(schema->schema_info);
-               } else {
-                       /* the last array member should contain the magic value not a oid */
-                       if (i == (ctr->num_mappings - 1)) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       schema->prefixes[j].id  = ctr->mappings[i].id_prefix<<16;
-                       schema->prefixes[j].oid = talloc_asprintf(schema->prefixes, "%s.",
-                                                                 ctr->mappings[i].oid.oid);
-                       W_ERROR_HAVE_NO_MEMORY(schema->prefixes[j].oid);
-                       schema->prefixes[j].oid_len = strlen(schema->prefixes[j].oid);
-                       j++;
-               }
-       }
+       talloc_free(discard_const(schema->schema_info));
+       schema->schema_info = schema_info;
 
-       schema->num_prefixes = j;
        return WERR_OK;
 }
 
-WERROR dsdb_load_oid_mappings_ldb(struct dsdb_schema *schema,
-                                 const struct ldb_val *prefixMap,
-                                 const struct ldb_val *schemaInfo)
+static WERROR _dsdb_prefixmap_from_ldb_val(const struct ldb_val *pfm_ldb_val,
+                                          struct smb_iconv_convenience *iconv_convenience,
+                                          TALLOC_CTX *mem_ctx,
+                                          struct dsdb_schema_prefixmap **_pfm)
 {
-       WERROR status;
+       WERROR werr;
        enum ndr_err_code ndr_err;
-       struct prefixMapBlob pfm;
-       char *schema_info;
+       struct prefixMapBlob pfm_blob;
 
-       TALLOC_CTX *mem_ctx = talloc_new(schema);
-       W_ERROR_HAVE_NO_MEMORY(mem_ctx);
-       
-       ndr_err = ndr_pull_struct_blob(prefixMap, mem_ctx, schema->iconv_convenience, &pfm, (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
+       TALLOC_CTX *temp_ctx = talloc_new(mem_ctx);
+       W_ERROR_HAVE_NO_MEMORY(temp_ctx);
+
+       ndr_err = ndr_pull_struct_blob(pfm_ldb_val, temp_ctx,
+                               iconv_convenience, &pfm_blob,
+                               (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
-               talloc_free(mem_ctx);
+               talloc_free(temp_ctx);
                return ntstatus_to_werror(nt_status);
        }
 
-       if (pfm.version != PREFIX_MAP_VERSION_DSDB) {
-               talloc_free(mem_ctx);
-               return WERR_FOOBAR;
+       if (pfm_blob.version != PREFIX_MAP_VERSION_DSDB) {
+               DEBUG(0,("_dsdb_prefixmap_from_ldb_val: pfm_blob->version incorrect\n"));
+               talloc_free(temp_ctx);
+               return WERR_VERSION_PARSE_ERROR;
        }
 
-       if (schemaInfo->length != 21 && schemaInfo->data[0] == 0xFF) {
-               talloc_free(mem_ctx);
-               return WERR_FOOBAR;
-       }
+       /* call the drsuapi version */
+       werr = dsdb_schema_pfm_from_drsuapi_pfm(&pfm_blob.ctr.dsdb, false, mem_ctx, _pfm, NULL);
 
-       /* append the schema info as last element */
-       pfm.ctr.dsdb.num_mappings++;
-       pfm.ctr.dsdb.mappings = talloc_realloc(mem_ctx, pfm.ctr.dsdb.mappings,
-                                              struct drsuapi_DsReplicaOIDMapping,
-                                              pfm.ctr.dsdb.num_mappings);
-       W_ERROR_HAVE_NO_MEMORY(pfm.ctr.dsdb.mappings);
+       talloc_free(temp_ctx);
 
-       schema_info = data_blob_hex_string(pfm.ctr.dsdb.mappings, schemaInfo);
-       W_ERROR_HAVE_NO_MEMORY(schema_info);
+       return werr;
+}
 
-       pfm.ctr.dsdb.mappings[pfm.ctr.dsdb.num_mappings - 1].id_prefix          = 0;    
-       pfm.ctr.dsdb.mappings[pfm.ctr.dsdb.num_mappings - 1].oid.__ndr_size     = schemaInfo->length;
-       pfm.ctr.dsdb.mappings[pfm.ctr.dsdb.num_mappings - 1].oid.oid            = schema_info;
+WERROR dsdb_load_oid_mappings_ldb(struct dsdb_schema *schema,
+                                 const struct ldb_val *prefixMap,
+                                 const struct ldb_val *schemaInfo)
+{
+       WERROR status;
+       const char *schema_info;
+       struct dsdb_schema_prefixmap *pfm;
+       TALLOC_CTX *mem_ctx;
 
-       /* call the drsuapi version */
-       status = dsdb_load_oid_mappings_drsuapi(schema, &pfm.ctr.dsdb);
-       talloc_free(mem_ctx);
+       /* verify input params */
+       if (schemaInfo->length != 21) {
+               return WERR_INVALID_PARAMETER;
+       }
+       if (schemaInfo->data[0] != 0xFF) {
+               return WERR_INVALID_PARAMETER;
+       }
+
+       mem_ctx = talloc_new(schema);
+       W_ERROR_HAVE_NO_MEMORY(mem_ctx);
 
+       /* fetch prefixMap */
+       status = _dsdb_prefixmap_from_ldb_val(prefixMap,
+                                             schema->iconv_convenience,
+                                             mem_ctx, &pfm);
        W_ERROR_NOT_OK_RETURN(status);
 
+       /* decode schema_info */
+       schema_info = hex_encode_talloc(mem_ctx,
+                                       schemaInfo->data,
+                                       schemaInfo->length);
+       if (!schema_info) {
+               talloc_free(mem_ctx);
+               return WERR_NOMEM;
+       }
+
+       /* store prefixMap and schema_info into cached Schema */
+       talloc_free(schema->prefixmap);
+       schema->prefixmap = talloc_steal(schema, pfm);
+
+       talloc_free(discard_const(schema->schema_info));
+       schema->schema_info = talloc_steal(schema, schema_info);
+
+       /* clean up locally allocated mem */
+       talloc_free(mem_ctx);
+
        return WERR_OK;
 }
 
@@ -145,34 +152,9 @@ WERROR dsdb_get_oid_mappings_drsuapi(const struct dsdb_schema *schema,
                                     TALLOC_CTX *mem_ctx,
                                     struct drsuapi_DsReplicaOIDMapping_Ctr **_ctr)
 {
-       struct drsuapi_DsReplicaOIDMapping_Ctr *ctr;
-       uint32_t i;
-
-       ctr = talloc(mem_ctx, struct drsuapi_DsReplicaOIDMapping_Ctr);
-       W_ERROR_HAVE_NO_MEMORY(ctr);
-
-       ctr->num_mappings       = schema->num_prefixes;
-       if (include_schema_info) ctr->num_mappings++;
-       ctr->mappings = talloc_array(schema, struct drsuapi_DsReplicaOIDMapping, ctr->num_mappings);
-       W_ERROR_HAVE_NO_MEMORY(ctr->mappings);
-
-       for (i=0; i < schema->num_prefixes; i++) {
-               ctr->mappings[i].id_prefix      = schema->prefixes[i].id>>16;
-               ctr->mappings[i].oid.oid        = talloc_strndup(ctr->mappings,
-                                                                schema->prefixes[i].oid,
-                                                                schema->prefixes[i].oid_len - 1);
-               W_ERROR_HAVE_NO_MEMORY(ctr->mappings[i].oid.oid);
-       }
-
-       if (include_schema_info) {
-               ctr->mappings[i].id_prefix      = 0;
-               ctr->mappings[i].oid.oid        = talloc_strdup(ctr->mappings,
-                                                               schema->schema_info);
-               W_ERROR_HAVE_NO_MEMORY(ctr->mappings[i].oid.oid);
-       }
-
-       *_ctr = ctr;
-       return WERR_OK;
+       return dsdb_drsuapi_pfm_from_schema_pfm(schema->prefixmap,
+                                               include_schema_info ? schema->schema_info : NULL,
+                                               mem_ctx, _ctr);
 }
 
 WERROR dsdb_get_oid_mappings_ldb(const struct dsdb_schema *schema,
@@ -192,7 +174,8 @@ WERROR dsdb_get_oid_mappings_ldb(const struct dsdb_schema *schema,
        pfm.reserved    = 0;
        pfm.ctr.dsdb    = *ctr;
 
-       ndr_err = ndr_push_struct_blob(prefixMap, mem_ctx, schema->iconv_convenience, &pfm, (ndr_push_flags_fn_t)ndr_push_prefixMapBlob);
+       ndr_err = ndr_push_struct_blob(prefixMap, mem_ctx, schema->iconv_convenience, &pfm,
+                                       (ndr_push_flags_fn_t)ndr_push_prefixMapBlob);
        talloc_free(ctr);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
@@ -205,93 +188,6 @@ WERROR dsdb_get_oid_mappings_ldb(const struct dsdb_schema *schema,
        return WERR_OK;
 }
 
-WERROR dsdb_verify_oid_mappings_drsuapi(const struct dsdb_schema *schema, const struct drsuapi_DsReplicaOIDMapping_Ctr *ctr)
-{
-       uint32_t i,j;
-
-       for (i=0; i < ctr->num_mappings; i++) {
-               if (ctr->mappings[i].oid.oid == NULL) {
-                       return WERR_INVALID_PARAM;
-               }
-
-               if (strncasecmp(ctr->mappings[i].oid.oid, "ff", 2) == 0) {
-                       if (ctr->mappings[i].id_prefix != 0) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       /* the magic value should be in the last array member */
-                       if (i != (ctr->num_mappings - 1)) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       if (ctr->mappings[i].oid.__ndr_size != 21) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       if (strcasecmp(schema->schema_info, ctr->mappings[i].oid.oid) != 0) {
-                               return WERR_DS_DRA_SCHEMA_MISMATCH;
-                       }
-               } else {
-                       /* the last array member should contain the magic value not a oid */
-                       if (i == (ctr->num_mappings - 1)) {
-                               return WERR_INVALID_PARAM;
-                       }
-
-                       for (j=0; j < schema->num_prefixes; j++) {
-                               size_t oid_len;
-                               if (schema->prefixes[j].id != (ctr->mappings[i].id_prefix<<16)) {
-                                       continue;
-                               }
-
-                               oid_len = strlen(ctr->mappings[i].oid.oid);
-
-                               if (oid_len != (schema->prefixes[j].oid_len - 1)) {
-                                       return WERR_DS_DRA_SCHEMA_MISMATCH;
-                               }
-
-                               if (strncmp(ctr->mappings[i].oid.oid, schema->prefixes[j].oid, oid_len) != 0) {
-                                       return WERR_DS_DRA_SCHEMA_MISMATCH;                             
-                               }
-
-                               break;
-                       }
-
-                       if (j == schema->num_prefixes) {
-                               return WERR_DS_DRA_SCHEMA_MISMATCH;                             
-                       }
-               }
-       }
-
-       return WERR_OK;
-}
-
-WERROR dsdb_map_oid2int(const struct dsdb_schema *schema, const char *in, uint32_t *out)
-{
-       return dsdb_find_prefix_for_oid(schema->num_prefixes, schema->prefixes, in, out);
-}
-
-
-WERROR dsdb_map_int2oid(const struct dsdb_schema *schema, uint32_t in, TALLOC_CTX *mem_ctx, const char **out)
-{
-       uint32_t i;
-
-       for (i=0; i < schema->num_prefixes; i++) {
-               const char *val;
-               if (schema->prefixes[i].id != (in & 0xFFFF0000)) {
-                       continue;
-               }
-
-               val = talloc_asprintf(mem_ctx, "%s%u",
-                                     schema->prefixes[i].oid,
-                                     in & 0xFFFF);
-               W_ERROR_HAVE_NO_MEMORY(val);
-
-               *out = val;
-               return WERR_OK;
-       }
-
-       return WERR_DS_NO_MSDS_INTID;
-}
 
 /*
  * this function is called from within a ldb transaction from the schema_fsmo module
@@ -299,16 +195,15 @@ WERROR dsdb_map_int2oid(const struct dsdb_schema *schema, uint32_t in, TALLOC_CT
 WERROR dsdb_create_prefix_mapping(struct ldb_context *ldb, struct dsdb_schema *schema, const char *full_oid)
 {
        WERROR status;
-       uint32_t num_prefixes;
-       struct dsdb_schema_oid_prefix *prefixes;
+       uint32_t attid;
        TALLOC_CTX *mem_ctx;
-       uint32_t out;
+       struct dsdb_schema_prefixmap *pfm;
 
        mem_ctx = talloc_new(ldb);
        W_ERROR_HAVE_NO_MEMORY(mem_ctx);
 
        /* Read prefixes from disk*/
-       status = dsdb_read_prefixes_from_ldb( mem_ctx, ldb, &num_prefixes, &prefixes ); 
+       status = dsdb_read_prefixes_from_ldb(ldb, mem_ctx, &pfm);
        if (!W_ERROR_IS_OK(status)) {
                DEBUG(0,("dsdb_create_prefix_mapping: dsdb_read_prefixes_from_ldb: %s\n",
                        win_errstr(status)));
@@ -317,7 +212,7 @@ WERROR dsdb_create_prefix_mapping(struct ldb_context *ldb, struct dsdb_schema *s
        }
 
        /* Check if there is a prefix for the oid in the prefixes array*/
-       status = dsdb_find_prefix_for_oid( num_prefixes, prefixes, full_oid, &out ); 
+       status = dsdb_schema_pfm_find_oid(pfm, full_oid, NULL);
        if (W_ERROR_IS_OK(status)) {
                /* prefix found*/
                talloc_free(mem_ctx);
@@ -331,16 +226,19 @@ WERROR dsdb_create_prefix_mapping(struct ldb_context *ldb, struct dsdb_schema *s
        }
 
        /* Create the new mapping for the prefix of full_oid */
-       status = dsdb_prefix_map_update(mem_ctx, &num_prefixes, &prefixes, full_oid);
+       status = dsdb_schema_pfm_make_attid(pfm, full_oid, &attid);
        if (!W_ERROR_IS_OK(status)) {
-               DEBUG(0,("dsdb_create_prefix_mapping: dsdb_prefix_map_update: %s\n",
+               DEBUG(0,("dsdb_create_prefix_mapping: dsdb_schema_pfm_make_attid: %s\n",
                        win_errstr(status)));
                talloc_free(mem_ctx);
                return status;
        }
 
+       talloc_unlink(schema, schema->prefixmap);
+       schema->prefixmap = talloc_steal(schema, pfm);
+
        /* Update prefixMap in ldb*/
-       status = dsdb_write_prefixes_to_ldb(mem_ctx, ldb, num_prefixes, prefixes);
+       status = dsdb_write_prefixes_from_schema_to_ldb(mem_ctx, ldb, schema);
        if (!W_ERROR_IS_OK(status)) {
                DEBUG(0,("dsdb_create_prefix_mapping: dsdb_write_prefixes_to_ldb: %s\n",
                        win_errstr(status)));
@@ -348,171 +246,90 @@ WERROR dsdb_create_prefix_mapping(struct ldb_context *ldb, struct dsdb_schema *s
                return status;
        }
 
+       DEBUG(2,(__location__ " Added prefixMap %s - now have %u prefixes\n",
+                full_oid, schema->prefixmap->length));
+
        talloc_free(mem_ctx);
        return status;
 }
 
-WERROR dsdb_prefix_map_update(TALLOC_CTX *mem_ctx, uint32_t *num_prefixes, struct dsdb_schema_oid_prefix **prefixes, const char *oid)
-{
-       uint32_t new_num_prefixes, index_new_prefix, new_entry_id;
-       const char* lastDotOffset;
-       size_t size;
-       
-       new_num_prefixes = *num_prefixes + 1;
-       index_new_prefix = *num_prefixes;
-
-       /*
-        * this is the algorithm we use to create new mappings for now
-        *
-        * TODO: find what algorithm windows use
-        */
-       new_entry_id = (*num_prefixes)<<16;
-
-       /* Extract the prefix from the oid*/
-       lastDotOffset = strrchr(oid, '.');
-       if (lastDotOffset == NULL) {
-               DEBUG(0,("dsdb_prefix_map_update: failed to find the last dot\n"));
-               return WERR_NOT_FOUND;
-       }
-
-       /* Calculate the size of the remainig string that should be the prefix of it */
-       size = strlen(oid) - strlen(lastDotOffset);
-       if (size <= 0) {
-               DEBUG(0,("dsdb_prefix_map_update: size of the remaining string invalid\n"));
-               return WERR_FOOBAR;
-       }
-       /* Add one because we need to copy the dot */
-       size += 1;
-
-       /* Create a spot in the prefixMap for one more prefix*/
-       (*prefixes) = talloc_realloc(mem_ctx, *prefixes, struct dsdb_schema_oid_prefix, new_num_prefixes);
-       W_ERROR_HAVE_NO_MEMORY(*prefixes);
-
-       /* Add the new prefix entry*/
-       (*prefixes)[index_new_prefix].id = new_entry_id;
-       (*prefixes)[index_new_prefix].oid = talloc_strndup(mem_ctx, oid, size);
-       (*prefixes)[index_new_prefix].oid_len = strlen((*prefixes)[index_new_prefix].oid);
 
-       /* Increase num_prefixes because new prefix has been added */
-       ++(*num_prefixes);
-
-       return WERR_OK;
-}
-
-WERROR dsdb_find_prefix_for_oid(uint32_t num_prefixes, const struct dsdb_schema_oid_prefix *prefixes, const char *in, uint32_t *out)
+WERROR dsdb_write_prefixes_from_schema_to_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
+                                             const struct dsdb_schema *schema)
 {
-       uint32_t i;
-
-       for (i=0; i < num_prefixes; i++) {
-               const char *val_str;
-               char *end_str;
-               unsigned val;
-
-               if (strncmp(prefixes[i].oid, in, prefixes[i].oid_len) != 0) {
-                       continue;
-               }
-
-               val_str = in + prefixes[i].oid_len;
-               end_str = NULL;
-               errno = 0;
-
-               if (val_str[0] == '\0') {
-                       return WERR_INVALID_PARAM;
-               }
-
-               /* two '.' chars are invalid */
-               if (val_str[0] == '.') {
-                       return WERR_INVALID_PARAM;
-               }
-
-               val = strtoul(val_str, &end_str, 10);
-               if (end_str[0] == '.' && end_str[1] != '\0') {
-                       /*
-                        * if it's a '.' and not the last char
-                        * then maybe an other mapping apply
-                        */
-                       continue;
-               } else if (end_str[0] != '\0') {
-                       return WERR_INVALID_PARAM;
-               } else if (val > 0xFFFF) {
-                       return WERR_INVALID_PARAM;
-               }
-
-               *out = prefixes[i].id | val;
-               return WERR_OK;
-       }
-
-       return WERR_DS_NO_MSDS_INTID;
-}
-
-WERROR dsdb_write_prefixes_to_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
-                                 uint32_t num_prefixes,
-                                 const struct dsdb_schema_oid_prefix *prefixes)
-{
-       struct ldb_message msg;
+       WERROR status;
+       int ldb_ret;
+       struct ldb_message *msg;
        struct ldb_dn *schema_dn;
-       struct ldb_message_element el;
-       struct prefixMapBlob pm;
+       struct prefixMapBlob pfm_blob;
        struct ldb_val ndr_blob;
        enum ndr_err_code ndr_err;
-       uint32_t i;
-       int ret;
-       
+       TALLOC_CTX *temp_ctx;
+       struct drsuapi_DsReplicaOIDMapping_Ctr *ctr;
+
        schema_dn = samdb_schema_dn(ldb);
        if (!schema_dn) {
-               DEBUG(0,("dsdb_write_prefixes_to_ldb: no schema dn present\n"));        
+               DEBUG(0,("dsdb_write_prefixes_from_schema_to_ldb: no schema dn present\n"));
                return WERR_FOOBAR;
        }
 
-       pm.version                      = PREFIX_MAP_VERSION_DSDB;
-       pm.ctr.dsdb.num_mappings        = num_prefixes;
-       pm.ctr.dsdb.mappings            = talloc_array(mem_ctx,
-                                               struct drsuapi_DsReplicaOIDMapping,
-                                               pm.ctr.dsdb.num_mappings);
-       if (!pm.ctr.dsdb.mappings) {
-               return WERR_NOMEM;
-       }
+       temp_ctx = talloc_new(mem_ctx);
+       W_ERROR_HAVE_NO_MEMORY(temp_ctx);
 
-       for (i=0; i < num_prefixes; i++) {
-               pm.ctr.dsdb.mappings[i].id_prefix = prefixes[i].id>>16;
-               pm.ctr.dsdb.mappings[i].oid.oid = talloc_strdup(pm.ctr.dsdb.mappings, prefixes[i].oid);
+       /* convert schema_prefixMap to prefixMap blob */
+       status = dsdb_get_oid_mappings_drsuapi(schema, false, temp_ctx, &ctr);
+       if (!W_ERROR_IS_OK(status)) {
+               talloc_free(temp_ctx);
+               return status;
        }
 
-       ndr_err = ndr_push_struct_blob(&ndr_blob, ldb,
+       pfm_blob.version        = PREFIX_MAP_VERSION_DSDB;
+       pfm_blob.ctr.dsdb       = *ctr;
+
+       ndr_err = ndr_push_struct_blob(&ndr_blob, temp_ctx,
                                       lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")),
-                                      &pm,
+                                      &pfm_blob,
                                       (ndr_push_flags_fn_t)ndr_push_prefixMapBlob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               talloc_free(temp_ctx);
                return WERR_FOOBAR;
        }
  
-       el.num_values = 1;
-       el.values = &ndr_blob;
-       el.flags = LDB_FLAG_MOD_REPLACE;
-       el.name = talloc_strdup(mem_ctx, "prefixMap");
-       msg.dn = ldb_dn_copy(mem_ctx, schema_dn);
-       msg.num_elements = 1;
-       msg.elements = &el;
+       /* write serialized prefixMap into LDB */
+       msg = ldb_msg_new(temp_ctx);
+       if (!msg) {
+               talloc_free(temp_ctx);
+               return WERR_NOMEM;
+       }
+
+       msg->dn = schema_dn;
+       ldb_ret = ldb_msg_add_value(msg, "prefixMap", &ndr_blob, NULL);
+       if (ldb_ret != 0) {
+               talloc_free(temp_ctx);
+               DEBUG(0,("dsdb_write_prefixes_from_schema_to_ldb: ldb_msg_add_value failed\n"));        
+               return WERR_NOMEM;
+       }
  
-       ret = ldb_modify( ldb, &msg );
-       if (ret != 0) {
-               DEBUG(0,("dsdb_write_prefixes_to_ldb: ldb_modify failed\n"));   
+       ldb_ret = samdb_replace( ldb, msg, msg );
+
+       talloc_free(temp_ctx);
+
+       if (ldb_ret != 0) {
+               DEBUG(0,("dsdb_write_prefixes_from_schema_to_ldb: samdb_replace failed\n"));    
                return WERR_FOOBAR;
        }
  
        return WERR_OK;
 }
 
-WERROR dsdb_read_prefixes_from_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb, uint32_t* num_prefixes, struct dsdb_schema_oid_prefix **prefixes)
+WERROR dsdb_read_prefixes_from_ldb(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, struct dsdb_schema_prefixmap **_pfm)
 {
-       struct prefixMapBlob *blob;
-       enum ndr_err_code ndr_err;
-       uint32_t i;
+       WERROR werr;
+       int ldb_ret;
        const struct ldb_val *prefix_val;
+       struct smb_iconv_convenience *iconv_convenience;
        struct ldb_dn *schema_dn;
-       struct ldb_result *schema_res;
-       int ret;    
+       struct ldb_result *schema_res = NULL;
        static const char *schema_attrs[] = {
                "prefixMap",
                NULL
@@ -524,12 +341,12 @@ WERROR dsdb_read_prefixes_from_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
                return WERR_FOOBAR;
        }
 
-       ret = ldb_search(ldb, mem_ctx, &schema_res, schema_dn, LDB_SCOPE_BASE, schema_attrs, NULL);
-       if (ret == LDB_ERR_NO_SUCH_OBJECT) {
+       ldb_ret = ldb_search(ldb, mem_ctx, &schema_res, schema_dn, LDB_SCOPE_BASE, schema_attrs, NULL);
+       if (ldb_ret == LDB_ERR_NO_SUCH_OBJECT) {
                DEBUG(0,("dsdb_read_prefixes_from_ldb: no prefix map present\n"));
                talloc_free(schema_res);
                return WERR_FOOBAR;
-       } else if (ret != LDB_SUCCESS) {
+       } else if (ldb_ret != LDB_SUCCESS) {
                DEBUG(0,("dsdb_read_prefixes_from_ldb: failed to search the schema head\n"));
                talloc_free(schema_res);
                return WERR_FOOBAR;
@@ -542,53 +359,101 @@ WERROR dsdb_read_prefixes_from_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
                return WERR_FOOBAR;
        }
 
-       blob = talloc(mem_ctx, struct prefixMapBlob);
-       W_ERROR_HAVE_NO_MEMORY(blob);
+       iconv_convenience = lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm"));
 
-       ndr_err = ndr_pull_struct_blob(prefix_val, blob, 
-                                          lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")), 
-                                          blob,
-                                          (ndr_pull_flags_fn_t)ndr_pull_prefixMapBlob);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               DEBUG(0,("dsdb_read_prefixes_from_ldb: ndr_pull_struct_blob failed\n"));
-               talloc_free(blob);
-               talloc_free(schema_res);
-               return WERR_FOOBAR;
+       werr = _dsdb_prefixmap_from_ldb_val(prefix_val,
+                                           iconv_convenience,
+                                           mem_ctx,
+                                           _pfm);
+       talloc_free(schema_res);
+       W_ERROR_NOT_OK_RETURN(werr);
+
+       return WERR_OK;
+}
+
+/*
+  this will be replaced with something that looks at the right part of
+  the schema once we know where unique indexing information is hidden
+ */
+static bool dsdb_schema_unique_attribute(const char *attr)
+{
+       const char *attrs[] = { "objectGUID", "objectSID" , NULL };
+       int i;
+       for (i=0;attrs[i];i++) {
+               if (strcasecmp(attr, attrs[i]) == 0) {
+                       return true;
+               }
        }
+       return false;
+}
 
-       talloc_free(schema_res);
 
-       if (blob->version != PREFIX_MAP_VERSION_DSDB) {
-               DEBUG(0,("dsdb_read_prefixes_from_ldb: blob->version incorect\n"));
-               talloc_free(blob);
-               return WERR_FOOBAR;
+/*
+  setup the ldb_schema_attribute field for a dsdb_attribute
+ */
+static int dsdb_schema_setup_ldb_schema_attribute(struct ldb_context *ldb, 
+                                                 struct dsdb_attribute *attr)
+{
+       const char *syntax = attr->syntax->ldb_syntax;
+       const struct ldb_schema_syntax *s;
+       struct ldb_schema_attribute *a;
+
+       if (!syntax) {
+               syntax = attr->syntax->ldap_oid;
        }
-       
-       *num_prefixes = blob->ctr.dsdb.num_mappings;
-       *prefixes = talloc_array(mem_ctx, struct dsdb_schema_oid_prefix, *num_prefixes);
-       if(!(*prefixes)) {
-               talloc_free(blob);
-               return WERR_NOMEM;
+
+       s = ldb_samba_syntax_by_lDAPDisplayName(ldb, attr->lDAPDisplayName);
+       if (s == NULL) {
+               s = ldb_samba_syntax_by_name(ldb, syntax);
        }
-       for (i=0; i < blob->ctr.dsdb.num_mappings; i++) {
-               char *oid;
-               (*prefixes)[i].id = blob->ctr.dsdb.mappings[i].id_prefix<<16;
-               oid = talloc_strdup(mem_ctx, blob->ctr.dsdb.mappings[i].oid.oid);
-               (*prefixes)[i].oid = talloc_asprintf_append(oid, "."); 
-               (*prefixes)[i].oid_len = strlen(blob->ctr.dsdb.mappings[i].oid.oid);
+       if (s == NULL) {
+               s = ldb_standard_syntax_by_name(ldb, syntax);
        }
 
-       talloc_free(blob);
-       return WERR_OK;
+       if (s == NULL) {
+               return LDB_ERR_OPERATIONS_ERROR;                
+       }
+
+       attr->ldb_schema_attribute = a = talloc(attr, struct ldb_schema_attribute);
+       if (attr->ldb_schema_attribute == NULL) {
+               ldb_oom(ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       a->name = attr->lDAPDisplayName;
+       a->flags = 0;
+       a->syntax = s;
+
+       if (dsdb_schema_unique_attribute(a->name)) {
+               a->flags |= LDB_ATTR_FLAG_UNIQUE_INDEX;
+       }
+       if (attr->isSingleValued) {
+               a->flags |= LDB_ATTR_FLAG_SINGLE_VALUE;
+       }
+       
+       
+       return LDB_SUCCESS;
 }
 
+
 #define GET_STRING_LDB(msg, attr, mem_ctx, p, elem, strict) do { \
-       (p)->elem = samdb_result_string(msg, attr, NULL);\
-       if (strict && (p)->elem == NULL) { \
-               d_printf("%s: %s == NULL\n", __location__, attr); \
-               return WERR_INVALID_PARAM; \
-       } \
-       talloc_steal(mem_ctx, (p)->elem); \
+       const struct ldb_val *get_string_val = ldb_msg_find_ldb_val(msg, attr); \
+       if (get_string_val == NULL) { \
+               if (strict) {                                     \
+                       d_printf("%s: %s == NULL\n", __location__, attr); \
+                       return WERR_INVALID_PARAM;                      \
+               } else {                                                \
+                       (p)->elem = NULL;                               \
+               }                                                       \
+       } else {                                                        \
+               (p)->elem = talloc_strndup(mem_ctx,                     \
+                                          (const char *)get_string_val->data, \
+                                          get_string_val->length); \
+               if (!(p)->elem) {                                       \
+                       d_printf("%s: talloc_strndup failed for %s\n", __location__, attr); \
+                       return WERR_NOMEM;                              \
+               }                                                       \
+       }                                                               \
 } while (0)
 
 #define GET_STRING_LIST_LDB(msg, attr, mem_ctx, p, elem, strict) do {  \
@@ -676,7 +541,8 @@ WERROR dsdb_read_prefixes_from_ldb(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
        }\
 } while (0)
 
-WERROR dsdb_attribute_from_ldb(const struct dsdb_schema *schema,
+WERROR dsdb_attribute_from_ldb(struct ldb_context *ldb,
+                              const struct dsdb_schema *schema,
                               struct ldb_message *msg,
                               TALLOC_CTX *mem_ctx,
                               struct dsdb_attribute *attr)
@@ -686,11 +552,13 @@ WERROR dsdb_attribute_from_ldb(const struct dsdb_schema *schema,
        GET_STRING_LDB(msg, "cn", mem_ctx, attr, cn, false);
        GET_STRING_LDB(msg, "lDAPDisplayName", mem_ctx, attr, lDAPDisplayName, true);
        GET_STRING_LDB(msg, "attributeID", mem_ctx, attr, attributeID_oid, true);
-       if (schema->num_prefixes == 0) {
+       if (!schema->prefixmap || schema->prefixmap->length == 0) {
                /* set an invalid value */
                attr->attributeID_id = 0xFFFFFFFF;
        } else {
-               status = dsdb_map_oid2int(schema, attr->attributeID_oid, &attr->attributeID_id);
+               status = dsdb_schema_pfm_make_attid(schema->prefixmap,
+                                                   attr->attributeID_oid,
+                                                   &attr->attributeID_id);
                if (!W_ERROR_IS_OK(status)) {
                        DEBUG(0,("%s: '%s': unable to map attributeID %s: %s\n",
                                __location__, attr->lDAPDisplayName, attr->attributeID_oid,
@@ -709,11 +577,13 @@ WERROR dsdb_attribute_from_ldb(const struct dsdb_schema *schema,
        GET_UINT32_LDB(msg, "linkID", attr, linkID);
 
        GET_STRING_LDB(msg, "attributeSyntax", mem_ctx, attr, attributeSyntax_oid, true);
-       if (schema->num_prefixes == 0) {
+       if (!schema->prefixmap || schema->prefixmap->length == 0) {
                /* set an invalid value */
                attr->attributeSyntax_id = 0xFFFFFFFF;
        } else {
-               status = dsdb_map_oid2int(schema, attr->attributeSyntax_oid, &attr->attributeSyntax_id);
+               status = dsdb_schema_pfm_make_attid(schema->prefixmap,
+                                                   attr->attributeSyntax_oid,
+                                                   &attr->attributeSyntax_id);
                if (!W_ERROR_IS_OK(status)) {
                        DEBUG(0,("%s: '%s': unable to map attributeSyntax_ %s: %s\n",
                                __location__, attr->lDAPDisplayName, attr->attributeSyntax_oid,
@@ -745,6 +615,10 @@ WERROR dsdb_attribute_from_ldb(const struct dsdb_schema *schema,
                return WERR_DS_ATT_SCHEMA_REQ_SYNTAX;
        }
 
+       if (dsdb_schema_setup_ldb_schema_attribute(ldb, attr) != LDB_SUCCESS) {
+               return WERR_DS_ATT_SCHEMA_REQ_SYNTAX;
+       }
+
        return WERR_OK;
 }
 
@@ -758,11 +632,13 @@ WERROR dsdb_class_from_ldb(const struct dsdb_schema *schema,
        GET_STRING_LDB(msg, "cn", mem_ctx, obj, cn, false);
        GET_STRING_LDB(msg, "lDAPDisplayName", mem_ctx, obj, lDAPDisplayName, true);
        GET_STRING_LDB(msg, "governsID", mem_ctx, obj, governsID_oid, true);
-       if (schema->num_prefixes == 0) {
+       if (!schema->prefixmap || schema->prefixmap->length == 0) {
                /* set an invalid value */
                obj->governsID_id = 0xFFFFFFFF;
        } else {
-               status = dsdb_map_oid2int(schema, obj->governsID_oid, &obj->governsID_id);
+               status = dsdb_schema_pfm_make_attid(schema->prefixmap,
+                                                   obj->governsID_oid,
+                                                   &obj->governsID_id);
                if (!W_ERROR_IS_OK(status)) {
                        DEBUG(0,("%s: '%s': unable to map governsID %s: %s\n",
                                __location__, obj->lDAPDisplayName, obj->governsID_oid,
@@ -788,7 +664,6 @@ WERROR dsdb_class_from_ldb(const struct dsdb_schema *schema,
 
        GET_STRING_LIST_LDB(msg, "systemPossSuperiors", mem_ctx, obj, systemPossSuperiors, false);
        GET_STRING_LIST_LDB(msg, "possSuperiors", mem_ctx, obj, possSuperiors, false);
-       GET_STRING_LIST_LDB(msg, "possibleInferiors", mem_ctx, obj, possibleInferiors, false);
 
        GET_STRING_LDB(msg, "defaultSecurityDescriptor", mem_ctx, obj, defaultSecurityDescriptor, false);
 
@@ -811,7 +686,7 @@ WERROR dsdb_class_from_ldb(const struct dsdb_schema *schema,
 /* 
  Create a DSDB schema from the ldb results provided.  This is called
  directly when the schema is provisioned from an on-disk LDIF file, or
- from dsdb_schema_from_schema_dn below
+ from dsdb_schema_from_schema_dn in schema_fsmo
 */
 
 int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
@@ -838,6 +713,7 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
        if (!prefix_val) {
                *error_string = talloc_asprintf(mem_ctx, 
                                                "schema_fsmo_init: no prefixMap attribute found");
+               DEBUG(0,(__location__ ": %s\n", *error_string));
                return LDB_ERR_CONSTRAINT_VIOLATION;
        }
        info_val = ldb_msg_find_ldb_val(schema_res->msgs[0], "schemaInfo");
@@ -855,6 +731,7 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
                *error_string = talloc_asprintf(mem_ctx, 
                              "schema_fsmo_init: failed to load oid mappings: %s",
                              win_errstr(status));
+               DEBUG(0,(__location__ ": %s\n", *error_string));
                return LDB_ERR_CONSTRAINT_VIOLATION;
        }
 
@@ -867,16 +744,17 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
                        return LDB_ERR_OPERATIONS_ERROR;
                }
 
-               status = dsdb_attribute_from_ldb(schema, attrs_res->msgs[i], sa, sa);
+               status = dsdb_attribute_from_ldb(ldb, schema, attrs_res->msgs[i], sa, sa);
                if (!W_ERROR_IS_OK(status)) {
                        *error_string = talloc_asprintf(mem_ctx, 
                                      "schema_fsmo_init: failed to load attribute definition: %s:%s",
                                      ldb_dn_get_linearized(attrs_res->msgs[i]->dn),
                                      win_errstr(status));
+                       DEBUG(0,(__location__ ": %s\n", *error_string));
                        return LDB_ERR_CONSTRAINT_VIOLATION;
                }
 
-               DLIST_ADD_END(schema->attributes, sa, struct dsdb_attribute *);
+               DLIST_ADD(schema->attributes, sa);
        }
 
        for (i=0; i < objectclass_res->count; i++) {
@@ -894,10 +772,11 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
                                      "schema_fsmo_init: failed to load class definition: %s:%s",
                                      ldb_dn_get_linearized(objectclass_res->msgs[i]->dn),
                                      win_errstr(status));
+                       DEBUG(0,(__location__ ": %s\n", *error_string));
                        return LDB_ERR_CONSTRAINT_VIOLATION;
                }
 
-               DLIST_ADD_END(schema->classes, sc, struct dsdb_class *);
+               DLIST_ADD(schema->classes, sc);
        }
 
        schema->fsmo.master_dn = ldb_msg_find_attr_as_dn(ldb, schema, schema_res->msgs[0], "fSMORoleOwner");
@@ -914,103 +793,6 @@ int dsdb_schema_from_ldb_results(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
        return LDB_SUCCESS;
 }
 
-/*
-  Given an LDB, and the DN, return a populated schema
-*/
-
-int dsdb_schema_from_schema_dn(TALLOC_CTX *mem_ctx, struct ldb_context *ldb,
-                              struct smb_iconv_convenience *iconv_convenience, 
-                              struct ldb_dn *schema_dn,
-                              struct dsdb_schema **schema,
-                              char **error_string_out) 
-{
-       TALLOC_CTX *tmp_ctx;
-       char *error_string;
-       int ret;
-
-       struct ldb_result *schema_res;
-       struct ldb_result *a_res;
-       struct ldb_result *c_res;
-       static const char *schema_attrs[] = {
-               "prefixMap",
-               "schemaInfo",
-               "fSMORoleOwner",
-               NULL
-       };
-
-       tmp_ctx = talloc_new(mem_ctx);
-       if (!tmp_ctx) {
-               dsdb_oom(error_string_out, mem_ctx);
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
-
-       /*
-        * setup the prefix mappings and schema info
-        */
-       ret = ldb_search(ldb, tmp_ctx, &schema_res,
-                        schema_dn, LDB_SCOPE_BASE, schema_attrs, NULL);
-       if (ret == LDB_ERR_NO_SUCH_OBJECT) {
-               talloc_free(tmp_ctx);
-               return ret;
-       } else if (ret != LDB_SUCCESS) {
-               *error_string_out = talloc_asprintf(mem_ctx, 
-                                      "dsdb_schema: failed to search the schema head: %s",
-                                      ldb_errstring(ldb));
-               talloc_free(tmp_ctx);
-               return ret;
-       }
-       if (schema_res->count != 1) {
-               *error_string_out = talloc_asprintf(mem_ctx, 
-                             "dsdb_schema: [%u] schema heads found on a base search",
-                             schema_res->count);
-               talloc_free(tmp_ctx);
-               return LDB_ERR_CONSTRAINT_VIOLATION;
-       }
-
-       /*
-        * load the attribute definitions
-        */
-       ret = ldb_search(ldb, tmp_ctx, &a_res,
-                        schema_dn, LDB_SCOPE_ONELEVEL, NULL,
-                        "(objectClass=attributeSchema)");
-       if (ret != LDB_SUCCESS) {
-               *error_string_out = talloc_asprintf(mem_ctx, 
-                                      "dsdb_schema: failed to search attributeSchema objects: %s",
-                                      ldb_errstring(ldb));
-               talloc_free(tmp_ctx);
-               return ret;
-       }
-
-       /*
-        * load the objectClass definitions
-        */
-       ret = ldb_search(ldb, tmp_ctx, &c_res,
-                        schema_dn, LDB_SCOPE_ONELEVEL, NULL,
-                        "(objectClass=classSchema)");
-       if (ret != LDB_SUCCESS) {
-               *error_string_out = talloc_asprintf(mem_ctx, 
-                                      "dsdb_schema: failed to search attributeSchema objects: %s",
-                                      ldb_errstring(ldb));
-               talloc_free(tmp_ctx);
-               return ret;
-       }
-
-       ret = dsdb_schema_from_ldb_results(tmp_ctx, ldb,
-                                          lp_iconv_convenience(ldb_get_opaque(ldb, "loadparm")),
-                                          schema_res, a_res, c_res, schema, &error_string);
-       if (ret != LDB_SUCCESS) {
-               *error_string_out = talloc_asprintf(mem_ctx, 
-                                                   "dsdb_schema load failed: %s",
-                                                   error_string);
-               talloc_free(tmp_ctx);
-               return ret;
-       }
-       talloc_steal(mem_ctx, *schema);
-       talloc_free(tmp_ctx);
-
-       return LDB_SUCCESS;
-}      
-
 
 static const struct {
        const char *name;
@@ -1066,7 +848,7 @@ static struct drsuapi_DsReplicaAttribute *dsdb_find_object_attr_name(struct dsdb
                                                                     uint32_t *idx)
 {
        WERROR status;
-       uint32_t i, id;
+       uint32_t i, attid;
        const char *oid = NULL;
 
        for(i=0; i < ARRAY_SIZE(name_mappings); i++) {
@@ -1080,13 +862,13 @@ static struct drsuapi_DsReplicaAttribute *dsdb_find_object_attr_name(struct dsdb
                return NULL;
        }
 
-       status = dsdb_map_oid2int(schema, oid, &id);
+       status = dsdb_schema_pfm_make_attid(schema->prefixmap, oid, &attid);
        if (!W_ERROR_IS_OK(status)) {
                return NULL;
        }
 
        for (i=0; i < obj->attribute_ctr.num_attributes; i++) {
-               if (obj->attribute_ctr.attributes[i].attid != id) continue;
+               if (obj->attribute_ctr.attributes[i].attid != attid) continue;
 
                if (idx) *idx = i;
                return &obj->attribute_ctr.attributes[i];
@@ -1124,32 +906,20 @@ static struct drsuapi_DsReplicaAttribute *dsdb_find_object_attr_name(struct dsdb
        } \
 } while (0)
 
-#define GET_STRING_LIST_DS(s, r, attr, mem_ctx, p, elem, strict) do { \
-       int get_string_list_counter;                                    \
+#define GET_UINT32_LIST_DS(s, r, attr, mem_ctx, p, elem) do { \
+       int list_counter;                                       \
        struct drsuapi_DsReplicaAttribute *_a; \
        _a = dsdb_find_object_attr_name(s, r, attr, NULL); \
-       if (strict && !_a) { \
-               d_printf("%s: %s == NULL\n", __location__, attr); \
-               return WERR_INVALID_PARAM; \
-       } \
-       (p)->elem = _a ? talloc_array(mem_ctx, const char *, _a->value_ctr.num_values + 1) : NULL; \
-        for (get_string_list_counter=0;                                        \
-            _a && get_string_list_counter < _a->value_ctr.num_values;  \
-            get_string_list_counter++) {                               \
-               size_t _ret;                                            \
-               if (!convert_string_talloc_convenience(mem_ctx, s->iconv_convenience, CH_UTF16, CH_UNIX, \
-                                            _a->value_ctr.values[get_string_list_counter].blob->data, \
-                                            _a->value_ctr.values[get_string_list_counter].blob->length, \
-                                                      (void **)discard_const(&(p)->elem[get_string_list_counter]), &_ret, false)) { \
-                       DEBUG(0,("%s: invalid data!\n", attr)); \
-                       dump_data(0, \
-                                    _a->value_ctr.values[get_string_list_counter].blob->data, \
-                                    _a->value_ctr.values[get_string_list_counter].blob->length); \
-                       return WERR_FOOBAR; \
-               } \
-               (p)->elem[get_string_list_counter+1] = NULL;            \
+       (p)->elem = _a ? talloc_array(mem_ctx, uint32_t, _a->value_ctr.num_values + 1) : NULL; \
+        for (list_counter=0;                                   \
+            _a && list_counter < _a->value_ctr.num_values;     \
+            list_counter++) {                          \
+               if (_a->value_ctr.values[list_counter].blob->length != 4) { \
+                       return WERR_INVALID_PARAM;                      \
+               }                                                       \
+               (p)->elem[list_counter] = IVAL(_a->value_ctr.values[list_counter].blob->data, 0); \
        }                                                               \
-       talloc_steal(mem_ctx, (p)->elem);                               \
+       if (_a) (p)->elem[list_counter] = 0;                            \
 } while (0)
 
 #define GET_DN_DS(s, r, attr, mem_ctx, p, elem, strict) do { \
@@ -1275,7 +1045,8 @@ static struct drsuapi_DsReplicaAttribute *dsdb_find_object_attr_name(struct dsdb
        }\
 } while (0)
 
-WERROR dsdb_attribute_from_drsuapi(struct dsdb_schema *schema,
+WERROR dsdb_attribute_from_drsuapi(struct ldb_context *ldb,
+                                  struct dsdb_schema *schema,
                                   struct drsuapi_DsReplicaObject *r,
                                   TALLOC_CTX *mem_ctx,
                                   struct dsdb_attribute *attr)
@@ -1285,7 +1056,8 @@ WERROR dsdb_attribute_from_drsuapi(struct dsdb_schema *schema,
        GET_STRING_DS(schema, r, "name", mem_ctx, attr, cn, true);
        GET_STRING_DS(schema, r, "lDAPDisplayName", mem_ctx, attr, lDAPDisplayName, true);
        GET_UINT32_DS(schema, r, "attributeID", attr, attributeID_id);
-       status = dsdb_map_int2oid(schema, attr->attributeID_id, mem_ctx, &attr->attributeID_oid);
+       status = dsdb_schema_pfm_oid_from_attid(schema->prefixmap, attr->attributeID_id,
+                                               mem_ctx, &attr->attributeID_oid);
        if (!W_ERROR_IS_OK(status)) {
                DEBUG(0,("%s: '%s': unable to map attributeID 0x%08X: %s\n",
                        __location__, attr->lDAPDisplayName, attr->attributeID_id,
@@ -1303,7 +1075,8 @@ WERROR dsdb_attribute_from_drsuapi(struct dsdb_schema *schema,
        GET_UINT32_DS(schema, r, "linkID", attr, linkID);
 
        GET_UINT32_DS(schema, r, "attributeSyntax", attr, attributeSyntax_id);
-       status = dsdb_map_int2oid(schema, attr->attributeSyntax_id, mem_ctx, &attr->attributeSyntax_oid);
+       status = dsdb_schema_pfm_oid_from_attid(schema->prefixmap, attr->attributeSyntax_id,
+                                               mem_ctx, &attr->attributeSyntax_oid);
        if (!W_ERROR_IS_OK(status)) {
                DEBUG(0,("%s: '%s': unable to map attributeSyntax 0x%08X: %s\n",
                        __location__, attr->lDAPDisplayName, attr->attributeSyntax_id,
@@ -1334,6 +1107,10 @@ WERROR dsdb_attribute_from_drsuapi(struct dsdb_schema *schema,
                return WERR_DS_ATT_SCHEMA_REQ_SYNTAX;
        }
 
+       if (dsdb_schema_setup_ldb_schema_attribute(ldb, attr) != LDB_SUCCESS) {
+               return WERR_DS_ATT_SCHEMA_REQ_SYNTAX;
+       }
+
        return WERR_OK;
 }
 
@@ -1347,7 +1124,8 @@ WERROR dsdb_class_from_drsuapi(struct dsdb_schema *schema,
        GET_STRING_DS(schema, r, "name", mem_ctx, obj, cn, true);
        GET_STRING_DS(schema, r, "lDAPDisplayName", mem_ctx, obj, lDAPDisplayName, true);
        GET_UINT32_DS(schema, r, "governsID", obj, governsID_id);
-       status = dsdb_map_int2oid(schema, obj->governsID_id, mem_ctx, &obj->governsID_oid);
+       status = dsdb_schema_pfm_oid_from_attid(schema->prefixmap, obj->governsID_id,
+                                               mem_ctx, &obj->governsID_oid);
        if (!W_ERROR_IS_OK(status)) {
                DEBUG(0,("%s: '%s': unable to map governsID 0x%08X: %s\n",
                        __location__, obj->lDAPDisplayName, obj->governsID_id,
@@ -1360,20 +1138,18 @@ WERROR dsdb_class_from_drsuapi(struct dsdb_schema *schema,
        GET_STRING_DS(schema, r, "rDNAttID", mem_ctx, obj, rDNAttID, false);
        GET_DN_DS(schema, r, "defaultObjectCategory", mem_ctx, obj, defaultObjectCategory, true);
 
-       GET_STRING_DS(schema, r, "subClassOf", mem_ctx, obj, subClassOf, true);
-
+       GET_UINT32_DS(schema, r, "subClassOf", obj, subClassOf_id);
 
-       GET_STRING_LIST_DS(schema, r, "systemAuxiliaryClass", mem_ctx, obj, systemAuxiliaryClass, false);
-       GET_STRING_LIST_DS(schema, r, "auxiliaryClass", mem_ctx, obj, auxiliaryClass, false);
+       GET_UINT32_LIST_DS(schema, r, "systemAuxiliaryClass", mem_ctx, obj, systemAuxiliaryClass_ids);
+       GET_UINT32_LIST_DS(schema, r, "auxiliaryClass", mem_ctx, obj, auxiliaryClass_ids);
 
-       GET_STRING_LIST_DS(schema, r, "systemMustContain", mem_ctx, obj, systemMustContain, false);
-       GET_STRING_LIST_DS(schema, r, "systemMayContain", mem_ctx, obj, systemMayContain, false);
-       GET_STRING_LIST_DS(schema, r, "mustContain", mem_ctx, obj, mustContain, false);
-       GET_STRING_LIST_DS(schema, r, "mayContain", mem_ctx, obj, mayContain, false);
+       GET_UINT32_LIST_DS(schema, r, "systemMustContain", mem_ctx, obj, systemMustContain_ids);
+       GET_UINT32_LIST_DS(schema, r, "systemMayContain", mem_ctx, obj, systemMayContain_ids);
+       GET_UINT32_LIST_DS(schema, r, "mustContain", mem_ctx, obj, mustContain_ids);
+       GET_UINT32_LIST_DS(schema, r, "mayContain", mem_ctx, obj, mayContain_ids);
 
-       GET_STRING_LIST_DS(schema, r, "systemPossSuperiors", mem_ctx, obj, systemPossSuperiors, false);
-       GET_STRING_LIST_DS(schema, r, "possSuperiors", mem_ctx, obj, possSuperiors, false);
-       GET_STRING_LIST_DS(schema, r, "possibleInferiors", mem_ctx, obj, possibleInferiors, false);
+       GET_UINT32_LIST_DS(schema, r, "systemPossSuperiors", mem_ctx, obj, systemPossSuperiors_ids);
+       GET_UINT32_LIST_DS(schema, r, "possSuperiors", mem_ctx, obj, possSuperiors_ids);
 
        GET_STRING_DS(schema, r, "defaultSecurityDescriptor", mem_ctx, obj, defaultSecurityDescriptor, false);