s4:schema_inferiors - Fix wrong check
[ira/wip.git] / source4 / dsdb / schema / schema_inferiors.c
index 28f44ab263700ec8de72a62a7c5fab2b3819aa93..3be97b6b83a1f72d2de65cca6c234e89f51bda6f 100644 (file)
@@ -42,14 +42,15 @@ static char **schema_supclasses(struct dsdb_schema *schema, struct dsdb_class *s
                return schema_class->supclasses;
        }
 
-       list = str_list_make(schema_class, NULL, NULL);
+       list = str_list_make_empty(schema_class);
        if (list == NULL) {
                DEBUG(0,(__location__ " out of memory\n"));
                return NULL;
        }
 
        /* Cope with 'top SUP top', ie top is subClassOf top */ 
-       if (strcmp(schema_class->lDAPDisplayName, schema_class->subClassOf) == 0) {
+       if (schema_class->subClassOf &&
+           strcmp(schema_class->lDAPDisplayName, schema_class->subClassOf) == 0) {
                schema_class->supclasses = list;
                return list;
        }
@@ -76,11 +77,15 @@ static char **schema_supclasses(struct dsdb_schema *schema, struct dsdb_class *s
  */
 static char **schema_subclasses(struct dsdb_schema *schema, TALLOC_CTX *mem_ctx, char **oclist)
 {
-       char **list = str_list_make(mem_ctx, NULL, NULL);
+       char **list = str_list_make_empty(mem_ctx);
        int i;
 
        for (i=0; oclist && oclist[i]; i++) {
                struct dsdb_class *schema_class = dsdb_class_by_lDAPDisplayName(schema, oclist[i]);
+               if (!schema_class) {
+                       DEBUG(0, ("ERROR: Unable to locate subClass: '%s'\n", oclist[i]));
+                       continue;
+               }
                list = str_list_append_const(list, schema_class->subclasses);
        }
        return list;
@@ -94,7 +99,7 @@ static char **schema_posssuperiors(struct dsdb_schema *schema,
                                   struct dsdb_class *schema_class)
 {
        if (schema_class->posssuperiors == NULL) {
-               char **list2 = str_list_make(schema_class, NULL, NULL);
+               char **list2 = str_list_make_empty(schema_class);
                char **list3;
                int i;
 
@@ -103,6 +108,10 @@ static char **schema_posssuperiors(struct dsdb_schema *schema,
                list3 = schema_supclasses(schema, schema_class);
                for (i=0; list3 && list3[i]; i++) {
                        struct dsdb_class *class2 = dsdb_class_by_lDAPDisplayName(schema, list3[i]);
+                       if (!class2) {
+                               DEBUG(0, ("ERROR: Unable to locate supClass: '%s'\n", list3[i]));
+                               continue;
+                       }
                        list2 = str_list_append_const(list2, schema_posssuperiors(schema, class2));
                }
                list2 = str_list_append_const(list2, schema_subclasses(schema, list2, list2));
@@ -126,15 +135,33 @@ static char **schema_subclasses_recurse(struct dsdb_schema *schema, struct dsdb_
        return list;
 }
 
+/* Walk down the subClass tree, setting a higher index as we go down
+ * each level.  top is 1, subclasses of top are 2, etc */
+void schema_subclasses_order_recurse(struct dsdb_schema *schema, struct dsdb_class *schema_class, int order)
+{
+       const char **list = schema_class->subclasses_direct;
+       int i;
+       schema_class->subClass_order = order;
+       for (i=0;list && list[i]; i++) {
+               struct dsdb_class *schema_class2 = dsdb_class_by_lDAPDisplayName(schema, list[i]);
+               schema_subclasses_order_recurse(schema, schema_class2, order+1);
+       }
+       return;
+}
+
 static void schema_create_subclasses(struct dsdb_schema *schema)
 {
        struct dsdb_class *schema_class;
 
        for (schema_class=schema->classes; schema_class; schema_class=schema_class->next) {
                struct dsdb_class *schema_class2 = dsdb_class_by_lDAPDisplayName(schema, schema_class->subClassOf);
-               if (schema_class != schema_class2) {
+               if (schema_class2 == NULL) {
+                       DEBUG(0,("ERROR: no subClassOf for '%s'\n", schema_class->lDAPDisplayName));
+                       continue;
+               }
+               if (schema_class2 && schema_class != schema_class2) {
                        if (schema_class2->subclasses_direct == NULL) {
-                               schema_class2->subclasses_direct = str_list_make(schema_class2, NULL, NULL);
+                               schema_class2->subclasses_direct = str_list_make_empty(schema_class2);
                        }
                        schema_class2->subclasses_direct = str_list_add_const(schema_class2->subclasses_direct, 
                                                                        schema_class->lDAPDisplayName);
@@ -143,7 +170,12 @@ static void schema_create_subclasses(struct dsdb_schema *schema)
 
        for (schema_class=schema->classes; schema_class; schema_class=schema_class->next) {
                schema_class->subclasses = str_list_unique(schema_subclasses_recurse(schema, schema_class));
-       }       
+
+               /* Initilise the subClass order, to ensure we can't have uninitilised sort on the subClass hirarchy */
+               schema_class->subClass_order = 0;
+       }
+
+       schema_subclasses_order_recurse(schema, dsdb_class_by_lDAPDisplayName(schema, "top"), 1);
 }
 
 static void schema_fill_possible_inferiors(struct dsdb_schema *schema, struct dsdb_class *schema_class)
@@ -157,7 +189,7 @@ static void schema_fill_possible_inferiors(struct dsdb_schema *schema, struct ds
                    && c2->objectClassCategory != 3
                    && str_list_check(superiors, schema_class->lDAPDisplayName)) {
                        if (schema_class->possibleInferiors == NULL) {
-                               schema_class->possibleInferiors = str_list_make(schema_class, NULL, NULL);
+                               schema_class->possibleInferiors = str_list_make_empty(schema_class);
                        }
                        schema_class->possibleInferiors = str_list_add_const(schema_class->possibleInferiors,
                                                                       c2->lDAPDisplayName);
@@ -166,14 +198,113 @@ static void schema_fill_possible_inferiors(struct dsdb_schema *schema, struct ds
        schema_class->possibleInferiors = str_list_unique(schema_class->possibleInferiors);
 }
 
+static void schema_fill_system_possible_inferiors(struct dsdb_schema *schema, struct dsdb_class *schema_class)
+{
+       struct dsdb_class *c2;
+
+       for (c2=schema->classes; c2; c2=c2->next) {
+               char **superiors = schema_posssuperiors(schema, c2);
+               if (c2->objectClassCategory != 2
+                   && c2->objectClassCategory != 3
+                   && str_list_check(superiors, schema_class->lDAPDisplayName)) {
+                       if (schema_class->systemPossibleInferiors == NULL) {
+                               schema_class->systemPossibleInferiors = str_list_make_empty(schema_class);
+                       }
+                       schema_class->systemPossibleInferiors = str_list_add_const(schema_class->systemPossibleInferiors,
+                                                                                  c2->lDAPDisplayName);
+               }
+       }
+       schema_class->systemPossibleInferiors = str_list_unique(schema_class->systemPossibleInferiors);
+}
+
+/*
+  fill in a string class name from a governs_ID
+ */
+static void schema_fill_from_class_one(struct dsdb_schema *schema, struct dsdb_class *c, 
+                                   const char **s, uint32_t id)
+{
+       if (*s == NULL && id != 0) {
+               struct dsdb_class *c2 = dsdb_class_by_governsID_id(schema, id);
+               if (c2) {
+                       *s = c2->lDAPDisplayName;
+               }
+       }
+}
+
+/*
+  fill in a list of string class names from a governs_ID list
+ */
+static void schema_fill_from_class_list(struct dsdb_schema *schema, struct dsdb_class *c, 
+                                    const char ***s, uint32_t *ids)
+{
+       if (*s == NULL && ids != NULL) {
+               int i;
+               for (i=0;ids[i];i++) ;
+               *s = talloc_array(c, const char *, i+1);
+               for (i=0;ids[i];i++) {
+                       struct dsdb_class *c2 = dsdb_class_by_governsID_id(schema, ids[i]);
+                       if (c2) {
+                               (*s)[i] = c2->lDAPDisplayName;
+                       } else {
+                               (*s)[i] = NULL;                         
+                       }
+               }
+               (*s)[i] = NULL;                         
+       }
+}
+
+/*
+  fill in a list of string attribute names from a attributeID list
+ */
+static void schema_fill_from_attribute_list(struct dsdb_schema *schema, struct dsdb_class *c, 
+                                           const char ***s, uint32_t *ids)
+{
+       if (*s == NULL && ids != NULL) {
+               int i;
+               for (i=0;ids[i];i++) ;
+               *s = talloc_array(c, const char *, i+1);
+               for (i=0;ids[i];i++) {
+                       struct dsdb_attribute *a = dsdb_attribute_by_attributeID_id(schema, ids[i]);
+                       if (a) {
+                               (*s)[i] = a->lDAPDisplayName;
+                       } else {
+                               (*s)[i] = NULL;                         
+                       }
+               }
+               (*s)[i] = NULL;                         
+       }
+}
+
+/*
+  if the schema came from DRS then some attributes will be setup as IDs
+ */
+static void schema_fill_from_ids(struct dsdb_schema *schema)
+{
+       struct dsdb_class *c;
+       for (c=schema->classes; c; c=c->next) {
+               schema_fill_from_class_one(schema, c, &c->subClassOf, c->subClassOf_id);
+               schema_fill_from_attribute_list(schema, c, &c->systemMayContain, c->systemMayContain_ids);
+               schema_fill_from_attribute_list(schema, c, &c->systemMustContain, c->systemMustContain_ids);
+               schema_fill_from_attribute_list(schema, c, &c->mustContain, c->mustContain_ids);
+               schema_fill_from_attribute_list(schema, c, &c->mayContain, c->mayContain_ids);
+               schema_fill_from_class_list(schema, c, &c->possSuperiors, c->possSuperiors_ids);
+               schema_fill_from_class_list(schema, c, &c->systemPossSuperiors, c->systemPossSuperiors_ids);
+               schema_fill_from_class_list(schema, c, &c->systemAuxiliaryClass, c->systemAuxiliaryClass_ids);
+               schema_fill_from_class_list(schema, c, &c->auxiliaryClass, c->auxiliaryClass_ids);
+       }
+}
+
 void schema_fill_constructed(struct dsdb_schema *schema) 
 {
        struct dsdb_class *schema_class;
 
+       schema_fill_from_ids(schema);
+
        schema_create_subclasses(schema);
 
        for (schema_class=schema->classes; schema_class; schema_class=schema_class->next) {
                schema_fill_possible_inferiors(schema, schema_class);
+               schema_fill_system_possible_inferiors(schema, schema_class);
        }
 
        /* free up our internal cache elements */