Cosmetic corrections for the DSDB module
[ira/wip.git] / source4 / dsdb / samdb / ldb_modules / repl_meta_data.c
index c91fcb2f4024df5412dd523d0a3a7ea7bc17deb5..d10c95eacb382302203840910db927a6705cc45f 100644 (file)
@@ -1,10 +1,10 @@
 /* 
    ldb database library
 
-   Copyright (C) Simo Sorce  2004-2006
+   Copyright (C) Simo Sorce  2004-2008
    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2005
    Copyright (C) Andrew Tridgell 2005
-   Copyright (C) Stefan Metzmacher 2007
+   Copyright (C) Stefan Metzmacher <metze@samba.org> 2007
 
      ** NOTE! The following LGPL license applies to the ldb
      ** library. This does NOT imply that all of Samba is released
@@ -13,7 +13,7 @@
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
    License as published by the Free Software Foundation; either
-   version 2 of the License, or (at your option) any later version.
+   version 3 of the License, or (at your option) any later version.
 
    This library is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -21,8 +21,7 @@
    Lesser General Public License for more details.
 
    You should have received a copy of the GNU Lesser General Public
-   License along with this library; if not, write to the Free Software
-   Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+   License along with this library; if not, see <http://www.gnu.org/licenses/>.
 */
 
 /*
 #include "lib/ldb/include/ldb_errors.h"
 #include "lib/ldb/include/ldb_private.h"
 #include "dsdb/samdb/samdb.h"
+#include "dsdb/common/flags.h"
 #include "librpc/gen_ndr/ndr_misc.h"
 #include "librpc/gen_ndr/ndr_drsuapi.h"
 #include "librpc/gen_ndr/ndr_drsblobs.h"
+#include "param/param.h"
 
 struct replmd_replicated_request {
        struct ldb_module *module;
-       struct ldb_handle *handle;
-       struct ldb_request *orig_req;
+       struct ldb_request *req;
+
+       const struct dsdb_schema *schema;
 
        struct dsdb_extended_replicated_objects *objs;
 
+       /* the controls we pass down */
+       struct ldb_control **controls;
+
        uint32_t index_current;
 
-       struct {
-               TALLOC_CTX *mem_ctx;
-               struct ldb_request *search_req;
-               struct ldb_message *search_msg;
-               int search_ret;
-               struct ldb_request *change_req;
-               int change_ret;
-       } sub;
+       struct ldb_message *search_msg;
 };
 
-static struct replmd_replicated_request *replmd_replicated_init_handle(struct ldb_module *module,
-                                                                      struct ldb_request *req,
-                                                                      struct dsdb_extended_replicated_objects *objs)
+static struct replmd_replicated_request *replmd_ctx_init(struct ldb_module *module,
+                                         struct ldb_request *req)
 {
-       struct replmd_replicated_request *ar;
-       struct ldb_handle *h;
+       struct replmd_replicated_request *ac;
 
-       h = talloc_zero(req, struct ldb_handle);
-       if (h == NULL) {
-               ldb_set_errstring(module->ldb, "Out of Memory");
+       ac = talloc_zero(req, struct replmd_replicated_request);
+       if (ac == NULL) {
+               ldb_oom(module->ldb);
                return NULL;
        }
 
-       h->module       = module;
-       h->state        = LDB_ASYNC_PENDING;
-       h->status       = LDB_SUCCESS;
-
-       ar = talloc_zero(h, struct replmd_replicated_request);
-       if (ar == NULL) {
-               ldb_set_errstring(module->ldb, "Out of Memory");
-               talloc_free(h);
-               return NULL;
-       }
-
-       h->private_data = ar;
-
-       ar->module      = module;
-       ar->handle      = h;
-       ar->orig_req    = req;
-       ar->objs        = objs;
-
-       req->handle = h;
-
-       return ar;
-}
-
-static struct ldb_message_element *replmd_find_attribute(const struct ldb_message *msg, const char *name)
-{
-       int i;
-
-       for (i = 0; i < msg->num_elements; i++) {
-               if (ldb_attr_cmp(name, msg->elements[i].name) == 0) {
-                       return &msg->elements[i];
-               }
-       }
-
-       return NULL;
+       ac->module = module;
+       ac->req = req;
+       return ac;
 }
 
 /*
@@ -125,16 +90,16 @@ static int add_time_element(struct ldb_message *msg, const char *attr, time_t t)
        char *s;
 
        if (ldb_msg_find_element(msg, attr) != NULL) {
-               return 0;
+               return LDB_SUCCESS;
        }
 
        s = ldb_timestring(msg, t);
        if (s == NULL) {
-               return -1;
+               return LDB_ERR_OPERATIONS_ERROR;
        }
 
        if (ldb_msg_add_string(msg, attr, s) != 0) {
-               return -1;
+               return LDB_ERR_OPERATIONS_ERROR;
        }
 
        el = ldb_msg_find_element(msg, attr);
@@ -142,7 +107,7 @@ static int add_time_element(struct ldb_message *msg, const char *attr, time_t t)
           is ignored */
        el->flags = LDB_FLAG_MOD_REPLACE;
 
-       return 0;
+       return LDB_SUCCESS;
 }
 
 /*
@@ -153,11 +118,11 @@ static int add_uint64_element(struct ldb_message *msg, const char *attr, uint64_
        struct ldb_message_element *el;
 
        if (ldb_msg_find_element(msg, attr) != NULL) {
-               return 0;
+               return LDB_SUCCESS;
        }
 
        if (ldb_msg_add_fmt(msg, attr, "%llu", (unsigned long long)v) != 0) {
-               return -1;
+               return LDB_ERR_OPERATIONS_ERROR;
        }
 
        el = ldb_msg_find_element(msg, attr);
@@ -165,250 +130,456 @@ static int add_uint64_element(struct ldb_message *msg, const char *attr, uint64_
           is ignored */
        el->flags = LDB_FLAG_MOD_REPLACE;
 
-       return 0;
+       return LDB_SUCCESS;
 }
 
-static int replmd_add_originating(struct ldb_module *module,
-                                 struct ldb_request *req,
-                                 const struct dsdb_schema *schema)
+static int replmd_replPropertyMetaData1_attid_sort(const struct replPropertyMetaData1 *m1,
+                                                  const struct replPropertyMetaData1 *m2,
+                                                  const uint32_t *rdn_attid)
 {
-       struct ldb_request *down_req;
-       struct ldb_message_element *attribute;
-       struct ldb_message *msg;
-       struct ldb_val v;
-       struct GUID guid;
-       uint64_t seq_num;
-       NTSTATUS nt_status;
-       int ret;
-       time_t t = time(NULL);
-
-       ldb_debug(module->ldb, LDB_DEBUG_TRACE, "replmd_add_originating\n");
+       if (m1->attid == m2->attid) {
+               return 0;
+       }
 
-       if ((attribute = replmd_find_attribute(req->op.add.message, "objectGUID")) != NULL ) {
-               return ldb_next_request(module, req);
+       /*
+        * the rdn attribute should be at the end!
+        * so we need to return a value greater than zero
+        * which means m1 is greater than m2
+        */
+       if (m1->attid == *rdn_attid) {
+               return 1;
        }
 
-       down_req = talloc(req, struct ldb_request);
-       if (down_req == NULL) {
-               return LDB_ERR_OPERATIONS_ERROR;
+       /*
+        * the rdn attribute should be at the end!
+        * so we need to return a value less than zero
+        * which means m2 is greater than m1
+        */
+       if (m2->attid == *rdn_attid) {
+               return -1;
        }
 
-       *down_req = *req;
+       return m1->attid - m2->attid;
+}
 
-       /* we have to copy the message as the caller might have it as a const */
-       down_req->op.add.message = msg = ldb_msg_copy_shallow(down_req, req->op.add.message);
-       if (msg == NULL) {
-               talloc_free(down_req);
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
+static void replmd_replPropertyMetaDataCtr1_sort(struct replPropertyMetaDataCtr1 *ctr1,
+                                                const uint32_t *rdn_attid)
+{
+       ldb_qsort(ctr1->array, ctr1->count, sizeof(struct replPropertyMetaData1),
+                 discard_const_p(void, rdn_attid), (ldb_qsort_cmp_fn_t)replmd_replPropertyMetaData1_attid_sort);
+}
 
-       /* a new GUID */
-       guid = GUID_random();
+static int replmd_ldb_message_element_attid_sort(const struct ldb_message_element *e1,
+                                                const struct ldb_message_element *e2,
+                                                const struct dsdb_schema *schema)
+{
+       const struct dsdb_attribute *a1;
+       const struct dsdb_attribute *a2;
 
-       nt_status = ndr_push_struct_blob(&v, msg, &guid, 
-                                        (ndr_push_flags_fn_t)ndr_push_GUID);
-       if (!NT_STATUS_IS_OK(nt_status)) {
-               talloc_free(down_req);
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
+       /* 
+        * TODO: make this faster by caching the dsdb_attribute pointer
+        *       on the ldb_messag_element
+        */
 
-       ret = ldb_msg_add_value(msg, "objectGUID", &v, NULL);
-       if (ret) {
-               talloc_free(down_req);
-               return ret;
-       }
-       
-       if (add_time_element(msg, "whenCreated", t) != 0 ||
-           add_time_element(msg, "whenChanged", t) != 0) {
-               talloc_free(down_req);
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
+       a1 = dsdb_attribute_by_lDAPDisplayName(schema, e1->name);
+       a2 = dsdb_attribute_by_lDAPDisplayName(schema, e2->name);
 
-       /* Get a sequence number from the backend */
-       ret = ldb_sequence_number(module->ldb, LDB_SEQ_NEXT, &seq_num);
-       if (ret == LDB_SUCCESS) {
-               if (add_uint64_element(msg, "uSNCreated", seq_num) != 0 ||
-                   add_uint64_element(msg, "uSNChanged", seq_num) != 0) {
-                       talloc_free(down_req);
-                       return LDB_ERR_OPERATIONS_ERROR;
-               }
+       /*
+        * TODO: remove this check, we should rely on e1 and e2 having valid attribute names
+        *       in the schema
+        */
+       if (!a1 || !a2) {
+               return strcasecmp(e1->name, e2->name);
        }
 
-       ldb_set_timeout_from_prev_req(module->ldb, req, down_req);
+       return a1->attributeID_id - a2->attributeID_id;
+}
 
-       /* go on with the call chain */
-       ret = ldb_next_request(module, down_req);
+static void replmd_ldb_message_sort(struct ldb_message *msg,
+                                   const struct dsdb_schema *schema)
+{
+       ldb_qsort(msg->elements, msg->num_elements, sizeof(struct ldb_message_element),
+                 discard_const_p(void, schema), (ldb_qsort_cmp_fn_t)replmd_ldb_message_element_attid_sort);
+}
 
-       /* do not free down_req as the call results may be linked to it,
-        * it will be freed when the upper level request get freed */
-       if (ret == LDB_SUCCESS) {
-               req->handle = down_req->handle;
+static int replmd_op_callback(struct ldb_request *req, struct ldb_reply *ares)
+{
+       struct replmd_replicated_request *ac;
+
+       ac = talloc_get_type(req->context, struct replmd_replicated_request);
+
+       if (!ares) {
+               return ldb_module_done(ac->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+       if (ares->error != LDB_SUCCESS) {
+               return ldb_module_done(ac->req, ares->controls,
+                                       ares->response, ares->error);
        }
 
-       return ret;
+       if (ares->type != LDB_REPLY_DONE) {
+               ldb_set_errstring(ac->module->ldb,
+                                 "invalid ldb_reply_type in callback");
+               talloc_free(ares);
+               return ldb_module_done(ac->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+
+       return ldb_module_done(ac->req, ares->controls,
+                               ares->response, LDB_SUCCESS);
 }
 
 static int replmd_add(struct ldb_module *module, struct ldb_request *req)
 {
+       struct replmd_replicated_request *ac;
        const struct dsdb_schema *schema;
+       enum ndr_err_code ndr_err;
+       struct ldb_request *down_req;
+       struct ldb_message *msg;
+       const struct dsdb_attribute *rdn_attr = NULL;
+       struct GUID guid;
+       struct ldb_val guid_value;
+       struct replPropertyMetaDataBlob nmd;
+       struct ldb_val nmd_value;
+       uint64_t seq_num;
+       const struct GUID *our_invocation_id;
+       time_t t = time(NULL);
+       NTTIME now;
+       char *time_str;
+       int ret;
+       uint32_t i, ni=0;
 
        /* do not manipulate our control entries */
        if (ldb_dn_is_special(req->op.add.message->dn)) {
                return ldb_next_request(module, req);
        }
 
+       ldb_debug(module->ldb, LDB_DEBUG_TRACE, "replmd_add\n");
+
        schema = dsdb_get_schema(module->ldb);
        if (!schema) {
-               ldb_debug_set(module->ldb, LDB_DEBUG_FATAL, "replmd_add: no dsdb_schema loaded");
+               ldb_debug_set(module->ldb, LDB_DEBUG_FATAL,
+                             "replmd_modify: no dsdb_schema loaded");
                return LDB_ERR_CONSTRAINT_VIOLATION;
        }
 
-       return replmd_add_originating(module, req, schema);
-}
+       ac = replmd_ctx_init(module, req);
+       if (!ac) {
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
 
-static int replmd_modify_originating(struct ldb_module *module,
-                                    struct ldb_request *req,
-                                    const struct dsdb_schema *schema)
-{
-       struct ldb_request *down_req;
-       struct ldb_message *msg;
-       int ret;
-       time_t t = time(NULL);
-       uint64_t seq_num;
+       ac->schema = schema;
 
-       ldb_debug(module->ldb, LDB_DEBUG_TRACE, "replmd_modify_originating\n");
+       if (ldb_msg_find_element(req->op.add.message, "objectGUID")) {
+               ldb_debug_set(module->ldb, LDB_DEBUG_ERROR,
+                             "replmd_add: it's not allowed to add an object with objectGUID\n");
+               return LDB_ERR_UNWILLING_TO_PERFORM;
+       }
 
-       down_req = talloc(req, struct ldb_request);
-       if (down_req == NULL) {
-               return LDB_ERR_OPERATIONS_ERROR;
+       /* Get a sequence number from the backend */
+       ret = ldb_sequence_number(module->ldb, LDB_SEQ_NEXT, &seq_num);
+       if (ret != LDB_SUCCESS) {
+               return ret;
        }
 
-       *down_req = *req;
+       /* a new GUID */
+       guid = GUID_random();
+
+       /* get our invicationId */
+       our_invocation_id = samdb_ntds_invocation_id(module->ldb);
+       if (!our_invocation_id) {
+               ldb_debug_set(module->ldb, LDB_DEBUG_ERROR,
+                             "replmd_add: unable to find invocationId\n");
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
 
        /* we have to copy the message as the caller might have it as a const */
-       down_req->op.mod.message = msg = ldb_msg_copy_shallow(down_req, req->op.mod.message);
+       msg = ldb_msg_copy_shallow(ac, req->op.add.message);
        if (msg == NULL) {
-               talloc_free(down_req);
+               ldb_oom(module->ldb);
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       if (add_time_element(msg, "whenChanged", t) != 0) {
-               talloc_free(down_req);
+       /* generated times */
+       unix_to_nt_time(&now, t);
+       time_str = ldb_timestring(msg, t);
+       if (!time_str) {
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       /* Get a sequence number from the backend */
-       ret = ldb_sequence_number(module->ldb, LDB_SEQ_NEXT, &seq_num);
-       if (ret == LDB_SUCCESS) {
-               if (add_uint64_element(msg, "uSNChanged", seq_num) != 0) {
-                       talloc_free(down_req);
-                       return LDB_ERR_OPERATIONS_ERROR;
+       /* 
+        * remove autogenerated attributes
+        */
+       ldb_msg_remove_attr(msg, "whenCreated");
+       ldb_msg_remove_attr(msg, "whenChanged");
+       ldb_msg_remove_attr(msg, "uSNCreated");
+       ldb_msg_remove_attr(msg, "uSNChanged");
+       ldb_msg_remove_attr(msg, "replPropertyMetaData");
+
+       /*
+        * readd replicated attributes
+        */
+       ret = ldb_msg_add_string(msg, "whenCreated", time_str);
+       if (ret != LDB_SUCCESS) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       /* build the replication meta_data */
+       ZERO_STRUCT(nmd);
+       nmd.version             = 1;
+       nmd.ctr.ctr1.count      = msg->num_elements;
+       nmd.ctr.ctr1.array      = talloc_array(msg,
+                                              struct replPropertyMetaData1,
+                                              nmd.ctr.ctr1.count);
+       if (!nmd.ctr.ctr1.array) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       for (i=0; i < msg->num_elements; i++) {
+               struct ldb_message_element *e = &msg->elements[i];
+               struct replPropertyMetaData1 *m = &nmd.ctr.ctr1.array[ni];
+               const struct dsdb_attribute *sa;
+
+               if (e->name[0] == '@') continue;
+
+               sa = dsdb_attribute_by_lDAPDisplayName(schema, e->name);
+               if (!sa) {
+                       ldb_debug_set(module->ldb, LDB_DEBUG_ERROR,
+                                     "replmd_add: attribute '%s' not defined in schema\n",
+                                     e->name);
+                       return LDB_ERR_NO_SUCH_ATTRIBUTE;
+               }
+
+               if ((sa->systemFlags & 0x00000001) || (sa->systemFlags & 0x00000004)) {
+                       /* if the attribute is not replicated (0x00000001)
+                        * or constructed (0x00000004) it has no metadata
+                        */
+                       continue;
+               }
+
+               m->attid                        = sa->attributeID_id;
+               m->version                      = 1;
+               m->originating_change_time      = now;
+               m->originating_invocation_id    = *our_invocation_id;
+               m->originating_usn              = seq_num;
+               m->local_usn                    = seq_num;
+               ni++;
+
+               if (ldb_attr_cmp(e->name, ldb_dn_get_rdn_name(msg->dn))) {
+                       rdn_attr = sa;
                }
        }
 
-       ldb_set_timeout_from_prev_req(module->ldb, req, down_req);
+       /* fix meta data count */
+       nmd.ctr.ctr1.count = ni;
 
-       /* go on with the call chain */
-       ret = ldb_next_request(module, down_req);
+       /*
+        * sort meta data array, and move the rdn attribute entry to the end
+        */
+       replmd_replPropertyMetaDataCtr1_sort(&nmd.ctr.ctr1, &rdn_attr->attributeID_id);
+
+       /* generated NDR encoded values */
+       ndr_err = ndr_push_struct_blob(&guid_value, msg, 
+                                      NULL,
+                                      &guid,
+                                      (ndr_push_flags_fn_t)ndr_push_GUID);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       ndr_err = ndr_push_struct_blob(&nmd_value, msg, 
+                                      lp_iconv_convenience(ldb_get_opaque(module->ldb, "loadparm")),
+                                      &nmd,
+                                      (ndr_push_flags_fn_t)ndr_push_replPropertyMetaDataBlob);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
 
-       /* do not free down_req as the call results may be linked to it,
-        * it will be freed when the upper level request get freed */
-       if (ret == LDB_SUCCESS) {
-               req->handle = down_req->handle;
+       /*
+        * add the autogenerated values
+        */
+       ret = ldb_msg_add_value(msg, "objectGUID", &guid_value, NULL);
+       if (ret != LDB_SUCCESS) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       ret = ldb_msg_add_string(msg, "whenChanged", time_str);
+       if (ret != LDB_SUCCESS) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       ret = samdb_msg_add_uint64(module->ldb, msg, msg, "uSNCreated", seq_num);
+       if (ret != LDB_SUCCESS) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       ret = samdb_msg_add_uint64(module->ldb, msg, msg, "uSNChanged", seq_num);
+       if (ret != LDB_SUCCESS) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       ret = ldb_msg_add_value(msg, "replPropertyMetaData", &nmd_value, NULL);
+       if (ret != LDB_SUCCESS) {
+               ldb_oom(module->ldb);
+               return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       return ret;
+       /*
+        * sort the attributes by attid before storing the object
+        */
+       replmd_ldb_message_sort(msg, schema);
+
+       ret = ldb_build_add_req(&down_req, module->ldb, ac,
+                               msg,
+                               req->controls,
+                               ac, replmd_op_callback,
+                               req);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+
+       /* go on with the call chain */
+       return ldb_next_request(module, down_req);
 }
 
 static int replmd_modify(struct ldb_module *module, struct ldb_request *req)
 {
+       struct replmd_replicated_request *ac;
        const struct dsdb_schema *schema;
+       struct ldb_request *down_req;
+       struct ldb_message *msg;
+       int ret;
+       time_t t = time(NULL);
+       uint64_t seq_num;
+
        /* do not manipulate our control entries */
        if (ldb_dn_is_special(req->op.mod.message->dn)) {
                return ldb_next_request(module, req);
        }
 
+       ldb_debug(module->ldb, LDB_DEBUG_TRACE, "replmd_modify\n");
+
        schema = dsdb_get_schema(module->ldb);
        if (!schema) {
-               ldb_debug_set(module->ldb, LDB_DEBUG_FATAL, "replmd_modify: no dsdb_schema loaded");
+               ldb_debug_set(module->ldb, LDB_DEBUG_FATAL,
+                             "replmd_modify: no dsdb_schema loaded");
                return LDB_ERR_CONSTRAINT_VIOLATION;
        }
 
-       return replmd_modify_originating(module, req, schema);
-}
-
-static int replmd_replicated_request_reply_helper(struct replmd_replicated_request *ar, int ret)
-{
-       struct ldb_reply *ares = NULL;
+       ac = replmd_ctx_init(module, req);
+       if (!ac) {
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
 
-       ar->handle->status = ret;
-       ar->handle->state = LDB_ASYNC_DONE;
+       ac->schema = schema;
 
-       if (!ar->orig_req->callback) {
-               return LDB_SUCCESS;
+       /* we have to copy the message as the caller might have it as a const */
+       msg = ldb_msg_copy_shallow(ac, req->op.mod.message);
+       if (msg == NULL) {
+               talloc_free(ac);
+               return LDB_ERR_OPERATIONS_ERROR;
        }
-       
-       /* we're done and need to report the success to the caller */
-       ares = talloc_zero(ar, struct ldb_reply);
-       if (!ares) {
-               ar->handle->status = LDB_ERR_OPERATIONS_ERROR;
-               ar->handle->state = LDB_ASYNC_DONE;
+
+       /* TODO:
+        * - get the whole old object
+        * - if the old object doesn't exist report an error
+        * - give an error when a readonly attribute should
+        *   be modified
+        * - merge the changed into the old object
+        *   if the caller set values to the same value
+        *   ignore the attribute, return success when no
+        *   attribute was changed
+        * - calculate the new replPropertyMetaData attribute
+        */
+
+       if (add_time_element(msg, "whenChanged", t) != 0) {
+               talloc_free(ac);
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       ares->type      = LDB_REPLY_EXTENDED;
-       ares->response  = NULL;
+       /* Get a sequence number from the backend */
+       ret = ldb_sequence_number(module->ldb, LDB_SEQ_NEXT, &seq_num);
+       if (ret == LDB_SUCCESS) {
+               if (add_uint64_element(msg, "uSNChanged", seq_num) != 0) {
+                       talloc_free(ac);
+                       return LDB_ERR_OPERATIONS_ERROR;
+               }
+       }
+
+       /* TODO:
+        * - sort the attributes by attid with replmd_ldb_message_sort()
+        * - replace the old object with the newly constructed one
+        */
 
-       return ar->orig_req->callback(ar->module->ldb, ar->orig_req->context, ares);
-}
+       ret = ldb_build_mod_req(&down_req, module->ldb, ac,
+                               msg,
+                               req->controls,
+                               ac, replmd_op_callback,
+                               req);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+       talloc_steal(down_req, msg);
 
-static int replmd_replicated_request_done(struct replmd_replicated_request *ar)
-{
-       return replmd_replicated_request_reply_helper(ar, LDB_SUCCESS);
+       /* go on with the call chain */
+       return ldb_next_request(module, down_req);
 }
 
 static int replmd_replicated_request_error(struct replmd_replicated_request *ar, int ret)
 {
-       return replmd_replicated_request_reply_helper(ar, ret);
+       return ret;
 }
 
 static int replmd_replicated_request_werror(struct replmd_replicated_request *ar, WERROR status)
 {
        int ret = LDB_ERR_OTHER;
        /* TODO: do some error mapping */
-       return replmd_replicated_request_reply_helper(ar, ret);
+       return ret;
 }
 
 static int replmd_replicated_apply_next(struct replmd_replicated_request *ar);
 
-static int replmd_replicated_apply_add_callback(struct ldb_context *ldb,
-                                               void *private_data,
+static int replmd_replicated_apply_add_callback(struct ldb_request *req,
                                                struct ldb_reply *ares)
 {
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       struct replmd_replicated_request *ar = talloc_get_type(private_data,
+       struct replmd_replicated_request *ar = talloc_get_type(req->context,
                                               struct replmd_replicated_request);
+       int ret;
 
-       ar->sub.change_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.change_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.change_ret);
+
+       if (!ares) {
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+       if (ares->error != LDB_SUCCESS) {
+               return ldb_module_done(ar->req, ares->controls,
+                                       ares->response, ares->error);
        }
 
-       talloc_free(ar->sub.mem_ctx);
-       ZERO_STRUCT(ar->sub);
+       if (ares->type != LDB_REPLY_DONE) {
+               ldb_set_errstring(ar->module->ldb, "Invalid reply type\n!");
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
 
+       talloc_free(ares);
        ar->index_current++;
 
-       return replmd_replicated_apply_next(ar);
-#else
+       ret = replmd_replicated_apply_next(ar);
+       if (ret != LDB_SUCCESS) {
+               return ldb_module_done(ar->req, NULL, NULL, ret);
+       }
+
        return LDB_SUCCESS;
-#endif
 }
 
 static int replmd_replicated_apply_add(struct replmd_replicated_request *ar)
 {
-       NTSTATUS nt_status;
+       struct ldb_request *change_req;
+       enum ndr_err_code ndr_err;
        struct ldb_message *msg;
        struct replPropertyMetaDataBlob *md;
        struct ldb_val md_value;
@@ -453,13 +624,18 @@ static int replmd_replicated_apply_add(struct replmd_replicated_request *ar)
                return replmd_replicated_request_error(ar, ret);
        }
 
-       md = ar->objs->objects[ar->index_current].meta_data;
+       /*
+        * the meta data array is already sorted by the caller
+        */
        for (i=0; i < md->ctr.ctr1.count; i++) {
                md->ctr.ctr1.array[i].local_usn = seq_num;
        }
-       nt_status = ndr_push_struct_blob(&md_value, msg, md,
-                                        (ndr_push_flags_fn_t)ndr_push_replPropertyMetaDataBlob);
-       if (!NT_STATUS_IS_OK(nt_status)) {
+       ndr_err = ndr_push_struct_blob(&md_value, msg, 
+                                      lp_iconv_convenience(ldb_get_opaque(ar->module->ldb, "loadparm")),
+                                      md,
+                                      (ndr_push_flags_fn_t)ndr_push_replPropertyMetaDataBlob);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
                return replmd_replicated_request_werror(ar, ntstatus_to_werror(nt_status));
        }
        ret = ldb_msg_add_value(msg, "replPropertyMetaData", &md_value, NULL);
@@ -467,39 +643,19 @@ static int replmd_replicated_apply_add(struct replmd_replicated_request *ar)
                return replmd_replicated_request_error(ar, ret);
        }
 
-       ret = ldb_build_add_req(&ar->sub.change_req,
+       replmd_ldb_message_sort(msg, ar->schema);
+
+       ret = ldb_build_add_req(&change_req,
                                ar->module->ldb,
-                               ar->sub.mem_ctx,
+                               ar,
                                msg,
-                               NULL,
+                               ar->controls,
                                ar,
-                               replmd_replicated_apply_add_callback);
-       if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
-
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       return ldb_next_request(ar->module, ar->sub.change_req);
-#else
-       ret = ldb_next_request(ar->module, ar->sub.change_req);
+                               replmd_replicated_apply_add_callback,
+                               ar->req);
        if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
 
-       ar->sub.change_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.change_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.change_ret);
-       }
-
-       talloc_free(ar->sub.mem_ctx);
-       ZERO_STRUCT(ar->sub);
-
-       ar->index_current++;
-
-       return LDB_SUCCESS;
-#endif
-}
-
-static int replmd_replPropertyMetaData1_attid_compare(struct replPropertyMetaData1 *m1,
-                                                     struct replPropertyMetaData1 *m2)
-{
-       return m1->attid - m2->attid;
+       return ldb_next_request(ar->module, change_req);
 }
 
 static int replmd_replPropertyMetaData1_conflict_compare(struct replPropertyMetaData1 *m1,
@@ -511,48 +667,55 @@ static int replmd_replPropertyMetaData1_conflict_compare(struct replPropertyMeta
                return m1->version - m2->version;
        }
 
-       if (m1->orginating_time != m2->orginating_time) {
-               return m1->orginating_time - m2->orginating_time;
+       if (m1->originating_change_time != m2->originating_change_time) {
+               return m1->originating_change_time - m2->originating_change_time;
        }
 
-       ret = GUID_compare(&m1->orginating_invocation_id, &m2->orginating_invocation_id);
+       ret = GUID_compare(&m1->originating_invocation_id, &m2->originating_invocation_id);
        if (ret != 0) {
                return ret;
        }
 
-       return m1->orginating_usn - m2->orginating_usn;
+       return m1->originating_usn - m2->originating_usn;
 }
 
-static int replmd_replicated_apply_merge_callback(struct ldb_context *ldb,
-                                                 void *private_data,
+static int replmd_replicated_apply_merge_callback(struct ldb_request *req,
                                                  struct ldb_reply *ares)
 {
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       struct replmd_replicated_request *ar = talloc_get_type(private_data,
+       struct replmd_replicated_request *ar = talloc_get_type(req->context,
                                               struct replmd_replicated_request);
+       int ret;
 
-       ret = ldb_next_request(ar->module, ar->sub.change_req);
-       if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
-
-       ar->sub.change_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.change_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.change_ret);
+       if (!ares) {
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+       if (ares->error != LDB_SUCCESS) {
+               return ldb_module_done(ar->req, ares->controls,
+                                       ares->response, ares->error);
        }
 
-       talloc_free(ar->sub.mem_ctx);
-       ZERO_STRUCT(ar->sub);
+       if (ares->type != LDB_REPLY_DONE) {
+               ldb_set_errstring(ar->module->ldb, "Invalid reply type\n!");
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
 
+       talloc_free(ares);
        ar->index_current++;
 
+       ret = replmd_replicated_apply_next(ar);
+       if (ret != LDB_SUCCESS) {
+               return ldb_module_done(ar->req, NULL, NULL, ret);
+       }
+
        return LDB_SUCCESS;
-#else
-       return LDB_SUCCESS;
-#endif
 }
 
 static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
 {
-       NTSTATUS nt_status;
+       struct ldb_request *change_req;
+       enum ndr_err_code ndr_err;
        struct ldb_message *msg;
        struct replPropertyMetaDataBlob *rmd;
        struct replPropertyMetaDataBlob omd;
@@ -572,11 +735,11 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
        /*
         * TODO: add rename conflict handling
         */
-       if (ldb_dn_compare(msg->dn, ar->sub.search_msg->dn) != 0) {
+       if (ldb_dn_compare(msg->dn, ar->search_msg->dn) != 0) {
                ldb_debug_set(ar->module->ldb, LDB_DEBUG_FATAL, "replmd_replicated_apply_merge[%u]: rename not supported",
                              ar->index_current);
                ldb_debug(ar->module->ldb, LDB_DEBUG_FATAL, "%s => %s\n",
-                         ldb_dn_get_linearized(ar->sub.search_msg->dn),
+                         ldb_dn_get_linearized(ar->search_msg->dn),
                          ldb_dn_get_linearized(msg->dn));
                return replmd_replicated_request_werror(ar, WERR_NOT_SUPPORTED);
        }
@@ -587,11 +750,13 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
        }
 
        /* find existing meta data */
-       omd_value = ldb_msg_find_ldb_val(ar->sub.search_msg, "replPropertyMetaData");
+       omd_value = ldb_msg_find_ldb_val(ar->search_msg, "replPropertyMetaData");
        if (omd_value) {
-               nt_status = ndr_pull_struct_blob(omd_value, ar->sub.mem_ctx, &omd,
-                                                (ndr_pull_flags_fn_t)ndr_pull_replPropertyMetaDataBlob);
-               if (!NT_STATUS_IS_OK(nt_status)) {
+               ndr_err = ndr_pull_struct_blob(omd_value, ar,
+                                              lp_iconv_convenience(ldb_get_opaque(ar->module->ldb, "loadparm")), &omd,
+                                              (ndr_pull_flags_fn_t)ndr_pull_replPropertyMetaDataBlob);
+               if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                       NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
                        return replmd_replicated_request_werror(ar, ntstatus_to_werror(nt_status));
                }
 
@@ -603,7 +768,7 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
        ZERO_STRUCT(nmd);
        nmd.version = 1;
        nmd.ctr.ctr1.count = omd.ctr.ctr1.count + rmd->ctr.ctr1.count;
-       nmd.ctr.ctr1.array = talloc_array(ar->sub.mem_ctx,
+       nmd.ctr.ctr1.array = talloc_array(ar,
                                          struct replPropertyMetaData1,
                                          nmd.ctr.ctr1.count);
        if (!nmd.ctr.ctr1.array) return replmd_replicated_request_werror(ar, WERR_NOMEM);
@@ -660,35 +825,23 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
         * 'cn' for most objects is the last entry in the meta data array
         * we have stored
         *
-        * as it should stay the last one in the new list, we move it to the end
+        * sort the new meta data array
         */
        {
-               struct replPropertyMetaData1 *rdn_p, rdn, *last_p;
+               struct replPropertyMetaData1 *rdn_p;
                uint32_t rdn_idx = omd.ctr.ctr1.count - 1;
-               uint32_t last_idx = ni - 1;
 
                rdn_p = &nmd.ctr.ctr1.array[rdn_idx];
-               rdn = *rdn_p;
-               last_p = &nmd.ctr.ctr1.array[last_idx];
-
-               if (last_idx > rdn_idx) {
-                       memmove(rdn_p, rdn_p+1, (last_idx - rdn_idx)*sizeof(rdn));
-                       *last_p = rdn;
-               }
+               replmd_replPropertyMetaDataCtr1_sort(&nmd.ctr.ctr1, &rdn_p->attid);
        }
 
-       /*
-        * sort the meta data entries by attid, but skip the last one containing
-        * the rdn attribute
-        */
-       qsort(nmd.ctr.ctr1.array, nmd.ctr.ctr1.count - 1,
-             sizeof(struct replPropertyMetaData1),
-             (comparison_fn_t)replmd_replPropertyMetaData1_attid_compare);
-
        /* create the meta data value */
-       nt_status = ndr_push_struct_blob(&nmd_value, msg, &nmd,
-                                        (ndr_push_flags_fn_t)ndr_push_replPropertyMetaDataBlob);
-       if (!NT_STATUS_IS_OK(nt_status)) {
+       ndr_err = ndr_push_struct_blob(&nmd_value, msg, 
+                                      lp_iconv_convenience(ldb_get_opaque(ar->module->ldb, "loadparm")),
+                                      &nmd,
+                                      (ndr_push_flags_fn_t)ndr_push_replPropertyMetaDataBlob);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
                return replmd_replicated_request_werror(ar, ntstatus_to_werror(nt_status));
        }
 
@@ -698,14 +851,16 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
        if (msg->num_elements == 0) {
                ldb_debug(ar->module->ldb, LDB_DEBUG_TRACE, "replmd_replicated_apply_merge[%u]: skip replace\n",
                          ar->index_current);
-               goto next_object;
+
+               ar->index_current++;
+               return replmd_replicated_apply_next(ar);
        }
 
        ldb_debug(ar->module->ldb, LDB_DEBUG_TRACE, "replmd_replicated_apply_merge[%u]: replace %u attributes\n",
                  ar->index_current, msg->num_elements);
 
        /*
-        * when we now that we'll modify the record, add the whenChanged, uSNChanged
+        * when we know that we'll modify the record, add the whenChanged, uSNChanged
         * and replPopertyMetaData attributes
         */
        ret = ldb_msg_add_string(msg, "whenChanged", ar->objs->objects[ar->index_current].when_changed);
@@ -721,155 +876,130 @@ static int replmd_replicated_apply_merge(struct replmd_replicated_request *ar)
                return replmd_replicated_request_error(ar, ret);
        }
 
+       replmd_ldb_message_sort(msg, ar->schema);
+
        /* we want to replace the old values */
        for (i=0; i < msg->num_elements; i++) {
                msg->elements[i].flags = LDB_FLAG_MOD_REPLACE;
        }
 
-       ret = ldb_build_mod_req(&ar->sub.change_req,
+       ret = ldb_build_mod_req(&change_req,
                                ar->module->ldb,
-                               ar->sub.mem_ctx,
+                               ar,
                                msg,
-                               NULL,
+                               ar->controls,
                                ar,
-                               replmd_replicated_apply_merge_callback);
+                               replmd_replicated_apply_merge_callback,
+                               ar->req);
        if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
 
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       return ldb_next_request(ar->module, ar->sub.change_req);
-#else
-       ret = ldb_next_request(ar->module, ar->sub.change_req);
-       if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
-
-       ar->sub.change_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.change_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.change_ret);
-       }
-
-next_object:
-       talloc_free(ar->sub.mem_ctx);
-       ZERO_STRUCT(ar->sub);
-
-       ar->index_current++;
-
-       return LDB_SUCCESS;
-#endif
+       return ldb_next_request(ar->module, change_req);
 }
 
-static int replmd_replicated_apply_search_callback(struct ldb_context *ldb,
-                                                  void *private_data,
+static int replmd_replicated_apply_search_callback(struct ldb_request *req,
                                                   struct ldb_reply *ares)
 {
-       struct replmd_replicated_request *ar = talloc_get_type(private_data,
+       struct replmd_replicated_request *ar = talloc_get_type(req->context,
                                               struct replmd_replicated_request);
-       bool is_done = false;
+       int ret;
+
+       if (!ares) {
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+       if (ares->error != LDB_SUCCESS &&
+           ares->error != LDB_ERR_NO_SUCH_OBJECT) {
+               return ldb_module_done(ar->req, ares->controls,
+                                       ares->response, ares->error);
+       }
 
        switch (ares->type) {
        case LDB_REPLY_ENTRY:
-               ar->sub.search_msg = talloc_steal(ar->sub.mem_ctx, ares->message);
+               ar->search_msg = talloc_steal(ar, ares->message);
                break;
+
        case LDB_REPLY_REFERRAL:
                /* we ignore referrals */
                break;
-       case LDB_REPLY_EXTENDED:
-       case LDB_REPLY_DONE:
-               is_done = true;
-       }
-
-       talloc_free(ares);
 
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       if (is_done) {
-               ar->sub.search_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-               if (ar->sub.search_ret != LDB_SUCCESS) {
-                       return replmd_replicated_request_error(ar, ar->sub.search_ret);
+       case LDB_REPLY_DONE:
+               if (ar->search_msg != NULL) {
+                       ret = replmd_replicated_apply_merge(ar);
+               } else {
+                       ret = replmd_replicated_apply_add(ar);
                }
-               if (ar->sub.search_msg) {
-                       return replmd_replicated_apply_merge(ar);
+               if (ret != LDB_SUCCESS) {
+                       return ldb_module_done(ar->req, NULL, NULL, ret);
                }
-               return replmd_replicated_apply_add(ar);
        }
-#endif
+
+       talloc_free(ares);
        return LDB_SUCCESS;
 }
 
-static int replmd_replicated_apply_search(struct replmd_replicated_request *ar)
+static int replmd_replicated_uptodate_vector(struct replmd_replicated_request *ar);
+
+static int replmd_replicated_apply_next(struct replmd_replicated_request *ar)
 {
        int ret;
        char *tmp_str;
        char *filter;
+       struct ldb_request *search_req;
 
-       tmp_str = ldb_binary_encode(ar->sub.mem_ctx, ar->objs->objects[ar->index_current].guid_value);
+       if (ar->index_current >= ar->objs->num_objects) {
+               /* done with it, go to the last op */
+               return replmd_replicated_uptodate_vector(ar);
+       }
+
+       ar->search_msg = NULL;
+
+       tmp_str = ldb_binary_encode(ar, ar->objs->objects[ar->index_current].guid_value);
        if (!tmp_str) return replmd_replicated_request_werror(ar, WERR_NOMEM);
 
-       filter = talloc_asprintf(ar->sub.mem_ctx, "(objectGUID=%s)", tmp_str);
+       filter = talloc_asprintf(ar, "(objectGUID=%s)", tmp_str);
        if (!filter) return replmd_replicated_request_werror(ar, WERR_NOMEM);
        talloc_free(tmp_str);
 
-       ret = ldb_build_search_req(&ar->sub.search_req,
+       ret = ldb_build_search_req(&search_req,
                                   ar->module->ldb,
-                                  ar->sub.mem_ctx,
+                                  ar,
                                   ar->objs->partition_dn,
                                   LDB_SCOPE_SUBTREE,
                                   filter,
                                   NULL,
                                   NULL,
                                   ar,
-                                  replmd_replicated_apply_search_callback);
+                                  replmd_replicated_apply_search_callback,
+                                  ar->req);
        if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
 
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       return ldb_next_request(ar->module, ar->sub.search_req);
-#else
-       ret = ldb_next_request(ar->module, ar->sub.search_req);
-       if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
-
-       ar->sub.search_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.search_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.search_ret);
-       }
-       if (ar->sub.search_msg) {
-               return replmd_replicated_apply_merge(ar);
-       }
-
-       return replmd_replicated_apply_add(ar);
-#endif
+       return ldb_next_request(ar->module, search_req);
 }
 
-static int replmd_replicated_apply_next(struct replmd_replicated_request *ar)
-{
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       if (ar->index_current >= ar->objs->num_objects) {
-               return replmd_replicated_uptodate_vector(ar);
-       }
-#endif
-
-       ar->sub.mem_ctx = talloc_new(ar);
-       if (!ar->sub.mem_ctx) return replmd_replicated_request_werror(ar, WERR_NOMEM);
-
-       return replmd_replicated_apply_search(ar);
-}
-
-static int replmd_replicated_uptodate_modify_callback(struct ldb_context *ldb,
-                                                     void *private_data,
+static int replmd_replicated_uptodate_modify_callback(struct ldb_request *req,
                                                      struct ldb_reply *ares)
 {
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       struct replmd_replicated_request *ar = talloc_get_type(private_data,
+       struct replmd_replicated_request *ar = talloc_get_type(req->context,
                                               struct replmd_replicated_request);
 
-       ar->sub.change_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.change_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.change_ret);
+       if (!ares) {
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+       if (ares->error != LDB_SUCCESS) {
+               return ldb_module_done(ar->req, ares->controls,
+                                       ares->response, ares->error);
+       }
+
+       if (ares->type != LDB_REPLY_DONE) {
+               ldb_set_errstring(ar->module->ldb, "Invalid reply type\n!");
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
        }
 
-       talloc_free(ar->sub.mem_ctx);
-       ZERO_STRUCT(ar->sub);
+       talloc_free(ares);
 
-       return replmd_replicated_request_done(ar);
-#else
-       return LDB_SUCCESS;
-#endif
+       return ldb_module_done(ar->req, NULL, NULL, LDB_SUCCESS);
 }
 
 static int replmd_drsuapi_DsReplicaCursor2_compare(const struct drsuapi_DsReplicaCursor2 *c1,
@@ -880,7 +1010,8 @@ static int replmd_drsuapi_DsReplicaCursor2_compare(const struct drsuapi_DsReplic
 
 static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *ar)
 {
-       NTSTATUS nt_status;
+       struct ldb_request *change_req;
+       enum ndr_err_code ndr_err;
        struct ldb_message *msg;
        struct replUpToDateVectorBlob ouv;
        const struct ldb_val *ouv_value;
@@ -921,11 +1052,13 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
        /*
         * first create the new replUpToDateVector
         */
-       ouv_value = ldb_msg_find_ldb_val(ar->sub.search_msg, "replUpToDateVector");
+       ouv_value = ldb_msg_find_ldb_val(ar->search_msg, "replUpToDateVector");
        if (ouv_value) {
-               nt_status = ndr_pull_struct_blob(ouv_value, ar->sub.mem_ctx, &ouv,
-                                                (ndr_pull_flags_fn_t)ndr_pull_replUpToDateVectorBlob);
-               if (!NT_STATUS_IS_OK(nt_status)) {
+               ndr_err = ndr_pull_struct_blob(ouv_value, ar,
+                                              lp_iconv_convenience(ldb_get_opaque(ar->module->ldb, "loadparm")), &ouv,
+                                              (ndr_pull_flags_fn_t)ndr_pull_replUpToDateVectorBlob);
+               if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                       NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
                        return replmd_replicated_request_werror(ar, ntstatus_to_werror(nt_status));
                }
 
@@ -936,13 +1069,13 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
 
        /*
         * the new uptodateness vector will at least
-        * contain 2 entries, one for the source_dsa and one the local server
+        * contain 1 entry, one for the source_dsa
         *
         * plus optional values from our old vector and the one from the source_dsa
         */
-       nuv.ctr.ctr2.count = 2 + ouv.ctr.ctr2.count;
+       nuv.ctr.ctr2.count = 1 + ouv.ctr.ctr2.count;
        if (ruv) nuv.ctr.ctr2.count += ruv->count;
-       nuv.ctr.ctr2.cursors = talloc_array(ar->sub.mem_ctx,
+       nuv.ctr.ctr2.cursors = talloc_array(ar,
                                            struct drsuapi_DsReplicaCursor2,
                                            nuv.ctr.ctr2.count);
        if (!nuv.ctr.ctr2.cursors) return replmd_replicated_request_werror(ar, WERR_NOMEM);
@@ -953,10 +1086,19 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
                ni++;
        }
 
+       /* get our invocation_id if we have one already attached to the ldb */
+       our_invocation_id = samdb_ntds_invocation_id(ar->module->ldb);
+
        /* merge in the source_dsa vector is available */
        for (i=0; (ruv && i < ruv->count); i++) {
                found = false;
 
+               if (our_invocation_id &&
+                   GUID_equal(&ruv->cursors[i].source_dsa_invocation_id,
+                              our_invocation_id)) {
+                       continue;
+               }
+
                for (j=0; j < ni; j++) {
                        if (!GUID_equal(&ruv->cursors[i].source_dsa_invocation_id,
                                        &nuv.ctr.ctr2.cursors[j].source_dsa_invocation_id)) {
@@ -1019,41 +1161,6 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
                ni++;
        }
 
-       /*
-        * merge our own current values if we have a invocation_id already
-        * attached to the ldb
-        */
-       our_invocation_id = samdb_ntds_invocation_id(ar->module->ldb);
-       if (our_invocation_id) {
-               found = false;
-               for (j=0; j < ni; j++) {
-                       if (!GUID_equal(our_invocation_id,
-                                       &nuv.ctr.ctr2.cursors[j].source_dsa_invocation_id)) {
-                               continue;
-                       }
-
-                       found = true;
-
-                       /*
-                        * here we update the highest_usn and last_sync_success time
-                        * because it's our own entry
-                        */
-                       nuv.ctr.ctr2.cursors[j].highest_usn             = seq_num;
-                       nuv.ctr.ctr2.cursors[j].last_sync_success       = now;
-                       break;
-               }
-               if (!found) {
-                       /*
-                        * here we update the highest_usn and last_sync_success time
-                        * because it's our own entry
-                        */
-                       nuv.ctr.ctr2.cursors[ni].source_dsa_invocation_id= *our_invocation_id;
-                       nuv.ctr.ctr2.cursors[ni].highest_usn            = seq_num;
-                       nuv.ctr.ctr2.cursors[ni].last_sync_success      = now;
-                       ni++;
-               }
-       }
-
        /*
         * finally correct the size of the cursors array
         */
@@ -1069,13 +1176,16 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
        /*
         * create the change ldb_message
         */
-       msg = ldb_msg_new(ar->sub.mem_ctx);
+       msg = ldb_msg_new(ar);
        if (!msg) return replmd_replicated_request_werror(ar, WERR_NOMEM);
-       msg->dn = ar->sub.search_msg->dn;
-
-       nt_status = ndr_push_struct_blob(&nuv_value, msg, &nuv,
-                                        (ndr_push_flags_fn_t)ndr_push_replUpToDateVectorBlob);
-       if (!NT_STATUS_IS_OK(nt_status)) {
+       msg->dn = ar->search_msg->dn;
+
+       ndr_err = ndr_push_struct_blob(&nuv_value, msg, 
+                                      lp_iconv_convenience(ldb_get_opaque(ar->module->ldb, "loadparm")), 
+                                      &nuv,
+                                      (ndr_push_flags_fn_t)ndr_push_replUpToDateVectorBlob);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
                return replmd_replicated_request_werror(ar, ntstatus_to_werror(nt_status));
        }
        ret = ldb_msg_add_value(msg, "replUpToDateVector", &nuv_value, &nuv_el);
@@ -1101,17 +1211,18 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
         * first see if we already have a repsFrom value for the current source dsa
         * if so we'll later replace this value
         */
-       orf_el = ldb_msg_find_element(ar->sub.search_msg, "repsFrom");
+       orf_el = ldb_msg_find_element(ar->search_msg, "repsFrom");
        if (orf_el) {
                for (i=0; i < orf_el->num_values; i++) {
                        struct repsFromToBlob *trf;
 
-                       trf = talloc(ar->sub.mem_ctx, struct repsFromToBlob);
+                       trf = talloc(ar, struct repsFromToBlob);
                        if (!trf) return replmd_replicated_request_werror(ar, WERR_NOMEM);
 
-                       nt_status = ndr_pull_struct_blob(&orf_el->values[i], trf, trf,
-                                                        (ndr_pull_flags_fn_t)ndr_pull_repsFromToBlob);
-                       if (!NT_STATUS_IS_OK(nt_status)) {
+                       ndr_err = ndr_pull_struct_blob(&orf_el->values[i], trf, lp_iconv_convenience(ldb_get_opaque(ar->module->ldb, "loadparm")), trf,
+                                                      (ndr_pull_flags_fn_t)ndr_pull_repsFromToBlob);
+                       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                               NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
                                return replmd_replicated_request_werror(ar, ntstatus_to_werror(nt_status));
                        }
 
@@ -1158,9 +1269,12 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
        }
 
        /* we now fill the value which is already attached to ldb_message */
-       nt_status = ndr_push_struct_blob(nrf_value, msg, &nrf,
-                                        (ndr_push_flags_fn_t)ndr_push_repsFromToBlob);
-       if (!NT_STATUS_IS_OK(nt_status)) {
+       ndr_err = ndr_push_struct_blob(nrf_value, msg, 
+                                      lp_iconv_convenience(ldb_get_opaque(ar->module->ldb, "loadparm")),
+                                      &nrf,
+                                      (ndr_push_flags_fn_t)ndr_push_repsFromToBlob);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               NTSTATUS nt_status = ndr_map_error2ntstatus(ndr_err);
                return replmd_replicated_request_werror(ar, ntstatus_to_werror(nt_status));
        }
 
@@ -1171,72 +1285,62 @@ static int replmd_replicated_uptodate_modify(struct replmd_replicated_request *a
        nrf_el->flags = LDB_FLAG_MOD_REPLACE;
 
        /* prepare the ldb_modify() request */
-       ret = ldb_build_mod_req(&ar->sub.change_req,
+       ret = ldb_build_mod_req(&change_req,
                                ar->module->ldb,
-                               ar->sub.mem_ctx,
+                               ar,
                                msg,
-                               NULL,
+                               ar->controls,
                                ar,
-                               replmd_replicated_uptodate_modify_callback);
-       if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
-
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       return ldb_next_request(ar->module, ar->sub.change_req);
-#else
-       ret = ldb_next_request(ar->module, ar->sub.change_req);
+                               replmd_replicated_uptodate_modify_callback,
+                               ar->req);
        if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
 
-       ar->sub.change_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.change_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.change_ret);
-       }
-
-       talloc_free(ar->sub.mem_ctx);
-       ZERO_STRUCT(ar->sub);
-
-       return replmd_replicated_request_done(ar);
-#endif
+       return ldb_next_request(ar->module, change_req);
 }
 
-static int replmd_replicated_uptodate_search_callback(struct ldb_context *ldb,
-                                                     void *private_data,
+static int replmd_replicated_uptodate_search_callback(struct ldb_request *req,
                                                      struct ldb_reply *ares)
 {
-       struct replmd_replicated_request *ar = talloc_get_type(private_data,
+       struct replmd_replicated_request *ar = talloc_get_type(req->context,
                                               struct replmd_replicated_request);
-       bool is_done = false;
+       int ret;
+
+       if (!ares) {
+               return ldb_module_done(ar->req, NULL, NULL,
+                                       LDB_ERR_OPERATIONS_ERROR);
+       }
+       if (ares->error != LDB_SUCCESS &&
+           ares->error != LDB_ERR_NO_SUCH_OBJECT) {
+               return ldb_module_done(ar->req, ares->controls,
+                                       ares->response, ares->error);
+       }
 
        switch (ares->type) {
        case LDB_REPLY_ENTRY:
-               ar->sub.search_msg = talloc_steal(ar->sub.mem_ctx, ares->message);
+               ar->search_msg = talloc_steal(ar, ares->message);
                break;
+
        case LDB_REPLY_REFERRAL:
                /* we ignore referrals */
                break;
-       case LDB_REPLY_EXTENDED:
-       case LDB_REPLY_DONE:
-               is_done = true;
-       }
-
-       talloc_free(ares);
 
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       if (is_done) {
-               ar->sub.search_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-               if (ar->sub.search_ret != LDB_SUCCESS) {
-                       return replmd_replicated_request_error(ar, ar->sub.search_ret);
+       case LDB_REPLY_DONE:
+               if (ar->search_msg == NULL) {
+                       ret = replmd_replicated_request_werror(ar, WERR_DS_DRA_INTERNAL_ERROR);
+               } else {
+                       ret = replmd_replicated_uptodate_modify(ar);
                }
-               if (!ar->sub.search_msg) {
-                       return replmd_replicated_request_werror(ar, WERR_DS_DRA_INTERNAL_ERROR);
+               if (ret != LDB_SUCCESS) {
+                       return ldb_module_done(ar->req, NULL, NULL, ret);
                }
-
-               return replmd_replicated_uptodate_modify(ar);
        }
-#endif
+
+       talloc_free(ares);
        return LDB_SUCCESS;
 }
 
-static int replmd_replicated_uptodate_search(struct replmd_replicated_request *ar)
+
+static int replmd_replicated_uptodate_vector(struct replmd_replicated_request *ar)
 {
        int ret;
        static const char *attrs[] = {
@@ -1244,49 +1348,32 @@ static int replmd_replicated_uptodate_search(struct replmd_replicated_request *a
                "repsFrom",
                NULL
        };
+       struct ldb_request *search_req;
 
-       ret = ldb_build_search_req(&ar->sub.search_req,
+       ar->search_msg = NULL;
+
+       ret = ldb_build_search_req(&search_req,
                                   ar->module->ldb,
-                                  ar->sub.mem_ctx,
+                                  ar,
                                   ar->objs->partition_dn,
                                   LDB_SCOPE_BASE,
                                   "(objectClass=*)",
                                   attrs,
                                   NULL,
                                   ar,
-                                  replmd_replicated_uptodate_search_callback);
+                                  replmd_replicated_uptodate_search_callback,
+                                  ar->req);
        if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
 
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       return ldb_next_request(ar->module, ar->sub.search_req);
-#else
-       ret = ldb_next_request(ar->module, ar->sub.search_req);
-       if (ret != LDB_SUCCESS) return replmd_replicated_request_error(ar, ret);
-
-       ar->sub.search_ret = ldb_wait(ar->sub.search_req->handle, LDB_WAIT_ALL);
-       if (ar->sub.search_ret != LDB_SUCCESS) {
-               return replmd_replicated_request_error(ar, ar->sub.search_ret);
-       }
-       if (!ar->sub.search_msg) {
-               return replmd_replicated_request_werror(ar, WERR_DS_DRA_INTERNAL_ERROR);
-       }
-
-       return replmd_replicated_uptodate_modify(ar);
-#endif
-}
-
-static int replmd_replicated_uptodate_vector(struct replmd_replicated_request *ar)
-{
-       ar->sub.mem_ctx = talloc_new(ar);
-       if (!ar->sub.mem_ctx) return replmd_replicated_request_werror(ar, WERR_NOMEM);
-
-       return replmd_replicated_uptodate_search(ar);
+       return ldb_next_request(ar->module, search_req);
 }
 
 static int replmd_extended_replicated_objects(struct ldb_module *module, struct ldb_request *req)
 {
        struct dsdb_extended_replicated_objects *objs;
        struct replmd_replicated_request *ar;
+       struct ldb_control **ctrls;
+       int ret;
 
        ldb_debug(module->ldb, LDB_DEBUG_TRACE, "replmd_extended_replicated_objects\n");
 
@@ -1302,25 +1389,35 @@ static int replmd_extended_replicated_objects(struct ldb_module *module, struct
                return LDB_ERR_PROTOCOL_ERROR;
        }
 
-       ar = replmd_replicated_init_handle(module, req, objs);
-       if (!ar) {
+       ar = replmd_ctx_init(module, req);
+       if (!ar)
                return LDB_ERR_OPERATIONS_ERROR;
+
+       ar->objs = objs;
+       ar->schema = dsdb_get_schema(module->ldb);
+       if (!ar->schema) {
+               ldb_debug_set(module->ldb, LDB_DEBUG_FATAL, "replmd_ctx_init: no loaded schema found\n");
+               talloc_free(ar);
+               return LDB_ERR_CONSTRAINT_VIOLATION;
        }
 
-#ifdef REPLMD_FULL_ASYNC /* TODO: active this code when ldb support full async code */ 
-       return replmd_replicated_apply_next(ar);
-#else
-       while (ar->index_current < ar->objs->num_objects &&
-              req->handle->state != LDB_ASYNC_DONE) { 
-               replmd_replicated_apply_next(ar);
+       ctrls = req->controls;
+
+       if (req->controls) {
+               req->controls = talloc_memdup(ar, req->controls,
+                                             talloc_get_size(req->controls));
+               if (!req->controls) return replmd_replicated_request_werror(ar, WERR_NOMEM);
        }
 
-       if (req->handle->state != LDB_ASYNC_DONE) {
-               replmd_replicated_uptodate_vector(ar);
+       ret = ldb_request_add_control(req, DSDB_CONTROL_REPLICATED_UPDATE_OID, false, NULL);
+       if (ret != LDB_SUCCESS) {
+               return ret;
        }
 
-       return LDB_SUCCESS;
-#endif
+       ar->controls = req->controls;
+       req->controls = ctrls;
+
+       return replmd_replicated_apply_next(ar);
 }
 
 static int replmd_extended(struct ldb_module *module, struct ldb_request *req)
@@ -1332,58 +1429,9 @@ static int replmd_extended(struct ldb_module *module, struct ldb_request *req)
        return ldb_next_request(module, req);
 }
 
-static int replmd_wait_none(struct ldb_handle *handle) {
-       struct replmd_replicated_request *ar;
-    
-       if (!handle || !handle->private_data) {
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
-
-       ar = talloc_get_type(handle->private_data, struct replmd_replicated_request);
-       if (!ar) {
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
-
-       /* we do only sync calls */
-       if (handle->state != LDB_ASYNC_DONE) {
-               return LDB_ERR_OPERATIONS_ERROR;
-       }
-
-       return handle->status;
-}
-
-static int replmd_wait_all(struct ldb_handle *handle) {
-
-       int ret;
-
-       while (handle->state != LDB_ASYNC_DONE) {
-               ret = replmd_wait_none(handle);
-               if (ret != LDB_SUCCESS) {
-                       return ret;
-               }
-       }
-
-       return handle->status;
-}
-
-static int replmd_wait(struct ldb_handle *handle, enum ldb_wait_type type)
-{
-       if (type == LDB_WAIT_ALL) {
-               return replmd_wait_all(handle);
-       } else {
-               return replmd_wait_none(handle);
-       }
-}
-
-static const struct ldb_module_ops replmd_ops = {
+_PUBLIC_ const struct ldb_module_ops ldb_repl_meta_data_module_ops = {
        .name          = "repl_meta_data",
        .add           = replmd_add,
        .modify        = replmd_modify,
        .extended      = replmd_extended,
-       .wait          = replmd_wait
 };
-
-int repl_meta_data_module_init(void)
-{
-       return ldb_register_module(&replmd_ops);
-}