Fix Samba4 build errors with common libcli/samsync
[ira/wip.git] / source4 / auth / ntlmssp / ntlmssp.c
index d0bd98419e7e8e1116da7c5b7c622c0e342d560e..1388ad4a2242fa229bd5c5ccffe365814320eb07 100644 (file)
@@ -9,7 +9,7 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
-#include "auth/auth.h"
-#include "lib/crypto/crypto.h"
 #include "auth/ntlmssp/ntlmssp.h"
+#include "../libcli/auth/libcli_auth.h"
+#include "librpc/gen_ndr/ndr_dcerpc.h"
+#include "auth/credentials/credentials.h"
+#include "auth/gensec/gensec.h"
+#include "auth/gensec/gensec_proto.h"
+#include "auth/auth.h"
+#include "auth/ntlm/auth_proto.h"
+#include "param/param.h"
 
 /**
  * Callbacks for NTLMSSP - for both client and server operating modes
 
 static const struct ntlmssp_callbacks {
        enum ntlmssp_role role;
-       enum ntlmssp_message_type ntlmssp_command;
-       NTSTATUS (*fn)(struct ntlmssp_state *ntlmssp_state, 
-                      TALLOC_CTX *out_mem_ctx, 
-                      DATA_BLOB in, DATA_BLOB *out);
+       enum ntlmssp_message_type command;
+       NTSTATUS (*sync_fn)(struct gensec_security *gensec_security,
+                           TALLOC_CTX *out_mem_ctx,
+                           DATA_BLOB in, DATA_BLOB *out);
 } ntlmssp_callbacks[] = {
-       {NTLMSSP_CLIENT, NTLMSSP_INITIAL, ntlmssp_client_initial},
-       {NTLMSSP_SERVER, NTLMSSP_NEGOTIATE, ntlmssp_server_negotiate},
-       {NTLMSSP_CLIENT, NTLMSSP_CHALLENGE, ntlmssp_client_challenge},
-       {NTLMSSP_SERVER, NTLMSSP_AUTH, ntlmssp_server_auth},
+       {
+               .role           = NTLMSSP_CLIENT,
+               .command        = NTLMSSP_INITIAL,
+               .sync_fn        = ntlmssp_client_initial,
+       },{
+               .role           = NTLMSSP_SERVER,
+               .command        = NTLMSSP_NEGOTIATE,
+               .sync_fn        = ntlmssp_server_negotiate,
+       },{
+               .role           = NTLMSSP_CLIENT,
+               .command        = NTLMSSP_CHALLENGE,
+               .sync_fn        = ntlmssp_client_challenge,
+       },{
+               .role           = NTLMSSP_SERVER,
+               .command        = NTLMSSP_AUTH,
+               .sync_fn        = ntlmssp_server_auth,
+       }
 };
 
 
@@ -65,6 +83,8 @@ void debug_ntlmssp_flags(uint32_t neg_flags)
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_SIGN\n"));
        if (neg_flags & NTLMSSP_NEGOTIATE_SEAL) 
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_SEAL\n"));
+       if (neg_flags & NTLMSSP_NEGOTIATE_DATAGRAM_STYLE) 
+               DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_DATAGRAM_STYLE\n"));
        if (neg_flags & NTLMSSP_NEGOTIATE_LM_KEY) 
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_LM_KEY\n"));
        if (neg_flags & NTLMSSP_NEGOTIATE_NETWARE) 
@@ -79,6 +99,10 @@ void debug_ntlmssp_flags(uint32_t neg_flags)
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_THIS_IS_LOCAL_CALL\n"));
        if (neg_flags & NTLMSSP_NEGOTIATE_ALWAYS_SIGN) 
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_ALWAYS_SIGN\n"));
+       if (neg_flags & NTLMSSP_CHAL_ACCEPT_RESPONSE) 
+               DEBUGADD(4, ("  NTLMSSP_CHAL_ACCEPT_RESPONSE\n"));
+       if (neg_flags & NTLMSSP_CHAL_NON_NT_SESSION_KEY) 
+               DEBUGADD(4, ("  NTLMSSP_CHAL_NON_NT_SESSION_KEY\n"));
        if (neg_flags & NTLMSSP_NEGOTIATE_NTLM2) 
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_NTLM2\n"));
        if (neg_flags & NTLMSSP_CHAL_TARGET_INFO) 
@@ -87,138 +111,54 @@ void debug_ntlmssp_flags(uint32_t neg_flags)
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_128\n"));
        if (neg_flags & NTLMSSP_NEGOTIATE_KEY_EXCH) 
                DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_KEY_EXCH\n"));
+       if (neg_flags & NTLMSSP_NEGOTIATE_56) 
+               DEBUGADD(4, ("  NTLMSSP_NEGOTIATE_56\n"));
 }
 
-/** 
- * Set a username on an NTLMSSP context - ensures it is talloc()ed 
- *
- */
-
-NTSTATUS ntlmssp_set_username(struct ntlmssp_state *ntlmssp_state, const char *user) 
+static NTSTATUS gensec_ntlmssp_magic(struct gensec_security *gensec_security, 
+                                    const DATA_BLOB *first_packet) 
 {
-       if (!user) {
-               /* it should be at least "" */
-               DEBUG(1, ("NTLMSSP failed to set username - cannot accept NULL username\n"));
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-       ntlmssp_state->user = talloc_strdup(ntlmssp_state, user);
-       if (!ntlmssp_state->user) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       return NT_STATUS_OK;
-}
-
-/** 
- * Set a password on an NTLMSSP context - ensures it is talloc()ed 
- *
- */
-NTSTATUS ntlmssp_set_password(struct ntlmssp_state *ntlmssp_state, const char *password) 
-{
-       if (!password) {
-               ntlmssp_state->password = NULL;
+       if (first_packet->length > 8 && memcmp("NTLMSSP\0", first_packet->data, 8) == 0) {
+               return NT_STATUS_OK;
        } else {
-               ntlmssp_state->password = talloc_strdup(ntlmssp_state, password);
-               if (!ntlmssp_state->password) {
-                       return NT_STATUS_NO_MEMORY;
-               }
-       }
-       return NT_STATUS_OK;
-}
-
-/** 
- * Set a domain on an NTLMSSP context - ensures it is talloc()ed 
- *
- */
-NTSTATUS ntlmssp_set_domain(struct ntlmssp_state *ntlmssp_state, const char *domain) 
-{
-       ntlmssp_state->domain = talloc_strdup(ntlmssp_state, domain);
-       if (!ntlmssp_state->domain) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       return NT_STATUS_OK;
-}
-
-/** 
- * Set a workstation on an NTLMSSP context - ensures it is talloc()ed 
- *
- */
-NTSTATUS ntlmssp_set_workstation(struct ntlmssp_state *ntlmssp_state, const char *workstation) 
-{
-       ntlmssp_state->workstation = talloc_strdup(ntlmssp_state, workstation);
-       if (!ntlmssp_state->workstation) {
-               return NT_STATUS_NO_MEMORY;
+               return NT_STATUS_INVALID_PARAMETER;
        }
-       return NT_STATUS_OK;
 }
 
-/**
- *  Store a DATA_BLOB containing an NTLMSSP response, for use later.
- *  This copies the data blob
- */
-
-NTSTATUS ntlmssp_store_response(struct ntlmssp_state *ntlmssp_state,
-                               DATA_BLOB response) 
+static NTSTATUS gensec_ntlmssp_update_find(struct gensec_ntlmssp_state *gensec_ntlmssp_state,
+                                          const DATA_BLOB input, uint32_t *idx)
 {
-       ntlmssp_state->stored_response = data_blob_talloc(ntlmssp_state, 
-                                                         response.data, response.length);
-       return NT_STATUS_OK;
-}
-
-/**
- * Next state function for the wrapped NTLMSSP state machine
- * 
- * @param gensec_security GENSEC state, initialised to NTLMSSP
- * @param out_mem_ctx The TALLOC_CTX for *out to be allocated on
- * @param in The request, as a DATA_BLOB
- * @param out The reply, as an talloc()ed DATA_BLOB, on *out_mem_ctx
- * @return Error, MORE_PROCESSING_REQUIRED if a reply is sent, 
- *                or NT_STATUS_OK if the user is authenticated. 
- */
-
-static NTSTATUS gensec_ntlmssp_update(struct gensec_security *gensec_security, TALLOC_CTX *out_mem_ctx, 
-                                     const DATA_BLOB in, DATA_BLOB *out) 
-{
-       struct gensec_ntlmssp_state *gensec_ntlmssp_state = gensec_security->private_data;
-       struct ntlmssp_state *ntlmssp_state = gensec_ntlmssp_state->ntlmssp_state;
-       NTSTATUS status;
-
-       DATA_BLOB input;
+       struct gensec_security *gensec_security = gensec_ntlmssp_state->gensec_security;
        uint32_t ntlmssp_command;
-       int i;
+       uint32_t i;
 
-       *out = data_blob(NULL, 0);
+       if (gensec_ntlmssp_state->expected_state == NTLMSSP_DONE) {
+               /* We are strict here because other modules, which we
+                * don't fully control (such as GSSAPI) are also
+                * strict, but are tested less often */
 
-       if (ntlmssp_state->expected_state == NTLMSSP_DONE) {
-               return NT_STATUS_OK;
-       }
-
-       if (!out_mem_ctx) {
-               /* if the caller doesn't want to manage/own the memory, 
-                  we can put it on our context */
-               out_mem_ctx = ntlmssp_state;
-       }
-
-       if (!in.length && ntlmssp_state->stored_response.length) {
-               input = ntlmssp_state->stored_response;
-               
-               /* we only want to read the stored response once - overwrite it */
-               ntlmssp_state->stored_response = data_blob(NULL, 0);
-       } else {
-               input = in;
+               DEBUG(1, ("Called NTLMSSP after state machine was 'done'\n"));
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
        if (!input.length) {
-               switch (ntlmssp_state->role) {
+               switch (gensec_ntlmssp_state->role) {
                case NTLMSSP_CLIENT:
                        ntlmssp_command = NTLMSSP_INITIAL;
                        break;
                case NTLMSSP_SERVER:
-                       /* 'datagram' mode - no neg packet */
-                       ntlmssp_command = NTLMSSP_NEGOTIATE;
+                       if (gensec_security->want_features & GENSEC_FEATURE_DATAGRAM_MODE) {
+                               /* 'datagram' mode - no neg packet */
+                               ntlmssp_command = NTLMSSP_NEGOTIATE;
+                       } else {
+                               /* This is normal in SPNEGO mech negotiation fallback */
+                               DEBUG(2, ("Failed to parse NTLMSSP packet: zero length\n"));
+                               return NT_STATUS_INVALID_PARAMETER;
+                       }
                        break;
                }
        } else {
-               if (!msrpc_parse(ntlmssp_state, 
+               if (!msrpc_parse(gensec_ntlmssp_state, 
                                 &input, "Cd",
                                 "NTLMSSP",
                                 &ntlmssp_command)) {
@@ -228,122 +168,141 @@ static NTSTATUS gensec_ntlmssp_update(struct gensec_security *gensec_security, T
                }
        }
 
-       if (ntlmssp_command != ntlmssp_state->expected_state) {
-               DEBUG(1, ("got NTLMSSP command %u, expected %u\n", ntlmssp_command, ntlmssp_state->expected_state));
+       if (ntlmssp_command != gensec_ntlmssp_state->expected_state) {
+               DEBUG(2, ("got NTLMSSP command %u, expected %u\n", ntlmssp_command, gensec_ntlmssp_state->expected_state));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
        for (i=0; i < ARRAY_SIZE(ntlmssp_callbacks); i++) {
-               if (ntlmssp_callbacks[i].role == ntlmssp_state->role 
-                   && ntlmssp_callbacks[i].ntlmssp_command == ntlmssp_command) {
-                       status = ntlmssp_callbacks[i].fn(ntlmssp_state, out_mem_ctx, input, out);
-                       break;
+               if (ntlmssp_callbacks[i].role == gensec_ntlmssp_state->role &&
+                   ntlmssp_callbacks[i].command == ntlmssp_command) {
+                       *idx = i;
+                       return NT_STATUS_OK;
                }
        }
 
-       if (i == ARRAY_SIZE(ntlmssp_callbacks)) {
-               
-               DEBUG(1, ("failed to find NTLMSSP callback for NTLMSSP mode %u, command %u\n", 
-                         ntlmssp_state->role, ntlmssp_command)); 
+       DEBUG(1, ("failed to find NTLMSSP callback for NTLMSSP mode %u, command %u\n", 
+                 gensec_ntlmssp_state->role, ntlmssp_command)); 
                
-               return NT_STATUS_INVALID_PARAMETER;
-       }
+       return NT_STATUS_INVALID_PARAMETER;
+}
 
-       if (!NT_STATUS_EQUAL(status, NT_STATUS_MORE_PROCESSING_REQUIRED) && !NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-       
-       gensec_ntlmssp_state->have_features = 0;
+/**
+ * Next state function for the wrapped NTLMSSP state machine
+ * 
+ * @param gensec_security GENSEC state, initialised to NTLMSSP
+ * @param out_mem_ctx The TALLOC_CTX for *out to be allocated on
+ * @param in The request, as a DATA_BLOB
+ * @param out The reply, as an talloc()ed DATA_BLOB, on *out_mem_ctx
+ * @return Error, MORE_PROCESSING_REQUIRED if a reply is sent, 
+ *                or NT_STATUS_OK if the user is authenticated. 
+ */
 
-       if (gensec_ntlmssp_state->ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_SIGN) {
-               gensec_ntlmssp_state->have_features |= GENSEC_FEATURE_SIGN;
-       }
+static NTSTATUS gensec_ntlmssp_update(struct gensec_security *gensec_security, 
+                                     TALLOC_CTX *out_mem_ctx, 
+                                     const DATA_BLOB input, DATA_BLOB *out)
+{
+       struct gensec_ntlmssp_state *gensec_ntlmssp_state = (struct gensec_ntlmssp_state *)gensec_security->private_data;
+       NTSTATUS status;
+       uint32_t i;
 
-       if (gensec_ntlmssp_state->ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_SEAL) {
-               gensec_ntlmssp_state->have_features |= GENSEC_FEATURE_SEAL;
-       }
+       *out = data_blob(NULL, 0);
 
-       if (gensec_ntlmssp_state->ntlmssp_state->session_key.data) {
-               gensec_ntlmssp_state->have_features |= GENSEC_FEATURE_SESSION_KEY;
+       if (!out_mem_ctx) {
+               /* if the caller doesn't want to manage/own the memory, 
+                  we can put it on our context */
+               out_mem_ctx = gensec_ntlmssp_state;
        }
 
-       return status;
+       status = gensec_ntlmssp_update_find(gensec_ntlmssp_state, input, &i);
+       NT_STATUS_NOT_OK_RETURN(status);
+
+       status = ntlmssp_callbacks[i].sync_fn(gensec_security, out_mem_ctx, input, out);
+       NT_STATUS_NOT_OK_RETURN(status);
+       
+       return NT_STATUS_OK;
 }
 
 /**
  * Return the NTLMSSP master session key
  * 
- * @param ntlmssp_state NTLMSSP State
+ * @param gensec_ntlmssp_state NTLMSSP State
  */
 
 NTSTATUS gensec_ntlmssp_session_key(struct gensec_security *gensec_security, 
                                    DATA_BLOB *session_key)
 {
-       struct gensec_ntlmssp_state *gensec_ntlmssp_state = gensec_security->private_data;
-       struct ntlmssp_state *ntlmssp_state = gensec_ntlmssp_state->ntlmssp_state;
+       struct gensec_ntlmssp_state *gensec_ntlmssp_state = (struct gensec_ntlmssp_state *)gensec_security->private_data;
+
+       if (gensec_ntlmssp_state->expected_state != NTLMSSP_DONE) {
+               return NT_STATUS_NO_USER_SESSION_KEY;
+       }
 
-       if (!ntlmssp_state->session_key.data) {
+       if (!gensec_ntlmssp_state->session_key.data) {
                return NT_STATUS_NO_USER_SESSION_KEY;
        }
-       *session_key = ntlmssp_state->session_key;
+       *session_key = gensec_ntlmssp_state->session_key;
 
        return NT_STATUS_OK;
 }
 
-void ntlmssp_handle_neg_flags(struct ntlmssp_state *ntlmssp_state,
-                             uint32_t neg_flags, BOOL allow_lm)
+void ntlmssp_handle_neg_flags(struct gensec_ntlmssp_state *gensec_ntlmssp_state,
+                             uint32_t neg_flags, bool allow_lm)
 {
        if (neg_flags & NTLMSSP_NEGOTIATE_UNICODE) {
-               ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_UNICODE;
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_OEM;
-               ntlmssp_state->unicode = True;
+               gensec_ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_UNICODE;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_OEM;
+               gensec_ntlmssp_state->unicode = true;
        } else {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_UNICODE;
-               ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_OEM;
-               ntlmssp_state->unicode = False;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_UNICODE;
+               gensec_ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_OEM;
+               gensec_ntlmssp_state->unicode = false;
        }
 
-       if ((neg_flags & NTLMSSP_NEGOTIATE_LM_KEY) && allow_lm && !ntlmssp_state->use_ntlmv2) {
+       if ((neg_flags & NTLMSSP_NEGOTIATE_LM_KEY) && allow_lm && !gensec_ntlmssp_state->use_ntlmv2) {
                /* other end forcing us to use LM */
-               ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_LM_KEY;
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_NTLM2;
+               gensec_ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_LM_KEY;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_NTLM2;
        } else {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_LM_KEY;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_LM_KEY;
        }
 
-       if (neg_flags & NTLMSSP_NEGOTIATE_ALWAYS_SIGN) {
-               ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_ALWAYS_SIGN;
+       if (!(neg_flags & NTLMSSP_NEGOTIATE_ALWAYS_SIGN)) {
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_ALWAYS_SIGN;
        }
 
        if (!(neg_flags & NTLMSSP_NEGOTIATE_SIGN)) {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_SIGN;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_SIGN;
        }
 
        if (!(neg_flags & NTLMSSP_NEGOTIATE_SEAL)) {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_SEAL;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_SEAL;
        }
 
        if (!(neg_flags & NTLMSSP_NEGOTIATE_NTLM2)) {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_NTLM2;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_NTLM2;
        }
 
        if (!(neg_flags & NTLMSSP_NEGOTIATE_128)) {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_128;
-               if (neg_flags & NTLMSSP_NEGOTIATE_56) {
-                       ntlmssp_state->neg_flags |= NTLMSSP_NEGOTIATE_56;
-               }
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_128;
        }
 
        if (!(neg_flags & NTLMSSP_NEGOTIATE_56)) {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_56;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_56;
        }
 
        if (!(neg_flags & NTLMSSP_NEGOTIATE_KEY_EXCH)) {
-               ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_KEY_EXCH;
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_NEGOTIATE_KEY_EXCH;
+       }
+
+       /* Woop Woop - unknown flag for Windows compatibility...
+          What does this really do ? JRA. */
+       if (!(neg_flags & NTLMSSP_UNKNOWN_02000000)) {
+               gensec_ntlmssp_state->neg_flags &= ~NTLMSSP_UNKNOWN_02000000;
        }
 
        if ((neg_flags & NTLMSSP_REQUEST_TARGET)) {
-               ntlmssp_state->neg_flags |= NTLMSSP_REQUEST_TARGET;
+               gensec_ntlmssp_state->neg_flags |= NTLMSSP_REQUEST_TARGET;
        }
        
 }
@@ -356,63 +315,105 @@ void ntlmssp_handle_neg_flags(struct ntlmssp_state *ntlmssp_state,
    by the client lanman auth/lanman auth parameters, it isn't too bad.
 */
 
-void ntlmssp_weaken_keys(struct ntlmssp_state *ntlmssp_state) 
+DATA_BLOB ntlmssp_weakend_key(struct gensec_ntlmssp_state *gensec_ntlmssp_state, 
+                             TALLOC_CTX *mem_ctx) 
 {
+       DATA_BLOB weakened_key = data_blob_talloc(mem_ctx, 
+                                                 gensec_ntlmssp_state->session_key.data, 
+                                                 gensec_ntlmssp_state->session_key.length);
+       /* Nothing to weaken.  We certainly don't want to 'extend' the length... */
+       if (weakened_key.length < 16) {
+               /* perhaps there was no key? */
+               return weakened_key;
+       }
+
        /* Key weakening not performed on the master key for NTLM2
           and does not occour for NTLM1.  Therefore we only need
           to do this for the LM_KEY.  
        */
-
-       if (ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_LM_KEY) {
-               if (ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_128) {
-                       
-               } else if (ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_56) {
-                       ntlmssp_state->session_key.data[7] = 0xa0;
+       if (gensec_ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_LM_KEY) {
+               /* LM key doesn't support 128 bit crypto, so this is
+                * the best we can do.  If you negotiate 128 bit, but
+                * not 56, you end up with 40 bit... */
+               if (gensec_ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_56) {
+                       weakened_key.data[7] = 0xa0;
+                       weakened_key.length = 8;
                } else { /* forty bits */
-                       ntlmssp_state->session_key.data[5] = 0xe5;
-                       ntlmssp_state->session_key.data[6] = 0x38;
-                       ntlmssp_state->session_key.data[7] = 0xb0;
+                       weakened_key.data[5] = 0xe5;
+                       weakened_key.data[6] = 0x38;
+                       weakened_key.data[7] = 0xb0;
+                       weakened_key.length = 8;
                }
-               ntlmssp_state->session_key.length = 8;
        }
+       return weakened_key;
 }
 
-static BOOL gensec_ntlmssp_have_feature(struct gensec_security *gensec_security,
+static bool gensec_ntlmssp_have_feature(struct gensec_security *gensec_security,
                                        uint32_t feature)
 {
-       struct gensec_ntlmssp_state *gensec_ntlmssp_state = gensec_security->private_data;
-       if (gensec_ntlmssp_state->have_features & feature) {
-               return True;
+       struct gensec_ntlmssp_state *gensec_ntlmssp_state = (struct gensec_ntlmssp_state *)gensec_security->private_data;
+       if (feature & GENSEC_FEATURE_SIGN) {
+               if (!gensec_ntlmssp_state->session_key.length) {
+                       return false;
+               }
+               if (gensec_ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_SIGN) {
+                       return true;
+               }
        }
-
-       return False;
+       if (feature & GENSEC_FEATURE_SEAL) {
+               if (!gensec_ntlmssp_state->session_key.length) {
+                       return false;
+               }
+               if (gensec_ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_SEAL) {
+                       return true;
+               }
+       }
+       if (feature & GENSEC_FEATURE_SESSION_KEY) {
+               if (gensec_ntlmssp_state->session_key.length) {
+                       return true;
+               }
+       }
+       if (feature & GENSEC_FEATURE_DCE_STYLE) {
+               return true;
+       }
+       if (feature & GENSEC_FEATURE_ASYNC_REPLIES) {
+               if (gensec_ntlmssp_state->neg_flags & NTLMSSP_NEGOTIATE_NTLM2) {
+                       return true;
+               }
+       }
+       return false;
 }
 
 NTSTATUS gensec_ntlmssp_start(struct gensec_security *gensec_security)
 {
        struct gensec_ntlmssp_state *gensec_ntlmssp_state;
        
-       gensec_ntlmssp_state = talloc(gensec_security, struct gensec_ntlmssp_state);
+       gensec_ntlmssp_state = talloc_zero(gensec_security, struct gensec_ntlmssp_state);
        if (!gensec_ntlmssp_state) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       gensec_ntlmssp_state->ntlmssp_state = NULL;
+       gensec_ntlmssp_state->gensec_security = gensec_security;
        gensec_ntlmssp_state->auth_context = NULL;
        gensec_ntlmssp_state->server_info = NULL;
-       gensec_ntlmssp_state->have_features = 0;
 
        gensec_security->private_data = gensec_ntlmssp_state;
        return NT_STATUS_OK;
 }
 
+static const char *gensec_ntlmssp_oids[] = { 
+       GENSEC_OID_NTLMSSP, 
+       NULL
+};
+
 static const struct gensec_security_ops gensec_ntlmssp_security_ops = {
        .name           = "ntlmssp",
        .sasl_name      = "NTLM",
        .auth_type      = DCERPC_AUTH_TYPE_NTLMSSP,
-       .oid            = GENSEC_OID_NTLMSSP,
+       .oid            = gensec_ntlmssp_oids,
        .client_start   = gensec_ntlmssp_client_start,
        .server_start   = gensec_ntlmssp_server_start,
+       .magic          = gensec_ntlmssp_magic,
        .update         = gensec_ntlmssp_update,
        .sig_size       = gensec_ntlmssp_sig_size,
        .sign_packet    = gensec_ntlmssp_sign_packet,
@@ -424,13 +425,15 @@ static const struct gensec_security_ops gensec_ntlmssp_security_ops = {
        .session_key    = gensec_ntlmssp_session_key,
        .session_info   = gensec_ntlmssp_session_info,
        .have_feature   = gensec_ntlmssp_have_feature,
-       .enabled        = True
+       .enabled        = true,
+       .priority       = GENSEC_NTLMSSP
 };
 
 
-NTSTATUS gensec_ntlmssp_init(void)
+_PUBLIC_ NTSTATUS gensec_ntlmssp_init(void)
 {
        NTSTATUS ret;
+
        ret = gensec_register(&gensec_ntlmssp_security_ops);
        if (!NT_STATUS_IS_OK(ret)) {
                DEBUG(0,("Failed to register '%s' gensec backend!\n",