Fix enumeration of forest trusts from our root domain.
[ira/wip.git] / source3 / winbindd / winbindd_cm.c
index 4c9ae0365fc730bee8d243d841b59be2ac4cd985..39d8def7ea67f04b4fcef3d2c16b06680009209a 100644 (file)
@@ -74,7 +74,7 @@ extern bool override_logfile;
 
 static NTSTATUS init_dc_connection_network(struct winbindd_domain *domain);
 static void set_dc_type_and_flags( struct winbindd_domain *domain );
-static bool get_dcs(TALLOC_CTX *mem_ctx, const struct winbindd_domain *domain,
+static bool get_dcs(TALLOC_CTX *mem_ctx, struct winbindd_domain *domain,
                    struct dc_name_ip **dcs, int *num_dcs);
 
 /****************************************************************
@@ -208,10 +208,12 @@ static bool fork_child_dc_connect(struct winbindd_domain *domain)
        close_conns_after_fork();
 
        if (!override_logfile) {
-               pstring logfile;
-               pstr_sprintf(logfile, "%s/log.winbindd-dc-connect", dyn_LOGFILEBASE);
-               lp_set_logfile(logfile);
-               reopen_logs();
+               char *logfile;
+               if (asprintf(&logfile, "%s/log.winbindd-dc-connect", get_dyn_LOGFILEBASE()) > 0) {
+                       lp_set_logfile(logfile);
+                       SAFE_FREE(logfile);
+                       reopen_logs();
+               }
        }
 
        mem_ctx = talloc_init("fork_child_dc_connect");
@@ -558,7 +560,7 @@ static void cm_get_ipc_userpass(char **username, char **domain, char **password)
        }
 }
 
-static bool get_dc_name_via_netlogon(const struct winbindd_domain *domain,
+static bool get_dc_name_via_netlogon(struct winbindd_domain *domain,
                                     fstring dcname,
                                     struct sockaddr_storage *dc_ss)
 {
@@ -568,8 +570,8 @@ static bool get_dc_name_via_netlogon(const struct winbindd_domain *domain,
        WERROR werr;
        TALLOC_CTX *mem_ctx;
        unsigned int orig_timeout;
-       fstring tmp;
-       char *p;
+       const char *tmp = NULL;
+       const char *p;
 
        /* Hmmmm. We can only open one connection to the NETLOGON pipe at the
         * moment.... */
@@ -598,22 +600,62 @@ static bool get_dc_name_via_netlogon(const struct winbindd_domain *domain,
           35 seconds should do it. */
 
        orig_timeout = cli_set_timeout(netlogon_pipe->cli, 35000);
-       
-       werr = rpccli_netlogon_getanydcname(netlogon_pipe, mem_ctx, our_domain->dcname,
-                                           domain->name, tmp);
+
+       if (our_domain->active_directory) {
+               struct netr_DsRGetDCNameInfo *domain_info = NULL;
+
+               result = rpccli_netr_DsRGetDCName(netlogon_pipe,
+                                                 mem_ctx,
+                                                 our_domain->dcname,
+                                                 domain->name,
+                                                 NULL,
+                                                 NULL,
+                                                 DS_RETURN_DNS_NAME,
+                                                 &domain_info,
+                                                 &werr);
+               if (W_ERROR_IS_OK(werr)) {
+                       tmp = talloc_strdup(
+                               mem_ctx, domain_info->dc_unc);
+                       if (tmp == NULL) {
+                               DEBUG(0, ("talloc_strdup failed\n"));
+                               talloc_destroy(mem_ctx);
+                               return false;
+                       }
+                       if (strlen(domain->alt_name) == 0) {
+                               fstrcpy(domain->alt_name,
+                                       domain_info->domain_name);
+                       }
+                       if (strlen(domain->forest_name) == 0) {
+                               fstrcpy(domain->forest_name,
+                                       domain_info->forest_name);
+                       }
+               }
+       } else {
+               result = rpccli_netr_GetAnyDCName(netlogon_pipe, mem_ctx,
+                                                 our_domain->dcname,
+                                                 domain->name,
+                                                 &tmp,
+                                                 &werr);
+       }
 
        /* And restore our original timeout. */
        cli_set_timeout(netlogon_pipe->cli, orig_timeout);
 
-       talloc_destroy(mem_ctx);
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(10,("rpccli_netr_GetAnyDCName failed: %s\n",
+                       nt_errstr(result)));
+               talloc_destroy(mem_ctx);
+               return false;
+       }
 
        if (!W_ERROR_IS_OK(werr)) {
-               DEBUG(10, ("rpccli_netlogon_getanydcname failed: %s\n",
+               DEBUG(10,("rpccli_netr_GetAnyDCName failed: %s\n",
                           dos_errstr(werr)));
-               return False;
+               talloc_destroy(mem_ctx);
+               return false;
        }
 
-       /* cli_netlogon_getanydcname gives us a name with \\ */
+       /* rpccli_netr_GetAnyDCName gives us a name with \\ */
        p = tmp;
        if (*p == '\\') {
                p+=1;
@@ -624,7 +666,9 @@ static bool get_dc_name_via_netlogon(const struct winbindd_domain *domain,
 
        fstrcpy(dcname, p);
 
-       DEBUG(10, ("rpccli_netlogon_getanydcname returned %s\n", dcname));
+       talloc_destroy(mem_ctx);
+
+       DEBUG(10,("rpccli_netr_GetAnyDCName returned %s\n", dcname));
 
        if (!resolve_name(dcname, dc_ss, 0x20)) {
                return False;
@@ -633,6 +677,58 @@ static bool get_dc_name_via_netlogon(const struct winbindd_domain *domain,
        return True;
 }
 
+/**
+ * Helper function to assemble trust password and account name
+ */
+static NTSTATUS get_trust_creds(const struct winbindd_domain *domain,
+                               char **machine_password,
+                               char **machine_account,
+                               char **machine_krb5_principal)
+{
+       const char *account_name;
+       const char *name = NULL;
+       
+       /* If we are a DC and this is not our own domain */
+
+       if (IS_DC) {
+               name = domain->name;
+       } else {
+               struct winbindd_domain *our_domain = find_our_domain();
+
+               if (!our_domain)
+                       return NT_STATUS_INVALID_SERVER_STATE;          
+               
+               name = our_domain->name;                
+       }       
+       
+       if (!get_trust_pw_clear(name, machine_password,
+                               &account_name, NULL))
+       {
+               return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
+       }
+
+       if ((machine_account != NULL) &&
+           (asprintf(machine_account, "%s$", account_name) == -1))
+       {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* this is at least correct when domain is our domain,
+        * which is the only case, when this is currently used: */
+       if (machine_krb5_principal != NULL)
+       {
+               if (asprintf(machine_krb5_principal, "%s$@%s",
+                            account_name, domain->alt_name) == -1)
+               {
+                       return NT_STATUS_NO_MEMORY;
+               }
+
+               strupper_m(*machine_krb5_principal);
+       }
+
+       return NT_STATUS_OK;
+}
+
 /************************************************************************
  Given a fd with a just-connected TCP connection to a DC, open a connection
  to the pipe.
@@ -644,10 +740,14 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                                      struct cli_state **cli,
                                      bool *retry)
 {
-       char *machine_password, *machine_krb5_principal, *machine_account;
-       char *ipc_username, *ipc_domain, *ipc_password;
+       char *machine_password = NULL;
+       char *machine_krb5_principal = NULL;
+       char *machine_account = NULL;
+       char *ipc_username = NULL;
+       char *ipc_domain = NULL;
+       char *ipc_password = NULL;
 
-       bool got_mutex;
+       struct named_mutex *mutex;
 
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
 
@@ -659,29 +759,11 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
        DEBUG(10,("cm_prepare_connection: connecting to DC %s for domain %s\n",
                controller, domain->name ));
 
-       machine_password = secrets_fetch_machine_password(lp_workgroup(), NULL,
-                                                         NULL);
-       
-       if (asprintf(&machine_account, "%s$", global_myname()) == -1) {
-               SAFE_FREE(machine_password);
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       if (asprintf(&machine_krb5_principal, "%s$@%s", global_myname(),
-                    lp_realm()) == -1) {
-               SAFE_FREE(machine_account);
-               SAFE_FREE(machine_password);
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       cm_get_ipc_userpass(&ipc_username, &ipc_domain, &ipc_password);
-
        *retry = True;
 
-       got_mutex = secrets_named_mutex(controller,
-                                       WINBIND_SERVER_MUTEX_WAIT_TIME);
-
-       if (!got_mutex) {
+       mutex = grab_named_mutex(talloc_tos(), controller,
+                                WINBIND_SERVER_MUTEX_WAIT_TIME);
+       if (mutex == NULL) {
                DEBUG(0,("cm_prepare_connection: mutex grab failed for %s\n",
                         controller));
                result = NT_STATUS_POSSIBLE_DEADLOCK;
@@ -732,10 +814,20 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                result = NT_STATUS_UNSUCCESSFUL;
                goto done;
        }
-                       
-       if ((*cli)->protocol >= PROTOCOL_NT1 && (*cli)->capabilities & CAP_EXTENDED_SECURITY) {
+
+       if (!is_trusted_domain_situation(domain->name) &&
+           (*cli)->protocol >= PROTOCOL_NT1 &&
+           (*cli)->capabilities & CAP_EXTENDED_SECURITY)
+       {
                ADS_STATUS ads_status;
 
+               result = get_trust_creds(domain, &machine_password,
+                                        &machine_account,
+                                        &machine_krb5_principal);
+               if (!NT_STATUS_IS_OK(result)) {
+                       goto done;
+               }
+
                if (lp_security() == SEC_ADS) {
 
                        /* Try a krb5 session */
@@ -750,7 +842,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                        ads_status = cli_session_setup_spnego(*cli,
                                                              machine_krb5_principal, 
                                                              machine_password, 
-                                                             lp_workgroup());
+                                                             domain->name);
 
                        if (!ADS_ERR_OK(ads_status)) {
                                DEBUG(4,("failed kerberos session setup with %s\n",
@@ -760,7 +852,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                        result = ads_ntstatus(ads_status);
                        if (NT_STATUS_IS_OK(result)) {
                                /* Ensure creds are stored for NTLMSSP authenticated pipe access. */
-                               cli_init_creds(*cli, machine_account, lp_workgroup(), machine_password);
+                               cli_init_creds(*cli, machine_account, domain->name, machine_password);
                                goto session_setup_done;
                        }
                }
@@ -770,12 +862,12 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
 
                DEBUG(5, ("connecting to %s from %s with username "
                          "[%s]\\[%s]\n",  controller, global_myname(),
-                         lp_workgroup(), machine_account));
+                         domain->name, machine_account));
 
                ads_status = cli_session_setup_spnego(*cli,
                                                      machine_account, 
                                                      machine_password, 
-                                                     lp_workgroup());
+                                                     domain->name);
                if (!ADS_ERR_OK(ads_status)) {
                        DEBUG(4, ("authenticated session setup failed with %s\n",
                                ads_errstr(ads_status)));
@@ -784,15 +876,17 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                result = ads_ntstatus(ads_status);
                if (NT_STATUS_IS_OK(result)) {
                        /* Ensure creds are stored for NTLMSSP authenticated pipe access. */
-                       cli_init_creds(*cli, machine_account, lp_workgroup(), machine_password);
+                       cli_init_creds(*cli, machine_account, domain->name, machine_password);
                        goto session_setup_done;
                }
        }
 
-       /* Fall back to non-kerberos session setup */
+       /* Fall back to non-kerberos session setup with auth_user */
 
        (*cli)->use_kerberos = False;
 
+       cm_get_ipc_userpass(&ipc_username, &ipc_domain, &ipc_password);
+
        if ((((*cli)->sec_mode & NEGOTIATE_SECURITY_CHALLENGE_RESPONSE) != 0) &&
            (strlen(ipc_username) > 0)) {
 
@@ -857,8 +951,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
                goto done;
        }
 
-       secrets_named_mutex_release(controller);
-       got_mutex = False;
+       TALLOC_FREE(mutex);
        *retry = False;
 
        /* set the domain if empty; needed for schannel connections */
@@ -869,10 +962,7 @@ static NTSTATUS cm_prepare_connection(const struct winbindd_domain *domain,
        result = NT_STATUS_OK;
 
  done:
-       if (got_mutex) {
-               secrets_named_mutex_release(controller);
-       }
-
+       TALLOC_FREE(mutex);
        SAFE_FREE(machine_account);
        SAFE_FREE(machine_password);
        SAFE_FREE(machine_krb5_principal);
@@ -923,6 +1013,8 @@ static bool add_sockaddr_to_array(TALLOC_CTX *mem_ctx,
        }
 
        (*addrs)[*num] = *pss;
+       set_sockaddr_port(&(*addrs)[*num], port);
+
        *num += 1;
        return True;
 }
@@ -941,6 +1033,7 @@ static bool send_getdc_request(struct sockaddr_storage *dc_ss,
        char *p;
        fstring my_acct_name;
        fstring my_mailslot;
+       size_t sid_size;
 
        if (dc_ss->ss_family != AF_INET) {
                return false;
@@ -982,7 +1075,9 @@ static bool send_getdc_request(struct sockaddr_storage *dc_ss,
        SIVAL(p, 0, 0x80);
        p+=4;
 
-       SIVAL(p, 0, sid_size(sid));
+       sid_size = ndr_size_dom_sid(sid, 0);
+
+       SIVAL(p, 0, sid_size);
        p+=4;
 
        p = ALIGN4(p, outbuf);
@@ -990,12 +1085,12 @@ static bool send_getdc_request(struct sockaddr_storage *dc_ss,
                return false;
        }
 
-       sid_linearize(p, sid_size(sid), sid);
-       if (sid_size(sid) + 8 > sizeof(outbuf) - PTR_DIFF(p, outbuf)) {
+       if (sid_size + 8 > sizeof(outbuf) - PTR_DIFF(p, outbuf)) {
                return false;
        }
+       sid_linearize(p, sizeof(outbuf) - PTR_DIFF(p, outbuf), sid);
 
-       p += sid_size(sid);
+       p += sid_size;
 
        SIVAL(p, 0, 1);
        SSVAL(p, 4, 0xffff);
@@ -1179,7 +1274,7 @@ static bool dcip_to_name(const struct winbindd_domain *domain,
  the dcs[]  with results.
 *******************************************************************/
 
-static bool get_dcs(TALLOC_CTX *mem_ctx, const struct winbindd_domain *domain,
+static bool get_dcs(TALLOC_CTX *mem_ctx, struct winbindd_domain *domain,
                    struct dc_name_ip **dcs, int *num_dcs)
 {
        fstring dcname;
@@ -1282,7 +1377,7 @@ static bool get_dcs(TALLOC_CTX *mem_ctx, const struct winbindd_domain *domain,
 }
 
 static bool find_new_dc(TALLOC_CTX *mem_ctx,
-                       const struct winbindd_domain *domain,
+                       struct winbindd_domain *domain,
                        fstring dcname, struct sockaddr_storage *pss, int *fd)
 {
        struct dc_name_ip *dcs = NULL;
@@ -1623,12 +1718,11 @@ static bool set_dc_type_and_flags_trustinfo( struct winbindd_domain *domain )
 {
        struct winbindd_domain *our_domain;
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
-       struct ds_domain_trust *domains = NULL;
-       int count = 0;
+       struct netr_DomainTrustList trusts;
        int i;
-       uint32 flags = (DS_DOMAIN_IN_FOREST | 
-                       DS_DOMAIN_DIRECT_OUTBOUND | 
-                       DS_DOMAIN_DIRECT_INBOUND);
+       uint32 flags = (NETR_TRUST_FLAG_IN_FOREST |
+                       NETR_TRUST_FLAG_OUTBOUND |
+                       NETR_TRUST_FLAG_INBOUND);
        struct rpc_pipe_client *cli;
        TALLOC_CTX *mem_ctx = NULL;
 
@@ -1670,27 +1764,35 @@ static bool set_dc_type_and_flags_trustinfo( struct winbindd_domain *domain )
                return False;
        }       
 
-       result = rpccli_ds_enum_domain_trusts(cli, mem_ctx,
-                                             cli->cli->desthost, 
-                                             flags, &domains,
-                                             (unsigned int *)&count);
+       result = rpccli_netr_DsrEnumerateDomainTrusts(cli, mem_ctx,
+                                                     cli->cli->desthost,
+                                                     flags,
+                                                     &trusts,
+                                                     NULL);
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(0,("set_dc_type_and_flags_trustinfo: "
+                       "failed to query trusted domain list: %s\n",
+                       nt_errstr(result)));
+               talloc_destroy(mem_ctx);
+               return false;
+       }
 
        /* Now find the domain name and get the flags */
 
-       for ( i=0; i<count; i++ ) {
-               if ( strequal( domain->name, domains[i].netbios_domain ) ) {                    
-                       domain->domain_flags          = domains[i].flags;
-                       domain->domain_type           = domains[i].trust_type;
-                       domain->domain_trust_attribs  = domains[i].trust_attributes;
-                                               
-                       if ( domain->domain_type == DS_DOMAIN_TRUST_TYPE_UPLEVEL )
+       for ( i=0; i<trusts.count; i++ ) {
+               if ( strequal( domain->name, trusts.array[i].netbios_name) ) {
+                       domain->domain_flags          = trusts.array[i].trust_flags;
+                       domain->domain_type           = trusts.array[i].trust_type;
+                       domain->domain_trust_attribs  = trusts.array[i].trust_attributes;
+
+                       if ( domain->domain_type == NETR_TRUST_TYPE_UPLEVEL )
                                domain->active_directory = True;
 
                        /* This flag is only set if the domain is *our* 
                           primary domain and the primary domain is in
                           native mode */
 
-                       domain->native_mode = (domain->domain_flags & DS_DOMAIN_NATIVE_MODE);
+                       domain->native_mode = (domain->domain_flags & NETR_TRUST_FLAG_NATIVE);
 
                        DEBUG(5, ("set_dc_type_and_flags_trustinfo: domain %s is %sin "
                                  "native mode.\n", domain->name, 
@@ -1726,42 +1828,45 @@ static bool set_dc_type_and_flags_trustinfo( struct winbindd_domain *domain )
 static void set_dc_type_and_flags_connect( struct winbindd_domain *domain )
 {
        NTSTATUS                result;
-       DS_DOMINFO_CTR          ctr;
+       WERROR werr;
        TALLOC_CTX              *mem_ctx = NULL;
        struct rpc_pipe_client  *cli;
        POLICY_HND pol;
+       union dssetup_DsRoleInfo info;
+       union lsa_PolicyInformation *lsa_info = NULL;
 
-       char *domain_name = NULL;
-       char *dns_name = NULL;
-       char *forest_name = NULL;       
-       DOM_SID *dom_sid = NULL;        
-
-       ZERO_STRUCT( ctr );
-       
        if (!connection_ok(domain)) {
                return;
        }
 
+       mem_ctx = talloc_init("set_dc_type_and_flags on domain %s\n",
+                             domain->name);
+       if (!mem_ctx) {
+               DEBUG(1, ("set_dc_type_and_flags_connect: talloc_init() failed\n"));
+               return;
+       }
+
        DEBUG(5, ("set_dc_type_and_flags_connect: domain %s\n", domain->name ));
 
-       cli = cli_rpc_pipe_open_noauth(domain->conn.cli, PI_LSARPC_DS,
+       cli = cli_rpc_pipe_open_noauth(domain->conn.cli, PI_DSSETUP,
                                       &result);
 
        if (cli == NULL) {
                DEBUG(5, ("set_dc_type_and_flags_connect: Could not bind to "
-                         "PI_LSARPC_DS on domain %s: (%s)\n",
+                         "PI_DSSETUP on domain %s: (%s)\n",
                          domain->name, nt_errstr(result)));
 
                /* if this is just a non-AD domain we need to continue
                 * identifying so that we can in the end return with
                 * domain->initialized = True - gd */
 
-               goto no_lsarpc_ds;
+               goto no_dssetup;
        }
 
-       result = rpccli_ds_getprimarydominfo(cli, cli->cli->mem_ctx,
-                                            DsRolePrimaryDomainInfoBasic,
-                                            &ctr);
+       result = rpccli_dssetup_DsRoleGetPrimaryDomainInformation(cli, mem_ctx,
+                                                                 DS_ROLE_BASIC_INFORMATION,
+                                                                 &info,
+                                                                 &werr);
        cli_rpc_pipe_close(cli);
 
        if (!NT_STATUS_IS_OK(result)) {
@@ -1770,25 +1875,26 @@ static void set_dc_type_and_flags_connect( struct winbindd_domain *domain )
                          domain->name, nt_errstr(result)));
 
                /* older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for
-                * every opcode on the LSARPC_DS pipe, continue with
-                * no_lsarpc_ds mode here as well to get domain->initialized
+                * every opcode on the DSSETUP pipe, continue with
+                * no_dssetup mode here as well to get domain->initialized
                 * set - gd */
 
                if (NT_STATUS_V(result) == DCERPC_FAULT_OP_RNG_ERROR) {
-                       goto no_lsarpc_ds;
+                       goto no_dssetup;
                }
 
+               TALLOC_FREE(mem_ctx);
                return;
        }
-       
-       if ((ctr.basic->flags & DSROLE_PRIMARY_DS_RUNNING) &&
-           !(ctr.basic->flags & DSROLE_PRIMARY_DS_MIXED_MODE)) {
+
+       if ((info.basic.flags & DS_ROLE_PRIMARY_DS_RUNNING) &&
+           !(info.basic.flags & DS_ROLE_PRIMARY_DS_MIXED_MODE)) {
                domain->native_mode = True;
        } else {
                domain->native_mode = False;
        }
 
-no_lsarpc_ds:
+no_dssetup:
        cli = cli_rpc_pipe_open_noauth(domain->conn.cli, PI_LSARPC, &result);
 
        if (cli == NULL) {
@@ -1796,14 +1902,7 @@ no_lsarpc_ds:
                          "PI_LSARPC on domain %s: (%s)\n",
                          domain->name, nt_errstr(result)));
                cli_rpc_pipe_close(cli);
-               return;
-       }
-
-       mem_ctx = talloc_init("set_dc_type_and_flags on domain %s\n",
-                             domain->name);
-       if (!mem_ctx) {
-               DEBUG(1, ("set_dc_type_and_flags_connect: talloc_init() failed\n"));
-               cli_rpc_pipe_close(cli);
+               TALLOC_FREE(mem_ctx);
                return;
        }
 
@@ -1813,46 +1912,65 @@ no_lsarpc_ds:
        if (NT_STATUS_IS_OK(result)) {
                /* This particular query is exactly what Win2k clients use 
                   to determine that the DC is active directory */
-               result = rpccli_lsa_query_info_policy2(cli, mem_ctx, &pol,
-                                                      12, &domain_name,
-                                                      &dns_name, &forest_name,
-                                                      NULL, &dom_sid);
+               result = rpccli_lsa_QueryInfoPolicy2(cli, mem_ctx,
+                                                    &pol,
+                                                    LSA_POLICY_INFO_DNS,
+                                                    &lsa_info);
        }
 
        if (NT_STATUS_IS_OK(result)) {
                domain->active_directory = True;
 
-               if (domain_name)
-                       fstrcpy(domain->name, domain_name);
+               if (lsa_info->dns.name.string) {
+                       fstrcpy(domain->name, lsa_info->dns.name.string);
+               }
 
-               if (dns_name)
-                       fstrcpy(domain->alt_name, dns_name);
+               if (lsa_info->dns.dns_domain.string) {
+                       fstrcpy(domain->alt_name,
+                               lsa_info->dns.dns_domain.string);
+               }
 
-               if ( forest_name )
-                       fstrcpy(domain->forest_name, forest_name);              
+               /* See if we can set some domain trust flags about
+                  ourself */
+
+               if (lsa_info->dns.dns_forest.string) {
+                       fstrcpy(domain->forest_name,
+                               lsa_info->dns.dns_forest.string);
+
+                       if (strequal(domain->forest_name, domain->alt_name)) {
+                               domain->domain_flags |= NETR_TRUST_FLAG_TREEROOT;
+                       }
+               }
 
-               if (dom_sid) 
-                       sid_copy(&domain->sid, dom_sid);
+               if (lsa_info->dns.sid) {
+                       sid_copy(&domain->sid, lsa_info->dns.sid);
+               }
        } else {
                domain->active_directory = False;
 
                result = rpccli_lsa_open_policy(cli, mem_ctx, True, 
                                                SEC_RIGHTS_MAXIMUM_ALLOWED,
                                                &pol);
-                       
-               if (!NT_STATUS_IS_OK(result))
+
+               if (!NT_STATUS_IS_OK(result)) {
                        goto done;
-                       
-               result = rpccli_lsa_query_info_policy(cli, mem_ctx, 
-                                                     &pol, 5, &domain_name, 
-                                                     &dom_sid);
-                       
+               }
+
+               result = rpccli_lsa_QueryInfoPolicy(cli, mem_ctx,
+                                                   &pol,
+                                                   LSA_POLICY_INFO_ACCOUNT_DOMAIN,
+                                                   &lsa_info);
+
                if (NT_STATUS_IS_OK(result)) {
-                       if (domain_name)
-                               fstrcpy(domain->name, domain_name);
 
-                       if (dom_sid) 
-                               sid_copy(&domain->sid, dom_sid);
+                       if (lsa_info->account_domain.name.string) {
+                               fstrcpy(domain->name,
+                                       lsa_info->account_domain.name.string);
+                       }
+
+                       if (lsa_info->account_domain.sid) {
+                               sid_copy(&domain->sid, lsa_info->account_domain.sid);
+                       }
                }
        }
 done:
@@ -1864,8 +1982,8 @@ done:
                  domain->name, domain->active_directory ? "" : "NOT "));
 
        cli_rpc_pipe_close(cli);
-       
-       talloc_destroy(mem_ctx);
+
+       TALLOC_FREE(mem_ctx);
 
        domain->initialized = True;
 }
@@ -1930,6 +2048,9 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
        NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
        fstring conn_pwd;
        struct dcinfo *p_dcinfo;
+       char *machine_password = NULL;
+       char *machine_account = NULL;
+       char *domain_name = NULL;
 
        result = init_dc_connection(domain);
        if (!NT_STATUS_IS_OK(result)) {
@@ -1952,10 +2073,25 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
        pwd_get_cleartext(&conn->cli->pwd, conn_pwd);
        if ((conn->cli->user_name[0] == '\0') ||
            (conn->cli->domain[0] == '\0') || 
-           (conn_pwd[0] == '\0')) {
-               DEBUG(10, ("cm_connect_sam: No no user available for "
-                          "domain %s, trying schannel\n", conn->cli->domain));
-               goto schannel;
+           (conn_pwd[0] == '\0'))
+       {
+               result = get_trust_creds(domain, &machine_password,
+                                        &machine_account, NULL);
+               if (!NT_STATUS_IS_OK(result)) {
+                       DEBUG(10, ("cm_connect_sam: No no user available for "
+                                  "domain %s, trying schannel\n", conn->cli->domain));
+                       goto schannel;
+               }
+               domain_name = domain->name;
+       } else {
+               machine_password = SMB_STRDUP(conn_pwd);                
+               machine_account = SMB_STRDUP(conn->cli->user_name);
+               domain_name = conn->cli->domain;
+       }
+
+       if (!machine_password || !machine_account) {
+               result = NT_STATUS_NO_MEMORY;
+               goto done;
        }
 
        /* We have an authenticated connection. Use a NTLMSSP SPNEGO
@@ -1963,31 +2099,32 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
        conn->samr_pipe =
                cli_rpc_pipe_open_spnego_ntlmssp(conn->cli, PI_SAMR,
                                                 PIPE_AUTH_LEVEL_PRIVACY,
-                                                conn->cli->domain,
-                                                conn->cli->user_name,
-                                                conn_pwd, &result);
+                                                domain_name,
+                                                machine_account,
+                                                machine_password, &result);
 
        if (conn->samr_pipe == NULL) {
                DEBUG(10,("cm_connect_sam: failed to connect to SAMR "
                          "pipe for domain %s using NTLMSSP "
                          "authenticated pipe: user %s\\%s. Error was "
-                         "%s\n", domain->name, conn->cli->domain,
-                         conn->cli->user_name, nt_errstr(result)));
+                         "%s\n", domain->name, domain_name,
+                         machine_account, nt_errstr(result)));
                goto schannel;
        }
 
        DEBUG(10,("cm_connect_sam: connected to SAMR pipe for "
                  "domain %s using NTLMSSP authenticated "
                  "pipe: user %s\\%s\n", domain->name,
-                 conn->cli->domain, conn->cli->user_name ));
+                 domain_name, machine_account));
 
-       result = rpccli_samr_connect(conn->samr_pipe, mem_ctx,
-                                    SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                    &conn->sam_connect_handle);
+       result = rpccli_samr_Connect2(conn->samr_pipe, mem_ctx,
+                                     conn->samr_pipe->cli->desthost,
+                                     SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                     &conn->sam_connect_handle);
        if (NT_STATUS_IS_OK(result)) {
                goto open_domain;
        }
-       DEBUG(10,("cm_connect_sam: ntlmssp-sealed rpccli_samr_connect "
+       DEBUG(10,("cm_connect_sam: ntlmssp-sealed rpccli_samr_Connect2 "
                  "failed for domain %s, error was %s. Trying schannel\n",
                  domain->name, nt_errstr(result) ));
        cli_rpc_pipe_close(conn->samr_pipe);
@@ -2015,13 +2152,14 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
        DEBUG(10,("cm_connect_sam: connected to SAMR pipe for domain %s using "
                  "schannel.\n", domain->name ));
 
-       result = rpccli_samr_connect(conn->samr_pipe, mem_ctx,
-                                    SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                    &conn->sam_connect_handle);
+       result = rpccli_samr_Connect2(conn->samr_pipe, mem_ctx,
+                                     conn->samr_pipe->cli->desthost,
+                                     SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                     &conn->sam_connect_handle);
        if (NT_STATUS_IS_OK(result)) {
                goto open_domain;
        }
-       DEBUG(10,("cm_connect_sam: schannel-sealed rpccli_samr_connect failed "
+       DEBUG(10,("cm_connect_sam: schannel-sealed rpccli_samr_Connect2 failed "
                  "for domain %s, error was %s. Trying anonymous\n",
                  domain->name, nt_errstr(result) ));
        cli_rpc_pipe_close(conn->samr_pipe);
@@ -2037,23 +2175,24 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
                goto done;
        }
 
-       result = rpccli_samr_connect(conn->samr_pipe, mem_ctx,
-                                    SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                    &conn->sam_connect_handle);
+       result = rpccli_samr_Connect2(conn->samr_pipe, mem_ctx,
+                                     conn->samr_pipe->cli->desthost,
+                                     SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                     &conn->sam_connect_handle);
        if (!NT_STATUS_IS_OK(result)) {
-               DEBUG(10,("cm_connect_sam: rpccli_samr_connect failed "
+               DEBUG(10,("cm_connect_sam: rpccli_samr_Connect2 failed "
                          "for domain %s Error was %s\n",
                          domain->name, nt_errstr(result) ));
                goto done;
        }
 
  open_domain:
-       result = rpccli_samr_open_domain(conn->samr_pipe,
-                                        mem_ctx,
-                                        &conn->sam_connect_handle,
-                                        SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                        &domain->sid,
-                                        &conn->sam_domain_handle);
+       result = rpccli_samr_OpenDomain(conn->samr_pipe,
+                                       mem_ctx,
+                                       &conn->sam_connect_handle,
+                                       SEC_RIGHTS_MAXIMUM_ALLOWED,
+                                       &domain->sid,
+                                       &conn->sam_domain_handle);
 
  done:
 
@@ -2064,6 +2203,8 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
 
        *cli = conn->samr_pipe;
        *sam_handle = conn->sam_domain_handle;
+       SAFE_FREE(machine_password);
+       SAFE_FREE(machine_account);
        return result;
 }
 
@@ -2207,6 +2348,10 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                return result;
        }
 
+       if (domain->active_directory) {
+               neg_flags = NETLOGON_NEG_AUTH2_ADS_FLAGS;
+       }
+
        conn = &domain->conn;
 
        if (conn->netlogon_pipe != NULL) {
@@ -2214,10 +2359,6 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                return NT_STATUS_OK;
        }
 
-       if ((IS_DC || domain->primary) && !get_trust_pw(domain->name, mach_pwd, &sec_chan_type)) {
-               return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
-       }
-
        netlogon_pipe = cli_rpc_pipe_open_noauth(conn->cli, PI_NETLOGON,
                                                 &result);
        if (netlogon_pipe == NULL) {
@@ -2229,27 +2370,16 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                neg_flags &= ~NETLOGON_NEG_SCHANNEL;            
                goto no_schannel;
        }
-       
+
        if (lp_client_schannel() != False) {
                neg_flags |= NETLOGON_NEG_SCHANNEL;
        }
 
-       /* if we are a DC and this is a trusted domain, then we need to use our
-          domain name in the net_req_auth2() request */
-
-       if ( IS_DC
-               && !strequal(domain->name, lp_workgroup())
-               && lp_allow_trusted_domains() ) 
+       if (!get_trust_pw_hash(domain->name, mach_pwd, &account_name,
+                              &sec_chan_type))
        {
-               account_name = lp_workgroup();
-       } else {
-               account_name = domain->primary ?
-                       global_myname() : domain->name;
-       }
-
-       if (account_name == NULL) {
                cli_rpc_pipe_close(netlogon_pipe);
-               return NT_STATUS_NO_MEMORY;
+               return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
        }
 
        result = rpccli_netlogon_setup_creds(
@@ -2277,6 +2407,11 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
  no_schannel:
        if ((lp_client_schannel() == False) ||
                        ((neg_flags & NETLOGON_NEG_SCHANNEL) == 0)) {
+               /*
+                * NetSamLogonEx only works for schannel
+                */
+               domain->can_do_samlogon_ex = False;
+
                /* We're done - just keep the existing connection to NETLOGON
                 * open */
                conn->netlogon_pipe = netlogon_pipe;
@@ -2308,6 +2443,11 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                return !NT_STATUS_IS_OK(result) ? result : NT_STATUS_PIPE_NOT_AVAILABLE;
        }
 
+       /*
+        * Try NetSamLogonEx for AD domains
+        */
+       domain->can_do_samlogon_ex = domain->active_directory;
+
        *cli = conn->netlogon_pipe;
        return NT_STATUS_OK;
 }