r5176: Warn the user that print command is ignored when using cups libraries
[ira/wip.git] / source3 / utils / testparm.c
index 20f36fcffe4d34630bab639c75612b77d13bc0f9..dfd12c7a58e920f6320ec1ff100f207a422a0058 100644 (file)
@@ -1,10 +1,10 @@
 /* 
-   Unix SMB/Netbios implementation.
-   Version 1.9.
+   Unix SMB/CIFS implementation.
    Test validity of smb.conf
    Copyright (C) Karl Auer 1993, 1994-1998
 
    Extensively modified by Andrew Tridgell, 1995
+   Converted to popt by Jelmer Vernooij (jelmer@nl.linux.org), 2002
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
  */
 
 #include "includes.h"
-#include "smb.h"
 
-/* these live in util.c */
-extern FILE *dbf;
-extern int DEBUGLEVEL;
+extern BOOL AllowDebugChange;
 
 /***********************************************
  Here we do a set of 'hard coded' checks for bad
@@ -49,43 +46,59 @@ static int do_global_checks(void)
        int ret = 0;
        SMB_STRUCT_STAT st;
 
-       if (lp_security() == SEC_DOMAIN && !lp_encrypted_passwords()) {
-               printf("ERROR: in 'security=domain' mode the 'encrypt passwords' parameter must also be set to 'true'.\n");
+       if (lp_security() >= SEC_DOMAIN && !lp_encrypted_passwords()) {
+               fprintf(stderr, "ERROR: in 'security=domain' mode the 'encrypt passwords' parameter must always be set to 'true'.\n");
                ret = 1;
        }
 
-       if (lp_wins_support() && *lp_wins_server()) {
-               printf("ERROR: both 'wins support = true' and 'wins server = <server>' \
+       if (lp_wins_support() && lp_wins_server_list()) {
+               fprintf(stderr, "ERROR: both 'wins support = true' and 'wins server = <server list>' \
 cannot be set in the smb.conf file. nmbd will abort with this setting.\n");
                ret = 1;
        }
 
        if (!directory_exist(lp_lockdir(), &st)) {
-               printf("ERROR: lock directory %s does not exist\n",
+               fprintf(stderr, "ERROR: lock directory %s does not exist\n",
                       lp_lockdir());
                ret = 1;
        } else if ((st.st_mode & 0777) != 0755) {
-               printf("WARNING: lock directory %s should have permissions 0755 for browsing to work\n",
+               fprintf(stderr, "WARNING: lock directory %s should have permissions 0755 for browsing to work\n",
                       lp_lockdir());
                ret = 1;
        }
 
+       if (!directory_exist(lp_piddir(), &st)) {
+               fprintf(stderr, "ERROR: pid directory %s does not exist\n",
+                      lp_piddir());
+               ret = 1;
+       }
+
        /*
         * Password server sanity checks.
         */
 
-       if((lp_security() == SEC_SERVER || lp_security() == SEC_DOMAIN) && !lp_passwordserver()) {
+       if((lp_security() == SEC_SERVER || lp_security() >= SEC_DOMAIN) && !lp_passwordserver()) {
                pstring sec_setting;
                if(lp_security() == SEC_SERVER)
                        pstrcpy(sec_setting, "server");
                else if(lp_security() == SEC_DOMAIN)
                        pstrcpy(sec_setting, "domain");
 
-               printf("ERROR: The setting 'security=%s' requires the 'password server' parameter be set \
+               fprintf(stderr, "ERROR: The setting 'security=%s' requires the 'password server' parameter be set \
 to a valid password server.\n", sec_setting );
                ret = 1;
        }
 
+       
+       /*
+        * Check 'hosts equiv' and 'use rhosts' compatibility with 'hostname lookup' value.
+        */
+
+       if(*lp_hosts_equiv() && !lp_hostname_lookups()) {
+               fprintf(stderr, "ERROR: The setting 'hosts equiv = %s' requires that 'hostname lookups = yes'.\n", lp_hosts_equiv());
+               ret = 1;
+       }
+
        /*
         * Password chat sanity checks.
         */
@@ -93,34 +106,48 @@ to a valid password server.\n", sec_setting );
        if(lp_security() == SEC_USER && lp_unix_password_sync()) {
 
                /*
-                * Check that we have a valid lp_passwd_program().
+                * Check that we have a valid lp_passwd_program() if not using pam.
                 */
 
-               if(lp_passwd_program() == NULL) {
-                       printf("ERROR: the 'unix password sync' parameter is set and there is no valid 'passwd program' \
+#ifdef WITH_PAM
+               if (!lp_pam_password_change()) {
+#endif
+
+                       if(lp_passwd_program() == NULL) {
+                               fprintf( stderr, "ERROR: the 'unix password sync' parameter is set and there is no valid 'passwd program' \
 parameter.\n" );
-                       ret = 1;
-               } else {
-                       pstring passwd_prog;
-                       pstring truncated_prog;
-                       char *p;
-
-                       pstrcpy( passwd_prog, lp_passwd_program());
-                       p = passwd_prog;
-                       *truncated_prog = '\0';
-                       next_token(&p, truncated_prog, NULL, sizeof(pstring));
-
-                       if(access(truncated_prog, F_OK) == -1) {
-                               printf("ERROR: the 'unix password sync' parameter is set and the 'passwd program' (%s) \
-cannot be executed (error was %s).\n", truncated_prog, strerror(errno) );
                                ret = 1;
-                       }
+                       } else {
+                               pstring passwd_prog;
+                               pstring truncated_prog;
+                               const char *p;
+
+                               pstrcpy( passwd_prog, lp_passwd_program());
+                               p = passwd_prog;
+                               *truncated_prog = '\0';
+                               next_token(&p, truncated_prog, NULL, sizeof(pstring));
+
+                               if(access(truncated_prog, F_OK) == -1) {
+                                       fprintf(stderr, "ERROR: the 'unix password sync' parameter is set and the 'passwd program' (%s) \
+cannot be executed (error was %s).\n", truncated_prog, strerror(errno) );
+                                       ret = 1;
+                               }
+
+             }
+
+#ifdef WITH_PAM
                }
+#endif
 
                if(lp_passwd_chat() == NULL) {
-                       printf("ERROR: the 'unix password sync' parameter is set and there is no valid 'passwd chat' \
+                       fprintf(stderr, "ERROR: the 'unix password sync' parameter is set and there is no valid 'passwd chat' \
 parameter.\n");
                        ret = 1;
+               } else 
+               /* check if there's a %u parameter present */
+               if(strstr_m(lp_passwd_program(), "%u") == NULL) {
+                       fprintf(stderr, "ERROR: the 'passwd program' (%s) requires a '%%u' parameter.\n", lp_passwd_program());
+                       ret = 1;
                }
 
                /*
@@ -129,170 +156,226 @@ parameter.\n");
                 */
 
                if(lp_encrypted_passwords()) {
-                       if(strstr( lp_passwd_chat(), "%o")!=NULL) {
-                               printf("ERROR: the 'passwd chat' script [%s] expects to use the old plaintext password \
+                       if(strstr_m( lp_passwd_chat(), "%o")!=NULL) {
+                               fprintf(stderr, "ERROR: the 'passwd chat' script [%s] expects to use the old plaintext password \
 via the %%o substitution. With encrypted passwords this is not possible.\n", lp_passwd_chat() );
                                ret = 1;
                        }
                }
        }
 
+       if (strlen(lp_winbind_separator()) != 1) {
+               fprintf(stderr,"ERROR: the 'winbind separator' parameter must be a single character.\n");
+               ret = 1;
+       }
+
+       if (*lp_winbind_separator() == '+') {
+               fprintf(stderr,"'winbind separator = +' might cause problems with group membership.\n");
+       }
+
+       if (lp_algorithmic_rid_base() < BASE_RID) {
+               /* Try to prevent admin foot-shooting, we can't put algorithmic
+                  rids below 1000, that's the 'well known RIDs' on NT */
+               fprintf(stderr,"'algorithmic rid base' must be equal to or above %lu\n", BASE_RID);
+       }
+
+       if (lp_algorithmic_rid_base() & 1) {
+               fprintf(stderr,"'algorithmic rid base' must be even.\n");
+       }
+
+#ifndef HAVE_DLOPEN
+       if (lp_preload_modules()) {
+               fprintf(stderr,"WARNING: 'preload modules = ' set while loading plugins not supported.\n");
+       }
+#endif
+
+       if (!lp_passdb_backend()) {
+               fprintf(stderr,"ERROR: passdb backend must have a value or be left out\n");
+       }
+
        return ret;
 }   
 
-static void usage(char *pname)
+ int main(int argc, const char *argv[])
 {
-       printf("Usage: %s [-sh] [-L servername] [configfilename] [hostname hostIP]\n", pname);
-       printf("\t-s                  Suppress prompt for enter\n");
-       printf("\t-h                  Print usage\n");
-       printf("\t-L servername       Set %%L macro to servername\n");
-       printf("\t-t encoding         Print parameters with encoding\n");
-       printf("\tconfigfilename      Configuration file to test\n");
-       printf("\thostname hostIP.    Hostname and Host IP address to test\n");
-       printf("\t                    against \"host allow\" and \"host deny\"\n");
-       printf("\n");
-}
+       const char *config_file = dyn_CONFIGFILE;
+       int s;
+       static BOOL silent_mode = False;
+       int ret = 0;
+       poptContext pc;
+       static const char *term_code = "";
+       static char *new_local_machine = NULL;
+       const char *cname;
+       const char *caddr;
+       static int show_defaults;
+
+       struct poptOption long_options[] = {
+               POPT_AUTOHELP
+               {"suppress-prompt", 's', POPT_ARG_VAL, &silent_mode, 1, "Suppress prompt for enter"},
+               {"verbose", 'v', POPT_ARG_NONE, &show_defaults, 1, "Show default options too"},
+               {"server", 'L',POPT_ARG_STRING, &new_local_machine, 0, "Set %%L macro to servername\n"},
+               {"encoding", 't', POPT_ARG_STRING, &term_code, 0, "Print parameters with encoding"},
+               POPT_COMMON_VERSION
+               POPT_TABLEEND
+       };
+
+       pc = poptGetContext(NULL, argc, argv, long_options, 
+                           POPT_CONTEXT_KEEP_FIRST);
+       poptSetOtherOptionHelp(pc, "[OPTION...] <config-file> [host-name] [host-ip]");
+
+       while(poptGetNextOpt(pc) != -1);
+
+       setup_logging(poptGetArg(pc), True);
+
+       if (poptPeekArg(pc)) 
+               config_file = poptGetArg(pc);
+
+       cname = poptGetArg(pc);
+       caddr = poptGetArg(pc);
+
+       if ( cname && ! caddr ) {
+               printf ( "ERROR: You must specify both a machine name and an IP address.\n" );
+               return(1);
+       }
 
+       if (new_local_machine) {
+               set_local_machine_name(new_local_machine, True);
+       }
 
-int main(int argc, char *argv[])
-{
-  extern char *optarg;
-  extern int optind;
-  extern fstring local_machine;
-  pstring configfile;
-  int opt;
-  int s;
-  BOOL silent_mode = False;
-  int ret = 0;
-  pstring term_code;
-
-  *term_code = 0;
-
-  TimeInit();
-
-  setup_logging(argv[0],True);
-  
-  charset_initialise();
-
-  while ((opt = getopt(argc, argv,"shL:t:")) != EOF) {
-  switch (opt) {
-    case 's':
-      silent_mode = True;
-      break;
-    case 'L':
-      fstrcpy(local_machine,optarg);
-      break;
-    case 'h':
-      usage(argv[0]);
-      exit(0);
-      break;
-    case 't':
-      pstrcpy(term_code,optarg);
-      break;
-    default:
-      printf("Incorrect program usage\n");
-      usage(argv[0]);
-      exit(1);
-      break;
-    }
-  }
-
-  argc += (1 - optind);
-
-  if ((argc == 1) || (argc == 3))
-    pstrcpy(configfile,CONFIGFILE);
-  else if ((argc == 2) || (argc == 4))
-    pstrcpy(configfile,argv[optind]);
-
-  dbf = stdout;
-  DEBUGLEVEL = 2;
-
-  printf("Load smb config files from %s\n",configfile);
-
-  if (!lp_load(configfile,False,True,False)) {
-      printf("Error loading services.\n");
-      return(1);
-  }
-
-  printf("Loaded services file OK.\n");
-
-  ret = do_global_checks();
-
-  for (s=0;s<1000;s++) {
-    if (VALID_SNUM(s))
-      if (strlen(lp_servicename(s)) > 8) {
-        printf("WARNING: You have some share names that are longer than 8 chars\n");
-        printf("These may give errors while browsing or may not be accessible\nto some older clients\n");
-        break;
-      }
-  }
-
-  for (s=0;s<1000;s++) {
-    if (VALID_SNUM(s)) {
-      char *deny_list = lp_hostsdeny(s);
-      char *allow_list = lp_hostsallow(s);
-      if(deny_list) {
-        char *hasstar = strchr(deny_list, '*');
-        char *hasquery = strchr(deny_list, '?');
-        if(hasstar || hasquery) {
-          printf("Invalid character %c in hosts deny list %s for service %s.\n",
-                 hasstar ? *hasstar : *hasquery, deny_list, lp_servicename(s) );
-        }
-      }
-
-      if(allow_list) {
-        char *hasstar = strchr(allow_list, '*');
-        char *hasquery = strchr(allow_list, '?');
-        if(hasstar || hasquery) {
-          printf("Invalid character %c in hosts allow list %s for service %s.\n",
-                 hasstar ? *hasstar : *hasquery, allow_list, lp_servicename(s) );
-        }
-      }
-
-      if(lp_level2_oplocks(s) && !lp_oplocks(s)) {
-        printf("Invalid combination of parameters for service %s. \
-Level II oplocks can only be set if oplocks are also set.\n",
-               lp_servicename(s) );
-      }
-    }
-  }
-
-  if (*term_code)
-    interpret_coding_system(term_code);
-
-  if (argc < 3) {
-    if (!silent_mode) {
-      printf("Press enter to see a dump of your service definitions\n");
-      fflush(stdout);
-      getc(stdin);
-    }
-    lp_dump(stdout,True, lp_numservices(), _dos_to_unix);
-  }
-  
-  if (argc >= 3) {
-    char *cname;
-    char *caddr;
-      
-    if (argc == 3) {
-      cname = argv[optind];
-      caddr = argv[optind+1];
-    } else {
-      cname = argv[optind+1];
-      caddr = argv[optind+2];
-    }
-
-    /* this is totally ugly, a real `quick' hack */
-    for (s=0;s<1000;s++) {
-      if (VALID_SNUM(s)) {              
-        if (allow_access(lp_hostsdeny(s),lp_hostsallow(s),cname,caddr)) {
-          printf("Allow connection from %s (%s) to %s\n",
-                 cname,caddr,lp_servicename(s));
-        } else {
-          printf("Deny connection from %s (%s) to %s\n",
-                 cname,caddr,lp_servicename(s));
-        }
-      }
-    }
-  }
-  return(ret);
+       dbf = x_stderr;
+       DEBUGLEVEL = 2;
+       AllowDebugChange = False;
+
+       fprintf(stderr,"Load smb config files from %s\n",config_file);
+
+       if (!lp_load(config_file,False,True,False)) {
+               fprintf(stderr,"Error loading services.\n");
+               return(1);
+       }
+
+       fprintf(stderr,"Loaded services file OK.\n");
+
+       ret = do_global_checks();
+
+       for (s=0;s<1000;s++) {
+               if (VALID_SNUM(s))
+                       if (strlen(lp_servicename(s)) > 12) {
+                               fprintf(stderr, "WARNING: You have some share names that are longer than 12 characters.\n" );
+                               fprintf(stderr, "These may not be accessible to some older clients.\n" );
+                               fprintf(stderr, "(Eg. Windows9x, WindowsMe, and smbclient prior to Samba 3.0.)\n" );
+                               break;
+                       }
+       }
+
+       for (s=0;s<1000;s++) {
+               if (VALID_SNUM(s)) {
+                       const char **deny_list = lp_hostsdeny(s);
+                       const char **allow_list = lp_hostsallow(s);
+                       int i;
+                       if(deny_list) {
+                               for (i=0; deny_list[i]; i++) {
+                                       char *hasstar = strchr_m(deny_list[i], '*');
+                                       char *hasquery = strchr_m(deny_list[i], '?');
+                                       if(hasstar || hasquery) {
+                                               fprintf(stderr,"Invalid character %c in hosts deny list (%s) for service %s.\n",
+                                                          hasstar ? *hasstar : *hasquery, deny_list[i], lp_servicename(s) );
+                                       }
+                               }
+                       }
+
+                       if(allow_list) {
+                               for (i=0; allow_list[i]; i++) {
+                                       char *hasstar = strchr_m(allow_list[i], '*');
+                                       char *hasquery = strchr_m(allow_list[i], '?');
+                                       if(hasstar || hasquery) {
+                                               fprintf(stderr,"Invalid character %c in hosts allow list (%s) for service %s.\n",
+                                                          hasstar ? *hasstar : *hasquery, allow_list[i], lp_servicename(s) );
+                                       }
+                               }
+                       }
+
+                       if(lp_level2_oplocks(s) && !lp_oplocks(s)) {
+                               fprintf(stderr,"Invalid combination of parameters for service %s. \
+                                          Level II oplocks can only be set if oplocks are also set.\n",
+                                          lp_servicename(s) );
+                       }
+
+                       if (lp_map_hidden(s) && !(lp_create_mask(s) & S_IXOTH)) {
+                               fprintf(stderr,"Invalid combination of parameters for service %s. \
+                                          Map hidden can only work if create mask includes octal 01 (S_IXOTH).\n",
+                                          lp_servicename(s) );
+                       }
+                       if (lp_map_hidden(s) && (lp_force_create_mode(s) & S_IXOTH)) {
+                               fprintf(stderr,"Invalid combination of parameters for service %s. \
+                                          Map hidden can only work if force create mode excludes octal 01 (S_IXOTH).\n",
+                                          lp_servicename(s) );
+                       }
+                       if (lp_map_system(s) && !(lp_create_mask(s) & S_IXGRP)) {
+                               fprintf(stderr,"Invalid combination of parameters for service %s. \
+                                          Map system can only work if create mask includes octal 010 (S_IXGRP).\n",
+                                          lp_servicename(s) );
+                       }
+                       if (lp_map_system(s) && (lp_force_create_mode(s) & S_IXGRP)) {
+                               fprintf(stderr,"Invalid combination of parameters for service %s. \
+                                          Map system can only work if force create mode excludes octal 010 (S_IXGRP).\n",
+                                          lp_servicename(s) );
+                       }
+#ifdef HAVE_CUPS
+                       if (lp_printing(s) == PRINT_CUPS && *(lp_printcommand(s)) != '\0') {
+                                fprintf(stderr,"Warning: Service %s defines a print command, but \
+print command parameter is ignored when using CUPS libraries.\n",
+                                          lp_servicename(s) );
+                       }
+#endif
+               }
+       }
+
+
+       if (!silent_mode) {
+               fprintf(stderr,"Server role: ");
+               switch(lp_server_role()) {
+                       case ROLE_STANDALONE:
+                               fprintf(stderr,"ROLE_STANDALONE\n");
+                               break;
+                       case ROLE_DOMAIN_MEMBER:
+                               fprintf(stderr,"ROLE_DOMAIN_MEMBER\n");
+                               break;
+                       case ROLE_DOMAIN_BDC:
+                               fprintf(stderr,"ROLE_DOMAIN_BDC\n");
+                               break;
+                       case ROLE_DOMAIN_PDC:
+                               fprintf(stderr,"ROLE_DOMAIN_PDC\n");
+                               break;
+                       default:
+                               fprintf(stderr,"Unknown -- internal error?\n");
+                               break;
+               }
+       }
+
+       if (!cname) {
+               if (!silent_mode) {
+                       fprintf(stderr,"Press enter to see a dump of your service definitions\n");
+                       fflush(stdout);
+                       getc(stdin);
+               }
+               lp_dump(stdout, show_defaults, lp_numservices());
+       }
+
+       if(cname && caddr){
+               /* this is totally ugly, a real `quick' hack */
+               for (s=0;s<1000;s++) {
+                       if (VALID_SNUM(s)) {
+                               if (allow_access(lp_hostsdeny(-1), lp_hostsallow(-1), cname, caddr)
+                                   && allow_access(lp_hostsdeny(s), lp_hostsallow(s), cname, caddr)) {
+                                       fprintf(stderr,"Allow connection from %s (%s) to %s\n",
+                                                  cname,caddr,lp_servicename(s));
+                               } else {
+                                       fprintf(stderr,"Deny connection from %s (%s) to %s\n",
+                                                  cname,caddr,lp_servicename(s));
+                               }
+                       }
+               }
+       }
+       return(ret);
 }
+