net: Be more tolerant while joining.
[ira/wip.git] / source3 / utils / net_ads.c
index 37bdd4e45693b28a37eba3a386a0c7c99a212c0f..c8bfc2630cc8283870f92a90cf949b766f9f3784 100644 (file)
@@ -1,5 +1,5 @@
-/* 
-   Samba Unix/Linux SMB client library 
+/*
+   Samba Unix/Linux SMB client library
    net ads commands
    Copyright (C) 2001 Andrew Tridgell (tridge@samba.org)
    Copyright (C) 2001 Remus Koos (remuskoos@yahoo.com)
@@ -8,22 +8,23 @@
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.  
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 #include "utils/net.h"
 
+#include "libnet/libnet.h"
+
 #ifdef HAVE_ADS
 
 int net_ads_usage(int argc, const char **argv)
@@ -55,7 +56,10 @@ int net_ads_usage(int argc, const char **argv)
        d_printf("    Issue LDAP search queries using a general filter, by DN, or by SID\n");
        d_printf("keytab\n");
        d_printf("    Manage a local keytab file based on the machine account in AD\n");
-       
+       d_printf("dns\n");
+       d_printf("    Issue a dynamic DNS update request the server's hostname\n");
+       d_printf("    (using the machine credentials)\n");
+
        return -1;
 }
 
@@ -76,15 +80,18 @@ static const char *assume_own_realm(void)
 */
 static int net_ads_cldap_netlogon(ADS_STRUCT *ads)
 {
+       char addr[INET6_ADDRSTRLEN];
        struct cldap_netlogon_reply reply;
+       struct GUID tmp_guid;
 
-       if ( !ads_cldap_netlogon( inet_ntoa(ads->ldap_ip), ads->server.realm, &reply ) ) {
+       print_sockaddr(addr, sizeof(addr), &ads->ldap.ss);
+       if ( !ads_cldap_netlogon(addr, ads->server.realm, &reply ) ) {
                d_fprintf(stderr, "CLDAP query failed!\n");
                return -1;
        }
 
-       d_printf("Information for Domain Controller: %s\n\n", 
-               inet_ntoa(ads->ldap_ip));
+       d_printf("Information for Domain Controller: %s\n\n",
+               addr);
 
        d_printf("Response Type: ");
        switch (reply.type) {
@@ -98,8 +105,10 @@ static int net_ads_cldap_netlogon(ADS_STRUCT *ads)
                d_printf("0x%x\n", reply.type);
                break;
        }
-       d_printf("GUID: %s\n", 
-                smb_uuid_string_static(smb_uuid_unpack_static(reply.guid))); 
+
+       smb_uuid_unpack(reply.guid, &tmp_guid);
+       d_printf("GUID: %s\n", smb_uuid_string(talloc_tos(), tmp_guid));
+
        d_printf("Flags:\n"
                 "\tIs a PDC:                                   %s\n"
                 "\tIs a GC of the forest:                      %s\n"
@@ -132,8 +141,8 @@ static int net_ads_cldap_netlogon(ADS_STRUCT *ads)
        if (*reply.unk) printf("Unk:\t\t\t%s\n", reply.unk);
        if (*reply.user_name) printf("User name:\t%s\n", reply.user_name);
 
-       printf("Site Name:\t\t%s\n", reply.site_name);
-       printf("Site Name (2):\t\t%s\n", reply.site_name_2);
+       printf("Server Site Name :\t\t%s\n", reply.server_site_name);
+       printf("Client Site Name :\t\t%s\n", reply.client_site_name);
 
        d_printf("NT Version: %d\n", reply.version);
        d_printf("LMNT Token: %.2x\n", reply.lmnt_token);
@@ -142,7 +151,6 @@ static int net_ads_cldap_netlogon(ADS_STRUCT *ads)
        return 0;
 }
 
-
 /*
   this implements the CLDAP based netlogon lookup requests
   for finding the domain controller of a ADS domain
@@ -150,23 +158,15 @@ static int net_ads_cldap_netlogon(ADS_STRUCT *ads)
 static int net_ads_lookup(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
-       ADS_STATUS status;
-       const char *realm = assume_own_realm();
-
-       ads = ads_init(realm, opt_target_workgroup, opt_host);
-       if (ads) {
-               ads->auth.flags |= ADS_AUTH_NO_BIND;
-       }
 
-       status = ads_connect(ads);
-       if (!ADS_ERR_OK(status) || !ads) {
+       if (!ADS_ERR_OK(ads_startup_nobind(False, &ads))) {
                d_fprintf(stderr, "Didn't find the cldap server!\n");
                return -1;
        }
-       
+
        if (!ads->config.realm) {
                ads->config.realm = CONST_DISCARD(char *, opt_target_workgroup);
-               ads->ldap_port = 389;
+               ads->ldap.port = 389;
        }
 
        return net_ads_cldap_netlogon(ads);
@@ -177,14 +177,13 @@ static int net_ads_lookup(int argc, const char **argv)
 static int net_ads_info(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
-       const char *realm = assume_own_realm();
+       char addr[INET6_ADDRSTRLEN];
 
-       if ( (ads = ads_init(realm, opt_target_workgroup, opt_host)) != NULL ) {
-               ads->auth.flags |= ADS_AUTH_NO_BIND;
+       if (!ADS_ERR_OK(ads_startup_nobind(False, &ads))) {
+               d_fprintf(stderr, "Didn't find the ldap server!\n");
+               return -1;
        }
 
-       ads_connect(ads);
-
        if (!ads || !ads->config.realm) {
                d_fprintf(stderr, "Didn't find the ldap server!\n");
                return -1;
@@ -197,11 +196,13 @@ static int net_ads_info(int argc, const char **argv)
                d_fprintf( stderr, "Failed to get server's current time!\n");
        }
 
-       d_printf("LDAP server: %s\n", inet_ntoa(ads->ldap_ip));
+       print_sockaddr(addr, sizeof(addr), &ads->ldap.ss);
+
+       d_printf("LDAP server: %s\n", addr);
        d_printf("LDAP server name: %s\n", ads->config.ldap_server_name);
        d_printf("Realm: %s\n", ads->config.realm);
        d_printf("Bind Path: %s\n", ads->config.bind_path);
-       d_printf("LDAP port: %d\n", ads->ldap_port);
+       d_printf("LDAP port: %d\n", ads->ldap.port);
        d_printf("Server time: %s\n", http_timestring(ads->config.current_time));
 
        d_printf("KDC server: %s\n", ads->auth.kdc_server );
@@ -216,24 +217,30 @@ static void use_in_memory_ccache(void) {
        setenv(KRB5_ENV_CCNAME, "MEMORY:net_ads", 1);
 }
 
-static ADS_STRUCT *ads_startup(BOOL only_own_domain)
+static ADS_STATUS ads_startup_int(bool only_own_domain, uint32 auth_flags, ADS_STRUCT **ads_ret)
 {
-       ADS_STRUCT *ads;
+       ADS_STRUCT *ads = NULL;
        ADS_STATUS status;
-       BOOL need_password = False;
-       BOOL second_time = False;
+       bool need_password = False;
+       bool second_time = False;
        char *cp;
        const char *realm = NULL;
-       
-       /* lp_realm() should be handled by a command line param, 
+       bool tried_closest_dc = False;
+
+       /* lp_realm() should be handled by a command line param,
           However, the join requires that realm be set in smb.conf
           and compares our realm with the remote server's so this is
           ok until someone needs more flexibility */
 
+       *ads_ret = NULL;
+
+retry_connect:
        if (only_own_domain) {
                realm = lp_realm();
+       } else {
+               realm = assume_own_realm();
        }
-   
+
        ads = ads_init(realm, opt_target_workgroup, opt_host);
 
        if (!opt_user_name) {
@@ -246,46 +253,89 @@ static ADS_STRUCT *ads_startup(BOOL only_own_domain)
 
 retry:
        if (!opt_password && need_password && !opt_machine_pass) {
-               char *prompt;
-               asprintf(&prompt,"%s's password: ", opt_user_name);
-               opt_password = getpass(prompt);
-               free(prompt);
+               opt_password = net_prompt_pass(opt_user_name);
+               if (!opt_password) {
+                       ads_destroy(&ads);
+                       return ADS_ERROR(LDAP_NO_MEMORY);
+               }
        }
 
        if (opt_password) {
                use_in_memory_ccache();
+               SAFE_FREE(ads->auth.password);
                ads->auth.password = smb_xstrdup(opt_password);
        }
 
+       ads->auth.flags |= auth_flags;
+       SAFE_FREE(ads->auth.user_name);
        ads->auth.user_name = smb_xstrdup(opt_user_name);
 
        /*
-        * If the username is of the form "name@realm", 
+        * If the username is of the form "name@realm",
         * extract the realm and convert to upper case.
         * This is only used to establish the connection.
         */
        if ((cp = strchr_m(ads->auth.user_name, '@'))!=0) {
-               *cp++ = '\0';
-               ads->auth.realm = smb_xstrdup(cp);
-               strupper_m(ads->auth.realm);
+               *cp++ = '\0';
+               SAFE_FREE(ads->auth.realm);
+               ads->auth.realm = smb_xstrdup(cp);
+               strupper_m(ads->auth.realm);
        }
 
        status = ads_connect(ads);
 
        if (!ADS_ERR_OK(status)) {
-               if (!need_password && !second_time) {
+
+               if (NT_STATUS_EQUAL(ads_ntstatus(status),
+                                   NT_STATUS_NO_LOGON_SERVERS)) {
+                       DEBUG(0,("ads_connect: %s\n", ads_errstr(status)));
+                       ads_destroy(&ads);
+                       return status;
+               }
+
+               if (!need_password && !second_time && !(auth_flags & ADS_AUTH_NO_BIND)) {
                        need_password = True;
                        second_time = True;
                        goto retry;
                } else {
-                       d_printf("%s.\n", ads_errstr(status));
                        ads_destroy(&ads);
-                       return NULL;
+                       return status;
+               }
+       }
+
+       /* when contacting our own domain, make sure we use the closest DC.
+        * This is done by reconnecting to ADS because only the first call to
+        * ads_connect will give us our own sitename */
+
+       if ((only_own_domain || !opt_host) && !tried_closest_dc) {
+
+               tried_closest_dc = True; /* avoid loop */
+
+               if (!ads->config.tried_closest_dc) {
+
+                       namecache_delete(ads->server.realm, 0x1C);
+                       namecache_delete(ads->server.workgroup, 0x1C);
+
+                       ads_destroy(&ads);
+                       ads = NULL;
+
+                       goto retry_connect;
                }
        }
-       return ads;
+
+       *ads_ret = ads;
+       return status;
+}
+
+ADS_STATUS ads_startup(bool only_own_domain, ADS_STRUCT **ads)
+{
+       return ads_startup_int(only_own_domain, 0, ads);
 }
 
+ADS_STATUS ads_startup_nobind(bool only_own_domain, ADS_STRUCT **ads)
+{
+       return ads_startup_int(only_own_domain, ADS_AUTH_NO_BIND, ads);
+}
 
 /*
   Check to see if connection can be made via ads.
@@ -321,33 +371,28 @@ int net_ads_check(void)
 {
        return net_ads_check_int(NULL, opt_workgroup, opt_host);
 }
-/* 
+
+/*
    determine the netbios workgroup name for a domain
  */
 static int net_ads_workgroup(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
-       ADS_STATUS status;
-       const char *realm = assume_own_realm();
+       char addr[INET6_ADDRSTRLEN];
        struct cldap_netlogon_reply reply;
 
-       ads = ads_init(realm, opt_target_workgroup, opt_host);
-       if (ads) {
-               ads->auth.flags |= ADS_AUTH_NO_BIND;
-       }
-
-       status = ads_connect(ads);
-       if (!ADS_ERR_OK(status) || !ads) {
+       if (!ADS_ERR_OK(ads_startup_nobind(False, &ads))) {
                d_fprintf(stderr, "Didn't find the cldap server!\n");
                return -1;
        }
-       
+
        if (!ads->config.realm) {
                ads->config.realm = CONST_DISCARD(char *, opt_target_workgroup);
-               ads->ldap_port = 389;
+               ads->ldap.port = 389;
        }
-       
-       if ( !ads_cldap_netlogon( inet_ntoa(ads->ldap_ip), ads->server.realm, &reply ) ) {
+
+       print_sockaddr(addr, sizeof(addr), &ads->ldap.ss);
+       if ( !ads_cldap_netlogon(addr, ads->server.realm, &reply ) ) {
                d_fprintf(stderr, "CLDAP query failed!\n");
                return -1;
        }
@@ -355,13 +400,13 @@ static int net_ads_workgroup(int argc, const char **argv)
        d_printf("Workgroup: %s\n", reply.netbios_domain);
 
        ads_destroy(&ads);
-       
+
        return 0;
 }
 
 
 
-static BOOL usergrp_display(char *field, void **values, void *data_area)
+static bool usergrp_display(ADS_STRUCT *ads, char *field, void **values, void *data_area)
 {
        char **disp_fields = (char **) data_area;
 
@@ -369,7 +414,7 @@ static BOOL usergrp_display(char *field, void **values, void *data_area)
                if (disp_fields[0]) {
                        if (!strchr_m(disp_fields[0], '$')) {
                                if (disp_fields[1])
-                                       d_printf("%-21.21s %s\n", 
+                                       d_printf("%-21.21s %s\n",
                                               disp_fields[0], disp_fields[1]);
                                else
                                        d_printf("%s\n", disp_fields[0]);
@@ -392,19 +437,20 @@ static BOOL usergrp_display(char *field, void **values, void *data_area)
 static int net_ads_user_usage(int argc, const char **argv)
 {
        return net_help_user(argc, argv);
-} 
+}
 
 static int ads_user_add(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS status;
        char *upn, *userdn;
-       void *res=NULL;
+       LDAPMessage *res=NULL;
        int rc = -1;
+       char *ou_str = NULL;
 
        if (argc < 1) return net_ads_user_usage(argc, argv);
-       
-       if (!(ads = ads_startup(False))) {
+
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
@@ -414,17 +460,19 @@ static int ads_user_add(int argc, const char **argv)
                d_fprintf(stderr, "ads_user_add: %s\n", ads_errstr(status));
                goto done;
        }
-       
+
        if (ads_count_replies(ads, res)) {
                d_fprintf(stderr, "ads_user_add: User %s already exists\n", argv[0]);
                goto done;
        }
 
-       if (opt_container == NULL) {
-               opt_container = ads_default_ou_string(ads, WELL_KNOWN_GUID_USERS);
+       if (opt_container) {
+               ou_str = SMB_STRDUP(opt_container);
+       } else {
+               ou_str = ads_default_ou_string(ads, WELL_KNOWN_GUID_USERS);
        }
 
-       status = ads_add_user_acct(ads, argv[0], opt_container, opt_comment);
+       status = ads_add_user_acct(ads, argv[0], ou_str, opt_comment);
 
        if (!ADS_ERR_OK(status)) {
                d_fprintf(stderr, "Could not add user %s: %s\n", argv[0],
@@ -433,7 +481,7 @@ static int ads_user_add(int argc, const char **argv)
        }
 
        /* if no password is to be set, we're done */
-       if (argc == 1) { 
+       if (argc == 1) {
                d_printf("User %s added\n", argv[0]);
                rc = 0;
                goto done;
@@ -441,7 +489,7 @@ static int ads_user_add(int argc, const char **argv)
 
        /* try setting the password */
        asprintf(&upn, "%s@%s", argv[0], ads->config.realm);
-       status = ads_krb5_set_password(ads->auth.kdc_server, upn, argv[1], 
+       status = ads_krb5_set_password(ads->auth.kdc_server, upn, argv[1],
                                       ads->auth.time_offset);
        safe_free(upn);
        if (ADS_ERR_OK(status)) {
@@ -465,6 +513,7 @@ static int ads_user_add(int argc, const char **argv)
        if (res)
                ads_msgfree(ads, res);
        ads_destroy(&ads);
+       SAFE_FREE(ou_str);
        return rc;
 }
 
@@ -472,7 +521,7 @@ static int ads_user_info(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       void *res;
+       LDAPMessage *res;
        const char *attrs[] = {"memberOf", NULL};
        char *searchstring=NULL;
        char **grouplist;
@@ -489,7 +538,7 @@ static int ads_user_info(int argc, const char **argv)
                return -1;
        }
 
-       if (!(ads = ads_startup(False))) {
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                SAFE_FREE(escaped_user);
                return -1;
        }
@@ -504,8 +553,8 @@ static int ads_user_info(int argc, const char **argv)
                SAFE_FREE(escaped_user);
                return -1;
        }
-       
-       grouplist = ldap_get_values((LDAP *)ads->ld,
+
+       grouplist = ldap_get_values((LDAP *)ads->ldap.ld,
                                    (LDAPMessage *)res, "memberOf");
 
        if (grouplist) {
@@ -518,7 +567,7 @@ static int ads_user_info(int argc, const char **argv)
                }
                ldap_value_free(grouplist);
        }
-       
+
        ads_msgfree(ads, res);
        ads_destroy(&ads);
        SAFE_FREE(escaped_user);
@@ -529,20 +578,21 @@ static int ads_user_delete(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       void *res;
+       LDAPMessage *res = NULL;
        char *userdn;
 
        if (argc < 1) {
                return net_ads_user_usage(argc, argv);
        }
-       
-       if (!(ads = ads_startup(False))) {
+
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
        rc = ads_find_user_acct(ads, &res, argv[0]);
-       if (!ADS_ERR_OK(rc)) {
+       if (!ADS_ERR_OK(rc) || ads_count_replies(ads, res) != 1) {
                d_printf("User %s does not exist.\n", argv[0]);
+               ads_msgfree(ads, res);
                ads_destroy(&ads);
                return -1;
        }
@@ -550,12 +600,12 @@ static int ads_user_delete(int argc, const char **argv)
        ads_msgfree(ads, res);
        rc = ads_del_dn(ads, userdn);
        ads_memfree(ads, userdn);
-       if (!ADS_ERR_OK(rc)) {
+       if (ADS_ERR_OK(rc)) {
                d_printf("User %s deleted\n", argv[0]);
                ads_destroy(&ads);
                return 0;
        }
-       d_fprintf(stderr, "Error deleting user %s: %s\n", argv[0], 
+       d_fprintf(stderr, "Error deleting user %s: %s\n", argv[0],
                 ads_errstr(rc));
        ads_destroy(&ads);
        return -1;
@@ -574,9 +624,9 @@ int net_ads_user(int argc, const char **argv)
        const char *shortattrs[] = {"sAMAccountName", NULL};
        const char *longattrs[] = {"sAMAccountName", "description", NULL};
        char *disp_fields[2] = {NULL, NULL};
-       
+
        if (argc == 0) {
-               if (!(ads = ads_startup(False))) {
+               if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                        return -1;
                }
 
@@ -584,11 +634,11 @@ int net_ads_user(int argc, const char **argv)
                        d_printf("\nUser name             Comment"\
                                 "\n-----------------------------\n");
 
-               rc = ads_do_search_all_fn(ads, ads->config.bind_path, 
+               rc = ads_do_search_all_fn(ads, ads->config.bind_path,
                                          LDAP_SCOPE_SUBTREE,
-                                         "(objectCategory=user)", 
+                                         "(objectCategory=user)",
                                          opt_long_list_entries ? longattrs :
-                                         shortattrs, usergrp_display, 
+                                         shortattrs, usergrp_display,
                                          disp_fields);
                ads_destroy(&ads);
                return ADS_ERR_OK(rc) ? 0 : -1;
@@ -600,20 +650,21 @@ int net_ads_user(int argc, const char **argv)
 static int net_ads_group_usage(int argc, const char **argv)
 {
        return net_help_group(argc, argv);
-} 
+}
 
 static int ads_group_add(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS status;
-       void *res=NULL;
+       LDAPMessage *res=NULL;
        int rc = -1;
+       char *ou_str = NULL;
 
        if (argc < 1) {
                return net_ads_group_usage(argc, argv);
        }
-       
-       if (!(ads = ads_startup(False))) {
+
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
@@ -623,18 +674,19 @@ static int ads_group_add(int argc, const char **argv)
                d_fprintf(stderr, "ads_group_add: %s\n", ads_errstr(status));
                goto done;
        }
-       
+
        if (ads_count_replies(ads, res)) {
                d_fprintf(stderr, "ads_group_add: Group %s already exists\n", argv[0]);
-               ads_msgfree(ads, res);
                goto done;
        }
 
-       if (opt_container == NULL) {
-               opt_container = ads_default_ou_string(ads, WELL_KNOWN_GUID_USERS);
+       if (opt_container) {
+               ou_str = SMB_STRDUP(opt_container);
+       } else {
+               ou_str = ads_default_ou_string(ads, WELL_KNOWN_GUID_USERS);
        }
 
-       status = ads_add_group_acct(ads, argv[0], opt_container, opt_comment);
+       status = ads_add_group_acct(ads, argv[0], ou_str, opt_comment);
 
        if (ADS_ERR_OK(status)) {
                d_printf("Group %s added\n", argv[0]);
@@ -648,6 +700,7 @@ static int ads_group_add(int argc, const char **argv)
        if (res)
                ads_msgfree(ads, res);
        ads_destroy(&ads);
+       SAFE_FREE(ou_str);
        return rc;
 }
 
@@ -655,20 +708,21 @@ static int ads_group_delete(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       void *res;
+       LDAPMessage *res = NULL;
        char *groupdn;
 
        if (argc < 1) {
                return net_ads_group_usage(argc, argv);
        }
-       
-       if (!(ads = ads_startup(False))) {
+
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
        rc = ads_find_user_acct(ads, &res, argv[0]);
-       if (!ADS_ERR_OK(rc)) {
+       if (!ADS_ERR_OK(rc) || ads_count_replies(ads, res) != 1) {
                d_printf("Group %s does not exist.\n", argv[0]);
+               ads_msgfree(ads, res);
                ads_destroy(&ads);
                return -1;
        }
@@ -676,12 +730,12 @@ static int ads_group_delete(int argc, const char **argv)
        ads_msgfree(ads, res);
        rc = ads_del_dn(ads, groupdn);
        ads_memfree(ads, groupdn);
-       if (!ADS_ERR_OK(rc)) {
+       if (ADS_ERR_OK(rc)) {
                d_printf("Group %s deleted\n", argv[0]);
                ads_destroy(&ads);
                return 0;
        }
-       d_fprintf(stderr, "Error deleting group %s: %s\n", argv[0], 
+       d_fprintf(stderr, "Error deleting group %s: %s\n", argv[0],
                 ads_errstr(rc));
        ads_destroy(&ads);
        return -1;
@@ -701,18 +755,18 @@ int net_ads_group(int argc, const char **argv)
        char *disp_fields[2] = {NULL, NULL};
 
        if (argc == 0) {
-               if (!(ads = ads_startup(False))) {
+               if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                        return -1;
                }
 
                if (opt_long_list_entries)
                        d_printf("\nGroup name            Comment"\
                                 "\n-----------------------------\n");
-               rc = ads_do_search_all_fn(ads, ads->config.bind_path, 
-                                         LDAP_SCOPE_SUBTREE, 
-                                         "(objectCategory=group)", 
-                                         opt_long_list_entries ? longattrs : 
-                                         shortattrs, usergrp_display, 
+               rc = ads_do_search_all_fn(ads, ads->config.bind_path,
+                                         LDAP_SCOPE_SUBTREE,
+                                         "(objectCategory=group)",
+                                         opt_long_list_entries ? longattrs :
+                                         shortattrs, usergrp_display,
                                          disp_fields);
 
                ads_destroy(&ads);
@@ -725,9 +779,9 @@ static int net_ads_status(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       void *res;
+       LDAPMessage *res;
 
-       if (!(ads = ads_startup(True))) {
+       if (!ADS_ERR_OK(ads_startup(True, &ads))) {
                return -1;
        }
 
@@ -755,16 +809,15 @@ static int net_ads_status(int argc, const char **argv)
  That only worked using the machine creds because added the machine
  with full control to the computer object's ACL.
 *******************************************************************/
+
 static int net_ads_leave(int argc, const char **argv)
 {
-       ADS_STRUCT *ads = NULL;
-       int ret = -1;
-       struct cli_state *cli = NULL;
        TALLOC_CTX *ctx;
-       DOM_SID *dom_sid = NULL;
+       struct libnet_UnjoinCtx *r = NULL;
+       WERROR werr;
 
-       if (!secrets_init()) {
-               DEBUG(1,("Failed to initialise secrets database\n"));
+       if (!*lp_realm()) {
+               d_fprintf(stderr, "No realm set, are we joined ?\n");
                return -1;
        }
 
@@ -773,65 +826,78 @@ static int net_ads_leave(int argc, const char **argv)
                return -1;
        }
 
-       /* The finds a DC and takes care of getting the 
-          user creds if necessary */
+       use_in_memory_ccache();
 
-       if (!(ads = ads_startup(True))) {
+       werr = libnet_init_UnjoinCtx(ctx, &r);
+       if (!W_ERROR_IS_OK(werr)) {
+               d_fprintf(stderr, "Could not initialise unjoin context.\n");
                return -1;
        }
 
-       /* make RPC calls here */
-
-       if ( !NT_STATUS_IS_OK(connect_to_ipc_krb5(&cli, &ads->ldap_ip, 
-               ads->config.ldap_server_name)) )
-       {
+       r->in.debug             = true;
+       r->in.dc_name           = opt_host;
+       r->in.domain_name       = lp_realm();
+       r->in.admin_account     = opt_user_name;
+       r->in.admin_password    = net_prompt_pass(opt_user_name);
+       r->in.modify_config     = lp_config_backend_is_registry();
+       r->in.unjoin_flags      = WKSSVC_JOIN_FLAGS_JOIN_TYPE |
+                                 WKSSVC_JOIN_FLAGS_ACCOUNT_DELETE;
+
+       werr = libnet_Unjoin(ctx, r);
+       if (!W_ERROR_IS_OK(werr)) {
+               d_printf("Failed to leave domain: %s\n",
+                        r->out.error_string ? r->out.error_string :
+                        get_friendly_werror_msg(werr));
                goto done;
        }
-       
-       saf_store( cli->server_domain, cli->desthost );
 
-       if ( !NT_STATUS_IS_OK(netdom_get_domain_sid( ctx, cli, &dom_sid )) ) {
+       if (W_ERROR_IS_OK(werr)) {
+               d_printf("Deleted account for '%s' in realm '%s'\n",
+                       r->in.machine_name, r->out.dns_domain_name);
                goto done;
        }
 
-       if ( !NT_STATUS_IS_OK(netdom_leave_domain( ctx, cli, dom_sid )) ) {
-               d_fprintf(stderr, "Failed to disable machine account for '%s' in realm '%s'\n",
-                       global_myname(), ads->config.realm);
+       /* We couldn't delete it - see if the disable succeeded. */
+       if (r->out.disabled_machine_account) {
+               d_printf("Disabled account for '%s' in realm '%s'\n",
+                       r->in.machine_name, r->out.dns_domain_name);
+               werr = WERR_OK;
                goto done;
        }
-       
-       d_printf("Disabled account for '%s' in realm '%s'\n", 
-               global_myname(), ads->config.realm);
-               
-       ret = 0;
 
-done:
-       if ( cli ) 
-               cli_shutdown(cli);
+       d_fprintf(stderr, "Failed to disable machine account for '%s' in realm '%s'\n",
+                 r->in.machine_name, r->out.dns_domain_name);
 
-       ads_destroy(&ads);
-       TALLOC_FREE( ctx );
+ done:
+       TALLOC_FREE(r);
+       TALLOC_FREE(ctx);
 
-       return ret;
+       if (W_ERROR_IS_OK(werr)) {
+               return 0;
+       }
+
+       return -1;
 }
 
-static int net_ads_join_ok(void)
+static NTSTATUS net_ads_join_ok(void)
 {
        ADS_STRUCT *ads = NULL;
+       ADS_STATUS status;
 
        if (!secrets_init()) {
                DEBUG(1,("Failed to initialise secrets database\n"));
-               return -1;
+               return NT_STATUS_ACCESS_DENIED;
        }
 
-       net_use_machine_password();
+       net_use_krb_machine_account();
 
-       if (!(ads = ads_startup(True))) {
-               return -1;
+       status = ads_startup(True, &ads);
+       if (!ADS_ERR_OK(status)) {
+               return ads_ntstatus(status);
        }
 
        ads_destroy(&ads);
-       return 0;
+       return NT_STATUS_OK;
 }
 
 /*
@@ -839,11 +905,14 @@ static int net_ads_join_ok(void)
  */
 int net_ads_testjoin(int argc, const char **argv)
 {
+       NTSTATUS status;
        use_in_memory_ccache();
 
        /* Display success or failure */
-       if (net_ads_join_ok() != 0) {
-               fprintf(stderr,"Join to domain is not valid\n");
+       status = net_ads_join_ok();
+       if (!NT_STATUS_IS_OK(status)) {
+               fprintf(stderr,"Join to domain is not valid: %s\n",
+                       get_friendly_nt_error_msg(status));
                return -1;
        }
 
@@ -855,302 +924,159 @@ int net_ads_testjoin(int argc, const char **argv)
   Simple configu checks before beginning the join
  ********************************************************************/
 
-static int check_ads_config( void )
+static WERROR check_ads_config( void )
 {
        if (lp_server_role() != ROLE_DOMAIN_MEMBER ) {
                d_printf("Host is not configured as a member server.\n");
-               return -1;
+               return WERR_INVALID_DOMAIN_ROLE;
        }
 
        if (strlen(global_myname()) > 15) {
                d_printf("Our netbios name can be at most 15 chars long, "
-                        "\"%s\" is %u chars long\n",
-                        global_myname(), (unsigned int)strlen(global_myname()));
-               return -1;
+                        "\"%s\" is %u chars long\n", global_myname(),
+                        (unsigned int)strlen(global_myname()));
+               return WERR_INVALID_COMPUTER_NAME;
        }
 
        if ( lp_security() == SEC_ADS && !*lp_realm()) {
-               d_fprintf(stderr, "realm must be set in in smb.conf for ADS "
-                       "join to succeed.\n");
-               return -1;
+               d_fprintf(stderr, "realm must be set in in %s for ADS "
+                       "join to succeed.\n", get_dyn_CONFIGFILE());
+               return WERR_INVALID_PARAM;
        }
 
-       if (!secrets_init()) {
-               DEBUG(1,("Failed to initialise secrets database\n"));
-               return -1;
-       }
-       
-       return 0;
+       return WERR_OK;
 }
 
 /*******************************************************************
- Do the domain join
- ********************************************************************/
-
-static int net_join_domain( TALLOC_CTX *ctx, const char *servername, 
-                            struct in_addr *ip, DOM_SID **dom_sid, const char *password )
-{
-       int ret = -1;
-       struct cli_state *cli = NULL;
-
-       if ( !NT_STATUS_IS_OK(connect_to_ipc_krb5(&cli, ip, servername)) )
-               goto done;
-       
-       saf_store( cli->server_domain, cli->desthost );
-
-       if ( !NT_STATUS_IS_OK(netdom_get_domain_sid( ctx, cli, dom_sid )) )
-               goto done;
+ Send a DNS update request
+*******************************************************************/
 
-       if ( !NT_STATUS_IS_OK(netdom_join_domain( ctx, cli, *dom_sid, 
-               password, ND_TYPE_AD )) )
-       {
+#if defined(WITH_DNS_UPDATES)
+#include "dns.h"
+DNS_ERROR DoDNSUpdate(char *pszServerName,
+                     const char *pszDomainName, const char *pszHostName,
+                     const struct sockaddr_storage *sslist,
+                     size_t num_addrs );
+
+static NTSTATUS net_update_dns_internal(TALLOC_CTX *ctx, ADS_STRUCT *ads,
+                                       const char *machine_name,
+                                       const struct sockaddr_storage *addrs,
+                                       int num_addrs)
+{
+       struct dns_rr_ns *nameservers = NULL;
+       int ns_count = 0;
+       NTSTATUS status = NT_STATUS_UNSUCCESSFUL;
+       DNS_ERROR dns_err;
+       fstring dns_server;
+       const char *dnsdomain = NULL;
+       char *root_domain = NULL;
+
+       if ( (dnsdomain = strchr_m( machine_name, '.')) == NULL ) {
+               d_printf("No DNS domain configured for %s. "
+                        "Unable to perform DNS Update.\n", machine_name);
+               status = NT_STATUS_INVALID_PARAMETER;
                goto done;
        }
-       
-       ret = 0;
-
-done:
-       if ( cli ) 
-               cli_shutdown(cli);
-
-       return ret;
-}
-
-/*******************************************************************
- Set a machines dNSHostName and servicePrincipalName attributes
- ********************************************************************/
+       dnsdomain++;
 
-static ADS_STATUS net_set_machine_spn(TALLOC_CTX *ctx, ADS_STRUCT *ads_s )
-{
-       ADS_STATUS status = ADS_ERROR(LDAP_SERVER_DOWN);
-       char *new_dn;
-       ADS_MODLIST mods;
-       const char *servicePrincipalName[3] = {NULL, NULL, NULL};
-       char *psp;
-       fstring my_fqdn;
-       LDAPMessage *res = NULL;
-       char *dn_string = NULL;
-       const char *machine_name = global_myname();
-       int count;
-       
-       if ( !machine_name ) {
-               return ADS_ERROR(LDAP_NO_MEMORY);
-       }
-       
-       /* Find our DN */
-       
-       status = ads_find_machine_acct(ads_s, (void **)(void *)&res, machine_name);
-       if (!ADS_ERR_OK(status)) 
-               return status;
-               
-       if ( (count = ads_count_replies(ads_s, res)) != 1 ) {
-               DEBUG(1,("net_set_machine_spn: %d entries returned!\n", count));
-               return ADS_ERROR(LDAP_NO_MEMORY);       
-       }
-       
-       if ( (dn_string = ads_get_dn(ads_s, res)) == NULL ) {
-               DEBUG(1, ("ads_add_machine_acct: ads_get_dn returned NULL (malloc failure?)\n"));
-               goto done;
-       }
-       
-       new_dn = talloc_strdup(ctx, dn_string);
-       ads_memfree(ads_s, dn_string);
-       if (!new_dn) {
-               return ADS_ERROR(LDAP_NO_MEMORY);
-       }
+       status = ads_dns_lookup_ns( ctx, dnsdomain, &nameservers, &ns_count );
+       if ( !NT_STATUS_IS_OK(status) || (ns_count == 0)) {
+               /* Child domains often do not have NS records.  Look
+                  for the NS record for the forest root domain
+                  (rootDomainNamingContext in therootDSE) */
 
-       /* Windows only creates HOST/shortname & HOST/fqdn. */
-          
-       if ( !(psp = talloc_asprintf(ctx, "HOST/%s", machine_name)) ) 
-               goto done;
-       strupper_m(psp);
-       servicePrincipalName[0] = psp;
+               const char *rootname_attrs[] =  { "rootDomainNamingContext", NULL };
+               LDAPMessage *msg = NULL;
+               char *root_dn;
+               ADS_STATUS ads_status;
 
-       name_to_fqdn(my_fqdn, machine_name);
-       strlower_m(my_fqdn);
-       if ( !(psp = talloc_asprintf(ctx, "HOST/%s", my_fqdn)) ) 
-               goto done;
-       servicePrincipalName[1] = psp;
-       
-       if (!(mods = ads_init_mods(ctx))) {
-               goto done;
-       }
-       
-       /* fields of primary importance */
-       
-       ads_mod_str(ctx, &mods, "dNSHostName", my_fqdn);
-       ads_mod_strlist(ctx, &mods, "servicePrincipalName", servicePrincipalName);
+               if ( !ads->ldap.ld ) {
+                       ads_status = ads_connect( ads );
+                       if ( !ADS_ERR_OK(ads_status) ) {
+                               DEBUG(0,("net_update_dns_internal: Failed to connect to our DC!\n"));
+                               goto done;
+                       }
+               }
 
-       status = ads_gen_mod(ads_s, new_dn, mods);
+               ads_status = ads_do_search(ads, "", LDAP_SCOPE_BASE,
+                                      "(objectclass=*)", rootname_attrs, &msg);
+               if (!ADS_ERR_OK(ads_status)) {
+                       goto done;
+               }
 
-done:
-       ads_msgfree(ads_s, res);
-       
-       return status;
-}
+               root_dn = ads_pull_string(ads, ctx, msg,  "rootDomainNamingContext");
+               if ( !root_dn ) {
+                       ads_msgfree( ads, msg );
+                       goto done;
+               }
 
-/*******************************************************************
- Set a machines dNSHostName and servicePrincipalName attributes
- ********************************************************************/
+               root_domain = ads_build_domain( root_dn );
 
-static ADS_STATUS net_set_machine_upn(TALLOC_CTX *ctx, ADS_STRUCT *ads_s, const char *upn )
-{
-       ADS_STATUS status = ADS_ERROR(LDAP_SERVER_DOWN);
-       char *new_dn;
-       ADS_MODLIST mods;
-       LDAPMessage *res = NULL;
-       char *dn_string = NULL;
-       const char *machine_name = global_myname();
-       int count;
-       
-       if ( !machine_name ) {
-               return ADS_ERROR(LDAP_NO_MEMORY);
-       }
-       
-       /* Find our DN */
-       
-       status = ads_find_machine_acct(ads_s, (void **)(void *)&res, machine_name);
-       if (!ADS_ERR_OK(status)) 
-               return status;
-               
-       if ( (count = ads_count_replies(ads_s, res)) != 1 ) {
-               DEBUG(1,("net_set_machine_spn: %d entries returned!\n", count));
-               return ADS_ERROR(LDAP_NO_MEMORY);       
-       }
-       
-       if ( (dn_string = ads_get_dn(ads_s, res)) == NULL ) {
-               DEBUG(1, ("ads_add_machine_acct: ads_get_dn returned NULL (malloc failure?)\n"));
-               goto done;
-       }
-       
-       new_dn = talloc_strdup(ctx, dn_string);
-       ads_memfree(ads_s, dn_string);
-       if (!new_dn) {
-               return ADS_ERROR(LDAP_NO_MEMORY);
-       }
-       
-       /* now do the mods */
-       
-       if (!(mods = ads_init_mods(ctx))) {
-               goto done;
-       }
-       
-       /* fields of primary importance */
-       
-       ads_mod_str(ctx, &mods, "userPrincipalName", upn);
+               /* cleanup */
+               ads_msgfree( ads, msg );
 
-       status = ads_gen_mod(ads_s, new_dn, mods);
+               /* try again for NS servers */
 
-done:
-       ads_msgfree(ads_s, res);
-       
-       return status;
-}
+               status = ads_dns_lookup_ns( ctx, root_domain, &nameservers, &ns_count );
 
-/*******************************************************************
-  join a domain using ADS (LDAP mods)
- ********************************************************************/
+               if ( !NT_STATUS_IS_OK(status) || (ns_count == 0)) {
+                       DEBUG(3,("net_ads_join: Failed to find name server for the %s "
+                        "realm\n", ads->config.realm));
+                       goto done;
+               }
 
-static ADS_STATUS net_precreate_machine_acct( ADS_STRUCT *ads, const char *ou )
-{
-       ADS_STATUS rc = ADS_ERROR(LDAP_SERVER_DOWN);
-       char *dn, *ou_str;
-       LDAPMessage *res = NULL;
+               dnsdomain = root_domain;
 
-       ou_str = ads_ou_string(ads, ou);
-       asprintf(&dn, "%s,%s", ou_str, ads->config.bind_path);
-       free(ou_str);
+       }
 
-       rc = ads_search_dn(ads, &res, dn, NULL);
-       ads_msgfree(ads, res);
+       /* Now perform the dns update - we'll try non-secure and if we fail,
+          we'll follow it up with a secure update */
 
-       if (ADS_ERR_OK(rc)) {
-               /* Attempt to create the machine account and bail if this fails.
-                  Assume that the admin wants exactly what they requested */
+       fstrcpy( dns_server, nameservers[0].hostname );
 
-               rc = ads_create_machine_acct( ads, global_myname(), dn );
-               if ( rc.error_type == ENUM_ADS_ERROR_LDAP && rc.err.rc == LDAP_ALREADY_EXISTS ) {
-                       rc = ADS_SUCCESS;
-               }
+       dns_err = DoDNSUpdate(dns_server, dnsdomain, machine_name, addrs, num_addrs);
+       if (!ERR_DNS_IS_OK(dns_err)) {
+               status = NT_STATUS_UNSUCCESSFUL;
        }
 
-       SAFE_FREE( dn );
+done:
 
-       return rc;
-}
+       SAFE_FREE( root_domain );
 
-/************************************************************************
- ************************************************************************/
+       return status;
+}
 
-static BOOL net_derive_salting_principal( TALLOC_CTX *ctx, ADS_STRUCT *ads )
+static NTSTATUS net_update_dns(TALLOC_CTX *mem_ctx, ADS_STRUCT *ads)
 {
-       uint32 domain_func;
-       ADS_STATUS status;
-       fstring salt;
-       char *std_salt;
-       LDAPMessage *res = NULL;
-       const char *machine_name = global_myname();
-
-       status = ads_domain_func_level( ads, &domain_func );
-       if ( !ADS_ERR_OK(status) ) {
-               DEBUG(2,("Failed to determine domain functional level!\n"));
-               return False;
-       }
+       int num_addrs;
+       struct sockaddr_storage *iplist = NULL;
+       fstring machine_name;
+       NTSTATUS status;
 
-       /* go ahead and setup the default salt */
+       name_to_fqdn( machine_name, global_myname() );
+       strlower_m( machine_name );
 
-       if ( (std_salt = kerberos_standard_des_salt()) == NULL ) {
-               d_fprintf(stderr, "net_derive_salting_principal: failed to obtain stanard DES salt\n");
-               return False;
-       }
+       /* Get our ip address (not the 127.0.0.x address but a real ip
+        * address) */
 
-       fstrcpy( salt, std_salt );
-       SAFE_FREE( std_salt );
-       
-       /* if it's a Windows functional domain, we have to look for the UPN */
-          
-       if ( domain_func == DS_DOMAIN_FUNCTION_2000 ) { 
-               char *upn;
-               int count;
-               
-               status = ads_find_machine_acct(ads, (void **)(void *)&res, machine_name);
-               if (!ADS_ERR_OK(status)) {
-                       return False;
-               }
-               
-               if ( (count = ads_count_replies(ads, res)) != 1 ) {
-                       DEBUG(1,("net_set_machine_spn: %d entries returned!\n", count));
-                       return False;
-               }
-               
-               upn = ads_pull_string(ads, ctx, res, "userPrincipalName");
-               if ( upn ) {
-                       fstrcpy( salt, upn );
-               }
-               
-               ads_msgfree(ads, res);
+       num_addrs = get_my_ip_address( &iplist );
+       if ( num_addrs <= 0 ) {
+               DEBUG(4,("net_update_dns: Failed to find my non-loopback IP "
+                        "addresses!\n"));
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
-       return kerberos_secrets_store_des_salt( salt );
+       status = net_update_dns_internal(mem_ctx, ads, machine_name,
+                                        iplist, num_addrs);
+       SAFE_FREE( iplist );
+       return status;
 }
+#endif
 
-/*********************************************************
- utility function to parse an integer parameter from 
- "parameter = value"
-**********************************************************/
-static char* get_string_param( const char* param )
-{
-       char *p;
-       
-       if ( (p = strchr( param, '=' )) == NULL )
-               return NULL;
-               
-       return (p+1);
-}
 
 /*******************************************************************
  ********************************************************************/
+
 static int net_ads_join_usage(int argc, const char **argv)
 {
        d_printf("net ads join [options]\n");
@@ -1160,51 +1086,58 @@ static int net_ads_join_usage(int argc, const char **argv)
        d_printf("   createcomputer=OU  Precreate the computer account in a specific OU.\n");
        d_printf("                      The OU string read from top to bottom without RDNs and delimited by a '/'.\n");
        d_printf("                      E.g. \"createcomputer=Computers/Servers/Unix\"\n");
+       d_printf("                      NB: A backslash '\\' is used as escape at multiple levels and may\n");
+       d_printf("                          need to be doubled or even quadrupled.  It is not used as a separator.\n");
+       d_printf("   osName=string      Set the operatingSystem attribute during the join.\n");
+       d_printf("   osVer=string       Set the operatingSystemVersion attribute during the join.\n");
+       d_printf("                      NB: osName and osVer must be specified together for either to take effect.\n");
+       d_printf("                          Also, the operatingSystemService attribute is also set when along with\n");
+       d_printf("                          the two other attributes.\n");
 
        return -1;
 }
 
 /*******************************************************************
  ********************************************************************/
+
 int net_ads_join(int argc, const char **argv)
 {
-       ADS_STRUCT *ads = NULL;
-       ADS_STATUS status;
-       char *machine_account = NULL;
-       const char *short_domain_name = NULL;
-       char *tmp_password, *password;
-       struct cldap_netlogon_reply cldap_reply;
-       TALLOC_CTX *ctx;
-       DOM_SID *domain_sid = NULL;
-       BOOL createupn = False;
+       TALLOC_CTX *ctx = NULL;
+       struct libnet_JoinCtx *r = NULL;
+       const char *domain = lp_realm();
+       WERROR werr = WERR_SETUP_NOT_JOINED;
+       bool createupn = False;
        const char *machineupn = NULL;
        const char *create_in_ou = NULL;
        int i;
-       
-       if ( check_ads_config() != 0 ) {
-               d_fprintf(stderr, "Invalid configuration.  Exiting....\n");
-               goto fail;
-       }
+       const char *os_name = NULL;
+       const char *os_version = NULL;
+       bool modify_config = lp_config_backend_is_registry();
 
-       if ( (ads = ads_startup(True)) == NULL ) {
-               goto fail;
-       }
+       if (!modify_config) {
 
-       if (strcmp(ads->config.realm, lp_realm()) != 0) {
-               d_fprintf(stderr, "realm of remote server (%s) and realm in smb.conf "
-                       "(%s) DO NOT match.  Aborting join\n", ads->config.realm, 
-                       lp_realm());
-               goto fail;
+               werr = check_ads_config();
+               if (!W_ERROR_IS_OK(werr)) {
+                       d_fprintf(stderr, "Invalid configuration.  Exiting....\n");
+                       goto fail;
+               }
        }
 
        if (!(ctx = talloc_init("net_ads_join"))) {
                d_fprintf(stderr, "Could not initialise talloc context.\n");
+               werr = WERR_NOMEM;
+               goto fail;
+       }
+
+       use_in_memory_ccache();
+
+       werr = libnet_init_JoinCtx(ctx, &r);
+       if (!W_ERROR_IS_OK(werr)) {
                goto fail;
        }
 
        /* process additional command line args */
-       
+
        for ( i=0; i<argc; i++ ) {
                if ( !StrnCaseCmp(argv[i], "createupn", strlen("createupn")) ) {
                        createupn = True;
@@ -1212,140 +1145,219 @@ int net_ads_join(int argc, const char **argv)
                }
                else if ( !StrnCaseCmp(argv[i], "createcomputer", strlen("createcomputer")) ) {
                        if ( (create_in_ou = get_string_param(argv[i])) == NULL ) {
-                               d_fprintf(stderr, "Please supply a valid OU path\n");
+                               d_fprintf(stderr, "Please supply a valid OU path.\n");
+                               werr = WERR_INVALID_PARAM;
+                               goto fail;
+                       }
+               }
+               else if ( !StrnCaseCmp(argv[i], "osName", strlen("osName")) ) {
+                       if ( (os_name = get_string_param(argv[i])) == NULL ) {
+                               d_fprintf(stderr, "Please supply a operating system name.\n");
+                               werr = WERR_INVALID_PARAM;
+                               goto fail;
+                       }
+               }
+               else if ( !StrnCaseCmp(argv[i], "osVer", strlen("osVer")) ) {
+                       if ( (os_version = get_string_param(argv[i])) == NULL ) {
+                               d_fprintf(stderr, "Please supply a valid operating system version.\n");
+                               werr = WERR_INVALID_PARAM;
                                goto fail;
-                       }               
+                       }
                }
                else {
-                       d_fprintf(stderr, "Bad option: %s\n", argv[i]);
-                       goto fail;
+                       domain = argv[i];
                }
        }
 
-       /* If we were given an OU, try to create the machine in 
-          the OU account first and then do the normal RPC join */
-
-       if  ( create_in_ou ) {
-               status = net_precreate_machine_acct( ads, create_in_ou );
-               if ( !ADS_ERR_OK(status) ) {
-                       d_fprintf( stderr, "Failed to pre-create the machine object "
-                               "in OU %s.\n", argv[0]);
-                       goto fail;
-               }
+       if (!*domain) {
+               d_fprintf(stderr, "Please supply a valid domain name\n");
+               werr = WERR_INVALID_PARAM;
+               goto fail;
        }
 
        /* Do the domain join here */
 
-       tmp_password = generate_random_str(DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH);
-       password = talloc_strdup(ctx, tmp_password);
-       
-       if ( net_join_domain( ctx, ads->config.ldap_server_name, &ads->ldap_ip, &domain_sid, password ) != 0 ) {
-               /* There should be more detailed output here... */
-               d_fprintf(stderr, "call of net_join_domain failed\n");
+       r->in.domain_name       = domain;
+       r->in.create_upn        = createupn;
+       r->in.upn               = machineupn;
+       r->in.account_ou        = create_in_ou;
+       r->in.os_name           = os_name;
+       r->in.os_version        = os_version;
+       r->in.dc_name           = opt_host;
+       r->in.admin_account     = opt_user_name;
+       r->in.admin_password    = net_prompt_pass(opt_user_name);
+       r->in.debug             = true;
+       r->in.modify_config     = modify_config;
+       r->in.join_flags        = WKSSVC_JOIN_FLAGS_JOIN_TYPE |
+                                 WKSSVC_JOIN_FLAGS_ACCOUNT_CREATE |
+                                 WKSSVC_JOIN_FLAGS_DOMAIN_JOIN_IF_JOINED;
+
+       werr = libnet_Join(ctx, r);
+       if (!W_ERROR_IS_OK(werr)) {
                goto fail;
        }
-       
+
        /* Check the short name of the domain */
-       
-       ZERO_STRUCT( cldap_reply );
-       
-       if ( ads_cldap_netlogon( ads->config.ldap_server_name, 
-               ads->server.realm, &cldap_reply ) ) 
-       {
-               short_domain_name = talloc_strdup( ctx, cldap_reply.netbios_domain );
-               if ( !strequal(lp_workgroup(), short_domain_name) ) {
-                       d_printf("The workgroup in smb.conf does not match the short\n");
-                       d_printf("domain name obtained from the server.\n");
-                       d_printf("Using the name [%s] from the server.\n", short_domain_name);
-                       d_printf("You should set \"workgroup = %s\" in smb.conf.\n", short_domain_name);
-               }
-       } else {
-               short_domain_name = lp_workgroup();
-       }
-       
-       d_printf("Using short domain name -- %s\n", short_domain_name);
-
-       /*  HACK ALERT!  Store the sid and password under both the lp_workgroup() 
-           value from smb.conf and the string returned from the server.  The former is
-           neede to bootstrap winbindd's first connection to the DC to get the real 
-           short domain name   --jerry */
-          
-       if ( (netdom_store_machine_account( lp_workgroup(), domain_sid, password ) == -1)
-               || (netdom_store_machine_account( short_domain_name, domain_sid, password ) == -1) )
-       {
-               goto fail;
+
+       if (!modify_config && !strequal(lp_workgroup(), r->out.netbios_domain_name)) {
+               d_printf("The workgroup in %s does not match the short\n", get_dyn_CONFIGFILE());
+               d_printf("domain name obtained from the server.\n");
+               d_printf("Using the name [%s] from the server.\n", r->out.netbios_domain_name);
+               d_printf("You should set \"workgroup = %s\" in %s.\n",
+                        r->out.netbios_domain_name, get_dyn_CONFIGFILE());
        }
 
-       /* Verify that everything is ok */
+       d_printf("Using short domain name -- %s\n", r->out.netbios_domain_name);
 
-       if ( net_rpc_join_ok(short_domain_name, ads->config.ldap_server_name, &ads->ldap_ip) != 0 ) {
-               d_fprintf(stderr, "Failed to verify membership in domain!\n");
-               goto fail;
-       }       
-
-       /* create the dNSHostName & servicePrincipalName values */
-       
-       status = net_set_machine_spn( ctx, ads );
-       if ( !ADS_ERR_OK(status) )  {
-
-               d_fprintf(stderr, "Failed to set servicePrincipalNames. Please ensure that\n");
-               d_fprintf(stderr, "the DNS domain of this server matches the AD domain,\n");
-               d_fprintf(stderr, "Or rejoin with using Domain Admin credentials.\n");
-               
-               /* Disable the machine account in AD.  Better to fail than to leave 
-                  a confused admin.  */
-               
-               if ( net_ads_leave( 0, NULL ) != 0 ) {
-                       d_fprintf( stderr, "Failed to disable machine account in AD.  Please do so manually.\n");
-               }
-               
-               /* clear out the machine password */
-               
-               netdom_store_machine_account( lp_workgroup(), domain_sid, "" ); 
-               netdom_store_machine_account( short_domain_name, domain_sid, "" );
-               
-               goto fail;
+       if (r->out.dns_domain_name) {
+               d_printf("Joined '%s' to realm '%s'\n", r->in.machine_name,
+                       r->out.dns_domain_name);
+       } else {
+               d_printf("Joined '%s' to domain '%s'\n", r->in.machine_name,
+                       r->out.netbios_domain_name);
        }
 
-       if ( !net_derive_salting_principal( ctx, ads ) ) {
-               DEBUG(1,("Failed to determine salting principal\n"));
-               goto fail;
-       }
+#if defined(WITH_DNS_UPDATES)
+       if (r->out.domain_is_ad) {
+               /* We enter this block with user creds */
+               ADS_STRUCT *ads_dns = NULL;
+
+               if ( (ads_dns = ads_init( lp_realm(), NULL, NULL )) != NULL ) {
+                       /* kinit with the machine password */
 
-       if ( createupn ) {
-               pstring upn;
-               
-               /* default to using the short UPN name */
-               if ( !machineupn ) {
-                       snprintf( upn, sizeof(upn), "host/%s@%s", global_myname(), 
-                               ads->config.realm );
-                       machineupn = upn;
+                       use_in_memory_ccache();
+                       asprintf( &ads_dns->auth.user_name, "%s$", global_myname() );
+                       ads_dns->auth.password = secrets_fetch_machine_password(
+                               r->out.netbios_domain_name, NULL, NULL );
+                       ads_dns->auth.realm = SMB_STRDUP( r->out.dns_domain_name );
+                       ads_kinit_password( ads_dns );
                }
-               
-               status = net_set_machine_upn( ctx, ads, machineupn );
-               if ( !ADS_ERR_OK(status) )  {
-                       d_fprintf(stderr, "Failed to set userPrincipalName.  Are you a Domain Admin?\n");
+
+               if ( !ads_dns || !NT_STATUS_IS_OK(net_update_dns( ctx, ads_dns )) ) {
+                       d_fprintf( stderr, "DNS update failed!\n" );
                }
-       }
 
-       /* Now build the keytab, using the same ADS connection */
-       if (lp_use_kerberos_keytab() && ads_keytab_create_default(ads)) {
-               DEBUG(1,("Error creating host keytab!\n"));
+               /* exit from this block using machine creds */
+               ads_destroy(&ads_dns);
        }
-
-       d_printf("Joined '%s' to realm '%s'\n", global_myname(), ads->config.realm);
-
-       SAFE_FREE(machine_account);
+#endif
+       TALLOC_FREE(r);
        TALLOC_FREE( ctx );
-       ads_destroy(&ads);
-       
+
        return 0;
 
 fail:
        /* issue an overall failure message at the end. */
-       d_printf("Failed to join domain!\n");
+       d_printf("Failed to join domain: %s\n",
+               r && r->out.error_string ? r->out.error_string :
+               get_friendly_werror_msg(werr));
+       TALLOC_FREE( ctx );
+
+        return -1;
+}
+
+/*******************************************************************
+ ********************************************************************/
+
+static int net_ads_dns_usage(int argc, const char **argv)
+{
+#if defined(WITH_DNS_UPDATES)
+       d_printf("net ads dns <command>\n");
+       d_printf("Valid commands:\n");
+       d_printf("   register         Issue a dynamic DNS update request for our hostname\n");
+
+       return 0;
+#else
+       d_fprintf(stderr, "DNS update support not enabled at compile time!\n");
+       return -1;
+#endif
+}
+
+/*******************************************************************
+ ********************************************************************/
+
+static int net_ads_dns_register(int argc, const char **argv)
+{
+#if defined(WITH_DNS_UPDATES)
+       ADS_STRUCT *ads;
+       ADS_STATUS status;
+       TALLOC_CTX *ctx;
+
+#ifdef DEVELOPER
+       talloc_enable_leak_report();
+#endif
+
+       if (argc > 0) {
+               d_fprintf(stderr, "net ads dns register\n");
+               return -1;
+       }
+
+       if (!(ctx = talloc_init("net_ads_dns"))) {
+               d_fprintf(stderr, "Could not initialise talloc context\n");
+               return -1;
+       }
+
+       status = ads_startup(True, &ads);
+       if ( !ADS_ERR_OK(status) ) {
+               DEBUG(1, ("error on ads_startup: %s\n", ads_errstr(status)));
+               TALLOC_FREE(ctx);
+               return -1;
+       }
+
+       if ( !NT_STATUS_IS_OK(net_update_dns(ctx, ads)) ) {
+               d_fprintf( stderr, "DNS update failed!\n" );
+               ads_destroy( &ads );
+               TALLOC_FREE( ctx );
+               return -1;
+       }
+
+       d_fprintf( stderr, "Successfully registered hostname with DNS\n" );
+
        ads_destroy(&ads);
+       TALLOC_FREE( ctx );
+
+       return 0;
+#else
+       d_fprintf(stderr, "DNS update support not enabled at compile time!\n");
        return -1;
+#endif
+}
+
+#if defined(WITH_DNS_UPDATES)
+DNS_ERROR do_gethostbyname(const char *server, const char *host);
+#endif
+
+static int net_ads_dns_gethostbyname(int argc, const char **argv)
+{
+#if defined(WITH_DNS_UPDATES)
+       DNS_ERROR err;
+
+#ifdef DEVELOPER
+       talloc_enable_leak_report();
+#endif
+
+       if (argc != 2) {
+               d_fprintf(stderr, "net ads dns gethostbyname <server> "
+                         "<name>\n");
+               return -1;
+       }
+
+       err = do_gethostbyname(argv[0], argv[1]);
+
+       d_printf("do_gethostbyname returned %d\n", ERROR_DNS_V(err));
+#endif
+       return 0;
+}
+
+static int net_ads_dns(int argc, const char *argv[])
+{
+       struct functable func[] = {
+               {"REGISTER", net_ads_dns_register},
+               {"GETHOSTBYNAME", net_ads_dns_gethostbyname},
+               {NULL, NULL}
+       };
+
+       return net_run_function(argc, argv, func, net_ads_dns_usage);
 }
 
 /*******************************************************************
@@ -1375,9 +1387,9 @@ static int net_ads_printer_search(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       void *res = NULL;
+       LDAPMessage *res = NULL;
 
-       if (!(ads = ads_startup(False))) {
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
@@ -1408,9 +1420,9 @@ static int net_ads_printer_info(int argc, const char **argv)
        ADS_STRUCT *ads;
        ADS_STATUS rc;
        const char *servername, *printername;
-       void *res = NULL;
+       LDAPMessage *res = NULL;
 
-       if (!(ads = ads_startup(False))) {
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
@@ -1429,7 +1441,8 @@ static int net_ads_printer_info(int argc, const char **argv)
        rc = ads_find_printer_on_server(ads, &res, printername, servername);
 
        if (!ADS_ERR_OK(rc)) {
-               d_fprintf(stderr, "ads_find_printer_on_server: %s\n", ads_errstr(rc));
+               d_fprintf(stderr, "Server '%s' not found: %s\n",
+                       servername, ads_errstr(rc));
                ads_msgfree(ads, res);
                ads_destroy(&ads);
                return -1;
@@ -1449,12 +1462,6 @@ static int net_ads_printer_info(int argc, const char **argv)
        return 0;
 }
 
-void do_drv_upgrade_printer(int msg_type, struct process_id src,
-                           void *buf, size_t len)
-{
-       return;
-}
-
 static int net_ads_printer_publish(int argc, const char **argv)
 {
         ADS_STRUCT *ads;
@@ -1462,21 +1469,24 @@ static int net_ads_printer_publish(int argc, const char **argv)
        const char *servername, *printername;
        struct cli_state *cli;
        struct rpc_pipe_client *pipe_hnd;
-       struct in_addr          server_ip;
+       struct sockaddr_storage server_ss;
        NTSTATUS nt_status;
        TALLOC_CTX *mem_ctx = talloc_init("net_ads_printer_publish");
        ADS_MODLIST mods = ads_init_mods(mem_ctx);
        char *prt_dn, *srv_dn, **srv_cn;
-       void *res = NULL;
+       char *srv_cn_escaped = NULL, *printername_escaped = NULL;
+       LDAPMessage *res = NULL;
 
-       if (!(ads = ads_startup(True))) {
+       if (!ADS_ERR_OK(ads_startup(True, &ads))) {
+               talloc_destroy(mem_ctx);
                return -1;
        }
 
        if (argc < 1) {
+               talloc_destroy(mem_ctx);
                return net_ads_printer_usage(argc, argv);
        }
-       
+
        printername = argv[0];
 
        if (argc == 2) {
@@ -1484,23 +1494,24 @@ static int net_ads_printer_publish(int argc, const char **argv)
        } else {
                servername = global_myname();
        }
-               
+
        /* Get printer data from SPOOLSS */
 
-       resolve_name(servername, &server_ip, 0x20);
+       resolve_name(servername, &server_ss, 0x20);
 
-       nt_status = cli_full_connection(&cli, global_myname(), servername, 
-                                       &server_ip, 0,
-                                       "IPC$", "IPC",  
+       nt_status = cli_full_connection(&cli, global_myname(), servername,
+                                       &server_ss, 0,
+                                       "IPC$", "IPC",
                                        opt_user_name, opt_workgroup,
-                                       opt_password ? opt_password : "", 
-                                       CLI_FULL_CONNECTION_USE_KERBEROS, 
+                                       opt_password ? opt_password : "",
+                                       CLI_FULL_CONNECTION_USE_KERBEROS,
                                        Undefined, NULL);
 
        if (NT_STATUS_IS_ERR(nt_status)) {
                d_fprintf(stderr, "Unable to open a connnection to %s to obtain data "
                         "for %s\n", servername, printername);
                ads_destroy(&ads);
+               talloc_destroy(mem_ctx);
                return -1;
        }
 
@@ -1512,35 +1523,61 @@ static int net_ads_printer_publish(int argc, const char **argv)
                d_fprintf(stderr, "Could not find machine account for server %s\n", 
                         servername);
                ads_destroy(&ads);
+               talloc_destroy(mem_ctx);
                return -1;
        }
 
-       srv_dn = ldap_get_dn((LDAP *)ads->ld, (LDAPMessage *)res);
+       srv_dn = ldap_get_dn((LDAP *)ads->ldap.ld, (LDAPMessage *)res);
        srv_cn = ldap_explode_dn(srv_dn, 1);
 
-       asprintf(&prt_dn, "cn=%s-%s,%s", srv_cn[0], printername, srv_dn);
+       srv_cn_escaped = escape_rdn_val_string_alloc(srv_cn[0]);
+       printername_escaped = escape_rdn_val_string_alloc(printername);
+       if (!srv_cn_escaped || !printername_escaped) {
+               SAFE_FREE(srv_cn_escaped);
+               SAFE_FREE(printername_escaped);
+               d_fprintf(stderr, "Internal error, out of memory!");
+               ads_destroy(&ads);
+               talloc_destroy(mem_ctx);
+               return -1;
+       }
+
+       asprintf(&prt_dn, "cn=%s-%s,%s", srv_cn_escaped, printername_escaped, srv_dn);
+
+       SAFE_FREE(srv_cn_escaped);
+       SAFE_FREE(printername_escaped);
 
        pipe_hnd = cli_rpc_pipe_open_noauth(cli, PI_SPOOLSS, &nt_status);
        if (!pipe_hnd) {
                d_fprintf(stderr, "Unable to open a connnection to the spoolss pipe on %s\n",
                         servername);
+               SAFE_FREE(prt_dn);
                ads_destroy(&ads);
+               talloc_destroy(mem_ctx);
                return -1;
        }
 
-       get_remote_printer_publishing_data(pipe_hnd, mem_ctx, &mods,
-                                          printername);
+       if (!W_ERROR_IS_OK(get_remote_printer_publishing_data(pipe_hnd, mem_ctx, &mods,
+                                                             printername))) {
+               SAFE_FREE(prt_dn);
+               ads_destroy(&ads);
+               talloc_destroy(mem_ctx);
+               return -1;
+       }
 
         rc = ads_add_printer_entry(ads, prt_dn, mem_ctx, &mods);
         if (!ADS_ERR_OK(rc)) {
                 d_fprintf(stderr, "ads_publish_printer: %s\n", ads_errstr(rc));
+               SAFE_FREE(prt_dn);
                ads_destroy(&ads);
+               talloc_destroy(mem_ctx);
                 return -1;
         }
+
         d_printf("published printer\n");
+       SAFE_FREE(prt_dn);
        ads_destroy(&ads);
+       talloc_destroy(mem_ctx);
+
        return 0;
 }
 
@@ -1550,9 +1587,9 @@ static int net_ads_printer_remove(int argc, const char **argv)
        ADS_STATUS rc;
        const char *servername;
        char *prt_dn;
-       void *res = NULL;
+       LDAPMessage *res = NULL;
 
-       if (!(ads = ads_startup(True))) {
+       if (!ADS_ERR_OK(ads_startup(True, &ads))) {
                return -1;
        }
 
@@ -1606,7 +1643,7 @@ static int net_ads_printer(int argc, const char **argv)
                {"REMOVE", net_ads_printer_remove},
                {NULL, NULL}
        };
-       
+
        return net_run_function(argc, argv, func, net_ads_printer_usage);
 }
 
@@ -1638,7 +1675,7 @@ static int net_ads_password(int argc, const char **argv)
                user = c;
        }
 
-       use_in_memory_ccache();    
+       use_in_memory_ccache();
        c = strchr_m(auth_principal, '@');
        if (c) {
                realm = ++c;
@@ -1646,7 +1683,7 @@ static int net_ads_password(int argc, const char **argv)
                realm = lp_realm();
        }
 
-       /* use the realm so we can eventually change passwords for users 
+       /* use the realm so we can eventually change passwords for users
        in realms other than default */
        if (!(ads = ads_init(realm, opt_workgroup, opt_host))) {
                return -1;
@@ -1655,8 +1692,8 @@ static int net_ads_password(int argc, const char **argv)
        /* we don't actually need a full connect, but it's the easy way to
                fill in the KDC's addresss */
        ads_connect(ads);
-    
-       if (!ads || !ads->config.realm) {
+
+       if (!ads->config.realm) {
                d_fprintf(stderr, "Didn't find the kerberos server!\n");
                return -1;
        }
@@ -1669,7 +1706,7 @@ static int net_ads_password(int argc, const char **argv)
                free(prompt);
        }
 
-       ret = kerberos_set_password(ads->auth.kdc_server, auth_principal, 
+       ret = kerberos_set_password(ads->auth.kdc_server, auth_principal,
                                auth_password, user, new_password, ads->auth.time_offset);
        if (!ADS_ERR_OK(ret)) {
                d_fprintf(stderr, "Password change failed: %s\n", ads_errstr(ret));
@@ -1684,7 +1721,7 @@ static int net_ads_password(int argc, const char **argv)
 }
 
 int net_ads_changetrustpw(int argc, const char **argv)
-{    
+{
        ADS_STRUCT *ads;
        char *host_principal;
        fstring my_name;
@@ -1695,11 +1732,11 @@ int net_ads_changetrustpw(int argc, const char **argv)
                return -1;
        }
 
-       net_use_machine_password();
+       net_use_krb_machine_account();
 
        use_in_memory_ccache();
 
-       if (!(ads = ads_startup(True))) {
+       if (!ADS_ERR_OK(ads_startup(True, &ads))) {
                return -1;
        }
 
@@ -1716,7 +1753,7 @@ int net_ads_changetrustpw(int argc, const char **argv)
                SAFE_FREE(host_principal);
                return -1;
        }
-    
+
        d_printf("Password change for principal %s succeeded.\n", host_principal);
 
        if (lp_use_kerberos_keytab()) {
@@ -1758,13 +1795,13 @@ static int net_ads_search(int argc, const char **argv)
        ADS_STATUS rc;
        const char *ldap_exp;
        const char **attrs;
-       void *res = NULL;
+       LDAPMessage *res = NULL;
 
        if (argc < 1) {
                return net_ads_search_usage(argc, argv);
        }
 
-       if (!(ads = ads_startup(False))) {
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
@@ -1778,7 +1815,7 @@ static int net_ads_search(int argc, const char **argv)
                d_fprintf(stderr, "search failed: %s\n", ads_errstr(rc));
                ads_destroy(&ads);
                return -1;
-       }       
+       }
 
        d_printf("Got %d replies\n\n", ads_count_replies(ads, res));
 
@@ -1803,6 +1840,7 @@ static int net_ads_dn_usage(int argc, const char **argv)
                "The DN standard LDAP DN, and the attributes are a list of LDAP fields \n"\
                "to show in the results\n\n"\
                "Example: net ads dn 'CN=administrator,CN=Users,DC=my,DC=domain' sAMAccountName\n\n"
+               "Note: the DN must be provided properly escaped. See RFC 4514 for details\n\n"
                );
        net_common_flags_usage(argc, argv);
        return -1;
@@ -1818,27 +1856,27 @@ static int net_ads_dn(int argc, const char **argv)
        ADS_STATUS rc;
        const char *dn;
        const char **attrs;
-       void *res = NULL;
+       LDAPMessage *res = NULL;
 
        if (argc < 1) {
                return net_ads_dn_usage(argc, argv);
        }
 
-       if (!(ads = ads_startup(False))) {
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
        dn = argv[0];
        attrs = (argv + 1);
 
-       rc = ads_do_search_all(ads, dn, 
+       rc = ads_do_search_all(ads, dn,
                               LDAP_SCOPE_BASE,
                               "(objectclass=*)", attrs, &res);
        if (!ADS_ERR_OK(rc)) {
                d_fprintf(stderr, "search failed: %s\n", ads_errstr(rc));
                ads_destroy(&ads);
                return -1;
-       }       
+       }
 
        d_printf("Got %d replies\n\n", ads_count_replies(ads, res));
 
@@ -1877,14 +1915,14 @@ static int net_ads_sid(int argc, const char **argv)
        ADS_STATUS rc;
        const char *sid_string;
        const char **attrs;
-       void *res = NULL;
+       LDAPMessage *res = NULL;
        DOM_SID sid;
 
        if (argc < 1) {
                return net_ads_sid_usage(argc, argv);
        }
 
-       if (!(ads = ads_startup(False))) {
+       if (!ADS_ERR_OK(ads_startup(False, &ads))) {
                return -1;
        }
 
@@ -1902,7 +1940,7 @@ static int net_ads_sid(int argc, const char **argv)
                d_fprintf(stderr, "search failed: %s\n", ads_errstr(rc));
                ads_destroy(&ads);
                return -1;
-       }       
+       }
 
        d_printf("Got %d replies\n\n", ads_count_replies(ads, res));
 
@@ -1921,16 +1959,18 @@ static int net_ads_keytab_usage(int argc, const char **argv)
        d_printf(
                "net ads keytab <COMMAND>\n"\
 "<COMMAND> can be either:\n"\
-"  CREATE    Creates a fresh keytab\n"\
 "  ADD       Adds new service principal\n"\
+"  CREATE    Creates a fresh keytab\n"\
 "  FLUSH     Flushes out all keytab entries\n"\
 "  HELP      Prints this help message\n"\
-"The ADD command will take arguments, the other commands\n"\
+"  LIST      List the keytab\n"\
+"The ADD and LIST command will take arguments, the other commands\n"\
 "will not take any arguments.   The arguments given to ADD\n"\
 "should be a list of principals to add.  For example, \n"\
 "   net ads keytab add srv1 srv2\n"\
 "will add principals for the services srv1 and srv2 to the\n"\
 "system's keytab.\n"\
+"The LIST command takes a keytabname.\n"\
 "\n"
                );
        return -1;
@@ -1941,7 +1981,7 @@ static int net_ads_keytab_flush(int argc, const char **argv)
        int ret;
        ADS_STRUCT *ads;
 
-       if (!(ads = ads_startup(True))) {
+       if (!ADS_ERR_OK(ads_startup(True, &ads))) {
                return -1;
        }
        ret = ads_keytab_flush(ads);
@@ -1956,7 +1996,7 @@ static int net_ads_keytab_add(int argc, const char **argv)
        ADS_STRUCT *ads;
 
        d_printf("Processing principals to add...\n");
-       if (!(ads = ads_startup(True))) {
+       if (!ADS_ERR_OK(ads_startup(True, &ads))) {
                return -1;
        }
        for (i = 0; i < argc; i++) {
@@ -1971,7 +2011,7 @@ static int net_ads_keytab_create(int argc, const char **argv)
        ADS_STRUCT *ads;
        int ret;
 
-       if (!(ads = ads_startup(True))) {
+       if (!ADS_ERR_OK(ads_startup(True, &ads))) {
                return -1;
        }
        ret = ads_keytab_create_default(ads);
@@ -1979,13 +2019,26 @@ static int net_ads_keytab_create(int argc, const char **argv)
        return ret;
 }
 
+static int net_ads_keytab_list(int argc, const char **argv)
+{
+       const char *keytab = NULL;
+
+       if (argc >= 1) {
+               keytab = argv[0];
+       }
+
+       return ads_keytab_list(keytab);
+}
+
+
 int net_ads_keytab(int argc, const char **argv)
 {
        struct functable func[] = {
-               {"CREATE", net_ads_keytab_create},
                {"ADD", net_ads_keytab_add},
+               {"CREATE", net_ads_keytab_create},
                {"FLUSH", net_ads_keytab_flush},
                {"HELP", net_ads_keytab_usage},
+               {"LIST", net_ads_keytab_list},
                {NULL, NULL}
        };
 
@@ -1997,6 +2050,120 @@ use keytab functions.\n");
        return net_run_function(argc, argv, func, net_ads_keytab_usage);
 }
 
+static int net_ads_kerberos_usage(int argc, const char **argv)
+{
+       d_printf(
+               "net ads kerberos <COMMAND>\n"\
+               "<COMMAND> can be either:\n"\
+               "  RENEW     Renew TGT from existing credential cache\n"\
+               "  PAC       Dumps the Kerberos PAC\n"\
+               "  KINIT     Retrieve Ticket Granting Ticket (TGT)\n"\
+               "\n"
+       );
+
+       return -1;
+}
+
+static int net_ads_kerberos_renew(int argc, const char **argv)
+{
+       int ret = smb_krb5_renew_ticket(NULL, NULL, NULL, NULL);
+       if (ret) {
+               d_printf("failed to renew kerberos ticket: %s\n",
+                       error_message(ret));
+       }
+       return ret;
+}
+
+static int net_ads_kerberos_pac(int argc, const char **argv)
+{
+       struct PAC_DATA *pac = NULL;
+       struct PAC_LOGON_INFO *info = NULL;
+       TALLOC_CTX *mem_ctx = NULL;
+       NTSTATUS status;
+       int ret = -1;
+
+       mem_ctx = talloc_init("net_ads_kerberos_pac");
+       if (!mem_ctx) {
+               goto out;
+       }
+
+       opt_password = net_prompt_pass(opt_user_name);
+
+       status = kerberos_return_pac(mem_ctx,
+                                    opt_user_name,
+                                    opt_password,
+                                    0,
+                                    NULL,
+                                    NULL,
+                                    NULL,
+                                    True,
+                                    True,
+                                    2592000, /* one month */
+                                    &pac);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("failed to query kerberos PAC: %s\n",
+                       nt_errstr(status));
+               goto out;
+       }
+
+       info = get_logon_info_from_pac(pac);
+       if (info) {
+               const char *s;
+               s = NDR_PRINT_STRUCT_STRING(mem_ctx, PAC_LOGON_INFO, info);
+               d_printf("The Pac: %s\n", s);
+       }
+
+       ret = 0;
+ out:
+       TALLOC_FREE(mem_ctx);
+       return ret;
+}
+
+static int net_ads_kerberos_kinit(int argc, const char **argv)
+{
+       TALLOC_CTX *mem_ctx = NULL;
+       int ret = -1;
+       NTSTATUS status;
+
+       mem_ctx = talloc_init("net_ads_kerberos_kinit");
+       if (!mem_ctx) {
+               goto out;
+       }
+
+       opt_password = net_prompt_pass(opt_user_name);
+
+       ret = kerberos_kinit_password_ext(opt_user_name,
+                                         opt_password,
+                                         0,
+                                         NULL,
+                                         NULL,
+                                         NULL,
+                                         True,
+                                         True,
+                                         2592000, /* one month */
+                                         &status);
+       if (ret) {
+               d_printf("failed to kinit password: %s\n",
+                       nt_errstr(status));
+       }
+ out:
+       return ret;
+}
+
+int net_ads_kerberos(int argc, const char **argv)
+{
+       struct functable func[] = {
+               {"KINIT", net_ads_kerberos_kinit},
+               {"RENEW", net_ads_kerberos_renew},
+               {"PAC", net_ads_kerberos_pac},
+               {"HELP", net_ads_kerberos_usage},
+               {NULL, NULL}
+       };
+
+       return net_run_function(argc, argv, func, net_ads_kerberos_usage);
+}
+
+
 int net_ads_help(int argc, const char **argv)
 {
        struct functable func[] = {
@@ -2006,6 +2173,7 @@ int net_ads_help(int argc, const char **argv)
                {"SEARCH", net_ads_search_usage},
                {"INFO", net_ads_info},
                {"JOIN", net_ads_join_usage},
+               {"DNS", net_ads_dns_usage},
                {"LEAVE", net_ads_leave},
                {"STATUS", net_ads_status},
                {"PASSWORD", net_ads_password},
@@ -2026,6 +2194,7 @@ int net_ads(int argc, const char **argv)
                {"STATUS", net_ads_status},
                {"USER", net_ads_user},
                {"GROUP", net_ads_group},
+               {"DNS", net_ads_dns},
                {"PASSWORD", net_ads_password},
                {"CHANGETRUSTPW", net_ads_changetrustpw},
                {"PRINTER", net_ads_printer},
@@ -2035,10 +2204,12 @@ int net_ads(int argc, const char **argv)
                {"WORKGROUP", net_ads_workgroup},
                {"LOOKUP", net_ads_lookup},
                {"KEYTAB", net_ads_keytab},
+               {"GPO", net_ads_gpo},
+               {"KERBEROS", net_ads_kerberos},
                {"HELP", net_ads_help},
                {NULL, NULL}
        };
-       
+
        return net_run_function(argc, argv, func, net_ads_usage);
 }
 
@@ -2055,6 +2226,11 @@ int net_ads_keytab(int argc, const char **argv)
        return net_ads_noads();
 }
 
+int net_ads_kerberos(int argc, const char **argv)
+{
+       return net_ads_noads();
+}
+
 int net_ads_usage(int argc, const char **argv)
 {
        return net_ads_noads();