s3 file_access: Convert some more functions over to use smb_filneame
[ira/wip.git] / source3 / smbd / dir.c
index eec8fa12ef8b994bd92895239ec2953f16e106bc..723fb6fd6f2f1168b53cc4639a545f478e770fa5 100644 (file)
@@ -1,30 +1,30 @@
-/* 
+/*
    Unix SMB/CIFS implementation.
    Directory handling routines
    Copyright (C) Andrew Tridgell 1992-1998
-   
+   Copyright (C) Jeremy Allison 2007
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
+#include "smbd/globals.h"
 
 /*
    This module implements directory related functions for Samba.
 */
 
-extern struct current_user current_user;
-
 /* "Special" directory offsets. */
 #define END_OF_DIRECTORY_OFFSET ((long)-1)
 #define START_OF_DIRECTORY_OFFSET ((long)0)
@@ -54,17 +54,14 @@ struct dptr_struct {
        uint16 spid;
        struct connection_struct *conn;
        struct smb_Dir *dir_hnd;
-       BOOL expect_close;
+       bool expect_close;
        char *wcard;
        uint32 attr;
        char *path;
-       BOOL has_wild; /* Set to true if the wcard entry has MS wildcard characters in it. */
-       BOOL did_stat; /* Optimisation for non-wcard searches. */
+       bool has_wild; /* Set to true if the wcard entry has MS wildcard characters in it. */
+       bool did_stat; /* Optimisation for non-wcard searches. */
 };
 
-static struct bitmap *dptr_bmap;
-static struct dptr_struct *dirptrs;
-static int dirhandles_open = 0;
 
 #define INVALID_DPTR_KEY (-3)
 
@@ -72,15 +69,25 @@ static int dirhandles_open = 0;
  Make a dir struct.
 ****************************************************************************/
 
-void make_dir_struct(char *buf, const char *mask, const char *fname,SMB_OFF_T size,uint32 mode,time_t date, BOOL uc)
-{  
+bool make_dir_struct(TALLOC_CTX *ctx,
+                       char *buf,
+                       const char *mask,
+                       const char *fname,
+                       SMB_OFF_T size,
+                       uint32 mode,
+                       time_t date,
+                       bool uc)
+{
        char *p;
-       pstring mask2;
+       char *mask2 = talloc_strdup(ctx, mask);
 
-       pstrcpy(mask2,mask);
+       if (!mask2) {
+               return False;
+       }
 
-       if ((mode & aDIR) != 0)
+       if ((mode & aDIR) != 0) {
                size = 0;
+       }
 
        memset(buf+1,' ',11);
        if ((p = strchr_m(mask2,'.')) != NULL) {
@@ -88,8 +95,9 @@ void make_dir_struct(char *buf, const char *mask, const char *fname,SMB_OFF_T si
                push_ascii(buf+1,mask2,8, 0);
                push_ascii(buf+9,p+1,3, 0);
                *p = '.';
-       } else
+       } else {
                push_ascii(buf+1,mask2,11, 0);
+       }
 
        memset(buf+21,'\0',DIR_STRUCT_SIZE-21);
        SCVAL(buf,21,mode);
@@ -100,6 +108,7 @@ void make_dir_struct(char *buf, const char *mask, const char *fname,SMB_OFF_T si
           Strange, but verified on W2K3. Needed for OS/2. JRA. */
        push_ascii(buf+30,fname,12, uc ? STR_UPPER : 0);
        DEBUG(8,("put name [%s] from [%s] into dir struct\n",buf+30, fname));
+       return True;
 }
 
 /****************************************************************************
@@ -108,17 +117,13 @@ void make_dir_struct(char *buf, const char *mask, const char *fname,SMB_OFF_T si
 
 void init_dptrs(void)
 {
-       static BOOL dptrs_init=False;
-
-       if (dptrs_init)
+       if (dptr_bmap)
                return;
 
        dptr_bmap = bitmap_allocate(MAX_DIRECTORY_HANDLES);
 
        if (!dptr_bmap)
                exit_server("out of memory in init_dptrs");
-
-       dptrs_init = True;
 }
 
 /****************************************************************************
@@ -129,8 +134,7 @@ static void dptr_idle(struct dptr_struct *dptr)
 {
        if (dptr->dir_hnd) {
                DEBUG(4,("Idling dptr dnum %d\n",dptr->dnum));
-               CloseDir(dptr->dir_hnd);
-               dptr->dir_hnd = NULL;
+               TALLOC_FREE(dptr->dir_hnd);
        }
 }
 
@@ -169,7 +173,7 @@ static void dptr_idleoldest(void)
  Get the struct dptr_struct for a dir index.
 ****************************************************************************/
 
-static struct dptr_struct *dptr_get(int key, BOOL forclose)
+static struct dptr_struct *dptr_get(int key, bool forclose)
 {
        struct dptr_struct *dptr;
 
@@ -179,7 +183,9 @@ static struct dptr_struct *dptr_get(int key, BOOL forclose)
                                if (dirhandles_open >= MAX_OPEN_DIRECTORIES)
                                        dptr_idleoldest();
                                DEBUG(4,("dptr_get: Reopening dptr key %d\n",key));
-                               if (!(dptr->dir_hnd = OpenDir(dptr->conn, dptr->path, dptr->wcard, dptr->attr))) {
+                               if (!(dptr->dir_hnd = OpenDir(
+                                             NULL, dptr->conn, dptr->path,
+                                             dptr->wcard, dptr->attr))) {
                                        DEBUG(4,("dptr_get: Failed to open %s (%s)\n",dptr->path,
                                                strerror(errno)));
                                        return False;
@@ -238,7 +244,7 @@ static void dptr_close_internal(struct dptr_struct *dptr)
 
        DLIST_REMOVE(dirptrs, dptr);
 
-       /* 
+       /*
         * Free the dnum in the bitmap. Remember the dnum value is always 
         * biased by one with respect to the bitmap.
         */
@@ -250,9 +256,7 @@ static void dptr_close_internal(struct dptr_struct *dptr)
 
        bitmap_clear(dptr_bmap, dptr->dnum - 1);
 
-       if (dptr->dir_hnd) {
-               CloseDir(dptr->dir_hnd);
-       }
+       TALLOC_FREE(dptr->dir_hnd);
 
        /* Lanman 2 specific code */
        SAFE_FREE(dptr->wcard);
@@ -341,7 +345,7 @@ void dptr_closepath(char *path,uint16 spid)
  finished with that one.
 ****************************************************************************/
 
-static void dptr_close_oldest(BOOL old)
+static void dptr_close_oldest(bool old)
 {
        struct dptr_struct *dptr;
 
@@ -380,12 +384,11 @@ static void dptr_close_oldest(BOOL old)
  wcard must not be zero.
 ****************************************************************************/
 
-NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOOL expect_close,uint16 spid,
-               const char *wcard, BOOL wcard_has_wild, uint32 attr, struct dptr_struct **dptr_ret)
+NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle, bool expect_close,uint16 spid,
+               const char *wcard, bool wcard_has_wild, uint32 attr, struct dptr_struct **dptr_ret)
 {
        struct dptr_struct *dptr = NULL;
        struct smb_Dir *dir_hnd;
-        const char *dir2;
        NTSTATUS status;
 
        DEBUG(5,("dptr_create dir=%s\n", path));
@@ -399,17 +402,12 @@ NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOO
                return status;
        }
 
-       /* use a const pointer from here on */
-       dir2 = path;
-       if (!*dir2)
-               dir2 = ".";
-
-       dir_hnd = OpenDir(conn, dir2, wcard, attr);
+       dir_hnd = OpenDir(NULL, conn, path, wcard, attr);
        if (!dir_hnd) {
                return map_nt_error_from_unix(errno);
        }
 
-       string_set(&conn->dirpath,dir2);
+       string_set(&conn->dirpath,path);
 
        if (dirhandles_open >= MAX_OPEN_DIRECTORIES) {
                dptr_idleoldest();
@@ -418,7 +416,7 @@ NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOO
        dptr = SMB_MALLOC_P(struct dptr_struct);
        if(!dptr) {
                DEBUG(0,("malloc fail in dptr_create.\n"));
-               CloseDir(dir_hnd);
+               TALLOC_FREE(dir_hnd);
                return NT_STATUS_NO_MEMORY;
        }
 
@@ -448,7 +446,7 @@ NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOO
                        if(dptr->dnum == -1 || dptr->dnum > 254) {
                                DEBUG(0,("dptr_create: returned %d: Error - all old dirptrs in use ?\n", dptr->dnum));
                                SAFE_FREE(dptr);
-                               CloseDir(dir_hnd);
+                               TALLOC_FREE(dir_hnd);
                                return NT_STATUS_TOO_MANY_OPENED_FILES;
                        }
                }
@@ -478,7 +476,7 @@ NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOO
                        if(dptr->dnum == -1 || dptr->dnum < 255) {
                                DEBUG(0,("dptr_create: returned %d: Error - all new dirptrs in use ?\n", dptr->dnum));
                                SAFE_FREE(dptr);
-                               CloseDir(dir_hnd);
+                               TALLOC_FREE(dir_hnd);
                                return NT_STATUS_TOO_MANY_OPENED_FILES;
                        }
                }
@@ -488,7 +486,7 @@ NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOO
 
        dptr->dnum += 1; /* Always bias the dnum by one - no zero dnums allowed. */
 
-       string_set(&dptr->path,dir2);
+       string_set(&dptr->path,path);
        dptr->conn = conn;
        dptr->dir_hnd = dir_hnd;
        dptr->spid = spid;
@@ -497,7 +495,7 @@ NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOO
        if (!dptr->wcard) {
                bitmap_clear(dptr_bmap, dptr->dnum - 1);
                SAFE_FREE(dptr);
-               CloseDir(dir_hnd);
+               TALLOC_FREE(dir_hnd);
                return NT_STATUS_NO_MEMORY;
        }
        if (lp_posix_pathnames() || (wcard[0] == '.' && wcard[1] == 0)) {
@@ -526,7 +524,8 @@ NTSTATUS dptr_create(connection_struct *conn, pstring path, BOOL old_handle, BOO
 int dptr_CloseDir(struct dptr_struct *dptr)
 {
        DLIST_REMOVE(dirptrs, dptr);
-       return CloseDir(dptr->dir_hnd);
+       TALLOC_FREE(dptr->dir_hnd);
+       return 0;
 }
 
 void dptr_SeekDir(struct dptr_struct *dptr, long offset)
@@ -539,7 +538,7 @@ long dptr_TellDir(struct dptr_struct *dptr)
        return TellDir(dptr->dir_hnd);
 }
 
-BOOL dptr_has_wild(struct dptr_struct *dptr)
+bool dptr_has_wild(struct dptr_struct *dptr)
 {
        return dptr->has_wild;
 }
@@ -553,11 +552,12 @@ int dptr_dnum(struct dptr_struct *dptr)
  Return the next visible file name, skipping veto'd and invisible files.
 ****************************************************************************/
 
-static const char *dptr_normal_ReadDirName(struct dptr_struct *dptr, long *poffset, SMB_STRUCT_STAT *pst)
+static const char *dptr_normal_ReadDirName(struct dptr_struct *dptr,
+                                          long *poffset, SMB_STRUCT_STAT *pst)
 {
        /* Normal search for the next file. */
        const char *name;
-       while ((name = ReadDirName(dptr->dir_hnd, poffset)) != NULL) {
+       while ((name = ReadDirName(dptr->dir_hnd, poffset, pst)) != NULL) {
                if (is_visible_file(dptr->conn, dptr->path, name, pst, True)) {
                        return name;
                }
@@ -569,83 +569,130 @@ static const char *dptr_normal_ReadDirName(struct dptr_struct *dptr, long *poffs
  Return the next visible file name, skipping veto'd and invisible files.
 ****************************************************************************/
 
-const char *dptr_ReadDirName(struct dptr_struct *dptr, long *poffset, SMB_STRUCT_STAT *pst)
+char *dptr_ReadDirName(TALLOC_CTX *ctx,
+                       struct dptr_struct *dptr,
+                       long *poffset,
+                       SMB_STRUCT_STAT *pst)
 {
+       struct smb_filename *smb_fname_base = NULL;
+       char *name = NULL;
+       char *pathreal = NULL;
+       char *found_name = NULL;
+       int ret;
+       const char *name_temp = NULL;
+       NTSTATUS status;
+
        SET_STAT_INVALID(*pst);
 
-       if (dptr->has_wild) {
-               return dptr_normal_ReadDirName(dptr, poffset, pst);
+       if (dptr->has_wild || dptr->did_stat) {
+               name_temp = dptr_normal_ReadDirName(dptr, poffset, pst);
+               name = talloc_strdup(ctx, name_temp);
+               return name;
        }
 
-       /* If poffset is -1 then we know we returned this name before and we have
-          no wildcards. We're at the end of the directory. */
+       /* If poffset is -1 then we know we returned this name before and we
+        * have no wildcards. We're at the end of the directory. */
        if (*poffset == END_OF_DIRECTORY_OFFSET) {
                return NULL;
        }
 
-       if (!dptr->did_stat) {
-               pstring pathreal;
+       /* We know the stored wcard contains no wildcard characters.
+        * See if we can match with a stat call. If we can't, then set
+        * did_stat to true to ensure we only do this once and keep
+        * searching. */
+
+       dptr->did_stat = true;
+
+       /* First check if it should be visible. */
+       if (!is_visible_file(dptr->conn, dptr->path, dptr->wcard,
+           pst, true))
+       {
+               /* This only returns false if the file was found, but
+                  is explicitly not visible. Set us to end of
+                  directory, but return NULL as we know we can't ever
+                  find it. */
+               goto ret;
+       }
 
-               /* We know the stored wcard contains no wildcard characters. See if we can match
-                  with a stat call. If we can't, then set did_stat to true to
-                  ensure we only do this once and keep searching. */
+       if (VALID_STAT(*pst)) {
+               name = talloc_strdup(ctx, dptr->wcard);
+               goto ret;
+       }
 
-               dptr->did_stat = True;
+       pathreal = talloc_asprintf(ctx,
+                               "%s/%s",
+                               dptr->path,
+                               dptr->wcard);
+       if (!pathreal)
+               return NULL;
 
-               /* First check if it should be visible. */
-               if (!is_visible_file(dptr->conn, dptr->path, dptr->wcard, pst, True)) {
-                       /* This only returns False if the file was found, but
-                          is explicitly not visible. Set us to end of directory,
-                          but return NULL as we know we can't ever find it. */
-                       dptr->dir_hnd->offset = *poffset = END_OF_DIRECTORY_OFFSET;
-                       return NULL;
-               }
+       /* Create an smb_filename with stream_name == NULL. */
+       status = create_synthetic_smb_fname(ctx, pathreal, NULL, NULL,
+                                           &smb_fname_base);
+       if (!NT_STATUS_IS_OK(status)) {
+               return NULL;
+       }
 
-               if (VALID_STAT(*pst)) {
-                       /* We need to set the underlying dir_hnd offset to -1 also as
-                          this function is usually called with the output from TellDir. */
-                       dptr->dir_hnd->offset = *poffset = END_OF_DIRECTORY_OFFSET;
-                       return dptr->wcard;
+       if (SMB_VFS_STAT(dptr->conn, smb_fname_base) == 0) {
+               *pst = smb_fname_base->st;
+               TALLOC_FREE(smb_fname_base);
+               name = talloc_strdup(ctx, dptr->wcard);
+               goto clean;
+       } else {
+               TALLOC_FREE(smb_fname_base);
+               /* If we get any other error than ENOENT or ENOTDIR
+                  then the file exists we just can't stat it. */
+               if (errno != ENOENT && errno != ENOTDIR) {
+                       name = talloc_strdup(ctx, dptr->wcard);
+                       goto clean;
                }
+       }
+
+       /* Stat failed. We know this is authoratiative if we are
+        * providing case sensitive semantics or the underlying
+        * filesystem is case sensitive.
+        */
+       if (dptr->conn->case_sensitive ||
+           !(dptr->conn->fs_capabilities & FILE_CASE_SENSITIVE_SEARCH))
+       {
+               goto clean;
+       }
 
-               pstrcpy(pathreal,dptr->path);
-               pstrcat(pathreal,"/");
-               pstrcat(pathreal,dptr->wcard);
+       /*
+        * Try case-insensitive stat if the fs has the ability. This avoids
+        * scanning the whole directory.
+        */
+       ret = SMB_VFS_GET_REAL_FILENAME(dptr->conn, dptr->path, dptr->wcard,
+                                       ctx, &found_name);
+       if (ret == 0) {
+               name = found_name;
+               goto clean;
+       } else if (errno == ENOENT) {
+               /* The case-insensitive lookup was authoritative. */
+               goto clean;
+       }
 
-               if (SMB_VFS_STAT(dptr->conn,pathreal,pst) == 0) {
-                       /* We need to set the underlying dir_hnd offset to -1 also as
-                          this function is usually called with the output from TellDir. */
-                       dptr->dir_hnd->offset = *poffset = END_OF_DIRECTORY_OFFSET;
-                       return dptr->wcard;
-               } else {
-                       /* If we get any other error than ENOENT or ENOTDIR
-                          then the file exists we just can't stat it. */
-                       if (errno != ENOENT && errno != ENOTDIR) {
-                               /* We need to set the underlying dir_hdn offset to -1 also as
-                                  this function is usually called with the output from TellDir. */
-                               dptr->dir_hnd->offset = *poffset = END_OF_DIRECTORY_OFFSET;
-                               return dptr->wcard;
-                       }
-               }
+       TALLOC_FREE(pathreal);
 
-               /* In case sensitive mode we don't search - we know if it doesn't exist 
-                  with a stat we will fail. */
+       name_temp = dptr_normal_ReadDirName(dptr, poffset, pst);
+       name = talloc_strdup(ctx, name_temp);
+       return name;
 
-               if (dptr->conn->case_sensitive) {
-                       /* We need to set the underlying dir_hnd offset to -1 also as
-                          this function is usually called with the output from TellDir. */
-                       dptr->dir_hnd->offset = *poffset = END_OF_DIRECTORY_OFFSET;
-                       return NULL;
-               }
-       }
-       return dptr_normal_ReadDirName(dptr, poffset, pst);
+clean:
+       TALLOC_FREE(pathreal);
+ret:
+       /* We need to set the underlying dir_hnd offset to -1
+        * also as this function is usually called with the
+        * output from TellDir. */
+       dptr->dir_hnd->offset = *poffset = END_OF_DIRECTORY_OFFSET;
+       return name;
 }
 
 /****************************************************************************
  Search for a file by name, skipping veto'ed and not visible files.
 ****************************************************************************/
 
-BOOL dptr_SearchDir(struct dptr_struct *dptr, const char *name, long *poffset, SMB_STRUCT_STAT *pst)
+bool dptr_SearchDir(struct dptr_struct *dptr, const char *name, long *poffset, SMB_STRUCT_STAT *pst)
 {
        SET_STAT_INVALID(*pst);
 
@@ -667,11 +714,19 @@ void dptr_DirCacheAdd(struct dptr_struct *dptr, const char *name, long offset)
        DirCacheAdd(dptr->dir_hnd, name, offset);
 }
 
+/****************************************************************************
+ Initialize variables & state data at the beginning of all search SMB requests.
+****************************************************************************/
+void dptr_init_search_op(struct dptr_struct *dptr)
+{
+       SMB_VFS_INIT_SEARCH_OP(dptr->conn, dptr->dir_hnd->dir);
+}
+
 /****************************************************************************
  Fill the 5 byte server reserved dptr field.
 ****************************************************************************/
 
-BOOL dptr_fill(char *buf1,unsigned int key)
+bool dptr_fill(char *buf1,unsigned int key)
 {
        unsigned char *buf = (unsigned char *)buf1;
        struct dptr_struct *dptr = dptr_get(key, False);
@@ -736,7 +791,7 @@ struct dptr_struct *dptr_fetch_lanman2(int dptr_num)
  Check that a file matches a particular file type.
 ****************************************************************************/
 
-BOOL dir_check_ftype(connection_struct *conn, uint32 mode, uint32 dirtype)
+bool dir_check_ftype(connection_struct *conn, uint32 mode, uint32 dirtype)
 {
        uint32 mask;
 
@@ -758,45 +813,60 @@ BOOL dir_check_ftype(connection_struct *conn, uint32 mode, uint32 dirtype)
        return True;
 }
 
-static BOOL mangle_mask_match(connection_struct *conn, fstring filename, char *mask)
+static bool mangle_mask_match(connection_struct *conn,
+               const char *filename,
+               const char *mask)
 {
-       mangle_map(filename,True,False,conn->params);
-       return mask_match_search(filename,mask,False);
+       char mname[13];
+
+       if (!name_to_8_3(filename,mname,False,conn->params)) {
+               return False;
+       }
+       return mask_match_search(mname,mask,False);
 }
 
 /****************************************************************************
  Get an 8.3 directory entry.
 ****************************************************************************/
 
-BOOL get_dir_entry(connection_struct *conn,char *mask,uint32 dirtype, pstring fname,
-                   SMB_OFF_T *size,uint32 *mode,time_t *date,BOOL check_descend)
+bool get_dir_entry(TALLOC_CTX *ctx,
+               connection_struct *conn,
+               const char *mask,
+               uint32 dirtype,
+               char **pp_fname_out,
+               SMB_OFF_T *size,
+               uint32 *mode,
+               struct timespec *date,
+               bool check_descend,
+               bool ask_sharemode)
 {
-       const char *dname;
-       BOOL found = False;
+       char *dname = NULL;
+       bool found = False;
        SMB_STRUCT_STAT sbuf;
-       pstring path;
-       pstring pathreal;
-       pstring filename;
-       BOOL needslash;
+       char *pathreal = NULL;
+       char *filename = NULL;
+       bool needslash;
 
-       *path = *pathreal = *filename = 0;
+       *pp_fname_out = NULL;
 
        needslash = ( conn->dirpath[strlen(conn->dirpath) -1] != '/');
 
-       if (!conn->dirptr)
+       if (!conn->dirptr) {
                return(False);
+       }
 
        while (!found) {
                long curoff = dptr_TellDir(conn->dirptr);
-               dname = dptr_ReadDirName(conn->dirptr, &curoff, &sbuf);
+               dname = dptr_ReadDirName(ctx, conn->dirptr, &curoff, &sbuf);
 
                DEBUG(6,("readdir on dirptr 0x%lx now at offset %ld\n",
                        (long)conn->dirptr,TellDir(conn->dirptr->dir_hnd)));
-      
-               if (dname == NULL) 
+
+               if (dname == NULL) {
                        return(False);
-      
-               pstrcpy(filename,dname);      
+               }
+
+               filename = dname;
 
                /* notice the special *.* handling. This appears to be the only difference
                        between the wildcard handling in this routine and in the trans2 routines.
@@ -805,40 +875,105 @@ BOOL get_dir_entry(connection_struct *conn,char *mask,uint32 dirtype, pstring fn
                if ((strcmp(mask,"*.*") == 0) ||
                    mask_match_search(filename,mask,False) ||
                    mangle_mask_match(conn,filename,mask)) {
+                       char mname[13];
 
-                       if (!mangle_is_8_3(filename, False, conn->params))
-                               mangle_map(filename,True,False,
-                                          conn->params);
-
-                       pstrcpy(fname,filename);
-                       *path = 0;
-                       pstrcpy(path,conn->dirpath);
-                       if(needslash)
-                               pstrcat(path,"/");
-                       pstrcpy(pathreal,path);
-                       pstrcat(path,fname);
-                       pstrcat(pathreal,dname);
-                       if (!VALID_STAT(sbuf) && (SMB_VFS_STAT(conn, pathreal, &sbuf)) != 0) {
-                               DEBUG(5,("Couldn't stat 1 [%s]. Error = %s\n",path, strerror(errno) ));
-                               continue;
+                       if (!mangle_is_8_3(filename, False, conn->params)) {
+                               if (!name_to_8_3(filename,mname,False,
+                                          conn->params)) {
+                                       TALLOC_FREE(filename);
+                                       continue;
+                               }
+                               filename = talloc_strdup(ctx, mname);
+                               if (!filename) {
+                                       return False;
+                               }
+                       }
+
+                       if (needslash) {
+                               pathreal = talloc_asprintf(ctx,
+                                               "%s/%s",
+                                               conn->dirpath,
+                                               dname);
+                       } else {
+                               pathreal = talloc_asprintf(ctx,
+                                               "%s%s",
+                                               conn->dirpath,
+                                               dname);
+                       }
+                       if (!pathreal) {
+                               TALLOC_FREE(filename);
+                               return False;
                        }
-         
+
+                       if (!VALID_STAT(sbuf)) {
+                               struct smb_filename *smb_fname = NULL;
+                               NTSTATUS status;
+
+                               /* Create smb_fname with NULL stream_name. */
+                               status =
+                                   create_synthetic_smb_fname(ctx, pathreal,
+                                                              NULL, NULL,
+                                                              &smb_fname);
+                               if (!NT_STATUS_IS_OK(status)) {
+                                       TALLOC_FREE(pathreal);
+                                       TALLOC_FREE(filename);
+                                       return NULL;
+                               }
+
+                               if ((SMB_VFS_STAT(conn, smb_fname)) != 0) {
+                                       DEBUG(5,("Couldn't stat 1 [%s]. Error "
+                                                "= %s\n", pathreal,
+                                                strerror(errno)));
+                                       TALLOC_FREE(smb_fname);
+                                       TALLOC_FREE(pathreal);
+                                       TALLOC_FREE(filename);
+                                       continue;
+                               }
+                               sbuf = smb_fname->st;
+                               TALLOC_FREE(smb_fname);
+                       }
+
                        *mode = dos_mode(conn,pathreal,&sbuf);
 
                        if (!dir_check_ftype(conn,*mode,dirtype)) {
                                DEBUG(5,("[%s] attribs 0x%x didn't match 0x%x\n",filename,(unsigned int)*mode,(unsigned int)dirtype));
+                               TALLOC_FREE(pathreal);
+                               TALLOC_FREE(filename);
                                continue;
                        }
 
-                       *size = sbuf.st_size;
-                       *date = sbuf.st_mtime;
+                       *size = sbuf.st_ex_size;
+                       *date = sbuf.st_ex_mtime;
+
+                       if (ask_sharemode) {
+                               struct timespec write_time_ts;
+                               struct file_id fileid;
+
+                               fileid = vfs_file_id_from_sbuf(conn, &sbuf);
+                               get_file_infos(fileid, NULL, &write_time_ts);
+                               if (!null_timespec(write_time_ts)) {
+                                       *date = write_time_ts;
+                               }
+                       }
 
-                       DEBUG(3,("get_dir_entry mask=[%s] found %s fname=%s\n",mask, pathreal,fname));
+                       DEBUG(3,("get_dir_entry mask=[%s] found %s "
+                               "fname=%s (%s)\n",
+                               mask,
+                               pathreal,
+                               dname,
+                               filename));
 
                        found = True;
 
+                       SMB_ASSERT(filename != NULL);
+                       *pp_fname_out = filename;
+
                        DirCacheAdd(conn->dirptr->dir_hnd, dname, curoff);
+                       TALLOC_FREE(pathreal);
                }
+
+               if (!found)
+                       TALLOC_FREE(filename);
        }
 
        return(found);
@@ -850,14 +985,9 @@ BOOL get_dir_entry(connection_struct *conn,char *mask,uint32 dirtype, pstring fn
  use it for anything security sensitive.
 ********************************************************************/
 
-static BOOL user_can_read_file(connection_struct *conn, char *name, SMB_STRUCT_STAT *pst)
+static bool user_can_read_file(connection_struct *conn,
+                              struct smb_filename *smb_fname)
 {
-       SEC_DESC *psd = NULL;
-       size_t sd_size;
-       files_struct *fsp;
-       NTSTATUS status;
-       uint32 access_granted;
-
        /*
         * If user is a member of the Admin group
         * we never hide files from them.
@@ -867,43 +997,7 @@ static BOOL user_can_read_file(connection_struct *conn, char *name, SMB_STRUCT_S
                return True;
        }
 
-       /* If we can't stat it does not show it */
-       if (!VALID_STAT(*pst) && (SMB_VFS_STAT(conn, name, pst) != 0)) {
-               DEBUG(10,("user_can_read_file: SMB_VFS_STAT failed for file %s with error %s\n",
-                       name, strerror(errno) ));
-               return False;
-       }
-
-       /* Pseudo-open the file (note - no fd's created). */
-
-       if(S_ISDIR(pst->st_mode)) {
-                status = open_directory(conn, NULL, name, pst,
-                       READ_CONTROL_ACCESS,
-                       FILE_SHARE_READ|FILE_SHARE_WRITE,
-                       FILE_OPEN,
-                       0, /* no create options. */
-                       FILE_ATTRIBUTE_DIRECTORY,
-                       NULL, &fsp);
-       } else {
-               status = open_file_stat(conn, NULL, name, pst, &fsp);
-       }
-
-       if (!NT_STATUS_IS_OK(status)) {
-               return False;
-       }
-
-       /* Get NT ACL -allocated in main loop talloc context. No free needed here. */
-       sd_size = SMB_VFS_FGET_NT_ACL(fsp, fsp->fh->fd,
-                       (OWNER_SECURITY_INFORMATION|GROUP_SECURITY_INFORMATION|DACL_SECURITY_INFORMATION), &psd);
-       close_file(fsp, NORMAL_CLOSE);
-
-       /* No access if SD get failed. */
-       if (!sd_size) {
-               return False;
-       }
-
-       return se_access_check(psd, current_user.nt_user_token, FILE_READ_DATA,
-                                 &access_granted, &status);
+       return can_access_file_acl(conn, smb_fname, FILE_READ_DATA);
 }
 
 /*******************************************************************
@@ -913,15 +1007,9 @@ static BOOL user_can_read_file(connection_struct *conn, char *name, SMB_STRUCT_S
  use it for anything security sensitive.
 ********************************************************************/
 
-static BOOL user_can_write_file(connection_struct *conn, char *name, SMB_STRUCT_STAT *pst)
+static bool user_can_write_file(connection_struct *conn,
+                               const struct smb_filename *smb_fname)
 {
-       SEC_DESC *psd = NULL;
-       size_t sd_size;
-       files_struct *fsp;
-       int info;
-       NTSTATUS status;
-       uint32 access_granted;
-
        /*
         * If user is a member of the Admin group
         * we never hide files from them.
@@ -931,48 +1019,23 @@ static BOOL user_can_write_file(connection_struct *conn, char *name, SMB_STRUCT_
                return True;
        }
 
-       /* If we can't stat it does not show it */
-       if (!VALID_STAT(*pst) && (SMB_VFS_STAT(conn, name, pst) != 0)) {
-               return False;
-       }
+       SMB_ASSERT(VALID_STAT(smb_fname->st));
 
        /* Pseudo-open the file */
 
-       if(S_ISDIR(pst->st_mode)) {
+       if(S_ISDIR(smb_fname->st.st_ex_mode)) {
                return True;
-       } else {
-               status = open_file_ntcreate(conn, NULL, name, pst,
-                       FILE_WRITE_ATTRIBUTES,
-                       FILE_SHARE_READ|FILE_SHARE_WRITE,
-                       FILE_OPEN,
-                       0,
-                       FILE_ATTRIBUTE_NORMAL,
-                       INTERNAL_OPEN_ONLY,
-                       &info, &fsp);
        }
 
-       if (!NT_STATUS_IS_OK(status)) {
-               return False;
-       }
-
-       /* Get NT ACL -allocated in main loop talloc context. No free needed here. */
-       sd_size = SMB_VFS_FGET_NT_ACL(fsp, fsp->fh->fd,
-                       (OWNER_SECURITY_INFORMATION|GROUP_SECURITY_INFORMATION|DACL_SECURITY_INFORMATION), &psd);
-       close_file(fsp, NORMAL_CLOSE);
-
-       /* No access if SD get failed. */
-       if (!sd_size)
-               return False;
-
-       return se_access_check(psd, current_user.nt_user_token, FILE_WRITE_DATA,
-                                 &access_granted, &status);
+       return can_write_to_file(conn, smb_fname);
 }
 
 /*******************************************************************
   Is a file a "special" type ?
 ********************************************************************/
 
-static BOOL file_is_special(connection_struct *conn, char *name, SMB_STRUCT_STAT *pst)
+static bool file_is_special(connection_struct *conn,
+                           const struct smb_filename *smb_fname)
 {
        /*
         * If user is a member of the Admin group
@@ -982,27 +1045,31 @@ static BOOL file_is_special(connection_struct *conn, char *name, SMB_STRUCT_STAT
        if (conn->admin_user)
                return False;
 
-       /* If we can't stat it does not show it */
-       if (!VALID_STAT(*pst) && (SMB_VFS_STAT(conn, name, pst) != 0))
-               return True;
+       SMB_ASSERT(VALID_STAT(smb_fname->st));
 
-       if (S_ISREG(pst->st_mode) || S_ISDIR(pst->st_mode) || S_ISLNK(pst->st_mode))
+       if (S_ISREG(smb_fname->st.st_ex_mode) ||
+           S_ISDIR(smb_fname->st.st_ex_mode) ||
+           S_ISLNK(smb_fname->st.st_ex_mode))
                return False;
 
        return True;
 }
 
 /*******************************************************************
- Should the file be seen by the client ?
+ Should the file be seen by the client?
+ NOTE: A successful return is no guarantee of the file's existence.
 ********************************************************************/
 
-BOOL is_visible_file(connection_struct *conn, const char *dir_path, const char *name, SMB_STRUCT_STAT *pst, BOOL use_veto)
+bool is_visible_file(connection_struct *conn, const char *dir_path,
+                    const char *name, SMB_STRUCT_STAT *pst, bool use_veto)
 {
-       BOOL hide_unreadable = lp_hideunreadable(SNUM(conn));
-       BOOL hide_unwriteable = lp_hideunwriteable_files(SNUM(conn));
-       BOOL hide_special = lp_hide_special_files(SNUM(conn));
-
-       SET_STAT_INVALID(*pst);
+       bool hide_unreadable = lp_hideunreadable(SNUM(conn));
+       bool hide_unwriteable = lp_hideunwriteable_files(SNUM(conn));
+       bool hide_special = lp_hide_special_files(SNUM(conn));
+       char *entry = NULL;
+       struct smb_filename *smb_fname_base = NULL;
+       NTSTATUS status;
+       bool ret = false;
 
        if ((strcmp(".",name) == 0) || (strcmp("..",name) == 0)) {
                return True; /* . and .. are always visible. */
@@ -1015,132 +1082,137 @@ BOOL is_visible_file(connection_struct *conn, const char *dir_path, const char *
        }
 
        if (hide_unreadable || hide_unwriteable || hide_special) {
-               pstring link_target;
-               char *entry = NULL;
-
-               if (asprintf(&entry, "%s/%s", dir_path, name) == -1) {
-                       return False;
+               entry = talloc_asprintf(talloc_tos(), "%s/%s", dir_path, name);
+               if (!entry) {
+                       ret = false;
+                       goto out;
                }
 
                /* If it's a dfs symlink, ignore _hide xxxx_ options */
                if (lp_host_msdfs() &&
                                lp_msdfs_root(SNUM(conn)) &&
-                               is_msdfs_link(conn, entry, link_target, NULL)) {
-                       SAFE_FREE(entry);
-                       return True;
+                               is_msdfs_link(conn, entry, NULL)) {
+                       ret = true;
+                       goto out;
+               }
+
+               /* Create an smb_filename with stream_name == NULL. */
+               status = create_synthetic_smb_fname(talloc_tos(), entry, NULL,
+                                                   pst, &smb_fname_base);
+               if (!NT_STATUS_IS_OK(status)) {
+                       ret = false;
+                       goto out;
+               }
+
+               /* If the file name does not exist, there's no point checking
+                * the configuration options. We succeed, on the basis that the
+                * checks *might* have passed if the file was present.
+                */
+               if (!VALID_STAT(*pst)) {
+                       if (SMB_VFS_STAT(conn, smb_fname_base) != 0) {
+                               ret = true;
+                               goto out;
+                       } else {
+                               *pst = smb_fname_base->st;
+                       }
                }
 
                /* Honour _hide unreadable_ option */
-               if (hide_unreadable && !user_can_read_file(conn, entry, pst)) {
-                       DEBUG(10,("is_visible_file: file %s is unreadable.\n", entry ));
-                       SAFE_FREE(entry);
-                       return False;
+               if (hide_unreadable &&
+                   !user_can_read_file(conn, smb_fname_base)) {
+                       DEBUG(10,("is_visible_file: file %s is unreadable.\n",
+                                entry ));
+                       ret = false;
+                       goto out;
                }
                /* Honour _hide unwriteable_ option */
-               if (hide_unwriteable && !user_can_write_file(conn, entry, pst)) {
-                       DEBUG(10,("is_visible_file: file %s is unwritable.\n", entry ));
-                       SAFE_FREE(entry);
-                       return False;
+               if (hide_unwriteable && !user_can_write_file(conn,
+                                                            smb_fname_base)) {
+                       DEBUG(10,("is_visible_file: file %s is unwritable.\n",
+                                entry ));
+                       ret = false;
+                       goto out;
                }
                /* Honour _hide_special_ option */
-               if (hide_special && file_is_special(conn, entry, pst)) {
-                       DEBUG(10,("is_visible_file: file %s is special.\n", entry ));
-                       SAFE_FREE(entry);
-                       return False;
+               if (hide_special && file_is_special(conn, smb_fname_base)) {
+                       DEBUG(10,("is_visible_file: file %s is special.\n",
+                                entry ));
+                       ret = false;
+                       goto out;
                }
-               SAFE_FREE(entry);
        }
-       return True;
+
+       ret = true;
+ out:
+       TALLOC_FREE(smb_fname_base);
+       TALLOC_FREE(entry);
+       return ret;
+}
+
+static int smb_Dir_destructor(struct smb_Dir *dirp)
+{
+       if (dirp->dir) {
+               SMB_VFS_CLOSEDIR(dirp->conn,dirp->dir);
+       }
+       dirhandles_open--;
+       return 0;
 }
 
 /*******************************************************************
  Open a directory.
 ********************************************************************/
 
-struct smb_Dir *OpenDir(connection_struct *conn, const char *name, const char *mask, uint32 attr)
+struct smb_Dir *OpenDir(TALLOC_CTX *mem_ctx, connection_struct *conn,
+                       const char *name, const char *mask, uint32 attr)
 {
-       struct smb_Dir *dirp = SMB_MALLOC_P(struct smb_Dir);
+       struct smb_Dir *dirp = TALLOC_ZERO_P(mem_ctx, struct smb_Dir);
 
        if (!dirp) {
                return NULL;
        }
-       ZERO_STRUCTP(dirp);
 
        dirp->conn = conn;
        dirp->name_cache_size = lp_directory_name_cache_size(SNUM(conn));
 
-       dirp->dir_path = SMB_STRDUP(name);
+       dirp->dir_path = talloc_strdup(dirp, name);
        if (!dirp->dir_path) {
+               errno = ENOMEM;
                goto fail;
        }
+
+       dirhandles_open++;
+       talloc_set_destructor(dirp, smb_Dir_destructor);
+
        dirp->dir = SMB_VFS_OPENDIR(conn, dirp->dir_path, mask, attr);
        if (!dirp->dir) {
-               DEBUG(5,("OpenDir: Can't open %s. %s\n", dirp->dir_path, strerror(errno) ));
+               DEBUG(5,("OpenDir: Can't open %s. %s\n", dirp->dir_path,
+                        strerror(errno) ));
                goto fail;
        }
 
-       if (dirp->name_cache_size) {
-               dirp->name_cache = SMB_CALLOC_ARRAY(struct name_cache_entry,
-                               dirp->name_cache_size);
-               if (!dirp->name_cache) {
-                       goto fail;
-               }
-       } else {
-               dirp->name_cache = NULL;
-       }
-
-       dirhandles_open++;
        return dirp;
 
   fail:
-
-       if (dirp) {
-               if (dirp->dir) {
-                       SMB_VFS_CLOSEDIR(conn,dirp->dir);
-               }
-               SAFE_FREE(dirp->dir_path);
-               SAFE_FREE(dirp->name_cache);
-               SAFE_FREE(dirp);
-       }
+       TALLOC_FREE(dirp);
        return NULL;
 }
 
-
 /*******************************************************************
- Close a directory.
-********************************************************************/
-
-int CloseDir(struct smb_Dir *dirp)
-{
-       int i, ret = 0;
-
-       if (dirp->dir) {
-               ret = SMB_VFS_CLOSEDIR(dirp->conn,dirp->dir);
-       }
-       SAFE_FREE(dirp->dir_path);
-       if (dirp->name_cache) {
-               for (i = 0; i < dirp->name_cache_size; i++) {
-                       SAFE_FREE(dirp->name_cache[i].name);
-               }
-       }
-       SAFE_FREE(dirp->name_cache);
-       SAFE_FREE(dirp);
-       dirhandles_open--;
-       return ret;
-}
-
-/*******************************************************************
- Read from a directory. Also return current offset.
+ Read from a directory.
+ Return directory entry, current offset, and optional stat information.
  Don't check for veto or invisible files.
 ********************************************************************/
 
-const char *ReadDirName(struct smb_Dir *dirp, long *poffset)
+const char *ReadDirName(struct smb_Dir *dirp, long *poffset,
+                       SMB_STRUCT_STAT *sbuf)
 {
        const char *n;
        connection_struct *conn = dirp->conn;
 
        /* Cheat to allow . and .. to be the first entries returned. */
-       if (((*poffset == START_OF_DIRECTORY_OFFSET) || (*poffset == DOT_DOT_DIRECTORY_OFFSET)) && (dirp->file_number < 2)) {
+       if (((*poffset == START_OF_DIRECTORY_OFFSET) ||
+            (*poffset == DOT_DOT_DIRECTORY_OFFSET)) && (dirp->file_number < 2))
+       {
                if (dirp->file_number == 0) {
                        n = ".";
                        *poffset = dirp->offset = START_OF_DIRECTORY_OFFSET;
@@ -1158,7 +1230,7 @@ const char *ReadDirName(struct smb_Dir *dirp, long *poffset)
                SeekDir(dirp, *poffset);
        }
 
-       while ((n = vfs_readdirname(conn, dirp->dir))) {
+       while ((n = vfs_readdirname(conn, dirp->dir, sbuf))) {
                /* Ignore . and .. - we've already returned them. */
                if (*n == '.') {
                        if ((n[1] == '\0') || (n[1] == '.' && n[2] == '\0')) {
@@ -1194,7 +1266,7 @@ void SeekDir(struct smb_Dir *dirp, long offset)
        if (offset != dirp->offset) {
                if (offset == START_OF_DIRECTORY_OFFSET) {
                        RewindDir(dirp, &offset);
-                       /* 
+                       /*
                         * Ok we should really set the file number here
                         * to 1 to enable ".." to be returned next. Trouble
                         * is I'm worried about callers using SeekDir(dirp,0)
@@ -1235,15 +1307,24 @@ void DirCacheAdd(struct smb_Dir *dirp, const char *name, long offset)
 {
        struct name_cache_entry *e;
 
-       if (!dirp->name_cache_size || !dirp->name_cache) {
+       if (dirp->name_cache_size == 0) {
                return;
        }
 
+       if (dirp->name_cache == NULL) {
+               dirp->name_cache = TALLOC_ZERO_ARRAY(
+                       dirp, struct name_cache_entry, dirp->name_cache_size);
+
+               if (dirp->name_cache == NULL) {
+                       return;
+               }
+       }
+
        dirp->name_cache_index = (dirp->name_cache_index+1) %
                                        dirp->name_cache_size;
        e = &dirp->name_cache[dirp->name_cache_index];
-       SAFE_FREE(e->name);
-       e->name = SMB_STRDUP(name);
+       TALLOC_FREE(e->name);
+       e->name = talloc_strdup(dirp, name);
        e->offset = offset;
 }
 
@@ -1252,7 +1333,7 @@ void DirCacheAdd(struct smb_Dir *dirp, const char *name, long offset)
  Don't check for veto or invisible files.
 ********************************************************************/
 
-BOOL SearchDir(struct smb_Dir *dirp, const char *name, long *poffset)
+bool SearchDir(struct smb_Dir *dirp, const char *name, long *poffset)
 {
        int i;
        const char *entry;
@@ -1282,7 +1363,7 @@ BOOL SearchDir(struct smb_Dir *dirp, const char *name, long *poffset)
        SMB_VFS_REWINDDIR(conn, dirp->dir);
        dirp->file_number = 0;
        *poffset = START_OF_DIRECTORY_OFFSET;
-       while ((entry = ReadDirName(dirp, poffset))) {
+       while ((entry = ReadDirName(dirp, poffset, NULL))) {
                if (conn->case_sensitive ? (strcmp(entry, name) == 0) : strequal(entry, name)) {
                        return True;
                }
@@ -1300,15 +1381,15 @@ NTSTATUS can_delete_directory(struct connection_struct *conn,
        NTSTATUS status = NT_STATUS_OK;
        long dirpos = 0;
        const char *dname;
-       struct smb_Dir *dir_hnd = OpenDir(conn, dirname, NULL, 0);
+       SMB_STRUCT_STAT st;
+       struct smb_Dir *dir_hnd = OpenDir(talloc_tos(), conn, dirname,
+                                         NULL, 0);
 
        if (!dir_hnd) {
                return map_nt_error_from_unix(errno);
        }
 
-       while ((dname = ReadDirName(dir_hnd,&dirpos))) {
-               SMB_STRUCT_STAT st;
-
+       while ((dname = ReadDirName(dir_hnd, &dirpos, &st))) {
                /* Quick check for "." and ".." */
                if (dname[0] == '.') {
                        if (!dname[1] || (dname[1] == '.' && !dname[2])) {
@@ -1320,11 +1401,12 @@ NTSTATUS can_delete_directory(struct connection_struct *conn,
                        continue;
                }
 
-               DEBUG(10,("can_delete_directory: got name %s - can't delete\n", dname ));
+               DEBUG(10,("can_delete_directory: got name %s - can't delete\n",
+                        dname ));
                status = NT_STATUS_DIRECTORY_NOT_EMPTY;
                break;
        }
-       CloseDir(dir_hnd);
+       TALLOC_FREE(dir_hnd);
 
        return status;
 }