Fix all warnings in source3 with gcc4.3.
[ira/wip.git] / source3 / rpcclient / cmd_spoolss.c
index a16c7ea52073e2aec96d35ed89680dd522368ab5..ecd0f36217af6ecfb307f1183359c9dc24cfc47d 100644 (file)
@@ -9,7 +9,7 @@
  
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
@@ -18,8 +18,7 @@
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
@@ -110,9 +109,9 @@ static WERROR cmd_spoolss_open_printer_ex(struct rpc_pipe_client *cli,
        if (!cli)
             return WERR_GENERAL_FAILURE;
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
        fstrcpy(printername, argv[1]);
 
        /* Open the printer handle */
@@ -318,7 +317,7 @@ static WERROR cmd_spoolss_enum_printers(struct rpc_pipe_client *cli,
        if (argc == 3)
                fstrcpy(name, argv[2]);
        else {
-               slprintf(name, sizeof(name)-1, "\\\\%s", cli->cli->desthost);
+               slprintf(name, sizeof(name)-1, "\\\\%s", cli->desthost);
                strupper_m(name);
        }
 
@@ -471,7 +470,7 @@ static WERROR cmd_spoolss_setprinter(struct rpc_pipe_client *cli,
        POLICY_HND      pol;
        WERROR          result;
        uint32          info_level = 2;
-       BOOL            opened_hnd = False;
+       bool            opened_hnd = False;
        PRINTER_INFO_CTR ctr;
        fstring         printername,
                        servername,
@@ -489,10 +488,10 @@ static WERROR cmd_spoolss_setprinter(struct rpc_pipe_client *cli,
                fstrcpy(comment, argv[2]);
        }
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
        slprintf(printername, sizeof(servername)-1, "%s\\%s", servername, argv[1]);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
 
        /* get a printer handle */
        result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "", 
@@ -537,7 +536,7 @@ static WERROR cmd_spoolss_setprintername(struct rpc_pipe_client *cli,
        POLICY_HND      pol;
        WERROR          result;
        uint32          info_level = 2;
-       BOOL            opened_hnd = False;
+       bool            opened_hnd = False;
        PRINTER_INFO_CTR ctr;
        fstring         printername,
                        servername,
@@ -555,10 +554,10 @@ static WERROR cmd_spoolss_setprintername(struct rpc_pipe_client *cli,
                fstrcpy(new_printername, argv[2]);
        }
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
        slprintf(printername, sizeof(printername)-1, "%s\\%s", servername, argv[1]);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
 
        /* get a printer handle */
        result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "", 
@@ -602,7 +601,7 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
        POLICY_HND      pol;
        WERROR          result;
        uint32          info_level = 1;
-       BOOL            opened_hnd = False;
+       bool            opened_hnd = False;
        PRINTER_INFO_CTR ctr;
        fstring         printername,
                        servername,
@@ -618,10 +617,10 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
                info_level = atoi(argv[2]);
        }
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
        slprintf(printername, sizeof(printername)-1, "%s\\%s", servername, argv[1]);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
        
        /* get a printer handle */
 
@@ -676,20 +675,23 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
 
 static void display_reg_value(REGISTRY_VALUE value)
 {
-       pstring text;
+       char *text = NULL;
 
        switch(value.type) {
        case REG_DWORD:
-               printf("%s: REG_DWORD: 0x%08x\n", value.valuename, 
+               printf("%s: REG_DWORD: 0x%08x\n", value.valuename,
                       *((uint32 *) value.data_p));
                break;
        case REG_SZ:
-               rpcstr_pull(text, value.data_p, sizeof(text), value.size,
-                           STR_TERMINATE);
-               printf("%s: REG_SZ: %s\n", value.valuename, text);
+               rpcstr_pull_talloc(talloc_tos(),
+                               &text,
+                               value.data_p,
+                               value.size,
+                               STR_TERMINATE);
+               printf("%s: REG_SZ: %s\n", value.valuename, text ? text : "");
                break;
        case REG_BINARY: {
-               char *hex = hex_encode(NULL, value.data_p, value.size);
+               char *hex = hex_encode_talloc(NULL, value.data_p, value.size);
                size_t i, len;
                printf("%s: REG_BINARY:", value.valuename);
                len = strlen(hex);
@@ -738,7 +740,7 @@ static WERROR cmd_spoolss_getprinterdata(struct rpc_pipe_client *cli,
 {
        POLICY_HND      pol;
        WERROR          result;
-       BOOL            opened_hnd = False;
+       bool            opened_hnd = False;
        fstring         printername,
                        servername,
                        user;
@@ -754,14 +756,14 @@ static WERROR cmd_spoolss_getprinterdata(struct rpc_pipe_client *cli,
 
        /* Open a printer handle */
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
        if (strncmp(argv[1], ".", sizeof(".")) == 0)
                fstrcpy(printername, servername);
        else
                slprintf(printername, sizeof(servername)-1, "%s\\%s", 
                          servername, argv[1]);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
        
        /* get a printer handle */
 
@@ -803,7 +805,7 @@ static WERROR cmd_spoolss_getprinterdataex(struct rpc_pipe_client *cli,
 {
        POLICY_HND      pol;
        WERROR          result;
-       BOOL            opened_hnd = False;
+       bool            opened_hnd = False;
        fstring         printername,
                        servername,
                        user;
@@ -821,14 +823,14 @@ static WERROR cmd_spoolss_getprinterdataex(struct rpc_pipe_client *cli,
 
        /* Open a printer handle */
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
        if (strncmp(argv[1], ".", sizeof(".")) == 0)
                fstrcpy(printername, servername);
        else
                slprintf(printername, sizeof(printername)-1, "%s\\%s", 
                          servername, argv[1]);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
        
        /* get a printer handle */
 
@@ -925,7 +927,7 @@ static void display_print_driver_3(DRIVER_INFO_3 *i1)
        fstring defaultdatatype = "";
        
        int length=0;
-       BOOL valid = True;
+       bool valid = True;
        
        if (i1 == NULL)
                return;
@@ -982,13 +984,13 @@ static WERROR cmd_spoolss_getdriver(struct rpc_pipe_client *cli,
        POLICY_HND      pol;
        WERROR          werror;
        uint32          info_level = 3;
-       BOOL            opened_hnd = False;
+       bool            opened_hnd = False;
        PRINTER_DRIVER_CTR      ctr;
        fstring         printername, 
                        servername, 
                        user;
        uint32          i;
-       BOOL            success = False;
+       bool            success = False;
 
        if ((argc == 1) || (argc > 3)) 
        {
@@ -997,9 +999,9 @@ static WERROR cmd_spoolss_getdriver(struct rpc_pipe_client *cli,
        }
 
        /* get the arguments need to open the printer handle */
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
        slprintf(printername, sizeof(servername)-1, "%s\\%s", servername, argv[1]);
        if (argc == 3)
                info_level = atoi(argv[2]);
@@ -1217,12 +1219,13 @@ void set_drv_info_3_env (DRIVER_INFO_3 *info, const char *arch)
  Needed to handle the empty parameter string denoted by "NULL"
  *************************************************************************/
  
-static char* get_driver_3_param (char* str, const char* delim, UNISTR* dest)
+static char* get_driver_3_param (char* str, const char* delim, UNISTR* dest,
+                                char **saveptr)
 {
        char    *ptr;
 
        /* get the next token */
-       ptr = strtok(str, delim);
+       ptr = strtok_r(str, delim, saveptr);
 
        /* a string of 'NULL' is used to represent an empty
           parameter because two consecutive delimiters
@@ -1244,33 +1247,35 @@ static char* get_driver_3_param (char* str, const char* delim, UNISTR* dest)
             <Config File Name>:<Help File Name>:<Language Monitor Name>:\
             <Default Data Type>:<Comma Separated list of Files> 
  *******************************************************************************/
-static BOOL init_drv_info_3_members ( TALLOC_CTX *mem_ctx, DRIVER_INFO_3 *info, 
+static bool init_drv_info_3_members ( TALLOC_CTX *mem_ctx, DRIVER_INFO_3 *info, 
                                       char *args )
 {
        char    *str, *str2;
        uint32  len, i;
-       
+       char *saveptr = NULL;
+
        /* fill in the UNISTR fields */
-       str = get_driver_3_param (args, ":", &info->name);
-       str = get_driver_3_param (NULL, ":", &info->driverpath);
-       str = get_driver_3_param (NULL, ":", &info->datafile);
-       str = get_driver_3_param (NULL, ":", &info->configfile);
-       str = get_driver_3_param (NULL, ":", &info->helpfile);
-       str = get_driver_3_param (NULL, ":", &info->monitorname);
-       str = get_driver_3_param (NULL, ":", &info->defaultdatatype);
+       str = get_driver_3_param (args, ":", &info->name, &saveptr);
+       str = get_driver_3_param (NULL, ":", &info->driverpath, &saveptr);
+       str = get_driver_3_param (NULL, ":", &info->datafile, &saveptr);
+       str = get_driver_3_param (NULL, ":", &info->configfile, &saveptr);
+       str = get_driver_3_param (NULL, ":", &info->helpfile, &saveptr);
+       str = get_driver_3_param (NULL, ":", &info->monitorname, &saveptr);
+       str = get_driver_3_param (NULL, ":", &info->defaultdatatype, &saveptr);
 
        /* <Comma Separated List of Dependent Files> */
-       str2 = get_driver_3_param (NULL, ":", NULL); /* save the beginning of the string */
-       str = str2;                     
+       /* save the beginning of the string */
+       str2 = get_driver_3_param (NULL, ":", NULL, &saveptr);
+       str = str2;
 
        /* begin to strip out each filename */
-       str = strtok(str, ",");         
+       str = strtok_r(str, ",", &saveptr);
        len = 0;
        while (str != NULL)
        {
                /* keep a cumlative count of the str lengths */
                len += strlen(str)+1;
-               str = strtok(NULL, ",");
+               str = strtok_r(NULL, ",", &saveptr);
        }
 
        /* allocate the space; add one extra slot for a terminating NULL.
@@ -1306,7 +1311,7 @@ static WERROR cmd_spoolss_addprinterdriver(struct rpc_pipe_client *cli,
        fstring                 driver_name;
        char                    *driver_args;
 
-       /* parse the command arguements */
+       /* parse the command arguments */
        if (argc != 3 && argc != 4)
        {
                printf ("Usage: %s <Environment> \\\n", argv[0]);
@@ -1371,14 +1376,14 @@ static WERROR cmd_spoolss_addprinterex(struct rpc_pipe_client *cli,
        PRINTER_INFO_2          info2;
        fstring                 servername;
        
-       /* parse the command arguements */
+       /* parse the command arguments */
        if (argc != 5)
        {
                printf ("Usage: %s <name> <shared name> <driver> <port>\n", argv[0]);
                return WERR_OK;
         }
        
-        slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+        slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
         strupper_m(servername);
 
        /* Fill in the DRIVER_INFO_2 struct */
@@ -1426,24 +1431,24 @@ static WERROR cmd_spoolss_setdriver(struct rpc_pipe_client *cli,
        POLICY_HND              pol;
        WERROR                  result;
        uint32                  level = 2;
-       BOOL                    opened_hnd = False;
+       bool                    opened_hnd = False;
        PRINTER_INFO_CTR        ctr;
        PRINTER_INFO_2          info2;
        fstring                 servername,
                                printername,
                                user;
        
-       /* parse the command arguements */
+       /* parse the command arguments */
        if (argc != 3)
        {
                printf ("Usage: %s <printer> <driver>\n", argv[0]);
                return WERR_OK;
         }
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
        slprintf(printername, sizeof(printername)-1, "%s\\%s", servername, argv[1]);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
 
        /* Get a printer handle */
 
@@ -1479,7 +1484,7 @@ static WERROR cmd_spoolss_setdriver(struct rpc_pipe_client *cli,
                goto done;;
        }
 
-       printf("Succesfully set %s to driver %s.\n", argv[1], argv[2]);
+       printf("Successfully set %s to driver %s.\n", argv[1], argv[2]);
 
 done:
        /* Cleanup */
@@ -1505,7 +1510,7 @@ static WERROR cmd_spoolss_deletedriverex(struct rpc_pipe_client *cli,
  
        const char *arch = NULL;
  
-       /* parse the command arguements */
+       /* parse the command arguments */
        if (argc < 2 || argc > 4) {
                printf ("Usage: %s <driver> [arch] [version]\n", argv[0]);
                return WERR_OK;
@@ -1534,7 +1539,7 @@ static WERROR cmd_spoolss_deletedriverex(struct rpc_pipe_client *cli,
                {
                        if ( !W_ERROR_EQUAL(result, WERR_UNKNOWN_PRINTER_DRIVER) ) {
                                printf ("Failed to remove driver %s for arch [%s] (version: %d): %s\n", 
-                                       argv[1], archi_table[i].long_archi, archi_table[i].version, dos_errstr(result));
+                                       argv[1], archi_table[i].long_archi, archi_table[i].version, win_errstr(result));
                        }
                } 
                else 
@@ -1560,13 +1565,13 @@ static WERROR cmd_spoolss_deletedriver(struct rpc_pipe_client *cli,
        fstring                 servername;
        int                     i;
        
-       /* parse the command arguements */
+       /* parse the command arguments */
        if (argc != 2) {
                printf ("Usage: %s <driver>\n", argv[0]);
                return WERR_OK;
         }
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
 
        /* delete the driver for all architectures */
@@ -1601,13 +1606,13 @@ static WERROR cmd_spoolss_getprintprocdir(struct rpc_pipe_client *cli,
        char *servername = NULL, *environment = NULL;
        fstring procdir;
        
-       /* parse the command arguements */
+       /* parse the command arguments */
        if (argc > 2) {
                printf ("Usage: %s [environment]\n", argv[0]);
                return WERR_OK;
         }
 
-       if (asprintf(&servername, "\\\\%s", cli->cli->desthost) < 0)
+       if (asprintf(&servername, "\\\\%s", cli->desthost) < 0)
                return WERR_NOMEM;
        strupper_m(servername);
 
@@ -1639,9 +1644,9 @@ static WERROR cmd_spoolss_addform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        WERROR werror;
        char *servername = NULL, *printername = NULL;
        FORM form;
-       BOOL got_handle = False;
+       bool got_handle = False;
        
-       /* Parse the command arguements */
+       /* Parse the command arguments */
 
        if (argc != 3) {
                printf ("Usage: %s <printer> <formname>\n", argv[0]);
@@ -1650,13 +1655,19 @@ static WERROR cmd_spoolss_addform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        
        /* Get a printer handle */
 
-       asprintf(&servername, "\\\\%s", cli->cli->desthost);
+       if (asprintf(&servername, "\\\\%s", cli->desthost) == -1) {
+               return WERR_NOMEM;
+       }
        strupper_m(servername);
-       asprintf(&printername, "%s\\%s", servername, argv[1]);
+       if (asprintf(&printername, "%s\\%s", servername, argv[1]) == -1) {
+               SAFE_FREE(servername);
+               return WERR_NOMEM;
+       }
 
        werror = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "", 
                                             PRINTER_ALL_ACCESS, 
-                                            servername, cli->user_name, &handle);
+                                            servername, cli->auth->user_name,
+                                            &handle);
 
        if (!W_ERROR_IS_OK(werror))
                goto done;
@@ -1699,9 +1710,9 @@ static WERROR cmd_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        WERROR werror;
        char *servername = NULL, *printername = NULL;
        FORM form;
-       BOOL got_handle = False;
+       bool got_handle = False;
        
-       /* Parse the command arguements */
+       /* Parse the command arguments */
 
        if (argc != 3) {
                printf ("Usage: %s <printer> <formname>\n", argv[0]);
@@ -1710,13 +1721,18 @@ static WERROR cmd_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        
        /* Get a printer handle */
 
-       asprintf(&servername, "\\\\%s", cli->cli->desthost);
+       if (asprintf(&servername, "\\\\%s", cli->desthost)) {
+               return WERR_NOMEM;
+       }
        strupper_m(servername);
-       asprintf(&printername, "%s\\%s", servername, argv[1]);
+       if (asprintf(&printername, "%s\\%s", servername, argv[1]) == -1) {
+               SAFE_FREE(servername);
+               return WERR_NOMEM;
+       }
 
        werror = rpccli_spoolss_open_printer_ex(
                cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS, 
-               servername, cli->user_name, &handle);
+               servername, cli->auth->user_name, &handle);
 
        if (!W_ERROR_IS_OK(werror))
                goto done;
@@ -1796,9 +1812,9 @@ static WERROR cmd_spoolss_getform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        WERROR werror;
        char *servername = NULL, *printername = NULL;
        FORM_1 form;
-       BOOL got_handle = False;
+       bool got_handle = False;
        
-       /* Parse the command arguements */
+       /* Parse the command arguments */
 
        if (argc != 3) {
                printf ("Usage: %s <printer> <formname>\n", argv[0]);
@@ -1807,13 +1823,18 @@ static WERROR cmd_spoolss_getform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        
        /* Get a printer handle */
 
-       asprintf(&servername, "\\\\%s", cli->cli->desthost);
+       if (asprintf(&servername, "\\\\%s", cli->desthost) == -1) {
+               return WERR_NOMEM;
+       }
        strupper_m(servername);
-       asprintf(&printername, "%s\\%s", servername, argv[1]);
+       if (asprintf(&printername, "%s\\%s", servername, argv[1])) {
+               SAFE_FREE(servername);
+               return WERR_NOMEM;
+       }
 
        werror = rpccli_spoolss_open_printer_ex(
                cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS, 
-               servername, cli->user_name, &handle);
+               servername, cli->auth->user_name, &handle);
 
        if (!W_ERROR_IS_OK(werror))
                goto done;
@@ -1849,9 +1870,9 @@ static WERROR cmd_spoolss_deleteform(struct rpc_pipe_client *cli,
        POLICY_HND handle;
        WERROR werror;
        char *servername = NULL, *printername = NULL;
-       BOOL got_handle = False;
+       bool got_handle = False;
        
-       /* Parse the command arguements */
+       /* Parse the command arguments */
 
        if (argc != 3) {
                printf ("Usage: %s <printer> <formname>\n", argv[0]);
@@ -1860,13 +1881,18 @@ static WERROR cmd_spoolss_deleteform(struct rpc_pipe_client *cli,
        
        /* Get a printer handle */
 
-       asprintf(&servername, "\\\\%s", cli->cli->desthost);
+       if (asprintf(&servername, "\\\\%s", cli->desthost) == -1) {
+               return WERR_NOMEM;
+       }
        strupper_m(servername);
-       asprintf(&printername, "%s\\%s", servername, argv[1]);
+       if (asprintf(&printername, "%s\\%s", servername, argv[1]) == -1) {
+               SAFE_FREE(servername);
+               return WERR_NOMEM;
+       }
 
        werror = rpccli_spoolss_open_printer_ex(
                cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS, 
-               servername, cli->user_name, &handle);
+               servername, cli->auth->user_name, &handle);
 
        if (!W_ERROR_IS_OK(werror))
                goto done;
@@ -1897,11 +1923,11 @@ static WERROR cmd_spoolss_enum_forms(struct rpc_pipe_client *cli,
        POLICY_HND handle;
        WERROR werror;
        char *servername = NULL, *printername = NULL;
-       BOOL got_handle = False;
+       bool got_handle = False;
        uint32 num_forms, level = 1, i;
        FORM_1 *forms;
        
-       /* Parse the command arguements */
+       /* Parse the command arguments */
 
        if (argc != 2) {
                printf ("Usage: %s <printer>\n", argv[0]);
@@ -1910,13 +1936,18 @@ static WERROR cmd_spoolss_enum_forms(struct rpc_pipe_client *cli,
        
        /* Get a printer handle */
 
-       asprintf(&servername, "\\\\%s", cli->cli->desthost);
+       if (asprintf(&servername, "\\\\%s", cli->desthost) == -1) {
+               return WERR_NOMEM;
+       }
        strupper_m(servername);
-       asprintf(&printername, "%s\\%s", servername, argv[1]);
+       if (asprintf(&printername, "%s\\%s", servername, argv[1]) == -1) {
+               SAFE_FREE(servername);
+               return WERR_NOMEM;
+       }
 
        werror = rpccli_spoolss_open_printer_ex(
                cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS, 
-               servername, cli->user_name, &handle);
+               servername, cli->auth->user_name, &handle);
 
        if (!W_ERROR_IS_OK(werror))
                goto done;
@@ -1958,23 +1989,25 @@ static WERROR cmd_spoolss_setprinterdata(struct rpc_pipe_client *cli,
        WERROR result;
        fstring servername, printername, user;
        POLICY_HND pol;
-       BOOL opened_hnd = False;
+       bool opened_hnd = False;
        PRINTER_INFO_CTR ctr;
        PRINTER_INFO_0 info;
        REGISTRY_VALUE value;
+       TALLOC_CTX *tmp_ctx = talloc_stackframe();
 
-       /* parse the command arguements */
+       /* parse the command arguments */
        if (argc < 5) {
                printf ("Usage: %s <printer> <string|binary|dword|multistring>"
                        " <value> <data>\n",
                        argv[0]);
-               return WERR_INVALID_PARAM;
+               result = WERR_INVALID_PARAM;
+               goto done;
        }
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
        slprintf(printername, sizeof(servername)-1, "%s\\%s", servername, argv[1]);
-       fstrcpy(user, cli->user_name);
+       fstrcpy(user, cli->auth->user_name);
 
        value.type = REG_NONE;
 
@@ -1996,7 +2029,8 @@ static WERROR cmd_spoolss_setprinterdata(struct rpc_pipe_client *cli,
 
        if (value.type == REG_NONE) {
                printf("Unknown data type: %s\n", argv[2]);
-               return WERR_INVALID_PARAM;
+               result =  WERR_INVALID_PARAM;
+               goto done;
        }
 
        /* get a printer handle */
@@ -2015,7 +2049,7 @@ static WERROR cmd_spoolss_setprinterdata(struct rpc_pipe_client *cli,
         if (!W_ERROR_IS_OK(result))
                 goto done;
                
-       printf("%s\n", current_timestring(True));
+       printf("%s\n", current_timestring(tmp_ctx, True));
        printf("\tchange_id (before set)\t:[0x%x]\n", info.change_id);
 
        /* Set the printer data */
@@ -2101,11 +2135,12 @@ static WERROR cmd_spoolss_setprinterdata(struct rpc_pipe_client *cli,
         if (!W_ERROR_IS_OK(result))
                 goto done;
                
-       printf("%s\n", current_timestring(True));
+       printf("%s\n", current_timestring(tmp_ctx, True));
        printf("\tchange_id (after set)\t:[0x%x]\n", info.change_id);
 
 done:
        /* cleanup */
+       TALLOC_FREE(tmp_ctx);
        if (opened_hnd)
                rpccli_spoolss_close_printer(cli, mem_ctx, &pol);
 
@@ -2163,36 +2198,42 @@ static WERROR cmd_spoolss_enum_jobs(struct rpc_pipe_client *cli,
 {
        WERROR result;
        uint32 level = 1, num_jobs, i;
-       BOOL got_hnd = False;
-       pstring printername;
+       bool got_hnd = False;
+       char *printername = NULL;
        fstring servername, user;
        POLICY_HND hnd;
        JOB_INFO_CTR ctr;
-       
+
        if (argc < 2 || argc > 3) {
                printf("Usage: %s printername [level]\n", argv[0]);
                return WERR_OK;
        }
-       
+
        if (argc == 3)
                level = atoi(argv[2]);
 
        /* Open printer handle */
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
-       fstrcpy(user, cli->user_name);
-       slprintf(printername, sizeof(servername)-1, "\\\\%s\\", cli->cli->desthost);
+       fstrcpy(user, cli->auth->user_name);
+       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
        strupper_m(printername);
-       pstrcat(printername, argv[1]);
+       printername = talloc_asprintf_append(printername, "%s", argv[1]);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
 
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, 
-                                            "", MAXIMUM_ALLOWED_ACCESS, 
+       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
+                                            "", MAXIMUM_ALLOWED_ACCESS,
                                             servername, user, &hnd);
 
        if (!W_ERROR_IS_OK(result))
                goto done;
+
        got_hnd = True;
 
        /* Enumerate ports */
@@ -2233,8 +2274,8 @@ static WERROR cmd_spoolss_enum_data( struct rpc_pipe_client *cli,
 {
        WERROR result;
        uint32 i=0, val_needed, data_needed;
-       BOOL got_hnd = False;
-       pstring printername;
+       bool got_hnd = False;
+       char *printername = NULL;
        fstring servername, user;
        POLICY_HND hnd;
 
@@ -2242,18 +2283,24 @@ static WERROR cmd_spoolss_enum_data( struct rpc_pipe_client *cli,
                printf("Usage: %s printername\n", argv[0]);
                return WERR_OK;
        }
-       
+
        /* Open printer handle */
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
-       fstrcpy(user, cli->user_name);
-       slprintf(printername, sizeof(printername)-1, "\\\\%s\\", cli->cli->desthost);
+       fstrcpy(user, cli->auth->user_name);
+       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
        strupper_m(printername);
-       pstrcat(printername, argv[1]);
+       printername = talloc_asprintf_append(printername, "%s", argv[1]);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
 
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, 
-                                            "", MAXIMUM_ALLOWED_ACCESS, 
+       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
+                                            "", MAXIMUM_ALLOWED_ACCESS,
                                             servername, user, &hnd);
 
        if (!W_ERROR_IS_OK(result))
@@ -2293,8 +2340,8 @@ static WERROR cmd_spoolss_enum_data_ex( struct rpc_pipe_client *cli,
 {
        WERROR result;
        uint32 i;
-       BOOL got_hnd = False;
-       pstring printername;
+       bool got_hnd = False;
+       char *printername = NULL;
        fstring servername, user;
        const char *keyname = NULL;
        POLICY_HND hnd;
@@ -2304,17 +2351,24 @@ static WERROR cmd_spoolss_enum_data_ex( struct rpc_pipe_client *cli,
                printf("Usage: %s printername <keyname>\n", argv[0]);
                return WERR_OK;
        }
-       
+
        keyname = argv[2];
 
        /* Open printer handle */
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
-       fstrcpy(user, cli->user_name);
-       slprintf(printername, sizeof(printername)-1, "\\\\%s\\", cli->cli->desthost);
+       fstrcpy(user, cli->auth->user_name);
+
+       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
        strupper_m(printername);
-       pstrcat(printername, argv[1]);
+       printername = talloc_asprintf_append(printername, "%s", argv[1]);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
 
        result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, 
                                             "", MAXIMUM_ALLOWED_ACCESS, 
@@ -2356,8 +2410,8 @@ static WERROR cmd_spoolss_enum_printerkey( struct rpc_pipe_client *cli,
                                             const char **argv)
 {
        WERROR result;
-       BOOL got_hnd = False;
-       pstring printername;
+       bool got_hnd = False;
+       char *printername = NULL;
        fstring servername, user;
        const char *keyname = NULL;
        POLICY_HND hnd;
@@ -2367,7 +2421,7 @@ static WERROR cmd_spoolss_enum_printerkey( struct rpc_pipe_client *cli,
                printf("Usage: %s printername [keyname]\n", argv[0]);
                return WERR_OK;
        }
-               
+
        if (argc == 3)
                keyname = argv[2];
        else
@@ -2375,12 +2429,20 @@ static WERROR cmd_spoolss_enum_printerkey( struct rpc_pipe_client *cli,
 
        /* Open printer handle */
 
-       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername)-1, "\\\\%s", cli->desthost);
        strupper_m(servername);
-       fstrcpy(user, cli->user_name);
-       slprintf(printername, sizeof(printername)-1, "\\\\%s\\", cli->cli->desthost);
+       fstrcpy(user, cli->auth->user_name);
+
+       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
        strupper_m(printername);
-       pstrcat(printername, argv[1]);
+       printername = talloc_asprintf_append(printername, "%s", argv[1]);
+       if (!printername) {
+               return WERR_NOMEM;
+       }
+
 
        result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, 
                                             "", MAXIMUM_ALLOWED_ACCESS, 
@@ -2400,9 +2462,12 @@ static WERROR cmd_spoolss_enum_printerkey( struct rpc_pipe_client *cli,
 
        curkey = keylist;
        while (*curkey != 0) {
-               pstring subkey;
-               rpcstr_pull(subkey, curkey, sizeof(subkey), -1, 
+               char *subkey = NULL;
+               rpcstr_pull_talloc(mem_ctx, &subkey, curkey, -1,
                            STR_TERMINATE);
+               if (!subkey) {
+                       break;
+               }
                printf("%s\n", subkey);
                curkey += strlen(subkey) + 1;
        }
@@ -2426,7 +2491,7 @@ static WERROR cmd_spoolss_rffpcnex(struct rpc_pipe_client *cli,
 {
        fstring servername, printername;
        POLICY_HND hnd;
-       BOOL got_hnd = False;
+       bool got_hnd = False;
        WERROR result;
        SPOOL_NOTIFY_OPTION option;
 
@@ -2438,16 +2503,16 @@ static WERROR cmd_spoolss_rffpcnex(struct rpc_pipe_client *cli,
 
        /* Open printer */
 
-       slprintf(servername, sizeof(servername) - 1, "\\\\%s", cli->cli->desthost);
+       slprintf(servername, sizeof(servername) - 1, "\\\\%s", cli->desthost);
        strupper_m(servername);
 
-       slprintf(printername, sizeof(printername) - 1, "\\\\%s\\%s", cli->cli->desthost,
-                argv[1]);
+       slprintf(printername, sizeof(printername) - 1, "\\\\%s\\%s",
+                cli->desthost, argv[1]);
        strupper_m(printername);
 
        result = rpccli_spoolss_open_printer_ex(
                cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS, 
-               servername, cli->user_name, &hnd);
+               servername, cli->auth->user_name, &hnd);
 
        if (!W_ERROR_IS_OK(result)) {
                printf("Error opening %s\n", argv[1]);
@@ -2505,26 +2570,26 @@ done:
 /****************************************************************************
 ****************************************************************************/
 
-static BOOL compare_printer( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
+static bool compare_printer( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
                              struct rpc_pipe_client *cli2, POLICY_HND *hnd2 )
 {
        PRINTER_INFO_CTR ctr1, ctr2;
        WERROR werror;
        TALLOC_CTX *mem_ctx = talloc_init("compare_printer");
 
-       printf("Retrieving printer propertiesfor %s...", cli1->cli->desthost);
+       printf("Retrieving printer propertiesfor %s...", cli1->desthost);
        werror = rpccli_spoolss_getprinter( cli1, mem_ctx, hnd1, 2, &ctr1);
        if ( !W_ERROR_IS_OK(werror) ) {
-               printf("failed (%s)\n", dos_errstr(werror));
+               printf("failed (%s)\n", win_errstr(werror));
                talloc_destroy(mem_ctx);
                return False;
        }
        printf("ok\n");
 
-       printf("Retrieving printer properties for %s...", cli2->cli->desthost);
+       printf("Retrieving printer properties for %s...", cli2->desthost);
        werror = rpccli_spoolss_getprinter( cli2, mem_ctx, hnd2, 2, &ctr2);
        if ( !W_ERROR_IS_OK(werror) ) {
-               printf("failed (%s)\n", dos_errstr(werror));
+               printf("failed (%s)\n", win_errstr(werror));
                talloc_destroy(mem_ctx);
                return False;
        }
@@ -2538,29 +2603,29 @@ static BOOL compare_printer( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
 /****************************************************************************
 ****************************************************************************/
 
-static BOOL compare_printer_secdesc( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
+static bool compare_printer_secdesc( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
                                      struct rpc_pipe_client *cli2, POLICY_HND *hnd2 )
 {
        PRINTER_INFO_CTR ctr1, ctr2;
        WERROR werror;
        TALLOC_CTX *mem_ctx = talloc_init("compare_printer_secdesc");
        SEC_DESC *sd1, *sd2;
-       BOOL result = True;
+       bool result = True;
 
 
-       printf("Retreiving printer security for %s...", cli1->cli->desthost);
+       printf("Retrieving printer security for %s...", cli1->desthost);
        werror = rpccli_spoolss_getprinter( cli1, mem_ctx, hnd1, 3, &ctr1);
        if ( !W_ERROR_IS_OK(werror) ) {
-               printf("failed (%s)\n", dos_errstr(werror));
+               printf("failed (%s)\n", win_errstr(werror));
                result = False;
                goto done;
        }
        printf("ok\n");
 
-       printf("Retrieving printer security for %s...", cli2->cli->desthost);
+       printf("Retrieving printer security for %s...", cli2->desthost);
        werror = rpccli_spoolss_getprinter( cli2, mem_ctx, hnd2, 3, &ctr2);
        if ( !W_ERROR_IS_OK(werror) ) {
-               printf("failed (%s)\n", dos_errstr(werror));
+               printf("failed (%s)\n", win_errstr(werror));
                result = False;
                goto done;
        }
@@ -2601,76 +2666,89 @@ done:
 /****************************************************************************
 ****************************************************************************/
 
+extern struct user_auth_info *rpcclient_auth_info;
+
 static WERROR cmd_spoolss_printercmp(struct rpc_pipe_client *cli, 
                                     TALLOC_CTX *mem_ctx, int argc, 
                                     const char **argv)
 {
        fstring printername, servername1, servername2;
-       pstring printername_path;
-       struct cli_state *cli_server1 = cli->cli;
+       char *printername_path = NULL;
+       struct cli_state *cli_server1 = rpc_pipe_np_smb_conn(cli);
        struct cli_state *cli_server2 = NULL;
        struct rpc_pipe_client *cli2 = NULL;
        POLICY_HND hPrinter1, hPrinter2;
        NTSTATUS nt_status;
        WERROR werror;
-       
+
        if ( argc != 3 )  {
                printf("Usage: %s <printer> <server>\n", argv[0]);
                return WERR_OK;
        }
-       
+
        fstrcpy( printername, argv[1] );
-       
-       fstr_sprintf( servername1, cli->cli->desthost );
+
+       fstrcpy( servername1, cli->desthost );
        fstrcpy( servername2, argv[2] );
        strupper_m( servername1 );
        strupper_m( servername2 );
-       
-       
+
        /* first get the connection to the remote server */
-       
+
        nt_status = cli_full_connection(&cli_server2, global_myname(), servername2, 
                                        NULL, 0,
-                                       "IPC$", "IPC",  
-                                       cmdline_auth_info.username, 
+                                       "IPC$", "IPC",
+                                       get_cmdline_auth_info_username(rpcclient_auth_info),
                                        lp_workgroup(),
-                                       cmdline_auth_info.password, 
-                                       cmdline_auth_info.use_kerberos ? CLI_FULL_CONNECTION_USE_KERBEROS : 0,
-                                       cmdline_auth_info.signing_state, NULL);
-                                       
+                                       get_cmdline_auth_info_password(rpcclient_auth_info),
+                                       get_cmdline_auth_info_use_kerberos(rpcclient_auth_info) ? CLI_FULL_CONNECTION_USE_KERBEROS : 0,
+                                       get_cmdline_auth_info_signing_state(rpcclient_auth_info), NULL);
+
        if ( !NT_STATUS_IS_OK(nt_status) )
                return WERR_GENERAL_FAILURE;
 
-       cli2 = cli_rpc_pipe_open_noauth(cli_server2, PI_SPOOLSS, &nt_status);
-       if (!cli2) {
+       nt_status = cli_rpc_pipe_open_noauth(cli_server2, &syntax_spoolss,
+                                            &cli2);
+       if (!NT_STATUS_IS_OK(nt_status)) {
                printf("failed to open spoolss pipe on server %s (%s)\n",
                        servername2, nt_errstr(nt_status));
                return WERR_GENERAL_FAILURE;
        }
-                                       
+
        /* now open up both printers */
 
-       pstr_sprintf( printername_path, "\\\\%s\\%s", servername1, printername );
+       printername_path = talloc_asprintf(mem_ctx,
+                               "\\\\%s\\%s",
+                               servername1,
+                               printername);
+       if (!printername_path) {
+               return WERR_NOMEM;
+       }
        printf("Opening %s...", printername_path);
        werror = rpccli_spoolss_open_printer_ex( cli, mem_ctx, printername_path, 
                "", PRINTER_ALL_ACCESS, servername1, cli_server1->user_name, &hPrinter1);
        if ( !W_ERROR_IS_OK(werror) ) {
-               printf("failed (%s)\n", dos_errstr(werror));
+               printf("failed (%s)\n", win_errstr(werror));
                goto done;
        }
        printf("ok\n");
-       
-       pstr_sprintf( printername_path, "\\\\%s\\%s", servername2, printername );
+
+       printername_path = talloc_asprintf(mem_ctx,
+                                       "\\\\%s\\%s",
+                                       servername2,
+                                       printername);
+       if (!printername_path) {
+               return WERR_NOMEM;
+       }
        printf("Opening %s...", printername_path);
        werror = rpccli_spoolss_open_printer_ex( cli2, mem_ctx, printername_path,  
                "", PRINTER_ALL_ACCESS, servername2, cli_server2->user_name, &hPrinter2 );
        if ( !W_ERROR_IS_OK(werror) ) {
-                printf("failed (%s)\n", dos_errstr(werror));
+                printf("failed (%s)\n", win_errstr(werror));
                goto done;
        }
        printf("ok\n");
-       
-       
+
        compare_printer( cli, &hPrinter1, cli2, &hPrinter2 );
        compare_printer_secdesc( cli, &hPrinter1, cli2, &hPrinter2 );
 #if 0
@@ -2681,15 +2759,14 @@ static WERROR cmd_spoolss_printercmp(struct rpc_pipe_client *cli,
 done:
        /* cleanup */
 
-       printf("Closing printers...");  
+       printf("Closing printers...");
        rpccli_spoolss_close_printer( cli, mem_ctx, &hPrinter1 );
        rpccli_spoolss_close_printer( cli2, mem_ctx, &hPrinter2 );
        printf("ok\n");
-       
+
        /* close the second remote connection */
-       
+
        cli_shutdown( cli_server2 );
-       
        return WERR_OK;
 }
 
@@ -2698,35 +2775,35 @@ struct cmd_set spoolss_commands[] = {
 
        { "SPOOLSS"  },
 
-       { "adddriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_addprinterdriver,   PI_SPOOLSS, NULL, "Add a print driver",                  "" },
-       { "addprinter",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_addprinterex,       PI_SPOOLSS, NULL, "Add a printer",                       "" },
-       { "deldriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_deletedriver,       PI_SPOOLSS, NULL, "Delete a printer driver",             "" },
-       { "deldriverex",        RPC_RTYPE_WERROR, NULL, cmd_spoolss_deletedriverex,     PI_SPOOLSS, NULL, "Delete a printer driver with files",  "" },
-       { "enumdata",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_data,          PI_SPOOLSS, NULL, "Enumerate printer data",              "" },
-       { "enumdataex",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_data_ex,       PI_SPOOLSS, NULL, "Enumerate printer data for a key",    "" },
-       { "enumkey",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_printerkey,    PI_SPOOLSS, NULL, "Enumerate printer keys",              "" },
-       { "enumjobs",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_jobs,          PI_SPOOLSS, NULL, "Enumerate print jobs",                "" },
-       { "enumports",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_ports,         PI_SPOOLSS, NULL, "Enumerate printer ports",             "" },
-       { "enumdrivers",        RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_drivers,       PI_SPOOLSS, NULL, "Enumerate installed printer drivers", "" },
-       { "enumprinters",       RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_printers,      PI_SPOOLSS, NULL, "Enumerate printers",                  "" },
-       { "getdata",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprinterdata,     PI_SPOOLSS, NULL, "Get print driver data",               "" },
-       { "getdataex",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprinterdataex,   PI_SPOOLSS, NULL, "Get printer driver data with keyname", ""},
-       { "getdriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_getdriver,          PI_SPOOLSS, NULL, "Get print driver information",        "" },
-       { "getdriverdir",       RPC_RTYPE_WERROR, NULL, cmd_spoolss_getdriverdir,       PI_SPOOLSS, NULL, "Get print driver upload directory",   "" },
-       { "getprinter",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprinter,         PI_SPOOLSS, NULL, "Get printer info",                    "" },
-       { "openprinter",        RPC_RTYPE_WERROR, NULL, cmd_spoolss_open_printer_ex,    PI_SPOOLSS, NULL, "Open printer handle",                 "" },
-       { "setdriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_setdriver,          PI_SPOOLSS, NULL, "Set printer driver",                  "" },
-       { "getprintprocdir",    RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprintprocdir,    PI_SPOOLSS, NULL, "Get print processor directory",       "" },
-       { "addform",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_addform,            PI_SPOOLSS, NULL, "Add form",                            "" },
-       { "setform",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_setform,            PI_SPOOLSS, NULL, "Set form",                            "" },
-       { "getform",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_getform,            PI_SPOOLSS, NULL, "Get form",                            "" },
-       { "deleteform",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_deleteform,         PI_SPOOLSS, NULL, "Delete form",                         "" },
-       { "enumforms",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_forms,         PI_SPOOLSS, NULL, "Enumerate forms",                     "" },
-       { "setprinter",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_setprinter,         PI_SPOOLSS, NULL, "Set printer comment",                 "" },
-       { "setprintername",     RPC_RTYPE_WERROR, NULL, cmd_spoolss_setprintername,     PI_SPOOLSS, NULL, "Set printername",                 "" },
-       { "setprinterdata",     RPC_RTYPE_WERROR, NULL, cmd_spoolss_setprinterdata,     PI_SPOOLSS, NULL, "Set REG_SZ printer data",             "" },
-       { "rffpcnex",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_rffpcnex,           PI_SPOOLSS, NULL, "Rffpcnex test", "" },
-       { "printercmp",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_printercmp,         PI_SPOOLSS, NULL, "Printer comparison test", "" },
+       { "adddriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_addprinterdriver,   &syntax_spoolss, NULL, "Add a print driver",                  "" },
+       { "addprinter",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_addprinterex,       &syntax_spoolss, NULL, "Add a printer",                       "" },
+       { "deldriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_deletedriver,       &syntax_spoolss, NULL, "Delete a printer driver",             "" },
+       { "deldriverex",        RPC_RTYPE_WERROR, NULL, cmd_spoolss_deletedriverex,     &syntax_spoolss, NULL, "Delete a printer driver with files",  "" },
+       { "enumdata",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_data,          &syntax_spoolss, NULL, "Enumerate printer data",              "" },
+       { "enumdataex",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_data_ex,       &syntax_spoolss, NULL, "Enumerate printer data for a key",    "" },
+       { "enumkey",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_printerkey,    &syntax_spoolss, NULL, "Enumerate printer keys",              "" },
+       { "enumjobs",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_jobs,          &syntax_spoolss, NULL, "Enumerate print jobs",                "" },
+       { "enumports",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_ports,         &syntax_spoolss, NULL, "Enumerate printer ports",             "" },
+       { "enumdrivers",        RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_drivers,       &syntax_spoolss, NULL, "Enumerate installed printer drivers", "" },
+       { "enumprinters",       RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_printers,      &syntax_spoolss, NULL, "Enumerate printers",                  "" },
+       { "getdata",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprinterdata,     &syntax_spoolss, NULL, "Get print driver data",               "" },
+       { "getdataex",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprinterdataex,   &syntax_spoolss, NULL, "Get printer driver data with keyname", ""},
+       { "getdriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_getdriver,          &syntax_spoolss, NULL, "Get print driver information",        "" },
+       { "getdriverdir",       RPC_RTYPE_WERROR, NULL, cmd_spoolss_getdriverdir,       &syntax_spoolss, NULL, "Get print driver upload directory",   "" },
+       { "getprinter",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprinter,         &syntax_spoolss, NULL, "Get printer info",                    "" },
+       { "openprinter",        RPC_RTYPE_WERROR, NULL, cmd_spoolss_open_printer_ex,    &syntax_spoolss, NULL, "Open printer handle",                 "" },
+       { "setdriver",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_setdriver,          &syntax_spoolss, NULL, "Set printer driver",                  "" },
+       { "getprintprocdir",    RPC_RTYPE_WERROR, NULL, cmd_spoolss_getprintprocdir,    &syntax_spoolss, NULL, "Get print processor directory",       "" },
+       { "addform",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_addform,            &syntax_spoolss, NULL, "Add form",                            "" },
+       { "setform",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_setform,            &syntax_spoolss, NULL, "Set form",                            "" },
+       { "getform",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_getform,            &syntax_spoolss, NULL, "Get form",                            "" },
+       { "deleteform",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_deleteform,         &syntax_spoolss, NULL, "Delete form",                         "" },
+       { "enumforms",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_forms,         &syntax_spoolss, NULL, "Enumerate forms",                     "" },
+       { "setprinter",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_setprinter,         &syntax_spoolss, NULL, "Set printer comment",                 "" },
+       { "setprintername",     RPC_RTYPE_WERROR, NULL, cmd_spoolss_setprintername,     &syntax_spoolss, NULL, "Set printername",                 "" },
+       { "setprinterdata",     RPC_RTYPE_WERROR, NULL, cmd_spoolss_setprinterdata,     &syntax_spoolss, NULL, "Set REG_SZ printer data",             "" },
+       { "rffpcnex",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_rffpcnex,           &syntax_spoolss, NULL, "Rffpcnex test", "" },
+       { "printercmp",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_printercmp,         &syntax_spoolss, NULL, "Printer comparison test", "" },
 
        { NULL }
 };