s3-rpcclient: use rpccli_spoolss_enumprinterkey wrapper.
[ira/wip.git] / source3 / rpcclient / cmd_spoolss.c
index aba961a22d20aa13fdbf1de777a0e5302ddda348..aba2939343fbdb48f58e60406fd6f12840ab51f1 100644 (file)
 #include "includes.h"
 #include "rpcclient.h"
 
+#define RPCCLIENT_PRINTERNAME(_printername, _cli, _arg) \
+{ \
+       _printername = talloc_asprintf_strupper_m(mem_ctx, "%s\\%s", \
+               _cli->srv_name_slash, _arg); \
+       W_ERROR_HAVE_NO_MEMORY(_printername); \
+}
+
 struct table_node {
        const char      *long_archi;
        const char      *short_archi;
@@ -97,7 +104,6 @@ static WERROR cmd_spoolss_open_printer_ex(struct rpc_pipe_client *cli,
                                             int argc, const char **argv)
 {
        WERROR          werror;
-       fstring         printername;
        POLICY_HND      hnd;
 
        if (argc != 2) {
@@ -108,17 +114,14 @@ static WERROR cmd_spoolss_open_printer_ex(struct rpc_pipe_client *cli,
        if (!cli)
             return WERR_GENERAL_FAILURE;
 
-       fstrcpy(printername, argv[1]);
-
        /* Open the printer handle */
 
-       werror = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", PRINTER_ALL_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &hnd);
-
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              argv[1],
+                                              PRINTER_ALL_ACCESS,
+                                              &hnd);
        if (W_ERROR_IS_OK(werror)) {
-               printf("Printer %s opened successfully\n", printername);
+               printf("Printer %s opened successfully\n", argv[1]);
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &hnd, &werror);
 
                if (!W_ERROR_IS_OK(werror)) {
@@ -134,57 +137,45 @@ static WERROR cmd_spoolss_open_printer_ex(struct rpc_pipe_client *cli,
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_info_0(PRINTER_INFO_0 *i0)
+static void display_print_info0(struct spoolss_PrinterInfo0 *r)
 {
-       fstring name = "";
-       fstring servername = "";
-
-       if (!i0)
+       if (!r)
                return;
 
-       rpcstr_pull(name, i0->printername.buffer, sizeof(name), -1, STR_TERMINATE);
-
-       rpcstr_pull(servername, i0->servername.buffer, sizeof(servername), -1,STR_TERMINATE);
-
-       printf("\tprintername:[%s]\n", name);
-       printf("\tservername:[%s]\n", servername);
-       printf("\tcjobs:[0x%x]\n", i0->cjobs);
-       printf("\ttotal_jobs:[0x%x]\n", i0->total_jobs);
-
-       printf("\t:date: [%d]-[%d]-[%d] (%d)\n", i0->year, i0->month,
-              i0->day, i0->dayofweek);
-       printf("\t:time: [%d]-[%d]-[%d]-[%d]\n", i0->hour, i0->minute,
-              i0->second, i0->milliseconds);
-
-       printf("\tglobal_counter:[0x%x]\n", i0->global_counter);
-       printf("\ttotal_pages:[0x%x]\n", i0->total_pages);
-
-       printf("\tmajorversion:[0x%x]\n", i0->major_version);
-       printf("\tbuildversion:[0x%x]\n", i0->build_version);
-
-       printf("\tunknown7:[0x%x]\n", i0->unknown7);
-       printf("\tunknown8:[0x%x]\n", i0->unknown8);
-       printf("\tunknown9:[0x%x]\n", i0->unknown9);
-       printf("\tsession_counter:[0x%x]\n", i0->session_counter);
-       printf("\tunknown11:[0x%x]\n", i0->unknown11);
-       printf("\tprinter_errors:[0x%x]\n", i0->printer_errors);
-       printf("\tunknown13:[0x%x]\n", i0->unknown13);
-       printf("\tunknown14:[0x%x]\n", i0->unknown14);
-       printf("\tunknown15:[0x%x]\n", i0->unknown15);
-       printf("\tunknown16:[0x%x]\n", i0->unknown16);
-       printf("\tchange_id:[0x%x]\n", i0->change_id);
-       printf("\tunknown18:[0x%x]\n", i0->unknown18);
-       printf("\tstatus:[0x%x]\n", i0->status);
-       printf("\tunknown20:[0x%x]\n", i0->unknown20);
-       printf("\tc_setprinter:[0x%x]\n", i0->c_setprinter);
-       printf("\tunknown22:[0x%x]\n", i0->unknown22);
-       printf("\tunknown23:[0x%x]\n", i0->unknown23);
-       printf("\tunknown24:[0x%x]\n", i0->unknown24);
-       printf("\tunknown25:[0x%x]\n", i0->unknown25);
-       printf("\tunknown26:[0x%x]\n", i0->unknown26);
-       printf("\tunknown27:[0x%x]\n", i0->unknown27);
-       printf("\tunknown28:[0x%x]\n", i0->unknown28);
-       printf("\tunknown29:[0x%x]\n", i0->unknown29);
+       printf("\tprintername:[%s]\n", r->printername);
+       printf("\tservername:[%s]\n", r->servername);
+       printf("\tcjobs:[0x%x]\n", r->cjobs);
+       printf("\ttotal_jobs:[0x%x]\n", r->total_jobs);
+       printf("\ttotal_bytes:[0x%x]\n", r->total_bytes);
+       printf("\t:date: [%d]-[%d]-[%d] (%d)\n", r->time.year, r->time.month,
+              r->time.day, r->time.day_of_week);
+       printf("\t:time: [%d]-[%d]-[%d]-[%d]\n", r->time.hour, r->time.minute,
+              r->time.second, r->time.millisecond);
+
+       printf("\tglobal_counter:[0x%x]\n", r->global_counter);
+       printf("\ttotal_pages:[0x%x]\n", r->total_pages);
+
+       printf("\tversion:[0x%x]\n", r->version);
+       printf("\tfree_build:[0x%x]\n", r->free_build);
+       printf("\tspooling:[0x%x]\n", r->spooling);
+       printf("\tmax_spooling:[0x%x]\n", r->max_spooling);
+       printf("\tsession_counter:[0x%x]\n", r->session_counter);
+       printf("\tnum_error_out_of_paper:[0x%x]\n", r->num_error_out_of_paper);
+       printf("\tnum_error_not_ready:[0x%x]\n", r->num_error_not_ready);
+       printf("\tjob_error:[0x%x]\n", r->job_error);
+       printf("\tnumber_of_processors:[0x%x]\n", r->number_of_processors);
+       printf("\tprocessor_type:[0x%x]\n", r->processor_type);
+       printf("\thigh_part_total_bytes:[0x%x]\n", r->high_part_total_bytes);
+       printf("\tchange_id:[0x%x]\n", r->change_id);
+       printf("\tlast_error: %s\n", win_errstr(r->last_error));
+       printf("\tstatus:[0x%x]\n", r->status);
+       printf("\tenumerate_network_printers:[0x%x]\n", r->enumerate_network_printers);
+       printf("\tc_setprinter:[0x%x]\n", r->c_setprinter);
+       printf("\tprocessor_architecture:[0x%x]\n", r->processor_architecture);
+       printf("\tprocessor_level:[0x%x]\n", r->processor_level);
+       printf("\tref_ic:[0x%x]\n", r->ref_ic);
+       printf("\treserved2:[0x%x]\n", r->reserved2);
+       printf("\treserved3:[0x%x]\n", r->reserved3);
 
        printf("\n");
 }
@@ -192,22 +183,12 @@ static void display_print_info_0(PRINTER_INFO_0 *i0)
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_info_1(PRINTER_INFO_1 *i1)
+static void display_print_info1(struct spoolss_PrinterInfo1 *r)
 {
-       fstring desc = "";
-       fstring name = "";
-       fstring comm = "";
-
-       rpcstr_pull(desc, i1->description.buffer, sizeof(desc), -1,
-                   STR_TERMINATE);
-
-       rpcstr_pull(name, i1->name.buffer, sizeof(name), -1, STR_TERMINATE);
-       rpcstr_pull(comm, i1->comment.buffer, sizeof(comm), -1, STR_TERMINATE);
-
-       printf("\tflags:[0x%x]\n", i1->flags);
-       printf("\tname:[%s]\n", name);
-       printf("\tdescription:[%s]\n", desc);
-       printf("\tcomment:[%s]\n", comm);
+       printf("\tflags:[0x%x]\n", r->flags);
+       printf("\tname:[%s]\n", r->name);
+       printf("\tdescription:[%s]\n", r->description);
+       printf("\tcomment:[%s]\n", r->comment);
 
        printf("\n");
 }
@@ -215,54 +196,30 @@ static void display_print_info_1(PRINTER_INFO_1 *i1)
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_info_2(PRINTER_INFO_2 *i2)
+static void display_print_info2(struct spoolss_PrinterInfo2 *r)
 {
-       fstring servername = "";
-       fstring printername = "";
-       fstring sharename = "";
-       fstring portname = "";
-       fstring drivername = "";
-       fstring comment = "";
-       fstring location = "";
-       fstring sepfile = "";
-       fstring printprocessor = "";
-       fstring datatype = "";
-       fstring parameters = "";
-
-       rpcstr_pull(servername, i2->servername.buffer,sizeof(servername), -1, STR_TERMINATE);
-       rpcstr_pull(printername, i2->printername.buffer,sizeof(printername), -1, STR_TERMINATE);
-       rpcstr_pull(sharename, i2->sharename.buffer,sizeof(sharename), -1, STR_TERMINATE);
-       rpcstr_pull(portname, i2->portname.buffer,sizeof(portname), -1, STR_TERMINATE);
-       rpcstr_pull(drivername, i2->drivername.buffer,sizeof(drivername), -1, STR_TERMINATE);
-       rpcstr_pull(comment, i2->comment.buffer,sizeof(comment), -1, STR_TERMINATE);
-       rpcstr_pull(location, i2->location.buffer,sizeof(location), -1, STR_TERMINATE);
-       rpcstr_pull(sepfile, i2->sepfile.buffer,sizeof(sepfile), -1, STR_TERMINATE);
-       rpcstr_pull(printprocessor, i2->printprocessor.buffer,sizeof(printprocessor), -1, STR_TERMINATE);
-       rpcstr_pull(datatype, i2->datatype.buffer,sizeof(datatype), -1, STR_TERMINATE);
-       rpcstr_pull(parameters, i2->parameters.buffer,sizeof(parameters), -1, STR_TERMINATE);
-
-       printf("\tservername:[%s]\n", servername);
-       printf("\tprintername:[%s]\n", printername);
-       printf("\tsharename:[%s]\n", sharename);
-       printf("\tportname:[%s]\n", portname);
-       printf("\tdrivername:[%s]\n", drivername);
-       printf("\tcomment:[%s]\n", comment);
-       printf("\tlocation:[%s]\n", location);
-       printf("\tsepfile:[%s]\n", sepfile);
-       printf("\tprintprocessor:[%s]\n", printprocessor);
-       printf("\tdatatype:[%s]\n", datatype);
-       printf("\tparameters:[%s]\n", parameters);
-       printf("\tattributes:[0x%x]\n", i2->attributes);
-       printf("\tpriority:[0x%x]\n", i2->priority);
-       printf("\tdefaultpriority:[0x%x]\n", i2->defaultpriority);
-       printf("\tstarttime:[0x%x]\n", i2->starttime);
-       printf("\tuntiltime:[0x%x]\n", i2->untiltime);
-       printf("\tstatus:[0x%x]\n", i2->status);
-       printf("\tcjobs:[0x%x]\n", i2->cjobs);
-       printf("\taverageppm:[0x%x]\n", i2->averageppm);
-
-       if (i2->secdesc)
-               display_sec_desc(i2->secdesc);
+       printf("\tservername:[%s]\n", r->servername);
+       printf("\tprintername:[%s]\n", r->printername);
+       printf("\tsharename:[%s]\n", r->sharename);
+       printf("\tportname:[%s]\n", r->portname);
+       printf("\tdrivername:[%s]\n", r->drivername);
+       printf("\tcomment:[%s]\n", r->comment);
+       printf("\tlocation:[%s]\n", r->location);
+       printf("\tsepfile:[%s]\n", r->sepfile);
+       printf("\tprintprocessor:[%s]\n", r->printprocessor);
+       printf("\tdatatype:[%s]\n", r->datatype);
+       printf("\tparameters:[%s]\n", r->parameters);
+       printf("\tattributes:[0x%x]\n", r->attributes);
+       printf("\tpriority:[0x%x]\n", r->priority);
+       printf("\tdefaultpriority:[0x%x]\n", r->defaultpriority);
+       printf("\tstarttime:[0x%x]\n", r->starttime);
+       printf("\tuntiltime:[0x%x]\n", r->untiltime);
+       printf("\tstatus:[0x%x]\n", r->status);
+       printf("\tcjobs:[0x%x]\n", r->cjobs);
+       printf("\taverageppm:[0x%x]\n", r->averageppm);
+
+       if (r->secdesc)
+               display_sec_desc(r->secdesc);
 
        printf("\n");
 }
@@ -270,9 +227,9 @@ static void display_print_info_2(PRINTER_INFO_2 *i2)
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_info_3(PRINTER_INFO_3 *i3)
+static void display_print_info3(struct spoolss_PrinterInfo3 *r)
 {
-       display_sec_desc(i3->secdesc);
+       display_sec_desc(r->secdesc);
 
        printf("\n");
 }
@@ -280,12 +237,10 @@ static void display_print_info_3(PRINTER_INFO_3 *i3)
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_info_7(PRINTER_INFO_7 *i7)
+static void display_print_info7(struct spoolss_PrinterInfo7 *r)
 {
-       fstring guid = "";
-       rpcstr_pull(guid, i7->guid.buffer,sizeof(guid), -1, STR_TERMINATE);
-       printf("\tguid:[%s]\n", guid);
-       printf("\taction:[0x%x]\n", i7->action);
+       printf("\tguid:[%s]\n", r->guid);
+       printf("\taction:[0x%x]\n", r->action);
 }
 
 
@@ -293,64 +248,65 @@ static void display_print_info_7(PRINTER_INFO_7 *i7)
 ****************************************************************************/
 
 static WERROR cmd_spoolss_enum_printers(struct rpc_pipe_client *cli,
-                                          TALLOC_CTX *mem_ctx,
-                                          int argc, const char **argv)
+                                       TALLOC_CTX *mem_ctx,
+                                       int argc, const char **argv)
 {
        WERROR                  result;
-       uint32                  info_level = 1;
-       PRINTER_INFO_CTR        ctr;
-       uint32                  i = 0, num_printers;
-       fstring name;
+       uint32_t                level = 1;
+       union spoolss_PrinterInfo *info;
+       uint32_t                i, count;
+       const char *name;
 
-       if (argc > 3)
-       {
+       if (argc > 3) {
                printf("Usage: %s [level] [name]\n", argv[0]);
                return WERR_OK;
        }
 
-       if (argc >= 2)
-               info_level = atoi(argv[1]);
-
-       if (argc == 3)
-               fstrcpy(name, argv[2]);
-       else {
-               slprintf(name, sizeof(name)-1, "\\\\%s", cli->desthost);
-               strupper_m(name);
+       if (argc >= 2) {
+               level = atoi(argv[1]);
        }
 
-       ZERO_STRUCT(ctr);
-
-       result = rpccli_spoolss_enum_printers(cli, mem_ctx, name, PRINTER_ENUM_LOCAL,
-               info_level, &num_printers, &ctr);
+       if (argc == 3) {
+               name = argv[2];
+       } else {
+               name = cli->srv_name_slash;
+       }
 
+       result = rpccli_spoolss_enumprinters(cli, mem_ctx,
+                                            PRINTER_ENUM_LOCAL,
+                                            name,
+                                            level,
+                                            0,
+                                            &count,
+                                            &info);
        if (W_ERROR_IS_OK(result)) {
 
-               if (!num_printers) {
+               if (!count) {
                        printf ("No printers returned.\n");
                        goto done;
                }
 
-               for (i = 0; i < num_printers; i++) {
-                       switch(info_level) {
+               for (i = 0; i < count; i++) {
+                       switch (level) {
                        case 0:
-                               display_print_info_0(&ctr.printers_0[i]);
+                               display_print_info0(&info[i].info0);
                                break;
                        case 1:
-                               display_print_info_1(&ctr.printers_1[i]);
+                               display_print_info1(&info[i].info1);
                                break;
                        case 2:
-                               display_print_info_2(&ctr.printers_2[i]);
+                               display_print_info2(&info[i].info2);
                                break;
                        case 3:
-                               display_print_info_3(&ctr.printers_3[i]);
+                               display_print_info3(&info[i].info3);
                                break;
                        default:
-                               printf("unknown info level %d\n", info_level);
+                               printf("unknown info level %d\n", level);
                                goto done;
                        }
                }
        }
      done:
+ done:
 
        return result;
 }
@@ -358,55 +314,45 @@ static WERROR cmd_spoolss_enum_printers(struct rpc_pipe_client *cli,
 /****************************************************************************
 ****************************************************************************/
 
-static void display_port_info_1(PORT_INFO_1 *i1)
+static void display_port_info_1(struct spoolss_PortInfo1 *r)
 {
-       fstring buffer;
-
-       rpcstr_pull(buffer, i1->port_name.buffer, sizeof(buffer), -1, STR_TERMINATE);
-       printf("\tPort Name:\t[%s]\n", buffer);
+       printf("\tPort Name:\t[%s]\n", r->port_name);
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static void display_port_info_2(PORT_INFO_2 *i2)
+static void display_port_info_2(struct spoolss_PortInfo2 *r)
 {
-       fstring buffer;
-
-       rpcstr_pull(buffer, i2->port_name.buffer, sizeof(buffer), -1, STR_TERMINATE);
-       printf("\tPort Name:\t[%s]\n", buffer);
-       rpcstr_pull(buffer, i2->monitor_name.buffer, sizeof(buffer), -1, STR_TERMINATE);
-
-       printf("\tMonitor Name:\t[%s]\n", buffer);
-       rpcstr_pull(buffer, i2->description.buffer, sizeof(buffer), -1, STR_TERMINATE);
-
-       printf("\tDescription:\t[%s]\n", buffer);
+       printf("\tPort Name:\t[%s]\n", r->port_name);
+       printf("\tMonitor Name:\t[%s]\n", r->monitor_name);
+       printf("\tDescription:\t[%s]\n", r->description);
        printf("\tPort Type:\t" );
-       if ( i2->port_type ) {
+       if (r->port_type) {
                int comma = 0; /* hack */
                printf( "[" );
-               if ( i2->port_type & PORT_TYPE_READ ) {
+               if (r->port_type & SPOOLSS_PORT_TYPE_READ) {
                        printf( "Read" );
                        comma = 1;
                }
-               if ( i2->port_type & PORT_TYPE_WRITE ) {
+               if (r->port_type & SPOOLSS_PORT_TYPE_WRITE) {
                        printf( "%sWrite", comma ? ", " : "" );
                        comma = 1;
                }
                /* These two have slightly different interpretations
                 on 95/98/ME but I'm disregarding that for now */
-               if ( i2->port_type & PORT_TYPE_REDIRECTED ) {
+               if (r->port_type & SPOOLSS_PORT_TYPE_REDIRECTED) {
                        printf( "%sRedirected", comma ? ", " : "" );
                        comma = 1;
                }
-               if ( i2->port_type & PORT_TYPE_NET_ATTACHED ) {
+               if (r->port_type & SPOOLSS_PORT_TYPE_NET_ATTACHED) {
                        printf( "%sNet-Attached", comma ? ", " : "" );
                }
                printf( "]\n" );
        } else {
                printf( "[Unset]\n" );
        }
-       printf("\tReserved:\t[%d]\n", i2->reserved);
+       printf("\tReserved:\t[%d]\n", r->reserved);
        printf("\n");
 }
 
@@ -418,37 +364,40 @@ static WERROR cmd_spoolss_enum_ports(struct rpc_pipe_client *cli,
                                       const char **argv)
 {
        WERROR                  result;
-       uint32                  info_level = 1;
-       PORT_INFO_CTR           ctr;
-       uint32                  returned;
+       uint32_t                level = 1;
+       uint32_t                count;
+       union spoolss_PortInfo *info;
 
        if (argc > 2) {
                printf("Usage: %s [level]\n", argv[0]);
                return WERR_OK;
        }
 
-       if (argc == 2)
-               info_level = atoi(argv[1]);
+       if (argc == 2) {
+               level = atoi(argv[1]);
+       }
 
        /* Enumerate ports */
 
-       ZERO_STRUCT(ctr);
-
-       result = rpccli_spoolss_enum_ports(cli, mem_ctx, info_level, &returned, &ctr);
-
+       result = rpccli_spoolss_enumports(cli, mem_ctx,
+                                         cli->srv_name_slash,
+                                         level,
+                                         0,
+                                         &count,
+                                         &info);
        if (W_ERROR_IS_OK(result)) {
                int i;
 
-               for (i = 0; i < returned; i++) {
-                       switch (info_level) {
+               for (i = 0; i < count; i++) {
+                       switch (level) {
                        case 1:
-                               display_port_info_1(&ctr.port.info_1[i]);
+                               display_port_info_1(&info[i].info1);
                                break;
                        case 2:
-                               display_port_info_2(&ctr.port.info_2[i]);
+                               display_port_info_2(&info[i].info2);
                                break;
                        default:
-                               printf("unknown info level %d\n", info_level);
+                               printf("unknown info level %d\n", level);
                                break;
                        }
                }
@@ -466,11 +415,13 @@ static WERROR cmd_spoolss_setprinter(struct rpc_pipe_client *cli,
 {
        POLICY_HND      pol;
        WERROR          result;
+       NTSTATUS        status;
        uint32          info_level = 2;
-       bool            opened_hnd = False;
-       PRINTER_INFO_CTR ctr;
-       fstring         printername,
-                       comment;
+       union spoolss_PrinterInfo info;
+       struct spoolss_SetPrinterInfoCtr info_ctr;
+       const char      *printername, *comment = NULL;
+       struct spoolss_DevmodeContainer devmode_ctr;
+       struct sec_desc_buf secdesc_ctr;
 
        if (argc == 1 || argc > 3) {
                printf("Usage: %s printername comment\n", argv[0]);
@@ -480,39 +431,52 @@ static WERROR cmd_spoolss_setprinter(struct rpc_pipe_client *cli,
 
        /* Open a printer handle */
        if (argc == 3) {
-               fstrcpy(comment, argv[2]);
+               comment = argv[2];
        }
 
-       slprintf(printername, sizeof(printername)-1, "%s\\%s", cli->srv_name_slash, argv[1]);
+       ZERO_STRUCT(devmode_ctr);
+       ZERO_STRUCT(secdesc_ctr);
 
-       /* get a printer handle */
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "",
-                               PRINTER_ALL_ACCESS, cli->srv_name_slash,
-                               cli->auth->user_name, &pol);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       /* get a printer handle */
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              PRINTER_ALL_ACCESS,
+                                              &pol);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
-       opened_hnd = True;
-
        /* Get printer info */
-        result = rpccli_spoolss_getprinter(cli, mem_ctx, &pol, info_level, &ctr);
-
+       result = rpccli_spoolss_getprinter(cli, mem_ctx,
+                                          &pol,
+                                          info_level,
+                                          0,
+                                          &info);
         if (!W_ERROR_IS_OK(result))
                 goto done;
 
 
        /* Modify the comment. */
-       init_unistr(&ctr.printers_2->comment, comment);
-       ctr.printers_2->devmode = NULL;
-       ctr.printers_2->secdesc = NULL;
-
-       result = rpccli_spoolss_setprinter(cli, mem_ctx, &pol, info_level, &ctr, 0);
+       info.info2.comment = comment;
+       info.info2.secdesc = NULL;
+       info.info2.devmode = NULL;
+
+       info_ctr.level = 2;
+       info_ctr.info.info2 = (struct spoolss_SetPrinterInfo2 *)&info.info2;
+
+       status = rpccli_spoolss_SetPrinter(cli, mem_ctx,
+                                          &pol,
+                                          &info_ctr,
+                                          &devmode_ctr,
+                                          &secdesc_ctr,
+                                          0, /* command */
+                                          &result);
        if (W_ERROR_IS_OK(result))
                printf("Success in setting comment.\n");
 
  done:
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
 
        return result;
@@ -527,11 +491,17 @@ static WERROR cmd_spoolss_setprintername(struct rpc_pipe_client *cli,
 {
        POLICY_HND      pol;
        WERROR          result;
+       NTSTATUS        status;
        uint32          info_level = 2;
-       bool            opened_hnd = False;
-       PRINTER_INFO_CTR ctr;
-       fstring         printername,
-                       new_printername;
+       union spoolss_PrinterInfo info;
+       const char      *printername,
+                       *new_printername = NULL;
+       struct spoolss_SetPrinterInfoCtr info_ctr;
+       struct spoolss_DevmodeContainer devmode_ctr;
+       struct sec_desc_buf secdesc_ctr;
+
+       ZERO_STRUCT(devmode_ctr);
+       ZERO_STRUCT(secdesc_ctr);
 
        if (argc == 1 || argc > 3) {
                printf("Usage: %s printername new_printername\n", argv[0]);
@@ -541,38 +511,48 @@ static WERROR cmd_spoolss_setprintername(struct rpc_pipe_client *cli,
 
        /* Open a printer handle */
        if (argc == 3) {
-               fstrcpy(new_printername, argv[2]);
+               new_printername = argv[2];
        }
 
-       slprintf(printername, sizeof(printername)-1, "%s\\%s", cli->srv_name_slash, argv[1]);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
        /* get a printer handle */
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "",
-                               PRINTER_ALL_ACCESS, cli->srv_name_slash,
-                               cli->auth->user_name, &pol);
-
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              PRINTER_ALL_ACCESS,
+                                              &pol);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
-       opened_hnd = True;
-
        /* Get printer info */
-        result = rpccli_spoolss_getprinter(cli, mem_ctx, &pol, info_level, &ctr);
-
+       result = rpccli_spoolss_getprinter(cli, mem_ctx,
+                                          &pol,
+                                          info_level,
+                                          0,
+                                          &info);
         if (!W_ERROR_IS_OK(result))
                 goto done;
 
        /* Modify the printername. */
-       init_unistr(&ctr.printers_2->printername, new_printername);
-       ctr.printers_2->devmode = NULL;
-       ctr.printers_2->secdesc = NULL;
-
-       result = rpccli_spoolss_setprinter(cli, mem_ctx, &pol, info_level, &ctr, 0);
+       info.info2.printername = new_printername;
+       info.info2.devmode = NULL;
+       info.info2.secdesc = NULL;
+
+       info_ctr.level = info_level;
+       info_ctr.info.info2 = (struct spoolss_SetPrinterInfo2 *)&info.info2;
+
+       status = rpccli_spoolss_SetPrinter(cli, mem_ctx,
+                                          &pol,
+                                          &info_ctr,
+                                          &devmode_ctr,
+                                          &secdesc_ctr,
+                                          0, /* command */
+                                          &result);
        if (W_ERROR_IS_OK(result))
                printf("Success in setting printername.\n");
 
  done:
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
 
        return result;
@@ -587,10 +567,9 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
 {
        POLICY_HND      pol;
        WERROR          result;
-       uint32          info_level = 1;
-       bool            opened_hnd = False;
-       PRINTER_INFO_CTR ctr;
-       fstring         printername;
+       uint32_t        level = 1;
+       const char      *printername;
+       union spoolss_PrinterInfo info;
 
        if (argc == 1 || argc > 3) {
                printf("Usage: %s <printername> [level]\n", argv[0]);
@@ -599,56 +578,57 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
 
        /* Open a printer handle */
        if (argc == 3) {
-               info_level = atoi(argv[2]);
+               level = atoi(argv[2]);
        }
 
-       slprintf(printername, sizeof(printername)-1, "%s\\%s", cli->srv_name_slash, argv[1]);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
        /* get a printer handle */
 
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &pol);
-
-       if (!W_ERROR_IS_OK(result))
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &pol);
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
-
-       opened_hnd = True;
+       }
 
        /* Get printer info */
 
-       result = rpccli_spoolss_getprinter(cli, mem_ctx, &pol, info_level, &ctr);
-
-       if (!W_ERROR_IS_OK(result))
+       result = rpccli_spoolss_getprinter(cli, mem_ctx,
+                                          &pol,
+                                          level,
+                                          0,
+                                          &info);
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
+       }
 
        /* Display printer info */
-
-       switch (info_level) {
+       switch (level) {
        case 0:
-               display_print_info_0(ctr.printers_0);
+               display_print_info0(&info.info0);
                break;
        case 1:
-               display_print_info_1(ctr.printers_1);
+               display_print_info1(&info.info1);
                break;
        case 2:
-               display_print_info_2(ctr.printers_2);
+               display_print_info2(&info.info2);
                break;
        case 3:
-               display_print_info_3(ctr.printers_3);
+               display_print_info3(&info.info3);
                break;
        case 7:
-               display_print_info_7(ctr.printers_7);
+               display_print_info7(&info.info7);
                break;
        default:
-               printf("unknown info level %d\n", info_level);
+               printf("unknown info level %d\n", level);
                break;
        }
-
  done:
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol)) {
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
+       }
 
        return result;
 }
@@ -717,16 +697,64 @@ static void display_reg_value(REGISTRY_VALUE value)
 /****************************************************************************
 ****************************************************************************/
 
+static void display_printer_data(const char *v,
+                                enum winreg_Type type,
+                                union spoolss_PrinterData *r)
+{
+       int i;
+
+       switch (type) {
+       case REG_DWORD:
+               printf("%s: REG_DWORD: 0x%08x\n", v, r->value);
+               break;
+       case REG_SZ:
+               printf("%s: REG_SZ: %s\n", v, r->string);
+               break;
+       case REG_BINARY: {
+               char *hex = hex_encode_talloc(NULL,
+                       r->binary.data, r->binary.length);
+               size_t len;
+               printf("%s: REG_BINARY:", v);
+               len = strlen(hex);
+               for (i=0; i<len; i++) {
+                       if (hex[i] == '\0') {
+                               break;
+                       }
+                       if (i%40 == 0) {
+                               putchar('\n');
+                       }
+                       putchar(hex[i]);
+               }
+               TALLOC_FREE(hex);
+               putchar('\n');
+               break;
+       }
+       case REG_MULTI_SZ:
+               printf("%s: REG_MULTI_SZ: ", v);
+               for (i=0; r->string_array[i] != NULL; i++) {
+                       printf("%s ", r->string_array[i]);
+               }
+               printf("\n");
+               break;
+       default:
+               printf("%s: unknown type 0x%02x:\n", v, type);
+               break;
+       }
+}
+
+/****************************************************************************
+****************************************************************************/
+
 static WERROR cmd_spoolss_getprinterdata(struct rpc_pipe_client *cli,
                                           TALLOC_CTX *mem_ctx,
                                           int argc, const char **argv)
 {
        POLICY_HND      pol;
        WERROR          result;
-       bool            opened_hnd = False;
        fstring         printername;
        const char *valuename;
-       REGISTRY_VALUE value;
+       enum winreg_Type type;
+       union spoolss_PrinterData data;
 
        if (argc != 3) {
                printf("Usage: %s <printername> <valuename>\n", argv[0]);
@@ -745,31 +773,30 @@ static WERROR cmd_spoolss_getprinterdata(struct rpc_pipe_client *cli,
 
        /* get a printer handle */
 
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &pol);
-
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &pol);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
-       opened_hnd = True;
-
        /* Get printer info */
 
-       result = rpccli_spoolss_getprinterdata(cli, mem_ctx, &pol, valuename, &value);
-
+       result = rpccli_spoolss_getprinterdata(cli, mem_ctx,
+                                              &pol,
+                                              valuename,
+                                              0,
+                                              &type,
+                                              &data);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
        /* Display printer data */
 
-       fstrcpy(value.valuename, valuename);
-       display_reg_value(value);
-
+       display_printer_data(valuename, type, &data);
 
  done:
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
 
        return result;
@@ -784,11 +811,16 @@ static WERROR cmd_spoolss_getprinterdataex(struct rpc_pipe_client *cli,
 {
        POLICY_HND      pol;
        WERROR          result;
-       bool            opened_hnd = False;
+       NTSTATUS        status;
        fstring         printername;
        const char *valuename, *keyname;
        REGISTRY_VALUE value;
 
+       enum winreg_Type type;
+       uint8_t *buffer = NULL;
+       uint32_t offered = 0;
+       uint32_t needed;
+
        if (argc != 4) {
                printf("Usage: %s <printername> <keyname> <valuename>\n",
                       argv[0]);
@@ -808,20 +840,46 @@ static WERROR cmd_spoolss_getprinterdataex(struct rpc_pipe_client *cli,
 
        /* get a printer handle */
 
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &pol);
-
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &pol);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
-       opened_hnd = True;
-
        /* Get printer info */
 
-       result = rpccli_spoolss_getprinterdataex(cli, mem_ctx, &pol, keyname,
-               valuename, &value);
+       status = rpccli_spoolss_GetPrinterDataEx(cli, mem_ctx,
+                                                &pol,
+                                                keyname,
+                                                valuename,
+                                                &type,
+                                                buffer,
+                                                offered,
+                                                &needed,
+                                                &result);
+       if (W_ERROR_EQUAL(result, WERR_MORE_DATA)) {
+               offered = needed;
+               buffer = talloc_array(mem_ctx, uint8_t, needed);
+               status = rpccli_spoolss_GetPrinterDataEx(cli, mem_ctx,
+                                                        &pol,
+                                                        keyname,
+                                                        valuename,
+                                                        &type,
+                                                        buffer,
+                                                        offered,
+                                                        &needed,
+                                                        &result);
+       }
+
+       if (!NT_STATUS_IS_OK(status)) {
+               goto done;
+       }
+
+       if (!W_ERROR_IS_OK(result)) {
+               goto done;
+       }
+
 
        if (!W_ERROR_IS_OK(result))
                goto done;
@@ -829,11 +887,14 @@ static WERROR cmd_spoolss_getprinterdataex(struct rpc_pipe_client *cli,
        /* Display printer data */
 
        fstrcpy(value.valuename, valuename);
-       display_reg_value(value);
+       value.type = type;
+       value.size = needed;
+       value.data_p = buffer;
 
+       display_reg_value(value);
 
  done:
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
 
        return result;
@@ -842,194 +903,155 @@ static WERROR cmd_spoolss_getprinterdataex(struct rpc_pipe_client *cli,
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_driver_1(DRIVER_INFO_1 *i1)
+static void display_print_driver1(struct spoolss_DriverInfo1 *r)
 {
-       fstring name;
-       if (i1 == NULL)
+       if (!r) {
                return;
+       }
 
-       rpcstr_pull(name, i1->name.buffer, sizeof(name), -1, STR_TERMINATE);
-
-       printf ("Printer Driver Info 1:\n");
-       printf ("\tDriver Name: [%s]\n\n", name);
-
-       return;
+       printf("Printer Driver Info 1:\n");
+       printf("\tDriver Name: [%s]\n\n", r->driver_name);
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_driver_2(DRIVER_INFO_2 *i1)
+static void display_print_driver2(struct spoolss_DriverInfo2 *r)
 {
-       fstring name;
-       fstring architecture;
-       fstring driverpath;
-       fstring datafile;
-       fstring configfile;
-       if (i1 == NULL)
+       if (!r) {
                return;
+       }
 
-       rpcstr_pull(name, i1->name.buffer, sizeof(name), -1, STR_TERMINATE);
-       rpcstr_pull(architecture, i1->architecture.buffer, sizeof(architecture), -1, STR_TERMINATE);
-       rpcstr_pull(driverpath, i1->driverpath.buffer, sizeof(driverpath), -1, STR_TERMINATE);
-       rpcstr_pull(datafile, i1->datafile.buffer, sizeof(datafile), -1, STR_TERMINATE);
-       rpcstr_pull(configfile, i1->configfile.buffer, sizeof(configfile), -1, STR_TERMINATE);
-
-       printf ("Printer Driver Info 2:\n");
-       printf ("\tVersion: [%x]\n", i1->version);
-       printf ("\tDriver Name: [%s]\n", name);
-       printf ("\tArchitecture: [%s]\n", architecture);
-       printf ("\tDriver Path: [%s]\n", driverpath);
-       printf ("\tDatafile: [%s]\n", datafile);
-       printf ("\tConfigfile: [%s]\n\n", configfile);
-
-       return;
+       printf("Printer Driver Info 2:\n");
+       printf("\tVersion: [%x]\n", r->version);
+       printf("\tDriver Name: [%s]\n", r->driver_name);
+       printf("\tArchitecture: [%s]\n", r->architecture);
+       printf("\tDriver Path: [%s]\n", r->driver_path);
+       printf("\tDatafile: [%s]\n", r->data_file);
+       printf("\tConfigfile: [%s]\n\n", r->config_file);
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static void display_print_driver_3(DRIVER_INFO_3 *i1)
+static void display_print_driver3(struct spoolss_DriverInfo3 *r)
 {
-       fstring name = "";
-       fstring architecture = "";
-       fstring driverpath = "";
-       fstring datafile = "";
-       fstring configfile = "";
-       fstring helpfile = "";
-       fstring dependentfiles = "";
-       fstring monitorname = "";
-       fstring defaultdatatype = "";
-
-       int length=0;
-       bool valid = True;
-
-       if (i1 == NULL)
-               return;
+       int i;
 
-       rpcstr_pull(name, i1->name.buffer, sizeof(name), -1, STR_TERMINATE);
-       rpcstr_pull(architecture, i1->architecture.buffer, sizeof(architecture), -1, STR_TERMINATE);
-       rpcstr_pull(driverpath, i1->driverpath.buffer, sizeof(driverpath), -1, STR_TERMINATE);
-       rpcstr_pull(datafile, i1->datafile.buffer, sizeof(datafile), -1, STR_TERMINATE);
-       rpcstr_pull(configfile, i1->configfile.buffer, sizeof(configfile), -1, STR_TERMINATE);
-       rpcstr_pull(helpfile, i1->helpfile.buffer, sizeof(helpfile), -1, STR_TERMINATE);
-       rpcstr_pull(monitorname, i1->monitorname.buffer, sizeof(monitorname), -1, STR_TERMINATE);
-       rpcstr_pull(defaultdatatype, i1->defaultdatatype.buffer, sizeof(defaultdatatype), -1, STR_TERMINATE);
-
-       printf ("Printer Driver Info 3:\n");
-       printf ("\tVersion: [%x]\n", i1->version);
-       printf ("\tDriver Name: [%s]\n",name);
-       printf ("\tArchitecture: [%s]\n", architecture);
-       printf ("\tDriver Path: [%s]\n", driverpath);
-       printf ("\tDatafile: [%s]\n", datafile);
-       printf ("\tConfigfile: [%s]\n", configfile);
-       printf ("\tHelpfile: [%s]\n\n", helpfile);
-
-       while (valid)
-       {
-               rpcstr_pull(dependentfiles, i1->dependentfiles+length, sizeof(dependentfiles), -1, STR_TERMINATE);
+       if (!r) {
+               return;
+       }
 
-               length+=strlen(dependentfiles)+1;
+       printf("Printer Driver Info 3:\n");
+       printf("\tVersion: [%x]\n", r->version);
+       printf("\tDriver Name: [%s]\n", r->driver_name);
+       printf("\tArchitecture: [%s]\n", r->architecture);
+       printf("\tDriver Path: [%s]\n", r->driver_path);
+       printf("\tDatafile: [%s]\n", r->data_file);
+       printf("\tConfigfile: [%s]\n\n", r->config_file);
+       printf("\tHelpfile: [%s]\n\n", r->help_file);
 
-               if (strlen(dependentfiles) > 0)
-               {
-                       printf ("\tDependentfiles: [%s]\n", dependentfiles);
-               }
-               else
-               {
-                       valid = False;
-               }
+       for (i=0; r->dependent_files[i] != NULL; i++) {
+               printf("\tDependentfiles: [%s]\n", r->dependent_files[i]);
        }
 
-       printf ("\n");
-
-       printf ("\tMonitorname: [%s]\n", monitorname);
-       printf ("\tDefaultdatatype: [%s]\n\n", defaultdatatype);
+       printf("\n");
 
-       return;
+       printf("\tMonitorname: [%s]\n", r->monitor_name);
+       printf("\tDefaultdatatype: [%s]\n\n", r->default_datatype);
 }
 
+
 /****************************************************************************
 ****************************************************************************/
 
 static WERROR cmd_spoolss_getdriver(struct rpc_pipe_client *cli,
-                                      TALLOC_CTX *mem_ctx,
-                                      int argc, const char **argv)
+                                   TALLOC_CTX *mem_ctx,
+                                   int argc, const char **argv)
 {
        POLICY_HND      pol;
        WERROR          werror;
-       uint32          info_level = 3;
-       bool            opened_hnd = False;
-       PRINTER_DRIVER_CTR      ctr;
-       fstring         printername;
-       uint32          i;
-       bool            success = False;
-
-       if ((argc == 1) || (argc > 3))
-       {
+       uint32_t        level = 3;
+       const char      *printername;
+       uint32_t        i;
+       bool            success = false;
+       union spoolss_DriverInfo info;
+       uint32_t server_major_version;
+       uint32_t server_minor_version;
+
+       if ((argc == 1) || (argc > 3)) {
                printf("Usage: %s <printername> [level]\n", argv[0]);
                return WERR_OK;
        }
 
        /* get the arguments need to open the printer handle */
-       slprintf(printername, sizeof(printername)-1, "%s\\%s", cli->srv_name_slash, argv[1]);
-       if (argc == 3)
-               info_level = atoi(argv[2]);
 
-       /* Open a printer handle */
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
-       werror = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "",
-                                            PRINTER_ACCESS_USE,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &pol);
+       if (argc == 3) {
+               level = atoi(argv[2]);
+       }
 
+       /* Open a printer handle */
+
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              PRINTER_ACCESS_USE,
+                                              &pol);
        if (!W_ERROR_IS_OK(werror)) {
                printf("Error opening printer handle for %s!\n", printername);
                return werror;
        }
 
-       opened_hnd = True;
-
        /* loop through and print driver info level for each architecture */
 
        for (i=0; archi_table[i].long_archi!=NULL; i++) {
 
-               werror = rpccli_spoolss_getprinterdriver( cli, mem_ctx, &pol, info_level,
-                       archi_table[i].long_archi, archi_table[i].version,
-                       &ctr);
-
-               if (!W_ERROR_IS_OK(werror))
+               werror = rpccli_spoolss_getprinterdriver2(cli, mem_ctx,
+                                                         &pol,
+                                                         archi_table[i].long_archi,
+                                                         level,
+                                                         0, /* offered */
+                                                         archi_table[i].version,
+                                                         2,
+                                                         &info,
+                                                         &server_major_version,
+                                                         &server_minor_version);
+               if (!W_ERROR_IS_OK(werror)) {
                        continue;
+               }
 
                /* need at least one success */
 
-               success = True;
+               success = true;
 
-               printf ("\n[%s]\n", archi_table[i].long_archi);
+               printf("\n[%s]\n", archi_table[i].long_archi);
 
-               switch (info_level) {
+               switch (level) {
                case 1:
-                       display_print_driver_1 (ctr.info1);
+                       display_print_driver1(&info.info1);
                        break;
                case 2:
-                       display_print_driver_2 (ctr.info2);
+                       display_print_driver2(&info.info2);
                        break;
                case 3:
-                       display_print_driver_3 (ctr.info3);
+                       display_print_driver3(&info.info3);
                        break;
                default:
-                       printf("unknown info level %d\n", info_level);
+                       printf("unknown info level %d\n", level);
                        break;
                }
        }
 
        /* Cleanup */
 
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol)) {
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
+       }
 
-       if ( success )
+       if (success) {
                werror = WERR_OK;
+       }
 
        return werror;
 }
@@ -1042,68 +1064,73 @@ static WERROR cmd_spoolss_enum_drivers(struct rpc_pipe_client *cli,
                                          int argc, const char **argv)
 {
        WERROR werror = WERR_OK;
-       uint32          info_level = 1;
-       PRINTER_DRIVER_CTR      ctr;
-       uint32          i, j,
-                       returned;
+       uint32_t        level = 1;
+       union spoolss_DriverInfo *info;
+       uint32_t        i, j, count;
 
        if (argc > 2) {
                printf("Usage: enumdrivers [level]\n");
                return WERR_OK;
        }
 
-       if (argc == 2)
-               info_level = atoi(argv[1]);
+       if (argc == 2) {
+               level = atoi(argv[1]);
+       }
 
 
        /* loop through and print driver info level for each architecture */
        for (i=0; archi_table[i].long_archi!=NULL; i++) {
                /* check to see if we already asked for this architecture string */
 
-               if ( i>0 && strequal(archi_table[i].long_archi, archi_table[i-1].long_archi) )
+               if (i>0 && strequal(archi_table[i].long_archi, archi_table[i-1].long_archi)) {
                        continue;
+               }
 
-               werror = rpccli_spoolss_enumprinterdrivers(
-                       cli, mem_ctx, info_level,
-                       archi_table[i].long_archi, &returned, &ctr);
+               werror = rpccli_spoolss_enumprinterdrivers(cli, mem_ctx,
+                                                          cli->srv_name_slash,
+                                                          archi_table[i].long_archi,
+                                                          level,
+                                                          0,
+                                                          &count,
+                                                          &info);
 
                if (W_ERROR_V(werror) == W_ERROR_V(WERR_INVALID_ENVIRONMENT)) {
-                       printf ("Server does not support environment [%s]\n",
+                       printf("Server does not support environment [%s]\n",
                                archi_table[i].long_archi);
                        werror = WERR_OK;
                        continue;
                }
 
-               if (returned == 0)
+               if (count == 0) {
                        continue;
+               }
 
                if (!W_ERROR_IS_OK(werror)) {
-                       printf ("Error getting driver for environment [%s] - %d\n",
+                       printf("Error getting driver for environment [%s] - %d\n",
                                archi_table[i].long_archi, W_ERROR_V(werror));
                        continue;
                }
 
-               printf ("\n[%s]\n", archi_table[i].long_archi);
-               switch (info_level)
-               {
+               printf("\n[%s]\n", archi_table[i].long_archi);
 
+               switch (level) {
                case 1:
-                       for (j=0; j < returned; j++) {
-                               display_print_driver_1 (&ctr.info1[j]);
+                       for (j=0; j < count; j++) {
+                               display_print_driver1(&info[j].info1);
                        }
                        break;
                case 2:
-                       for (j=0; j < returned; j++) {
-                               display_print_driver_2 (&ctr.info2[j]);
+                       for (j=0; j < count; j++) {
+                               display_print_driver2(&info[j].info2);
                        }
                        break;
                case 3:
-                       for (j=0; j < returned; j++) {
-                               display_print_driver_3 (&ctr.info3[j]);
+                       for (j=0; j < count; j++) {
+                               display_print_driver3(&info[j].info3);
                        }
                        break;
                default:
-                       printf("unknown info level %d\n", info_level);
+                       printf("unknown info level %d\n", level);
                        return WERR_UNKNOWN_LEVEL;
                }
        }
@@ -1114,15 +1141,9 @@ static WERROR cmd_spoolss_enum_drivers(struct rpc_pipe_client *cli,
 /****************************************************************************
 ****************************************************************************/
 
-static void display_printdriverdir_1(DRIVER_DIRECTORY_1 *i1)
+static void display_printdriverdir_1(struct spoolss_DriverDirectoryInfo1 *r)
 {
-        fstring name;
-        if (i1 == NULL)
-                return;
-
-       rpcstr_pull(name, i1->name.buffer, sizeof(name), -1, STR_TERMINATE);
-
-       printf ("\tDirectory Name:[%s]\n", name);
+       printf("\tDirectory Name:[%s]\n", r->directory_name);
 }
 
 /****************************************************************************
@@ -1133,8 +1154,12 @@ static WERROR cmd_spoolss_getdriverdir(struct rpc_pipe_client *cli,
                                          int argc, const char **argv)
 {
        WERROR result;
-       fstring                 env;
-       DRIVER_DIRECTORY_CTR    ctr;
+       NTSTATUS status;
+       const char *env = SPOOLSS_ARCHITECTURE_NT_X86;
+       DATA_BLOB buffer;
+       uint32_t offered;
+       union spoolss_DriverDirectoryInfo info;
+       uint32_t needed;
 
        if (argc > 2) {
                printf("Usage: %s [environment]\n", argv[0]);
@@ -1143,17 +1168,39 @@ static WERROR cmd_spoolss_getdriverdir(struct rpc_pipe_client *cli,
 
        /* Get the arguments need to open the printer handle */
 
-       if (argc == 2)
-               fstrcpy (env, argv[1]);
-       else
-               fstrcpy (env, "Windows NT x86");
+       if (argc == 2) {
+               env = argv[1];
+       }
 
        /* Get the directory.  Only use Info level 1 */
 
-       result = rpccli_spoolss_getprinterdriverdir(cli, mem_ctx, 1, env, &ctr);
+       status = rpccli_spoolss_GetPrinterDriverDirectory(cli, mem_ctx,
+                                                         cli->srv_name_slash,
+                                                         env,
+                                                         1,
+                                                         NULL, /* buffer */
+                                                         0, /* offered */
+                                                         NULL, /* info */
+                                                         &needed,
+                                                         &result);
+       if (W_ERROR_EQUAL(result, WERR_INSUFFICIENT_BUFFER)) {
+               offered = needed;
+               buffer = data_blob_talloc_zero(mem_ctx, needed);
+
+               status = rpccli_spoolss_GetPrinterDriverDirectory(cli, mem_ctx,
+                                                                 cli->srv_name_slash,
+                                                                 env,
+                                                                 1,
+                                                                 &buffer,
+                                                                 offered,
+                                                                 &info,
+                                                                 &needed,
+                                                                 &result);
+       }
 
-       if (W_ERROR_IS_OK(result))
-               display_printdriverdir_1(ctr.info1);
+       if (W_ERROR_IS_OK(result)) {
+               display_printdriverdir_1(&info.info1);
+       }
 
        return result;
 }
@@ -1161,7 +1208,9 @@ static WERROR cmd_spoolss_getdriverdir(struct rpc_pipe_client *cli,
 /****************************************************************************
 ****************************************************************************/
 
-void set_drv_info_3_env (DRIVER_INFO_3 *info, const char *arch)
+static void set_drv_info_3_env(TALLOC_CTX *mem_ctx,
+                              struct spoolss_AddDriverInfo3 *info,
+                              const char *arch)
 {
 
        int i;
@@ -1171,7 +1220,7 @@ void set_drv_info_3_env (DRIVER_INFO_3 *info, const char *arch)
                if (strcmp(arch, archi_table[i].short_archi) == 0)
                {
                        info->version = archi_table[i].version;
-                       init_unistr (&info->architecture, archi_table[i].long_archi);
+                       info->architecture = talloc_strdup(mem_ctx, archi_table[i].long_archi);
                        break;
                }
        }
@@ -1190,8 +1239,9 @@ void set_drv_info_3_env (DRIVER_INFO_3 *info, const char *arch)
  Needed to handle the empty parameter string denoted by "NULL"
  *************************************************************************/
 
-static char* get_driver_3_param (char* str, const char* delim, UNISTR* dest,
-                                char **saveptr)
+static char *get_driver_3_param(TALLOC_CTX *mem_ctx, char *str,
+                               const char *delim, const char **dest,
+                               char **saveptr)
 {
        char    *ptr;
 
@@ -1202,70 +1252,80 @@ static char* get_driver_3_param (char* str, const char* delim, UNISTR* dest,
           parameter because two consecutive delimiters
           will not return an empty string.  See man strtok(3)
           for details */
-       if (ptr && (StrCaseCmp(ptr, "NULL") == 0))
+       if (ptr && (StrCaseCmp(ptr, "NULL") == 0)) {
                ptr = NULL;
+       }
 
-       if (dest != NULL)
-               init_unistr(dest, ptr);
+       if (dest != NULL) {
+               *dest = talloc_strdup(mem_ctx, ptr);
+       }
 
        return ptr;
 }
 
 /********************************************************************************
- fill in the members of a DRIVER_INFO_3 struct using a character
+ fill in the members of a spoolss_AddDriverInfo3 struct using a character
  string in the form of
         <Long Printer Name>:<Driver File Name>:<Data File Name>:\
             <Config File Name>:<Help File Name>:<Language Monitor Name>:\
             <Default Data Type>:<Comma Separated list of Files>
  *******************************************************************************/
-static bool init_drv_info_3_members ( TALLOC_CTX *mem_ctx, DRIVER_INFO_3 *info,
-                                      char *args )
+
+static bool init_drv_info_3_members(TALLOC_CTX *mem_ctx, struct spoolss_AddDriverInfo3 *r,
+                                    char *args)
 {
        char    *str, *str2;
-       uint32  len, i;
+       int count = 0;
        char *saveptr = NULL;
+       struct spoolss_StringArray *deps;
+       const char **file_array = NULL;
+       int i;
 
        /* fill in the UNISTR fields */
-       str = get_driver_3_param (args, ":", &info->name, &saveptr);
-       str = get_driver_3_param (NULL, ":", &info->driverpath, &saveptr);
-       str = get_driver_3_param (NULL, ":", &info->datafile, &saveptr);
-       str = get_driver_3_param (NULL, ":", &info->configfile, &saveptr);
-       str = get_driver_3_param (NULL, ":", &info->helpfile, &saveptr);
-       str = get_driver_3_param (NULL, ":", &info->monitorname, &saveptr);
-       str = get_driver_3_param (NULL, ":", &info->defaultdatatype, &saveptr);
+       str = get_driver_3_param(mem_ctx, args, ":", &r->driver_name, &saveptr);
+       str = get_driver_3_param(mem_ctx, NULL, ":", &r->driver_path, &saveptr);
+       str = get_driver_3_param(mem_ctx, NULL, ":", &r->data_file, &saveptr);
+       str = get_driver_3_param(mem_ctx, NULL, ":", &r->config_file, &saveptr);
+       str = get_driver_3_param(mem_ctx, NULL, ":", &r->help_file, &saveptr);
+       str = get_driver_3_param(mem_ctx, NULL, ":", &r->monitor_name, &saveptr);
+       str = get_driver_3_param(mem_ctx, NULL, ":", &r->default_datatype, &saveptr);
 
        /* <Comma Separated List of Dependent Files> */
        /* save the beginning of the string */
-       str2 = get_driver_3_param (NULL, ":", NULL, &saveptr);
+       str2 = get_driver_3_param(mem_ctx, NULL, ":", NULL, &saveptr);
        str = str2;
 
        /* begin to strip out each filename */
        str = strtok_r(str, ",", &saveptr);
-       len = 0;
-       while (str != NULL)
-       {
-               /* keep a cumlative count of the str lengths */
-               len += strlen(str)+1;
+
+       /* no dependent files, we are done */
+       if (!str) {
+               return true;
+       }
+
+       deps = talloc_zero(mem_ctx, struct spoolss_StringArray);
+       if (!deps) {
+               return false;
+       }
+
+       while (str != NULL) {
+               add_string_to_array(deps, str, &file_array, &count);
                str = strtok_r(NULL, ",", &saveptr);
        }
 
-       /* allocate the space; add one extra slot for a terminating NULL.
-          Each filename is NULL terminated and the end contains a double
-          NULL */
-       if ((info->dependentfiles=TALLOC_ARRAY(mem_ctx, uint16, len+1)) == NULL)
-       {
-               DEBUG(0,("init_drv_info_3_members: Unable to malloc memory for dependenfiles\n"));
-               return False;
+       deps->string = talloc_zero_array(deps, const char *, count + 1);
+       if (!deps->string) {
+               return false;
        }
-       for (i=0; i<len; i++)
-       {
-               SSVAL(&info->dependentfiles[i], 0, str2[i]);
+
+       for (i=0; i < count; i++) {
+               deps->string[i] = file_array[i];
        }
-       info->dependentfiles[len] = '\0';
 
-       return True;
-}
+       r->dependent_files = deps;
 
+       return true;
+}
 
 /****************************************************************************
 ****************************************************************************/
@@ -1275,11 +1335,11 @@ static WERROR cmd_spoolss_addprinterdriver(struct rpc_pipe_client *cli,
                                              int argc, const char **argv)
 {
        WERROR result;
+       NTSTATUS status;
        uint32                  level = 3;
-       PRINTER_DRIVER_CTR      ctr;
-       DRIVER_INFO_3           info3;
+       struct spoolss_AddDriverInfoCtr info_ctr;
+       struct spoolss_AddDriverInfo3 info3;
        const char              *arch;
-       fstring                 driver_name;
        char                    *driver_args;
 
        /* parse the command arguments */
@@ -1294,15 +1354,16 @@ static WERROR cmd_spoolss_addprinterdriver(struct rpc_pipe_client *cli,
             return WERR_OK;
         }
 
-       /* Fill in the DRIVER_INFO_3 struct */
+       /* Fill in the spoolss_AddDriverInfo3 struct */
        ZERO_STRUCT(info3);
-       if (!(arch = cmd_spoolss_get_short_archi(argv[1])))
-       {
+
+       arch = cmd_spoolss_get_short_archi(argv[1]);
+       if (!arch) {
                printf ("Error Unknown architechture [%s]\n", argv[1]);
                return WERR_INVALID_PARAM;
        }
-       else
-               set_drv_info_3_env(&info3, arch);
+
+       set_drv_info_3_env(mem_ctx, &info3, arch);
 
        driver_args = talloc_strdup( mem_ctx, argv[2] );
        if (!init_drv_info_3_members(mem_ctx, &info3, driver_args ))
@@ -1320,14 +1381,19 @@ static WERROR cmd_spoolss_addprinterdriver(struct rpc_pipe_client *cli,
        }
 
 
-       ctr.info3 = &info3;
-       result = rpccli_spoolss_addprinterdriver (cli, mem_ctx, level, &ctr);
+       info_ctr.level          = level;
+       info_ctr.info.info3     = &info3;
 
+       status = rpccli_spoolss_AddPrinterDriver(cli, mem_ctx,
+                                                cli->srv_name_slash,
+                                                &info_ctr,
+                                                &result);
+       if (!NT_STATUS_IS_OK(status)) {
+               return ntstatus_to_werror(status);
+       }
        if (W_ERROR_IS_OK(result)) {
-               rpcstr_pull(driver_name, info3.name.buffer,
-                           sizeof(driver_name), -1, STR_TERMINATE);
                printf ("Printer Driver %s successfully installed.\n",
-                       driver_name);
+                       info3.driver_name);
        }
 
        return result;
@@ -1342,9 +1408,8 @@ static WERROR cmd_spoolss_addprinterex(struct rpc_pipe_client *cli,
                                          int argc, const char **argv)
 {
        WERROR result;
-       uint32                  level = 2;
-       PRINTER_INFO_CTR        ctr;
-       PRINTER_INFO_2          info2;
+       struct spoolss_SetPrinterInfoCtr info_ctr;
+       struct spoolss_SetPrinterInfo2 info2;
 
        /* parse the command arguments */
        if (argc != 5)
@@ -1356,15 +1421,15 @@ static WERROR cmd_spoolss_addprinterex(struct rpc_pipe_client *cli,
        /* Fill in the DRIVER_INFO_2 struct */
        ZERO_STRUCT(info2);
 
-       init_unistr( &info2.printername,        argv[1]);
-       init_unistr( &info2.sharename,          argv[2]);
-       init_unistr( &info2.drivername,         argv[3]);
-       init_unistr( &info2.portname,           argv[4]);
-       init_unistr( &info2.comment,            "Created by rpcclient");
-       init_unistr( &info2.printprocessor,     "winprint");
-       init_unistr( &info2.datatype,           "RAW");
-       info2.devmode =         NULL;
-       info2.secdesc =         NULL;
+       info2.printername       = argv[1];
+       info2.drivername        = argv[3];
+       info2.sharename         = argv[2];
+       info2.portname          = argv[4];
+       info2.comment           = "Created by rpcclient";
+       info2.printprocessor    = "winprint";
+       info2.datatype          = "RAW";
+       info2.devmode           = NULL;
+       info2.secdesc           = NULL;
        info2.attributes        = PRINTER_ATTRIBUTE_SHARED;
        info2.priority          = 0;
        info2.defaultpriority   = 0;
@@ -1379,9 +1444,11 @@ static WERROR cmd_spoolss_addprinterex(struct rpc_pipe_client *cli,
        info2.averageppm        = 0;
        */
 
-       ctr.printers_2 = &info2;
-       result = rpccli_spoolss_addprinterex (cli, mem_ctx, level, &ctr);
+       info_ctr.level = 2;
+       info_ctr.info.info2 = &info2;
 
+       result = rpccli_spoolss_addprinterex(cli, mem_ctx,
+                                            &info_ctr);
        if (W_ERROR_IS_OK(result))
                printf ("Printer %s successfully installed.\n", argv[1]);
 
@@ -1397,11 +1464,16 @@ static WERROR cmd_spoolss_setdriver(struct rpc_pipe_client *cli,
 {
        POLICY_HND              pol;
        WERROR                  result;
+       NTSTATUS                status;
        uint32                  level = 2;
-       bool                    opened_hnd = False;
-       PRINTER_INFO_CTR        ctr;
-       PRINTER_INFO_2          info2;
-       fstring                 printername;
+       const char              *printername;
+       union spoolss_PrinterInfo info;
+       struct spoolss_SetPrinterInfoCtr info_ctr;
+       struct spoolss_DevmodeContainer devmode_ctr;
+       struct sec_desc_buf secdesc_ctr;
+
+       ZERO_STRUCT(devmode_ctr);
+       ZERO_STRUCT(secdesc_ctr);
 
        /* parse the command arguments */
        if (argc != 3)
@@ -1410,27 +1482,24 @@ static WERROR cmd_spoolss_setdriver(struct rpc_pipe_client *cli,
                return WERR_OK;
         }
 
-       slprintf(printername, sizeof(printername)-1, "%s\\%s", cli->srv_name_slash, argv[1]);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
        /* Get a printer handle */
 
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "",
-                                            PRINTER_ALL_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &pol);
-
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              PRINTER_ALL_ACCESS,
+                                              &pol);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
-       opened_hnd = True;
-
        /* Get printer info */
 
-       ZERO_STRUCT (info2);
-       ctr.printers_2 = &info2;
-
-       result = rpccli_spoolss_getprinter(cli, mem_ctx, &pol, level, &ctr);
-
+       result = rpccli_spoolss_getprinter(cli, mem_ctx,
+                                          &pol,
+                                          level,
+                                          0,
+                                          &info);
        if (!W_ERROR_IS_OK(result)) {
                printf ("Unable to retrieve printer information!\n");
                goto done;
@@ -1438,10 +1507,20 @@ static WERROR cmd_spoolss_setdriver(struct rpc_pipe_client *cli,
 
        /* Set the printer driver */
 
-       init_unistr(&ctr.printers_2->drivername, argv[2]);
+       info.info2.drivername = argv[2];
+       info.info2.devmode = NULL;
+       info.info2.secdesc = NULL;
 
-       result = rpccli_spoolss_setprinter(cli, mem_ctx, &pol, level, &ctr, 0);
+       info_ctr.level = 2;
+       info_ctr.info.info2 = (struct spoolss_SetPrinterInfo2 *)&info.info2;
 
+       status = rpccli_spoolss_SetPrinter(cli, mem_ctx,
+                                          &pol,
+                                          &info_ctr,
+                                          &devmode_ctr,
+                                          &secdesc_ctr,
+                                          0, /* command */
+                                          &result);
        if (!W_ERROR_IS_OK(result)) {
                printf("SetPrinter call failed!\n");
                goto done;;
@@ -1452,7 +1531,7 @@ static WERROR cmd_spoolss_setdriver(struct rpc_pipe_client *cli,
 done:
        /* Cleanup */
 
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
 
        return result;
@@ -1578,8 +1657,12 @@ static WERROR cmd_spoolss_getprintprocdir(struct rpc_pipe_client *cli,
                                            int argc, const char **argv)
 {
        WERROR result;
-       char *environment = NULL;
-       fstring procdir;
+       NTSTATUS status;
+       const char *environment = SPOOLSS_ARCHITECTURE_NT_X86;
+       DATA_BLOB buffer;
+       uint32_t offered;
+       union spoolss_PrintProcessorDirectoryInfo info;
+       uint32_t needed;
 
        /* parse the command arguments */
        if (argc > 2) {
@@ -1587,18 +1670,37 @@ static WERROR cmd_spoolss_getprintprocdir(struct rpc_pipe_client *cli,
                return WERR_OK;
         }
 
-       if (asprintf(&environment, "%s", (argc == 2) ? argv[1] :
-                    PRINTER_DRIVER_ARCHITECTURE) < 0) {
-               return WERR_NOMEM;
+       if (argc == 2) {
+               environment = argv[1];
        }
 
-       result = rpccli_spoolss_getprintprocessordirectory(
-               cli, mem_ctx, cli->srv_name_slash, environment, procdir);
+       status = rpccli_spoolss_GetPrintProcessorDirectory(cli, mem_ctx,
+                                                          cli->srv_name_slash,
+                                                          environment,
+                                                          1,
+                                                          NULL, /* buffer */
+                                                          0, /* offered */
+                                                          NULL, /* info */
+                                                          &needed,
+                                                          &result);
+       if (W_ERROR_EQUAL(result, WERR_INSUFFICIENT_BUFFER)) {
+               offered = needed;
+               buffer = data_blob_talloc_zero(mem_ctx, needed);
 
-       if (W_ERROR_IS_OK(result))
-               printf("%s\n", procdir);
+               status = rpccli_spoolss_GetPrintProcessorDirectory(cli, mem_ctx,
+                                                                  cli->srv_name_slash,
+                                                                  environment,
+                                                                  1,
+                                                                  &buffer,
+                                                                  offered,
+                                                                  &info,
+                                                                  &needed,
+                                                                  &result);
+       }
 
-       SAFE_FREE(environment);
+       if (W_ERROR_IS_OK(result)) {
+               printf("%s\n", info.info1.directory_name);
+       }
 
        return result;
 }
@@ -1612,62 +1714,84 @@ static WERROR cmd_spoolss_addform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        POLICY_HND handle;
        WERROR werror;
        NTSTATUS status;
-       char *printername = NULL;
-       bool got_handle = False;
+       const char *printername;
        union spoolss_AddFormInfo info;
        struct spoolss_AddFormInfo1 info1;
+       struct spoolss_AddFormInfo2 info2;
+       uint32_t level = 1;
 
        /* Parse the command arguments */
 
-       if (argc != 3) {
-               printf ("Usage: %s <printer> <formname>\n", argv[0]);
+       if (argc < 3 || argc > 5) {
+               printf ("Usage: %s <printer> <formname> [level]\n", argv[0]);
                return WERR_OK;
         }
 
        /* Get a printer handle */
 
-       if (asprintf(&printername, "%s\\%s", cli->srv_name_slash, argv[1]) == -1) {
-               return WERR_NOMEM;
-       }
-
-       werror = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "",
-                                            PRINTER_ALL_ACCESS,
-                                            cli->srv_name_slash, cli->auth->user_name,
-                                            &handle);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              PRINTER_ALL_ACCESS,
+                                              &handle);
        if (!W_ERROR_IS_OK(werror))
                goto done;
 
-       got_handle = True;
-
        /* Dummy up some values for the form data */
 
-       info1.flags             = FORM_USER;
-       info1.form_name         = argv[2];
-       info1.size.width        = 100;
-       info1.size.height       = 100;
-       info1.area.left         = 0;
-       info1.area.top          = 10;
-       info1.area.right        = 20;
-       info1.area.bottom       = 30;
+       if (argc == 4) {
+               level = atoi(argv[3]);
+       }
 
-       info.info1 = &info1;
+       switch (level) {
+       case 1:
+               info1.flags             = SPOOLSS_FORM_USER;
+               info1.form_name         = argv[2];
+               info1.size.width        = 100;
+               info1.size.height       = 100;
+               info1.area.left         = 0;
+               info1.area.top          = 10;
+               info1.area.right        = 20;
+               info1.area.bottom       = 30;
+
+               info.info1 = &info1;
+
+               break;
+       case 2:
+               info2.flags             = SPOOLSS_FORM_USER;
+               info2.form_name         = argv[2];
+               info2.size.width        = 100;
+               info2.size.height       = 100;
+               info2.area.left         = 0;
+               info2.area.top          = 10;
+               info2.area.right        = 20;
+               info2.area.bottom       = 30;
+               info2.keyword           = argv[2];
+               info2.string_type       = SPOOLSS_FORM_STRING_TYPE_NONE;
+               info2.mui_dll           = NULL;
+               info2.ressource_id      = 0;
+               info2.display_name      = argv[2];
+               info2.lang_id           = 0;
+
+               info.info2 = &info2;
+
+               break;
+       }
 
        /* Add the form */
 
 
        status = rpccli_spoolss_AddForm(cli, mem_ctx,
                                        &handle,
-                                       1,
+                                       level,
                                        info,
                                        &werror);
 
  done:
-       if (got_handle)
+       if (is_valid_policy_hnd(&handle))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &handle, NULL);
 
-       SAFE_FREE(printername);
-
        return werror;
 }
 
@@ -1680,8 +1804,7 @@ static WERROR cmd_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        POLICY_HND handle;
        WERROR werror;
        NTSTATUS status;
-       char *printername = NULL;
-       bool got_handle = False;
+       const char *printername;
        union spoolss_AddFormInfo info;
        struct spoolss_AddFormInfo1 info1;
 
@@ -1694,22 +1817,18 @@ static WERROR cmd_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
 
        /* Get a printer handle */
 
-       if (asprintf(&printername, "%s\\%s", cli->srv_name_slash, argv[1]) == -1) {
-               return WERR_NOMEM;
-       }
-
-       werror = rpccli_spoolss_open_printer_ex(
-               cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS,
-               cli->srv_name_slash, cli->auth->user_name, &handle);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &handle);
        if (!W_ERROR_IS_OK(werror))
                goto done;
 
-       got_handle = True;
-
        /* Dummy up some values for the form data */
 
-       info1.flags             = FORM_PRINTER;
+       info1.flags             = SPOOLSS_FORM_PRINTER;
        info1.size.width        = 100;
        info1.size.height       = 100;
        info1.area.left         = 0;
@@ -1730,11 +1849,9 @@ static WERROR cmd_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
                                        &werror);
 
  done:
-       if (got_handle)
+       if (is_valid_policy_hnd(&handle))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &handle, NULL);
 
-       SAFE_FREE(printername);
-
        return werror;
 }
 
@@ -1744,11 +1861,11 @@ static WERROR cmd_spoolss_setform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
 static const char *get_form_flag(int form_flag)
 {
        switch (form_flag) {
-       case FORM_USER:
+       case SPOOLSS_FORM_USER:
                return "FORM_USER";
-       case FORM_BUILTIN:
+       case SPOOLSS_FORM_BUILTIN:
                return "FORM_BUILTIN";
-       case FORM_PRINTER:
+       case SPOOLSS_FORM_PRINTER:
                return "FORM_PRINTER";
        default:
                return "unknown";
@@ -1758,37 +1875,38 @@ static const char *get_form_flag(int form_flag)
 /****************************************************************************
 ****************************************************************************/
 
-static void display_form(FORM_1 *form)
+static void display_form_info1(struct spoolss_FormInfo1 *r)
 {
-       fstring form_name = "";
-
-       if (form->name.buffer)
-               rpcstr_pull(form_name, form->name.buffer,
-                           sizeof(form_name), -1, STR_TERMINATE);
-
        printf("%s\n" \
                "\tflag: %s (%d)\n" \
                "\twidth: %d, length: %d\n" \
                "\tleft: %d, right: %d, top: %d, bottom: %d\n\n",
-               form_name, get_form_flag(form->flag), form->flag,
-               form->width, form->length,
-               form->left, form->right,
-               form->top, form->bottom);
+               r->form_name, get_form_flag(r->flags), r->flags,
+               r->size.width, r->size.height,
+               r->area.left, r->area.right,
+               r->area.top, r->area.bottom);
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static void display_form_info1(struct spoolss_FormInfo1 *r)
+static void display_form_info2(struct spoolss_FormInfo2 *r)
 {
        printf("%s\n" \
                "\tflag: %s (%d)\n" \
                "\twidth: %d, length: %d\n" \
-               "\tleft: %d, right: %d, top: %d, bottom: %d\n\n",
+               "\tleft: %d, right: %d, top: %d, bottom: %d\n",
                r->form_name, get_form_flag(r->flags), r->flags,
                r->size.width, r->size.height,
                r->area.left, r->area.right,
                r->area.top, r->area.bottom);
+       printf("\tkeyword: %s\n", r->keyword);
+       printf("\tstring_type: 0x%08x\n", r->string_type);
+       printf("\tmui_dll: %s\n", r->mui_dll);
+       printf("\tressource_id: 0x%08x\n", r->ressource_id);
+       printf("\tdisplay_name: %s\n", r->display_name);
+       printf("\tlang_id: %d\n", r->lang_id);
+       printf("\n");
 }
 
 /****************************************************************************
@@ -1800,53 +1918,53 @@ static WERROR cmd_spoolss_getform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
        POLICY_HND handle;
        WERROR werror;
        NTSTATUS status;
-       char *printername = NULL;
-       bool got_handle = False;
+       const char *printername;
        DATA_BLOB buffer;
        uint32_t offered = 0;
        union spoolss_FormInfo info;
        uint32_t needed;
+       uint32_t level = 1;
 
        /* Parse the command arguments */
 
-       if (argc != 3) {
-               printf ("Usage: %s <printer> <formname>\n", argv[0]);
+       if (argc < 3 || argc > 5) {
+               printf ("Usage: %s <printer> <formname> [level]\n", argv[0]);
                return WERR_OK;
         }
 
        /* Get a printer handle */
 
-       if (asprintf(&printername, "%s\\%s", cli->srv_name_slash, argv[1]) == -1) {
-               return WERR_NOMEM;
-       }
-
-       werror = rpccli_spoolss_open_printer_ex(
-               cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS,
-               cli->srv_name_slash, cli->auth->user_name, &handle);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &handle);
        if (!W_ERROR_IS_OK(werror))
                goto done;
 
-       got_handle = True;
+       if (argc == 4) {
+               level = atoi(argv[3]);
+       }
 
        /* Get the form */
 
        status = rpccli_spoolss_GetForm(cli, mem_ctx,
                                        &handle,
                                        argv[2],
-                                       1,
+                                       level,
                                        NULL,
                                        offered,
                                        &info,
                                        &needed,
                                        &werror);
        if (W_ERROR_EQUAL(werror, WERR_INSUFFICIENT_BUFFER)) {
-               buffer = data_blob_talloc(mem_ctx, NULL, needed);
+               buffer = data_blob_talloc_zero(mem_ctx, needed);
                offered = needed;
                status = rpccli_spoolss_GetForm(cli, mem_ctx,
                                                &handle,
                                                argv[2],
-                                               1,
+                                               level,
                                                &buffer,
                                                offered,
                                                &info,
@@ -1858,13 +1976,19 @@ static WERROR cmd_spoolss_getform(struct rpc_pipe_client *cli, TALLOC_CTX *mem_c
                return werror;
        }
 
-       display_form_info1(&info.info1);
+       switch (level) {
+       case 1:
+               display_form_info1(&info.info1);
+               break;
+       case 2:
+               display_form_info2(&info.info2);
+               break;
+       }
+
  done:
-       if (got_handle)
+       if (is_valid_policy_hnd(&handle))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &handle, NULL);
 
-       SAFE_FREE(printername);
-
        return werror;
 }
 
@@ -1878,8 +2002,7 @@ static WERROR cmd_spoolss_deleteform(struct rpc_pipe_client *cli,
        POLICY_HND handle;
        WERROR werror;
        NTSTATUS status;
-       char *printername = NULL;
-       bool got_handle = False;
+       const char *printername;
 
        /* Parse the command arguments */
 
@@ -1890,19 +2013,15 @@ static WERROR cmd_spoolss_deleteform(struct rpc_pipe_client *cli,
 
        /* Get a printer handle */
 
-       if (asprintf(&printername, "%s\\%s", cli->srv_name_slash, argv[1]) == -1) {
-               return WERR_NOMEM;
-       }
-
-       werror = rpccli_spoolss_open_printer_ex(
-               cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS,
-               cli->srv_name_slash, cli->auth->user_name, &handle);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &handle);
        if (!W_ERROR_IS_OK(werror))
                goto done;
 
-       got_handle = True;
-
        /* Delete the form */
 
        status = rpccli_spoolss_DeleteForm(cli, mem_ctx,
@@ -1914,11 +2033,9 @@ static WERROR cmd_spoolss_deleteform(struct rpc_pipe_client *cli,
        }
 
  done:
-       if (got_handle)
+       if (is_valid_policy_hnd(&handle))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &handle, NULL);
 
-       SAFE_FREE(printername);
-
        return werror;
 }
 
@@ -1931,36 +2048,40 @@ static WERROR cmd_spoolss_enum_forms(struct rpc_pipe_client *cli,
 {
        POLICY_HND handle;
        WERROR werror;
-       char *printername = NULL;
-       bool got_handle = False;
+       const char *printername;
        uint32 num_forms, level = 1, i;
-       FORM_1 *forms;
+       union spoolss_FormInfo *forms;
 
        /* Parse the command arguments */
 
-       if (argc != 2) {
-               printf ("Usage: %s <printer>\n", argv[0]);
+       if (argc < 2 || argc > 4) {
+               printf ("Usage: %s <printer> [level]\n", argv[0]);
                return WERR_OK;
         }
 
        /* Get a printer handle */
 
-       if (asprintf(&printername, "%s\\%s", cli->srv_name_slash, argv[1]) == -1) {
-               return WERR_NOMEM;
-       }
-
-       werror = rpccli_spoolss_open_printer_ex(
-               cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS,
-               cli->srv_name_slash, cli->auth->user_name, &handle);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &handle);
        if (!W_ERROR_IS_OK(werror))
                goto done;
 
-       got_handle = True;
+       if (argc == 3) {
+               level = atoi(argv[2]);
+       }
 
        /* Enumerate forms */
 
-       werror = rpccli_spoolss_enumforms(cli, mem_ctx, &handle, level, &num_forms, &forms);
+       werror = rpccli_spoolss_enumforms(cli, mem_ctx,
+                                         &handle,
+                                         level,
+                                         0,
+                                         &num_forms,
+                                         &forms);
 
        if (!W_ERROR_IS_OK(werror))
                goto done;
@@ -1968,17 +2089,20 @@ static WERROR cmd_spoolss_enum_forms(struct rpc_pipe_client *cli,
        /* Display output */
 
        for (i = 0; i < num_forms; i++) {
-
-               display_form(&forms[i]);
-
+               switch (level) {
+               case 1:
+                       display_form_info1(&forms[i].info1);
+                       break;
+               case 2:
+                       display_form_info2(&forms[i].info2);
+                       break;
+               }
        }
 
  done:
-       if (got_handle)
+       if (is_valid_policy_hnd(&handle))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &handle, NULL);
 
-       SAFE_FREE(printername);
-
        return werror;
 }
 
@@ -1990,13 +2114,12 @@ static WERROR cmd_spoolss_setprinterdata(struct rpc_pipe_client *cli,
                                            int argc, const char **argv)
 {
        WERROR result;
-       fstring printername;
+       NTSTATUS status;
+       const char *printername;
        POLICY_HND pol;
-       bool opened_hnd = False;
-       PRINTER_INFO_CTR ctr;
-       PRINTER_INFO_0 info;
-       REGISTRY_VALUE value;
-       TALLOC_CTX *tmp_ctx = talloc_stackframe();
+       union spoolss_PrinterInfo info;
+       enum winreg_Type type;
+       union spoolss_PrinterData data;
 
        /* parse the command arguments */
        if (argc < 5) {
@@ -2007,143 +2130,128 @@ static WERROR cmd_spoolss_setprinterdata(struct rpc_pipe_client *cli,
                goto done;
        }
 
-       slprintf(printername, sizeof(printername)-1, "%s\\%s", cli->srv_name_slash, argv[1]);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
-       value.type = REG_NONE;
+       type = REG_NONE;
 
        if (strequal(argv[2], "string")) {
-               value.type = REG_SZ;
+               type = REG_SZ;
        }
 
        if (strequal(argv[2], "binary")) {
-               value.type = REG_BINARY;
+               type = REG_BINARY;
        }
 
        if (strequal(argv[2], "dword")) {
-               value.type = REG_DWORD;
+               type = REG_DWORD;
        }
 
        if (strequal(argv[2], "multistring")) {
-               value.type = REG_MULTI_SZ;
+               type = REG_MULTI_SZ;
        }
 
-       if (value.type == REG_NONE) {
+       if (type == REG_NONE) {
                printf("Unknown data type: %s\n", argv[2]);
                result =  WERR_INVALID_PARAM;
                goto done;
        }
 
        /* get a printer handle */
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername, "",
-                                            MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &pol);
-       if (!W_ERROR_IS_OK(result))
-               goto done;
-
-       opened_hnd = True;
 
-       ctr.printers_0 = &info;
-
-        result = rpccli_spoolss_getprinter(cli, mem_ctx, &pol, 0, &ctr);
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &pol);
+       if (!W_ERROR_IS_OK(result)) {
+               goto done;
+       }
 
-        if (!W_ERROR_IS_OK(result))
+       result = rpccli_spoolss_getprinter(cli, mem_ctx,
+                                          &pol,
+                                          0,
+                                          0,
+                                          &info);
+        if (!W_ERROR_IS_OK(result)) {
                 goto done;
+       }
 
-       printf("%s\n", current_timestring(tmp_ctx, True));
-       printf("\tchange_id (before set)\t:[0x%x]\n", info.change_id);
+       printf("%s\n", current_timestring(mem_ctx, true));
+       printf("\tchange_id (before set)\t:[0x%x]\n", info.info0.change_id);
 
        /* Set the printer data */
 
-       fstrcpy(value.valuename, argv[3]);
-
-       switch (value.type) {
-       case REG_SZ: {
-               UNISTR2 data;
-               init_unistr2(&data, argv[4], UNI_STR_TERMINATE);
-               value.size = data.uni_str_len * 2;
-               if (value.size) {
-                       value.data_p = (uint8 *)TALLOC_MEMDUP(mem_ctx, data.buffer,
-                                                     value.size);
-               } else {
-                       value.data_p = NULL;
-               }
+       switch (type) {
+       case REG_SZ:
+               data.string = talloc_strdup(mem_ctx, argv[4]);
+               W_ERROR_HAVE_NO_MEMORY(data.string);
                break;
-       }
-       case REG_DWORD: {
-               uint32 data = strtoul(argv[4], NULL, 10);
-               value.size = sizeof(data);
-               if (sizeof(data)) {
-                       value.data_p = (uint8 *)TALLOC_MEMDUP(mem_ctx, &data,
-                                                     sizeof(data));
-               } else {
-                       value.data_p = NULL;
-               }
+       case REG_DWORD:
+               data.value = strtoul(argv[4], NULL, 10);
                break;
-       }
-       case REG_BINARY: {
-               DATA_BLOB data = strhex_to_data_blob(mem_ctx, argv[4]);
-               value.data_p = data.data;
-               value.size = data.length;
+       case REG_BINARY:
+               data.binary = strhex_to_data_blob(mem_ctx, argv[4]);
                break;
-       }
        case REG_MULTI_SZ: {
-               int i;
-               size_t len = 0;
-               char *p;
+               int i, num_strings;
+               const char **strings = NULL;
 
                for (i=4; i<argc; i++) {
                        if (strcmp(argv[i], "NULL") == 0) {
                                argv[i] = "";
                        }
-                       len += strlen(argv[i])+1;
+                       if (!add_string_to_array(mem_ctx, argv[i],
+                                                &strings,
+                                                &num_strings)) {
+                               result = WERR_NOMEM;
+                               goto done;
+                       }
                }
-
-               value.size = len*2;
-               value.data_p = TALLOC_ARRAY(mem_ctx, unsigned char, value.size);
-               if (value.data_p == NULL) {
+               data.string_array = talloc_zero_array(mem_ctx, const char *, num_strings + 1);
+               if (!data.string_array) {
                        result = WERR_NOMEM;
                        goto done;
                }
-
-               p = (char *)value.data_p;
-               len = value.size;
-               for (i=4; i<argc; i++) {
-                       size_t l = (strlen(argv[i])+1)*2;
-                       rpcstr_push(p, argv[i], len, STR_TERMINATE);
-                       p += l;
-                       len -= l;
+               for (i=0; i < num_strings; i++) {
+                       data.string_array[i] = strings[i];
                }
-               SMB_ASSERT(len == 0);
                break;
-       }
+               }
        default:
                printf("Unknown data type: %s\n", argv[2]);
                result = WERR_INVALID_PARAM;
                goto done;
        }
 
-       result = rpccli_spoolss_setprinterdata(cli, mem_ctx, &pol, &value);
-
+       status = rpccli_spoolss_SetPrinterData(cli, mem_ctx,
+                                              &pol,
+                                              argv[3], /* value_name */
+                                              type,
+                                              data,
+                                              0, /* autocalculated size */
+                                              &result);
        if (!W_ERROR_IS_OK(result)) {
                printf ("Unable to set [%s=%s]!\n", argv[3], argv[4]);
                goto done;
        }
        printf("\tSetPrinterData succeeded [%s: %s]\n", argv[3], argv[4]);
 
-        result = rpccli_spoolss_getprinter(cli, mem_ctx, &pol, 0, &ctr);
-
-        if (!W_ERROR_IS_OK(result))
+       result = rpccli_spoolss_getprinter(cli, mem_ctx,
+                                          &pol,
+                                          0,
+                                          0,
+                                          &info);
+        if (!W_ERROR_IS_OK(result)) {
                 goto done;
+       }
 
-       printf("%s\n", current_timestring(tmp_ctx, True));
-       printf("\tchange_id (after set)\t:[0x%x]\n", info.change_id);
+       printf("%s\n", current_timestring(mem_ctx, true));
+       printf("\tchange_id (after set)\t:[0x%x]\n", info.info0.change_id);
 
 done:
        /* cleanup */
-       TALLOC_FREE(tmp_ctx);
-       if (opened_hnd)
+       if (is_valid_policy_hnd(&pol)) {
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
+       }
 
        return result;
 }
@@ -2151,43 +2259,42 @@ done:
 /****************************************************************************
 ****************************************************************************/
 
-static void display_job_info_1(JOB_INFO_1 *job)
+static void display_job_info1(struct spoolss_JobInfo1 *r)
 {
-       fstring username = "", document = "", text_status = "";
-
-       rpcstr_pull(username, job->username.buffer,
-                   sizeof(username), -1, STR_TERMINATE);
-
-       rpcstr_pull(document, job->document.buffer,
-                   sizeof(document), -1, STR_TERMINATE);
-
-       rpcstr_pull(text_status, job->text_status.buffer,
-                   sizeof(text_status), -1, STR_TERMINATE);
-
-       printf("%d: jobid[%d]: %s %s %s %d/%d pages\n", job->position, job->jobid,
-              username, document, text_status, job->pagesprinted,
-              job->totalpages);
+       printf("%d: jobid[%d]: %s %s %s %d/%d pages\n", r->position, r->job_id,
+              r->user_name, r->document_name, r->text_status, r->pages_printed,
+              r->total_pages);
 }
 
 /****************************************************************************
 ****************************************************************************/
 
-static void display_job_info_2(JOB_INFO_2 *job)
+static void display_job_info2(struct spoolss_JobInfo2 *r)
 {
-       fstring username = "", document = "", text_status = "";
+       printf("%d: jobid[%d]: %s %s %s %d/%d pages, %d bytes\n",
+              r->position, r->job_id,
+              r->user_name, r->document_name, r->text_status, r->pages_printed,
+              r->total_pages, r->size);
+}
 
-       rpcstr_pull(username, job->username.buffer,
-                   sizeof(username), -1, STR_TERMINATE);
+/****************************************************************************
+****************************************************************************/
 
-       rpcstr_pull(document, job->document.buffer,
-                   sizeof(document), -1, STR_TERMINATE);
+static void display_job_info3(struct spoolss_JobInfo3 *r)
+{
+       printf("jobid[%d], next_jobid[%d]\n",
+               r->job_id, r->next_job_id);
+}
 
-       rpcstr_pull(text_status, job->text_status.buffer,
-                   sizeof(text_status), -1, STR_TERMINATE);
+/****************************************************************************
+****************************************************************************/
 
-       printf("%d: jobid[%d]: %s %s %s %d/%d pages, %d bytes\n", job->position, job->jobid,
-              username, document, text_status, job->pagesprinted,
-              job->totalpages, job->size);
+static void display_job_info4(struct spoolss_JobInfo4 *r)
+{
+       printf("%d: jobid[%d]: %s %s %s %d/%d pages, %d/%d bytes\n",
+              r->position, r->job_id,
+              r->user_name, r->document_name, r->text_status, r->pages_printed,
+              r->total_pages, r->size, r->size_high);
 }
 
 /****************************************************************************
@@ -2198,57 +2305,52 @@ static WERROR cmd_spoolss_enum_jobs(struct rpc_pipe_client *cli,
                                      const char **argv)
 {
        WERROR result;
-       uint32 level = 1, num_jobs, i;
-       bool got_hnd = False;
-       char *printername = NULL;
+       uint32_t level = 1, count, i;
+       const char *printername;
        POLICY_HND hnd;
-       JOB_INFO_CTR ctr;
+       union spoolss_JobInfo *info;
 
        if (argc < 2 || argc > 3) {
                printf("Usage: %s printername [level]\n", argv[0]);
                return WERR_OK;
        }
 
-       if (argc == 3)
+       if (argc == 3) {
                level = atoi(argv[2]);
+       }
 
        /* Open printer handle */
 
-       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
-       if (!printername) {
-               return WERR_NOMEM;
-       }
-       strupper_m(printername);
-       printername = talloc_asprintf_append(printername, "%s", argv[1]);
-       if (!printername) {
-               return WERR_NOMEM;
-       }
-
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &hnd);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &hnd);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
-       got_hnd = True;
-
        /* Enumerate ports */
 
-       result = rpccli_spoolss_enumjobs(cli, mem_ctx, &hnd, level, 0, 1000,
-               &num_jobs, &ctr);
-
-       if (!W_ERROR_IS_OK(result))
+       result = rpccli_spoolss_enumjobs(cli, mem_ctx,
+                                        &hnd,
+                                        0, /* firstjob */
+                                        1000, /* numjobs */
+                                        level,
+                                        0,
+                                        &count,
+                                        &info);
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
+       }
 
-       for (i = 0; i < num_jobs; i++) {
-               switch(level) {
+       for (i = 0; i < count; i++) {
+               switch (level) {
                case 1:
-                       display_job_info_1(&ctr.job.job_info_1[i]);
+                       display_job_info1(&info[i].info1);
                        break;
                case 2:
-                       display_job_info_2(&ctr.job.job_info_2[i]);
+                       display_job_info2(&info[i].info2);
                        break;
                default:
                        d_printf("unknown info level %d\n", level);
@@ -2257,8 +2359,9 @@ static WERROR cmd_spoolss_enum_jobs(struct rpc_pipe_client *cli,
        }
 
 done:
-       if (got_hnd)
+       if (is_valid_policy_hnd(&hnd)) {
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &hnd, NULL);
+       }
 
        return result;
 }
@@ -2266,15 +2369,99 @@ done:
 /****************************************************************************
 ****************************************************************************/
 
-static WERROR cmd_spoolss_enum_data( struct rpc_pipe_client *cli,
-                                      TALLOC_CTX *mem_ctx, int argc,
-                                      const char **argv)
+static WERROR cmd_spoolss_get_job(struct rpc_pipe_client *cli,
+                                 TALLOC_CTX *mem_ctx, int argc,
+                                 const char **argv)
+{
+       WERROR result;
+       const char *printername;
+       struct policy_handle hnd;
+       uint32_t job_id;
+       uint32_t level = 1;
+       union spoolss_JobInfo info;
+
+       if (argc < 3 || argc > 4) {
+               printf("Usage: %s printername job_id [level]\n", argv[0]);
+               return WERR_OK;
+       }
+
+       job_id = atoi(argv[2]);
+
+       if (argc == 4) {
+               level = atoi(argv[3]);
+       }
+
+       /* Open printer handle */
+
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
+
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &hnd);
+       if (!W_ERROR_IS_OK(result)) {
+               goto done;
+       }
+
+       /* Enumerate ports */
+
+       result = rpccli_spoolss_getjob(cli, mem_ctx,
+                                      &hnd,
+                                      job_id,
+                                      level,
+                                      0,
+                                      &info);
+
+       if (!W_ERROR_IS_OK(result)) {
+               goto done;
+       }
+
+       switch (level) {
+       case 1:
+               display_job_info1(&info.info1);
+               break;
+       case 2:
+               display_job_info2(&info.info2);
+               break;
+       case 3:
+               display_job_info3(&info.info3);
+               break;
+       case 4:
+               display_job_info4(&info.info4);
+               break;
+       default:
+               d_printf("unknown info level %d\n", level);
+               break;
+       }
+
+done:
+       if (is_valid_policy_hnd(&hnd)) {
+               rpccli_spoolss_ClosePrinter(cli, mem_ctx, &hnd, NULL);
+       }
+
+       return result;
+}
+
+
+/****************************************************************************
+****************************************************************************/
+
+static WERROR cmd_spoolss_enum_data(struct rpc_pipe_client *cli,
+                                   TALLOC_CTX *mem_ctx, int argc,
+                                   const char **argv)
 {
        WERROR result;
-       uint32 i=0, val_needed, data_needed;
-       bool got_hnd = False;
-       char *printername = NULL;
+       NTSTATUS status;
+       uint32_t i = 0;
+       const char *printername;
        POLICY_HND hnd;
+       uint32_t value_offered = 0;
+       const char *value_name = NULL;
+       uint32_t value_needed;
+       enum winreg_Type type;
+       uint8_t *data = NULL;
+       uint32_t data_offered = 0;
+       uint32_t data_needed;
 
        if (argc != 2) {
                printf("Usage: %s printername\n", argv[0]);
@@ -2283,45 +2470,66 @@ static WERROR cmd_spoolss_enum_data( struct rpc_pipe_client *cli,
 
        /* Open printer handle */
 
-       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
-       if (!printername) {
-               return WERR_NOMEM;
-       }
-       strupper_m(printername);
-       printername = talloc_asprintf_append(printername, "%s", argv[1]);
-       if (!printername) {
-               return WERR_NOMEM;
-       }
-
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &hnd);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
-       if (!W_ERROR_IS_OK(result))
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &hnd);
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
-
-       got_hnd = True;
+       }
 
        /* Enumerate data */
 
-       result = rpccli_spoolss_enumprinterdata(cli, mem_ctx, &hnd, i, 0, 0,
-                                            &val_needed, &data_needed,
-                                            NULL);
-       while (W_ERROR_IS_OK(result)) {
-               REGISTRY_VALUE value;
-               result = rpccli_spoolss_enumprinterdata(
-                       cli, mem_ctx, &hnd, i++, val_needed,
-                       data_needed, 0, 0, &value);
-               if (W_ERROR_IS_OK(result))
-                       display_reg_value(value);
-       }
-       if (W_ERROR_V(result) == ERRnomoreitems)
+       status = rpccli_spoolss_EnumPrinterData(cli, mem_ctx,
+                                               &hnd,
+                                               i,
+                                               value_name,
+                                               value_offered,
+                                               &value_needed,
+                                               &type,
+                                               data,
+                                               data_offered,
+                                               &data_needed,
+                                               &result);
+
+       data_offered    = data_needed;
+       value_offered   = value_needed;
+       data            = talloc_zero_array(mem_ctx, uint8_t, data_needed);
+       value_name      = talloc_zero_array(mem_ctx, char, value_needed);
+
+       while (NT_STATUS_IS_OK(status) && W_ERROR_IS_OK(result)) {
+
+               status = rpccli_spoolss_EnumPrinterData(cli, mem_ctx,
+                                                       &hnd,
+                                                       i++,
+                                                       value_name,
+                                                       value_offered,
+                                                       &value_needed,
+                                                       &type,
+                                                       data,
+                                                       data_offered,
+                                                       &data_needed,
+                                                       &result);
+               if (NT_STATUS_IS_OK(status) && W_ERROR_IS_OK(result)) {
+                       REGISTRY_VALUE v;
+                       fstrcpy(v.valuename, value_name);
+                       v.type = type;
+                       v.size = data_offered;
+                       v.data_p = data;
+                       display_reg_value(v);
+               }
+       }
+
+       if (W_ERROR_V(result) == ERRnomoreitems) {
                result = W_ERROR(ERRsuccess);
+       }
 
 done:
-       if (got_hnd)
+       if (is_valid_policy_hnd(&hnd)) {
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &hnd, NULL);
+       }
 
        return result;
 }
@@ -2335,8 +2543,7 @@ static WERROR cmd_spoolss_enum_data_ex( struct rpc_pipe_client *cli,
 {
        WERROR result;
        uint32 i;
-       bool got_hnd = False;
-       char *printername = NULL;
+       const char *printername;
        const char *keyname = NULL;
        POLICY_HND hnd;
        REGVAL_CTR *ctr = NULL;
@@ -2350,26 +2557,15 @@ static WERROR cmd_spoolss_enum_data_ex( struct rpc_pipe_client *cli,
 
        /* Open printer handle */
 
-       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
-       if (!printername) {
-               return WERR_NOMEM;
-       }
-       strupper_m(printername);
-       printername = talloc_asprintf_append(printername, "%s", argv[1]);
-       if (!printername) {
-               return WERR_NOMEM;
-       }
-
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &hnd);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &hnd);
        if (!W_ERROR_IS_OK(result))
                goto done;
 
-       got_hnd = True;
-
        /* Enumerate subkeys */
 
        if ( !(ctr = TALLOC_ZERO_P( mem_ctx, REGVAL_CTR )) )
@@ -2387,7 +2583,7 @@ static WERROR cmd_spoolss_enum_data_ex( struct rpc_pipe_client *cli,
        TALLOC_FREE( ctr );
 
 done:
-       if (got_hnd)
+       if (is_valid_policy_hnd(&hnd))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &hnd, NULL);
 
        return result;
@@ -2396,75 +2592,61 @@ done:
 /****************************************************************************
 ****************************************************************************/
 
-static WERROR cmd_spoolss_enum_printerkey( struct rpc_pipe_client *cli,
-                                            TALLOC_CTX *mem_ctx, int argc,
-                                            const char **argv)
+static WERROR cmd_spoolss_enum_printerkey(struct rpc_pipe_client *cli,
+                                         TALLOC_CTX *mem_ctx, int argc,
+                                         const char **argv)
 {
        WERROR result;
-       bool got_hnd = False;
-       char *printername = NULL;
+       const char *printername;
        const char *keyname = NULL;
        POLICY_HND hnd;
-       uint16 *keylist = NULL, *curkey;
+       const char **key_buffer = NULL;
+       int i;
 
        if (argc < 2 || argc > 3) {
                printf("Usage: %s printername [keyname]\n", argv[0]);
                return WERR_OK;
        }
 
-       if (argc == 3)
+       if (argc == 3) {
                keyname = argv[2];
-       else
+       } else {
                keyname = "";
-
-       /* Open printer handle */
-
-       printername = talloc_asprintf(mem_ctx, "\\\\%s\\", cli->desthost);
-       if (!printername) {
-               return WERR_NOMEM;
-       }
-       strupper_m(printername);
-       printername = talloc_asprintf_append(printername, "%s", argv[1]);
-       if (!printername) {
-               return WERR_NOMEM;
        }
 
+       /* Open printer handle */
 
-       result = rpccli_spoolss_open_printer_ex(cli, mem_ctx, printername,
-                                            "", MAXIMUM_ALLOWED_ACCESS,
-                                            cli->srv_name_slash,
-                                            cli->auth->user_name, &hnd);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
-       if (!W_ERROR_IS_OK(result))
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &hnd);
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
-
-       got_hnd = True;
+       }
 
        /* Enumerate subkeys */
 
-       result = rpccli_spoolss_enumprinterkey(cli, mem_ctx, &hnd, keyname, &keylist, NULL);
+       result = rpccli_spoolss_enumprinterkey(cli, mem_ctx,
+                                              &hnd,
+                                              keyname,
+                                              &key_buffer,
+                                              0);
 
-       if (!W_ERROR_IS_OK(result))
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
-
-       curkey = keylist;
-       while (*curkey != 0) {
-               char *subkey = NULL;
-               rpcstr_pull_talloc(mem_ctx, &subkey, curkey, -1,
-                           STR_TERMINATE);
-               if (!subkey) {
-                       break;
-               }
-               printf("%s\n", subkey);
-               curkey += strlen(subkey) + 1;
        }
 
-done:
+       for (i=0; key_buffer && key_buffer[i]; i++) {
+               printf("%s\n", key_buffer[i]);
+       }
 
-       SAFE_FREE(keylist);
+ done:
 
-       if (got_hnd)
+       if (is_valid_policy_hnd(&hnd)) {
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &hnd, NULL);
+       }
 
        return result;
 }
@@ -2476,11 +2658,12 @@ static WERROR cmd_spoolss_rffpcnex(struct rpc_pipe_client *cli,
                                     TALLOC_CTX *mem_ctx, int argc,
                                     const char **argv)
 {
-       fstring servername, printername;
+       const char *printername;
+       const char *clientname;
        POLICY_HND hnd;
-       bool got_hnd = False;
        WERROR result;
-       SPOOL_NOTIFY_OPTION option;
+       NTSTATUS status;
+       struct spoolss_NotifyOption option;
 
        if (argc != 2) {
                printf("Usage: %s printername\n", argv[0]);
@@ -2490,62 +2673,69 @@ static WERROR cmd_spoolss_rffpcnex(struct rpc_pipe_client *cli,
 
        /* Open printer */
 
-       slprintf(printername, sizeof(printername) - 1, "\\\\%s\\%s",
-                cli->desthost, argv[1]);
-       strupper_m(printername);
-
-       result = rpccli_spoolss_open_printer_ex(
-               cli, mem_ctx, printername, "", MAXIMUM_ALLOWED_ACCESS,
-               cli->srv_name_slash, cli->auth->user_name, &hnd);
+       RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
 
+       result = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername,
+                                              SEC_FLAG_MAXIMUM_ALLOWED,
+                                              &hnd);
        if (!W_ERROR_IS_OK(result)) {
                printf("Error opening %s\n", argv[1]);
                goto done;
        }
 
-       got_hnd = True;
-
        /* Create spool options */
 
-       ZERO_STRUCT(option);
-
        option.version = 2;
-       option.option_type_ptr = 1;
-       option.count = option.ctr.count = 2;
+       option.count = 2;
 
-       option.ctr.type = TALLOC_ARRAY(mem_ctx, SPOOL_NOTIFY_OPTION_TYPE, 2);
-       if (option.ctr.type == NULL) {
+       option.types = talloc_array(mem_ctx, struct spoolss_NotifyOptionType, 2);
+       if (option.types == NULL) {
                result = WERR_NOMEM;
                goto done;
        }
 
-       ZERO_STRUCT(option.ctr.type[0]);
-       option.ctr.type[0].type = PRINTER_NOTIFY_TYPE;
-       option.ctr.type[0].count = option.ctr.type[0].count2 = 1;
-       option.ctr.type[0].fields_ptr = 1;
-       option.ctr.type[0].fields[0] = PRINTER_NOTIFY_SERVER_NAME;
-
-       ZERO_STRUCT(option.ctr.type[1]);
-       option.ctr.type[1].type = JOB_NOTIFY_TYPE;
-       option.ctr.type[1].count = option.ctr.type[1].count2 = 1;
-       option.ctr.type[1].fields_ptr = 1;
-       option.ctr.type[1].fields[0] = JOB_NOTIFY_PRINTER_NAME;
+       option.types[0].type = PRINTER_NOTIFY_TYPE;
+       option.types[0].count = 1;
+       option.types[0].fields = talloc_array(mem_ctx, enum spoolss_Field, 1);
+       if (option.types[0].fields == NULL) {
+               result = WERR_NOMEM;
+               goto done;
+       }
+       option.types[0].fields[0] = PRINTER_NOTIFY_SERVER_NAME;
 
-       /* Send rffpcnex */
+       option.types[1].type = JOB_NOTIFY_TYPE;
+       option.types[1].count = 1;
+       option.types[1].fields = talloc_array(mem_ctx, enum spoolss_Field, 1);
+       if (option.types[1].fields == NULL) {
+               result = WERR_NOMEM;
+               goto done;
+       }
+       option.types[1].fields[0] = JOB_NOTIFY_PRINTER_NAME;
 
-       slprintf(servername, sizeof(servername) - 1, "\\\\%s", myhostname());
-       strupper_m(servername);
+       clientname = talloc_asprintf(mem_ctx, "\\\\%s", global_myname());
+       if (!clientname) {
+               result = WERR_NOMEM;
+               goto done;
+       }
 
-       result = rpccli_spoolss_rffpcnex(
-               cli, mem_ctx, &hnd, 0, 0, cli->srv_name_slash, 123, &option);
+       /* Send rffpcnex */
 
+       status = rpccli_spoolss_RemoteFindFirstPrinterChangeNotifyEx(cli, mem_ctx,
+                                                                    &hnd,
+                                                                    0,
+                                                                    0,
+                                                                    clientname,
+                                                                    123,
+                                                                    &option,
+                                                                    &result);
        if (!W_ERROR_IS_OK(result)) {
                printf("Error rffpcnex %s\n", argv[1]);
                goto done;
        }
 
 done:
-       if (got_hnd)
+       if (is_valid_policy_hnd(&hnd))
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &hnd, NULL);
 
        return result;
@@ -2557,12 +2747,16 @@ done:
 static bool compare_printer( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
                              struct rpc_pipe_client *cli2, POLICY_HND *hnd2 )
 {
-       PRINTER_INFO_CTR ctr1, ctr2;
+       union spoolss_PrinterInfo info1, info2;
        WERROR werror;
        TALLOC_CTX *mem_ctx = talloc_init("compare_printer");
 
        printf("Retrieving printer propertiesfor %s...", cli1->desthost);
-       werror = rpccli_spoolss_getprinter( cli1, mem_ctx, hnd1, 2, &ctr1);
+       werror = rpccli_spoolss_getprinter(cli1, mem_ctx,
+                                          hnd1,
+                                          2,
+                                          0,
+                                          &info1);
        if ( !W_ERROR_IS_OK(werror) ) {
                printf("failed (%s)\n", win_errstr(werror));
                talloc_destroy(mem_ctx);
@@ -2571,7 +2765,11 @@ static bool compare_printer( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
        printf("ok\n");
 
        printf("Retrieving printer properties for %s...", cli2->desthost);
-       werror = rpccli_spoolss_getprinter( cli2, mem_ctx, hnd2, 2, &ctr2);
+       werror = rpccli_spoolss_getprinter(cli2, mem_ctx,
+                                          hnd2,
+                                          2,
+                                          0,
+                                          &info2);
        if ( !W_ERROR_IS_OK(werror) ) {
                printf("failed (%s)\n", win_errstr(werror));
                talloc_destroy(mem_ctx);
@@ -2590,7 +2788,7 @@ static bool compare_printer( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
 static bool compare_printer_secdesc( struct rpc_pipe_client *cli1, POLICY_HND *hnd1,
                                      struct rpc_pipe_client *cli2, POLICY_HND *hnd2 )
 {
-       PRINTER_INFO_CTR ctr1, ctr2;
+       union spoolss_PrinterInfo info1, info2;
        WERROR werror;
        TALLOC_CTX *mem_ctx = talloc_init("compare_printer_secdesc");
        SEC_DESC *sd1, *sd2;
@@ -2598,7 +2796,11 @@ static bool compare_printer_secdesc( struct rpc_pipe_client *cli1, POLICY_HND *h
 
 
        printf("Retrieving printer security for %s...", cli1->desthost);
-       werror = rpccli_spoolss_getprinter( cli1, mem_ctx, hnd1, 3, &ctr1);
+       werror = rpccli_spoolss_getprinter(cli1, mem_ctx,
+                                          hnd1,
+                                          3,
+                                          0,
+                                          &info1);
        if ( !W_ERROR_IS_OK(werror) ) {
                printf("failed (%s)\n", win_errstr(werror));
                result = False;
@@ -2607,7 +2809,11 @@ static bool compare_printer_secdesc( struct rpc_pipe_client *cli1, POLICY_HND *h
        printf("ok\n");
 
        printf("Retrieving printer security for %s...", cli2->desthost);
-       werror = rpccli_spoolss_getprinter( cli2, mem_ctx, hnd2, 3, &ctr2);
+       werror = rpccli_spoolss_getprinter(cli2, mem_ctx,
+                                          hnd2,
+                                          3,
+                                          0,
+                                          &info2);
        if ( !W_ERROR_IS_OK(werror) ) {
                printf("failed (%s)\n", win_errstr(werror));
                result = False;
@@ -2618,14 +2824,8 @@ static bool compare_printer_secdesc( struct rpc_pipe_client *cli1, POLICY_HND *h
 
        printf("++ ");
 
-       if ( (ctr1.printers_3 != ctr2.printers_3) && (!ctr1.printers_3 || !ctr2.printers_3) ) {
-               printf("NULL PRINTER_INFO_3!\n");
-               result = False;
-               goto done;
-       }
-
-       sd1 = ctr1.printers_3->secdesc;
-       sd2 = ctr2.printers_3->secdesc;
+       sd1 = info1.info3.secdesc;
+       sd2 = info2.info3.secdesc;
 
        if ( (sd1 != sd2) && ( !sd1 || !sd2 ) ) {
                printf("NULL secdesc!\n");
@@ -2656,9 +2856,8 @@ static WERROR cmd_spoolss_printercmp(struct rpc_pipe_client *cli,
                                     TALLOC_CTX *mem_ctx, int argc,
                                     const char **argv)
 {
-       fstring printername, servername1, servername2;
+       const char *printername;
        char *printername_path = NULL;
-       struct cli_state *cli_server1 = rpc_pipe_np_smb_conn(cli);
        struct cli_state *cli_server2 = NULL;
        struct rpc_pipe_client *cli2 = NULL;
        POLICY_HND hPrinter1, hPrinter2;
@@ -2670,16 +2869,11 @@ static WERROR cmd_spoolss_printercmp(struct rpc_pipe_client *cli,
                return WERR_OK;
        }
 
-       fstrcpy( printername, argv[1] );
-
-       fstrcpy( servername1, cli->desthost );
-       fstrcpy( servername2, argv[2] );
-       strupper_m( servername1 );
-       strupper_m( servername2 );
+       printername = argv[1];
 
        /* first get the connection to the remote server */
 
-       nt_status = cli_full_connection(&cli_server2, global_myname(), servername2,
+       nt_status = cli_full_connection(&cli_server2, global_myname(), argv[2],
                                        NULL, 0,
                                        "IPC$", "IPC",
                                        get_cmdline_auth_info_username(rpcclient_auth_info),
@@ -2695,38 +2889,33 @@ static WERROR cmd_spoolss_printercmp(struct rpc_pipe_client *cli,
                                             &cli2);
        if (!NT_STATUS_IS_OK(nt_status)) {
                printf("failed to open spoolss pipe on server %s (%s)\n",
-                       servername2, nt_errstr(nt_status));
+                       argv[2], nt_errstr(nt_status));
                return WERR_GENERAL_FAILURE;
        }
 
        /* now open up both printers */
 
-       printername_path = talloc_asprintf(mem_ctx,
-                               "\\\\%s\\%s",
-                               servername1,
-                               printername);
-       if (!printername_path) {
-               return WERR_NOMEM;
-       }
+       RPCCLIENT_PRINTERNAME(printername_path, cli, printername);
+
        printf("Opening %s...", printername_path);
-       werror = rpccli_spoolss_open_printer_ex( cli, mem_ctx, printername_path,
-               "", PRINTER_ALL_ACCESS, servername1, cli_server1->user_name, &hPrinter1);
+
+       werror = rpccli_spoolss_openprinter_ex(cli, mem_ctx,
+                                              printername_path,
+                                              PRINTER_ALL_ACCESS,
+                                              &hPrinter1);
        if ( !W_ERROR_IS_OK(werror) ) {
                printf("failed (%s)\n", win_errstr(werror));
                goto done;
        }
        printf("ok\n");
 
-       printername_path = talloc_asprintf(mem_ctx,
-                                       "\\\\%s\\%s",
-                                       servername2,
-                                       printername);
-       if (!printername_path) {
-               return WERR_NOMEM;
-       }
+       RPCCLIENT_PRINTERNAME(printername_path, cli2, printername);
+
        printf("Opening %s...", printername_path);
-       werror = rpccli_spoolss_open_printer_ex( cli2, mem_ctx, printername_path,
-               "", PRINTER_ALL_ACCESS, servername2, cli_server2->user_name, &hPrinter2 );
+       werror = rpccli_spoolss_openprinter_ex(cli2, mem_ctx,
+                                              printername_path,
+                                              PRINTER_ALL_ACCESS,
+                                              &hPrinter2);
        if ( !W_ERROR_IS_OK(werror) ) {
                 printf("failed (%s)\n", win_errstr(werror));
                goto done;
@@ -2754,6 +2943,176 @@ done:
        return WERR_OK;
 }
 
+static void display_proc_info1(struct spoolss_PrintProcessorInfo1 *r)
+{
+       printf("print_processor_name: %s\n", r->print_processor_name);
+}
+
+static WERROR cmd_spoolss_enum_procs(struct rpc_pipe_client *cli,
+                                    TALLOC_CTX *mem_ctx, int argc,
+                                    const char **argv)
+{
+       WERROR werror;
+       const char *environment = SPOOLSS_ARCHITECTURE_NT_X86;
+       uint32_t num_procs, level = 1, i;
+       union spoolss_PrintProcessorInfo *procs;
+
+       /* Parse the command arguments */
+
+       if (argc < 1 || argc > 4) {
+               printf ("Usage: %s [environment] [level]\n", argv[0]);
+               return WERR_OK;
+        }
+
+       if (argc >= 2) {
+               environment = argv[1];
+       }
+
+       if (argc == 3) {
+               level = atoi(argv[2]);
+       }
+
+       /* Enumerate Print Processors */
+
+       werror = rpccli_spoolss_enumprintprocessors(cli, mem_ctx,
+                                                   cli->srv_name_slash,
+                                                   environment,
+                                                   level,
+                                                   0,
+                                                   &num_procs,
+                                                   &procs);
+       if (!W_ERROR_IS_OK(werror))
+               goto done;
+
+       /* Display output */
+
+       for (i = 0; i < num_procs; i++) {
+               switch (level) {
+               case 1:
+                       display_proc_info1(&procs[i].info1);
+                       break;
+               }
+       }
+
+ done:
+       return werror;
+}
+
+static void display_proc_data_types_info1(struct spoolss_PrintProcDataTypesInfo1 *r)
+{
+       printf("name_array: %s\n", r->name_array);
+}
+
+static WERROR cmd_spoolss_enum_proc_data_types(struct rpc_pipe_client *cli,
+                                              TALLOC_CTX *mem_ctx, int argc,
+                                              const char **argv)
+{
+       WERROR werror;
+       const char *print_processor_name = "winprint";
+       uint32_t num_procs, level = 1, i;
+       union spoolss_PrintProcDataTypesInfo *procs;
+
+       /* Parse the command arguments */
+
+       if (argc < 1 || argc > 4) {
+               printf ("Usage: %s [environment] [level]\n", argv[0]);
+               return WERR_OK;
+        }
+
+       if (argc >= 2) {
+               print_processor_name = argv[1];
+       }
+
+       if (argc == 3) {
+               level = atoi(argv[2]);
+       }
+
+       /* Enumerate Print Processor Data Types */
+
+       werror = rpccli_spoolss_enumprintprocessordatatypes(cli, mem_ctx,
+                                                           cli->srv_name_slash,
+                                                           print_processor_name,
+                                                           level,
+                                                           0,
+                                                           &num_procs,
+                                                           &procs);
+       if (!W_ERROR_IS_OK(werror))
+               goto done;
+
+       /* Display output */
+
+       for (i = 0; i < num_procs; i++) {
+               switch (level) {
+               case 1:
+                       display_proc_data_types_info1(&procs[i].info1);
+                       break;
+               }
+       }
+
+ done:
+       return werror;
+}
+
+static void display_monitor1(const struct spoolss_MonitorInfo1 *r)
+{
+       printf("monitor_name: %s\n", r->monitor_name);
+}
+
+static void display_monitor2(const struct spoolss_MonitorInfo2 *r)
+{
+       printf("monitor_name: %s\n", r->monitor_name);
+       printf("environment: %s\n", r->environment);
+       printf("dll_name: %s\n", r->dll_name);
+}
+
+static WERROR cmd_spoolss_enum_monitors(struct rpc_pipe_client *cli,
+                                       TALLOC_CTX *mem_ctx, int argc,
+                                       const char **argv)
+{
+       WERROR werror;
+       uint32_t count, level = 1, i;
+       union spoolss_MonitorInfo *info;
+
+       /* Parse the command arguments */
+
+       if (argc > 2) {
+               printf("Usage: %s [level]\n", argv[0]);
+               return WERR_OK;
+       }
+
+       if (argc == 2) {
+               level = atoi(argv[1]);
+       }
+
+       /* Enumerate Print Monitors */
+
+       werror = rpccli_spoolss_enummonitors(cli, mem_ctx,
+                                            cli->srv_name_slash,
+                                            level,
+                                            0,
+                                            &count,
+                                            &info);
+       if (!W_ERROR_IS_OK(werror)) {
+               goto done;
+       }
+
+       /* Display output */
+
+       for (i = 0; i < count; i++) {
+               switch (level) {
+               case 1:
+                       display_monitor1(&info[i].info1);
+                       break;
+               case 2:
+                       display_monitor2(&info[i].info2);
+                       break;
+               }
+       }
+
+ done:
+       return werror;
+}
+
 /* List of commands exported by this module */
 struct cmd_set spoolss_commands[] = {
 
@@ -2767,6 +3126,7 @@ struct cmd_set spoolss_commands[] = {
        { "enumdataex",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_data_ex,       &syntax_spoolss, NULL, "Enumerate printer data for a key",    "" },
        { "enumkey",            RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_printerkey,    &syntax_spoolss, NULL, "Enumerate printer keys",              "" },
        { "enumjobs",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_jobs,          &syntax_spoolss, NULL, "Enumerate print jobs",                "" },
+       { "getjob",             RPC_RTYPE_WERROR, NULL, cmd_spoolss_get_job,            &syntax_spoolss, NULL, "Get print job",                       "" },
        { "enumports",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_ports,         &syntax_spoolss, NULL, "Enumerate printer ports",             "" },
        { "enumdrivers",        RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_drivers,       &syntax_spoolss, NULL, "Enumerate installed printer drivers", "" },
        { "enumprinters",       RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_printers,      &syntax_spoolss, NULL, "Enumerate printers",                  "" },
@@ -2788,6 +3148,9 @@ struct cmd_set spoolss_commands[] = {
        { "setprinterdata",     RPC_RTYPE_WERROR, NULL, cmd_spoolss_setprinterdata,     &syntax_spoolss, NULL, "Set REG_SZ printer data",             "" },
        { "rffpcnex",           RPC_RTYPE_WERROR, NULL, cmd_spoolss_rffpcnex,           &syntax_spoolss, NULL, "Rffpcnex test", "" },
        { "printercmp",         RPC_RTYPE_WERROR, NULL, cmd_spoolss_printercmp,         &syntax_spoolss, NULL, "Printer comparison test", "" },
+       { "enumprocs",          RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_procs,         &syntax_spoolss, NULL, "Enumerate Print Processors",          "" },
+       { "enumprocdatatypes",  RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_proc_data_types, &syntax_spoolss, NULL, "Enumerate Print Processor Data Types", "" },
+       { "enummonitors",       RPC_RTYPE_WERROR, NULL, cmd_spoolss_enum_monitors,      &syntax_spoolss, NULL, "Enumerate Print Monitors", "" },
 
        { NULL }
 };