Changes from APPLIANCE_HEAD:
[ira/wip.git] / source3 / rpc_server / srv_spoolss_nt.c
index 7d5036c6d40a371d61918466d91df6ec17da681a..23f8ab15efb1ddfa9fc5a805a113aa3253def429 100644 (file)
@@ -1,34 +1,29 @@
 #define OLD_NTDOMAIN 1
-/* 
+/*
  *  Unix SMB/Netbios implementation.
  *  Version 1.9.
  *  RPC Pipe client / server routines
  *  Copyright (C) Andrew Tridgell              1992-2000,
  *  Copyright (C) Luke Kenneth Casson Leighton 1996-2000,
  *  Copyright (C) Jean François Micouleau      1998-2000.
- *  
+ *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
  *  the Free Software Foundation; either version 2 of the License, or
  *  (at your option) any later version.
- *  
+ *
  *  This program is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  *  GNU General Public License for more details.
- *  
+ *
  *  You should have received a copy of the GNU General Public License
  *  along with this program; if not, write to the Free Software
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-
 #include "includes.h"
 
-#ifndef MANGLE_DRIVER_PATH
-#define MANGLE_DRIVER_PATH 0
-#endif
-
 extern int DEBUGLEVEL;
 extern pstring global_myname;
 
@@ -62,9 +57,11 @@ typedef struct _Printer{
        struct {
                uint32 flags;
                uint32 options;
-               fstring localmachine; 
+               fstring localmachine;
                uint32 printerlocal;
                SPOOL_NOTIFY_OPTION *option;
+               POLICY_HND client_hnd;
+               uint32 client_connected;
        } notify;
        struct {
                fstring machine;
@@ -83,6 +80,8 @@ typedef struct _counter_printer_0 {
 static ubi_dlList Printer_list;
 static ubi_dlList counter_list;
 
+static struct cli_state cli;
+static uint32 smb_connections=0;
 
 #define OPEN_HANDLE(pnum)    ((pnum!=NULL) && (pnum->open!=False) && (IVAL(pnum->printer_hnd.data,16)==(uint32)sys_getpid()))
 #define OUR_HANDLE(pnum) ((pnum==NULL)?"NULL":(IVAL(pnum->data,16)==sys_getpid()?"OURS":"OTHER"))
@@ -105,7 +104,7 @@ static int nt_printq_status(int v)
 {
        switch (v) {
        case LPQ_PAUSED:
-               return PRINTER_STATUS_ERROR;
+               return PRINTER_STATUS_PAUSED;
        case LPQ_QUEUED:
        case LPQ_SPOOLING:
        case LPQ_PRINTING:
@@ -175,6 +174,35 @@ static void clear_handle(POLICY_HND *hnd)
        ZERO_STRUCTP(hnd);
 }
 
+/***************************************************************************
+ Disconnect from the client
+****************************************************************************/
+static BOOL srv_spoolss_replycloseprinter(POLICY_HND *handle)
+{
+       uint32 status;
+
+       /* weird if the test succeds !!! */
+       if (smb_connections==0) {
+               DEBUG(0,("srv_spoolss_replycloseprinter:Trying to close non-existant notify backchannel !\n"));
+               return False;
+       }
+
+       if(!cli_spoolss_reply_close_printer(&cli, handle, &status))
+               return False;
+
+       /* if it's the last connection, deconnect the IPC$ share */
+       if (smb_connections==1) {
+               if(!spoolss_disconnect_from_client(&cli))
+                       return False;
+
+               message_deregister(MSG_PRINTER_NOTIFY);
+       }
+
+       smb_connections--;
+
+       return True;
+}
+
 /****************************************************************************
   close printer index by handle
 ****************************************************************************/
@@ -187,6 +215,10 @@ static BOOL close_printer_handle(POLICY_HND *hnd)
                return False;
        }
 
+       if (Printer->notify.client_connected==True)
+               if(!srv_spoolss_replycloseprinter(&Printer->notify.client_hnd))
+                       return ERROR_INVALID_HANDLE;
+
        Printer->open=False;
        Printer->notify.flags=0;
        Printer->notify.options=0;
@@ -194,7 +226,8 @@ static BOOL close_printer_handle(POLICY_HND *hnd)
        Printer->notify.printerlocal=0;
        safe_free(Printer->notify.option);
        Printer->notify.option=NULL;
-       
+       Printer->notify.client_connected=False;
+
        clear_handle(hnd);
 
        ubi_dlRemThis(&Printer_list, Printer);
@@ -221,6 +254,48 @@ static BOOL delete_printer_handle(POLICY_HND *hnd)
                return False;
        }
 
+       if (*lp_deleteprinter_cmd()) {
+
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_deleteprinter_cmd();
+               char *path;
+               pstring tmp_file;
+               pstring command;
+               int ret;
+               int i;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+               
+               /* Printer->dev.handlename equals portname equals sharename */
+               slprintf(command, sizeof(command), "%s \"%s\"", cmd,
+                                       Printer->dev.handlename);
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       return False;
+               }
+               DEBUGADD(10,("returned [%d]\n", ret));
+               DEBUGADD(10,("Unlinking output file [%s]\n", tmp_file));
+               unlink(tmp_file);
+
+               /* Send SIGHUP to process group... is there a better way? */
+               kill(0, SIGHUP);
+
+               if ( ( i = lp_servicenumber( Printer->dev.handlename ) ) >= 0 ) {
+                       lp_remove_service( i );
+                       lp_killservice( i );
+                       return True;
+               } else
+                       return False;
+       }
+
        return True;
 }      
 
@@ -237,16 +312,14 @@ static BOOL get_printer_snum(POLICY_HND *hnd, int *number)
        }
        
        switch (Printer->printer_type) {
-       case PRINTER_HANDLE_IS_PRINTER:            
+       case PRINTER_HANDLE_IS_PRINTER:         
                DEBUG(4,("short name:%s\n", Printer->dev.handlename));                  
                *number = print_queue_snum(Printer->dev.handlename);
                return (*number != -1);
        case PRINTER_HANDLE_IS_PRINTSERVER:
                return False;
-               break;
        default:
                return False;
-               break;
        }
 }
 
@@ -285,16 +358,14 @@ static BOOL set_printer_hnd_printertype(Printer_entry *Printer, char *handlename
        if (!strchr(handlename+2, '\\')) {
                DEBUGADD(4,("Printer is a print server\n"));
                Printer->printer_type = PRINTER_HANDLE_IS_PRINTSERVER;          
-               return True;
        }
        /* it's a printer */
        else {
                DEBUGADD(4,("Printer is a printer\n"));
                Printer->printer_type = PRINTER_HANDLE_IS_PRINTER;
-               return True;
        }
 
-       return False;
+       return True;
 }
 
 /****************************************************************************
@@ -334,6 +405,7 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
         */
 
        for (snum=0;snum<n_services && found==False;snum++) {
+               char *printername;
        
                if ( !(lp_snum_ok(snum) && lp_print_ok(snum) ) )
                        continue;
@@ -343,15 +415,18 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
                if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
                        continue;
 
-               DEBUG(10,("set_printer_hnd_name: name [%s], aprinter [%s]\n", 
+               printername=strchr(printer->info_2->printername+2, '\\');
+               printername++;
+
+               DEBUG(10,("set_printer_hnd_name: name [%s], aprinter [%s]\n",
                                printer->info_2->printername, aprinter ));
 
-               if ( strlen(printer->info_2->printername) != strlen(aprinter) ) {
+               if ( strlen(printername) != strlen(aprinter) ) {
                        free_a_printer(&printer, 2);
                        continue;
                }
                
-               if ( strncasecmp(printer->info_2->printername, aprinter, strlen(aprinter)))  {
+               if ( strncasecmp(printername, aprinter, strlen(aprinter)))  {
                        free_a_printer(&printer, 2);
                        continue;
                }
@@ -359,7 +434,7 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
                found=True;
        }
 
-       /* 
+       /*
         * if we haven't found a printer with the given handlename
         * then it can be a share name as you can open both \\server\printer and
         * \\server\share
@@ -383,7 +458,7 @@ static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
                        if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
                                continue;
 
-                       DEBUG(10,("set_printer_hnd_name: printername [%s], aprinter [%s]\n", 
+                       DEBUG(10,("set_printer_hnd_name: printername [%s], aprinter [%s]\n",
                                        printer->info_2->printername, aprinter ));
 
                        if ( strlen(lp_servicename(snum)) != strlen(aprinter) ) {
@@ -425,6 +500,7 @@ static BOOL open_printer_hnd(POLICY_HND *hnd, char *name)
 {
        Printer_entry *new_printer;
 
+       DEBUG(10,("open_printer_hnd: name [%s]\n", name));
        clear_handle(hnd);
        create_printer_hnd(hnd);
 
@@ -486,9 +562,9 @@ static BOOL alloc_buffer_size(NEW_BUFFER *buffer, uint32 buffer_size)
        else    
                extra_space = buffer_size - prs_data_size(ps);
 
-       /* 
+       /*
         * save the offset and move to the end of the buffer
-        * prs_grow() checks the extra_space against the offset 
+        * prs_grow() checks the extra_space against the offset
         */
        old_offset=prs_offset(ps);      
        prs_set_offset(ps, prs_data_size(ps));
@@ -498,15 +574,77 @@ static BOOL alloc_buffer_size(NEW_BUFFER *buffer, uint32 buffer_size)
 
        prs_set_offset(ps, old_offset);
 
-#if 0 /* JRATEST */
-       buffer->string_at_end = buffer_size;
-#else
        buffer->string_at_end=prs_data_size(ps);
-#endif
 
        return True;
 }
 
+/***************************************************************************
+ receive the notify message
+****************************************************************************/
+void srv_spoolss_receive_message(int msg_type, pid_t src, void *buf, size_t len)
+{
+       fstring printer;
+       uint32 status;
+       Printer_entry *find_printer;
+
+       *printer = '\0';
+       fstrcpy(printer,buf);
+
+       if (len == 0) {
+               DEBUG(0,("srv_spoolss_receive_message: got null message !\n"));
+               return;
+       }
+
+       DEBUG(10,("srv_spoolss_receive_message: Got message about printer %s\n", printer ));
+
+       find_printer = (Printer_entry *)ubi_dlFirst(&Printer_list);
+
+       /* Iterate the printer list. */
+       for(; find_printer; find_printer = (Printer_entry *)ubi_dlNext(find_printer)) {
+
+               /*
+                * if the entry is the given printer or if it's a printerserver
+                * we send the message
+                */
+
+               if (find_printer->printer_type==PRINTER_HANDLE_IS_PRINTER)
+                       if (strcmp(find_printer->dev.handlename, printer))
+                               continue;
+
+               if (find_printer->notify.client_connected==True)
+                       cli_spoolss_reply_rrpcn(&cli, &find_printer->notify.client_hnd, PRINTER_CHANGE_ALL, 0x0, &status);
+
+       }
+}
+
+/***************************************************************************
+ send a notify event
+****************************************************************************/
+static BOOL srv_spoolss_sendnotify(POLICY_HND *handle)
+{
+       fstring printer;
+
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("srv_spoolss_sendnotify: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return False;
+       }
+
+       if (Printer->printer_type==PRINTER_HANDLE_IS_PRINTER)
+               fstrcpy(printer, Printer->dev.handlename);
+       else
+               fstrcpy(printer, "");
+
+       /*srv_spoolss_receive_message(printer);*/
+       DEBUG(10,("srv_spoolss_sendnotify: Sending message about printer %s\n", printer ));
+
+       message_send_all(conn_tdb_ctx(), MSG_PRINTER_NOTIFY, printer, strlen(printer) + 1, False); /* Null terminate... */
+
+       return True;
+}      
+
 /********************************************************************
  * spoolss_open_printer
  *
@@ -517,10 +655,16 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
                                 uint32  user_switch, SPOOL_USER_CTR user_ctr,
                                 POLICY_HND *handle)
 {
+       uint32 result = NT_STATUS_NO_PROBLEMO;
+       SEC_DESC_BUF *sec_desc = NULL;
+       uint32 acc_granted, status;
        fstring name;
+       extern struct current_user current_user;
        
-       if (printername == NULL)
-               return ERROR_INVALID_PRINTER_NAME;
+       if (printername == NULL) {
+               result = ERROR_INVALID_PRINTER_NAME;
+               goto done;
+       }
 
        /* some sanity check because you can open a printer or a print server */
        /* aka: \\server\printer or \\server */
@@ -528,8 +672,10 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
 
        DEBUGADD(3,("checking name: %s\n",name));
 
-       if (!open_printer_hnd(handle, name))
-               return ERROR_INVALID_PRINTER_NAME;
+       if (!open_printer_hnd(handle, name)) {
+               result = ERROR_INVALID_PRINTER_NAME;
+               goto done;
+       }
        
 /*
        if (printer_default->datatype_ptr != NULL)
@@ -543,10 +689,57 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
        
        if (!set_printer_hnd_accesstype(handle, printer_default->access_required)) {
                close_printer_handle(handle);
-               return ERROR_ACCESS_DENIED;
+               result = ERROR_ACCESS_DENIED;
+               goto done;
        }
                
-       return NT_STATUS_NO_PROBLEMO;
+       /* Disallow MS AddPrinterWizard if parameter disables it. A Win2k
+          client 1st tries an OpenPrinterEx with access==0, MUST be allowed.
+          Then both Win2k and WinNT clients try an OpenPrinterEx with
+          SERVER_ALL_ACCESS, which we force to fail. Then they try
+          OpenPrinterEx with SERVER_READ which we allow. This lets the
+          client view printer folder, but does not show the MSAPW.
+
+          Note: this test needs code to check access rights here too. Jeremy
+          could you look at this? */
+
+       if (handle_is_printserver(handle) &&
+           !lp_ms_add_printer_wizard()) {
+               if (printer_default->access_required == 0) {
+                       goto done;
+               }
+               else if (printer_default->access_required != (SERVER_READ)) {
+                       close_printer_handle(handle);
+                       result = ERROR_ACCESS_DENIED;
+                       goto done;
+               }
+       }
+
+       /* NT doesn't let us connect to a printer if the connecting user
+          doesn't have print permission.  If no security descriptor just
+          return OK. */
+
+       if (!nt_printing_getsec(name, &sec_desc)) {
+               goto done;
+       }
+       
+       /* Yuck - we should use the pipe_user rather than current_user but
+          it doesn't seem to be filled in correctly. )-: */
+
+       map_printer_permissions(sec_desc->sec);
+
+       if (!se_access_check(sec_desc->sec, &current_user, PRINTER_ACCESS_USE,
+                            &acc_granted, &status)) {
+               DEBUG(3, ("access DENIED for printer open\n"));
+               close_printer_handle(handle);
+               result = ERROR_ACCESS_DENIED;
+               goto done;
+       }
+
+ done:
+       free_sec_desc_buf(&sec_desc);
+
+       return result;
 }
 
 /****************************************************************************
@@ -555,7 +748,7 @@ static BOOL convert_printer_info(const SPOOL_PRINTER_INFO_LEVEL *uni,
                                NT_PRINTER_INFO_LEVEL *printer, uint32 level)
 {
        switch (level) {
-               case 2: 
+               case 2:
                        uni_2_asc_printer_info_2(uni->info_2, &printer->info_2);
                        break;
                default:
@@ -569,11 +762,11 @@ static BOOL convert_printer_driver_info(const SPOOL_PRINTER_DRIVER_INFO_LEVEL *u
                                        NT_PRINTER_DRIVER_INFO_LEVEL *printer, uint32 level)
 {
        switch (level) {
-               case 3: 
+               case 3:
                        printer->info_3=NULL;
                        uni_2_asc_printer_driver_3(uni->info_3, &printer->info_3);
                        break;
-               case 6: 
+               case 6:
                        printer->info_6=NULL;
                        uni_2_asc_printer_driver_6(uni->info_6, &printer->info_6);
                        break;
@@ -623,13 +816,16 @@ static BOOL convert_devicemode(const DEVICEMODE *devmode, NT_DEVICEMODE *nt_devm
        nt_devmode->panningwidth=devmode->panningwidth;
        nt_devmode->panningheight=devmode->panningheight;
 
+       safe_free(nt_devmode->private);
        if (nt_devmode->driverextra != 0) {
                /* if we had a previous private delete it and make a new one */
-               safe_free(nt_devmode->private);
                if((nt_devmode->private=(uint8 *)malloc(nt_devmode->driverextra * sizeof(uint8))) == NULL)
                        return False;
                memcpy(nt_devmode->private, devmode->private, nt_devmode->driverextra);
        }
+       else {
+               nt_devmode->private = NULL;
+       }
 
        return True;
 }
@@ -639,6 +835,11 @@ static BOOL convert_devicemode(const DEVICEMODE *devmode, NT_DEVICEMODE *nt_devm
  ********************************************************************/
 uint32 _spoolss_closeprinter(POLICY_HND *handle)
 {
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+
+       if (Printer && Printer->document_started)
+               _spoolss_enddocprinter(handle);          /* print job was not closed */
+
        if (!close_printer_handle(handle))
                return ERROR_INVALID_HANDLE;    
                
@@ -650,8 +851,15 @@ uint32 _spoolss_closeprinter(POLICY_HND *handle)
  ********************************************************************/
 uint32 _spoolss_deleteprinter(POLICY_HND *handle)
 {
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+
+       if (Printer && Printer->document_started)
+               _spoolss_enddocprinter(handle);          /* print job was not closed */
+
        if (!delete_printer_handle(handle))
                return ERROR_INVALID_HANDLE;    
+
+       srv_spoolss_sendnotify(handle);
                
        return NT_STATUS_NO_PROBLEMO;
 }
@@ -738,7 +946,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
  GetPrinterData on a printer Handle.
 ********************************************************************/
 static BOOL getprinterdata_printer(POLICY_HND *handle,
-                               fstring value, uint32 *type, 
+                               fstring value, uint32 *type,
                                uint8 **data, uint32 *needed, uint32 in_size )
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
@@ -804,7 +1012,7 @@ uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
        BOOL found=False;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
        
-       /* 
+       /*
         * Reminder: when it's a string, the length is in BYTES
         * even if UNICODE is negociated.
         *
@@ -848,11 +1056,37 @@ uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
        }
        
        if (*needed > *out_size)
-               return ERROR_INSUFFICIENT_BUFFER;
+               return ERROR_MORE_DATA;
        else
                return NT_STATUS_NO_PROBLEMO;
 }
 
+/***************************************************************************
+ connect to the client
+****************************************************************************/
+static BOOL srv_spoolss_replyopenprinter(char *printer, uint32 localprinter, uint32 type, POLICY_HND *handle)
+{
+       uint32 status;
+
+       /*
+        * If it's the first connection, contact the client
+        * and connect to the IPC$ share anonumously
+        */
+       if (smb_connections==0) {
+               if(!spoolss_connect_to_client(&cli, printer+2)) /* the +2 is to strip the leading 2 backslashs */
+                       return False;
+               message_register(MSG_PRINTER_NOTIFY, srv_spoolss_receive_message);
+
+       }
+
+       smb_connections++;
+
+       if(!cli_spoolss_reply_open_printer(&cli, printer, localprinter, type, &status, handle))
+               return False;
+
+       return True;
+}
+
 /********************************************************************
  * _spoolss_rffpcnex
  * ReplyFindFirstPrinterChangeNotifyEx
@@ -862,7 +1096,7 @@ uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
  * have to code it, later.
  *
  * in fact ReplyOpenPrinter is the changenotify equivalent on the spoolss pipe
- * called from api_spoolss_rffpcnex 
+ * called from api_spoolss_rffpcnex
  ********************************************************************/
 uint32 _spoolss_rffpcnex(POLICY_HND *handle, uint32 flags, uint32 options,
                         const UNISTR2 *localmachine, uint32 printerlocal,
@@ -883,6 +1117,12 @@ uint32 _spoolss_rffpcnex(POLICY_HND *handle, uint32 flags, uint32 options,
        Printer->notify.option=option;
        unistr2_to_ascii(Printer->notify.localmachine, localmachine, sizeof(Printer->notify.localmachine)-1);
 
+       /* connect to the client machine and send a ReplyOpenPrinter */
+       if(srv_spoolss_replyopenprinter(Printer->notify.localmachine,
+                                       Printer->notify.printerlocal, 1,
+                                       &Printer->notify.client_hnd))
+               Printer->notify.client_connected=True;
+
        return NT_STATUS_NO_PROBLEMO;
 }
 
@@ -901,18 +1141,21 @@ static void spoolss_notify_server_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, p
 }
 
 /*******************************************************************
- * fill a notify_info_data with the servicename
- * jfmxxxx: it's incorrect should be long_printername
+ * fill a notify_info_data with the printername (not including the servername).
  ********************************************************************/
 static void spoolss_notify_printer_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue,
                                                                                NT_PRINTER_INFO_LEVEL *printer)
 {
-/*
-       data->notify_data.data.length=strlen(lp_servicename(snum));
-       dos_PutUniCode(data->notify_data.data.string, lp_servicename(snum), sizeof(data->notify_data.data.string), True);
-*/
+       /* the notify name should not contain the \\server\ part */
+       char *p = strrchr(printer->info_2->printername, '\\');
+       if (!p) {
+               p = printer->info_2->printername;
+       } else {
+               p++;
+       }
+
        data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-                               printer->info_2->printername, sizeof(data->notify_data.data.string), True) - sizeof(uint16))/sizeof(uint16));
+                               p, sizeof(data->notify_data.data.string), True) - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -932,7 +1175,7 @@ static void spoolss_notify_port_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, pri
        /* even if it's strange, that's consistant in all the code */
 
        data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
-               lp_servicename(snum), sizeof(data->notify_data.data.string), True)  - sizeof(uint16))/sizeof(uint16));
+               printer->info_2->portname, sizeof(data->notify_data.data.string), True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -951,8 +1194,12 @@ static void spoolss_notify_driver_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, p
  ********************************************************************/
 static void spoolss_notify_comment(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+       if (*printer->info_2->comment == '\0')
+               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
                        lp_comment(snum), sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       else
+               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->comment, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1032,9 +1279,7 @@ static void spoolss_notify_security_desc(int snum, SPOOL_NOTIFY_INFO_DATA *data,
  ********************************************************************/
 static void spoolss_notify_attributes(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.value[0] =   PRINTER_ATTRIBUTE_SHARED   \
-                                    | PRINTER_ATTRIBUTE_LOCAL  \
-                                    | PRINTER_ATTRIBUTE_RAW_ONLY ;
+       data->notify_data.value[0] = printer->info_2->attributes;
 }
 
 /*******************************************************************
@@ -1108,7 +1353,7 @@ static void spoolss_notify_average_ppm(int snum, SPOOL_NOTIFY_INFO_DATA *data, p
 }
 
 /*******************************************************************
- * fill a notify_info_data with 
+ * fill a notify_info_data with username
  ********************************************************************/
 static void spoolss_notify_username(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
@@ -1117,7 +1362,7 @@ static void spoolss_notify_username(int snum, SPOOL_NOTIFY_INFO_DATA *data, prin
 }
 
 /*******************************************************************
- * fill a notify_info_data with 
+ * fill a notify_info_data with job status
  ********************************************************************/
 static void spoolss_notify_job_status(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
@@ -1125,7 +1370,7 @@ static void spoolss_notify_job_status(int snum, SPOOL_NOTIFY_INFO_DATA *data, pr
 }
 
 /*******************************************************************
- * fill a notify_info_data with 
+ * fill a notify_info_data with job name
  ********************************************************************/
 static void spoolss_notify_job_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
@@ -1134,23 +1379,24 @@ static void spoolss_notify_job_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, prin
 }
 
 /*******************************************************************
- * fill a notify_info_data with 
+ * fill a notify_info_data with job status
  ********************************************************************/
 static void spoolss_notify_job_status_string(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
        char *p = "unknown";
+
        switch (queue->status) {
        case LPQ_QUEUED:
-               p = "QUEUED";
+               p = "Queued";
                break;
        case LPQ_PAUSED:
-               p = "PAUSED";
+               p = "";    /* NT provides the paused string */
                break;
        case LPQ_SPOOLING:
-               p = "SPOOLING";
+               p = "Spooling";
                break;
        case LPQ_PRINTING:
-               p = "PRINTING";
+               p = "Printing";
                break;
        }
        data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
@@ -1158,7 +1404,7 @@ static void spoolss_notify_job_status_string(int snum, SPOOL_NOTIFY_INFO_DATA *d
 }
 
 /*******************************************************************
- * fill a notify_info_data with 
+ * fill a notify_info_data with job time
  ********************************************************************/
 static void spoolss_notify_job_time(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
@@ -1166,7 +1412,7 @@ static void spoolss_notify_job_time(int snum, SPOOL_NOTIFY_INFO_DATA *data, prin
 }
 
 /*******************************************************************
- * fill a notify_info_data with 
+ * fill a notify_info_data with job size
  ********************************************************************/
 static void spoolss_notify_job_size(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
@@ -1174,13 +1420,26 @@ static void spoolss_notify_job_size(int snum, SPOOL_NOTIFY_INFO_DATA *data, prin
 }
 
 /*******************************************************************
- * fill a notify_info_data with 
+ * fill a notify_info_data with job position
  ********************************************************************/
 static void spoolss_notify_job_position(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
        data->notify_data.value[0]=queue->job;
 }
 
+/*******************************************************************
+ * fill a notify_info_data with submitted time
+ ********************************************************************/
+static void spoolss_notify_submitted_time(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+{
+       struct tm *t;
+
+       t=gmtime(&queue->time);
+
+       data->notify_data.data.length = sizeof(SYSTEMTIME);
+       make_systemtime((SYSTEMTIME*)(data->notify_data.data.string), t);
+}
+
 #define END 65535
 
 struct s_notify_info_data_table
@@ -1238,7 +1497,7 @@ struct s_notify_info_data_table notify_info_data_table[] =
 { JOB_NOTIFY_TYPE,     JOB_NOTIFY_DOCUMENT,                "JOB_NOTIFY_DOCUMENT",                POINTER,   spoolss_notify_job_name },
 { JOB_NOTIFY_TYPE,     JOB_NOTIFY_PRIORITY,                "JOB_NOTIFY_PRIORITY",                ONE_VALUE, spoolss_notify_priority },
 { JOB_NOTIFY_TYPE,     JOB_NOTIFY_POSITION,                "JOB_NOTIFY_POSITION",                ONE_VALUE, spoolss_notify_job_position },
-{ JOB_NOTIFY_TYPE,     JOB_NOTIFY_SUBMITTED,               "JOB_NOTIFY_SUBMITTED",               POINTER,   NULL },
+{ JOB_NOTIFY_TYPE,     JOB_NOTIFY_SUBMITTED,               "JOB_NOTIFY_SUBMITTED",               POINTER,   spoolss_notify_submitted_time },
 { JOB_NOTIFY_TYPE,     JOB_NOTIFY_START_TIME,              "JOB_NOTIFY_START_TIME",              ONE_VALUE, spoolss_notify_start_time },
 { JOB_NOTIFY_TYPE,     JOB_NOTIFY_UNTIL_TIME,              "JOB_NOTIFY_UNTIL_TIME",              ONE_VALUE, spoolss_notify_until_time },
 { JOB_NOTIFY_TYPE,     JOB_NOTIFY_TIME,                    "JOB_NOTIFY_TIME",                    ONE_VALUE, spoolss_notify_job_time },
@@ -1251,7 +1510,7 @@ struct s_notify_info_data_table notify_info_data_table[] =
 
 /*******************************************************************
 return the size of info_data structure
-********************************************************************/  
+********************************************************************/
 static uint32 size_of_notify_info_data(uint16 type, uint16 field)
 {
        int i=0;
@@ -1262,7 +1521,6 @@ static uint32 size_of_notify_info_data(uint16 type, uint16 field)
                     (notify_info_data_table[i].field == field ) )
                {
                        return (notify_info_data_table[i].size);
-                       continue;
                }
                i++;
        }
@@ -1271,7 +1529,7 @@ static uint32 size_of_notify_info_data(uint16 type, uint16 field)
 
 /*******************************************************************
 return the type of notify_info_data
-********************************************************************/  
+********************************************************************/
 static BOOL type_of_notify_info_data(uint16 type, uint16 field)
 {
        int i=0;
@@ -1289,7 +1547,6 @@ static BOOL type_of_notify_info_data(uint16 type, uint16 field)
                        {
                                return (True);
                        }
-                       continue;
                }
                i++;
        }
@@ -1333,7 +1590,7 @@ static void construct_info_data(SPOOL_NOTIFY_INFO_DATA *info_data, uint16 type,
 /*******************************************************************
  *
  * fill a notify_info struct with info asked
- * 
+ *
  ********************************************************************/
 static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPOOL_NOTIFY_OPTION_TYPE *option_type, uint32 id)
 {
@@ -1350,7 +1607,7 @@ static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPO
        type=option_type->type;
 
        DEBUGADD(4,("Notify type: [%s], number of notify info: [%d] on printer: [%s]\n",
-               (option_type->type==PRINTER_NOTIFY_TYPE?"PRINTER_NOTIFY_TYPE":"JOB_NOTIFY_TYPE"), 
+               (option_type->type==PRINTER_NOTIFY_TYPE?"PRINTER_NOTIFY_TYPE":"JOB_NOTIFY_TYPE"),
                option_type->count, lp_servicename(snum)));
        
        if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
@@ -1369,6 +1626,10 @@ static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPO
                current_data=&info->data[info->count];
 
                construct_info_data(current_data, type, field, id);             
+
+               DEBUG(10,("construct_notify_printer_info: calling %s\n",
+                               notify_info_data_table[j].name ));
+
                notify_info_data_table[j].fn(snum, current_data, queue, printer);
 
                info->count++;
@@ -1381,7 +1642,7 @@ static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPO
 /*******************************************************************
  *
  * fill a notify_info struct with info asked
- * 
+ *
  ********************************************************************/
 static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_INFO *info, int snum, SPOOL_NOTIFY_OPTION_TYPE *option_type, uint32 id)
 {
@@ -1397,7 +1658,7 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_I
        type = option_type->type;
 
        DEBUGADD(4,("Notify type: [%s], number of notify info: [%d]\n",
-               (option_type->type==PRINTER_NOTIFY_TYPE?"PRINTER_NOTIFY_TYPE":"JOB_NOTIFY_TYPE"), 
+               (option_type->type==PRINTER_NOTIFY_TYPE?"PRINTER_NOTIFY_TYPE":"JOB_NOTIFY_TYPE"),
                option_type->count));
 
        if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
@@ -1431,7 +1692,7 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_I
  * the printer's name and the number of jobs currently queued.
  * So in the NOTIFY_OPTION, I have one NOTIFY_OPTION_TYPE structure.
  * Its type is PRINTER_NOTIFY_TYPE and it has 2 fields NAME and CJOBS.
- * 
+ *
  * I have 3 printers on the back of my server.
  *
  * Now the response is a NOTIFY_INFO structure, with 6 NOTIFY_INFO_DATA
@@ -1453,7 +1714,7 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_I
  *
  * enumerate all printers on the printserver
  * fill a notify_info struct with info asked
- * 
+ *
  ********************************************************************/
 static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
 {
@@ -1488,7 +1749,7 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
        /*
         * Debugging information, don't delete.
         */
-       /* 
+       /*
        DEBUG(1,("dumping the NOTIFY_INFO\n"));
        DEBUGADD(1,("info->version:[%d], info->flags:[%d], info->count:[%d]\n", info->version, info->flags, info->count));
        DEBUGADD(1,("num\ttype\tfield\tres\tid\tsize\tenc_type\n"));
@@ -1506,7 +1767,7 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
 /*******************************************************************
  *
  * fill a notify_info struct with info asked
- * 
+ *
  ********************************************************************/
 static uint32 printer_notify_info(POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
 {
@@ -1552,7 +1813,7 @@ static uint32 printer_notify_info(POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
        /*
         * Debugging information, don't delete.
         */
-       /* 
+       /*
        DEBUG(1,("dumping the NOTIFY_INFO\n"));
        DEBUGADD(1,("info->version:[%d], info->flags:[%d], info->count:[%d]\n", info->version, info->flags, info->count));
        DEBUGADD(1,("num\ttype\tfield\tres\tid\tsize\tenc_type\n"));
@@ -1587,7 +1848,7 @@ uint32 _spoolss_rfnpcnex( POLICY_HND *handle, uint32 change,
         *      b) we'll have a way to communicate between the spoolss process.
         *
         *      same thing for option->flags
-        *      I should check for PRINTER_NOTIFY_OPTIONS_REFRESH but as 
+        *      I should check for PRINTER_NOTIFY_OPTIONS_REFRESH but as
         *      I don't have a global notification system, I'm sending back all the
         *      informations even when _NOTHING_ has changed.
         */
@@ -1599,10 +1860,8 @@ uint32 _spoolss_rfnpcnex( POLICY_HND *handle, uint32 change,
        switch (Printer->printer_type) {
                case PRINTER_HANDLE_IS_PRINTSERVER:
                        return printserver_notify_info(handle, info);
-                       break;
                case PRINTER_HANDLE_IS_PRINTER:
                        return printer_notify_info(handle, info);
-                       break;
        }
 
        return ERROR_INVALID_HANDLE;
@@ -1610,9 +1869,9 @@ uint32 _spoolss_rfnpcnex( POLICY_HND *handle, uint32 change,
 
 /********************************************************************
  * construct_printer_info_0
- * fill a printer_info_1 struct
+ * fill a printer_info_0 struct
  ********************************************************************/
-static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring servername)
+static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum)
 {
        pstring chaine;
        int count;
@@ -1620,7 +1879,7 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
        counter_printer_0 *session_counter;
        uint32 global_counter;
        struct tm *t;
-       time_t setup_time = time(NULL);
+       time_t setuptime;
 
        print_queue_struct *queue=NULL;
        print_status_struct status;
@@ -1661,20 +1920,19 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
         */
        global_counter=session_counter->counter;
        
-       /* the description and the name are of the form \\server\share */
-       slprintf(chaine,sizeof(chaine)-1,"\\\\%s\\%s",servername, ntprinter->info_2->printername);
+       pstrcpy(chaine,ntprinter->info_2->printername);
 
        init_unistr(&printer->printername, chaine);
        
-       slprintf(chaine,sizeof(chaine)-1,"\\\\%s", servername);
+       slprintf(chaine,sizeof(chaine)-1,"\\\\%s", global_myname);
        init_unistr(&printer->servername, chaine);
        
        printer->cjobs = count;
        printer->total_jobs = 0;
        printer->total_bytes = 0;
 
-       t=gmtime(&setup_time);
-       ntprinter->info_2->setuptime = (uint32)setup_time; /* FIXME !! */
+       setuptime = (time_t)ntprinter->info_2->setuptime;
+       t=gmtime(&setuptime);
 
        printer->year = t->tm_year+1900;
        printer->month = t->tm_mon+1;
@@ -1722,7 +1980,7 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
  * construct_printer_info_1
  * fill a printer_info_1 struct
  ********************************************************************/
-static BOOL construct_printer_info_1(fstring server, uint32 flags, PRINTER_INFO_1 *printer, int snum)
+static BOOL construct_printer_info_1(uint32 flags, PRINTER_INFO_1 *printer, int snum)
 {
        pstring chaine;
        pstring chaine2;
@@ -1733,14 +1991,21 @@ static BOOL construct_printer_info_1(fstring server, uint32 flags, PRINTER_INFO_
 
        printer->flags=flags;
 
-       snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",server, ntprinter->info_2->printername,
-               ntprinter->info_2->drivername, lp_comment(snum));
+       if (*ntprinter->info_2->comment == '\0') {
+               init_unistr(&printer->comment, lp_comment(snum));
+               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",global_myname, ntprinter->info_2->printername,
+                       ntprinter->info_2->drivername, lp_comment(snum));
+       }
+       else {
+               init_unistr(&printer->comment, ntprinter->info_2->comment); /* saved comment. */
+               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",global_myname, ntprinter->info_2->printername,
+                       ntprinter->info_2->drivername, ntprinter->info_2->comment);
+       }
                
-       snprintf(chaine2,sizeof(chaine)-1,"%s%s", server, ntprinter->info_2->printername);
+       snprintf(chaine2,sizeof(chaine)-1,"%s", ntprinter->info_2->printername);
 
        init_unistr(&printer->description, chaine);
        init_unistr(&printer->name, chaine2);   
-       init_unistr(&printer->comment, lp_comment(snum));
        
        free_a_printer(&ntprinter,2);
 
@@ -1766,7 +2031,7 @@ static void free_dev_mode(DEVICEMODE *dev)
  Create a DEVMODE struct. Returns malloced memory.
 ****************************************************************************/
 
-static DEVICEMODE *construct_dev_mode(int snum, char *servername)
+static DEVICEMODE *construct_dev_mode(int snum)
 {
        char adevice[32];
        char aform[32];
@@ -1790,16 +2055,13 @@ static DEVICEMODE *construct_dev_mode(int snum, char *servername)
 
        if (printer->info_2->devmode)
                ntdevmode = dup_nt_devicemode(printer->info_2->devmode);
-#if 0 /* JFMTEST */
-       else
-               ntdevmode = construct_nt_devicemode(printer->info_2->printername);
-#endif
+
        if (ntdevmode == NULL)
                goto fail;
 
        DEBUGADD(8,("loading DEVICEMODE\n"));
 
-       snprintf(adevice, sizeof(adevice), "\\\\%s\\%s", global_myname, printer->info_2->printername);
+       snprintf(adevice, sizeof(adevice), printer->info_2->printername);
        init_unistr(&devmode->devicename, adevice);
 
        snprintf(aform, sizeof(aform), ntdevmode->formname);
@@ -1810,7 +2072,7 @@ static DEVICEMODE *construct_dev_mode(int snum, char *servername)
        devmode->size             = ntdevmode->size;
        devmode->driverextra      = ntdevmode->driverextra;
        devmode->fields           = ntdevmode->fields;
-                                   
+                               
        devmode->orientation      = ntdevmode->orientation;     
        devmode->papersize        = ntdevmode->papersize;
        devmode->paperlength      = ntdevmode->paperlength;
@@ -1855,11 +2117,8 @@ static DEVICEMODE *construct_dev_mode(int snum, char *servername)
  * fill a printer_info_2 struct
  ********************************************************************/
 
-static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer, int snum)
+static BOOL construct_printer_info_2(PRINTER_INFO_2 *printer, int snum)
 {
-       pstring chaine;
-       pstring chaine2;
-       pstring sl;
        int count;
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
 
@@ -1873,24 +2132,10 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
        memset(&status, 0, sizeof(status));             
        count = print_queue_status(snum, &queue, &status);
 
-       snprintf(chaine, sizeof(chaine)-1, "%s", servername);
-
-       if (strlen(servername)!=0)
-               fstrcpy(sl, "\\");
-       else
-               fstrcpy(sl, '\0');
-
-       snprintf(chaine2, sizeof(chaine)-1, "%s%s%s", servername, sl, ntprinter->info_2->printername);
-
-       init_unistr(&printer->servername, chaine);                              /* servername*/
-       init_unistr(&printer->printername, chaine2);                            /* printername*/
+       init_unistr(&printer->servername, ntprinter->info_2->servername); /* servername*/
+       init_unistr(&printer->printername, ntprinter->info_2->printername);                             /* printername*/
        init_unistr(&printer->sharename, lp_servicename(snum));                 /* sharename */
-#if 1 /* JRATEST */
-       /* We need to determine the correct model for this..... */
-       init_unistr(&printer->portname, lp_printername(snum));                  /* port */      
-#else
-       init_unistr(&printer->portname, lp_servicename(snum));                  /* port */      
-#endif
+       init_unistr(&printer->portname, ntprinter->info_2->portname);                   /* port */      
        init_unistr(&printer->drivername, ntprinter->info_2->drivername);       /* drivername */
 
        if (*ntprinter->info_2->comment == '\0')
@@ -1914,11 +2159,8 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
        printer->cjobs = count;                                                 /* jobs */
        printer->averageppm = ntprinter->info_2->averageppm;                    /* average pages per minute */
                        
-       if((printer->devmode = construct_dev_mode(snum, servername)) == NULL) {
+       if((printer->devmode = construct_dev_mode(snum)) == NULL) {
                DEBUG(8, ("Returning NULL Devicemode!\n"));
-#if 0 /* JFMTEST */
-               goto err;
-#endif
        }
 
        if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->len != 0) {
@@ -1935,21 +2177,13 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
        free_a_printer(&ntprinter, 2);
        safe_free(queue);
        return True;
-
-  err:
-
-       if (ntprinter)
-               free_a_printer(&ntprinter, 2);
-       safe_free(queue);
-       return False;
 }
 
 /********************************************************************
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static BOOL construct_printer_info_3(fstring servername,
-                       PRINTER_INFO_3 **pp_printer, int snum)
+static BOOL construct_printer_info_3(PRINTER_INFO_3 **pp_printer, int snum)
 {
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        PRINTER_INFO_3 *printer = NULL;
@@ -1965,10 +2199,29 @@ static BOOL construct_printer_info_3(fstring servername,
 
        ZERO_STRUCTP(printer);
        
-       printer->flags = 4; /* This is the offset to the SEC_DESC. */
+       printer->flags = 4; /* These are the components of the SD we are returning. */
        if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->len != 0) {
                /* steal the printer info sec_desc structure.  [badly done]. */
                printer->secdesc = ntprinter->info_2->secdesc_buf->sec;
+
+#if 0
+               /*
+                * Set the flags for the components we are returning.
+                */
+
+               if (printer->secdesc->owner_sid)
+                       printer->flags |= OWNER_SECURITY_INFORMATION;
+
+               if (printer->secdesc->grp_sid)
+                       printer->flags |= GROUP_SECURITY_INFORMATION;
+
+               if (printer->secdesc->dacl)
+                       printer->flags |= DACL_SECURITY_INFORMATION;
+
+               if (printer->secdesc->sacl)
+                       printer->flags |= SACL_SECURITY_INFORMATION;
+#endif
+
                ntprinter->info_2->secdesc_buf->sec = NULL; /* Stolen the malloced memory. */
                ntprinter->info_2->secdesc_buf->len = 0; /* Stolen the malloced memory. */
                ntprinter->info_2->secdesc_buf->max_len = 0; /* Stolen the malloced memory. */
@@ -1983,7 +2236,7 @@ static BOOL construct_printer_info_3(fstring servername,
 /********************************************************************
  Spoolss_enumprinters.
 ********************************************************************/
-static BOOL enum_all_printers_info_1(fstring server, uint32 flags, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static BOOL enum_all_printers_info_1(uint32 flags, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int snum;
        int i;
@@ -1997,7 +2250,7 @@ static BOOL enum_all_printers_info_1(fstring server, uint32 flags, NEW_BUFFER *b
                if (lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
                        DEBUG(4,("Found a printer in smb.conf: %s[%x]\n", lp_servicename(snum), snum));
                                
-                       if (construct_printer_info_1(server, flags, &current_prt, snum)) {
+                       if (construct_printer_info_1(flags, &current_prt, snum)) {
                                if((printers=Realloc(printers, (*returned +1)*sizeof(PRINTER_INFO_1))) == NULL) {
                                        *returned=0;
                                        return ERROR_NOT_ENOUGH_MEMORY;
@@ -2034,20 +2287,11 @@ static BOOL enum_all_printers_info_1(fstring server, uint32 flags, NEW_BUFFER *b
 /********************************************************************
  enum_all_printers_info_1_local.
 *********************************************************************/
-static BOOL enum_all_printers_info_1_local(fstring name, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static BOOL enum_all_printers_info_1_local(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       fstring temp;
        DEBUG(4,("enum_all_printers_info_1_local\n"));  
        
-       fstrcpy(temp, "\\\\");
-       fstrcat(temp, global_myname);
-
-       if (!strcmp(name, temp)) {
-               fstrcat(temp, "\\");
-               return enum_all_printers_info_1(temp, PRINTER_ENUM_ICON8, buffer, offered, needed, returned);
-       }
-       else
-               return enum_all_printers_info_1("", PRINTER_ENUM_ICON8, buffer, offered, needed, returned);
+       return enum_all_printers_info_1(PRINTER_ENUM_ICON8, buffer, offered, needed, returned);
 }
 
 /********************************************************************
@@ -2061,9 +2305,8 @@ static BOOL enum_all_printers_info_1_name(fstring name, NEW_BUFFER *buffer, uint
        fstrcpy(temp, "\\\\");
        fstrcat(temp, global_myname);
 
-       if (!strcmp(name, temp)) {
-               fstrcat(temp, "\\");
-               return enum_all_printers_info_1(temp, PRINTER_ENUM_ICON8, buffer, offered, needed, returned);
+       if (strequal(name, temp)) {
+               return enum_all_printers_info_1(PRINTER_ENUM_ICON8, buffer, offered, needed, returned);
        }
        else
                return ERROR_INVALID_NAME;
@@ -2083,7 +2326,7 @@ static BOOL enum_all_printers_info_1_remote(fstring name, NEW_BUFFER *buffer, ui
        /* JFM: currently it's more a place holder than anything else.
         * In the spooler world there is a notion of server registration.
         * the print servers are registring (sp ?) on the PDC (in the same domain)
-        * 
+        *
         * We should have a TDB here. The registration is done thru an undocumented RPC call.
         */
        
@@ -2126,15 +2369,11 @@ static BOOL enum_all_printers_info_1_remote(fstring name, NEW_BUFFER *buffer, ui
 /********************************************************************
  enum_all_printers_info_1_network.
 *********************************************************************/
-static BOOL enum_all_printers_info_1_network(fstring name, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static BOOL enum_all_printers_info_1_network(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       fstring temp;
        DEBUG(4,("enum_all_printers_info_1_network\n"));        
        
-       fstrcpy(temp, "\\\\");
-       fstrcat(temp, global_myname);
-       fstrcat(temp, "\\");
-       return enum_all_printers_info_1(temp, PRINTER_ENUM_UNKNOWN_8, buffer, offered, needed, returned);
+       return enum_all_printers_info_1(PRINTER_ENUM_UNKNOWN_8, buffer, offered, needed, returned);
 }
 
 /********************************************************************
@@ -2142,7 +2381,7 @@ static BOOL enum_all_printers_info_1_network(fstring name, NEW_BUFFER *buffer, u
  *
  * called from api_spoolss_enumprinters (see this to understand)
  ********************************************************************/
-static BOOL enum_all_printers_info_2(fstring servername, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static BOOL enum_all_printers_info_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int snum;
        int i;
@@ -2154,7 +2393,7 @@ static BOOL enum_all_printers_info_2(fstring servername, NEW_BUFFER *buffer, uin
                if (lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
                        DEBUG(4,("Found a printer in smb.conf: %s[%x]\n", lp_servicename(snum), snum));
                                
-                       if (construct_printer_info_2(servername, &current_prt, snum)) {
+                       if (construct_printer_info_2(&current_prt, snum)) {
                                if((printers=Realloc(printers, (*returned +1)*sizeof(PRINTER_INFO_2))) == NULL)
                                        return ERROR_NOT_ENOUGH_MEMORY;
                                DEBUG(4,("ReAlloced memory for [%d] PRINTER_INFO_2\n", *returned));             
@@ -2206,7 +2445,7 @@ static uint32 enumprinters_level1( uint32 flags, fstring name,
        /* Not all the flags are equals */
 
        if (flags & PRINTER_ENUM_LOCAL)
-               return enum_all_printers_info_1_local(name, buffer, offered, needed, returned);
+               return enum_all_printers_info_1_local(buffer, offered, needed, returned);
 
        if (flags & PRINTER_ENUM_NAME)
                return enum_all_printers_info_1_name(name, buffer, offered, needed, returned);
@@ -2215,7 +2454,7 @@ static uint32 enumprinters_level1( uint32 flags, fstring name,
                return enum_all_printers_info_1_remote(name, buffer, offered, needed, returned);
 
        if (flags & PRINTER_ENUM_NETWORK)
-               return enum_all_printers_info_1_network(name, buffer, offered, needed, returned);
+               return enum_all_printers_info_1_network(buffer, offered, needed, returned);
 
        return NT_STATUS_NO_PROBLEMO; /* NT4sp5 does that */
 }
@@ -2233,15 +2472,15 @@ static uint32 enumprinters_level2( uint32 flags, fstring servername,
        fstrcat(temp, global_myname);
 
        if (flags & PRINTER_ENUM_LOCAL) {
-               if (!strcmp(servername, temp))
-                       return enum_all_printers_info_2(temp, buffer, offered, needed, returned);
+               if (strequal(servername, temp))
+                       return enum_all_printers_info_2(buffer, offered, needed, returned);
                else
-                       return enum_all_printers_info_2("", buffer, offered, needed, returned);
+                       return enum_all_printers_info_2(buffer, offered, needed, returned);
        }
 
        if (flags & PRINTER_ENUM_NAME) {
-               if (!strcmp(servername, temp))
-                       return enum_all_printers_info_2(temp, buffer, offered, needed, returned);
+               if (strequal(servername, temp))
+                       return enum_all_printers_info_2(buffer, offered, needed, returned);
                else
                        return ERROR_INVALID_NAME;
        }
@@ -2280,7 +2519,7 @@ uint32 _spoolss_enumprinters( uint32 flags, const UNISTR2 *servername, uint32 le
        *returned=0;
        
        /*
-        * Level 1: 
+        * Level 1:
         *          flags==PRINTER_ENUM_NAME
         *           if name=="" then enumerates all printers
         *           if name!="" then enumerate the printer
@@ -2298,31 +2537,27 @@ uint32 _spoolss_enumprinters( uint32 flags, const UNISTR2 *servername, uint32 le
        switch (level) {
        case 1:
                return enumprinters_level1(flags, name, buffer, offered, needed, returned);
-               break;
        case 2:
                return enumprinters_level2(flags, name, buffer, offered, needed, returned);
-               break;                          
        case 5:
                return enumprinters_level5(flags, name, buffer, offered, needed, returned);
-               break;                          
        case 3:
        case 4:
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_0(fstring servername, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinter_level_0(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_0 *printer=NULL;
 
        if((printer=(PRINTER_INFO_0*)malloc(sizeof(PRINTER_INFO_0))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
 
-       construct_printer_info_0(printer, snum, servername);
+       construct_printer_info_0(printer, snum);
        
        /* check the required size. */  
        *needed += spoolss_size_printer_info_0(printer);
@@ -2347,14 +2582,14 @@ static uint32 getprinter_level_0(fstring servername, int snum, NEW_BUFFER *buffe
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_1(fstring servername, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinter_level_1(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_1 *printer=NULL;
 
        if((printer=(PRINTER_INFO_1*)malloc(sizeof(PRINTER_INFO_1))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
 
-       construct_printer_info_1(servername, PRINTER_ENUM_ICON8, printer, snum);
+       construct_printer_info_1(PRINTER_ENUM_ICON8, printer, snum);
        
        /* check the required size. */  
        *needed += spoolss_size_printer_info_1(printer);
@@ -2379,17 +2614,14 @@ static uint32 getprinter_level_1(fstring servername, int snum, NEW_BUFFER *buffe
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_2(fstring servername, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinter_level_2(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_2 *printer=NULL;
-       fstring temp;
 
        if((printer=(PRINTER_INFO_2*)malloc(sizeof(PRINTER_INFO_2)))==NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
        
-       fstrcpy(temp, "\\\\");
-       fstrcat(temp, servername);
-       construct_printer_info_2(temp, printer, snum);
+       construct_printer_info_2(printer, snum);
        
        /* check the required size. */  
        *needed += spoolss_size_printer_info_2(printer);
@@ -2417,14 +2649,11 @@ static uint32 getprinter_level_2(fstring servername, int snum, NEW_BUFFER *buffe
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinter_level_3(fstring servername, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinter_level_3(int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        PRINTER_INFO_3 *printer=NULL;
-       fstring temp;
 
-       fstrcpy(temp, "\\\\");
-       fstrcat(temp, servername);
-       if (!construct_printer_info_3(temp, &printer, snum))
+       if (!construct_printer_info_3(&printer, snum))
                return ERROR_NOT_ENOUGH_MEMORY;
        
        /* check the required size. */  
@@ -2454,98 +2683,95 @@ uint32 _spoolss_getprinter(POLICY_HND *handle, uint32 level,
                           NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        int snum;
-       fstring servername;
        
        *needed=0;
 
-       pstrcpy(servername, global_myname);
-
        if (!get_printer_snum(handle, &snum))
                return ERROR_INVALID_HANDLE;
 
        switch (level) {
        case 0:
-               return getprinter_level_0(servername, snum, buffer, offered, needed);
+               return getprinter_level_0(snum, buffer, offered, needed);
        case 1:
-               return getprinter_level_1(servername,snum, buffer, offered, needed);
+               return getprinter_level_1(snum, buffer, offered, needed);
        case 2:         
-               return getprinter_level_2(servername,snum, buffer, offered, needed);
+               return getprinter_level_2(snum, buffer, offered, needed);
        case 3:         
-               return getprinter_level_3(servername,snum, buffer, offered, needed);
+               return getprinter_level_3(snum, buffer, offered, needed);
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }      
                
 /********************************************************************
- * construct_printer_driver_info_1
- * fill a construct_printer_driver_info_1 struct
+ * fill a DRIVER_INFO_1 struct
  ********************************************************************/
-static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername, fstring architecture)
 {
-       init_unistr( &(info->name), driver.info_3->name);
+       init_unistr( &info->name, driver.info_3->name);
 }
 
-static void construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, 
-                                            fstring servername, fstring architecture)
+/********************************************************************
+ * construct_printer_driver_info_1
+ ********************************************************************/
+static uint32 construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
 
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );
-       get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture);    
-       
+       if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       if (get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
+
        fill_printer_driver_info_1(info, driver, servername, architecture);
 
        free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /********************************************************************
  * construct_printer_driver_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
-static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
 {
-       pstring where;
-       pstring temp_driverpath;
-       pstring temp_datafile;
-       pstring temp_configfile;
-       fstring short_archi;
-
-       get_short_archi(short_archi,architecture);
-       
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\", servername, short_archi);
+       pstring temp;
 
        info->version=driver.info_3->cversion;
 
-       init_unistr( &info->name,         driver.info_3->name );
-       init_unistr( &info->architecture, architecture );
-       
-       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "%s%s", where, 
-                driver.info_3->driverpath);
-       init_unistr( &info->driverpath,   temp_driverpath );
+       init_unistr( &info->name, driver.info_3->name );
+       init_unistr( &info->architecture, driver.info_3->environment );
+
 
-       snprintf(temp_datafile,   sizeof(temp_datafile)-1, "%s%s", where, 
-                driver.info_3->datafile);
-       init_unistr( &info->datafile,     temp_datafile );
+    if (strlen(driver.info_3->driverpath)) {
+               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);
+               init_unistr( &info->driverpath, temp );
+    } else
+        init_unistr( &info->driverpath, "" );
 
-       snprintf(temp_configfile, sizeof(temp_configfile)-1, "%s%s", where, 
-                driver.info_3->configfile);
-       init_unistr( &info->configfile,   temp_configfile );    
+       if (strlen(driver.info_3->datafile)) {
+               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+               init_unistr( &info->datafile, temp );
+       } else
+               init_unistr( &info->datafile, "" );
+       
+       if (strlen(driver.info_3->configfile)) {
+               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+               init_unistr( &info->configfile, temp ); 
+       } else
+               init_unistr( &info->configfile, "" );
 }
 
 /********************************************************************
  * construct_printer_driver_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
-static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture)
+static uint32 construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
@@ -2553,12 +2779,17 @@ static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstri
        ZERO_STRUCT(printer);
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );
-       get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture);    
+       if (!get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       if (!get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
 
-       fill_printer_driver_info_2(info, driver, servername, architecture);
+       fill_printer_driver_info_2(info, driver, servername);
 
        free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /********************************************************************
@@ -2566,7 +2797,7 @@ static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstri
  *
  * convert an array of ascii string to a UNICODE string
  ********************************************************************/
-static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *where)
+static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *servername)
 {
        int i=0;
        int j=0;
@@ -2584,7 +2815,7 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *whe
                        if (!v) v = ""; /* hack to handle null lists */
                }
                if (strlen(v) == 0) break;
-               snprintf(line, sizeof(line)-1, "%s%s", where, v);
+               snprintf(line, sizeof(line)-1, "\\\\%s%s", servername, v);
                DEBUGADD(6,("%d:%s:%d\n", i, line, strlen(line)));
                if((*uni_array=Realloc(*uni_array, (j+strlen(line)+2)*sizeof(uint16))) == NULL) {
                        DEBUG(0,("init_unistr_array: Realloc error\n" ));
@@ -2605,67 +2836,185 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *whe
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
-{
-       pstring where;
-       pstring temp_driverpath;
-       pstring temp_datafile;
-       pstring temp_configfile;
-       pstring temp_helpfile;
-       fstring short_archi;
-       
-       get_short_archi(short_archi, architecture);
-       
-#if MANGLE_DRIVER_PATH
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\%s\\", servername, short_archi, driver.info_3->name);
-#else
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\", servername, short_archi);
-#endif
+static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
+{
+       pstring temp;
+
+       ZERO_STRUCTP(info);
 
        info->version=driver.info_3->cversion;
 
-       init_unistr( &info->name,         driver.info_3->name );        
-       init_unistr( &info->architecture, architecture );
-       
-       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "%s%s", where, driver.info_3->driverpath);          
-       init_unistr( &info->driverpath, temp_driverpath );
-       
-       snprintf(temp_datafile,   sizeof(temp_datafile)-1,   "%s%s", where, driver.info_3->datafile); 
-       init_unistr( &info->datafile, temp_datafile );
-       
-       snprintf(temp_configfile, sizeof(temp_configfile)-1, "%s%s", where, driver.info_3->configfile);
-       init_unistr( &info->configfile, temp_configfile );      
-       
-       snprintf(temp_helpfile,   sizeof(temp_helpfile)-1,   "%s%s", where, driver.info_3->helpfile);
-       init_unistr( &info->helpfile, temp_helpfile );
+       init_unistr( &info->name, driver.info_3->name );        
+       init_unistr( &info->architecture, driver.info_3->environment );
+
+    if (strlen(driver.info_3->driverpath)) {
+        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);             
+        init_unistr( &info->driverpath, temp );
+    } else
+        init_unistr( &info->driverpath, "" );
+    
+    if (strlen(driver.info_3->datafile)) {
+        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+        init_unistr( &info->datafile, temp );
+    } else
+        init_unistr( &info->datafile, "" );
+
+    if (strlen(driver.info_3->configfile)) {
+        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+        init_unistr( &info->configfile, temp );        
+    } else
+        init_unistr( &info->configfile, "" );
+
+    if (strlen(driver.info_3->helpfile)) {
+        snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
+        init_unistr( &info->helpfile, temp );
+    } else
+        init_unistr( &info->helpfile, "" );
 
        init_unistr( &info->monitorname, driver.info_3->monitorname );
        init_unistr( &info->defaultdatatype, driver.info_3->defaultdatatype );
 
        info->dependentfiles=NULL;
-       init_unistr_array(&info->dependentfiles, driver.info_3->dependentfiles, where);
+       init_unistr_array(&info->dependentfiles, driver.info_3->dependentfiles, servername);
 }
 
 /********************************************************************
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static void construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, 
-                                            fstring servername, fstring architecture)
+static uint32 construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-
+       uint32 status=0;
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );      
-       get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture);    
+       status=get_a_printer(&printer, 2, lp_servicename(snum) );
+       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
+       if (status != 0)
+               return ERROR_INVALID_PRINTER_NAME;
 
-       fill_printer_driver_info_3(info, driver, servername, architecture);
+       status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
+       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
+       if (status != 0) {
+               free_a_printer(&printer,2);
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
+       }
+
+       fill_printer_driver_info_3(info, driver, servername);
 
        free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
+}
+
+/********************************************************************
+ * construct_printer_info_6
+ * fill a printer_info_6 struct - we know that driver is really level 3. This sucks. JRA.
+ ********************************************************************/
+
+static void fill_printer_driver_info_6(DRIVER_INFO_6 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
+{
+       pstring temp;
+       fstring nullstr;
+
+       ZERO_STRUCTP(info);
+       memset(&nullstr, '\0', sizeof(fstring));
+
+       info->version=driver.info_3->cversion;
+
+       init_unistr( &info->name, driver.info_3->name );        
+       init_unistr( &info->architecture, driver.info_3->environment );
+
+       if (strlen(driver.info_3->driverpath)) {
+               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->driverpath);              
+               init_unistr( &info->driverpath, temp );
+       } else
+               init_unistr( &info->driverpath, "" );
+
+       if (strlen(driver.info_3->datafile)) {
+               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+               init_unistr( &info->datafile, temp );
+       } else
+               init_unistr( &info->datafile, "" );
+
+       if (strlen(driver.info_3->configfile)) {
+               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+               init_unistr( &info->configfile, temp ); 
+       } else
+               init_unistr( &info->configfile, "" );
+
+       if (strlen(driver.info_3->helpfile)) {
+               snprintf(temp, sizeof(temp)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
+               init_unistr( &info->helpfile, temp );
+       } else
+               init_unistr( &info->helpfile, "" );
+       
+       init_unistr( &info->monitorname, driver.info_3->monitorname );
+       init_unistr( &info->defaultdatatype, driver.info_3->defaultdatatype );
+
+       info->dependentfiles=NULL;
+       init_unistr_array(&info->dependentfiles, driver.info_3->dependentfiles, servername);
+
+       info->previousdrivernames=NULL;
+       init_unistr_array(&info->previousdrivernames, &nullstr, servername);
+
+       info->driver_date.low=0;
+       info->driver_date.high=0;
+
+       info->padding=0;
+       info->driver_version_low=0;
+       info->driver_version_high=0;
+
+       init_unistr( &info->mfgname, "");
+       init_unistr( &info->oem_url, "");
+       init_unistr( &info->hardware_id, "");
+       init_unistr( &info->provider, "");
+}
+
+/********************************************************************
+ * construct_printer_info_6
+ * fill a printer_info_6 struct
+ ********************************************************************/
+static uint32 construct_printer_driver_info_6(DRIVER_INFO_6 *info, int snum, fstring servername, fstring architecture, uint32 version)
+{      
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       NT_PRINTER_DRIVER_INFO_LEVEL driver;
+       uint32 status=0;
+       ZERO_STRUCT(driver);
+
+       status=get_a_printer(&printer, 2, lp_servicename(snum) );
+       DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
+       if (status != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
+       DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
+       if (status != 0) {
+               /*
+                * Is this a W2k client ?
+                */
+
+               if (version < 3) {
+                       free_a_printer(&printer,2);
+                       return ERROR_UNKNOWN_PRINTER_DRIVER;
+               }
+
+               /* Yes - try again with a WinNT driver. */
+               version = 2;
+               status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
+               DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
+               if (status != 0) {
+                       free_a_printer(&printer,2);
+                       return ERROR_UNKNOWN_PRINTER_DRIVER;
+               }
+       }
+
+       fill_printer_driver_info_6(info, driver, servername);
+
+       free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /****************************************************************************
@@ -2678,14 +3027,28 @@ static void free_printer_driver_info_3(DRIVER_INFO_3 *info)
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level1(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+
+static void free_printer_driver_info_6(DRIVER_INFO_6 *info)
+{
+       safe_free(info->dependentfiles);
+       
+}
+
+/****************************************************************************
+****************************************************************************/
+static uint32 getprinterdriver2_level1(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_1 *info=NULL;
+       uint32 status;
        
        if((info=(DRIVER_INFO_1 *)malloc(sizeof(DRIVER_INFO_1))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
        
-       construct_printer_driver_info_1(info, snum, servername, architecture);
+       status=construct_printer_driver_info_1(info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               safe_free(info);
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_1(info);
@@ -2709,14 +3072,19 @@ static uint32 getprinterdriver2_level1(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level2(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level2(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_2 *info=NULL;
+       uint32 status;
        
        if((info=(DRIVER_INFO_2 *)malloc(sizeof(DRIVER_INFO_2))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
        
-       construct_printer_driver_info_2(info, snum, servername, architecture);
+       status=construct_printer_driver_info_2(info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               safe_free(info);
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_2(info);
@@ -2740,13 +3108,17 @@ static uint32 getprinterdriver2_level2(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level3(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level3(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_3 info;
+       uint32 status;
 
        ZERO_STRUCT(info);
 
-       construct_printer_driver_info_3(&info, snum, servername, architecture);
+       status=construct_printer_driver_info_3(&info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_3(&info);
@@ -2769,7 +3141,40 @@ static uint32 getprinterdriver2_level3(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getprinterdriver2(POLICY_HND *handle, const UNISTR2 *uni_arch, uint32 level, 
+static uint32 getprinterdriver2_level6(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+{
+       DRIVER_INFO_6 info;
+       uint32 status;
+
+       ZERO_STRUCT(info);
+
+       status=construct_printer_driver_info_6(&info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               return status;
+       }
+
+       /* check the required size. */  
+       *needed += spoolss_size_printer_driver_info_6(&info);
+
+       if (!alloc_buffer_size(buffer, *needed)) {
+               free_printer_driver_info_6(&info);
+               return ERROR_INSUFFICIENT_BUFFER;
+       }
+
+       /* fill the buffer with the structures */
+       new_smb_io_printer_driver_info_6("", buffer, &info, 0);
+
+       free_printer_driver_info_6(&info);
+
+       if (*needed > offered)
+               return ERROR_INSUFFICIENT_BUFFER;
+       else
+               return NT_STATUS_NO_PROBLEMO;
+}
+
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_getprinterdriver2(POLICY_HND *handle, const UNISTR2 *uni_arch, uint32 level,
                                uint32 clientmajorversion, uint32 clientminorversion,
                                NEW_BUFFER *buffer, uint32 offered,
                                uint32 *needed, uint32 *servermajorversion, uint32 *serverminorversion)
@@ -2792,17 +3197,15 @@ uint32 _spoolss_getprinterdriver2(POLICY_HND *handle, const UNISTR2 *uni_arch, u
 
        switch (level) {
        case 1:
-               return getprinterdriver2_level1(servername, architecture, snum, buffer, offered, needed);
-               break;
+               return getprinterdriver2_level1(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
        case 2:
-               return getprinterdriver2_level2(servername, architecture, snum, buffer, offered, needed);
-               break;                          
+               return getprinterdriver2_level2(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
        case 3:
-               return getprinterdriver2_level3(servername, architecture, snum, buffer, offered, needed);
-               break;                          
+               return getprinterdriver2_level3(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
+       case 6:
+               return getprinterdriver2_level6(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -2837,6 +3240,21 @@ uint32 _spoolss_endpageprinter(POLICY_HND *handle)
        return NT_STATUS_NO_PROBLEMO;
 }
 
+/****************************************************************************
+ Return a user struct for a pipe user.
+****************************************************************************/
+
+static struct current_user *get_current_user(struct current_user *user, pipes_struct *p)
+{
+       if (p->ntlmssp_auth_validated) {
+               memcpy(user, &p->pipe_user, sizeof(struct current_user));
+       } else {
+               extern struct current_user current_user;
+               memcpy(user, &current_user, sizeof(struct current_user));
+       }
+
+       return user;
+}
 
 /********************************************************************
  * api_spoolss_getprinter
@@ -2844,7 +3262,7 @@ uint32 _spoolss_endpageprinter(POLICY_HND *handle)
  *
  ********************************************************************/
 uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
-                               pipes_struct *p, DOC_INFO *docinfo, 
+                               pipes_struct *p, DOC_INFO *docinfo,
                                uint32 *jobid)
 {
        DOC_INFO_1 *info_1 = &docinfo->doc_info_1;
@@ -2859,12 +3277,7 @@ uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
                return ERROR_INVALID_HANDLE;
        }
 
-       if (p->ntlmssp_auth_validated) {
-               memcpy(&user, &p->pipe_user, sizeof(user));
-       } else {
-               extern struct current_user current_user;
-               memcpy(&user, &current_user, sizeof(user));
-       }
+       get_current_user(&user, p);
 
        /*
         * a nice thing with NT is it doesn't listen to what you tell it.
@@ -2878,19 +3291,16 @@ uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
         * server-side code. *nnnnnggggh!*
         */
        
-       if (info_1->p_datatype != 0)
-       {
-               unistr2_to_ascii(datatype, &(info_1->docname), sizeof(datatype));
-               if (strcmp(datatype, "RAW") != 0)
-               {
+       if (info_1->p_datatype != 0) {
+               unistr2_to_ascii(datatype, &info_1->datatype, sizeof(datatype));
+               if (strcmp(datatype, "RAW") != 0) {
                        (*jobid)=0;
                        return ERROR_INVALID_DATATYPE;
                }               
-       }                
+       }               
        
        /* get the share number of the printer */
-       if (!get_printer_snum(handle, &snum))
-       {
+       if (!get_printer_snum(handle, &snum)) {
                return ERROR_INVALID_HANDLE;
        }
 
@@ -2898,15 +3308,17 @@ uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
        
        Printer->jobid = print_job_start(&user, snum, jobname);
 
-       /* need to map error codes properly - for now give out of
-          memory as I don't know the correct codes (tridge) */
+       /* An error occured in print_job_start() so return an appropriate
+          NT error code. */
+
        if (Printer->jobid == -1) {
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return map_nt_error_from_unix(errno);
        }
        
        Printer->document_started=True;
        (*jobid) = Printer->jobid;
 
+       srv_spoolss_sendnotify(handle);
        return 0x0;
 }
 
@@ -2928,6 +3340,8 @@ uint32 _spoolss_enddocprinter(POLICY_HND *handle)
        print_job_end(Printer->jobid);
        /* error codes unhandled so far ... */
 
+       srv_spoolss_sendnotify(handle);
+
        return 0x0;
 }
 
@@ -2945,7 +3359,7 @@ uint32 _spoolss_writeprinter( POLICY_HND *handle,
                return ERROR_INVALID_HANDLE;
        }
 
-       (*buffer_written) = print_job_write(Printer->jobid, (char *)buffer, 
+       (*buffer_written) = print_job_write(Printer->jobid, (char *)buffer,
                                            buffer_size);
 
        return 0x0;
@@ -2960,44 +3374,50 @@ static uint32 control_printer(POLICY_HND *handle, uint32 command,
                              pipes_struct *p)
 {
        struct current_user user;
-       int snum;
+       int snum, errcode = ERROR_INVALID_FUNCTION;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (p->ntlmssp_auth_validated) {
-               memcpy(&user, &p->pipe_user, sizeof(user));
-       } else {
-               extern struct current_user current_user;
-               memcpy(&user, &current_user, sizeof(user));
-       }
+       get_current_user(&user, p);
 
        if (!OPEN_HANDLE(Printer)) {
                DEBUG(0,("control_printer: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
 
-       if (!get_printer_snum(handle, &snum) )   
+       if (!get_printer_snum(handle, &snum))
                return ERROR_INVALID_HANDLE;
 
        switch (command) {
        case PRINTER_CONTROL_PAUSE:
-               if (print_queue_pause(&user, snum)) {
-                       return 0;
+               if (print_queue_pause(&user, snum, &errcode)) {
+                       errcode = 0;
                }
                break;
        case PRINTER_CONTROL_RESUME:
        case PRINTER_CONTROL_UNPAUSE:
-               if (print_queue_resume(&user, snum)) {
-                       return 0;
+               if (print_queue_resume(&user, snum, &errcode)) {
+                       errcode = 0;
                }
                break;
        case PRINTER_CONTROL_PURGE:
-               if (print_queue_purge(&user, snum)) {
-                       return 0;
+               if (print_queue_purge(&user, snum, &errcode)) {
+                       errcode = 0;
                }
                break;
+       default:
+               return ERROR_INVALID_LEVEL;
        }
 
-       return ERROR_INVALID_FUNCTION;
+       return errcode;
+}
+
+/********************************************************************
+ * api_spoolss_abortprinter
+ ********************************************************************/
+
+uint32 _spoolss_abortprinter(POLICY_HND *handle, pipes_struct *p)
+{
+       return control_printer(handle, PRINTER_CONTROL_PURGE, p);
 }
 
 /********************************************************************
@@ -3008,86 +3428,410 @@ static uint32 update_printer_sec(POLICY_HND *handle, uint32 level,
                                 const SPOOL_PRINTER_INFO_LEVEL *info,
                                 pipes_struct *p, SEC_DESC_BUF *secdesc_ctr)
 {
-       SEC_DESC_BUF *old_secdesc_ctr = NULL;
+       SEC_DESC_BUF *new_secdesc_ctr = NULL, *old_secdesc_ctr = NULL;
        struct current_user user;
-       uint32 acc_granted, status, result;
+       uint32 result;
+       int snum;
 
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUG(0,("update_printer_sec: Invalid handle (%s)\n", OUR_HANDLE(handle)));
-               return ERROR_INVALID_HANDLE;
+       if (!OPEN_HANDLE(Printer) || !get_printer_snum(handle, &snum)) {
+               DEBUG(0,("update_printer_sec: Invalid handle (%s)\n",
+                        OUR_HANDLE(handle)));
+
+               result = ERROR_INVALID_HANDLE;
+               goto done;
        }
 
-       /* Work out which user is performing the operation */
+       /* NT seems to like setting the security descriptor even though
+          nothing may have actually changed.  This causes annoying
+          dialog boxes when the user doesn't have permission to change
+          the security descriptor. */
 
-       if (p->ntlmssp_auth_validated) {
-               memcpy(&user, &p->pipe_user, sizeof(user));
-       } else {
-               extern struct current_user current_user;
-               memcpy(&user, &current_user, sizeof(user));
+       nt_printing_getsec(Printer->dev.handlename, &old_secdesc_ctr);
+
+       if (DEBUGLEVEL >= 10) {
+               SEC_ACL *acl;
+               int i;
+
+               acl = old_secdesc_ctr->sec->dacl;
+               DEBUG(10, ("old_secdesc_ctr for %s has %d aces:\n", 
+                          PRINTERNAME(snum), acl->num_aces));
+
+               for (i = 0; i < acl->num_aces; i++) {
+                       fstring sid_str;
+
+                       sid_to_string(sid_str, &acl->ace[i].sid);
+
+                       DEBUG(10, ("%s 0x%08x\n", sid_str, 
+                                 acl->ace[i].info.mask));
+               }
+
+               acl = secdesc_ctr->sec->dacl;
+
+               if (acl) {
+                       DEBUG(10, ("secdesc_ctr for %s has %d aces:\n", 
+                                  PRINTERNAME(snum), acl->num_aces));
+
+                       for (i = 0; i < acl->num_aces; i++) {
+                               fstring sid_str;
+                               
+                               sid_to_string(sid_str, &acl->ace[i].sid);
+                               
+                               DEBUG(10, ("%s 0x%08x\n", sid_str, 
+                                          acl->ace[i].info.mask));
+                       }
+               } else {
+                       DEBUG(10, ("dacl for secdesc_ctr is NULL\n"));
+               }
        }
 
-       /* Get old security descriptor */
+       new_secdesc_ctr = sec_desc_merge(secdesc_ctr, old_secdesc_ctr);
 
-       if (!nt_printing_getsec(Printer->dev.handlename, &old_secdesc_ctr)) {
-               DEBUG(3, ("could not get old security descriptor for "
-                         "printer %s", Printer->dev.handlename));
-               return ERROR_INVALID_FUNCTION;
+       if (sec_desc_equal(new_secdesc_ctr->sec, old_secdesc_ctr->sec)) {
+               result = NT_STATUS_NO_PROBLEMO;
+               goto done;
        }
 
+       /* Work out which user is performing the operation */
+
+       get_current_user(&user, p);
+
        /* Check the user has permissions to change the security
           descriptor.  By experimentation with two NT machines, the user
           requires Full Access to the printer to change security
-          information. */ 
+          information. */
 
-       if (!se_access_check(old_secdesc_ctr->sec, &user,
-                            PRINTER_ACE_FULL_CONTROL, &acc_granted,
-                            &status)) {
-               DEBUG(3, ("security descriptor change denied by existing "
-                         "security descriptor\n"));
-               result = status;
+       if (!print_access_check(&user, snum, PRINTER_ACCESS_ADMINISTER)) {
+               result = ERROR_ACCESS_DENIED;
                goto done;
        }
 
-       result = nt_printing_setsec(Printer->dev.handlename, secdesc_ctr);
+       result = nt_printing_setsec(Printer->dev.handlename, new_secdesc_ctr);
 
  done:
+       free_sec_desc_buf(&new_secdesc_ctr);
        free_sec_desc_buf(&old_secdesc_ctr);
+
        return result;
 }
 
 /********************************************************************
  Do Samba sanity checks on a printer info struct.
+ this has changed purpose: it now "canonicalises" printer
+ info from a client rather than just checking it is correct
  ********************************************************************/
 
 static BOOL check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
 {
-       /*
-        * Ensure that this printer is shared under the correct name
-        * as this is what Samba insists upon.
-        */
+       DEBUG(5,("check_printer_ok: servername=%s printername=%s sharename=%s portname=%s drivername=%s comment=%s location=%s\n",
+                info->servername, info->printername, info->sharename, info->portname, info->drivername, info->comment, info->location));
+
+       /* we force some elements to "correct" values */
+       slprintf(info->servername, sizeof(info->servername), "\\\\%s", global_myname);
+       slprintf(info->printername, sizeof(info->printername), "\\\\%s\\%s",
+                global_myname, lp_servicename(snum));
+       fstrcpy(info->sharename, lp_servicename(snum));
+       info->attributes = PRINTER_ATTRIBUTE_SHARED   \
+               | PRINTER_ATTRIBUTE_LOCAL  \
+               | PRINTER_ATTRIBUTE_RAW_ONLY \
+               | PRINTER_ATTRIBUTE_QUEUED ;
+       
+       return True;
+}
 
-       if (!(info->attributes & PRINTER_ATTRIBUTE_SHARED)) {
-               DEBUG(10,("check_printer_ok: SHARED check failed (%x).\n", (unsigned int)info->attributes ));
+/****************************************************************************
+****************************************************************************/
+static BOOL add_printer_hook(NT_PRINTER_INFO_LEVEL *printer)
+{
+       pid_t local_pid = sys_getpid();
+       char *cmd = lp_addprinter_cmd();
+       char *path;
+       char **qlines;
+       pstring tmp_file;
+       pstring command;
+       pstring driverlocation;
+       int numlines;
+       int ret;
+
+       if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+               path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+       else
+               path = tmpdir();
+
+       /* build driver path... only 9X architecture is needed for legacy reasons */
+       slprintf(driverlocation, sizeof(driverlocation)-1, "\\\\%s\\print$\\WIN40\\0",
+                       global_myname);
+       /* change \ to \\ for the shell */
+       all_string_sub(driverlocation,"\\","\\\\",sizeof(pstring));
+       
+       slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+       slprintf(command, sizeof(command), "%s \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\"",
+                       cmd, printer->info_2->printername, printer->info_2->sharename,
+                       printer->info_2->portname, printer->info_2->drivername,
+                       printer->info_2->location, driverlocation);
+
+       unlink(tmp_file);
+
+    /* Convert script args to unix-codepage */
+    dos_to_unix(command, True);
+       DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+       ret = smbrun(command, tmp_file, False);
+       DEBUGADD(10,("returned [%d]\n", ret));
+
+       if ( ret != 0 ) {
+               unlink(tmp_file);
                return False;
        }
 
-       if (!(info->attributes & PRINTER_ATTRIBUTE_RAW_ONLY)) {
-               /* NT forgets to set the raw attribute but sends the correct type. */
-               if (strequal(info->datatype, "RAW"))
-                       info->attributes |= PRINTER_ATTRIBUTE_RAW_ONLY;
-               else {
-                       DEBUG(10,("check_printer_ok: RAW check failed (%x).\n", (unsigned int)info->attributes ));
+       numlines = 0;
+    /* Get lines and convert them back to dos-codepage */
+       qlines = file_lines_load(tmp_file, &numlines, True);
+       DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+       DEBUGADD(10,("Unlinking script output file [%s]\n", tmp_file));
+       unlink(tmp_file);
+
+       if(numlines) {
+               /* Set the portname to what the script says the portname should be. */
+               strncpy(printer->info_2->portname, qlines[0], sizeof(printer->info_2->portname));
+               DEBUGADD(6,("Line[0] = [%s]\n", qlines[0]));
+
+               /* Send SIGHUP to process group... is there a better way? */
+               kill(0, SIGHUP);
+               add_all_printers();
+       }
+
+       file_lines_free(qlines);
+       return True;
+}
+
+/* Return true if two devicemodes are equal */
+
+#define DEVMODE_CHECK_INT(field) \
+    if (d1->field != d2->field) { \
+        DEBUG(10, ("nt_devicemode_equal(): " #field " not equal (%d != %d)\n", \
+            d1->field, d2->field)); \
+        return False; \
+    }
+
+static BOOL nt_devicemode_equal(NT_DEVICEMODE *d1, NT_DEVICEMODE *d2)
+{
+       if (!d1 && !d2) goto equal;  /* if both are NULL they are equal */
+
+       if (!d1 ^ !d2) {
+               DEBUG(10, ("nt_devicemode_equal(): pointers not equal\n"));
+               return False; /* if either is exclusively NULL are not equal */
+       }
+
+       if (!strequal(d1->devicename, d2->devicename) ||
+           !strequal(d1->formname, d2->formname)) {
+               DEBUG(10, ("nt_devicemode_equal(): device,form not equal\n"));
+               return False;
+       }
+
+       DEVMODE_CHECK_INT(specversion);
+       DEVMODE_CHECK_INT(driverversion);
+       DEVMODE_CHECK_INT(driverextra);
+       DEVMODE_CHECK_INT(orientation);
+       DEVMODE_CHECK_INT(papersize);
+       DEVMODE_CHECK_INT(paperlength);
+       DEVMODE_CHECK_INT(paperwidth);
+       DEVMODE_CHECK_INT(scale);
+       DEVMODE_CHECK_INT(copies);
+       DEVMODE_CHECK_INT(defaultsource);
+       DEVMODE_CHECK_INT(printquality);
+       DEVMODE_CHECK_INT(color);
+       DEVMODE_CHECK_INT(duplex);
+       DEVMODE_CHECK_INT(yresolution);
+       DEVMODE_CHECK_INT(ttoption);
+       DEVMODE_CHECK_INT(collate);
+       DEVMODE_CHECK_INT(logpixels);
+
+       DEVMODE_CHECK_INT(fields);
+       DEVMODE_CHECK_INT(bitsperpel);
+       DEVMODE_CHECK_INT(pelswidth);
+       DEVMODE_CHECK_INT(pelsheight);
+       DEVMODE_CHECK_INT(displayflags);
+       DEVMODE_CHECK_INT(displayfrequency);
+       DEVMODE_CHECK_INT(icmmethod);
+       DEVMODE_CHECK_INT(icmintent);
+       DEVMODE_CHECK_INT(mediatype);
+       DEVMODE_CHECK_INT(dithertype);
+       DEVMODE_CHECK_INT(reserved1);
+       DEVMODE_CHECK_INT(reserved2);
+       DEVMODE_CHECK_INT(panningwidth);
+       DEVMODE_CHECK_INT(panningheight);
+
+       /* compare the private data if it exists */
+       if (!d1->driverextra && !d2->driverextra) goto equal;
+
+
+       DEVMODE_CHECK_INT(driverextra);
+
+       if (memcmp(d1->private, d2->private, d1->driverextra)) {
+               DEBUG(10, ("nt_devicemode_equal(): private data not equal\n"));
+               return False;
+       }
+
+ equal:
+       DEBUG(10, ("nt_devicemode_equal(): devicemodes identical\n"));
+       return True;
+}
+
+/* Return true if two NT_PRINTER_PARAM structures are equal */
+
+static BOOL nt_printer_param_equal(NT_PRINTER_PARAM *p1,
+                                  NT_PRINTER_PARAM *p2)
+{
+       if (!p1 && !p2) goto equal;
+
+       if ((!p1 && p2) || (p1 && !p2)) {
+               DEBUG(10, ("nt_printer_param_equal(): pointers differ\n"));
+               return False;
+       }
+
+       /* Compare lists of printer parameters */
+
+       while (p1) {
+               BOOL found = False;
+               NT_PRINTER_PARAM *q = p1;
+
+               /* Find the parameter in the second structure */
+
+               while(q) {
+
+                       if (strequal(p1->value, q->value)) {
+
+                               if (p1->type != q->type) {
+                                       DEBUG(10, ("nt_printer_param_equal():"
+                                                  "types for %s differ (%d != %d)\n",
+                                                  p1->value, p1->type,
+                                                  q->type));
+                                       break;
+                               }
+
+                               if (p1->data_len != q->data_len) {
+                                       DEBUG(10, ("nt_printer_param_equal():"
+                                                  "len for %s differs (%d != %d)\n",
+                                                  p1->value, p1->data_len,
+                                                  q->data_len));
+                                       break;
+                               }
+
+                               if (memcmp(p1->data, q->data, p1->data_len) == 0) {
+                                       found = True;
+                               } else {
+                                       DEBUG(10, ("nt_printer_param_equal():"
+                                                  "data for %s differs\n", p1->value));
+                               }
+
+                               break;
+                       }
+
+                       q = q->next;
+               }
+
+               if (!found) {
+                       DEBUG(10, ("nt_printer_param_equal(): param %s "
+                                  "does not exist\n", p1->value));
                        return False;
                }
+
+               p1 = p1->next;
        }
 
-       if (!strequal(info->sharename, lp_servicename(snum))) {
-               DEBUG(10,("check_printer_ok: NAME check failed (%s) (%s).\n", info->sharename, lp_servicename(snum)));
+       equal:
+
+       DEBUG(10, ("nt_printer_param_equal(): printer params identical\n"));
+       return True;
+}
+
+/********************************************************************
+ * Called by update_printer when trying to work out whether to
+ * actually update printer info.
+ ********************************************************************/
+
+#define PI_CHECK_INT(field) \
+    if (pi1->field != pi2->field) { \
+        DEBUG(10, ("nt_printer_info_level_equal(): " #field " not equal (%d != %d)\n", \
+            pi1->field, pi2->field)); \
+        return False; \
+    }
+
+#define PI_CHECK_STR(field) \
+    if (!strequal(pi1->field, pi2->field)) { \
+        DEBUG(10, ("nt_printer_info_level_equal(): " #field " not equal (%s != %s)\n", \
+            pi1->field, pi2->field)); \
+        return False; \
+    }
+
+static BOOL nt_printer_info_level_equal(NT_PRINTER_INFO_LEVEL *p1,
+                                       NT_PRINTER_INFO_LEVEL *p2)
+{
+       NT_PRINTER_INFO_LEVEL_2 *pi1, *pi2;
+
+       /* Trivial conditions */
+
+       if ((!p1 && !p2) || (!p1->info_2 && !p2->info_2)) {
+               goto equal;
+       }
+
+       if ((!p1 && p2) || (p1 && !p2) ||
+           (!p1->info_2 && p2->info_2) ||
+           (p1->info_2 && !p2->info_2)) {
+               DEBUG(10, ("nt_printer_info_level_equal(): info levels "
+                          "differ\n"));
+               return False;
+       }
+
+       /* Compare two nt_printer_info_level structures.  Don't compare
+          status or cjobs as they seem to have something to do with the
+          printer queue. */
+
+       pi1 = p1->info_2;
+       pi2 = p2->info_2;
+
+       PI_CHECK_INT(attributes);
+       PI_CHECK_INT(priority);
+       PI_CHECK_INT(default_priority);
+       PI_CHECK_INT(starttime);
+       PI_CHECK_INT(untiltime);
+       PI_CHECK_INT(averageppm);
+
+       /* Yuck - don't check the printername or servername as the
+          add_a_printer() code plays games with them.  You can't
+          change the printername or the sharename through this interface
+          in Samba. */
+
+       PI_CHECK_STR(sharename);
+       PI_CHECK_STR(portname);
+       PI_CHECK_STR(drivername);
+       PI_CHECK_STR(comment);
+       PI_CHECK_STR(location);
+
+       if (!nt_devicemode_equal(pi1->devmode, pi2->devmode)) {
+               return False;
+       }
+
+       PI_CHECK_STR(sepfile);
+       PI_CHECK_STR(printprocessor);
+       PI_CHECK_STR(datatype);
+       PI_CHECK_STR(parameters);
+
+       if (!nt_printer_param_equal(pi1->specific, pi2->specific)) {
                return False;
        }
 
+       if (!sec_desc_equal(pi1->secdesc_buf->sec, pi2->secdesc_buf->sec)) {
+               return False;
+       }
+
+       PI_CHECK_INT(changeid);
+       PI_CHECK_INT(c_setprinter);
+       PI_CHECK_INT(setuptime);
+
+ equal:
+       DEBUG(10, ("nt_printer_info_level_equal(): infos are identical\n"));
        return True;
 }
 
@@ -3101,34 +3845,14 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
                            DEVICEMODE *devmode)
 {
        int snum;
-       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       NT_PRINTER_INFO_LEVEL *printer = NULL, *old_printer = NULL;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
-       SEC_DESC_BUF *sd = NULL;
-       uint32 result, acc_granted;
-       extern struct current_user current_user;
+       uint32 result;
 
        DEBUG(8,("update_printer\n"));
        
        result = NT_STATUS_NO_PROBLEMO;
 
-       /* Check calling user has permission to update printer description */ 
-
-#if 1 /* JFMTEST */
-       if (!nt_printing_getsec(Printer->dev.handlename, &sd)) {
-               DEBUG(3, ("Could not get security descriptor for printer %s",
-                         Printer->dev.handlename));
-               result = ERROR_INVALID_FUNCTION;
-               goto done;
-       }
-
-       if (!se_access_check(sd->sec, &current_user,
-                            PRINTER_ACE_FULL_CONTROL, &acc_granted,
-                            &result)) {
-               DEBUG(3, ("printer property change denied by security "
-                         "descriptor\n"));
-               goto done;
-       }
-#endif
        if (level!=2) {
                DEBUG(0,("Send a mail to samba@samba.org\n"));
                DEBUGADD(0,("with the following message: update_printer: level!=2\n"));
@@ -3145,8 +3869,9 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
                result = ERROR_INVALID_HANDLE;
                goto done;
        }
-       
-       if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0) {
+
+       if((get_a_printer(&printer, 2, lp_servicename(snum)) != 0) ||
+          (get_a_printer(&old_printer, 2, lp_servicename(snum)) != 0)) {
                result = ERROR_INVALID_HANDLE;
                goto done;
        }
@@ -3160,13 +3885,13 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
         */
 
        convert_printer_info(info, printer, level);
-       
+
        if (info->info_2->devmode_ptr != 0) {
                /* we have a valid devmode
                   convert it and link it*/
 
                /*
-                * Ensure printer->info_2->devmode is a valid pointer 
+                * Ensure printer->info_2->devmode is a valid pointer
                 * as we will be overwriting it in convert_devicemode().
                 */
                
@@ -3182,15 +3907,42 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
                printer->info_2->devmode=NULL;
        }
 
-       /*
-        * Do sanity check on the requested changes for Samba.
-        */
+       /* Do sanity check on the requested changes for Samba */
 
        if (!check_printer_ok(printer->info_2, snum)) {
+               result = ERROR_INVALID_PARAMETER;
+               goto done;
+       }
+
+       /* NT likes to call this function even though nothing has actually
+          changed.  Check this so the user doesn't end up with an
+          annoying permission denied dialog box. */
+
+       if (nt_printer_info_level_equal(printer, old_printer)) {
+               DEBUG(3, ("printer info has not changed\n"));
+               result = NT_STATUS_NO_PROBLEMO;
+               goto done;
+       }
+
+       /* Check calling user has permission to update printer description */
+
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("printer property change denied by security "
+                         "descriptor\n"));
                result = ERROR_ACCESS_DENIED;
                goto done;
        }
 
+       /* Call addprinter hook */
+
+       if (*lp_addprinter_cmd() )
+               if ( !add_printer_hook(printer) ) {
+                       result = ERROR_ACCESS_DENIED;
+                       goto done;
+               }
+       
+       /* Update printer info */
+
        if (add_a_printer(*printer, 2)!=0) {
                /* I don't really know what to return here !!! */
                result = ERROR_ACCESS_DENIED;
@@ -3199,7 +3951,9 @@ static uint32 update_printer(POLICY_HND *handle, uint32 level,
 
  done:
        free_a_printer(&printer, 2);
-       free_sec_desc_buf(&sd);
+       free_a_printer(&old_printer, 2);
+
+       srv_spoolss_sendnotify(handle);
 
        return result;
 }
@@ -3223,17 +3977,13 @@ uint32 _spoolss_setprinter(POLICY_HND *handle, uint32 level,
        switch (level) {
                case 0:
                        return control_printer(handle, command, p);
-                       break;
                case 2:
                        return update_printer(handle, level, info, devmode_ctr.devmode);
-                       break;
                case 3:
                        return update_printer_sec(handle, level, info, p,
                                                  secdesc_ctr);
-                       break;
                default:
                        return ERROR_INVALID_LEVEL;
-                       break;
        }
 }
 
@@ -3247,7 +3997,11 @@ uint32 _spoolss_fcpn(POLICY_HND *handle)
                DEBUG(0,("_spoolss_fcpn: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
-       
+
+       if (Printer->notify.client_connected==True)
+               if(!srv_spoolss_replycloseprinter(&Printer->notify.client_hnd))
+                       return ERROR_INVALID_HANDLE;
+
        Printer->notify.flags=0;
        Printer->notify.options=0;
        Printer->notify.localmachine[0]='\0';
@@ -3256,16 +4010,22 @@ uint32 _spoolss_fcpn(POLICY_HND *handle)
                safe_free(Printer->notify.option->ctr.type);
        safe_free(Printer->notify.option);
        Printer->notify.option=NULL;
-       
+       Printer->notify.client_connected=False;
+
        return NT_STATUS_NO_PROBLEMO;
 }
 
 /****************************************************************************
 ****************************************************************************/
 uint32 _spoolss_addjob(POLICY_HND *handle, uint32 level,
-                       NEW_BUFFER *buffer, uint32 offered)
+                      NEW_BUFFER *buffer, uint32 offered,
+                      uint32 *needed)
 {
-       return NT_STATUS_NO_PROBLEMO;
+       *needed = 0;
+       return ERROR_INVALID_PARAMETER; /* this is what a NT server
+                                           returns for AddJob. AddJob
+                                           must fail on non-local
+                                           printers */
 }
 
 /****************************************************************************
@@ -3276,9 +4036,8 @@ static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
        pstring temp_name;
        
        struct tm *t;
-       time_t unixdate = time(NULL);
        
-       t=gmtime(&unixdate);
+       t=gmtime(&queue->time);
        snprintf(temp_name, sizeof(temp_name), "\\\\%s", global_myname);
 
        job_info->jobid=queue->job;     
@@ -3294,7 +4053,7 @@ static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
        job_info->totalpages=0;
        job_info->pagesprinted=0;
 
-       make_systemtime(&(job_info->submitted), t);
+       make_systemtime(&job_info->submitted, t);
 }
 
 /****************************************************************************
@@ -3305,21 +4064,19 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
        pstring temp_name;
        NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        pstring chaine;
-
        struct tm *t;
-       time_t unixdate = time(NULL);
 
        if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) !=0 )
                return False;
        
-       t=gmtime(&unixdate);
+       t=gmtime(&queue->time);
        snprintf(temp_name, sizeof(temp_name), "\\\\%s", global_myname);
 
        job_info->jobid=queue->job;
        
        snprintf(chaine, sizeof(chaine)-1, "\\\\%s\\%s", global_myname, ntprinter->info_2->printername);
 
-       init_unistr(&(job_info->printername), chaine);
+       init_unistr(&job_info->printername, chaine);
        
        init_unistr(&job_info->machinename, temp_name);
        init_unistr(&job_info->username, queue->user);
@@ -3328,6 +4085,7 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
        init_unistr(&job_info->datatype, "RAW");
        init_unistr(&job_info->printprocessor, "winprint");
        init_unistr(&job_info->parameters, "");
+       init_unistr(&job_info->drivername, ntprinter->info_2->drivername);
        init_unistr(&job_info->text_status, "");
        
 /* and here the security descriptor */
@@ -3343,7 +4101,7 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
        job_info->timeelapsed=0;
        job_info->pagesprinted=0;
 
-       if((job_info->devmode = construct_dev_mode(snum, global_myname)) == NULL) {
+       if((job_info->devmode = construct_dev_mode(snum)) == NULL) {
                free_a_printer(&ntprinter, 2);
                return False;
        }
@@ -3355,8 +4113,8 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
 /****************************************************************************
  Enumjobs at level 1.
 ****************************************************************************/
-static uint32 enumjobs_level1(print_queue_struct *queue, int snum, 
-                             NEW_BUFFER *buffer, uint32 offered, 
+static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
+                             NEW_BUFFER *buffer, uint32 offered,
                              uint32 *needed, uint32 *returned)
 {
        JOB_INFO_1 *info;
@@ -3401,8 +4159,8 @@ static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
 /****************************************************************************
  Enumjobs at level 2.
 ****************************************************************************/
-static uint32 enumjobs_level2(print_queue_struct *queue, int snum, 
-                             NEW_BUFFER *buffer, uint32 offered, 
+static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
+                             NEW_BUFFER *buffer, uint32 offered,
                              uint32 *needed, uint32 *returned)
 {
        JOB_INFO_2 *info;
@@ -3434,7 +4192,7 @@ static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
                new_smb_io_job_info_2("", buffer, &info[i], 0); 
 
        /* clear memory */
-       safe_free(info);
+       free_job_info_2(info);
 
        if (*needed > offered) {
                *returned=0;
@@ -3447,7 +4205,7 @@ static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
 /****************************************************************************
  Enumjobs.
 ****************************************************************************/
-uint32 _spoolss_enumjobs( POLICY_HND *handle, uint32 firstjob, uint32 numofjobs, uint32 level,                   
+uint32 _spoolss_enumjobs( POLICY_HND *handle, uint32 firstjob, uint32 numofjobs, uint32 level,                 
                          NEW_BUFFER *buffer, uint32 offered,
                          uint32 *needed, uint32 *returned)
 {      
@@ -3468,18 +4226,20 @@ uint32 _spoolss_enumjobs( POLICY_HND *handle, uint32 firstjob, uint32 numofjobs,
        *returned = print_queue_status(snum, &queue, &prt_status);
        DEBUGADD(4,("count:[%d], status:[%d], [%s]\n", *returned, prt_status.status, prt_status.message));
 
+       if (*returned == 0) {
+               safe_free(queue);
+               return NT_STATUS_NO_PROBLEMO;
+       }
+
        switch (level) {
        case 1:
                return enumjobs_level1(queue, snum, buffer, offered, needed, returned);
-               break;
        case 2:
                return enumjobs_level2(queue, snum, buffer, offered, needed, returned);
-               break;                          
        default:
                safe_free(queue);
                *returned=0;
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -3493,17 +4253,12 @@ uint32 _spoolss_schedulejob( POLICY_HND *handle, uint32 jobid)
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setjob( POLICY_HND *handle,
-                               uint32 jobid,
-                               uint32 level,
-                               pipes_struct *p,
-                               JOB_INFO *ctr,
-                               uint32 command)
-
+uint32 _spoolss_setjob(POLICY_HND *handle, uint32 jobid, uint32 level,
+                      pipes_struct *p, JOB_INFO *ctr, uint32 command)
 {
        struct current_user user;
-       int snum;
        print_status_struct prt_status;
+       int snum, errcode = ERROR_INVALID_FUNCTION;
                
        memset(&prt_status, 0, sizeof(prt_status));
 
@@ -3514,57 +4269,86 @@ uint32 _spoolss_setjob( POLICY_HND *handle,
        if (!print_job_exists(jobid)) {
                return ERROR_INVALID_PRINTER_NAME;
        }
-       
-       if (p->ntlmssp_auth_validated) {
-               memcpy(&user, &p->pipe_user, sizeof(user));
-       } else {
-               extern struct current_user current_user;
-               memcpy(&user, &current_user, sizeof(user));
-       }
+
+       get_current_user(&user, p);     
 
        switch (command) {
        case JOB_CONTROL_CANCEL:
        case JOB_CONTROL_DELETE:
-               if (print_job_delete(&user, jobid)) return 0x0;
+               if (print_job_delete(&user, jobid, &errcode)) {
+                       errcode = 0;
+               }
                break;
        case JOB_CONTROL_PAUSE:
-               if (print_job_pause(&user, jobid)) return 0x0;
+               if (print_job_pause(&user, jobid, &errcode)) {
+                       errcode = 0;
+               }               
                break;
+       case JOB_CONTROL_RESTART:
        case JOB_CONTROL_RESUME:
-               if (print_job_resume(&user, jobid)) return 0x0;
+               if (print_job_resume(&user, jobid, &errcode)) {
+                       errcode = 0;
+               }
                break;
        default:
                return ERROR_INVALID_LEVEL;
        }
 
-       return ERROR_INVALID_HANDLE;
+       return errcode;
 }
 
 /****************************************************************************
  Enumerates all printer drivers at level 1.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_1 *driver_info_1=NULL;
 
-       ZERO_STRUCT(driver);
+       *returned=0;
 
-       if((driver_info_1=(DRIVER_INFO_1 *)malloc(*returned * sizeof(DRIVER_INFO_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+#define MAX_VERSION 4
 
-       for (i=0; i<*returned; i++) {
-               get_a_printer_driver(&driver, 3, list[i], architecture);
-               fill_printer_driver_info_1(&(driver_info_1[i]), driver, servername, architecture );
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_1=(DRIVER_INFO_1 *)Realloc(driver_info_1, (*returned+ndrivers) * sizeof(DRIVER_INFO_1))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+               }
+
+               for (i=0; i<ndrivers; i++) {
+                       uint32 status;
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
+                               safe_free(list);
+                               return status;
+                       }
+                       fill_printer_driver_info_1(&driver_info_1[*returned+i], driver, servername, architecture );             
+                       free_a_printer_driver(driver, 3);
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
        
-       safe_free(list);
-       
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
-               *needed += spoolss_size_printer_driver_info_1(&(driver_info_1[i]));
+               *needed += spoolss_size_printer_driver_info_1(&driver_info_1[i]);
        }
 
        if (!alloc_buffer_size(buffer, *needed)) {
@@ -3575,7 +4359,7 @@ static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstri
        /* fill the buffer with the form structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d] to buffer\n",i));
-               new_smb_io_printer_driver_info_1("", buffer, &(driver_info_1[i]), 0);
+               new_smb_io_printer_driver_info_1("", buffer, &driver_info_1[i], 0);
        }
 
        safe_free(driver_info_1);
@@ -3591,28 +4375,52 @@ static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstri
 /****************************************************************************
  Enumerates all printer drivers at level 2.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
+       NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_2 *driver_info_2=NULL;
 
-       if (*returned > 0 && 
-           !(driver_info_2=(DRIVER_INFO_2 *)malloc(*returned * sizeof(DRIVER_INFO_2))))
-               return ERROR_NOT_ENOUGH_MEMORY;
+       *returned=0;
 
-       for (i=0; i<*returned; i++) {
-               NT_PRINTER_DRIVER_INFO_LEVEL driver;
-               ZERO_STRUCT(driver);
-               if (get_a_printer_driver(&driver, 3, list[i], architecture)
-                   != 0) { 
-                       *returned = i;
-                       break;
+#define MAX_VERSION 4
+
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_2=(DRIVER_INFO_2 *)Realloc(driver_info_2, (*returned+ndrivers) * sizeof(DRIVER_INFO_2))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
                }
-               fill_printer_driver_info_2(&(driver_info_2[i]), driver, servername, architecture );
+               
+               for (i=0; i<ndrivers; i++) {
+                       uint32 status;
+
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
+                               safe_free(list);
+                               return status;
+                       }
+                       fill_printer_driver_info_2(&driver_info_2[*returned+i], driver, servername);            
+                       free_a_printer_driver(driver, 3);
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
        
-       safe_free(list);
-       
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
@@ -3643,24 +4451,52 @@ static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstri
 /****************************************************************************
  Enumerates all printer drivers at level 3.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level3(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_3 *driver_info_3=NULL;
 
-       ZERO_STRUCT(driver);
+       *returned=0;
 
-       if((driver_info_3=(DRIVER_INFO_3 *)malloc((*returned)*sizeof(DRIVER_INFO_3))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+#define MAX_VERSION 4
 
-       for (i=0; i<*returned; i++) {
-               get_a_printer_driver(&driver, 3, list[i], architecture);
-               fill_printer_driver_info_3(&(driver_info_3[i]), driver, servername, architecture );
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_3=(DRIVER_INFO_3 *)Realloc(driver_info_3, (*returned+ndrivers) * sizeof(DRIVER_INFO_3))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+               }
+
+               for (i=0; i<ndrivers; i++) {
+                       uint32 status;
+
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
+                               safe_free(list);
+                               return status;
+                       }
+                       fill_printer_driver_info_3(&driver_info_3[*returned+i], driver, servername);            
+                       free_a_printer_driver(driver, 3);
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
-       
-       safe_free(list);
-       
+
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
@@ -3698,7 +4534,6 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
                                    NEW_BUFFER *buffer, uint32 offered,
                                    uint32 *needed, uint32 *returned)
 {
-       int i;
        fstring *list = NULL;
        fstring servername;
        fstring architecture;
@@ -3709,35 +4544,24 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
        *returned=0;
 
        unistr2_to_ascii(architecture, environment, sizeof(architecture)-1);
-       *returned=get_ntdrivers(&list, architecture);
-
-       DEBUGADD(4,("we have: [%d] drivers in environment [%s]\n", *returned, architecture));
-       if(*returned == -1)
-               return ERROR_NOT_ENOUGH_MEMORY;
 
-       for (i=0; i<*returned; i++)
-               DEBUGADD(5,("driver: [%s]\n", list[i]));
-       
        switch (level) {
        case 1:
-               return enumprinterdrivers_level1(list, servername, architecture, buffer, offered, needed, returned);
-               break;
+               return enumprinterdrivers_level1(servername, architecture, buffer, offered, needed, returned);
        case 2:
-               return enumprinterdrivers_level2(list, servername, architecture, buffer, offered, needed, returned);
-               break;
+               return enumprinterdrivers_level2(servername, architecture, buffer, offered, needed, returned);
        case 3:
-               return enumprinterdrivers_level3(list, servername, architecture, buffer, offered, needed, returned);
-               break;
+               return enumprinterdrivers_level3(servername, architecture, buffer, offered, needed, returned);
        default:
                *returned=0;
+               safe_free(list);
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-static void fill_form_1(FORM_1 *form, nt_forms_struct *list, int position)
+static void fill_form_1(FORM_1 *form, nt_forms_struct *list)
 {
        form->flag=list->flag;
        init_unistr(&form->name, list->name);
@@ -3751,8 +4575,8 @@ static void fill_form_1(FORM_1 *form, nt_forms_struct *list, int position)
        
 /****************************************************************************
 ****************************************************************************/
-uint32 _new_spoolss_enumforms( POLICY_HND *handle, uint32 level, 
-                              NEW_BUFFER *buffer, uint32 offered, 
+uint32 _new_spoolss_enumforms( POLICY_HND *handle, uint32 level,
+                              NEW_BUFFER *buffer, uint32 offered,
                               uint32 *needed, uint32 *numofforms)
 {
        nt_forms_struct *list=NULL;
@@ -3764,59 +4588,122 @@ uint32 _new_spoolss_enumforms( POLICY_HND *handle, uint32 level,
        DEBUGADD(5,("Offered buffer size [%d]\n", offered));
        DEBUGADD(5,("Info level [%d]\n",          level));
 
-       *numofforms = get_ntforms(&list);
-       DEBUGADD(5,("Number of forms [%d]\n",     *numofforms));
+       *numofforms = get_ntforms(&list);
+       DEBUGADD(5,("Number of forms [%d]\n",     *numofforms));
+
+       if (*numofforms == 0) return ERROR_NO_MORE_ITEMS;
+
+       switch (level) {
+       case 1:
+               if ((forms_1=(FORM_1 *)malloc(*numofforms * sizeof(FORM_1))) == NULL) {
+                       *numofforms=0;
+                       return ERROR_NOT_ENOUGH_MEMORY;
+               }
+
+               /* construct the list of form structures */
+               for (i=0; i<*numofforms; i++) {
+                       DEBUGADD(6,("Filling form number [%d]\n",i));
+                       fill_form_1(&forms_1[i], &list[i]);
+               }
+               
+               safe_free(list);
+
+               /* check the required size. */
+               for (i=0; i<*numofforms; i++) {
+                       DEBUGADD(6,("adding form [%d]'s size\n",i));
+                       buffer_size += spoolss_size_form_1(&forms_1[i]);
+               }
+
+               *needed=buffer_size;            
+               
+               if (!alloc_buffer_size(buffer, buffer_size)){
+                       safe_free(forms_1);
+                       return ERROR_INSUFFICIENT_BUFFER;
+               }
+
+               /* fill the buffer with the form structures */
+               for (i=0; i<*numofforms; i++) {
+                       DEBUGADD(6,("adding form [%d] to buffer\n",i));
+                       new_smb_io_form_1("", buffer, &forms_1[i], 0);
+               }
+
+               safe_free(forms_1);
+
+               if (*needed > offered) {
+                       *numofforms=0;
+                       return ERROR_INSUFFICIENT_BUFFER;
+               }
+               else
+                       return NT_STATUS_NO_PROBLEMO;
+                       
+       default:
+               safe_free(list);
+               return ERROR_INVALID_LEVEL;
+       }
+
+}
+
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_getform( POLICY_HND *handle, uint32 level, UNISTR2 *uni_formname, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+{
+       nt_forms_struct *list=NULL;
+       FORM_1 form_1;
+       fstring form_name;
+       int buffer_size=0;
+       int numofforms, i;
+
+       unistr2_to_ascii(form_name, uni_formname, sizeof(form_name)-1);
+
+       DEBUG(4,("_spoolss_getform\n"));
+       DEBUGADD(5,("Offered buffer size [%d]\n", offered));
+       DEBUGADD(5,("Info level [%d]\n",          level));
+
+       numofforms = get_ntforms(&list);
+       DEBUGADD(5,("Number of forms [%d]\n",     numofforms));
 
-       if (*numofforms == 0) return ERROR_NO_MORE_ITEMS;
+       if (numofforms == 0)
+               return ERROR_NO_MORE_ITEMS;
 
        switch (level) {
        case 1:
-               if ((forms_1=(FORM_1 *)malloc(*numofforms * sizeof(FORM_1))) == NULL) {
-                       *numofforms=0;
-                       return ERROR_NOT_ENOUGH_MEMORY;
-               }
 
-               /* construct the list of form structures */
-               for (i=0; i<*numofforms; i++) {
-                       DEBUGADD(6,("Filling form number [%d]\n",i));
-                       fill_form_1(&forms_1[i], &list[i], i);
+               /* Check if the requested name is in the list of form structures */
+               for (i=0; i<numofforms; i++) {
+
+                       DEBUG(4,("_spoolss_getform: checking form %s (want %s)\n", list[i].name, form_name));
+
+                       if (strequal(form_name, list[i].name)) {
+                               DEBUGADD(6,("Found form %s number [%d]\n", form_name, i));
+                               fill_form_1(&form_1, &list[i]);
+                               break;
+                       }
                }
                
                safe_free(list);
 
                /* check the required size. */
-               for (i=0; i<*numofforms; i++) {
-                       DEBUGADD(6,("adding form [%d]'s size\n",i));
-                       buffer_size += spoolss_size_form_1(&forms_1[i]);
-               }
 
-               *needed=buffer_size;            
+               *needed=spoolss_size_form_1(&form_1);
                
                if (!alloc_buffer_size(buffer, buffer_size)){
-                       safe_free(forms_1);
                        return ERROR_INSUFFICIENT_BUFFER;
                }
 
-               /* fill the buffer with the form structures */
-               for (i=0; i<*numofforms; i++) {
-                       DEBUGADD(6,("adding form [%d] to buffer\n",i));
-                       new_smb_io_form_1("", buffer, &forms_1[i], 0);
-               }
-
-               safe_free(forms_1);
-
                if (*needed > offered) {
-                       *numofforms=0;
                        return ERROR_INSUFFICIENT_BUFFER;
                }
-               else
-                       return NT_STATUS_NO_PROBLEMO;
+
+               /* fill the buffer with the form structures */
+               DEBUGADD(6,("adding form %s [%d] to buffer\n", form_name, i));
+               new_smb_io_form_1("", buffer, &form_1, 0);
+
+               return NT_STATUS_NO_PROBLEMO;
                        
        default:
                safe_free(list);
                return ERROR_INVALID_LEVEL;
        }
-
 }
 
 /****************************************************************************
@@ -3843,46 +4730,70 @@ static void fill_port_2(PORT_INFO_2 *port, char *name)
 ****************************************************************************/
 static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       int n_services=lp_numservices();
-       int snum;
-       int i=0;
-       
        PORT_INFO_1 *ports=NULL;
+       int i=0;
 
-       for (snum=0; snum<n_services; snum++)
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) )
-                       (*returned)++;
-
-       if((ports=(PORT_INFO_1 *)malloc( (*returned+1) * sizeof(PORT_INFO_1) )) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
-       
-       for (snum=0; snum<n_services; snum++) {
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
-                       /*
-                        * Ensure this port name is unique.
-                        */
-                       int j;
-
-                       DEBUG(10,("enumports_level_1: port name %s\n", PRINTERNAME(snum)));
+       if (*lp_enumports_cmd()) {
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_enumports_cmd();
+               char *path;
+               char **qlines;
+               pstring tmp_file;
+               pstring command;
+               int numlines;
+               int ret;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 1);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               DEBUG(10,("Returned [%d]\n", ret));
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       /* Is this the best error to return here? */
+                       return ERROR_ACCESS_DENIED;
+               }
 
-                       for(j = 0; j < i; j++) {
-                               fstring port_name;
-                               unistr_to_dos(port_name, (const char *)&ports[j].port_name.buffer[0], sizeof(port_name));
+               numlines = 0;
+               qlines = file_lines_load(tmp_file, &numlines,True);
+               DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+               unlink(tmp_file);
 
-                               if (strequal(port_name, PRINTERNAME(snum)))
-                                       break;
+               if(numlines) {
+                       if((ports=(PORT_INFO_1 *)malloc( numlines * sizeof(PORT_INFO_1) )) == NULL) {
+                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
+                               file_lines_free(qlines);
+                               return ERROR_NOT_ENOUGH_MEMORY;
                        }
 
-                       if (j < i)
-                               continue;
+                       for (i=0; i<numlines; i++) {
+                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                               fill_port_1(&ports[i], qlines[i]);
+                       }
 
-                       DEBUGADD(6,("Filling port number [%d]\n", i));
-                       fill_port_1(&ports[i], PRINTERNAME(snum));
-                       i++;
+                       file_lines_free(qlines);
                }
-       }
 
-       *returned = i;
+               *returned = numlines;
+
+       } else {
+               *returned = 1; /* Sole Samba port returned. */
+
+               if((ports=(PORT_INFO_1 *)malloc( sizeof(PORT_INFO_1) )) == NULL)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+       
+               DEBUG(10,("enumports_level_1: port name %s\n", SAMBA_PRINTER_PORT_NAME));
+
+               fill_port_1(&ports[0], SAMBA_PRINTER_PORT_NAME);
+       }
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
@@ -3917,46 +4828,71 @@ static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *need
 
 static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       int n_services=lp_numservices();
-       int snum;
-       int i=0;
-       
        PORT_INFO_2 *ports=NULL;
+       int i=0;
 
-       for (snum=0; snum<n_services; snum++)
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) )
-                       (*returned)++;
-
-       if((ports=(PORT_INFO_2 *)malloc( (*returned+1) * sizeof(PORT_INFO_2) )) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
-       
-       for (snum=0; snum<n_services; snum++) {
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
-                       /*
-                        * Ensure this port name is unique.
-                        */
-                       int j;
-
-                       DEBUG(10,("enumports_level_2: port name %s\n", PRINTERNAME(snum)));
+       if (*lp_enumports_cmd()) {
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_enumports_cmd();
+               char *path;
+               char **qlines;
+               pstring tmp_file;
+               pstring command;
+               int numlines;
+               int ret;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 2);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               DEBUGADD(10,("returned [%d]\n", ret));
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       /* Is this the best error to return here? */
+                       return ERROR_ACCESS_DENIED;
+               }
 
-                       for(j = 0; j < i; j++) {
-                               fstring port_name;
-                               unistr_to_dos(port_name, (const char *)&ports[j].port_name.buffer[0], sizeof(port_name));
+               numlines = 0;
+               qlines = file_lines_load(tmp_file, &numlines,True);
+               DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+               unlink(tmp_file);
 
-                               if (strequal(port_name, PRINTERNAME(snum)))
-                                       break;
+               if(numlines) {
+                       if((ports=(PORT_INFO_2 *)malloc( numlines * sizeof(PORT_INFO_2) )) == NULL) {
+                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
+                               file_lines_free(qlines);
+                               return ERROR_NOT_ENOUGH_MEMORY;
                        }
 
-                       if (j < i)
-                               continue;
+                       for (i=0; i<numlines; i++) {
+                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                               fill_port_2(&(ports[i]), qlines[i]);
+                       }
 
-                       DEBUGADD(6,("Filling port number [%d]\n", i));
-                       fill_port_2(&ports[i], PRINTERNAME(snum));
-                       i++;
+                       file_lines_free(qlines);
                }
-       }
 
-       *returned = i;
+               *returned = numlines;
+
+       } else {
+
+               *returned = 1;
+
+               if((ports=(PORT_INFO_2 *)malloc( sizeof(PORT_INFO_2) )) == NULL)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+       
+               DEBUG(10,("enumports_level_2: port name %s\n", SAMBA_PRINTER_PORT_NAME));
+
+               fill_port_2(&ports[0], SAMBA_PRINTER_PORT_NAME);
+       }
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
@@ -3988,8 +4924,8 @@ static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *need
 /****************************************************************************
  enumports.
 ****************************************************************************/
-uint32 _spoolss_enumports( UNISTR2 *name, uint32 level, 
-                          NEW_BUFFER *buffer, uint32 offered, 
+uint32 _spoolss_enumports( UNISTR2 *name, uint32 level,
+                          NEW_BUFFER *buffer, uint32 offered,
                           uint32 *needed, uint32 *returned)
 {
        DEBUG(4,("_spoolss_enumports\n"));
@@ -4000,13 +4936,10 @@ uint32 _spoolss_enumports( UNISTR2 *name, uint32 level,
        switch (level) {
        case 1:
                return enumports_level_1(buffer, offered, needed, returned);
-               break;
        case 2:
                return enumports_level_2(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -4020,7 +4953,6 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
        fstring name;
-       fstring share_name;
        int snum;
 
        if ((printer = (NT_PRINTER_INFO_LEVEL *)malloc(sizeof(NT_PRINTER_INFO_LEVEL))) == NULL) {
@@ -4033,14 +4965,25 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
        /* convert from UNICODE to ASCII - this allocates the info_2 struct inside *printer.*/
        convert_printer_info(info, printer, 2);
 
-       unistr2_to_ascii(share_name, &info->info_2->sharename, sizeof(share_name)-1);
-       
-       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", global_myname, share_name);
+       if (*lp_addprinter_cmd() )
+               if ( !add_printer_hook(printer) ) {
+                       free_a_printer(&printer,2);
+                       return ERROR_ACCESS_DENIED;
+       }
 
-       if ((snum = print_queue_snum(share_name)) == -1) {
+       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", global_myname,
+             printer->info_2->sharename);
+
+       if ((snum = print_queue_snum(printer->info_2->sharename)) == -1) {
                free_a_printer(&printer,2);
                return ERROR_ACCESS_DENIED;
        }
+
+       /* you must be a printer admin to add a new printer */
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               free_a_printer(&printer,2);
+               return ERROR_ACCESS_DENIED;             
+       }
        
        /*
         * Do sanity check on the requested changes for Samba.
@@ -4048,7 +4991,7 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
 
        if (!check_printer_ok(printer->info_2, snum)) {
                free_a_printer(&printer,2);
-               return ERROR_ACCESS_DENIED;
+               return ERROR_INVALID_PARAMETER;
        }
 
        /* write the ASCII on disk */
@@ -4059,12 +5002,15 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
 
        if (!open_printer_hnd(handle, name)) {
                /* Handle open failed - remove addition. */
-               del_a_printer(share_name);
+               del_a_printer(printer->info_2->sharename);
                free_a_printer(&printer,2);
                return ERROR_ACCESS_DENIED;
        }
 
        free_a_printer(&printer,2);
+
+       srv_spoolss_sendnotify(handle);
+
        return NT_STATUS_NO_PROBLEMO;
 }
 
@@ -4081,92 +5027,48 @@ uint32 _spoolss_addprinterex( const UNISTR2 *uni_srv_name, uint32 level,
                        /* we don't handle yet */
                        /* but I know what to do ... */
                        return ERROR_INVALID_LEVEL;
-                       break;
                case 2:
-                       return spoolss_addprinterex_level_2(uni_srv_name, info, 
+                       return spoolss_addprinterex_level_2(uni_srv_name, info,
                                                            unk0, unk1, unk2, unk3,
                                                            user_switch, user, handle);
-                       break;
-               default:
-                       return ERROR_INVALID_LEVEL;
-                       break;
-       }
-}
-
-/****************************************************************************
- Modify internal driver heirarchy.
-****************************************************************************/
-
-#if MANGLE_DRIVER_PATH
-static uint32 modify_driver_heirarchy(NT_PRINTER_DRIVER_INFO_LEVEL *driver, uint32 level)
-{
-       pstring path_old;
-       pstring path_new;
-       pstring short_archi;
-       pstring model_name;
-
-       /* find_service is an smbd-specific function call */
-       int snum = find_service("print$");
-       char *model = NULL;
-
-       *short_archi = '\0';
-       switch (level) {
-               case 3:
-                       get_short_archi(short_archi, driver->info_3->environment);
-                       model = driver->info_3->name;
-                       break;
-               case 6:
-                       get_short_archi(short_archi, driver->info_6->environment);
-                       model = driver->info_6->name;
-                       break;
                default:
-                       DEBUG(0,("modify_driver_heirarchy: unknown info level (%d)\n", level));
                        return ERROR_INVALID_LEVEL;
-                       break;
-       }
-
-       slprintf(path_old, sizeof(path_old)-1, "%s/%s/TMP_%s", lp_pathname(snum), short_archi,
-               client_addr());
-
-       /* Clean up any '/' and other characters in the model name. */
-       alpha_strcpy(model_name, model, sizeof(pstring));
-
-       slprintf(path_new, sizeof(path_new)-1, "%s/%s/%s", lp_pathname(snum), short_archi, model_name);
-
-       DEBUG(10,("modify_driver_heirarchy: old_path=%s, new_path=%s\n",
-                       path_old, path_new ));
-       if (dos_rename(path_old, path_new) == -1) {
-               DEBUG(0,("modify_driver_heirarchy: rename from %s to %s failed (%s)\n", 
-                       path_old, path_new, strerror(errno) ));
-               /* We need to clean up here.... - how ? */
-               return ERROR_ACCESS_DENIED; /* We need a generic mapping from NT errors here... */
        }
-
-       return NT_STATUS_NO_PROBLEMO;
 }
-#endif
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addprinterdriver( const UNISTR2 *server_name,
-                               uint32 level,
-                               const SPOOL_PRINTER_DRIVER_INFO_LEVEL *info)
+uint32 _spoolss_addprinterdriver(pipes_struct *p, const UNISTR2 *server_name,
+                                uint32 level, const SPOOL_PRINTER_DRIVER_INFO_LEVEL *info)
 {
        uint32 err = NT_STATUS_NO_PROBLEMO;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
+       struct current_user user;
+       
        ZERO_STRUCT(driver);
+
+       get_current_user(&user, p);     
        
        convert_printer_driver_info(info, &driver, level);
 
-       if (add_a_printer_driver(driver, level)!=0)
-               return ERROR_ACCESS_DENIED;
+       DEBUG(5,("Cleaning driver's information\n"));
+       if ((err = clean_up_driver_struct(driver, level, &user)) != NT_STATUS_NO_PROBLEMO )
+               goto done;
 
-#if MANGLE_DRIVER_PATH
-       err = modify_driver_heirarchy(&driver, level);
-#endif
+       DEBUG(5,("Moving driver to final destination\n"));
+       if(!move_driver_to_download_area(driver, level, &user, &err)) {
+               if (err == 0)
+                       err = ERROR_ACCESS_DENIED;
+               goto done;
+       }
 
-       free_a_printer_driver(driver, level);
+       if (add_a_printer_driver(driver, level)!=0) {
+               err = ERROR_ACCESS_DENIED;
+               goto done;
+       }
 
+ done:
+       free_a_printer_driver(driver, level);
        return err;
 }
 
@@ -4174,7 +5076,7 @@ uint32 _spoolss_addprinterdriver( const UNISTR2 *server_name,
 ****************************************************************************/
 static void fill_driverdir_1(DRIVER_DIRECTORY_1 *info, char *name)
 {
-       init_unistr(&(info->name), name);
+       init_unistr(&info->name, name);
 }
 
 /****************************************************************************
@@ -4185,20 +5087,17 @@ static uint32 getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environmen
        pstring long_archi;
        pstring short_archi;
        DRIVER_DIRECTORY_1 *info=NULL;
-       
+
+       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
+
+       if (get_short_archi(short_archi, long_archi)==FALSE)
+               return ERROR_INVALID_ENVIRONMENT;
+
        if((info=(DRIVER_DIRECTORY_1 *)malloc(sizeof(DRIVER_DIRECTORY_1))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
-       
-       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
-       get_short_archi(short_archi, long_archi);
-               
-#if MANGLE_DRIVER_PATH
-       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s\\TMP_%s", global_myname, short_archi,
-               client_addr());
-#else
-       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s",
-                       global_myname, short_archi);
-#endif
+
+       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s", global_myname, short_archi);
+
        DEBUG(4,("printer driver directory: [%s]\n", path));
 
        fill_driverdir_1(info, path);
@@ -4223,7 +5122,7 @@ static uint32 getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environmen
 /****************************************************************************
 ****************************************************************************/
 uint32 _spoolss_getprinterdriverdirectory(UNISTR2 *name, UNISTR2 *uni_environment, uint32 level,
-                                       NEW_BUFFER *buffer, uint32 offered, 
+                                       NEW_BUFFER *buffer, uint32 offered,
                                        uint32 *needed)
 {
        DEBUG(4,("_spoolss_getprinterdriverdirectory\n"));
@@ -4233,10 +5132,8 @@ uint32 _spoolss_getprinterdriverdirectory(UNISTR2 *name, UNISTR2 *uni_environmen
        switch(level) {
        case 1:
                return getprinterdriverdir_level_1(name, uni_environment, buffer, offered, needed);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
        
@@ -4286,14 +5183,34 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
        if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
                return ERROR_INVALID_HANDLE;
 
-       /* 
+       /*
         * The NT machine wants to know the biggest size of value and data
         *
         * cf: MSDN EnumPrinterData remark section
         */
        if ( (in_value_len==0) && (in_data_len==0) ) {
                DEBUGADD(6,("Activating NT mega-hack to find sizes\n"));
-               
+
+#if 0
+               /*
+                * NT can ask for a specific parameter size - we need to return NO_MORE_ITEMS
+                * if this parameter size doesn't exist.
+                * Ok - my opinion here is that the client is not asking for the greatest
+                * possible size of all the parameters, but is asking specifically for the size needed
+                * for this specific parameter. In that case we can remove the loop below and
+                * simplify this lookup code considerably. JF - comments welcome. JRA.
+                */
+
+               if (!get_specific_param_by_index(*printer, 2, idx, value, &data, &type, &data_len)) {
+                       safe_free(data);
+                       free_a_printer(&printer, 2);
+                       return ERROR_NO_MORE_ITEMS;
+               }
+#endif
+
+               safe_free(data);
+               data = NULL;
+
                param_index=0;
                biggest_valuesize=0;
                biggest_datasize=0;
@@ -4305,9 +5222,22 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
                        DEBUG(6,("current values: [%d], [%d]\n", biggest_valuesize, biggest_datasize));
 
                        safe_free(data);
+                       data = NULL;
                        param_index++;
                }
 
+               /*
+                * I think this is correct, it doesn't break APW and
+                * allows Gerald's Win32 test programs to work correctly,
+                * but may need altering.... JRA.
+                */
+
+               if (param_index == 0) {
+                       /* No parameters found. */
+                       free_a_printer(&printer, 2);
+                       return ERROR_NO_MORE_ITEMS;
+               }
+
                /* the value is an UNICODE string but realvaluesize is the length in bytes including the leading 0 */
                *out_value_len=2*(1+biggest_valuesize);
                *out_data_len=biggest_datasize;
@@ -4318,7 +5248,7 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
                return NT_STATUS_NO_PROBLEMO;
        }
        
-       /* 
+       /*
         * the value len is wrong in NT sp3
         * that's the number of bytes not the number of unicode chars
         */
@@ -4331,7 +5261,7 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
 
        free_a_printer(&printer, 2);
 
-       /* 
+       /*
         * the value is:
         * - counted in bytes in the request
         * - counted in UNICODE chars in the max reply
@@ -4339,7 +5269,7 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
         *
         * take a pause *before* coding not *during* coding
         */
-        
+       
        *out_max_value_len=(in_value_len/sizeof(uint16));
        if((*out_value=(uint16 *)malloc(in_value_len*sizeof(uint8))) == NULL) {
                safe_free(data);
@@ -4358,7 +5288,7 @@ uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
                return ERROR_NOT_ENOUGH_MEMORY;
        }
        
-       ZERO_STRUCTP(*data_out);
+       memset(*data_out,'\0',in_data_len);
        memcpy(*data_out, data, (size_t)data_len);
        *out_data_len=data_len;
 
@@ -4378,15 +5308,13 @@ uint32 _spoolss_setprinterdata( POLICY_HND *handle,
                                uint32 numeric_data)
 {
        NT_PRINTER_INFO_LEVEL *printer = NULL;
-       NT_PRINTER_PARAM *param = NULL;
-               
+       NT_PRINTER_PARAM *param = NULL, old_param;
        int snum=0;
        uint32 status = 0x0;
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
        
        DEBUG(5,("spoolss_setprinterdata\n"));
 
-       
        if (!OPEN_HANDLE(Printer)) {
                DEBUG(0,("_spoolss_setprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
@@ -4400,12 +5328,86 @@ uint32 _spoolss_setprinterdata( POLICY_HND *handle,
                return ERROR_INVALID_NAME;
 
        convert_specific_param(&param, value , type, data, real_len);
+
+       /* Check if we are making any changes or not.  Return true if
+          nothing is actually changing. */
+
+       ZERO_STRUCT(old_param);
+
+       if (get_specific_param(*printer, 2, param->value, &old_param.data,
+                              &old_param.type, (unsigned int *)&old_param.data_len)) {
+
+               if (param->type == old_param.type &&
+                   param->data_len == old_param.data_len &&
+                   memcmp(param->data, old_param.data,
+                          old_param.data_len) == 0) {
+
+                       DEBUG(3, ("setprinterdata hasn't changed\n"));
+                       status = NT_STATUS_NO_PROBLEMO;
+                       goto done;
+               }
+       }
+
+       /* Access check */
+
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("security descriptor change denied by existing "
+                         "security descriptor\n"));
+               status = ERROR_ACCESS_DENIED;
+               goto done;
+       }
+
        unlink_specific_param_if_exist(printer->info_2, param);
        
-       if (!add_a_specific_param(printer->info_2, param))
+       add_a_specific_param(printer->info_2, &param);
+       status = mod_a_printer(*printer, 2);
+
+ done:
+       free_a_printer(&printer, 2);
+       if (param)
+               free_nt_printer_param(&param);
+       safe_free(old_param.data);
+
+       return status;
+}
+
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_deleteprinterdata( POLICY_HND *handle, const UNISTR2 *value)
+{
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       NT_PRINTER_PARAM param;
+       int snum=0;
+       uint32 status = 0x0;
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+       
+       DEBUG(5,("spoolss_deleteprinterdata\n"));
+       
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_deleteprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return ERROR_INVALID_HANDLE;
+       }
+
+       if (!get_printer_snum(handle, &snum))
+               return ERROR_INVALID_HANDLE;
+
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("_spoolss_deleteprinterdata: security descriptor change denied by existing "
+                         "security descriptor\n"));
+               return ERROR_ACCESS_DENIED;
+       }
+
+       status = get_a_printer(&printer, 2, lp_servicename(snum));
+       if (status != 0x0)
+               return ERROR_INVALID_NAME;
+
+       ZERO_STRUCTP(&param);
+       unistr2_to_ascii(param.value, value, sizeof(param.value)-1);
+
+       if(!unlink_specific_param_if_exist(printer->info_2, &param))
                status = ERROR_INVALID_PARAMETER;
        else
-               status = add_a_printer(*printer, 2);
+               status = mod_a_printer(*printer, 2);
 
        free_a_printer(&printer, 2);
        return status;
@@ -4438,6 +5440,31 @@ uint32 _spoolss_addform( POLICY_HND *handle,
        return 0x0;
 }
 
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_deleteform( POLICY_HND *handle, UNISTR2 *form_name)
+{
+       int count=0;
+       uint32 ret = 0;
+       nt_forms_struct *list=NULL;
+       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+
+       DEBUG(5,("spoolss_deleteform\n"));
+
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_deleteform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return ERROR_INVALID_HANDLE;
+       }
+
+       count = get_ntforms(&list);
+       if(!delete_a_form(&list, form_name, &count, &ret))
+               return ERROR_INVALID_PARAMETER;
+
+       safe_free(list);
+
+       return ret;
+}
+
 /****************************************************************************
 ****************************************************************************/
 uint32 _spoolss_setform( POLICY_HND *handle,
@@ -4476,7 +5503,7 @@ static uint32 enumprintprocessors_level_1(NEW_BUFFER *buffer, uint32 offered, ui
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "winprint");
+       init_unistr(&info_1->name, "winprint");
 
        *needed += spoolss_size_printprocessor_info_1(info_1);
 
@@ -4498,12 +5525,12 @@ static uint32 enumprintprocessors_level_1(NEW_BUFFER *buffer, uint32 offered, ui
 /****************************************************************************
 ****************************************************************************/
 uint32 _spoolss_enumprintprocessors(UNISTR2 *name, UNISTR2 *environment, uint32 level,
-                                   NEW_BUFFER *buffer, uint32 offered, 
+                                   NEW_BUFFER *buffer, uint32 offered,
                                    uint32 *needed, uint32 *returned)
 {
        DEBUG(5,("spoolss_enumprintprocessors\n"));
 
-       /* 
+       /*
         * Enumerate the print processors ...
         *
         * Just reply with "winprint", to keep NT happy
@@ -4516,10 +5543,8 @@ uint32 _spoolss_enumprintprocessors(UNISTR2 *name, UNISTR2 *environment, uint32
        switch (level) {
        case 1:
                return enumprintprocessors_level_1(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -4535,7 +5560,7 @@ static uint32 enumprintprocdatatypes_level_1(NEW_BUFFER *buffer, uint32 offered,
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "RAW");
+       init_unistr(&info_1->name, "RAW");
 
        *needed += spoolss_size_printprocdatatype_info_1(info_1);
 
@@ -4557,7 +5582,7 @@ static uint32 enumprintprocdatatypes_level_1(NEW_BUFFER *buffer, uint32 offered,
 /****************************************************************************
 ****************************************************************************/
 uint32 _spoolss_enumprintprocdatatypes(UNISTR2 *name, UNISTR2 *processor, uint32 level,
-                                       NEW_BUFFER *buffer, uint32 offered, 
+                                       NEW_BUFFER *buffer, uint32 offered,
                                        uint32 *needed, uint32 *returned)
 {
        DEBUG(5,("_spoolss_enumprintprocdatatypes\n"));
@@ -4568,10 +5593,8 @@ uint32 _spoolss_enumprintprocdatatypes(UNISTR2 *name, UNISTR2 *processor, uint32
        switch (level) {
        case 1:
                return enumprintprocdatatypes_level_1(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -4587,7 +5610,7 @@ static uint32 enumprintmonitors_level_1(NEW_BUFFER *buffer, uint32 offered, uint
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "Local Port");
+       init_unistr(&info_1->name, "Local Port");
 
        *needed += spoolss_size_printmonitor_info_1(info_1);
 
@@ -4618,9 +5641,9 @@ static uint32 enumprintmonitors_level_2(NEW_BUFFER *buffer, uint32 offered, uint
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_2->name), "Local Port");
-       init_unistr(&(info_2->environment), "Windows NT X86");
-       init_unistr(&(info_2->dll_name), "localmon.dll");
+       init_unistr(&info_2->name, "Local Port");
+       init_unistr(&info_2->environment, "Windows NT X86");
+       init_unistr(&info_2->dll_name, "localmon.dll");
 
        *needed += spoolss_size_printmonitor_info_2(info_2);
 
@@ -4642,12 +5665,12 @@ static uint32 enumprintmonitors_level_2(NEW_BUFFER *buffer, uint32 offered, uint
 /****************************************************************************
 ****************************************************************************/
 uint32 _spoolss_enumprintmonitors(UNISTR2 *name,uint32 level,
-                                   NEW_BUFFER *buffer, uint32 offered, 
+                                   NEW_BUFFER *buffer, uint32 offered,
                                    uint32 *needed, uint32 *returned)
 {
        DEBUG(5,("spoolss_enumprintmonitors\n"));
 
-       /* 
+       /*
         * Enumerate the print monitors ...
         *
         * Just reply with "Local Port", to keep NT happy
@@ -4660,13 +5683,10 @@ uint32 _spoolss_enumprintmonitors(UNISTR2 *name,uint32 level,
        switch (level) {
        case 1:
                return enumprintmonitors_level_1(buffer, offered, needed, returned);
-               break;          
        case 2:
                return enumprintmonitors_level_2(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -4760,8 +5780,7 @@ static uint32 getjob_level_2(print_queue_struct *queue, int count, int snum, uin
 
        new_smb_io_job_info_2("", buffer, info_2, 0);
 
-       free_dev_mode(info_2->devmode);
-       safe_free(info_2);
+       free_job_info_2(info_2);
 
        if (*needed > offered)
                return ERROR_INSUFFICIENT_BUFFER;
@@ -4772,7 +5791,7 @@ static uint32 getjob_level_2(print_queue_struct *queue, int count, int snum, uin
 /****************************************************************************
 ****************************************************************************/
 uint32 _spoolss_getjob( POLICY_HND *handle, uint32 jobid, uint32 level,
-                       NEW_BUFFER *buffer, uint32 offered, 
+                       NEW_BUFFER *buffer, uint32 offered,
                        uint32 *needed)
 {
        int snum;
@@ -4797,14 +5816,11 @@ uint32 _spoolss_getjob( POLICY_HND *handle, uint32 jobid, uint32 level,
        switch (level) {
        case 1:
                return getjob_level_1(queue, count, snum, jobid, buffer, offered, needed);
-               break;
        case 2:
                return getjob_level_2(queue, count, snum, jobid, buffer, offered, needed);
-               break;
        default:
                safe_free(queue);
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 #undef OLD_NTDOMAIN