Now that Volker fixed the real issues with ldapsam and adding null attributes
[ira/wip.git] / source3 / rpc_server / srv_samr_nt.c
index daa39b215fead53e43bcbc660c651c880ab6d733..7b2cd78dc63a61e630ec6f2f1de0131ededb40ee 100644 (file)
@@ -3,10 +3,12 @@
  *  RPC Pipe client / server routines
  *  Copyright (C) Andrew Tridgell              1992-1997,
  *  Copyright (C) Luke Kenneth Casson Leighton 1996-1997,
- *  Copyright (C) Paul Ashton                       1997.
- *  Copyright (C) Marc Jacobsen                            1999.
- *  Copyright (C) Jeremy Allison               2001-2002.
- *  Copyright (C) Jean François Micouleau      1998-2001.
+ *  Copyright (C) Paul Ashton                       1997,
+ *  Copyright (C) Marc Jacobsen                            1999,
+ *  Copyright (C) Jeremy Allison               2001-2002,
+ *  Copyright (C) Jean François Micouleau      1998-2001,
+ *  Copyright (C) Anthony Liguori                   2002,
+ *  Copyright (C) Jim McDonough                     2002.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -29,8 +31,9 @@
 
 #include "includes.h"
 
-extern fstring global_myworkgroup;
-extern pstring global_myname;
+#undef DBGC_CLASS
+#define DBGC_CLASS DBGC_RPC_SRV
+
 extern DOM_SID global_sid_Builtin;
 
 extern rid_name domain_group_rids[];
@@ -51,11 +54,71 @@ struct samr_info {
        /* for use by the \PIPE\samr policy */
        DOM_SID sid;
        uint32 status; /* some sort of flag.  best to record it.  comes from opnum 0x39 */
+       uint32 acc_granted;
+       uint16 acb_mask;
+       BOOL all_machines;
        DISP_INFO disp_info;
 
        TALLOC_CTX *mem_ctx;
 };
 
+struct generic_mapping sam_generic_mapping = {GENERIC_RIGHTS_SAM_READ, GENERIC_RIGHTS_SAM_WRITE, GENERIC_RIGHTS_SAM_EXECUTE, GENERIC_RIGHTS_SAM_ALL_ACCESS};
+struct generic_mapping dom_generic_mapping = {GENERIC_RIGHTS_DOMAIN_READ, GENERIC_RIGHTS_DOMAIN_WRITE, GENERIC_RIGHTS_DOMAIN_EXECUTE, GENERIC_RIGHTS_DOMAIN_ALL_ACCESS};
+struct generic_mapping usr_generic_mapping = {GENERIC_RIGHTS_USER_READ, GENERIC_RIGHTS_USER_WRITE, GENERIC_RIGHTS_USER_EXECUTE, GENERIC_RIGHTS_USER_ALL_ACCESS};
+struct generic_mapping grp_generic_mapping = {GENERIC_RIGHTS_GROUP_READ, GENERIC_RIGHTS_GROUP_WRITE, GENERIC_RIGHTS_GROUP_EXECUTE, GENERIC_RIGHTS_GROUP_ALL_ACCESS};
+struct generic_mapping ali_generic_mapping = {GENERIC_RIGHTS_ALIAS_READ, GENERIC_RIGHTS_ALIAS_WRITE, GENERIC_RIGHTS_ALIAS_EXECUTE, GENERIC_RIGHTS_ALIAS_ALL_ACCESS};
+
+static NTSTATUS samr_make_dom_obj_sd(TALLOC_CTX *ctx, SEC_DESC **psd, size_t *sd_size);
+
+/*******************************************************************
+ Checks if access to an object should be granted, and returns that
+ level of access for further checks.
+********************************************************************/
+
+NTSTATUS access_check_samr_object(SEC_DESC *psd, NT_USER_TOKEN *nt_user_token, uint32 des_access, 
+                                 uint32 *acc_granted, const char *debug) 
+{
+       NTSTATUS status = NT_STATUS_ACCESS_DENIED;
+
+       if (!se_access_check(psd, nt_user_token, des_access, acc_granted, &status)) {
+               *acc_granted = des_access;
+               if (geteuid() == sec_initial_uid()) {
+                       DEBUG(4,("%s: ACCESS should be DENIED  (requested: %#010x)\n",
+                               debug, des_access));
+                       DEBUGADD(4,("but overritten by euid == sec_initial_uid()\n"));
+                       status = NT_STATUS_OK;
+               }
+               else {
+                       DEBUG(2,("%s: ACCESS DENIED  (requested: %#010x)\n",
+                               debug, des_access));
+               }
+       }
+       return status;
+}
+
+/*******************************************************************
+ Checks if access to a function can be granted
+********************************************************************/
+
+NTSTATUS access_check_samr_function(uint32 acc_granted, uint32 acc_required, const char *debug)
+{
+       DEBUG(5,("%s: access check ((granted: %#010x;  required: %#010x)\n",
+                       debug, acc_granted, acc_required));
+       if ((acc_granted & acc_required) != acc_required) {
+               if (geteuid() == sec_initial_uid()) {
+                       DEBUG(4,("%s: ACCESS should be DENIED (granted: %#010x;  required: %#010x)\n",
+                               debug, acc_granted, acc_required));
+                       DEBUGADD(4,("but overwritten by euid == 0\n"));
+                       return NT_STATUS_OK;
+               }
+               DEBUG(2,("%s: ACCESS DENIED (granted: %#010x;  required: %#010x)\n",
+                       debug, acc_granted, acc_required));
+               return NT_STATUS_ACCESS_DENIED;
+       }
+       return NT_STATUS_OK;
+}
+
+
 /*******************************************************************
  Create a samr_info struct.
 ********************************************************************/
@@ -72,7 +135,7 @@ static struct samr_info *get_samr_info_by_sid(DOM_SID *psid)
                fstrcpy(sid_str,"(NULL)");
        }
 
-       mem_ctx = talloc_init_named("samr_info for domain sid %s", sid_str);
+       mem_ctx = talloc_init("samr_info for domain sid %s", sid_str);
 
        if ((info = (struct samr_info *)talloc(mem_ctx, sizeof(struct samr_info))) == NULL)
                return NULL;
@@ -88,26 +151,36 @@ static struct samr_info *get_samr_info_by_sid(DOM_SID *psid)
        return info;
 }
 
+
 /*******************************************************************
  Function to free the per handle data.
  ********************************************************************/
-static void free_samr_db(struct samr_info *info)
+static void free_samr_users(struct samr_info *info) 
 {
        int i;
 
-       /* Groups are talloced */
-
        if (info->disp_info.user_dbloaded){
                for (i=0; i<info->disp_info.num_user_account; i++) {
                        /* Not really a free, actually a 'clear' */
                        pdb_free_sam(&info->disp_info.disp_user_info[i].sam);
                }
        }
-
        info->disp_info.user_dbloaded=False;
+       info->disp_info.num_user_account=0;
+}
+
+
+/*******************************************************************
+ Function to free the per handle data.
+ ********************************************************************/
+static void free_samr_db(struct samr_info *info)
+{
+       /* Groups are talloced */
+
+       free_samr_users(info);
+
        info->disp_info.group_dbloaded=False;
        info->disp_info.num_group_account=0;
-       info->disp_info.num_user_account=0;
 }
 
 
@@ -123,19 +196,6 @@ static void free_samr_info(void *ptr)
  Ensure password info is never given out. Paranioa... JRA.
  ********************************************************************/
 
-static void samr_clear_passwd_fields( SAM_USER_INFO_21 *pass, int num_entries)
-{
-       int i;
-
-       if (!pass)
-               return;
-
-       for (i = 0; i < num_entries; i++) {
-               memset(&pass[i].lm_pwd, '\0', sizeof(pass[i].lm_pwd));
-               memset(&pass[i].nt_pwd, '\0', sizeof(pass[i].nt_pwd));
-       }
-}
-
 static void samr_clear_sam_passwd(SAM_ACCOUNT *sam_pass)
 {
        
@@ -144,12 +204,12 @@ static void samr_clear_sam_passwd(SAM_ACCOUNT *sam_pass)
 
        /* These now zero out the old password */
 
-       pdb_set_lanman_passwd(sam_pass, NULL);
-       pdb_set_nt_passwd(sam_pass, NULL);
+       pdb_set_lanman_passwd(sam_pass, NULL, PDB_DEFAULT);
+       pdb_set_nt_passwd(sam_pass, NULL, PDB_DEFAULT);
 }
 
 
-static NTSTATUS load_sampwd_entries(struct samr_info *info, uint16 acb_mask)
+static NTSTATUS load_sampwd_entries(struct samr_info *info, uint16 acb_mask, BOOL all_machines)
 {
        SAM_ACCOUNT *pwd = NULL;
        DISP_USER_INFO *pwd_array = NULL;
@@ -159,11 +219,15 @@ static NTSTATUS load_sampwd_entries(struct samr_info *info, uint16 acb_mask)
        DEBUG(10,("load_sampwd_entries\n"));
 
        /* if the snapshoot is already loaded, return */
-       if (info->disp_info.user_dbloaded==True) {
+       if ((info->disp_info.user_dbloaded==True) 
+           && (info->acb_mask == acb_mask) 
+           && (info->all_machines == all_machines)) {
                DEBUG(10,("load_sampwd_entries: already in memory\n"));
                return NT_STATUS_OK;
        }
 
+       free_samr_users(info);
+
        if (!pdb_setsampwent(False)) {
                DEBUG(0, ("load_sampwd_entries: Unable to open passdb.\n"));
                return NT_STATUS_ACCESS_DENIED;
@@ -172,10 +236,19 @@ static NTSTATUS load_sampwd_entries(struct samr_info *info, uint16 acb_mask)
        for (; (NT_STATUS_IS_OK(nt_status = pdb_init_sam_talloc(mem_ctx, &pwd))) 
                     && pdb_getsampwent(pwd) == True; pwd=NULL) {
                
-               if (acb_mask != 0 && !(pdb_get_acct_ctrl(pwd) & acb_mask)) {
-                       pdb_free_sam(&pwd);
-                       DEBUG(5,(" acb_mask %x reject\n", acb_mask));
-                       continue;
+               if (all_machines) {
+                       if (!((pdb_get_acct_ctrl(pwd) & ACB_WSTRUST) 
+                             || (pdb_get_acct_ctrl(pwd) & ACB_SVRTRUST))) {
+                               DEBUG(5,("load_sampwd_entries: '%s' is not a machine account - ACB: %x - skipping\n", pdb_get_username(pwd), acb_mask));
+                               pdb_free_sam(&pwd);
+                               continue;
+                       }
+               } else {
+                       if (acb_mask != 0 && !(pdb_get_acct_ctrl(pwd) & acb_mask)) {
+                               pdb_free_sam(&pwd);
+                               DEBUG(5,(" acb_mask %x reject\n", acb_mask));
+                               continue;
+                       }
                }
 
                /* Realloc some memory for the array of ptr to the SAM_ACCOUNT structs */
@@ -203,9 +276,11 @@ static NTSTATUS load_sampwd_entries(struct samr_info *info, uint16 acb_mask)
 
        /* the snapshoot is in memory, we're ready to enumerate fast */
 
+       info->acb_mask = acb_mask;
+       info->all_machines = all_machines;
        info->disp_info.user_dbloaded=True;
 
-       DEBUG(12,("load_sampwd_entries: done\n"));
+       DEBUG(10,("load_sampwd_entries: done\n"));
 
        return nt_status;
 }
@@ -225,16 +300,23 @@ static NTSTATUS load_group_domain_entries(struct samr_info *info, DOM_SID *sid)
                DEBUG(10,("load_group_domain_entries: already in memory\n"));
                return NT_STATUS_OK;
        }
+       
 
-       if (!enum_group_mapping(SID_NAME_DOM_GRP, &map, (int *)&group_entries, ENUM_ONLY_MAPPED, MAPPING_WITHOUT_PRIV)) {
+       become_root();
+
+       if (!pdb_enum_group_mapping(SID_NAME_DOM_GRP, &map, (int *)&group_entries, ENUM_ONLY_MAPPED, MAPPING_WITHOUT_PRIV)) {
+               DEBUG(1, ("load_group_domain_entries: pdb_enum_group_mapping() failed!\n"));
                return NT_STATUS_NO_MEMORY;
        }
+       
+       unbecome_root();
 
        info->disp_info.num_group_account=group_entries;
 
        grp_array=(DISP_GROUP_INFO *)talloc(mem_ctx, info->disp_info.num_group_account*sizeof(DISP_GROUP_INFO));
 
        if (group_entries!=0 && grp_array==NULL) {
+               DEBUG(1, ("load_group_domain_entries: talloc() failed for grp_array!\n"));
                SAFE_FREE(map);
                return NT_STATUS_NO_MEMORY;
        }
@@ -257,109 +339,12 @@ static NTSTATUS load_group_domain_entries(struct samr_info *info, DOM_SID *sid)
 
        info->disp_info.group_dbloaded=True;
 
-       DEBUG(12,("load_group_domain_entries: done\n"));
+       DEBUG(10,("load_group_domain_entries: done\n"));
 
        return NT_STATUS_OK;
 }
 
 
-/*******************************************************************
-  This next function should be replaced with something that
-  dynamically returns the correct user info..... JRA.
- ********************************************************************/
-
-static NTSTATUS get_sampwd_entries(SAM_USER_INFO_21 *pw_buf, int start_idx,
-                                int *total_entries, int *num_entries,
-                                int max_num_entries, uint16 acb_mask)
-{
-       SAM_ACCOUNT *pwd = NULL;
-       BOOL not_finished = True;
-       NTSTATUS nt_status;
-
-       (*num_entries) = 0;
-       (*total_entries) = 0;
-
-       if (pw_buf == NULL)
-               return NT_STATUS_NO_MEMORY;
-
-       if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam(&pwd))) {
-               return nt_status;
-       }
-
-       if (!pdb_setsampwent(False)) {
-               DEBUG(0, ("get_sampwd_entries: Unable to open passdb.\n"));
-               pdb_free_sam(&pwd);
-               return NT_STATUS_ACCESS_DENIED;
-       }
-       
-       while (((not_finished = pdb_getsampwent(pwd)) != False) 
-              && (*num_entries) < max_num_entries) 
-       {
-               int user_name_len;
-               const char *user_name;
-
-               if (start_idx > 0) {
-
-                       pdb_free_sam(&pwd);
-                       
-                       if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam(&pwd))) {
-                               pdb_endsampwent();
-                               return nt_status;
-                       }
-
-                       /* skip the requested number of entries.
-                          not very efficient, but hey...  */
-                       start_idx--;
-                       continue;
-               }
-               
-               user_name = pdb_get_username(pwd);
-
-               if (!user_name) {
-                       DEBUG(2, ("account had NULL username!\n"));
-               } else if (!(acb_mask == 0 || (pdb_get_acct_ctrl(pwd) & acb_mask))) {
-                       DEBUG(5,(" acb_mask %x rejects\n", acb_mask));
-               } else {
-                       DEBUG(5,(" acb_mask %x accepts\n", acb_mask));
-                       
-                       user_name_len = strlen(user_name)+1;
-                       init_unistr2(&pw_buf[(*num_entries)].uni_user_name, user_name, user_name_len);
-                       init_uni_hdr(&pw_buf[(*num_entries)].hdr_user_name, user_name_len);
-                       pw_buf[(*num_entries)].user_rid = pdb_get_user_rid(pwd);
-                       memset((char *)pw_buf[(*num_entries)].nt_pwd, '\0', 16);
-                       
-                       /* Now check if the NT compatible password is available. */
-                       if (pdb_get_nt_passwd(pwd))
-                               memcpy( pw_buf[(*num_entries)].nt_pwd , pdb_get_nt_passwd(pwd), 16);
-                       
-                       pw_buf[(*num_entries)].acb_info = pdb_get_acct_ctrl(pwd);
-                       
-                       DEBUG(5, ("entry idx: %d user %s, rid 0x%x, acb %x",
-                                 (*num_entries), pdb_get_username(pwd), pdb_get_user_rid(pwd), pdb_get_acct_ctrl(pwd) ));
-                       
-                       (*num_entries)++;
-               }
-
-               (*total_entries)++;
-               
-               pdb_free_sam(&pwd);
-
-               if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam(&pwd))) {
-                       pdb_endsampwent();
-                       return nt_status;
-               }
-
-       }
-       
-       pdb_endsampwent();
-       pdb_free_sam(&pwd);
-
-       if (not_finished)
-               return STATUS_MORE_ENTRIES;
-       else
-               return NT_STATUS_OK;
-}
-
 /*******************************************************************
  _samr_close_hnd
  ********************************************************************/
@@ -383,17 +368,37 @@ NTSTATUS _samr_close_hnd(pipes_struct *p, SAMR_Q_CLOSE_HND *q_u, SAMR_R_CLOSE_HN
 
 NTSTATUS _samr_open_domain(pipes_struct *p, SAMR_Q_OPEN_DOMAIN *q_u, SAMR_R_OPEN_DOMAIN *r_u)
 {
-       struct samr_info *info;
+       struct    samr_info *info;
+       SEC_DESC *psd = NULL;
+       uint32    acc_granted;
+       uint32    des_access = q_u->flags;
+       size_t    sd_size;
+       NTSTATUS  status;
 
        r_u->status = NT_STATUS_OK;
 
        /* find the connection policy handle. */
-       if (!find_policy_by_hnd(p, &q_u->pol, NULL))
+       if (!find_policy_by_hnd(p, &q_u->pol, (void**)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (!NT_STATUS_IS_OK(status = access_check_samr_function(info->acc_granted, SA_RIGHT_SAM_OPEN_DOMAIN,"_samr_open_domain"))) {
+               return status;
+       }
+
+       /*check if access can be granted as requested by client. */
+       samr_make_dom_obj_sd(p->mem_ctx, &psd, &sd_size);
+       se_map_generic(&des_access,&dom_generic_mapping);
+
+       if (!NT_STATUS_IS_OK(status = 
+                            access_check_samr_object(psd, p->pipe_user.nt_user_token, 
+                                                     des_access, &acc_granted, "_samr_open_domain"))) {
+               return status;
+       }
+
        /* associate the domain SID with the (unique) handle. */
        if ((info = get_samr_info_by_sid(&q_u->dom_sid.sid))==NULL)
                return NT_STATUS_NO_MEMORY;
+       info->acc_granted = acc_granted;
 
        /* get a (unique) handle.  open a policy on it. */
        if (!create_policy_hnd(p, &r_u->domain_pol, free_samr_info, (void *)info))
@@ -433,11 +438,50 @@ NTSTATUS _samr_get_usrdom_pwinfo(pipes_struct *p, SAMR_Q_GET_USRDOM_PWINFO *q_u,
        return r_u->status;
 }
 
+/*******************************************************************
+ samr_make_dom_obj_sd
+ ********************************************************************/
+
+static NTSTATUS samr_make_dom_obj_sd(TALLOC_CTX *ctx, SEC_DESC **psd, size_t *sd_size)
+{
+       extern DOM_SID global_sid_World;
+       DOM_SID adm_sid;
+       DOM_SID act_sid;
+
+       SEC_ACE ace[3];
+       SEC_ACCESS mask;
+
+       SEC_ACL *psa = NULL;
+
+       sid_copy(&adm_sid, &global_sid_Builtin);
+       sid_append_rid(&adm_sid, BUILTIN_ALIAS_RID_ADMINS);
+
+       sid_copy(&act_sid, &global_sid_Builtin);
+       sid_append_rid(&act_sid, BUILTIN_ALIAS_RID_ACCOUNT_OPS);
+
+       /*basic access for every one*/
+       init_sec_access(&mask, GENERIC_RIGHTS_DOMAIN_EXECUTE | GENERIC_RIGHTS_DOMAIN_READ);
+       init_sec_ace(&ace[0], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+
+       /*full access for builtin aliases Administrators and Account Operators*/
+       init_sec_access(&mask, GENERIC_RIGHTS_DOMAIN_ALL_ACCESS);
+       init_sec_ace(&ace[1], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+       init_sec_ace(&ace[2], &act_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+
+       if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, 3, ace)) == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       if ((*psd = make_sec_desc(ctx, SEC_DESC_REVISION, NULL, NULL, NULL, psa, sd_size)) == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       return NT_STATUS_OK;
+}
+
 /*******************************************************************
  samr_make_usr_obj_sd
  ********************************************************************/
 
-static NTSTATUS samr_make_usr_obj_sd(TALLOC_CTX *ctx, SEC_DESC_BUF **buf, DOM_SID *usr_sid)
+static NTSTATUS samr_make_usr_obj_sd(TALLOC_CTX *ctx, SEC_DESC **psd, size_t *sd_size, DOM_SID *usr_sid)
 {
        extern DOM_SID global_sid_World;
        DOM_SID adm_sid;
@@ -447,8 +491,6 @@ static NTSTATUS samr_make_usr_obj_sd(TALLOC_CTX *ctx, SEC_DESC_BUF **buf, DOM_SI
        SEC_ACCESS mask;
 
        SEC_ACL *psa = NULL;
-       SEC_DESC *psd = NULL;
-       size_t sd_size;
 
        sid_copy(&adm_sid, &global_sid_Builtin);
        sid_append_rid(&adm_sid, BUILTIN_ALIAS_RID_ADMINS);
@@ -456,29 +498,107 @@ static NTSTATUS samr_make_usr_obj_sd(TALLOC_CTX *ctx, SEC_DESC_BUF **buf, DOM_SI
        sid_copy(&act_sid, &global_sid_Builtin);
        sid_append_rid(&act_sid, BUILTIN_ALIAS_RID_ACCOUNT_OPS);
 
-       init_sec_access(&mask, 0x2035b);
+       /*basic access for every one*/
+       init_sec_access(&mask, GENERIC_RIGHTS_USER_EXECUTE | GENERIC_RIGHTS_USER_READ);
        init_sec_ace(&ace[0], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
 
-       init_sec_access(&mask, 0xf07ff);
+       /*full access for builtin aliases Administrators and Account Operators*/
+       init_sec_access(&mask, GENERIC_RIGHTS_USER_ALL_ACCESS);
        init_sec_ace(&ace[1], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
        init_sec_ace(&ace[2], &act_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
 
-       init_sec_access(&mask,0x20044);
+       /*extended access for the user*/
+       init_sec_access(&mask,READ_CONTROL_ACCESS | SA_RIGHT_USER_CHANGE_PASSWORD | SA_RIGHT_USER_SET_LOC_COM);
        init_sec_ace(&ace[3], usr_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
 
-       if((psa = make_sec_acl(ctx, NT4_ACL_REVISION, 4, ace)) == NULL)
+       if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, 4, ace)) == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       if ((*psd = make_sec_desc(ctx, SEC_DESC_REVISION, NULL, NULL, NULL, psa, sd_size)) == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       return NT_STATUS_OK;
+}
+
+/*******************************************************************
+ samr_make_grp_obj_sd
+ ********************************************************************/
+
+static NTSTATUS samr_make_grp_obj_sd(TALLOC_CTX *ctx, SEC_DESC **psd, size_t *sd_size)
+{
+       extern DOM_SID global_sid_World;
+       DOM_SID adm_sid;
+       DOM_SID act_sid;
+
+       SEC_ACE ace[3];
+       SEC_ACCESS mask;
+
+       SEC_ACL *psa = NULL;
+
+       sid_copy(&adm_sid, &global_sid_Builtin);
+       sid_append_rid(&adm_sid, BUILTIN_ALIAS_RID_ADMINS);
+
+       sid_copy(&act_sid, &global_sid_Builtin);
+       sid_append_rid(&act_sid, BUILTIN_ALIAS_RID_ACCOUNT_OPS);
+
+       /*basic access for every one*/
+       init_sec_access(&mask, GENERIC_RIGHTS_GROUP_EXECUTE | GENERIC_RIGHTS_GROUP_READ);
+       init_sec_ace(&ace[0], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+
+       /*full access for builtin aliases Administrators and Account Operators*/
+       init_sec_access(&mask, GENERIC_RIGHTS_GROUP_ALL_ACCESS);
+       init_sec_ace(&ace[1], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+       init_sec_ace(&ace[2], &act_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+
+       if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, 3, ace)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
-       if((psd = make_sec_desc(ctx, SEC_DESC_REVISION, NULL, NULL, NULL, psa, &sd_size)) == NULL)
+       if ((*psd = make_sec_desc(ctx, SEC_DESC_REVISION, NULL, NULL, NULL, psa, sd_size)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
-       if((*buf = make_sec_desc_buf(ctx, sd_size, psd)) == NULL)
+       return NT_STATUS_OK;
+}
+
+/*******************************************************************
+ samr_make_ali_obj_sd
+ ********************************************************************/
+
+static NTSTATUS samr_make_ali_obj_sd(TALLOC_CTX *ctx, SEC_DESC **psd, size_t *sd_size)
+{
+       extern DOM_SID global_sid_World;
+       DOM_SID adm_sid;
+       DOM_SID act_sid;
+
+       SEC_ACE ace[3];
+       SEC_ACCESS mask;
+
+       SEC_ACL *psa = NULL;
+
+       sid_copy(&adm_sid, &global_sid_Builtin);
+       sid_append_rid(&adm_sid, BUILTIN_ALIAS_RID_ADMINS);
+
+       sid_copy(&act_sid, &global_sid_Builtin);
+       sid_append_rid(&act_sid, BUILTIN_ALIAS_RID_ACCOUNT_OPS);
+
+       /*basic access for every one*/
+       init_sec_access(&mask, GENERIC_RIGHTS_ALIAS_EXECUTE | GENERIC_RIGHTS_ALIAS_READ);
+       init_sec_ace(&ace[0], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+
+       /*full access for builtin aliases Administrators and Account Operators*/
+       init_sec_access(&mask, GENERIC_RIGHTS_ALIAS_ALL_ACCESS);
+       init_sec_ace(&ace[1], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+       init_sec_ace(&ace[2], &act_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, mask, 0);
+
+       if ((psa = make_sec_acl(ctx, NT4_ACL_REVISION, 3, ace)) == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       if ((*psd = make_sec_desc(ctx, SEC_DESC_REVISION, NULL, NULL, NULL, psa, sd_size)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
        return NT_STATUS_OK;
 }
 
-static BOOL get_lsa_policy_samr_sid(pipes_struct *p, POLICY_HND *pol, DOM_SID *sid)
+static BOOL get_lsa_policy_samr_sid(pipes_struct *p, POLICY_HND *pol, DOM_SID *sid, uint32 *acc_granted)
 {
        struct samr_info *info = NULL;
 
@@ -490,9 +610,21 @@ static BOOL get_lsa_policy_samr_sid(pipes_struct *p, POLICY_HND *pol, DOM_SID *s
                return False;
 
        *sid = info->sid;
+       *acc_granted = info->acc_granted;
        return True;
 }
 
+/*******************************************************************
+ _samr_set_sec_obj
+ ********************************************************************/
+
+NTSTATUS _samr_set_sec_obj(pipes_struct *p, SAMR_Q_SET_SEC_OBJ *q_u, SAMR_R_SET_SEC_OBJ *r_u)
+{
+       DEBUG(0,("_samr_set_sec_obj: Not yet implemented!\n"));
+       return NT_STATUS_NOT_IMPLEMENTED;
+}
+
+
 /*******************************************************************
  _samr_query_sec_obj
  ********************************************************************/
@@ -501,17 +633,52 @@ NTSTATUS _samr_query_sec_obj(pipes_struct *p, SAMR_Q_QUERY_SEC_OBJ *q_u, SAMR_R_
 {
        DOM_SID pol_sid;
        fstring str_sid;
+       SEC_DESC * psd = NULL;
+       size_t sd_size;
+       uint32 acc_granted;
 
        r_u->status = NT_STATUS_OK;
 
        /* Get the SID. */
-
-       if (!get_lsa_policy_samr_sid(p, &q_u->user_pol, &pol_sid))
+       if (!get_lsa_policy_samr_sid(p, &q_u->user_pol, &pol_sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
 
+
+
        DEBUG(10,("_samr_query_sec_obj: querying security on SID: %s\n", sid_to_string(str_sid, &pol_sid)));
 
-       r_u->status = samr_make_usr_obj_sd(p->mem_ctx, &r_u->buf, &pol_sid);
+       /* Check what typ of SID is beeing queried (e.g Domain SID, User SID, Group SID) */
+
+       /* To query the security of the SAM it self an invalid SID with S-0-0 is passed to this function */
+       if (pol_sid.sid_rev_num == 0)
+       {
+               DEBUG(5,("_samr_query_sec_obj: querying security on SAM\n"));
+               r_u->status = samr_make_sam_obj_sd(p->mem_ctx, &psd, &sd_size);
+       }
+       else if (sid_equal(&pol_sid,get_global_sam_sid()))  /* check if it is our domain SID */
+
+       {
+               DEBUG(5,("_samr_query_sec_obj: querying security on Domain with SID: %s\n", sid_to_string(str_sid, &pol_sid)));
+               r_u->status = samr_make_dom_obj_sd(p->mem_ctx, &psd, &sd_size);
+       }
+       else if (sid_equal(&pol_sid,&global_sid_Builtin)) /* check if it is the Builtin  Domain */
+       {
+               /* TODO: Builtin probably needs a different SD with restricted write access*/
+               DEBUG(5,("_samr_query_sec_obj: querying security on Builtin Domain with SID: %s\n", sid_to_string(str_sid, &pol_sid)));
+               r_u->status = samr_make_dom_obj_sd(p->mem_ctx, &psd, &sd_size);
+       }
+       else if (sid_check_is_in_our_domain(&pol_sid) ||
+                sid_check_is_in_builtin(&pol_sid))
+       {
+               /* TODO: different SDs have to be generated for aliases groups and users.
+                        Currently all three get a default user SD  */
+               DEBUG(10,("_samr_query_sec_obj: querying security on Object with SID: %s\n", sid_to_string(str_sid, &pol_sid)));
+               r_u->status = samr_make_usr_obj_sd(p->mem_ctx, &psd,&sd_size, &pol_sid);
+       }
+       else return NT_STATUS_OBJECT_TYPE_MISMATCH;
+
+       if ((r_u->buf = make_sec_desc_buf(p->mem_ctx, sd_size, psd)) == NULL)
+               return NT_STATUS_NO_MEMORY;
 
        if (NT_STATUS_IS_OK(r_u->status))
                r_u->ptr = 1;
@@ -523,69 +690,121 @@ NTSTATUS _samr_query_sec_obj(pipes_struct *p, SAMR_Q_QUERY_SEC_OBJ *q_u, SAMR_R_
 makes a SAM_ENTRY / UNISTR2* structure from a user list.
 ********************************************************************/
 
-static void make_user_sam_entry_list(TALLOC_CTX *ctx, SAM_ENTRY **sam_pp, UNISTR2 **uni_name_pp,
-                uint32 num_sam_entries, SAM_USER_INFO_21 *pass)
+static NTSTATUS make_user_sam_entry_list(TALLOC_CTX *ctx, SAM_ENTRY **sam_pp, UNISTR2 **uni_name_pp,
+                                        uint32 num_entries, uint32 start_idx, DISP_USER_INFO *disp_user_info,
+                                        DOM_SID *domain_sid)
 {
        uint32 i;
        SAM_ENTRY *sam;
        UNISTR2 *uni_name;
-
+       SAM_ACCOUNT *pwd = NULL;
+       UNISTR2 uni_temp_name;
+       const char *temp_name;
+       const DOM_SID *user_sid;
+       uint32 user_rid;
+       fstring user_sid_string;
+       fstring domain_sid_string;
+       
        *sam_pp = NULL;
        *uni_name_pp = NULL;
 
-       if (num_sam_entries == 0)
-               return;
+       if (num_entries == 0)
+               return NT_STATUS_OK;
 
-       sam = (SAM_ENTRY *)talloc_zero(ctx, sizeof(SAM_ENTRY)*num_sam_entries);
+       sam = (SAM_ENTRY *)talloc_zero(ctx, sizeof(SAM_ENTRY)*num_entries);
 
-       uni_name = (UNISTR2 *)talloc_zero(ctx, sizeof(UNISTR2)*num_sam_entries);
+       uni_name = (UNISTR2 *)talloc_zero(ctx, sizeof(UNISTR2)*num_entries);
 
        if (sam == NULL || uni_name == NULL) {
-               DEBUG(0, ("NULL pointers in SAMR_R_QUERY_DISPINFO\n"));
-               return;
+               DEBUG(0, ("make_user_sam_entry_list: talloc_zero failed!\n"));
+               return NT_STATUS_NO_MEMORY;
        }
 
-       ZERO_STRUCTP(sam);
-       ZERO_STRUCTP(uni_name);
-
-       for (i = 0; i < num_sam_entries; i++) {
-               int len = pass[i].uni_user_name.uni_str_len;
+       for (i = 0; i < num_entries; i++) {
+               pwd = disp_user_info[i+start_idx].sam;
+               temp_name = pdb_get_username(pwd);
+               init_unistr2(&uni_temp_name, temp_name, strlen(temp_name)+1);
+               user_sid = pdb_get_user_sid(pwd);
+
+               if (!sid_peek_check_rid(domain_sid, user_sid, &user_rid)) {
+                       DEBUG(0, ("make_user_sam_entry_list: User %s has SID %s, which conflicts with "
+                                 "the domain sid %s.  Failing operation.\n", 
+                                 temp_name, 
+                                 sid_to_string(user_sid_string, user_sid),
+                                 sid_to_string(domain_sid_string, domain_sid)));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
 
-               init_sam_entry(&sam[i], len, pass[i].user_rid);
-               copy_unistr2(&uni_name[i], &pass[i].uni_user_name);
+               init_sam_entry(&sam[i], uni_temp_name.uni_str_len, user_rid);
+               copy_unistr2(&uni_name[i], &uni_temp_name);
        }
 
        *sam_pp = sam;
        *uni_name_pp = uni_name;
+       return NT_STATUS_OK;
 }
 
 /*******************************************************************
  samr_reply_enum_dom_users
  ********************************************************************/
 
-NTSTATUS _samr_enum_dom_users(pipes_struct *p, SAMR_Q_ENUM_DOM_USERS *q_u, SAMR_R_ENUM_DOM_USERS *r_u)
+NTSTATUS _samr_enum_dom_users(pipes_struct *p, SAMR_Q_ENUM_DOM_USERS *q_u, 
+                             SAMR_R_ENUM_DOM_USERS *r_u)
 {
-       SAM_USER_INFO_21 pass[MAX_SAM_ENTRIES];
-       int num_entries = 0;
-       int total_entries = 0;
+       struct samr_info *info = NULL;
+       uint32 struct_size=0x20; /* W2K always reply that, client doesn't care */
+       int num_account;
+       uint32 enum_context=q_u->start_idx;
+       uint32 max_size=q_u->max_size;
+       uint32 temp_size;
+       enum remote_arch_types ra_type = get_remote_arch();
+       int max_sam_entries = (ra_type == RA_WIN95) ? MAX_SAM_ENTRIES_W95 : MAX_SAM_ENTRIES_W2K;
+       uint32 max_entries = max_sam_entries;
+       DOM_SID domain_sid;
        
        r_u->status = NT_STATUS_OK;
 
        /* find the policy handle.  open a policy on it. */
-       if (!find_policy_by_hnd(p, &q_u->pol, NULL))
+       if (!find_policy_by_hnd(p, &q_u->pol, (void **)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       domain_sid = info->sid;
+
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(info->acc_granted, 
+                                       SA_RIGHT_DOMAIN_ENUM_ACCOUNTS, 
+                                       "_samr_enum_dom_users"))) {
+               return r_u->status;
+       }
+       
        DEBUG(5,("_samr_enum_dom_users: %d\n", __LINE__));
 
        become_root();
-       r_u->status = get_sampwd_entries(pass, q_u->start_idx, &total_entries, &num_entries,
-                                                               MAX_SAM_ENTRIES, q_u->acb_mask);
+       r_u->status=load_sampwd_entries(info, q_u->acb_mask, False);
        unbecome_root();
-
-       if (NT_STATUS_IS_ERR(r_u->status))
+       
+       if (!NT_STATUS_IS_OK(r_u->status))
                return r_u->status;
 
-       samr_clear_passwd_fields(pass, num_entries);
+       num_account = info->disp_info.num_user_account;
+
+       if (enum_context > num_account) {
+               DEBUG(5, ("_samr_enum_dom_users: enumeration handle over total entries\n"));
+               return NT_STATUS_OK;
+       }
+
+       /* verify we won't overflow */
+       if (max_entries > num_account-enum_context) {
+               max_entries = num_account-enum_context;
+               DEBUG(5, ("_samr_enum_dom_users: only %d entries to return\n", max_entries));
+       }
+
+       /* calculate the size and limit on the number of entries we will return */
+       temp_size=max_entries*struct_size;
+       
+       if (temp_size>max_size) {
+               max_entries=MIN((max_size/struct_size),max_entries);;
+               DEBUG(5, ("_samr_enum_dom_users: buffer size limits to only %d entries\n", max_entries));
+       }
 
        /* 
         * Note from JRA. total_entries is not being used here. Currently if there is a
@@ -600,9 +819,20 @@ NTSTATUS _samr_enum_dom_users(pipes_struct *p, SAMR_Q_ENUM_DOM_USERS *q_u, SAMR_
         * value (again I think this is wrong).
         */
 
-       make_user_sam_entry_list(p->mem_ctx, &r_u->sam, &r_u->uni_acct_name, num_entries, pass);
+       r_u->status = make_user_sam_entry_list(p->mem_ctx, &r_u->sam, &r_u->uni_acct_name, 
+                                              max_entries, enum_context, 
+                                              info->disp_info.disp_user_info,
+                                              &domain_sid);
+
+       if (!NT_STATUS_IS_OK(r_u->status))
+               return r_u->status;
 
-       init_samr_r_enum_dom_users(r_u, q_u->start_idx + num_entries, num_entries);
+       if (enum_context+max_entries < num_account)
+               r_u->status = STATUS_MORE_ENTRIES;
+
+       DEBUG(5, ("_samr_enum_dom_users: %d\n", __LINE__));
+
+       init_samr_r_enum_dom_users(r_u, q_u->start_idx + max_entries, max_entries);
 
        DEBUG(5,("_samr_enum_dom_users: %d\n", __LINE__));
 
@@ -660,7 +890,7 @@ static NTSTATUS get_group_alias_entries(TALLOC_CTX *ctx, DOMAIN_GRP **d_grp, DOM
        uint32 num_entries = 0;
        int i;
        GROUP_MAP smap;
-       GROUP_MAP *map;
+       GROUP_MAP *map = NULL;
 
        sid_to_string(sid_str, sid);
        DEBUG(5, ("get_group_alias_entries: enumerating aliases on SID: %s\n", sid_str));
@@ -670,7 +900,7 @@ static NTSTATUS get_group_alias_entries(TALLOC_CTX *ctx, DOMAIN_GRP **d_grp, DOM
        /* well-known aliases */
        if (sid_equal(sid, &global_sid_Builtin) && !lp_hide_local_users()) {
                
-               enum_group_mapping(SID_NAME_ALIAS, &map, (int *)&num_entries, ENUM_ONLY_MAPPED, MAPPING_WITHOUT_PRIV);
+               pdb_enum_group_mapping(SID_NAME_WKN_GRP, &map, (int *)&num_entries, ENUM_ONLY_MAPPED, MAPPING_WITHOUT_PRIV);
                
                if (num_entries != 0) {         
                        *d_grp=(DOMAIN_GRP *)talloc_zero(ctx, num_entries*sizeof(DOMAIN_GRP));
@@ -707,7 +937,7 @@ static NTSTATUS get_group_alias_entries(TALLOC_CTX *ctx, DOMAIN_GRP **d_grp, DOM
                for (; (num_entries < max_entries) && (grp != NULL); grp = grp->next) {
                        uint32 trid;
                        
-                       if(!get_group_from_gid(grp->gr_gid, &smap, MAPPING_WITHOUT_PRIV))
+                       if(!pdb_getgrgid(&smap, grp->gr_gid, MAPPING_WITHOUT_PRIV))
                                continue;
                        
                        if (smap.sid_name_use!=SID_NAME_ALIAS) {
@@ -788,7 +1018,7 @@ static NTSTATUS get_group_domain_entries(TALLOC_CTX *ctx, DOMAIN_GRP **d_grp, DO
 
        *p_num_entries = 0;
 
-       enum_group_mapping(SID_NAME_DOM_GRP, &map, (int *)&group_entries, ENUM_ONLY_MAPPED, MAPPING_WITHOUT_PRIV);
+       pdb_enum_group_mapping(SID_NAME_DOM_GRP, &map, (int *)&group_entries, ENUM_ONLY_MAPPED, MAPPING_WITHOUT_PRIV);
 
        num_entries=group_entries-start_idx;
 
@@ -820,8 +1050,6 @@ static NTSTATUS get_group_domain_entries(TALLOC_CTX *ctx, DOMAIN_GRP **d_grp, DO
 
 /*******************************************************************
  samr_reply_enum_dom_groups
- Only reply with one group - domain admins. This must be fixed for
- a real PDC. JRA.
  ********************************************************************/
 
 NTSTATUS _samr_enum_dom_groups(pipes_struct *p, SAMR_Q_ENUM_DOM_GROUPS *q_u, SAMR_R_ENUM_DOM_GROUPS *r_u)
@@ -829,16 +1057,23 @@ NTSTATUS _samr_enum_dom_groups(pipes_struct *p, SAMR_Q_ENUM_DOM_GROUPS *q_u, SAM
        DOMAIN_GRP *grp=NULL;
        uint32 num_entries;
        DOM_SID sid;
+       uint32 acc_granted;
 
        r_u->status = NT_STATUS_OK;
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &sid))
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
+               
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_ENUM_ACCOUNTS, "_samr_enum_dom_groups"))) {
+               return r_u->status;
+       }
 
        DEBUG(5,("samr_reply_enum_dom_groups: %d\n", __LINE__));
 
        /* the domain group array is being allocated in the function below */
-       get_group_domain_entries(p->mem_ctx, &grp, &sid, q_u->start_idx, &num_entries, MAX_SAM_ENTRIES);
+       if (!NT_STATUS_IS_OK(r_u->status = get_group_domain_entries(p->mem_ctx, &grp, &sid, q_u->start_idx, &num_entries, MAX_SAM_ENTRIES))) {
+               return r_u->status;
+       }
 
        make_group_sam_entry_list(p->mem_ctx, &r_u->sam, &r_u->uni_grp_name, num_entries, grp);
 
@@ -861,12 +1096,17 @@ NTSTATUS _samr_enum_dom_aliases(pipes_struct *p, SAMR_Q_ENUM_DOM_ALIASES *q_u, S
        fstring sid_str;
        DOM_SID sid;
        NTSTATUS status;
+       uint32  acc_granted;
        
        r_u->status = NT_STATUS_OK;
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &sid))
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_ENUM_ACCOUNTS, "_samr_enum_dom_aliases"))) {
+               return r_u->status;
+       }
+       
        sid_to_string(sid_str, &sid);
        DEBUG(5,("samr_reply_enum_dom_aliases: sid %s\n", sid_str));
 
@@ -888,11 +1128,11 @@ NTSTATUS _samr_enum_dom_aliases(pipes_struct *p, SAMR_Q_ENUM_DOM_ALIASES *q_u, S
 /*******************************************************************
  samr_reply_query_dispinfo
  ********************************************************************/
-NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_R_QUERY_DISPINFO *r_u)
+NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, 
+                             SAMR_R_QUERY_DISPINFO *r_u)
 {
        struct samr_info *info = NULL;
        uint32 struct_size=0x20; /* W2K always reply that, client doesn't care */
-       uint16 acb_mask;
        
        uint32 max_entries=q_u->max_entries;
        uint32 enum_context=q_u->start_idx;
@@ -903,9 +1143,8 @@ NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_
        NTSTATUS disp_ret;
        uint32 num_account = 0;
        enum remote_arch_types ra_type = get_remote_arch();
-       int max_sam_entries;
-
-       max_sam_entries = (ra_type == RA_WIN95) ? MAX_SAM_ENTRIES_W95 : MAX_SAM_ENTRIES_W2K;
+       int max_sam_entries = (ra_type == RA_WIN95) ? MAX_SAM_ENTRIES_W95 : MAX_SAM_ENTRIES_W2K;
+       DOM_SID domain_sid;
 
        DEBUG(5, ("samr_reply_query_dispinfo: %d\n", __LINE__));
        r_u->status = NT_STATUS_OK;
@@ -914,6 +1153,8 @@ NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_
        if (!find_policy_by_hnd(p, &q_u->domain_pol, (void **)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       domain_sid = info->sid;
+
        /*
         * calculate how many entries we will return.
         * based on 
@@ -942,20 +1183,26 @@ NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_
         * JFM, 12/20/2001
         */
 
-       /* Get what we need from the password database */
-
-       if (q_u->switch_level==2)
-               acb_mask = ACB_WSTRUST;
-       else
-               acb_mask = ACB_NORMAL;
-
        /* Get what we need from the password database */
        switch (q_u->switch_level) {
                case 0x1:
+                       /* When playing with usrmgr, this is necessary
+                           if you want immediate refresh after editing
+                           a user. I would like to do this after the
+                           setuserinfo2, but we do not have access to
+                           the domain handle in that call, only to the
+                           user handle. Where else does this hurt?
+                          -- Volker
+                       */
+#if 0
+                       /* We cannot do this here - it kills performace. JRA. */
+                       free_samr_users(info);
+#endif
                case 0x2:
                case 0x4:
                        become_root();          
-                       r_u->status=load_sampwd_entries(info, acb_mask);
+                       /* Level 2 is for all machines, otherwise only 'normal' users */
+                       r_u->status=load_sampwd_entries(info, ACB_NORMAL, q_u->switch_level==2);
                        unbecome_root();
                        if (!NT_STATUS_IS_OK(r_u->status)) {
                                DEBUG(5, ("_samr_query_dispinfo: load_sampwd_entries failed\n"));
@@ -983,7 +1230,7 @@ NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_
 
        if (enum_context > num_account) {
                DEBUG(5, ("samr_reply_query_dispinfo: enumeration handle over total entries\n"));
-               return NT_STATUS_OK;
+               return NT_STATUS_NO_MORE_ENTRIES;
        }
 
        /* verify we won't overflow */
@@ -1012,7 +1259,8 @@ NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_
                        if (!(ctr->sam.info1 = (SAM_DISPINFO_1 *)talloc_zero(p->mem_ctx,max_entries*sizeof(SAM_DISPINFO_1))))
                                return NT_STATUS_NO_MEMORY;
                }
-               disp_ret = init_sam_dispinfo_1(p->mem_ctx, ctr->sam.info1, max_entries, enum_context, info->disp_info.disp_user_info);
+               disp_ret = init_sam_dispinfo_1(p->mem_ctx, ctr->sam.info1, max_entries, enum_context, 
+                                              info->disp_info.disp_user_info, &domain_sid);
                if (!NT_STATUS_IS_OK(disp_ret))
                        return disp_ret;
                break;
@@ -1021,7 +1269,8 @@ NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_
                        if (!(ctr->sam.info2 = (SAM_DISPINFO_2 *)talloc_zero(p->mem_ctx,max_entries*sizeof(SAM_DISPINFO_2))))
                                return NT_STATUS_NO_MEMORY;
                }
-               disp_ret = init_sam_dispinfo_2(p->mem_ctx, ctr->sam.info2, max_entries, enum_context, info->disp_info.disp_user_info);
+               disp_ret = init_sam_dispinfo_2(p->mem_ctx, ctr->sam.info2, max_entries, enum_context, 
+                                              info->disp_info.disp_user_info, &domain_sid);
                if (!NT_STATUS_IS_OK(disp_ret))
                        return disp_ret;
                break;
@@ -1078,22 +1327,26 @@ NTSTATUS _samr_query_dispinfo(pipes_struct *p, SAMR_Q_QUERY_DISPINFO *q_u, SAMR_
 
 NTSTATUS _samr_query_aliasinfo(pipes_struct *p, SAMR_Q_QUERY_ALIASINFO *q_u, SAMR_R_QUERY_ALIASINFO *r_u)
 {
-       struct samr_info *info = NULL;
+       DOM_SID   sid;
        GROUP_MAP map;
+       uint32    acc_granted;
 
        r_u->status = NT_STATUS_OK;
 
        DEBUG(5,("_samr_query_aliasinfo: %d\n", __LINE__));
 
        /* find the policy handle.  open a policy on it. */
-       if (!find_policy_by_hnd(p, &q_u->pol, (void **)&info))
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_ALIAS_LOOKUP_INFO, "_samr_query_aliasinfo"))) {
+               return r_u->status;
+       }
 
-       if (!sid_check_is_in_our_domain(&info->sid) &&
-           !sid_check_is_in_builtin(&info->sid))
+       if (!sid_check_is_in_our_domain(&sid) &&
+           !sid_check_is_in_builtin(&sid))
                return NT_STATUS_OBJECT_TYPE_MISMATCH;
 
-       if(!get_local_group_from_sid(info->sid, &map, MAPPING_WITHOUT_PRIV))
+       if (!pdb_getgrsid(&map, sid, MAPPING_WITHOUT_PRIV))
                return NT_STATUS_NO_SUCH_ALIAS;
 
        switch (q_u->switch_level) {
@@ -1190,6 +1443,7 @@ NTSTATUS _samr_lookup_names(pipes_struct *p, SAMR_Q_LOOKUP_NAMES *q_u, SAMR_R_LO
        int num_rids = q_u->num_names2;
        DOM_SID pol_sid;
        fstring sid_str;
+       uint32  acc_granted;
 
        r_u->status = NT_STATUS_OK;
 
@@ -1198,10 +1452,14 @@ NTSTATUS _samr_lookup_names(pipes_struct *p, SAMR_Q_LOOKUP_NAMES *q_u, SAMR_R_LO
        ZERO_ARRAY(rid);
        ZERO_ARRAY(type);
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &pol_sid)) {
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &pol_sid, &acc_granted)) {
                init_samr_r_lookup_names(p->mem_ctx, r_u, 0, NULL, NULL, NT_STATUS_OBJECT_TYPE_MISMATCH);
                return r_u->status;
        }
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, 0, "_samr_lookup_names"))) { /* Don't know the acc_bits yet */
+               return r_u->status;
+       }
 
        if (num_rids > MAX_SAM_ENTRIES) {
                num_rids = MAX_SAM_ENTRIES;
@@ -1284,9 +1542,8 @@ NTSTATUS _samr_chgpasswd_user(pipes_struct *p, SAMR_Q_CHGPASSWD_USER *q_u, SAMR_
         * is case insensitive.
         */
 
-    if (!pass_oem_change(user_name, q_u->lm_newpass.pass, q_u->lm_oldhash.hash,
-                         q_u->nt_newpass.pass, q_u->nt_oldhash.hash))
-        r_u->status = NT_STATUS_WRONG_PASSWORD;
+    r_u->status = pass_oem_change(user_name, q_u->lm_newpass.pass, q_u->lm_oldhash.hash,
+                                 q_u->nt_newpass.pass, q_u->nt_oldhash.hash);
 
     init_samr_r_chgpasswd_user(r_u, r_u->status);
 
@@ -1345,13 +1602,14 @@ NTSTATUS _samr_lookup_rids(pipes_struct *p, SAMR_Q_LOOKUP_RIDS *q_u, SAMR_R_LOOK
        DOM_SID pol_sid;
        int num_rids = q_u->num_rids1;
        int i;
+       uint32 acc_granted;
 
        r_u->status = NT_STATUS_OK;
 
        DEBUG(5,("_samr_lookup_rids: %d\n", __LINE__));
 
        /* find the policy handle.  open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &pol_sid))
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &pol_sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
 
        if (num_rids > MAX_SAM_ENTRIES) {
@@ -1413,27 +1671,40 @@ NTSTATUS _api_samr_open_user(pipes_struct *p, SAMR_Q_OPEN_USER *q_u, SAMR_R_OPEN
        POLICY_HND domain_pol = q_u->domain_pol;
        POLICY_HND *user_pol = &r_u->user_pol;
        struct samr_info *info = NULL;
+       SEC_DESC *psd = NULL;
+       uint32    acc_granted;
+       uint32    des_access = q_u->access_mask;
+       size_t    sd_size;
        BOOL ret;
        NTSTATUS nt_status;
 
        r_u->status = NT_STATUS_OK;
 
-       /* find the domain policy handle. */
-       if (!find_policy_by_hnd(p, &domain_pol, NULL))
+       /* find the domain policy handle and get domain SID / access bits in the domain policy. */
+       if (!get_lsa_policy_samr_sid(p, &domain_pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
+       
+       if (!NT_STATUS_IS_OK(nt_status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_open_user"))) {
+               return nt_status;
+       }
 
        nt_status = pdb_init_sam_talloc(p->mem_ctx, &sampass);
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
        }
 
-       /* Get the domain SID stored in the domain policy */
-       if(!get_lsa_policy_samr_sid(p, &domain_pol, &sid))
-               return NT_STATUS_INVALID_HANDLE;
-
        /* append the user's RID to it */
-       if(!sid_append_rid(&sid, q_u->user_rid))
+       if (!sid_append_rid(&sid, q_u->user_rid))
                return NT_STATUS_NO_SUCH_USER;
+       
+       /* check if access can be granted as requested by client. */
+       samr_make_usr_obj_sd(p->mem_ctx, &psd, &sd_size, &sid);
+       se_map_generic(&des_access, &usr_generic_mapping);
+       if (!NT_STATUS_IS_OK(nt_status = 
+                            access_check_samr_object(psd, p->pipe_user.nt_user_token, 
+                                                     des_access, &acc_granted, "_samr_open_user"))) {
+               return nt_status;
+       }
 
        become_root();
        ret=pdb_getsampwsid(sampass, &sid);
@@ -1446,9 +1717,10 @@ NTSTATUS _api_samr_open_user(pipes_struct *p, SAMR_Q_OPEN_USER *q_u, SAMR_R_OPEN
 
        pdb_free_sam(&sampass);
 
-       /* associate the user's SID with the new handle. */
+       /* associate the user's SID and access bits with the new handle. */
        if ((info = get_samr_info_by_sid(&sid)) == NULL)
                return NT_STATUS_NO_MEMORY;
+       info->acc_granted = acc_granted;
 
        /* get a (unique) handle.  open a policy on it. */
        if (!create_policy_hnd(p, user_pol, free_samr_info, (void *)info))
@@ -1579,7 +1851,8 @@ static NTSTATUS get_user_info_20(TALLOC_CTX *mem_ctx, SAM_USER_INFO_20 *id20, DO
  get_user_info_21
  *************************************************************************/
 
-static NTSTATUS get_user_info_21(TALLOC_CTX *mem_ctx, SAM_USER_INFO_21 *id21, DOM_SID *user_sid)
+static NTSTATUS get_user_info_21(TALLOC_CTX *mem_ctx, SAM_USER_INFO_21 *id21, 
+                                DOM_SID *user_sid, DOM_SID *domain_sid)
 {
        SAM_ACCOUNT *sampass=NULL;
        BOOL ret;
@@ -1604,7 +1877,7 @@ static NTSTATUS get_user_info_21(TALLOC_CTX *mem_ctx, SAM_USER_INFO_21 *id21, DO
        DEBUG(3,("User:[%s]\n",  pdb_get_username(sampass) ));
 
        ZERO_STRUCTP(id21);
-       init_sam_user_info21A(id21, sampass);
+       nt_status = init_sam_user_info21A(id21, sampass, domain_sid);
        
        pdb_free_sam(&sampass);
 
@@ -1619,13 +1892,19 @@ NTSTATUS _samr_query_userinfo(pipes_struct *p, SAMR_Q_QUERY_USERINFO *q_u, SAMR_
 {
        SAM_USERINFO_CTR *ctr;
        struct samr_info *info = NULL;
-
+       DOM_SID domain_sid;
+       uint32 rid;
+       
        r_u->status=NT_STATUS_OK;
 
        /* search for the handle */
        if (!find_policy_by_hnd(p, &q_u->pol, (void **)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       domain_sid = info->sid;
+
+       sid_split_rid(&domain_sid, &rid);
+
        if (!sid_check_is_in_our_domain(&info->sid))
                return NT_STATUS_OBJECT_TYPE_MISMATCH;
 
@@ -1697,7 +1976,8 @@ NTSTATUS _samr_query_userinfo(pipes_struct *p, SAMR_Q_QUERY_USERINFO *q_u, SAMR_
                ctr->info.id21 = (SAM_USER_INFO_21 *)talloc_zero(p->mem_ctx,sizeof(SAM_USER_INFO_21));
                if (ctr->info.id21 == NULL)
                        return NT_STATUS_NO_MEMORY;
-               if (!NT_STATUS_IS_OK(r_u->status = get_user_info_21(p->mem_ctx, ctr->info.id21, &info->sid)))
+               if (!NT_STATUS_IS_OK(r_u->status = get_user_info_21(p->mem_ctx, ctr->info.id21, 
+                                                                   &info->sid, &domain_sid)))
                        return r_u->status;
                break;
 
@@ -1719,9 +1999,10 @@ NTSTATUS _samr_query_userinfo(pipes_struct *p, SAMR_Q_QUERY_USERINFO *q_u, SAMR_
 NTSTATUS _samr_query_usergroups(pipes_struct *p, SAMR_Q_QUERY_USERGROUPS *q_u, SAMR_R_QUERY_USERGROUPS *r_u)
 {
        SAM_ACCOUNT *sam_pass=NULL;
+       DOM_SID  sid;
        DOM_GID *gids = NULL;
        int num_groups = 0;
-       struct samr_info *info = NULL;
+       uint32 acc_granted;
        BOOL ret;
 
        /*
@@ -1741,16 +2022,20 @@ NTSTATUS _samr_query_usergroups(pipes_struct *p, SAMR_Q_QUERY_USERGROUPS *q_u, S
        DEBUG(5,("_samr_query_usergroups: %d\n", __LINE__));
 
        /* find the policy handle.  open a policy on it. */
-       if (!find_policy_by_hnd(p, &q_u->pol, (void **)&info))
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_USER_GET_GROUPS, "_samr_query_usergroups"))) {
+               return r_u->status;
+       }
 
-       if (!sid_check_is_in_our_domain(&info->sid))
+       if (!sid_check_is_in_our_domain(&sid))
                return NT_STATUS_OBJECT_TYPE_MISMATCH;
 
        pdb_init_sam(&sam_pass);
        
        become_root();
-       ret = pdb_getsampwsid(sam_pass, &info->sid);
+       ret = pdb_getsampwsid(sam_pass, &sid);
        unbecome_root();
 
        if (ret == False) {
@@ -1792,6 +2077,8 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
        time_t u_logout;
        NTTIME nt_logout;
 
+       uint32 account_policy_temp;
+
        uint32 num_users=0, num_groups=0, num_aliases=0;
 
        if ((ctr = (SAM_UNK_CTR *)talloc_zero(p->mem_ctx, sizeof(SAM_UNK_CTR))) == NULL)
@@ -1809,12 +2096,22 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
        
        switch (q_u->switch_value) {
                case 0x01:
-                       account_policy_get(AP_MIN_PASSWORD_LEN, &min_pass_len);
-                       account_policy_get(AP_PASSWORD_HISTORY, &pass_hist);
-                       account_policy_get(AP_USER_MUST_LOGON_TO_CHG_PASS, &flag);
-                       account_policy_get(AP_MAX_PASSWORD_AGE, (int *)&u_expire);
-                       account_policy_get(AP_MIN_PASSWORD_AGE, (int *)&u_min_age);
+                       
+                       account_policy_get(AP_MIN_PASSWORD_LEN, &account_policy_temp);
+                       min_pass_len = account_policy_temp;
+
+                       account_policy_get(AP_PASSWORD_HISTORY, &account_policy_temp);
+                       pass_hist = account_policy_temp;
+
+                       account_policy_get(AP_USER_MUST_LOGON_TO_CHG_PASS, &account_policy_temp);
+                       flag = account_policy_temp;
+
+                       account_policy_get(AP_MAX_PASSWORD_AGE, &account_policy_temp);
+                       u_expire = account_policy_temp;
 
+                       account_policy_get(AP_MIN_PASSWORD_AGE, &account_policy_temp);
+                       u_min_age = account_policy_temp;
+                       
                        unix_to_nt_time_abs(&nt_expire, u_expire);
                        unix_to_nt_time_abs(&nt_min_age, u_min_age);
 
@@ -1823,7 +2120,7 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
                        break;
                case 0x02:
                        become_root();          
-                       r_u->status=load_sampwd_entries(info, ACB_NORMAL);
+                       r_u->status=load_sampwd_entries(info, ACB_NORMAL, False);
                        unbecome_root();
                        if (!NT_STATUS_IS_OK(r_u->status)) {
                                DEBUG(5, ("_samr_query_dispinfo: load_sampwd_entries failed\n"));
@@ -1841,7 +2138,7 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
                        free_samr_db(info);
                        
                        /* The time call below is to get a sequence number for the sam. FIXME !!! JRA. */
-                       init_unk_info2(&ctr->info.inf2, global_myworkgroup, global_myname, (uint32) time(NULL), 
+                       init_unk_info2(&ctr->info.inf2, lp_workgroup(), global_myname(), (uint32) time(NULL), 
                                       num_users, num_groups, num_aliases);
                        break;
                case 0x03:
@@ -1851,7 +2148,7 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
                        init_unk_info3(&ctr->info.inf3, nt_logout);
                        break;
                case 0x05:
-                       init_unk_info5(&ctr->info.inf5, global_myname);
+                       init_unk_info5(&ctr->info.inf5, global_myname());
                        break;
                case 0x06:
                        init_unk_info6(&ctr->info.inf6);
@@ -1860,10 +2157,15 @@ NTSTATUS _samr_query_dom_info(pipes_struct *p, SAMR_Q_QUERY_DOMAIN_INFO *q_u, SA
                        init_unk_info7(&ctr->info.inf7);
                        break;
                case 0x0c:
-                       account_policy_get(AP_LOCK_ACCOUNT_DURATION, (int *)&u_lock_duration);
-                       account_policy_get(AP_RESET_COUNT_TIME, (int *)&u_reset_time);
-                       account_policy_get(AP_BAD_ATTEMPT_LOCKOUT, &lockout);
-       
+                       account_policy_get(AP_LOCK_ACCOUNT_DURATION, &account_policy_temp);
+                       u_lock_duration = account_policy_temp;
+
+                       account_policy_get(AP_RESET_COUNT_TIME, &account_policy_temp);
+                       u_reset_time = account_policy_temp;
+
+                       account_policy_get(AP_BAD_ATTEMPT_LOCKOUT, &account_policy_temp);
+                       lockout = account_policy_temp;
+
                        unix_to_nt_time_abs(&nt_lock_duration, u_lock_duration);
                        unix_to_nt_time_abs(&nt_reset_time, u_reset_time);
        
@@ -1900,11 +2202,20 @@ NTSTATUS _api_samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u, SAMR_R_
        BOOL ret;
        NTSTATUS nt_status;
        struct passwd *pw;
+       uint32 acc_granted;
+       SEC_DESC *psd;
+       size_t    sd_size;
+       /* check this, when giving away 'add computer to domain' privs */
+       uint32    des_access = GENERIC_RIGHTS_USER_ALL_ACCESS;
 
-       /* find the policy handle.  open a policy on it. */
-       if (!find_policy_by_hnd(p, &dom_pol, NULL))
+       /* Get the domain SID stored in the domain policy */
+       if (!get_lsa_policy_samr_sid(p, &dom_pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (!NT_STATUS_IS_OK(nt_status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_CREATE_USER, "_samr_create_user"))) {
+               return nt_status;
+       }
+
        /* find the account: tell the caller if it exists.
          lkclXXXX i have *no* idea if this is a problem or not
          or even if you are supposed to construct a different
@@ -1973,7 +2284,7 @@ NTSTATUS _api_samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u, SAMR_R_
        else 
                pstrcpy(add_script, lp_adduser_script());
 
-       if(*add_script) {
+       if (*add_script) {
                int add_ret;
                all_string_sub(add_script, "%u", account, sizeof(account));
                add_ret = smbrun(add_script,NULL);
@@ -1983,11 +2294,12 @@ NTSTATUS _api_samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u, SAMR_R_
        pw = getpwnam_alloc(account);
 
        if (pw) {
-               if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam_pw(&sam_pass, pw))) {
-                       passwd_free(&pw);
+               nt_status = pdb_init_sam_pw(&sam_pass, pw);
+               passwd_free(&pw); /* done with this now */
+               if (!NT_STATUS_IS_OK(nt_status)) {
+                       pdb_free_sam(&sam_pass);
                        return nt_status;
                }
-               passwd_free(&pw); /* done with this now */
        } else {
                DEBUG(3,("attempting to create non-unix account %s\n", account));
                
@@ -1995,13 +2307,13 @@ NTSTATUS _api_samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u, SAMR_R_
                        return nt_status;
                }
                
-               if (!pdb_set_username(sam_pass, account)) {
+               if (!pdb_set_username(sam_pass, account, PDB_CHANGED)) {
                        pdb_free_sam(&sam_pass);
                        return NT_STATUS_NO_MEMORY;
                }
        }
 
-       pdb_set_acct_ctrl(sam_pass, acb_info);
+       pdb_set_acct_ctrl(sam_pass, acb_info, PDB_CHANGED);
  
        if (!pdb_add_sam_account(sam_pass)) {
                pdb_free_sam(&sam_pass);
@@ -2009,26 +2321,16 @@ NTSTATUS _api_samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u, SAMR_R_
                          account));
                return NT_STATUS_ACCESS_DENIED;         
        }
-
-       pdb_reset_sam(sam_pass);
-       
-       if (!pdb_getsampwnam(sam_pass, account)) {
-               pdb_free_sam(&sam_pass);
-               DEBUG(0, ("could not find user/computer %s just added to passdb?!?\n", 
-                         account));
-               return NT_STATUS_ACCESS_DENIED;         
-       }
        
-       /* Get the domain SID stored in the domain policy */
-       if(!get_lsa_policy_samr_sid(p, &dom_pol, &sid)) {
-               pdb_free_sam(&sam_pass);
-               return NT_STATUS_INVALID_HANDLE;
-       }
-
-       /* append the user's RID to it */
-       if(!sid_append_rid(&sid, pdb_get_user_rid(sam_pass) )) {
-               pdb_free_sam(&sam_pass);
-               return NT_STATUS_NO_SUCH_USER;
+       /* Get the user's SID */
+       sid_copy(&sid, pdb_get_user_sid(sam_pass));
+       
+       samr_make_usr_obj_sd(p->mem_ctx, &psd, &sd_size, &sid);
+       se_map_generic(&des_access, &usr_generic_mapping);
+       if (!NT_STATUS_IS_OK(nt_status = 
+                            access_check_samr_object(psd, p->pipe_user.nt_user_token, 
+                                                     des_access, &acc_granted, "_samr_create_user"))) {
+               return nt_status;
        }
 
        /* associate the user's SID with the new handle. */
@@ -2039,6 +2341,7 @@ NTSTATUS _api_samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u, SAMR_R_
 
        ZERO_STRUCTP(info);
        info->sid = sid;
+       info->acc_granted = acc_granted;
 
        /* get a (unique) handle.  open a policy on it. */
        if (!create_policy_hnd(p, user_pol, free_samr_info, (void *)info)) {
@@ -2047,7 +2350,8 @@ NTSTATUS _api_samr_create_user(pipes_struct *p, SAMR_Q_CREATE_USER *q_u, SAMR_R_
        }
 
        r_u->user_rid=pdb_get_user_rid(sam_pass);
-       r_u->unknown_0 = 0x000703ff;
+
+       r_u->access_granted = acc_granted;
 
        pdb_free_sam(&sam_pass);
 
@@ -2062,29 +2366,29 @@ NTSTATUS _samr_connect_anon(pipes_struct *p, SAMR_Q_CONNECT_ANON *q_u, SAMR_R_CO
 {
        struct samr_info *info = NULL;
 
-    /* Access check */
+       /* Access check */
 
-    if (!pipe_access_check(p)) {
-           DEBUG(3, ("access denied to samr_connect_anon\n"));
-           r_u->status = NT_STATUS_ACCESS_DENIED;
-           return r_u->status;
-    }
+       if (!pipe_access_check(p)) {
+               DEBUG(3, ("access denied to samr_connect_anon\n"));
+               r_u->status = NT_STATUS_ACCESS_DENIED;
+               return r_u->status;
+       }
 
-    /* set up the SAMR connect_anon response */
+       /* set up the SAMR connect_anon response */
 
-    r_u->status = NT_STATUS_OK;
+       r_u->status = NT_STATUS_OK;
 
-    /* associate the user's SID with the new handle. */
-    if ((info = get_samr_info_by_sid(NULL)) == NULL)
-        return NT_STATUS_NO_MEMORY;
+       /* associate the user's SID with the new handle. */
+       if ((info = get_samr_info_by_sid(NULL)) == NULL)
+               return NT_STATUS_NO_MEMORY;
 
-    info->status = q_u->unknown_0;
+       info->status = q_u->unknown_0;
 
-    /* get a (unique) handle.  open a policy on it. */
-    if (!create_policy_hnd(p, &r_u->connect_pol, free_samr_info, (void *)info))
-        return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+       /* get a (unique) handle.  open a policy on it. */
+       if (!create_policy_hnd(p, &r_u->connect_pol, free_samr_info, (void *)info))
+               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
-    return r_u->status;
+       return r_u->status;
 }
 
 /*******************************************************************
@@ -2094,32 +2398,97 @@ NTSTATUS _samr_connect_anon(pipes_struct *p, SAMR_Q_CONNECT_ANON *q_u, SAMR_R_CO
 NTSTATUS _samr_connect(pipes_struct *p, SAMR_Q_CONNECT *q_u, SAMR_R_CONNECT *r_u)
 {
        struct samr_info *info = NULL;
+       SEC_DESC *psd = NULL;
+       uint32    acc_granted;
+       uint32    des_access = q_u->access_mask;
+       size_t    sd_size;
+       NTSTATUS  nt_status;
 
-    DEBUG(5,("_samr_connect: %d\n", __LINE__));
 
-    /* Access check */
+       DEBUG(5,("_samr_connect: %d\n", __LINE__));
 
-    if (!pipe_access_check(p)) {
-           DEBUG(3, ("access denied to samr_connect\n"));
-           r_u->status = NT_STATUS_ACCESS_DENIED;
-           return r_u->status;
-    }
+       /* Access check */
 
-    r_u->status = NT_STATUS_OK;
+       if (!pipe_access_check(p)) {
+               DEBUG(3, ("access denied to samr_connect\n"));
+               r_u->status = NT_STATUS_ACCESS_DENIED;
+               return r_u->status;
+       }
+
+       samr_make_sam_obj_sd(p->mem_ctx, &psd, &sd_size);
+       se_map_generic(&des_access, &sam_generic_mapping);
+       if (!NT_STATUS_IS_OK(nt_status = 
+                            access_check_samr_object(psd, p->pipe_user.nt_user_token, 
+                                                     des_access, &acc_granted, "_samr_connect"))) {
+               return nt_status;
+       }
 
-    /* associate the user's SID with the new handle. */
+       r_u->status = NT_STATUS_OK;
+
+       /* associate the user's SID and access granted with the new handle. */
        if ((info = get_samr_info_by_sid(NULL)) == NULL)
-        return NT_STATUS_NO_MEMORY;
+               return NT_STATUS_NO_MEMORY;
 
-    info->status = q_u->access_mask;
+       info->acc_granted = acc_granted;
+       info->status = q_u->access_mask;
 
-    /* get a (unique) handle.  open a policy on it. */
-    if (!create_policy_hnd(p, &r_u->connect_pol, free_samr_info, (void *)info))
-        return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+       /* get a (unique) handle.  open a policy on it. */
+       if (!create_policy_hnd(p, &r_u->connect_pol, free_samr_info, (void *)info))
+               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
 
-    DEBUG(5,("_samr_connect: %d\n", __LINE__));
+       DEBUG(5,("_samr_connect: %d\n", __LINE__));
 
-    return r_u->status;
+       return r_u->status;
+}
+
+/*******************************************************************
+ samr_connect4
+ ********************************************************************/
+
+NTSTATUS _samr_connect4(pipes_struct *p, SAMR_Q_CONNECT4 *q_u, SAMR_R_CONNECT4 *r_u)
+{
+       struct samr_info *info = NULL;
+       SEC_DESC *psd = NULL;
+       uint32    acc_granted;
+       uint32    des_access = q_u->access_mask;
+       size_t    sd_size;
+       NTSTATUS  nt_status;
+
+
+       DEBUG(5,("_samr_connect4: %d\n", __LINE__));
+
+       /* Access check */
+
+       if (!pipe_access_check(p)) {
+               DEBUG(3, ("access denied to samr_connect4\n"));
+               r_u->status = NT_STATUS_ACCESS_DENIED;
+               return r_u->status;
+       }
+
+       samr_make_sam_obj_sd(p->mem_ctx, &psd, &sd_size);
+       se_map_generic(&des_access, &sam_generic_mapping);
+       if (!NT_STATUS_IS_OK(nt_status = 
+                            access_check_samr_object(psd, p->pipe_user.nt_user_token, 
+                                                     des_access, &acc_granted, "_samr_connect"))) {
+               return nt_status;
+       }
+
+       r_u->status = NT_STATUS_OK;
+
+       /* associate the user's SID and access granted with the new handle. */
+       if ((info = get_samr_info_by_sid(NULL)) == NULL)
+               return NT_STATUS_NO_MEMORY;
+
+       info->acc_granted = acc_granted;
+       info->status = q_u->access_mask;
+
+       /* get a (unique) handle.  open a policy on it. */
+       if (!create_policy_hnd(p, &r_u->connect_pol, free_samr_info, (void *)info))
+               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+
+       DEBUG(5,("_samr_connect: %d\n", __LINE__));
+
+       return r_u->status;
 }
 
 /**********************************************************************
@@ -2128,14 +2497,19 @@ NTSTATUS _samr_connect(pipes_struct *p, SAMR_Q_CONNECT *q_u, SAMR_R_CONNECT *r_u
 
 NTSTATUS _samr_lookup_domain(pipes_struct *p, SAMR_Q_LOOKUP_DOMAIN *q_u, SAMR_R_LOOKUP_DOMAIN *r_u)
 {
+       struct samr_info *info;
        fstring domain_name;
        DOM_SID sid;
 
        r_u->status = NT_STATUS_OK;
 
-       if (!find_policy_by_hnd(p, &q_u->connect_pol, NULL))
+       if (!find_policy_by_hnd(p, &q_u->connect_pol, (void**)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(info->acc_granted, SA_RIGHT_SAM_OPEN_DOMAIN, "_samr_lookup_domain"))) {
+               return r_u->status;
+       }
+
        rpcstr_pull(domain_name, q_u->uni_domain.buffer, sizeof(domain_name), q_u->uni_domain.uni_str_len*2, 0);
 
        ZERO_STRUCT(sid);
@@ -2195,19 +2569,27 @@ static BOOL make_enum_domains(TALLOC_CTX *ctx, SAM_ENTRY **pp_sam,
 
 NTSTATUS _samr_enum_domains(pipes_struct *p, SAMR_Q_ENUM_DOMAINS *q_u, SAMR_R_ENUM_DOMAINS *r_u)
 {
+       struct samr_info *info;
        uint32 num_entries = 2;
        fstring dom[2];
-       char *name;
+       const char *name;
 
        r_u->status = NT_STATUS_OK;
+       
+       if (!find_policy_by_hnd(p, &q_u->pol, (void**)&info))
+               return NT_STATUS_INVALID_HANDLE;
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(info->acc_granted, SA_RIGHT_SAM_ENUM_DOMAINS, "_samr_enum_domains"))) {
+               return r_u->status;
+       }
 
        switch (lp_server_role()) {
        case ROLE_DOMAIN_PDC:
        case ROLE_DOMAIN_BDC:
-               name = global_myworkgroup;
+               name = lp_workgroup();
                break;
        default:
-               name = global_myname;
+               name = global_myname();
        }
 
        fstrcpy(dom[0],name);
@@ -2232,21 +2614,35 @@ NTSTATUS _api_samr_open_alias(pipes_struct *p, SAMR_Q_OPEN_ALIAS *q_u, SAMR_R_OP
        POLICY_HND domain_pol = q_u->dom_pol;
        uint32 alias_rid = q_u->rid_alias;
        POLICY_HND *alias_pol = &r_u->pol;
-       struct samr_info *info = NULL;
+       struct    samr_info *info = NULL;
+       SEC_DESC *psd = NULL;
+       uint32    acc_granted;
+       uint32    des_access = q_u->access_mask;
+       size_t    sd_size;
+       NTSTATUS  status;
 
        r_u->status = NT_STATUS_OK;
 
-       /* get the domain policy. */
-       if (!find_policy_by_hnd(p, &domain_pol, NULL))
-               return NT_STATUS_INVALID_HANDLE;
-
-       /* Get the domain SID stored in the domain policy */
-       if(!get_lsa_policy_samr_sid(p, &domain_pol, &sid))
+       /* find the domain policy and get the SID / access bits stored in the domain policy */
+       if (!get_lsa_policy_samr_sid(p, &domain_pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
+               
+       if (!NT_STATUS_IS_OK(status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_open_alias"))) {
+               return status;
+       }
 
        /* append the alias' RID to it */
-       if(!sid_append_rid(&sid, alias_rid))
+       if (!sid_append_rid(&sid, alias_rid))
                return NT_STATUS_NO_SUCH_USER;
+               
+       /*check if access can be granted as requested by client. */
+       samr_make_ali_obj_sd(p->mem_ctx, &psd, &sd_size);
+       se_map_generic(&des_access,&ali_generic_mapping);
+       if (!NT_STATUS_IS_OK(status = 
+                            access_check_samr_object(psd, p->pipe_user.nt_user_token, 
+                                                     des_access, &acc_granted, "_samr_open_alias"))) {
+               return status;
+       }
 
        /*
         * we should check if the rid really exist !!!
@@ -2256,6 +2652,8 @@ NTSTATUS _api_samr_open_alias(pipes_struct *p, SAMR_Q_OPEN_ALIAS *q_u, SAMR_R_OP
        /* associate the user's SID with the new handle. */
        if ((info = get_samr_info_by_sid(&sid)) == NULL)
                return NT_STATUS_NO_MEMORY;
+               
+       info->acc_granted = acc_granted;
 
        /* get a (unique) handle.  open a policy on it. */
        if (!create_policy_hnd(p, alias_pol, free_samr_info, (void *)info))
@@ -2287,8 +2685,9 @@ static BOOL set_user_info_10(const SAM_USER_INFO_10 *id10, DOM_SID *sid)
                pdb_free_sam(&pwd);
                return False;
        }
-
-       if (!pdb_set_acct_ctrl(pwd, id10->acb_info)) {
+       
+       /* FIX ME: check if the value is really changed --metze */
+       if (!pdb_set_acct_ctrl(pwd, id10->acb_info, PDB_CHANGED)) {
                pdb_free_sam(&pwd);
                return False;
        }
@@ -2324,11 +2723,11 @@ static BOOL set_user_info_12(SAM_USER_INFO_12 *id12, DOM_SID *sid)
                return False;
        }
  
-       if (!pdb_set_lanman_passwd (pwd, id12->lm_pwd)) {
+       if (!pdb_set_lanman_passwd (pwd, id12->lm_pwd, PDB_CHANGED)) {
                pdb_free_sam(&pwd);
                return False;
        }
-       if (!pdb_set_nt_passwd     (pwd, id12->nt_pwd)) {
+       if (!pdb_set_nt_passwd     (pwd, id12->nt_pwd, PDB_CHANGED)) {
                pdb_free_sam(&pwd);
                return False;
        }
@@ -2414,8 +2813,6 @@ static BOOL set_user_info_23(SAM_USER_INFO_23 *id23, DOM_SID *sid)
 
        acct_ctrl = pdb_get_acct_ctrl(pwd);
 
-       copy_id23_to_sam_passwd(pwd, id23);
        if (!decode_pw_buffer((char*)id23->pass, plaintext_buf, 256, &len)) {
                pdb_free_sam(&pwd);
                return False;
@@ -2426,6 +2823,8 @@ static BOOL set_user_info_23(SAM_USER_INFO_23 *id23, DOM_SID *sid)
                return False;
        }
  
+       copy_id23_to_sam_passwd(pwd, id23);
        /* if it's a trust account, don't update /etc/passwd */
        if ( (!IS_SAM_UNIX_USER(pwd)) ||
                ( (acct_ctrl &  ACB_DOMTRUST) == ACB_DOMTRUST ) ||
@@ -2529,15 +2928,22 @@ NTSTATUS _samr_set_userinfo(pipes_struct *p, SAMR_Q_SET_USERINFO *q_u, SAMR_R_SE
        POLICY_HND *pol = &q_u->pol;
        uint16 switch_value = q_u->switch_value;
        SAM_USERINFO_CTR *ctr = q_u->ctr;
+       uint32 acc_granted;
+       uint32 acc_required;
 
        DEBUG(5, ("_samr_set_userinfo: %d\n", __LINE__));
 
        r_u->status = NT_STATUS_OK;
 
        /* find the policy handle.  open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, pol, &sid))
+       if (!get_lsa_policy_samr_sid(p, pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       acc_required = SA_RIGHT_USER_SET_LOC_COM | SA_RIGHT_USER_SET_ATTRIBUTES; /* This is probably wrong */   
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, acc_required, "_samr_set_userinfo"))) {
+               return r_u->status;
+       }
+               
        DEBUG(5, ("_samr_set_userinfo: sid:%s, level:%d\n", sid_string_static(&sid), switch_value));
 
        if (ctr == NULL) {
@@ -2607,14 +3013,21 @@ NTSTATUS _samr_set_userinfo2(pipes_struct *p, SAMR_Q_SET_USERINFO2 *q_u, SAMR_R_
        SAM_USERINFO_CTR *ctr = q_u->ctr;
        POLICY_HND *pol = &q_u->pol;
        uint16 switch_value = q_u->switch_value;
+       uint32 acc_granted;
+       uint32 acc_required;
 
        DEBUG(5, ("samr_reply_set_userinfo2: %d\n", __LINE__));
 
        r_u->status = NT_STATUS_OK;
 
        /* find the policy handle.  open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, pol, &sid))
+       if (!get_lsa_policy_samr_sid(p, pol, &sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
+       
+       acc_required = SA_RIGHT_USER_SET_LOC_COM | SA_RIGHT_USER_SET_ATTRIBUTES; /* This is probably wrong */   
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, acc_required, "_samr_set_userinfo2"))) {
+               return r_u->status;
+       }
 
        DEBUG(5, ("samr_reply_set_userinfo2: sid:%s\n", sid_string_static(&sid)));
 
@@ -2657,6 +3070,10 @@ NTSTATUS _samr_query_useraliases(pipes_struct *p, SAMR_Q_QUERY_USERALIASES *q_u,
        uint32 *rids=NULL, *new_rids=NULL, *tmp_rids=NULL;
        struct samr_info *info = NULL;
        int i,j;
+               
+       NTSTATUS ntstatus1;
+       NTSTATUS ntstatus2;
+
        /* until i see a real useraliases query, we fack one up */
 
        /* I have seen one, JFM 2/12/2001 */
@@ -2681,6 +3098,16 @@ NTSTATUS _samr_query_useraliases(pipes_struct *p, SAMR_Q_QUERY_USERALIASES *q_u,
        /* find the policy handle.  open a policy on it. */
        if (!find_policy_by_hnd(p, &q_u->pol, (void **)&info))
                return NT_STATUS_INVALID_HANDLE;
+               
+       ntstatus1 = access_check_samr_function(info->acc_granted, SA_RIGHT_DOMAIN_LOOKUP_ALIAS_BY_MEM, "_samr_query_useraliases");
+       ntstatus2 = access_check_samr_function(info->acc_granted, SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_query_useraliases");
+       
+       if (!NT_STATUS_IS_OK(ntstatus1) || !NT_STATUS_IS_OK(ntstatus2)) {
+               if (!(NT_STATUS_EQUAL(ntstatus1,NT_STATUS_ACCESS_DENIED) && NT_STATUS_IS_OK(ntstatus2)) &&
+                   !(NT_STATUS_EQUAL(ntstatus1,NT_STATUS_ACCESS_DENIED) && NT_STATUS_IS_OK(ntstatus1))) {
+                       return (NT_STATUS_IS_OK(ntstatus1)) ? ntstatus2 : ntstatus1;
+               }
+       }               
 
        if (!sid_check_is_domain(&info->sid) &&
            !sid_check_is_builtin(&info->sid))
@@ -2745,11 +3172,17 @@ NTSTATUS _samr_query_aliasmem(pipes_struct *p, SAMR_Q_QUERY_ALIASMEM *q_u, SAMR_
 
        SAM_ACCOUNT *sam_user = NULL;
        BOOL check;
+       uint32 acc_granted;
 
        /* find the policy handle.  open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = 
+               access_check_samr_function(acc_granted, SA_RIGHT_ALIAS_GET_MEMBERS, "_samr_query_aliasmem"))) {
+               return r_u->status;
+       }
+               
        sid_copy(&als_sid, &alias_sid);
        sid_to_string(alias_sid_str, &alias_sid);
        sid_split_rid(&alias_sid, &alias_rid);
@@ -2758,7 +3191,7 @@ NTSTATUS _samr_query_aliasmem(pipes_struct *p, SAMR_Q_QUERY_ALIASMEM *q_u, SAMR_
 
        if (sid_equal(&alias_sid, &global_sid_Builtin)) {
                DEBUG(10, ("lookup on Builtin SID (S-1-5-32)\n"));
-               if(!get_local_group_from_sid(als_sid, &map, MAPPING_WITHOUT_PRIV))
+               if(!get_builtin_group_from_sid(als_sid, &map, MAPPING_WITHOUT_PRIV))
                        return NT_STATUS_NO_SUCH_ALIAS;
        } else {
                if (sid_equal(&alias_sid, get_global_sam_sid())) {
@@ -2841,12 +3274,16 @@ NTSTATUS _samr_query_groupmem(pipes_struct *p, SAMR_Q_QUERY_GROUPMEM *q_u, SAMR_
 
        SAM_ACCOUNT *sam_user = NULL;
        BOOL check;
-
+       uint32 acc_granted;
 
        /* find the policy handle.  open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->group_pol, &group_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->group_pol, &group_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+               
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_GROUP_GET_MEMBERS, "_samr_query_groupmem"))) {
+               return r_u->status;
+       }
+               
        /* todo: change to use sid_compare_front */
 
        sid_split_rid(&group_sid, &group_rid);
@@ -2929,11 +3366,16 @@ NTSTATUS _samr_add_aliasmem(pipes_struct *p, SAMR_Q_ADD_ALIASMEM *q_u, SAMR_R_AD
        NTSTATUS ret;
        SAM_ACCOUNT *sam_user = NULL;
        BOOL check;
+       uint32 acc_granted;
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_ALIAS_ADD_MEMBER, "_samr_add_aliasmem"))) {
+               return r_u->status;
+       }
+               
        sid_to_string(alias_sid_str, &alias_sid);
        DEBUG(10, ("sid is %s\n", alias_sid_str));
 
@@ -2973,19 +3415,21 @@ NTSTATUS _samr_add_aliasmem(pipes_struct *p, SAMR_Q_ADD_ALIASMEM *q_u, SAMR_R_AD
 
        if ((pwd=getpwuid_alloc(uid)) == NULL) {
                return NT_STATUS_NO_SUCH_USER;
-       } else {
-               passwd_free(&pwd);
        }
 
-       if ((grp=getgrgid(map.gid)) == NULL)
+       if ((grp=getgrgid(map.gid)) == NULL) {
+               passwd_free(&pwd);
                return NT_STATUS_NO_SUCH_ALIAS;
+       }
 
        /* we need to copy the name otherwise it's overloaded in user_in_group_list */
        fstrcpy(grp_name, grp->gr_name);
 
        /* if the user is already in the group */
-       if(user_in_group_list(pwd->pw_name, grp_name))
+       if(user_in_unix_group_list(pwd->pw_name, grp_name)) {
+               passwd_free(&pwd);
                return NT_STATUS_MEMBER_IN_ALIAS;
+       }
 
        /* 
         * ok, the group exist, the user exist, the user is not in the group,
@@ -2994,9 +3438,12 @@ NTSTATUS _samr_add_aliasmem(pipes_struct *p, SAMR_Q_ADD_ALIASMEM *q_u, SAMR_R_AD
        smb_add_user_group(grp_name, pwd->pw_name);
 
        /* check if the user has been added then ... */
-       if(!user_in_group_list(pwd->pw_name, grp_name))
+       if(!user_in_unix_group_list(pwd->pw_name, grp_name)) {
+               passwd_free(&pwd);
                return NT_STATUS_MEMBER_NOT_IN_ALIAS;   /* don't know what to reply else */
+       }
 
+       passwd_free(&pwd);
        return NT_STATUS_OK;
 }
 
@@ -3012,11 +3459,16 @@ NTSTATUS _samr_del_aliasmem(pipes_struct *p, SAMR_Q_DEL_ALIASMEM *q_u, SAMR_R_DE
        fstring grp_name;
        GROUP_MAP map;
        SAM_ACCOUNT *sam_pass=NULL;
+       uint32 acc_granted;
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_ALIAS_REMOVE_MEMBER, "_samr_del_aliasmem"))) {
+               return r_u->status;
+       }
+       
        sid_to_string(alias_sid_str, &alias_sid);
        DEBUG(10, ("_samr_del_aliasmem:sid is %s\n", alias_sid_str));
 
@@ -3032,7 +3484,7 @@ NTSTATUS _samr_del_aliasmem(pipes_struct *p, SAMR_Q_DEL_ALIASMEM *q_u, SAMR_R_DE
        if ((grp=getgrgid(map.gid)) == NULL)
                return NT_STATUS_NO_SUCH_ALIAS;
 
-       /* we need to copy the name otherwise it's overloaded in user_in_group_list */
+       /* we need to copy the name otherwise it's overloaded in user_in_unix_group_list */
        fstrcpy(grp_name, grp->gr_name);
 
        /* check if the user exists before trying to remove it from the group */
@@ -3044,7 +3496,7 @@ NTSTATUS _samr_del_aliasmem(pipes_struct *p, SAMR_Q_DEL_ALIASMEM *q_u, SAMR_R_DE
        }
 
        /* if the user is not in the group */
-       if(!user_in_group_list(pdb_get_username(sam_pass), grp_name)) {
+       if(!user_in_unix_group_list(pdb_get_username(sam_pass), grp_name)) {
                pdb_free_sam(&sam_pass);
                return NT_STATUS_MEMBER_IN_ALIAS;
        }
@@ -3052,7 +3504,7 @@ NTSTATUS _samr_del_aliasmem(pipes_struct *p, SAMR_Q_DEL_ALIASMEM *q_u, SAMR_R_DE
        smb_delete_user_group(grp_name, pdb_get_username(sam_pass));
 
        /* check if the user has been removed then ... */
-       if(user_in_group_list(pdb_get_username(sam_pass), grp_name)) {
+       if(user_in_unix_group_list(pdb_get_username(sam_pass), grp_name)) {
                pdb_free_sam(&sam_pass);
                return NT_STATUS_MEMBER_NOT_IN_ALIAS;   /* don't know what to reply else */
        }
@@ -3076,12 +3528,17 @@ NTSTATUS _samr_add_groupmem(pipes_struct *p, SAMR_Q_ADD_GROUPMEM *q_u, SAMR_R_AD
        GROUP_MAP map;
        uid_t uid;
        NTSTATUS ret;
-       SAM_ACCOUNT *sam_user;
+       SAM_ACCOUNT *sam_user=NULL;
        BOOL check;
+       uint32 acc_granted;
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_GROUP_ADD_MEMBER, "_samr_add_groupmem"))) {
+               return r_u->status;
+       }
 
        sid_to_string(group_sid_str, &group_sid);
        DEBUG(10, ("sid is %s\n", group_sid_str));
@@ -3118,19 +3575,21 @@ NTSTATUS _samr_add_groupmem(pipes_struct *p, SAMR_Q_ADD_GROUPMEM *q_u, SAMR_R_AD
 
        if ((pwd=getpwuid_alloc(uid)) == NULL) {
                return NT_STATUS_NO_SUCH_USER;
-       } else {
-               passwd_free(&pwd);
        }
 
-       if ((grp=getgrgid(map.gid)) == NULL)
+       if ((grp=getgrgid(map.gid)) == NULL) {
+               passwd_free(&pwd);
                return NT_STATUS_NO_SUCH_GROUP;
+       }
 
-       /* we need to copy the name otherwise it's overloaded in user_in_group_list */
+       /* we need to copy the name otherwise it's overloaded in user_in_unix_group_list */
        fstrcpy(grp_name, grp->gr_name);
 
        /* if the user is already in the group */
-       if(user_in_group_list(pwd->pw_name, grp_name))
+       if(user_in_unix_group_list(pwd->pw_name, grp_name)) {
+               passwd_free(&pwd);
                return NT_STATUS_MEMBER_IN_GROUP;
+       }
 
        /* 
         * ok, the group exist, the user exist, the user is not in the group,
@@ -3141,9 +3600,12 @@ NTSTATUS _samr_add_groupmem(pipes_struct *p, SAMR_Q_ADD_GROUPMEM *q_u, SAMR_R_AD
        smb_add_user_group(grp_name, pwd->pw_name);
 
        /* check if the user has been added then ... */
-       if(!user_in_group_list(pwd->pw_name, grp_name))
+       if(!user_in_unix_group_list(pwd->pw_name, grp_name)) {
+               passwd_free(&pwd);
                return NT_STATUS_MEMBER_NOT_IN_GROUP;           /* don't know what to reply else */
+       }
 
+       passwd_free(&pwd);
        return NT_STATUS_OK;
 }
 
@@ -3159,6 +3621,7 @@ NTSTATUS _samr_del_groupmem(pipes_struct *p, SAMR_Q_DEL_GROUPMEM *q_u, SAMR_R_DE
        GROUP_MAP map;
        fstring grp_name;
        struct group *grp;
+       uint32 acc_granted;
 
        /*
         * delete the group member named q_u->rid
@@ -3167,16 +3630,20 @@ NTSTATUS _samr_del_groupmem(pipes_struct *p, SAMR_Q_DEL_GROUPMEM *q_u, SAMR_R_DE
         */
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
-       if(!sid_check_is_in_our_domain(&group_sid))
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_GROUP_REMOVE_MEMBER, "_samr_del_groupmem"))) {
+               return r_u->status;
+       }
+               
+       if (!sid_check_is_in_our_domain(&group_sid))
                return NT_STATUS_NO_SUCH_GROUP;
 
        sid_copy(&user_sid, get_global_sam_sid());
        sid_append_rid(&user_sid, q_u->rid);
 
-       if(!get_domain_group_from_sid(group_sid, &map, MAPPING_WITHOUT_PRIV))
+       if (!get_domain_group_from_sid(group_sid, &map, MAPPING_WITHOUT_PRIV))
                return NT_STATUS_NO_SUCH_GROUP;
 
        if ((grp=getgrgid(map.gid)) == NULL)
@@ -3187,14 +3654,14 @@ NTSTATUS _samr_del_groupmem(pipes_struct *p, SAMR_Q_DEL_GROUPMEM *q_u, SAMR_R_DE
 
        /* check if the user exists before trying to remove it from the group */
        pdb_init_sam(&sam_pass);
-       if(!pdb_getsampwsid(sam_pass, &user_sid)) {
+       if (!pdb_getsampwsid(sam_pass, &user_sid)) {
                DEBUG(5,("User %s doesn't exist.\n", pdb_get_username(sam_pass)));
                pdb_free_sam(&sam_pass);
                return NT_STATUS_NO_SUCH_USER;
        }
 
        /* if the user is not in the group */
-       if(!user_in_group_list(pdb_get_username(sam_pass), grp_name)) {
+       if (!user_in_unix_group_list(pdb_get_username(sam_pass), grp_name)) {
                pdb_free_sam(&sam_pass);
                return NT_STATUS_MEMBER_NOT_IN_GROUP;
        }
@@ -3202,7 +3669,7 @@ NTSTATUS _samr_del_groupmem(pipes_struct *p, SAMR_Q_DEL_GROUPMEM *q_u, SAMR_R_DE
        smb_delete_user_group(grp_name, pdb_get_username(sam_pass));
 
        /* check if the user has been removed then ... */
-       if(user_in_group_list(pdb_get_username(sam_pass), grp_name)) {
+       if (user_in_unix_group_list(pdb_get_username(sam_pass), grp_name)) {
                pdb_free_sam(&sam_pass);
                return NT_STATUS_ACCESS_DENIED;         /* don't know what to reply else */
        }
@@ -3238,13 +3705,18 @@ NTSTATUS _samr_delete_dom_user(pipes_struct *p, SAMR_Q_DELETE_DOM_USER *q_u, SAM
 {
        DOM_SID user_sid;
        SAM_ACCOUNT *sam_pass=NULL;
+       uint32 acc_granted;
 
        DEBUG(5, ("_samr_delete_dom_user: %d\n", __LINE__));
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->user_pol, &user_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->user_pol, &user_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+               
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_delete_dom_user"))) {
+               return r_u->status;
+       }
+               
        if (!sid_check_is_in_our_domain(&user_sid))
                return NT_STATUS_CANNOT_DELETE;
 
@@ -3292,13 +3764,18 @@ NTSTATUS _samr_delete_dom_group(pipes_struct *p, SAMR_Q_DELETE_DOM_GROUP *q_u, S
        gid_t gid;
        struct group *grp;
        GROUP_MAP map;
+       uint32 acc_granted;
 
        DEBUG(5, ("samr_delete_dom_group: %d\n", __LINE__));
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->group_pol, &group_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->group_pol, &group_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+               
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_delete_dom_group"))) {
+               return r_u->status;
+       }
+               
        sid_copy(&dom_sid, &group_sid);
        sid_to_string(group_sid_str, &dom_sid);
        sid_split_rid(&dom_sid, &group_rid);
@@ -3327,7 +3804,7 @@ NTSTATUS _samr_delete_dom_group(pipes_struct *p, SAMR_Q_DELETE_DOM_GROUP *q_u, S
        if ( (grp=getgrgid(gid)) != NULL)
                return NT_STATUS_ACCESS_DENIED;
 
-       if(!group_map_remove(group_sid))
+       if(!pdb_delete_group_mapping_entry(group_sid))
                return NT_STATUS_ACCESS_DENIED;
 
        if (!close_policy_hnd(p, &q_u->group_pol))
@@ -3349,13 +3826,18 @@ NTSTATUS _samr_delete_dom_alias(pipes_struct *p, SAMR_Q_DELETE_DOM_ALIAS *q_u, S
        gid_t gid;
        struct group *grp;
        GROUP_MAP map;
+       uint32 acc_granted;
 
        DEBUG(5, ("_samr_delete_dom_alias: %d\n", __LINE__));
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &alias_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, STD_RIGHT_DELETE_ACCESS, "_samr_delete_dom_alias"))) {
+               return r_u->status;
+       }
+               
        sid_copy(&dom_sid, &alias_sid);
        sid_to_string(alias_sid_str, &dom_sid);
        sid_split_rid(&dom_sid, &alias_rid);
@@ -3385,7 +3867,7 @@ NTSTATUS _samr_delete_dom_alias(pipes_struct *p, SAMR_Q_DELETE_DOM_ALIAS *q_u, S
                return NT_STATUS_ACCESS_DENIED;
 
        /* don't check if we removed it as it could be an un-mapped group */
-       group_map_remove(alias_sid);
+       pdb_delete_group_mapping_entry(alias_sid);
 
        if (!close_policy_hnd(p, &q_u->alias_pol))
                return NT_STATUS_OBJECT_NAME_INVALID;
@@ -3406,13 +3888,19 @@ NTSTATUS _samr_create_dom_group(pipes_struct *p, SAMR_Q_CREATE_DOM_GROUP *q_u, S
        struct group *grp;
        struct samr_info *info;
        PRIVILEGE_SET priv_set;
+       uint32 acc_granted;
+       gid_t gid;
 
        init_privilege(&priv_set);
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &dom_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &dom_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_CREATE_GROUP, "_samr_create_dom_group"))) {
+               return r_u->status;
+       }
+               
        if (!sid_equal(&dom_sid, get_global_sam_sid()))
                return NT_STATUS_ACCESS_DENIED;
 
@@ -3425,10 +3913,11 @@ NTSTATUS _samr_create_dom_group(pipes_struct *p, SAMR_Q_CREATE_DOM_GROUP *q_u, S
                return NT_STATUS_GROUP_EXISTS;
 
        /* we can create the UNIX group */
-       smb_create_group(name);
+       if (smb_create_group(name, &gid) != 0)
+               return NT_STATUS_ACCESS_DENIED;
 
        /* check if the group has been successfully created */
-       if ((grp=getgrnam(name)) == NULL)
+       if ((grp=getgrgid(gid)) == NULL)
                return NT_STATUS_ACCESS_DENIED;
 
        r_u->rid=pdb_gid_to_group_rid(grp->gr_gid);
@@ -3464,13 +3953,19 @@ NTSTATUS _samr_create_dom_alias(pipes_struct *p, SAMR_Q_CREATE_DOM_ALIAS *q_u, S
        struct group *grp;
        struct samr_info *info;
        PRIVILEGE_SET priv_set;
+       uint32 acc_granted;
+       gid_t gid;
 
        init_privilege(&priv_set);
 
        /* Find the policy handle. Open a policy on it. */
-       if (!get_lsa_policy_samr_sid(p, &q_u->dom_pol, &dom_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->dom_pol, &dom_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+               
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_CREATE_ALIAS, "_samr_create_alias"))) {
+               return r_u->status;
+       }
+               
        if (!sid_equal(&dom_sid, get_global_sam_sid()))
                return NT_STATUS_ACCESS_DENIED;
 
@@ -3483,10 +3978,11 @@ NTSTATUS _samr_create_dom_alias(pipes_struct *p, SAMR_Q_CREATE_DOM_ALIAS *q_u, S
                return NT_STATUS_GROUP_EXISTS;
 
        /* we can create the UNIX group */
-       smb_create_group(name);
+       if (smb_create_group(name, &gid) != 0)
+               return NT_STATUS_ACCESS_DENIED;
 
        /* check if the group has been successfully created */
-       if ((grp=getgrnam(name)) == NULL)
+       if ((grp=getgrgid(gid)) == NULL)
                return NT_STATUS_ACCESS_DENIED;
 
        r_u->rid=pdb_gid_to_group_rid(grp->gr_gid);
@@ -3523,10 +4019,15 @@ NTSTATUS _samr_query_groupinfo(pipes_struct *p, SAMR_Q_QUERY_GROUPINFO *q_u, SAM
        uid_t *uid=NULL;
        int num_uids=0;
        GROUP_INFO_CTR *ctr;
+       uint32 acc_granted;
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_GROUP_LOOKUP_INFO, "_samr_query_groupinfo"))) {
+               return r_u->status;
+       }
+               
        if (!get_domain_group_from_sid(group_sid, &map, MAPPING_WITHOUT_PRIV))
                return NT_STATUS_INVALID_HANDLE;
 
@@ -3570,10 +4071,15 @@ NTSTATUS _samr_set_groupinfo(pipes_struct *p, SAMR_Q_SET_GROUPINFO *q_u, SAMR_R_
        DOM_SID group_sid;
        GROUP_MAP map;
        GROUP_INFO_CTR *ctr;
+       uint32 acc_granted;
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->pol, &group_sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_GROUP_SET_INFO, "_samr_set_groupinfo"))) {
+               return r_u->status;
+       }
+               
        if (!get_domain_group_from_sid(group_sid, &map, MAPPING_WITH_PRIV))
                return NT_STATUS_NO_SUCH_GROUP;
        
@@ -3591,7 +4097,7 @@ NTSTATUS _samr_set_groupinfo(pipes_struct *p, SAMR_Q_SET_GROUPINFO *q_u, SAMR_R_
                        return NT_STATUS_INVALID_INFO_CLASS;
        }
 
-       if(!add_mapping_entry(&map, TDB_REPLACE)) {
+       if(!pdb_update_group_mapping_entry(&map)) {
                free_privilege(&map.priv_set);
                return NT_STATUS_NO_SUCH_GROUP;
        }
@@ -3602,9 +4108,9 @@ NTSTATUS _samr_set_groupinfo(pipes_struct *p, SAMR_Q_SET_GROUPINFO *q_u, SAMR_R_
 }
 
 /*********************************************************************
- _samr_set_groupinfo
+ _samr_set_aliasinfo
  
- update a domain group's comment.
+ update an alias's comment.
 *********************************************************************/
 
 NTSTATUS _samr_set_aliasinfo(pipes_struct *p, SAMR_Q_SET_ALIASINFO *q_u, SAMR_R_SET_ALIASINFO *r_u)
@@ -3612,10 +4118,15 @@ NTSTATUS _samr_set_aliasinfo(pipes_struct *p, SAMR_Q_SET_ALIASINFO *q_u, SAMR_R_
        DOM_SID group_sid;
        GROUP_MAP map;
        ALIAS_INFO_CTR *ctr;
+       uint32 acc_granted;
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &group_sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->alias_pol, &group_sid, &acc_granted))
                return NT_STATUS_INVALID_HANDLE;
-
+       
+       if (!NT_STATUS_IS_OK(r_u->status = access_check_samr_function(acc_granted, SA_RIGHT_ALIAS_SET_INFO, "_samr_set_aliasinfo"))) {
+               return r_u->status;
+       }
+               
        if (!get_local_group_from_sid(group_sid, &map, MAPPING_WITH_PRIV))
                return NT_STATUS_NO_SUCH_GROUP;
        
@@ -3630,7 +4141,7 @@ NTSTATUS _samr_set_aliasinfo(pipes_struct *p, SAMR_Q_SET_ALIASINFO *q_u, SAMR_R_
                        return NT_STATUS_INVALID_INFO_CLASS;
        }
 
-       if(!add_mapping_entry(&map, TDB_REPLACE)) {
+       if(!pdb_update_group_mapping_entry(&map)) {
                free_privilege(&map.priv_set);
                return NT_STATUS_NO_SUCH_GROUP;
        }
@@ -3671,10 +4182,29 @@ NTSTATUS _samr_open_group(pipes_struct *p, SAMR_Q_OPEN_GROUP *q_u, SAMR_R_OPEN_G
        DOM_SID info_sid;
        GROUP_MAP map;
        struct samr_info *info;
+       SEC_DESC         *psd = NULL;
+       uint32            acc_granted;
+       uint32            des_access;
+       size_t            sd_size;
+       NTSTATUS          status;
        fstring sid_string;
 
-       if (!get_lsa_policy_samr_sid(p, &q_u->domain_pol, &sid)) 
+       if (!get_lsa_policy_samr_sid(p, &q_u->domain_pol, &sid, &acc_granted)) 
                return NT_STATUS_INVALID_HANDLE;
+       
+       if (!NT_STATUS_IS_OK(status = access_check_samr_function(acc_granted, SA_RIGHT_DOMAIN_OPEN_ACCOUNT, "_samr_open_group"))) {
+               return status;
+       }
+               
+       /*check if access can be granted as requested by client. */
+       samr_make_grp_obj_sd(p->mem_ctx, &psd, &sd_size);
+       se_map_generic(&des_access,&grp_generic_mapping);
+       if (!NT_STATUS_IS_OK(status = 
+                            access_check_samr_object(psd, p->pipe_user.nt_user_token, 
+                                                     des_access, &acc_granted, "_samr_open_group"))) {
+               return status;
+       }
+
 
        /* this should not be hard-coded like this */
        if (!sid_equal(&sid, get_global_sam_sid()))
@@ -3686,6 +4216,8 @@ NTSTATUS _samr_open_group(pipes_struct *p, SAMR_Q_OPEN_GROUP *q_u, SAMR_R_OPEN_G
 
        if ((info = get_samr_info_by_sid(&info_sid)) == NULL)
                return NT_STATUS_NO_MEMORY;
+               
+       info->acc_granted = acc_granted;
 
        DEBUG(10, ("_samr_open_group:Opening SID: %s\n", sid_string));
 
@@ -3731,6 +4263,8 @@ NTSTATUS _samr_unknown_2e(pipes_struct *p, SAMR_Q_UNKNOWN_2E *q_u, SAMR_R_UNKNOW
 
        uint32 num_users=0, num_groups=0, num_aliases=0;
 
+       uint32 account_policy_temp;
+
        if ((ctr = (SAM_UNK_CTR *)talloc_zero(p->mem_ctx, sizeof(SAM_UNK_CTR))) == NULL)
                return NT_STATUS_NO_MEMORY;
 
@@ -3746,11 +4280,20 @@ NTSTATUS _samr_unknown_2e(pipes_struct *p, SAMR_Q_UNKNOWN_2E *q_u, SAMR_R_UNKNOW
 
        switch (q_u->switch_value) {
                case 0x01:
-                       account_policy_get(AP_MIN_PASSWORD_LEN, &min_pass_len);
-                       account_policy_get(AP_PASSWORD_HISTORY, &pass_hist);
-                       account_policy_get(AP_USER_MUST_LOGON_TO_CHG_PASS, &flag);
-                       account_policy_get(AP_MAX_PASSWORD_AGE, (int *)&u_expire);
-                       account_policy_get(AP_MIN_PASSWORD_AGE, (int *)&u_min_age);
+                       account_policy_get(AP_MIN_PASSWORD_LEN, &account_policy_temp);
+                       min_pass_len = account_policy_temp;
+
+                       account_policy_get(AP_PASSWORD_HISTORY, &account_policy_temp);
+                       pass_hist = account_policy_temp;
+
+                       account_policy_get(AP_USER_MUST_LOGON_TO_CHG_PASS, &account_policy_temp);
+                       flag = account_policy_temp;
+
+                       account_policy_get(AP_MAX_PASSWORD_AGE, &account_policy_temp);
+                       u_expire = account_policy_temp;
+
+                       account_policy_get(AP_MIN_PASSWORD_AGE, &account_policy_temp);
+                       u_min_age = account_policy_temp;
 
                        unix_to_nt_time_abs(&nt_expire, u_expire);
                        unix_to_nt_time_abs(&nt_min_age, u_min_age);
@@ -3760,10 +4303,10 @@ NTSTATUS _samr_unknown_2e(pipes_struct *p, SAMR_Q_UNKNOWN_2E *q_u, SAMR_R_UNKNOW
                        break;
                case 0x02:
                        become_root();          
-                       r_u->status=load_sampwd_entries(info, ACB_NORMAL);
+                       r_u->status=load_sampwd_entries(info, ACB_NORMAL, False);
                        unbecome_root();
                        if (!NT_STATUS_IS_OK(r_u->status)) {
-                               DEBUG(5, ("_samr_query_dispinfo: load_sampwd_entries failed\n"));
+                               DEBUG(5, ("_samr_unknown_2e: load_sampwd_entries failed\n"));
                                return r_u->status;
                        }
                        num_users=info->disp_info.num_user_account;
@@ -3771,24 +4314,26 @@ NTSTATUS _samr_unknown_2e(pipes_struct *p, SAMR_Q_UNKNOWN_2E *q_u, SAMR_R_UNKNOW
                        
                        r_u->status=load_group_domain_entries(info, get_global_sam_sid());
                        if (NT_STATUS_IS_ERR(r_u->status)) {
-                               DEBUG(5, ("_samr_query_dispinfo: load_group_domain_entries failed\n"));
+                               DEBUG(5, ("_samr_unknown_2e: load_group_domain_entries failed\n"));
                                return r_u->status;
                        }
                        num_groups=info->disp_info.num_group_account;
                        free_samr_db(info);
 
                        /* The time call below is to get a sequence number for the sam. FIXME !!! JRA. */
-                       init_unk_info2(&ctr->info.inf2, global_myworkgroup, global_myname, (uint32) time(NULL), 
+                       init_unk_info2(&ctr->info.inf2, lp_workgroup(), global_myname(), (uint32) time(NULL), 
                                       num_users, num_groups, num_aliases);
                        break;
                case 0x03:
-                       account_policy_get(AP_TIME_TO_LOGOUT, (int *)&u_logout);
+                       account_policy_get(AP_TIME_TO_LOGOUT, &account_policy_temp);
+                       u_logout = account_policy_temp;
+
                        unix_to_nt_time_abs(&nt_logout, u_logout);
                        
                        init_unk_info3(&ctr->info.inf3, nt_logout);
                        break;
                case 0x05:
-                       init_unk_info5(&ctr->info.inf5, global_myname);
+                       init_unk_info5(&ctr->info.inf5, global_myname());
                        break;
                case 0x06:
                        init_unk_info6(&ctr->info.inf6);
@@ -3797,9 +4342,14 @@ NTSTATUS _samr_unknown_2e(pipes_struct *p, SAMR_Q_UNKNOWN_2E *q_u, SAMR_R_UNKNOW
                        init_unk_info7(&ctr->info.inf7);
                        break;
                case 0x0c:
-                       account_policy_get(AP_LOCK_ACCOUNT_DURATION, (int *)&u_lock_duration);
-                       account_policy_get(AP_RESET_COUNT_TIME, (int *)&u_reset_time);
-                       account_policy_get(AP_BAD_ATTEMPT_LOCKOUT, &lockout);
+                       account_policy_get(AP_LOCK_ACCOUNT_DURATION, &account_policy_temp);
+                       u_lock_duration = account_policy_temp;
+
+                       account_policy_get(AP_RESET_COUNT_TIME, &account_policy_temp);
+                       u_reset_time = account_policy_temp;
+
+                       account_policy_get(AP_BAD_ATTEMPT_LOCKOUT, &account_policy_temp);
+                       lockout = account_policy_temp;
        
                        unix_to_nt_time_abs(&nt_lock_duration, u_lock_duration);
                        unix_to_nt_time_abs(&nt_reset_time, u_reset_time);