s3-lsa: add (not yet activate) level specific access checks for _lsa_QueryInfoPolicy.
[ira/wip.git] / source3 / rpc_server / srv_lsa_nt.c
index 9481c206f66b4583cbf61ce2ec7dfa4841d666cc..bbad9b18d20a7fd65e20fc18ecc3407ee9224f5f 100644 (file)
 
 extern PRIVS privs[];
 
+enum lsa_handle_type { LSA_HANDLE_POLICY_TYPE = 1, LSA_HANDLE_ACCOUNT_TYPE };
+
 struct lsa_info {
        DOM_SID sid;
        uint32 access;
+       enum lsa_handle_type type;
+};
+
+const struct generic_mapping lsa_account_mapping = {
+       LSA_ACCOUNT_READ,
+       LSA_ACCOUNT_WRITE,
+       LSA_ACCOUNT_EXECUTE,
+       LSA_ACCOUNT_ALL_ACCESS
 };
 
-const struct generic_mapping lsa_generic_mapping = {
+const struct generic_mapping lsa_policy_mapping = {
        LSA_POLICY_READ,
        LSA_POLICY_WRITE,
        LSA_POLICY_EXECUTE,
@@ -277,26 +287,42 @@ static NTSTATUS lookup_lsa_sids(TALLOC_CTX *mem_ctx,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS lsa_get_generic_sd(TALLOC_CTX *mem_ctx, SEC_DESC **sd, size_t *sd_size)
+static NTSTATUS make_lsa_object_sd(TALLOC_CTX *mem_ctx, SEC_DESC **sd, size_t *sd_size,
+                                       const struct generic_mapping *map,
+                                       DOM_SID *sid, uint32_t sid_access)
 {
-       DOM_SID local_adm_sid;
        DOM_SID adm_sid;
-
-       SEC_ACE ace[3];
+       SEC_ACE ace[5];
+       size_t i = 0;
 
        SEC_ACL *psa = NULL;
 
-       init_sec_ace(&ace[0], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED, LSA_POLICY_EXECUTE, 0);
+       /* READ|EXECUTE access for Everyone */
+
+       init_sec_ace(&ace[i++], &global_sid_World, SEC_ACE_TYPE_ACCESS_ALLOWED,
+                       map->generic_execute | map->generic_read, 0);
+
+       /* Add Full Access 'BUILTIN\Administrators' and 'BUILTIN\Account Operators */
 
+       init_sec_ace(&ace[i++], &global_sid_Builtin_Administrators,
+                       SEC_ACE_TYPE_ACCESS_ALLOWED, map->generic_all, 0);
+       init_sec_ace(&ace[i++], &global_sid_Builtin_Account_Operators,
+                       SEC_ACE_TYPE_ACCESS_ALLOWED, map->generic_all, 0);
+
+       /* Add Full Access for Domain Admins */
        sid_copy(&adm_sid, get_global_sam_sid());
        sid_append_rid(&adm_sid, DOMAIN_GROUP_RID_ADMINS);
-       init_sec_ace(&ace[1], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, LSA_POLICY_ALL_ACCESS, 0);
+       init_sec_ace(&ace[i++], &adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED,
+                       map->generic_all, 0);
+
+       /* If we have a sid, give it some special access */
 
-       sid_copy(&local_adm_sid, &global_sid_Builtin);
-       sid_append_rid(&local_adm_sid, BUILTIN_ALIAS_RID_ADMINS);
-       init_sec_ace(&ace[2], &local_adm_sid, SEC_ACE_TYPE_ACCESS_ALLOWED, LSA_POLICY_ALL_ACCESS, 0);
+       if (sid) {
+               init_sec_ace(&ace[i++], sid, SEC_ACE_TYPE_ACCESS_ALLOWED,
+                       sid_access, 0);
+       }
 
-       if((psa = make_sec_acl(mem_ctx, NT4_ACL_REVISION, 3, ace)) == NULL)
+       if((psa = make_sec_acl(mem_ctx, NT4_ACL_REVISION, i, ace)) == NULL)
                return NT_STATUS_NO_MEMORY;
 
        if((*sd = make_sec_desc(mem_ctx, SECURITY_DESCRIPTOR_REVISION_1,
@@ -307,49 +333,6 @@ static NTSTATUS lsa_get_generic_sd(TALLOC_CTX *mem_ctx, SEC_DESC **sd, size_t *s
        return NT_STATUS_OK;
 }
 
-#if 0  /* AD DC work in ongoing in Samba 4 */
-
-/***************************************************************************
- Init_dns_dom_info.
-***************************************************************************/
-
-static void init_dns_dom_info(LSA_DNS_DOM_INFO *r_l, const char *nb_name,
-                             const char *dns_name, const char *forest_name,
-                             struct GUID *dom_guid, DOM_SID *dom_sid)
-{
-       if (nb_name && *nb_name) {
-               init_unistr2(&r_l->uni_nb_dom_name, nb_name, UNI_FLAGS_NONE);
-               init_uni_hdr(&r_l->hdr_nb_dom_name, &r_l->uni_nb_dom_name);
-               r_l->hdr_nb_dom_name.uni_max_len += 2;
-               r_l->uni_nb_dom_name.uni_max_len += 1;
-       }
-
-       if (dns_name && *dns_name) {
-               init_unistr2(&r_l->uni_dns_dom_name, dns_name, UNI_FLAGS_NONE);
-               init_uni_hdr(&r_l->hdr_dns_dom_name, &r_l->uni_dns_dom_name);
-               r_l->hdr_dns_dom_name.uni_max_len += 2;
-               r_l->uni_dns_dom_name.uni_max_len += 1;
-       }
-
-       if (forest_name && *forest_name) {
-               init_unistr2(&r_l->uni_forest_name, forest_name, UNI_FLAGS_NONE);
-               init_uni_hdr(&r_l->hdr_forest_name, &r_l->uni_forest_name);
-               r_l->hdr_forest_name.uni_max_len += 2;
-               r_l->uni_forest_name.uni_max_len += 1;
-       }
-
-       /* how do we init the guid ? probably should write an init fn */
-       if (dom_guid) {
-               memcpy(&r_l->dom_guid, dom_guid, sizeof(struct GUID));
-       }
-
-       if (dom_sid) {
-               r_l->ptr_dom_sid = 1;
-               init_dom_sid2(&r_l->dom_sid, dom_sid);
-       }
-}
-#endif /* AD DC work in ongoing in Samba 4 */
-
 
 /***************************************************************************
  _lsa_OpenPolicy2
@@ -365,28 +348,28 @@ NTSTATUS _lsa_OpenPolicy2(pipes_struct *p,
        uint32 acc_granted;
        NTSTATUS status;
 
+       /* Work out max allowed. */
+       map_max_allowed_access(p->server_info->ptok,
+                              &p->server_info->utok,
+                              &des_access);
 
        /* map the generic bits to the lsa policy ones */
-       se_map_generic(&des_access, &lsa_generic_mapping);
+       se_map_generic(&des_access, &lsa_policy_mapping);
 
        /* get the generic lsa policy SD until we store it */
-       lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
-
-       status = se_access_check(psd, p->server_info->ptok, des_access,
-                                &acc_granted);
+       status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size, &lsa_policy_mapping,
+                       NULL, 0);
        if (!NT_STATUS_IS_OK(status)) {
-               if (p->server_info->utok.uid != sec_initial_uid()) {
-                       return status;
-               }
-               DEBUG(4,("ACCESS should be DENIED (granted: %#010x;  required: %#010x)\n",
-                        acc_granted, des_access));
-               DEBUGADD(4,("but overwritten by euid == 0\n"));
+               return status;
        }
 
-       /* This is needed for lsa_open_account and rpcclient .... :-) */
+       status = access_check_object(psd, p->server_info->ptok,
+               NULL, 0, des_access,
+               &acc_granted, "_lsa_OpenPolicy2" );
 
-       if (p->server_info->utok.uid == sec_initial_uid())
-               acc_granted = LSA_POLICY_ALL_ACCESS;
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
        /* associate the domain SID with the (unique) handle. */
        info = TALLOC_ZERO_P(p->mem_ctx, struct lsa_info);
@@ -396,6 +379,7 @@ NTSTATUS _lsa_OpenPolicy2(pipes_struct *p,
 
        sid_copy(&info->sid,get_global_sam_sid());
        info->access = acc_granted;
+       info->type = LSA_HANDLE_POLICY_TYPE;
 
        /* set up the LSA QUERY INFO response */
        if (!create_policy_hnd(p, r->out.handle, info))
@@ -411,46 +395,15 @@ NTSTATUS _lsa_OpenPolicy2(pipes_struct *p,
 NTSTATUS _lsa_OpenPolicy(pipes_struct *p,
                         struct lsa_OpenPolicy *r)
 {
-       struct lsa_info *info;
-       SEC_DESC *psd = NULL;
-       size_t sd_size;
-       uint32 des_access= r->in.access_mask;
-       uint32 acc_granted;
-       NTSTATUS status;
-
-
-       /* map the generic bits to the lsa policy ones */
-       se_map_generic(&des_access, &lsa_generic_mapping);
+       struct lsa_OpenPolicy2 o;
 
-       /* get the generic lsa policy SD until we store it */
-       lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
+       o.in.system_name        = NULL; /* should be ignored */
+       o.in.attr               = r->in.attr;
+       o.in.access_mask        = r->in.access_mask;
 
-       status = se_access_check(psd, p->server_info->ptok, des_access,
-                                &acc_granted);
-       if (!NT_STATUS_IS_OK(status)) {
-               if (p->server_info->utok.uid != sec_initial_uid()) {
-                       return status;
-               }
-               DEBUG(4,("ACCESS should be DENIED (granted: %#010x;  required: %#010x)\n",
-                        acc_granted, des_access));
-               DEBUGADD(4,("but overwritten by euid == 0\n"));
-               acc_granted = des_access;
-       }
+       o.out.handle            = r->out.handle;
 
-       /* associate the domain SID with the (unique) handle. */
-       info = TALLOC_ZERO_P(p->mem_ctx, struct lsa_info);
-       if (info == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       sid_copy(&info->sid,get_global_sam_sid());
-       info->access = acc_granted;
-
-       /* set up the LSA QUERY INFO response */
-       if (!create_policy_hnd(p, r->out.handle, info))
-               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
-
-       return NT_STATUS_OK;
+       return _lsa_OpenPolicy2(p, &o);
 }
 
 /***************************************************************************
@@ -482,6 +435,10 @@ NTSTATUS _lsa_EnumTrustDom(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
        if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                return NT_STATUS_ACCESS_DENIED;
@@ -548,17 +505,63 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
        const char *name;
        DOM_SID *sid = NULL;
        union lsa_PolicyInformation *info = NULL;
+       uint32_t acc_required = 0;
 
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       switch (r->in.level) {
+       case LSA_POLICY_INFO_AUDIT_LOG:
+       case LSA_POLICY_INFO_AUDIT_EVENTS:
+               acc_required = LSA_POLICY_VIEW_AUDIT_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_DOMAIN:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_PD:
+               acc_required = LSA_POLICY_GET_PRIVATE_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_ACCOUNT_DOMAIN:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_ROLE:
+       case LSA_POLICY_INFO_REPLICA:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_QUOTA:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_MOD:
+       case LSA_POLICY_INFO_AUDIT_FULL_SET:
+               /* according to MS-LSAD 3.1.4.4.3 */
+               return NT_STATUS_INVALID_PARAMETER;
+       case LSA_POLICY_INFO_AUDIT_FULL_QUERY:
+               acc_required = LSA_POLICY_VIEW_AUDIT_INFORMATION;
+               break;
+       case LSA_POLICY_INFO_DNS:
+       case LSA_POLICY_INFO_DNS_INT:
+       case LSA_POLICY_INFO_L_ACCOUNT_DOMAIN:
+               acc_required = LSA_POLICY_VIEW_LOCAL_INFORMATION;
+               break;
+       default:
+               break;
+       }
+
+       if (!(handle->access & acc_required)) {
+               /* return NT_STATUS_ACCESS_DENIED; */
+       }
+
        info = TALLOC_ZERO_P(p->mem_ctx, union lsa_PolicyInformation);
        if (!info) {
                return NT_STATUS_NO_MEMORY;
        }
 
        switch (r->in.level) {
-       case 0x02:
+       case LSA_POLICY_INFO_AUDIT_EVENTS:
                {
 
                uint32 policy_def = LSA_AUDIT_POLICY_ALL;
@@ -590,7 +593,7 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
 
                break;
                }
-       case 0x03:
+       case LSA_POLICY_INFO_DOMAIN:
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                        return NT_STATUS_ACCESS_DENIED;
@@ -626,7 +629,7 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
                }
                init_dom_query_3(&info->domain, name, sid);
                break;
-       case 0x05:
+       case LSA_POLICY_INFO_ACCOUNT_DOMAIN:
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                        return NT_STATUS_ACCESS_DENIED;
@@ -637,7 +640,7 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
 
                init_dom_query_5(&info->account_domain, name, sid);
                break;
-       case 0x06:
+       case LSA_POLICY_INFO_ROLE:
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                        return NT_STATUS_ACCESS_DENIED;
@@ -659,6 +662,33 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
                                break;
                }
                break;
+       case LSA_POLICY_INFO_DNS:
+       case LSA_POLICY_INFO_DNS_INT: {
+               struct pdb_domain_info *dominfo;
+
+               if ((pdb_capabilities() & PDB_CAP_ADS) == 0) {
+                       DEBUG(10, ("Not replying to LSA_POLICY_INFO_DNS "
+                                  "without ADS passdb backend\n"));
+                       status = NT_STATUS_INVALID_INFO_CLASS;
+                       break;
+               }
+
+               dominfo = pdb_get_domain_info(info);
+               if (dominfo == NULL) {
+                       status = NT_STATUS_NO_MEMORY;
+                       break;
+               }
+
+               init_lsa_StringLarge(&info->dns.name,
+                                    dominfo->name);
+               init_lsa_StringLarge(&info->dns.dns_domain,
+                                    dominfo->dns_domain);
+               init_lsa_StringLarge(&info->dns.dns_forest,
+                                    dominfo->dns_forest);
+               info->dns.domain_guid = dominfo->guid;
+               info->dns.sid = &dominfo->sid;
+               break;
+       }
        default:
                DEBUG(0,("_lsa_QueryInfoPolicy: unknown info level in Lsa Query: %d\n",
                        r->in.level));
@@ -671,6 +701,28 @@ NTSTATUS _lsa_QueryInfoPolicy(pipes_struct *p,
        return status;
 }
 
+/***************************************************************************
+ _lsa_QueryInfoPolicy2
+ ***************************************************************************/
+
+NTSTATUS _lsa_QueryInfoPolicy2(pipes_struct *p,
+                              struct lsa_QueryInfoPolicy2 *r2)
+{
+       struct lsa_QueryInfoPolicy r;
+
+       if ((pdb_capabilities() & PDB_CAP_ADS) == 0) {
+               p->rng_fault_state = True;
+               return NT_STATUS_NOT_IMPLEMENTED;
+       }
+
+       ZERO_STRUCT(r);
+       r.in.handle = r2->in.handle;
+       r.in.level = r2->in.level;
+       r.out.info = r2->out.info;
+
+       return _lsa_QueryInfoPolicy(p, &r);
+}
+
 /***************************************************************************
  _lsa_lookup_sids_internal
  ***************************************************************************/
@@ -807,6 +859,10 @@ NTSTATUS _lsa_LookupSids(pipes_struct *p,
                return NT_STATUS_INVALID_HANDLE;
        }
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
        if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                return NT_STATUS_ACCESS_DENIED;
@@ -893,6 +949,10 @@ NTSTATUS _lsa_LookupSids2(pipes_struct *p,
                        return NT_STATUS_INVALID_HANDLE;
                }
 
+               if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+                       return NT_STATUS_INVALID_HANDLE;
+               }
+
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                        return NT_STATUS_ACCESS_DENIED;
@@ -1025,6 +1085,10 @@ NTSTATUS _lsa_LookupNames(pipes_struct *p,
                goto done;
        }
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
        if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                status = NT_STATUS_ACCESS_DENIED;
@@ -1089,6 +1153,7 @@ NTSTATUS _lsa_LookupNames2(pipes_struct *p,
 
        status = _lsa_LookupNames(p, &q);
 
+       sid_array2->count = sid_array->count;
        sid_array2->sids = TALLOC_ARRAY(p->mem_ctx, struct lsa_TranslatedSid2, sid_array->count);
        if (!sid_array2->sids) {
                return NT_STATUS_NO_MEMORY;
@@ -1164,6 +1229,10 @@ NTSTATUS _lsa_LookupNames3(pipes_struct *p,
                        goto done;
                }
 
+               if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+                       return NT_STATUS_INVALID_HANDLE;
+               }
+
                /* check if the user has enough rights */
                if (!(handle->access & LSA_POLICY_LOOKUP_NAMES)) {
                        status = NT_STATUS_ACCESS_DENIED;
@@ -1289,7 +1358,34 @@ NTSTATUS _lsa_SetSecret(pipes_struct *p, struct lsa_SetSecret *r)
 NTSTATUS _lsa_DeleteObject(pipes_struct *p,
                           struct lsa_DeleteObject *r)
 {
-       return NT_STATUS_ACCESS_DENIED;
+       NTSTATUS status;
+       struct lsa_info *info = NULL;
+
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info)) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & STD_RIGHT_DELETE_ACCESS)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       switch (info->type) {
+       case LSA_HANDLE_ACCOUNT_TYPE:
+               status = privilege_delete_account(&info->sid);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(10,("_lsa_DeleteObject: privilege_delete_account gave: %s\n",
+                               nt_errstr(status)));
+                       return status;
+               }
+               break;
+       default:
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       close_policy_hnd(p, r->in.handle);
+       ZERO_STRUCTP(r->out.handle);
+
+       return status;
 }
 
 /***************************************************************************
@@ -1317,6 +1413,10 @@ NTSTATUS _lsa_EnumPrivs(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights
           I don't know if it's the right one. not documented.  */
 
@@ -1373,6 +1473,10 @@ NTSTATUS _lsa_LookupPrivDisplayName(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
 
        /*
@@ -1420,6 +1524,10 @@ NTSTATUS _lsa_EnumAccounts(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
                return NT_STATUS_ACCESS_DENIED;
 
@@ -1536,21 +1644,17 @@ NTSTATUS _lsa_CreateAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
        /* check if the user has enough rights */
 
        /*
         * I don't know if it's the right one. not documented.
         * but guessed with rpcclient.
         */
-       if (!(handle->access & LSA_POLICY_GET_PRIVATE_INFORMATION))
-               return NT_STATUS_ACCESS_DENIED;
-
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
-
-       if ( p->server_info->utok.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->server_info->ptok,
-                                              DOMAIN_GROUP_RID_ADMINS ) )
+       if (!(handle->access & LSA_POLICY_CREATE_ACCOUNT))
                return NT_STATUS_ACCESS_DENIED;
 
        if ( is_privileged_sid( r->in.sid ) )
@@ -1565,6 +1669,7 @@ NTSTATUS _lsa_CreateAccount(pipes_struct *p,
 
        info->sid = *r->in.sid;
        info->access = r->in.access_mask;
+       info->type = LSA_HANDLE_ACCOUNT_TYPE;
 
        /* get a (unique) handle.  open a policy on it. */
        if (!create_policy_hnd(p, r->out.acct_handle, info))
@@ -1573,7 +1678,6 @@ NTSTATUS _lsa_CreateAccount(pipes_struct *p,
        return privilege_create_account( &info->sid );
 }
 
-
 /***************************************************************************
  _lsa_OpenAccount
  ***************************************************************************/
@@ -1583,19 +1687,46 @@ NTSTATUS _lsa_OpenAccount(pipes_struct *p,
 {
        struct lsa_info *handle;
        struct lsa_info *info;
+       SEC_DESC *psd = NULL;
+       size_t sd_size;
+       uint32_t des_access = r->in.access_mask;
+       uint32_t acc_granted;
+       NTSTATUS status;
 
        /* find the connection policy handle. */
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check if the user has enough rights */
+       if (handle->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       /*
-        * I don't know if it's the right one. not documented.
-        * but guessed with rpcclient.
-        */
-       if (!(handle->access & LSA_POLICY_GET_PRIVATE_INFORMATION))
-               return NT_STATUS_ACCESS_DENIED;
+       /* des_access is for the account here, not the policy
+        * handle - so don't check against policy handle. */
+
+       /* Work out max allowed. */
+       map_max_allowed_access(p->server_info->ptok,
+                              &p->server_info->utok,
+                              &des_access);
+
+       /* map the generic bits to the lsa account ones */
+       se_map_generic(&des_access, &lsa_account_mapping);
+
+       /* get the generic lsa account SD until we store it */
+       status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                               &lsa_account_mapping,
+                               r->in.sid, LSA_ACCOUNT_ALL_ACCESS);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       status = access_check_object(psd, p->server_info->ptok,
+               NULL, 0, des_access,
+               &acc_granted, "_lsa_OpenAccount" );
+
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
        /* TODO: Fis the parsing routine before reenabling this check! */
        #if 0
@@ -1609,7 +1740,8 @@ NTSTATUS _lsa_OpenAccount(pipes_struct *p,
        }
 
        info->sid = *r->in.sid;
-       info->access = r->in.access_mask;
+       info->access = acc_granted;
+       info->type = LSA_HANDLE_ACCOUNT_TYPE;
 
        /* get a (unique) handle.  open a policy on it. */
        if (!create_policy_hnd(p, r->out.acct_handle, info))
@@ -1638,26 +1770,29 @@ NTSTATUS _lsa_EnumPrivsAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_ACCOUNT_VIEW))
                return NT_STATUS_ACCESS_DENIED;
 
-       if ( !get_privileges_for_sids( &mask, &info->sid, 1 ) )
-               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+       get_privileges_for_sids(&mask, &info->sid, 1);
 
        privilege_set_init( &privileges );
 
+       priv_set = TALLOC_ZERO_P(p->mem_ctx, struct lsa_PrivilegeSet);
+       if (!priv_set) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+
        if ( se_priv_to_privilege_set( &privileges, &mask ) ) {
 
                DEBUG(10,("_lsa_EnumPrivsAccount: %s has %d privileges\n",
                          sid_string_dbg(&info->sid),
                          privileges.count));
 
-               priv_set = TALLOC_ZERO_P(p->mem_ctx, struct lsa_PrivilegeSet);
-               if (!priv_set) {
-                       status = NT_STATUS_NO_MEMORY;
-                       goto done;
-               }
-
                luid_attrs = TALLOC_ZERO_ARRAY(p->mem_ctx,
                                               struct lsa_LUIDAttribute,
                                               privileges.count);
@@ -1676,11 +1811,14 @@ NTSTATUS _lsa_EnumPrivsAccount(pipes_struct *p,
                priv_set->unknown = 0;
                priv_set->set = luid_attrs;
 
-               *r->out.privs = priv_set;
        } else {
-               status = NT_STATUS_NO_SUCH_PRIVILEGE;
+               priv_set->count = 0;
+               priv_set->unknown = 0;
+               priv_set->set = NULL;
        }
 
+       *r->out.privs = priv_set;
+
  done:
        privilege_set_free( &privileges );
 
@@ -1694,19 +1832,43 @@ NTSTATUS _lsa_EnumPrivsAccount(pipes_struct *p,
 NTSTATUS _lsa_GetSystemAccessAccount(pipes_struct *p,
                                     struct lsa_GetSystemAccessAccount *r)
 {
-       struct lsa_info *info=NULL;
+       NTSTATUS status;
+       struct lsa_info *info = NULL;
+       struct lsa_EnumPrivsAccount e;
+       struct lsa_PrivilegeSet *privset;
 
        /* find the connection policy handle. */
 
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
-               return NT_STATUS_ACCESS_DENIED;
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       if (!lookup_sid(p->mem_ctx, &info->sid, NULL, NULL, NULL))
+       if (!(info->access & LSA_ACCOUNT_VIEW))
                return NT_STATUS_ACCESS_DENIED;
 
+       privset = talloc_zero(p->mem_ctx, struct lsa_PrivilegeSet);
+       if (!privset) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       e.in.handle = r->in.handle;
+       e.out.privs = &privset;
+
+       status = _lsa_EnumPrivsAccount(p, &e);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10,("_lsa_GetSystemAccessAccount: "
+                       "failed to call _lsa_EnumPrivsAccount(): %s\n",
+                       nt_errstr(status)));
+               return status;
+       }
+
+       /* Samba4 would iterate over the privset to merge the policy mode bits,
+        * not sure samba3 can do the same here, so just return what we did in
+        * the past - gd */
+
        /*
          0x01 -> Log on locally
          0x02 -> Access this computer from network
@@ -1716,7 +1878,8 @@ NTSTATUS _lsa_GetSystemAccessAccount(pipes_struct *p,
          they can be ORed together
        */
 
-       *r->out.access_mask = PR_LOG_ON_LOCALLY | PR_ACCESS_FROM_NETWORK;
+       *r->out.access_mask = LSA_POLICY_MODE_INTERACTIVE |
+                             LSA_POLICY_MODE_NETWORK;
 
        return NT_STATUS_OK;
 }
@@ -1735,13 +1898,13 @@ NTSTATUS _lsa_SetSystemAccessAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       if ( p->server_info->utok.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->server_info->ptok,
-                                              DOMAIN_GROUP_RID_ADMINS ) )
+       if (!(info->access & LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS)) {
                return NT_STATUS_ACCESS_DENIED;
+       }
 
        if (!pdb_getgrsid(&map, info->sid))
                return NT_STATUS_NO_SUCH_GROUP;
@@ -1765,13 +1928,11 @@ NTSTATUS _lsa_AddPrivilegesToAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is root or a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       if ( p->server_info->utok.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->server_info->ptok,
-                                              DOMAIN_GROUP_RID_ADMINS ) )
-       {
+       if (!(info->access & LSA_ACCOUNT_ADJUST_PRIVILEGES)) {
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -1806,13 +1967,11 @@ NTSTATUS _lsa_RemovePrivilegesFromAccount(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is root or a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
+       if (info->type != LSA_HANDLE_ACCOUNT_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
-       if ( p->server_info->utok.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->server_info->ptok,
-                                              DOMAIN_GROUP_RID_ADMINS ) )
-       {
+       if (!(info->access & LSA_ACCOUNT_ADJUST_PRIVILEGES)) {
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -1833,121 +1992,88 @@ NTSTATUS _lsa_RemovePrivilegesFromAccount(pipes_struct *p,
 }
 
 /***************************************************************************
- _lsa_QuerySecurity
+ _lsa_LookupPrivName
  ***************************************************************************/
 
-NTSTATUS _lsa_QuerySecurity(pipes_struct *p,
-                           struct lsa_QuerySecurity *r)
+NTSTATUS _lsa_LookupPrivName(pipes_struct *p,
+                            struct lsa_LookupPrivName *r)
 {
-       struct lsa_info *handle=NULL;
-       SEC_DESC *psd = NULL;
-       size_t sd_size;
-       NTSTATUS status;
+       struct lsa_info *info = NULL;
+       const char *name;
+       struct lsa_StringLarge *lsa_name;
 
        /* find the connection policy handle. */
-       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info)) {
                return NT_STATUS_INVALID_HANDLE;
+       }
 
-       /* check if the user has enough rights */
-       if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
-               return NT_STATUS_ACCESS_DENIED;
-
-       switch (r->in.sec_info) {
-       case 1:
-               /* SD contains only the owner */
-
-               status=lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
-               if(!NT_STATUS_IS_OK(status))
-                       return NT_STATUS_NO_MEMORY;
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
 
+       if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
 
-               if((*r->out.sdbuf = make_sec_desc_buf(p->mem_ctx, sd_size, psd)) == NULL)
-                       return NT_STATUS_NO_MEMORY;
-               break;
-       case 4:
-               /* SD contains only the ACL */
+       name = luid_to_privilege_name((LUID *)r->in.luid);
+       if (!name) {
+               return NT_STATUS_NO_SUCH_PRIVILEGE;
+       }
 
-               status=lsa_get_generic_sd(p->mem_ctx, &psd, &sd_size);
-               if(!NT_STATUS_IS_OK(status))
-                       return NT_STATUS_NO_MEMORY;
+       lsa_name = TALLOC_ZERO_P(p->mem_ctx, struct lsa_StringLarge);
+       if (!lsa_name) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
-               if((*r->out.sdbuf = make_sec_desc_buf(p->mem_ctx, sd_size, psd)) == NULL)
-                       return NT_STATUS_NO_MEMORY;
-               break;
-       default:
-               return NT_STATUS_INVALID_LEVEL;
+       lsa_name->string = talloc_strdup(lsa_name, name);
+       if (!lsa_name->string) {
+               TALLOC_FREE(lsa_name);
+               return NT_STATUS_NO_MEMORY;
        }
 
-       return status;
-}
+       *r->out.name = lsa_name;
 
-#if 0  /* AD DC work in ongoing in Samba 4 */
+       return NT_STATUS_OK;
+}
 
 /***************************************************************************
+ _lsa_QuerySecurity
  ***************************************************************************/
 
- NTSTATUS _lsa_query_info2(pipes_struct *p, LSA_Q_QUERY_INFO2 *q_u, LSA_R_QUERY_INFO2 *r_u)
+NTSTATUS _lsa_QuerySecurity(pipes_struct *p,
+                           struct lsa_QuerySecurity *r)
 {
-       struct lsa_info *handle;
-       const char *nb_name;
-       char *dns_name = NULL;
-       char *forest_name = NULL;
-       DOM_SID *sid = NULL;
-       struct GUID guid;
-       fstring dnsdomname;
-
-       ZERO_STRUCT(guid);
-       r_u->status = NT_STATUS_OK;
+       struct lsa_info *handle=NULL;
+       SEC_DESC *psd = NULL;
+       size_t sd_size;
+       NTSTATUS status;
 
-       if (!find_policy_by_hnd(p, &q_u->pol, (void **)(void *)&handle))
+       /* find the connection policy handle. */
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&handle))
                return NT_STATUS_INVALID_HANDLE;
 
-       switch (q_u->info_class) {
-       case 0x0c:
-               /* check if the user has enough rights */
-               if (!(handle->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
-                       return NT_STATUS_ACCESS_DENIED;
-
-               /* Request PolicyPrimaryDomainInformation. */
-               switch (lp_server_role()) {
-                       case ROLE_DOMAIN_PDC:
-                       case ROLE_DOMAIN_BDC:
-                               nb_name = get_global_sam_name();
-                               /* ugly temp hack for these next two */
-
-                               /* This should be a 'netbios domain -> DNS domain' mapping */
-                               dnsdomname = get_mydnsdomname(p->mem_ctx);
-                               if (!dnsdomname || !*dnsdomname) {
-                                       return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
-                               }
-                               strlower_m(dnsdomname);
-
-                               dns_name = dnsdomname;
-                               forest_name = dnsdomname;
+       if (handle->type == LSA_HANDLE_POLICY_TYPE) {
+               status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                               &lsa_policy_mapping, NULL, 0);
+       } else if (handle->type == LSA_HANDLE_ACCOUNT_TYPE) {
+               status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                               &lsa_account_mapping,
+                               &handle->sid, LSA_ACCOUNT_ALL_ACCESS);
+       } else {
+               status = NT_STATUS_INVALID_HANDLE;
+       }
 
-                               sid = get_global_sam_sid();
-                               secrets_fetch_domain_guid(lp_workgroup(), &guid);
-                               break;
-                       default:
-                               return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
-               }
-               init_dns_dom_info(&r_u->info.dns_dom_info, nb_name, dns_name,
-                                 forest_name,&guid,sid);
-               break;
-       default:
-               DEBUG(0,("_lsa_query_info2: unknown info level in Lsa Query: %d\n", q_u->info_class));
-               r_u->status = NT_STATUS_INVALID_INFO_CLASS;
-               break;
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       if (NT_STATUS_IS_OK(r_u->status)) {
-               r_u->ptr = 0x1;
-               r_u->info_class = q_u->info_class;
+       *r->out.sdbuf = make_sec_desc_buf(p->mem_ctx, sd_size, psd);
+       if (!*r->out.sdbuf) {
+               return NT_STATUS_NO_MEMORY;
        }
 
-       return r_u->status;
+       return status;
 }
-#endif /* AD DC work in ongoing in Samba 4 */
 
 /***************************************************************************
  _lsa_AddAccountRights
@@ -1958,22 +2084,43 @@ NTSTATUS _lsa_AddAccountRights(pipes_struct *p,
 {
        struct lsa_info *info = NULL;
        int i = 0;
+       uint32_t acc_granted = 0;
+       SEC_DESC *psd = NULL;
+       size_t sd_size;
        DOM_SID sid;
+       NTSTATUS status;
 
        /* find the connection policy handle. */
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
-
-       if ( p->server_info->utok.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->server_info->ptok,
-                                              DOMAIN_GROUP_RID_ADMINS ) )
-       {
-               return NT_STATUS_ACCESS_DENIED;
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
        }
 
+        /* get the generic lsa account SD for this SID until we store it */
+        status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                                &lsa_account_mapping,
+                                r->in.sid, LSA_ACCOUNT_ALL_ACCESS);
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
+       /*
+        * From the MS DOCs. If the sid doesn't exist, ask for LSA_POLICY_CREATE_ACCOUNT
+        * on the policy handle. If it does, ask for
+        * LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|LSA_ACCOUNT_VIEW,
+        * on the account sid. We don't check here so just use the latter. JRA.
+        */
+
+        status = access_check_object(psd, p->server_info->ptok,
+                NULL, 0, LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|LSA_ACCOUNT_VIEW,
+                &acc_granted, "_lsa_AddAccountRights" );
+
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
        /* according to an NT4 PDC, you can add privileges to SIDs even without
           call_lsa_create_account() first.  And you can use any arbitrary SID. */
 
@@ -2007,23 +2154,44 @@ NTSTATUS _lsa_RemoveAccountRights(pipes_struct *p,
 {
        struct lsa_info *info = NULL;
        int i = 0;
+       SEC_DESC *psd = NULL;
+       size_t sd_size;
        DOM_SID sid;
        const char *privname = NULL;
+       uint32_t acc_granted = 0;
+       NTSTATUS status;
 
        /* find the connection policy handle. */
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       /* check to see if the pipe_user is a Domain Admin since
-          account_pol.tdb was already opened as root, this is all we have */
-
-       if ( p->server_info->utok.uid != sec_initial_uid()
-               && !nt_token_check_domain_rid( p->server_info->ptok,
-                                              DOMAIN_GROUP_RID_ADMINS ) )
-       {
-               return NT_STATUS_ACCESS_DENIED;
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
        }
 
+        /* get the generic lsa account SD for this SID until we store it */
+        status = make_lsa_object_sd(p->mem_ctx, &psd, &sd_size,
+                                &lsa_account_mapping,
+                                r->in.sid, LSA_ACCOUNT_ALL_ACCESS);
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
+       /*
+        * From the MS DOCs. We need
+        * LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|LSA_ACCOUNT_VIEW
+        * and DELETE on the account sid.
+        */
+
+        status = access_check_object(psd, p->server_info->ptok,
+                NULL, 0, LSA_ACCOUNT_ADJUST_PRIVILEGES|LSA_ACCOUNT_ADJUST_SYSTEM_ACCESS|
+                       LSA_ACCOUNT_VIEW|STD_RIGHT_DELETE_ACCESS,
+                &acc_granted, "_lsa_AddAccountRights" );
+
+        if (!NT_STATUS_IS_OK(status)) {
+                return status;
+        }
+
        sid_copy( &sid, r->in.sid );
 
        if ( r->in.remove_all ) {
@@ -2111,28 +2279,38 @@ NTSTATUS _lsa_EnumAccountRights(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_ACCOUNT_VIEW)) {
                return NT_STATUS_ACCESS_DENIED;
+       }
 
        /* according to an NT4 PDC, you can add privileges to SIDs even without
           call_lsa_create_account() first.  And you can use any arbitrary SID. */
 
        sid_copy( &sid, r->in.sid );
 
-       if ( !get_privileges_for_sids( &mask, &sid, 1 ) )
+       /* according to MS-LSAD 3.1.4.5.10 it is required to return
+        * NT_STATUS_OBJECT_NAME_NOT_FOUND if the account sid was not found in
+        * the lsa database */
+
+       if (!get_privileges_for_sids(&mask, &sid, 1)) {
                return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+       }
 
-       privilege_set_init( &privileges );
+       status = privilege_set_init(&privileges);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
-       if ( se_priv_to_privilege_set( &privileges, &mask ) ) {
+       se_priv_to_privilege_set(&privileges, &mask);
 
-               DEBUG(10,("_lsa_EnumAccountRights: %s has %d privileges\n",
-                         sid_string_dbg(&sid), privileges.count));
+       DEBUG(10,("_lsa_EnumAccountRights: %s has %d privileges\n",
+                 sid_string_dbg(&sid), privileges.count));
 
-               status = init_lsa_right_set(p->mem_ctx, r->out.rights, &privileges);
-       } else {
-               status = NT_STATUS_NO_SUCH_PRIVILEGE;
-       }
+       status = init_lsa_right_set(p->mem_ctx, r->out.rights, &privileges);
 
        privilege_set_free( &privileges );
 
@@ -2156,7 +2334,11 @@ NTSTATUS _lsa_LookupPrivValue(pipes_struct *p,
        if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info))
                return NT_STATUS_INVALID_HANDLE;
 
-       if (!(info->access & LSA_POLICY_VIEW_LOCAL_INFORMATION))
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_POLICY_LOOKUP_NAMES))
                return NT_STATUS_ACCESS_DENIED;
 
        name = r->in.name->string;
@@ -2174,6 +2356,63 @@ NTSTATUS _lsa_LookupPrivValue(pipes_struct *p,
        return NT_STATUS_OK;
 }
 
+/***************************************************************************
+ _lsa_EnumAccountsWithUserRight
+ ***************************************************************************/
+
+NTSTATUS _lsa_EnumAccountsWithUserRight(pipes_struct *p,
+                                       struct lsa_EnumAccountsWithUserRight *r)
+{
+       NTSTATUS status;
+       struct lsa_info *info = NULL;
+       struct dom_sid *sids = NULL;
+       int num_sids = 0;
+       uint32_t i;
+       SE_PRIV mask;
+
+       if (!find_policy_by_hnd(p, r->in.handle, (void **)(void *)&info)) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (info->type != LSA_HANDLE_POLICY_TYPE) {
+               return NT_STATUS_INVALID_HANDLE;
+       }
+
+       if (!(info->access & LSA_POLICY_LOOKUP_NAMES)) {
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       if (!r->in.name || !r->in.name->string) {
+               return NT_STATUS_NO_SUCH_PRIVILEGE;
+       }
+
+       if (!se_priv_from_name(r->in.name->string, &mask)) {
+               return NT_STATUS_NO_SUCH_PRIVILEGE;
+       }
+
+       status = privilege_enum_sids(&mask, p->mem_ctx,
+                                    &sids, &num_sids);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       r->out.sids->num_sids = num_sids;
+       r->out.sids->sids = talloc_array(p->mem_ctx, struct lsa_SidPtr,
+                                        r->out.sids->num_sids);
+
+       for (i=0; i < r->out.sids->num_sids; i++) {
+               r->out.sids->sids[i].sid = sid_dup_talloc(r->out.sids->sids,
+                                                         &sids[i]);
+               if (!r->out.sids->sids[i].sid) {
+                       TALLOC_FREE(r->out.sids->sids);
+                       r->out.sids->num_sids = 0;
+                       return NT_STATUS_NO_MEMORY;
+               }
+       }
+
+       return NT_STATUS_OK;
+}
+
 /*
  * From here on the server routines are just dummy ones to make smbd link with
  * librpc/gen_ndr/srv_lsa.c. These routines are actually never called, we are
@@ -2240,18 +2479,6 @@ NTSTATUS _lsa_QuerySecret(pipes_struct *p, struct lsa_QuerySecret *r)
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_LookupPrivName(pipes_struct *p, struct lsa_LookupPrivName *r)
-{
-       p->rng_fault_state = True;
-       return NT_STATUS_NOT_IMPLEMENTED;
-}
-
-NTSTATUS _lsa_EnumAccountsWithUserRight(pipes_struct *p, struct lsa_EnumAccountsWithUserRight *r)
-{
-       p->rng_fault_state = True;
-       return NT_STATUS_NOT_IMPLEMENTED;
-}
-
 NTSTATUS _lsa_QueryTrustedDomainInfoBySid(pipes_struct *p, struct lsa_QueryTrustedDomainInfoBySid *r)
 {
        p->rng_fault_state = True;
@@ -2282,12 +2509,6 @@ NTSTATUS _lsa_RetrievePrivateData(pipes_struct *p, struct lsa_RetrievePrivateDat
        return NT_STATUS_NOT_IMPLEMENTED;
 }
 
-NTSTATUS _lsa_QueryInfoPolicy2(pipes_struct *p, struct lsa_QueryInfoPolicy2 *r)
-{
-       p->rng_fault_state = True;
-       return NT_STATUS_NOT_IMPLEMENTED;
-}
-
 NTSTATUS _lsa_SetInfoPolicy2(pipes_struct *p, struct lsa_SetInfoPolicy2 *r)
 {
        p->rng_fault_state = True;