Merge branch 'master' of ssh://git.samba.org/data/git/samba into talloc-next
[ira/wip.git] / source3 / printing / printing.c
index b45a31a1c7b2f5937fac805e146d6bc4ea7e9939..fc3667ea3a959ff5a0041ed28ab6a4d99be34d56 100644 (file)
@@ -1,38 +1,37 @@
-/* 
+/*
    Unix SMB/Netbios implementation.
    Version 3.0
    printing backend routines
    Copyright (C) Andrew Tridgell 1992-2000
    Copyright (C) Jeremy Allison 2002
-   
+
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 #include "printing.h"
 
-extern SIG_ATOMIC_T got_sig_term;
-extern SIG_ATOMIC_T reload_after_sighup;
+extern struct current_user current_user;
+extern userdom_struct current_user_info;
 
 /* Current printer interface */
-static BOOL remove_from_jobs_changed(const char* sharename, uint32 jobid);
+static bool remove_from_jobs_changed(const char* sharename, uint32 jobid);
 
-/* 
+/*
    the printing backend revolves around a tdb database that stores the
-   SMB view of the print queue 
-   
+   SMB view of the print queue
+
    The key for this database is a jobid - a internally generated number that
    uniquely identifies a print job
 
@@ -40,16 +39,9 @@ static BOOL remove_from_jobs_changed(const char* sharename, uint32 jobid);
      - possibly running lpq and updating the internal database from that
      - reading entries from the database
 
-   jobids are assigned when a job starts spooling. 
+   jobids are assigned when a job starts spooling.
 */
 
-struct print_queue_update_context {
-       char* sharename;
-       enum printing_types printing_type;
-       char* lpqcommand;
-};
-
-
 static TDB_CONTEXT *rap_tdb;
 static uint16 next_rap_jobid;
 struct rap_jobid_key {
@@ -67,6 +59,7 @@ uint16 pjobid_to_rap(const char* sharename, uint32 jobid)
        uint16 rap_jobid;
        TDB_DATA data, key;
        struct rap_jobid_key jinfo;
+       uint8 buf[2];
 
        DEBUG(10,("pjobid_to_rap: called.\n"));
 
@@ -80,7 +73,7 @@ uint16 pjobid_to_rap(const char* sharename, uint32 jobid)
        ZERO_STRUCT( jinfo );
        fstrcpy( jinfo.sharename, sharename );
        jinfo.jobid = jobid;
-       key.dptr = (char*)&jinfo;
+       key.dptr = (uint8 *)&jinfo;
        key.dsize = sizeof(jinfo);
 
        data = tdb_fetch(rap_tdb, key);
@@ -96,7 +89,8 @@ uint16 pjobid_to_rap(const char* sharename, uint32 jobid)
        rap_jobid = ++next_rap_jobid;
        if (rap_jobid == 0)
                rap_jobid = ++next_rap_jobid;
-       data.dptr = (char *)&rap_jobid;
+       SSVAL(buf,0,rap_jobid);
+       data.dptr = buf;
        data.dsize = sizeof(rap_jobid);
        tdb_store(rap_tdb, key, data, TDB_REPLACE);
        tdb_store(rap_tdb, data, key, TDB_REPLACE);
@@ -106,22 +100,26 @@ uint16 pjobid_to_rap(const char* sharename, uint32 jobid)
        return rap_jobid;
 }
 
-BOOL rap_to_pjobid(uint16 rap_jobid, fstring sharename, uint32 *pjobid)
+bool rap_to_pjobid(uint16 rap_jobid, fstring sharename, uint32 *pjobid)
 {
        TDB_DATA data, key;
+       uint8 buf[2];
 
        DEBUG(10,("rap_to_pjobid called.\n"));
 
        if (!rap_tdb)
                return False;
 
-       key.dptr = (char *)&rap_jobid;
+       SSVAL(buf,0,rap_jobid);
+       key.dptr = buf;
        key.dsize = sizeof(rap_jobid);
        data = tdb_fetch(rap_tdb, key);
-       if ( data.dptr && data.dsize == sizeof(struct rap_jobid_key) ) 
+       if ( data.dptr && data.dsize == sizeof(struct rap_jobid_key) )
        {
                struct rap_jobid_key *jinfo = (struct rap_jobid_key*)data.dptr;
-               fstrcpy( sharename, jinfo->sharename );
+               if (sharename != NULL) {
+                       fstrcpy( sharename, jinfo->sharename );
+               }
                *pjobid = jinfo->jobid;
                DEBUG(10,("rap_to_pjobid: jobid %u maps to RAP jobid %u\n",
                        (unsigned int)*pjobid, (unsigned int)rap_jobid));
@@ -140,6 +138,7 @@ static void rap_jobid_delete(const char* sharename, uint32 jobid)
        TDB_DATA key, data;
        uint16 rap_jobid;
        struct rap_jobid_key jinfo;
+       uint8 buf[2];
 
        DEBUG(10,("rap_jobid_delete: called.\n"));
 
@@ -149,7 +148,7 @@ static void rap_jobid_delete(const char* sharename, uint32 jobid)
        ZERO_STRUCT( jinfo );
        fstrcpy( jinfo.sharename, sharename );
        jinfo.jobid = jobid;
-       key.dptr = (char*)&jinfo;
+       key.dptr = (uint8 *)&jinfo;
        key.dsize = sizeof(jinfo);
 
        data = tdb_fetch(rap_tdb, key);
@@ -165,7 +164,8 @@ static void rap_jobid_delete(const char* sharename, uint32 jobid)
 
        rap_jobid = SVAL(data.dptr, 0);
        SAFE_FREE(data.dptr);
-       data.dptr = (char *)&rap_jobid;
+       SSVAL(buf,0,rap_jobid);
+       data.dptr = buf;
        data.dsize = sizeof(rap_jobid);
        tdb_delete(rap_tdb, key);
        tdb_delete(rap_tdb, data);
@@ -177,16 +177,14 @@ static int get_queue_status(const char* sharename, print_status_struct *);
  Initialise the printing backend. Called once at startup before the fork().
 ****************************************************************************/
 
-BOOL print_backend_init(void)
+bool print_backend_init(struct messaging_context *msg_ctx)
 {
        const char *sversion = "INFO/version";
-       pstring printing_path;
        int services = lp_numservices();
        int snum;
 
-       unlink(lock_path("printing.tdb"));
-       pstrcpy(printing_path,lock_path("printing"));
-       mkdir(printing_path,0755);
+       unlink(cache_path("printing.tdb"));
+       mkdir(cache_path("printing"),0755);
 
        /* handle a Samba upgrade */
 
@@ -198,13 +196,13 @@ BOOL print_backend_init(void)
                pdb = get_print_db_byname(lp_const_servicename(snum));
                if (!pdb)
                        continue;
-               if (tdb_lock_bystring(pdb->tdb, sversion, 0) == -1) {
+               if (tdb_lock_bystring(pdb->tdb, sversion) == -1) {
                        DEBUG(0,("print_backend_init: Failed to open printer %s database\n", lp_const_servicename(snum) ));
                        release_print_db(pdb);
                        return False;
                }
                if (tdb_fetch_int32(pdb->tdb, sversion) != PRINT_DATABASE_VERSION) {
-                       tdb_traverse(pdb->tdb, tdb_traverse_delete_fn, NULL);
+                       tdb_wipe_all(pdb->tdb);
                        tdb_store_int32(pdb->tdb, sversion, PRINT_DATABASE_VERSION);
                }
                tdb_unlock_bystring(pdb->tdb, sversion);
@@ -214,7 +212,7 @@ BOOL print_backend_init(void)
        close_all_print_db(); /* Don't leave any open. */
 
        /* do NT print initialization... */
-       return nt_printing_init();
+       return nt_printing_init(msg_ctx);
 }
 
 /****************************************************************************
@@ -227,10 +225,10 @@ void printing_end(void)
 }
 
 /****************************************************************************
- Retrieve the set of printing functions for a given service.  This allows 
+ Retrieve the set of printing functions for a given service.  This allows
  us to set the printer function table based on the value of the 'printing'
  service parameter.
+
  Use the generic interface as the default and only use cups interface only
  when asked for (and only when supported)
 ****************************************************************************/
@@ -245,14 +243,20 @@ static struct printif *get_printer_fns_from_type( enum printing_types type )
        }
 #endif /* HAVE_CUPS */
 
+#ifdef HAVE_IPRINT
+       if ( type == PRINT_IPRINT ) {
+               printer_fns = &iprint_printif;
+       }
+#endif /* HAVE_IPRINT */
+
        printer_fns->type = type;
-       
+
        return printer_fns;
 }
 
 static struct printif *get_printer_fns( int snum )
 {
-       return get_printer_fns_from_type( lp_printing(snum) );
+       return get_printer_fns_from_type( (enum printing_types)lp_printing(snum) );
 }
 
 
@@ -260,22 +264,21 @@ static struct printif *get_printer_fns( int snum )
  Useful function to generate a tdb key.
 ****************************************************************************/
 
-static TDB_DATA print_key(uint32 jobid)
+static TDB_DATA print_key(uint32 jobid, uint32 *tmp)
 {
-       static uint32 j;
        TDB_DATA ret;
 
-       SIVAL(&j, 0, jobid);
-       ret.dptr = (void *)&j;
-       ret.dsize = sizeof(j);
+       SIVAL(tmp, 0, jobid);
+       ret.dptr = (uint8 *)tmp;
+       ret.dsize = sizeof(*tmp);
        return ret;
 }
 
 /***********************************************************************
- unpack a pjob from a tdb buffer 
+ unpack a pjob from a tdb buffer
 ***********************************************************************/
-int unpack_pjob( char* buf, int buflen, struct printjob *pjob )
+
+int unpack_pjob( uint8 *buf, int buflen, struct printjob *pjob )
 {
        int     len = 0;
        int     used;
@@ -284,7 +287,7 @@ int unpack_pjob( char* buf, int buflen, struct printjob *pjob )
 
        if ( !buf || !pjob )
                return -1;
-               
+
        len += tdb_unpack(buf+len, buflen-len, "dddddddddffff",
                                &pjpid,
                                &pjsysjob,
@@ -299,13 +302,13 @@ int unpack_pjob( char* buf, int buflen, struct printjob *pjob )
                                pjob->jobname,
                                pjob->user,
                                pjob->queuename);
-                               
+
        if ( len == -1 )
                return -1;
-               
+
        if ( (used = unpack_devicemode(&pjob->nt_devmode, buf+len, buflen-len)) == -1 )
                return -1;
-       
+
        len += used;
 
        pjob->pid = pjpid;
@@ -317,7 +320,7 @@ int unpack_pjob( char* buf, int buflen, struct printjob *pjob )
        pjob->page_count = pjpage_count;
        pjob->spooled = pjspooled;
        pjob->smbjob = pjsmbjob;
-       
+
        return len;
 
 }
@@ -329,42 +332,58 @@ int unpack_pjob( char* buf, int buflen, struct printjob *pjob )
 static struct printjob *print_job_find(const char *sharename, uint32 jobid)
 {
        static struct printjob  pjob;
+       uint32_t tmp;
        TDB_DATA                ret;
        struct tdb_print_db     *pdb = get_print_db_byname(sharename);
-       
 
-       if (!pdb)
+       DEBUG(10,("print_job_find: looking up job %u for share %s\n",
+                       (unsigned int)jobid, sharename ));
+
+       if (!pdb) {
                return NULL;
+       }
 
-       ret = tdb_fetch(pdb->tdb, print_key(jobid));
+       ret = tdb_fetch(pdb->tdb, print_key(jobid, &tmp));
        release_print_db(pdb);
 
-       if (!ret.dptr)
+       if (!ret.dptr) {
+               DEBUG(10,("print_job_find: failed to find jobid %u.\n", (unsigned int)jobid ));
                return NULL;
-       
-       if ( pjob.nt_devmode )
+       }
+
+       if ( pjob.nt_devmode ) {
                free_nt_devicemode( &pjob.nt_devmode );
-               
+       }
+
        ZERO_STRUCT( pjob );
-       
+
        if ( unpack_pjob( ret.dptr, ret.dsize, &pjob ) == -1 ) {
+               DEBUG(10,("print_job_find: failed to unpack jobid %u.\n", (unsigned int)jobid ));
                SAFE_FREE(ret.dptr);
                return NULL;
        }
-       
-       SAFE_FREE(ret.dptr);    
+
+       SAFE_FREE(ret.dptr);
+
+       DEBUG(10,("print_job_find: returning system job %d for jobid %u.\n",
+                       (int)pjob.sysjob, (unsigned int)jobid ));
+
        return &pjob;
 }
 
 /* Convert a unix jobid to a smb jobid */
 
-static uint32 sysjob_to_jobid_value;
+struct unixjob_traverse_state {
+       int sysjob;
+       uint32 sysjob_to_jobid_value;
+};
 
 static int unixjob_traverse_fn(TDB_CONTEXT *the_tdb, TDB_DATA key,
-                              TDB_DATA data, void *state)
+                              TDB_DATA data, void *private_data)
 {
        struct printjob *pjob;
-       int *sysjob = (int *)state;
+       struct unixjob_traverse_state *state =
+               (struct unixjob_traverse_state *)private_data;
 
        if (!data.dptr || data.dsize == 0)
                return 0;
@@ -373,10 +392,10 @@ static int unixjob_traverse_fn(TDB_CONTEXT *the_tdb, TDB_DATA key,
        if (key.dsize != sizeof(uint32))
                return 0;
 
-       if (*sysjob == pjob->sysjob) {
+       if (state->sysjob == pjob->sysjob) {
                uint32 jobid = IVAL(key.dptr,0);
 
-               sysjob_to_jobid_value = jobid;
+               state->sysjob_to_jobid_value = jobid;
                return 1;
        }
 
@@ -392,19 +411,23 @@ uint32 sysjob_to_jobid(int unix_jobid)
 {
        int services = lp_numservices();
        int snum;
+       struct unixjob_traverse_state state;
 
-       sysjob_to_jobid_value = (uint32)-1;
+       state.sysjob = unix_jobid;
+       state.sysjob_to_jobid_value = (uint32)-1;
 
        for (snum = 0; snum < services; snum++) {
                struct tdb_print_db *pdb;
                if (!lp_print_ok(snum))
                        continue;
                pdb = get_print_db_byname(lp_const_servicename(snum));
-               if (pdb)
-                       tdb_traverse(pdb->tdb, unixjob_traverse_fn, &unix_jobid);
+               if (!pdb) {
+                       continue;
+               }
+               tdb_traverse(pdb->tdb, unixjob_traverse_fn, &state);
                release_print_db(pdb);
-               if (sysjob_to_jobid_value != (uint32)-1)
-                       return sysjob_to_jobid_value;
+               if (state.sysjob_to_jobid_value != (uint32)-1)
+                       return state.sysjob_to_jobid_value;
        }
        return (uint32)-1;
 }
@@ -413,7 +436,7 @@ uint32 sysjob_to_jobid(int unix_jobid)
  Send notifications based on what has changed after a pjob_store.
 ****************************************************************************/
 
-static struct {
+static const struct {
        uint32 lpq_status;
        uint32 spoolss_status;
 } lpq_to_spoolss_status_map[] = {
@@ -426,7 +449,7 @@ static struct {
        { LPQ_PAPEROUT, JOB_STATUS_PAPEROUT },
        { LPQ_PRINTED, JOB_STATUS_PRINTED },
        { LPQ_DELETED, JOB_STATUS_DELETED },
-       { LPQ_BLOCKED, JOB_STATUS_BLOCKED },
+       { LPQ_BLOCKED, JOB_STATUS_BLOCKED_DEVQ },
        { LPQ_USER_INTERVENTION, JOB_STATUS_USER_INTERVENTION },
        { -1, 0 }
 };
@@ -450,7 +473,7 @@ static uint32 map_to_spoolss_status(uint32 lpq_status)
 static void pjob_store_notify(const char* sharename, uint32 jobid, struct printjob *old_data,
                              struct printjob *new_data)
 {
-       BOOL new_job = False;
+       bool new_job = False;
 
        if (!old_data)
                new_job = True;
@@ -458,13 +481,13 @@ static void pjob_store_notify(const char* sharename, uint32 jobid, struct printj
        /* Job attributes that can't be changed.  We only send
           notification for these on a new job. */
 
-       /* ACHTUNG!  Due to a bug in Samba's spoolss parsing of the 
-          NOTIFY_INFO_DATA buffer, we *have* to send the job submission 
-          time first or else we'll end up with potential alignment 
-          errors.  I don't think the systemtime should be spooled as 
-          a string, but this gets us around that error.   
-          --jerry (i'll feel dirty for this) */
+       /* ACHTUNG!  Due to a bug in Samba's spoolss parsing of the
+          NOTIFY_INFO_DATA buffer, we *have* to send the job submission
+          time first or else we'll end up with potential alignment
+          errors.  I don't think the systemtime should be spooled as
+          a string, but this gets us around that error.
+          --jerry (i'll feel dirty for this) */
+
        if (new_job) {
                notify_job_submitted(sharename, jobid, new_data->starttime);
                notify_job_username(sharename, jobid, new_data->user);
@@ -493,26 +516,27 @@ static void pjob_store_notify(const char* sharename, uint32 jobid, struct printj
  Store a job structure back to the database.
 ****************************************************************************/
 
-static BOOL pjob_store(const char* sharename, uint32 jobid, struct printjob *pjob)
+static bool pjob_store(const char* sharename, uint32 jobid, struct printjob *pjob)
 {
+       uint32_t tmp;
        TDB_DATA                old_data, new_data;
-       BOOL                    ret = False;
+       bool                    ret = False;
        struct tdb_print_db     *pdb = get_print_db_byname(sharename);
-       char                    *buf = NULL;
+       uint8                   *buf = NULL;
        int                     len, newlen, buflen;
-       
+
 
        if (!pdb)
                return False;
 
        /* Get old data */
 
-       old_data = tdb_fetch(pdb->tdb, print_key(jobid));
+       old_data = tdb_fetch(pdb->tdb, print_key(jobid, &tmp));
 
        /* Doh!  Now we have to pack/unpack data since the NT_DEVICEMODE was added */
 
        newlen = 0;
-       
+
        do {
                len = 0;
                buflen = newlen;
@@ -532,27 +556,24 @@ static BOOL pjob_store(const char* sharename, uint32 jobid, struct printjob *pjo
                                pjob->queuename);
 
                len += pack_devicemode(pjob->nt_devmode, buf+len, buflen-len);
-       
-               if (buflen != len) {
-                       char *tb;
 
-                       tb = (char *)SMB_REALLOC(buf, len);
-                       if (!tb) {
+               if (buflen != len) {
+                       buf = (uint8 *)SMB_REALLOC(buf, len);
+                       if (!buf) {
                                DEBUG(0,("pjob_store: failed to enlarge buffer!\n"));
                                goto done;
                        }
-                       else 
-                               buf = tb;
                        newlen = len;
                }
        } while ( buflen != len );
-               
-       
+
+
        /* Store new data */
 
        new_data.dptr = buf;
        new_data.dsize = len;
-       ret = (tdb_store(pdb->tdb, print_key(jobid), new_data, TDB_REPLACE) == 0);
+       ret = (tdb_store(pdb->tdb, print_key(jobid, &tmp), new_data,
+                        TDB_REPLACE) == 0);
 
        release_print_db(pdb);
 
@@ -588,6 +609,7 @@ done:
 
 void pjob_delete(const char* sharename, uint32 jobid)
 {
+       uint32_t tmp;
        struct printjob *pjob;
        uint32 job_status = 0;
        struct tdb_print_db *pdb;
@@ -609,13 +631,13 @@ void pjob_delete(const char* sharename, uint32 jobid)
        /* We must cycle through JOB_STATUS_DELETING and
            JOB_STATUS_DELETED for the port monitor to delete the job
            properly. */
-       
+
        job_status = JOB_STATUS_DELETING|JOB_STATUS_DELETED;
        notify_job_status(sharename, jobid, job_status);
-       
+
        /* Remove from printing.tdb */
 
-       tdb_delete(pdb->tdb, print_key(jobid));
+       tdb_delete(pdb->tdb, print_key(jobid, &tmp));
        remove_from_jobs_changed(sharename, jobid);
        release_print_db( pdb );
        rap_jobid_delete(sharename, jobid);
@@ -648,7 +670,7 @@ static void print_unix_job(const char *sharename, print_queue_struct *q, uint32
 {
        struct printjob pj, *old_pj;
 
-       if (jobid == (uint32)-1) 
+       if (jobid == (uint32)-1)
                jobid = q->job + UNIX_JOB_START;
 
        /* Preserve the timestamp on an existing unix print job */
@@ -684,6 +706,8 @@ struct traverse_struct {
        int qcount, snum, maxcount, total_jobs;
        const char *sharename;
        time_t lpq_time;
+       const char *lprm_command;
+       struct printif *print_if;
 };
 
 /****************************************************************************
@@ -699,7 +723,7 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
 
        if (  key.dsize != sizeof(jobid) )
                return 0;
-               
+
        jobid = IVAL(key.dptr, 0);
        if ( unpack_pjob( data.dptr, data.dsize, &pjob ) == -1 )
                return 0;
@@ -719,7 +743,7 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
                                                (unsigned int)jobid ));
                        pjob_delete(ts->sharename, jobid);
                        return 0;
-               } 
+               }
 
                /* need to continue the the bottom of the function to
                   save the correct attributes */
@@ -730,7 +754,7 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
                /* if a job is not spooled and the process doesn't
                    exist then kill it. This cleans up after smbd
                    deaths */
-               if (!process_exists(pjob.pid)) {
+               if (!process_exists_by_pid(pjob.pid)) {
                        DEBUG(10,("traverse_fn_delete: pjob %u deleted due to !process_exists (%u)\n",
                                                (unsigned int)jobid, (unsigned int)pjob.pid ));
                        pjob_delete(ts->sharename, jobid);
@@ -740,15 +764,44 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
        }
 
        /* this check only makes sense for jobs submitted from Windows clients */
-       
+
        if ( pjob.smbjob ) {
                for (i=0;i<ts->qcount;i++) {
-                       uint32 curr_jobid = print_parse_jobid(ts->queue[i].fs_file);
-                       if (jobid == curr_jobid)
+                       uint32 curr_jobid;
+
+                       if ( pjob.status == LPQ_DELETED )
+                               continue;
+
+                       curr_jobid = print_parse_jobid(ts->queue[i].fs_file);
+
+                       if (jobid == curr_jobid) {
+
+                               /* try to clean up any jobs that need to be deleted */
+
+                               if ( pjob.status == LPQ_DELETING ) {
+                                       int result;
+
+                                       result = (*(ts->print_if->job_delete))(
+                                               ts->sharename, ts->lprm_command, &pjob );
+
+                                       if ( result != 0 ) {
+                                               /* if we can't delete, then reset the job status */
+                                               pjob.status = LPQ_QUEUED;
+                                               pjob_store(ts->sharename, jobid, &pjob);
+                                       }
+                                       else {
+                                               /* if we deleted the job, the remove the tdb record */
+                                               pjob_delete(ts->sharename, jobid);
+                                               pjob.status = LPQ_DELETED;
+                                       }
+
+                               }
+
                                break;
+                       }
                }
        }
-       
+
        /* The job isn't in the system queue - we have to assume it has
           completed, so delete the database entry. */
 
@@ -772,10 +825,11 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
                return 0;
        }
 
-       /* Save the pjob attributes we will store. */
-       /* FIXME!!! This is the only place where queue->job 
+       /* Save the pjob attributes we will store.
+          FIXME!!! This is the only place where queue->job
           represents the SMB jobid      --jerry */
-       ts->queue[i].job = jobid;               
+
+       ts->queue[i].job = jobid;
        ts->queue[i].size = pjob.size;
        ts->queue[i].page_count = pjob.page_count;
        ts->queue[i].status = pjob.status;
@@ -793,10 +847,9 @@ static int traverse_fn_delete(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void
  Check if the print queue has been updated recently enough.
 ****************************************************************************/
 
-static void print_cache_flush(int snum)
+static void print_cache_flush(const char *sharename)
 {
        fstring key;
-       const char *sharename = lp_const_servicename(snum);
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
 
        if (!pdb)
@@ -820,8 +873,7 @@ static pid_t get_updating_pid(const char *sharename)
        if (!pdb)
                return (pid_t)-1;
        slprintf(keystr, sizeof(keystr)-1, "UPDATING/%s", sharename);
-       key.dptr = keystr;
-       key.dsize = strlen(keystr);
+       key = string_tdb_data(keystr);
 
        data = tdb_fetch(pdb->tdb, key);
        release_print_db(pdb);
@@ -833,7 +885,7 @@ static pid_t get_updating_pid(const char *sharename)
        updating_pid = IVAL(data.dptr, 0);
        SAFE_FREE(data.dptr);
 
-       if (process_exists(updating_pid))
+       if (process_exists_by_pid(updating_pid))
                return updating_pid;
 
        return (pid_t)-1;
@@ -844,24 +896,23 @@ static pid_t get_updating_pid(const char *sharename)
  in the tdb.
 ****************************************************************************/
 
-static void set_updating_pid(const fstring sharename, BOOL updating)
+static void set_updating_pid(const fstring sharename, bool updating)
 {
        fstring keystr;
        TDB_DATA key;
        TDB_DATA data;
        pid_t updating_pid = sys_getpid();
        uint8 buffer[4];
-       
+
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
 
        if (!pdb)
                return;
 
        slprintf(keystr, sizeof(keystr)-1, "UPDATING/%s", sharename);
-       key.dptr = keystr;
-       key.dsize = strlen(keystr);
-       
-       DEBUG(5, ("set_updating_pid: %s updating lpq cache for print share %s\n", 
+       key = string_tdb_data(keystr);
+
+       DEBUG(5, ("set_updating_pid: %s updating lpq cache for print share %s\n",
                updating ? "" : "not ",
                sharename ));
 
@@ -870,12 +921,12 @@ static void set_updating_pid(const fstring sharename, BOOL updating)
                release_print_db(pdb);
                return;
        }
-       
+
        SIVAL( buffer, 0, updating_pid);
-       data.dptr = (void *)buffer;
+       data.dptr = buffer;
        data.dsize = 4;         /* we always assume this is a 4 byte value */
 
-       tdb_store(pdb->tdb, key, data, TDB_REPLACE);    
+       tdb_store(pdb->tdb, key, data, TDB_REPLACE);
        release_print_db(pdb);
 }
 
@@ -903,6 +954,7 @@ static int printjob_comp(print_queue_struct *j1, print_queue_struct *j2)
 
 /****************************************************************************
  Store the sorted queue representation for later portmon retrieval.
+ Skip deleted jobs
 ****************************************************************************/
 
 static void store_queue_struct(struct tdb_print_db *pdb, struct traverse_struct *pts)
@@ -912,17 +964,21 @@ static void store_queue_struct(struct tdb_print_db *pdb, struct traverse_struct
        print_queue_struct *queue = pts->queue;
        size_t len;
        size_t i;
-       uint qcount;
+       unsigned int qcount;
 
        if (max_reported_jobs && (max_reported_jobs < pts->qcount))
                pts->qcount = max_reported_jobs;
-       qcount = pts->qcount;
+       qcount = 0;
 
        /* Work out the size. */
        data.dsize = 0;
        data.dsize += tdb_pack(NULL, 0, "d", qcount);
 
        for (i = 0; i < pts->qcount; i++) {
+               if ( queue[i].status == LPQ_DELETED )
+                       continue;
+
+               qcount++;
                data.dsize += tdb_pack(NULL, 0, "ddddddff",
                                (uint32)queue[i].job,
                                (uint32)queue[i].size,
@@ -934,12 +990,15 @@ static void store_queue_struct(struct tdb_print_db *pdb, struct traverse_struct
                                queue[i].fs_file);
        }
 
-       if ((data.dptr = SMB_MALLOC(data.dsize)) == NULL)
+       if ((data.dptr = (uint8 *)SMB_MALLOC(data.dsize)) == NULL)
                return;
 
         len = 0;
        len += tdb_pack(data.dptr + len, data.dsize - len, "d", qcount);
        for (i = 0; i < pts->qcount; i++) {
+               if ( queue[i].status == LPQ_DELETED )
+                       continue;
+
                len += tdb_pack(data.dptr + len, data.dsize - len, "ddddddff",
                                (uint32)queue[i].job,
                                (uint32)queue[i].size,
@@ -990,12 +1049,12 @@ static void check_job_changed(const char *sharename, TDB_DATA data, uint32 jobid
  Check if the print queue has been updated recently enough.
 ****************************************************************************/
 
-static BOOL print_cache_expired(const char *sharename, BOOL check_pending)
+static bool print_cache_expired(const char *sharename, bool check_pending)
 {
        fstring key;
        time_t last_qscan_time, time_now = time(NULL);
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
-       BOOL result = False;
+       bool result = False;
 
        if (!pdb)
                return False;
@@ -1013,35 +1072,36 @@ static BOOL print_cache_expired(const char *sharename, BOOL check_pending)
         * that last lpq scan would stay around for a loooong loooong time... :-). JRA.
         */
 
-       if (last_qscan_time == ((time_t)-1) 
-               || (time_now - last_qscan_time) >= lp_lpqcachetime() 
-               || last_qscan_time > (time_now + MAX_CACHE_VALID_TIME)) 
+       if (last_qscan_time == ((time_t)-1)
+               || (time_now - last_qscan_time) >= lp_lpqcachetime()
+               || last_qscan_time > (time_now + MAX_CACHE_VALID_TIME))
        {
+               uint32 u;
                time_t msg_pending_time;
 
-               DEBUG(4, ("print_cache_expired: cache expired for queue %s " 
-                       "(last_qscan_time = %d, time now = %d, qcachetime = %d)\n", 
-                       sharename, (int)last_qscan_time, (int)time_now, 
+               DEBUG(4, ("print_cache_expired: cache expired for queue %s "
+                       "(last_qscan_time = %d, time now = %d, qcachetime = %d)\n",
+                       sharename, (int)last_qscan_time, (int)time_now,
                        (int)lp_lpqcachetime() ));
 
-               /* check if another smbd has already sent a message to update the 
-                  queue.  Give the pending message one minute to clear and 
-                  then send another message anyways.  Make sure to check for 
+               /* check if another smbd has already sent a message to update the
+                  queue.  Give the pending message one minute to clear and
+                  then send another message anyways.  Make sure to check for
                   clocks that have been run forward and then back again. */
 
                snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
 
-               if ( check_pending 
-                       && tdb_fetch_uint32( pdb->tdb, key, &msg_pending_time ) 
-                       && msg_pending_time > 0
-                       && msg_pending_time <= time_now 
-                       && (time_now - msg_pending_time) < 60 ) 
+               if ( check_pending
+                       && tdb_fetch_uint32( pdb->tdb, key, &u )
+                       && (msg_pending_time=u) > 0
+                       && msg_pending_time <= time_now
+                       && (time_now - msg_pending_time) < 60 )
                {
                        DEBUG(4,("print_cache_expired: message already pending for %s.  Accepting cache\n",
                                sharename));
                        goto done;
                }
-               
+
                result = True;
        }
 
@@ -1054,9 +1114,9 @@ done:
  main work for updating the lpq cahe for a printer queue
 ****************************************************************************/
 
-static void print_queue_update_internal( const char *sharename, 
+static void print_queue_update_internal( const char *sharename,
                                          struct printif *current_printif,
-                                         char *lpq_command )
+                                         char *lpq_command, char *lprm_command )
 {
        int i, qcount;
        print_queue_struct *queue = NULL;
@@ -1068,7 +1128,11 @@ static void print_queue_update_internal( const char *sharename,
        TDB_DATA jcdata;
        fstring keystr, cachestr;
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
-       
+
+       if (!pdb) {
+               return;
+       }
+
        DEBUG(5,("print_queue_update_internal: printer = %s, type = %d, lpq command = [%s]\n",
                sharename, current_printif->type, lpq_command));
 
@@ -1077,18 +1141,18 @@ static void print_queue_update_internal( const char *sharename,
         * attempting to get the lock and doing this
         * if the lpq takes a long time.
         */
-        
+
        slprintf(cachestr, sizeof(cachestr)-1, "CACHE/%s", sharename);
        tdb_store_int32(pdb->tdb, cachestr, (int)time(NULL));
 
         /* get the current queue using the appropriate interface */
        ZERO_STRUCT(status);
 
-       qcount = (*(current_printif->queue_get))(sharename, 
-               current_printif->type, 
+       qcount = (*(current_printif->queue_get))(sharename,
+               current_printif->type,
                lpq_command, &queue, &status);
 
-       DEBUG(3, ("print_queue_update_internal: %d job%s in queue for %s\n", 
+       DEBUG(3, ("print_queue_update_internal: %d job%s in queue for %s\n",
                qcount, (qcount != 1) ? "s" : "", sharename));
 
        /* Sort the queue by submission time otherwise they are displayed
@@ -1102,7 +1166,7 @@ static void print_queue_update_internal( const char *sharename,
          and doesn't exist in the system queue is considered finished
          and removed from the database
 
-         any job in the system database but not in the internal database 
+         any job in the system database but not in the internal database
          is added as a unix job
 
          fill in any system job numbers as we go
@@ -1130,8 +1194,14 @@ static void print_queue_update_internal( const char *sharename,
                }
 
                pjob->sysjob = queue[i].job;
-               pjob->status = queue[i].status;
+
+               /* don't reset the status on jobs to be deleted */
+
+               if ( pjob->status != LPQ_DELETING )
+                       pjob->status = queue[i].status;
+
                pjob_store(sharename, jobid, pjob);
+
                check_job_changed(sharename, jcdata, jobid);
        }
 
@@ -1145,6 +1215,8 @@ static void print_queue_update_internal( const char *sharename,
        tstruct.total_jobs = 0;
        tstruct.lpq_time = time(NULL);
        tstruct.sharename = sharename;
+       tstruct.lprm_command = lprm_command;
+       tstruct.print_if = current_printif;
 
        tdb_traverse(pdb->tdb, traverse_fn_delete, (void *)&tstruct);
 
@@ -1165,13 +1237,12 @@ static void print_queue_update_internal( const char *sharename,
 
        /* store the new queue status structure */
        slprintf(keystr, sizeof(keystr)-1, "STATUS/%s", sharename);
-       key.dptr = keystr;
-       key.dsize = strlen(keystr);
+       key = string_tdb_data(keystr);
 
        status.qcount = qcount;
-       data.dptr = (void *)&status;
+       data.dptr = (uint8 *)&status;
        data.dsize = sizeof(status);
-       tdb_store(pdb->tdb, key, data, TDB_REPLACE);    
+       tdb_store(pdb->tdb, key, data, TDB_REPLACE);
 
        /*
         * Update the cache time again. We want to do this call
@@ -1203,9 +1274,9 @@ static void print_queue_update_internal( const char *sharename,
  smbd processes maytry to update the lpq cache concurrently).
 ****************************************************************************/
 
-static void print_queue_update_with_lock( const char *sharename, 
+static void print_queue_update_with_lock( const char *sharename,
                                           struct printif *current_printif,
-                                          char *lpq_command )
+                                          char *lpq_command, char *lprm_command )
 {
        fstring keystr;
        struct tdb_print_db *pdb;
@@ -1220,7 +1291,7 @@ static void print_queue_update_with_lock( const char *sharename,
                release_print_db(pdb);
                return;
        }
-       
+
        /*
         * Check to see if someone else is doing this update.
         * This is essentially a mutex on the update.
@@ -1235,7 +1306,7 @@ static void print_queue_update_with_lock( const char *sharename,
 
        slprintf(keystr, sizeof(keystr) - 1, "LOCK/%s", sharename);
        /* Only wait 10 seconds for this. */
-       if (tdb_lock_bystring(pdb->tdb, keystr, 10) == -1) {
+       if (tdb_lock_bystring_with_timeout(pdb->tdb, keystr, 10) == -1) {
                DEBUG(0,("print_queue_update_with_lock: Failed to lock printer %s database\n", sharename));
                release_print_db(pdb);
                return;
@@ -1271,9 +1342,10 @@ static void print_queue_update_with_lock( const char *sharename,
        tdb_unlock_bystring(pdb->tdb, keystr);
 
        /* do the main work now */
-       
-       print_queue_update_internal( sharename, current_printif, lpq_command );
-       
+
+       print_queue_update_internal( sharename, current_printif,
+               lpq_command, lprm_command );
+
        /* Delete our pid from the db. */
        set_updating_pid(sharename, False);
        release_print_db(pdb);
@@ -1282,30 +1354,36 @@ static void print_queue_update_with_lock( const char *sharename,
 /****************************************************************************
 this is the receive function of the background lpq updater
 ****************************************************************************/
-static void print_queue_receive(int msg_type, pid_t src, void *buf, size_t msglen)
+static void print_queue_receive(struct messaging_context *msg,
+                               void *private_data,
+                               uint32_t msg_type,
+                               struct server_id server_id,
+                               DATA_BLOB *data)
 {
-       struct print_queue_update_context ctx;
        fstring sharename;
-       pstring lpqcommand;
+       char *lpqcommand = NULL, *lprmcommand = NULL;
+       int printing_type;
        size_t len;
 
-       len = tdb_unpack( buf, msglen, "fdP",
+       len = tdb_unpack( (uint8 *)data->data, data->length, "fdPP",
                sharename,
-               &ctx.printing_type,
-               lpqcommand );
+               &printing_type,
+               &lpqcommand,
+               &lprmcommand );
 
        if ( len == -1 ) {
+               SAFE_FREE(lpqcommand);
+               SAFE_FREE(lprmcommand);
                DEBUG(0,("print_queue_receive: Got invalid print queue update message\n"));
                return;
        }
 
-       ctx.sharename = sharename;
-       ctx.lpqcommand = lpqcommand;
-
-       print_queue_update_with_lock(ctx.sharename, 
-               get_printer_fns_from_type(ctx.printing_type),
-               ctx.lpqcommand );
+       print_queue_update_with_lock(sharename,
+               get_printer_fns_from_type((enum printing_types)printing_type),
+               lpqcommand, lprmcommand );
 
+       SAFE_FREE(lpqcommand);
+       SAFE_FREE(lprmcommand);
        return;
 }
 
@@ -1316,7 +1394,19 @@ main thread of the background lpq updater
 ****************************************************************************/
 void start_background_queue(void)
 {
+       /* Use local variables for this as we don't
+        * need to save the parent side of this, just
+        * ensure it closes when the process exits.
+        */
+       int pause_pipe[2];
+
        DEBUG(3,("start_background_queue: Starting background LPQ thread\n"));
+
+       if (pipe(pause_pipe) == -1) {
+               DEBUG(5,("start_background_queue: cannot create pipe. %s\n", strerror(errno) ));
+               exit(1);
+       }
+
        background_lpq_updater_pid = sys_fork();
 
        if (background_lpq_updater_pid == -1) {
@@ -1328,106 +1418,197 @@ void start_background_queue(void)
                /* Child. */
                DEBUG(5,("start_background_queue: background LPQ thread started\n"));
 
-               claim_connection( NULL, "smbd lpq backend", 0, False, 
+               close(pause_pipe[0]);
+               pause_pipe[0] = -1;
+
+               if (!reinit_after_fork(smbd_messaging_context(),
+                                      smbd_event_context(), true)) {
+                       DEBUG(0,("reinit_after_fork() failed\n"));
+                       smb_panic("reinit_after_fork() failed");
+               }
+
+               smbd_setup_sig_term_handler();
+               smbd_setup_sig_hup_handler();
+
+               claim_connection( NULL, "smbd lpq backend",
                        FLAG_MSG_GENERAL|FLAG_MSG_SMBD|FLAG_MSG_PRINT_GENERAL);
 
-               if (!locking_init(0)) {
+               if (!locking_init()) {
                        exit(1);
                }
 
-               message_register(MSG_PRINTER_UPDATE, print_queue_receive);
-               
+               messaging_register(smbd_messaging_context(), NULL,
+                                  MSG_PRINTER_UPDATE, print_queue_receive);
+
                DEBUG(5,("start_background_queue: background LPQ thread waiting for messages\n"));
                while (1) {
-                       pause();
-                       
-                       /* check for some essential signals first */
-                       
-                        if (got_sig_term) {
-                                exit_server("Caught TERM signal");
-                        }
-
-                        if (reload_after_sighup) {
-                                change_to_root_user();
-                                DEBUG(1,("Reloading services after SIGHUP\n"));
-                                reload_services(False);
-                                reload_after_sighup = 0;
-                        }
-                       
-                       /* now check for messages */
-                       
-                       DEBUG(10,("start_background_queue: background LPQ thread got a message\n"));
-                       message_dispatch();
-
-                       /* process any pending print change notify messages */
-
-                       print_notify_send_messages(0);
+                       fd_set r_fds, w_fds;
+                       int ret;
+                       struct timeval to;
+                       int maxfd = 0;
+
+                       /* Process a signal and timed events now... */
+                       if (run_events(smbd_event_context(), 0, NULL, NULL)) {
+                               continue;
+                       }
+
+                       to.tv_sec = SMBD_SELECT_TIMEOUT;
+                       to.tv_usec = 0;
+
+                       /*
+                        * Setup the select fd sets.
+                        */
+
+                       FD_ZERO(&r_fds);
+                       FD_ZERO(&w_fds);
+
+                       /*
+                        * Are there any timed events waiting ? If so, ensure we don't
+                        * select for longer than it would take to wait for them.
+                        */
+
+                       {
+                               struct timeval now;
+                               GetTimeOfDay(&now);
+
+                               event_add_to_select_args(smbd_event_context(), &now,
+                                                        &r_fds, &w_fds, &to, &maxfd);
+                       }
+
+                       FD_SET(pause_pipe[1], &r_fds);
+                       maxfd = MAX(pause_pipe[1], maxfd);
+
+                       ret = sys_select(maxfd, &r_fds, &w_fds, NULL, &to);
+
+                       /*
+                        * If pause_pipe[1] is closed it means the parent smbd
+                        * and children exited or aborted. If sys_select()
+                        * failed, then something more sinister is wrong
+                        */
+                       if ((ret < 0) ||
+                           (ret == 1 && FD_ISSET(pause_pipe[1], &r_fds))) {
+                                exit_server_cleanly(NULL);
+                       }
+
+                       if (run_events(smbd_event_context(), ret, &r_fds, &w_fds)) {
+                               continue;
+                       }
                }
        }
+
+       close(pause_pipe[1]);
 }
 
 /****************************************************************************
 update the internal database from the system print queue for a queue
 ****************************************************************************/
 
-static void print_queue_update(int snum, BOOL force)
+static void print_queue_update(int snum, bool force)
 {
        fstring key;
        fstring sharename;
-       pstring lpqcommand;
-       char *buffer = NULL;
+       char *lpqcommand = NULL;
+       char *lprmcommand = NULL;
+       uint8 *buffer = NULL;
        size_t len = 0;
        size_t newlen;
        struct tdb_print_db *pdb;
-       enum printing_types type;
+       int type;
        struct printif *current_printif;
+       TALLOC_CTX *ctx = talloc_tos();
 
        fstrcpy( sharename, lp_const_servicename(snum));
 
-       pstrcpy( lpqcommand, lp_lpqcommand(snum));
-       pstring_sub( lpqcommand, "%p", PRINTERNAME(snum) );
-       standard_sub_snum( snum, lpqcommand, sizeof(lpqcommand) );
-       
-       /* 
-        * Make sure that the background queue process exists.  
-        * Otherwise just do the update ourselves 
+       /* don't strip out characters like '$' from the printername */
+
+       lpqcommand = talloc_string_sub2(ctx,
+                       lp_lpqcommand(snum),
+                       "%p",
+                       PRINTERNAME(snum),
+                       false, false, false);
+       if (!lpqcommand) {
+               return;
+       }
+       lpqcommand = talloc_sub_advanced(ctx,
+                       lp_servicename(snum),
+                       current_user_info.unix_name,
+                       "",
+                       current_user.ut.gid,
+                       get_current_username(),
+                       current_user_info.domain,
+                       lpqcommand);
+       if (!lpqcommand) {
+               return;
+       }
+
+       lprmcommand = talloc_string_sub2(ctx,
+                       lp_lprmcommand(snum),
+                       "%p",
+                       PRINTERNAME(snum),
+                       false, false, false);
+       if (!lprmcommand) {
+               return;
+       }
+       lprmcommand = talloc_sub_advanced(ctx,
+                       lp_servicename(snum),
+                       current_user_info.unix_name,
+                       "",
+                       current_user.ut.gid,
+                       get_current_username(),
+                       current_user_info.domain,
+                       lprmcommand);
+       if (!lprmcommand) {
+               return;
+       }
+
+       /*
+        * Make sure that the background queue process exists.
+        * Otherwise just do the update ourselves
         */
-       
+
        if ( force || background_lpq_updater_pid == -1 ) {
                DEBUG(4,("print_queue_update: updating queue [%s] myself\n", sharename));
                current_printif = get_printer_fns( snum );
-               print_queue_update_with_lock( sharename, current_printif, lpqcommand );
+               print_queue_update_with_lock( sharename, current_printif, lpqcommand, lprmcommand );
 
                return;
        }
 
        type = lp_printing(snum);
-       
+
        /* get the length */
 
-       len = tdb_pack( buffer, len, "fdP",
+       len = tdb_pack( NULL, 0, "fdPP",
                sharename,
                type,
-               lpqcommand );
+               lpqcommand,
+               lprmcommand );
 
-       buffer = SMB_XMALLOC_ARRAY( char, len );
+       buffer = SMB_XMALLOC_ARRAY( uint8, len );
 
        /* now pack the buffer */
-       newlen = tdb_pack( buffer, len, "fdP",
+       newlen = tdb_pack( buffer, len, "fdPP",
                sharename,
                type,
-               lpqcommand );
+               lpqcommand,
+               lprmcommand );
 
        SMB_ASSERT( newlen == len );
 
        DEBUG(10,("print_queue_update: Sending message -> printer = %s, "
-               "type = %d, lpq command = [%s]\n", sharename, type, lpqcommand ));
+               "type = %d, lpq command = [%s] lprm command = [%s]\n",
+               sharename, type, lpqcommand, lprmcommand ));
 
-       /* here we set a msg pending record for other smbd processes 
+       /* here we set a msg pending record for other smbd processes
           to throttle the number of duplicate print_queue_update msgs
           sent.  */
 
        pdb = get_print_db_byname(sharename);
+       if (!pdb) {
+               SAFE_FREE(buffer);
+               return;
+       }
+
        snprintf(key, sizeof(key), "MSG_PENDING/%s", sharename);
 
        if ( !tdb_store_uint32( pdb->tdb, key, time(NULL) ) ) {
@@ -1440,11 +1621,10 @@ static void print_queue_update(int snum, BOOL force)
        release_print_db( pdb );
 
        /* finally send the message */
-       
-       become_root();
-       message_send_pid(background_lpq_updater_pid,
-                MSG_PRINTER_UPDATE, buffer, len, False);
-       unbecome_root();
+
+       messaging_send_buf(smbd_messaging_context(),
+                          pid_to_procid(background_lpq_updater_pid),
+                          MSG_PRINTER_UPDATE, (uint8 *)buffer, len);
 
        SAFE_FREE( buffer );
 
@@ -1453,33 +1633,33 @@ static void print_queue_update(int snum, BOOL force)
 
 /****************************************************************************
  Create/Update an entry in the print tdb that will allow us to send notify
- updates only to interested smbd's. 
+ updates only to interested smbd's.
 ****************************************************************************/
 
-BOOL print_notify_register_pid(int snum)
+bool print_notify_register_pid(int snum)
 {
        TDB_DATA data;
        struct tdb_print_db *pdb = NULL;
        TDB_CONTEXT *tdb = NULL;
        const char *printername;
        uint32 mypid = (uint32)sys_getpid();
-       BOOL ret = False;
+       bool ret = False;
        size_t i;
 
        /* if (snum == -1), then the change notify request was
           on a print server handle and we need to register on
           all print queus */
-          
-       if (snum == -1) 
+
+       if (snum == -1)
        {
                int num_services = lp_numservices();
                int idx;
-               
+
                for ( idx=0; idx<num_services; idx++ ) {
                        if (lp_snum_ok(idx) && lp_print_ok(idx) )
                                print_notify_register_pid(idx);
                }
-               
+
                return True;
        }
        else /* register for a specific printer */
@@ -1491,7 +1671,7 @@ BOOL print_notify_register_pid(int snum)
                tdb = pdb->tdb;
        }
 
-       if (tdb_lock_bystring(tdb, NOTIFY_PID_LIST_KEY, 10) == -1) {
+       if (tdb_lock_bystring_with_timeout(tdb, NOTIFY_PID_LIST_KEY, 10) == -1) {
                DEBUG(0,("print_notify_register_pid: Failed to lock printer %s\n",
                                        printername));
                if (pdb)
@@ -1513,7 +1693,7 @@ BOOL print_notify_register_pid(int snum)
 
        if (i == data.dsize) {
                /* We weren't in the list. Realloc. */
-               data.dptr = SMB_REALLOC(data.dptr, data.dsize + 8);
+               data.dptr = (uint8 *)SMB_REALLOC(data.dptr, data.dsize + 8);
                if (!data.dptr) {
                        DEBUG(0,("print_notify_register_pid: Relloc fail for printer %s\n",
                                                printername));
@@ -1544,10 +1724,10 @@ list for printer %s\n", printername));
 
 /****************************************************************************
  Update an entry in the print tdb that will allow us to send notify
- updates only to interested smbd's. 
+ updates only to interested smbd's.
 ****************************************************************************/
 
-BOOL print_notify_deregister_pid(int snum)
+bool print_notify_deregister_pid(int snum)
 {
        TDB_DATA data;
        struct tdb_print_db *pdb = NULL;
@@ -1555,21 +1735,21 @@ BOOL print_notify_deregister_pid(int snum)
        const char *printername;
        uint32 mypid = (uint32)sys_getpid();
        size_t i;
-       BOOL ret = False;
+       bool ret = False;
 
        /* if ( snum == -1 ), we are deregister a print server handle
           which means to deregister on all print queues */
-          
-       if (snum == -1) 
+
+       if (snum == -1)
        {
                int num_services = lp_numservices();
                int idx;
-               
+
                for ( idx=0; idx<num_services; idx++ ) {
                        if ( lp_snum_ok(idx) && lp_print_ok(idx) )
                                print_notify_deregister_pid(idx);
                }
-               
+
                return True;
        }
        else /* deregister a specific printer */
@@ -1581,7 +1761,7 @@ BOOL print_notify_deregister_pid(int snum)
                tdb = pdb->tdb;
        }
 
-       if (tdb_lock_bystring(tdb, NOTIFY_PID_LIST_KEY, 10) == -1) {
+       if (tdb_lock_bystring_with_timeout(tdb, NOTIFY_PID_LIST_KEY, 10) == -1) {
                DEBUG(0,("print_notify_register_pid: Failed to lock \
 printer %s database\n", printername));
                if (pdb)
@@ -1636,14 +1816,15 @@ list for printer %s\n", printername));
  Check if a jobid is valid. It is valid if it exists in the database.
 ****************************************************************************/
 
-BOOL print_job_exists(const char* sharename, uint32 jobid)
+bool print_job_exists(const char* sharename, uint32 jobid)
 {
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
-       BOOL ret;
+       bool ret;
+       uint32_t tmp;
 
        if (!pdb)
                return False;
-       ret = tdb_exists(pdb->tdb, print_key(jobid));
+       ret = tdb_exists(pdb->tdb, print_key(jobid, &tmp));
        release_print_db(pdb);
        return ret;
 }
@@ -1687,10 +1868,10 @@ char *print_job_fname(const char* sharename, uint32 jobid)
 NT_DEVICEMODE *print_job_devmode(const char* sharename, uint32 jobid)
 {
        struct printjob *pjob = print_job_find(sharename, jobid);
-       
+
        if ( !pjob )
                return NULL;
-               
+
        return pjob->nt_devmode;
 }
 
@@ -1698,7 +1879,7 @@ NT_DEVICEMODE *print_job_devmode(const char* sharename, uint32 jobid)
  Set the place in the queue for a job.
 ****************************************************************************/
 
-BOOL print_job_set_place(int snum, uint32 jobid, int place)
+bool print_job_set_place(const char *sharename, uint32 jobid, int place)
 {
        DEBUG(2,("print_job_set_place not implemented yet\n"));
        return False;
@@ -1708,9 +1889,8 @@ BOOL print_job_set_place(int snum, uint32 jobid, int place)
  Set the name of a job. Only possible for owner.
 ****************************************************************************/
 
-BOOL print_job_set_name(int snum, uint32 jobid, char *name)
+bool print_job_set_name(const char *sharename, uint32 jobid, char *name)
 {
-       const char* sharename = lp_const_servicename(snum);
        struct printjob *pjob;
 
        pjob = print_job_find(sharename, jobid);
@@ -1725,19 +1905,23 @@ BOOL print_job_set_name(int snum, uint32 jobid, char *name)
  Remove a jobid from the 'jobs changed' list.
 ***************************************************************************/
 
-static BOOL remove_from_jobs_changed(const char* sharename, uint32 jobid)
+static bool remove_from_jobs_changed(const char* sharename, uint32 jobid)
 {
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
        TDB_DATA data, key;
        size_t job_count, i;
-       BOOL ret = False;
-       BOOL gotlock = False;
+       bool ret = False;
+       bool gotlock = False;
+
+       if (!pdb) {
+               return False;
+       }
 
        ZERO_STRUCT(data);
 
-       if (tdb_chainlock_with_timeout(pdb->tdb,
-                                      string_tdb_data("INFO/jobs_changed"),
-                                      5) == -1)
+       key = string_tdb_data("INFO/jobs_changed");
+
+       if (tdb_chainlock_with_timeout(pdb->tdb, key, 5) == -1)
                goto out;
 
        gotlock = True;
@@ -1780,15 +1964,13 @@ static BOOL remove_from_jobs_changed(const char* sharename, uint32 jobid)
  Delete a print job - don't update queue.
 ****************************************************************************/
 
-static BOOL print_job_delete1(int snum, uint32 jobid)
+static bool print_job_delete1(int snum, uint32 jobid)
 {
        const char* sharename = lp_const_servicename(snum);
        struct printjob *pjob = print_job_find(sharename, jobid);
        int result = 0;
        struct printif *current_printif = get_printer_fns( snum );
 
-       pjob = print_job_find(sharename, jobid);
-
        if (!pjob)
                return False;
 
@@ -1800,7 +1982,9 @@ static BOOL print_job_delete1(int snum, uint32 jobid)
                return True;
 
        /* Hrm - we need to be able to cope with deleting a job before it
-          has reached the spooler. */
+          has reached the spooler.  Just mark it as LPQ_DELETING and
+          let the print_queue_update() code rmeove the record */
+
 
        if (pjob->sysjob == -1) {
                DEBUG(5, ("attempt to delete job %u not seen by lpr\n", (unsigned int)jobid));
@@ -1812,23 +1996,30 @@ static BOOL print_job_delete1(int snum, uint32 jobid)
        pjob_store(sharename, jobid, pjob);
 
        if (pjob->spooled && pjob->sysjob != -1)
-               result = (*(current_printif->job_delete))(snum, pjob);
+       {
+               result = (*(current_printif->job_delete))(
+                       PRINTERNAME(snum),
+                       lp_lprmcommand(snum),
+                       pjob);
 
-       /* Delete the tdb entry if the delete succeeded or the job hasn't
-          been spooled. */
+               /* Delete the tdb entry if the delete succeeded or the job hasn't
+                  been spooled. */
 
-       if (result == 0) {
-               struct tdb_print_db *pdb = get_print_db_byname(sharename);
-               int njobs = 1;
+               if (result == 0) {
+                       struct tdb_print_db *pdb = get_print_db_byname(sharename);
+                       int njobs = 1;
 
-               if (!pdb)
-                       return False;
-               pjob_delete(sharename, jobid);
-               /* Ensure we keep a rough count of the number of total jobs... */
-               tdb_change_int32_atomic(pdb->tdb, "INFO/total_jobs", &njobs, -1);
-               release_print_db(pdb);
+                       if (!pdb)
+                               return False;
+                       pjob_delete(sharename, jobid);
+                       /* Ensure we keep a rough count of the number of total jobs... */
+                       tdb_change_int32_atomic(pdb->tdb, "INFO/total_jobs", &njobs, -1);
+                       release_print_db(pdb);
+               }
        }
 
+       remove_from_jobs_changed( sharename, jobid );
+
        return (result == 0);
 }
 
@@ -1836,60 +2027,60 @@ static BOOL print_job_delete1(int snum, uint32 jobid)
  Return true if the current user owns the print job.
 ****************************************************************************/
 
-static BOOL is_owner(struct current_user *user, int snum, uint32 jobid)
+static bool is_owner(struct auth_serversupplied_info *server_info,
+                    const char *servicename,
+                    uint32 jobid)
 {
-       struct printjob *pjob = print_job_find(lp_const_servicename(snum), jobid);
-       user_struct *vuser;
+       struct printjob *pjob = print_job_find(servicename, jobid);
 
-       if (!pjob || !user)
+       if (!pjob || !server_info)
                return False;
 
-       if ((vuser = get_valid_user_struct(user->vuid)) != NULL) {
-               return strequal(pjob->user, vuser->user.smb_name);
-       } else {
-               return strequal(pjob->user, uidtoname(user->uid));
-       }
+       return strequal(pjob->user, server_info->sanitized_username);
 }
 
 /****************************************************************************
  Delete a print job.
 ****************************************************************************/
 
-BOOL print_job_delete(struct current_user *user, int snum, uint32 jobid, WERROR *errcode)
+bool print_job_delete(struct auth_serversupplied_info *server_info, int snum,
+                     uint32 jobid, WERROR *errcode)
 {
        const char* sharename = lp_const_servicename( snum );
-       BOOL    owner, deleted;
+       struct printjob *pjob;
+       bool    owner;
        char    *fname;
 
        *errcode = WERR_OK;
-               
-       owner = is_owner(user, snum, jobid);
-       
+
+       owner = is_owner(server_info, lp_const_servicename(snum), jobid);
+
        /* Check access against security descriptor or whether the user
           owns their job. */
 
-       if (!owner && 
-           !print_access_check(user, snum, JOB_ACCESS_ADMINISTER)) {
+       if (!owner &&
+           !print_access_check(server_info, snum, JOB_ACCESS_ADMINISTER)) {
                DEBUG(3, ("delete denied by security descriptor\n"));
                *errcode = WERR_ACCESS_DENIED;
 
                /* BEGIN_ADMIN_LOG */
-               sys_adminlog( LOG_ERR, 
+               sys_adminlog( LOG_ERR,
                              "Permission denied-- user not allowed to delete, \
 pause, or resume print job. User name: %s. Printer name: %s.",
-                             uidtoname(user->uid), PRINTERNAME(snum) );
+                             uidtoname(server_info->utok.uid),
+                             PRINTERNAME(snum) );
                /* END_ADMIN_LOG */
 
                return False;
        }
 
-       /* 
+       /*
         * get the spooled filename of the print job
         * if this works, then the file has not been spooled
-        * to the underlying print system.  Just delete the 
+        * to the underlying print system.  Just delete the
         * spool file & return.
         */
-        
+
        if ( (fname = print_job_fname( sharename, jobid )) != NULL )
        {
                /* remove the spool file */
@@ -1899,7 +2090,7 @@ pause, or resume print job. User name: %s. Printer name: %s.",
                        return False;
                }
        }
-       
+
        if (!print_job_delete1(snum, jobid)) {
                *errcode = WERR_ACCESS_DENIED;
                return False;
@@ -1909,19 +2100,20 @@ pause, or resume print job. User name: %s. Printer name: %s.",
            job still exists */
 
        print_queue_update(snum, True);
-       
-       deleted = !print_job_exists(sharename, jobid);
-       if ( !deleted )
+
+       pjob = print_job_find(sharename, jobid);
+       if ( pjob && (pjob->status != LPQ_DELETING) )
                *errcode = WERR_ACCESS_DENIED;
 
-       return deleted;
+       return (pjob == NULL );
 }
 
 /****************************************************************************
  Pause a job.
 ****************************************************************************/
 
-BOOL print_job_pause(struct current_user *user, int snum, uint32 jobid, WERROR *errcode)
+bool print_job_pause(struct auth_serversupplied_info *server_info, int snum,
+                    uint32 jobid, WERROR *errcode)
 {
        const char* sharename = lp_const_servicename(snum);
        struct printjob *pjob;
@@ -1929,22 +2121,29 @@ BOOL print_job_pause(struct current_user *user, int snum, uint32 jobid, WERROR *
        struct printif *current_printif = get_printer_fns( snum );
 
        pjob = print_job_find(sharename, jobid);
-       
-       if (!pjob || !user) 
+
+       if (!pjob || !server_info) {
+               DEBUG(10, ("print_job_pause: no pjob or user for jobid %u\n",
+                       (unsigned int)jobid ));
                return False;
+       }
 
-       if (!pjob->spooled || pjob->sysjob == -1) 
+       if (!pjob->spooled || pjob->sysjob == -1) {
+               DEBUG(10, ("print_job_pause: not spooled or bad sysjob = %d for jobid %u\n",
+                       (int)pjob->sysjob, (unsigned int)jobid ));
                return False;
+       }
 
-       if (!is_owner(user, snum, jobid) &&
-           !print_access_check(user, snum, JOB_ACCESS_ADMINISTER)) {
+       if (!is_owner(server_info, lp_const_servicename(snum), jobid) &&
+           !print_access_check(server_info, snum, JOB_ACCESS_ADMINISTER)) {
                DEBUG(3, ("pause denied by security descriptor\n"));
 
                /* BEGIN_ADMIN_LOG */
-               sys_adminlog( LOG_ERR, 
+               sys_adminlog( LOG_ERR,
                        "Permission denied-- user not allowed to delete, \
 pause, or resume print job. User name: %s. Printer name: %s.",
-                               uidtoname(user->uid), PRINTERNAME(snum) );
+                             uidtoname(server_info->utok.uid),
+                             PRINTERNAME(snum) );
                /* END_ADMIN_LOG */
 
                *errcode = WERR_ACCESS_DENIED;
@@ -1960,7 +2159,7 @@ pause, or resume print job. User name: %s. Printer name: %s.",
        }
 
        /* force update the database */
-       print_cache_flush(snum);
+       print_cache_flush(lp_const_servicename(snum));
 
        /* Send a printer notify message */
 
@@ -1975,7 +2174,8 @@ pause, or resume print job. User name: %s. Printer name: %s.",
  Resume a job.
 ****************************************************************************/
 
-BOOL print_job_resume(struct current_user *user, int snum, uint32 jobid, WERROR *errcode)
+bool print_job_resume(struct auth_serversupplied_info *server_info, int snum,
+                     uint32 jobid, WERROR *errcode)
 {
        const char *sharename = lp_const_servicename(snum);
        struct printjob *pjob;
@@ -1983,23 +2183,30 @@ BOOL print_job_resume(struct current_user *user, int snum, uint32 jobid, WERROR
        struct printif *current_printif = get_printer_fns( snum );
 
        pjob = print_job_find(sharename, jobid);
-       
-       if (!pjob || !user)
+
+       if (!pjob || !server_info) {
+               DEBUG(10, ("print_job_resume: no pjob or user for jobid %u\n",
+                       (unsigned int)jobid ));
                return False;
+       }
 
-       if (!pjob->spooled || pjob->sysjob == -1)
+       if (!pjob->spooled || pjob->sysjob == -1) {
+               DEBUG(10, ("print_job_resume: not spooled or bad sysjob = %d for jobid %u\n",
+                       (int)pjob->sysjob, (unsigned int)jobid ));
                return False;
+       }
 
-       if (!is_owner(user, snum, jobid) &&
-           !print_access_check(user, snum, JOB_ACCESS_ADMINISTER)) {
+       if (!is_owner(server_info, lp_const_servicename(snum), jobid) &&
+           !print_access_check(server_info, snum, JOB_ACCESS_ADMINISTER)) {
                DEBUG(3, ("resume denied by security descriptor\n"));
                *errcode = WERR_ACCESS_DENIED;
 
                /* BEGIN_ADMIN_LOG */
-               sys_adminlog( LOG_ERR, 
+               sys_adminlog( LOG_ERR,
                         "Permission denied-- user not allowed to delete, \
 pause, or resume print job. User name: %s. Printer name: %s.",
-                       uidtoname(user->uid), PRINTERNAME(snum) );
+                             uidtoname(server_info->utok.uid),
+                             PRINTERNAME(snum) );
                /* END_ADMIN_LOG */
                return False;
        }
@@ -2012,7 +2219,7 @@ pause, or resume print job. User name: %s. Printer name: %s.",
        }
 
        /* force update the database */
-       print_cache_flush(snum);
+       print_cache_flush(lp_const_servicename(snum));
 
        /* Send a printer notify message */
 
@@ -2025,7 +2232,7 @@ pause, or resume print job. User name: %s. Printer name: %s.",
  Write to a print file.
 ****************************************************************************/
 
-int print_job_write(int snum, uint32 jobid, const char *buf, int size)
+ssize_t print_job_write(int snum, uint32 jobid, const char *buf, SMB_OFF_T pos, size_t size)
 {
        const char* sharename = lp_const_servicename(snum);
        int return_code;
@@ -2039,7 +2246,8 @@ int print_job_write(int snum, uint32 jobid, const char *buf, int size)
        if (pjob->pid != sys_getpid())
                return -1;
 
-       return_code = write(pjob->fd, buf, size);
+       return_code = write_data_at_offset(pjob->fd, buf, size, pos);
+
        if (return_code>0) {
                pjob->size += size;
                pjob_store(sharename, jobid, pjob);
@@ -2058,16 +2266,19 @@ static int get_queue_status(const char* sharename, print_status_struct *status)
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
        int len;
 
+       if (status) {
+               ZERO_STRUCTP(status);
+       }
+
        if (!pdb)
                return 0;
 
        if (status) {
-               ZERO_STRUCTP(status);
                fstr_sprintf(keystr, "STATUS/%s", sharename);
                data = tdb_fetch(pdb->tdb, string_tdb_data(keystr));
                if (data.dptr) {
                        if (data.dsize == sizeof(print_status_struct))
-                               /* this memcpy is ok since the status struct was 
+                               /* this memcpy is ok since the status struct was
                                   not packed before storing it in the tdb */
                                memcpy(status, data.dptr, sizeof(print_status_struct));
                        SAFE_FREE(data.dptr);
@@ -2087,11 +2298,13 @@ int print_queue_length(int snum, print_status_struct *pstatus)
        const char* sharename = lp_const_servicename( snum );
        print_status_struct status;
        int len;
+
+       ZERO_STRUCT( status );
+
        /* make sure the database is up to date */
        if (print_cache_expired(lp_const_servicename(snum), True))
                print_queue_update(snum, False);
+
        /* also fetch the queue status */
        memset(&status, 0, sizeof(status));
        len = get_queue_status(sharename, &status);
@@ -2106,7 +2319,7 @@ int print_queue_length(int snum, print_status_struct *pstatus)
  Allocate a jobid. Hold the lock for as short a time as possible.
 ***************************************************************************/
 
-static BOOL allocate_print_jobid(struct tdb_print_db *pdb, int snum, const char *sharename, uint32 *pjobid)
+static bool allocate_print_jobid(struct tdb_print_db *pdb, int snum, const char *sharename, uint32 *pjobid)
 {
        int i;
        uint32 jobid;
@@ -2115,7 +2328,7 @@ static BOOL allocate_print_jobid(struct tdb_print_db *pdb, int snum, const char
 
        for (i = 0; i < 3; i++) {
                /* Lock the database - only wait 20 seconds. */
-               if (tdb_lock_bystring(pdb->tdb, "INFO/nextjob", 20) == -1) {
+               if (tdb_lock_bystring_with_timeout(pdb->tdb, "INFO/nextjob", 20) == -1) {
                        DEBUG(0,("allocate_print_jobid: failed to lock printing database %s\n", sharename));
                        return False;
                }
@@ -2139,7 +2352,7 @@ static BOOL allocate_print_jobid(struct tdb_print_db *pdb, int snum, const char
 
                /* We've finished with the INFO/nextjob lock. */
                tdb_unlock_bystring(pdb->tdb, "INFO/nextjob");
-                               
+
                if (!print_job_exists(sharename, jobid))
                        break;
        }
@@ -2154,10 +2367,12 @@ static BOOL allocate_print_jobid(struct tdb_print_db *pdb, int snum, const char
 
        /* Store a dummy placeholder. */
        {
+               uint32_t tmp;
                TDB_DATA dum;
                dum.dptr = NULL;
                dum.dsize = 0;
-               if (tdb_store(pdb->tdb, print_key(jobid), dum, TDB_INSERT) == -1) {
+               if (tdb_store(pdb->tdb, print_key(jobid, &tmp), dum,
+                             TDB_INSERT) == -1) {
                        DEBUG(3, ("allocate_print_jobid: jobid (%d) failed to store placeholder.\n",
                                jobid ));
                        return False;
@@ -2172,13 +2387,13 @@ static BOOL allocate_print_jobid(struct tdb_print_db *pdb, int snum, const char
  Append a jobid to the 'jobs changed' list.
 ***************************************************************************/
 
-static BOOL add_to_jobs_changed(struct tdb_print_db *pdb, uint32 jobid)
+static bool add_to_jobs_changed(struct tdb_print_db *pdb, uint32 jobid)
 {
        TDB_DATA data;
        uint32 store_jobid;
 
        SIVAL(&store_jobid, 0, jobid);
-       data.dptr = (char *)&store_jobid;
+       data.dptr = (uint8 *)&store_jobid;
        data.dsize = 4;
 
        DEBUG(10,("add_to_jobs_changed: Added jobid %u\n", (unsigned int)jobid ));
@@ -2191,12 +2406,12 @@ static BOOL add_to_jobs_changed(struct tdb_print_db *pdb, uint32 jobid)
  Start spooling a job - return the jobid.
 ***************************************************************************/
 
-uint32 print_job_start(struct current_user *user, int snum, char *jobname, NT_DEVICEMODE *nt_devmode )
+uint32 print_job_start(struct auth_serversupplied_info *server_info, int snum,
+                      char *jobname, NT_DEVICEMODE *nt_devmode )
 {
        uint32 jobid;
        char *path;
        struct printjob pjob;
-       user_struct *vuser;
        const char *sharename = lp_const_servicename(snum);
        struct tdb_print_db *pdb = get_print_db_byname(sharename);
        int njobs;
@@ -2206,13 +2421,13 @@ uint32 print_job_start(struct current_user *user, int snum, char *jobname, NT_DE
        if (!pdb)
                return (uint32)-1;
 
-       if (!print_access_check(user, snum, PRINTER_ACCESS_USE)) {
+       if (!print_access_check(server_info, snum, PRINTER_ACCESS_USE)) {
                DEBUG(3, ("print_job_start: job start denied by security descriptor\n"));
                release_print_db(pdb);
                return (uint32)-1;
        }
 
-       if (!print_time_access_check(snum)) {
+       if (!print_time_access_check(lp_servicename(snum))) {
                DEBUG(3, ("print_job_start: job start denied by time check\n"));
                release_print_db(pdb);
                return (uint32)-1;
@@ -2222,9 +2437,9 @@ uint32 print_job_start(struct current_user *user, int snum, char *jobname, NT_DE
 
        /* see if we have sufficient disk space */
        if (lp_minprintspace(snum)) {
-               SMB_BIG_UINT dspace, dsize;
+               uint64_t dspace, dsize;
                if (sys_fsusage(path, &dspace, &dsize) == 0 &&
-                   dspace < 2*(SMB_BIG_UINT)lp_minprintspace(snum)) {
+                   dspace < 2*(uint64_t)lp_minprintspace(snum)) {
                        DEBUG(3, ("print_job_start: disk space check failed.\n"));
                        release_print_db(pdb);
                        errno = ENOSPC;
@@ -2256,9 +2471,9 @@ uint32 print_job_start(struct current_user *user, int snum, char *jobname, NT_DE
                goto fail;
 
        /* create the database entry */
-       
+
        ZERO_STRUCT(pjob);
-       
+
        pjob.pid = sys_getpid();
        pjob.sysjob = -1;
        pjob.fd = -1;
@@ -2268,19 +2483,22 @@ uint32 print_job_start(struct current_user *user, int snum, char *jobname, NT_DE
        pjob.spooled = False;
        pjob.smbjob = True;
        pjob.nt_devmode = nt_devmode;
-       
+
        fstrcpy(pjob.jobname, jobname);
 
-       if ((vuser = get_valid_user_struct(user->vuid)) != NULL) {
-               fstrcpy(pjob.user, vuser->user.smb_name);
-       } else {
-               fstrcpy(pjob.user, uidtoname(user->uid));
-       }
+       fstrcpy(pjob.user, lp_printjob_username(snum));
+       standard_sub_advanced(sharename, server_info->sanitized_username,
+                             path, server_info->utok.gid,
+                             server_info->sanitized_username,
+                             pdb_get_domain(server_info->sam_account),
+                             pjob.user, sizeof(pjob.user)-1);
+       /* ensure NULL termination */
+       pjob.user[sizeof(pjob.user)-1] = '\0';
 
        fstrcpy(pjob.queuename, lp_const_servicename(snum));
 
        /* we have a job entry - now create the spool file */
-       slprintf(pjob.filename, sizeof(pjob.filename)-1, "%s/%s%.8u.XXXXXX", 
+       slprintf(pjob.filename, sizeof(pjob.filename)-1, "%s/%s%.8u.XXXXXX",
                 path, PRINT_SPOOL_PREFIX, (unsigned int)jobid);
        pjob.fd = smb_mkstemp(pjob.filename);
 
@@ -2345,7 +2563,7 @@ void print_job_endpage(int snum, uint32 jobid)
  error.
 ****************************************************************************/
 
-BOOL print_job_end(int snum, uint32 jobid, BOOL normal_close)
+bool print_job_end(int snum, uint32 jobid, enum file_close_type close_type)
 {
        const char* sharename = lp_const_servicename(snum);
        struct printjob *pjob;
@@ -2361,13 +2579,14 @@ BOOL print_job_end(int snum, uint32 jobid, BOOL normal_close)
        if (pjob->spooled || pjob->pid != sys_getpid())
                return False;
 
-       if (normal_close && (sys_fstat(pjob->fd, &sbuf) == 0)) {
+       if ((close_type == NORMAL_CLOSE || close_type == SHUTDOWN_CLOSE) &&
+                               (sys_fstat(pjob->fd, &sbuf) == 0)) {
                pjob->size = sbuf.st_size;
                close(pjob->fd);
                pjob->fd = -1;
        } else {
 
-               /* 
+               /*
                 * Not a normal close or we couldn't stat the job file,
                 * so something has gone wrong. Cleanup.
                 */
@@ -2396,21 +2615,21 @@ BOOL print_job_end(int snum, uint32 jobid, BOOL normal_close)
        if (ret)
                goto fail;
 
-       /* The print job has been sucessfully handed over to the back-end */
-       
+       /* The print job has been successfully handed over to the back-end */
+
        pjob->spooled = True;
        pjob->status = LPQ_QUEUED;
        pjob_store(sharename, jobid, pjob);
-       
+
        /* make sure the database is up to date */
        if (print_cache_expired(lp_const_servicename(snum), True))
                print_queue_update(snum, False);
-       
+
        return True;
 
 fail:
 
-       /* The print job was not succesfully started. Cleanup */
+       /* The print job was not successfully started. Cleanup */
        /* Still need to add proper error return propagation! 010122:JRR */
        unlink(pjob->filename);
        pjob_delete(sharename, jobid);
@@ -2421,7 +2640,7 @@ fail:
  Get a snapshot of jobs in the system without traversing.
 ****************************************************************************/
 
-static BOOL get_stored_queue_info(struct tdb_print_db *pdb, int snum, int *pcount, print_queue_struct **ppqueue)
+static bool get_stored_queue_info(struct tdb_print_db *pdb, int snum, int *pcount, print_queue_struct **ppqueue)
 {
        TDB_DATA data, cgdata;
        print_queue_struct *queue = NULL;
@@ -2431,13 +2650,13 @@ static BOOL get_stored_queue_info(struct tdb_print_db *pdb, int snum, int *pcoun
        size_t len = 0;
        uint32 i;
        int max_reported_jobs = lp_max_reported_jobs(snum);
-       BOOL ret = False;
+       bool ret = False;
        const char* sharename = lp_servicename(snum);
 
        /* make sure the database is up to date */
        if (print_cache_expired(lp_const_servicename(snum), True))
                print_queue_update(snum, False);
+
        *pcount = 0;
        *ppqueue = NULL;
 
@@ -2446,10 +2665,10 @@ static BOOL get_stored_queue_info(struct tdb_print_db *pdb, int snum, int *pcoun
 
        /* Get the stored queue data. */
        data = tdb_fetch(pdb->tdb, string_tdb_data("INFO/linear_queue_array"));
-       
+
        if (data.dptr && data.dsize >= sizeof(qcount))
                len += tdb_unpack(data.dptr + len, data.dsize - len, "d", &qcount);
-               
+
        /* Get the changed jobs list. */
        cgdata = tdb_fetch(pdb->tdb, string_tdb_data("INFO/jobs_changed"));
        if (cgdata.dptr != NULL && (cgdata.dsize % 4 == 0))
@@ -2539,7 +2758,7 @@ static BOOL get_stored_queue_info(struct tdb_print_db *pdb, int snum, int *pcoun
  set queue = NULL and status = NULL if you just want to update the cache
 ****************************************************************************/
 
-int print_queue_status(int snum, 
+int print_queue_status(int snum,
                       print_queue_struct **ppqueue,
                       print_status_struct *status)
 {
@@ -2572,12 +2791,12 @@ int print_queue_status(int snum,
 
        ZERO_STRUCTP(status);
        slprintf(keystr, sizeof(keystr)-1, "STATUS/%s", sharename);
-       key.dptr = keystr;
-       key.dsize = strlen(keystr);
+       key = string_tdb_data(keystr);
+
        data = tdb_fetch(pdb->tdb, key);
        if (data.dptr) {
                if (data.dsize == sizeof(*status)) {
-                       /* this memcpy is ok since the status struct was 
+                       /* this memcpy is ok since the status struct was
                           not packed before storing it in the tdb */
                        memcpy(status, data.dptr, sizeof(*status));
                }
@@ -2602,30 +2821,32 @@ int print_queue_status(int snum,
  Pause a queue.
 ****************************************************************************/
 
-BOOL print_queue_pause(struct current_user *user, int snum, WERROR *errcode)
+bool print_queue_pause(struct auth_serversupplied_info *server_info, int snum,
+                      WERROR *errcode)
 {
        int ret;
        struct printif *current_printif = get_printer_fns( snum );
-       
-       if (!print_access_check(user, snum, PRINTER_ACCESS_ADMINISTER)) {
+
+       if (!print_access_check(server_info, snum,
+                               PRINTER_ACCESS_ADMINISTER)) {
                *errcode = WERR_ACCESS_DENIED;
                return False;
        }
-       
+
 
        become_root();
-               
+
        ret = (*(current_printif->queue_pause))(snum);
 
        unbecome_root();
-               
+
        if (ret != 0) {
                *errcode = WERR_INVALID_PARAM;
                return False;
        }
 
        /* force update the database */
-       print_cache_flush(snum);
+       print_cache_flush(lp_const_servicename(snum));
 
        /* Send a printer notify message */
 
@@ -2638,22 +2859,24 @@ BOOL print_queue_pause(struct current_user *user, int snum, WERROR *errcode)
  Resume a queue.
 ****************************************************************************/
 
-BOOL print_queue_resume(struct current_user *user, int snum, WERROR *errcode)
+bool print_queue_resume(struct auth_serversupplied_info *server_info, int snum,
+                       WERROR *errcode)
 {
        int ret;
        struct printif *current_printif = get_printer_fns( snum );
 
-       if (!print_access_check(user, snum, PRINTER_ACCESS_ADMINISTER)) {
+       if (!print_access_check(server_info, snum,
+                               PRINTER_ACCESS_ADMINISTER)) {
                *errcode = WERR_ACCESS_DENIED;
                return False;
        }
-       
+
        become_root();
-               
+
        ret = (*(current_printif->queue_resume))(snum);
 
        unbecome_root();
-               
+
        if (ret != 0) {
                *errcode = WERR_INVALID_PARAM;
                return False;
@@ -2674,30 +2897,33 @@ BOOL print_queue_resume(struct current_user *user, int snum, WERROR *errcode)
  Purge a queue - implemented by deleting all jobs that we can delete.
 ****************************************************************************/
 
-BOOL print_queue_purge(struct current_user *user, int snum, WERROR *errcode)
+bool print_queue_purge(struct auth_serversupplied_info *server_info, int snum,
+                      WERROR *errcode)
 {
        print_queue_struct *queue;
        print_status_struct status;
        int njobs, i;
-       BOOL can_job_admin;
+       bool can_job_admin;
 
        /* Force and update so the count is accurate (i.e. not a cached count) */
        print_queue_update(snum, True);
-       
-       can_job_admin = print_access_check(user, snum, JOB_ACCESS_ADMINISTER);
+
+       can_job_admin = print_access_check(server_info, snum,
+                                          JOB_ACCESS_ADMINISTER);
        njobs = print_queue_status(snum, &queue, &status);
-       
+
        if ( can_job_admin )
                become_root();
 
        for (i=0;i<njobs;i++) {
-               BOOL owner = is_owner(user, snum, queue[i].job);
+               bool owner = is_owner(server_info, lp_const_servicename(snum),
+                                     queue[i].job);
 
                if (owner || can_job_admin) {
                        print_job_delete1(snum, queue[i].job);
                }
        }
-       
+
        if ( can_job_admin )
                unbecome_root();