Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly...
[ira/wip.git] / source3 / passdb / pdb_tdb.c
index a5e2f7ae02468f5b2e20b18a3de817413d557e22..fb40b274765bed2348d6c549f22b15525cbdcd59 100644 (file)
@@ -10,7 +10,7 @@
  * 
  * This program is free software; you can redistribute it and/or modify it under
  * the terms of the GNU General Public License as published by the Free
- * Software Foundation; either version 2 of the License, or (at your option)
+ * Software Foundation; either version 3 of the License, or (at your option)
  * any later version.
  * 
  * This program is distributed in the hope that it will be useful, but WITHOUT
@@ -19,8 +19,7 @@
  * more details.
  * 
  * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc., 675
- * Mass Ave, Cambridge, MA 02139, USA.
+ * this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "includes.h"
@@ -38,339 +37,445 @@ static int tdbsam_debug_level = DBGC_ALL;
 
 #endif
 
-#define TDBSAM_VERSION 2       /* Most recent TDBSAM version */
+#define TDBSAM_VERSION 4       /* Most recent TDBSAM version */
 #define TDBSAM_VERSION_STRING  "INFO/version"
 #define PASSDB_FILE_NAME       "passdb.tdb"
 #define USERPREFIX             "USER_"
+#define USERPREFIX_LEN         5
 #define RIDPREFIX              "RID_"
 #define PRIVPREFIX             "PRIV_"
-
-struct pwent_list {
-       struct pwent_list *prev, *next;
-       TDB_DATA key;
-};
-static struct pwent_list *tdbsam_pwent_list;
+#define NEXT_RID_STRING                "NEXT_RID"
 
 /* GLOBAL TDB SAM CONTEXT */
 
-static TDB_CONTEXT *tdbsam;
-static int ref_count = 0;
-static pstring tdbsam_filename;
+static struct db_context *db_sam;
+static char *tdbsam_filename;
 
-/**
- * Convert old TDBSAM to the latest version.
- * @param pdb_tdb A pointer to the opened TDBSAM file which must be converted. 
- *                This file must be opened with read/write access.
- * @param from Current version of the TDBSAM file.
- * @return True if the conversion has been successful, false otherwise. 
- **/
+struct tdbsam_convert_state {
+       int32_t from;
+       bool success;
+};
 
-static BOOL tdbsam_convert(int32 from) 
+static int tdbsam_convert_one(struct db_record *rec, void *priv)
 {
-       const char      *vstring = TDBSAM_VERSION_STRING;
-       const char      *prefix = USERPREFIX;
-       TDB_DATA        data, key, old_key;
-       uint8           *buf = NULL;
-       BOOL            ret;
+       struct tdbsam_convert_state *state =
+               (struct tdbsam_convert_state *)priv;
+       struct samu *user;
+       TDB_DATA data;
+       NTSTATUS status;
+       bool ret;
+
+       if (rec->key.dsize < USERPREFIX_LEN) {
+               return 0;
+       }
+       if (strncmp((char *)rec->key.dptr, USERPREFIX, USERPREFIX_LEN) != 0) {
+               return 0;
+       }
 
-       /* handle a Samba upgrade */
-       tdb_lock_bystring(tdbsam, vstring, 0);
-       
-       /* Enumerate all records and convert them */
-       key = tdb_firstkey(tdbsam);
+       user = samu_new(talloc_tos());
+       if (user == NULL) {
+               DEBUG(0,("tdbsam_convert: samu_new() failed!\n"));
+               state->success = false;
+               return -1;
+       }
 
-       while (key.dptr) {
-       
-               /* skip all non-USER entries (eg. RIDs) */
-               while ((key.dsize != 0) && (strncmp(key.dptr, prefix, strlen (prefix)))) {
-                       old_key = key;
-                       /* increment to next in line */
-                       key = tdb_nextkey(tdbsam, key);
-                       SAFE_FREE(old_key.dptr);
-               }
-       
-               if (key.dptr) {
-                       struct samu *user = NULL;
-
-                       /* read from tdbsam */
-                       data = tdb_fetch(tdbsam, key);
-                       if (!data.dptr) {
-                               DEBUG(0,("tdbsam_convert: database entry not found: %s.\n",key.dptr));
-                               return False;
-                       }
-       
-                       /* unpack the buffer from the former format */
-                       pdb_init_sam( &user );
-                       DEBUG(10,("tdbsam_convert: Try unpacking a record with (key:%s) (version:%d)\n", key.dptr, from));
-                       switch (from) {
-                               case 0:
-                                       ret = init_sam_from_buffer_v0(user, (uint8 *)data.dptr, data.dsize);
-                                       break;
-                               case 1:
-                                       ret = init_sam_from_buffer_v1(user, (uint8 *)data.dptr, data.dsize);
-                                       break;
-                               case 2:
-                                       ret = init_sam_from_buffer_v2(user, (uint8 *)data.dptr, data.dsize);
-                                       break;
-                               default:
-                                       /* unknown tdbsam version */
-                                       ret = False;
-                       }
-                       if (!ret) {
-                               DEBUG(0,("tdbsam_convert: Bad struct samu entry returned from TDB (key:%s) (version:%d)\n", key.dptr, from));
-                               SAFE_FREE(data.dptr);
-                               TALLOC_FREE(user );
-                               return False;
-                       }
-       
-                       /* We're finished with the old data. */
-                       SAFE_FREE(data.dptr);
-
-                       /* pack from the buffer into the new format */
-                       
-                       DEBUG(10,("tdbsam_convert: Try packing a record (key:%s) (version:%d)\n", key.dptr, from));
-                       data.dsize = init_buffer_from_sam (&buf, user, False);
-                       TALLOC_FREE(user );
-                       
-                       if ( data.dsize == -1 ) {
-                               DEBUG(0,("tdbsam_convert: cannot pack the struct samu into the new format\n"));
-                               return False;
-                       }
-                       data.dptr = (char *)buf;
-                       
-                       /* Store the buffer inside the TDBSAM */
-                       if (tdb_store(tdbsam, key, data, TDB_MODIFY) != TDB_SUCCESS) {
-                               DEBUG(0,("tdbsam_convert: cannot store the struct samu (key:%s) in new format\n",key.dptr));
-                               SAFE_FREE(data.dptr);
-                               return False;
-                       }
-                       
-                       SAFE_FREE(data.dptr);
-                       
-                       /* increment to next in line */
-                       old_key = key;
-                       key = tdb_nextkey(tdbsam, key);
-                       SAFE_FREE(old_key.dptr);
-               }
-               
+       DEBUG(10,("tdbsam_convert: Try unpacking a record with (key:%s) "
+                 "(version:%d)\n", rec->key.dptr, state->from));
+
+       switch (state->from) {
+       case 0:
+               ret = init_samu_from_buffer(user, SAMU_BUFFER_V0,
+                                           (uint8 *)rec->value.dptr,
+                                           rec->value.dsize);
+               break;
+       case 1:
+               ret = init_samu_from_buffer(user, SAMU_BUFFER_V1,
+                                           (uint8 *)rec->value.dptr,
+                                           rec->value.dsize);
+               break;
+       case 2:
+               ret = init_samu_from_buffer(user, SAMU_BUFFER_V2,
+                                           (uint8 *)rec->value.dptr,
+                                           rec->value.dsize);
+               break;
+       case 3:
+               ret = init_samu_from_buffer(user, SAMU_BUFFER_V3,
+                                           (uint8 *)rec->value.dptr,
+                                           rec->value.dsize);
+               break;
+       case 4:
+               ret = init_samu_from_buffer(user, SAMU_BUFFER_V4,
+                                           (uint8 *)rec->value.dptr,
+                                           rec->value.dsize);
+               break;
+       default:
+               /* unknown tdbsam version */
+               ret = False;
+       }
+       if (!ret) {
+               DEBUG(0,("tdbsam_convert: Bad struct samu entry returned "
+                        "from TDB (key:%s) (version:%d)\n", rec->key.dptr,
+                        state->from));
+               TALLOC_FREE(user);
+               state->success = false;
+               return -1;
        }
 
-       
-       /* upgrade finished */
-       tdb_store_int32(tdbsam, vstring, TDBSAM_VERSION);
-       tdb_unlock_bystring(tdbsam, vstring);
+       data.dsize = init_buffer_from_samu(&data.dptr, user, false);
+       TALLOC_FREE(user);
+
+       if (data.dsize == -1) {
+               DEBUG(0,("tdbsam_convert: cannot pack the struct samu into "
+                        "the new format\n"));
+               state->success = false;
+               return -1;
+       }
 
-       return(True);   
+       status = rec->store(rec, data, TDB_MODIFY);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("Could not store the new record: %s\n",
+                         nt_errstr(status)));
+               state->success = false;
+               return -1;
+       }
+
+       return 0;
 }
 
-/*********************************************************************
- Open the tdbsam file based on the absolute path specified.
- Uses a reference count to allow multiple open calls.
-*********************************************************************/
+/**********************************************************************
+ Struct and function to backup an old record.
+ *********************************************************************/
 
-static BOOL tdbsam_open( const char *name )
+struct tdbsam_backup_state {
+       struct db_context *new_db;
+       bool success;
+};
+
+static int backup_copy_fn(struct db_record *orig_rec, void *state)
 {
-       int32   version;
-       
-       /* check if we are already open */
-       
-       if ( tdbsam ) {
-               ref_count++;
-               DEBUG(8,("tdbsam_open: Incrementing open reference count.  Ref count is now %d\n", 
-                       ref_count));
-               return True;
-       }
-       
-       SMB_ASSERT( ref_count == 0 );
-       
-       /* Try to open tdb passwd.  Create a new one if necessary */
-       
-       if (!(tdbsam = tdb_open_log(name, 0, TDB_DEFAULT, O_CREAT|O_RDWR, 0600))) {
-               DEBUG(0, ("tdbsam_open: Failed to open/create TDB passwd [%s]\n", name));
-               return False;
+       struct tdbsam_backup_state *bs = (struct tdbsam_backup_state *)state;
+       struct db_record *new_rec;
+       NTSTATUS status;
+
+       new_rec = bs->new_db->fetch_locked(bs->new_db, talloc_tos(), orig_rec->key);
+       if (new_rec == NULL) {
+               bs->success = false;
+               return 1;
        }
 
-       /* Check the version */
-       version = tdb_fetch_int32( tdbsam, TDBSAM_VERSION_STRING );
-       
-       if (version == -1)
-               version = 0;    /* Version not found, assume version 0 */
-       
-       /* Compare the version */
-       if (version > TDBSAM_VERSION) {
-               /* Version more recent than the latest known */ 
-               DEBUG(0, ("tdbsam_open: unknown version => %d\n", version));
-               tdb_close( tdbsam );
-               return False;
-       } 
-       
-       
-       if ( version < TDBSAM_VERSION ) {       
-               DEBUG(1, ("tdbsam_open: Converting version %d database to version %d.\n", 
-                       version, TDBSAM_VERSION));
-               
-               if ( !tdbsam_convert(version) ) {
-                       DEBUG(0, ("tdbsam_open: Error when trying to convert tdbsam [%s]\n",name));
-                       tdb_close(tdbsam);
-                       return False;
-               }
-                       
-               DEBUG(3, ("TDBSAM converted successfully.\n"));
-       }
-       
-       /* set the initial reference count */
+       status = new_rec->store(new_rec, orig_rec->value, TDB_INSERT);
 
-       ref_count = 1;
+       TALLOC_FREE(new_rec);
 
-       DEBUG(4,("tdbsam_open: successfully opened %s\n", name ));      
-       
-       return True;
+       if (!NT_STATUS_IS_OK(status)) {
+               bs->success = false;
+                return 1;
+        }
+        return 0;
 }
 
-/****************************************************************************
- wrapper atound tdb_close() to handle the reference count
-****************************************************************************/
+/**********************************************************************
+ Make a backup of an old passdb and replace the new one with it. We
+ have to do this as between 3.0.x and 3.2.x the hash function changed
+ by mistake (used unsigned char * instead of char *). This means the
+ previous simple update code will fail due to not being able to find
+ existing records to replace in the tdbsam_convert_one() function. JRA.
+ *********************************************************************/
 
-void tdbsam_close( void )
+static bool tdbsam_convert_backup(const char *dbname, struct db_context **pp_db)
 {
-       ref_count--;
-       
-       DEBUG(8,("tdbsam_close: Reference count is now %d.\n", ref_count));
+       TALLOC_CTX *frame = talloc_stackframe();
+       const char *tmp_fname = NULL;
+       struct db_context *tmp_db = NULL;
+       struct db_context *orig_db = *pp_db;
+       struct tdbsam_backup_state bs;
+       int ret;
+
+       tmp_fname = talloc_asprintf(frame, "%s.tmp", dbname);
+       if (!tmp_fname) {
+               TALLOC_FREE(frame);
+               return false;
+       }
 
-       SMB_ASSERT(ref_count >= 0 );
-       
-       if ( ref_count == 0 ) {
-               tdb_close( tdbsam );
-               tdbsam = NULL;
+       unlink(tmp_fname);
+
+       /* Remember to open this on the NULL context. We need
+        * it to stay around after we return from here. */
+
+       tmp_db = db_open(NULL, tmp_fname, 0,
+                               TDB_DEFAULT, O_CREAT|O_RDWR, 0600);
+       if (tmp_db == NULL) {
+               DEBUG(0, ("tdbsam_convert_backup: Failed to create backup TDB passwd "
+                         "[%s]\n", tmp_fname));
+               TALLOC_FREE(frame);
+               return false;
        }
-       
-       return;
-}
 
-/****************************************************************************
- creates a list of user keys
-****************************************************************************/
+       if (orig_db->transaction_start(orig_db) != 0) {
+               DEBUG(0, ("tdbsam_convert_backup: Could not start transaction (1)\n"));
+               unlink(tmp_fname);
+               TALLOC_FREE(tmp_db);
+               TALLOC_FREE(frame);
+               return false;
+       }
+       if (tmp_db->transaction_start(tmp_db) != 0) {
+               DEBUG(0, ("tdbsam_convert_backup: Could not start transaction (2)\n"));
+               orig_db->transaction_cancel(orig_db);
+               unlink(tmp_fname);
+               TALLOC_FREE(tmp_db);
+               TALLOC_FREE(frame);
+               return false;
+       }
+
+       bs.new_db = tmp_db;
+       bs.success = true;
+
+        ret = orig_db->traverse(orig_db, backup_copy_fn, (void *)&bs);
+        if (ret < 0) {
+                DEBUG(0, ("tdbsam_convert_backup: traverse failed\n"));
+                goto cancel;
+        }
 
-static int tdbsam_traverse_setpwent(TDB_CONTEXT *t, TDB_DATA key, TDB_DATA data, void *state)
+       if (!bs.success) {
+               DEBUG(0, ("tdbsam_convert_backup: Rewriting records failed\n"));
+               goto cancel;
+       }
+
+       if (orig_db->transaction_commit(orig_db) != 0) {
+               smb_panic("tdbsam_convert_backup: orig commit failed\n");
+       }
+       if (tmp_db->transaction_commit(tmp_db) != 0) {
+               smb_panic("tdbsam_convert_backup: orig commit failed\n");
+       }
+
+       /* This is safe from other users as we know we're
+        * under a mutex here. */
+
+       if (rename(tmp_fname, dbname) == -1) {
+               DEBUG(0, ("tdbsam_convert_backup: rename of %s to %s failed %s\n",
+                       tmp_fname,
+                       dbname,
+                       strerror(errno)));
+               smb_panic("tdbsam_convert_backup: replace passdb failed\n");
+       }
+
+       TALLOC_FREE(frame);
+       TALLOC_FREE(orig_db);
+
+       DEBUG(1, ("tdbsam_convert_backup: updated %s file.\n",
+               dbname ));
+
+       /* Replace the global db pointer. */
+       *pp_db = tmp_db;
+       return true;
+
+  cancel:
+
+       if (orig_db->transaction_cancel(orig_db) != 0) {
+               smb_panic("tdbsam_convert: transaction_cancel failed");
+       }
+
+       if (tmp_db->transaction_cancel(tmp_db) != 0) {
+               smb_panic("tdbsam_convert: transaction_cancel failed");
+       }
+
+       unlink(tmp_fname);
+       TALLOC_FREE(tmp_db);
+       TALLOC_FREE(frame);
+       return false;
+}
+
+static bool tdbsam_upgrade_next_rid(struct db_context *db)
 {
-       const char *prefix = USERPREFIX;
-       int  prefixlen = strlen (prefix);
-       struct pwent_list *ptr;
-       
-       if ( strncmp(key.dptr, prefix, prefixlen) == 0 ) {
-               if ( !(ptr=SMB_MALLOC_P(struct pwent_list)) ) {
-                       DEBUG(0,("tdbsam_traverse_setpwent: Failed to malloc new entry for list\n"));
-                       
-                       /* just return 0 and let the traversal continue */
-                       return 0;
+       TDB_CONTEXT *tdb;
+       uint32 rid;
+       bool ok = false;
+
+       ok = dbwrap_fetch_uint32(db, NEXT_RID_STRING, &rid);
+       if (ok) {
+               return true;
+       }
+
+       tdb = tdb_open_log(state_path("winbindd_idmap.tdb"), 0,
+                          TDB_DEFAULT, O_RDONLY, 0644);
+
+       if (tdb) {
+               ok = tdb_fetch_uint32(tdb, "RID_COUNTER", &rid);
+               if (!ok) {
+                       rid = BASE_RID;
                }
-               ZERO_STRUCTP(ptr);
-               
-               /* save a copy of the key */
-               
-               ptr->key.dptr = memdup( key.dptr, key.dsize );
-               ptr->key.dsize = key.dsize;
-               
-               DLIST_ADD( tdbsam_pwent_list, ptr );
-       
+               tdb_close(tdb);
+       } else {
+               rid = BASE_RID;
        }
-       
-       
-       return 0;
-}
 
-/***************************************************************
- Open the TDB passwd database for SAM account enumeration.
- Save a list of user keys for iteration.
-****************************************************************/
+       if (dbwrap_store_uint32(db, NEXT_RID_STRING, rid) != 0) {
+               return false;
+       }
 
-static NTSTATUS tdbsam_setsampwent(struct pdb_methods *my_methods, BOOL update, uint16 acb_mask)
+       return true;
+}
+
+static bool tdbsam_convert(struct db_context **pp_db, const char *name, int32 from)
 {
-       if ( !tdbsam_open( tdbsam_filename ) ) {
-               DEBUG(0,("tdbsam_getsampwnam: failed to open %s!\n", tdbsam_filename));
-               return NT_STATUS_ACCESS_DENIED;
+       struct tdbsam_convert_state state;
+       struct db_context *db = NULL;
+       int ret;
+
+       /* We only need the update backup for local db's. */
+       if (db_is_local(name) && !tdbsam_convert_backup(name, pp_db)) {
+               DEBUG(0, ("tdbsam_convert: Could not backup %s\n", name));
+               return false;
        }
 
-       tdb_traverse( tdbsam, tdbsam_traverse_setpwent, NULL );
+       db = *pp_db;
+       state.from = from;
+       state.success = true;
 
-       return NT_STATUS_OK;
-}
+       if (db->transaction_start(db) != 0) {
+               DEBUG(0, ("tdbsam_convert: Could not start transaction\n"));
+               return false;
+       }
 
+       if (!tdbsam_upgrade_next_rid(db)) {
+               DEBUG(0, ("tdbsam_convert: tdbsam_upgrade_next_rid failed\n"));
+               goto cancel;
+       }
 
-/***************************************************************
- End enumeration of the TDB passwd list.
-****************************************************************/
+       ret = db->traverse(db, tdbsam_convert_one, &state);
+       if (ret < 0) {
+               DEBUG(0, ("tdbsam_convert: traverse failed\n"));
+               goto cancel;
+       }
 
-static void tdbsam_endsampwent(struct pdb_methods *my_methods)
-{
-       struct pwent_list *ptr, *ptr_next;
-       
-       /* clear out any remaining entries in the list */
-       
-       for ( ptr=tdbsam_pwent_list; ptr; ptr = ptr_next ) {
-               ptr_next = ptr->next;
-               DLIST_REMOVE( tdbsam_pwent_list, ptr );
-               SAFE_FREE( ptr->key.dptr);
-               SAFE_FREE( ptr );
+       if (!state.success) {
+               DEBUG(0, ("tdbsam_convert: Converting records failed\n"));
+               goto cancel;
+       }
+
+       if (dbwrap_store_int32(db, TDBSAM_VERSION_STRING,
+                              TDBSAM_VERSION) != 0) {
+               DEBUG(0, ("tdbsam_convert: Could not store tdbsam version\n"));
+               goto cancel;
+       }
+
+       if (db->transaction_commit(db) != 0) {
+               DEBUG(0, ("tdbsam_convert: Could not commit transaction\n"));
+               return false;
        }
-       
-       DEBUG(7, ("endtdbpwent: closed sam database.\n"));
 
-       tdbsam_close();
+       return true;
+
+ cancel:
+       if (db->transaction_cancel(db) != 0) {
+               smb_panic("tdbsam_convert: transaction_cancel failed");
+       }
+
+       return false;
 }
 
-/*****************************************************************
- Get one struct samu from the TDB (next in line)
-*****************************************************************/
+/*********************************************************************
+ Open the tdbsam file based on the absolute path specified.
+ Uses a reference count to allow multiple open calls.
+*********************************************************************/
 
-static NTSTATUS tdbsam_getsampwent(struct pdb_methods *my_methods, struct samu *user)
+static bool tdbsam_open( const char *name )
 {
-       NTSTATUS                nt_status = NT_STATUS_UNSUCCESSFUL;
-       TDB_DATA                data;
-       struct pwent_list       *pkey;
+       int32   version;
 
-       if ( !user ) {
-               DEBUG(0,("tdbsam_getsampwent: struct samu is NULL.\n"));
-               return nt_status;
+       /* check if we are already open */
+
+       if ( db_sam ) {
+               return true;
        }
 
-       if ( !tdbsam_pwent_list ) {
-               DEBUG(4,("tdbsam_getsampwent: end of list\n"));
-               return nt_status;
+       /* Try to open tdb passwd.  Create a new one if necessary */
+
+       db_sam = db_open(NULL, name, 0, TDB_DEFAULT, O_CREAT|O_RDWR, 0600);
+       if (db_sam == NULL) {
+               DEBUG(0, ("tdbsam_open: Failed to open/create TDB passwd "
+                         "[%s]\n", name));
+               return false;
        }
-       
-       /* pull the next entry */
-               
-       pkey = tdbsam_pwent_list;
-       DLIST_REMOVE( tdbsam_pwent_list, pkey );
-       
-       data = tdb_fetch(tdbsam, pkey->key);
 
-       SAFE_FREE( pkey->key.dptr);
-       SAFE_FREE( pkey);
-       
-       if ( !data.dptr ) {
-               DEBUG(5,("pdb_getsampwent: database entry not found.  Was the user deleted?\n"));
-               return nt_status;
+       /* Check the version */
+       version = dbwrap_fetch_int32(db_sam, TDBSAM_VERSION_STRING);
+       if (version == -1) {
+               version = 0;    /* Version not found, assume version 0 */
        }
-  
-       if ( !init_sam_from_buffer(user, (unsigned char *)data.dptr, data.dsize) ) {
-               DEBUG(0,("pdb_getsampwent: Bad struct samu entry returned from TDB!\n"));
+
+       /* Compare the version */
+       if (version > TDBSAM_VERSION) {
+               /* Version more recent than the latest known */
+               DEBUG(0, ("tdbsam_open: unknown version => %d\n", version));
+               TALLOC_FREE(db_sam);
+               return false;
        }
-       
-       SAFE_FREE( data.dptr );
 
-       return NT_STATUS_OK;
+       if ( version < TDBSAM_VERSION ) {
+               /*
+                * Ok - we think we're going to have to convert.
+                * Due to the backup process we now must do to
+                * upgrade we have to get a mutex and re-check
+                * the version. Someone else may have upgraded
+                * whilst we were checking.
+                */
+
+               struct named_mutex *mtx = grab_named_mutex(NULL,
+                                               "tdbsam_upgrade_mutex",
+                                               600);
+
+               if (!mtx) {
+                       DEBUG(0, ("tdbsam_open: failed to grab mutex.\n"));
+                       TALLOC_FREE(db_sam);
+                       return false;
+               }
+
+               /* Re-check the version */
+               version = dbwrap_fetch_int32(db_sam, TDBSAM_VERSION_STRING);
+               if (version == -1) {
+                       version = 0;    /* Version not found, assume version 0 */
+               }
+
+               /* Compare the version */
+               if (version > TDBSAM_VERSION) {
+                       /* Version more recent than the latest known */
+                       DEBUG(0, ("tdbsam_open: unknown version => %d\n", version));
+                       TALLOC_FREE(db_sam);
+                       TALLOC_FREE(mtx);
+                       return false;
+               }
+
+               if ( version < TDBSAM_VERSION ) {
+                       DEBUG(1, ("tdbsam_open: Converting version %d database to "
+                                 "version %d.\n", version, TDBSAM_VERSION));
+
+                       if ( !tdbsam_convert(&db_sam, name, version) ) {
+                               DEBUG(0, ("tdbsam_open: Error when trying to convert "
+                                         "tdbsam [%s]\n",name));
+                               TALLOC_FREE(db_sam);
+                               TALLOC_FREE(mtx);
+                               return false;
+                       }
+
+                       DEBUG(3, ("TDBSAM converted successfully.\n"));
+               }
+               TALLOC_FREE(mtx);
+       }
+
+       DEBUG(4,("tdbsam_open: successfully opened %s\n", name ));
+
+       return true;
 }
 
 /******************************************************************
  Lookup a name in the SAM TDB
 ******************************************************************/
 
-static NTSTATUS tdbsam_getsampwnam (struct pdb_methods *my_methods, struct samu *user, const char *sname)
+static NTSTATUS tdbsam_getsampwnam (struct pdb_methods *my_methods,
+                                   struct samu *user, const char *sname)
 {
-       NTSTATUS        result;
-       TDB_DATA        data, key;
+       TDB_DATA        data;
        fstring         keystr;
        fstring         name;
 
@@ -385,53 +490,47 @@ static NTSTATUS tdbsam_getsampwnam (struct pdb_methods *my_methods, struct samu
 
        /* set search key */
        slprintf(keystr, sizeof(keystr)-1, "%s%s", USERPREFIX, name);
-       key.dptr = keystr;
-       key.dsize = strlen(keystr) + 1;
 
        /* open the database */
-               
+
        if ( !tdbsam_open( tdbsam_filename ) ) {
                DEBUG(0,("tdbsam_getsampwnam: failed to open %s!\n", tdbsam_filename));
                return NT_STATUS_ACCESS_DENIED;
        }
-       
+
        /* get the record */
-       
-       data = tdb_fetch(tdbsam, key);
+
+       data = dbwrap_fetch_bystring(db_sam, talloc_tos(), keystr);
        if (!data.dptr) {
                DEBUG(5,("pdb_getsampwnam (TDB): error fetching database.\n"));
-               DEBUGADD(5, (" Error: %s\n", tdb_errorstr(tdbsam)));
                DEBUGADD(5, (" Key: %s\n", keystr));
-               result = NT_STATUS_NO_SUCH_USER;
-               goto done;
+               return NT_STATUS_NO_SUCH_USER;
        }
-  
+
        /* unpack the buffer */
-       
-       if (!init_sam_from_buffer(user, (unsigned char *)data.dptr, data.dsize)) {
+
+       if (!init_samu_from_buffer(user, SAMU_BUFFER_LATEST, data.dptr, data.dsize)) {
                DEBUG(0,("pdb_getsampwent: Bad struct samu entry returned from TDB!\n"));
                SAFE_FREE(data.dptr);
-               result = NT_STATUS_NO_MEMORY;
-               goto done;
+               return NT_STATUS_NO_MEMORY;
        }
-       
-       result = NT_STATUS_OK;
-       
- done:
-       SAFE_FREE(data.dptr);
-       tdbsam_close();
-       
-       return result;
+
+       /* success */
+
+       TALLOC_FREE(data.dptr);
+
+       return NT_STATUS_OK;
 }
 
 /***************************************************************************
  Search by rid
  **************************************************************************/
 
-static NTSTATUS tdbsam_getsampwrid (struct pdb_methods *my_methods, struct samu *user, uint32 rid)
+static NTSTATUS tdbsam_getsampwrid (struct pdb_methods *my_methods,
+                                   struct samu *user, uint32 rid)
 {
        NTSTATUS                nt_status = NT_STATUS_UNSUCCESSFUL;
-       TDB_DATA                data, key;
+       TDB_DATA                data;
        fstring                 keystr;
        fstring                 name;
 
@@ -439,146 +538,141 @@ static NTSTATUS tdbsam_getsampwrid (struct pdb_methods *my_methods, struct samu
                DEBUG(0,("pdb_getsampwrid: struct samu is NULL.\n"));
                return nt_status;
        }
-       
+
        /* set search key */
-       
+
        slprintf(keystr, sizeof(keystr)-1, "%s%.8x", RIDPREFIX, rid);
-       key.dptr = keystr;
-       key.dsize = strlen (keystr) + 1;
 
        /* open the database */
-               
+
        if ( !tdbsam_open( tdbsam_filename ) ) {
-               DEBUG(0,("tdbsam_getsampwnam: failed to open %s!\n", tdbsam_filename));
+               DEBUG(0,("tdbsam_getsampwrid: failed to open %s!\n", tdbsam_filename));
                return NT_STATUS_ACCESS_DENIED;
        }
 
        /* get the record */
-       
-       data = tdb_fetch (tdbsam, key);
+
+       data = dbwrap_fetch_bystring(db_sam, talloc_tos(), keystr);
        if (!data.dptr) {
                DEBUG(5,("pdb_getsampwrid (TDB): error looking up RID %d by key %s.\n", rid, keystr));
-               DEBUGADD(5, (" Error: %s\n", tdb_errorstr(tdbsam)));
-               nt_status = NT_STATUS_UNSUCCESSFUL;
-               goto done;
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
-       fstrcpy(name, data.dptr);
-       SAFE_FREE(data.dptr);
-       
-       nt_status = tdbsam_getsampwnam (my_methods, user, name);
+       fstrcpy(name, (const char *)data.dptr);
+       TALLOC_FREE(data.dptr);
 
- done:
-       /* cleanup */
-       
-       tdbsam_close();
-               
-       return nt_status;
+       return tdbsam_getsampwnam (my_methods, user, name);
 }
 
-static NTSTATUS tdbsam_getsampwsid(struct pdb_methods *my_methods, struct samu * user, const DOM_SID *sid)
+static NTSTATUS tdbsam_getsampwsid(struct pdb_methods *my_methods,
+                                  struct samu * user, const DOM_SID *sid)
 {
        uint32 rid;
-       
+
        if ( !sid_peek_check_rid(get_global_sam_sid(), sid, &rid) )
                return NT_STATUS_UNSUCCESSFUL;
 
        return tdbsam_getsampwrid(my_methods, user, rid);
 }
 
-static BOOL tdb_delete_samacct_only( struct samu *sam_pass )
+static bool tdb_delete_samacct_only( struct samu *sam_pass )
 {
-       TDB_DATA        key;
        fstring         keystr;
        fstring         name;
+       NTSTATUS status;
 
        fstrcpy(name, pdb_get_username(sam_pass));
        strlower_m(name);
-       
+
        /* set the search key */
-       
+
        slprintf(keystr, sizeof(keystr)-1, "%s%s", USERPREFIX, name);
-       key.dptr = keystr;
-       key.dsize = strlen (keystr) + 1;
-       
+
        /* it's outaa here!  8^) */
-       
-       if (tdb_delete(tdbsam, key) != TDB_SUCCESS) {
-               DEBUG(5, ("Error deleting entry from tdb passwd database!\n"));
-               DEBUGADD(5, (" Error: %s\n", tdb_errorstr(tdbsam)));
-               return False;
+       if ( !tdbsam_open( tdbsam_filename ) ) {
+               DEBUG(0,("tdb_delete_samacct_only: failed to open %s!\n",
+                        tdbsam_filename));
+               return false;
        }
-       
-       return True;
+
+       status = dbwrap_delete_bystring(db_sam, keystr);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(5, ("Error deleting entry from tdb passwd "
+                         "database: %s!\n", nt_errstr(status)));
+               return false;
+       }
+
+       return true;
 }
 
 /***************************************************************************
  Delete a struct samu records for the username and RID key
 ****************************************************************************/
 
-static NTSTATUS tdbsam_delete_sam_account(struct pdb_methods *my_methods, struct samu *sam_pass)
+static NTSTATUS tdbsam_delete_sam_account(struct pdb_methods *my_methods,
+                                         struct samu *sam_pass)
 {
        NTSTATUS        nt_status = NT_STATUS_UNSUCCESSFUL;
-       TDB_DATA        key;
        fstring         keystr;
        uint32          rid;
        fstring         name;
-       
-       /* make sure we have an open handle to the tdb.  Should have happened 
-          at module  initialization time */
-          
-       if ( !tdbsam ) {
-               DEBUG(0,("tdbsam_getsampwrid: tdbsam not open!\n"));
-               return NT_STATUS_NO_SUCH_USER;
+
+       /* open the database */
+
+       if ( !tdbsam_open( tdbsam_filename ) ) {
+               DEBUG(0,("tdbsam_delete_sam_account: failed to open %s!\n",
+                        tdbsam_filename));
+               return NT_STATUS_ACCESS_DENIED;
        }
 
        fstrcpy(name, pdb_get_username(sam_pass));
        strlower_m(name);
-       
+
        /* set the search key */
 
        slprintf(keystr, sizeof(keystr)-1, "%s%s", USERPREFIX, name);
-       key.dptr = keystr;
-       key.dsize = strlen (keystr) + 1;
-       
+
        rid = pdb_get_user_rid(sam_pass);
 
-       /* open the database */
-               
-       if ( !tdbsam_open( tdbsam_filename ) ) {
-               DEBUG(0,("tdbsam_getsampwnam: failed to open %s!\n", tdbsam_filename));
-               return NT_STATUS_ACCESS_DENIED;
-       }
-       
        /* it's outaa here!  8^) */
 
-       if ( tdb_delete(tdbsam, key) != TDB_SUCCESS ) {
-               DEBUG(5, ("Error deleting entry from tdb passwd database!\n"));
-               DEBUGADD(5, (" Error: %s\n", tdb_errorstr(tdbsam)));
-               nt_status = NT_STATUS_UNSUCCESSFUL;
-               goto done;
+       if (db_sam->transaction_start(db_sam) != 0) {
+               DEBUG(0, ("Could not start transaction\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       nt_status = dbwrap_delete_bystring(db_sam, keystr);
+       if (!NT_STATUS_IS_OK(nt_status)) {
+               DEBUG(5, ("Error deleting entry from tdb passwd "
+                         "database: %s!\n", nt_errstr(nt_status)));
+               goto cancel;
        }
 
        /* set the search key */
-       
+
        slprintf(keystr, sizeof(keystr)-1, "%s%.8x", RIDPREFIX, rid);
-       key.dptr = keystr;
-       key.dsize = strlen (keystr) + 1;
 
        /* it's outaa here!  8^) */
-       
-       if ( tdb_delete(tdbsam, key) != TDB_SUCCESS ) {
-               DEBUG(5, ("Error deleting entry from tdb rid database!\n"));
-               DEBUGADD(5, (" Error: %s\n", tdb_errorstr(tdbsam)));
-               nt_status = NT_STATUS_UNSUCCESSFUL;
-               goto done;
+
+       nt_status = dbwrap_delete_bystring(db_sam, keystr);
+       if (!NT_STATUS_IS_OK(nt_status)) {
+               DEBUG(5, ("Error deleting entry from tdb rid "
+                         "database: %s!\n", nt_errstr(nt_status)));
+               goto cancel;
+       }
+
+       if (db_sam->transaction_commit(db_sam) != 0) {
+               DEBUG(0, ("Could not commit transaction\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
+       return NT_STATUS_OK;
+
+ cancel:
+       if (db_sam->transaction_cancel(db_sam) != 0) {
+               smb_panic("transaction_cancel failed");
        }
 
-       nt_status = NT_STATUS_OK;
-       
- done:
-       tdbsam_close();
-       
        return nt_status;
 }
 
@@ -587,84 +681,80 @@ static NTSTATUS tdbsam_delete_sam_account(struct pdb_methods *my_methods, struct
  Update the TDB SAM account record only
  Assumes that the tdbsam is already open 
 ****************************************************************************/
-static BOOL tdb_update_samacct_only( struct samu* newpwd, int flag )
+static bool tdb_update_samacct_only( struct samu* newpwd, int flag )
 {
-       TDB_DATA        key, data;
+       TDB_DATA        data;
        uint8           *buf = NULL;
        fstring         keystr;
        fstring         name;
-       BOOL            ret = True;
+       bool            ret = false;
+       NTSTATUS status;
 
        /* copy the struct samu struct into a BYTE buffer for storage */
-       
-       if ( (data.dsize=init_buffer_from_sam (&buf, newpwd, False)) == -1 ) {
+
+       if ( (data.dsize=init_buffer_from_samu(&buf, newpwd, False)) == -1 ) {
                DEBUG(0,("tdb_update_sam: ERROR - Unable to copy struct samu info BYTE buffer!\n"));
-               ret = False;
                goto done;
        }
-       data.dptr = (char *)buf;
+       data.dptr = buf;
 
        fstrcpy(name, pdb_get_username(newpwd));
        strlower_m(name);
-       
-       DEBUG(5, ("Storing %saccount %s with RID %d\n", 
-                 flag == TDB_INSERT ? "(new) " : "", name, 
+
+       DEBUG(5, ("Storing %saccount %s with RID %d\n",
+                 flag == TDB_INSERT ? "(new) " : "", name,
                  pdb_get_user_rid(newpwd)));
 
        /* setup the USER index key */
        slprintf(keystr, sizeof(keystr)-1, "%s%s", USERPREFIX, name);
-       key.dptr = keystr;
-       key.dsize = strlen(keystr) + 1;
 
        /* add the account */
-       
-       if ( tdb_store(tdbsam, key, data, flag) != TDB_SUCCESS ) {
-               DEBUG(0, ("Unable to modify passwd TDB!"));
-               DEBUGADD(0, (" Error: %s", tdb_errorstr(tdbsam)));
-               DEBUGADD(0, (" occured while storing the main record (%s)\n",
-                            keystr));
-               ret = False;
+
+       status = dbwrap_store_bystring(db_sam, keystr, data, flag);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("Unable to modify passwd TDB: %s!",
+                         nt_errstr(status)));
                goto done;
        }
 
-done:  
+       ret = true;
+
+done:
        /* cleanup */
        SAFE_FREE(buf);
-       
        return ret;
 }
 
 /***************************************************************************
  Update the TDB SAM RID record only
- Assumes that the tdbsam is already open 
+ Assumes that the tdbsam is already open
 ****************************************************************************/
-static BOOL tdb_update_ridrec_only( struct samu* newpwd, int flag )
+static bool tdb_update_ridrec_only( struct samu* newpwd, int flag )
 {
-       TDB_DATA        key, data;
+       TDB_DATA        data;
        fstring         keystr;
        fstring         name;
+       NTSTATUS status;
 
        fstrcpy(name, pdb_get_username(newpwd));
        strlower_m(name);
 
        /* setup RID data */
-       data.dsize = strlen(name) + 1;
-       data.dptr = name;
+       data = string_term_tdb_data(name);
 
        /* setup the RID index key */
-       slprintf(keystr, sizeof(keystr)-1, "%s%.8x", RIDPREFIX,  pdb_get_user_rid(newpwd));
-       key.dptr = keystr;
-       key.dsize = strlen (keystr) + 1;
-       
+       slprintf(keystr, sizeof(keystr)-1, "%s%.8x", RIDPREFIX,
+                pdb_get_user_rid(newpwd));
+
        /* add the reference */
-       if (tdb_store(tdbsam, key, data, flag) != TDB_SUCCESS) {
-               DEBUG(0, ("Unable to modify TDB passwd !"));
-               DEBUGADD(0, (" Error: %s\n", tdb_errorstr(tdbsam)));
-               DEBUGADD(0, (" occured while storing the RID index (%s)\n", keystr));
-               return False;
+       status = dbwrap_store_bystring(db_sam, keystr, data, flag);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("Unable to modify TDB passwd: %s!\n",
+                         nt_errstr(status)));
+               return false;
        }
 
-       return True;
+       return true;
 
 }
 
@@ -672,42 +762,44 @@ static BOOL tdb_update_ridrec_only( struct samu* newpwd, int flag )
  Update the TDB SAM
 ****************************************************************************/
 
-static BOOL tdb_update_sam(struct pdb_methods *my_methods, struct samu* newpwd, int flag)
+static bool tdb_update_sam(struct pdb_methods *my_methods, struct samu* newpwd,
+                          int flag)
 {
-       uint32          user_rid;
-       BOOL            result = True;
-
-       /* invalidate the existing TDB iterator if it is open */
-       
-       tdbsam_endsampwent( my_methods );
-       
-       if ( !pdb_get_group_rid(newpwd) ) {
-               DEBUG (0,("tdb_update_sam: Failing to store a struct samu for [%s] "
-                       "without a primary group RID\n", pdb_get_username(newpwd)));
-               return False;
-       }
-
-       if ( !(user_rid = pdb_get_user_rid(newpwd)) ) {
-               DEBUG(0,("tdb_update_sam: struct samu (%s) with no RID!\n", pdb_get_username(newpwd)));
+       if (!pdb_get_user_rid(newpwd)) {
+               DEBUG(0,("tdb_update_sam: struct samu (%s) with no RID!\n",
+                        pdb_get_username(newpwd)));
                return False;
        }
 
        /* open the database */
-               
+
        if ( !tdbsam_open( tdbsam_filename ) ) {
                DEBUG(0,("tdbsam_getsampwnam: failed to open %s!\n", tdbsam_filename));
                return False;
        }
-       
-       if ( !tdb_update_samacct_only(newpwd, flag) || !tdb_update_ridrec_only(newpwd, flag)) {
-               result = False;
+
+       if (db_sam->transaction_start(db_sam) != 0) {
+               DEBUG(0, ("Could not start transaction\n"));
+               return false;
        }
 
-       /* cleanup */
+       if (!tdb_update_samacct_only(newpwd, flag)
+           || !tdb_update_ridrec_only(newpwd, flag)) {
+               goto cancel;
+       }
 
-       tdbsam_close();
-       
-       return result;  
+       if (db_sam->transaction_commit(db_sam) != 0) {
+               DEBUG(0, ("Could not commit transaction\n"));
+               return false;
+       }
+
+       return true;
+
+ cancel:
+       if (db_sam->transaction_cancel(db_sam) != 0) {
+               smb_panic("transaction_cancel failed");
+       }
+       return false;
 }
 
 /***************************************************************************
@@ -744,189 +836,283 @@ static NTSTATUS tdbsam_add_sam_account (struct pdb_methods *my_methods, struct s
  - unlock the new user record
 ***************************************************************************/
 static NTSTATUS tdbsam_rename_sam_account(struct pdb_methods *my_methods,
-                                         struct samu *old_acct, 
+                                         struct samu *old_acct,
                                          const char *newname)
 {
        struct samu      *new_acct = NULL;
-       pstring          rename_script;
-       BOOL             interim_account = False;
+       char *rename_script = NULL;
        int              rename_ret;
+       fstring          oldname_lower;
+       fstring          newname_lower;
 
-       /* make sure we have an open handle to the tdb.  Should have happened 
-          at module  initialization time */
-          
-       if ( !tdbsam ) {
-               DEBUG(0,("tdbsam_getsampwrid: tdbsam not open!\n"));
-               return NT_STATUS_NO_SUCH_USER;
-       }
-       
        /* can't do anything without an external script */
-       
-       pstrcpy(rename_script, lp_renameuser_script() );
-       if ( ! *rename_script )
-               return NT_STATUS_ACCESS_DENIED;
 
-       /* invalidate the existing TDB iterator if it is open */
-       
-       tdbsam_endsampwent( my_methods );
+       if ( !(new_acct = samu_new( talloc_tos() )) ) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       rename_script = talloc_strdup(new_acct, lp_renameuser_script());
+       if (!rename_script) {
+               TALLOC_FREE(new_acct);
+               return NT_STATUS_NO_MEMORY;
+       }
+       if (!*rename_script) {
+               TALLOC_FREE(new_acct);
+               return NT_STATUS_ACCESS_DENIED;
+       }
 
-       if ( !pdb_copy_sam_account(old_acct, &new_acct) 
-               || !pdb_set_username(new_acct, newname, PDB_CHANGED)) 
+       if ( !pdb_copy_sam_account(new_acct, old_acct)
+               || !pdb_set_username(new_acct, newname, PDB_CHANGED))
        {
-               TALLOC_FREE(new_acct );
+               TALLOC_FREE(new_acct);
                return NT_STATUS_NO_MEMORY;
        }
 
        /* open the database */
-               
        if ( !tdbsam_open( tdbsam_filename ) ) {
-               DEBUG(0,("tdbsam_getsampwnam: failed to open %s!\n", tdbsam_filename));
-               TALLOC_FREE(new_acct );
+               DEBUG(0, ("tdbsam_getsampwnam: failed to open %s!\n",
+                         tdbsam_filename));
+               TALLOC_FREE(new_acct);
                return NT_STATUS_ACCESS_DENIED;
        }
 
-       /* add the new account and lock it */
-       
-       if ( !tdb_update_samacct_only(new_acct, TDB_INSERT) ) 
-       {
-               goto done;
+       if (db_sam->transaction_start(db_sam) != 0) {
+               DEBUG(0, ("Could not start transaction\n"));
+               TALLOC_FREE(new_acct);
+               return NT_STATUS_ACCESS_DENIED;
+
        }
-       
-       interim_account = True;
 
-       if ( tdb_lock_bystring(tdbsam, newname, 30) == -1 ) {
-               goto done;
+       /* add the new account and lock it */
+       if ( !tdb_update_samacct_only(new_acct, TDB_INSERT) ) {
+               goto cancel;
        }
 
-       /* rename the posix user */
-       
-       pstring_sub(rename_script, "%unew", newname);
-       pstring_sub(rename_script, "%uold", pdb_get_username(old_acct));
+       /* Rename the posix user.  Follow the semantics of _samr_create_user()
+          so that we lower case the posix name but preserve the case in passdb */
+
+       fstrcpy( oldname_lower, pdb_get_username(old_acct) );
+       strlower_m( oldname_lower );
+
+       fstrcpy( newname_lower, newname );
+       strlower_m( newname_lower );
+
+       rename_script = talloc_string_sub2(new_acct,
+                               rename_script,
+                               "%unew",
+                               newname_lower,
+                               true,
+                               false,
+                               true);
+       if (!rename_script) {
+               goto cancel;
+       }
+       rename_script = talloc_string_sub2(new_acct,
+                               rename_script,
+                               "%uold",
+                               oldname_lower,
+                               true,
+                               false,
+                               true);
+       if (!rename_script) {
+               goto cancel;
+       }
        rename_ret = smbrun(rename_script, NULL);
 
-       DEBUG(rename_ret ? 0 : 3,("Running the command `%s' gave %d\n", rename_script, rename_ret));
+       DEBUG(rename_ret ? 0 : 3,("Running the command `%s' gave %d\n",
+                               rename_script, rename_ret));
+
+       if (rename_ret != 0) {
+               goto cancel;
+       }
 
-       if (rename_ret) 
-               goto done; 
+       smb_nscd_flush_user_cache();
 
        /* rewrite the rid->username record */
-       
-       if ( !tdb_update_ridrec_only( new_acct, TDB_MODIFY) )
-               goto done;
-       interim_account = False;
-       tdb_unlock_bystring( tdbsam, newname );
+
+       if ( !tdb_update_ridrec_only( new_acct, TDB_MODIFY) ) {
+               goto cancel;
+       }
 
        tdb_delete_samacct_only( old_acct );
-       
-       tdbsam_close();
-       
+
+       if (db_sam->transaction_commit(db_sam) != 0) {
+               /*
+                * Ok, we're screwed. We've changed the posix account, but
+                * could not adapt passdb.tdb. Shall we change the posix
+                * account back?
+                */
+               DEBUG(0, ("transaction_commit failed\n"));
+               TALLOC_FREE(new_acct);
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;        
+       }
+
        TALLOC_FREE(new_acct );
        return NT_STATUS_OK;
 
-done:  
-       /* cleanup */
-       if (interim_account) {
-               tdb_unlock_bystring(tdbsam, newname);
-               tdb_delete_samacct_only(new_acct);
+ cancel:
+       if (db_sam->transaction_cancel(db_sam) != 0) {
+               smb_panic("transaction_cancel failed");
        }
-       
-       tdbsam_close();
-       
-       if (new_acct)
-               TALLOC_FREE(new_acct);
-       
+
+       TALLOC_FREE(new_acct);
+
        return NT_STATUS_ACCESS_DENIED; 
 }
 
-static BOOL tdbsam_rid_algorithm(struct pdb_methods *methods)
+static bool tdbsam_rid_algorithm(struct pdb_methods *methods)
 {
        return False;
 }
 
-/*
- * Historically, winbind was responsible for allocating RIDs, so the next RID
- * value was stored in winbindd_idmap.tdb. It has been moved to passdb now,
- * but for compatibility reasons we still keep the the next RID counter in
- * winbindd_idmap.tdb.
- */
+static bool tdbsam_new_rid(struct pdb_methods *methods, uint32 *prid)
+{
+       uint32 rid;
 
-/*****************************************************************************
- Initialise idmap database. For now (Dec 2005) this is a copy of the code in
- sam/idmap_tdb.c. Maybe at a later stage we can remove that capability from
- winbind completely and store the RID counter in passdb.tdb.
+       rid = BASE_RID;         /* Default if not set */
+
+       if (!tdbsam_open(tdbsam_filename)) {
+               DEBUG(0,("tdbsam_new_rid: failed to open %s!\n",
+                       tdbsam_filename));
+               return false;
+       }
 
- Dont' fully initialize with the HWM values, if it's new, we're only
- interested in the RID counter.
-*****************************************************************************/
+       if (dbwrap_change_uint32_atomic(db_sam, NEXT_RID_STRING, &rid, 1) != 0) {
+               DEBUG(3, ("tdbsam_new_rid: Failed to increase %s\n",
+                       NEXT_RID_STRING));
+               return false;
+       }
 
-static BOOL init_idmap_tdb(TDB_CONTEXT *tdb)
+       *prid = rid;
+
+       return true;
+}
+
+struct tdbsam_search_state {
+       struct pdb_methods *methods;
+       uint32_t acct_flags;
+
+       uint32_t *rids;
+       uint32_t num_rids;
+       ssize_t array_size;
+       uint32_t current;
+};
+
+static int tdbsam_collect_rids(struct db_record *rec, void *private_data)
 {
-       int32 version;
+       struct tdbsam_search_state *state = talloc_get_type_abort(
+               private_data, struct tdbsam_search_state);
+       size_t prefixlen = strlen(RIDPREFIX);
+       uint32 rid;
 
-       if (tdb_lock_bystring(tdb, "IDMAP_VERSION", 0) != 0) {
-               DEBUG(0, ("Could not lock IDMAP_VERSION\n"));
-               return False;
+       if ((rec->key.dsize < prefixlen)
+           || (strncmp((char *)rec->key.dptr, RIDPREFIX, prefixlen))) {
+               return 0;
        }
 
-       version = tdb_fetch_int32(tdb, "IDMAP_VERSION");
+       rid = strtoul((char *)rec->key.dptr+prefixlen, NULL, 16);
 
-       if (version == -1) {
-               /* No key found, must be a new db */
-               if (tdb_store_int32(tdb, "IDMAP_VERSION",
-                                   IDMAP_VERSION) != 0) {
-                       DEBUG(0, ("Could not store IDMAP_VERSION\n"));
-                       tdb_unlock_bystring(tdb, "IDMAP_VERSION");
-                       return False;
-               }
-               version = IDMAP_VERSION;
-       }
+       ADD_TO_LARGE_ARRAY(state, uint32, rid, &state->rids, &state->num_rids,
+                          &state->array_size);
 
-       if (version != IDMAP_VERSION) {
-               DEBUG(0, ("Expected IDMAP_VERSION=%d, found %d. Please "
-                         "start winbind once\n", IDMAP_VERSION, version));
-               tdb_unlock_bystring(tdb, "IDMAP_VERSION");
-               return False;
-       }
+       return 0;
+}
 
-       tdb_unlock_bystring(tdb, "IDMAP_VERSION");
-       return True;
+static void tdbsam_search_end(struct pdb_search *search)
+{
+       struct tdbsam_search_state *state = talloc_get_type_abort(
+               search->private_data, struct tdbsam_search_state);
+       TALLOC_FREE(state);
 }
 
-static BOOL tdbsam_new_rid(struct pdb_methods *methods, uint32 *prid)
+static bool tdbsam_search_next_entry(struct pdb_search *search,
+                                    struct samr_displayentry *entry)
 {
-       TDB_CONTEXT *tdb;
-       uint32 rid;
-       BOOL ret = False;
+       struct tdbsam_search_state *state = talloc_get_type_abort(
+               search->private_data, struct tdbsam_search_state);
+       struct samu *user = NULL;
+       NTSTATUS status;
+       uint32_t rid;
+
+ again:
+       TALLOC_FREE(user);
+       user = samu_new(talloc_tos());
+       if (user == NULL) {
+               DEBUG(0, ("samu_new failed\n"));
+               return false;
+       }
 
-       tdb = tdb_open_log(lock_path("winbindd_idmap.tdb"), 0,
-                          TDB_DEFAULT, O_RDWR | O_CREAT, 0644);
+       if (state->current == state->num_rids) {
+               return false;
+       }
 
-       if (tdb == NULL) {
-               DEBUG(1, ("Could not open idmap: %s\n", strerror(errno)));
-               goto done;
+       rid = state->rids[state->current++];
+
+       status = tdbsam_getsampwrid(state->methods, user, rid);
+
+       if (NT_STATUS_EQUAL(status, NT_STATUS_NO_SUCH_USER)) {
+               /*
+                * Someone has deleted that user since we listed the RIDs
+                */
+               goto again;
        }
 
-       if (!init_idmap_tdb(tdb)) {
-               DEBUG(1, ("Could not init idmap\n"));
-               goto done;
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("tdbsam_getsampwrid failed: %s\n",
+                          nt_errstr(status)));
+               TALLOC_FREE(user);
+               return false;
        }
 
-       rid = BASE_RID;         /* Default if not set */
+       if ((state->acct_flags != 0) &&
+           ((state->acct_flags & pdb_get_acct_ctrl(user)) == 0)) {
+               goto again;
+       }
 
-       if (!tdb_change_uint32_atomic(tdb, "RID_COUNTER", &rid, 1)) {
-               DEBUG(3, ("tdbsam_new_rid: Failed to increase RID_COUNTER\n"));
-               goto done;
+       entry->acct_flags = pdb_get_acct_ctrl(user);
+       entry->rid = rid;
+       entry->account_name = talloc_strdup(search, pdb_get_username(user));
+       entry->fullname = talloc_strdup(search, pdb_get_fullname(user));
+       entry->description = talloc_strdup(search, pdb_get_acct_desc(user));
+
+       TALLOC_FREE(user);
+
+       if ((entry->account_name == NULL) || (entry->fullname == NULL)
+           || (entry->description == NULL)) {
+               DEBUG(0, ("talloc_strdup failed\n"));
+               return false;
        }
 
-       *prid = rid;
-       ret = True;
+       return true;
+}
+
+static bool tdbsam_search_users(struct pdb_methods *methods,
+                               struct pdb_search *search,
+                               uint32 acct_flags)
+{
+       struct tdbsam_search_state *state;
 
- done:
-       if ((tdb != NULL) && (tdb_close(tdb) != 0)) {
-               smb_panic("tdb_close(idmap_tdb) failed\n");
+       if (!tdbsam_open(tdbsam_filename)) {
+               DEBUG(0,("tdbsam_getsampwnam: failed to open %s!\n",
+                        tdbsam_filename));
+               return false;
        }
 
-       return ret;
+       state = talloc_zero(search, struct tdbsam_search_state);
+       if (state == NULL) {
+               DEBUG(0, ("talloc failed\n"));
+               return false;
+       }
+       state->acct_flags = acct_flags;
+       state->methods = methods;
+
+       db_sam->traverse_read(db_sam, tdbsam_collect_rids, state);
+
+       search->private_data = state;
+       search->next_entry = tdbsam_search_next_entry;
+       search->search_end = tdbsam_search_end;
+
+       return true;
 }
 
 /*********************************************************************
@@ -937,7 +1123,7 @@ static BOOL tdbsam_new_rid(struct pdb_methods *methods, uint32 *prid)
 static NTSTATUS pdb_init_tdbsam(struct pdb_methods **pdb_method, const char *location)
 {
        NTSTATUS nt_status;
-       pstring tdbfile;
+       char *tdbfile = NULL;
        const char *pfile = location;
 
        if (!NT_STATUS_IS_OK(nt_status = make_pdb_method( pdb_method ))) {
@@ -946,29 +1132,34 @@ static NTSTATUS pdb_init_tdbsam(struct pdb_methods **pdb_method, const char *loc
 
        (*pdb_method)->name = "tdbsam";
 
-       (*pdb_method)->setsampwent = tdbsam_setsampwent;
-       (*pdb_method)->endsampwent = tdbsam_endsampwent;
-       (*pdb_method)->getsampwent = tdbsam_getsampwent;
        (*pdb_method)->getsampwnam = tdbsam_getsampwnam;
        (*pdb_method)->getsampwsid = tdbsam_getsampwsid;
        (*pdb_method)->add_sam_account = tdbsam_add_sam_account;
        (*pdb_method)->update_sam_account = tdbsam_update_sam_account;
        (*pdb_method)->delete_sam_account = tdbsam_delete_sam_account;
        (*pdb_method)->rename_sam_account = tdbsam_rename_sam_account;
+       (*pdb_method)->search_users = tdbsam_search_users;
 
        (*pdb_method)->rid_algorithm = tdbsam_rid_algorithm;
        (*pdb_method)->new_rid = tdbsam_new_rid;
 
        /* save the path for later */
-                          
-       if ( !location ) {
-               pstr_sprintf( tdbfile, "%s/%s", lp_private_dir(), PASSDB_FILE_NAME );
+
+       if (!location) {
+               if (asprintf(&tdbfile, "%s/%s", lp_private_dir(),
+                            PASSDB_FILE_NAME) < 0) {
+                       return NT_STATUS_NO_MEMORY;
+               }
                pfile = tdbfile;
        }
-       pstrcpy( tdbsam_filename, pfile );
+       tdbsam_filename = SMB_STRDUP(pfile);
+       if (!tdbsam_filename) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       SAFE_FREE(tdbfile);
 
        /* no private data */
-       
+
        (*pdb_method)->private_data      = NULL;
        (*pdb_method)->free_private_data = NULL;