This is meant to be initialised to the size of the buffer.
[ira/wip.git] / source3 / passdb / pdb_ldap.c
index 38e2e0504d1c09435fd55fa1a5925c256321199c..8a2378f91b281fef28896fe2b931489ef009764e 100644 (file)
@@ -28,7 +28,6 @@
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_PASSDB
 
-#ifdef HAVE_LDAP
 /* TODO:
 *  persistent connections: if using NSS LDAP, many connections are made
 *      however, using only one within Samba would be nice
@@ -64,6 +63,7 @@ struct ldapsam_privates {
        LDAPMessage *entry;
        int index;
        
+       time_t last_ping;
        /* retrive-once info */
        const char *uri;
        
@@ -74,8 +74,11 @@ struct ldapsam_privates {
 
        char *bind_dn;
        char *bind_secret;
+
+       unsigned int num_failures;
 };
 
+#define LDAPSAM_DONT_PING_TIME 10      /* ping only all 10 seconds */
 
 static struct ldapsam_privates *static_ldap_state;
 
@@ -144,53 +147,40 @@ static BOOL fetch_ldapsam_pw(char **dn, char** pw)
 }
 
 static const char *attr[] = {"uid", "pwdLastSet", "logonTime",
-               "logoffTime", "kickoffTime", "cn",
-               "pwdCanChange", "pwdMustChange",
-               "displayName", "homeDrive",
-               "smbHome", "scriptPath",
-               "profilePath", "description",
-               "userWorkstations", "rid",
-               "primaryGroupID", "lmPassword",
-               "ntPassword", "acctFlags",
-               "domain", "description", NULL };
+                            "logoffTime", "kickoffTime", "cn",
+                            "pwdCanChange", "pwdMustChange",
+                            "displayName", "homeDrive",
+                            "smbHome", "scriptPath",
+                            "profilePath", "description",
+                            "userWorkstations", "rid",
+                            "primaryGroupID", "lmPassword",
+                            "ntPassword", "acctFlags",
+                            "domain", "objectClass", 
+                            "uidNumber", "gidNumber", 
+                            "homeDirectory", NULL };
 
 /*******************************************************************
  open a connection to the ldap server.
 ******************************************************************/
-static BOOL ldapsam_open_connection (struct ldapsam_privates *ldap_state, LDAP ** ldap_struct)
+static int ldapsam_open_connection (struct ldapsam_privates *ldap_state, LDAP ** ldap_struct)
 {
-
+       int rc = LDAP_SUCCESS;
        int version;
+       BOOL ldap_v3 = False;
 
-       if (geteuid() != 0) {
-               DEBUG(0, ("ldap_open_connection: cannot access LDAP when not root..\n"));
-               return False;
-       }
-
-#if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
+#ifdef HAVE_LDAP_INITIALIZE
        DEBUG(10, ("ldapsam_open_connection: %s\n", ldap_state->uri));
        
-       if (ldap_initialize(ldap_struct, ldap_state->uri) != LDAP_SUCCESS) {
-               DEBUG(0, ("ldap_initialize: %s\n", strerror(errno)));
-               return (False);
+       if ((rc = ldap_initialize(ldap_struct, ldap_state->uri)) != LDAP_SUCCESS) {
+               DEBUG(0, ("ldap_initialize: %s\n", ldap_err2string(rc)));
+               return rc;
        }
        
-       if (ldap_get_option(*ldap_struct, LDAP_OPT_PROTOCOL_VERSION, &version) == LDAP_OPT_SUCCESS)
-       {
-               if (version != LDAP_VERSION3)
-               {
-                       version = LDAP_VERSION3;
-                       ldap_set_option (*ldap_struct, LDAP_OPT_PROTOCOL_VERSION, &version);
-               }
-       }
-
 #else 
 
        /* Parse the string manually */
 
        {
-               int rc;
-               int tls = LDAP_OPT_X_TLS_HARD;
                int port = 0;
                fstring protocol;
                fstring host;
@@ -201,7 +191,7 @@ static BOOL ldapsam_open_connection (struct ldapsam_privates *ldap_state, LDAP *
                if ( strncasecmp( p, "URL:", 4 ) == 0 ) {
                        p += 4;
                }
-
+               
                sscanf(p, "%10[^:]://%254s[^:]:%d", protocol, host, &port);
                
                if (port == 0) {
@@ -213,59 +203,65 @@ static BOOL ldapsam_open_connection (struct ldapsam_privates *ldap_state, LDAP *
                                DEBUG(0, ("unrecognised protocol (%s)!\n", protocol));
                        }
                }
-
+               
                if ((*ldap_struct = ldap_init(host, port)) == NULL)     {
                        DEBUG(0, ("ldap_init failed !\n"));
-                       return False;
+                       return LDAP_OPERATIONS_ERROR;
                }
-
-               /* Connect to older servers using SSL and V2 rather than Start TLS */
-               if (ldap_get_option(*ldap_struct, LDAP_OPT_PROTOCOL_VERSION, &version) == LDAP_OPT_SUCCESS)
-               {
-                       if (version != LDAP_VERSION2)
+               
+               if (strequal(protocol, "ldaps")) {
+#ifdef LDAP_OPT_X_TLS
+                       int tls = LDAP_OPT_X_TLS_HARD;
+                       if (ldap_set_option (*ldap_struct, LDAP_OPT_X_TLS, &tls) != LDAP_SUCCESS)
                        {
-                               version = LDAP_VERSION2;
-                               ldap_set_option (*ldap_struct, LDAP_OPT_PROTOCOL_VERSION, &version);
+                               DEBUG(0, ("Failed to setup a TLS session\n"));
                        }
+                       
+                       DEBUG(3,("LDAPS option set...!\n"));
+#else
+                       DEBUG(0,("ldapsam_open_connection: Secure connection not supported by LDAP client libraries!\n"));
+                       return LDAP_OPERATIONS_ERROR;
+#endif
                }
+       }
+#endif
 
-               if (strequal(protocol, "ldaps")) { 
-                       if (lp_ldap_ssl() == LDAP_SSL_START_TLS) {
-                               if (ldap_get_option (*ldap_struct, LDAP_OPT_PROTOCOL_VERSION, 
-                                                    &version) == LDAP_OPT_SUCCESS)
-                               {
-                                       if (version < LDAP_VERSION3)
-                                       {
-                                               version = LDAP_VERSION3;
-                                               ldap_set_option (*ldap_struct, LDAP_OPT_PROTOCOL_VERSION,
-                                                                &version);
-                                       }
-                               }
-                               if ((rc = ldap_start_tls_s (*ldap_struct, NULL, NULL)) != LDAP_SUCCESS)
-                               {
-                                       DEBUG(0,("Failed to issue the StartTLS instruction: %s\n",
-                                                ldap_err2string(rc)));
-                                       return False;
-                               }
-                               DEBUG (2, ("StartTLS issued: using a TLS connection\n"));
-                       } else {
-                               
-                               if (ldap_set_option (*ldap_struct, LDAP_OPT_X_TLS, &tls) != LDAP_SUCCESS)
-                               {
-                                       DEBUG(0, ("Failed to setup a TLS session\n"));
-                               }
+       if (ldap_get_option(*ldap_struct, LDAP_OPT_PROTOCOL_VERSION, &version) == LDAP_OPT_SUCCESS)
+       {
+               if (version != LDAP_VERSION3)
+               {
+                       version = LDAP_VERSION3;
+                       if (ldap_set_option (*ldap_struct, LDAP_OPT_PROTOCOL_VERSION, &version) == LDAP_OPT_SUCCESS) {
+                               ldap_v3 = True;
                        }
                } else {
-                       /* 
-                        * No special needs to setup options prior to the LDAP
-                        * bind (which should be called next via ldap_connect_system()
-                        */
+                       ldap_v3 = True;
                }
        }
+
+       if (lp_ldap_ssl() == LDAP_SSL_START_TLS) {
+#ifdef LDAP_OPT_X_TLS
+               if (ldap_v3) {
+                       if ((rc = ldap_start_tls_s (*ldap_struct, NULL, NULL)) != LDAP_SUCCESS)
+                       {
+                               DEBUG(0,("Failed to issue the StartTLS instruction: %s\n",
+                                        ldap_err2string(rc)));
+                               return rc;
+                       }
+                       DEBUG (3, ("StartTLS issued: using a TLS connection\n"));
+               } else {
+                       
+                       DEBUG(0, ("Need LDAPv3 for Start TLS\n"));
+                       return LDAP_OPERATIONS_ERROR;
+               }
+#else
+               DEBUG(0,("ldapsam_open_connection: StartTLS not supported by LDAP client libraries!\n"));
+               return LDAP_OPERATIONS_ERROR;
 #endif
+       }
 
-       DEBUG(2, ("ldap_open_connection: connection opened\n"));
-       return True;
+       DEBUG(2, ("ldapsam_open_connection: connection opened\n"));
+       return rc;
 }
 
 
@@ -289,7 +285,7 @@ static int rebindproc_with_state  (LDAP * ld, char **whop, char **credp,
                memset(*credp, '\0', strlen(*credp));
                SAFE_FREE(*credp);
        } else {
-               DEBUG(5,("ldap_connect_system: Rebinding as \"%s\"\n", 
+               DEBUG(5,("rebind_proc_with_state: Rebinding as \"%s\"\n", 
                          ldap_state->bind_dn));
 
                *whop = strdup(ldap_state->bind_dn);
@@ -320,7 +316,7 @@ static int rebindproc_connect_with_state (LDAP *ldap_struct,
 {
        struct ldapsam_privates *ldap_state = arg;
        int rc;
-       DEBUG(5,("ldap_connect_system: Rebinding as \"%s\"\n", 
+       DEBUG(5,("rebindproc_connect_with_state: Rebinding as \"%s\"\n", 
                 ldap_state->bind_dn));
        
        /** @TODO Should we be doing something to check what servers we rebind to?
@@ -367,7 +363,7 @@ static int rebindproc_connect (LDAP * ld, LDAP_CONST char *url, int request,
 /*******************************************************************
  connect to the ldap server under system privilege.
 ******************************************************************/
-static BOOL ldapsam_connect_system(struct ldapsam_privates *ldap_state, LDAP * ldap_struct)
+static int ldapsam_connect_system(struct ldapsam_privates *ldap_state, LDAP * ldap_struct)
 {
        int rc;
        char *ldap_dn;
@@ -381,7 +377,7 @@ static BOOL ldapsam_connect_system(struct ldapsam_privates *ldap_state, LDAP * l
        if (!fetch_ldapsam_pw(&ldap_dn, &ldap_secret))
        {
                DEBUG(0, ("ldap_connect_system: Failed to retrieve password from secrets.tdb\n"));
-               return False;
+               return LDAP_INVALID_CREDENTIALS;
        }
 
        ldap_state->bind_dn = ldap_dn;
@@ -390,8 +386,8 @@ static BOOL ldapsam_connect_system(struct ldapsam_privates *ldap_state, LDAP * l
        /* removed the sasl_bind_s "EXTERNAL" stuff, as my testsuite 
           (OpenLDAP) doesnt' seem to support it */
           
-       DEBUG(10,("ldap_connect_system: Binding to ldap server as \"%s\"\n",
-               ldap_dn));
+       DEBUG(10,("ldap_connect_system: Binding to ldap server %s as \"%s\"\n",
+                 ldap_state->uri, ldap_dn));
 
 #if defined(LDAP_API_FEATURE_X_OPENLDAP) && (LDAP_API_VERSION > 2000)
 # if LDAP_SET_REBIND_PROC_ARGS == 2    
@@ -412,31 +408,272 @@ static BOOL ldapsam_connect_system(struct ldapsam_privates *ldap_state, LDAP * l
        rc = ldap_simple_bind_s(ldap_struct, ldap_dn, ldap_secret);
 
        if (rc != LDAP_SUCCESS) {
-               DEBUG(0, ("Bind failed: %s\n", ldap_err2string(rc)));
-               return False;
+               char *ld_error = NULL;
+               ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                               &ld_error);
+               DEBUG(ldap_state->num_failures ? 2 : 0,
+                     ("failed to bind to server with dn= %s Error: %s\n\t%s\n",
+                              ldap_dn ? ld_error : "(unknown)", ldap_err2string(rc),
+                              ld_error));
+               SAFE_FREE(ld_error);
+               ldap_state->num_failures++;
+               return rc;
+       }
+
+       ldap_state->num_failures = 0;
+
+       DEBUG(3, ("ldap_connect_system: succesful connection to the LDAP server\n"));
+       return rc;
+}
+
+/**********************************************************************
+Connect to LDAP server 
+*********************************************************************/
+static int ldapsam_open(struct ldapsam_privates *ldap_state)
+{
+       int rc;
+       SMB_ASSERT(ldap_state);
+               
+#ifndef NO_LDAP_SECURITY
+       if (geteuid() != 0) {
+               DEBUG(0, ("ldapsam_open: cannot access LDAP when not root..\n"));
+               return  LDAP_INSUFFICIENT_ACCESS;
+       }
+#endif
+
+       if ((ldap_state->ldap_struct != NULL) && ((ldap_state->last_ping + LDAPSAM_DONT_PING_TIME) < time(NULL))) {
+               struct sockaddr_un addr;
+               socklen_t len = sizeof(addr);
+               int sd;
+               if (ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_DESC, &sd) == 0 &&
+                   getpeername(sd, (struct sockaddr *) &addr, &len) < 0) {
+                       /* the other end has died. reopen. */
+                       ldap_unbind_ext(ldap_state->ldap_struct, NULL, NULL);
+                       ldap_state->ldap_struct = NULL;
+                       ldap_state->last_ping = (time_t)0;
+               } else {
+                       ldap_state->last_ping = time(NULL);
+               } 
+       }
+
+       if (ldap_state->ldap_struct != NULL) {
+               DEBUG(5,("ldapsam_open: allready connected to the LDAP server\n"));
+               return LDAP_SUCCESS;
+       }
+
+       if ((rc = ldapsam_open_connection(ldap_state, &ldap_state->ldap_struct))) {
+               return rc;
+       }
+
+       if ((rc = ldapsam_connect_system(ldap_state, ldap_state->ldap_struct))) {
+               ldap_unbind_ext(ldap_state->ldap_struct, NULL, NULL);
+               ldap_state->ldap_struct = NULL;
+               return rc;
+       }
+
+
+       ldap_state->last_ping = time(NULL);
+       DEBUG(4,("The LDAP server is succesful connected\n"));
+
+       return LDAP_SUCCESS;
+}
+
+/**********************************************************************
+Disconnect from LDAP server 
+*********************************************************************/
+static NTSTATUS ldapsam_close(struct ldapsam_privates *ldap_state)
+{
+       if (!ldap_state)
+               return NT_STATUS_INVALID_PARAMETER;
+               
+       if (ldap_state->ldap_struct != NULL) {
+               ldap_unbind_ext(ldap_state->ldap_struct, NULL, NULL);
+               ldap_state->ldap_struct = NULL;
        }
        
-       DEBUG(2, ("ldap_connect_system: succesful connection to the LDAP server\n"));
-       return True;
+       DEBUG(5,("The connection to the LDAP server was closed\n"));
+       /* maybe free the results here --metze */
+       
+       return NT_STATUS_OK;
+}
+
+static int ldapsam_retry_open(struct ldapsam_privates *ldap_state, int *attempts)
+{
+       int rc;
+
+       SMB_ASSERT(ldap_state && attempts);
+               
+       if (*attempts != 0) {
+               unsigned int sleep_time;
+               uint8 rand_byte = 128; /* a reasonable place to start */
+
+               generate_random_buffer(&rand_byte, 1, False);
+
+               sleep_time = (((*attempts)*(*attempts))/2)*rand_byte*2; 
+               /* we retry after (0.5, 1, 2, 3, 4.5, 6) seconds
+                  on average.  
+                */
+               DEBUG(3, ("Sleeping for %u milliseconds before reconnecting\n", 
+                         sleep_time));
+               msleep(sleep_time);
+       }
+       (*attempts)++;
+
+       if ((rc = ldapsam_open(ldap_state))) {
+               DEBUG(1,("Connection to LDAP Server failed for the %d try!\n",*attempts));
+               return rc;
+       } 
+       
+       return LDAP_SUCCESS;            
+}
+
+
+static int ldapsam_search(struct ldapsam_privates *ldap_state, 
+                         const char *base, int scope, const char *filter, 
+                         const char *attrs[], int attrsonly, 
+                         LDAPMessage **res)
+{
+       int             rc = LDAP_SERVER_DOWN;
+       int             attempts = 0;
+       
+       SMB_ASSERT(ldap_state);
+
+       while ((rc == LDAP_SERVER_DOWN) && (attempts < 8)) {
+               
+               if ((rc = ldapsam_retry_open(ldap_state,&attempts)) != LDAP_SUCCESS)
+                       continue;
+               
+               rc = ldap_search_s(ldap_state->ldap_struct, base, scope, 
+                                  filter, (char **)attrs, attrsonly, res);
+       }
+       
+       if (rc == LDAP_SERVER_DOWN) {
+               DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO));
+               ldapsam_close(ldap_state);      
+       }
+       
+       return rc;
+}
+
+static int ldapsam_modify(struct ldapsam_privates *ldap_state, char *dn, LDAPMod *attrs[])
+{
+       int             rc = LDAP_SERVER_DOWN;
+       int             attempts = 0;
+       
+       if (!ldap_state)
+               return (-1);
+
+       while ((rc == LDAP_SERVER_DOWN) && (attempts < 8)) {
+               
+               if ((rc = ldapsam_retry_open(ldap_state,&attempts)) != LDAP_SUCCESS)
+                       continue;
+               
+               rc = ldap_modify_s(ldap_state->ldap_struct, dn, attrs);
+       }
+       
+       if (rc == LDAP_SERVER_DOWN) {
+               DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO));
+               ldapsam_close(ldap_state);      
+       }
+       
+       return rc;
+}
+
+static int ldapsam_add(struct ldapsam_privates *ldap_state, const char *dn, LDAPMod *attrs[])
+{
+       int             rc = LDAP_SERVER_DOWN;
+       int             attempts = 0;
+       
+       if (!ldap_state)
+               return (-1);
+
+       while ((rc == LDAP_SERVER_DOWN) && (attempts < 8)) {
+               
+               if ((rc = ldapsam_retry_open(ldap_state,&attempts)) != LDAP_SUCCESS)
+                       continue;
+               
+               rc = ldap_add_s(ldap_state->ldap_struct, dn, attrs);
+       }
+       
+       if (rc == LDAP_SERVER_DOWN) {
+               DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO));
+               ldapsam_close(ldap_state);      
+       }
+               
+       return rc;
+}
+
+static int ldapsam_delete(struct ldapsam_privates *ldap_state, char *dn)
+{
+       int             rc = LDAP_SERVER_DOWN;
+       int             attempts = 0;
+       
+       if (!ldap_state)
+               return (-1);
+
+       while ((rc == LDAP_SERVER_DOWN) && (attempts < 8)) {
+               
+               if ((rc = ldapsam_retry_open(ldap_state,&attempts)) != LDAP_SUCCESS)
+                       continue;
+               
+               rc = ldap_delete_s(ldap_state->ldap_struct, dn);
+       }
+       
+       if (rc == LDAP_SERVER_DOWN) {
+               DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO));
+               ldapsam_close(ldap_state);      
+       }
+               
+       return rc;
+}
+
+#ifdef LDAP_EXOP_X_MODIFY_PASSWD
+static int ldapsam_extended_operation(struct ldapsam_privates *ldap_state, LDAP_CONST char *reqoid, struct berval *reqdata, LDAPControl **serverctrls, LDAPControl **clientctrls, char **retoidp, struct berval **retdatap)
+{
+       int             rc = LDAP_SERVER_DOWN;
+       int             attempts = 0;
+       
+       if (!ldap_state)
+               return (-1);
+
+       while ((rc == LDAP_SERVER_DOWN) && (attempts < 8)) {
+               
+               if ((rc = ldapsam_retry_open(ldap_state,&attempts)) != LDAP_SUCCESS)
+                       continue;
+               
+               rc = ldap_extended_operation_s(ldap_state->ldap_struct, reqoid, reqdata, serverctrls, clientctrls, retoidp, retdatap);
+       }
+       
+       if (rc == LDAP_SERVER_DOWN) {
+               DEBUG(0,("%s: LDAP server is down!\n",FUNCTION_MACRO));
+               ldapsam_close(ldap_state);      
+       }
+               
+       return rc;
 }
+#endif
 
 /*******************************************************************
  run the search by name.
 ******************************************************************/
-static int ldapsam_search_one_user (struct ldapsam_privates *ldap_state, LDAP * ldap_struct, const char *filter, LDAPMessage ** result)
+static int ldapsam_search_one_user (struct ldapsam_privates *ldap_state, const char *filter, LDAPMessage ** result)
 {
        int scope = LDAP_SCOPE_SUBTREE;
        int rc;
 
        DEBUG(2, ("ldapsam_search_one_user: searching for:[%s]\n", filter));
 
-       rc = ldap_search_s(ldap_struct, lp_ldap_suffix (), scope, filter, (char **)attr, 0, result);
+       rc = ldapsam_search(ldap_state, lp_ldap_suffix (), scope, filter, attr, 0, result);
 
        if (rc != LDAP_SUCCESS) {
-               DEBUG(0,("ldapsam_search_one_user: Problem during the LDAP search: %s\n", 
-                       ldap_err2string (rc)));
+               char *ld_error = NULL;
+               ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                               &ld_error);
+               DEBUG(0,("ldapsam_search_one_user: Problem during the LDAP search: %s (%s)\n", 
+                       ld_error?ld_error:"(unknown)", ldap_err2string (rc)));
                DEBUG(3,("ldapsam_search_one_user: Query was: %s, %s\n", lp_ldap_suffix(), 
                        filter));
+               SAFE_FREE(ld_error);
        }
        
        return rc;
@@ -445,11 +682,16 @@ static int ldapsam_search_one_user (struct ldapsam_privates *ldap_state, LDAP *
 /*******************************************************************
  run the search by name.
 ******************************************************************/
-static int ldapsam_search_one_user_by_name (struct ldapsam_privates *ldap_state, LDAP * ldap_struct, const char *user,
+static int ldapsam_search_one_user_by_name (struct ldapsam_privates *ldap_state, const char *user,
                             LDAPMessage ** result)
 {
        pstring filter;
-       
+       char *escape_user = escape_ldap_string_alloc(user);
+
+       if (!escape_user) {
+               return LDAP_NO_MEMORY;
+       }
+
        /*
         * in the filter expression, replace %u with the real name
         * so in ldap filter, %u MUST exist :-)
@@ -460,20 +702,24 @@ static int ldapsam_search_one_user_by_name (struct ldapsam_privates *ldap_state,
         * have to use this here because $ is filtered out
           * in pstring_sub
         */
-       all_string_sub(filter, "%u", user, sizeof(pstring));
+       
 
-       return ldapsam_search_one_user(ldap_state, ldap_struct, filter, result);
+       all_string_sub(filter, "%u", escape_user, sizeof(pstring));
+       SAFE_FREE(escape_user);
+
+       return ldapsam_search_one_user(ldap_state, filter, result);
 }
 
 /*******************************************************************
  run the search by uid.
 ******************************************************************/
 static int ldapsam_search_one_user_by_uid(struct ldapsam_privates *ldap_state, 
-                                         LDAP * ldap_struct, int uid,
+                                         int uid,
                                          LDAPMessage ** result)
 {
        struct passwd *user;
        pstring filter;
+       char *escape_user;
 
        /* Get the username from the system and look that up in the LDAP */
        
@@ -484,18 +730,25 @@ static int ldapsam_search_one_user_by_uid(struct ldapsam_privates *ldap_state,
        
        pstrcpy(filter, lp_ldap_filter());
        
-       all_string_sub(filter, "%u", user->pw_name, sizeof(pstring));
+       escape_user = escape_ldap_string_alloc(user->pw_name);
+       if (!escape_user) {
+               passwd_free(&user);
+               return LDAP_NO_MEMORY;
+       }
+
+       all_string_sub(filter, "%u", escape_user, sizeof(pstring));
 
        passwd_free(&user);
+       SAFE_FREE(escape_user);
 
-       return ldapsam_search_one_user(ldap_state, ldap_struct, filter, result);
+       return ldapsam_search_one_user(ldap_state, filter, result);
 }
 
 /*******************************************************************
  run the search by rid.
 ******************************************************************/
 static int ldapsam_search_one_user_by_rid (struct ldapsam_privates *ldap_state, 
-                                          LDAP * ldap_struct, uint32 rid,
+                                          uint32 rid,
                                           LDAPMessage ** result)
 {
        pstring filter;
@@ -504,10 +757,10 @@ static int ldapsam_search_one_user_by_rid (struct ldapsam_privates *ldap_state,
        /* check if the user rid exsists, if not, try searching on the uid */
        
        snprintf(filter, sizeof(filter) - 1, "rid=%i", rid);
-       rc = ldapsam_search_one_user(ldap_state, ldap_struct, filter, result);
+       rc = ldapsam_search_one_user(ldap_state, filter, result);
        
        if (rc != LDAP_SUCCESS)
-               rc = ldapsam_search_one_user_by_uid(ldap_state, ldap_struct, 
+               rc = ldapsam_search_one_user_by_uid(ldap_state,
                                                    fallback_pdb_user_rid_to_uid(rid), 
                                                    result);
 
@@ -518,7 +771,7 @@ static int ldapsam_search_one_user_by_rid (struct ldapsam_privates *ldap_state,
 search an attribute and return the first value found.
 ******************************************************************/
 static BOOL get_single_attribute (LDAP * ldap_struct, LDAPMessage * entry,
-                                 char *attribute, pstring value)
+                                 const char *attribute, pstring value)
 {
        char **values;
 
@@ -553,8 +806,11 @@ static void make_a_mod (LDAPMod *** modlist, int modop, const char *attribute, c
        if (attribute == NULL || *attribute == '\0')
                return;
 
-       if (value == NULL || *value == '\0')
+#if 0
+       /* Why do we need this??? -- vl */
+               if (value == NULL || *value == '\0')
                return;
+#endif
 
        if (mods == NULL) 
        {
@@ -611,15 +867,152 @@ static void make_a_mod (LDAPMod *** modlist, int modop, const char *attribute, c
        *modlist = mods;
 }
 
+/*******************************************************************
+ Delete complete object or objectclass and attrs from
+ object found in search_result depending on lp_ldap_delete_dn
+******************************************************************/
+static NTSTATUS ldapsam_delete_entry(struct ldapsam_privates *ldap_state,
+                                    LDAPMessage *result,
+                                    const char *objectclass,
+                                    const char **attrs)
+{
+       int rc;
+       LDAPMessage *entry;
+       LDAPMod **mods = NULL;
+       char *name, *dn;
+       BerElement *ptr = NULL;
+
+       rc = ldap_count_entries(ldap_state->ldap_struct, result);
+
+       if (rc != 1) {
+               DEBUG(0, ("Entry must exist exactly once!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       entry = ldap_first_entry(ldap_state->ldap_struct, result);
+       dn    = ldap_get_dn(ldap_state->ldap_struct, entry);
+
+       if (lp_ldap_delete_dn()) {
+               NTSTATUS ret = NT_STATUS_OK;
+               rc = ldapsam_delete(ldap_state, dn);
+
+               if (rc != LDAP_SUCCESS) {
+                       DEBUG(0, ("Could not delete object %s\n", dn));
+                       ret = NT_STATUS_UNSUCCESSFUL;
+               }
+               ldap_memfree(dn);
+               return ret;
+       }
+
+       /* Ok, delete only the SAM attributes */
+
+       for (name = ldap_first_attribute(ldap_state->ldap_struct, entry, &ptr);
+            name != NULL;
+            name = ldap_next_attribute(ldap_state->ldap_struct, entry, ptr)) {
+
+               const char **attrib;
+
+               /* We are only allowed to delete the attributes that
+                  really exist. */
+
+               for (attrib = attrs; *attrib != NULL; attrib++) {
+                       if (StrCaseCmp(*attrib, name) == 0) {
+                               DEBUG(10, ("deleting attribute %s\n", name));
+                               make_a_mod(&mods, LDAP_MOD_DELETE, name, NULL);
+                       }
+               }
+
+               ldap_memfree(name);
+       }
+
+       if (ptr != NULL) {
+               ber_free(ptr, 0);
+       }
+       
+       make_a_mod(&mods, LDAP_MOD_DELETE, "objectClass", objectclass);
+
+       rc = ldapsam_modify(ldap_state, dn, mods);
+       ldap_mods_free(mods, 1);
+
+       if (rc != LDAP_SUCCESS) {
+               char *ld_error = NULL;
+               ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                               &ld_error);
+               
+               DEBUG(0, ("could not delete attributes for %s, error: %s (%s)\n",
+                         dn, ldap_err2string(rc), ld_error?ld_error:"unknown"));
+               SAFE_FREE(ld_error);
+               ldap_memfree(dn);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       ldap_memfree(dn);
+       return NT_STATUS_OK;
+}
+                                         
 /* New Interface is being implemented here */
 
+/**********************************************************************
+Initialize SAM_ACCOUNT from an LDAP query (unix attributes only)
+*********************************************************************/
+static BOOL get_unix_attributes (struct ldapsam_privates *ldap_state, 
+                               SAM_ACCOUNT * sampass,
+                               LDAPMessage * entry)
+{
+       pstring  homedir;
+       pstring  temp;
+       uid_t uid;
+       gid_t gid;
+       char **ldap_values;
+       char **values;
+
+       if ((ldap_values = ldap_get_values (ldap_state->ldap_struct, entry, "objectClass")) == NULL) {
+               DEBUG (1, ("get_unix_attributes: no objectClass! \n"));
+               return False;
+       }
+
+       for (values=ldap_values;*values;values++) {
+               if (strcasecmp(*values, "posixAccount") == 0) {
+                       break;
+               }
+       }
+       
+       if (!*values) { /*end of array, no posixAccount */
+               DEBUG(10, ("user does not have posixAcccount attributes\n"));
+               ldap_value_free(ldap_values);
+               return False;
+       }
+       ldap_value_free(ldap_values);
+
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "homeDirectory", homedir)) 
+               return False;
+       
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "uidNumber", temp))
+               return False;
+       
+       uid = (uid_t)atol(temp);
+       
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "gidNumber", temp))
+               return False;
+       
+       gid = (gid_t)atol(temp);
+
+       pdb_set_unix_homedir(sampass, homedir, PDB_SET);
+       pdb_set_uid(sampass, uid, PDB_SET);
+       pdb_set_gid(sampass, gid, PDB_SET);
+       
+       DEBUG(10, ("user has posixAcccount attributes\n"));
+       return True;
+}
+
+
 /**********************************************************************
 Initialize SAM_ACCOUNT from an LDAP query
 (Based on init_sam_from_buffer in pdb_tdb.c)
 *********************************************************************/
 static BOOL init_sam_from_ldap (struct ldapsam_privates *ldap_state, 
                                SAM_ACCOUNT * sampass,
-                               LDAP * ldap_struct, LDAPMessage * entry)
+                               LDAPMessage * entry)
 {
        time_t  logon_time,
                        logoff_time,
@@ -641,9 +1034,9 @@ static BOOL init_sam_from_ldap (struct ldapsam_privates *ldap_state,
        struct passwd   *pw;
        uint32          user_rid, 
                        group_rid;
-       uint8           smblmpwd[16],
-                       smbntpwd[16];
-       uint16          acct_ctrl, 
+       uint8           smblmpwd[LM_HASH_LEN],
+                       smbntpwd[NT_HASH_LEN];
+       uint16          acct_ctrl = 0
                        logon_divs;
        uint32 hours_len;
        uint8           hours[MAX_HOURS_LEN];
@@ -668,107 +1061,121 @@ static BOOL init_sam_from_ldap (struct ldapsam_privates *ldap_state,
        workstations[0] = '\0';
         
 
-       if (sampass == NULL || ldap_struct == NULL || entry == NULL) {
+       if (sampass == NULL || ldap_state == NULL || entry == NULL) {
                DEBUG(0, ("init_sam_from_ldap: NULL parameters found!\n"));
                return False;
        }
 
-       get_single_attribute(ldap_struct, entry, "uid", username);
+       if (ldap_state->ldap_struct == NULL) {
+               DEBUG(0, ("init_sam_from_ldap: ldap_state->ldap_struct is NULL!\n"));
+               return False;
+       }
+       
+       get_single_attribute(ldap_state->ldap_struct, entry, "uid", username);
        DEBUG(2, ("Entry found for user: %s\n", username));
 
        pstrcpy(nt_username, username);
 
        pstrcpy(domain, lp_workgroup());
+       
+       pdb_set_username(sampass, username, PDB_SET);
 
-       get_single_attribute(ldap_struct, entry, "rid", temp);
+       pdb_set_domain(sampass, domain, PDB_DEFAULT);
+       pdb_set_nt_username(sampass, nt_username, PDB_SET);
+
+       get_single_attribute(ldap_state->ldap_struct, entry, "rid", temp);
        user_rid = (uint32)atol(temp);
 
-       pdb_set_user_sid_from_rid(sampass, user_rid);
+       pdb_set_user_sid_from_rid(sampass, user_rid, PDB_SET);
 
-       if (!get_single_attribute(ldap_struct, entry, "primaryGroupID", temp)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "primaryGroupID", temp)) {
                group_rid = 0;
        } else {
                group_rid = (uint32)atol(temp);
-               pdb_set_group_sid_from_rid(sampass, group_rid);
+               pdb_set_group_sid_from_rid(sampass, group_rid, PDB_SET);
        }
 
-       if ((ldap_state->permit_non_unix_accounts) 
-           && (user_rid >= ldap_state->low_nua_rid)
-           && (user_rid <= ldap_state->high_nua_rid)) {
-               
-       } else {
+
+       /* 
+        * If so configured, try and get the values from LDAP 
+        */
+
+       if (!lp_ldap_trust_ids() || (!get_unix_attributes(ldap_state, sampass, entry))) {
                
-               /* These values MAY be in LDAP, but they can also be retrieved through 
-                *  sys_getpw*() which is how we're doing it 
+               /* 
+                * Otherwise just ask the system getpw() calls.
                 */
        
                pw = getpwnam_alloc(username);
                if (pw == NULL) {
-                       DEBUG (2,("init_sam_from_ldap: User [%s] does not exist via system getpwnam!\n", username));
-                       return False;
-               }
-               uid = pw->pw_uid;
-               gid = pw->pw_gid;
-
-               pdb_set_unix_homedir(sampass, pw->pw_dir);
-
-               passwd_free(&pw);
+                       if (! ldap_state->permit_non_unix_accounts) {
+                               DEBUG (2,("init_sam_from_ldap: User [%s] does not exist via system getpwnam!\n", username));
+                               return False;
+                       }
+               } else {
+                       uid = pw->pw_uid;
+                       pdb_set_uid(sampass, uid, PDB_SET);
+                       gid = pw->pw_gid;
+                       pdb_set_gid(sampass, gid, PDB_SET);
+                       
+                       pdb_set_unix_homedir(sampass, pw->pw_dir, PDB_SET);
 
-               pdb_set_uid(sampass, uid);
-               pdb_set_gid(sampass, gid);
+                       passwd_free(&pw);
+               }
+       }
 
-               if (group_rid == 0) {
-                       GROUP_MAP map;
-                       /* call the mapping code here */
-                       if(get_group_map_from_gid(gid, &map, MAPPING_WITHOUT_PRIV)) {
-                               pdb_set_group_sid(sampass, &map.sid);
-                       } 
-                       else {
-                               pdb_set_group_sid_from_rid(sampass, pdb_gid_to_group_rid(gid));
-                       }
+       if (group_rid == 0 && pdb_get_init_flags(sampass,PDB_GID) != PDB_DEFAULT) {
+               GROUP_MAP map;
+               gid = pdb_get_gid(sampass);
+               /* call the mapping code here */
+               if(pdb_getgrgid(&map, gid, MAPPING_WITHOUT_PRIV)) {
+                       pdb_set_group_sid(sampass, &map.sid, PDB_SET);
+               } 
+               else {
+                       pdb_set_group_sid_from_rid(sampass, pdb_gid_to_group_rid(gid), PDB_SET);
                }
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "pwdLastSet", temp)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "pwdLastSet", temp)) {
                /* leave as default */
        } else {
                pass_last_set_time = (time_t) atol(temp);
-               pdb_set_pass_last_set_time(sampass, pass_last_set_time);
+               pdb_set_pass_last_set_time(sampass, pass_last_set_time, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "logonTime", temp)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "logonTime", temp)) {
                /* leave as default */
        } else {
                logon_time = (time_t) atol(temp);
-               pdb_set_logon_time(sampass, logon_time, True);
+               pdb_set_logon_time(sampass, logon_time, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "logoffTime", temp)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "logoffTime", temp)) {
                /* leave as default */
        } else {
                logoff_time = (time_t) atol(temp);
-               pdb_set_logoff_time(sampass, logoff_time, True);
+               pdb_set_logoff_time(sampass, logoff_time, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "kickoffTime", temp)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "kickoffTime", temp)) {
                /* leave as default */
        } else {
                kickoff_time = (time_t) atol(temp);
-               pdb_set_kickoff_time(sampass, kickoff_time, True);
+               pdb_set_kickoff_time(sampass, kickoff_time, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "pwdCanChange", temp)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "pwdCanChange", temp)) {
                /* leave as default */
        } else {
                pass_can_change_time = (time_t) atol(temp);
-               pdb_set_pass_can_change_time(sampass, pass_can_change_time, True);
+               pdb_set_pass_can_change_time(sampass, pass_can_change_time, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "pwdMustChange", temp)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "pwdMustChange", temp)) {
                /* leave as default */
        } else {
                pass_must_change_time = (time_t) atol(temp);
-               pdb_set_pass_must_change_time(sampass, pass_must_change_time, True);
+               pdb_set_pass_must_change_time(sampass, pass_must_change_time, PDB_SET);
        }
 
        /* recommend that 'gecos' and 'displayName' should refer to the same
@@ -777,66 +1184,68 @@ static BOOL init_sam_from_ldap (struct ldapsam_privates *ldap_state,
         * that fits your needs; using cn then displayName rather than 'userFullName'
         */
 
-       if (!get_single_attribute(ldap_struct, entry, "cn", fullname)) {
-               if (!get_single_attribute(ldap_struct, entry, "displayName", fullname)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry,
+                                 "displayName", fullname)) {
+               if (!get_single_attribute(ldap_state->ldap_struct, entry,
+                                         "cn", fullname)) {
                        /* leave as default */
                } else {
-                       pdb_set_fullname(sampass, fullname);
+                       pdb_set_fullname(sampass, fullname, PDB_SET);
                }
        } else {
-               pdb_set_fullname(sampass, fullname);
+               pdb_set_fullname(sampass, fullname, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "homeDrive", dir_drive)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "homeDrive", dir_drive)) {
                pdb_set_dir_drive(sampass, talloc_sub_specified(sampass->mem_ctx, 
                                                                  lp_logon_drive(),
                                                                  username, domain, 
                                                                  uid, gid),
-                                 False);
+                                 PDB_DEFAULT);
        } else {
-               pdb_set_dir_drive(sampass, dir_drive, True);
+               pdb_set_dir_drive(sampass, dir_drive, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "smbHome", homedir)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "smbHome", homedir)) {
                pdb_set_homedir(sampass, talloc_sub_specified(sampass->mem_ctx, 
                                                                  lp_logon_home(),
                                                                  username, domain, 
                                                                  uid, gid), 
-                                 False);
+                                 PDB_DEFAULT);
        } else {
-               pdb_set_homedir(sampass, homedir, True);
+               pdb_set_homedir(sampass, homedir, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "scriptPath", logon_script)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "scriptPath", logon_script)) {
                pdb_set_logon_script(sampass, talloc_sub_specified(sampass->mem_ctx, 
                                                                     lp_logon_script(),
                                                                     username, domain, 
                                                                     uid, gid), 
-                                    False);
+                                    PDB_DEFAULT);
        } else {
-               pdb_set_logon_script(sampass, logon_script, True);
+               pdb_set_logon_script(sampass, logon_script, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "profilePath", profile_path)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "profilePath", profile_path)) {
                pdb_set_profile_path(sampass, talloc_sub_specified(sampass->mem_ctx, 
                                                                     lp_logon_path(),
                                                                     username, domain, 
                                                                     uid, gid), 
-                                    False);
+                                    PDB_DEFAULT);
        } else {
-               pdb_set_profile_path(sampass, profile_path, True);
+               pdb_set_profile_path(sampass, profile_path, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "description", acct_desc)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "description", acct_desc)) {
                /* leave as default */
        } else {
-               pdb_set_acct_desc(sampass, acct_desc);
+               pdb_set_acct_desc(sampass, acct_desc, PDB_SET);
        }
 
-       if (!get_single_attribute(ldap_struct, entry, "userWorkstations", workstations)) {
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "userWorkstations", workstations)) {
                /* leave as default */;
        } else {
-               pdb_set_workstations(sampass, workstations);
+               pdb_set_workstations(sampass, workstations, PDB_SET);
        }
 
        /* FIXME: hours stuff should be cleaner */
@@ -845,27 +1254,27 @@ static BOOL init_sam_from_ldap (struct ldapsam_privates *ldap_state,
        hours_len = 21;
        memset(hours, 0xff, hours_len);
 
-       if (!get_single_attribute (ldap_struct, entry, "lmPassword", temp)) {
+       if (!get_single_attribute (ldap_state->ldap_struct, entry, "lmPassword", temp)) {
                /* leave as default */
        } else {
                pdb_gethexpwd(temp, smblmpwd);
                memset((char *)temp, '\0', strlen(temp)+1);
-               if (!pdb_set_lanman_passwd(sampass, smblmpwd))
+               if (!pdb_set_lanman_passwd(sampass, smblmpwd, PDB_SET))
                        return False;
                ZERO_STRUCT(smblmpwd);
        }
 
-       if (!get_single_attribute (ldap_struct, entry, "ntPassword", temp)) {
+       if (!get_single_attribute (ldap_state->ldap_struct, entry, "ntPassword", temp)) {
                /* leave as default */
        } else {
                pdb_gethexpwd(temp, smbntpwd);
                memset((char *)temp, '\0', strlen(temp)+1);
-               if (!pdb_set_nt_passwd(sampass, smbntpwd))
+               if (!pdb_set_nt_passwd(sampass, smbntpwd, PDB_SET))
                        return False;
                ZERO_STRUCT(smbntpwd);
        }
 
-       if (!get_single_attribute (ldap_struct, entry, "acctFlags", temp)) {
+       if (!get_single_attribute (ldap_state->ldap_struct, entry, "acctFlags", temp)) {
                acct_ctrl |= ACB_NORMAL;
        } else {
                acct_ctrl = pdb_decode_acct_ctrl(temp);
@@ -873,26 +1282,85 @@ static BOOL init_sam_from_ldap (struct ldapsam_privates *ldap_state,
                if (acct_ctrl == 0)
                        acct_ctrl |= ACB_NORMAL;
 
-               pdb_set_acct_ctrl(sampass, acct_ctrl);
+               pdb_set_acct_ctrl(sampass, acct_ctrl, PDB_SET);
        }
 
-       pdb_set_hours_len(sampass, hours_len);
-       pdb_set_logon_divs(sampass, logon_divs);
+       pdb_set_hours_len(sampass, hours_len, PDB_SET);
+       pdb_set_logon_divs(sampass, logon_divs, PDB_SET);
 
-       pdb_set_username(sampass, username);
+       pdb_set_munged_dial(sampass, munged_dial, PDB_SET);
+       
+       /* pdb_set_unknown_3(sampass, unknown3, PDB_SET); */
+       /* pdb_set_unknown_5(sampass, unknown5, PDB_SET); */
+       /* pdb_set_unknown_6(sampass, unknown6, PDB_SET); */
 
-       pdb_set_domain(sampass, domain);
-       pdb_set_nt_username(sampass, nt_username);
+       pdb_set_hours(sampass, hours, PDB_SET);
 
-       pdb_set_munged_dial(sampass, munged_dial);
-       
-       /* pdb_set_unknown_3(sampass, unknown3); */
-       /* pdb_set_unknown_5(sampass, unknown5); */
-       /* pdb_set_unknown_6(sampass, unknown6); */
+       return True;
+}
 
-       pdb_set_hours(sampass, hours);
+/**********************************************************************
+  An LDAP modification is needed in two cases:
+  * If we are updating the record AND the attribute is CHANGED.
+  * If we are adding   the record AND it is SET or CHANGED (ie not default)
+*********************************************************************/
+#ifdef LDAP_EXOP_X_MODIFY_PASSWD
+static BOOL need_ldap_mod(BOOL pdb_add, const SAM_ACCOUNT * sampass, enum pdb_elements element) {
+       if (pdb_add) {
+               return (!IS_SAM_DEFAULT(sampass, element));
+       } else {
+               return IS_SAM_CHANGED(sampass, element);
+       }
+}
+#endif
 
-       return True;
+/**********************************************************************
+  Set attribute to newval in LDAP, regardless of what value the
+  attribute had in LDAP before.
+*********************************************************************/
+static void make_ldap_mod(LDAP *ldap_struct, LDAPMessage *existing,
+                         LDAPMod ***mods,
+                         const char *attribute, const char *newval)
+{
+       char **values = NULL;
+
+       if (existing != NULL) {
+               values = ldap_get_values(ldap_struct, existing, attribute);
+       }
+
+       if ((values != NULL) && (values[0] != NULL) &&
+           strcmp(values[0], newval) == 0) {
+               
+               /* Believe it or not, but LDAP will deny a delete and
+                  an add at the same time if the values are the
+                  same... */
+
+               ldap_value_free(values);
+               return;
+       }
+
+       /* Regardless of the real operation (add or modify)
+          we add the new value here. We rely on deleting
+          the old value, should it exist. */
+
+       if ((newval != NULL) && (strlen(newval) > 0)) {
+               make_a_mod(mods, LDAP_MOD_ADD, attribute, newval);
+       }
+
+       if (values == NULL) {
+               /* There has been no value before, so don't delete it.
+                  Here's a possible race: We might end up with
+                  duplicate attributes */
+               return;
+       }
+
+       /* By deleting exactly the value we found in the entry this
+          should be race-free in the sense that the LDAP-Server will
+          deny the complete operation if somebody changed the
+          attribute behind our back. */
+
+       make_a_mod(mods, LDAP_MOD_DELETE, attribute, values[0]);
+       ldap_value_free(values);
 }
 
 /**********************************************************************
@@ -900,8 +1368,10 @@ Initialize SAM_ACCOUNT from an LDAP query
 (Based on init_buffer_from_sam in pdb_tdb.c)
 *********************************************************************/
 static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state, 
-                               LDAPMod *** mods, int ldap_op, 
-                               const SAM_ACCOUNT * sampass)
+                               LDAPMessage *existing,
+                               LDAPMod *** mods, const SAM_ACCOUNT * sampass,
+                               BOOL (*need_update)(const SAM_ACCOUNT *,
+                                                   enum pdb_elements))
 {
        pstring temp;
        uint32 rid;
@@ -917,113 +1387,164 @@ static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state,
         * took out adding "objectclass: sambaAccount"
         * do this on a per-mod basis
         */
+       if (need_update(sampass, PDB_USERNAME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods, 
+                             "uid", pdb_get_username(sampass));
 
-       make_a_mod(mods, ldap_op, "uid", pdb_get_username(sampass));
        DEBUG(2, ("Setting entry for user: %s\n", pdb_get_username(sampass)));
 
-       if ( pdb_get_user_rid(sampass) ) {
-               rid = pdb_get_user_rid(sampass);
-       } else if (IS_SAM_SET(sampass, FLAG_SAM_UID)) {
-               rid = fallback_pdb_uid_to_user_rid(pdb_get_uid(sampass));
-       } else if (ldap_state->permit_non_unix_accounts) {
-               rid = ldapsam_get_next_available_nua_rid(ldap_state);
-               if (rid == 0) {
-                       DEBUG(0, ("NO user RID specified on account %s, and findining next available NUA RID failed, cannot store!\n", pdb_get_username(sampass)));
+       rid = pdb_get_user_rid(sampass);
+
+       if (rid == 0) {
+               if (!IS_SAM_DEFAULT(sampass, PDB_UID)) {
+                       rid = fallback_pdb_uid_to_user_rid(pdb_get_uid(sampass));
+               } else if (ldap_state->permit_non_unix_accounts) {
+                       rid = ldapsam_get_next_available_nua_rid(ldap_state);
+                       if (rid == 0) {
+                               DEBUG(0, ("NO user RID specified on account %s, and "
+                                         "finding next available NUA RID failed, "
+                                         "cannot store!\n",
+                                         pdb_get_username(sampass)));
+                               ldap_mods_free(*mods, 1);
+                               return False;
+                       }
+               } else {
+                       DEBUG(0, ("NO user RID specified on account %s, "
+                                 "cannot store!\n", pdb_get_username(sampass)));
+                       ldap_mods_free(*mods, 1);
                        return False;
                }
-       } else {
-               DEBUG(0, ("NO user RID specified on account %s, cannot store!\n", pdb_get_username(sampass)));
-               return False;
        }
 
        slprintf(temp, sizeof(temp) - 1, "%i", rid);
-       make_a_mod(mods, ldap_op, "rid", temp);
-
-       if ( pdb_get_group_rid(sampass) ) {
-               rid = pdb_get_group_rid(sampass);
-       } else if (IS_SAM_SET(sampass, FLAG_SAM_GID)) {
-               rid = pdb_gid_to_group_rid(pdb_get_gid(sampass));
-       } else if (ldap_state->permit_non_unix_accounts) {
-               rid = DOMAIN_GROUP_RID_USERS;
-       } else {
-               DEBUG(0, ("NO group RID specified on account %s, cannot store!\n", pdb_get_username(sampass)));
-               return False;
+
+       if (need_update(sampass, PDB_USERSID))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "rid", temp);
+
+
+       rid = pdb_get_group_rid(sampass);
+
+       if (rid == 0) {
+               if (!IS_SAM_DEFAULT(sampass, PDB_GID)) {
+                       rid = pdb_gid_to_group_rid(pdb_get_gid(sampass));
+               } else if (ldap_state->permit_non_unix_accounts) {
+                       rid = DOMAIN_GROUP_RID_USERS;
+               } else {
+                       DEBUG(0, ("NO group RID specified on account %s, "
+                                 "cannot store!\n", pdb_get_username(sampass)));
+                       ldap_mods_free(*mods, 1);
+                       return False;
+               }
        }
 
        slprintf(temp, sizeof(temp) - 1, "%i", rid);
-       make_a_mod(mods, ldap_op, "primaryGroupID", temp);
+
+       if (need_update(sampass, PDB_GROUPSID))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "primaryGroupID", temp);
 
        /* displayName, cn, and gecos should all be the same
         *  most easily accomplished by giving them the same OID
         *  gecos isn't set here b/c it should be handled by the 
         *  add-user script
+        *  We change displayName only and fall back to cn if
+        *  it does not exist.
         */
 
-       make_a_mod(mods, ldap_op, "displayName", pdb_get_fullname(sampass));
-       make_a_mod(mods, ldap_op, "cn", pdb_get_fullname(sampass));
-       make_a_mod(mods, ldap_op, "description", pdb_get_acct_desc(sampass));
-       make_a_mod(mods, ldap_op, "userWorkstations", pdb_get_workstations(sampass));
+       if (need_update(sampass, PDB_FULLNAME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "displayName", pdb_get_fullname(sampass));
 
-       /*
-        * Only updates fields which have been set (not defaults from smb.conf)
-        */
+       if (need_update(sampass, PDB_ACCTDESC))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "description", pdb_get_acct_desc(sampass));
 
-       if (IS_SAM_SET(sampass, FLAG_SAM_SMBHOME))
-               make_a_mod(mods, ldap_op, "smbHome", pdb_get_homedir(sampass));
-               
-       if (IS_SAM_SET(sampass, FLAG_SAM_DRIVE))
-               make_a_mod(mods, ldap_op, "homeDrive", pdb_get_dir_drive(sampass));
-       
-       if (IS_SAM_SET(sampass, FLAG_SAM_LOGONSCRIPT))
-               make_a_mod(mods, ldap_op, "scriptPath", pdb_get_logon_script(sampass));
+       if (need_update(sampass, PDB_WORKSTATIONS))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "userWorkstations", pdb_get_workstations(sampass));
 
-       if (IS_SAM_SET(sampass, FLAG_SAM_PROFILE))
-               make_a_mod(mods, ldap_op, "profilePath", pdb_get_profile_path(sampass));
+       if (need_update(sampass, PDB_SMBHOME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "smbHome", pdb_get_homedir(sampass));
+                       
+       if (need_update(sampass, PDB_DRIVE))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "homeDrive", pdb_get_dir_drive(sampass));
 
-       if (IS_SAM_SET(sampass, FLAG_SAM_LOGONTIME)) {
-               slprintf(temp, sizeof(temp) - 1, "%li", pdb_get_logon_time(sampass));
-               make_a_mod(mods, ldap_op, "logonTime", temp);
-       }
+       if (need_update(sampass, PDB_LOGONSCRIPT))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "scriptPath", pdb_get_logon_script(sampass));
 
-       if (IS_SAM_SET(sampass, FLAG_SAM_LOGOFFTIME)) {
-               slprintf(temp, sizeof(temp) - 1, "%li", pdb_get_logoff_time(sampass));
-               make_a_mod(mods, ldap_op, "logoffTime", temp);
-       }
+       if (need_update(sampass, PDB_PROFILE))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "profilePath", pdb_get_profile_path(sampass));
 
-       if (IS_SAM_SET(sampass, FLAG_SAM_KICKOFFTIME)) {
-               slprintf (temp, sizeof (temp) - 1, "%li", pdb_get_kickoff_time(sampass));
-               make_a_mod(mods, ldap_op, "kickoffTime", temp);
-       }
+       slprintf(temp, sizeof(temp) - 1, "%li", pdb_get_logon_time(sampass));
 
+       if (need_update(sampass, PDB_LOGONTIME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "logonTime", temp);
 
-       if (IS_SAM_SET(sampass, FLAG_SAM_CANCHANGETIME)) {
-               slprintf (temp, sizeof (temp) - 1, "%li", pdb_get_pass_can_change_time(sampass));
-               make_a_mod(mods, ldap_op, "pwdCanChange", temp);
-       }
+       slprintf(temp, sizeof(temp) - 1, "%li", pdb_get_logoff_time(sampass));
 
-       if (IS_SAM_SET(sampass, FLAG_SAM_MUSTCHANGETIME)) {
-               slprintf (temp, sizeof (temp) - 1, "%li", pdb_get_pass_must_change_time(sampass));
-               make_a_mod(mods, ldap_op, "pwdMustChange", temp);
-       }
+       if (need_update(sampass, PDB_LOGOFFTIME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "logoffTime", temp);
+
+       slprintf (temp, sizeof (temp) - 1, "%li",
+                 pdb_get_kickoff_time(sampass));
+
+       if (need_update(sampass, PDB_KICKOFFTIME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "kickoffTime", temp);
+
+       slprintf (temp, sizeof (temp) - 1, "%li",
+                 pdb_get_pass_can_change_time(sampass));
+
+       if (need_update(sampass, PDB_CANCHANGETIME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "pwdCanChange", temp);
+
+       slprintf (temp, sizeof (temp) - 1, "%li",
+                 pdb_get_pass_must_change_time(sampass));
+
+       if (need_update(sampass, PDB_MUSTCHANGETIME))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "pwdMustChange", temp);
 
        if ((pdb_get_acct_ctrl(sampass)&(ACB_WSTRUST|ACB_SVRTRUST|ACB_DOMTRUST))||
-               (lp_ldap_passwd_sync()!=LDAP_PASSWD_SYNC_ONLY)) {
+           (lp_ldap_passwd_sync()!=LDAP_PASSWD_SYNC_ONLY)) {
 
-               pdb_sethexpwd (temp, pdb_get_lanman_passwd(sampass), pdb_get_acct_ctrl(sampass));
-               make_a_mod (mods, ldap_op, "lmPassword", temp);
-       
-               pdb_sethexpwd (temp, pdb_get_nt_passwd(sampass), pdb_get_acct_ctrl(sampass));
-               make_a_mod (mods, ldap_op, "ntPassword", temp);
-       
-               slprintf (temp, sizeof (temp) - 1, "%li", pdb_get_pass_last_set_time(sampass));
-               make_a_mod(mods, ldap_op, "pwdLastSet", temp);
+               pdb_sethexpwd (temp, pdb_get_lanman_passwd(sampass),
+                              pdb_get_acct_ctrl(sampass));
+
+               if (need_update(sampass, PDB_LMPASSWD))
+                       make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                                     "lmPassword", temp);
 
+               pdb_sethexpwd (temp, pdb_get_nt_passwd(sampass),
+                              pdb_get_acct_ctrl(sampass));
+
+               if (need_update(sampass, PDB_NTPASSWD))
+                       make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                                     "ntPassword", temp);
+
+               slprintf (temp, sizeof (temp) - 1, "%li",
+                         pdb_get_pass_last_set_time(sampass));
+
+               if (need_update(sampass, PDB_PASSLASTSET))
+                       make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                                     "pwdLastSet", temp);
        }
 
        /* FIXME: Hours stuff goes in LDAP  */
 
-       make_a_mod (mods, ldap_op, "acctFlags", pdb_encode_acct_ctrl (pdb_get_acct_ctrl(sampass),
-               NEW_PW_FORMAT_SPACE_PADDED_LEN));
+       if (need_update(sampass, PDB_ACCTCTRL))
+               make_ldap_mod(ldap_state->ldap_struct, existing, mods,
+                             "acctFlags",
+                             pdb_encode_acct_ctrl (pdb_get_acct_ctrl(sampass),
+                                                   NEW_PW_FORMAT_SPACE_PADDED_LEN));
 
        return True;
 }
@@ -1032,7 +1553,7 @@ static BOOL init_ldap_from_sam (struct ldapsam_privates *ldap_state,
 /**********************************************************************
 Connect to LDAP server and find the next available RID.
 *********************************************************************/
-static uint32 check_nua_rid_is_avail(struct ldapsam_privates *ldap_state, uint32 top_rid, LDAP *ldap_struct
+static uint32 check_nua_rid_is_avail(struct ldapsam_privates *ldap_state, uint32 top_rid) 
 {
        LDAPMessage *result;
        uint32 final_rid = (top_rid & (~USER_RID_TYPE)) + RID_MULTIPLIER;
@@ -1044,13 +1565,12 @@ static uint32 check_nua_rid_is_avail(struct ldapsam_privates *ldap_state, uint32
                return 0;
        }
 
-       if (ldapsam_search_one_user_by_rid(ldap_state, ldap_struct, final_rid, &result) != LDAP_SUCCESS) {
+       if (ldapsam_search_one_user_by_rid(ldap_state, final_rid, &result) != LDAP_SUCCESS) {
                DEBUG(0, ("Cannot allocate NUA RID %d (0x%x), as the confirmation search failed!\n", final_rid, final_rid));
-               ldap_msgfree(result);
                return 0;
        }
 
-       if (ldap_count_entries(ldap_struct, result) != 0) {
+       if (ldap_count_entries(ldap_state->ldap_struct, result) != 0) {
                DEBUG(0, ("Cannot allocate NUA RID %d (0x%x), as the RID is already in use!!\n", final_rid, final_rid));
                ldap_msgfree(result);
                return 0;
@@ -1064,14 +1584,14 @@ static uint32 check_nua_rid_is_avail(struct ldapsam_privates *ldap_state, uint32
 /**********************************************************************
 Extract the RID from an LDAP entry
 *********************************************************************/
-static uint32 entry_to_user_rid(struct ldapsam_privates *ldap_state, LDAPMessage *entry, LDAP *ldap_struct) {
+static uint32 entry_to_user_rid(struct ldapsam_privates *ldap_state, LDAPMessage *entry) {
        uint32 rid;
        SAM_ACCOUNT *user = NULL;
        if (!NT_STATUS_IS_OK(pdb_init_sam(&user))) {
                return 0;
        }
 
-       if (init_sam_from_ldap(ldap_state, user, ldap_struct, entry)) {
+       if (init_sam_from_ldap(ldap_state, user, entry)) {
                rid = pdb_get_user_rid(user);
        } else {
                rid =0;
@@ -1087,7 +1607,7 @@ static uint32 entry_to_user_rid(struct ldapsam_privates *ldap_state, LDAPMessage
 /**********************************************************************
 Connect to LDAP server and find the next available RID.
 *********************************************************************/
-static uint32 search_top_nua_rid(struct ldapsam_privates *ldap_state, LDAP *ldap_struct)
+static uint32 search_top_nua_rid(struct ldapsam_privates *ldap_state)
 {
        int rc;
        pstring filter;
@@ -1108,8 +1628,8 @@ static uint32 search_top_nua_rid(struct ldapsam_privates *ldap_state, LDAP *ldap
 #endif 
        DEBUG(2, ("ldapsam_get_next_available_nua_rid: searching for:[%s]\n", final_filter));
 
-       rc = ldap_search_s(ldap_struct, lp_ldap_suffix(),
-                          LDAP_SCOPE_SUBTREE, final_filter, (char **)attr, 0,
+       rc = ldapsam_search(ldap_state, lp_ldap_suffix(),
+                          LDAP_SCOPE_SUBTREE, final_filter, attr, 0,
                           &result);
 
        if (rc != LDAP_SUCCESS) {
@@ -1117,12 +1637,11 @@ static uint32 search_top_nua_rid(struct ldapsam_privates *ldap_state, LDAP *ldap
                DEBUGADD(3, ("Query was: %s, %s\n", lp_ldap_suffix(), final_filter));
 
                free(final_filter);
-               ldap_msgfree(result);
                result = NULL;
                return 0;
        }
        
-       count = ldap_count_entries(ldap_struct, result);
+       count = ldap_count_entries(ldap_state->ldap_struct, result);
        DEBUG(2, ("search_top_nua_rid: %d entries in the base!\n", count));
        
        if (count == 0) {
@@ -1135,13 +1654,13 @@ static uint32 search_top_nua_rid(struct ldapsam_privates *ldap_state, LDAP *ldap
        }
        
        free(final_filter);
-       entry = ldap_first_entry(ldap_struct,result);
+       entry = ldap_first_entry(ldap_state->ldap_struct,result);
 
-       top_rid = entry_to_user_rid(ldap_state, entry, ldap_struct);
+       top_rid = entry_to_user_rid(ldap_state, entry);
 
-       while ((entry = ldap_next_entry(ldap_struct, entry))) {
+       while ((entry = ldap_next_entry(ldap_state->ldap_struct, entry))) {
 
-               rid = entry_to_user_rid(ldap_state, entry, ldap_struct);
+               rid = entry_to_user_rid(ldap_state, entry);
                if (rid > top_rid) {
                        top_rid = rid;
                }
@@ -1159,24 +1678,14 @@ static uint32 search_top_nua_rid(struct ldapsam_privates *ldap_state, LDAP *ldap
 Connect to LDAP server and find the next available RID.
 *********************************************************************/
 static uint32 ldapsam_get_next_available_nua_rid(struct ldapsam_privates *ldap_state) {
-       LDAP *ldap_struct;
        uint32 next_nua_rid;
        uint32 top_nua_rid;
 
-       if (!ldapsam_open_connection(ldap_state, &ldap_struct)) {
-               return 0;
-       }
-       if (!ldapsam_connect_system(ldap_state, ldap_struct)) {
-               ldap_unbind(ldap_struct);
-               return 0;
-       }
-       
-       top_nua_rid = search_top_nua_rid(ldap_state, ldap_struct);
+       top_nua_rid = search_top_nua_rid(ldap_state);
 
        next_nua_rid = check_nua_rid_is_avail(ldap_state, 
-                                             top_nua_rid, ldap_struct);
+                                             top_nua_rid);
        
-       ldap_unbind(ldap_struct);
        return next_nua_rid;
 }
 
@@ -1185,34 +1694,23 @@ Connect to LDAP server for password enumeration
 *********************************************************************/
 static NTSTATUS ldapsam_setsampwent(struct pdb_methods *my_methods, BOOL update)
 {
-       NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        int rc;
        pstring filter;
 
-       if (!ldapsam_open_connection(ldap_state, &ldap_state->ldap_struct)) {
-               return ret;
-       }
-       if (!ldapsam_connect_system(ldap_state, ldap_state->ldap_struct)) {
-               ldap_unbind(ldap_state->ldap_struct);
-               return ret;
-       }
-
        pstrcpy(filter, lp_ldap_filter());
        all_string_sub(filter, "%u", "*", sizeof(pstring));
 
-       rc = ldap_search_s(ldap_state->ldap_struct, lp_ldap_suffix(),
-                          LDAP_SCOPE_SUBTREE, filter, (char **)attr, 0,
+       rc = ldapsam_search(ldap_state, lp_ldap_suffix(),
+                          LDAP_SCOPE_SUBTREE, filter, attr, 0,
                           &ldap_state->result);
 
        if (rc != LDAP_SUCCESS) {
                DEBUG(0, ("LDAP search failed: %s\n", ldap_err2string(rc)));
                DEBUG(3, ("Query was: %s, %s\n", lp_ldap_suffix(), filter));
                ldap_msgfree(ldap_state->result);
-               ldap_unbind(ldap_state->ldap_struct);
-               ldap_state->ldap_struct = NULL;
                ldap_state->result = NULL;
-               return ret;
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
        DEBUG(2, ("ldapsam_setsampwent: %d entries in the base!\n",
@@ -1232,10 +1730,8 @@ End enumeration of the LDAP password list
 static void ldapsam_endsampwent(struct pdb_methods *my_methods)
 {
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
-       if (ldap_state->ldap_struct && ldap_state->result) {
+       if (ldap_state->result) {
                ldap_msgfree(ldap_state->result);
-               ldap_unbind(ldap_state->ldap_struct);
-               ldap_state->ldap_struct = NULL;
                ldap_state->result = NULL;
        }
 }
@@ -1258,8 +1754,7 @@ static NTSTATUS ldapsam_getsampwent(struct pdb_methods *my_methods, SAM_ACCOUNT
                        return ret;
                
                ldap_state->index++;
-               bret = init_sam_from_ldap(ldap_state, user, ldap_state->ldap_struct,
-                                        ldap_state->entry);
+               bret = init_sam_from_ldap(ldap_state, user, ldap_state->entry);
                
                ldap_state->entry = ldap_next_entry(ldap_state->ldap_struct,
                                            ldap_state->entry); 
@@ -1275,41 +1770,39 @@ static NTSTATUS ldapsam_getsampwnam(struct pdb_methods *my_methods, SAM_ACCOUNT
 {
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
-       LDAP *ldap_struct;
        LDAPMessage *result;
        LDAPMessage *entry;
-
-       if (!ldapsam_open_connection(ldap_state, &ldap_struct))
-               return ret;
-       if (!ldapsam_connect_system(ldap_state, ldap_struct)) {
-               ldap_unbind(ldap_struct);
-               return ret;
-       }
-       if (ldapsam_search_one_user_by_name(ldap_state, ldap_struct, sname, &result) != LDAP_SUCCESS) {
-               ldap_unbind(ldap_struct);
-               return ret;
+       int count;
+       
+       if (ldapsam_search_one_user_by_name(ldap_state, sname, &result) != LDAP_SUCCESS) {
+               return NT_STATUS_NO_SUCH_USER;
        }
-       if (ldap_count_entries(ldap_struct, result) < 1) {
+       
+       count = ldap_count_entries(ldap_state->ldap_struct, result);
+       
+       if (count < 1) {
                DEBUG(4,
                      ("We don't find this user [%s] count=%d\n", sname,
-                      ldap_count_entries(ldap_struct, result)));
-               ldap_unbind(ldap_struct);
-               return ret;
+                      count));
+               return NT_STATUS_NO_SUCH_USER;
+       } else if (count > 1) {
+               DEBUG(1,
+                     ("Duplicate entries for this user [%s] Failing. count=%d\n", sname,
+                      count));
+               return NT_STATUS_NO_SUCH_USER;
        }
-       entry = ldap_first_entry(ldap_struct, result);
+
+       entry = ldap_first_entry(ldap_state->ldap_struct, result);
        if (entry) {
-               if (!init_sam_from_ldap(ldap_state, user, ldap_struct, entry)) {
+               if (!init_sam_from_ldap(ldap_state, user, entry)) {
                        DEBUG(1,("ldapsam_getsampwnam: init_sam_from_ldap failed for user '%s'!\n", sname));
                        ldap_msgfree(result);
-                       ldap_unbind(ldap_struct);
-                       return ret;
+                       return NT_STATUS_NO_SUCH_USER;
                }
                ldap_msgfree(result);
-               ldap_unbind(ldap_struct);
                ret = NT_STATUS_OK;
        } else {
                ldap_msgfree(result);
-               ldap_unbind(ldap_struct);
        }
        return ret;
 }
@@ -1320,45 +1813,41 @@ Get SAM_ACCOUNT entry from LDAP by rid
 static NTSTATUS ldapsam_getsampwrid(struct pdb_methods *my_methods, SAM_ACCOUNT *user, uint32 rid)
 {
        NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
-       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
-       LDAP *ldap_struct;
+       struct ldapsam_privates *ldap_state = 
+               (struct ldapsam_privates *)my_methods->private_data;
        LDAPMessage *result;
        LDAPMessage *entry;
+       int count;
 
-       if (!ldapsam_open_connection(ldap_state, &ldap_struct))
-               return ret;
-
-       if (!ldapsam_connect_system(ldap_state, ldap_struct)) {
-               ldap_unbind(ldap_struct);
-               return ret;
-       }
-       if (ldapsam_search_one_user_by_rid(ldap_state, ldap_struct, rid, &result) != LDAP_SUCCESS) {
-               ldap_unbind(ldap_struct);
-               return ret;
+       if (ldapsam_search_one_user_by_rid(ldap_state, rid, &result) != LDAP_SUCCESS) {
+               return NT_STATUS_NO_SUCH_USER;
        }
 
-       if (ldap_count_entries(ldap_struct, result) < 1) {
+       count = ldap_count_entries(ldap_state->ldap_struct, result);
+               
+       if (count < 1) {
                DEBUG(4,
                      ("We don't find this rid [%i] count=%d\n", rid,
-                      ldap_count_entries(ldap_struct, result)));
-               ldap_unbind(ldap_struct);
-               return ret;
+                      count));
+               return NT_STATUS_NO_SUCH_USER;
+       } else if (count > 1) {
+               DEBUG(1,
+                     ("More than one user with rid [%i]. Failing. count=%d\n", rid,
+                      count));
+               return NT_STATUS_NO_SUCH_USER;
        }
 
-       entry = ldap_first_entry(ldap_struct, result);
+       entry = ldap_first_entry(ldap_state->ldap_struct, result);
        if (entry) {
-               if (!init_sam_from_ldap(ldap_state, user, ldap_struct, entry)) {
+               if (!init_sam_from_ldap(ldap_state, user, entry)) {
                        DEBUG(1,("ldapsam_getsampwrid: init_sam_from_ldap failed!\n"));
                        ldap_msgfree(result);
-                       ldap_unbind(ldap_struct);
-                       return ret;
+                       return NT_STATUS_NO_SUCH_USER;
                }
                ldap_msgfree(result);
-               ldap_unbind(ldap_struct);
                ret = NT_STATUS_OK;
        } else {
                ldap_msgfree(result);
-               ldap_unbind(ldap_struct);
        }
        return ret;
 }
@@ -1367,52 +1856,62 @@ static NTSTATUS ldapsam_getsampwsid(struct pdb_methods *my_methods, SAM_ACCOUNT
 {
        uint32 rid;
        if (!sid_peek_check_rid(get_global_sam_sid(), sid, &rid))
-               return NT_STATUS_UNSUCCESSFUL;
+               return NT_STATUS_NO_SUCH_USER;
        return ldapsam_getsampwrid(my_methods, user, rid);
 }      
 
-static NTSTATUS ldapsam_modify_entry(LDAP *ldap_struct,SAM_ACCOUNT *newpwd,char *dn,LDAPMod **mods,int ldap_op)
+/********************************************************************
+Do the actual modification - also change a plaittext passord if 
+it it set.
+**********************************************************************/
+
+static NTSTATUS ldapsam_modify_entry(struct pdb_methods *my_methods, 
+                                    SAM_ACCOUNT *newpwd, char *dn,
+                                    LDAPMod **mods, int ldap_op, BOOL pdb_add)
 {
-       NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        int rc;
        
-       switch(ldap_op)
-       {
-               case LDAP_MOD_ADD: 
+       if (!my_methods || !newpwd || !dn) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
+       if (!mods) {
+               DEBUG(5,("mods is empty: nothing to modify\n"));
+               /* may be password change below however */
+       } else {
+               switch(ldap_op)
+               {
+                       case LDAP_MOD_ADD: 
                                make_a_mod(&mods, LDAP_MOD_ADD, "objectclass", "account");
-                               if((rc = ldap_add_s(ldap_struct,dn,mods))!=LDAP_SUCCESS) {
-                                       char *ld_error;
-                                       ldap_get_option(ldap_struct, LDAP_OPT_ERROR_STRING,
-                                       &ld_error);
-                                       DEBUG(0,
-                                               ("failed to add user with uid = %s with: %s\n\t%s\n",
-                                               pdb_get_username(newpwd), ldap_err2string(rc),
-                                               ld_error));
-                                       free(ld_error);
-                                       return ret;
-                               }  
+                               rc = ldapsam_add(ldap_state, dn, mods);
                                break;
-               case LDAP_MOD_REPLACE:  
-                               if((rc = ldap_modify_s(ldap_struct,dn,mods))!=LDAP_SUCCESS) {
-                                       char *ld_error;
-                                       ldap_get_option(ldap_struct, LDAP_OPT_ERROR_STRING,
-                                       &ld_error);
-                                       DEBUG(0,
-                                               ("failed to modify user with uid = %s with: %s\n\t%s\n",
-                                               pdb_get_username(newpwd), ldap_err2string(rc),
-                                               ld_error));
-                                       free(ld_error);
-                                       return ret;
-                               }  
+                       case LDAP_MOD_REPLACE: 
+                               rc = ldapsam_modify(ldap_state, dn ,mods);
                                break;
-               default:        
-                               DEBUG(0,("Wrong LDAP operation type: %d!\n",ldap_op));
-                               return ret;
+                       default:        
+                               DEBUG(0,("Wrong LDAP operation type: %d!\n", ldap_op));
+                               return NT_STATUS_UNSUCCESSFUL;
+               }
+               
+               if (rc!=LDAP_SUCCESS) {
+                       char *ld_error = NULL;
+                       ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                                       &ld_error);
+                       DEBUG(1,
+                             ("failed to %s user dn= %s with: %s\n\t%s\n",
+                              ldap_op == LDAP_MOD_ADD ? "add" : "modify",
+                              dn, ldap_err2string(rc),
+                              ld_error?ld_error:"unknown"));
+                       SAFE_FREE(ld_error);
+                       return NT_STATUS_UNSUCCESSFUL;
+               }  
        }
        
 #ifdef LDAP_EXOP_X_MODIFY_PASSWD
        if (!(pdb_get_acct_ctrl(newpwd)&(ACB_WSTRUST|ACB_SVRTRUST|ACB_DOMTRUST))&&
                (lp_ldap_passwd_sync()!=LDAP_PASSWD_SYNC_OFF)&&
+               need_ldap_mod(pdb_add, newpwd, PDB_PLAINTEXT_PW)&&
                (pdb_get_plaintext_passwd(newpwd)!=NULL)) {
                BerElement *ber;
                struct berval *bv;
@@ -1421,7 +1920,7 @@ static NTSTATUS ldapsam_modify_entry(LDAP *ldap_struct,SAM_ACCOUNT *newpwd,char
 
                if ((ber = ber_alloc_t(LBER_USE_DER))==NULL) {
                        DEBUG(0,("ber_alloc_t returns NULL\n"));
-                       return ret;
+                       return NT_STATUS_UNSUCCESSFUL;
                }
                ber_printf (ber, "{");
                ber_printf (ber, "ts", LDAP_TAG_EXOP_X_MODIFY_PASSWD_ID,dn);
@@ -1430,12 +1929,12 @@ static NTSTATUS ldapsam_modify_entry(LDAP *ldap_struct,SAM_ACCOUNT *newpwd,char
 
                if ((rc = ber_flatten (ber, &bv))<0) {
                        DEBUG(0,("ber_flatten returns a value <0\n"));
-                       return ret;
+                       return NT_STATUS_UNSUCCESSFUL;
                }
                
                ber_free(ber,1);
-               
-               if ((rc = ldap_extended_operation_s(ldap_struct, LDAP_EXOP_X_MODIFY_PASSWD,
+
+               if ((rc = ldapsam_extended_operation(ldap_state, LDAP_EXOP_X_MODIFY_PASSWD,
                                                    bv, NULL, NULL, &retoid, &retdata))!=LDAP_SUCCESS) {
                        DEBUG(0,("LDAP Password could not be changed for user %s: %s\n",
                                pdb_get_username(newpwd),ldap_err2string(rc)));
@@ -1458,61 +1957,45 @@ Delete entry from LDAP for username
 *********************************************************************/
 static NTSTATUS ldapsam_delete_sam_account(struct pdb_methods *my_methods, SAM_ACCOUNT * sam_acct)
 {
-       NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        const char *sname;
        int rc;
-       char *dn;
-       LDAP *ldap_struct;
-       LDAPMessage *entry;
        LDAPMessage *result;
+       NTSTATUS ret;
+       const char *sam_user_attrs[] =
+       { "lmPassword", "ntPassword", "pwdLastSet", "logonTime", "logoffTime",
+         "kickoffTime", "pwdCanChange", "pwdMustChange", "acctFlags",
+         "displayName", "smbHome", "homeDrive", "scriptPath", "profilePath",
+         "userWorkstations", "primaryGroupID", "domain", "rid", NULL };
 
        if (!sam_acct) {
                DEBUG(0, ("sam_acct was NULL!\n"));
-               return ret;
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
        sname = pdb_get_username(sam_acct);
 
-       if (!ldapsam_open_connection(ldap_state, &ldap_struct))
-               return ret;
-
        DEBUG (3, ("Deleting user %s from LDAP.\n", sname));
-       
-       if (!ldapsam_connect_system(ldap_state, ldap_struct)) {
-               ldap_unbind (ldap_struct);
-               DEBUG(0, ("Failed to delete user %s from LDAP.\n", sname));
-               return ret;
-       }
 
-       rc = ldapsam_search_one_user_by_name(ldap_state, ldap_struct, sname, &result);
-       if (ldap_count_entries (ldap_struct, result) == 0) {
-               DEBUG (0, ("User doesn't exit!\n"));
-               ldap_msgfree (result);
-               ldap_unbind (ldap_struct);
-               return ret;
+       rc = ldapsam_search_one_user_by_name(ldap_state, sname, &result);
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_NO_SUCH_USER;
        }
 
-       entry = ldap_first_entry (ldap_struct, result);
-       dn = ldap_get_dn (ldap_struct, entry);
+       ret = ldapsam_delete_entry(ldap_state, result, "sambaAccount",
+                                  sam_user_attrs);
        ldap_msgfree(result);
-       
-       rc = ldap_delete_s (ldap_struct, dn);
-
-       ldap_memfree (dn);
-       if (rc != LDAP_SUCCESS) {
-               char *ld_error;
-               ldap_get_option (ldap_struct, LDAP_OPT_ERROR_STRING, &ld_error);
-               DEBUG (0,("failed to delete user with uid = %s with: %s\n\t%s\n",
-                       sname, ldap_err2string (rc), ld_error));
-               free (ld_error);
-               ldap_unbind (ldap_struct);
-               return ret;
-       }
+       return ret;
+}
 
-       DEBUG (2,("successfully deleted uid = %s from the LDAP database\n", sname));
-       ldap_unbind (ldap_struct);
-       return NT_STATUS_OK;
+/**********************************************************************
+  Helper function to determine for update_sam_account whether
+  we need LDAP modification.
+*********************************************************************/
+static BOOL element_is_changed(const SAM_ACCOUNT *sampass,
+                              enum pdb_elements element)
+{
+       return IS_SAM_CHANGED(sampass, element);
 }
 
 /**********************************************************************
@@ -1524,57 +2007,69 @@ static NTSTATUS ldapsam_update_sam_account(struct pdb_methods *my_methods, SAM_A
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        int rc;
        char *dn;
-       LDAP *ldap_struct;
        LDAPMessage *result;
        LDAPMessage *entry;
        LDAPMod **mods;
 
-       if (!ldapsam_open_connection(ldap_state, &ldap_struct)) /* open a connection to the server */
-               return ret;
-
-       if (!ldapsam_connect_system(ldap_state, ldap_struct)) { /* connect as system account */
-               ldap_unbind(ldap_struct);
-               return ret;
+       rc = ldapsam_search_one_user_by_name(ldap_state, pdb_get_username(newpwd), &result);
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
-       rc = ldapsam_search_one_user_by_name(ldap_state, ldap_struct,
-                                            pdb_get_username(newpwd), &result);
-
-       if (ldap_count_entries(ldap_struct, result) == 0) {
+       if (ldap_count_entries(ldap_state->ldap_struct, result) == 0) {
                DEBUG(0, ("No user to modify!\n"));
                ldap_msgfree(result);
-               ldap_unbind(ldap_struct);
-               return ret;
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
-       if (!init_ldap_from_sam(ldap_state, &mods, LDAP_MOD_REPLACE, newpwd)) {
+       entry = ldap_first_entry(ldap_state->ldap_struct, result);
+       dn = ldap_get_dn(ldap_state->ldap_struct, entry);
+
+       if (!init_ldap_from_sam(ldap_state, entry, &mods, newpwd,
+                               element_is_changed)) {
                DEBUG(0, ("ldapsam_update_sam_account: init_ldap_from_sam failed!\n"));
                ldap_msgfree(result);
-               ldap_unbind(ldap_struct);
-               return ret;
+               return NT_STATUS_UNSUCCESSFUL;
        }
-
-       entry = ldap_first_entry(ldap_struct, result);
-       dn = ldap_get_dn(ldap_struct, entry);
+       
         ldap_msgfree(result);
        
-       if (NT_STATUS_IS_ERR(ldapsam_modify_entry(ldap_struct,newpwd,dn,mods,LDAP_MOD_REPLACE))) {
-               DEBUG(0,("failed to modify user with uid = %s\n",
-                                       pdb_get_username(newpwd)));
-               ldap_mods_free(mods,1);
-               ldap_unbind(ldap_struct);
+       if (mods == NULL) {
+               DEBUG(4,("mods is empty: nothing to update for user: %s\n",
+                        pdb_get_username(newpwd)));
+               ldap_mods_free(mods, 1);
+               return NT_STATUS_OK;
+       }
+       
+       ret = ldapsam_modify_entry(my_methods,newpwd,dn,mods,LDAP_MOD_REPLACE, False);
+       ldap_mods_free(mods,1);
+
+       if (!NT_STATUS_IS_OK(ret)) {
+               char *ld_error = NULL;
+               ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                               &ld_error);
+               DEBUG(0,("failed to modify user with uid = %s, error: %s (%s)\n",
+                        pdb_get_username(newpwd), ld_error?ld_error:"(unknwon)", ldap_err2string(rc)));
+               SAFE_FREE(ld_error);
                return ret;
        }
 
-
-       DEBUG(2,
-             ("successfully modified uid = %s in the LDAP database\n",
-              pdb_get_username(newpwd)));
-       ldap_mods_free(mods, 1);
-       ldap_unbind(ldap_struct);
+       DEBUG(2, ("successfully modified uid = %s in the LDAP database\n",
+                 pdb_get_username(newpwd)));
        return NT_STATUS_OK;
 }
 
+/**********************************************************************
+  Helper function to determine for update_sam_account whether
+  we need LDAP modification.
+*********************************************************************/
+static BOOL element_is_set_or_changed(const SAM_ACCOUNT *sampass,
+                                     enum pdb_elements element)
+{
+       return (IS_SAM_SET(sampass, element) ||
+               IS_SAM_CHANGED(sampass, element));
+}
+
 /**********************************************************************
 Add SAM_ACCOUNT to LDAP 
 *********************************************************************/
@@ -1584,8 +2079,8 @@ static NTSTATUS ldapsam_add_sam_account(struct pdb_methods *my_methods, SAM_ACCO
        struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
        int rc;
        pstring filter;
-       LDAP *ldap_struct = NULL;
        LDAPMessage *result = NULL;
+       LDAPMessage *entry  = NULL;
        pstring dn;
        LDAPMod **mods = NULL;
        int             ldap_op;
@@ -1594,46 +2089,44 @@ static NTSTATUS ldapsam_add_sam_account(struct pdb_methods *my_methods, SAM_ACCO
        const char *username = pdb_get_username(newpwd);
        if (!username || !*username) {
                DEBUG(0, ("Cannot add user without a username!\n"));
-               return ret;
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (!ldapsam_open_connection(ldap_state, &ldap_struct)) /* open a connection to the server */
-               return ret;
-
-       if (!ldapsam_connect_system(ldap_state, ldap_struct)) { /* connect as system account */
-               ldap_unbind(ldap_struct);
-               return ret;
+       rc = ldapsam_search_one_user_by_name (ldap_state, username, &result);
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
-       rc = ldapsam_search_one_user_by_name (ldap_state, ldap_struct, username, &result);
-
-       if (ldap_count_entries(ldap_struct, result) != 0) {
-               DEBUG(0,("User already in the base, with samba properties\n"));
+       if (ldap_count_entries(ldap_state->ldap_struct, result) != 0) {
+               DEBUG(0,("User '%s' already in the base, with samba properties\n", 
+                        username));
                ldap_msgfree(result);
-               ldap_unbind(ldap_struct);
-               return ret;
+               return NT_STATUS_UNSUCCESSFUL;
        }
        ldap_msgfree(result);
 
        slprintf (filter, sizeof (filter) - 1, "uid=%s", username);
-       rc = ldapsam_search_one_user(ldap_state, ldap_struct, filter, &result);
-       num_result = ldap_count_entries(ldap_struct, result);
+       rc = ldapsam_search_one_user(ldap_state, filter, &result);
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       num_result = ldap_count_entries(ldap_state->ldap_struct, result);
        
        if (num_result > 1) {
                DEBUG (0, ("More than one user with that uid exists: bailing out!\n"));
                ldap_msgfree(result);
-               return ret;
+               return NT_STATUS_UNSUCCESSFUL;
        }
        
        /* Check if we need to update an existing entry */
        if (num_result == 1) {
                char *tmp;
-               LDAPMessage *entry;
                
                DEBUG(3,("User exists without samba properties: adding them\n"));
                ldap_op = LDAP_MOD_REPLACE;
-               entry = ldap_first_entry (ldap_struct, result);
-               tmp = ldap_get_dn (ldap_struct, entry);
+               entry = ldap_first_entry (ldap_state->ldap_struct, result);
+               tmp = ldap_get_dn (ldap_state->ldap_struct, entry);
                slprintf (dn, sizeof (dn) - 1, "%s", tmp);
                ldap_memfree (tmp);
        } else {
@@ -1647,27 +2140,32 @@ static NTSTATUS ldapsam_add_sam_account(struct pdb_methods *my_methods, SAM_ACCO
                 }
        }
 
+       if (!init_ldap_from_sam(ldap_state, entry, &mods, newpwd,
+                               element_is_set_or_changed)) {
+               DEBUG(0, ("ldapsam_add_sam_account: init_ldap_from_sam failed!\n"));
+               ldap_msgfree(result);
+               return NT_STATUS_UNSUCCESSFUL;          
+       }
+       
        ldap_msgfree(result);
 
-       if (!init_ldap_from_sam(ldap_state, &mods, ldap_op, newpwd)) {
-               DEBUG(0, ("ldapsam_add_sam_account: init_ldap_from_sam failed!\n"));
-               ldap_mods_free(mods, 1);
-               ldap_unbind(ldap_struct);
-               return ret;             
+       if (mods == NULL) {
+               DEBUG(0,("mods is empty: nothing to add for user: %s\n",pdb_get_username(newpwd)));
+               return NT_STATUS_UNSUCCESSFUL;
        }
+       
        make_a_mod(&mods, LDAP_MOD_ADD, "objectclass", "sambaAccount");
 
-       if (NT_STATUS_IS_ERR(ldapsam_modify_entry(ldap_struct,newpwd,dn,mods,ldap_op))) {
+       ret = ldapsam_modify_entry(my_methods,newpwd,dn,mods,ldap_op, True);
+       if (NT_STATUS_IS_ERR(ret)) {
                DEBUG(0,("failed to modify/add user with uid = %s (dn = %s)\n",
-                                       pdb_get_username(newpwd),dn));
+                        pdb_get_username(newpwd),dn));
                ldap_mods_free(mods,1);
-               ldap_unbind(ldap_struct);
                return ret;
        }
 
        DEBUG(2,("added: uid = %s in the LDAP database\n", pdb_get_username(newpwd)));
        ldap_mods_free(mods, 1);
-       ldap_unbind(ldap_struct);
        return NT_STATUS_OK;
 }
 
@@ -1675,14 +2173,14 @@ static void free_private_data(void **vp)
 {
        struct ldapsam_privates **ldap_state = (struct ldapsam_privates **)vp;
 
-       if ((*ldap_state)->ldap_struct) {
-               ldap_unbind((*ldap_state)->ldap_struct);
-       }
+       ldapsam_close(*ldap_state);
 
        if ((*ldap_state)->bind_secret) {
                memset((*ldap_state)->bind_secret, '\0', strlen((*ldap_state)->bind_secret));
        }
 
+       ldapsam_close(*ldap_state);
+               
        SAFE_FREE((*ldap_state)->bind_dn);
        SAFE_FREE((*ldap_state)->bind_secret);
 
@@ -1691,6 +2189,496 @@ static void free_private_data(void **vp)
        /* No need to free any further, as it is talloc()ed */
 }
 
+static const char *group_attr[] = {"cn", "ntSid", "ntGroupType",
+                                  "gidNumber",
+                                  "displayName", "description",
+                                  NULL };
+                                  
+static int ldapsam_search_one_group (struct ldapsam_privates *ldap_state,
+                                    const char *filter,
+                                    LDAPMessage ** result)
+{
+       int scope = LDAP_SCOPE_SUBTREE;
+       int rc;
+
+       DEBUG(2, ("ldapsam_search_one_group: searching for:[%s]\n", filter));
+
+       rc = ldapsam_search(ldap_state, lp_ldap_suffix (), scope,
+                           filter, group_attr, 0, result);
+
+       if (rc != LDAP_SUCCESS) {
+               char *ld_error = NULL;
+               ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                               &ld_error);
+               DEBUG(0, ("ldapsam_search_one_group: "
+                         "Problem during the LDAP search: LDAP error: %s (%s)",
+                         ld_error?ld_error:"(unknown)", ldap_err2string(rc)));
+               DEBUG(3, ("ldapsam_search_one_group: Query was: %s, %s\n",
+                         lp_ldap_suffix(), filter));
+               SAFE_FREE(ld_error);
+       }
+
+       return rc;
+}
+
+static BOOL init_group_from_ldap(struct ldapsam_privates *ldap_state,
+                                GROUP_MAP *map, LDAPMessage *entry)
+{
+       pstring temp;
+
+       if (ldap_state == NULL || map == NULL || entry == NULL ||
+           ldap_state->ldap_struct == NULL) {
+               DEBUG(0, ("init_group_from_ldap: NULL parameters found!\n"));
+               return False;
+       }
+
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "gidNumber",
+                                 temp)) {
+               DEBUG(0, ("Mandatory attribute gidNumber not found\n"));
+               return False;
+       }
+       DEBUG(2, ("Entry found for group: %s\n", temp));
+
+       map->gid = (gid_t)atol(temp);
+
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "ntSid",
+                                 temp)) {
+               DEBUG(0, ("Mandatory attribute ntSid not found\n"));
+               return False;
+       }
+       string_to_sid(&map->sid, temp);
+
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "ntGroupType",
+                                 temp)) {
+               DEBUG(0, ("Mandatory attribute ntGroupType not found\n"));
+               return False;
+       }
+       map->sid_name_use = (uint32)atol(temp);
+
+       if ((map->sid_name_use < SID_NAME_USER) ||
+           (map->sid_name_use > SID_NAME_UNKNOWN)) {
+               DEBUG(0, ("Unknown Group type: %d\n", map->sid_name_use));
+               return False;
+       }
+
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "displayName",
+                                 temp)) {
+               DEBUG(3, ("Attribute displayName not found\n"));
+               temp[0] = '\0';
+               if (!get_single_attribute(ldap_state->ldap_struct, entry, "cn",
+                                         temp)) {
+                       DEBUG(0, ("Attributes cn not found either "
+                                 "for gidNumber(%i)\n",map->gid));
+                       return False;
+               }
+       }
+       fstrcpy(map->nt_name, temp);
+
+       if (!get_single_attribute(ldap_state->ldap_struct, entry, "description",
+                                 temp)) {
+               DEBUG(3, ("Attribute description not found\n"));
+               temp[0] = '\0';
+       }
+       fstrcpy(map->comment, temp);
+
+       map->systemaccount = 0;
+       init_privilege(&map->priv_set);
+
+       return True;
+}
+
+static BOOL init_ldap_from_group(LDAP *ldap_struct,
+                                LDAPMessage *existing,
+                                LDAPMod ***mods,
+                                const GROUP_MAP *map)
+{
+       pstring tmp;
+
+       if (mods == NULL || map == NULL) {
+               DEBUG(0, ("init_ldap_from_group: NULL parameters found!\n"));
+               return False;
+       }
+
+       *mods = NULL;
+
+       sid_to_string(tmp, &map->sid);
+       make_ldap_mod(ldap_struct, existing, mods, "ntSid", tmp);
+       snprintf(tmp, sizeof(tmp)-1, "%i", map->sid_name_use);
+       make_ldap_mod(ldap_struct, existing, mods, "ntGroupType", tmp);
+
+       make_ldap_mod(ldap_struct, existing, mods, "displayName", map->nt_name);
+       make_ldap_mod(ldap_struct, existing, mods, "description", map->comment);
+
+       return True;
+}
+
+static NTSTATUS ldapsam_getgroup(struct pdb_methods *methods,
+                                const char *filter,
+                                GROUP_MAP *map)
+{
+       struct ldapsam_privates *ldap_state =
+               (struct ldapsam_privates *)methods->private_data;
+       LDAPMessage *result;
+       LDAPMessage *entry;
+       int count;
+
+       if (ldapsam_search_one_group(ldap_state, filter, &result)
+           != LDAP_SUCCESS) {
+               return NT_STATUS_NO_SUCH_GROUP;
+       }
+
+       count = ldap_count_entries(ldap_state->ldap_struct, result);
+
+       if (count < 1) {
+               DEBUG(4, ("Did not find group for filter %s\n", filter));
+               return NT_STATUS_NO_SUCH_GROUP;
+       }
+
+       if (count > 1) {
+               DEBUG(1, ("Duplicate entries for filter %s: count=%d\n",
+                         filter, count));
+               return NT_STATUS_NO_SUCH_GROUP;
+       }
+
+       entry = ldap_first_entry(ldap_state->ldap_struct, result);
+
+       if (!entry) {
+               ldap_msgfree(result);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       if (!init_group_from_ldap(ldap_state, map, entry)) {
+               DEBUG(1, ("init_group_from_ldap failed for group filter %s\n",
+                         filter));
+               ldap_msgfree(result);
+               return NT_STATUS_NO_SUCH_GROUP;
+       }
+
+       ldap_msgfree(result);
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_getgrsid(struct pdb_methods *methods, GROUP_MAP *map,
+                                DOM_SID sid, BOOL with_priv)
+{
+       pstring filter;
+
+       snprintf(filter, sizeof(filter)-1,
+                "(&(objectClass=sambaGroupMapping)(ntSid=%s))",
+                sid_string_static(&sid));
+
+       return ldapsam_getgroup(methods, filter, map);
+}
+
+static NTSTATUS ldapsam_getgrgid(struct pdb_methods *methods, GROUP_MAP *map,
+                                gid_t gid, BOOL with_priv)
+{
+       pstring filter;
+
+       snprintf(filter, sizeof(filter)-1,
+                "(&(objectClass=sambaGroupMapping)(gidNumber=%d))",
+                gid);
+
+       return ldapsam_getgroup(methods, filter, map);
+}
+
+static NTSTATUS ldapsam_getgrnam(struct pdb_methods *methods, GROUP_MAP *map,
+                                char *name, BOOL with_priv)
+{
+       pstring filter;
+
+       /* TODO: Escaping of name? */
+
+       snprintf(filter, sizeof(filter)-1,
+                "(&(objectClass=sambaGroupMapping)(|(displayName=%s)(cn=%s)))",
+                name, name);
+
+       return ldapsam_getgroup(methods, filter, map);
+}
+
+static int ldapsam_search_one_group_by_gid(struct ldapsam_privates *ldap_state,
+                                          gid_t gid,
+                                          LDAPMessage **result)
+{
+       pstring filter;
+
+       snprintf(filter, sizeof(filter)-1,
+                "(&(objectClass=posixGroup)(gidNumber=%i))", gid);
+
+       return ldapsam_search_one_group(ldap_state, filter, result);
+}
+
+static NTSTATUS ldapsam_add_group_mapping_entry(struct pdb_methods *methods,
+                                               GROUP_MAP *map)
+{
+       struct ldapsam_privates *ldap_state =
+               (struct ldapsam_privates *)methods->private_data;
+       LDAPMessage *result = NULL;
+       LDAPMod **mods = NULL;
+
+       char *tmp;
+       pstring dn;
+       LDAPMessage *entry;
+
+       GROUP_MAP dummy;
+
+       int rc;
+
+       if (NT_STATUS_IS_OK(ldapsam_getgrgid(methods, &dummy,
+                                            map->gid, False))) {
+               DEBUG(0, ("Group %i already exists in LDAP\n", map->gid));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       rc = ldapsam_search_one_group_by_gid(ldap_state, map->gid, &result);
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       if (ldap_count_entries(ldap_state->ldap_struct, result) != 1) {
+               DEBUG(2, ("Group %i must exist exactly once in LDAP\n",
+                         map->gid));
+               ldap_msgfree(result);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       entry = ldap_first_entry(ldap_state->ldap_struct, result);
+       tmp = ldap_get_dn(ldap_state->ldap_struct, entry);
+       pstrcpy(dn, tmp);
+       ldap_memfree(tmp);
+
+       if (!init_ldap_from_group(ldap_state->ldap_struct,
+                                 result, &mods, map)) {
+               DEBUG(0, ("init_ldap_from_group failed!\n"));
+               ldap_mods_free(mods, 1);
+               ldap_msgfree(result);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       ldap_msgfree(result);
+
+       if (mods == NULL) {
+               DEBUG(0, ("mods is empty\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       make_a_mod(&mods, LDAP_MOD_ADD, "objectClass",
+                  "sambaGroupMapping");
+
+       rc = ldapsam_modify(ldap_state, dn, mods);
+       ldap_mods_free(mods, 1);
+
+       if (rc != LDAP_SUCCESS) {
+               char *ld_error = NULL;
+               ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                               &ld_error);
+               DEBUG(0, ("failed to add group %i error: %s (%s)\n", map->gid, 
+                         ld_error ? ld_error : "(unknown)", ldap_err2string(rc)));
+               SAFE_FREE(ld_error);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       DEBUG(2, ("successfully modified group %i in LDAP\n", map->gid));
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_update_group_mapping_entry(struct pdb_methods *methods,
+                                                  GROUP_MAP *map)
+{
+       struct ldapsam_privates *ldap_state =
+               (struct ldapsam_privates *)methods->private_data;
+       int rc;
+       char *dn;
+       LDAPMessage *result;
+       LDAPMessage *entry;
+       LDAPMod **mods;
+
+       rc = ldapsam_search_one_group_by_gid(ldap_state, map->gid, &result);
+
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       if (ldap_count_entries(ldap_state->ldap_struct, result) == 0) {
+               DEBUG(0, ("No group to modify!\n"));
+               ldap_msgfree(result);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       entry = ldap_first_entry(ldap_state->ldap_struct, result);
+       dn = ldap_get_dn(ldap_state->ldap_struct, entry);
+
+       if (!init_ldap_from_group(ldap_state->ldap_struct,
+                                 result, &mods, map)) {
+               DEBUG(0, ("init_ldap_from_group failed\n"));
+               ldap_msgfree(result);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       ldap_msgfree(result);
+
+       if (mods == NULL) {
+               DEBUG(4, ("mods is empty: nothing to do\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       rc = ldapsam_modify(ldap_state, dn, mods);
+
+       ldap_mods_free(mods, 1);
+
+       if (rc != LDAP_SUCCESS) {
+               char *ld_error = NULL;
+               ldap_get_option(ldap_state->ldap_struct, LDAP_OPT_ERROR_STRING,
+                               &ld_error);
+               DEBUG(0, ("failed to modify group %i error: %s (%s)\n", map->gid, 
+                         ld_error ? ld_error : "(unknown)", ldap_err2string(rc)));
+               SAFE_FREE(ld_error);
+       }
+
+       DEBUG(2, ("successfully modified group %i in LDAP\n", map->gid));
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_delete_group_mapping_entry(struct pdb_methods *methods,
+                                                  DOM_SID sid)
+{
+       struct ldapsam_privates *ldap_state =
+               (struct ldapsam_privates *)methods->private_data;
+       pstring sidstring, filter;
+       LDAPMessage *result;
+       int rc;
+       NTSTATUS ret;
+
+       const char *sam_group_attrs[] = { "ntSid", "ntGroupType",
+                                         "description", "displayName",
+                                         NULL };
+       sid_to_string(sidstring, &sid);
+       snprintf(filter, sizeof(filter)-1,
+                "(&(objectClass=sambaGroupMapping)(ntSid=%s))", sidstring);
+
+       rc = ldapsam_search_one_group(ldap_state, filter, &result);
+
+       if (rc != LDAP_SUCCESS) {
+               return NT_STATUS_NO_SUCH_GROUP;
+       }
+
+       ret = ldapsam_delete_entry(ldap_state, result, "sambaGroupMapping",
+                                  sam_group_attrs);
+       ldap_msgfree(result);
+       return ret;
+}
+
+static NTSTATUS ldapsam_setsamgrent(struct pdb_methods *my_methods,
+                                   BOOL update)
+{
+       struct ldapsam_privates *ldap_state =
+               (struct ldapsam_privates *)my_methods->private_data;
+       const char *filter = "(objectClass=sambaGroupMapping)";
+       int rc;
+
+       rc = ldapsam_search(ldap_state, lp_ldap_suffix(),
+                           LDAP_SCOPE_SUBTREE, filter,
+                           group_attr, 0, &ldap_state->result);
+
+       if (rc != LDAP_SUCCESS) {
+               DEBUG(0, ("LDAP search failed: %s\n", ldap_err2string(rc)));
+               DEBUG(3, ("Query was: %s, %s\n", lp_ldap_suffix(), filter));
+               ldap_msgfree(ldap_state->result);
+               ldap_state->result = NULL;
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       DEBUG(2, ("ldapsam_setsampwent: %d entries in the base!\n",
+                 ldap_count_entries(ldap_state->ldap_struct,
+                                    ldap_state->result)));
+
+       ldap_state->entry = ldap_first_entry(ldap_state->ldap_struct,
+                                ldap_state->result);
+       ldap_state->index = 0;
+
+       return NT_STATUS_OK;
+}
+
+static void ldapsam_endsamgrent(struct pdb_methods *my_methods)
+{
+       ldapsam_endsampwent(my_methods);
+}
+
+static NTSTATUS ldapsam_getsamgrent(struct pdb_methods *my_methods,
+                                   GROUP_MAP *map)
+{
+       NTSTATUS ret = NT_STATUS_UNSUCCESSFUL;
+       struct ldapsam_privates *ldap_state = (struct ldapsam_privates *)my_methods->private_data;
+       BOOL bret = False;
+
+       /* The rebind proc needs this *HACK*.  We are not multithreaded, so
+          this will work, but it's not nice. */
+       static_ldap_state = ldap_state;
+
+       while (!bret) {
+               if (!ldap_state->entry)
+                       return ret;
+               
+               ldap_state->index++;
+               bret = init_group_from_ldap(ldap_state, map, ldap_state->entry);
+               
+               ldap_state->entry = ldap_next_entry(ldap_state->ldap_struct,
+                                           ldap_state->entry); 
+       }
+
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ldapsam_enum_group_mapping(struct pdb_methods *methods,
+                                          enum SID_NAME_USE sid_name_use,
+                                          GROUP_MAP **rmap, int *num_entries,
+                                          BOOL unix_only, BOOL with_priv)
+{
+       GROUP_MAP map;
+       GROUP_MAP *mapt;
+       int entries = 0;
+       NTSTATUS nt_status;
+
+       *num_entries = 0;
+       *rmap = NULL;
+
+       if (!NT_STATUS_IS_OK(ldapsam_setsamgrent(methods, False))) {
+               DEBUG(0, ("Unable to open passdb\n"));
+               return NT_STATUS_ACCESS_DENIED;
+       }
+
+       while (NT_STATUS_IS_OK(nt_status = ldapsam_getsamgrent(methods, &map))) {
+               if (sid_name_use != SID_NAME_UNKNOWN &&
+                   sid_name_use != map.sid_name_use) {
+                       DEBUG(11,("enum_group_mapping: group %s is not of the requested type\n", map.nt_name));
+                       continue;
+               }
+               if (unix_only==ENUM_ONLY_MAPPED && map.gid==-1) {
+                       DEBUG(11,("enum_group_mapping: group %s is non mapped\n", map.nt_name));
+                       continue;
+               }
+
+               mapt=(GROUP_MAP *)Realloc((*rmap), (entries+1)*sizeof(GROUP_MAP));
+               if (!mapt) {
+                       DEBUG(0,("enum_group_mapping: Unable to enlarge group map!\n"));
+                       SAFE_FREE(*rmap);
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+               else
+                       (*rmap) = mapt;
+
+               mapt[entries] = map;
+
+               entries += 1;
+
+       }
+       ldapsam_endsamgrent(methods);
+
+       *num_entries = entries;
+
+       return NT_STATUS_OK;
+}
+
 NTSTATUS pdb_init_ldapsam(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method, const char *location)
 {
        NTSTATUS nt_status;
@@ -1711,6 +2699,14 @@ NTSTATUS pdb_init_ldapsam(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method, co
        (*pdb_method)->update_sam_account = ldapsam_update_sam_account;
        (*pdb_method)->delete_sam_account = ldapsam_delete_sam_account;
 
+       (*pdb_method)->getgrsid = ldapsam_getgrsid;
+       (*pdb_method)->getgrgid = ldapsam_getgrgid;
+       (*pdb_method)->getgrnam = ldapsam_getgrnam;
+       (*pdb_method)->add_group_mapping_entry = ldapsam_add_group_mapping_entry;
+       (*pdb_method)->update_group_mapping_entry = ldapsam_update_group_mapping_entry;
+       (*pdb_method)->delete_group_mapping_entry = ldapsam_delete_group_mapping_entry;
+       (*pdb_method)->enum_group_mapping = ldapsam_enum_group_mapping;
+
        /* TODO: Setup private data and free */
 
        ldap_state = talloc_zero(pdb_context->mem_ctx, sizeof(struct ldapsam_privates));
@@ -1726,18 +2722,18 @@ NTSTATUS pdb_init_ldapsam(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method, co
        } else {
                int ldap_port = lp_ldap_port();
                        
-               /* remap default port is no SSL */
-               if ( (lp_ldap_ssl() == LDAP_SSL_OFF) && (ldap_port == 636) ) {
+               /* remap default port if not using SSL (ie clear or TLS) */
+               if ( (lp_ldap_ssl() != LDAP_SSL_ON) && (ldap_port == 636) ) {
                        ldap_port = 389;
                }
 
-               ldap_state->uri = talloc_asprintf(pdb_context->mem_ctx, "%s://%s:%d", lp_ldap_ssl() ? "ldap" : "ldaps", lp_ldap_server(), ldap_port);
+               ldap_state->uri = talloc_asprintf(pdb_context->mem_ctx, "%s://%s:%d", lp_ldap_ssl() == LDAP_SSL_ON ? "ldaps" : "ldap", lp_ldap_server(), ldap_port);
                if (!ldap_state->uri) {
                        return NT_STATUS_NO_MEMORY;
                }
 #else
        } else {
-               ldap_state->uri = "ldaps://localhost";
+               ldap_state->uri = "ldap://localhost";
 #endif
        }
 
@@ -1776,20 +2772,9 @@ NTSTATUS pdb_init_ldapsam_nua(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method
        return NT_STATUS_OK;
 }
 
-
-#else
-
-NTSTATUS pdb_init_ldapsam(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method, const char *location)
-{
-       DEBUG(0, ("ldap not detected at configure time, ldapsam not availalble!\n"));
-       return NT_STATUS_UNSUCCESSFUL;
-}
-
-NTSTATUS pdb_init_ldapsam_nua(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method, const char *location)
+int pdb_ldap_init(void)
 {
-       DEBUG(0, ("ldap not dectected at configure time, ldapsam_nua not available!\n"));
-       return NT_STATUS_UNSUCCESSFUL;
+       smb_register_passdb("ldapsam", pdb_init_ldapsam, PASSDB_INTERFACE_VERSION);
+       smb_register_passdb("ldapsam_nua", pdb_init_ldapsam_nua, PASSDB_INTERFACE_VERSION);
+       return True;
 }
-
-
-#endif