s3-pdb: Make ADS-type backends updates secrets.tdb.
[ira/wip.git] / source3 / passdb / pdb_ipa.c
index 622705f40b31cc62432fcea1834de20d8a0686f1..74ac6774a47369a9ec25cdef7b57ae972b701c95 100644 (file)
 #include "libcli/security/dom_sid.h"
 #include "../librpc/ndr/libndr.h"
 #include "librpc/gen_ndr/samr.h"
+#include "secrets.h"
 
 #include "smbldap.h"
+#include "passdb/pdb_ldap.h"
+#include "passdb/pdb_ipa.h"
+#include "passdb/pdb_ldap_schema.h"
 
 #define IPA_KEYTAB_SET_OID "2.16.840.1.113730.3.8.3.1"
+#define IPA_MAGIC_ID_STR "999"
 
 #define LDAP_TRUST_CONTAINER "ou=system"
 #define LDAP_ATTRIBUTE_CN "cn"
 #define LDAP_ATTRIBUTE_TRUST_TYPE "sambaTrustType"
 #define LDAP_ATTRIBUTE_TRUST_ATTRIBUTES "sambaTrustAttributes"
 #define LDAP_ATTRIBUTE_TRUST_DIRECTION "sambaTrustDirection"
+#define LDAP_ATTRIBUTE_TRUST_POSIX_OFFSET "sambaTrustPosixOffset"
+#define LDAP_ATTRIBUTE_SUPPORTED_ENC_TYPE "sambaSupportedEncryptionTypes"
 #define LDAP_ATTRIBUTE_TRUST_PARTNER "sambaTrustPartner"
 #define LDAP_ATTRIBUTE_FLAT_NAME "sambaFlatName"
 #define LDAP_ATTRIBUTE_TRUST_AUTH_OUTGOING "sambaTrustAuthOutgoing"
 #define LDAP_OBJ_IPAHOST "ipaHost"
 #define LDAP_OBJ_POSIXACCOUNT "posixAccount"
 
+#define LDAP_OBJ_GROUPOFNAMES "groupOfNames"
+#define LDAP_OBJ_NESTEDGROUP "nestedGroup"
+#define LDAP_OBJ_IPAUSERGROUP "ipaUserGroup"
+#define LDAP_OBJ_POSIXGROUP "posixGroup"
+
 #define HAS_KRB_PRINCIPAL (1<<0)
 #define HAS_KRB_PRINCIPAL_AUX (1<<1)
 #define HAS_IPAOBJECT (1<<2)
 #define HAS_IPAHOST (1<<3)
 #define HAS_POSIXACCOUNT (1<<4)
+#define HAS_GROUPOFNAMES (1<<5)
+#define HAS_NESTEDGROUP (1<<6)
+#define HAS_IPAUSERGROUP (1<<7)
+#define HAS_POSIXGROUP (1<<8)
 
 struct ipasam_privates {
        bool server_is_ipa;
@@ -64,6 +80,10 @@ struct ipasam_privates {
        NTSTATUS (*ldapsam_create_user)(struct pdb_methods *my_methods,
                                        TALLOC_CTX *tmp_ctx, const char *name,
                                        uint32_t acb_info, uint32_t *rid);
+       NTSTATUS (*ldapsam_create_dom_group)(struct pdb_methods *my_methods,
+                                            TALLOC_CTX *tmp_ctx,
+                                            const char *name,
+                                            uint32_t *rid);
 };
 
 static bool ipasam_get_trusteddom_pw(struct pdb_methods *methods,
@@ -349,6 +369,29 @@ static bool fill_pdb_trusted_domain(TALLOC_CTX *mem_ctx,
                return false;
        }
 
+       td->trust_posix_offset = talloc(td, uint32_t);
+       if (td->trust_posix_offset == NULL) {
+               return false;
+       }
+       res = get_uint32_t_from_ldap_msg(ldap_state, entry,
+                                        LDAP_ATTRIBUTE_TRUST_POSIX_OFFSET,
+                                        td->trust_posix_offset);
+       if (!res) {
+               return false;
+       }
+
+       td->supported_enc_type = talloc(td, uint32_t);
+       if (td->supported_enc_type == NULL) {
+               return false;
+       }
+       res = get_uint32_t_from_ldap_msg(ldap_state, entry,
+                                        LDAP_ATTRIBUTE_SUPPORTED_ENC_TYPE,
+                                        td->supported_enc_type);
+       if (!res) {
+               return false;
+       }
+
+
        get_data_blob_from_ldap_msg(td, ldap_state, entry,
                                    LDAP_ATTRIBUTE_TRUST_FOREST_TRUST_INFO,
                                    &td->trust_forest_trust_info);
@@ -505,6 +548,26 @@ static NTSTATUS ipasam_set_trusted_domain(struct pdb_methods *methods,
                }
        }
 
+       if (td->trust_posix_offset != NULL) {
+               res = smbldap_make_mod_uint32_t(priv2ld(ldap_state), entry,
+                                               &mods,
+                                               LDAP_ATTRIBUTE_TRUST_POSIX_OFFSET,
+                                               *td->trust_posix_offset);
+               if (!res) {
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       }
+
+       if (td->supported_enc_type != NULL) {
+               res = smbldap_make_mod_uint32_t(priv2ld(ldap_state), entry,
+                                               &mods,
+                                               LDAP_ATTRIBUTE_SUPPORTED_ENC_TYPE,
+                                               *td->supported_enc_type);
+               if (!res) {
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       }
+
        if (td->trust_auth_outgoing.data != NULL) {
                smbldap_make_mod_blob(priv2ld(ldap_state), entry, &mods,
                                      LDAP_ATTRIBUTE_TRUST_AUTH_OUTGOING,
@@ -622,7 +685,7 @@ static NTSTATUS ipasam_enum_trusted_domains(struct pdb_methods *methods,
        }
 
        *num_domains = 0;
-       if (!(*domains = TALLOC_ARRAY(mem_ctx, struct pdb_trusted_domain *, 1))) {
+       if (!(*domains = talloc_array(mem_ctx, struct pdb_trusted_domain *, 1))) {
                DEBUG(1, ("talloc failed\n"));
                return NT_STATUS_NO_MEMORY;
        }
@@ -670,7 +733,7 @@ static NTSTATUS ipasam_enum_trusteddoms(struct pdb_methods *methods,
                return NT_STATUS_OK;
        }
 
-       if (!(*domains = TALLOC_ARRAY(mem_ctx, struct trustdom_info *,
+       if (!(*domains = talloc_array(mem_ctx, struct trustdom_info *,
                                      *num_domains))) {
                DEBUG(1, ("talloc failed\n"));
                return NT_STATUS_NO_MEMORY;
@@ -679,7 +742,7 @@ static NTSTATUS ipasam_enum_trusteddoms(struct pdb_methods *methods,
        for (i = 0; i < *num_domains; i++) {
                struct trustdom_info *dom_info;
 
-               dom_info = TALLOC_P(*domains, struct trustdom_info);
+               dom_info = talloc(*domains, struct trustdom_info);
                if (dom_info == NULL) {
                        DEBUG(1, ("talloc failed\n"));
                        return NT_STATUS_NO_MEMORY;
@@ -703,8 +766,11 @@ static struct pdb_domain_info *pdb_ipasam_get_domain_info(struct pdb_methods *pd
                                                          TALLOC_CTX *mem_ctx)
 {
        struct pdb_domain_info *info;
+       struct ldapsam_privates *ldap_state =
+                       (struct ldapsam_privates *)pdb_methods->private_data;
+       char sid_buf[24];
+       DATA_BLOB sid_blob;
        NTSTATUS status;
-       struct ldapsam_privates *ldap_state = pdb_methods->private_data;
 
        info = talloc(mem_ctx, struct pdb_domain_info);
        if (info == NULL) {
@@ -723,9 +789,27 @@ static struct pdb_domain_info *pdb_ipasam_get_domain_info(struct pdb_methods *pd
        }
        strlower_m(info->dns_domain);
        info->dns_forest = talloc_strdup(info, info->dns_domain);
+
+       /* we expect a domain SID to have 4 sub IDs */
+       if (ldap_state->domain_sid.num_auths != 4) {
+               goto fail;
+       }
+
        sid_copy(&info->sid, &ldap_state->domain_sid);
 
-       status = GUID_from_string("testguid", &info->guid);
+       if (!sid_linearize(sid_buf, sizeof(sid_buf), &info->sid)) {
+               goto fail;
+       }
+
+       /* the first 8 bytes of the linearized SID are not random,
+        * so we skip them */
+       sid_blob.data = (uint8_t *) sid_buf + 8 ;
+       sid_blob.length = 16;
+
+       status = GUID_from_ndr_blob(&sid_blob, &info->guid);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto fail;
+       }
 
        return info;
 
@@ -821,6 +905,14 @@ static NTSTATUS ipasam_get_objectclasses(struct ldapsam_privates *ldap_state,
                        *has_objectclass |= HAS_IPAHOST;
                } else if (strequal(objectclasses[c], LDAP_OBJ_POSIXACCOUNT)) {
                        *has_objectclass |= HAS_POSIXACCOUNT;
+               } else if (strequal(objectclasses[c], LDAP_OBJ_GROUPOFNAMES)) {
+                       *has_objectclass |= HAS_GROUPOFNAMES;
+               } else if (strequal(objectclasses[c], LDAP_OBJ_NESTEDGROUP)) {
+                       *has_objectclass |= HAS_NESTEDGROUP;
+               } else if (strequal(objectclasses[c], LDAP_OBJ_IPAUSERGROUP)) {
+                       *has_objectclass |= HAS_IPAUSERGROUP;
+               } else if (strequal(objectclasses[c], LDAP_OBJ_POSIXGROUP)) {
+                       *has_objectclass |= HAS_POSIXGROUP;
                }
        }
        ldap_value_free(objectclasses);
@@ -828,8 +920,15 @@ static NTSTATUS ipasam_get_objectclasses(struct ldapsam_privates *ldap_state,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS find_user(struct ldapsam_privates *ldap_state, const char *name,
-                         char **_dn, uint32_t *_has_objectclass)
+enum obj_type {
+       IPA_NO_OBJ = 0,
+       IPA_USER_OBJ,
+       IPA_GROUP_OBJ
+};
+
+static NTSTATUS find_obj(struct ldapsam_privates *ldap_state, const char *name,
+                        enum obj_type type, char **_dn,
+                        uint32_t *_has_objectclass)
 {
        int ret;
        char *username;
@@ -840,13 +939,26 @@ static NTSTATUS find_user(struct ldapsam_privates *ldap_state, const char *name,
        char *dn;
        uint32_t has_objectclass;
        NTSTATUS status;
+       const char *obj_class = NULL;
+
+       switch (type) {
+               case IPA_USER_OBJ:
+                       obj_class = LDAP_OBJ_POSIXACCOUNT;
+                       break;
+               case IPA_GROUP_OBJ:
+                       obj_class = LDAP_OBJ_POSIXGROUP;
+                       break;
+               default:
+                       DEBUG(0, ("Unsupported IPA object.\n"));
+                       return NT_STATUS_INVALID_PARAMETER;
+       }
 
        username = escape_ldap_string(talloc_tos(), name);
        if (username == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
        filter = talloc_asprintf(talloc_tos(), "(&(uid=%s)(objectClass=%s))",
-                                username, LDAP_OBJ_POSIXACCOUNT);
+                                username, obj_class);
        if (filter == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -863,9 +975,18 @@ static NTSTATUS find_user(struct ldapsam_privates *ldap_state, const char *name,
 
        if (num_result != 1) {
                if (num_result == 0) {
-                       status = NT_STATUS_NO_SUCH_USER;
+                       switch (type) {
+                               case IPA_USER_OBJ:
+                                       status = NT_STATUS_NO_SUCH_USER;
+                                       break;
+                               case IPA_GROUP_OBJ:
+                                       status = NT_STATUS_NO_SUCH_GROUP;
+                                       break;
+                               default:
+                                       status = NT_STATUS_INVALID_PARAMETER;
+                       }
                } else {
-                       DEBUG (0, ("find_user: More than one user with name [%s] ?!\n",
+                       DEBUG (0, ("find_user: More than one object with name [%s] ?!\n",
                                   name));
                        status = NT_STATUS_INTERNAL_DB_CORRUPTION;
                }
@@ -902,6 +1023,18 @@ done:
        return status;
 }
 
+static NTSTATUS find_user(struct ldapsam_privates *ldap_state, const char *name,
+                         char **_dn, uint32_t *_has_objectclass)
+{
+       return find_obj(ldap_state, name, IPA_USER_OBJ, _dn, _has_objectclass);
+}
+
+static NTSTATUS find_group(struct ldapsam_privates *ldap_state, const char *name,
+                          char **_dn, uint32_t *_has_objectclass)
+{
+       return find_obj(ldap_state, name, IPA_GROUP_OBJ, _dn, _has_objectclass);
+}
+
 static NTSTATUS ipasam_add_posix_account_objectclass(struct ldapsam_privates *ldap_state,
                                                     int ldap_op,
                                                     const char *dn,
@@ -909,12 +1042,13 @@ static NTSTATUS ipasam_add_posix_account_objectclass(struct ldapsam_privates *ld
 {
        int ret;
        LDAPMod **mods = NULL;
-       NTSTATUS status;
 
        smbldap_set_mod(&mods, LDAP_MOD_ADD,
                        "objectclass", "posixAccount");
        smbldap_set_mod(&mods, LDAP_MOD_ADD,
                        "cn", username);
+       smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                       "uidNumber", IPA_MAGIC_ID_STR);
        smbldap_set_mod(&mods, LDAP_MOD_ADD,
                        "gidNumber", "12345");
        smbldap_set_mod(&mods, LDAP_MOD_ADD,
@@ -929,7 +1063,62 @@ static NTSTATUS ipasam_add_posix_account_objectclass(struct ldapsam_privates *ld
        if (ret != LDAP_SUCCESS) {
                DEBUG(1, ("failed to modify/add user with uid = %s (dn = %s)\n",
                          username, dn));
-               return status;
+               return NT_STATUS_LDAP(ret);
+       }
+
+       return NT_STATUS_OK;
+}
+
+static NTSTATUS ipasam_add_ipa_group_objectclasses(struct ldapsam_privates *ldap_state,
+                                                  const char *dn,
+                                                  const char *name,
+                                                  uint32_t has_objectclass)
+{
+       LDAPMod **mods = NULL;
+       int ret;
+
+       if (!(has_objectclass & HAS_GROUPOFNAMES)) {
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               LDAP_ATTRIBUTE_OBJECTCLASS,
+                               LDAP_OBJ_GROUPOFNAMES);
+       }
+
+       if (!(has_objectclass & HAS_NESTEDGROUP)) {
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               LDAP_ATTRIBUTE_OBJECTCLASS,
+                               LDAP_OBJ_NESTEDGROUP);
+       }
+
+       if (!(has_objectclass & HAS_IPAUSERGROUP)) {
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               LDAP_ATTRIBUTE_OBJECTCLASS,
+                               LDAP_OBJ_IPAUSERGROUP);
+       }
+
+       if (!(has_objectclass & HAS_IPAOBJECT)) {
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               LDAP_ATTRIBUTE_OBJECTCLASS,
+                               LDAP_OBJ_IPAOBJECT);
+       }
+
+       if (!(has_objectclass & HAS_POSIXGROUP)) {
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               LDAP_ATTRIBUTE_OBJECTCLASS,
+                               LDAP_OBJ_POSIXGROUP);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               LDAP_ATTRIBUTE_CN,
+                               name);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               LDAP_ATTRIBUTE_GIDNUMBER,
+                               IPA_MAGIC_ID_STR);
+       }
+
+       ret = smbldap_modify(ldap_state->smbldap_state, dn, mods);
+       ldap_mods_free(mods, 1);
+       if (ret != LDAP_SUCCESS) {
+               DEBUG(1, ("failed to modify/add group %s (dn = %s)\n",
+                         name, dn));
+               return NT_STATUS_LDAP(ret);
        }
 
        return NT_STATUS_OK;
@@ -942,24 +1131,23 @@ static NTSTATUS ipasam_add_ipa_objectclasses(struct ldapsam_privates *ldap_state
                                             uint32_t has_objectclass)
 {
        LDAPMod **mods = NULL;
-       NTSTATUS status;
        int ret;
        char *princ;
 
-       if (!(has_objectclass & HAS_KRB_PRINCIPAL)); {
+       if (!(has_objectclass & HAS_KRB_PRINCIPAL)) {
                smbldap_set_mod(&mods, LDAP_MOD_ADD,
                                LDAP_ATTRIBUTE_OBJECTCLASS,
                                LDAP_OBJ_KRB_PRINCIPAL);
-       }
 
-       princ = talloc_asprintf(talloc_tos(), "%s@%s", name, lp_realm());
-       if (princ == NULL) {
-               return NT_STATUS_NO_MEMORY;
-       }
+               princ = talloc_asprintf(talloc_tos(), "%s@%s", name, lp_realm());
+               if (princ == NULL) {
+                       return NT_STATUS_NO_MEMORY;
+               }
 
-       smbldap_set_mod(&mods, LDAP_MOD_ADD, LDAP_ATTRIBUTE_KRB_PRINCIPAL, princ);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, LDAP_ATTRIBUTE_KRB_PRINCIPAL, princ);
+       }
 
-       if (!(has_objectclass & HAS_KRB_PRINCIPAL_AUX)); {
+       if (!(has_objectclass & HAS_KRB_PRINCIPAL_AUX)) {
                smbldap_set_mod(&mods, LDAP_MOD_ADD,
                                LDAP_ATTRIBUTE_OBJECTCLASS,
                                LDAP_OBJ_KRB_PRINCIPAL_AUX);
@@ -978,32 +1166,36 @@ static NTSTATUS ipasam_add_ipa_objectclasses(struct ldapsam_privates *ldap_state
                        smbldap_set_mod(&mods, LDAP_MOD_ADD,
                                        LDAP_ATTRIBUTE_OBJECTCLASS,
                                        LDAP_OBJ_IPAHOST);
-               }
 
-               if (domain == NULL) {
-                       return NT_STATUS_INVALID_PARAMETER;
-               }
+                       if (domain == NULL) {
+                               return NT_STATUS_INVALID_PARAMETER;
+                       }
 
-               smbldap_set_mod(&mods, LDAP_MOD_ADD,
-                               "fqdn", domain);
+                       smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                                       "fqdn", domain);
+               }
        }
 
        if (!(has_objectclass & HAS_POSIXACCOUNT)) {
                smbldap_set_mod(&mods, LDAP_MOD_ADD,
                                "objectclass", "posixAccount");
+               smbldap_set_mod(&mods, LDAP_MOD_ADD, "cn", name);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               "uidNumber", IPA_MAGIC_ID_STR);
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               "gidNumber", "12345");
+               smbldap_set_mod(&mods, LDAP_MOD_ADD,
+                               "homeDirectory", "/dev/null");
        }
-       smbldap_set_mod(&mods, LDAP_MOD_ADD, "cn", name);
-       smbldap_set_mod(&mods, LDAP_MOD_ADD,
-                       "gidNumber", "12345");
-       smbldap_set_mod(&mods, LDAP_MOD_ADD,
-                       "homeDirectory", "/dev/null");
 
-       ret = smbldap_modify(ldap_state->smbldap_state, dn, mods);
-       ldap_mods_free(mods, 1);
-       if (ret != LDAP_SUCCESS) {
-               DEBUG(1, ("failed to modify/add user with uid = %s (dn = %s)\n",
-                         name, dn));
-               return status;
+       if (mods != NULL) {
+               ret = smbldap_modify(ldap_state->smbldap_state, dn, mods);
+               ldap_mods_free(mods, 1);
+               if (ret != LDAP_SUCCESS) {
+                       DEBUG(1, ("failed to modify/add user with uid = %s (dn = %s)\n",
+                                 name, dn));
+                       return NT_STATUS_LDAP(ret);
+               }
        }
 
        return NT_STATUS_OK;
@@ -1017,9 +1209,22 @@ static NTSTATUS pdb_ipasam_add_sam_account(struct pdb_methods *pdb_methods,
        const char *name;
        char *dn;
        uint32_t has_objectclass;
+       uint32_t rid;
+       struct dom_sid user_sid;
 
        ldap_state = (struct ldapsam_privates *)(pdb_methods->private_data);
 
+       if (IS_SAM_SET(sampass, PDB_USERSID) ||
+           IS_SAM_CHANGED(sampass, PDB_USERSID)) {
+               if (!pdb_new_rid(&rid)) {
+                       return NT_STATUS_DS_NO_MORE_RIDS;
+               }
+               sid_compose(&user_sid, get_global_sam_sid(), rid);
+               if (!pdb_set_user_sid(sampass, &user_sid, PDB_SET)) {
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       }
+
        status = ldap_state->ipasam_privates->ldapsam_add_sam_account(pdb_methods,
                                                                      sampass);
        if (!NT_STATUS_IS_OK(status)) {
@@ -1090,6 +1295,50 @@ static NTSTATUS pdb_ipasam_update_sam_account(struct pdb_methods *pdb_methods,
        return NT_STATUS_OK;
 }
 
+static NTSTATUS ipasam_create_dom_group(struct pdb_methods *pdb_methods,
+                                       TALLOC_CTX *tmp_ctx, const char *name,
+                                       uint32_t *rid)
+{
+       NTSTATUS status;
+       struct ldapsam_privates *ldap_state;
+       int ldap_op = LDAP_MOD_REPLACE;
+       char *dn;
+       uint32_t has_objectclass = 0;
+
+       ldap_state = (struct ldapsam_privates *)(pdb_methods->private_data);
+
+       if (name == NULL || *name == '\0') {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       status = find_group(ldap_state, name, &dn, &has_objectclass);
+       if (NT_STATUS_IS_OK(status)) {
+               ldap_op = LDAP_MOD_REPLACE;
+       } else if (NT_STATUS_EQUAL(status, NT_STATUS_NO_SUCH_USER)) {
+               ldap_op = LDAP_MOD_ADD;
+       } else {
+               return status;
+       }
+
+       if (!(has_objectclass & HAS_POSIXGROUP)) {
+               status = ipasam_add_ipa_group_objectclasses(ldap_state, dn,
+                                                           name,
+                                                           has_objectclass);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
+       }
+
+       status = ldap_state->ipasam_privates->ldapsam_create_dom_group(pdb_methods,
+                                                                      tmp_ctx,
+                                                                      name,
+                                                                      rid);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       return NT_STATUS_OK;
+}
 static NTSTATUS ipasam_create_user(struct pdb_methods *pdb_methods,
                                   TALLOC_CTX *tmp_ctx, const char *name,
                                   uint32_t acb_info, uint32_t *rid)
@@ -1110,7 +1359,25 @@ static NTSTATUS ipasam_create_user(struct pdb_methods *pdb_methods,
        if (NT_STATUS_IS_OK(status)) {
                ldap_op = LDAP_MOD_REPLACE;
        } else if (NT_STATUS_EQUAL(status, NT_STATUS_NO_SUCH_USER)) {
+               char *escape_username;
                ldap_op = LDAP_MOD_ADD;
+               escape_username = escape_rdn_val_string_alloc(name);
+               if (!escape_username) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+               if (name[strlen(name)-1] == '$') {
+                       dn = talloc_asprintf(tmp_ctx, "uid=%s,%s",
+                                            escape_username,
+                                            lp_ldap_machine_suffix());
+               } else {
+                       dn = talloc_asprintf(tmp_ctx, "uid=%s,%s",
+                                            escape_username,
+                                            lp_ldap_user_suffix());
+               }
+               SAFE_FREE(escape_username);
+               if (!dn) {
+                       return NT_STATUS_NO_MEMORY;
+               }
        } else {
                return status;
        }
@@ -1121,6 +1388,7 @@ static NTSTATUS ipasam_create_user(struct pdb_methods *pdb_methods,
                if (!NT_STATUS_IS_OK(status)) {
                        return status;
                }
+               has_objectclass |= HAS_POSIXACCOUNT;
        }
 
        status = ldap_state->ipasam_privates->ldapsam_create_user(pdb_methods,
@@ -1139,6 +1407,42 @@ static NTSTATUS ipasam_create_user(struct pdb_methods *pdb_methods,
        return NT_STATUS_OK;
 }
 
+static NTSTATUS pdb_ipa_init_secrets(struct pdb_methods *m)
+{
+#if _SAMBA_BUILD_ == 4
+       struct pdb_domain_info *dom_info;
+       bool ret;
+
+       dom_info = pdb_ipasam_get_domain_info(m, m);
+       if (!dom_info) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       secrets_clear_domain_protection(dom_info->name);
+       ret = secrets_store_domain_sid(dom_info->name,
+                                      &dom_info->sid);
+       if (!ret) {
+               goto done;
+       }
+       ret = secrets_store_domain_guid(dom_info->name,
+                                       &dom_info->guid);
+       if (!ret) {
+               goto done;
+       }
+       ret = secrets_mark_domain_protected(dom_info->name);
+       if (!ret) {
+               goto done;
+       }
+
+done:
+       TALLOC_FREE(dom_info);
+       if (!ret) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+#endif
+       return NT_STATUS_OK;
+}
+
 static NTSTATUS pdb_init_IPA_ldapsam(struct pdb_methods **pdb_method, const char *location)
 {
        struct ldapsam_privates *ldap_state;
@@ -1164,6 +1468,7 @@ static NTSTATUS pdb_init_IPA_ldapsam(struct pdb_methods **pdb_method, const char
        ldap_state->ipasam_privates->ldapsam_add_sam_account = (*pdb_method)->add_sam_account;
        ldap_state->ipasam_privates->ldapsam_update_sam_account = (*pdb_method)->update_sam_account;
        ldap_state->ipasam_privates->ldapsam_create_user = (*pdb_method)->create_user;
+       ldap_state->ipasam_privates->ldapsam_create_dom_group = (*pdb_method)->create_dom_group;
 
        (*pdb_method)->add_sam_account = pdb_ipasam_add_sam_account;
        (*pdb_method)->update_sam_account = pdb_ipasam_update_sam_account;
@@ -1171,6 +1476,7 @@ static NTSTATUS pdb_init_IPA_ldapsam(struct pdb_methods **pdb_method, const char
        if (lp_parm_bool(-1, "ldapsam", "trusted", False)) {
                if (lp_parm_bool(-1, "ldapsam", "editposix", False)) {
                        (*pdb_method)->create_user = ipasam_create_user;
+                       (*pdb_method)->create_dom_group = ipasam_create_dom_group;
                }
        }
 
@@ -1188,6 +1494,12 @@ static NTSTATUS pdb_init_IPA_ldapsam(struct pdb_methods **pdb_method, const char
        (*pdb_method)->del_trusted_domain = ipasam_del_trusted_domain;
        (*pdb_method)->enum_trusted_domains = ipasam_enum_trusted_domains;
 
+       status = pdb_ipa_init_secrets(*pdb_method);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("pdb_ipa_init_secrets failed!\n"));
+               return status;
+       }
+
        return NT_STATUS_OK;
 }