Merge of a debuglevel downgrade from HEAD.
[ira/wip.git] / source3 / passdb / pdb_get_set.c
index 980850b89c9cc09abfa2bc6e3af3cdee949fe927..a86d9362630b994c84f244dfd5e7f1fc4133613c 100644 (file)
@@ -37,7 +37,7 @@
 #define PDB_NOT_QUITE_NULL ""
 
 /*********************************************************************
- Collection of get...() functions for SAM_ACCOUNT_INFO.
+ Collection of get...() functions for SAM_ACCOUNT.
  ********************************************************************/
 
 uint16 pdb_get_acct_ctrl (const SAM_ACCOUNT *sampass)
@@ -151,7 +151,7 @@ const uint8* pdb_get_lanman_passwd (const SAM_ACCOUNT *sampass)
 const char* pdb_get_plaintext_passwd (const SAM_ACCOUNT *sampass)
 {
        if (sampass) {
-               return ((char*)sampass->private.plaintext_pw.data);
+               return (sampass->private.plaintext_pw);
        }
        else
                return (NULL);
@@ -172,39 +172,34 @@ const DOM_SID *pdb_get_group_sid(const SAM_ACCOUNT *sampass)
                return (NULL);
 }      
 
-uint32 pdb_get_user_rid (const SAM_ACCOUNT *sampass)
-{
-       uint32 u_rid;
-
-       if (sampass)
-               if (sid_peek_check_rid(get_global_sam_sid(), pdb_get_user_sid(sampass),&u_rid))
-                       return u_rid;
-       
-       return (-1);
-}
-
-uint32 pdb_get_group_rid (const SAM_ACCOUNT *sampass)
-{
-       uint32 g_rid;
-
-       if (sampass)
-               if (sid_peek_check_rid(get_global_sam_sid(), pdb_get_group_sid(sampass),&g_rid))
-                       return g_rid;
-       return (-1);
-}
-
 /**
  * Get flags showing what is initalised in the SAM_ACCOUNT
  * @param sampass the SAM_ACCOUNT in question
  * @return the flags indicating the members initialised in the struct.
  **/
  
-uint32 pdb_get_init_flag (const SAM_ACCOUNT *sampass)
+enum pdb_value_state pdb_get_init_flags (const SAM_ACCOUNT *sampass, enum pdb_elements element)
 {
-        if (sampass)
-               return sampass->private.init_flag;
-       else 
-                return FLAG_SAM_UNINIT;
+       enum pdb_value_state ret = PDB_DEFAULT;
+       
+        if (!sampass || !sampass->private.change_flags || !sampass->private.set_flags)
+               return ret;
+               
+        if (bitmap_query(sampass->private.set_flags, element)) {
+               DEBUG(11, ("element %d: SET\n", element)); 
+               ret = PDB_SET;
+       }
+               
+        if (bitmap_query(sampass->private.change_flags, element)) {
+               DEBUG(11, ("element %d: CHANGED\n", element)); 
+               ret = PDB_CHANGED;
+       }
+
+       if (ret == PDB_DEFAULT) {
+               DEBUG(11, ("element %d: DEFAULT\n", element)); 
+       }
+
+        return ret;
 }
 
 uid_t pdb_get_uid (const SAM_ACCOUNT *sampass)
@@ -271,7 +266,7 @@ const char* pdb_get_unix_homedir (const SAM_ACCOUNT *sampass)
                return (NULL);
 }
 
-const char* pdb_get_dirdrive (const SAM_ACCOUNT *sampass)
+const char* pdb_get_dir_drive (const SAM_ACCOUNT *sampass)
 {
        if (sampass)
                return (sampass->private.dir_drive);
@@ -327,7 +322,7 @@ const char* pdb_get_munged_dial (const SAM_ACCOUNT *sampass)
                return (NULL);
 }
 
-uint32 pdb_get_unknown3 (const SAM_ACCOUNT *sampass)
+uint32 pdb_get_unknown_3 (const SAM_ACCOUNT *sampass)
 {
        if (sampass)
                return (sampass->private.unknown_3);
@@ -335,7 +330,7 @@ uint32 pdb_get_unknown3 (const SAM_ACCOUNT *sampass)
                return (-1);
 }
 
-uint32 pdb_get_unknown5 (const SAM_ACCOUNT *sampass)
+uint32 pdb_get_unknown_5 (const SAM_ACCOUNT *sampass)
 {
        if (sampass)
                return (sampass->private.unknown_5);
@@ -343,7 +338,7 @@ uint32 pdb_get_unknown5 (const SAM_ACCOUNT *sampass)
                return (-1);
 }
 
-uint32 pdb_get_unknown6 (const SAM_ACCOUNT *sampass)
+uint32 pdb_get_unknown_6 (const SAM_ACCOUNT *sampass)
 {
        if (sampass)
                return (sampass->private.unknown_6);
@@ -352,113 +347,97 @@ uint32 pdb_get_unknown6 (const SAM_ACCOUNT *sampass)
 }
 
 /*********************************************************************
- Collection of set...() functions for SAM_ACCOUNT_INFO.
+ Collection of set...() functions for SAM_ACCOUNT.
  ********************************************************************/
 
-BOOL pdb_set_acct_ctrl (SAM_ACCOUNT *sampass, uint16 flags)
+BOOL pdb_set_acct_ctrl (SAM_ACCOUNT *sampass, uint16 acct_ctrl, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
                
-       if (sampass) {
-               sampass->private.acct_ctrl = flags;
-               return True;
-       }
-       
-       return False;
+       sampass->private.acct_ctrl = acct_ctrl;
+
+       return pdb_set_init_flags(sampass, PDB_ACCTCTRL, flag);
 }
 
-BOOL pdb_set_logon_time (SAM_ACCOUNT *sampass, time_t mytime, BOOL store)
+BOOL pdb_set_logon_time (SAM_ACCOUNT *sampass, time_t mytime, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.logon_time = mytime;
 
-       if (store)
-               pdb_set_init_flag(sampass, FLAG_SAM_LOGONTIME); 
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_LOGONTIME, flag);
 }
 
-BOOL pdb_set_logoff_time (SAM_ACCOUNT *sampass, time_t mytime, BOOL store)
+BOOL pdb_set_logoff_time (SAM_ACCOUNT *sampass, time_t mytime, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.logoff_time = mytime;
 
-       if (store)
-               pdb_set_init_flag(sampass, FLAG_SAM_LOGOFFTIME); 
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_LOGOFFTIME, flag);
 }
 
-BOOL pdb_set_kickoff_time (SAM_ACCOUNT *sampass, time_t mytime, BOOL store)
+BOOL pdb_set_kickoff_time (SAM_ACCOUNT *sampass, time_t mytime, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.kickoff_time = mytime;
 
-       if (store)
-               pdb_set_init_flag(sampass, FLAG_SAM_KICKOFFTIME); 
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_KICKOFFTIME, flag);
 }
 
-BOOL pdb_set_pass_can_change_time (SAM_ACCOUNT *sampass, time_t mytime, BOOL store)
+BOOL pdb_set_pass_can_change_time (SAM_ACCOUNT *sampass, time_t mytime, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.pass_can_change_time = mytime;
 
-       if (store)
-               pdb_set_init_flag(sampass, FLAG_SAM_CANCHANGETIME); 
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_CANCHANGETIME, flag);
 }
 
-BOOL pdb_set_pass_must_change_time (SAM_ACCOUNT *sampass, time_t mytime, BOOL store)
+BOOL pdb_set_pass_must_change_time (SAM_ACCOUNT *sampass, time_t mytime, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.pass_must_change_time = mytime;
 
-       if (store)
-               pdb_set_init_flag(sampass, FLAG_SAM_MUSTCHANGETIME); 
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_MUSTCHANGETIME, flag);
 }
 
-BOOL pdb_set_pass_last_set_time (SAM_ACCOUNT *sampass, time_t mytime)
+BOOL pdb_set_pass_last_set_time (SAM_ACCOUNT *sampass, time_t mytime, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.pass_last_set_time = mytime;
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_PASSLASTSET, flag);
 }
 
-BOOL pdb_set_hours_len (SAM_ACCOUNT *sampass, uint32 len)
+BOOL pdb_set_hours_len (SAM_ACCOUNT *sampass, uint32 len, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.hours_len = len;
-       return True;
+
+       return pdb_set_init_flags(sampass, PDB_HOURSLEN, flag);
 }
 
-BOOL pdb_set_logon_divs (SAM_ACCOUNT *sampass, uint16 hours)
+BOOL pdb_set_logon_divs (SAM_ACCOUNT *sampass, uint16 hours, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.logon_divs = hours;
-       return True;
+
+       return pdb_set_init_flags(sampass, PDB_LOGONDIVS, flag);
 }
 
 /**
@@ -468,18 +447,70 @@ BOOL pdb_set_logon_divs (SAM_ACCOUNT *sampass, uint16 hours)
  *             this flag is only added.  
  **/
  
-BOOL pdb_set_init_flag (SAM_ACCOUNT *sampass, uint32 flag)
+BOOL pdb_set_init_flags (SAM_ACCOUNT *sampass, enum pdb_elements element, enum pdb_value_state value_flag)
 {
-        if (!sampass)
+        if (!sampass || !sampass->mem_ctx)
                 return False;
 
-        sampass->private.init_flag |= flag;
+        if (!sampass->private.set_flags) {
+               if ((sampass->private.set_flags = 
+                       bitmap_talloc(sampass->mem_ctx, 
+                                       PDB_COUNT))==NULL) {
+                       DEBUG(0,("bitmap_talloc failed\n"));
+                       return False;
+               }
+        }
+        if (!sampass->private.change_flags) {
+               if ((sampass->private.change_flags = 
+                       bitmap_talloc(sampass->mem_ctx, 
+                                       PDB_COUNT))==NULL) {
+                       DEBUG(0,("bitmap_talloc failed\n"));
+                       return False;
+               }
+        }
+        
+        switch(value_flag) {
+               case PDB_CHANGED:
+                       if (!bitmap_set(sampass->private.change_flags, element)) {
+                               DEBUG(0,("Can't set flag: %d in change_flags.\n",element));
+                               return False;
+                       }
+                       if (!bitmap_set(sampass->private.set_flags, element)) {
+                               DEBUG(0,("Can't set flag: %d in set_flags.\n",element));
+                               return False;
+                       }
+                       DEBUG(11, ("element %d -> now CHANGED\n", element)); 
+                       break;
+               case PDB_SET:
+                       if (!bitmap_clear(sampass->private.change_flags, element)) {
+                               DEBUG(0,("Can't set flag: %d in change_flags.\n",element));
+                               return False;
+                       }
+                       if (!bitmap_set(sampass->private.set_flags, element)) {
+                               DEBUG(0,("Can't set flag: %d in set_flags.\n",element));
+                               return False;
+                       }
+                       DEBUG(10, ("element %d -> now SET\n", element)); 
+                       break;
+               case PDB_DEFAULT:
+               default:
+                       if (!bitmap_clear(sampass->private.change_flags, element)) {
+                               DEBUG(0,("Can't set flag: %d in change_flags.\n",element));
+                               return False;
+                       }
+                       if (!bitmap_clear(sampass->private.set_flags, element)) {
+                               DEBUG(0,("Can't set flag: %d in set_flags.\n",element));
+                               return False;
+                       }
+                       DEBUG(11, ("element %d -> now DEFAULT\n", element)); 
+                       break;
+       }
 
         return True;
 }
 
-BOOL pdb_set_uid (SAM_ACCOUNT *sampass, const uid_t uid)
-{
+BOOL pdb_set_uid (SAM_ACCOUNT *sampass, const uid_t uid, enum pdb_value_state flag)
+{      
        if (!sampass)
                return False;
        
@@ -487,13 +518,11 @@ BOOL pdb_set_uid (SAM_ACCOUNT *sampass, const uid_t uid)
                   (int)uid, (int)sampass->private.uid));
  
        sampass->private.uid = uid;
-       pdb_set_init_flag(sampass, FLAG_SAM_UID); 
-
-       return True;
-
+       
+       return pdb_set_init_flags(sampass, PDB_UID, flag);
 }
 
-BOOL pdb_set_gid (SAM_ACCOUNT *sampass, const gid_t gid)
+BOOL pdb_set_gid (SAM_ACCOUNT *sampass, const gid_t gid, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -502,13 +531,11 @@ BOOL pdb_set_gid (SAM_ACCOUNT *sampass, const gid_t gid)
                   (int)gid, (int)sampass->private.gid));
  
        sampass->private.gid = gid; 
-       pdb_set_init_flag(sampass, FLAG_SAM_GID); 
-
-       return True;
 
+       return pdb_set_init_flags(sampass, PDB_GID, flag);
 }
 
-BOOL pdb_set_user_sid (SAM_ACCOUNT *sampass, DOM_SID *u_sid)
+BOOL pdb_set_user_sid (SAM_ACCOUNT *sampass, DOM_SID *u_sid, enum pdb_value_state flag)
 {
        if (!sampass || !u_sid)
                return False;
@@ -517,74 +544,64 @@ BOOL pdb_set_user_sid (SAM_ACCOUNT *sampass, DOM_SID *u_sid)
 
        DEBUG(10, ("pdb_set_user_sid: setting user sid %s\n", 
                    sid_string_static(&sampass->private.user_sid)));
-       
-       return True;
-}
-
-BOOL pdb_set_group_sid(SAM_ACCOUNT *sampass, DOM_SID *g_sid)
-{
-       if (!sampass || !g_sid)
-               return False;
 
-       sid_copy(&sampass->private.group_sid, g_sid);
-
-       DEBUG(10, ("pdb_set_group_sid: setting group sid %s\n", 
-                   sid_string_static(&sampass->private.group_sid)));
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_USERSID, flag);
 }
 
-BOOL pdb_set_user_sid_from_rid (SAM_ACCOUNT *sampass, uint32 rid)
+BOOL pdb_set_user_sid_from_string (SAM_ACCOUNT *sampass, fstring u_sid, enum pdb_value_state flag)
 {
-       DOM_SID u_sid;
-       const DOM_SID *global_sam_sid;
+       DOM_SID new_sid;
        
-       if (!sampass)
+       if (!sampass || !u_sid)
                return False;
 
-       if (!(global_sam_sid = get_global_sam_sid())) {
-               DEBUG(1, ("pdb_set_user_sid_from_rid: Could not read global sam sid!\n"));
+       DEBUG(10, ("pdb_set_user_sid_from_string: setting user sid %s\n",
+                  u_sid));
+
+       if (!string_to_sid(&new_sid, u_sid)) { 
+               DEBUG(1, ("pdb_set_user_sid_from_string: %s isn't a valid SID!\n", u_sid));
+               return False;
+       }
+        
+       if (!pdb_set_user_sid(sampass, &new_sid, flag)) {
+               DEBUG(1, ("pdb_set_user_sid_from_string: could not set sid %s on SAM_ACCOUNT!\n", u_sid));
                return False;
        }
 
-       sid_copy(&u_sid, global_sam_sid);
+       return True;
+}
 
-       if (!sid_append_rid(&u_sid, rid))
+BOOL pdb_set_group_sid (SAM_ACCOUNT *sampass, DOM_SID *g_sid, enum pdb_value_state flag)
+{
+       if (!sampass || !g_sid)
                return False;
 
-       if (!pdb_set_user_sid(sampass, &u_sid))
-               return False;
+       sid_copy(&sampass->private.group_sid, g_sid);
 
-       DEBUG(10, ("pdb_set_user_sid_from_rid:\n\tsetting user sid %s from rid %d\n", 
-                   sid_string_static(&u_sid),rid));
+       DEBUG(10, ("pdb_set_group_sid: setting group sid %s\n", 
+                   sid_string_static(&sampass->private.group_sid)));
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_GROUPSID, flag);
 }
 
-BOOL pdb_set_group_sid_from_rid (SAM_ACCOUNT *sampass, uint32 grid)
+BOOL pdb_set_group_sid_from_string (SAM_ACCOUNT *sampass, fstring g_sid, enum pdb_value_state flag)
 {
-       DOM_SID g_sid;
-       const DOM_SID *global_sam_sid;
-
-       if (!sampass)
-               return False;
-       
-       if (!(global_sam_sid = get_global_sam_sid())) {
-               DEBUG(1, ("pdb_set_user_sid_from_rid: Could not read global sam sid!\n"));
+       DOM_SID new_sid;
+       if (!sampass || !g_sid)
                return False;
-       }
 
-       sid_copy(&g_sid, global_sam_sid);
-       
-       if (!sid_append_rid(&g_sid, grid))
-               return False;
+       DEBUG(10, ("pdb_set_group_sid_from_string: setting group sid %s\n",
+                  g_sid));
 
-       if (!pdb_set_group_sid(sampass, &g_sid))
+       if (!string_to_sid(&new_sid, g_sid)) { 
+               DEBUG(1, ("pdb_set_group_sid_from_string: %s isn't a valid SID!\n", g_sid));
                return False;
-
-       DEBUG(10, ("pdb_set_group_sid_from_rid:\n\tsetting group sid %s from rid %d\n", 
-                   sid_string_static(&g_sid), grid));
-
+       }
+        
+       if (!pdb_set_group_sid(sampass, &new_sid, flag)) {
+               DEBUG(1, ("pdb_set_group_sid_from_string: could not set sid %s on SAM_ACCOUNT!\n", g_sid));
+               return False;
+       }
        return True;
 }
 
@@ -592,8 +609,8 @@ BOOL pdb_set_group_sid_from_rid (SAM_ACCOUNT *sampass, uint32 grid)
  Set the user's UNIX name.
  ********************************************************************/
 
-BOOL pdb_set_username(SAM_ACCOUNT *sampass, const char *username)
-{      
+BOOL pdb_set_username(SAM_ACCOUNT *sampass, const char *username, enum pdb_value_state flag)
+{
        if (!sampass)
                return False;
  
@@ -611,16 +628,16 @@ BOOL pdb_set_username(SAM_ACCOUNT *sampass, const char *username)
        } else {
                sampass->private.username = PDB_NOT_QUITE_NULL;
        }
-
-       return True;
+       
+       return pdb_set_init_flags(sampass, PDB_USERNAME, flag);
 }
 
 /*********************************************************************
  Set the domain name.
  ********************************************************************/
 
-BOOL pdb_set_domain(SAM_ACCOUNT *sampass, const char *domain)
-{      
+BOOL pdb_set_domain(SAM_ACCOUNT *sampass, const char *domain, enum pdb_value_state flag)
+{
        if (!sampass)
                return False;
 
@@ -639,14 +656,14 @@ BOOL pdb_set_domain(SAM_ACCOUNT *sampass, const char *domain)
                sampass->private.domain = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_DOMAIN, flag);
 }
 
 /*********************************************************************
  Set the user's NT name.
  ********************************************************************/
 
-BOOL pdb_set_nt_username(SAM_ACCOUNT *sampass, const char *nt_username)
+BOOL pdb_set_nt_username(SAM_ACCOUNT *sampass, const char *nt_username, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -666,14 +683,14 @@ BOOL pdb_set_nt_username(SAM_ACCOUNT *sampass, const char *nt_username)
                sampass->private.nt_username = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_NTUSERNAME, flag);
 }
 
 /*********************************************************************
  Set the user's full name.
  ********************************************************************/
 
-BOOL pdb_set_fullname(SAM_ACCOUNT *sampass, const char *full_name)
+BOOL pdb_set_fullname(SAM_ACCOUNT *sampass, const char *full_name, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -693,14 +710,14 @@ BOOL pdb_set_fullname(SAM_ACCOUNT *sampass, const char *full_name)
                sampass->private.full_name = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_FULLNAME, flag);
 }
 
 /*********************************************************************
  Set the user's logon script.
  ********************************************************************/
 
-BOOL pdb_set_logon_script(SAM_ACCOUNT *sampass, const char *logon_script, BOOL store)
+BOOL pdb_set_logon_script(SAM_ACCOUNT *sampass, const char *logon_script, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -720,19 +737,14 @@ BOOL pdb_set_logon_script(SAM_ACCOUNT *sampass, const char *logon_script, BOOL s
                sampass->private.logon_script = PDB_NOT_QUITE_NULL;
        }
        
-       if (store) {
-               DEBUG(10, ("pdb_set_logon_script: setting logon script sam flag!\n"));
-               pdb_set_init_flag(sampass, FLAG_SAM_LOGONSCRIPT);
-       }
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_LOGONSCRIPT, flag);
 }
 
 /*********************************************************************
  Set the user's profile path.
  ********************************************************************/
 
-BOOL pdb_set_profile_path (SAM_ACCOUNT *sampass, const char *profile_path, BOOL store)
+BOOL pdb_set_profile_path (SAM_ACCOUNT *sampass, const char *profile_path, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -752,19 +764,14 @@ BOOL pdb_set_profile_path (SAM_ACCOUNT *sampass, const char *profile_path, BOOL
                sampass->private.profile_path = PDB_NOT_QUITE_NULL;
        }
 
-       if (store) {
-               DEBUG(10, ("pdb_set_profile_path: setting profile path sam flag!\n"));
-               pdb_set_init_flag(sampass, FLAG_SAM_PROFILE);
-       }
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_PROFILE, flag);
 }
 
 /*********************************************************************
  Set the user's directory drive.
  ********************************************************************/
 
-BOOL pdb_set_dir_drive (SAM_ACCOUNT *sampass, const char *dir_drive, BOOL store)
+BOOL pdb_set_dir_drive (SAM_ACCOUNT *sampass, const char *dir_drive, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -784,19 +791,14 @@ BOOL pdb_set_dir_drive (SAM_ACCOUNT *sampass, const char *dir_drive, BOOL store)
                sampass->private.dir_drive = PDB_NOT_QUITE_NULL;
        }
        
-       if (store) {
-               DEBUG(10, ("pdb_set_dir_drive: setting dir drive sam flag!\n"));
-               pdb_set_init_flag(sampass, FLAG_SAM_DRIVE);
-       }
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_DRIVE, flag);
 }
 
 /*********************************************************************
  Set the user's home directory.
  ********************************************************************/
 
-BOOL pdb_set_homedir (SAM_ACCOUNT *sampass, const char *home_dir, BOOL store)
+BOOL pdb_set_homedir (SAM_ACCOUNT *sampass, const char *home_dir, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -816,25 +818,20 @@ BOOL pdb_set_homedir (SAM_ACCOUNT *sampass, const char *home_dir, BOOL store)
                sampass->private.home_dir = PDB_NOT_QUITE_NULL;
        }
 
-       if (store) {
-               DEBUG(10, ("pdb_set_homedir: setting home dir sam flag!"));
-               pdb_set_init_flag(sampass, FLAG_SAM_SMBHOME);
-       }
-
-       return True;
+       return pdb_set_init_flags(sampass, PDB_SMBHOME, flag);
 }
 
 /*********************************************************************
  Set the user's unix home directory.
  ********************************************************************/
 
-BOOL pdb_set_unix_homedir (SAM_ACCOUNT *sampass, const char *unix_home_dir)
+BOOL pdb_set_unix_homedir (SAM_ACCOUNT *sampass, const char *unix_home_dir, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        if (unix_home_dir) { 
-               DEBUG(10, ("pdb_set_homedir: setting home dir %s, was %s\n", unix_home_dir,
+               DEBUG(10, ("pdb_set_unix_homedir: setting home dir %s, was %s\n", unix_home_dir,
                        (sampass->private.unix_home_dir)?(sampass->private.unix_home_dir):"NULL"));
  
                sampass->private.unix_home_dir = talloc_strdup(sampass->mem_ctx, 
@@ -849,14 +846,14 @@ BOOL pdb_set_unix_homedir (SAM_ACCOUNT *sampass, const char *unix_home_dir)
                sampass->private.unix_home_dir = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_UNIXHOMEDIR, flag);
 }
 
 /*********************************************************************
  Set the user's account description.
  ********************************************************************/
 
-BOOL pdb_set_acct_desc (SAM_ACCOUNT *sampass, const char *acct_desc)
+BOOL pdb_set_acct_desc (SAM_ACCOUNT *sampass, const char *acct_desc, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -873,14 +870,14 @@ BOOL pdb_set_acct_desc (SAM_ACCOUNT *sampass, const char *acct_desc)
                sampass->private.acct_desc = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_ACCTDESC, flag);
 }
 
 /*********************************************************************
  Set the user's workstation allowed list.
  ********************************************************************/
 
-BOOL pdb_set_workstations (SAM_ACCOUNT *sampass, const char *workstations)
+BOOL pdb_set_workstations (SAM_ACCOUNT *sampass, const char *workstations, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -900,14 +897,14 @@ BOOL pdb_set_workstations (SAM_ACCOUNT *sampass, const char *workstations)
                sampass->private.workstations = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_WORKSTATIONS, flag);
 }
 
 /*********************************************************************
  Set the user's 'unknown_str', whatever the heck this actually is...
  ********************************************************************/
 
-BOOL pdb_set_unknown_str (SAM_ACCOUNT *sampass, const char *unknown_str)
+BOOL pdb_set_unknown_str (SAM_ACCOUNT *sampass, const char *unknown_str, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -924,14 +921,14 @@ BOOL pdb_set_unknown_str (SAM_ACCOUNT *sampass, const char *unknown_str)
                sampass->private.unknown_str = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_UNKNOWNSTR, flag);
 }
 
 /*********************************************************************
  Set the user's dial string.
  ********************************************************************/
 
-BOOL pdb_set_munged_dial (SAM_ACCOUNT *sampass, const char *munged_dial)
+BOOL pdb_set_munged_dial (SAM_ACCOUNT *sampass, const char *munged_dial, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -948,14 +945,14 @@ BOOL pdb_set_munged_dial (SAM_ACCOUNT *sampass, const char *munged_dial)
                sampass->private.munged_dial = PDB_NOT_QUITE_NULL;
        }
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_MUNGEDDIAL, flag);
 }
 
 /*********************************************************************
  Set the user's NT hash.
  ********************************************************************/
 
-BOOL pdb_set_nt_passwd (SAM_ACCOUNT *sampass, const uint8 *pwd)
+BOOL pdb_set_nt_passwd (SAM_ACCOUNT *sampass, const uint8 pwd[NT_HASH_LEN], enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -964,14 +961,14 @@ BOOL pdb_set_nt_passwd (SAM_ACCOUNT *sampass, const uint8 *pwd)
        
        sampass->private.nt_pw = data_blob(pwd, NT_HASH_LEN);
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_NTPASSWD, flag);
 }
 
 /*********************************************************************
  Set the user's LM hash.
  ********************************************************************/
 
-BOOL pdb_set_lanman_passwd (SAM_ACCOUNT *sampass, const uint8 pwd[16])
+BOOL pdb_set_lanman_passwd (SAM_ACCOUNT *sampass, const uint8 pwd[LM_HASH_LEN], enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -980,7 +977,7 @@ BOOL pdb_set_lanman_passwd (SAM_ACCOUNT *sampass, const uint8 pwd[16])
        
        sampass->private.lm_pw = data_blob(pwd, LM_HASH_LEN);
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_LMPASSWD, flag);
 }
 
 /*********************************************************************
@@ -988,46 +985,60 @@ BOOL pdb_set_lanman_passwd (SAM_ACCOUNT *sampass, const uint8 pwd[16])
  below)
  ********************************************************************/
 
-BOOL pdb_set_plaintext_pw_only (SAM_ACCOUNT *sampass, const uint8 *password, size_t len)
+BOOL pdb_set_plaintext_pw_only (SAM_ACCOUNT *sampass, const char *password, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
-       data_blob_clear_free(&sampass->private.plaintext_pw);
-       
-       sampass->private.plaintext_pw = data_blob(password, len);
+       if (password) { 
+               if (sampass->private.plaintext_pw!=NULL) 
+                       memset(sampass->private.plaintext_pw,'\0',strlen(sampass->private.plaintext_pw)+1);
 
-       return True;
+               sampass->private.plaintext_pw = talloc_strdup(sampass->mem_ctx, password);
+               
+               if (!sampass->private.plaintext_pw) {
+                       DEBUG(0, ("pdb_set_unknown_str: talloc_strdup() failed!\n"));
+                       return False;
+               }
+
+       } else {
+               sampass->private.plaintext_pw = NULL;
+       }
+
+       return pdb_set_init_flags(sampass, PDB_PLAINTEXT_PW, flag);
 }
 
-BOOL pdb_set_unknown_3 (SAM_ACCOUNT *sampass, uint32 unkn)
+BOOL pdb_set_unknown_3 (SAM_ACCOUNT *sampass, uint32 unkn, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.unknown_3 = unkn;
-       return True;
+       
+       return pdb_set_init_flags(sampass, PDB_UNKNOWN3, flag);
 }
 
-BOOL pdb_set_unknown_5 (SAM_ACCOUNT *sampass, uint32 unkn)
+BOOL pdb_set_unknown_5 (SAM_ACCOUNT *sampass, uint32 unkn, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.unknown_5 = unkn;
-       return True;
+
+       return pdb_set_init_flags(sampass, PDB_UNKNOWN5, flag);
 }
 
-BOOL pdb_set_unknown_6 (SAM_ACCOUNT *sampass, uint32 unkn)
+BOOL pdb_set_unknown_6 (SAM_ACCOUNT *sampass, uint32 unkn, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
 
        sampass->private.unknown_6 = unkn;
-       return True;
+
+       return pdb_set_init_flags(sampass, PDB_UNKNOWN6, flag);
 }
 
-BOOL pdb_set_hours (SAM_ACCOUNT *sampass, const uint8 *hours)
+BOOL pdb_set_hours (SAM_ACCOUNT *sampass, const uint8 *hours, enum pdb_value_state flag)
 {
        if (!sampass)
                return False;
@@ -1039,7 +1050,7 @@ BOOL pdb_set_hours (SAM_ACCOUNT *sampass, const uint8 *hours)
        
        memcpy (sampass->private.hours, hours, MAX_HOURS_LEN);
 
-       return True;
+       return pdb_set_init_flags(sampass, PDB_HOURS, flag);
 }
 
 
@@ -1053,25 +1064,35 @@ BOOL pdb_set_hours (SAM_ACCOUNT *sampass, const uint8 *hours)
 BOOL pdb_set_pass_changed_now (SAM_ACCOUNT *sampass)
 {
        uint32 expire;
+       uint32 min_age;
 
        if (!sampass)
                return False;
        
-       if (!pdb_set_pass_last_set_time (sampass, time(NULL)))
+       if (!pdb_set_pass_last_set_time (sampass, time(NULL), PDB_CHANGED))
                return False;
 
-       account_policy_get(AP_MAX_PASSWORD_AGE, &expire);
-
-       if (expire==(uint32)-1) {
-               if (!pdb_set_pass_must_change_time (sampass, get_time_t_max(), False))
+       if (!account_policy_get(AP_MAX_PASSWORD_AGE, &expire) 
+           || (expire==(uint32)-1)) {
+               if (!pdb_set_pass_must_change_time (sampass, get_time_t_max(), PDB_CHANGED))
                        return False;
        } else {
                if (!pdb_set_pass_must_change_time (sampass, 
-                                           pdb_get_pass_last_set_time(sampass)
-                                           + expire, True))
+                                                   pdb_get_pass_last_set_time(sampass)
+                                                   + expire, PDB_CHANGED))
                        return False;
        }
        
+       if (!account_policy_get(AP_MIN_PASSWORD_AGE, &min_age) 
+           || (min_age==(uint32)-1)) {
+               if (!pdb_set_pass_can_change_time (sampass, 0, PDB_CHANGED))
+                       return False;
+       } else {
+               if (!pdb_set_pass_can_change_time (sampass, 
+                                                   pdb_get_pass_last_set_time(sampass)
+                                                   + min_age, PDB_CHANGED))
+                       return False;
+       }
        return True;
 }
 
@@ -1090,15 +1111,17 @@ BOOL pdb_set_plaintext_passwd (SAM_ACCOUNT *sampass, const char *plaintext)
        
        nt_lm_owf_gen (plaintext, new_nt_p16, new_lanman_p16);
 
-       if (!pdb_set_nt_passwd (sampass, new_nt_p16)) 
+       if (!pdb_set_nt_passwd (sampass, new_nt_p16, PDB_CHANGED)) 
                return False;
 
-       if (!pdb_set_lanman_passwd (sampass, new_lanman_p16)) 
+       if (!pdb_set_lanman_passwd (sampass, new_lanman_p16, PDB_CHANGED)) 
                return False;
-       
+
+       if (!pdb_set_plaintext_pw_only (sampass, plaintext, PDB_CHANGED)) 
+               return False;
+
        if (!pdb_set_pass_changed_now (sampass))
                return False;
 
        return True;
 }
-