*id_to_*id call reshape to return NTSTATUS errors
[ira/wip.git] / source3 / passdb / passdb.c
index 1dd0d4141acd2b5849789c0d514a74cd2e560bd0..8631888fafbd2e803f4ae1bcbce8c9f866d9e181 100644 (file)
@@ -1,11 +1,11 @@
 /* 
-   Unix SMB/Netbios implementation.
-   Version 3.0
+   Unix SMB/CIFS implementation.
    Password and authentication handling
    Copyright (C) Jeremy Allison                1996-2001
    Copyright (C) Luke Kenneth Casson Leighton  1996-1998
    Copyright (C) Gerald (Jerry) Carter         2000-2001
    Copyright (C) Andrew Bartlett               2001-2002
+   Copyright (C) Simo Sorce                    2003
       
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 
 #include "includes.h"
 
+#undef DBGC_CLASS
+#define DBGC_CLASS DBGC_PASSDB
+
 /*
  * This is set on startup - it defines the SID for this
  * machine, and therefore the SAM database for which it is
  * responsible.
  */
 
-extern DOM_SID global_sam_sid;
-
-struct passdb_ops *pdb_ops;
-
-#if 0  /* JERRY */
-static void* pdb_handle = NULL;
-#endif
-
-/***************************************************************
- Initialize the password db operations.
-***************************************************************/
-
-BOOL initialize_password_db(BOOL reload)
-{      
-       /* 
-        * This function is unfinished right now, so just 
-        * ignore the details and always return True.  It 
-        * is here only as a placeholder          --jerry 
-        */
-       return True;
-       
-}
-
-
 /************************************************************
  Fill the SAM_ACCOUNT with default values.
  ***********************************************************/
 
-static BOOL pdb_fill_default_sam(SAM_ACCOUNT *user)
+static void pdb_fill_default_sam(SAM_ACCOUNT *user)
 {
-       if (user == NULL) {
-               DEBUG(0,("pdb_fill_default_sam: SAM_ACCOUNT was NULL\n"));
-               return False;
-       }
-       
-       ZERO_STRUCTP(user);
+       ZERO_STRUCT(user->private); /* Don't touch the talloc context */
+
+       /* no initial methods */
+       user->methods = NULL;
 
         /* Don't change these timestamp settings without a good reason.
            They are important for NT member server compatibility. */
 
-       user->private.init_flag             = FLAG_SAM_UNINIT;
-       user->private.uid = user->private.gid       = -1;
-
        user->private.logon_time            = (time_t)0;
        user->private.pass_last_set_time    = (time_t)0;
        user->private.pass_can_change_time  = (time_t)0;
@@ -85,34 +59,100 @@ static BOOL pdb_fill_default_sam(SAM_ACCOUNT *user)
        memset(user->private.hours, 0xff, user->private.hours_len); /* available at all hours */
        user->private.unknown_5 = 0x00000000; /* don't know */
        user->private.unknown_6 = 0x000004ec; /* don't know */
-       return True;
+
+       /* Some parts of samba strlen their pdb_get...() returns, 
+          so this keeps the interface unchanged for now. */
+          
+       user->private.username = "";
+       user->private.domain = "";
+       user->private.nt_username = "";
+       user->private.full_name = "";
+       user->private.home_dir = "";
+       user->private.logon_script = "";
+       user->private.profile_path = "";
+       user->private.acct_desc = "";
+       user->private.workstations = "";
+       user->private.unknown_str = "";
+       user->private.munged_dial = "";
+
+       user->private.plaintext_pw = NULL;
+
 }      
 
+static void destroy_pdb_talloc(SAM_ACCOUNT **user) 
+{
+       if (*user) {
+               data_blob_clear_free(&((*user)->private.lm_pw));
+               data_blob_clear_free(&((*user)->private.nt_pw));
+
+               if((*user)->private.plaintext_pw!=NULL)
+                       memset((*user)->private.plaintext_pw,'\0',strlen((*user)->private.plaintext_pw));
+               talloc_destroy((*user)->mem_ctx);
+               *user = NULL;
+       }
+}
+
 
-/*************************************************************
- Alloc memory and initialises a struct sam_passwd.
- ************************************************************/
+/**********************************************************************
+ Alloc memory and initialises a struct sam_passwd on supplied mem_ctx.
+***********************************************************************/
 
-BOOL pdb_init_sam(SAM_ACCOUNT **user)
+NTSTATUS pdb_init_sam_talloc(TALLOC_CTX *mem_ctx, SAM_ACCOUNT **user)
 {
        if (*user != NULL) {
-               DEBUG(0,("pdb_init_sam: SAM_ACCOUNT was non NULL\n"));
+               DEBUG(0,("pdb_init_sam_talloc: SAM_ACCOUNT was non NULL\n"));
 #if 0
-               smb_panic("NULL pointer passed to pdb_init_sam\n");
+               smb_panic("non-NULL pointer passed to pdb_init_sam\n");
 #endif
-               return False;
+               return NT_STATUS_UNSUCCESSFUL;
        }
-       
-       *user=(SAM_ACCOUNT *)malloc(sizeof(SAM_ACCOUNT));
+
+       if (!mem_ctx) {
+               DEBUG(0,("pdb_init_sam_talloc: mem_ctx was NULL!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       *user=(SAM_ACCOUNT *)talloc(mem_ctx, sizeof(SAM_ACCOUNT));
 
        if (*user==NULL) {
-               DEBUG(0,("pdb_init_sam: error while allocating memory\n"));
-               return False;
+               DEBUG(0,("pdb_init_sam_talloc: error while allocating memory\n"));
+               return NT_STATUS_NO_MEMORY;
        }
 
+       (*user)->mem_ctx = mem_ctx;
+
+       (*user)->free_fn = NULL;
+
        pdb_fill_default_sam(*user);
+       
+       return NT_STATUS_OK;
+}
 
-       return True;
+
+/*************************************************************
+ Alloc memory and initialises a struct sam_passwd.
+ ************************************************************/
+
+NTSTATUS pdb_init_sam(SAM_ACCOUNT **user)
+{
+       TALLOC_CTX *mem_ctx;
+       NTSTATUS nt_status;
+       
+       mem_ctx = talloc_init("passdb internal SAM_ACCOUNT allocation");
+
+       if (!mem_ctx) {
+               DEBUG(0,("pdb_init_sam: error while doing talloc_init()\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam_talloc(mem_ctx, user))) {
+               talloc_destroy(mem_ctx);
+               return nt_status;
+       }
+       
+       (*user)->free_fn = destroy_pdb_talloc;
+
+       return NT_STATUS_OK;
 }
 
 
@@ -120,85 +160,168 @@ BOOL pdb_init_sam(SAM_ACCOUNT **user)
  Initialises a struct sam_passwd with sane values.
  ************************************************************/
 
-BOOL pdb_init_sam_pw(SAM_ACCOUNT **new_sam_acct, const struct passwd *pwd)
+NTSTATUS pdb_fill_sam_pw(SAM_ACCOUNT *sam_account, const struct passwd *pwd)
 {
-       pstring str;
-       GROUP_MAP map;
-       uint32 rid;
+       NTSTATUS ret;
+
+       if (!pwd) {
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       pdb_fill_default_sam(sam_account);
+
+       pdb_set_username(sam_account, pwd->pw_name, PDB_SET);
+       pdb_set_fullname(sam_account, pwd->pw_gecos, PDB_SET);
+
+       pdb_set_unix_homedir(sam_account, pwd->pw_dir, PDB_SET);
+
+       pdb_set_domain (sam_account, lp_workgroup(), PDB_DEFAULT);
+       
+       /* When we get a proper uid -> SID and SID -> uid allocation
+          mechinism, we should call it here.  
+          
+          We can't just set this to 0 or allow it only to be filled
+          in when added to the backend, becouse the user's SID 
+          may already be in security descriptors etc.
+          
+          -- abartlet 11-May-02
+       */
+
+       ret = pdb_set_sam_sids(sam_account, pwd);
+       if (NT_STATUS_IS_ERR(ret)) return ret;
+
+       /* check if this is a user account or a machine account */
+       if (pwd->pw_name[strlen(pwd->pw_name)-1] != '$')
+       {
+               pdb_set_profile_path(sam_account, 
+                                    talloc_sub_specified((sam_account)->mem_ctx, 
+                                                           lp_logon_path(), 
+                                                           pwd->pw_name, global_myname(), 
+                                                           pwd->pw_uid, pwd->pw_gid), 
+                                    PDB_DEFAULT);
+               
+               pdb_set_homedir(sam_account, 
+                               talloc_sub_specified((sam_account)->mem_ctx, 
+                                                      lp_logon_home(),
+                                                      pwd->pw_name, global_myname(), 
+                                                      pwd->pw_uid, pwd->pw_gid),
+                               PDB_DEFAULT);
+               
+               pdb_set_dir_drive(sam_account, 
+                                 talloc_sub_specified((sam_account)->mem_ctx, 
+                                                        lp_logon_drive(),
+                                                        pwd->pw_name, global_myname(), 
+                                                        pwd->pw_uid, pwd->pw_gid),
+                                 PDB_DEFAULT);
+               
+               pdb_set_logon_script(sam_account, 
+                                    talloc_sub_specified((sam_account)->mem_ctx, 
+                                                           lp_logon_script(),
+                                                           pwd->pw_name, global_myname(), 
+                                                           pwd->pw_uid, pwd->pw_gid), 
+                                    PDB_DEFAULT);
+               if (!pdb_set_acct_ctrl(sam_account, ACB_NORMAL, PDB_DEFAULT)) {
+                       DEBUG(1, ("Failed to set 'normal account' flags for user %s.\n", pwd->pw_name));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       } else {
+               if (!pdb_set_acct_ctrl(sam_account, ACB_WSTRUST, PDB_DEFAULT)) {
+                       DEBUG(1, ("Failed to set 'trusted workstation account' flags for user %s.\n", pwd->pw_name));
+                       return NT_STATUS_UNSUCCESSFUL;
+               }
+       }
+       return NT_STATUS_OK;
+}
+
+
+/*************************************************************
+ Initialises a struct sam_passwd with sane values.
+ ************************************************************/
+
+NTSTATUS pdb_init_sam_pw(SAM_ACCOUNT **new_sam_acct, const struct passwd *pwd)
+{
+       NTSTATUS nt_status;
 
        if (!pwd) {
                new_sam_acct = NULL;
-               return False;
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
-       if (!pdb_init_sam(new_sam_acct)) {
+       if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam(new_sam_acct))) {
                new_sam_acct = NULL;
-               return False;
+               return nt_status;
        }
 
-       pdb_set_username(*new_sam_acct, pwd->pw_name);
-       pdb_set_fullname(*new_sam_acct, pwd->pw_gecos);
+       if (!NT_STATUS_IS_OK(nt_status = pdb_fill_sam_pw(*new_sam_acct, pwd))) {
+               pdb_free_sam(new_sam_acct);
+               new_sam_acct = NULL;
+               return nt_status;
+       }
 
-       pdb_set_uid(*new_sam_acct, pwd->pw_uid);
-       pdb_set_gid(*new_sam_acct, pwd->pw_gid);
-       
-       pdb_set_user_rid(*new_sam_acct, pdb_uid_to_user_rid(pwd->pw_uid));
+       return NT_STATUS_OK;
+}
 
-       /* call the mapping code here */
-       if(get_group_map_from_gid(pwd->pw_gid, &map, MAPPING_WITHOUT_PRIV)) {
-               sid_peek_rid(&map.sid, &rid);
-       } 
-       else {
-               rid=pdb_gid_to_group_rid(pwd->pw_gid);
-       }
-               
-       pdb_set_group_rid(*new_sam_acct, rid);
 
-       pstrcpy(str, lp_logon_path());
-       standard_sub_advanced(-1, pwd->pw_name, "", pwd->pw_gid, pwd->pw_name, str);
-       pdb_set_profile_path(*new_sam_acct, str, False);
-       
-       pstrcpy(str, lp_logon_home());
-       standard_sub_advanced(-1, pwd->pw_name, "", pwd->pw_gid, pwd->pw_name, str);
-       pdb_set_homedir(*new_sam_acct, str, False);
-       
-       pstrcpy(str, lp_logon_drive());
-       standard_sub_advanced(-1, pwd->pw_name, "", pwd->pw_gid, pwd->pw_name, str);
-       pdb_set_dir_drive(*new_sam_acct, str, False);
+/*************************************************************
+ Initialises a SAM_ACCOUNT ready to add a new account, based
+ on the unix user if possible.
+ ************************************************************/
+
+NTSTATUS pdb_init_sam_new(SAM_ACCOUNT **new_sam_acct, const char *username)
+{
+       NTSTATUS nt_status = NT_STATUS_NO_MEMORY;
 
-       pstrcpy(str, lp_logon_script());
-       standard_sub_advanced(-1, pwd->pw_name, "", pwd->pw_gid, pwd->pw_name, str);
-       pdb_set_logon_script(*new_sam_acct, str, False);
+       struct passwd *pwd;
        
-       return True;
+       pwd = Get_Pwnam(username);
+
+       if (pwd) {
+               if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam_pw(new_sam_acct, pwd))) {
+                       *new_sam_acct = NULL;
+                       return nt_status;
+               }
+       } else {
+               DOM_SID g_sid;
+               if (!NT_STATUS_IS_OK(nt_status = pdb_init_sam(new_sam_acct))) {
+                       *new_sam_acct = NULL;
+                       return nt_status;
+               }
+               if (!pdb_set_username(*new_sam_acct, username, PDB_SET)) {
+                       pdb_free_sam(new_sam_acct);
+                       return nt_status;
+               }
+
+               /* this is a hack this thing should not be set
+                  here --SSS */
+
+               /* set Domain Users by default ! */
+               sid_copy(&g_sid, get_global_sam_sid());
+               sid_append_rid(&g_sid,  DOMAIN_GROUP_RID_USERS);
+               pdb_set_group_sid(*new_sam_acct, &g_sid, PDB_SET);
+       }
+       return NT_STATUS_OK;
 }
 
 
 /**
  * Free the contets of the SAM_ACCOUNT, but not the structure.
  *
- * Also wipes the LM and NT hashes from memory.
+ * Also wipes the LM and NT hashes and plaintext password from 
+ * memory.
  *
  * @param user SAM_ACCOUNT to free members of.
  **/
 
-static BOOL pdb_free_sam_contents(SAM_ACCOUNT *user)
+static void pdb_free_sam_contents(SAM_ACCOUNT *user)
 {
-       if (user == NULL) {
-               DEBUG(0,("pdb_free_sam_contents: SAM_ACCOUNT was NULL\n"));
-#if 0
-               smb_panic("NULL pointer passed to pdb_free_sam_contents\n");
-#endif
-               return False;
-       }
 
-       /* As we start mallocing more strings this is where  
-          we should free them. */
+       /* Kill off sensitive data.  Free()ed by the
+          talloc mechinism */
 
        data_blob_clear_free(&(user->private.lm_pw));
        data_blob_clear_free(&(user->private.nt_pw));
-
-       return True;    
+       if (user->private.plaintext_pw!=NULL)
+               memset(user->private.plaintext_pw,'\0',strlen(user->private.plaintext_pw));
 }
 
 
@@ -206,25 +329,21 @@ static BOOL pdb_free_sam_contents(SAM_ACCOUNT *user)
  Reset the SAM_ACCOUNT and free the NT/LM hashes.
  ***********************************************************/
 
-BOOL pdb_reset_sam(SAM_ACCOUNT *user)
+NTSTATUS pdb_reset_sam(SAM_ACCOUNT *user)
 {
        if (user == NULL) {
                DEBUG(0,("pdb_reset_sam: SAM_ACCOUNT was NULL\n"));
 #if 0
                smb_panic("NULL pointer passed to pdb_free_sam\n");
 #endif
-               return False;
+               return NT_STATUS_UNSUCCESSFUL;
        }
        
-       if (!pdb_free_sam_contents(user)) {
-               return False;
-       }
+       pdb_free_sam_contents(user);
 
-       if (!pdb_fill_default_sam(user)) {
-               return False;
-       }
+       pdb_fill_default_sam(user);
 
-       return True;
+       return NT_STATUS_OK;
 }
 
 
@@ -232,25 +351,82 @@ BOOL pdb_reset_sam(SAM_ACCOUNT *user)
  Free the SAM_ACCOUNT and the member pointers.
  ***********************************************************/
 
-BOOL pdb_free_sam(SAM_ACCOUNT **user)
+NTSTATUS pdb_free_sam(SAM_ACCOUNT **user)
 {
        if (*user == NULL) {
                DEBUG(0,("pdb_free_sam: SAM_ACCOUNT was NULL\n"));
 #if 0
                smb_panic("NULL pointer passed to pdb_free_sam\n");
 #endif
-               return False;
+               return NT_STATUS_UNSUCCESSFUL;
        }
 
-       if (!pdb_free_sam_contents(*user)) {
-               return False;
+       pdb_free_sam_contents(*user);
+       
+       if ((*user)->free_fn) {
+               (*user)->free_fn(user);
        }
 
-       SAFE_FREE(*user);
-       
-       return True;    
+       return NT_STATUS_OK;    
 }
 
+/**************************************************************************
+ * This function will take care of all the steps needed to correctly
+ * allocate and set the user SID, please do use this function to create new
+ * users, messing with SIDs is not good.
+ *
+ * account_data must be provided initialized, pwd may be null.
+ *                                                                     SSS
+ ***************************************************************************/
+
+NTSTATUS pdb_set_sam_sids(SAM_ACCOUNT *account_data, const struct passwd *pwd)
+{
+       const char *guest_account = lp_guestaccount();
+       GROUP_MAP map;
+       
+       if (!account_data || !pwd) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       /* this is a hack this thing should not be set
+          this way --SSS */
+       if (!(guest_account && *guest_account)) {
+               DEBUG(1, ("NULL guest account!?!?\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       } else {
+               /* Ensure this *must* be set right */
+               if (strcmp(pwd->pw_name, guest_account) == 0) {
+                       if (!pdb_set_user_sid_from_rid(account_data, DOMAIN_USER_RID_GUEST, PDB_DEFAULT)) {
+                               return NT_STATUS_UNSUCCESSFUL;
+                       }
+                       if (!pdb_set_group_sid_from_rid(account_data, DOMAIN_GROUP_RID_GUESTS, PDB_DEFAULT)) {
+                               return NT_STATUS_UNSUCCESSFUL;
+                       }
+                       return NT_STATUS_OK;
+               }
+       }
+
+       if (!pdb_set_user_sid_from_rid(account_data, fallback_pdb_uid_to_user_rid(pwd->pw_uid), PDB_SET)) {
+               DEBUG(0,("Can't set User SID from RID!\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
+       /* call the mapping code here */
+       if(pdb_getgrgid(&map, pwd->pw_gid, MAPPING_WITHOUT_PRIV)) {
+               if (!pdb_set_group_sid(account_data, &map.sid, PDB_SET)){
+                       DEBUG(0,("Can't set Group SID!\n"));
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+       } 
+       else {
+               if (!pdb_set_group_sid_from_rid(account_data, pdb_gid_to_group_rid(pwd->pw_gid), PDB_SET)) {
+                       DEBUG(0,("Can't set Group SID\n"));
+                       return NT_STATUS_INVALID_PARAMETER;
+               }
+       }
+
+       return NT_STATUS_OK;
+}
 
 /**********************************************************
  Encode the account control bits into a string.
@@ -356,7 +532,7 @@ BOOL pdb_gethexpwd(const char *p, unsigned char *pwd)
 {
        int i;
        unsigned char   lonybble, hinybble;
-       char           *hexchars = "0123456789ABCDEF";
+       const char      *hexchars = "0123456789ABCDEF";
        char           *p1, *p2;
        
        if (!p)
@@ -380,63 +556,56 @@ BOOL pdb_gethexpwd(const char *p, unsigned char *pwd)
        return (True);
 }
 
-/*******************************************************************
- Group and User RID username mapping function
- ********************************************************************/
-
-BOOL pdb_name_to_rid(const char *user_name, uint32 *u_rid, uint32 *g_rid)
+static int algorithmic_rid_base(void)
 {
-       GROUP_MAP map;
-       struct passwd *pw = Get_Pwnam(user_name);
+       static int rid_offset = 0;
 
-       if (u_rid == NULL || g_rid == NULL || user_name == NULL)
-               return False;
+       if (rid_offset != 0)
+               return rid_offset;
 
-       if (!pw) {
-               DEBUG(1,("Username %s is invalid on this system\n", user_name));
-               return False;
-       }
+       rid_offset = lp_algorithmic_rid_base();
 
-       /* turn the unix UID into a Domain RID.  this is what the posix
-          sub-system does (adds 1000 to the uid) */
-       *u_rid = pdb_uid_to_user_rid(pw->pw_uid);
-
-       /* absolutely no idea what to do about the unix GID to Domain RID mapping */
-       /* map it ! */
-       if (get_group_map_from_gid(pw->pw_gid, &map, MAPPING_WITHOUT_PRIV)) {
-               sid_peek_rid(&map.sid, g_rid);
-       } else 
-               *g_rid = pdb_gid_to_group_rid(pw->pw_gid);
-
-       return True;
+       if (rid_offset < BASE_RID) {  
+               /* Try to prevent admin foot-shooting, we can't put algorithmic
+                  rids below 1000, that's the 'well known RIDs' on NT */
+               DEBUG(0, ("'algorithmic rid base' must be equal to or above %ld\n", BASE_RID));
+               rid_offset = BASE_RID;
+       }
+       if (rid_offset & 1) {
+               DEBUG(0, ("algorithmic rid base must be even\n"));
+               rid_offset += 1;
+       }
+       return rid_offset;
 }
 
 /*******************************************************************
  Converts NT user RID to a UNIX uid.
  ********************************************************************/
 
-uid_t pdb_user_rid_to_uid(uint32 user_rid)
+uid_t fallback_pdb_user_rid_to_uid(uint32 user_rid)
 {
-       return (uid_t)(((user_rid & (~USER_RID_TYPE))- 1000)/RID_MULTIPLIER);
+       int rid_offset = algorithmic_rid_base();
+       return (uid_t)(((user_rid & (~USER_RID_TYPE)) - rid_offset)/RID_MULTIPLIER);
 }
 
-
 /*******************************************************************
Converts NT group RID to a UNIX gid.
converts UNIX uid to an NT User RID.
  ********************************************************************/
 
-gid_t pdb_group_rid_to_gid(uint32 group_rid)
+uint32 fallback_pdb_uid_to_user_rid(uid_t uid)
 {
-       return (gid_t)(((group_rid & (~GROUP_RID_TYPE))- 1000)/RID_MULTIPLIER);
+       int rid_offset = algorithmic_rid_base();
+       return (((((uint32)uid)*RID_MULTIPLIER) + rid_offset) | USER_RID_TYPE);
 }
 
 /*******************************************************************
converts UNIX uid to an NT User RID.
Converts NT group RID to a UNIX gid.
  ********************************************************************/
 
-uint32 pdb_uid_to_user_rid(uid_t uid)
+gid_t pdb_group_rid_to_gid(uint32 group_rid)
 {
-       return (((((uint32)uid)*RID_MULTIPLIER) + 1000) | USER_RID_TYPE);
+       int rid_offset = algorithmic_rid_base();
+       return (gid_t)(((group_rid & (~GROUP_RID_TYPE))- rid_offset)/RID_MULTIPLIER);
 }
 
 /*******************************************************************
@@ -449,7 +618,8 @@ uint32 pdb_uid_to_user_rid(uid_t uid)
 
 uint32 pdb_gid_to_group_rid(gid_t gid)
 {
-  return (((((uint32)gid)*RID_MULTIPLIER) + 1000) | GROUP_RID_TYPE);
+       int rid_offset = algorithmic_rid_base();
+       return (((((uint32)gid)*RID_MULTIPLIER) + rid_offset) | GROUP_RID_TYPE);
 }
 
 /*******************************************************************
@@ -458,19 +628,25 @@ uint32 pdb_gid_to_group_rid(gid_t gid)
 
 static BOOL pdb_rid_is_well_known(uint32 rid)
 {
-  return (rid < 1000);
+       /* Not using rid_offset here, becouse this is the actual
+          NT fixed value (1000) */
+
+       return (rid < BASE_RID);
 }
 
 /*******************************************************************
  Decides if a RID is a user or group RID.
  ********************************************************************/
 
-BOOL pdb_rid_is_user(uint32 rid)
+BOOL fallback_pdb_rid_is_user(uint32 rid)
 {
   /* lkcl i understand that NT attaches an enumeration to a RID
    * such that it can be identified as either a user, group etc
    * type.  there are 5 such categories, and they are documented.
    */
+       /* However, they are not in the RID, just somthing you can query
+          seperatly.  Sorry luke :-) */
+
    if(pdb_rid_is_well_known(rid)) {
       /*
        * The only well known user RIDs are DOMAIN_USER_RID_ADMIN
@@ -491,126 +667,126 @@ BOOL pdb_rid_is_user(uint32 rid)
 BOOL local_lookup_sid(DOM_SID *sid, char *name, enum SID_NAME_USE *psid_name_use)
 {
        uint32 rid;
-       BOOL is_user;
+       SAM_ACCOUNT *sam_account = NULL;
+       GROUP_MAP map;
 
-       sid_peek_rid(sid, &rid);
-       is_user = pdb_rid_is_user(rid);
+       if (!sid_peek_check_rid(get_global_sam_sid(), sid, &rid)){
+               DEBUG(0,("local_sid_to_gid: sid_peek_check_rid return False! SID: %s\n",
+                       sid_string_static(&map.sid)));
+               return False;
+       }       
        *psid_name_use = SID_NAME_UNKNOWN;
-
-       DEBUG(5,("local_lookup_sid: looking up %s RID %u.\n", is_user ? "user" :
-                       "group", (unsigned int)rid));
-
-       if(is_user) {
-               if(rid == DOMAIN_USER_RID_ADMIN) {
-                       pstring admin_users;
-                       char *p = admin_users;
-                       *psid_name_use = SID_NAME_USER;
+       
+       DEBUG(5,("local_lookup_sid: looking up RID %u.\n", (unsigned int)rid));
+       
+       if (rid == DOMAIN_USER_RID_ADMIN) {
+               const char **admin_list = lp_admin_users(-1);
+               *psid_name_use = SID_NAME_USER;
+               if (admin_list) {
+                       const char *p = *admin_list;
                        if(!next_token(&p, name, NULL, sizeof(fstring)))
                                fstrcpy(name, "Administrator");
-               } else if (rid == DOMAIN_USER_RID_GUEST) {
-                       pstring guest_users;
-                       char *p = guest_users;
-                       *psid_name_use = SID_NAME_USER;
-                       if(!next_token(&p, name, NULL, sizeof(fstring)))
-                               fstrcpy(name, "Guest");
                } else {
-                       uid_t uid;
-                       struct passwd *pass;
-                       
-                       /*
-                        * Don't try to convert the rid to a name if 
-                        * running in appliance mode
-                        */
-                       if (lp_hide_local_users())
-                               return False;
+                       fstrcpy(name, "Administrator");
+               }
+               return True;
+       }
+
+       /*
+        * Don't try to convert the rid to a name if 
+        * running in appliance mode
+        */
+
+       if (lp_hide_local_users())
+               return False;
+               
+       if (!NT_STATUS_IS_OK(pdb_init_sam(&sam_account))) {
+               return False;
+       }
+       
+       /* see if the passdb can help us with the name of the user */
+       if (pdb_getsampwsid(sam_account, sid)) {
+               fstrcpy(name, pdb_get_username(sam_account));
+               *psid_name_use = SID_NAME_USER;
+
+               pdb_free_sam(&sam_account);
                        
-                       uid = pdb_user_rid_to_uid(rid);
-                       pass = sys_getpwuid(uid);
+               return True;
+       }
 
-                       *psid_name_use = SID_NAME_USER;
+       pdb_free_sam(&sam_account);
+               
+       if (pdb_getgrsid(&map, *sid, MAPPING_WITHOUT_PRIV)) {
+               if (map.gid!=(gid_t)-1) {
+                       DEBUG(5,("local_lookup_sid: mapped group %s to gid %u\n", map.nt_name, (unsigned int)map.gid));
+               } else {
+                       DEBUG(5,("local_lookup_sid: mapped group %s to no unix gid.  Returning name.\n", map.nt_name));
+               }
 
-                       DEBUG(5,("local_lookup_sid: looking up uid %u %s\n", (unsigned int)uid,
-                               pass ? "succeeded" : "failed" ));
+               fstrcpy(name, map.nt_name);
+               *psid_name_use = map.sid_name_use;
+               return True;
+       }
 
-                       if(!pass) {
-                               slprintf(name, sizeof(fstring)-1, "unix_user.%u", (unsigned int)uid);
-                               return True;
-                       }
+       if (fallback_pdb_rid_is_user(rid)) {
+               uid_t uid;
 
-                       fstrcpy(name, pass->pw_name);
+               DEBUG(5, ("assuming RID %u is a user\n", (unsigned)rid));
 
-                       DEBUG(5,("local_lookup_sid: found user %s for rid %u\n", name,
-                               (unsigned int)rid ));
-               }
+                       uid = fallback_pdb_user_rid_to_uid(rid);
+               slprintf(name, sizeof(fstring)-1, "unix_user.%u", (unsigned int)uid);   
 
+               return False;  /* Indicates that this user was 'not mapped' */
        } else {
                gid_t gid;
                struct group *gr; 
-               GROUP_MAP map;
-               
-               /* 
-                * Don't try to convert the rid to a name if running
-                * in appliance mode
-                */
-               
-               if (lp_hide_local_users()) 
-                       return False;
+                       
+               DEBUG(5, ("assuming RID %u is a group\n", (unsigned)rid));
 
-               /* check if it's a mapped group */
-               if (get_group_map_from_sid(*sid, &map, MAPPING_WITHOUT_PRIV)) {
-                       if (map.gid!=-1) {
-                               DEBUG(5,("local_lookup_sid: mapped group %s to gid %u\n", map.nt_name, (unsigned int)map.gid));
-                               fstrcpy(name, map.nt_name);
-                               *psid_name_use = map.sid_name_use;
-                               return True;
-                       }
-               }
-               
                gid = pdb_group_rid_to_gid(rid);
                gr = getgrgid(gid);
-
+                       
                *psid_name_use = SID_NAME_ALIAS;
-
+                       
                DEBUG(5,("local_lookup_sid: looking up gid %u %s\n", (unsigned int)gid,
-                       gr ? "succeeded" : "failed" ));
-
+                        gr ? "succeeded" : "failed" ));
+                       
                if(!gr) {
                        slprintf(name, sizeof(fstring)-1, "unix_group.%u", (unsigned int)gid);
-                       return False;
+                       return False; /* Indicates that this group was 'not mapped' */
                }
-
+                       
                fstrcpy( name, gr->gr_name);
-
+                       
                DEBUG(5,("local_lookup_sid: found group %s for rid %u\n", name,
-                       (unsigned int)rid ));
+                        (unsigned int)rid ));
+               return True;   
        }
-
-       return True;
 }
 
 /*******************************************************************
  Convert a name into a SID. Used in the lookup name rpc.
  ********************************************************************/
 
-BOOL local_lookup_name(const char *c_domain, const char *c_user, DOM_SID *psid, enum SID_NAME_USE *psid_name_use)
+BOOL local_lookup_name(const char *c_user, DOM_SID *psid, enum SID_NAME_USE *psid_name_use)
 {
        extern DOM_SID global_sid_World_Domain;
-       struct passwd *pass = NULL;
        DOM_SID local_sid;
        fstring user;
-       fstring domain;
-
+       SAM_ACCOUNT *sam_account = NULL;
+       struct group *grp;
+       GROUP_MAP map;
+               
        *psid_name_use = SID_NAME_UNKNOWN;
 
        /*
-        * domain and user may be quoted const strings, and map_username and
-        * friends can modify them. Make a modifiable copy. JRA.
+        * user may be quoted a const string, and map_username and
+        * friends can modify it. Make a modifiable copy. JRA.
         */
 
-       fstrcpy(domain, c_domain);
        fstrcpy(user, c_user);
 
-       sid_copy(&local_sid, &global_sam_sid);
+       sid_copy(&local_sid, get_global_sam_sid());
 
        /*
         * Special case for MACHINE\Everyone. Map to the world_sid.
@@ -631,313 +807,64 @@ BOOL local_lookup_name(const char *c_domain, const char *c_user, DOM_SID *psid,
 
        (void)map_username(user);
 
-       if((pass = Get_Pwnam(user))) {
-               sid_append_rid( &local_sid, pdb_uid_to_user_rid(pass->pw_uid));
-               *psid_name_use = SID_NAME_USER;
-       } else {
-               /*
-                * Maybe it was a group ?
-                */
-               struct group *grp;
-               GROUP_MAP map;
-               
-               /* check if it's a mapped group */
-               if (get_group_map_from_ntname(user, &map, MAPPING_WITHOUT_PRIV)) {
-                       if (map.gid!=-1) {
-                               /* yes it's a mapped group to a valid unix group */
-                               sid_copy(&local_sid, &map.sid);
-                               *psid_name_use = map.sid_name_use;
-                       }
-                       else
-                               /* it's a correct name but not mapped so it points to nothing*/
-                               return False;
-               } else {
-                       /* it's not a mapped group */
-                       grp = getgrnam(user);
-                       if(!grp)
-                               return False;
-
-                       /* 
-                        *check if it's mapped, if it is reply it doesn't exist
-                        *
-                        * that's to prevent this case:
-                        *
-                        * unix group ug is mapped to nt group ng
-                        * someone does a lookup on ug
-                        * we must not reply as it doesn't "exist" anymore
-                        * for NT. For NT only ng exists.
-                        * JFM, 30/11/2001
-                        */
-                       
-                       if(get_group_map_from_gid(grp->gr_gid, &map, MAPPING_WITHOUT_PRIV)){
-                               return False;
-                       }
-
-                       sid_append_rid( &local_sid, pdb_gid_to_group_rid(grp->gr_gid));
-                       *psid_name_use = SID_NAME_ALIAS;
-               }
-       }
-
-       sid_copy( psid, &local_sid);
-
-       return True;
-}
-
-/****************************************************************************
- Convert a uid to SID - locally.
-****************************************************************************/
-
-DOM_SID *local_uid_to_sid(DOM_SID *psid, uid_t uid)
-{
-       extern DOM_SID global_sam_sid;
-
-       sid_copy(psid, &global_sam_sid);
-       sid_append_rid(psid, pdb_uid_to_user_rid(uid));
-
-       return psid;
-}
-
-/****************************************************************************
- Convert a SID to uid - locally.
-****************************************************************************/
-
-BOOL local_sid_to_uid(uid_t *puid, DOM_SID *psid, enum SID_NAME_USE *name_type)
-{
-       extern DOM_SID global_sam_sid;
-
-       DOM_SID dom_sid;
-       uint32 rid;
-       fstring str;
-       struct passwd *pass;
-
-       *name_type = SID_NAME_UNKNOWN;
-
-       sid_copy(&dom_sid, psid);
-       sid_split_rid(&dom_sid, &rid);
-
-       if (!pdb_rid_is_user(rid))
-               return False;
-
-       /*
-        * We can only convert to a uid if this is our local
-        * Domain SID (ie. we are the controling authority).
-        */
-       if (!sid_equal(&global_sam_sid, &dom_sid))
+       if (!NT_STATUS_IS_OK(pdb_init_sam(&sam_account))) {
                return False;
-
-       *puid = pdb_user_rid_to_uid(rid);
-
-       /*
-        * Ensure this uid really does exist.
-        */
-       if(!(pass = sys_getpwuid(*puid)))
-               return False;
-
-       DEBUG(10,("local_sid_to_uid: SID %s -> uid (%u) (%s).\n", sid_to_string( str, psid),
-               (unsigned int)*puid, pass->pw_name ));
-
-       *name_type = SID_NAME_USER;
-
-       return True;
-}
-
-/****************************************************************************
- Convert a gid to SID - locally.
-****************************************************************************/
-
-DOM_SID *local_gid_to_sid(DOM_SID *psid, gid_t gid)
-{
-       extern DOM_SID global_sam_sid;
-       GROUP_MAP map;
-
-       sid_copy(psid, &global_sam_sid);
-       
-       if (get_group_map_from_gid(gid, &map, MAPPING_WITHOUT_PRIV)) {
-               sid_copy(psid, &map.sid);
        }
-       else {
-               sid_append_rid(psid, pdb_gid_to_group_rid(gid));
+       
+       if (pdb_getsampwnam(sam_account, user)) {
+               sid_copy(psid, pdb_get_user_sid(sam_account));
+               *psid_name_use = SID_NAME_USER;
+               
+               pdb_free_sam(&sam_account);
+               return True;
        }
 
-       return psid;
-}
-
-/****************************************************************************
- Convert a SID to gid - locally.
-****************************************************************************/
-
-BOOL local_sid_to_gid(gid_t *pgid, DOM_SID *psid, enum SID_NAME_USE *name_type)
-{
-       extern DOM_SID global_sam_sid;
-       DOM_SID dom_sid;
-       uint32 rid;
-       fstring str;
-       struct group *grp;
-       GROUP_MAP map;
-
-       *name_type = SID_NAME_UNKNOWN;
-
-       sid_copy(&dom_sid, psid);
-       sid_split_rid(&dom_sid, &rid);
+       pdb_free_sam(&sam_account);
 
        /*
-        * We can only convert to a gid if this is our local
-        * Domain SID (ie. we are the controling authority).
-        *
-        * Or in the Builtin SID too. JFM, 11/30/2001
+        * Maybe it was a group ?
         */
 
-       if (!sid_equal(&global_sam_sid, &dom_sid))
-               return False;
-
-       if (pdb_rid_is_user(rid))
-               return False;
-
-       if (get_group_map_from_sid(*psid, &map, MAPPING_WITHOUT_PRIV)) {
+       /* check if it's a mapped group */
+       if (pdb_getgrnam(&map, user, MAPPING_WITHOUT_PRIV)) {
+               /* yes it's a mapped group */
+               sid_copy(&local_sid, &map.sid);
+               *psid_name_use = map.sid_name_use;
+       } else {
+               /* it's not a mapped group */
+               grp = getgrnam(user);
+               if(!grp)
+                       return False;
+               
+               /* 
+                *check if it's mapped, if it is reply it doesn't exist
+                *
+                * that's to prevent this case:
+                *
+                * unix group ug is mapped to nt group ng
+                * someone does a lookup on ug
+                * we must not reply as it doesn't "exist" anymore
+                * for NT. For NT only ng exists.
+                * JFM, 30/11/2001
+                */
                
-               /* the SID is in the mapping table but not mapped */
-               if (map.gid==-1)
+               if (pdb_getgrgid(&map, grp->gr_gid, MAPPING_WITHOUT_PRIV)){
                        return False;
-
-               sid_peek_rid(&map.sid, &rid);
-               *pgid = rid;
-               *name_type = map.sid_name_use;
-       } else {
-               *pgid = pdb_group_rid_to_gid(rid);
-               *name_type = SID_NAME_ALIAS;
+               }
+               
+               sid_append_rid( &local_sid, pdb_gid_to_group_rid(grp->gr_gid));
+               *psid_name_use = SID_NAME_ALIAS;
        }
 
-       /*
-        * Ensure this gid really does exist.
-        */
-
-       if(!(grp = getgrgid(*pgid)))
-               return False;
-
-       DEBUG(10,("local_sid_to_gid: SID %s -> gid (%u) (%s).\n", sid_to_string( str, psid),
-               (unsigned int)*pgid, grp->gr_name ));
+       sid_copy( psid, &local_sid);
 
        return True;
 }
 
-/** 
- * Quick hack to do an easy ucs2 -> mulitbyte conversion 
- * @return static buffer containing the converted string
- **/
-
-static char *pdb_convert(const UNISTR2 *from)
-{
-       static pstring convert_buffer;
-       *convert_buffer = 0;
-       if (!from) {
-               return convert_buffer;
-       }
-
-       unistr2_to_ascii(convert_buffer, from, sizeof(pstring));
-       return convert_buffer;
-}
-
-/*************************************************************
- Copies a SAM_USER_INFO_23 to a SAM_ACCOUNT
- **************************************************************/
-
-void copy_id23_to_sam_passwd(SAM_ACCOUNT *to, SAM_USER_INFO_23 *from)
-{
-
-       if (from == NULL || to == NULL) 
-               return;
-
-       pdb_set_logon_time(to,nt_time_to_unix(&from->logon_time));
-       pdb_set_logoff_time(to,nt_time_to_unix(&from->logoff_time));
-       pdb_set_kickoff_time(to, nt_time_to_unix(&from->kickoff_time));
-       pdb_set_pass_last_set_time(to, nt_time_to_unix(&from->pass_last_set_time));
-       pdb_set_pass_can_change_time(to, nt_time_to_unix(&from->pass_can_change_time));
-       pdb_set_pass_must_change_time(to, nt_time_to_unix(&from->pass_must_change_time));
-
-       pdb_set_username(to      , pdb_convert(&from->uni_user_name   ));
-       pdb_set_fullname(to      , pdb_convert(&from->uni_full_name   ));
-       pdb_set_homedir(to       , pdb_convert(&from->uni_home_dir    ), True);
-       pdb_set_dir_drive(to     , pdb_convert(&from->uni_dir_drive   ), True);
-       pdb_set_logon_script(to  , pdb_convert(&from->uni_logon_script), True);
-       pdb_set_profile_path(to  , pdb_convert(&from->uni_profile_path), True);
-       pdb_set_acct_desc(to     , pdb_convert(&from->uni_acct_desc   ));
-       pdb_set_workstations(to  , pdb_convert(&from->uni_workstations));
-       pdb_set_unknown_str(to   , pdb_convert(&from->uni_unknown_str ));
-       pdb_set_munged_dial(to   , pdb_convert(&from->uni_munged_dial ));
-
-       if (from->user_rid)
-               pdb_set_user_rid(to, from->user_rid);
-       if (from->group_rid)
-               pdb_set_group_rid(to, from->group_rid);
-
-       pdb_set_acct_ctrl(to, from->acb_info);
-       pdb_set_unknown_3(to, from->unknown_3);
-
-       pdb_set_logon_divs(to, from->logon_divs);
-       pdb_set_hours_len(to, from->logon_hrs.len);
-       pdb_set_hours(to, from->logon_hrs.hours);
-
-       pdb_set_unknown_5(to, from->unknown_5);
-       pdb_set_unknown_6(to, from->unknown_6);
-}
-
-
-/*************************************************************
- Copies a sam passwd.
- **************************************************************/
-
-void copy_id21_to_sam_passwd(SAM_ACCOUNT *to, SAM_USER_INFO_21 *from)
-{
-       if (from == NULL || to == NULL) 
-               return;
-
-       pdb_set_logon_time(to,nt_time_to_unix(&from->logon_time));
-       pdb_set_logoff_time(to,nt_time_to_unix(&from->logoff_time));
-       pdb_set_kickoff_time(to, nt_time_to_unix(&from->kickoff_time));
-       pdb_set_pass_last_set_time(to, nt_time_to_unix(&from->pass_last_set_time));
-       pdb_set_pass_can_change_time(to, nt_time_to_unix(&from->pass_can_change_time));
-       pdb_set_pass_must_change_time(to, nt_time_to_unix(&from->pass_must_change_time));
-
-       pdb_set_username(to      , pdb_convert(&from->uni_user_name   ));
-       pdb_set_fullname(to      , pdb_convert(&from->uni_full_name   ));
-       pdb_set_homedir(to       , pdb_convert(&from->uni_home_dir    ), True);
-       pdb_set_dir_drive(to     , pdb_convert(&from->uni_dir_drive   ), True);
-       pdb_set_logon_script(to  , pdb_convert(&from->uni_logon_script), True);
-       pdb_set_profile_path(to  , pdb_convert(&from->uni_profile_path), True);
-       pdb_set_acct_desc(to     , pdb_convert(&from->uni_acct_desc   ));
-       pdb_set_workstations(to  , pdb_convert(&from->uni_workstations));
-       pdb_set_unknown_str(to   , pdb_convert(&from->uni_unknown_str ));
-       pdb_set_munged_dial(to   , pdb_convert(&from->uni_munged_dial ));
-
-       if (from->user_rid)
-               pdb_set_user_rid(to, from->user_rid);
-       if (from->group_rid)
-               pdb_set_group_rid(to, from->group_rid);
-
-       /* FIXME!!  Do we need to copy the passwords here as well?
-          I don't know.  Need to figure this out   --jerry */
-
-       /* Passwords dealt with in caller --abartlet */
-
-       pdb_set_acct_ctrl(to, from->acb_info);
-       pdb_set_unknown_3(to, from->unknown_3);
-
-       pdb_set_logon_divs(to, from->logon_divs);
-       pdb_set_hours_len(to, from->logon_hrs.len);
-       pdb_set_hours(to, from->logon_hrs.hours);
-
-       pdb_set_unknown_5(to, from->unknown_5);
-       pdb_set_unknown_6(to, from->unknown_6);
-}
-
-
 /*************************************************************
  Change a password entry in the local smbpasswd file.
 
- FIXME!!  The function needs to be abstracted into the
- passdb interface or something.  It is currently being called
- by _api_samr_create_user() in rpc_server/srv_samr.c,
- in SWAT and by smbpasswd/pdbedit.
+It is currently being called by SWAT and by smbpasswd.
  
  --jerry
  *************************************************************/
@@ -947,8 +874,8 @@ BOOL local_password_change(const char *user_name, int local_flags,
                           char *err_str, size_t err_str_len,
                           char *msg_str, size_t msg_str_len)
 {
-       struct passwd  *pwd = NULL;
        SAM_ACCOUNT     *sam_pass=NULL;
+       uint16 other_acb;
 
        *err_str = '\0';
        *msg_str = '\0';
@@ -958,51 +885,41 @@ BOOL local_password_change(const char *user_name, int local_flags,
        if(!pdb_getsampwnam(sam_pass, user_name)) {
                pdb_free_sam(&sam_pass);
                
-               if (local_flags & LOCAL_ADD_USER) {
-                       /*
-                        * Check for a local account - if we're adding only.
-                        */
-                       
-                       if(!(pwd = sys_getpwnam(user_name))) {
-                               slprintf(err_str, err_str_len - 1, "User %s does not \
-exist in system password file (usually /etc/passwd). Cannot add \
-account without a valid local system user.\n", user_name);
+               if ((local_flags & LOCAL_ADD_USER) || (local_flags & LOCAL_DELETE_USER)) {
+                       /* Might not exist in /etc/passwd */
+                       if (!NT_STATUS_IS_OK(pdb_init_sam_new(&sam_pass, user_name))) {
+                               slprintf(err_str, err_str_len-1, "Failed initialise SAM_ACCOUNT for user %s.\n", user_name);
                                return False;
                        }
                } else {
                        slprintf(err_str, err_str_len-1,"Failed to find entry for user %s.\n", user_name);
                        return False;
                }
+       } else {
+               /* the entry already existed */
+               local_flags &= ~LOCAL_ADD_USER;
+       }
 
-               if (!pdb_init_sam_pw(&sam_pass, pwd)) {
-                       slprintf(err_str, err_str_len-1, "Failed initialise SAM_ACCOUNT for user %s.\n", user_name);
+       /* the 'other' acb bits not being changed here */
+       other_acb =  (pdb_get_acct_ctrl(sam_pass) & (!(ACB_WSTRUST|ACB_DOMTRUST|ACB_SVRTRUST|ACB_NORMAL)));
+       if (local_flags & LOCAL_TRUST_ACCOUNT) {
+               if (!pdb_set_acct_ctrl(sam_pass, ACB_WSTRUST | other_acb, PDB_CHANGED) ) {
+                       slprintf(err_str, err_str_len - 1, "Failed to set 'trusted workstation account' flags for user %s.\n", user_name);
+                       pdb_free_sam(&sam_pass);
                        return False;
                }
-
-       
-               if (local_flags & LOCAL_TRUST_ACCOUNT) {
-                       if (!pdb_set_acct_ctrl(sam_pass, ACB_WSTRUST)) {
-                               slprintf(err_str, err_str_len - 1, "Failed to set 'trusted workstation account' flags for user %s.\n", user_name);
-                               pdb_free_sam(&sam_pass);
-                               return False;
-                       }
-               } else if (local_flags & LOCAL_INTERDOM_ACCOUNT) {
-                       if (!pdb_set_acct_ctrl(sam_pass, ACB_DOMTRUST)) {
-                               slprintf(err_str, err_str_len - 1, "Failed to set 'domain trust account' flags for user %s.\n", user_name);
-                               pdb_free_sam(&sam_pass);
-                               return False;
-                       }
-               } else {
-                       if (!pdb_set_acct_ctrl(sam_pass, ACB_NORMAL)) {
-                               slprintf(err_str, err_str_len - 1, "Failed to set 'normal account' flags for user %s.\n", user_name);
-                               pdb_free_sam(&sam_pass);
-                               return False;
-                       }
+       } else if (local_flags & LOCAL_INTERDOM_ACCOUNT) {
+               if (!pdb_set_acct_ctrl(sam_pass, ACB_DOMTRUST | other_acb, PDB_CHANGED)) {
+                       slprintf(err_str, err_str_len - 1, "Failed to set 'domain trust account' flags for user %s.\n", user_name);
+                       pdb_free_sam(&sam_pass);
+                       return False;
                }
-
        } else {
-               /* the entry already existed */
-               local_flags &= ~LOCAL_ADD_USER;
+               if (!pdb_set_acct_ctrl(sam_pass, ACB_NORMAL | other_acb, PDB_CHANGED)) {
+                       slprintf(err_str, err_str_len - 1, "Failed to set 'normal account' flags for user %s.\n", user_name);
+                       pdb_free_sam(&sam_pass);
+                       return False;
+               }
        }
 
        /*
@@ -1011,13 +928,13 @@ account without a valid local system user.\n", user_name);
         */
 
        if (local_flags & LOCAL_DISABLE_USER) {
-               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)|ACB_DISABLED)) {
+               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)|ACB_DISABLED, PDB_CHANGED)) {
                        slprintf(err_str, err_str_len-1, "Failed to set 'disabled' flag for user %s.\n", user_name);
                        pdb_free_sam(&sam_pass);
                        return False;
                }
        } else if (local_flags & LOCAL_ENABLE_USER) {
-               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)&(~ACB_DISABLED))) {
+               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)&(~ACB_DISABLED), PDB_CHANGED)) {
                        slprintf(err_str, err_str_len-1, "Failed to unset 'disabled' flag for user %s.\n", user_name);
                        pdb_free_sam(&sam_pass);
                        return False;
@@ -1025,7 +942,7 @@ account without a valid local system user.\n", user_name);
        }
        
        if (local_flags & LOCAL_SET_NO_PASSWORD) {
-               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)|ACB_PWNOTREQ)) {
+               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)|ACB_PWNOTREQ, PDB_CHANGED)) {
                        slprintf(err_str, err_str_len-1, "Failed to set 'no password required' flag for user %s.\n", user_name);
                        pdb_free_sam(&sam_pass);
                        return False;
@@ -1041,13 +958,13 @@ account without a valid local system user.\n", user_name);
                 * don't create them disabled). JRA.
                 */
                if ((pdb_get_lanman_passwd(sam_pass)==NULL) && (pdb_get_acct_ctrl(sam_pass)&ACB_DISABLED)) {
-                       if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)&(~ACB_DISABLED))) {
+                       if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)&(~ACB_DISABLED), PDB_CHANGED)) {
                                slprintf(err_str, err_str_len-1, "Failed to unset 'disabled' flag for user %s.\n", user_name);
                                pdb_free_sam(&sam_pass);
                                return False;
                        }
                }
-               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)&(~ACB_PWNOTREQ))) {
+               if (!pdb_set_acct_ctrl (sam_pass, pdb_get_acct_ctrl(sam_pass)&(~ACB_PWNOTREQ), PDB_CHANGED)) {
                        slprintf(err_str, err_str_len-1, "Failed to unset 'no password required' flag for user %s.\n", user_name);
                        pdb_free_sam(&sam_pass);
                        return False;
@@ -1071,14 +988,14 @@ account without a valid local system user.\n", user_name);
                        return False;
                }
        } else if (local_flags & LOCAL_DELETE_USER) {
-               if (!pdb_delete_sam_account(user_name)) {
+               if (!pdb_delete_sam_account(sam_pass)) {
                        slprintf(err_str,err_str_len-1, "Failed to delete entry for user %s.\n", user_name);
                        pdb_free_sam(&sam_pass);
                        return False;
                }
                slprintf(msg_str, msg_str_len-1, "Deleted user %s.\n", user_name);
        } else {
-               if(!pdb_update_sam_account(sam_pass, True)) {
+               if(!pdb_update_sam_account(sam_pass)) {
                        slprintf(err_str, err_str_len-1, "Failed to modify entry for user %s.\n", user_name);
                        pdb_free_sam(&sam_pass);
                        return False;
@@ -1094,34 +1011,3 @@ account without a valid local system user.\n", user_name);
        pdb_free_sam(&sam_pass);
        return True;
 }
-
-/***************************************************************************
- Search by uid.  Wrapper around pdb_getsampwnam()
- **************************************************************************/
-
-BOOL pdb_getsampwuid (SAM_ACCOUNT* user, uid_t uid)
-{
-       struct passwd   *pw;
-       fstring         name;
-
-       if (user==NULL) {
-               DEBUG(0,("pdb_getsampwuid: SAM_ACCOUNT is NULL.\n"));
-               return False;
-       }
-
-       /*
-        * Never trust the uid in the passdb.  Lookup the username first
-        * and then lokup the user by name in the sam.
-        */
-        
-       if ((pw=sys_getpwuid(uid)) == NULL)  {
-               DEBUG(0,("pdb_getsampwuid: getpwuid(%d) return NULL. User does not exist in Unix accounts!\n", uid));
-               return False;
-       }
-       
-       fstrcpy (name, pw->pw_name);
-
-       return pdb_getsampwnam (user, name);
-
-}
-