s3: Add a zfsacl:denymissingspecial parameter

[ira/wip.git] / source3 / modules / vfs_zfsacl.c

diff --git a/source3/modules/vfs_zfsacl.c b/source3/modules/vfs_zfsacl.c
index 650666e921b97c21fe98a662340d686fa067678b..a3de30e8085a3c65d50c7320472ebd9bf54810ab 100644 (file)
--- a/source3/modules/vfs_zfsacl.c
+++ b/source3/modules/vfs_zfsacl.c
@@ -106,6 +106,7 @@ static bool zfs_process_smbacl(files_struct *fsp, SMB4ACL_T *smbacl)
        ace_t *acebuf;
        SMB4ACE_T *smbace;
        TALLOC_CTX      *mem_ctx;
+       bool have_special_id = false;
 
        /* allocate the field of ZFS aces */
        mem_ctx = talloc_tos();
@@ -140,19 +141,28 @@ static bool zfs_process_smbacl(files_struct *fsp, SMB4ACL_T *smbacl)
                                        aceprop->who.special_id));
                                continue; /* don't add it !!! */
                        }
+                       have_special_id = true;
                }
        }
+
+       if (!have_special_id
+           && lp_parm_bool(fsp->conn->params->service, "zfsacl",
+                           "denymissingspecial", false)) {
+               errno = EACCES;
+               return false;
+       }
+
        SMB_ASSERT(i == naces);
 
        /* store acl */
-       if(acl(fsp->fsp_name, ACE_SETACL, naces, acebuf)) {
+       if(acl(fsp->fsp_name->base_name, ACE_SETACL, naces, acebuf)) {
                if(errno == ENOSYS) {
                        DEBUG(9, ("acl(ACE_SETACL, %s): Operation is not "
                                  "supported on the filesystem where the file "
-                                 "reside", fsp->fsp_name));
+                                 "reside", fsp_str_dbg(fsp)));
                } else {
-                       DEBUG(9, ("acl(ACE_SETACL, %s): %s ", fsp->fsp_name,
-                                       strerror(errno)));
+                       DEBUG(9, ("acl(ACE_SETACL, %s): %s ", fsp_str_dbg(fsp),
+                                 strerror(errno)));
                }
                return 0;
        }
@@ -180,7 +190,8 @@ static NTSTATUS zfsacl_fget_nt_acl(struct vfs_handle_struct *handle,
        SMB4ACL_T *pacl;
        NTSTATUS status;
 
-       status = zfs_get_nt_acl_common(fsp->fsp_name, security_info, &pacl);
+       status = zfs_get_nt_acl_common(fsp->fsp_name->base_name, security_info,
+                                      &pacl);
        if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
@@ -261,55 +272,38 @@ int zfsacl_fail__sys_acl_set_file(vfs_handle_struct *handle,
                                  SMB_ACL_TYPE_T type,
                                  SMB_ACL_T theacl)
 {
-       return(-1);
+       return -1;
 }
 
 int zfsacl_fail__sys_acl_set_fd(vfs_handle_struct *handle,
                                files_struct *fsp,
                                int fd, SMB_ACL_T theacl)
 {
-       return(-1);
+       return -1;
 }
 
 int zfsacl_fail__sys_acl_delete_def_file(vfs_handle_struct *handle,
                                         const char *path)
 {
-       return(-1);
+       return -1;
 }
 
 /* VFS operations structure */
 
-static vfs_op_tuple zfsacl_ops[] = {
-       /* invalidate conflicting VFS methods */
-       {SMB_VFS_OP(zfsacl_fail__sys_acl_get_file),
-        SMB_VFS_OP_SYS_ACL_GET_FILE,
-        SMB_VFS_LAYER_OPAQUE},
-       {SMB_VFS_OP(zfsacl_fail__sys_acl_get_fd),
-        SMB_VFS_OP_SYS_ACL_GET_FD,
-        SMB_VFS_LAYER_OPAQUE},
-       {SMB_VFS_OP(zfsacl_fail__sys_acl_set_file),
-        SMB_VFS_OP_SYS_ACL_SET_FILE,
-        SMB_VFS_LAYER_OPAQUE},
-       {SMB_VFS_OP(zfsacl_fail__sys_acl_set_fd),
-        SMB_VFS_OP_SYS_ACL_SET_FD,
-        SMB_VFS_LAYER_OPAQUE},
-       {SMB_VFS_OP(zfsacl_fail__sys_acl_delete_def_file),
-        SMB_VFS_OP_SYS_ACL_DELETE_DEF_FILE,
-        SMB_VFS_LAYER_OPAQUE},
-
-       /* actual methods */
-       {SMB_VFS_OP(zfsacl_fget_nt_acl), SMB_VFS_OP_FGET_NT_ACL,
-        SMB_VFS_LAYER_OPAQUE},
-       {SMB_VFS_OP(zfsacl_get_nt_acl), SMB_VFS_OP_GET_NT_ACL,
-        SMB_VFS_LAYER_OPAQUE},
-       {SMB_VFS_OP(zfsacl_fset_nt_acl), SMB_VFS_OP_FSET_NT_ACL,
-        SMB_VFS_LAYER_OPAQUE},
-       {SMB_VFS_OP(NULL), SMB_VFS_OP_NOOP, SMB_VFS_LAYER_NOOP}
+static struct vfs_fn_pointers zfsacl_fns = {
+       .sys_acl_get_file = zfsacl_fail__sys_acl_get_file,
+       .sys_acl_get_fd = zfsacl_fail__sys_acl_get_fd,
+       .sys_acl_set_file = zfsacl_fail__sys_acl_set_file,
+       .sys_acl_set_fd = zfsacl_fail__sys_acl_set_fd,
+       .sys_acl_delete_def_file = zfsacl_fail__sys_acl_delete_def_file,
+       .fget_nt_acl = zfsacl_fget_nt_acl,
+       .get_nt_acl = zfsacl_get_nt_acl,
+       .fset_nt_acl = zfsacl_fset_nt_acl,
 };
 
 NTSTATUS vfs_zfsacl_init(void);
 NTSTATUS vfs_zfsacl_init(void)
 {
        return smb_register_vfs(SMB_VFS_INTERFACE_VERSION, "zfsacl",
-                               zfsacl_ops);
+                               &zfsacl_fns);
 }