Fix a scary "fill_share_mode_lock failed" message
[ira/wip.git] / source3 / locking / locking.c
index dc1d6071559ca1d3dc332d6c8f9898c938e61c0b..70841225a70db04dc54e4f75f10b538997e3e2ec 100644 (file)
@@ -7,7 +7,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
@@ -16,8 +16,7 @@
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
    Revision History:
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_LOCKING
 
+#define NO_LOCKING_COUNT (-1)
+
 /* the locking database handle */
-static TDB_CONTEXT *tdb;
+static struct db_context *lock_db;
 
 /****************************************************************************
  Debugging aids :-).
@@ -74,77 +75,97 @@ const char *lock_flav_name(enum brl_flavour lock_flav)
  Called in the read/write codepath.
 ****************************************************************************/
 
-BOOL is_locked(files_struct *fsp,
-               uint32 smbpid,
-               SMB_BIG_UINT count,
-               SMB_BIG_UINT offset, 
-               enum brl_type lock_type)
+void init_strict_lock_struct(files_struct *fsp,
+                               uint32 smbpid,
+                               br_off start,
+                               br_off size,
+                               enum brl_type lock_type,
+                               struct lock_struct *plock)
+{
+       SMB_ASSERT(lock_type == READ_LOCK || lock_type == WRITE_LOCK);
+
+       plock->context.smbpid = smbpid;
+        plock->context.tid = fsp->conn->cnum;
+        plock->context.pid = procid_self();
+        plock->start = start;
+        plock->size = size;
+        plock->fnum = fsp->fnum;
+        plock->lock_type = lock_type;
+        plock->lock_flav = lp_posix_cifsu_locktype(fsp);
+}
+
+bool strict_lock_default(files_struct *fsp, struct lock_struct *plock)
 {
        int strict_locking = lp_strict_locking(fsp->conn->params);
-       enum brl_flavour lock_flav = lp_posix_cifsu_locktype(fsp);
-       BOOL ret = True;
-       
-       if (count == 0) {
-               return False;
+       bool ret = False;
+
+       if (plock->size == 0) {
+               return True;
        }
 
        if (!lp_locking(fsp->conn->params) || !strict_locking) {
-               return False;
+               return True;
        }
 
        if (strict_locking == Auto) {
-               if  (EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type) && (lock_type == READ_LOCK || lock_type == WRITE_LOCK)) {
+               if  (EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type) && (plock->lock_type == READ_LOCK || plock->lock_type == WRITE_LOCK)) {
                        DEBUG(10,("is_locked: optimisation - exclusive oplock on file %s\n", fsp->fsp_name ));
-                       ret = False;
+                       ret = True;
                } else if ((fsp->oplock_type == LEVEL_II_OPLOCK) &&
-                          (lock_type == READ_LOCK)) {
+                          (plock->lock_type == READ_LOCK)) {
                        DEBUG(10,("is_locked: optimisation - level II oplock on file %s\n", fsp->fsp_name ));
-                       ret = False;
+                       ret = True;
                } else {
-                       struct byte_range_lock *br_lck = brl_get_locks_readonly(NULL, fsp);
+                       struct byte_range_lock *br_lck = brl_get_locks_readonly(talloc_tos(), fsp);
                        if (!br_lck) {
-                               return False;
+                               return True;
                        }
-                       ret = !brl_locktest(br_lck,
-                                       smbpid,
-                                       procid_self(),
-                                       offset,
-                                       count,
-                                       lock_type,
-                                       lock_flav);
+                       ret = brl_locktest(br_lck,
+                                       plock->context.smbpid,
+                                       plock->context.pid,
+                                       plock->start,
+                                       plock->size,
+                                       plock->lock_type,
+                                       plock->lock_flav);
                        TALLOC_FREE(br_lck);
                }
        } else {
-               struct byte_range_lock *br_lck = brl_get_locks_readonly(NULL, fsp);
+               struct byte_range_lock *br_lck = brl_get_locks_readonly(talloc_tos(), fsp);
                if (!br_lck) {
-                       return False;
+                       return True;
                }
-               ret = !brl_locktest(br_lck,
-                               smbpid,
-                               procid_self(),
-                               offset,
-                               count,
-                               lock_type,
-                               lock_flav);
+               ret = brl_locktest(br_lck,
+                               plock->context.smbpid,
+                               plock->context.pid,
+                               plock->start,
+                               plock->size,
+                               plock->lock_type,
+                               plock->lock_flav);
                TALLOC_FREE(br_lck);
        }
 
-       DEBUG(10,("is_locked: flavour = %s brl start=%.0f len=%.0f %s for fnum %d file %s\n",
-                       lock_flav_name(lock_flav),
-                       (double)offset, (double)count, ret ? "locked" : "unlocked",
-                       fsp->fnum, fsp->fsp_name ));
+       DEBUG(10,("strict_lock_default: flavour = %s brl start=%.0f "
+                       "len=%.0f %s for fnum %d file %s\n",
+                       lock_flav_name(plock->lock_flav),
+                       (double)plock->start, (double)plock->size,
+                       ret ? "unlocked" : "locked",
+                       plock->fnum, fsp->fsp_name ));
 
        return ret;
 }
 
+void strict_unlock_default(files_struct *fsp, struct lock_struct *plock)
+{
+}
+
 /****************************************************************************
  Find out if a lock could be granted - return who is blocking us if we can't.
 ****************************************************************************/
 
 NTSTATUS query_lock(files_struct *fsp,
                        uint32 *psmbpid,
-                       SMB_BIG_UINT *pcount,
-                       SMB_BIG_UINT *poffset,
+                       uint64_t *pcount,
+                       uint64_t *poffset,
                        enum brl_type *plock_type,
                        enum brl_flavour lock_flav)
 {
@@ -159,7 +180,7 @@ NTSTATUS query_lock(files_struct *fsp,
                return NT_STATUS_OK;
        }
 
-       br_lck = brl_get_locks_readonly(NULL, fsp);
+       br_lck = brl_get_locks_readonly(talloc_tos(), fsp);
        if (!br_lck) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -176,18 +197,49 @@ NTSTATUS query_lock(files_struct *fsp,
        return status;
 }
 
+static void increment_current_lock_count(files_struct *fsp,
+    enum brl_flavour lock_flav)
+{
+       if (lock_flav == WINDOWS_LOCK &&
+           fsp->current_lock_count != NO_LOCKING_COUNT) {
+               /* blocking ie. pending, locks also count here,
+                * as this is an efficiency counter to avoid checking
+                * the lock db. on close. JRA. */
+
+               fsp->current_lock_count++;
+       } else {
+               /* Notice that this has had a POSIX lock request.
+                * We can't count locks after this so forget them.
+                */
+               fsp->current_lock_count = NO_LOCKING_COUNT;
+       }
+}
+
+static void decrement_current_lock_count(files_struct *fsp,
+    enum brl_flavour lock_flav)
+{
+       if (lock_flav == WINDOWS_LOCK &&
+           fsp->current_lock_count != NO_LOCKING_COUNT) {
+               SMB_ASSERT(fsp->current_lock_count > 0);
+               fsp->current_lock_count--;
+       }
+}
+
 /****************************************************************************
  Utility function called by locking requests.
 ****************************************************************************/
 
-struct byte_range_lock *do_lock(files_struct *fsp,
+struct byte_range_lock *do_lock(struct messaging_context *msg_ctx,
+                       files_struct *fsp,
                        uint32 lock_pid,
-                       SMB_BIG_UINT count,
-                       SMB_BIG_UINT offset,
+                       uint64_t count,
+                       uint64_t offset,
                        enum brl_type lock_type,
                        enum brl_flavour lock_flav,
-                       BOOL blocking_lock,
-                       NTSTATUS *perr)
+                       bool blocking_lock,
+                       NTSTATUS *perr,
+                       uint32 *plock_pid,
+                       struct blocking_lock_record *blr)
 {
        struct byte_range_lock *br_lck = NULL;
 
@@ -203,31 +255,33 @@ struct byte_range_lock *do_lock(files_struct *fsp,
 
        /* NOTE! 0 byte long ranges ARE allowed and should be stored  */
 
-       DEBUG(10,("do_lock: lock flavour %s lock type %s start=%.0f len=%.0f requested for fnum %d file %s\n",
+       DEBUG(10,("do_lock: lock flavour %s lock type %s start=%.0f len=%.0f "
+               "blocking_lock=%s requested for fnum %d file %s\n",
                lock_flav_name(lock_flav), lock_type_name(lock_type),
-               (double)offset, (double)count, fsp->fnum, fsp->fsp_name ));
+               (double)offset, (double)count, blocking_lock ? "true" :
+               "false", fsp->fnum, fsp->fsp_name));
 
-       br_lck = brl_get_locks(NULL, fsp);
+       br_lck = brl_get_locks(talloc_tos(), fsp);
        if (!br_lck) {
                *perr = NT_STATUS_NO_MEMORY;
                return NULL;
        }
 
-       *perr = brl_lock(br_lck,
+       *perr = brl_lock(msg_ctx,
+                       br_lck,
                        lock_pid,
                        procid_self(),
                        offset,
                        count, 
                        lock_type,
                        lock_flav,
-                       blocking_lock);
-
-       /* blocking ie. pending, locks also count here,
-        * as this is an efficiency counter to avoid checking
-        * the lock db. on close. JRA. */
+                       blocking_lock,
+                       plock_pid,
+                       blr);
 
-       fsp->current_lock_count++;
+       DEBUG(10, ("do_lock: returning status=%s\n", nt_errstr(*perr)));
 
+       increment_current_lock_count(fsp, lock_flav);
        return br_lck;
 }
 
@@ -235,13 +289,14 @@ struct byte_range_lock *do_lock(files_struct *fsp,
  Utility function called by unlocking requests.
 ****************************************************************************/
 
-NTSTATUS do_unlock(files_struct *fsp,
+NTSTATUS do_unlock(struct messaging_context *msg_ctx,
+                       files_struct *fsp,
                        uint32 lock_pid,
-                       SMB_BIG_UINT count,
-                       SMB_BIG_UINT offset,
+                       uint64_t count,
+                       uint64_t offset,
                        enum brl_flavour lock_flav)
 {
-       BOOL ok = False;
+       bool ok = False;
        struct byte_range_lock *br_lck = NULL;
        
        if (!fsp->can_lock) {
@@ -255,12 +310,13 @@ NTSTATUS do_unlock(files_struct *fsp,
        DEBUG(10,("do_unlock: unlock start=%.0f len=%.0f requested for fnum %d file %s\n",
                  (double)offset, (double)count, fsp->fnum, fsp->fsp_name ));
 
-       br_lck = brl_get_locks(NULL, fsp);
+       br_lck = brl_get_locks(talloc_tos(), fsp);
        if (!br_lck) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       ok = brl_unlock(br_lck,
+       ok = brl_unlock(msg_ctx,
+                       br_lck,
                        lock_pid,
                        procid_self(),
                        offset,
@@ -274,9 +330,7 @@ NTSTATUS do_unlock(files_struct *fsp,
                return NT_STATUS_RANGE_NOT_LOCKED;
        }
 
-       SMB_ASSERT(fsp->current_lock_count > 0);
-       fsp->current_lock_count--;
-
+       decrement_current_lock_count(fsp, lock_flav);
        return NT_STATUS_OK;
 }
 
@@ -286,13 +340,14 @@ NTSTATUS do_unlock(files_struct *fsp,
 
 NTSTATUS do_lock_cancel(files_struct *fsp,
                        uint32 lock_pid,
-                       SMB_BIG_UINT count,
-                       SMB_BIG_UINT offset,
-                       enum brl_flavour lock_flav)
+                       uint64_t count,
+                       uint64_t offset,
+                       enum brl_flavour lock_flav,
+                       struct blocking_lock_record *blr)
 {
-       BOOL ok = False;
+       bool ok = False;
        struct byte_range_lock *br_lck = NULL;
-       
+
        if (!fsp->can_lock) {
                return fsp->is_directory ?
                        NT_STATUS_INVALID_DEVICE_REQUEST : NT_STATUS_INVALID_HANDLE;
@@ -305,7 +360,7 @@ NTSTATUS do_lock_cancel(files_struct *fsp,
        DEBUG(10,("do_lock_cancel: cancel start=%.0f len=%.0f requested for fnum %d file %s\n",
                  (double)offset, (double)count, fsp->fnum, fsp->fsp_name ));
 
-       br_lck = brl_get_locks(NULL, fsp);
+       br_lck = brl_get_locks(talloc_tos(), fsp);
        if (!br_lck) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -315,8 +370,9 @@ NTSTATUS do_lock_cancel(files_struct *fsp,
                        procid_self(),
                        offset,
                        count,
-                       lock_flav);
-   
+                       lock_flav,
+                       blr);
+
        TALLOC_FREE(br_lck);
 
        if (!ok) {
@@ -324,9 +380,7 @@ NTSTATUS do_lock_cancel(files_struct *fsp,
                return NT_STATUS_DOS(ERRDOS, ERRcancelviolation);
        }
 
-       SMB_ASSERT(fsp->current_lock_count > 0);
-       fsp->current_lock_count--;
-
+       decrement_current_lock_count(fsp, lock_flav);
        return NT_STATUS_OK;
 }
 
@@ -334,7 +388,8 @@ NTSTATUS do_lock_cancel(files_struct *fsp,
  Remove any locks on this fd. Called from file_close().
 ****************************************************************************/
 
-void locking_close_file(files_struct *fsp)
+void locking_close_file(struct messaging_context *msg_ctx,
+                       files_struct *fsp)
 {
        struct byte_range_lock *br_lck;
 
@@ -350,11 +405,11 @@ void locking_close_file(files_struct *fsp)
                return;
        }
 
-       br_lck = brl_get_locks(NULL,fsp);
+       br_lck = brl_get_locks(talloc_tos(),fsp);
 
        if (br_lck) {
                cancel_pending_lock_requests_by_fid(fsp, br_lck);
-               brl_close_fnum(br_lck);
+               brl_close_fnum(msg_ctx, br_lck);
                TALLOC_FREE(br_lck);
        }
 }
@@ -363,102 +418,77 @@ void locking_close_file(files_struct *fsp)
  Initialise the locking functions.
 ****************************************************************************/
 
-static int open_read_only;
-
-BOOL locking_init(int read_only)
+static bool locking_init_internal(bool read_only)
 {
        brl_init(read_only);
 
-       if (tdb)
+       if (lock_db)
                return True;
 
-       tdb = tdb_open_log(lock_path("locking.tdb"), 
-                       lp_open_files_db_hash_size(),
-                       TDB_DEFAULT|(read_only?0x0:TDB_CLEAR_IF_FIRST), 
-                       read_only?O_RDONLY:O_RDWR|O_CREAT,
-                       0644);
+       lock_db = db_open(NULL, lock_path("locking.tdb"),
+                         lp_open_files_db_hash_size(),
+                         TDB_DEFAULT|TDB_VOLATILE|TDB_CLEAR_IF_FIRST,
+                         read_only?O_RDONLY:O_RDWR|O_CREAT, 0644);
 
-       if (!tdb) {
+       if (!lock_db) {
                DEBUG(0,("ERROR: Failed to initialise locking database\n"));
                return False;
        }
 
-       /* Activate the per-hashchain freelist */
-       tdb_set_max_dead(tdb, 5);
-
        if (!posix_locking_init(read_only))
                return False;
 
-       open_read_only = read_only;
-
        return True;
 }
 
-/*******************************************************************
- Deinitialize the share_mode management.
-******************************************************************/
-
-BOOL locking_end(void)
+bool locking_init(void)
 {
-       BOOL ret = True;
-
-       brl_shutdown(open_read_only);
-       if (tdb) {
-               if (tdb_close(tdb) != 0)
-                       ret = False;
-       }
+       return locking_init_internal(false);
+}
 
-       return ret;
+bool locking_init_readonly(void)
+{
+       return locking_init_internal(true);
 }
 
 /*******************************************************************
Form a static locking key for a dev/inode pair.
Deinitialize the share_mode management.
 ******************************************************************/
 
-/* key and data records in the tdb locking database */
-struct locking_key {
-       SMB_DEV_T dev;
-       SMB_INO_T ino;
-};
+bool locking_end(void)
+{
+       brl_shutdown();
+       TALLOC_FREE(lock_db);
+       return true;
+}
 
 /*******************************************************************
  Form a static locking key for a dev/inode pair.
 ******************************************************************/
 
-static TDB_DATA locking_key(SMB_DEV_T dev, SMB_INO_T inode)
+static TDB_DATA locking_key(const struct file_id *id, struct file_id *tmp)
 {
-       static struct locking_key key;
-       TDB_DATA kbuf;
-
-       memset(&key, '\0', sizeof(key));
-       key.dev = dev;
-       key.ino = inode;
-       kbuf.dptr = (uint8 *)&key;
-       kbuf.dsize = sizeof(key);
-       return kbuf;
+       *tmp = *id;
+       return make_tdb_data((const uint8_t *)tmp, sizeof(*tmp));
 }
 
 /*******************************************************************
  Print out a share mode.
 ********************************************************************/
 
-char *share_mode_str(int num, struct share_mode_entry *e)
+char *share_mode_str(TALLOC_CTX *ctx, int num, const struct share_mode_entry *e)
 {
-       static pstring share_str;
-
-       slprintf(share_str, sizeof(share_str)-1, "share_mode_entry[%d]: %s "
+       return talloc_asprintf(ctx, "share_mode_entry[%d]: %s "
                 "pid = %s, share_access = 0x%x, private_options = 0x%x, "
-                "access_mask = 0x%x, mid = 0x%x, type= 0x%x, file_id = %lu, "
-                "uid = %u, flags = %u, dev = 0x%x, inode = %.0f",
+                "access_mask = 0x%x, mid = 0x%x, type= 0x%x, gen_id = %lu, "
+                "uid = %u, flags = %u, file_id %s",
                 num,
                 e->op_type == UNUSED_SHARE_MODE_ENTRY ? "UNUSED" : "",
                 procid_str_static(&e->pid),
                 e->share_access, e->private_options,
                 e->access_mask, e->op_mid, e->op_type, e->share_file_id,
                 (unsigned int)e->uid, (unsigned int)e->flags,
-                (unsigned int)e->dev, (double)e->inode );
-
-       return share_str;
+                file_id_string_tos(&e->id));
 }
 
 /*******************************************************************
@@ -474,10 +504,19 @@ static void print_share_mode_table(struct locking_data *data)
 
        for (i = 0; i < num_share_modes; i++) {
                struct share_mode_entry entry;
+               char *str;
+
+               /*
+                * We need to memcpy the entry here due to alignment
+                * restrictions that are not met when directly accessing
+                * shares[i]
+                */
 
                memcpy(&entry, &shares[i], sizeof(struct share_mode_entry));
-               DEBUG(10,("print_share_mode_table: %s\n",
-                         share_mode_str(i, &entry)));
+               str = share_mode_str(talloc_tos(), i, &entry);
+
+               DEBUG(10,("print_share_mode_table: %s\n", str ? str : ""));
+               TALLOC_FREE(str);
        }
 }
 
@@ -485,29 +524,37 @@ static void print_share_mode_table(struct locking_data *data)
  Get all share mode entries for a dev/inode pair.
 ********************************************************************/
 
-static BOOL parse_share_modes(TDB_DATA dbuf, struct share_mode_lock *lck)
+static bool parse_share_modes(TDB_DATA dbuf, struct share_mode_lock *lck)
 {
-       struct locking_data *data;
+       struct locking_data data;
        int i;
 
        if (dbuf.dsize < sizeof(struct locking_data)) {
-               smb_panic("PANIC: parse_share_modes: buffer too short.\n");
+               smb_panic("parse_share_modes: buffer too short");
        }
 
-       data = (struct locking_data *)dbuf.dptr;
+       memcpy(&data, dbuf.dptr, sizeof(data));
 
-       lck->delete_on_close = data->u.s.delete_on_close;
-       lck->num_share_modes = data->u.s.num_share_mode_entries;
+       lck->delete_on_close = data.u.s.delete_on_close;
+       lck->old_write_time = data.u.s.old_write_time;
+       lck->changed_write_time = data.u.s.changed_write_time;
+       lck->num_share_modes = data.u.s.num_share_mode_entries;
 
-       DEBUG(10, ("parse_share_modes: delete_on_close: %d, "
-                  "num_share_modes: %d\n",
-               lck->delete_on_close,
-               lck->num_share_modes));
+       DEBUG(10, ("parse_share_modes: delete_on_close: %d, owrt: %s, "
+                  "cwrt: %s, tok: %u, num_share_modes: %d\n",
+                  lck->delete_on_close,
+                  timestring(debug_ctx(),
+                             convert_timespec_to_time_t(lck->old_write_time)),
+                  timestring(debug_ctx(),
+                             convert_timespec_to_time_t(
+                                     lck->changed_write_time)),
+                  (unsigned int)data.u.s.delete_token_size,
+                  lck->num_share_modes));
 
        if ((lck->num_share_modes < 0) || (lck->num_share_modes > 1000000)) {
                DEBUG(0, ("invalid number of share modes: %d\n",
                          lck->num_share_modes));
-               smb_panic("PANIC: invalid number of share modes");
+               smb_panic("parse_share_modes: invalid number of share modes");
        }
 
        lck->share_modes = NULL;
@@ -517,35 +564,36 @@ static BOOL parse_share_modes(TDB_DATA dbuf, struct share_mode_lock *lck)
                if (dbuf.dsize < (sizeof(struct locking_data) +
                                  (lck->num_share_modes *
                                   sizeof(struct share_mode_entry)))) {
-                       smb_panic("PANIC: parse_share_modes: buffer too short.\n");
+                       smb_panic("parse_share_modes: buffer too short");
                }
                                  
                lck->share_modes = (struct share_mode_entry *)
-                       talloc_memdup(lck, dbuf.dptr+sizeof(*data),
+                       TALLOC_MEMDUP(lck,
+                                     dbuf.dptr+sizeof(struct locking_data),
                                      lck->num_share_modes *
                                      sizeof(struct share_mode_entry));
 
                if (lck->share_modes == NULL) {
-                       smb_panic("talloc failed\n");
+                       smb_panic("parse_share_modes: talloc failed");
                }
        }
 
        /* Get any delete token. */
-       if (data->u.s.delete_token_size) {
-               uint8 *p = dbuf.dptr + sizeof(*data) +
+       if (data.u.s.delete_token_size) {
+               uint8 *p = dbuf.dptr + sizeof(struct locking_data) +
                                (lck->num_share_modes *
                                sizeof(struct share_mode_entry));
 
-               if ((data->u.s.delete_token_size < sizeof(uid_t) + sizeof(gid_t)) ||
-                               ((data->u.s.delete_token_size - sizeof(uid_t)) % sizeof(gid_t)) != 0) {
+               if ((data.u.s.delete_token_size < sizeof(uid_t) + sizeof(gid_t)) ||
+                               ((data.u.s.delete_token_size - sizeof(uid_t)) % sizeof(gid_t)) != 0) {
                        DEBUG(0, ("parse_share_modes: invalid token size %d\n",
-                               data->u.s.delete_token_size));
-                       smb_panic("parse_share_modes: invalid token size\n");
+                               data.u.s.delete_token_size));
+                       smb_panic("parse_share_modes: invalid token size");
                }
 
                lck->delete_token = TALLOC_P(lck, UNIX_USER_TOKEN);
                if (!lck->delete_token) {
-                       smb_panic("talloc failed\n");
+                       smb_panic("parse_share_modes: talloc failed");
                }
 
                /* Copy out the uid and gid. */
@@ -555,8 +603,8 @@ static BOOL parse_share_modes(TDB_DATA dbuf, struct share_mode_lock *lck)
                p += sizeof(gid_t);
 
                /* Any supplementary groups ? */
-               lck->delete_token->ngroups = (data->u.s.delete_token_size > (sizeof(uid_t) + sizeof(gid_t))) ?
-                                       ((data->u.s.delete_token_size -
+               lck->delete_token->ngroups = (data.u.s.delete_token_size > (sizeof(uid_t) + sizeof(gid_t))) ?
+                                       ((data.u.s.delete_token_size -
                                                (sizeof(uid_t) + sizeof(gid_t)))/sizeof(gid_t)) : 0;
 
                if (lck->delete_token->ngroups) {
@@ -564,7 +612,7 @@ static BOOL parse_share_modes(TDB_DATA dbuf, struct share_mode_lock *lck)
                        lck->delete_token->groups = TALLOC_ARRAY(lck->delete_token, gid_t,
                                                        lck->delete_token->ngroups);
                        if (!lck->delete_token) {
-                               smb_panic("talloc failed\n");
+                               smb_panic("parse_share_modes: talloc failed");
                        }
 
                        for (i = 0; i < lck->delete_token->ngroups; i++) {
@@ -578,22 +626,14 @@ static BOOL parse_share_modes(TDB_DATA dbuf, struct share_mode_lock *lck)
        }
 
        /* Save off the associated service path and filename. */
-       lck->servicepath = talloc_strdup(lck, (const char *)dbuf.dptr + sizeof(*data) +
-                                       (lck->num_share_modes *
-                                       sizeof(struct share_mode_entry)) +
-                                       data->u.s.delete_token_size );
-       if (lck->servicepath == NULL) {
-               smb_panic("talloc_strdup failed\n");
-       }
+       lck->servicepath = (const char *)dbuf.dptr + sizeof(struct locking_data) +
+               (lck->num_share_modes * sizeof(struct share_mode_entry)) +
+               data.u.s.delete_token_size;
 
-       lck->filename = talloc_strdup(lck, (const char *)dbuf.dptr + sizeof(*data) +
-                                       (lck->num_share_modes *
-                                       sizeof(struct share_mode_entry)) +
-                                       data->u.s.delete_token_size +
-                                       strlen(lck->servicepath) + 1 );
-       if (lck->filename == NULL) {
-               smb_panic("talloc_strdup failed\n");
-       }
+       lck->filename = (const char *)dbuf.dptr + sizeof(struct locking_data) +
+               (lck->num_share_modes * sizeof(struct share_mode_entry)) +
+               data.u.s.delete_token_size +
+               strlen(lck->servicepath) + 1;
 
        /*
         * Ensure that each entry has a real process attached.
@@ -601,14 +641,19 @@ static BOOL parse_share_modes(TDB_DATA dbuf, struct share_mode_lock *lck)
 
        for (i = 0; i < lck->num_share_modes; i++) {
                struct share_mode_entry *entry_p = &lck->share_modes[i];
+               char *str = NULL;
+               if (DEBUGLEVEL >= 10) {
+                       str = share_mode_str(NULL, i, entry_p);
+               }
                DEBUG(10,("parse_share_modes: %s\n",
-                         share_mode_str(i, entry_p) ));
+                       str ? str : ""));
                if (!process_exists(entry_p->pid)) {
                        DEBUG(10,("parse_share_modes: deleted %s\n",
-                                 share_mode_str(i, entry_p) ));
+                               str ? str : ""));
                        entry_p->op_type = UNUSED_SHARE_MODE_ENTRY;
                        lck->modified = True;
                }
+               TALLOC_FREE(str);
        }
 
        return True;
@@ -649,18 +694,27 @@ static TDB_DATA unparse_share_modes(struct share_mode_lock *lck)
        result.dptr = TALLOC_ARRAY(lck, uint8, result.dsize);
 
        if (result.dptr == NULL) {
-               smb_panic("talloc failed\n");
+               smb_panic("talloc failed");
        }
 
        data = (struct locking_data *)result.dptr;
        ZERO_STRUCTP(data);
        data->u.s.num_share_mode_entries = lck->num_share_modes;
        data->u.s.delete_on_close = lck->delete_on_close;
+       data->u.s.old_write_time = lck->old_write_time;
+       data->u.s.changed_write_time = lck->changed_write_time;
        data->u.s.delete_token_size = delete_token_size;
-       DEBUG(10, ("unparse_share_modes: del: %d, tok = %u, num: %d\n",
-               data->u.s.delete_on_close,
-               (unsigned int)data->u.s.delete_token_size,
-               data->u.s.num_share_mode_entries));
+
+       DEBUG(10,("unparse_share_modes: del: %d, owrt: %s cwrt: %s, tok: %u, "
+                 "num: %d\n", data->u.s.delete_on_close,
+                 timestring(debug_ctx(),
+                            convert_timespec_to_time_t(lck->old_write_time)),
+                 timestring(debug_ctx(),
+                            convert_timespec_to_time_t(
+                                    lck->changed_write_time)),
+                 (unsigned int)data->u.s.delete_token_size,
+                 data->u.s.num_share_mode_entries));
+
        memcpy(result.dptr + sizeof(*data), lck->share_modes,
               sizeof(struct share_mode_entry)*lck->num_share_modes);
        offset = sizeof(*data) +
@@ -698,11 +752,11 @@ static TDB_DATA unparse_share_modes(struct share_mode_lock *lck)
 
 static int share_mode_lock_destructor(struct share_mode_lock *lck)
 {
-       TDB_DATA key = locking_key(lck->dev, lck->ino);
+       NTSTATUS status;
        TDB_DATA data;
 
        if (!lck->modified) {
-               goto done;
+               return 0;
        }
 
        data = unparse_share_modes(lck);
@@ -710,90 +764,134 @@ static int share_mode_lock_destructor(struct share_mode_lock *lck)
        if (data.dptr == NULL) {
                if (!lck->fresh) {
                        /* There has been an entry before, delete it */
-                       if (tdb_delete(tdb, key) == -1) {
-                               smb_panic("Could not delete share entry\n");
+
+                       status = lck->record->delete_rec(lck->record);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               DEBUG(0, ("delete_rec returned %s\n",
+                                         nt_errstr(status)));
+                               smb_panic("could not delete share entry");
                        }
                }
                goto done;
        }
 
-       if (tdb_store(tdb, key, data, TDB_REPLACE) == -1) {
-               smb_panic("Could not store share mode entry\n");
+       status = lck->record->store(lck->record, data, TDB_REPLACE);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("store returned %s\n", nt_errstr(status)));
+               smb_panic("could not store share mode entry");
        }
 
  done:
-       tdb_chainunlock(tdb, key);
 
        return 0;
 }
 
-struct share_mode_lock *get_share_mode_lock(TALLOC_CTX *mem_ctx,
-                                               SMB_DEV_T dev, SMB_INO_T ino,
-                                               const char *servicepath,
-                                               const char *fname)
+static bool fill_share_mode_lock(struct share_mode_lock *lck,
+                                struct file_id id,
+                                const char *servicepath,
+                                const char *fname,
+                                TDB_DATA share_mode_data,
+                                const struct timespec *old_write_time)
 {
-       struct share_mode_lock *lck;
-       TDB_DATA key = locking_key(dev, ino);
-       TDB_DATA data;
-
-       lck = TALLOC_P(mem_ctx, struct share_mode_lock);
-       if (lck == NULL) {
-               DEBUG(0, ("talloc failed\n"));
-               return NULL;
-       }
-
        /* Ensure we set every field here as the destructor must be
           valid even if parse_share_modes fails. */
 
        lck->servicepath = NULL;
        lck->filename = NULL;
-       lck->dev = dev;
-       lck->ino = ino;
+       lck->id = id;
        lck->num_share_modes = 0;
        lck->share_modes = NULL;
        lck->delete_token = NULL;
        lck->delete_on_close = False;
+       ZERO_STRUCT(lck->old_write_time);
+       ZERO_STRUCT(lck->changed_write_time);
        lck->fresh = False;
        lck->modified = False;
 
-       if (tdb_chainlock(tdb, key) != 0) {
-               DEBUG(3, ("Could not lock share entry\n"));
-               TALLOC_FREE(lck);
-               return NULL;
-       }
-
-       /* We must set the destructor immediately after the chainlock
-          ensure the lock is cleaned up on any of the error return
-          paths below. */
-
-       talloc_set_destructor(lck, share_mode_lock_destructor);
-
-       data = tdb_fetch(tdb, key);
-       lck->fresh = (data.dptr == NULL);
+       lck->fresh = (share_mode_data.dptr == NULL);
 
        if (lck->fresh) {
-
-               if (fname == NULL || servicepath == NULL) {
-                       TALLOC_FREE(lck);
-                       return NULL;
+               if (fname == NULL || servicepath == NULL
+                   || old_write_time == NULL) {
+                       return False;
                }
                lck->filename = talloc_strdup(lck, fname);
                lck->servicepath = talloc_strdup(lck, servicepath);
                if (lck->filename == NULL || lck->servicepath == NULL) {
                        DEBUG(0, ("talloc failed\n"));
-                       TALLOC_FREE(lck);
-                       return NULL;
+                       return False;
                }
+               lck->old_write_time = *old_write_time;
        } else {
-               if (!parse_share_modes(data, lck)) {
+               if (!parse_share_modes(share_mode_data, lck)) {
                        DEBUG(0, ("Could not parse share modes\n"));
-                       TALLOC_FREE(lck);
-                       SAFE_FREE(data.dptr);
-                       return NULL;
+                       return False;
                }
        }
 
-       SAFE_FREE(data.dptr);
+       return True;
+}
+
+struct share_mode_lock *get_share_mode_lock(TALLOC_CTX *mem_ctx,
+                                           const struct file_id id,
+                                           const char *servicepath,
+                                           const char *fname,
+                                           const struct timespec *old_write_time)
+{
+       struct share_mode_lock *lck;
+       struct file_id tmp;
+       TDB_DATA key = locking_key(&id, &tmp);
+
+       if (!(lck = TALLOC_P(mem_ctx, struct share_mode_lock))) {
+               DEBUG(0, ("talloc failed\n"));
+               return NULL;
+       }
+
+       if (!(lck->record = lock_db->fetch_locked(lock_db, lck, key))) {
+               DEBUG(3, ("Could not lock share entry\n"));
+               TALLOC_FREE(lck);
+               return NULL;
+       }
+
+       if (!fill_share_mode_lock(lck, id, servicepath, fname,
+                                 lck->record->value, old_write_time)) {
+               DEBUG(3, ("fill_share_mode_lock failed\n"));
+               TALLOC_FREE(lck);
+               return NULL;
+       }
+
+       talloc_set_destructor(lck, share_mode_lock_destructor);
+
+       return lck;
+}
+
+struct share_mode_lock *fetch_share_mode_unlocked(TALLOC_CTX *mem_ctx,
+                                                 const struct file_id id,
+                                                 const char *servicepath,
+                                                 const char *fname)
+{
+       struct share_mode_lock *lck;
+       struct file_id tmp;
+       TDB_DATA key = locking_key(&id, &tmp);
+       TDB_DATA data;
+
+       if (!(lck = TALLOC_P(mem_ctx, struct share_mode_lock))) {
+               DEBUG(0, ("talloc failed\n"));
+               return NULL;
+       }
+
+       if (lock_db->fetch(lock_db, lck, key, &data) == -1) {
+               DEBUG(3, ("Could not fetch share entry\n"));
+               TALLOC_FREE(lck);
+               return NULL;
+       }
+
+       if (!fill_share_mode_lock(lck, id, servicepath, fname, data, NULL)) {
+               DEBUG(10, ("fetch_share_mode_unlocked: no share_mode record "
+                          "around (file not open)\n"));
+               TALLOC_FREE(lck);
+               return NULL;
+       }
 
        return lck;
 }
@@ -805,7 +903,8 @@ struct share_mode_lock *get_share_mode_lock(TALLOC_CTX *mem_ctx,
  Based on an initial code idea from SATOH Fumiyasu <fumiya@samba.gr.jp>
 ********************************************************************/
 
-BOOL rename_share_filename(struct share_mode_lock *lck,
+bool rename_share_filename(struct messaging_context *msg_ctx,
+                       struct share_mode_lock *lck,
                        const char *servicepath,
                        const char *newname)
 {
@@ -815,10 +914,6 @@ BOOL rename_share_filename(struct share_mode_lock *lck,
        char *frm = NULL;
        int i;
 
-       if (!lck) {
-               return False;
-       }
-
        DEBUG(10, ("rename_share_filename: servicepath %s newname %s\n",
                servicepath, newname));
 
@@ -849,13 +944,12 @@ BOOL rename_share_filename(struct share_mode_lock *lck,
                return False;
        }
 
-       SDEV_T_VAL(frm,0,lck->dev);
-       SINO_T_VAL(frm,8,lck->ino);
+       push_file_id_24(frm, &lck->id);
 
        DEBUG(10,("rename_share_filename: msg_len = %u\n", (unsigned int)msg_len ));
 
-       safe_strcpy(&frm[16], lck->servicepath, sp_len);
-       safe_strcpy(&frm[16 + sp_len + 1], lck->filename, fn_len);
+       safe_strcpy(&frm[24], lck->servicepath, sp_len);
+       safe_strcpy(&frm[24 + sp_len + 1], lck->filename, fn_len);
 
        /* Send the messages. */
        for (i=0; i<lck->num_share_modes; i++) {
@@ -869,48 +963,66 @@ BOOL rename_share_filename(struct share_mode_lock *lck,
                }
 
                DEBUG(10,("rename_share_filename: sending rename message to pid %s "
-                       "dev %x, inode  %.0f sharepath %s newname %s\n",
-                       procid_str_static(&se->pid),
-                       (unsigned int)lck->dev, (double)lck->ino,
-                       lck->servicepath, lck->filename ));
+                         "file_id %s sharepath %s newname %s\n",
+                         procid_str_static(&se->pid),
+                         file_id_string_tos(&lck->id),
+                         lck->servicepath, lck->filename ));
 
-               message_send_pid(se->pid, MSG_SMB_FILE_RENAME,
-                               frm, msg_len, True);
+               messaging_send_buf(msg_ctx, se->pid, MSG_SMB_FILE_RENAME,
+                                  (uint8 *)frm, msg_len);
        }
 
        return True;
 }
 
-static int pull_delete_on_close_flag(TDB_DATA key, TDB_DATA dbuf,
-                                    void *private_data)
+void get_file_infos(struct file_id id,
+                   bool *delete_on_close,
+                   struct timespec *write_time)
 {
-       BOOL *result = (BOOL *)private_data;
-       struct locking_data *data;
+       struct share_mode_lock *lck;
 
-       if (dbuf.dsize < sizeof(struct locking_data)) {
-               smb_panic("PANIC: parse_share_modes: buffer too short.\n");
+       if (delete_on_close) {
+               *delete_on_close = false;
        }
 
-       data = (struct locking_data *)dbuf.dptr;
+       if (write_time) {
+               ZERO_STRUCTP(write_time);
+       }
 
-       *result = data->u.s.delete_on_close;
-       return 0;
-}
+       if (!(lck = fetch_share_mode_unlocked(talloc_tos(), id, NULL, NULL))) {
+               return;
+       }
 
-BOOL get_delete_on_close_flag(SMB_DEV_T dev, SMB_INO_T inode)
-{
-       TDB_DATA key = locking_key(dev, inode);
-       BOOL result = False;
+       if (delete_on_close) {
+               *delete_on_close = lck->delete_on_close;
+       }
 
-       tdb_parse_record(tdb, key, pull_delete_on_close_flag,
-                        (void *)&result);
-       return result;
+       if (write_time) {
+               struct timespec wt;
+
+               wt = lck->changed_write_time;
+               if (null_timespec(wt)) {
+                       wt = lck->old_write_time;
+               }
+
+               *write_time = wt;
+       }
+
+       TALLOC_FREE(lck);
 }
 
-BOOL is_valid_share_mode_entry(const struct share_mode_entry *e)
+bool is_valid_share_mode_entry(const struct share_mode_entry *e)
 {
        int num_props = 0;
 
+       if (e->op_type == UNUSED_SHARE_MODE_ENTRY) {
+               /* cope with dead entries from the process not
+                  existing. These should not be considered valid,
+                  otherwise we end up doing zero timeout sharing
+                  violation */
+               return False;
+       }
+
        num_props += ((e->op_type == NO_OPLOCK) ? 1 : 0);
        num_props += (EXCLUSIVE_OPLOCK_TYPE(e->op_type) ? 1 : 0);
        num_props += (LEVEL_II_OPLOCK_TYPE(e->op_type) ? 1 : 0);
@@ -919,12 +1031,12 @@ BOOL is_valid_share_mode_entry(const struct share_mode_entry *e)
        return (num_props != 0);
 }
 
-BOOL is_deferred_open_entry(const struct share_mode_entry *e)
+bool is_deferred_open_entry(const struct share_mode_entry *e)
 {
        return (e->op_type == DEFERRED_OPEN_ENTRY);
 }
 
-BOOL is_unused_share_mode_entry(const struct share_mode_entry *e)
+bool is_unused_share_mode_entry(const struct share_mode_entry *e)
 {
        return (e->op_type == UNUSED_SHARE_MODE_ENTRY);
 }
@@ -946,16 +1058,15 @@ static void fill_share_mode_entry(struct share_mode_entry *e,
        e->op_type = op_type;
        e->time.tv_sec = fsp->open_time.tv_sec;
        e->time.tv_usec = fsp->open_time.tv_usec;
-       e->dev = fsp->dev;
-       e->inode = fsp->inode;
-       e->share_file_id = fsp->fh->file_id;
+       e->id = fsp->file_id;
+       e->share_file_id = fsp->fh->gen_id;
        e->uid = (uint32)uid;
        e->flags = fsp->posix_open ? SHARE_MODE_FLAG_POSIX_OPEN : 0;
 }
 
 static void fill_deferred_open_entry(struct share_mode_entry *e,
                                     const struct timeval request_time,
-                                    SMB_DEV_T dev, SMB_INO_T ino, uint16 mid)
+                                    struct file_id id, uint16 mid)
 {
        ZERO_STRUCTP(e);
        e->pid = procid_self();
@@ -963,8 +1074,7 @@ static void fill_deferred_open_entry(struct share_mode_entry *e,
        e->op_type = DEFERRED_OPEN_ENTRY;
        e->time.tv_sec = request_time.tv_sec;
        e->time.tv_usec = request_time.tv_usec;
-       e->dev = dev;
-       e->inode = ino;
+       e->id = id;
        e->uid = (uint32)-1;
        e->flags = 0;
 }
@@ -991,7 +1101,7 @@ static void add_share_mode_entry(struct share_mode_lock *lck,
 }
 
 void set_share_mode(struct share_mode_lock *lck, files_struct *fsp,
-                       uid_t uid, uint16 mid, uint16 op_type)
+                   uid_t uid, uint16 mid, uint16 op_type)
 {
        struct share_mode_entry entry;
        fill_share_mode_entry(&entry, fsp, uid, mid, op_type);
@@ -1000,10 +1110,10 @@ void set_share_mode(struct share_mode_lock *lck, files_struct *fsp,
 
 void add_deferred_open(struct share_mode_lock *lck, uint16 mid,
                       struct timeval request_time,
-                      SMB_DEV_T dev, SMB_INO_T ino)
+                      struct file_id id)
 {
        struct share_mode_entry entry;
-       fill_deferred_open_entry(&entry, request_time, dev, ino, mid);
+       fill_deferred_open_entry(&entry, request_time, id, mid);
        add_share_mode_entry(lck, &entry);
 }
 
@@ -1013,7 +1123,7 @@ void add_deferred_open(struct share_mode_lock *lck, uint16 mid,
  not automatically a logic error if they are identical. JRA.)
 ********************************************************************/
 
-static BOOL share_modes_identical(struct share_mode_entry *e1,
+static bool share_modes_identical(struct share_mode_entry *e1,
                                  struct share_mode_entry *e2)
 {
        /* We used to check for e1->share_access == e2->share_access here
@@ -1022,18 +1132,16 @@ static BOOL share_modes_identical(struct share_mode_entry *e1,
           fsp->share_access field. */
 
        return (procid_equal(&e1->pid, &e2->pid) &&
-               e1->dev == e2->dev &&
-               e1->inode == e2->inode &&
+               file_id_equal(&e1->id, &e2->id) &&
                e1->share_file_id == e2->share_file_id );
 }
 
-static BOOL deferred_open_identical(struct share_mode_entry *e1,
+static bool deferred_open_identical(struct share_mode_entry *e1,
                                    struct share_mode_entry *e2)
 {
        return (procid_equal(&e1->pid, &e2->pid) &&
                (e1->op_mid == e2->op_mid) &&
-               (e1->dev == e2->dev) &&
-               (e1->inode == e2->inode));
+               file_id_equal(&e1->id, &e2->id));
 }
 
 static struct share_mode_entry *find_share_mode_entry(struct share_mode_lock *lck,
@@ -1062,7 +1170,7 @@ static struct share_mode_entry *find_share_mode_entry(struct share_mode_lock *lc
  entries left.
 ********************************************************************/
 
-BOOL del_share_mode(struct share_mode_lock *lck, files_struct *fsp)
+bool del_share_mode(struct share_mode_lock *lck, files_struct *fsp)
 {
        struct share_mode_entry entry, *e;
 
@@ -1084,7 +1192,7 @@ void del_deferred_open_entry(struct share_mode_lock *lck, uint16 mid)
        struct share_mode_entry entry, *e;
 
        fill_deferred_open_entry(&entry, timeval_zero(),
-                                lck->dev, lck->ino, mid);
+                                lck->id, mid);
 
        e = find_share_mode_entry(lck, &entry);
        if (e == NULL) {
@@ -1099,7 +1207,7 @@ void del_deferred_open_entry(struct share_mode_lock *lck, uint16 mid)
  Remove an oplock mid and mode entry from a share mode.
 ********************************************************************/
 
-BOOL remove_share_oplock(struct share_mode_lock *lck, files_struct *fsp)
+bool remove_share_oplock(struct share_mode_lock *lck, files_struct *fsp)
 {
        struct share_mode_entry entry, *e;
 
@@ -1112,7 +1220,16 @@ BOOL remove_share_oplock(struct share_mode_lock *lck, files_struct *fsp)
        }
 
        e->op_mid = 0;
-       e->op_type = NO_OPLOCK;
+       if (EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type)) {
+               /*
+                * Going from exclusive or batch,
+                * we always go through FAKE_LEVEL_II
+                * first.
+                */
+               e->op_type = FAKE_LEVEL_II_OPLOCK;
+       } else {
+               e->op_type = NO_OPLOCK;
+       }
        lck->modified = True;
        return True;
 }
@@ -1121,7 +1238,7 @@ BOOL remove_share_oplock(struct share_mode_lock *lck, files_struct *fsp)
  Downgrade a oplock type from exclusive to level II.
 ********************************************************************/
 
-BOOL downgrade_share_oplock(struct share_mode_lock *lck, files_struct *fsp)
+bool downgrade_share_oplock(struct share_mode_lock *lck, files_struct *fsp)
 {
        struct share_mode_entry entry, *e;
 
@@ -1144,7 +1261,7 @@ BOOL downgrade_share_oplock(struct share_mode_lock *lck, files_struct *fsp)
  open_file_ntcreate. JRA.
 ****************************************************************************/
 
-NTSTATUS can_set_delete_on_close(files_struct *fsp, BOOL delete_on_close,
+NTSTATUS can_set_delete_on_close(files_struct *fsp, bool delete_on_close,
                                 uint32 dosmode)
 {
        if (!delete_on_close) {
@@ -1199,7 +1316,7 @@ NTSTATUS can_set_delete_on_close(files_struct *fsp, BOOL delete_on_close,
  (Should this be in locking.c.... ?).
 *************************************************************************/
 
-static UNIX_USER_TOKEN *copy_unix_token(TALLOC_CTX *ctx, UNIX_USER_TOKEN *tok)
+static UNIX_USER_TOKEN *copy_unix_token(TALLOC_CTX *ctx, const UNIX_USER_TOKEN *tok)
 {
        UNIX_USER_TOKEN *cpy;
 
@@ -1230,13 +1347,9 @@ static UNIX_USER_TOKEN *copy_unix_token(TALLOC_CTX *ctx, UNIX_USER_TOKEN *tok)
  Replace the delete on close token.
 ****************************************************************************/
 
-void set_delete_on_close_token(struct share_mode_lock *lck, UNIX_USER_TOKEN *tok)
+void set_delete_on_close_token(struct share_mode_lock *lck, const UNIX_USER_TOKEN *tok)
 {
-       /* Ensure there's no token. */
-       if (lck->delete_token) {
-               TALLOC_FREE(lck->delete_token); /* Also deletes groups... */
-               lck->delete_token = NULL;
-       }
+       TALLOC_FREE(lck->delete_token); /* Also deletes groups... */
 
        /* Copy the new token (can be NULL). */
        lck->delete_token = copy_unix_token(lck, tok);
@@ -1254,7 +1367,7 @@ void set_delete_on_close_token(struct share_mode_lock *lck, UNIX_USER_TOKEN *tok
  lck entry. This function is used when the lock is already granted.
 ****************************************************************************/
 
-void set_delete_on_close_lck(struct share_mode_lock *lck, BOOL delete_on_close, UNIX_USER_TOKEN *tok)
+void set_delete_on_close_lck(struct share_mode_lock *lck, bool delete_on_close, const UNIX_USER_TOKEN *tok)
 {
        if (lck->delete_on_close != delete_on_close) {
                set_delete_on_close_token(lck, tok);
@@ -1266,8 +1379,9 @@ void set_delete_on_close_lck(struct share_mode_lock *lck, BOOL delete_on_close,
        }
 }
 
-BOOL set_delete_on_close(files_struct *fsp, BOOL delete_on_close, UNIX_USER_TOKEN *tok)
+bool set_delete_on_close(files_struct *fsp, bool delete_on_close, const UNIX_USER_TOKEN *tok)
 {
+       UNIX_USER_TOKEN *tok_copy = NULL;
        struct share_mode_lock *lck;
        
        DEBUG(10,("set_delete_on_close: %s delete on close flag for "
@@ -1275,15 +1389,22 @@ BOOL set_delete_on_close(files_struct *fsp, BOOL delete_on_close, UNIX_USER_TOKE
                  delete_on_close ? "Adding" : "Removing", fsp->fnum,
                  fsp->fsp_name ));
 
-       if (fsp->is_stat) {
-               return True;
-       }
-
-       lck = get_share_mode_lock(NULL, fsp->dev, fsp->inode, NULL, NULL);
+       lck = get_share_mode_lock(talloc_tos(), fsp->file_id, NULL, NULL,
+                                 NULL);
        if (lck == NULL) {
                return False;
        }
 
+       if (fsp->conn->admin_user) {
+               tok_copy = copy_unix_token(lck, tok);
+               tok_copy->uid = (uid_t)0;
+               if (tok_copy == NULL) {
+                       TALLOC_FREE(lck);
+                       return false;
+               }
+               tok = tok_copy;
+       }
+
        set_delete_on_close_lck(lck, delete_on_close, tok);
 
        if (fsp->is_directory) {
@@ -1294,6 +1415,53 @@ BOOL set_delete_on_close(files_struct *fsp, BOOL delete_on_close, UNIX_USER_TOKE
        return True;
 }
 
+bool set_sticky_write_time(struct file_id fileid, struct timespec write_time)
+{
+       struct share_mode_lock *lck;
+
+       DEBUG(5,("set_sticky_write_time: %s id=%s\n",
+                timestring(debug_ctx(),
+                           convert_timespec_to_time_t(write_time)),
+                file_id_string_tos(&fileid)));
+
+       lck = get_share_mode_lock(NULL, fileid, NULL, NULL, NULL);
+       if (lck == NULL) {
+               return False;
+       }
+
+       if (timespec_compare(&lck->changed_write_time, &write_time) != 0) {
+               lck->modified = True;
+               lck->changed_write_time = write_time;
+       }
+
+       TALLOC_FREE(lck);
+       return True;
+}
+
+bool set_write_time(struct file_id fileid, struct timespec write_time)
+{
+       struct share_mode_lock *lck;
+
+       DEBUG(5,("set_write_time: %s id=%s\n",
+                timestring(debug_ctx(),
+                           convert_timespec_to_time_t(write_time)),
+                file_id_string_tos(&fileid)));
+
+       lck = get_share_mode_lock(NULL, fileid, NULL, NULL, NULL);
+       if (lck == NULL) {
+               return False;
+       }
+
+       if (timespec_compare(&lck->old_write_time, &write_time) != 0) {
+               lck->modified = True;
+               lck->old_write_time = write_time;
+       }
+
+       TALLOC_FREE(lck);
+       return True;
+}
+
+
 struct forall_state {
        void (*fn)(const struct share_mode_entry *entry,
                   const char *sharepath,
@@ -1302,8 +1470,7 @@ struct forall_state {
        void *private_data;
 };
 
-static int traverse_fn(TDB_CONTEXT *the_tdb, TDB_DATA kbuf, TDB_DATA dbuf, 
-                       void *_state)
+static int traverse_fn(struct db_record *rec, void *_state)
 {
        struct forall_state *state = (struct forall_state *)_state;
        struct locking_data *data;
@@ -1313,15 +1480,15 @@ static int traverse_fn(TDB_CONTEXT *the_tdb, TDB_DATA kbuf, TDB_DATA dbuf,
        int i;
 
        /* Ensure this is a locking_key record. */
-       if (kbuf.dsize != sizeof(struct locking_key))
+       if (rec->key.dsize != sizeof(struct file_id))
                return 0;
 
-       data = (struct locking_data *)dbuf.dptr;
-       shares = (struct share_mode_entry *)(dbuf.dptr + sizeof(*data));
-       sharepath = (const char *)dbuf.dptr + sizeof(*data) +
+       data = (struct locking_data *)rec->value.dptr;
+       shares = (struct share_mode_entry *)(rec->value.dptr + sizeof(*data));
+       sharepath = (const char *)rec->value.dptr + sizeof(*data) +
                data->u.s.num_share_mode_entries*sizeof(*shares) +
                data->u.s.delete_token_size;
-       fname = (const char *)dbuf.dptr + sizeof(*data) +
+       fname = (const char *)rec->value.dptr + sizeof(*data) +
                data->u.s.num_share_mode_entries*sizeof(*shares) +
                data->u.s.delete_token_size +
                strlen(sharepath) + 1;
@@ -1344,11 +1511,11 @@ int share_mode_forall(void (*fn)(const struct share_mode_entry *, const char *,
 {
        struct forall_state state;
 
-       if (tdb == NULL)
+       if (lock_db == NULL)
                return 0;
 
        state.fn = fn;
        state.private_data = private_data;
 
-       return tdb_traverse(tdb, traverse_fn, (void *)&state);
+       return lock_db->traverse_read(lock_db, traverse_fn, (void *)&state);
 }