s3:dsgetdcname: use parentheses in if condition to make negation clear
[ira/wip.git] / source3 / libsmb / dsgetdcname.c
index a278c4ef508abdf5afaefc8ce72ecc365fca0061..1064a63d97f1d465416aaac2ac3e07f935a14074 100644 (file)
@@ -32,6 +32,12 @@ struct ip_service_name {
        const char *hostname;
 };
 
+static NTSTATUS make_dc_info_from_cldap_reply(TALLOC_CTX *mem_ctx,
+                                             uint32_t flags,
+                                             struct sockaddr_storage *ss,
+                                             struct NETLOGON_SAM_LOGON_RESPONSE_EX *r,
+                                             struct netr_DsRGetDCNameInfo **info);
+
 /****************************************************************
 ****************************************************************/
 
@@ -112,7 +118,7 @@ void debug_dsdcinfo_flags(int lvl, uint32_t flags)
 
 static char *dsgetdcname_cache_key(TALLOC_CTX *mem_ctx, const char *domain)
 {
-       if (!mem_ctx || !domain) {
+       if (!domain) {
                return NULL;
        }
 
@@ -148,13 +154,11 @@ static NTSTATUS dsgetdcname_cache_delete(TALLOC_CTX *mem_ctx,
 
 static NTSTATUS dsgetdcname_cache_store(TALLOC_CTX *mem_ctx,
                                        const char *domain_name,
-                                       struct netr_DsRGetDCNameInfo *info)
+                                       const DATA_BLOB *blob)
 {
        time_t expire_time;
        char *key;
        bool ret = false;
-       DATA_BLOB blob;
-       enum ndr_err_code ndr_err;
 
        if (!gencache_init()) {
                return NT_STATUS_INTERNAL_DB_ERROR;
@@ -167,19 +171,11 @@ static NTSTATUS dsgetdcname_cache_store(TALLOC_CTX *mem_ctx,
 
        expire_time = time(NULL) + DSGETDCNAME_CACHE_TTL;
 
-       ndr_err = ndr_push_struct_blob(&blob, mem_ctx, info,
-                      (ndr_push_flags_fn_t)ndr_push_netr_DsRGetDCNameInfo);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               return ndr_map_error2ntstatus(ndr_err);
-       }
-
        if (gencache_lock_entry(key) != 0) {
-               data_blob_free(&blob);
                return NT_STATUS_LOCK_NOT_GRANTED;
        }
 
-       ret = gencache_set_data_blob(key, &blob, expire_time);
-       data_blob_free(&blob);
+       ret = gencache_set_data_blob(key, blob, expire_time);
 
        gencache_unlock_entry(key);
 
@@ -189,49 +185,101 @@ static NTSTATUS dsgetdcname_cache_store(TALLOC_CTX *mem_ctx,
 /****************************************************************
 ****************************************************************/
 
-static NTSTATUS dsgetdcname_cache_refresh(TALLOC_CTX *mem_ctx,
-                                         const char *domain_name,
-                                         struct GUID *domain_guid,
-                                         uint32_t flags,
-                                         const char *site_name,
-                                         struct netr_DsRGetDCNameInfo *info)
+static NTSTATUS store_cldap_reply(TALLOC_CTX *mem_ctx,
+                                 uint32_t flags,
+                                 struct sockaddr_storage *ss,
+                                 uint32_t nt_version,
+                                 struct NETLOGON_SAM_LOGON_RESPONSE_EX *r)
 {
-       uint32_t nt_version = NETLOGON_VERSION_1;
+       DATA_BLOB blob;
+       enum ndr_err_code ndr_err;
+       NTSTATUS status;
+       char addr[INET6_ADDRSTRLEN];
 
-       /* check if matching entry is older then 15 minutes, if yes, send
-        * CLDAP/MAILSLOT ping again and store the cached data */
+       print_sockaddr(addr, sizeof(addr), ss);
 
-       if (ads_cldap_netlogon(mem_ctx, info->dc_unc,
-                              info->domain_name, &nt_version, NULL)) {
+       /* FIXME */
+       r->sockaddr_size = 0x10; /* the w32 winsock addr size */
+       r->sockaddr.sockaddr_family = 2; /* AF_INET */
+       r->sockaddr.pdc_ip = talloc_strdup(mem_ctx, addr);
 
-               dsgetdcname_cache_delete(mem_ctx, domain_name);
+       ndr_err = ndr_push_struct_blob(&blob, mem_ctx, NULL, r,
+                      (ndr_push_flags_fn_t)ndr_push_NETLOGON_SAM_LOGON_RESPONSE_EX);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               return ndr_map_error2ntstatus(ndr_err);
+       }
 
-               return dsgetdcname_cache_store(mem_ctx,
-                                              info->domain_name,
-                                              info);
+       if (r->domain) {
+               status = dsgetdcname_cache_store(mem_ctx, r->domain, &blob);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto done;
+               }
+               if (r->client_site) {
+                       sitename_store(r->domain, r->client_site);
+               }
        }
+       if (r->dns_domain) {
+               status = dsgetdcname_cache_store(mem_ctx, r->dns_domain, &blob);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto done;
+               }
+               if (r->client_site) {
+                       sitename_store(r->dns_domain, r->client_site);
+               }
+       }
+
+       status = NT_STATUS_OK;
+
+ done:
+       data_blob_free(&blob);
 
-       return NT_STATUS_INVALID_NETWORK_RESPONSE;
+       return status;
+}
+
+/****************************************************************
+****************************************************************/
+
+static NTSTATUS dsgetdcname_cache_refresh(TALLOC_CTX *mem_ctx,
+                                         struct messaging_context *msg_ctx,
+                                         const char *domain_name,
+                                         struct GUID *domain_guid,
+                                         uint32_t flags,
+                                         const char *site_name,
+                                         struct netr_DsRGetDCNameInfo *info)
+{
+       struct netr_DsRGetDCNameInfo *dc_info;
+
+       return dsgetdcname(mem_ctx,
+                          msg_ctx,
+                          domain_name,
+                          domain_guid,
+                          site_name,
+                          flags | DS_FORCE_REDISCOVERY,
+                          &dc_info);
 }
 
 /****************************************************************
 ****************************************************************/
 
-static uint32_t get_cldap_reply_server_flags(union nbt_cldap_netlogon *r,
+static uint32_t get_cldap_reply_server_flags(struct netlogon_samlogon_response *r,
                                             uint32_t nt_version)
 {
-       switch (nt_version & 0x000000ff) {
+       switch (nt_version & 0x0000001f) {
                case 0:
                case 1:
+               case 16:
+               case 17:
                        return 0;
                case 2:
                case 3:
-                       return r->logon3.server_type;
+               case 18:
+               case 19:
+                       return r->data.nt5.server_type;
                case 4:
                case 5:
                case 6:
                case 7:
-                       return r->logon5.server_type;
+                       return r->data.nt5_ex.server_type;
                case 8:
                case 9:
                case 10:
@@ -240,16 +288,30 @@ static uint32_t get_cldap_reply_server_flags(union nbt_cldap_netlogon *r,
                case 13:
                case 14:
                case 15:
-                       return r->logon13.server_type;
+                       return r->data.nt5_ex.server_type;
+               case 20:
+               case 21:
+               case 22:
+               case 23:
+               case 24:
+               case 25:
+               case 26:
+               case 27:
+               case 28:
+                       return r->data.nt5_ex.server_type;
+               case 29:
+               case 30:
+               case 31:
+                       return r->data.nt5_ex.server_type;
                default:
-                       return r->logon29.server_type;
+                       return 0;
        }
 }
 
 /****************************************************************
 ****************************************************************/
 
-#define RETURN_ON_FALSE(x) if (!x) return false;
+#define RETURN_ON_FALSE(x) if (!(x)) return false;
 
 static bool check_cldap_reply_required_flags(uint32_t ret_flags,
                                             uint32_t req_flags)
@@ -298,6 +360,8 @@ static NTSTATUS dsgetdcname_cache_fetch(TALLOC_CTX *mem_ctx,
        DATA_BLOB blob;
        enum ndr_err_code ndr_err;
        struct netr_DsRGetDCNameInfo *info;
+       struct NETLOGON_SAM_LOGON_RESPONSE_EX r;
+       NTSTATUS status;
 
        if (!gencache_init()) {
                return NT_STATUS_INTERNAL_DB_ERROR;
@@ -317,8 +381,8 @@ static NTSTATUS dsgetdcname_cache_fetch(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_MEMORY;
        }
 
-       ndr_err = ndr_pull_struct_blob(&blob, mem_ctx, info,
-                     (ndr_pull_flags_fn_t)ndr_pull_netr_DsRGetDCNameInfo);
+       ndr_err = ndr_pull_struct_blob(&blob, mem_ctx, NULL, &r,
+                     (ndr_pull_flags_fn_t)ndr_pull_NETLOGON_SAM_LOGON_RESPONSE_EX);
 
        data_blob_free(&blob);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -326,6 +390,12 @@ static NTSTATUS dsgetdcname_cache_fetch(TALLOC_CTX *mem_ctx,
                return ndr_map_error2ntstatus(ndr_err);
        }
 
+       status = make_dc_info_from_cldap_reply(mem_ctx, flags, NULL,
+                                              &r, &info);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
        if (DEBUGLEVEL >= 10) {
                NDR_PRINT_DEBUG(netr_DsRGetDCNameInfo, info);
        }
@@ -350,6 +420,7 @@ static NTSTATUS dsgetdcname_cache_fetch(TALLOC_CTX *mem_ctx,
 ****************************************************************/
 
 static NTSTATUS dsgetdcname_cached(TALLOC_CTX *mem_ctx,
+                                  struct messaging_context *msg_ctx,
                                   const char *domain_name,
                                   struct GUID *domain_guid,
                                   uint32_t flags,
@@ -372,7 +443,8 @@ static NTSTATUS dsgetdcname_cached(TALLOC_CTX *mem_ctx,
        }
 
        if (expired) {
-               status = dsgetdcname_cache_refresh(mem_ctx, domain_name,
+               status = dsgetdcname_cache_refresh(mem_ctx, msg_ctx,
+                                                  domain_name,
                                                   domain_guid, flags,
                                                   site_name, *info);
                if (!NT_STATUS_IS_OK(status)) {
@@ -386,7 +458,8 @@ static NTSTATUS dsgetdcname_cached(TALLOC_CTX *mem_ctx,
 /****************************************************************
 ****************************************************************/
 
-static bool check_allowed_required_flags(uint32_t flags)
+static bool check_allowed_required_flags(uint32_t flags,
+                                        const char *site_name)
 {
        uint32_t return_type = flags & (DS_RETURN_FLAT_NAME|DS_RETURN_DNS_NAME);
        uint32_t offered_type = flags & (DS_IS_FLAT_NAME|DS_IS_DNS_NAME);
@@ -397,6 +470,10 @@ static bool check_allowed_required_flags(uint32_t flags)
 
        debug_dsdcinfo_flags(10, flags);
 
+       if ((flags & DS_TRY_NEXTCLOSEST_SITE) && site_name) {
+               return false;
+       }
+
        if (return_type == (DS_RETURN_FLAT_NAME|DS_RETURN_DNS_NAME)) {
                return false;
        }
@@ -552,11 +629,6 @@ static NTSTATUS discover_dc_dns(TALLOC_CTX *mem_ctx,
                r->port = dcs[count].port;
                r->hostname = dcs[count].hostname;
 
-               if (!(flags & DS_IP_REQUIRED)) {
-                       count++;
-                       continue;
-               }
-
                /* If we don't have an IP list for a name, lookup it up */
 
                if (!dcs[i].ss_s) {
@@ -584,7 +656,7 @@ static NTSTATUS discover_dc_dns(TALLOC_CTX *mem_ctx,
                 * back to netbios lookups is that our DNS server doesn't know
                 * anything about the DC's   -- jerry */
 
-               if (!is_zero_addr(&r->ss)) {
+               if (!is_zero_addr((struct sockaddr *)&r->ss)) {
                        count++;
                        continue;
                }
@@ -626,7 +698,12 @@ static NTSTATUS make_domain_controller_info(TALLOC_CTX *mem_ctx,
        }
 
        if (dc_address) {
-               info->dc_address = talloc_strdup(mem_ctx, dc_address);
+               if (!(dc_address[0] == '\\' && dc_address[1] == '\\')) {
+                       info->dc_address = talloc_asprintf(mem_ctx, "\\\\%s",
+                                                          dc_address);
+               } else {
+                       info->dc_address = talloc_strdup(mem_ctx, dc_address);
+               }
                NT_STATUS_HAVE_NO_MEMORY(info->dc_address);
        }
 
@@ -641,7 +718,7 @@ static NTSTATUS make_domain_controller_info(TALLOC_CTX *mem_ctx,
                NT_STATUS_HAVE_NO_MEMORY(info->domain_name);
        }
 
-       if (forest_name) {
+       if (forest_name && *forest_name) {
                info->forest_name = talloc_strdup(mem_ctx, forest_name);
                NT_STATUS_HAVE_NO_MEMORY(info->forest_name);
                flags |= DS_DNS_FOREST;
@@ -668,14 +745,52 @@ static NTSTATUS make_domain_controller_info(TALLOC_CTX *mem_ctx,
 /****************************************************************
 ****************************************************************/
 
+static void map_dc_and_domain_names(uint32_t flags,
+                                   const char *dc_name,
+                                   const char *domain_name,
+                                   const char *dns_dc_name,
+                                   const char *dns_domain_name,
+                                   uint32_t *dc_flags,
+                                   const char **hostname_p,
+                                   const char **domain_p)
+{
+       switch (flags & 0xf0000000) {
+               case DS_RETURN_FLAT_NAME:
+                       if (dc_name && domain_name &&
+                           *dc_name && *domain_name) {
+                               *hostname_p = dc_name;
+                               *domain_p = domain_name;
+                               break;
+                       }
+               case DS_RETURN_DNS_NAME:
+               default:
+                       if (dns_dc_name && dns_domain_name &&
+                           *dns_dc_name && *dns_domain_name) {
+                               *hostname_p = dns_dc_name;
+                               *domain_p = dns_domain_name;
+                               *dc_flags |= DS_DNS_DOMAIN | DS_DNS_CONTROLLER;
+                               break;
+                       }
+                       if (dc_name && domain_name &&
+                           *dc_name && *domain_name) {
+                               *hostname_p = dc_name;
+                               *domain_p = domain_name;
+                               break;
+                       }
+       }
+}
+
+/****************************************************************
+****************************************************************/
+
 static NTSTATUS make_dc_info_from_cldap_reply(TALLOC_CTX *mem_ctx,
                                              uint32_t flags,
                                              struct sockaddr_storage *ss,
-                                             uint32_t nt_version,
-                                             union nbt_cldap_netlogon *r,
+                                             struct NETLOGON_SAM_LOGON_RESPONSE_EX *r,
                                              struct netr_DsRGetDCNameInfo **info)
 {
-       const char *dc_hostname, *dc_domain_name;
+       const char *dc_hostname = NULL;
+       const char *dc_domain_name = NULL;
        const char *dc_address = NULL;
        const char *dc_forest = NULL;
        uint32_t dc_address_type = 0;
@@ -686,116 +801,34 @@ static NTSTATUS make_dc_info_from_cldap_reply(TALLOC_CTX *mem_ctx,
 
        char addr[INET6_ADDRSTRLEN];
 
-       print_sockaddr(addr, sizeof(addr), ss);
-
-       dc_address = talloc_asprintf(mem_ctx, "\\\\%s", addr);
-       NT_STATUS_HAVE_NO_MEMORY(dc_address);
-       dc_address_type = DS_ADDRESS_TYPE_INET;
-
-       switch (nt_version & 0x000000ff) {
-               case 0:
-                       return NT_STATUS_INVALID_PARAMETER;
-               case 1:
-                       dc_hostname     = r->logon1.pdc_name;
-                       dc_domain_name  = r->logon1.domain_name;
-                       if (flags & DS_PDC_REQUIRED) {
-                               dc_flags = NBT_SERVER_WRITABLE | NBT_SERVER_PDC;
-                       }
-                       break;
-               case 2:
-               case 3:
-                       switch (flags & 0xf0000000) {
-                               case DS_RETURN_FLAT_NAME:
-                                       dc_hostname     = r->logon3.pdc_name;
-                                       dc_domain_name  = r->logon3.domain_name;
-                                       break;
-                               case DS_RETURN_DNS_NAME:
-                               default:
-                                       dc_hostname     = r->logon3.pdc_dns_name;
-                                       dc_domain_name  = r->logon3.dns_domain;
-                                       dc_flags |= DS_DNS_DOMAIN | DS_DNS_CONTROLLER;
-                                       break;
-                       }
-
-                       dc_flags        |= r->logon3.server_type;
-                       dc_forest       = r->logon3.forest;
-                       dc_domain_guid  = &r->logon3.domain_uuid;
-
-                       break;
-               case 4:
-               case 5:
-               case 6:
-               case 7:
-                       switch (flags & 0xf0000000) {
-                               case DS_RETURN_FLAT_NAME:
-                                       dc_hostname     = r->logon5.pdc_name;
-                                       dc_domain_name  = r->logon5.domain;
-                                       break;
-                               case DS_RETURN_DNS_NAME:
-                               default:
-                                       dc_hostname     = r->logon5.pdc_dns_name;
-                                       dc_domain_name  = r->logon5.dns_domain;
-                                       dc_flags |= DS_DNS_DOMAIN | DS_DNS_CONTROLLER;
-                                       break;
-                       }
-
-                       dc_flags        |= r->logon5.server_type;
-                       dc_forest       = r->logon5.forest;
-                       dc_domain_guid  = &r->logon5.domain_uuid;
-                       dc_server_site  = r->logon5.server_site;
-                       dc_client_site  = r->logon5.client_site;
-
-                       break;
-               case 8:
-               case 9:
-               case 10:
-               case 11:
-               case 12:
-               case 13:
-               case 14:
-               case 15:
-                       switch (flags & 0xf0000000) {
-                               case DS_RETURN_FLAT_NAME:
-                                       dc_hostname     = r->logon13.pdc_name;
-                                       dc_domain_name  = r->logon13.domain;
-                                       break;
-                               case DS_RETURN_DNS_NAME:
-                               default:
-                                       dc_hostname     = r->logon13.pdc_dns_name;
-                                       dc_domain_name  = r->logon13.dns_domain;
-                                       dc_flags |= DS_DNS_DOMAIN | DS_DNS_CONTROLLER;
-                                       break;
-                       }
-
-                       dc_flags        |= r->logon13.server_type;
-                       dc_forest       = r->logon13.forest;
-                       dc_domain_guid  = &r->logon13.domain_uuid;
-                       dc_server_site  = r->logon13.server_site;
-                       dc_client_site  = r->logon13.client_site;
+       if (ss) {
+               print_sockaddr(addr, sizeof(addr), ss);
+               dc_address = addr;
+               dc_address_type = DS_ADDRESS_TYPE_INET;
+       }
 
-                       break;
-               default:
-                       switch (flags & 0xf0000000) {
-                               case DS_RETURN_FLAT_NAME:
-                                       dc_hostname     = r->logon29.pdc_name;
-                                       dc_domain_name  = r->logon29.domain;
-                                       break;
-                               case DS_RETURN_DNS_NAME:
-                               default:
-                                       dc_hostname     = r->logon29.pdc_dns_name;
-                                       dc_domain_name  = r->logon29.dns_domain;
-                                       dc_flags |= DS_DNS_DOMAIN | DS_DNS_CONTROLLER;
-                                       break;
-                       }
+       if (!ss && r->sockaddr.pdc_ip) {
+               dc_address      = r->sockaddr.pdc_ip;
+               dc_address_type = DS_ADDRESS_TYPE_INET;
+       } else {
+               dc_address      = r->pdc_name;
+               dc_address_type = DS_ADDRESS_TYPE_NETBIOS;
+       }
 
-                       dc_flags        |= r->logon29.server_type;
-                       dc_forest       = r->logon29.forest;
-                       dc_domain_guid  = &r->logon29.domain_uuid;
-                       dc_server_site  = r->logon29.server_site;
-                       dc_client_site  = r->logon29.client_site;
+       map_dc_and_domain_names(flags,
+                               r->pdc_name,
+                               r->domain,
+                               r->pdc_dns_name,
+                               r->dns_domain,
+                               &dc_flags,
+                               &dc_hostname,
+                               &dc_domain_name);
 
-                       break;
-       }
+       dc_flags        |= r->server_type;
+       dc_forest       = r->forest;
+       dc_domain_guid  = &r->domain_uuid;
+       dc_server_site  = r->server_site;
+       dc_client_site  = r->client_site;
 
        return make_domain_controller_info(mem_ctx,
                                           dc_hostname,
@@ -818,19 +851,19 @@ static uint32_t map_ds_flags_to_nt_version(uint32_t flags)
        uint32_t nt_version = 0;
 
        if (flags & DS_PDC_REQUIRED) {
-               nt_version |= NETLOGON_VERSION_PDC;
+               nt_version |= NETLOGON_NT_VERSION_PDC;
        }
 
        if (flags & DS_GC_SERVER_REQUIRED) {
-               nt_version |= NETLOGON_VERSION_GC;
+               nt_version |= NETLOGON_NT_VERSION_GC;
        }
 
        if (flags & DS_TRY_NEXTCLOSEST_SITE) {
-               nt_version |= NETLOGON_VERSION_WITH_CLOSEST_SITE;
+               nt_version |= NETLOGON_NT_VERSION_WITH_CLOSEST_SITE;
        }
 
        if (flags & DS_IP_REQUIRED) {
-               nt_version |= NETLOGON_VERSION_IP;
+               nt_version |= NETLOGON_NT_VERSION_IP;
        }
 
        return nt_version;
@@ -848,10 +881,11 @@ static NTSTATUS process_dc_dns(TALLOC_CTX *mem_ctx,
 {
        int i = 0;
        bool valid_dc = false;
-       union nbt_cldap_netlogon *r = NULL;
-       uint32_t nt_version = NETLOGON_VERSION_5 |
-                             NETLOGON_VERSION_5EX;
+       struct netlogon_samlogon_response *r = NULL;
+       uint32_t nt_version = NETLOGON_NT_VERSION_5 |
+                             NETLOGON_NT_VERSION_5EX;
        uint32_t ret_flags = 0;
+       NTSTATUS status;
 
        nt_version |= map_ds_flags_to_nt_version(flags);
 
@@ -861,9 +895,10 @@ static NTSTATUS process_dc_dns(TALLOC_CTX *mem_ctx,
 
                if (ads_cldap_netlogon(mem_ctx, dclist[i].hostname,
                                        domain_name,
-                                       &nt_version,
+                                       nt_version,
                                        &r))
                {
+                       nt_version = r->ntver;
                        ret_flags = get_cldap_reply_server_flags(r, nt_version);
 
                        if (check_cldap_reply_required_flags(ret_flags, flags)) {
@@ -879,8 +914,14 @@ static NTSTATUS process_dc_dns(TALLOC_CTX *mem_ctx,
                return NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
        }
 
-       return make_dc_info_from_cldap_reply(mem_ctx, flags, &dclist[i].ss,
-                                            nt_version, r, info);
+       status = make_dc_info_from_cldap_reply(mem_ctx, flags, &dclist[i].ss,
+                                              &r->data.nt5_ex, info);
+       if (NT_STATUS_IS_OK(status)) {
+               return store_cldap_reply(mem_ctx, flags, &dclist[i].ss,
+                                        nt_version, &r->data.nt5_ex);
+       }
+
+       return status;
 }
 
 /****************************************************************
@@ -914,6 +955,7 @@ static struct messaging_context *msg_context(TALLOC_CTX *mem_ctx)
 ****************************************************************/
 
 static NTSTATUS process_dc_netbios(TALLOC_CTX *mem_ctx,
+                                  struct messaging_context *msg_ctx,
                                   const char *domain_name,
                                   uint32_t flags,
                                   struct ip_service_name *dclist,
@@ -923,23 +965,19 @@ static NTSTATUS process_dc_netbios(TALLOC_CTX *mem_ctx,
        struct sockaddr_storage ss;
        struct ip_service ip_list;
        enum nbt_name_type name_type = NBT_NAME_LOGON;
-
+       NTSTATUS status;
        int i;
-       const char *dc_hostname, *dc_domain_name;
-       const char *dc_address;
-       uint32_t dc_address_type;
-       uint32_t dc_flags = 0;
        const char *dc_name = NULL;
-       const char *dc_forest = NULL;
-       const char *dc_server_site = NULL;
-       const char *dc_client_site = NULL;
-       struct GUID *dc_domain_guid = NULL;
        fstring tmp_dc_name;
-       struct messaging_context *msg_ctx = msg_context(mem_ctx);
-       struct nbt_ntlogon_packet *reply = NULL;
-       uint32_t nt_version = NETLOGON_VERSION_1 |
-                             NETLOGON_VERSION_5 |
-                             NETLOGON_VERSION_5EX_WITH_IP;
+       struct netlogon_samlogon_response *r = NULL;
+       bool store_cache = false;
+       uint32_t nt_version = NETLOGON_NT_VERSION_1 |
+                             NETLOGON_NT_VERSION_5 |
+                             NETLOGON_NT_VERSION_5EX_WITH_IP;
+
+       if (!msg_ctx) {
+               msg_ctx = msg_context(mem_ctx);
+       }
 
        if (flags & DS_PDC_REQUIRED) {
                name_type = NBT_NAME_PDC;
@@ -963,20 +1001,19 @@ static NTSTATUS process_dc_netbios(TALLOC_CTX *mem_ctx,
                                       NULL, nt_version))
                {
                        int k;
-                       smb_msleep(100);
+                       smb_msleep(300);
                        for (k=0; k<5; k++) {
                                if (receive_getdc_response(mem_ctx,
                                                           &dclist[i].ss,
                                                           domain_name,
+                                                          &nt_version,
                                                           &dc_name,
-                                                          &reply)) {
+                                                          &r)) {
+                                       store_cache = true;
                                        namecache_store(dc_name, NBT_NAME_SERVER, 1, &ip_list);
-                                       dc_hostname = dc_name;
-                                       dc_domain_name = talloc_strdup_upper(mem_ctx, domain_name);
-                                       NT_STATUS_HAVE_NO_MEMORY(dc_domain_name);
                                        goto make_reply;
                                }
-                               smb_msleep(500);
+                               smb_msleep(1500);
                        }
                }
 
@@ -986,71 +1023,50 @@ static NTSTATUS process_dc_netbios(TALLOC_CTX *mem_ctx,
                                     &dclist[i].ss,
                                     tmp_dc_name))
                {
-                       dc_hostname = tmp_dc_name;
-                       dc_domain_name = talloc_strdup_upper(mem_ctx, domain_name);
-                       namecache_store(tmp_dc_name, NBT_NAME_SERVER, 1, &ip_list);
-                       goto make_reply;
-               }
-       }
+                       struct NETLOGON_SAM_LOGON_RESPONSE_NT40 logon1;
 
-       return NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
+                       r = TALLOC_ZERO_P(mem_ctx, struct netlogon_samlogon_response);
+                       NT_STATUS_HAVE_NO_MEMORY(r);
 
- make_reply:
+                       ZERO_STRUCT(logon1);
+
+                       nt_version = NETLOGON_NT_VERSION_1;
+
+                       logon1.nt_version = nt_version;
+                       logon1.server = tmp_dc_name;
+                       logon1.domain = talloc_strdup_upper(mem_ctx, domain_name);
+                       NT_STATUS_HAVE_NO_MEMORY(logon1.domain);
 
-       if (reply && reply->command == NTLOGON_RESPONSE_FROM_PDC2) {
+                       r->data.nt4 = logon1;
+                       r->ntver = nt_version;
 
-               dc_flags |= reply->req.reply2.server_type;
-               dc_forest = reply->req.reply2.forest;
-               dc_server_site = reply->req.reply2.server_site;
-               dc_client_site = reply->req.reply2.client_site;
+                       map_netlogon_samlogon_response(r);
 
-               dc_domain_guid = &reply->req.reply2.domain_uuid;
+                       namecache_store(tmp_dc_name, NBT_NAME_SERVER, 1, &ip_list);
 
-               if (flags & DS_RETURN_DNS_NAME) {
-                       dc_domain_name = reply->req.reply2.dns_domain;
-                       dc_hostname = reply->req.reply2.pdc_dns_name;
-                       dc_flags |= DS_DNS_DOMAIN | DS_DNS_CONTROLLER;
-               } else if (flags & DS_RETURN_FLAT_NAME) {
-                       dc_domain_name = reply->req.reply2.domain;
-                       dc_hostname = reply->req.reply2.pdc_name;
+                       goto make_reply;
                }
        }
 
-       if (flags & DS_IP_REQUIRED) {
-               char addr[INET6_ADDRSTRLEN];
-               print_sockaddr(addr, sizeof(addr), &dclist[i].ss);
-               dc_address = talloc_asprintf(mem_ctx, "\\\\%s", addr);
-               dc_address_type = DS_ADDRESS_TYPE_INET;
-       } else {
-               dc_address = talloc_asprintf(mem_ctx, "\\\\%s", dc_hostname);
-               dc_address_type = DS_ADDRESS_TYPE_NETBIOS;
-       }
+       return NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
 
-       if (flags & DS_PDC_REQUIRED) {
-               dc_flags |= NBT_SERVER_PDC | NBT_SERVER_WRITABLE;
-       }
+ make_reply:
 
-       if (dc_forest) {
-               dc_flags |= DS_DNS_FOREST;
+       status = make_dc_info_from_cldap_reply(mem_ctx, flags, &dclist[i].ss,
+                                              &r->data.nt5_ex, info);
+       if (NT_STATUS_IS_OK(status) && store_cache) {
+               return store_cldap_reply(mem_ctx, flags, &dclist[i].ss,
+                                        nt_version, &r->data.nt5_ex);
        }
 
-       return make_domain_controller_info(mem_ctx,
-                                          dc_hostname,
-                                          dc_address,
-                                          dc_address_type,
-                                          dc_domain_guid,
-                                          dc_domain_name,
-                                          dc_forest,
-                                          dc_flags,
-                                          dc_server_site,
-                                          dc_client_site,
-                                          info);
+       return status;
 }
 
 /****************************************************************
 ****************************************************************/
 
 static NTSTATUS dsgetdcname_rediscover(TALLOC_CTX *mem_ctx,
+                                      struct messaging_context *msg_ctx,
                                       const char *domain_name,
                                       struct GUID *domain_guid,
                                       uint32_t flags,
@@ -1069,7 +1085,7 @@ static NTSTATUS dsgetdcname_rediscover(TALLOC_CTX *mem_ctx,
                                             &dclist, &num_dcs);
                NT_STATUS_NOT_OK_RETURN(status);
 
-               return process_dc_netbios(mem_ctx, domain_name, flags,
+               return process_dc_netbios(mem_ctx, msg_ctx, domain_name, flags,
                                          dclist, num_dcs, info);
        }
 
@@ -1099,10 +1115,31 @@ static NTSTATUS dsgetdcname_rediscover(TALLOC_CTX *mem_ctx,
                                     &num_dcs);
        NT_STATUS_NOT_OK_RETURN(status);
 
-       return process_dc_netbios(mem_ctx, domain_name, flags, dclist,
+       return process_dc_netbios(mem_ctx, msg_ctx, domain_name, flags, dclist,
                                  num_dcs, info);
 }
 
+static bool is_closest_site(struct netr_DsRGetDCNameInfo *info)
+{
+       if (info->dc_flags & DS_SERVER_CLOSEST) {
+               return true;
+       }
+
+       if (!info->client_site_name) {
+               return true;
+       }
+
+       if (!info->dc_site_name) {
+               return false;
+       }
+
+       if (strcmp(info->client_site_name, info->dc_site_name) == 0) {
+               return true;
+       }
+
+       return false;
+}
+
 /********************************************************************
  dsgetdcname.
 
@@ -1110,6 +1147,7 @@ static NTSTATUS dsgetdcname_rediscover(TALLOC_CTX *mem_ctx,
 ********************************************************************/
 
 NTSTATUS dsgetdcname(TALLOC_CTX *mem_ctx,
+                    struct messaging_context *msg_ctx,
                     const char *domain_name,
                     struct GUID *domain_guid,
                     const char *site_name,
@@ -1118,6 +1156,9 @@ NTSTATUS dsgetdcname(TALLOC_CTX *mem_ctx,
 {
        NTSTATUS status = NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND;
        struct netr_DsRGetDCNameInfo *myinfo = NULL;
+       char *query_site = NULL;
+       bool first = true;
+       struct netr_DsRGetDCNameInfo *first_info = NULL;
 
        DEBUG(10,("dsgetdcname: domain_name: %s, "
                  "domain_guid: %s, site_name: %s, flags: 0x%08x\n",
@@ -1127,119 +1168,57 @@ NTSTATUS dsgetdcname(TALLOC_CTX *mem_ctx,
 
        *info = NULL;
 
-       if (!check_allowed_required_flags(flags)) {
+       if (!check_allowed_required_flags(flags, site_name)) {
                DEBUG(0,("invalid flags specified\n"));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
+       if (!site_name) {
+               query_site = sitename_fetch(domain_name);
+       } else {
+               query_site = SMB_STRDUP(site_name);
+       }
+
        if (flags & DS_FORCE_REDISCOVERY) {
                goto rediscover;
        }
 
-       status = dsgetdcname_cached(mem_ctx, domain_name, domain_guid,
-                                   flags, site_name, &myinfo);
+       status = dsgetdcname_cached(mem_ctx, msg_ctx, domain_name, domain_guid,
+                                   flags, query_site, &myinfo);
        if (NT_STATUS_IS_OK(status)) {
-               *info = myinfo;
-               return status;
+               goto done;
        }
 
        if (flags & DS_BACKGROUND_ONLY) {
-               return status;
+               goto done;
        }
 
  rediscover:
-       status = dsgetdcname_rediscover(mem_ctx, domain_name,
-                                       domain_guid, flags, site_name,
+       status = dsgetdcname_rediscover(mem_ctx, msg_ctx, domain_name,
+                                       domain_guid, flags, query_site,
                                        &myinfo);
 
-       if (NT_STATUS_IS_OK(status)) {
-               dsgetdcname_cache_store(mem_ctx, domain_name, myinfo);
-               *info = myinfo;
-       }
-
-       return status;
-}
-
-/****************************************************************
-****************************************************************/
-
-bool pull_mailslot_cldap_reply(TALLOC_CTX *mem_ctx,
-                              const DATA_BLOB *blob,
-                              union nbt_cldap_netlogon *r,
-                              uint32_t *nt_version)
-{
-       enum ndr_err_code ndr_err;
-       uint32_t nt_version_query = ((*nt_version) & 0x000000ff);
-       uint16_t command = 0;
-
-       ndr_err = ndr_pull_struct_blob(blob, mem_ctx, &command,
-                       (ndr_pull_flags_fn_t)ndr_pull_uint16);
-       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               return false;
-       }
-
-       switch (command) {
-               case 0x13: /* 19 */
-               case 0x15: /* 21 */
-               case 0x17: /* 23 */
-                        break;
-               default:
-                       DEBUG(1,("got unexpected command: %d (0x%08x)\n",
-                               command, command));
-                       return false;
-       }
-
-       ndr_err = ndr_pull_union_blob_all(blob, mem_ctx, r, nt_version_query,
-                      (ndr_pull_flags_fn_t)ndr_pull_nbt_cldap_netlogon);
-       if (NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               goto done;
-       }
-
-       /* when the caller requested just those nt_version bits that the server
-        * was able to reply to, we are fine and all done. otherwise we need to
-        * assume downgraded replies which are painfully parsed here - gd */
+ done:
+       SAFE_FREE(query_site);
 
-       if (nt_version_query & NETLOGON_VERSION_WITH_CLOSEST_SITE) {
-               nt_version_query &= ~NETLOGON_VERSION_WITH_CLOSEST_SITE;
-       }
-       ndr_err = ndr_pull_union_blob_all(blob, mem_ctx, r, nt_version_query,
-                      (ndr_pull_flags_fn_t)ndr_pull_nbt_cldap_netlogon);
-       if (NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               goto done;
-       }
-       if (nt_version_query & NETLOGON_VERSION_5EX_WITH_IP) {
-               nt_version_query &= ~NETLOGON_VERSION_5EX_WITH_IP;
-       }
-       ndr_err = ndr_pull_union_blob_all(blob, mem_ctx, r, nt_version_query,
-                      (ndr_pull_flags_fn_t)ndr_pull_nbt_cldap_netlogon);
-       if (NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               goto done;
-       }
-       if (nt_version_query & NETLOGON_VERSION_5EX) {
-               nt_version_query &= ~NETLOGON_VERSION_5EX;
-       }
-       ndr_err = ndr_pull_union_blob_all(blob, mem_ctx, r, nt_version_query,
-                      (ndr_pull_flags_fn_t)ndr_pull_nbt_cldap_netlogon);
-       if (NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               goto done;
-       }
-       if (nt_version_query & NETLOGON_VERSION_5) {
-               nt_version_query &= ~NETLOGON_VERSION_5;
-       }
-       ndr_err = ndr_pull_union_blob_all(blob, mem_ctx, r, nt_version_query,
-                      (ndr_pull_flags_fn_t)ndr_pull_nbt_cldap_netlogon);
-       if (NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               goto done;
+       if (!NT_STATUS_IS_OK(status)) {
+               if (!first) {
+                       *info = first_info;
+                       return NT_STATUS_OK;
+               }
+               return status;
        }
 
-       return false;
-
- done:
-       if (DEBUGLEVEL >= 10) {
-               NDR_PRINT_UNION_DEBUG(nbt_cldap_netlogon, nt_version_query, r);
+       if (!first) {
+               TALLOC_FREE(first_info);
+       } else if (!is_closest_site(myinfo)) {
+               first = false;
+               first_info = myinfo;
+               /* TODO: may use the next_closest_site here */
+               query_site = SMB_STRDUP(myinfo->client_site_name);
+               goto rediscover;
        }
 
-       *nt_version = nt_version_query;
-
-       return true;
+       *info = myinfo;
+       return NT_STATUS_OK;
 }