Fix wb_trans_done after conversion to unix calling conventions
[ira/wip.git] / source3 / lib / wbclient.c
index d1f3190c79c03cce72eb4ca0722de79dc5c38b88..63401fad46232d6822df51046d7c6c3783e9f4bc 100644 (file)
 #include "includes.h"
 #include "wbc_async.h"
 
+wbcErr map_wbc_err_from_errno(int error)
+{
+       switch(error) {
+       case EPERM:
+       case EACCES:
+               return WBC_ERR_AUTH_ERROR;
+       case ENOMEM:
+               return WBC_ERR_NO_MEMORY;
+       case EIO:
+       default:
+               return WBC_ERR_UNKNOWN_FAILURE;
+       }
+}
+
+bool tevent_req_is_wbcerr(struct tevent_req *req, wbcErr *pwbc_err)
+{
+       enum tevent_req_state state;
+       uint64_t error;
+       if (!tevent_req_is_error(req, &state, &error)) {
+               *pwbc_err = WBC_ERR_SUCCESS;
+               return false;
+       }
+
+       switch (state) {
+       case TEVENT_REQ_USER_ERROR:
+               *pwbc_err = error;
+               break;
+       case TEVENT_REQ_TIMED_OUT:
+               *pwbc_err = WBC_ERR_UNKNOWN_FAILURE;
+               break;
+       case TEVENT_REQ_NO_MEMORY:
+               *pwbc_err = WBC_ERR_NO_MEMORY;
+               break;
+       default:
+               *pwbc_err = WBC_ERR_UNKNOWN_FAILURE;
+               break;
+       }
+       return true;
+}
+
+wbcErr tevent_req_simple_recv_wbcerr(struct tevent_req *req)
+{
+       wbcErr wbc_err;
+
+       if (tevent_req_is_wbcerr(req, &wbc_err)) {
+               return wbc_err;
+       }
+
+       return WBC_ERR_SUCCESS;
+}
+
+struct wb_context {
+       struct tevent_queue *queue;
+       int fd;
+       bool is_priv;
+};
+
 static int make_nonstd_fd(int fd)
 {
        int i;
@@ -109,27 +166,6 @@ static int make_safe_fd(int fd)
        return -1;
 }
 
-static bool winbind_closed_fd(int fd)
-{
-       struct timeval tv;
-       fd_set r_fds;
-
-       if (fd == -1) {
-               return true;
-       }
-
-       FD_ZERO(&r_fds);
-       FD_SET(fd, &r_fds);
-       ZERO_STRUCT(tv);
-
-       if ((select(fd+1, &r_fds, NULL, NULL, &tv) == -1)
-           || FD_ISSET(fd, &r_fds)) {
-               return true;
-       }
-
-       return false;
-}
-
 struct wb_context *wb_context_init(TALLOC_CTX *mem_ctx)
 {
        struct wb_context *result;
@@ -138,12 +174,13 @@ struct wb_context *wb_context_init(TALLOC_CTX *mem_ctx)
        if (result == NULL) {
                return NULL;
        }
-       result->queue = async_req_queue_init(result);
+       result->queue = tevent_queue_create(result, "wb_trans");
        if (result->queue == NULL) {
                TALLOC_FREE(result);
                return NULL;
        }
        result->fd = -1;
+       result->is_priv = false;
        return result;
 }
 
@@ -218,7 +255,7 @@ static struct tevent_req *wb_connect_send(TALLOC_CTX *mem_ctx,
        }
 
        subreq = async_connect_send(mem_ctx, ev, wb_ctx->fd,
-                                   (struct sockaddr *)&sunaddr,
+                                   (struct sockaddr *)(void *)&sunaddr,
                                    sizeof(sunaddr));
        if (subreq == NULL) {
                goto nomem;
@@ -259,136 +296,6 @@ static wbcErr wb_connect_recv(struct tevent_req *req)
        return tevent_req_simple_recv_wbcerr(req);
 }
 
-static struct winbindd_request *winbindd_request_copy(
-       TALLOC_CTX *mem_ctx,
-       const struct winbindd_request *req)
-{
-       struct winbindd_request *result;
-
-       result = (struct winbindd_request *)TALLOC_MEMDUP(
-               mem_ctx, req, sizeof(struct winbindd_request));
-       if (result == NULL) {
-               return NULL;
-       }
-
-       if (result->extra_len == 0) {
-               return result;
-       }
-
-       result->extra_data.data = (char *)TALLOC_MEMDUP(
-               result, result->extra_data.data, result->extra_len);
-       if (result->extra_data.data == NULL) {
-               TALLOC_FREE(result);
-               return NULL;
-       }
-       return result;
-}
-
-struct wb_int_trans_state {
-       struct tevent_context *ev;
-       int fd;
-       struct winbindd_request *wb_req;
-       struct winbindd_response *wb_resp;
-};
-
-static void wb_int_trans_write_done(struct tevent_req *subreq);
-static void wb_int_trans_read_done(struct tevent_req *subreq);
-
-static struct tevent_req *wb_int_trans_send(TALLOC_CTX *mem_ctx,
-                                           struct tevent_context *ev,
-                                           struct tevent_queue *queue, int fd,
-                                           struct winbindd_request *wb_req)
-{
-       struct tevent_req *result, *subreq;
-       struct wb_int_trans_state *state;
-
-       result = tevent_req_create(mem_ctx, &state,
-                                  struct wb_int_trans_state);
-       if (result == NULL) {
-               return NULL;
-       }
-
-       if (winbind_closed_fd(fd)) {
-               tevent_req_error(result, WBC_ERR_WINBIND_NOT_AVAILABLE);
-               return tevent_req_post(result, ev);
-       }
-
-       state->ev = ev;
-       state->fd = fd;
-       state->wb_req = wb_req;
-       state->wb_req->length = sizeof(struct winbindd_request);
-       state->wb_req->pid = getpid();
-
-       subreq = wb_req_write_send(state, state->ev, queue, state->fd,
-                                  state->wb_req);
-       if (subreq == NULL) {
-               goto fail;
-       }
-       tevent_req_set_callback(subreq, wb_int_trans_write_done, result);
-
-       return result;
-
- fail:
-       TALLOC_FREE(result);
-       return NULL;
-}
-
-static void wb_int_trans_write_done(struct tevent_req *subreq)
-{
-       struct tevent_req *req = tevent_req_callback_data(
-               subreq, struct tevent_req);
-       struct wb_int_trans_state *state = tevent_req_data(
-               req, struct wb_int_trans_state);
-       wbcErr wbc_err;
-
-       wbc_err = wb_req_write_recv(subreq);
-       TALLOC_FREE(subreq);
-       if (!WBC_ERROR_IS_OK(wbc_err)) {
-               tevent_req_error(req, wbc_err);
-               return;
-       }
-
-       subreq = wb_resp_read_send(state, state->ev, state->fd);
-       if (tevent_req_nomem(subreq, req)) {
-               return;
-       }
-       tevent_req_set_callback(subreq, wb_int_trans_read_done, req);
-}
-
-static void wb_int_trans_read_done(struct tevent_req *subreq)
-{
-       struct tevent_req *req = tevent_req_callback_data(
-               subreq, struct tevent_req);
-       struct wb_int_trans_state *state = tevent_req_data(
-               req, struct wb_int_trans_state);
-       wbcErr wbc_err;
-
-       wbc_err = wb_resp_read_recv(subreq, state, &state->wb_resp);
-       TALLOC_FREE(subreq);
-       if (!WBC_ERROR_IS_OK(wbc_err)) {
-               tevent_req_error(req, wbc_err);
-               return;
-       }
-
-       tevent_req_done(req);
-}
-
-static wbcErr wb_int_trans_recv(struct tevent_req *req,
-                               TALLOC_CTX *mem_ctx,
-                               struct winbindd_response **presponse)
-{
-       struct wb_int_trans_state *state = tevent_req_data(
-               req, struct wb_int_trans_state);
-       wbcErr wbc_err;
-
-       if (tevent_req_is_wbcerr(req, &wbc_err)) {
-               return wbc_err;
-       }
-
-       *presponse = talloc_move(mem_ctx, &state->wb_resp);
-       return WBC_ERR_SUCCESS;
-}
-
 static const char *winbindd_socket_dir(void)
 {
 #ifdef SOCKET_WRAPPER
@@ -467,9 +374,10 @@ static void wb_open_pipe_connect_nonpriv_done(struct tevent_req *subreq)
 
        ZERO_STRUCT(state->wb_req);
        state->wb_req.cmd = WINBINDD_INTERFACE_VERSION;
+       state->wb_req.pid = getpid();
 
-       subreq = wb_int_trans_send(state, state->ev, NULL, state->wb_ctx->fd,
-                                  &state->wb_req);
+       subreq = wb_simple_trans_send(state, state->ev, state->wb_ctx->queue,
+                                     state->wb_ctx->fd, &state->wb_req);
        if (tevent_req_nomem(subreq, req)) {
                return;
        }
@@ -483,12 +391,12 @@ static void wb_open_pipe_ping_done(struct tevent_req *subreq)
        struct wb_open_pipe_state *state = tevent_req_data(
                req, struct wb_open_pipe_state);
        struct winbindd_response *wb_resp;
-       wbcErr wbc_err;
+       int ret, err;
 
-       wbc_err = wb_int_trans_recv(subreq, state, &wb_resp);
+       ret = wb_simple_trans_recv(subreq, state, &wb_resp, &err);
        TALLOC_FREE(subreq);
-       if (!WBC_ERROR_IS_OK(wbc_err)) {
-               tevent_req_error(req, wbc_err);
+       if (ret == -1) {
+               tevent_req_error(req, map_wbc_err_from_errno(err));
                return;
        }
 
@@ -498,9 +406,10 @@ static void wb_open_pipe_ping_done(struct tevent_req *subreq)
        }
 
        state->wb_req.cmd = WINBINDD_PRIV_PIPE_DIR;
+       state->wb_req.pid = getpid();
 
-       subreq = wb_int_trans_send(state, state->ev, NULL, state->wb_ctx->fd,
-                                  &state->wb_req);
+       subreq = wb_simple_trans_send(state, state->ev, state->wb_ctx->queue,
+                                     state->wb_ctx->fd, &state->wb_req);
        if (tevent_req_nomem(subreq, req)) {
                return;
        }
@@ -514,12 +423,12 @@ static void wb_open_pipe_getpriv_done(struct tevent_req *subreq)
        struct wb_open_pipe_state *state = tevent_req_data(
                req, struct wb_open_pipe_state);
        struct winbindd_response *wb_resp = NULL;
-       wbcErr wbc_err;
+       int ret, err;
 
-       wbc_err = wb_int_trans_recv(subreq, state, &wb_resp);
+       ret = wb_simple_trans_recv(subreq, state, &wb_resp, &err);
        TALLOC_FREE(subreq);
-       if (!WBC_ERROR_IS_OK(wbc_err)) {
-               tevent_req_error(req, wbc_err);
+       if (ret == -1) {
+               tevent_req_error(req, map_wbc_err_from_errno(err));
                return;
        }
 
@@ -570,69 +479,54 @@ struct wb_trans_state {
 
 static void wb_trans_connect_done(struct tevent_req *subreq);
 static void wb_trans_done(struct tevent_req *subreq);
-static void wb_trans_retry_wait_done(struct async_req *subreq);
+static void wb_trans_retry_wait_done(struct tevent_req *subreq);
 
-static void wb_trigger_trans(struct async_req *req)
+struct tevent_req *wb_trans_send(TALLOC_CTX *mem_ctx,
+                                struct tevent_context *ev,
+                                struct wb_context *wb_ctx, bool need_priv,
+                                struct winbindd_request *wb_req)
 {
-       struct wb_trans_state *state = talloc_get_type_abort(
-               req->private_data, struct wb_trans_state);
-       struct tevent_req *subreq;
-
-       if ((state->wb_ctx->fd == -1)
-           || (state->need_priv && !state->wb_ctx->is_priv)) {
-
-               subreq = wb_open_pipe_send(state, state->ev, state->wb_ctx,
-                                          state->need_priv);
-               if (async_req_nomem(subreq, req)) {
-                       return;
-               }
-               tevent_req_set_callback(subreq, wb_trans_connect_done, req);
-               return;
-       }
-
-       subreq = wb_int_trans_send(state, state->ev, NULL, state->wb_ctx->fd,
-                                  state->wb_req);
-       if (async_req_nomem(subreq, req)) {
-               return;
-       }
-       tevent_req_set_callback(subreq, wb_trans_done, req);
-}
-
-struct async_req *wb_trans_send(TALLOC_CTX *mem_ctx, struct tevent_context *ev,
-                               struct wb_context *wb_ctx, bool need_priv,
-                               const struct winbindd_request *wb_req)
-{
-       struct async_req *result;
+       struct tevent_req *req, *subreq;
        struct wb_trans_state *state;
 
-       if (!async_req_setup(mem_ctx, &result, &state,
-                            struct wb_trans_state)) {
+       req = tevent_req_create(mem_ctx, &state, struct wb_trans_state);
+       if (req == NULL) {
                return NULL;
        }
        state->wb_ctx = wb_ctx;
        state->ev = ev;
-       state->wb_req = winbindd_request_copy(state, wb_req);
-       if (state->wb_req == NULL) {
-               goto fail;
-       }
+       state->wb_req = wb_req;
        state->num_retries = 10;
        state->need_priv = need_priv;
 
-       if (!async_req_enqueue(wb_ctx->queue, ev, result, wb_trigger_trans)) {
-               goto fail;
+       if ((wb_ctx->fd == -1) || (need_priv && !wb_ctx->is_priv)) {
+               subreq = wb_open_pipe_send(state, ev, wb_ctx, need_priv);
+               if (subreq == NULL) {
+                       goto fail;
+               }
+               tevent_req_set_callback(subreq, wb_trans_connect_done, req);
+               return req;
        }
-       return result;
 
+       state->wb_req->pid = getpid();
+
+       subreq = wb_simple_trans_send(state, ev, wb_ctx->queue, wb_ctx->fd,
+                                     wb_req);
+       if (subreq == NULL) {
+               goto fail;
+       }
+       tevent_req_set_callback(subreq, wb_trans_done, req);
+       return req;
  fail:
-       TALLOC_FREE(result);
+       TALLOC_FREE(req);
        return NULL;
 }
 
-static bool wb_trans_retry(struct async_req *req,
+static bool wb_trans_retry(struct tevent_req *req,
                           struct wb_trans_state *state,
                           wbcErr wbc_err)
 {
-       struct async_req *subreq;
+       struct tevent_req *subreq;
 
        if (WBC_ERROR_IS_OK(wbc_err)) {
                return false;
@@ -643,13 +537,13 @@ static bool wb_trans_retry(struct async_req *req,
                 * Winbind not around or we can't connect to the pipe. Fail
                 * immediately.
                 */
-               async_req_error(req, wbc_err);
+               tevent_req_error(req, wbc_err);
                return true;
        }
 
        state->num_retries -= 1;
        if (state->num_retries == 0) {
-               async_req_error(req, wbc_err);
+               tevent_req_error(req, wbc_err);
                return true;
        }
 
@@ -662,47 +556,44 @@ static bool wb_trans_retry(struct async_req *req,
                state->wb_ctx->fd = -1;
        }
 
-       subreq = async_wait_send(state, state->ev, timeval_set(1, 0));
-       if (async_req_nomem(subreq, req)) {
+       subreq = tevent_wakeup_send(state, state->ev,
+                                   timeval_current_ofs(1, 0));
+       if (tevent_req_nomem(subreq, req)) {
                return true;
        }
-
-       subreq->async.fn = wb_trans_retry_wait_done;
-       subreq->async.priv = req;
+       tevent_req_set_callback(subreq, wb_trans_retry_wait_done, req);
        return true;
 }
 
-static void wb_trans_retry_wait_done(struct async_req *subreq)
+static void wb_trans_retry_wait_done(struct tevent_req *subreq)
 {
-       struct async_req *req = talloc_get_type_abort(
-               subreq->async.priv, struct async_req);
-       struct wb_trans_state *state = talloc_get_type_abort(
-               req->private_data, struct wb_trans_state);
-       struct tevent_req *subreq2;
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct wb_trans_state *state = tevent_req_data(
+               req, struct wb_trans_state);
        bool ret;
 
-       ret = async_wait_recv(subreq);
+       ret = tevent_wakeup_recv(subreq);
        TALLOC_FREE(subreq);
-       if (ret) {
-               async_req_error(req, WBC_ERR_UNKNOWN_FAILURE);
+       if (!ret) {
+               tevent_req_error(req, WBC_ERR_UNKNOWN_FAILURE);
                return;
        }
 
-       subreq2 = wb_open_pipe_send(state, state->ev, state->wb_ctx,
-                                   state->need_priv);
-       if (async_req_nomem(subreq2, req)) {
+       subreq = wb_open_pipe_send(state, state->ev, state->wb_ctx,
+                                  state->need_priv);
+       if (tevent_req_nomem(subreq, req)) {
                return;
        }
-       tevent_req_set_callback(subreq2, wb_trans_connect_done, req);
+       tevent_req_set_callback(subreq, wb_trans_connect_done, req);
 }
 
 static void wb_trans_connect_done(struct tevent_req *subreq)
 {
-       struct async_req *req = tevent_req_callback_data(
-               subreq, struct async_req);
-       struct wb_trans_state *state = talloc_get_type_abort(
-               req->private_data, struct wb_trans_state);
-       struct tevent_req *subreq2;
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct wb_trans_state *state = tevent_req_data(
+               req, struct wb_trans_state);
        wbcErr wbc_err;
 
        wbc_err = wb_open_pipe_recv(subreq);
@@ -712,40 +603,40 @@ static void wb_trans_connect_done(struct tevent_req *subreq)
                return;
        }
 
-       subreq2 = wb_int_trans_send(state, state->ev, NULL, state->wb_ctx->fd,
-                                   state->wb_req);
-       if (async_req_nomem(subreq2, req)) {
+       subreq = wb_simple_trans_send(state, state->ev, state->wb_ctx->queue,
+                                     state->wb_ctx->fd, state->wb_req);
+       if (tevent_req_nomem(subreq, req)) {
                return;
        }
-       tevent_req_set_callback(subreq2, wb_trans_done, req);
+       tevent_req_set_callback(subreq, wb_trans_done, req);
 }
 
 static void wb_trans_done(struct tevent_req *subreq)
 {
-       struct async_req *req = tevent_req_callback_data(
-               subreq, struct async_req);
-       struct wb_trans_state *state = talloc_get_type_abort(
-               req->private_data, struct wb_trans_state);
-       wbcErr wbc_err;
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct wb_trans_state *state = tevent_req_data(
+               req, struct wb_trans_state);
+       int ret, err;
 
-       wbc_err = wb_int_trans_recv(subreq, state, &state->wb_resp);
+       ret = wb_simple_trans_recv(subreq, state, &state->wb_resp, &err);
        TALLOC_FREE(subreq);
-
-       if (wb_trans_retry(req, state, wbc_err)) {
+       if ((ret == -1)
+           && wb_trans_retry(req, state, map_wbc_err_from_errno(err))) {
                return;
        }
 
-       async_req_done(req);
+       tevent_req_done(req);
 }
 
-wbcErr wb_trans_recv(struct async_req *req, TALLOC_CTX *mem_ctx,
+wbcErr wb_trans_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
                     struct winbindd_response **presponse)
 {
-       struct wb_trans_state *state = talloc_get_type_abort(
-               req->private_data, struct wb_trans_state);
+       struct wb_trans_state *state = tevent_req_data(
+               req, struct wb_trans_state);
        wbcErr wbc_err;
 
-       if (async_req_is_wbcerr(req, &wbc_err)) {
+       if (tevent_req_is_wbcerr(req, &wbc_err)) {
                return wbc_err;
        }