Fix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....
[ira/wip.git] / source3 / lib / util_sock.c
index f77fcc9968bb5a9a39ed3e06baa79b5cc24de507..30a3b83be75894b56e6b2807116b258ca13e4530 100644 (file)
 
 #include "includes.h"
 
-/* the following 3 client_*() functions are nasty ways of allowing
-   some generic functions to get info that really should be hidden in
-   particular modules */
-static int client_fd = -1;
-/* What to print out on a client disconnect error. */
-static char client_ip_string[INET6_ADDRSTRLEN];
+/****************************************************************************
+ Return true if a string could be an IPv4 address.
+****************************************************************************/
+
+bool is_ipaddress_v4(const char *str)
+{
+       int ret = -1;
+       struct in_addr dest;
+
+       ret = inet_pton(AF_INET, str, &dest);
+       if (ret > 0) {
+               return true;
+       }
+       return false;
+}
 
 /****************************************************************************
Pritn out an IPv4 or IPv6 address from a struct sockaddr_storage.
Return true if a string could be an IPv4 or IPv6 address.
 ****************************************************************************/
 
-char *print_sockaddr(char *dest,
-                       size_t destlen,
-                       struct sockaddr_storage *psa)
+bool is_ipaddress(const char *str)
 {
-       if (destlen > 0) {
-               dest[0] = '\0';
+       int ret = -1;
+
+#if defined(HAVE_IPV6)
+       if (strchr_m(str, ':')) {
+               char addr[INET6_ADDRSTRLEN];
+               struct in6_addr dest6;
+               const char *sp = str;
+               char *p = strchr_m(str, '%');
+
+               /*
+                * Cope with link-local.
+                * This is IP:v6:addr%ifname.
+                */
+
+               if (p && (p > str) && (if_nametoindex(p+1) != 0)) {
+                       strlcpy(addr, str,
+                               MIN(PTR_DIFF(p,str)+1,
+                                       sizeof(addr)));
+                       sp = addr;
+               }
+               ret = inet_pton(AF_INET6, sp, &dest6);
+               if (ret > 0) {
+                       return true;
+               }
+       }
+#endif
+       return is_ipaddress_v4(str);
+}
+
+/****************************************************************************
+ Is a sockaddr_storage a broadcast address ?
+****************************************************************************/
+
+bool is_broadcast_addr(const struct sockaddr_storage *pss)
+{
+#if defined(HAVE_IPV6)
+       if (pss->ss_family == AF_INET6) {
+               const struct in6_addr *sin6 =
+                       &((const struct sockaddr_in6 *)pss)->sin6_addr;
+               return IN6_IS_ADDR_MULTICAST(sin6);
+       }
+#endif
+       if (pss->ss_family == AF_INET) {
+               uint32_t addr =
+               ntohl(((const struct sockaddr_in *)pss)->sin_addr.s_addr);
+               return addr == INADDR_BROADCAST;
+       }
+       return false;
+}
+
+/*******************************************************************
+ Wrap getaddrinfo...
+******************************************************************/
+
+static bool interpret_string_addr_internal(struct addrinfo **ppres,
+                                       const char *str, int flags)
+{
+       int ret;
+       struct addrinfo hints;
+
+       memset(&hints, '\0', sizeof(hints));
+       /* By default make sure it supports TCP. */
+       hints.ai_socktype = SOCK_STREAM;
+       hints.ai_flags = flags;
+
+       /* Linux man page on getaddinfo() says port will be
+          uninitialized when service string in NULL */
+
+       ret = getaddrinfo(str, NULL,
+                       &hints,
+                       ppres);
+
+       if (ret) {
+               DEBUG(3,("interpret_string_addr_internal: getaddrinfo failed "
+                       "for name %s [%s]\n",
+                       str,
+                       gai_strerror(ret) ));
+               return false;
+       }
+       return true;
+}
+
+/****************************************************************************
+ Interpret an internet address or name into an IP address in 4 byte form.
+ RETURNS IN NETWORK BYTE ORDER (big endian).
+****************************************************************************/
+
+uint32 interpret_addr(const char *str)
+{
+       uint32 ret;
+
+       /* If it's in the form of an IP address then
+        * get the lib to interpret it */
+       if (is_ipaddress_v4(str)) {
+               struct in_addr dest;
+
+               if (inet_pton(AF_INET, str, &dest) <= 0) {
+                       /* Error - this shouldn't happen ! */
+                       DEBUG(0,("interpret_addr: inet_pton failed "
+                               "host %s\n",
+                               str));
+                       return 0;
+               }
+               ret = dest.s_addr; /* NETWORK BYTE ORDER ! */
+       } else {
+               /* Otherwise assume it's a network name of some sort and use
+                       getadddrinfo. */
+               struct addrinfo *res = NULL;
+               struct addrinfo *res_list = NULL;
+               if (!interpret_string_addr_internal(&res_list,
+                                       str,
+                                       AI_ADDRCONFIG)) {
+                       DEBUG(3,("interpret_addr: Unknown host. %s\n",str));
+                       return 0;
+               }
+
+               /* Find the first IPv4 address. */
+               for (res = res_list; res; res = res->ai_next) {
+                       if (res->ai_family != AF_INET) {
+                               continue;
+                       }
+                       if (res->ai_addr == NULL) {
+                               continue;
+                       }
+                       break;
+               }
+               if(res == NULL) {
+                       DEBUG(3,("interpret_addr: host address is "
+                               "invalid for host %s\n",str));
+                       if (res_list) {
+                               freeaddrinfo(res_list);
+                       }
+                       return 0;
+               }
+               putip((char *)&ret,
+                       &((struct sockaddr_in *)res->ai_addr)->sin_addr.s_addr);
+               if (res_list) {
+                       freeaddrinfo(res_list);
+               }
+       }
+
+       /* This is so bogus - all callers need fixing... JRA. */
+       if (ret == (uint32)-1) {
+               return 0;
+       }
+
+       return ret;
+}
+
+/*******************************************************************
+ A convenient addition to interpret_addr().
+******************************************************************/
+
+struct in_addr *interpret_addr2(struct in_addr *ip, const char *str)
+{
+       uint32 a = interpret_addr(str);
+       ip->s_addr = a;
+       return ip;
+}
+
+/*******************************************************************
+ Map a text hostname or IP address (IPv4 or IPv6) into a
+ struct sockaddr_storage.
+******************************************************************/
+
+bool interpret_string_addr(struct sockaddr_storage *pss,
+               const char *str,
+               int flags)
+{
+       char addr[INET6_ADDRSTRLEN];
+       struct addrinfo *res = NULL;
+#if defined(HAVE_IPV6)
+       unsigned int scope_id = 0;
+
+       if (strchr_m(str, ':')) {
+               char *p = strchr_m(str, '%');
+
+               /*
+                * Cope with link-local.
+                * This is IP:v6:addr%ifname.
+                */
+
+               if (p && (p > str) && ((scope_id = if_nametoindex(p+1)) != 0)) {
+                       strlcpy(addr, str,
+                               MIN(PTR_DIFF(p,str)+1,
+                                       sizeof(addr)));
+                       str = addr;
+               }
        }
-#ifdef AF_INET6
+#endif
+
+       zero_addr(pss);
+
+       if (!interpret_string_addr_internal(&res, str, flags|AI_ADDRCONFIG)) {
+               return false;
+       }
+       if (!res) {
+               return false;
+       }
+       /* Copy the first sockaddr. */
+       memcpy(pss, res->ai_addr, res->ai_addrlen);
+
+#if defined(HAVE_IPV6)
+       if (pss->ss_family == AF_INET6 && scope_id) {
+               struct sockaddr_in6 *ps6 = (struct sockaddr_in6 *)pss;
+               if (IN6_IS_ADDR_LINKLOCAL(&ps6->sin6_addr) &&
+                               ps6->sin6_scope_id == 0) {
+                       ps6->sin6_scope_id = scope_id;
+               }
+       }
+#endif
+
+       freeaddrinfo(res);
+       return true;
+}
+
+/*******************************************************************
+ Check if an IPv7 is 127.0.0.1
+******************************************************************/
+
+bool is_loopback_ip_v4(struct in_addr ip)
+{
+       struct in_addr a;
+       a.s_addr = htonl(INADDR_LOOPBACK);
+       return(ip.s_addr == a.s_addr);
+}
+
+/*******************************************************************
+ Check if a struct sockaddr_storage is the loopback address.
+******************************************************************/
+
+bool is_loopback_addr(const struct sockaddr_storage *pss)
+{
+#if defined(HAVE_IPV6)
+       if (pss->ss_family == AF_INET6) {
+               struct in6_addr *pin6 =
+                       &((struct sockaddr_in6 *)pss)->sin6_addr;
+               return IN6_IS_ADDR_LOOPBACK(pin6);
+       }
+#endif
+       if (pss->ss_family == AF_INET) {
+               struct in_addr *pin = &((struct sockaddr_in *)pss)->sin_addr;
+               return is_loopback_ip_v4(*pin);
+       }
+       return false;
+}
+
+/*******************************************************************
+ Check if an IPv4 is 0.0.0.0.
+******************************************************************/
+
+bool is_zero_ip_v4(struct in_addr ip)
+{
+       uint32 a;
+       putip((char *)&a,(char *)&ip);
+       return(a == 0);
+}
+
+/*******************************************************************
+ Check if a struct sockaddr_storage has an unspecified address.
+******************************************************************/
+
+bool is_zero_addr(const struct sockaddr_storage *pss)
+{
+#if defined(HAVE_IPV6)
+       if (pss->ss_family == AF_INET6) {
+               struct in6_addr *pin6 =
+                       &((struct sockaddr_in6 *)pss)->sin6_addr;
+               return IN6_IS_ADDR_UNSPECIFIED(pin6);
+       }
+#endif
+       if (pss->ss_family == AF_INET) {
+               struct in_addr *pin = &((struct sockaddr_in *)pss)->sin_addr;
+               return is_zero_ip_v4(*pin);
+       }
+       return false;
+}
+
+/*******************************************************************
+ Set an IP to 0.0.0.0.
+******************************************************************/
+
+void zero_ip_v4(struct in_addr *ip)
+{
+       memset(ip, '\0', sizeof(struct in_addr));
+}
+
+/*******************************************************************
+ Set an address to INADDR_ANY.
+******************************************************************/
+
+void zero_addr(struct sockaddr_storage *pss)
+{
+       memset(pss, '\0', sizeof(*pss));
+       /* Ensure we're at least a valid sockaddr-storage. */
+       pss->ss_family = AF_INET;
+}
+
+/*******************************************************************
+ Are two IPs on the same subnet - IPv4 version ?
+********************************************************************/
+
+bool same_net_v4(struct in_addr ip1,struct in_addr ip2,struct in_addr mask)
+{
+       uint32 net1,net2,nmask;
+
+       nmask = ntohl(mask.s_addr);
+       net1  = ntohl(ip1.s_addr);
+       net2  = ntohl(ip2.s_addr);
+
+       return((net1 & nmask) == (net2 & nmask));
+}
+
+/*******************************************************************
+ Convert an IPv4 struct in_addr to a struct sockaddr_storage.
+********************************************************************/
+
+void in_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
+               struct in_addr ip)
+{
+       struct sockaddr_in *sa = (struct sockaddr_in *)ss;
+       memset(ss, '\0', sizeof(*ss));
+       ss->ss_family = AF_INET;
+       sa->sin_addr = ip;
+}
+
+#if defined(HAVE_IPV6)
+/*******************************************************************
+ Convert an IPv6 struct in_addr to a struct sockaddr_storage.
+********************************************************************/
+
+ void in6_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
+               struct in6_addr ip)
+{
+       struct sockaddr_in6 *sa = (struct sockaddr_in6 *)ss;
+       memset(ss, '\0', sizeof(*ss));
+       ss->ss_family = AF_INET6;
+       sa->sin6_addr = ip;
+}
+#endif
+
+/*******************************************************************
+ Are two IPs on the same subnet?
+********************************************************************/
+
+bool same_net(const struct sockaddr_storage *ip1,
+               const struct sockaddr_storage *ip2,
+               const struct sockaddr_storage *mask)
+{
+       if (ip1->ss_family != ip2->ss_family) {
+               /* Never on the same net. */
+               return false;
+       }
+
+#if defined(HAVE_IPV6)
+       if (ip1->ss_family == AF_INET6) {
+               struct sockaddr_in6 ip1_6 = *(struct sockaddr_in6 *)ip1;
+               struct sockaddr_in6 ip2_6 = *(struct sockaddr_in6 *)ip2;
+               struct sockaddr_in6 mask_6 = *(struct sockaddr_in6 *)mask;
+               char *p1 = (char *)&ip1_6.sin6_addr;
+               char *p2 = (char *)&ip2_6.sin6_addr;
+               char *m = (char *)&mask_6.sin6_addr;
+               int i;
+
+               for (i = 0; i < sizeof(struct in6_addr); i++) {
+                       *p1++ &= *m;
+                       *p2++ &= *m;
+                       m++;
+               }
+               return (memcmp(&ip1_6.sin6_addr,
+                               &ip2_6.sin6_addr,
+                               sizeof(struct in6_addr)) == 0);
+       }
+#endif
+       if (ip1->ss_family == AF_INET) {
+               return same_net_v4(((const struct sockaddr_in *)ip1)->sin_addr,
+                               ((const struct sockaddr_in *)ip2)->sin_addr,
+                               ((const struct sockaddr_in *)mask)->sin_addr);
+       }
+       return false;
+}
+
+/*******************************************************************
+ Are two sockaddr_storage's the same family and address ? Ignore port etc.
+********************************************************************/
+
+bool addr_equal(const struct sockaddr_storage *ip1,
+               const struct sockaddr_storage *ip2)
+{
+       if (ip1->ss_family != ip2->ss_family) {
+               /* Never the same. */
+               return false;
+       }
+
+#if defined(HAVE_IPV6)
+       if (ip1->ss_family == AF_INET6) {
+               return (memcmp(&((const struct sockaddr_in6 *)ip1)->sin6_addr,
+                               &((const struct sockaddr_in6 *)ip2)->sin6_addr,
+                               sizeof(struct in6_addr)) == 0);
+       }
+#endif
+       if (ip1->ss_family == AF_INET) {
+               return (memcmp(&((const struct sockaddr_in *)ip1)->sin_addr,
+                               &((const struct sockaddr_in *)ip2)->sin_addr,
+                               sizeof(struct in_addr)) == 0);
+       }
+       return false;
+}
+
+/****************************************************************************
+ Is an IP address the INADDR_ANY or in6addr_any value ?
+****************************************************************************/
+
+bool is_address_any(const struct sockaddr_storage *psa)
+{
+#if defined(HAVE_IPV6)
        if (psa->ss_family == AF_INET6) {
-               inet_ntop(AF_INET6,
-                       &((struct sockaddr_in6 *)psa)->sin6_addr,
-                       dest,
-                       destlen);
+               struct sockaddr_in6 *si6 = (struct sockaddr_in6 *)psa;
+               if (memcmp(&in6addr_any,
+                               &si6->sin6_addr,
+                               sizeof(in6addr_any)) == 0) {
+                       return true;
+               }
+               return false;
        }
 #endif
        if (psa->ss_family == AF_INET) {
-               inet_ntop(AF_INET,
-                       &((struct sockaddr_in *)psa)->sin_addr,
-                       dest,
-                       destlen);
+               struct sockaddr_in *si = (struct sockaddr_in *)psa;
+               if (si->sin_addr.s_addr == INADDR_ANY) {
+                       return true;
+               }
+               return false;
        }
+       return false;
+}
+
+/****************************************************************************
+ Get a port number in host byte order from a sockaddr_storage.
+****************************************************************************/
+
+uint16_t get_sockaddr_port(const struct sockaddr_storage *pss)
+{
+       uint16_t port = 0;
+
+       if (pss->ss_family != AF_INET) {
+#if defined(HAVE_IPV6)
+               /* IPv6 */
+               const struct sockaddr_in6 *sa6 =
+                       (const struct sockaddr_in6 *)pss;
+               port = ntohs(sa6->sin6_port);
+#endif
+       } else {
+               const struct sockaddr_in *sa =
+                       (const struct sockaddr_in *)pss;
+               port = ntohs(sa->sin_port);
+       }
+       return port;
+}
+
+/****************************************************************************
+ Print out an IPv4 or IPv6 address from a struct sockaddr_storage.
+****************************************************************************/
+
+static char *print_sockaddr_len(char *dest,
+                       size_t destlen,
+                       const struct sockaddr_storage *psa,
+                       socklen_t psalen)
+{
+       if (destlen > 0) {
+               dest[0] = '\0';
+       }
+       (void)sys_getnameinfo((const struct sockaddr *)psa,
+                       psalen,
+                       dest, destlen,
+                       NULL, 0,
+                       NI_NUMERICHOST);
        return dest;
 }
 
-void client_setfd(int fd)
+/****************************************************************************
+ Print out an IPv4 or IPv6 address from a struct sockaddr_storage.
+****************************************************************************/
+
+char *print_sockaddr(char *dest,
+                       size_t destlen,
+                       const struct sockaddr_storage *psa)
 {
-       client_fd = fd;
-       safe_strcpy(client_ip_string,
-                       get_peer_addr(client_fd),
-                       sizeof(client_ip_string)-1);
+       return print_sockaddr_len(dest, destlen, psa,
+                       sizeof(struct sockaddr_storage));
 }
 
-static char *get_socket_addr(int fd)
+/****************************************************************************
+ Print out a canonical IPv4 or IPv6 address from a struct sockaddr_storage.
+****************************************************************************/
+
+char *print_canonical_sockaddr(TALLOC_CTX *ctx,
+                       const struct sockaddr_storage *pss)
+{
+       char addr[INET6_ADDRSTRLEN];
+       char *dest = NULL;
+       int ret;
+
+       /* Linux getnameinfo() man pages says port is unitialized if
+          service name is NULL. */
+
+       ret = sys_getnameinfo((const struct sockaddr *)pss,
+                       sizeof(struct sockaddr_storage),
+                       addr, sizeof(addr),
+                       NULL, 0,
+                       NI_NUMERICHOST);
+       if (ret != 0) {
+               return NULL;
+       }
+
+       if (pss->ss_family != AF_INET) {
+#if defined(HAVE_IPV6)
+               dest = talloc_asprintf(ctx, "[%s]", addr);
+#else
+               return NULL;
+#endif
+       } else {
+               dest = talloc_asprintf(ctx, "%s", addr);
+       }
+       
+       return dest;
+}
+
+/****************************************************************************
+ Return the string of an IP address (IPv4 or IPv6).
+****************************************************************************/
+
+static const char *get_socket_addr(int fd, char *addr_buf, size_t addr_len)
 {
        struct sockaddr_storage sa;
        socklen_t length = sizeof(sa);
-       static char addr_buf[INET6_ADDRSTRLEN];
 
-       addr_buf[0] = '\0';
+       /* Ok, returning a hard coded IPv4 address
+        * is bogus, but it's just as bogus as a
+        * zero IPv6 address. No good choice here.
+        */
+
+       strlcpy(addr_buf, "0.0.0.0", addr_len);
 
        if (fd == -1) {
                return addr_buf;
@@ -82,9 +596,15 @@ static char *get_socket_addr(int fd)
                return addr_buf;
        }
 
-       return print_sockaddr(addr_buf, sizeof(addr_buf), &sa);
+       return print_sockaddr_len(addr_buf, addr_len, &sa, length);
 }
 
+#if 0
+/* Not currently used. JRA. */
+/****************************************************************************
+ Return the port number we've bound to on a socket.
+****************************************************************************/
+
 static int get_socket_port(int fd)
 {
        struct sockaddr_storage sa;
@@ -100,7 +620,7 @@ static int get_socket_port(int fd)
                return -1;
        }
 
-#ifdef AF_INET6
+#if defined(HAVE_IPV6)
        if (sa.ss_family == AF_INET6) {
                return ntohs(((struct sockaddr_in6 *)&sa)->sin6_port);
        }
@@ -110,34 +630,68 @@ static int get_socket_port(int fd)
        }
        return -1;
 }
+#endif
 
-char *client_name(void)
+void set_sockaddr_port(struct sockaddr_storage *psa, uint16 port)
 {
-       return get_peer_name(client_fd,False);
+#if defined(HAVE_IPV6)
+       if (psa->ss_family == AF_INET6) {
+               ((struct sockaddr_in6 *)psa)->sin6_port = htons(port);
+       }
+#endif
+       if (psa->ss_family == AF_INET) {
+               ((struct sockaddr_in *)psa)->sin_port = htons(port);
+       }
 }
 
-char *client_addr(void)
+const char *client_name(int fd)
 {
-       return get_peer_addr(client_fd);
+       return get_peer_name(fd,false);
 }
 
-char *client_socket_addr(void)
+const char *client_addr(int fd, char *addr, size_t addrlen)
 {
-       return get_socket_addr(client_fd);
+       return get_peer_addr(fd,addr,addrlen);
 }
 
-int client_socket_port(void)
+const char *client_socket_addr(int fd, char *addr, size_t addr_len)
 {
-       return get_socket_port(client_fd);
+       return get_socket_addr(fd, addr, addr_len);
 }
 
-int smb_read_error = 0;
+#if 0
+/* Not currently used. JRA. */
+int client_socket_port(int fd)
+{
+       return get_socket_port(fd);
+}
+#endif
+
+/****************************************************************************
+ Accessor functions to make thread-safe code easier later...
+****************************************************************************/
+
+void set_smb_read_error(enum smb_read_errors *pre,
+                       enum smb_read_errors newerr)
+{
+       if (pre) {
+               *pre = newerr;
+       }
+}
+
+void cond_set_smb_read_error(enum smb_read_errors *pre,
+                       enum smb_read_errors newerr)
+{
+       if (pre && *pre == SMB_READ_OK) {
+               *pre = newerr;
+       }
+}
 
 /****************************************************************************
  Determine if a file descriptor is in fact a socket.
 ****************************************************************************/
 
-BOOL is_a_socket(int fd)
+bool is_a_socket(int fd)
 {
        int v;
        socklen_t l;
@@ -236,18 +790,19 @@ static void print_socket_options(int s)
 
 void set_socket_options(int fd, const char *options)
 {
-       fstring tok;
+       TALLOC_CTX *ctx = talloc_stackframe();
+       char *tok;
 
-       while (next_token(&options,tok," \t,", sizeof(tok))) {
+       while (next_token_talloc(ctx, &options, &tok," \t,")) {
                int ret=0,i;
                int value = 1;
                char *p;
-               BOOL got_value = False;
+               bool got_value = false;
 
                if ((p = strchr_m(tok,'='))) {
                        *p = 0;
                        value = atoi(p+1);
-                       got_value = True;
+                       got_value = true;
                }
 
                for (i=0;socket_options[i].name;i++)
@@ -287,6 +842,7 @@ void set_socket_options(int fd, const char *options)
                }
        }
 
+       TALLOC_FREE(ctx);
        print_socket_options(fd);
 }
 
@@ -339,23 +895,21 @@ ssize_t read_udp_v4_socket(int fd,
  time_out = timeout in milliseconds
 ****************************************************************************/
 
-ssize_t read_socket_with_timeout(int fd,
-                               char *buf,
-                               size_t mincnt,
-                               size_t maxcnt,
-                               unsigned int time_out)
+NTSTATUS read_socket_with_timeout(int fd, char *buf,
+                                 size_t mincnt, size_t maxcnt,
+                                 unsigned int time_out,
+                                 size_t *size_ret)
 {
        fd_set fds;
        int selrtn;
        ssize_t readret;
        size_t nread = 0;
        struct timeval timeout;
+       char addr[INET6_ADDRSTRLEN];
 
        /* just checking .... */
        if (maxcnt <= 0)
-               return(0);
-
-       smb_read_error = 0;
+               return NT_STATUS_OK;
 
        /* Blocking read */
        if (time_out == 0) {
@@ -369,29 +923,27 @@ ssize_t read_socket_with_timeout(int fd,
                        if (readret == 0) {
                                DEBUG(5,("read_socket_with_timeout: "
                                        "blocking read. EOF from client.\n"));
-                               smb_read_error = READ_EOF;
-                               return -1;
+                               return NT_STATUS_END_OF_FILE;
                        }
 
                        if (readret == -1) {
-                               if (fd == client_fd) {
+                               if (fd == get_client_fd()) {
                                        /* Try and give an error message
                                         * saying what client failed. */
                                        DEBUG(0,("read_socket_with_timeout: "
                                                "client %s read error = %s.\n",
-                                               client_ip_string,
+                                               get_peer_addr(fd,addr,sizeof(addr)),
                                                strerror(errno) ));
                                } else {
                                        DEBUG(0,("read_socket_with_timeout: "
                                                "read error = %s.\n",
                                                strerror(errno) ));
                                }
-                               smb_read_error = READ_ERROR;
-                               return -1;
+                               return map_nt_error_from_unix(errno);
                        }
                        nread += readret;
                }
-               return((ssize_t)nread);
+               goto done;
        }
 
        /* Most difficult - timeout read */
@@ -413,27 +965,26 @@ ssize_t read_socket_with_timeout(int fd,
                /* Check if error */
                if (selrtn == -1) {
                        /* something is wrong. Maybe the socket is dead? */
-                       if (fd == client_fd) {
+                       if (fd == get_client_fd()) {
                                /* Try and give an error message saying
                                 * what client failed. */
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                "read for client %s. select error = %s.\n",
-                               client_ip_string, strerror(errno) ));
+                               get_peer_addr(fd,addr,sizeof(addr)),
+                               strerror(errno) ));
                        } else {
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                "read. select error = %s.\n",
                                strerror(errno) ));
                        }
-                       smb_read_error = READ_ERROR;
-                       return -1;
+                       return map_nt_error_from_unix(errno);
                }
 
                /* Did we timeout ? */
                if (selrtn == 0) {
                        DEBUG(10,("read_socket_with_timeout: timeout read. "
                                "select timed out.\n"));
-                       smb_read_error = READ_TIMEOUT;
-                       return -1;
+                       return NT_STATUS_IO_TIMEOUT;
                }
 
                readret = sys_read(fd, buf+nread, maxcnt-nread);
@@ -442,77 +993,44 @@ ssize_t read_socket_with_timeout(int fd,
                        /* we got EOF on the file descriptor */
                        DEBUG(5,("read_socket_with_timeout: timeout read. "
                                "EOF from client.\n"));
-                       smb_read_error = READ_EOF;
-                       return -1;
+                       return NT_STATUS_END_OF_FILE;
                }
 
                if (readret == -1) {
                        /* the descriptor is probably dead */
-                       if (fd == client_fd) {
+                       if (fd == get_client_fd()) {
                                /* Try and give an error message
                                 * saying what client failed. */
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                        "read to client %s. read error = %s.\n",
-                                       client_ip_string, strerror(errno) ));
+                                       get_peer_addr(fd,addr,sizeof(addr)),
+                                       strerror(errno) ));
                        } else {
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                        "read. read error = %s.\n",
                                        strerror(errno) ));
                        }
-                       smb_read_error = READ_ERROR;
-                       return -1;
+                       return map_nt_error_from_unix(errno);
                }
 
                nread += readret;
        }
 
+ done:
        /* Return the number we got */
-       return (ssize_t)nread;
+       if (size_ret) {
+               *size_ret = nread;
+       }
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
  Read data from the client, reading exactly N bytes.
 ****************************************************************************/
 
-ssize_t read_data(int fd,char *buffer,size_t N)
+NTSTATUS read_data(int fd, char *buffer, size_t N)
 {
-       ssize_t ret;
-       size_t total=0;
-
-       smb_read_error = 0;
-
-       while (total < N) {
-               ret = sys_read(fd,buffer + total,N - total);
-
-               if (ret == 0) {
-                       DEBUG(10,("read_data: read of %d returned 0. "
-                               "Error = %s\n",
-                               (int)(N - total), strerror(errno) ));
-                       smb_read_error = READ_EOF;
-                       return 0;
-               }
-
-               if (ret == -1) {
-                       if (fd == client_fd) {
-                               /* Try and give an error message saying
-                                * what client failed. */
-                               DEBUG(0,("read_data: read failure for %d "
-                                       "bytes to client %s. Error = %s\n",
-                                       (int)(N - total),
-                                       client_ip_string,
-                                       strerror(errno) ));
-                       } else {
-                               DEBUG(0,("read_data: read failure for %d. "
-                                       "Error = %s\n",
-                                       (int)(N - total),
-                                       strerror(errno) ));
-                       }
-                       smb_read_error = READ_ERROR;
-                       return -1;
-               }
-               total += ret;
-       }
-       return (ssize_t)total;
+       return read_socket_with_timeout(fd, buffer, N, N, 0, NULL);
 }
 
 /****************************************************************************
@@ -523,395 +1041,168 @@ ssize_t write_data(int fd, const char *buffer, size_t N)
 {
        size_t total=0;
        ssize_t ret;
+       char addr[INET6_ADDRSTRLEN];
 
-       while (total < N) {
-               ret = sys_write(fd,buffer + total,N - total);
-
-               if (ret == -1) {
-                       if (fd == client_fd) {
-                               /* Try and give an error message saying
-                                * what client failed. */
-                               DEBUG(0,("write_data: write failure in "
-                                       "writing to client %s. Error %s\n",
-                                       client_ip_string, strerror(errno) ));
-                       } else {
-                               DEBUG(0,("write_data: write failure. "
-                                       "Error = %s\n", strerror(errno) ));
-                       }
-                       return -1;
-               }
-
-               if (ret == 0) {
-                       return total;
-               }
-
-               total += ret;
-       }
-       return (ssize_t)total;
-}
-
-/****************************************************************************
- Send a keepalive packet (rfc1002).
-****************************************************************************/
-
-BOOL send_keepalive(int client)
-{
-       unsigned char buf[4];
-
-       buf[0] = SMBkeepalive;
-       buf[1] = buf[2] = buf[3] = 0;
-
-       return(write_data(client,(char *)buf,4) == 4);
-}
-
-/****************************************************************************
- Read 4 bytes of a smb packet and return the smb length of the packet.
- Store the result in the buffer.
- This version of the function will return a length of zero on receiving
- a keepalive packet.
- Timeout is in milliseconds.
-****************************************************************************/
-
-static ssize_t read_smb_length_return_keepalive(int fd,
-                                               char *inbuf,
-                                               unsigned int timeout)
-{
-       ssize_t len=0;
-       int msg_type;
-       BOOL ok = False;
-
-       while (!ok) {
-               if (timeout > 0) {
-                       ok = (read_socket_with_timeout(fd,inbuf,4,4,timeout)
-                                       == 4);
-               } else {
-                       ok = (read_data(fd,inbuf,4) == 4);
-               }
-               if (!ok) {
-                       return -1;
-               }
-
-               len = smb_len(inbuf);
-               msg_type = CVAL(inbuf,0);
-
-               if (msg_type == SMBkeepalive) {
-                       DEBUG(5,("Got keepalive packet\n"));
-               }
-       }
-
-       DEBUG(10,("got smb length of %lu\n",(unsigned long)len));
-
-       return(len);
-}
-
-/****************************************************************************
- Read 4 bytes of a smb packet and return the smb length of the packet.
- Store the result in the buffer. This version of the function will
- never return a session keepalive (length of zero).
- Timeout is in milliseconds.
-****************************************************************************/
-
-ssize_t read_smb_length(int fd, char *inbuf, unsigned int timeout)
-{
-       ssize_t len;
-
-       for(;;) {
-               len = read_smb_length_return_keepalive(fd, inbuf, timeout);
-
-               if(len < 0)
-                       return len;
-
-               /* Ignore session keepalives. */
-               if(CVAL(inbuf,0) != SMBkeepalive)
-                       break;
-       }
-
-       DEBUG(10,("read_smb_length: got smb length of %lu\n",
-                 (unsigned long)len));
-
-       return len;
-}
-
-/****************************************************************************
- Read an smb from a fd. Note that the buffer *MUST* be of size
- BUFFER_SIZE+SAFETY_MARGIN.
- The timeout is in milliseconds.
- This function will return on receipt of a session keepalive packet.
- maxlen is the max number of bytes to return, not including the 4 byte
- length. If zero it means BUFFER_SIZE+SAFETY_MARGIN limit.
- Doesn't check the MAC on signed packets.
-****************************************************************************/
-
-ssize_t receive_smb_raw(int fd,
-                       char *buffer,
-                       unsigned int timeout,
-                       size_t maxlen)
-{
-       ssize_t len,ret;
-
-       smb_read_error = 0;
-
-       len = read_smb_length_return_keepalive(fd,buffer,timeout);
-       if (len < 0) {
-               DEBUG(10,("receive_smb_raw: length < 0!\n"));
-
-               /*
-                * Correct fix. smb_read_error may have already been
-                * set. Only set it here if not already set. Global
-                * variables still suck :-). JRA.
-                */
-
-               if (smb_read_error == 0)
-                       smb_read_error = READ_ERROR;
-               return -1;
-       }
-
-       /*
-        * A WRITEX with CAP_LARGE_WRITEX can be 64k worth of data plus 65 bytes
-        * of header. Don't print the error if this fits.... JRA.
-        */
-
-       if (len > (BUFFER_SIZE + LARGE_WRITEX_HDR_SIZE)) {
-               DEBUG(0,("Invalid packet length! (%lu bytes).\n",
-                                       (unsigned long)len));
-               if (len > BUFFER_SIZE + (SAFETY_MARGIN/2)) {
-
-                       /*
-                        * Correct fix. smb_read_error may have already been
-                        * set. Only set it here if not already set. Global
-                        * variables still suck :-). JRA.
-                        */
-
-                       if (smb_read_error == 0)
-                               smb_read_error = READ_ERROR;
-                       return -1;
-               }
-       }
-
-       if(len > 0) {
-               if (maxlen) {
-                       len = MIN(len,maxlen);
-               }
-
-               if (timeout > 0) {
-                       ret = read_socket_with_timeout(fd,
-                                       buffer+4,
-                                       len,
-                                       len,
-                                       timeout);
-               } else {
-                       ret = read_data(fd,buffer+4,len);
-               }
-
-               if (ret != len) {
-                       if (smb_read_error == 0) {
-                               smb_read_error = READ_ERROR;
-                       }
-                       return -1;
-               }
-
-               /* not all of samba3 properly checks for packet-termination
-                * of strings. This ensures that we don't run off into
-                * empty space. */
-               SSVAL(buffer+4,len, 0);
-       }
-
-       return len;
-}
-
-static ssize_t receive_smb_raw_talloc(TALLOC_CTX *mem_ctx, int fd,
-                                     char **buffer, unsigned int timeout)
-{
-       char lenbuf[4];
-       ssize_t len,ret;
-
-       smb_read_error = 0;
-
-       len = read_smb_length_return_keepalive(fd, lenbuf, timeout);
-       if (len < 0) {
-               DEBUG(10,("receive_smb_raw: length < 0!\n"));
-
-               /*
-                * Correct fix. smb_read_error may have already been
-                * set. Only set it here if not already set. Global
-                * variables still suck :-). JRA.
-                */
-
-               if (smb_read_error == 0)
-                       smb_read_error = READ_ERROR;
-               return -1;
-       }
-
-       /*
-        * A WRITEX with CAP_LARGE_WRITEX can be 64k worth of data plus 65 bytes
-        * of header. Don't print the error if this fits.... JRA.
-        */
-
-       if (len > (BUFFER_SIZE + LARGE_WRITEX_HDR_SIZE)) {
-               DEBUG(0,("Invalid packet length! (%lu bytes).\n",
-                                       (unsigned long)len));
-               if (len > BUFFER_SIZE + (SAFETY_MARGIN/2)) {
-
-                       /*
-                        * Correct fix. smb_read_error may have already been
-                        * set. Only set it here if not already set. Global
-                        * variables still suck :-). JRA.
-                        */
+       while (total < N) {
+               ret = sys_write(fd,buffer + total,N - total);
 
-                       if (smb_read_error == 0)
-                               smb_read_error = READ_ERROR;
+               if (ret == -1) {
+                       if (fd == get_client_fd()) {
+                               /* Try and give an error message saying
+                                * what client failed. */
+                               DEBUG(0,("write_data: write failure in "
+                                       "writing to client %s. Error %s\n",
+                                       get_peer_addr(fd,addr,sizeof(addr)),
+                                       strerror(errno) ));
+                       } else {
+                               DEBUG(0,("write_data: write failure. "
+                                       "Error = %s\n", strerror(errno) ));
+                       }
                        return -1;
                }
-       }
-
-       /*
-        * The +4 here can't wrap, we've checked the length above already.
-        */
 
-       *buffer = TALLOC_ARRAY(mem_ctx, char, len+4);
+               if (ret == 0) {
+                       return total;
+               }
 
-       if (*buffer == NULL) {
-               DEBUG(0, ("Could not allocate inbuf of length %d\n",
-                         (int)len+4));
-               if (smb_read_error == 0)
-                       smb_read_error = READ_ERROR;
-               return -1;
+               total += ret;
        }
+       return (ssize_t)total;
+}
 
-       memcpy(*buffer, lenbuf, sizeof(lenbuf));
+/****************************************************************************
+ Send a keepalive packet (rfc1002).
+****************************************************************************/
 
-       if(len > 0) {
-               if (timeout > 0) {
-                       ret = read_socket_with_timeout(fd,(*buffer)+4, len,
-                                                      len, timeout);
-               } else {
-                       ret = read_data(fd, (*buffer)+4, len);
-               }
+bool send_keepalive(int client)
+{
+       unsigned char buf[4];
 
-               if (ret != len) {
-                       if (smb_read_error == 0) {
-                               smb_read_error = READ_ERROR;
-                       }
-                       return -1;
-               }
-       }
+       buf[0] = SMBkeepalive;
+       buf[1] = buf[2] = buf[3] = 0;
 
-       return len + 4;
+       return(write_data(client,(char *)buf,4) == 4);
 }
 
 /****************************************************************************
- Wrapper for receive_smb_raw().
- Checks the MAC on signed packets.
+ Read 4 bytes of a smb packet and return the smb length of the packet.
+ Store the result in the buffer.
+ This version of the function will return a length of zero on receiving
+ a keepalive packet.
+ Timeout is in milliseconds.
 ****************************************************************************/
 
-BOOL receive_smb(int fd, char *buffer, unsigned int timeout)
+NTSTATUS read_smb_length_return_keepalive(int fd, char *inbuf,
+                                         unsigned int timeout,
+                                         size_t *len)
 {
-       if (receive_smb_raw(fd, buffer, timeout, 0) < 0) {
-               return False;
-       }
+       int msg_type;
+       NTSTATUS status;
 
-       if (srv_encryption_on()) {
-               NTSTATUS status = srv_decrypt_buffer(buffer);
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0, ("receive_smb: SMB decryption failed "
-                               "on incoming packet! Error %s\n",
-                               nt_errstr(status) ));
-                       if (smb_read_error == 0) {
-                               smb_read_error = READ_BAD_DECRYPT;
-                       }
-                       return False;
-               }
+       status = read_socket_with_timeout(fd, inbuf, 4, 4, timeout, NULL);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       /* Check the incoming SMB signature. */
-       if (!srv_check_sign_mac(buffer, True)) {
-               DEBUG(0, ("receive_smb: SMB Signature verification "
-                       "failed on incoming packet!\n"));
-               if (smb_read_error == 0) {
-                       smb_read_error = READ_BAD_SIG;
-               }
-               return False;
+       *len = smb_len(inbuf);
+       msg_type = CVAL(inbuf,0);
+
+       if (msg_type == SMBkeepalive) {
+               DEBUG(5,("Got keepalive packet\n"));
        }
 
-       return True;
+       DEBUG(10,("got smb length of %lu\n",(unsigned long)(*len)));
+
+       return NT_STATUS_OK;
 }
 
-ssize_t receive_smb_talloc(TALLOC_CTX *mem_ctx, int fd, char **buffer,
-                          unsigned int timeout)
-{
-       ssize_t len;
+/****************************************************************************
+ Read 4 bytes of a smb packet and return the smb length of the packet.
+ Store the result in the buffer. This version of the function will
+ never return a session keepalive (length of zero).
+ Timeout is in milliseconds.
+****************************************************************************/
 
-       len = receive_smb_raw_talloc(mem_ctx, fd, buffer, timeout);
+NTSTATUS read_smb_length(int fd, char *inbuf, unsigned int timeout,
+                        size_t *len)
+{
+       uint8_t msgtype = SMBkeepalive;
 
-       if (len < 0) {
-               return -1;
-       }
+       while (msgtype == SMBkeepalive) {
+               NTSTATUS status;
 
-       if (srv_encryption_on()) {
-               NTSTATUS status = srv_decrypt_buffer(*buffer);
+               status = read_smb_length_return_keepalive(fd, inbuf, timeout,
+                                                         len);
                if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0, ("receive_smb: SMB decryption failed on "
-                                 "incoming packet! Error %s\n",
-                                 nt_errstr(status) ));
-                       if (smb_read_error == 0) {
-                               smb_read_error = READ_BAD_DECRYPT;
-                       }
-                       return -1;
+                       return status;
                }
-       }
 
-       /* Check the incoming SMB signature. */
-       if (!srv_check_sign_mac(*buffer, True)) {
-               DEBUG(0, ("receive_smb: SMB Signature verification failed on "
-                         "incoming packet!\n"));
-               if (smb_read_error == 0) {
-                       smb_read_error = READ_BAD_SIG;
-               }
-               return -1;
+               msgtype = CVAL(inbuf, 0);
        }
 
-       return len;
+       DEBUG(10,("read_smb_length: got smb length of %lu\n",
+                 (unsigned long)len));
+
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
- Send an smb to a fd.
+ Read an smb from a fd. Note that the buffer *MUST* be of size
+ BUFFER_SIZE+SAFETY_MARGIN.
+ The timeout is in milliseconds.
+ This function will return on receipt of a session keepalive packet.
+ maxlen is the max number of bytes to return, not including the 4 byte
+ length. If zero it means BUFFER_SIZE+SAFETY_MARGIN limit.
+ Doesn't check the MAC on signed packets.
 ****************************************************************************/
 
-BOOL send_smb(int fd, char *buffer)
+NTSTATUS receive_smb_raw(int fd, char *buffer, unsigned int timeout,
+                        size_t maxlen, size_t *p_len)
 {
        size_t len;
-       size_t nwritten=0;
-       ssize_t ret;
-       char *buf_out = buffer;
+       NTSTATUS status;
 
-       /* Sign the outgoing packet if required. */
-       srv_calculate_sign_mac(buf_out);
+       status = read_smb_length_return_keepalive(fd,buffer,timeout,&len);
 
-       if (srv_encryption_on()) {
-               NTSTATUS status = srv_encrypt_buffer(buffer, &buf_out);
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0, ("send_smb: SMB encryption failed "
-                               "on outgoing packet! Error %s\n",
-                               nt_errstr(status) ));
-                       return False;
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("receive_smb_raw: %s!\n", nt_errstr(status)));
+               return status;
+       }
+
+       /*
+        * A WRITEX with CAP_LARGE_WRITEX can be 64k worth of data plus 65 bytes
+        * of header. Don't print the error if this fits.... JRA.
+        */
+
+       if (len > (BUFFER_SIZE + LARGE_WRITEX_HDR_SIZE)) {
+               DEBUG(0,("Invalid packet length! (%lu bytes).\n",
+                                       (unsigned long)len));
+               if (len > BUFFER_SIZE + (SAFETY_MARGIN/2)) {
+                       return NT_STATUS_INVALID_PARAMETER;
                }
        }
 
-       len = smb_len(buf_out) + 4;
+       if(len > 0) {
+               if (maxlen) {
+                       len = MIN(len,maxlen);
+               }
+
+               status = read_socket_with_timeout(
+                       fd, buffer+4, len, len, timeout, &len);
 
-       while (nwritten < len) {
-               ret = write_data(fd,buf_out+nwritten,len - nwritten);
-               if (ret <= 0) {
-                       DEBUG(0,("Error writing %d bytes to client. %d. (%s)\n",
-                               (int)len,(int)ret, strerror(errno) ));
-                       srv_free_enc_buffer(buf_out);
-                       return False;
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
-               nwritten += ret;
+
+               /* not all of samba3 properly checks for packet-termination
+                * of strings. This ensures that we don't run off into
+                * empty space. */
+               SSVAL(buffer+4,len, 0);
        }
 
-       srv_free_enc_buffer(buf_out);
-       return True;
+       *p_len = len;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -919,24 +1210,28 @@ BOOL send_smb(int fd, char *buffer)
 ****************************************************************************/
 
 int open_socket_in(int type,
-               int port,
+               uint16_t port,
                int dlevel,
-               uint32 socket_addr,
-               BOOL rebind )
+               const struct sockaddr_storage *psock,
+               bool rebind)
 {
-       struct sockaddr_in sock;
+       struct sockaddr_storage sock;
        int res;
+       socklen_t slen = sizeof(struct sockaddr_in);
 
-       memset( (char *)&sock, '\0', sizeof(sock) );
+       sock = *psock;
 
-#ifdef HAVE_SOCK_SIN_LEN
-       sock.sin_len         = sizeof(sock);
+#if defined(HAVE_IPV6)
+       if (sock.ss_family == AF_INET6) {
+               ((struct sockaddr_in6 *)&sock)->sin6_port = htons(port);
+               slen = sizeof(struct sockaddr_in6);
+       }
 #endif
-       sock.sin_port        = htons( port );
-       sock.sin_family      = AF_INET;
-       sock.sin_addr.s_addr = socket_addr;
+       if (sock.ss_family == AF_INET) {
+               ((struct sockaddr_in *)&sock)->sin_port = htons(port);
+       }
 
-       res = socket( AF_INET, type, 0 );
+       res = socket(sock.ss_family, type, 0 );
        if( res == -1 ) {
                if( DEBUGLVL(0) ) {
                        dbgtext( "open_socket_in(): socket() call failed: " );
@@ -953,7 +1248,7 @@ int open_socket_in(int type,
                        if( DEBUGLVL( dlevel ) ) {
                                dbgtext( "open_socket_in(): setsockopt: " );
                                dbgtext( "SO_REUSEADDR = %s ",
-                                               val?"True":"False" );
+                                               val?"true":"false" );
                                dbgtext( "on port %d failed ", port );
                                dbgtext( "with error = %s\n", strerror(errno) );
                        }
@@ -964,29 +1259,30 @@ int open_socket_in(int type,
                        if( DEBUGLVL( dlevel ) ) {
                                dbgtext( "open_socket_in(): setsockopt: ");
                                dbgtext( "SO_REUSEPORT = %s ",
-                                               val?"True":"False" );
-                               dbgtext( "on port %d failed ", port );
-                               dbgtext( "with error = %s\n", strerror(errno) );
+                                               val?"true":"false");
+                               dbgtext( "on port %d failed ", port);
+                               dbgtext( "with error = %s\n", strerror(errno));
                        }
                }
 #endif /* SO_REUSEPORT */
        }
 
        /* now we've got a socket - we need to bind it */
-       if( bind( res, (struct sockaddr *)&sock, sizeof(sock) ) == -1 ) {
+       if (bind(res, (struct sockaddr *)&sock, slen) == -1 ) {
                if( DEBUGLVL(dlevel) && (port == SMB_PORT1 ||
                                port == SMB_PORT2 || port == NMB_PORT) ) {
-                       dbgtext( "bind failed on port %d ", port );
-                       dbgtext( "socket_addr = %s.\n",
-                                       inet_ntoa( sock.sin_addr ) );
-                       dbgtext( "Error = %s\n", strerror(errno) );
+                       char addr[INET6_ADDRSTRLEN];
+                       print_sockaddr(addr, sizeof(addr),
+                                       &sock);
+                       dbgtext( "bind failed on port %d ", port);
+                       dbgtext( "socket_addr = %s.\n", addr);
+                       dbgtext( "Error = %s\n", strerror(errno));
                }
-               close( res );
+               close(res);
                return -1;
        }
 
        DEBUG( 10, ( "bind succeeded on port %d\n", port ) );
-
        return( res );
  }
 
@@ -994,38 +1290,55 @@ int open_socket_in(int type,
  Create an outgoing socket. timeout is in milliseconds.
 **************************************************************************/
 
-int open_socket_out(int type, struct in_addr *addr, int port ,int timeout)
+int open_socket_out(int type,
+               const struct sockaddr_storage *pss,
+               uint16_t port,
+               int timeout)
 {
-       struct sockaddr_in sock_out;
+       char addr[INET6_ADDRSTRLEN];
+       struct sockaddr_storage sock_out = *pss;
        int res,ret;
        int connect_loop = 10;
        int increment = 10;
 
        /* create a socket to write to */
-       res = socket(PF_INET, type, 0);
+       res = socket(pss->ss_family, type, 0);
        if (res == -1) {
                 DEBUG(0,("socket error (%s)\n", strerror(errno)));
                return -1;
        }
 
-       if (type != SOCK_STREAM)
-               return(res);
-
-       memset((char *)&sock_out,'\0',sizeof(sock_out));
-       putip((char *)&sock_out.sin_addr,(char *)addr);
+       if (type != SOCK_STREAM) {
+               return res;
+       }
 
-       sock_out.sin_port = htons( port );
-       sock_out.sin_family = PF_INET;
+#if defined(HAVE_IPV6)
+       if (pss->ss_family == AF_INET6) {
+               struct sockaddr_in6 *psa6 = (struct sockaddr_in6 *)&sock_out;
+               psa6->sin6_port = htons(port);
+               if (psa6->sin6_scope_id == 0 &&
+                               IN6_IS_ADDR_LINKLOCAL(&psa6->sin6_addr)) {
+                       setup_linklocal_scope_id(&sock_out);
+               }
+       }
+#endif
+       if (pss->ss_family == AF_INET) {
+               struct sockaddr_in *psa = (struct sockaddr_in *)&sock_out;
+               psa->sin_port = htons(port);
+       }
 
        /* set it non-blocking */
-       set_blocking(res,False);
+       set_blocking(res,false);
 
-       DEBUG(3,("Connecting to %s at port %d\n",inet_ntoa(*addr),port));
+       print_sockaddr(addr, sizeof(addr), &sock_out);
+       DEBUG(3,("Connecting to %s at port %u\n",
+                               addr,
+                               (unsigned int)port));
 
        /* and connect it to the destination */
   connect_again:
 
-       ret = connect(res,(struct sockaddr *)&sock_out,sizeof(sock_out));
+       ret = sys_connect(res, (struct sockaddr *)&sock_out);
 
        /* Some systems return EAGAIN when they mean EINPROGRESS */
        if (ret < 0 && (errno == EINPROGRESS || errno == EALREADY ||
@@ -1042,8 +1355,9 @@ int open_socket_out(int type, struct in_addr *addr, int port ,int timeout)
 
        if (ret < 0 && (errno == EINPROGRESS || errno == EALREADY ||
                        errno == EAGAIN)) {
-               DEBUG(1,("timeout connecting to %s:%d\n",
-                                       inet_ntoa(*addr),port));
+               DEBUG(1,("timeout connecting to %s:%u\n",
+                                       addr,
+                                       (unsigned int)port));
                close(res);
                return -1;
        }
@@ -1057,13 +1371,15 @@ int open_socket_out(int type, struct in_addr *addr, int port ,int timeout)
 
        if (ret < 0) {
                DEBUG(2,("error connecting to %s:%d (%s)\n",
-                               inet_ntoa(*addr),port,strerror(errno)));
+                               addr,
+                               (unsigned int)port,
+                               strerror(errno)));
                close(res);
                return -1;
        }
 
        /* set it blocking again */
-       set_blocking(res,True);
+       set_blocking(res,true);
 
        return res;
 }
@@ -1074,12 +1390,12 @@ int open_socket_out(int type, struct in_addr *addr, int port ,int timeout)
  of DC's all of which are equivalent for our purposes.
 **************************************************************************/
 
-BOOL open_any_socket_out(struct sockaddr_in *addrs, int num_addrs,
+bool open_any_socket_out(struct sockaddr_storage *addrs, int num_addrs,
                         int timeout, int *fd_index, int *fd)
 {
        int i, resulting_index, res;
        int *sockets;
-       BOOL good_connect;
+       bool good_connect;
 
        fd_set r_fds, wr_fds;
        struct timeval tv;
@@ -1092,7 +1408,7 @@ BOOL open_any_socket_out(struct sockaddr_in *addrs, int num_addrs,
        sockets = SMB_MALLOC_ARRAY(int, num_addrs);
 
        if (sockets == NULL)
-               return False;
+               return false;
 
        resulting_index = -1;
 
@@ -1100,22 +1416,23 @@ BOOL open_any_socket_out(struct sockaddr_in *addrs, int num_addrs,
                sockets[i] = -1;
 
        for (i=0; i<num_addrs; i++) {
-               sockets[i] = socket(PF_INET, SOCK_STREAM, 0);
+               sockets[i] = socket(addrs[i].ss_family, SOCK_STREAM, 0);
                if (sockets[i] < 0)
                        goto done;
-               set_blocking(sockets[i], False);
+               set_blocking(sockets[i], false);
        }
 
  connect_again:
-       good_connect = False;
+       good_connect = false;
 
        for (i=0; i<num_addrs; i++) {
+               const struct sockaddr * a = 
+                   (const struct sockaddr *)&(addrs[i]);
 
                if (sockets[i] == -1)
                        continue;
 
-               if (connect(sockets[i], (struct sockaddr *)&(addrs[i]),
-                           sizeof(*addrs)) == 0) {
+               if (sys_connect(sockets[i], a) == 0) {
                        /* Rather unlikely as we are non-blocking, but it
                         * might actually happen. */
                        resulting_index = i;
@@ -1129,7 +1446,7 @@ BOOL open_any_socket_out(struct sockaddr_in *addrs, int num_addrs,
                    errno == EAGAIN || errno == EINTR) {
                        /* These are the error messages that something is
                           progressing. */
-                       good_connect = True;
+                       good_connect = true;
                } else if (errno != 0) {
                        /* There was a direct error */
                        close(sockets[i]);
@@ -1214,7 +1531,7 @@ BOOL open_any_socket_out(struct sockaddr_in *addrs, int num_addrs,
        if (resulting_index >= 0) {
                *fd_index = resulting_index;
                *fd = sockets[*fd_index];
-               set_blocking(*fd, True);
+               set_blocking(*fd, true);
        }
 
        free(sockets);
@@ -1230,9 +1547,9 @@ int open_udp_socket(const char *host, int port)
        int type = SOCK_DGRAM;
        struct sockaddr_in sock_out;
        int res;
-       struct in_addr *addr;
+       struct in_addr addr;
 
-       addr = interpret_addr2(host);
+       (void)interpret_addr2(&addr, host);
 
        res = socket(PF_INET, type, 0);
        if (res == -1) {
@@ -1240,11 +1557,11 @@ int open_udp_socket(const char *host, int port)
        }
 
        memset((char *)&sock_out,'\0',sizeof(sock_out));
-       putip((char *)&sock_out.sin_addr,(char *)addr);
+       putip((char *)&sock_out.sin_addr,(char *)&addr);
        sock_out.sin_port = htons(port);
        sock_out.sin_family = PF_INET;
 
-       if (connect(res,(struct sockaddr *)&sock_out,sizeof(sock_out))) {
+       if (sys_connect(res,(struct sockaddr *)&sock_out)) {
                close(res);
                return -1;
        }
@@ -1252,41 +1569,95 @@ int open_udp_socket(const char *host, int port)
        return res;
 }
 
+/*******************************************************************
+ Return the IP addr of the remote end of a socket as a string.
+ Optionally return the struct sockaddr_storage.
+ ******************************************************************/
+
+static const char *get_peer_addr_internal(int fd,
+                               char *addr_buf,
+                               size_t addr_buf_len,
+                               struct sockaddr_storage *pss,
+                               socklen_t *plength)
+{
+       struct sockaddr_storage ss;
+       socklen_t length = sizeof(ss);
+
+       strlcpy(addr_buf,"0.0.0.0",addr_buf_len);
+
+       if (fd == -1) {
+               return addr_buf;
+       }
+
+       if (pss == NULL) {
+               pss = &ss;
+       }
+       if (plength == NULL) {
+               plength = &length;
+       }
+
+       if (getpeername(fd, (struct sockaddr *)pss, plength) < 0) {
+               DEBUG(0,("getpeername failed. Error was %s\n",
+                                       strerror(errno) ));
+               return addr_buf;
+       }
+
+       print_sockaddr_len(addr_buf,
+                       addr_buf_len,
+                       pss,
+                       *plength);
+       return addr_buf;
+}
+
 /*******************************************************************
  Matchname - determine if host name matches IP address. Used to
  confirm a hostname lookup to prevent spoof attacks.
 ******************************************************************/
 
-static BOOL matchname(char *remotehost,struct in_addr  addr)
+static bool matchname(const char *remotehost,
+               const struct sockaddr_storage *pss,
+               socklen_t len)
 {
-       struct hostent *hp;
-       int     i;
-
-       if ((hp = sys_gethostbyname(remotehost)) == 0) {
-               DEBUG(0,("sys_gethostbyname(%s): lookup failure.\n",
-                                       remotehost));
-               return False;
+       struct addrinfo *res = NULL;
+       struct addrinfo *ailist = NULL;
+       char addr_buf[INET6_ADDRSTRLEN];
+       bool ret = interpret_string_addr_internal(&ailist,
+                       remotehost,
+                       AI_ADDRCONFIG|AI_CANONNAME);
+
+       if (!ret || ailist == NULL) {
+               DEBUG(3,("matchname: getaddrinfo failed for "
+                       "name %s [%s]\n",
+                       remotehost,
+                       gai_strerror(ret) ));
+               return false;
        }
 
        /*
-        * Make sure that gethostbyname() returns the "correct" host name.
-        * Unfortunately, gethostbyname("localhost") sometimes yields
-        * "localhost.domain". Since the latter host name comes from the
-        * local DNS, we just have to trust it (all bets are off if the local
-        * DNS is perverted). We always check the address list, though.
+        * Make sure that getaddrinfo() returns the "correct" host name.
         */
 
-       if (!strequal(remotehost, hp->h_name)
-           && !strequal(remotehost, "localhost")) {
-               DEBUG(0,("host name/name mismatch: %s != %s\n",
-                        remotehost, hp->h_name));
-               return False;
+       if (ailist->ai_canonname == NULL ||
+               (!strequal(remotehost, ailist->ai_canonname) &&
+                !strequal(remotehost, "localhost"))) {
+               DEBUG(0,("matchname: host name/name mismatch: %s != %s\n",
+                        remotehost,
+                        ailist->ai_canonname ?
+                                ailist->ai_canonname : "(NULL)"));
+               freeaddrinfo(ailist);
+               return false;
        }
 
        /* Look up the host address in the address list we just got. */
-       for (i = 0; hp->h_addr_list[i]; i++) {
-               if (memcmp(hp->h_addr_list[i], (char *)&addr,sizeof(addr)) == 0)
-                       return True;
+       for (res = ailist; res; res = res->ai_next) {
+               if (!res->ai_addr) {
+                       continue;
+               }
+               if (addr_equal((const struct sockaddr_storage *)res->ai_addr,
+                                       pss)) {
+                       freeaddrinfo(ailist);
+                       return true;
+               }
        }
 
        /*
@@ -1295,56 +1666,134 @@ static BOOL matchname(char *remotehost,struct in_addr  addr)
         * it, but that could be dangerous, too.
         */
 
-       DEBUG(0,("host name/address mismatch: %s != %s\n",
-                inet_ntoa(addr), hp->h_name));
-       return False;
+       DEBUG(0,("matchname: host name/address mismatch: %s != %s\n",
+               print_sockaddr_len(addr_buf,
+                       sizeof(addr_buf),
+                       pss,
+                       len),
+                ailist->ai_canonname ? ailist->ai_canonname : "(NULL)"));
+
+       if (ailist) {
+               freeaddrinfo(ailist);
+       }
+       return false;
+}
+
+/*******************************************************************
+ Deal with the singleton cache.
+******************************************************************/
+
+struct name_addr_pair {
+       struct sockaddr_storage ss;
+       const char *name;
+};
+
+/*******************************************************************
+ Lookup a name/addr pair. Returns memory allocated from memcache.
+******************************************************************/
+
+static bool lookup_nc(struct name_addr_pair *nc)
+{
+       DATA_BLOB tmp;
+
+       ZERO_STRUCTP(nc);
+
+       if (!memcache_lookup(
+                       NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_peer_name"),
+                       &tmp)) {
+               return false;
+       }
+
+       memcpy(&nc->ss, tmp.data, sizeof(nc->ss));
+       nc->name = (const char *)tmp.data + sizeof(nc->ss);
+       return true;
+}
+
+/*******************************************************************
+ Save a name/addr pair.
+******************************************************************/
+
+static void store_nc(const struct name_addr_pair *nc)
+{
+       DATA_BLOB tmp;
+       size_t namelen = strlen(nc->name);
+
+       tmp = data_blob(NULL, sizeof(nc->ss) + namelen + 1);
+       if (!tmp.data) {
+               return;
+       }
+       memcpy(tmp.data, &nc->ss, sizeof(nc->ss));
+       memcpy(tmp.data+sizeof(nc->ss), nc->name, namelen+1);
+
+       memcache_add(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_peer_name"),
+                       tmp);
+       data_blob_free(&tmp);
 }
 
 /*******************************************************************
  Return the DNS name of the remote end of a socket.
 ******************************************************************/
 
-char *get_peer_name(int fd, BOOL force_lookup)
+const char *get_peer_name(int fd, bool force_lookup)
 {
-       static pstring name_buf;
-       pstring tmp_name;
-       static fstring addr_buf;
-       struct hostent *hp;
-       struct in_addr addr;
-       char *p;
+       struct name_addr_pair nc;
+       char addr_buf[INET6_ADDRSTRLEN];
+       struct sockaddr_storage ss;
+       socklen_t length = sizeof(ss);
+       const char *p;
+       int ret;
+       char name_buf[MAX_DNS_NAME_LENGTH];
+       char tmp_name[MAX_DNS_NAME_LENGTH];
 
        /* reverse lookups can be *very* expensive, and in many
           situations won't work because many networks don't link dhcp
           with dns. To avoid the delay we avoid the lookup if
           possible */
-       if (!lp_hostname_lookups() && (force_lookup == False)) {
-               return get_peer_addr(fd);
+       if (!lp_hostname_lookups() && (force_lookup == false)) {
+               length = sizeof(nc.ss);
+               nc.name = get_peer_addr_internal(fd, addr_buf, sizeof(addr_buf),
+                       &nc.ss, &length);
+               store_nc(&nc);
+               lookup_nc(&nc);
+               return nc.name ? nc.name : "UNKNOWN";
        }
 
-       p = get_peer_addr(fd);
+       lookup_nc(&nc);
 
-       /* it might be the same as the last one - save some DNS work */
-       if (strcmp(p, addr_buf) == 0)
-               return name_buf;
-
-       pstrcpy(name_buf,"UNKNOWN");
-       if (fd == -1)
-               return name_buf;
+       memset(&ss, '\0', sizeof(ss));
+       p = get_peer_addr_internal(fd, addr_buf, sizeof(addr_buf), &ss, &length);
 
-       fstrcpy(addr_buf, p);
+       /* it might be the same as the last one - save some DNS work */
+       if (addr_equal(&ss, &nc.ss)) {
+               return nc.name ? nc.name : "UNKNOWN";
+       }
 
-       addr = *interpret_addr2(p);
+       /* Not the same. We need to lookup. */
+       if (fd == -1) {
+               return "UNKNOWN";
+       }
 
        /* Look up the remote host name. */
-       if ((hp = gethostbyaddr((char *)&addr.s_addr,
-                                       sizeof(addr.s_addr), AF_INET)) == 0) {
-               DEBUG(1,("Gethostbyaddr failed for %s\n",p));
-               pstrcpy(name_buf, p);
+       ret = sys_getnameinfo((struct sockaddr *)&ss,
+                       length,
+                       name_buf,
+                       sizeof(name_buf),
+                       NULL,
+                       0,
+                       0);
+
+       if (ret) {
+               DEBUG(1,("get_peer_name: getnameinfo failed "
+                       "for %s with error %s\n",
+                       p,
+                       gai_strerror(ret)));
+               strlcpy(name_buf, p, sizeof(name_buf));
        } else {
-               pstrcpy(name_buf,(char *)hp->h_name);
-               if (!matchname(name_buf, addr)) {
+               if (!matchname(name_buf, &ss, length)) {
                        DEBUG(0,("Matchname failed on %s %s\n",name_buf,p));
-                       pstrcpy(name_buf,"UNKNOWN");
+                       strlcpy(name_buf,"UNKNOWN",sizeof(name_buf));
                }
        }
 
@@ -1352,41 +1801,27 @@ char *get_peer_name(int fd, BOOL force_lookup)
           use --enable-developer or the clobber_region() call will
           get you */
 
-       pstrcpy( tmp_name, name_buf );
+       strlcpy(tmp_name, name_buf, sizeof(tmp_name));
        alpha_strcpy(name_buf, tmp_name, "_-.", sizeof(name_buf));
        if (strstr(name_buf,"..")) {
-               pstrcpy(name_buf, "UNKNOWN");
+               strlcpy(name_buf, "UNKNOWN", sizeof(name_buf));
        }
 
-       return name_buf;
+       nc.name = name_buf;
+       nc.ss = ss;
+
+       store_nc(&nc);
+       lookup_nc(&nc);
+       return nc.name ? nc.name : "UNKNOWN";
 }
 
 /*******************************************************************
  Return the IP addr of the remote end of a socket as a string.
  ******************************************************************/
 
-char *get_peer_addr(int fd)
+const char *get_peer_addr(int fd, char *addr, size_t addr_len)
 {
-       struct sockaddr sa;
-       struct sockaddr_in *sockin = (struct sockaddr_in *) (&sa);
-       socklen_t length = sizeof(sa);
-       static fstring addr_buf;
-
-       fstrcpy(addr_buf,"0.0.0.0");
-
-       if (fd == -1) {
-               return addr_buf;
-       }
-
-       if (getpeername(fd, &sa, &length) < 0) {
-               DEBUG(0,("getpeername failed. Error was %s\n",
-                                       strerror(errno) ));
-               return addr_buf;
-       }
-
-       fstrcpy(addr_buf,(char *)inet_ntoa(sockin->sin_addr));
-
-       return addr_buf;
+       return get_peer_addr_internal(fd, addr, addr_len, NULL, NULL);
 }
 
 /*******************************************************************
@@ -1406,7 +1841,7 @@ int create_pipe_sock(const char *socket_dir,
        struct stat st;
        int sock;
        mode_t old_umask;
-       pstring path;
+       char *path = NULL;
 
        old_umask = umask(0);
 
@@ -1446,16 +1881,19 @@ int create_pipe_sock(const char *socket_dir,
        sock = socket(AF_UNIX, SOCK_STREAM, 0);
 
        if (sock == -1) {
-               perror("socket");
-                goto out_umask;
+               DEBUG(0, ("create_pipe_sock: socket error %s\n",
+                       strerror(errno) ));
+                goto out_close;
        }
 
-       pstr_sprintf(path, "%s/%s", socket_dir, socket_name);
+       if (asprintf(&path, "%s/%s", socket_dir, socket_name) == -1) {
+                goto out_close;
+       }
 
        unlink(path);
        memset(&sunaddr, 0, sizeof(sunaddr));
        sunaddr.sun_family = AF_UNIX;
-       safe_strcpy(sunaddr.sun_path, path, sizeof(sunaddr.sun_path)-1);
+       strlcpy(sunaddr.sun_path, path, sizeof(sunaddr.sun_path));
 
        if (bind(sock, (struct sockaddr *)&sunaddr, sizeof(sunaddr)) == -1) {
                DEBUG(0, ("bind failed on pipe socket %s: %s\n", path,
@@ -1469,11 +1907,15 @@ int create_pipe_sock(const char *socket_dir,
                goto out_close;
        }
 
+       SAFE_FREE(path);
+
        umask(old_umask);
        return sock;
 
 out_close:
-       close(sock);
+       SAFE_FREE(path);
+       if (sock != -1)
+               close(sock);
 
 out_umask:
        umask(old_umask);
@@ -1484,3 +1926,173 @@ out_umask:
         return -1;
 #endif /* HAVE_UNIXSOCKET */
 }
+
+/****************************************************************************
+ Get my own canonical name, including domain.
+****************************************************************************/
+
+const char *get_mydnsfullname(void)
+{
+       struct addrinfo *res = NULL;
+       char my_hostname[HOST_NAME_MAX];
+       bool ret;
+       DATA_BLOB tmp;
+
+       if (memcache_lookup(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       &tmp)) {
+               SMB_ASSERT(tmp.length > 0);
+               return (const char *)tmp.data;
+       }
+
+       /* get my host name */
+       if (gethostname(my_hostname, sizeof(my_hostname)) == -1) {
+               DEBUG(0,("get_mydnsfullname: gethostname failed\n"));
+               return NULL;
+       }
+
+       /* Ensure null termination. */
+       my_hostname[sizeof(my_hostname)-1] = '\0';
+
+       ret = interpret_string_addr_internal(&res,
+                               my_hostname,
+                               AI_ADDRCONFIG|AI_CANONNAME);
+
+       if (!ret || res == NULL) {
+               DEBUG(3,("get_mydnsfullname: getaddrinfo failed for "
+                       "name %s [%s]\n",
+                       my_hostname,
+                       gai_strerror(ret) ));
+               return NULL;
+       }
+
+       /*
+        * Make sure that getaddrinfo() returns the "correct" host name.
+        */
+
+       if (res->ai_canonname == NULL) {
+               DEBUG(3,("get_mydnsfullname: failed to get "
+                       "canonical name for %s\n",
+                       my_hostname));
+               freeaddrinfo(res);
+               return NULL;
+       }
+
+       /* This copies the data, so we must do a lookup
+        * afterwards to find the value to return.
+        */
+
+       memcache_add(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       data_blob_string_const(res->ai_canonname));
+
+       if (!memcache_lookup(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       &tmp)) {
+               tmp = data_blob_talloc(talloc_tos(), res->ai_canonname,
+                               strlen(res->ai_canonname) + 1);
+       }
+
+       freeaddrinfo(res);
+
+       return (const char *)tmp.data;
+}
+
+/************************************************************
+ Is this my name ?
+************************************************************/
+
+bool is_myname_or_ipaddr(const char *s)
+{
+       TALLOC_CTX *ctx = talloc_tos();
+       char *name = NULL;
+       const char *dnsname;
+       char *servername = NULL;
+
+       if (!s) {
+               return false;
+       }
+
+       /* Santize the string from '\\name' */
+       name = talloc_strdup(ctx, s);
+       if (!name) {
+               return false;
+       }
+
+       servername = strrchr_m(name, '\\' );
+       if (!servername) {
+               servername = name;
+       } else {
+               servername++;
+       }
+
+       /* Optimize for the common case */
+       if (strequal(servername, global_myname())) {
+               return true;
+       }
+
+       /* Check for an alias */
+       if (is_myname(servername)) {
+               return true;
+       }
+
+       /* Check for loopback */
+       if (strequal(servername, "127.0.0.1") ||
+                       strequal(servername, "::1")) {
+               return true;
+       }
+
+       if (strequal(servername, "localhost")) {
+               return true;
+       }
+
+       /* Maybe it's my dns name */
+       dnsname = get_mydnsfullname();
+       if (dnsname && strequal(servername, dnsname)) {
+               return true;
+       }
+
+       /* Handle possible CNAME records - convert to an IP addr. */
+       if (!is_ipaddress(servername)) {
+               /* Use DNS to resolve the name, but only the first address */
+               struct sockaddr_storage ss;
+               if (interpret_string_addr(&ss, servername,0)) {
+                       print_sockaddr(name,
+                                       sizeof(name),
+                                       &ss);
+                       servername = name;
+               }
+       }
+
+       /* Maybe its an IP address? */
+       if (is_ipaddress(servername)) {
+               struct sockaddr_storage ss;
+               struct iface_struct *nics;
+               int i, n;
+
+               if (!interpret_string_addr(&ss, servername, AI_NUMERICHOST)) {
+                       return false;
+               }
+
+               if (is_zero_addr(&ss) || is_loopback_addr(&ss)) {
+                       return false;
+               }
+
+               nics = TALLOC_ARRAY(ctx, struct iface_struct,
+                                       MAX_INTERFACES);
+               if (!nics) {
+                       return false;
+               }
+               n = get_interfaces(nics, MAX_INTERFACES);
+               for (i=0; i<n; i++) {
+                       if (addr_equal(&nics[i].ip, &ss)) {
+                               TALLOC_FREE(nics);
+                               return true;
+                       }
+               }
+               TALLOC_FREE(nics);
+       }
+
+       /* No match */
+       return false;
+}