Fix a bug in the output from print_canonical_sockaddr() fix from 36f8bafbd3dee66a8....
[ira/wip.git] / source3 / lib / util_sock.c
index a59b1d5ef283fbbd3afe51ea15ec0edfffbbc1cb..30a3b83be75894b56e6b2807116b258ca13e4530 100644 (file)
@@ -63,7 +63,7 @@ bool is_ipaddress(const char *str)
                                        sizeof(addr)));
                        sp = addr;
                }
-               ret = inet_pton(AF_INET6, addr, &dest6);
+               ret = inet_pton(AF_INET6, sp, &dest6);
                if (ret > 0) {
                        return true;
                }
@@ -108,11 +108,15 @@ static bool interpret_string_addr_internal(struct addrinfo **ppres,
        hints.ai_socktype = SOCK_STREAM;
        hints.ai_flags = flags;
 
+       /* Linux man page on getaddinfo() says port will be
+          uninitialized when service string in NULL */
+
        ret = getaddrinfo(str, NULL,
                        &hints,
                        ppres);
+
        if (ret) {
-               DEBUG(3,("interpret_string_addr_interal: getaddrinfo failed "
+               DEBUG(3,("interpret_string_addr_internal: getaddrinfo failed "
                        "for name %s [%s]\n",
                        str,
                        gai_strerror(ret) ));
@@ -370,7 +374,7 @@ void in_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
  Convert an IPv6 struct in_addr to a struct sockaddr_storage.
 ********************************************************************/
 
-void in6_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
+ void in6_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
                struct in6_addr ip)
 {
        struct sockaddr_in6 *sa = (struct sockaddr_in6 *)ss;
@@ -475,6 +479,29 @@ bool is_address_any(const struct sockaddr_storage *psa)
        return false;
 }
 
+/****************************************************************************
+ Get a port number in host byte order from a sockaddr_storage.
+****************************************************************************/
+
+uint16_t get_sockaddr_port(const struct sockaddr_storage *pss)
+{
+       uint16_t port = 0;
+
+       if (pss->ss_family != AF_INET) {
+#if defined(HAVE_IPV6)
+               /* IPv6 */
+               const struct sockaddr_in6 *sa6 =
+                       (const struct sockaddr_in6 *)pss;
+               port = ntohs(sa6->sin6_port);
+#endif
+       } else {
+               const struct sockaddr_in *sa =
+                       (const struct sockaddr_in *)pss;
+               port = ntohs(sa->sin_port);
+       }
+       return port;
+}
+
 /****************************************************************************
  Print out an IPv4 or IPv6 address from a struct sockaddr_storage.
 ****************************************************************************/
@@ -518,50 +545,28 @@ char *print_canonical_sockaddr(TALLOC_CTX *ctx,
        char *dest = NULL;
        int ret;
 
-       ret = getnameinfo((const struct sockaddr *)pss,
+       /* Linux getnameinfo() man pages says port is unitialized if
+          service name is NULL. */
+
+       ret = sys_getnameinfo((const struct sockaddr *)pss,
                        sizeof(struct sockaddr_storage),
                        addr, sizeof(addr),
                        NULL, 0,
                        NI_NUMERICHOST);
-       if (ret) {
+       if (ret != 0) {
                return NULL;
        }
+
        if (pss->ss_family != AF_INET) {
 #if defined(HAVE_IPV6)
-               /* IPv6 */
-               const struct sockaddr_in6 *sa6 =
-                       (const struct sockaddr_in6 *)pss;
-               uint16_t port = ntohs(sa6->sin6_port);
-
-               if (port) {
-                       dest = talloc_asprintf(ctx,
-                                       "[%s]:%d",
-                                       addr,
-                                       (unsigned int)port);
-               } else {
-                       dest = talloc_asprintf(ctx,
-                                       "[%s]",
-                                       addr);
-               }
+               dest = talloc_asprintf(ctx, "[%s]", addr);
 #else
                return NULL;
 #endif
        } else {
-               const struct sockaddr_in *sa =
-                       (const struct sockaddr_in *)pss;
-               uint16_t port = ntohs(sa->sin_port);
-
-               if (port) {
-                       dest = talloc_asprintf(ctx,
-                                       "%s:%d",
-                                       addr,
-                                       (unsigned int)port);
-               } else {
-                       dest = talloc_asprintf(ctx,
-                                       "%s",
-                                       addr);
-               }
+               dest = talloc_asprintf(ctx, "%s", addr);
        }
+       
        return dest;
 }
 
@@ -627,6 +632,18 @@ static int get_socket_port(int fd)
 }
 #endif
 
+void set_sockaddr_port(struct sockaddr_storage *psa, uint16 port)
+{
+#if defined(HAVE_IPV6)
+       if (psa->ss_family == AF_INET6) {
+               ((struct sockaddr_in6 *)psa)->sin6_port = htons(port);
+       }
+#endif
+       if (psa->ss_family == AF_INET) {
+               ((struct sockaddr_in *)psa)->sin_port = htons(port);
+       }
+}
+
 const char *client_name(int fd)
 {
        return get_peer_name(fd,false);
@@ -773,9 +790,10 @@ static void print_socket_options(int s)
 
 void set_socket_options(int fd, const char *options)
 {
-       fstring tok;
+       TALLOC_CTX *ctx = talloc_stackframe();
+       char *tok;
 
-       while (next_token(&options,tok," \t,", sizeof(tok))) {
+       while (next_token_talloc(ctx, &options, &tok," \t,")) {
                int ret=0,i;
                int value = 1;
                char *p;
@@ -824,6 +842,7 @@ void set_socket_options(int fd, const char *options)
                }
        }
 
+       TALLOC_FREE(ctx);
        print_socket_options(fd);
 }
 
@@ -876,12 +895,10 @@ ssize_t read_udp_v4_socket(int fd,
  time_out = timeout in milliseconds
 ****************************************************************************/
 
-ssize_t read_socket_with_timeout(int fd,
-                               char *buf,
-                               size_t mincnt,
-                               size_t maxcnt,
-                               unsigned int time_out,
-                               enum smb_read_errors *pre)
+NTSTATUS read_socket_with_timeout(int fd, char *buf,
+                                 size_t mincnt, size_t maxcnt,
+                                 unsigned int time_out,
+                                 size_t *size_ret)
 {
        fd_set fds;
        int selrtn;
@@ -892,9 +909,7 @@ ssize_t read_socket_with_timeout(int fd,
 
        /* just checking .... */
        if (maxcnt <= 0)
-               return(0);
-
-       set_smb_read_error(pre,SMB_READ_OK);
+               return NT_STATUS_OK;
 
        /* Blocking read */
        if (time_out == 0) {
@@ -908,8 +923,7 @@ ssize_t read_socket_with_timeout(int fd,
                        if (readret == 0) {
                                DEBUG(5,("read_socket_with_timeout: "
                                        "blocking read. EOF from client.\n"));
-                               set_smb_read_error(pre,SMB_READ_EOF);
-                               return -1;
+                               return NT_STATUS_END_OF_FILE;
                        }
 
                        if (readret == -1) {
@@ -925,12 +939,11 @@ ssize_t read_socket_with_timeout(int fd,
                                                "read error = %s.\n",
                                                strerror(errno) ));
                                }
-                               set_smb_read_error(pre,SMB_READ_ERROR);
-                               return -1;
+                               return map_nt_error_from_unix(errno);
                        }
                        nread += readret;
                }
-               return((ssize_t)nread);
+               goto done;
        }
 
        /* Most difficult - timeout read */
@@ -964,16 +977,14 @@ ssize_t read_socket_with_timeout(int fd,
                                "read. select error = %s.\n",
                                strerror(errno) ));
                        }
-                       set_smb_read_error(pre,SMB_READ_ERROR);
-                       return -1;
+                       return map_nt_error_from_unix(errno);
                }
 
                /* Did we timeout ? */
                if (selrtn == 0) {
                        DEBUG(10,("read_socket_with_timeout: timeout read. "
                                "select timed out.\n"));
-                       set_smb_read_error(pre,SMB_READ_TIMEOUT);
-                       return -1;
+                       return NT_STATUS_IO_TIMEOUT;
                }
 
                readret = sys_read(fd, buf+nread, maxcnt-nread);
@@ -982,8 +993,7 @@ ssize_t read_socket_with_timeout(int fd,
                        /* we got EOF on the file descriptor */
                        DEBUG(5,("read_socket_with_timeout: timeout read. "
                                "EOF from client.\n"));
-                       set_smb_read_error(pre,SMB_READ_EOF);
-                       return -1;
+                       return NT_STATUS_END_OF_FILE;
                }
 
                if (readret == -1) {
@@ -1000,61 +1010,27 @@ ssize_t read_socket_with_timeout(int fd,
                                        "read. read error = %s.\n",
                                        strerror(errno) ));
                        }
-                       set_smb_read_error(pre,SMB_READ_ERROR);
-                       return -1;
+                       return map_nt_error_from_unix(errno);
                }
 
                nread += readret;
        }
 
+ done:
        /* Return the number we got */
-       return (ssize_t)nread;
+       if (size_ret) {
+               *size_ret = nread;
+       }
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
  Read data from the client, reading exactly N bytes.
 ****************************************************************************/
 
-ssize_t read_data(int fd,char *buffer,size_t N, enum smb_read_errors *pre)
+NTSTATUS read_data(int fd, char *buffer, size_t N)
 {
-       ssize_t ret;
-       size_t total=0;
-       char addr[INET6_ADDRSTRLEN];
-
-       set_smb_read_error(pre,SMB_READ_OK);
-
-       while (total < N) {
-               ret = sys_read(fd,buffer + total,N - total);
-
-               if (ret == 0) {
-                       DEBUG(10,("read_data: read of %d returned 0. "
-                               "Error = %s\n",
-                               (int)(N - total), strerror(errno) ));
-                       set_smb_read_error(pre,SMB_READ_EOF);
-                       return 0;
-               }
-
-               if (ret == -1) {
-                       if (fd == get_client_fd()) {
-                               /* Try and give an error message saying
-                                * what client failed. */
-                               DEBUG(0,("read_data: read failure for %d "
-                                       "bytes to client %s. Error = %s\n",
-                                       (int)(N - total),
-                                       get_peer_addr(fd,addr,sizeof(addr)),
-                                       strerror(errno) ));
-                       } else {
-                               DEBUG(0,("read_data: read failure for %d. "
-                                       "Error = %s\n",
-                                       (int)(N - total),
-                                       strerror(errno) ));
-                       }
-                       set_smb_read_error(pre,SMB_READ_ERROR);
-                       return -1;
-               }
-               total += ret;
-       }
-       return (ssize_t)total;
+       return read_socket_with_timeout(fd, buffer, N, N, 0, NULL);
 }
 
 /****************************************************************************
@@ -1116,37 +1092,29 @@ bool send_keepalive(int client)
  Timeout is in milliseconds.
 ****************************************************************************/
 
-ssize_t read_smb_length_return_keepalive(int fd,
-                                       char *inbuf,
-                                       unsigned int timeout,
-                                       enum smb_read_errors *pre)
+NTSTATUS read_smb_length_return_keepalive(int fd, char *inbuf,
+                                         unsigned int timeout,
+                                         size_t *len)
 {
-       ssize_t len=0;
        int msg_type;
-       bool ok = false;
+       NTSTATUS status;
 
-       while (!ok) {
-               if (timeout > 0) {
-                       ok = (read_socket_with_timeout(fd,inbuf,4,4,
-                                               timeout,pre) == 4);
-               } else {
-                       ok = (read_data(fd,inbuf,4,pre) == 4);
-               }
-               if (!ok) {
-                       return -1;
-               }
+       status = read_socket_with_timeout(fd, inbuf, 4, 4, timeout, NULL);
 
-               len = smb_len(inbuf);
-               msg_type = CVAL(inbuf,0);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
-               if (msg_type == SMBkeepalive) {
-                       DEBUG(5,("Got keepalive packet\n"));
-               }
+       *len = smb_len(inbuf);
+       msg_type = CVAL(inbuf,0);
+
+       if (msg_type == SMBkeepalive) {
+               DEBUG(5,("Got keepalive packet\n"));
        }
 
-       DEBUG(10,("got smb length of %lu\n",(unsigned long)len));
+       DEBUG(10,("got smb length of %lu\n",(unsigned long)(*len)));
 
-       return len;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -1156,25 +1124,27 @@ ssize_t read_smb_length_return_keepalive(int fd,
  Timeout is in milliseconds.
 ****************************************************************************/
 
-ssize_t read_smb_length(int fd, char *inbuf, unsigned int timeout, enum smb_read_errors *pre)
+NTSTATUS read_smb_length(int fd, char *inbuf, unsigned int timeout,
+                        size_t *len)
 {
-       ssize_t len;
+       uint8_t msgtype = SMBkeepalive;
 
-       for(;;) {
-               len = read_smb_length_return_keepalive(fd, inbuf, timeout, pre);
+       while (msgtype == SMBkeepalive) {
+               NTSTATUS status;
 
-               if(len < 0)
-                       return len;
+               status = read_smb_length_return_keepalive(fd, inbuf, timeout,
+                                                         len);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
 
-               /* Ignore session keepalives. */
-               if(CVAL(inbuf,0) != SMBkeepalive)
-                       break;
+               msgtype = CVAL(inbuf, 0);
        }
 
        DEBUG(10,("read_smb_length: got smb length of %lu\n",
                  (unsigned long)len));
 
-       return len;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -1187,28 +1157,17 @@ ssize_t read_smb_length(int fd, char *inbuf, unsigned int timeout, enum smb_read
  Doesn't check the MAC on signed packets.
 ****************************************************************************/
 
-ssize_t receive_smb_raw(int fd,
-                       char *buffer,
-                       unsigned int timeout,
-                       size_t maxlen,
-                       enum smb_read_errors *pre)
+NTSTATUS receive_smb_raw(int fd, char *buffer, unsigned int timeout,
+                        size_t maxlen, size_t *p_len)
 {
-       ssize_t len,ret;
-
-       set_smb_read_error(pre,SMB_READ_OK);
-
-       len = read_smb_length_return_keepalive(fd,buffer,timeout,pre);
-       if (len < 0) {
-               DEBUG(10,("receive_smb_raw: length < 0!\n"));
+       size_t len;
+       NTSTATUS status;
 
-               /*
-                * Correct fix. smb_read_error may have already been
-                * set. Only set it here if not already set. Global
-                * variables still suck :-). JRA.
-                */
+       status = read_smb_length_return_keepalive(fd,buffer,timeout,&len);
 
-               cond_set_smb_read_error(pre,SMB_READ_ERROR);
-               return -1;
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("receive_smb_raw: %s!\n", nt_errstr(status)));
+               return status;
        }
 
        /*
@@ -1220,15 +1179,7 @@ ssize_t receive_smb_raw(int fd,
                DEBUG(0,("Invalid packet length! (%lu bytes).\n",
                                        (unsigned long)len));
                if (len > BUFFER_SIZE + (SAFETY_MARGIN/2)) {
-
-                       /*
-                        * Correct fix. smb_read_error may have already been
-                        * set. Only set it here if not already set. Global
-                        * variables still suck :-). JRA.
-                        */
-
-                       cond_set_smb_read_error(pre,SMB_READ_ERROR);
-                       return -1;
+                       return NT_STATUS_INVALID_PARAMETER;
                }
        }
 
@@ -1237,20 +1188,11 @@ ssize_t receive_smb_raw(int fd,
                        len = MIN(len,maxlen);
                }
 
-               if (timeout > 0) {
-                       ret = read_socket_with_timeout(fd,
-                                       buffer+4,
-                                       len,
-                                       len,
-                                       timeout,
-                                       pre);
-               } else {
-                       ret = read_data(fd,buffer+4,len,pre);
-               }
+               status = read_socket_with_timeout(
+                       fd, buffer+4, len, len, timeout, &len);
 
-               if (ret != len) {
-                       cond_set_smb_read_error(pre,SMB_READ_ERROR);
-                       return -1;
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
 
                /* not all of samba3 properly checks for packet-termination
@@ -1259,57 +1201,8 @@ ssize_t receive_smb_raw(int fd,
                SSVAL(buffer+4,len, 0);
        }
 
-       return len;
-}
-
-/****************************************************************************
- Wrapper for receive_smb_raw().
- Checks the MAC on signed packets.
-****************************************************************************/
-
-bool receive_smb(int fd, char *buffer, unsigned int timeout, enum smb_read_errors *pre)
-{
-       if (receive_smb_raw(fd, buffer, timeout, 0, pre) < 0) {
-               return false;
-       }
-
-       /* Check the incoming SMB signature. */
-       if (!srv_check_sign_mac(buffer, true)) {
-               DEBUG(0, ("receive_smb: SMB Signature verification "
-                       "failed on incoming packet!\n"));
-               cond_set_smb_read_error(pre,SMB_READ_BAD_SIG);
-               return false;
-       }
-
-       return true;
-}
-
-/****************************************************************************
- Send an smb to a fd.
-****************************************************************************/
-
-bool send_smb(int fd, char *buffer)
-{
-       size_t len;
-       size_t nwritten=0;
-       ssize_t ret;
-
-       /* Sign the outgoing packet if required. */
-       srv_calculate_sign_mac(buffer);
-
-       len = smb_len(buffer) + 4;
-
-       while (nwritten < len) {
-               ret = write_data(fd,buffer+nwritten,len - nwritten);
-               if (ret <= 0) {
-                       DEBUG(0,("Error writing %d bytes to client. %d. (%s)\n",
-                               (int)len,(int)ret, strerror(errno) ));
-                       return false;
-               }
-               nwritten += ret;
-       }
-
-       return true;
+       *p_len = len;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -1445,7 +1338,7 @@ int open_socket_out(int type,
        /* and connect it to the destination */
   connect_again:
 
-       ret = connect(res,(struct sockaddr *)&sock_out,sizeof(sock_out));
+       ret = sys_connect(res, (struct sockaddr *)&sock_out);
 
        /* Some systems return EAGAIN when they mean EINPROGRESS */
        if (ret < 0 && (errno == EINPROGRESS || errno == EALREADY ||
@@ -1533,12 +1426,13 @@ bool open_any_socket_out(struct sockaddr_storage *addrs, int num_addrs,
        good_connect = false;
 
        for (i=0; i<num_addrs; i++) {
+               const struct sockaddr * a = 
+                   (const struct sockaddr *)&(addrs[i]);
 
                if (sockets[i] == -1)
                        continue;
 
-               if (connect(sockets[i], (struct sockaddr *)&(addrs[i]),
-                           sizeof(*addrs)) == 0) {
+               if (sys_connect(sockets[i], a) == 0) {
                        /* Rather unlikely as we are non-blocking, but it
                         * might actually happen. */
                        resulting_index = i;
@@ -1667,7 +1561,7 @@ int open_udp_socket(const char *host, int port)
        sock_out.sin_port = htons(port);
        sock_out.sin_family = PF_INET;
 
-       if (connect(res,(struct sockaddr *)&sock_out,sizeof(sock_out))) {
+       if (sys_connect(res,(struct sockaddr *)&sock_out)) {
                close(res);
                return -1;
        }
@@ -1785,18 +1679,66 @@ static bool matchname(const char *remotehost,
        return false;
 }
 
-static struct {
-        struct sockaddr_storage ss;
-        char *name;
-} nc;
+/*******************************************************************
+ Deal with the singleton cache.
+******************************************************************/
+
+struct name_addr_pair {
+       struct sockaddr_storage ss;
+       const char *name;
+};
+
+/*******************************************************************
+ Lookup a name/addr pair. Returns memory allocated from memcache.
+******************************************************************/
+
+static bool lookup_nc(struct name_addr_pair *nc)
+{
+       DATA_BLOB tmp;
+
+       ZERO_STRUCTP(nc);
+
+       if (!memcache_lookup(
+                       NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_peer_name"),
+                       &tmp)) {
+               return false;
+       }
+
+       memcpy(&nc->ss, tmp.data, sizeof(nc->ss));
+       nc->name = (const char *)tmp.data + sizeof(nc->ss);
+       return true;
+}
+
+/*******************************************************************
+ Save a name/addr pair.
+******************************************************************/
+
+static void store_nc(const struct name_addr_pair *nc)
+{
+       DATA_BLOB tmp;
+       size_t namelen = strlen(nc->name);
+
+       tmp = data_blob(NULL, sizeof(nc->ss) + namelen + 1);
+       if (!tmp.data) {
+               return;
+       }
+       memcpy(tmp.data, &nc->ss, sizeof(nc->ss));
+       memcpy(tmp.data+sizeof(nc->ss), nc->name, namelen+1);
+
+       memcache_add(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_peer_name"),
+                       tmp);
+       data_blob_free(&tmp);
+}
 
 /*******************************************************************
  Return the DNS name of the remote end of a socket.
 ******************************************************************/
 
-const char *get_peer_name(int fd,
-                               bool force_lookup)
+const char *get_peer_name(int fd, bool force_lookup)
 {
+       struct name_addr_pair nc;
        char addr_buf[INET6_ADDRSTRLEN];
        struct sockaddr_storage ss;
        socklen_t length = sizeof(ss);
@@ -1811,13 +1753,15 @@ const char *get_peer_name(int fd,
           possible */
        if (!lp_hostname_lookups() && (force_lookup == false)) {
                length = sizeof(nc.ss);
-               p = get_peer_addr_internal(fd, addr_buf, sizeof(addr_buf),
+               nc.name = get_peer_addr_internal(fd, addr_buf, sizeof(addr_buf),
                        &nc.ss, &length);
-               SAFE_FREE(nc.name);
-               nc.name = SMB_STRDUP(p);
+               store_nc(&nc);
+               lookup_nc(&nc);
                return nc.name ? nc.name : "UNKNOWN";
        }
 
+       lookup_nc(&nc);
+
        memset(&ss, '\0', sizeof(ss));
        p = get_peer_addr_internal(fd, addr_buf, sizeof(addr_buf), &ss, &length);
 
@@ -1826,15 +1770,13 @@ const char *get_peer_name(int fd,
                return nc.name ? nc.name : "UNKNOWN";
        }
 
-       /* Not the same. Reset the cache. */
-       zero_addr(&nc.ss);
-       SAFE_FREE(nc.name);
+       /* Not the same. We need to lookup. */
        if (fd == -1) {
                return "UNKNOWN";
        }
 
        /* Look up the remote host name. */
-       ret = getnameinfo((struct sockaddr *)&ss,
+       ret = sys_getnameinfo((struct sockaddr *)&ss,
                        length,
                        name_buf,
                        sizeof(name_buf),
@@ -1865,7 +1807,11 @@ const char *get_peer_name(int fd,
                strlcpy(name_buf, "UNKNOWN", sizeof(name_buf));
        }
 
-       nc.name = SMB_STRDUP(name_buf);
+       nc.name = name_buf;
+       nc.ss = ss;
+
+       store_nc(&nc);
+       lookup_nc(&nc);
        return nc.name ? nc.name : "UNKNOWN";
 }
 
@@ -1940,8 +1886,7 @@ int create_pipe_sock(const char *socket_dir,
                 goto out_close;
        }
 
-       asprintf(&path, "%s/%s", socket_dir, socket_name);
-       if (!path) {
+       if (asprintf(&path, "%s/%s", socket_dir, socket_name) == -1) {
                 goto out_close;
        }
 
@@ -1969,7 +1914,8 @@ int create_pipe_sock(const char *socket_dir,
 
 out_close:
        SAFE_FREE(path);
-       close(sock);
+       if (sock != -1)
+               close(sock);
 
 out_umask:
        umask(old_umask);
@@ -1987,50 +1933,69 @@ out_umask:
 
 const char *get_mydnsfullname(void)
 {
-       static char *dnshostname_cache;
-
-       if (dnshostname_cache == NULL || !*dnshostname_cache) {
-               struct addrinfo *res = NULL;
-               char my_hostname[HOST_NAME_MAX];
-               bool ret;
+       struct addrinfo *res = NULL;
+       char my_hostname[HOST_NAME_MAX];
+       bool ret;
+       DATA_BLOB tmp;
 
-               /* get my host name */
-               if (gethostname(my_hostname, sizeof(my_hostname)) == -1) {
-                       DEBUG(0,("get_mydnsfullname: gethostname failed\n"));
-                       return NULL;
-               }
+       if (memcache_lookup(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       &tmp)) {
+               SMB_ASSERT(tmp.length > 0);
+               return (const char *)tmp.data;
+       }
 
-               /* Ensure null termination. */
-               my_hostname[sizeof(my_hostname)-1] = '\0';
+       /* get my host name */
+       if (gethostname(my_hostname, sizeof(my_hostname)) == -1) {
+               DEBUG(0,("get_mydnsfullname: gethostname failed\n"));
+               return NULL;
+       }
 
-               ret = interpret_string_addr_internal(&res,
-                                       my_hostname,
-                                       AI_ADDRCONFIG|AI_CANONNAME);
+       /* Ensure null termination. */
+       my_hostname[sizeof(my_hostname)-1] = '\0';
 
-               if (!ret || res == NULL) {
-                       DEBUG(3,("get_mydnsfullname: getaddrinfo failed for "
-                               "name %s [%s]\n",
+       ret = interpret_string_addr_internal(&res,
                                my_hostname,
-                               gai_strerror(ret) ));
-                       return NULL;
-               }
+                               AI_ADDRCONFIG|AI_CANONNAME);
 
-               /*
-                * Make sure that getaddrinfo() returns the "correct" host name.
-                */
+       if (!ret || res == NULL) {
+               DEBUG(3,("get_mydnsfullname: getaddrinfo failed for "
+                       "name %s [%s]\n",
+                       my_hostname,
+                       gai_strerror(ret) ));
+               return NULL;
+       }
 
-               if (res->ai_canonname == NULL) {
-                       DEBUG(3,("get_mydnsfullname: failed to get "
-                               "canonical name for %s\n",
-                               my_hostname));
-                       freeaddrinfo(res);
-                       return NULL;
-               }
+       /*
+        * Make sure that getaddrinfo() returns the "correct" host name.
+        */
 
-               dnshostname_cache = SMB_STRDUP(res->ai_canonname);
+       if (res->ai_canonname == NULL) {
+               DEBUG(3,("get_mydnsfullname: failed to get "
+                       "canonical name for %s\n",
+                       my_hostname));
                freeaddrinfo(res);
+               return NULL;
        }
-       return dnshostname_cache;
+
+       /* This copies the data, so we must do a lookup
+        * afterwards to find the value to return.
+        */
+
+       memcache_add(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       data_blob_string_const(res->ai_canonname));
+
+       if (!memcache_lookup(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       &tmp)) {
+               tmp = data_blob_talloc(talloc_tos(), res->ai_canonname,
+                               strlen(res->ai_canonname) + 1);
+       }
+
+       freeaddrinfo(res);
+
+       return (const char *)tmp.data;
 }
 
 /************************************************************