s3: piddir creation fix part 2.
[ira/wip.git] / source3 / groupdb / mapping.c
index b648c582020b3a3748790c1435812456e6b436de..2c0fea0cb98408a7dbad173d05fde617500bf24b 100644 (file)
  */
 
 #include "includes.h"
+#include "system/passwd.h"
+#include "passdb.h"
 #include "groupdb/mapping.h"
+#include "../libcli/security/security.h"
+#include "lib/winbind_util.h"
+#include "tdb_compat.h"
+#include "groupdb/mapping_tdb.h"
 
 static const struct mapping_backend *backend;
 
@@ -45,28 +51,52 @@ initialise first time the mapping list
 ****************************************************************************/
 NTSTATUS add_initial_entry(gid_t gid, const char *sid, enum lsa_SidType sid_name_use, const char *nt_name, const char *comment)
 {
-       GROUP_MAP map;
+       NTSTATUS status;
+       GROUP_MAP *map;
 
        if(!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
                return NT_STATUS_UNSUCCESSFUL;
        }
-       
-       map.gid=gid;
-       if (!string_to_sid(&map.sid, sid)) {
+
+       map = talloc_zero(NULL, GROUP_MAP);
+       if (!map) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       map->gid=gid;
+       if (!string_to_sid(&map->sid, sid)) {
                DEBUG(0, ("string_to_sid failed: %s", sid));
-               return NT_STATUS_UNSUCCESSFUL;
+               status = NT_STATUS_UNSUCCESSFUL;
+               goto done;
+       }
+
+       map->sid_name_use=sid_name_use;
+       map->nt_name = talloc_strdup(map, nt_name);
+       if (!map->nt_name) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+
+       if (comment) {
+               map->comment = talloc_strdup(map, comment);
+       } else {
+               map->comment = talloc_strdup(map, "");
+       }
+       if (!map->comment) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
        }
-       
-       map.sid_name_use=sid_name_use;
-       fstrcpy(map.nt_name, nt_name);
-       fstrcpy(map.comment, comment);
 
-       return pdb_add_group_mapping_entry(&map);
+       status = pdb_add_group_mapping_entry(map);
+
+done:
+       TALLOC_FREE(map);
+       return status;
 }
 
-static NTSTATUS alias_memberships(const DOM_SID *members, size_t num_members,
-                                 DOM_SID **sids, size_t *num)
+static NTSTATUS alias_memberships(const struct dom_sid *members, size_t num_members,
+                                 struct dom_sid **sids, size_t *num)
 {
        size_t i;
 
@@ -82,8 +112,8 @@ static NTSTATUS alias_memberships(const DOM_SID *members, size_t num_members,
 }
 
 struct aliasmem_closure {
-       const DOM_SID *alias;
-       DOM_SID **sids;
+       const struct dom_sid *alias;
+       struct dom_sid **sids;
        size_t *num;
 };
 
@@ -101,11 +131,11 @@ struct aliasmem_closure {
 
 /* get a domain group from it's SID */
 
-bool get_domain_group_from_sid(DOM_SID sid, GROUP_MAP *map)
+bool get_domain_group_from_sid(struct dom_sid sid, GROUP_MAP *map)
 {
        struct group *grp;
        bool ret;
-       
+
        if(!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
                return(False);
@@ -114,32 +144,36 @@ bool get_domain_group_from_sid(DOM_SID sid, GROUP_MAP *map)
        DEBUG(10, ("get_domain_group_from_sid\n"));
 
        /* if the group is NOT in the database, it CAN NOT be a domain group */
-       
+
        become_root();
        ret = pdb_getgrsid(map, sid);
        unbecome_root();
-       
+
        /* special case check for rid 513 */
-       
+
        if ( !ret ) {
                uint32 rid;
-               
+
                sid_peek_rid( &sid, &rid );
-               
-               if ( rid == DOMAIN_GROUP_RID_USERS ) {
-                       fstrcpy( map->nt_name, "None" );
-                       fstrcpy( map->comment, "Ordinary Users" );
+
+               if ( rid == DOMAIN_RID_USERS ) {
+                       map->nt_name = talloc_strdup(map, "None");
+                       if (!map->nt_name) {
+                               return false;
+                       }
+                       map->comment = talloc_strdup(map, "Ordinary Users");
+                       if (!map->comment) {
+                               return false;
+                       }
                        sid_copy( &map->sid, &sid );
                        map->sid_name_use = SID_NAME_DOM_GRP;
                        map->gid = (gid_t)-1;
-                       
                        return True;
                }
-               
                return False;
        }
 
-       DEBUG(10, ("get_domain_group_from_sid: SID found in the TDB\n"));
+       DEBUG(10, ("get_domain_group_from_sid: SID found in passdb\n"));
 
        /* if it's not a domain group, continue */
        if (map->sid_name_use!=SID_NAME_DOM_GRP) {
@@ -147,13 +181,13 @@ bool get_domain_group_from_sid(DOM_SID sid, GROUP_MAP *map)
        }
 
        DEBUG(10, ("get_domain_group_from_sid: SID is a domain group\n"));
-       
+
        if (map->gid==-1) {
                return False;
        }
 
        DEBUG(10, ("get_domain_group_from_sid: SID is mapped to gid:%lu\n",(unsigned long)map->gid));
-       
+
        grp = getgrgid(map->gid);
        if ( !grp ) {
                DEBUG(10, ("get_domain_group_from_sid: gid DOESN'T exist in UNIX security\n"));
@@ -325,8 +359,8 @@ int smb_add_user_group(const char *unix_group, const char *unix_user)
                if (!add_script) {
                        return -1;
                }
-               add_script = talloc_string_sub(ctx,
-                               add_script, "%u", unix_user);
+               add_script = talloc_string_sub2(ctx,
+                               add_script, "%u", unix_user, true, false, true);
                if (!add_script) {
                        return -1;
                }
@@ -365,8 +399,8 @@ int smb_delete_user_group(const char *unix_group, const char *unix_user)
                if (!del_script) {
                        return -1;
                }
-               del_script = talloc_string_sub(ctx,
-                               del_script, "%u", unix_user);
+               del_script = talloc_string_sub2(ctx,
+                               del_script, "%u", unix_user, true, false, true);
                if (!del_script) {
                        return -1;
                }
@@ -383,7 +417,7 @@ int smb_delete_user_group(const char *unix_group, const char *unix_user)
 
 
 NTSTATUS pdb_default_getgrsid(struct pdb_methods *methods, GROUP_MAP *map,
-                                DOM_SID sid)
+                                struct dom_sid sid)
 {
        if (!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
@@ -438,7 +472,7 @@ NTSTATUS pdb_default_update_group_mapping_entry(struct pdb_methods *methods,
 }
 
 NTSTATUS pdb_default_delete_group_mapping_entry(struct pdb_methods *methods,
-                                                  DOM_SID sid)
+                                                  struct dom_sid sid)
 {
        if (!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
@@ -449,9 +483,11 @@ NTSTATUS pdb_default_delete_group_mapping_entry(struct pdb_methods *methods,
 }
 
 NTSTATUS pdb_default_enum_group_mapping(struct pdb_methods *methods,
-                                          const DOM_SID *sid, enum lsa_SidType sid_name_use,
-                                          GROUP_MAP **pp_rmap, size_t *p_num_entries,
-                                          bool unix_only)
+                                       const struct dom_sid *sid,
+                                       enum lsa_SidType sid_name_use,
+                                       GROUP_MAP ***pp_rmap,
+                                       size_t *p_num_entries,
+                                       bool unix_only)
 {
        if (!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
@@ -464,12 +500,12 @@ NTSTATUS pdb_default_enum_group_mapping(struct pdb_methods *methods,
 NTSTATUS pdb_default_create_alias(struct pdb_methods *methods,
                                  const char *name, uint32 *rid)
 {
-       DOM_SID sid;
+       struct dom_sid sid;
        enum lsa_SidType type;
        uint32 new_rid;
        gid_t gid;
        bool exists;
-       GROUP_MAP map;
+       GROUP_MAP *map;
        TALLOC_CTX *mem_ctx;
        NTSTATUS status;
 
@@ -482,92 +518,151 @@ NTSTATUS pdb_default_create_alias(struct pdb_methods *methods,
 
        exists = lookup_name(mem_ctx, name, LOOKUP_NAME_LOCAL,
                             NULL, NULL, &sid, &type);
-       TALLOC_FREE(mem_ctx);
 
        if (exists) {
-               return NT_STATUS_ALIAS_EXISTS;
+               status = NT_STATUS_ALIAS_EXISTS;
+               goto done;
        }
 
-       if (!winbind_allocate_gid(&gid)) {
-               DEBUG(3, ("Could not get a gid out of winbind\n"));
-               return NT_STATUS_ACCESS_DENIED;
+       if (!pdb_new_rid(&new_rid)) {
+               DEBUG(0, ("Could not allocate a RID.\n"));
+               status = NT_STATUS_ACCESS_DENIED;
+               goto done;
        }
 
-       if (!pdb_new_rid(&new_rid)) {
-               DEBUG(0, ("Could not allocate a RID -- wasted a gid :-(\n"));
-               return NT_STATUS_ACCESS_DENIED;
+       sid_compose(&sid, get_global_sam_sid(), new_rid);
+
+       if (!winbind_allocate_gid(&gid)) {
+               DEBUG(3, ("Could not get a gid out of winbind - "
+                         "wasted a rid :-(\n"));
+               status = NT_STATUS_ACCESS_DENIED;
+               goto done;
        }
 
        DEBUG(10, ("Creating alias %s with gid %u and rid %u\n",
                   name, (unsigned int)gid, (unsigned int)new_rid));
 
-       sid_compose(&sid, get_global_sam_sid(), new_rid);
+       map = talloc_zero(mem_ctx, GROUP_MAP);
+       if (!map) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
-       map.gid = gid;
-       sid_copy(&map.sid, &sid);
-       map.sid_name_use = SID_NAME_ALIAS;
-       fstrcpy(map.nt_name, name);
-       fstrcpy(map.comment, "");
+       map->gid = gid;
+       sid_copy(&map->sid, &sid);
+       map->sid_name_use = SID_NAME_ALIAS;
+       map->nt_name = talloc_strdup(map, name);
+       if (!map->nt_name) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+       map->comment = talloc_strdup(map, "");
+       if (!map->comment) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
-       status = pdb_add_group_mapping_entry(&map);
+       status = pdb_add_group_mapping_entry(map);
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("Could not add group mapping entry for alias %s "
                          "(%s)\n", name, nt_errstr(status)));
-               return status;
+               goto done;
        }
 
        *rid = new_rid;
 
-       return NT_STATUS_OK;
+done:
+       TALLOC_FREE(mem_ctx);
+       return status;
 }
 
 NTSTATUS pdb_default_delete_alias(struct pdb_methods *methods,
-                                 const DOM_SID *sid)
+                                 const struct dom_sid *sid)
 {
        return pdb_delete_group_mapping_entry(*sid);
 }
 
 NTSTATUS pdb_default_get_aliasinfo(struct pdb_methods *methods,
-                                  const DOM_SID *sid,
+                                  const struct dom_sid *sid,
                                   struct acct_info *info)
 {
-       GROUP_MAP map;
+       NTSTATUS status = NT_STATUS_OK;
+       GROUP_MAP *map;
 
-       if (!pdb_getgrsid(&map, *sid))
-               return NT_STATUS_NO_SUCH_ALIAS;
+       map = talloc_zero(NULL, GROUP_MAP);
+       if (!map) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
-       if ((map.sid_name_use != SID_NAME_ALIAS) &&
-           (map.sid_name_use != SID_NAME_WKN_GRP)) {
+       if (!pdb_getgrsid(map, *sid)) {
+               status = NT_STATUS_NO_SUCH_ALIAS;
+               goto done;
+       }
+
+       if ((map->sid_name_use != SID_NAME_ALIAS) &&
+           (map->sid_name_use != SID_NAME_WKN_GRP)) {
                DEBUG(2, ("%s is a %s, expected an alias\n",
                          sid_string_dbg(sid),
-                         sid_type_lookup(map.sid_name_use)));
-               return NT_STATUS_NO_SUCH_ALIAS;
+                         sid_type_lookup(map->sid_name_use)));
+               status = NT_STATUS_NO_SUCH_ALIAS;
+               goto done;
        }
 
-       fstrcpy(info->acct_name, map.nt_name);
-       fstrcpy(info->acct_desc, map.comment);
-       sid_peek_rid(&map.sid, &info->rid);
-       return NT_STATUS_OK;
+       info->acct_name = talloc_move(info, &map->nt_name);
+       if (!info->acct_name) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+       info->acct_desc = talloc_move(info, &map->comment);
+       if (!info->acct_desc) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+       sid_peek_rid(&map->sid, &info->rid);
+
+done:
+       TALLOC_FREE(map);
+       return status;
 }
 
 NTSTATUS pdb_default_set_aliasinfo(struct pdb_methods *methods,
-                                  const DOM_SID *sid,
+                                  const struct dom_sid *sid,
                                   struct acct_info *info)
 {
-       GROUP_MAP map;
+       NTSTATUS status = NT_STATUS_OK;
+       GROUP_MAP *map;
 
-       if (!pdb_getgrsid(&map, *sid))
-               return NT_STATUS_NO_SUCH_ALIAS;
+       map = talloc_zero(NULL, GROUP_MAP);
+       if (!map) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
-       fstrcpy(map.nt_name, info->acct_name);
-       fstrcpy(map.comment, info->acct_desc);
+       if (!pdb_getgrsid(map, *sid)) {
+               status = NT_STATUS_NO_SUCH_ALIAS;
+               goto done;
+       }
+
+       map->nt_name = talloc_strdup(map, info->acct_name);
+       if (!map->nt_name) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+       map->comment = talloc_strdup(map, info->acct_desc);
+       if (!map->comment) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+
+       status = pdb_update_group_mapping_entry(map);
 
-       return pdb_update_group_mapping_entry(&map);
+done:
+       TALLOC_FREE(map);
+       return status;
 }
 
 NTSTATUS pdb_default_add_aliasmem(struct pdb_methods *methods,
-                                 const DOM_SID *alias, const DOM_SID *member)
+                                 const struct dom_sid *alias, const struct dom_sid *member)
 {
        if (!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
@@ -577,7 +672,7 @@ NTSTATUS pdb_default_add_aliasmem(struct pdb_methods *methods,
 }
 
 NTSTATUS pdb_default_del_aliasmem(struct pdb_methods *methods,
-                                 const DOM_SID *alias, const DOM_SID *member)
+                                 const struct dom_sid *alias, const struct dom_sid *member)
 {
        if (!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
@@ -587,8 +682,8 @@ NTSTATUS pdb_default_del_aliasmem(struct pdb_methods *methods,
 }
 
 NTSTATUS pdb_default_enum_aliasmem(struct pdb_methods *methods,
-                                  const DOM_SID *alias, TALLOC_CTX *mem_ctx,
-                                  DOM_SID **pp_members, size_t *p_num_members)
+                                  const struct dom_sid *alias, TALLOC_CTX *mem_ctx,
+                                  struct dom_sid **pp_members, size_t *p_num_members)
 {
        if (!init_group_mapping()) {
                DEBUG(0,("failed to initialize group mapping\n"));
@@ -600,13 +695,13 @@ NTSTATUS pdb_default_enum_aliasmem(struct pdb_methods *methods,
 
 NTSTATUS pdb_default_alias_memberships(struct pdb_methods *methods,
                                       TALLOC_CTX *mem_ctx,
-                                      const DOM_SID *domain_sid,
-                                      const DOM_SID *members,
+                                      const struct dom_sid *domain_sid,
+                                      const struct dom_sid *members,
                                       size_t num_members,
                                       uint32 **pp_alias_rids,
                                       size_t *p_num_alias_rids)
 {
-       DOM_SID *alias_sids;
+       struct dom_sid *alias_sids;
        size_t i, num_alias_sids;
        NTSTATUS result;
 
@@ -631,7 +726,7 @@ NTSTATUS pdb_default_alias_memberships(struct pdb_methods *methods,
                return NT_STATUS_OK;
        }
 
-       *pp_alias_rids = TALLOC_ARRAY(mem_ctx, uint32, num_alias_sids);
+       *pp_alias_rids = talloc_array(mem_ctx, uint32, num_alias_sids);
        if (*pp_alias_rids == NULL)
                return NT_STATUS_NO_MEMORY;
 
@@ -652,7 +747,7 @@ NTSTATUS pdb_default_alias_memberships(struct pdb_methods *methods,
  *********************************************************************/
 
 NTSTATUS pdb_nop_getgrsid(struct pdb_methods *methods, GROUP_MAP *map,
-                                DOM_SID sid)
+                                struct dom_sid sid)
 {
        return NT_STATUS_UNSUCCESSFUL;
 }
@@ -682,7 +777,7 @@ NTSTATUS pdb_nop_update_group_mapping_entry(struct pdb_methods *methods,
 }
 
 NTSTATUS pdb_nop_delete_group_mapping_entry(struct pdb_methods *methods,
-                                                  DOM_SID sid)
+                                                  struct dom_sid sid)
 {
        return NT_STATUS_UNSUCCESSFUL;
 }
@@ -695,95 +790,67 @@ NTSTATUS pdb_nop_enum_group_mapping(struct pdb_methods *methods,
        return NT_STATUS_UNSUCCESSFUL;
 }
 
-/****************************************************************************
- These need to be redirected through pdb_interface.c
-****************************************************************************/
-bool pdb_get_dom_grp_info(const DOM_SID *sid, struct acct_info *info)
-{
-       GROUP_MAP map;
-       bool res;
-
-       become_root();
-       res = get_domain_group_from_sid(*sid, &map);
-       unbecome_root();
-
-       if (!res)
-               return False;
-
-       fstrcpy(info->acct_name, map.nt_name);
-       fstrcpy(info->acct_desc, map.comment);
-       sid_peek_rid(sid, &info->rid);
-       return True;
-}
-
-bool pdb_set_dom_grp_info(const DOM_SID *sid, const struct acct_info *info)
-{
-       GROUP_MAP map;
-
-       if (!get_domain_group_from_sid(*sid, &map))
-               return False;
-
-       fstrcpy(map.nt_name, info->acct_name);
-       fstrcpy(map.comment, info->acct_desc);
-
-       return NT_STATUS_IS_OK(pdb_update_group_mapping_entry(&map));
-}
-
 /********************************************************************
  Really just intended to be called by smbd
 ********************************************************************/
 
 NTSTATUS pdb_create_builtin_alias(uint32 rid)
 {
-       DOM_SID sid;
+       struct dom_sid sid;
        enum lsa_SidType type;
        gid_t gid;
-       GROUP_MAP map;
-       TALLOC_CTX *mem_ctx;
+       GROUP_MAP *map;
        NTSTATUS status;
        const char *name = NULL;
-       fstring groupname;
 
        DEBUG(10, ("Trying to create builtin alias %d\n", rid));
-       
+
        if ( !sid_compose( &sid, &global_sid_Builtin, rid ) ) {
                return NT_STATUS_NO_SUCH_ALIAS;
        }
-       
-       if ( (mem_ctx = talloc_new(NULL)) == NULL ) {
+
+       /* use map as overall temp mem context */
+       map = talloc_zero(NULL, GROUP_MAP);
+       if (!map) {
                return NT_STATUS_NO_MEMORY;
        }
-       
-       if ( !lookup_sid(mem_ctx, &sid, NULL, &name, &type) ) {
-               TALLOC_FREE( mem_ctx );
-               return NT_STATUS_NO_SUCH_ALIAS;
+
+       if (!lookup_sid(map, &sid, NULL, &name, &type)) {
+               status = NT_STATUS_NO_SUCH_ALIAS;
+               goto done;
        }
-       
-       /* validate RID so copy the name and move on */
-               
-       fstrcpy( groupname, name );
-       TALLOC_FREE( mem_ctx );
 
        if (!winbind_allocate_gid(&gid)) {
                DEBUG(3, ("pdb_create_builtin_alias: Could not get a gid out of winbind\n"));
-               return NT_STATUS_ACCESS_DENIED;
+               status = NT_STATUS_ACCESS_DENIED;
+               goto done;
        }
 
-       DEBUG(10,("Creating alias %s with gid %u\n", groupname, (unsigned int)gid));
+       DEBUG(10, ("Creating alias %s with gid %u\n", name, (unsigned)gid));
 
-       map.gid = gid;
-       sid_copy(&map.sid, &sid);
-       map.sid_name_use = SID_NAME_ALIAS;
-       fstrcpy(map.nt_name, groupname);
-       fstrcpy(map.comment, "");
+       map->gid = gid;
+       sid_copy(&map->sid, &sid);
+       map->sid_name_use = SID_NAME_ALIAS;
+       map->nt_name = talloc_strdup(map, name);
+       if (!map->nt_name) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
+       map->comment = talloc_strdup(map, "");
+       if (!map->comment) {
+               status = NT_STATUS_NO_MEMORY;
+               goto done;
+       }
 
-       status = pdb_add_group_mapping_entry(&map);
+       status = pdb_add_group_mapping_entry(map);
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("pdb_create_builtin_alias: Could not add group mapping entry for alias %d "
                          "(%s)\n", rid, nt_errstr(status)));
        }
 
+done:
+       TALLOC_FREE(map);
        return status;
 }