mount.cifs: initialize rc to 0 in main
[ira/wip.git] / source3 / client / mount.cifs.c
index fd8014cf9ff7c5248cb955a7f02b9d9c32bce7c3..a73660958055f72559c2edcb32a8ff44cd0ca95c 100644 (file)
 #include <mntent.h>
 #include <fcntl.h>
 #include <limits.h>
+#include "mount.h"
 
 #define MOUNT_CIFS_VERSION_MAJOR "1"
-#define MOUNT_CIFS_VERSION_MINOR "11"
+#define MOUNT_CIFS_VERSION_MINOR "12"
 
 #ifndef MOUNT_CIFS_VENDOR_SUFFIX
  #ifdef _SAMBA_BUILD_
 #define MOUNT_PASSWD_SIZE 64
 #define DOMAIN_SIZE 64
 
-/* exit status - bits below are ORed */
-#define EX_USAGE        1       /* incorrect invocation or permission */
-#define EX_SYSERR       2       /* out of memory, cannot fork, ... */
-#define EX_SOFTWARE     4       /* internal mount bug or wrong version */
-#define EX_USER         8       /* user interrupt */
-#define EX_FILEIO      16       /* problems writing, locking, ... mtab/fstab */
-#define EX_FAIL        32       /* mount failure */
-#define EX_SOMEOK      64       /* some mount succeeded */
+/* currently maximum length of IPv6 address string */
+#define MAX_ADDRESS_LEN INET6_ADDRSTRLEN
 
 const char *thisprogram;
 int verboseflag = 0;
+int fakemnt = 0;
 static int got_password = 0;
 static int got_user = 0;
 static int got_domain = 0;
@@ -197,12 +193,6 @@ static char * getusername(void) {
        return username;
 }
 
-static char * parse_cifs_url(char * unc_name)
-{
-       printf("\nMounting cifs URL not implemented yet. Attempt to mount %s\n",unc_name);
-       return NULL;
-}
-
 static int open_cred_file(char * file_name)
 {
        char * line_buf;
@@ -441,6 +431,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                                        goto nocopy;
                                } else {
                                        printf("username specified with no parameter\n");
+                                       SAFE_FREE(out);
                                        return 1;       /* needs_arg; */
                                }
                        } else {
@@ -473,6 +464,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                                        domain_name = check_for_domain(&value);
                                } else {
                                        printf("username too long\n");
+                                       SAFE_FREE(out);
                                        return 1;
                                }
                        }
@@ -488,6 +480,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                                got_password = 1;
                        } else {
                                printf("password too long\n");
+                               SAFE_FREE(out);
                                return 1;
                        }
                } else if (strncmp(data, "sec", 3) == 0) {
@@ -499,12 +492,13 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                } else if (strncmp(data, "ip", 2) == 0) {
                        if (!value || !*value) {
                                printf("target ip address argument missing");
-                       } else if (strnlen(value, 35) < 35) {
+                       } else if (strnlen(value, MAX_ADDRESS_LEN) <= MAX_ADDRESS_LEN) {
                                if(verboseflag)
                                        printf("ip address %s override specified\n",value);
                                got_ip = 1;
                        } else {
                                printf("ip address too long\n");
+                               SAFE_FREE(out);
                                return 1;
                        }
                } else if ((strncmp(data, "unc", 3) == 0)
@@ -512,6 +506,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                   || (strncmp(data, "path", 4) == 0)) {
                        if (!value || !*value) {
                                printf("invalid path to network resource\n");
+                               SAFE_FREE(out);
                                return 1;  /* needs_arg; */
                        } else if(strnlen(value,5) < 5) {
                                printf("UNC name too short");
@@ -526,6 +521,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                                                got_unc = 1;
                                } else if (strncmp(value, "\\\\", 2) != 0) {                       
                                        printf("UNC Path does not begin with // or \\\\ \n");
+                                       SAFE_FREE(out);
                                        return 1;
                                } else {
                                        if(got_unc)
@@ -535,6 +531,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                                }
                        } else {
                                printf("CIFS: UNC name too long\n");
+                               SAFE_FREE(out);
                                return 1;
                        }
                } else if ((strncmp(data, "dom" /* domain */, 3) == 0)
@@ -544,12 +541,14 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                           and "WORKGRP" etc. */
                        if (!value || !*value) {
                                printf("CIFS: invalid domain name\n");
+                               SAFE_FREE(out);
                                return 1;       /* needs_arg; */
                        }
                        if (strnlen(value, DOMAIN_SIZE+1) < DOMAIN_SIZE+1) {
                                got_domain = 1;
                        } else {
                                printf("domain name too long\n");
+                               SAFE_FREE(out);
                                return 1;
                        }
                } else if (strncmp(data, "cred", 4) == 0) {
@@ -558,10 +557,12 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                                if(rc) {
                                        printf("error %d (%s) opening credential file %s\n",
                                                rc, strerror(rc), value);
+                                       SAFE_FREE(out);
                                        return 1;
                                }
                        } else {
                                printf("invalid credential file name specified\n");
+                               SAFE_FREE(out);
                                return 1;
                        }
                } else if (strncmp(data, "uid", 3) == 0) {
@@ -600,6 +601,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                } else if (strcmp(data, "file_mode") == 0 || strcmp(data, "fmask")==0) {
                        if (!value || !*value) {
                                printf ("Option '%s' requires a numerical argument\n", data);
+                               SAFE_FREE(out);
                                return 1;
                        }
 
@@ -614,6 +616,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
                } else if (strcmp(data, "dir_mode") == 0 || strcmp(data, "dmask")==0) {
                        if (!value || !*value) {
                                printf ("Option '%s' requires a numerical argument\n", data);
+                               SAFE_FREE(out);
                                return 1;
                        }
 
@@ -877,23 +880,23 @@ static void replace_char(char *string, char from, char to, int maxlen)
 }
 
 /* Note that caller frees the returned buffer if necessary */
-static char * parse_server(char ** punc_name)
+static struct addrinfo *
+parse_server(char ** punc_name)
 {
        char * unc_name = *punc_name;
        int length = strnlen(unc_name, MAX_UNC_LEN);
        char * share;
-       char * ipaddress_string = NULL;
-       struct hostent * host_entry = NULL;
-       struct in_addr server_ipaddr;
+       struct addrinfo *addrlist;
+       int rc;
 
        if(length > (MAX_UNC_LEN - 1)) {
                printf("mount error: UNC name too long");
                return NULL;
        }
-       if (strncasecmp("cifs://",unc_name,7) == 0)
-               return parse_cifs_url(unc_name+7);
-       if (strncasecmp("smb://",unc_name,6) == 0) {
-               return parse_cifs_url(unc_name+6);
+       if ((strncasecmp("cifs://", unc_name, 7) == 0) ||
+           (strncasecmp("smb://", unc_name, 6) == 0)) {
+               printf("\nMounting cifs URL not implemented yet. Attempt to mount %s\n", unc_name);
+               return NULL;
        }
 
        if(length < 3) {
@@ -934,7 +937,12 @@ continue_unc_parsing:
                                *share = 0;  /* temporarily terminate the string */
                                share += 1;
                                if(got_ip == 0) {
-                                       host_entry = gethostbyname(unc_name);
+                                       rc = getaddrinfo(unc_name, NULL, NULL, &addrlist);
+                                       if (rc != 0) {
+                                               printf("mount error: could not resolve address for %s: %s\n",
+                                                       unc_name, gai_strerror(rc));
+                                               addrlist = NULL;
+                                       }
                                }
                                *(share - 1) = '/'; /* put delimiter back */
 
@@ -949,23 +957,9 @@ continue_unc_parsing:
                                                printf("ip address specified explicitly\n");
                                        return NULL;
                                }
-                               if(host_entry == NULL) {
-                                       printf("mount error: could not find target server. TCP name %s not found\n", unc_name);
-                                       return NULL;
-                               } else {
-                                       /* BB should we pass an alternate version of the share name as Unicode */
-                                       /* BB what about ipv6? BB */
-                                       /* BB add retries with alternate servers in list */
-
-                                       memcpy(&server_ipaddr.s_addr, host_entry->h_addr, 4);
+                               /* BB should we pass an alternate version of the share name as Unicode */
 
-                                       ipaddress_string = inet_ntoa(server_ipaddr);                                                                                     
-                                       if(ipaddress_string == NULL) {
-                                               printf("mount error: could not get valid ip address for target server\n");
-                                               return NULL;
-                                       }
-                                       return ipaddress_string; 
-                               }
+                               return addrlist; 
                        } else {
                                /* BB add code to find DFS root (send null path on get DFS Referral to specified server here */
                                printf("Mounting the DFS root for a particular server not implemented yet\n");
@@ -1029,14 +1023,15 @@ int main(int argc, char ** argv)
        int flags = MS_MANDLOCK; /* no need to set legacy MS_MGC_VAL */
        char * orgoptions = NULL;
        char * share_name = NULL;
-       char * ipaddr = NULL;
+       const char * ipaddr = NULL;
        char * uuid = NULL;
        char * mountpoint = NULL;
        char * options = NULL;
+       char * optionstail;
        char * resolved_path = NULL;
        char * temp;
        char * dev_name;
-       int rc;
+       int rc = 0;
        int rsize = 0;
        int wsize = 0;
        int nomtab = 0;
@@ -1045,10 +1040,14 @@ int main(int argc, char ** argv)
        int optlen = 0;
        int orgoptlen = 0;
        size_t options_size = 0;
+       size_t current_len;
        int retry = 0; /* set when we have to retry mount with uppercase */
+       struct addrinfo *addrhead = NULL, *addr;
        struct stat statbuf;
        struct utsname sysinfo;
        struct mntent mountent;
+       struct sockaddr_in *addr4;
+       struct sockaddr_in6 *addr6;
        FILE * pmntfile;
 
        /* setlocale(LC_ALL, "");
@@ -1105,8 +1104,8 @@ int main(int argc, char ** argv)
                        mount_cifs_usage ();
                        exit(EX_USAGE);
                case 'n':
-                   ++nomtab;
-                   break;
+                       ++nomtab;
+                       break;
                case 'b':
 #ifdef MS_BIND
                        flags |= MS_BIND;
@@ -1211,6 +1210,9 @@ int main(int argc, char ** argv)
                        break;
                case 't':
                        break;
+               case 'f':
+                       ++fakemnt;
+                       break;
                default:
                        printf("unknown mount option %c\n",c);
                        mount_cifs_usage();
@@ -1240,8 +1242,8 @@ int main(int argc, char ** argv)
                 rc = EX_USAGE;
                goto mount_exit;
        }
-       ipaddr = parse_server(&share_name);
-       if((ipaddr == NULL) && (got_ip == 0)) {
+       addrhead = addr = parse_server(&share_name);
+       if((addrhead == NULL) && (got_ip == 0)) {
                printf("No ip address specified and hostname not found\n");
                rc = EX_USAGE;
                goto mount_exit;
@@ -1288,7 +1290,13 @@ int main(int argc, char ** argv)
        }
 
        if(got_user == 0) {
-               user_name = getusername();
+               /* Note that the password will not be retrieved from the
+                  USER env variable (ie user%password form) as there is
+                  already a PASSWD environment varaible */
+               if (getenv("USER"))
+                       user_name = strdup(getenv("USER"));
+               if (user_name == NULL)
+                       user_name = getusername();
                got_user = 1;
        }
        
@@ -1305,7 +1313,6 @@ int main(int argc, char ** argv)
        }
        /* FIXME launch daemon (handles dfs name resolution and credential change) 
           remember to clear parms and overwrite password field before launching */
-mount_retry:
        if(orgoptions) {
                optlen = strlen(orgoptions);
                orgoptlen = optlen;
@@ -1320,10 +1327,10 @@ mount_retry:
        }
        if(user_name)
                optlen += strlen(user_name) + 6;
-       if(ipaddr)
-               optlen += strlen(ipaddr) + 4;
+       optlen += MAX_ADDRESS_LEN + 4;
        if(mountpassword)
                optlen += strlen(mountpassword) + 6;
+mount_retry:
        SAFE_FREE(options);
        options_size = optlen + 10 + DOMAIN_SIZE;
        options = (char *)malloc(options_size /* space for commas in password */ + 8 /* space for domain=  , domain name itself was counted as part of the length username string above */);
@@ -1333,18 +1340,12 @@ mount_retry:
                exit(EX_SYSERR);
        }
 
-       options[0] = 0;
-       strlcpy(options,"unc=",options_size);
+       strlcpy(options, "unc=", options_size);
        strlcat(options,share_name,options_size);
        /* scan backwards and reverse direction of slash */
        temp = strrchr(options, '/');
        if(temp > options + 6)
                *temp = '\\';
-       if(ipaddr) {
-               strlcat(options,",ip=",options_size);
-               strlcat(options,ipaddr,options_size);
-       }
-
        if(user_name) {
                /* check for syntax like user=domain\user */
                if(got_domain == 0)
@@ -1386,11 +1387,42 @@ mount_retry:
        /* convert all '\\' to '/' in share portion so that /proc/mounts looks pretty */
        replace_char(dev_name, '\\', '/', strlen(share_name));
 
-       if(mount(dev_name, mountpoint, "cifs", flags, options)) {
-       /* remember to kill daemon on error */
+       if (!got_ip && addr) {
+               strlcat(options, ",ip=", options_size);
+               current_len = strnlen(options, options_size);
+               optionstail = options + current_len;
+               switch (addr->ai_addr->sa_family) {
+               case AF_INET6:
+                       addr6 = (struct sockaddr_in6 *) addr->ai_addr;
+                       ipaddr = inet_ntop(AF_INET6, &addr6->sin6_addr, optionstail,
+                                          options_size - current_len);
+                       break;
+               case AF_INET:
+                       addr4 = (struct sockaddr_in *) addr->ai_addr;
+                       ipaddr = inet_ntop(AF_INET, &addr4->sin_addr, optionstail,
+                                          options_size - current_len);
+                       break;
+               }
+
+               /* if the address looks bogus, try the next one */
+               if (!ipaddr) {
+                       addr = addr->ai_next;
+                       if (addr)
+                               goto mount_retry;
+                       rc = EX_SYSERR;
+                       goto mount_exit;
+               }
+       }
+
+       if (!fakemnt && mount(dev_name, mountpoint, "cifs", flags, options)) {
                switch (errno) {
-               case 0:
-                       printf("mount failed but no error number set\n");
+               case ECONNREFUSED:
+               case EHOSTUNREACH:
+                       if (addr) {
+                               addr = addr->ai_next;
+                               if (addr)
+                                       goto mount_retry;
+                       }
                        break;
                case ENODEV:
                        printf("mount error: cifs filesystem not supported by the system\n");
@@ -1405,55 +1437,66 @@ mount_retry:
                                        goto mount_retry;
                                }
                        }
-               default:
-                       printf("mount error %d = %s\n",errno,strerror(errno));
                }
+               printf("mount error(%d): %s\n", errno, strerror(errno));
                printf("Refer to the mount.cifs(8) manual page (e.g.man mount.cifs)\n");
                rc = EX_FAIL;
-       } else {
-               pmntfile = setmntent(MOUNTED, "a+");
-               if(pmntfile) {
-                       mountent.mnt_fsname = dev_name;
-                       mountent.mnt_dir = mountpoint;
-                       mountent.mnt_type = CONST_DISCARD(char *,"cifs");
-                       mountent.mnt_opts = (char *)malloc(220);
-                       if(mountent.mnt_opts) {
-                               char * mount_user = getusername();
-                               memset(mountent.mnt_opts,0,200);
-                               if(flags & MS_RDONLY)
-                                       strlcat(mountent.mnt_opts,"ro",220);
-                               else
-                                       strlcat(mountent.mnt_opts,"rw",220);
-                               if(flags & MS_MANDLOCK)
-                                       strlcat(mountent.mnt_opts,",mand",220);
-                               if(flags & MS_NOEXEC)
-                                       strlcat(mountent.mnt_opts,",noexec",220);
-                               if(flags & MS_NOSUID)
-                                       strlcat(mountent.mnt_opts,",nosuid",220);
-                               if(flags & MS_NODEV)
-                                       strlcat(mountent.mnt_opts,",nodev",220);
-                               if(flags & MS_SYNCHRONOUS)
-                                       strlcat(mountent.mnt_opts,",synch",220);
-                               if(mount_user) {
-                                       if(getuid() != 0) {
-                                               strlcat(mountent.mnt_opts,",user=",220);
-                                               strlcat(mountent.mnt_opts,mount_user,220);
-                                       }
-                                       /* free(mount_user); do not free static mem */
-                               }
+               goto mount_exit;
+       }
+
+       if (nomtab)
+               goto mount_exit;
+       atexit(unlock_mtab);
+       rc = lock_mtab();
+       if (rc) {
+               printf("cannot lock mtab");
+               goto mount_exit;
+       }
+       pmntfile = setmntent(MOUNTED, "a+");
+       if (!pmntfile) {
+               printf("could not update mount table\n");
+               unlock_mtab();
+               rc = EX_FILEIO;
+               goto mount_exit;
+       }
+       mountent.mnt_fsname = dev_name;
+       mountent.mnt_dir = mountpoint;
+       mountent.mnt_type = CONST_DISCARD(char *,"cifs");
+       mountent.mnt_opts = (char *)malloc(220);
+       if(mountent.mnt_opts) {
+               char * mount_user = getusername();
+               memset(mountent.mnt_opts,0,200);
+               if(flags & MS_RDONLY)
+                       strlcat(mountent.mnt_opts,"ro",220);
+               else
+                       strlcat(mountent.mnt_opts,"rw",220);
+               if(flags & MS_MANDLOCK)
+                       strlcat(mountent.mnt_opts,",mand",220);
+               if(flags & MS_NOEXEC)
+                       strlcat(mountent.mnt_opts,",noexec",220);
+               if(flags & MS_NOSUID)
+                       strlcat(mountent.mnt_opts,",nosuid",220);
+               if(flags & MS_NODEV)
+                       strlcat(mountent.mnt_opts,",nodev",220);
+               if(flags & MS_SYNCHRONOUS)
+                       strlcat(mountent.mnt_opts,",sync",220);
+               if(mount_user) {
+                       if(getuid() != 0) {
+                               strlcat(mountent.mnt_opts,
+                                       ",user=", 220);
+                               strlcat(mountent.mnt_opts,
+                                       mount_user, 220);
                        }
-                       mountent.mnt_freq = 0;
-                       mountent.mnt_passno = 0;
-                       rc = addmntent(pmntfile,&mountent);
-                       endmntent(pmntfile);
-                       SAFE_FREE(mountent.mnt_opts);
-                       if (rc)
-                               rc = EX_FILEIO;
-               } else {
-                       printf("could not update mount table\n");
-                       rc = EX_FILEIO;
                }
        }
+       mountent.mnt_freq = 0;
+       mountent.mnt_passno = 0;
+       rc = addmntent(pmntfile,&mountent);
+       endmntent(pmntfile);
+       unlock_mtab();
+       SAFE_FREE(mountent.mnt_opts);
+       if (rc)
+               rc = EX_FILEIO;
 mount_exit:
        if(mountpassword) {
                int len = strlen(mountpassword);
@@ -1461,6 +1504,8 @@ mount_exit:
                SAFE_FREE(mountpassword);
        }
 
+       if (addrhead)
+               freeaddrinfo(addrhead);
        SAFE_FREE(options);
        SAFE_FREE(orgoptions);
        SAFE_FREE(resolved_path);