Move the bang (!) command back to the bottom of the list, allowing smbclient
[ira/wip.git] / source3 / client / client.c
index 9fd55c74f0388d68b98df7591df76c87257f8baa..f1059f8ee1ffd8a227fda1b1b8b213623500dfb0 100644 (file)
@@ -1,8 +1,9 @@
 /* 
    Unix SMB/Netbios implementation.
-   Version 1.9.
+   Version 3.0.
    SMB client
    Copyright (C) Andrew Tridgell 1994-1998
+   Copyright (C) Simo Sorce 2001
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 #define REGISTER 0
 #endif
 
+const char prog_name[] = "smbclient";
+
 struct cli_state *cli;
 extern BOOL in_client;
-static int port = SMB_PORT;
+extern BOOL AllowDebugChange;
+static int port = 0;
 pstring cur_dir = "\\";
 pstring cd_path = "";
 static pstring service;
@@ -40,15 +44,15 @@ static pstring username;
 static pstring workgroup;
 static char *cmdstr;
 static BOOL got_pass;
-static int io_bufsize = 65520;
-extern struct in_addr ipzero;
+static int io_bufsize = 64512;
+static BOOL use_kerberos;
 
 static int name_type = 0x20;
-
+static int max_protocol = PROTOCOL_NT1;
 extern pstring user_socket_options;
 
 static int process_tok(fstring tok);
-static void cmd_help(void);
+static int cmd_help(void);
 
 /* 30 second timeout on most commands */
 #define CLIENT_TIMEOUT (30*1000)
@@ -60,9 +64,6 @@ static void cmd_help(void);
 time_t newer_than = 0;
 int archive_level = 0;
 
-extern pstring debugf;
-extern int DEBUGLEVEL;
-
 BOOL translation = False;
 
 static BOOL have_ip;
@@ -135,17 +136,17 @@ static int writefile(int f, char *b, int n)
   read from a file with LF->CR/LF translation if appropriate. return the 
   number read. read approx n bytes.
 ****************************************************************************/
-static int readfile(char *b, int size, int n, FILE *f)
+static int readfile(char *b, int n, XFILE *f)
 {
        int i;
        int c;
 
-       if (!translation || (size != 1))
-               return(fread(b,size,n,f));
+       if (!translation)
+               return x_fread(b,1,n,f);
   
        i = 0;
        while (i < (n - 1) && (i < BUFFER_SIZE)) {
-               if ((c = getc(f)) == EOF) {
+               if ((c = x_getc(f)) == EOF) {
                        break;
                }
       
@@ -169,12 +170,12 @@ static void send_message(void)
        int grp_id;
 
        if (!cli_message_start(cli, desthost, username, &grp_id)) {
-               DEBUG(0,("message start: %s\n", cli_errstr(cli)));
+               d_printf("message start: %s\n", cli_errstr(cli));
                return;
        }
 
 
-       printf("Connected. Type your message, ending it with a Control-D\n");
+       d_printf("Connected. Type your message, ending it with a Control-D\n");
 
        while (!feof(stdin) && total_len < 1600) {
                int maxlen = MIN(1600 - total_len,127);
@@ -190,15 +191,8 @@ static void send_message(void)
                        msg[l] = c;   
                }
 
-               /*
-                * The message is in UNIX codepage format. Convert to
-                * DOS before sending.
-                */
-
-               unix_to_dos(msg, True);
-
                if (!cli_message_text(cli, msg, l, grp_id)) {
-                       printf("SMBsendtxt failed (%s)\n",cli_errstr(cli));
+                       d_printf("SMBsendtxt failed (%s)\n",cli_errstr(cli));
                        return;
                }      
                
@@ -206,12 +200,12 @@ static void send_message(void)
        }
 
        if (total_len >= 1600)
-               printf("the message was truncated to 1600 bytes\n");
+               d_printf("the message was truncated to 1600 bytes\n");
        else
-               printf("sent %d bytes\n",total_len);
+               d_printf("sent %d bytes\n",total_len);
 
        if (!cli_message_end(cli, grp_id)) {
-               printf("SMBsendend failed (%s)\n",cli_errstr(cli));
+               d_printf("SMBsendend failed (%s)\n",cli_errstr(cli));
                return;
        }      
 }
@@ -221,33 +215,36 @@ static void send_message(void)
 /****************************************************************************
 check the space on a device
 ****************************************************************************/
-static void do_dskattr(void)
+static int do_dskattr(void)
 {
        int total, bsize, avail;
 
        if (!cli_dskattr(cli, &bsize, &total, &avail)) {
-               DEBUG(0,("Error in dskattr: %s\n",cli_errstr(cli))); 
-               return;
+               d_printf("Error in dskattr: %s\n",cli_errstr(cli)); 
+               return 1;
        }
 
-       DEBUG(0,("\n\t\t%d blocks of size %d. %d blocks available\n",
-                total, bsize, avail));
+       d_printf("\n\t\t%d blocks of size %d. %d blocks available\n",
+                total, bsize, avail);
+
+       return 0;
 }
 
 /****************************************************************************
 show cd/pwd
 ****************************************************************************/
-static void cmd_pwd(void)
+static int cmd_pwd(void)
 {
-       DEBUG(0,("Current directory is %s",service));
-       DEBUG(0,("%s\n",cur_dir));
+       d_printf("Current directory is %s",service);
+       d_printf("%s\n",cur_dir);
+       return 0;
 }
 
 
 /****************************************************************************
 change directory - inner section
 ****************************************************************************/
-static void do_cd(char *newdir)
+static int do_cd(char *newdir)
 {
        char *p = newdir;
        pstring saved_dir;
@@ -272,25 +269,30 @@ static void do_cd(char *newdir)
        
        if (!strequal(cur_dir,"\\")) {
                if (!cli_chkpath(cli, dname)) {
-                       DEBUG(0,("cd %s: %s\n", dname, cli_errstr(cli)));
+                       d_printf("cd %s: %s\n", dname, cli_errstr(cli));
                        pstrcpy(cur_dir,saved_dir);
                }
        }
        
        pstrcpy(cd_path,cur_dir);
+
+       return 0;
 }
 
 /****************************************************************************
 change directory
 ****************************************************************************/
-static void cmd_cd(void)
+static int cmd_cd(void)
 {
        fstring buf;
+       int rc = 0;
 
-       if (next_token(NULL,buf,NULL,sizeof(buf)))
-               do_cd(buf);
+       if (next_token_nr(NULL,buf,NULL,sizeof(buf)))
+               rc = do_cd(buf);
        else
-               DEBUG(0,("Current directory is %s\n",cur_dir));
+               d_printf("Current directory is %s\n",cur_dir);
+
+       return rc;
 }
 
 
@@ -327,11 +329,11 @@ static void display_finfo(file_info *finfo)
 {
        if (do_this_one(finfo)) {
                time_t t = finfo->mtime; /* the time is assumed to be passed as GMT */
-               DEBUG(0,("  %-30s%7.7s %8.0f  %s",
+               d_printf("  %-30s%7.7s %8.0f  %s",
                         finfo->name,
                         attrib_string(finfo->mode),
                         (double)finfo->size,
-                        asctime(LocalTime(&t))));
+                        asctime(LocalTime(&t)));
                dir_total += finfo->size;
        }
 }
@@ -372,11 +374,7 @@ functions for do_list_queue
  */
 static void reset_do_list_queue(void)
 {
-       if (do_list_queue)
-       {
-               free(do_list_queue);
-       }
-       do_list_queue = 0;
+       SAFE_FREE(do_list_queue);
        do_list_queue_size = 0;
        do_list_queue_start = 0;
        do_list_queue_end = 0;
@@ -388,8 +386,8 @@ static void init_do_list_queue(void)
        do_list_queue_size = 1024;
        do_list_queue = malloc(do_list_queue_size);
        if (do_list_queue == 0) { 
-               DEBUG(0,("malloc fail for size %d\n",
-                        (int)do_list_queue_size));
+               d_printf("malloc fail for size %d\n",
+                        (int)do_list_queue_size);
                reset_do_list_queue();
        } else {
                memset(do_list_queue, 0, do_list_queue_size);
@@ -422,20 +420,22 @@ static void adjust_do_list_queue(void)
 
 static void add_to_do_list_queue(const char* entry)
 {
+       char *dlq;
        long new_end = do_list_queue_end + ((long)strlen(entry)) + 1;
        while (new_end > do_list_queue_size)
        {
                do_list_queue_size *= 2;
                DEBUG(4,("enlarging do_list_queue to %d\n",
                         (int)do_list_queue_size));
-               do_list_queue = Realloc(do_list_queue, do_list_queue_size);
-               if (! do_list_queue) {
-                       DEBUG(0,("failure enlarging do_list_queue to %d bytes\n",
-                                (int)do_list_queue_size));
+               dlq = Realloc(do_list_queue, do_list_queue_size);
+               if (! dlq) {
+                       d_printf("failure enlarging do_list_queue to %d bytes\n",
+                                (int)do_list_queue_size);
                        reset_do_list_queue();
                }
                else
                {
+                       do_list_queue = dlq;
                        memset(do_list_queue + do_list_queue_size / 2,
                               0, do_list_queue_size / 2);
                }
@@ -473,7 +473,7 @@ static int do_list_queue_empty(void)
 /****************************************************************************
 a helper for do_list
   ****************************************************************************/
-static void do_list_helper(file_info *f, const char *mask)
+static void do_list_helper(file_info *f, const char *mask, void *state)
 {
        if (f->mode & aDIR) {
                if (do_list_dirs && do_this_one(f)) {
@@ -486,7 +486,7 @@ static void do_list_helper(file_info *f, const char *mask)
                        char *p;
 
                        pstrcpy(mask2, mask);
-                       p = strrchr(mask2,'\\');
+                       p = strrchr_m(mask2,'\\');
                        if (!p) return;
                        p[1] = 0;
                        pstrcat(mask2, f->name);
@@ -537,7 +537,7 @@ void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec,
                         */
                        pstring head;
                        pstrcpy(head, do_list_queue_head());
-                       cli_list(cli, head, attribute, do_list_helper);
+                       cli_list(cli, head, attribute, do_list_helper, NULL);
                        remove_do_list_queue_head();
                        if ((! do_list_queue_empty()) && (fn == display_finfo))
                        {
@@ -551,7 +551,7 @@ void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec,
                                                strlen(next_file) - 2;
                                        *save_ch = '\0';
                                }
-                               DEBUG(0,("\n%s\n",next_file));
+                               d_printf("\n%s\n",next_file);
                                if (save_ch)
                                {
                                        *save_ch = '\\';
@@ -561,9 +561,9 @@ void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec,
        }
        else
        {
-               if (cli_list(cli, mask, attribute, do_list_helper) == -1)
+               if (cli_list(cli, mask, attribute, do_list_helper, NULL) == -1)
                {
-                       DEBUG(0, ("%s listing %s\n", cli_errstr(cli), mask));
+                       d_printf("%s listing %s\n", cli_errstr(cli), mask);
                }
        }
 
@@ -574,19 +574,20 @@ void do_list(const char *mask,uint16 attribute,void (*fn)(file_info *),BOOL rec,
 /****************************************************************************
   get a directory listing
   ****************************************************************************/
-static void cmd_dir(void)
+static int cmd_dir(void)
 {
        uint16 attribute = aDIR | aSYSTEM | aHIDDEN;
        pstring mask;
        fstring buf;
        char *p=buf;
+       int rc;
        
        dir_total = 0;
        pstrcpy(mask,cur_dir);
        if(mask[strlen(mask)-1]!='\\')
                pstrcat(mask,"\\");
        
-       if (next_token(NULL,buf,NULL,sizeof(buf))) {
+       if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                dos_format(p);
                if (*p == '\\')
                        pstrcpy(mask,p);
@@ -599,28 +600,31 @@ static void cmd_dir(void)
 
        do_list(mask, attribute, display_finfo, recurse, True);
 
-       do_dskattr();
+       rc = do_dskattr();
 
        DEBUG(3, ("Total bytes listed: %.0f\n", dir_total));
+
+       return rc;
 }
 
 
 /****************************************************************************
   get a directory listing
   ****************************************************************************/
-static void cmd_du(void)
+static int cmd_du(void)
 {
        uint16 attribute = aDIR | aSYSTEM | aHIDDEN;
        pstring mask;
        fstring buf;
        char *p=buf;
+       int rc;
        
        dir_total = 0;
        pstrcpy(mask,cur_dir);
        if(mask[strlen(mask)-1]!='\\')
                pstrcat(mask,"\\");
        
-       if (next_token(NULL,buf,NULL,sizeof(buf))) {
+       if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                dos_format(p);
                if (*p == '\\')
                        pstrcpy(mask,p);
@@ -632,16 +636,18 @@ static void cmd_du(void)
 
        do_list(mask, attribute, do_du, recurse, True);
 
-       do_dskattr();
+       rc = do_dskattr();
 
-       DEBUG(0, ("Total number of bytes: %.0f\n", dir_total));
+       d_printf("Total number of bytes: %.0f\n", dir_total);
+
+       return rc;
 }
 
 
 /****************************************************************************
   get a file from rname to lname
   ****************************************************************************/
-static void do_get(char *rname,char *lname)
+static int do_get(char *rname,char *lname)
 {  
        int handle=0,fnum;
        BOOL newhandle = False;
@@ -651,6 +657,7 @@ static void do_get(char *rname,char *lname)
        uint16 attr;
        size_t size;
        off_t nread = 0;
+       int rc = 0;
 
        GetTimeOfDay(&tp_start);
 
@@ -661,8 +668,8 @@ static void do_get(char *rname,char *lname)
        fnum = cli_open(cli, rname, O_RDONLY, DENY_NONE);
 
        if (fnum == -1) {
-               DEBUG(0,("%s opening remote file %s\n",cli_errstr(cli),rname));
-               return;
+               d_printf("%s opening remote file %s\n",cli_errstr(cli),rname);
+               return 1;
        }
 
        if(!strcmp(lname,"-")) {
@@ -672,8 +679,8 @@ static void do_get(char *rname,char *lname)
                newhandle = True;
        }
        if (handle < 0) {
-               DEBUG(0,("Error opening local file %s\n",lname));
-               return;
+               d_printf("Error opening local file %s\n",lname);
+               return 1;
        }
 
 
@@ -681,17 +688,17 @@ static void do_get(char *rname,char *lname)
                           &attr, &size, NULL, NULL, NULL, NULL, NULL) &&
            !cli_getattrE(cli, fnum, 
                          &attr, &size, NULL, NULL, NULL)) {
-               DEBUG(0,("getattrib: %s\n",cli_errstr(cli)));
-               return;
+               d_printf("getattrib: %s\n",cli_errstr(cli));
+               return 1;
        }
 
        DEBUG(2,("getting file %s of size %.0f as %s ", 
                 lname, (double)size, lname));
 
        if(!(data = (char *)malloc(read_size))) { 
-               DEBUG(0,("malloc fail for size %d\n", read_size));
+               d_printf("malloc fail for size %d\n", read_size);
                cli_close(cli, fnum);
-               return;
+               return 1;
        }
 
        while (1) {
@@ -700,7 +707,8 @@ static void do_get(char *rname,char *lname)
                if (n <= 0) break;
  
                if (writefile(handle,data, n) != n) {
-                       DEBUG(0,("Error writing local file\n"));
+                       d_printf("Error writing local file\n");
+                       rc = 1;
                        break;
                }
       
@@ -709,13 +717,16 @@ static void do_get(char *rname,char *lname)
 
        if (nread < size) {
                DEBUG (0, ("Short read when getting file %s. Only got %ld bytes.\n",
-               rname, (long)nread));
+                           rname, (long)nread));
+
+               rc = 1;
        }
 
-       free(data);
+       SAFE_FREE(data);
        
        if (!cli_close(cli, fnum)) {
-               DEBUG(0,("Error %s closing remote file\n",cli_errstr(cli)));
+               d_printf("Error %s closing remote file\n",cli_errstr(cli));
+               rc = 1;
        }
 
        if (newhandle) {
@@ -741,13 +752,15 @@ static void do_get(char *rname,char *lname)
                         nread / (1.024*this_time + 1.0e-4),
                         get_total_size / (1.024*get_total_time_ms)));
        }
+       
+       return rc;
 }
 
 
 /****************************************************************************
   get a file
   ****************************************************************************/
-static void cmd_get(void)
+static int cmd_get(void)
 {
        pstring lname;
        pstring rname;
@@ -758,16 +771,16 @@ static void cmd_get(void)
        
        p = rname + strlen(rname);
        
-       if (!next_token(NULL,p,NULL,sizeof(rname)-strlen(rname))) {
-               DEBUG(0,("get <filename>\n"));
-               return;
+       if (!next_token_nr(NULL,p,NULL,sizeof(rname)-strlen(rname))) {
+               d_printf("get <filename>\n");
+               return 1;
        }
        pstrcpy(lname,p);
        dos_clean_name(rname);
        
-       next_token(NULL,lname,NULL,sizeof(lname));
+       next_token_nr(NULL,lname,NULL,sizeof(lname));
        
-       do_get(rname, lname);
+       return do_get(rname, lname);
 }
 
 
@@ -785,7 +798,7 @@ static void do_mget(file_info *finfo)
                return;
 
        if (abort_mget) {
-               DEBUG(0,("mget aborted\n"));
+               d_printf("mget aborted\n");
                return;
        }
 
@@ -817,13 +830,13 @@ static void do_mget(file_info *finfo)
        
        if (!directory_exist(finfo->name,NULL) && 
            mkdir(finfo->name,0777) != 0) {
-               DEBUG(0,("failed to create directory %s\n",finfo->name));
+               d_printf("failed to create directory %s\n",finfo->name);
                pstrcpy(cur_dir,saved_curdir);
                return;
        }
        
        if (chdir(finfo->name) != 0) {
-               DEBUG(0,("failed to chdir to directory %s\n",finfo->name));
+               d_printf("failed to chdir to directory %s\n",finfo->name);
                pstrcpy(cur_dir,saved_curdir);
                return;
        }
@@ -840,32 +853,41 @@ static void do_mget(file_info *finfo)
 /****************************************************************************
 view the file using the pager
 ****************************************************************************/
-static void cmd_more(void)
+static int cmd_more(void)
 {
-       fstring rname,lname,tmpname,pager_cmd;
+       fstring rname,lname,pager_cmd;
        char *pager;
+       int fd;
+       int rc = 0;
 
        fstrcpy(rname,cur_dir);
        fstrcat(rname,"\\");
-       slprintf(tmpname,
-                sizeof(fstring)-1,
-                "%s/smbmore.%d",tmpdir(),(int)sys_getpid());
-       fstrcpy(lname,tmpname);
        
-       if (!next_token(NULL,rname+strlen(rname),NULL,sizeof(rname)-strlen(rname))) {
-               DEBUG(0,("more <filename>\n"));
-               return;
+       slprintf(lname,sizeof(lname)-1, "%s/smbmore.XXXXXX",tmpdir());
+       fd = smb_mkstemp(lname);
+       if (fd == -1) {
+               d_printf("failed to create temporary file for more\n");
+               return 1;
+       }
+       close(fd);
+
+       if (!next_token_nr(NULL,rname+strlen(rname),NULL,sizeof(rname)-strlen(rname))) {
+               d_printf("more <filename>\n");
+               unlink(lname);
+               return 1;
        }
        dos_clean_name(rname);
 
-       do_get(rname,lname);
+       rc = do_get(rname,lname);
 
        pager=getenv("PAGER");
 
        slprintf(pager_cmd,sizeof(pager_cmd)-1,
-                "%s %s",(pager? pager:PAGER), tmpname);
+                "%s %s",(pager? pager:PAGER), lname);
        system(pager_cmd);
-       unlink(tmpname);
+       unlink(lname);
+       
+       return rc;
 }
 
 
@@ -873,7 +895,7 @@ static void cmd_more(void)
 /****************************************************************************
 do a mget command
 ****************************************************************************/
-static void cmd_mget(void)
+static int cmd_mget(void)
 {
        uint16 attribute = aSYSTEM | aHIDDEN;
        pstring mget_mask;
@@ -887,7 +909,7 @@ static void cmd_mget(void)
        
        abort_mget = False;
 
-       while (next_token(NULL,p,NULL,sizeof(buf))) {
+       while (next_token_nr(NULL,p,NULL,sizeof(buf))) {
                pstrcpy(mget_mask,cur_dir);
                if(mget_mask[strlen(mget_mask)-1]!='\\')
                        pstrcat(mget_mask,"\\");
@@ -906,6 +928,8 @@ static void cmd_mget(void)
                pstrcat(mget_mask,"*");
                do_list(mget_mask, attribute,do_mget,False,True);
        }
+       
+       return 0;
 }
 
 
@@ -915,29 +939,47 @@ make a directory of name "name"
 static BOOL do_mkdir(char *name)
 {
        if (!cli_mkdir(cli, name)) {
-               DEBUG(0,("%s making remote directory %s\n",
-                        cli_errstr(cli),name));
+               d_printf("%s making remote directory %s\n",
+                        cli_errstr(cli),name);
                return(False);
        }
 
        return(True);
 }
 
+/****************************************************************************
+show 8.3 name of a file
+****************************************************************************/
+static BOOL do_altname(char *name)
+{
+       fstring altname;
+       if (!NT_STATUS_IS_OK(cli_qpathinfo_alt_name(cli, name, altname))) {
+               d_printf("%s getting alt name for %s\n",
+                        cli_errstr(cli),name);
+               return(False);
+       }
+       d_printf("%s\n", altname);
+
+       return(True);
+}
+
 
 /****************************************************************************
  Exit client.
 ****************************************************************************/
-static void cmd_quit(void)
+static int cmd_quit(void)
 {
        cli_shutdown(cli);
        exit(0);
+       /* NOTREACHED */
+       return 0;
 }
 
 
 /****************************************************************************
   make a directory
   ****************************************************************************/
-static void cmd_mkdir(void)
+static int cmd_mkdir(void)
 {
        pstring mask;
        fstring buf;
@@ -945,10 +987,10 @@ static void cmd_mkdir(void)
   
        pstrcpy(mask,cur_dir);
 
-       if (!next_token(NULL,p,NULL,sizeof(buf))) {
+       if (!next_token_nr(NULL,p,NULL,sizeof(buf))) {
                if (!recurse)
-                       DEBUG(0,("mkdir <dirname>\n"));
-               return;
+                       d_printf("mkdir <dirname>\n");
+               return 1;
        }
        pstrcat(mask,p);
 
@@ -971,19 +1013,45 @@ static void cmd_mkdir(void)
        } else {
                do_mkdir(mask);
        }
+       
+       return 0;
+}
+
+
+/****************************************************************************
+  show alt name
+  ****************************************************************************/
+static int cmd_altname(void)
+{
+       pstring name;
+       fstring buf;
+       char *p=buf;
+  
+       pstrcpy(name,cur_dir);
+
+       if (!next_token_nr(NULL,p,NULL,sizeof(buf))) {
+               d_printf("altname <file>\n");
+               return 1;
+       }
+       pstrcat(name,p);
+
+       do_altname(name);
+
+       return 0;
 }
 
 
 /****************************************************************************
   put a single file
   ****************************************************************************/
-static void do_put(char *rname,char *lname)
+static int do_put(char *rname,char *lname)
 {
        int fnum;
-       FILE *f;
+       XFILE *f;
        int nread=0;
        char *buf=NULL;
        int maxwrite=io_bufsize;
+       int rc = 0;
        
        struct timeval tp_start;
        GetTimeOfDay(&tp_start);
@@ -991,22 +1059,22 @@ static void do_put(char *rname,char *lname)
        fnum = cli_open(cli, rname, O_RDWR|O_CREAT|O_TRUNC, DENY_NONE);
   
        if (fnum == -1) {
-               DEBUG(0,("%s opening remote file %s\n",cli_errstr(cli),rname));
-               return;
+               d_printf("%s opening remote file %s\n",cli_errstr(cli),rname);
+               return 1;
        }
 
        /* allow files to be piped into smbclient
           jdblair 24.jun.98 */
        if (!strcmp(lname, "-")) {
-               f = stdin;
+               f = x_stdin;
                /* size of file is not known */
        } else {
-               f = sys_fopen(lname,"r");
+               f = x_fopen(lname,O_RDONLY, 0);
        }
 
        if (!f) {
-               DEBUG(0,("Error opening local file %s\n",lname));
-               return;
+               d_printf("Error opening local file %s\n",lname);
+               return 1;
        }
 
   
@@ -1014,22 +1082,28 @@ static void do_put(char *rname,char *lname)
                 rname));
   
        buf = (char *)malloc(maxwrite);
-       while (!feof(f)) {
+       if (!buf) {
+               d_printf("ERROR: Not enough memory!\n");
+               return 1;
+       }
+       while (!x_feof(f)) {
                int n = maxwrite;
                int ret;
 
-               if ((n = readfile(buf,1,n,f)) < 1) {
-                       if((n == 0) && feof(f))
+               if ((n = readfile(buf,n,f)) < 1) {
+                       if((n == 0) && x_feof(f))
                                break; /* Empty local file. */
 
-                       DEBUG(0,("Error reading local file: %s\n", strerror(errno) ));
+                       d_printf("Error reading local file: %s\n", strerror(errno));
+                       rc = 1;
                        break;
                }
 
                ret = cli_write(cli, fnum, 0, buf, nread, n);
 
                if (n != ret) {
-                       DEBUG(0,("Error writing file: %s\n", cli_errstr(cli)));
+                       d_printf("Error writing file: %s\n", cli_errstr(cli));
+                       rc = 1;
                        break;
                } 
 
@@ -1037,15 +1111,15 @@ static void do_put(char *rname,char *lname)
        }
 
        if (!cli_close(cli, fnum)) {
-               DEBUG(0,("%s closing remote file %s\n",cli_errstr(cli),rname));
-               fclose(f);
-               if (buf) free(buf);
-               return;
+               d_printf("%s closing remote file %s\n",cli_errstr(cli),rname);
+               x_fclose(f);
+               SAFE_FREE(buf);
+               return 1;
        }
 
        
-       fclose(f);
-       if (buf) free(buf);
+       x_fclose(f);
+       SAFE_FREE(buf);
 
        {
                struct timeval tp_end;
@@ -1063,10 +1137,12 @@ static void do_put(char *rname,char *lname)
                         put_total_size / (1.024*put_total_time_ms)));
        }
 
-       if (f == stdin) {
+       if (f == x_stdin) {
                cli_shutdown(cli);
                exit(0);
        }
+       
+       return rc;
 }
 
  
@@ -1074,7 +1150,7 @@ static void do_put(char *rname,char *lname)
 /****************************************************************************
   put a file
   ****************************************************************************/
-static void cmd_put(void)
+static int cmd_put(void)
 {
        pstring lname;
        pstring rname;
@@ -1084,13 +1160,13 @@ static void cmd_put(void)
        pstrcpy(rname,cur_dir);
        pstrcat(rname,"\\");
   
-       if (!next_token(NULL,p,NULL,sizeof(buf))) {
-               DEBUG(0,("put <filename>\n"));
-               return;
+       if (!next_token_nr(NULL,p,NULL,sizeof(buf))) {
+               d_printf("put <filename>\n");
+               return 1;
        }
        pstrcpy(lname,p);
   
-       if (next_token(NULL,p,NULL,sizeof(buf)))
+       if (next_token_nr(NULL,p,NULL,sizeof(buf)))
                pstrcat(rname,p);      
        else
                pstrcat(rname,lname);
@@ -1103,132 +1179,226 @@ static void cmd_put(void)
                   jdblair, 24.jun.98 */
                if (!file_exist(lname,&st) &&
                    (strcmp(lname,"-"))) {
-                       DEBUG(0,("%s does not exist\n",lname));
-                       return;
+                       d_printf("%s does not exist\n",lname);
+                       return 1;
                }
        }
 
-       do_put(rname,lname);
+       return do_put(rname,lname);
 }
 
+/*************************************
+  File list structure
+*************************************/
+
+static struct file_list {
+       struct file_list *prev, *next;
+       char *file_path;
+       BOOL isdir;
+} *file_list;
+
+/****************************************************************************
+  Free a file_list structure
+****************************************************************************/
+
+static void free_file_list (struct file_list * list)
+{
+       struct file_list *tmp;
+       
+       while (list)
+       {
+               tmp = list;
+               DLIST_REMOVE(list, list);
+               SAFE_FREE(tmp->file_path);
+               SAFE_FREE(tmp);
+       }
+}
 
 /****************************************************************************
   seek in a directory/file list until you get something that doesn't start with
   the specified name
   ****************************************************************************/
-static BOOL seek_list(FILE *f,char *name)
-{
-       pstring s;
-       while (!feof(f)) {
-               if (!fgets(s,sizeof(s),f)) return(False);
-               trim_string(s,"./","\n");
-               if (strncmp(s,name,strlen(name)) != 0) {
-                       pstrcpy(name,s);
+static BOOL seek_list(struct file_list *list, char *name)
+{
+       while (list) {
+               trim_string(list->file_path,"./","\n");
+               if (strncmp(list->file_path, name, strlen(name)) != 0) {
                        return(True);
                }
+               list = list->next;
        }
       
        return(False);
 }
 
-
 /****************************************************************************
   set the file selection mask
   ****************************************************************************/
-static void cmd_select(void)
+static int cmd_select(void)
 {
        pstrcpy(fileselection,"");
-       next_token(NULL,fileselection,NULL,sizeof(fileselection));
+       next_token_nr(NULL,fileselection,NULL,sizeof(fileselection));
+
+       return 0;
 }
 
+/****************************************************************************
+  Recursive file matching function act as find
+  match must be always set to True when calling this function
+****************************************************************************/
+static int file_find(struct file_list **list, const char *directory, 
+                     const char *expression, BOOL match)
+{
+       DIR *dir;
+       struct file_list *entry;
+        struct stat statbuf;
+        int ret;
+        char *path;
+       BOOL isdir;
+       char *dname;
+
+        dir = opendir(directory);
+       if (!dir) return -1;
+       
+        while ((dname = readdirname(dir))) {
+               if (!strcmp("..", dname)) continue;
+               if (!strcmp(".", dname)) continue;
+               
+               if (asprintf(&path, "%s/%s", directory, dname) <= 0) {
+                       continue;
+               }
+
+               isdir = False;
+               if (!match || !gen_fnmatch(expression, dname)) {
+                       if (recurse) {
+                               ret = stat(path, &statbuf);
+                               if (ret == 0) {
+                                       if (S_ISDIR(statbuf.st_mode)) {
+                                               isdir = True;
+                                               ret = file_find(list, path, expression, False);
+                                       }
+                               } else {
+                                       d_printf("file_find: cannot stat file %s\n", path);
+                               }
+                               
+                               if (ret == -1) {
+                                       SAFE_FREE(path);
+                                       closedir(dir);
+                                       return -1;
+                               }
+                       }
+                       entry = (struct file_list *) malloc(sizeof (struct file_list));
+                       if (!entry) {
+                               d_printf("Out of memory in file_find\n");
+                               closedir(dir);
+                               return -1;
+                       }
+                       entry->file_path = path;
+                       entry->isdir = isdir;
+                        DLIST_ADD(*list, entry);
+               } else {
+                       SAFE_FREE(path);
+               }
+        }
+
+       closedir(dir);
+       return 0;
+}
 
 /****************************************************************************
   mput some files
   ****************************************************************************/
-static void cmd_mput(void)
+static int cmd_mput(void)
 {
-       pstring lname;
-       pstring rname;
        fstring buf;
        char *p=buf;
        
-       while (next_token(NULL,p,NULL,sizeof(buf))) {
-               SMB_STRUCT_STAT st;
-               pstring cmd;
-               pstring tmpname;
-               FILE *f;
-               
-               slprintf(tmpname,sizeof(pstring)-1,
-                        "%s/ls.smb.%d",tmpdir(),(int)sys_getpid());
-               if (recurse)
-                       slprintf(cmd,sizeof(pstring)-1,
-                               "find . -name \"%s\" -print > %s",p,tmpname);
-               else
-                       slprintf(cmd,sizeof(pstring)-1,
-                               "find . -maxdepth 1 -name \"%s\" -print > %s",p,tmpname);
-               system(cmd);
+       while (next_token_nr(NULL,p,NULL,sizeof(buf))) {
+               int ret;
+               struct file_list *temp_list;
+               char *quest, *lname, *rname;
+       
+               file_list = NULL;
 
-               f = sys_fopen(tmpname,"r");
-               if (!f) continue;
+               ret = file_find(&file_list, ".", p, True);
+               if (ret) {
+                       free_file_list(file_list);
+                       continue;
+               }
                
-               while (!feof(f)) {
-                       pstring quest;
+               quest = NULL;
+               lname = NULL;
+               rname = NULL;
+                               
+               for (temp_list = file_list; temp_list; 
+                    temp_list = temp_list->next) {
 
-                       if (!fgets(lname,sizeof(lname),f)) break;
-                       trim_string(lname,"./","\n");
-                       
-               again1:
+                       SAFE_FREE(lname);
+                       if (asprintf(&lname, "%s/", temp_list->file_path) <= 0)
+                               continue;
+                       trim_string(lname, "./", "/");
                        
                        /* check if it's a directory */
-                       if (directory_exist(lname,&st)) {
-                               if (!recurse) continue;
-                               slprintf(quest,sizeof(pstring)-1,
-                                        "Put directory %s? ",lname);
-                               if (prompt && !yesno(quest)) {
-                                       pstrcat(lname,"/");
-                                       if (!seek_list(f,lname))
-                                               break;
-                                       goto again1;                
-                               }
-             
-                               pstrcpy(rname,cur_dir);
-                               pstrcat(rname,lname);
-                               dos_format(rname);
-                               if (!cli_chkpath(cli, rname) && !do_mkdir(rname)) {
-                                       pstrcat(lname,"/");
-                                       if (!seek_list(f,lname))
-                                               break;
-                                       goto again1;
+                       if (temp_list->isdir) {
+                               /* if (!recurse) continue; */
+                               
+                               SAFE_FREE(quest);
+                               asprintf(&quest, "Put directory %s? ", lname);
+                               if (prompt && !yesno(quest)) { /* No */
+                                       /* Skip the directory */
+                                       lname[strlen(lname)-1] = '/';
+                                       if (!seek_list(temp_list, lname))
+                                               break;              
+                               } else { /* Yes */
+                                       SAFE_FREE(rname);
+                                       asprintf(&rname, "%s%s", cur_dir, lname);
+                                       dos_format(rname);
+                                       if (!cli_chkpath(cli, rname) && 
+                                           !do_mkdir(rname)) {
+                                               DEBUG (0, ("Unable to make dir, skipping..."));
+                                               /* Skip the directory */
+                                               lname[strlen(lname)-1] = '/';
+                                               if (!seek_list(temp_list, lname))
+                                                       break;
+                                       }
                                }
                                continue;
                        } else {
-                               slprintf(quest,sizeof(quest)-1,
-                                        "Put file %s? ",lname);
-                               if (prompt && !yesno(quest)) continue;
+                               SAFE_FREE(quest);
+                               asprintf(&quest,"Put file %s? ", lname);
+                               if (prompt && !yesno(quest)) /* No */
+                                       continue;
                                
-                               pstrcpy(rname,cur_dir);
-                               pstrcat(rname,lname);
+                               /* Yes */
+                               SAFE_FREE(rname);
+                               asprintf(&rname, "%s%s", cur_dir, lname);
                        }
 
                        dos_format(rname);
 
-                       do_put(rname,lname);
+                       do_put(rname, lname);
                }
-               fclose(f);
-               unlink(tmpname);
+               free_file_list(file_list);
+               SAFE_FREE(quest);
+               SAFE_FREE(lname);
+               SAFE_FREE(rname);
        }
+
+       return 0;
 }
 
 
 /****************************************************************************
   cancel a print job
   ****************************************************************************/
-static void do_cancel(int job)
+static int do_cancel(int job)
 {
        if (cli_printjob_del(cli, job)) {
-               printf("Job %d cancelled\n",job);
+               d_printf("Job %d cancelled\n",job);
+               return 0;
        } else {
-               printf("Error calcelling job %d : %s\n",job,cli_errstr(cli));
+               d_printf("Error cancelling job %d : %s\n",job,cli_errstr(cli));
+               return 1;
        }
 }
 
@@ -1236,38 +1406,40 @@ static void do_cancel(int job)
 /****************************************************************************
   cancel a print job
   ****************************************************************************/
-static void cmd_cancel(void)
+static int cmd_cancel(void)
 {
        fstring buf;
        int job; 
 
-       if (!next_token(NULL,buf,NULL,sizeof(buf))) {
-               printf("cancel <jobid> ...\n");
-               return;
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf))) {
+               d_printf("cancel <jobid> ...\n");
+               return 1;
        }
        do {
                job = atoi(buf);
                do_cancel(job);
-       } while (next_token(NULL,buf,NULL,sizeof(buf)));
+       } while (next_token_nr(NULL,buf,NULL,sizeof(buf)));
+       
+       return 0;
 }
 
 
 /****************************************************************************
   print a file
   ****************************************************************************/
-static void cmd_print(void)
+static int cmd_print(void)
 {
        pstring lname;
        pstring rname;
        char *p;
 
-       if (!next_token(NULL,lname,NULL, sizeof(lname))) {
-               DEBUG(0,("print <filename>\n"));
-               return;
+       if (!next_token_nr(NULL,lname,NULL, sizeof(lname))) {
+               d_printf("print <filename>\n");
+               return 1;
        }
 
        pstrcpy(rname,lname);
-       p = strrchr(rname,'/');
+       p = strrchr_m(rname,'/');
        if (p) {
                slprintf(rname, sizeof(rname)-1, "%s-%d", p+1, (int)sys_getpid());
        }
@@ -1276,7 +1448,7 @@ static void cmd_print(void)
                slprintf(rname, sizeof(rname)-1, "stdin-%d", (int)sys_getpid());
        }
 
-       do_put(rname, lname);
+       return do_put(rname, lname);
 }
 
 
@@ -1285,15 +1457,17 @@ static void cmd_print(void)
 ****************************************************************************/
 static void queue_fn(struct print_job_info *p)
 {
-       DEBUG(0,("%-6d   %-9d    %s\n", (int)p->id, (int)p->size, p->name));
+       d_printf("%-6d   %-9d    %s\n", (int)p->id, (int)p->size, p->name);
 }
 
 /****************************************************************************
  show a print queue
 ****************************************************************************/
-static void cmd_queue(void)
+static int cmd_queue(void)
 {
-       cli_print_queue(cli, queue_fn);  
+       cli_print_queue(cli, queue_fn);
+       
+       return 0;
 }
 
 /****************************************************************************
@@ -1310,14 +1484,14 @@ static void do_del(file_info *finfo)
                return;
 
        if (!cli_unlink(cli, mask)) {
-               DEBUG(0,("%s deleting remote file %s\n",cli_errstr(cli),mask));
+               d_printf("%s deleting remote file %s\n",cli_errstr(cli),mask);
        }
 }
 
 /****************************************************************************
 delete some files
 ****************************************************************************/
-static void cmd_del(void)
+static int cmd_del(void)
 {
        pstring mask;
        fstring buf;
@@ -1328,103 +1502,255 @@ static void cmd_del(void)
        
        pstrcpy(mask,cur_dir);
        
-       if (!next_token(NULL,buf,NULL,sizeof(buf))) {
-               DEBUG(0,("del <filename>\n"));
-               return;
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf))) {
+               d_printf("del <filename>\n");
+               return 1;
        }
        pstrcat(mask,buf);
 
        do_list(mask, attribute,do_del,False,False);
+       
+       return 0;
 }
 
 /****************************************************************************
 ****************************************************************************/
-static void cmd_open(void)
+static int cmd_open(void)
 {
        pstring mask;
        fstring buf;
        
        pstrcpy(mask,cur_dir);
        
-       if (!next_token(NULL,buf,NULL,sizeof(buf))) {
-               DEBUG(0,("del <filename>\n"));
-               return;
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf))) {
+               d_printf("open <filename>\n");
+               return 1;
        }
        pstrcat(mask,buf);
 
        cli_open(cli, mask, O_RDWR, DENY_ALL);
+
+       return 0;
 }
 
 
 /****************************************************************************
 remove a directory
 ****************************************************************************/
-static void cmd_rmdir(void)
+static int cmd_rmdir(void)
 {
        pstring mask;
        fstring buf;
   
        pstrcpy(mask,cur_dir);
        
-       if (!next_token(NULL,buf,NULL,sizeof(buf))) {
-               DEBUG(0,("rmdir <dirname>\n"));
-               return;
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf))) {
+               d_printf("rmdir <dirname>\n");
+               return 1;
        }
        pstrcat(mask,buf);
 
        if (!cli_rmdir(cli, mask)) {
-               DEBUG(0,("%s removing remote directory file %s\n",
-                        cli_errstr(cli),mask));
+               d_printf("%s removing remote directory file %s\n",
+                        cli_errstr(cli),mask);
+       }
+       
+       return 0;
+}
+
+/****************************************************************************
+ UNIX hardlink.
+****************************************************************************/
+
+static int cmd_link(void)
+{
+       pstring src,dest;
+       fstring buf,buf2;
+  
+       if (!SERVER_HAS_UNIX_CIFS(cli)) {
+               d_printf("Server doesn't support UNIX CIFS calls.\n");
+               return 1;
+       }
+
+       pstrcpy(src,cur_dir);
+       pstrcpy(dest,cur_dir);
+  
+       if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token(NULL,buf2,NULL, sizeof(buf2))) {
+               d_printf("link <src> <dest>\n");
+               return 1;
+       }
+
+       pstrcat(src,buf);
+       pstrcat(dest,buf2);
+
+       if (!cli_unix_hardlink(cli, src, dest)) {
+               d_printf("%s linking files (%s -> %s)\n", cli_errstr(cli), src, dest);
+               return 1;
        }  
+
+       return 0;
 }
 
 /****************************************************************************
-rename some files
+ UNIX symlink.
 ****************************************************************************/
-static void cmd_rename(void)
+
+static int cmd_symlink(void)
 {
        pstring src,dest;
        fstring buf,buf2;
   
+       if (!SERVER_HAS_UNIX_CIFS(cli)) {
+               d_printf("Server doesn't support UNIX CIFS calls.\n");
+               return 1;
+       }
+
        pstrcpy(src,cur_dir);
        pstrcpy(dest,cur_dir);
        
        if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
            !next_token(NULL,buf2,NULL, sizeof(buf2))) {
-               DEBUG(0,("rename <src> <dest>\n"));
-               return;
+               d_printf("symlink <src> <dest>\n");
+               return 1;
+       }
+
+       pstrcat(src,buf);
+       pstrcat(dest,buf2);
+
+       if (!cli_unix_symlink(cli, src, dest)) {
+               d_printf("%s symlinking files (%s -> %s)\n",
+                       cli_errstr(cli), src, dest);
+               return 1;
+       } 
+
+       return 0;
+}
+
+/****************************************************************************
+ UNIX chmod.
+****************************************************************************/
+
+static int cmd_chmod(void)
+{
+       pstring src;
+       mode_t mode;
+       fstring buf, buf2;
+  
+       if (!SERVER_HAS_UNIX_CIFS(cli)) {
+               d_printf("Server doesn't support UNIX CIFS calls.\n");
+               return 1;
+       }
+
+       pstrcpy(src,cur_dir);
+       
+       if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token(NULL,buf2,NULL, sizeof(buf2))) {
+               d_printf("chmod mode file\n");
+               return 1;
+       }
+
+       mode = (mode_t)strtol(buf, NULL, 8);
+       pstrcat(src,buf2);
+
+       if (!cli_unix_chmod(cli, src, mode)) {
+               d_printf("%s chmod file %s 0%o\n",
+                       cli_errstr(cli), src, (unsigned int)mode);
+               return 1;
+       } 
+
+       return 0;
+}
+
+/****************************************************************************
+ UNIX chown.
+****************************************************************************/
+
+static int cmd_chown(void)
+{
+       pstring src;
+       uid_t uid;
+       gid_t gid;
+       fstring buf, buf2, buf3;
+  
+       if (!SERVER_HAS_UNIX_CIFS(cli)) {
+               d_printf("Server doesn't support UNIX CIFS calls.\n");
+               return 1;
+       }
+
+       pstrcpy(src,cur_dir);
+       
+       if (!next_token(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token(NULL,buf2,NULL, sizeof(buf2)) ||
+           !next_token(NULL,buf3,NULL, sizeof(buf3))) {
+               d_printf("chown uid gid file\n");
+               return 1;
+       }
+
+       uid = (uid_t)atoi(buf);
+       gid = (gid_t)atoi(buf2);
+       pstrcat(src,buf3);
+
+       if (!cli_unix_chown(cli, src, uid, gid)) {
+               d_printf("%s chown file %s uid=%d, gid=%d\n",
+                       cli_errstr(cli), src, (int)uid, (int)gid);
+               return 1;
+       } 
+
+       return 0;
+}
+
+/****************************************************************************
+rename some files
+****************************************************************************/
+static int cmd_rename(void)
+{
+       pstring src,dest;
+       fstring buf,buf2;
+  
+       pstrcpy(src,cur_dir);
+       pstrcpy(dest,cur_dir);
+       
+       if (!next_token_nr(NULL,buf,NULL,sizeof(buf)) || 
+           !next_token_nr(NULL,buf2,NULL, sizeof(buf2))) {
+               d_printf("rename <src> <dest>\n");
+               return 1;
        }
 
        pstrcat(src,buf);
        pstrcat(dest,buf2);
 
        if (!cli_rename(cli, src, dest)) {
-               DEBUG(0,("%s renaming files\n",cli_errstr(cli)));
-               return;
-       }  
+               d_printf("%s renaming files\n",cli_errstr(cli));
+               return 1;
+       }
+       
+       return 0;
 }
 
 
 /****************************************************************************
 toggle the prompt flag
 ****************************************************************************/
-static void cmd_prompt(void)
+static int cmd_prompt(void)
 {
        prompt = !prompt;
        DEBUG(2,("prompting is now %s\n",prompt?"on":"off"));
+       
+       return 1;
 }
 
 
 /****************************************************************************
 set the newer than time
 ****************************************************************************/
-static void cmd_newer(void)
+static int cmd_newer(void)
 {
        fstring buf;
        BOOL ok;
        SMB_STRUCT_STAT sbuf;
 
-       ok = next_token(NULL,buf,NULL,sizeof(buf));
+       ok = next_token_nr(NULL,buf,NULL,sizeof(buf));
        if (ok && (sys_stat(buf,&sbuf) == 0)) {
                newer_than = sbuf.st_mtime;
                DEBUG(1,("Getting files newer than %s",
@@ -1433,30 +1759,38 @@ static void cmd_newer(void)
                newer_than = 0;
        }
 
-       if (ok && newer_than == 0)
-               DEBUG(0,("Error setting newer-than time\n"));
+       if (ok && newer_than == 0) {
+               d_printf("Error setting newer-than time\n");
+               return 1;
+       }
+
+       return 0;
 }
 
 /****************************************************************************
 set the archive level
 ****************************************************************************/
-static void cmd_archive(void)
+static int cmd_archive(void)
 {
        fstring buf;
 
-       if (next_token(NULL,buf,NULL,sizeof(buf))) {
+       if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                archive_level = atoi(buf);
        } else
-               DEBUG(0,("Archive level is %d\n",archive_level));
+               d_printf("Archive level is %d\n",archive_level);
+
+       return 0;
 }
 
 /****************************************************************************
 toggle the lowercaseflag
 ****************************************************************************/
-static void cmd_lowercase(void)
+static int cmd_lowercase(void)
 {
        lowercase = !lowercase;
        DEBUG(2,("filename lowercasing is now %s\n",lowercase?"on":"off"));
+
+       return 0;
 }
 
 
@@ -1465,32 +1799,36 @@ static void cmd_lowercase(void)
 /****************************************************************************
 toggle the recurse flag
 ****************************************************************************/
-static void cmd_recurse(void)
+static int cmd_recurse(void)
 {
        recurse = !recurse;
        DEBUG(2,("directory recursion is now %s\n",recurse?"on":"off"));
+
+       return 0;
 }
 
 /****************************************************************************
 toggle the translate flag
 ****************************************************************************/
-static void cmd_translate(void)
+static int cmd_translate(void)
 {
        translation = !translation;
        DEBUG(2,("CR/LF<->LF and print text translation now %s\n",
                 translation?"on":"off"));
+
+       return 0;
 }
 
 
 /****************************************************************************
 do a printmode command
 ****************************************************************************/
-static void cmd_printmode(void)
+static int cmd_printmode(void)
 {
        fstring buf;
        fstring mode;
 
-       if (next_token(NULL,buf,NULL,sizeof(buf))) {
+       if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                if (strequal(buf,"text")) {
                        printmode = 0;      
                } else {
@@ -1515,25 +1853,30 @@ static void cmd_printmode(void)
                }
        
        DEBUG(2,("the printmode is now %s\n",mode));
+
+       return 0;
 }
 
 /****************************************************************************
 do the lcd command
 ****************************************************************************/
-static void cmd_lcd(void)
+static int cmd_lcd(void)
 {
        fstring buf;
        pstring d;
        
-       if (next_token(NULL,buf,NULL,sizeof(buf)))
+       if (next_token_nr(NULL,buf,NULL,sizeof(buf)))
                chdir(buf);
        DEBUG(2,("the local directory is now %s\n",sys_getwd(d)));
+
+       return 0;
 }
 
 /****************************************************************************
 list a share name
 ****************************************************************************/
-static void browse_fn(const char *name, uint32 m, const char *comment)
+static void browse_fn(const char *name, uint32 m, 
+                      const char *comment, void *state)
 {
         fstring typestr;
 
@@ -1550,9 +1893,11 @@ static void browse_fn(const char *name, uint32 m, const char *comment)
           case STYPE_IPC:
             fstrcpy(typestr,"IPC"); break;
         }
-
-        printf("\t%-15.15s%-10.10s%s\n",
-               name, typestr,comment);
+       /* FIXME: If the remote machine returns non-ascii characters
+          in any of these fields, they can corrupt the output.  We
+          should remove them. */
+       d_printf("\t%-15.15s%-10.10s%s\n",
+               name,typestr,comment);
 }
 
 
@@ -1563,11 +1908,11 @@ static BOOL browse_host(BOOL sort)
 {
        int ret;
 
-        printf("\n\tSharename      Type      Comment\n");
-        printf("\t---------      ----      -------\n");
+        d_printf("\n\tSharename      Type      Comment\n");
+        d_printf("\t---------      ----      -------\n");
 
-       if((ret = cli_RNetShareEnum(cli, browse_fn)) == -1)
-               printf("Error returning browse list: %s\n", cli_errstr(cli));
+       if((ret = cli_RNetShareEnum(cli, browse_fn, NULL)) == -1)
+               d_printf("Error returning browse list: %s\n", cli_errstr(cli));
 
        return (ret != -1);
 }
@@ -1575,9 +1920,10 @@ static BOOL browse_host(BOOL sort)
 /****************************************************************************
 list a server name
 ****************************************************************************/
-static void server_fn(const char *name, uint32 m, const char *comment)
+static void server_fn(const char *name, uint32 m, 
+                      const char *comment, void *state)
 {
-        printf("\t%-16.16s     %s\n", name, comment);
+        d_printf("\t%-16.16s     %s\n", name, comment);
 }
 
 /****************************************************************************
@@ -1586,98 +1932,85 @@ try and browse available connections on a host
 static BOOL list_servers(char *wk_grp)
 {
        if (!cli->server_domain) return False;
+       
+        d_printf("\n\tServer               Comment\n");
+        d_printf("\t---------            -------\n");
 
-        printf("\n\tServer               Comment\n");
-        printf("\t---------            -------\n");
-
-       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_ALL, server_fn);
+       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_ALL, server_fn, NULL);
 
-        printf("\n\tWorkgroup            Master\n");
-        printf("\t---------            -------\n");
+        d_printf("\n\tWorkgroup            Master\n");
+        d_printf("\t---------            -------\n");
 
-       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_DOMAIN_ENUM, server_fn);
+       cli_NetServerEnum(cli, cli->server_domain, SV_TYPE_DOMAIN_ENUM, server_fn, NULL);
        return True;
 }
 
-#if defined(HAVE_LIBREADLINE)
-#  if defined(HAVE_READLINE_HISTORY_H) || defined(HAVE_HISTORY_H)
-/****************************************************************************
-history
-****************************************************************************/
-static void cmd_history(void)
-{
-       HIST_ENTRY **hlist;
-       register int i;
-
-       hlist = history_list ();        /* Get pointer to history list */
-       
-       if (hlist)                      /* If list not empty */
-       {
-               for (i = 0; hlist[i]; i++)      /* then display it */
-                       DEBUG(0, ("%d: %s\n", i, hlist[i]->line));
-       }
-}
-#  endif 
-#endif
-
 /* Some constants for completing filename arguments */
 
 #define COMPL_NONE        0          /* No completions */
 #define COMPL_REMOTE      1          /* Complete remote filename */
 #define COMPL_LOCAL       2          /* Complete local filename */
 
-/* This defines the commands supported by this client */
+/* This defines the commands supported by this client.
+ * NOTE: The "!" must be the last one in the list because it's fn pointer
+ *       field is NULL, and NULL in that field is used in process_tok()
+ *       (below) to indicate the end of the list.  crh
+ */
 struct
 {
   char *name;
-  void (*fn)(void);
+  int (*fn)(void);
   char *description;
   char compl_args[2];      /* Completion argument info */
 } commands[] = 
 {
-  {"ls",cmd_dir,"<mask> list the contents of the current directory",{COMPL_REMOTE,COMPL_NONE}},
+  {"?",cmd_help,"[command] give help on a command",{COMPL_NONE,COMPL_NONE}},
+  {"altname",cmd_altname,"<file> show alt name",{COMPL_NONE,COMPL_NONE}},
+  {"archive",cmd_archive,"<level>\n0=ignore archive bit\n1=only get archive files\n2=only get archive files and reset archive bit\n3=get all files and reset archive bit",{COMPL_NONE,COMPL_NONE}},
+  {"blocksize",cmd_block,"blocksize <number> (default 20)",{COMPL_NONE,COMPL_NONE}},
+  {"cancel",cmd_cancel,"<jobid> cancel a print queue entry",{COMPL_NONE,COMPL_NONE}},
+  {"cd",cmd_cd,"[directory] change/report the remote directory",{COMPL_REMOTE,COMPL_NONE}},
+  {"chmod",cmd_chmod,"<src> <mode> chmod a file using UNIX permission",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"chown",cmd_chown,"<src> <uid> <gid> chown a file using UNIX uids and gids",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"del",cmd_del,"<mask> delete all matching files",{COMPL_REMOTE,COMPL_NONE}},
   {"dir",cmd_dir,"<mask> list the contents of the current directory",{COMPL_REMOTE,COMPL_NONE}},
   {"du",cmd_du,"<mask> computes the total size of the current directory",{COMPL_REMOTE,COMPL_NONE}},
-  {"lcd",cmd_lcd,"[directory] change/report the local current working directory",{COMPL_LOCAL,COMPL_NONE}},
-  {"cd",cmd_cd,"[directory] change/report the remote directory",{COMPL_REMOTE,COMPL_NONE}},
-  {"pwd",cmd_pwd,"show current remote directory (same as 'cd' with no args)",{COMPL_NONE,COMPL_NONE}},
+  {"exit",cmd_quit,"logoff the server",{COMPL_NONE,COMPL_NONE}},
   {"get",cmd_get,"<remote name> [local name] get a file",{COMPL_REMOTE,COMPL_LOCAL}},
+  {"help",cmd_help,"[command] give help on a command",{COMPL_NONE,COMPL_NONE}},
+  {"history",cmd_history,"displays the command history",{COMPL_NONE,COMPL_NONE}},
+  {"lcd",cmd_lcd,"[directory] change/report the local current working directory",{COMPL_LOCAL,COMPL_NONE}},
+  {"link",cmd_link,"<src> <dest> create a UNIX hard link",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"lowercase",cmd_lowercase,"toggle lowercasing of filenames for get",{COMPL_NONE,COMPL_NONE}},  
+  {"ls",cmd_dir,"<mask> list the contents of the current directory",{COMPL_REMOTE,COMPL_NONE}},
+  {"mask",cmd_select,"<mask> mask all filenames against this",{COMPL_REMOTE,COMPL_NONE}},
+  {"md",cmd_mkdir,"<directory> make a directory",{COMPL_NONE,COMPL_NONE}},
   {"mget",cmd_mget,"<mask> get all the matching files",{COMPL_REMOTE,COMPL_NONE}},
-  {"put",cmd_put,"<local name> [remote name] put a file",{COMPL_LOCAL,COMPL_REMOTE}},
-  {"mput",cmd_mput,"<mask> put all matching files",{COMPL_REMOTE,COMPL_NONE}},
-  {"rename",cmd_rename,"<src> <dest> rename some files",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"mkdir",cmd_mkdir,"<directory> make a directory",{COMPL_NONE,COMPL_NONE}},
   {"more",cmd_more,"<remote name> view a remote file with your pager",{COMPL_REMOTE,COMPL_NONE}},  
-  {"mask",cmd_select,"<mask> mask all filenames against this",{COMPL_REMOTE,COMPL_NONE}},
-  {"del",cmd_del,"<mask> delete all matching files",{COMPL_REMOTE,COMPL_NONE}},
+  {"mput",cmd_mput,"<mask> put all matching files",{COMPL_REMOTE,COMPL_NONE}},
+  {"newer",cmd_newer,"<file> only mget files newer than the specified local file",{COMPL_LOCAL,COMPL_NONE}},
   {"open",cmd_open,"<mask> open a file",{COMPL_REMOTE,COMPL_NONE}},
-  {"rm",cmd_del,"<mask> delete all matching files",{COMPL_REMOTE,COMPL_NONE}},
-  {"mkdir",cmd_mkdir,"<directory> make a directory",{COMPL_NONE,COMPL_NONE}},
-  {"md",cmd_mkdir,"<directory> make a directory",{COMPL_NONE,COMPL_NONE}},
-  {"rmdir",cmd_rmdir,"<directory> remove a directory",{COMPL_NONE,COMPL_NONE}},
-  {"rd",cmd_rmdir,"<directory> remove a directory",{COMPL_NONE,COMPL_NONE}},
-  {"prompt",cmd_prompt,"toggle prompting for filenames for mget and mput",{COMPL_NONE,COMPL_NONE}},  
-  {"recurse",cmd_recurse,"toggle directory recursion for mget and mput",{COMPL_NONE,COMPL_NONE}},  
-  {"translate",cmd_translate,"toggle text translation for printing",{COMPL_NONE,COMPL_NONE}},  
-  {"lowercase",cmd_lowercase,"toggle lowercasing of filenames for get",{COMPL_NONE,COMPL_NONE}},  
   {"print",cmd_print,"<file name> print a file",{COMPL_NONE,COMPL_NONE}},
   {"printmode",cmd_printmode,"<graphics or text> set the print mode",{COMPL_NONE,COMPL_NONE}},
+  {"prompt",cmd_prompt,"toggle prompting for filenames for mget and mput",{COMPL_NONE,COMPL_NONE}},  
+  {"put",cmd_put,"<local name> [remote name] put a file",{COMPL_LOCAL,COMPL_REMOTE}},
+  {"pwd",cmd_pwd,"show current remote directory (same as 'cd' with no args)",{COMPL_NONE,COMPL_NONE}},
+  {"q",cmd_quit,"logoff the server",{COMPL_NONE,COMPL_NONE}},
   {"queue",cmd_queue,"show the print queue",{COMPL_NONE,COMPL_NONE}},
-  {"cancel",cmd_cancel,"<jobid> cancel a print queue entry",{COMPL_NONE,COMPL_NONE}},
   {"quit",cmd_quit,"logoff the server",{COMPL_NONE,COMPL_NONE}},
-  {"q",cmd_quit,"logoff the server",{COMPL_NONE,COMPL_NONE}},
-  {"exit",cmd_quit,"logoff the server",{COMPL_NONE,COMPL_NONE}},
-  {"newer",cmd_newer,"<file> only mget files newer than the specified local file",{COMPL_LOCAL,COMPL_NONE}},
-  {"archive",cmd_archive,"<level>\n0=ignore archive bit\n1=only get archive files\n2=only get archive files and reset archive bit\n3=get all files and reset archive bit",{COMPL_NONE,COMPL_NONE}},
-  {"tar",cmd_tar,"tar <c|x>[IXFqbgNan] current directory to/from <file name>",{COMPL_NONE,COMPL_NONE}},
-  {"blocksize",cmd_block,"blocksize <number> (default 20)",{COMPL_NONE,COMPL_NONE}},
-  {"tarmode",cmd_tarmode,
-     "<full|inc|reset|noreset> tar's behaviour towards archive bits",{COMPL_NONE,COMPL_NONE}},
+  {"rd",cmd_rmdir,"<directory> remove a directory",{COMPL_NONE,COMPL_NONE}},
+  {"recurse",cmd_recurse,"toggle directory recursion for mget and mput",{COMPL_NONE,COMPL_NONE}},  
+  {"rename",cmd_rename,"<src> <dest> rename some files",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"rm",cmd_del,"<mask> delete all matching files",{COMPL_REMOTE,COMPL_NONE}},
+  {"rmdir",cmd_rmdir,"<directory> remove a directory",{COMPL_NONE,COMPL_NONE}},
   {"setmode",cmd_setmode,"filename <setmode string> change modes of file",{COMPL_REMOTE,COMPL_NONE}},
-  {"help",cmd_help,"[command] give help on a command",{COMPL_NONE,COMPL_NONE}},
-  {"?",cmd_help,"[command] give help on a command",{COMPL_NONE,COMPL_NONE}},
-#ifdef HAVE_LIBREADLINE
-  {"history",cmd_history,"displays the command history",{COMPL_NONE,COMPL_NONE}},
-#endif
+  {"symlink",cmd_symlink,"<src> <dest> create a UNIX symlink",{COMPL_REMOTE,COMPL_REMOTE}},
+  {"tar",cmd_tar,"tar <c|x>[IXFqbgNan] current directory to/from <file name>",{COMPL_NONE,COMPL_NONE}},
+  {"tarmode",cmd_tarmode,"<full|inc|reset|noreset> tar's behaviour towards archive bits",{COMPL_NONE,COMPL_NONE}},
+  {"translate",cmd_translate,"toggle text translation for printing",{COMPL_NONE,COMPL_NONE}},
+  
+  /* Yes, this must be here, see crh's comment above. */
   {"!",NULL,"run a shell command on the local system",{COMPL_NONE,COMPL_NONE}},
   {"",NULL,NULL,{COMPL_NONE,COMPL_NONE}}
 };
@@ -1716,72 +2049,41 @@ static int process_tok(fstring tok)
 /****************************************************************************
 help
 ****************************************************************************/
-static void cmd_help(void)
+static int cmd_help(void)
 {
        int i=0,j;
        fstring buf;
        
-       if (next_token(NULL,buf,NULL,sizeof(buf))) {
+       if (next_token_nr(NULL,buf,NULL,sizeof(buf))) {
                if ((i = process_tok(buf)) >= 0)
-                       DEBUG(0,("HELP %s:\n\t%s\n\n",commands[i].name,commands[i].description));                   
+                       d_printf("HELP %s:\n\t%s\n\n",commands[i].name,commands[i].description);
        } else {
                while (commands[i].description) {
                        for (j=0; commands[i].description && (j<5); j++) {
-                               DEBUG(0,("%-15s",commands[i].name));
+                               d_printf("%-15s",commands[i].name);
                                i++;
                        }
-                       DEBUG(0,("\n"));
+                       d_printf("\n");
                }
        }
+       return 0;
 }
 
-#ifndef HAVE_LIBREADLINE
-/****************************************************************************
-wait for keyboard activity, swallowing network packets
-****************************************************************************/
-static void wait_keyboard(void)
-{
-       fd_set fds;
-       struct timeval timeout;
-  
-       while (1) {
-               FD_ZERO(&fds);
-               FD_SET(cli->fd,&fds);
-               FD_SET(fileno(stdin),&fds);
-
-               timeout.tv_sec = 20;
-               timeout.tv_usec = 0;
-               sys_select_intr(MAX(cli->fd,fileno(stdin))+1,&fds,&timeout);
-               
-               if (FD_ISSET(fileno(stdin),&fds))
-                       return;
-
-               /* We deliberately use receive_smb instead of
-                  client_receive_smb as we want to receive
-                  session keepalives and then drop them here.
-               */
-               if (FD_ISSET(cli->fd,&fds))
-                       receive_smb(cli->fd,cli->inbuf,0);
-      
-               cli_chkpath(cli, "\\");
-       }  
-}
-#endif
-
 /****************************************************************************
 process a -c command string
 ****************************************************************************/
-static void process_command_string(char *cmd)
+static int process_command_string(char *cmd)
 {
        pstring line;
        char *ptr;
+       int rc = 0;
 
        while (cmd[0] != '\0')    {
                char *p;
                fstring tok;
                int i;
                
-               if ((p = strchr(cmd, ';')) == 0) {
+               if ((p = strchr_m(cmd, ';')) == 0) {
                        strncpy(line, cmd, 999);
                        line[1000] = '\0';
                        cmd += strlen(cmd);
@@ -1794,69 +2096,113 @@ static void process_command_string(char *cmd)
                
                /* and get the first part of the command */
                ptr = line;
-               if (!next_token(&ptr,tok,NULL,sizeof(tok))) continue;
+               if (!next_token_nr(&ptr,tok,NULL,sizeof(tok))) continue;
                
                if ((i = process_tok(tok)) >= 0) {
-                       commands[i].fn();
+                       rc = commands[i].fn();
                } else if (i == -2) {
-                       DEBUG(0,("%s: command abbreviation ambiguous\n",tok));
+                       d_printf("%s: command abbreviation ambiguous\n",tok);
                } else {
-                       DEBUG(0,("%s: command not found\n",tok));
+                       d_printf("%s: command not found\n",tok);
                }
        }
+       
+       return rc;
 }      
 
 /****************************************************************************
-process commands on stdin
+handle completion of commands for readline
 ****************************************************************************/
-static void process_stdin(void)
+static char **completion_fn(char *text, int start, int end)
 {
-       pstring line;
-       char *ptr;
+#define MAX_COMPLETIONS 100
+       char **matches;
+       int i, count=0;
 
-#ifdef HAVE_LIBREADLINE
-/* Minimal readline support, 29Jun1999, s.xenitellis@rhbnc.ac.uk */
-#ifdef PROMPTSIZE
-#undef PROMPTSIZE
-#endif
-#define PROMPTSIZE 2048
-       char prompt_str[PROMPTSIZE];    /* This holds the buffer "smb: \dir1\> " */
-       
-        char *temp;                    /* Gets the buffer from readline() */
-       temp = (char *)NULL;
-#endif
-       while (!feof(stdin)) {
-               fstring tok;
-               int i;
-#ifdef HAVE_LIBREADLINE
-               if ( temp != (char *)NULL )
-               {
-                       free( temp );   /* Free memory allocated every time by readline() */
-                       temp = (char *)NULL;
+       /* for words not at the start of the line fallback to filename completion */
+       if (start) return NULL;
+
+       matches = (char **)malloc(sizeof(matches[0])*MAX_COMPLETIONS);
+       if (!matches) return NULL;
+
+       matches[count++] = strdup(text);
+       if (!matches[0]) return NULL;
+
+       for (i=0;commands[i].fn && count < MAX_COMPLETIONS-1;i++) {
+               if (strncmp(text, commands[i].name, strlen(text)) == 0) {
+                       matches[count] = strdup(commands[i].name);
+                       if (!matches[count]) return NULL;
+                       count++;
                }
+       }
 
-               snprintf( prompt_str, PROMPTSIZE - 1, "smb: %s> ", cur_dir );
+       if (count == 2) {
+               SAFE_FREE(matches[0]);
+               matches[0] = strdup(matches[1]);
+       }
+       matches[count] = NULL;
+       return matches;
+}
 
-               temp = readline( prompt_str );          /* We read the line here */
 
-               if ( !temp )
-                       break;          /* EOF occured */
+/****************************************************************************
+make sure we swallow keepalives during idle time
+****************************************************************************/
+static void readline_callback(void)
+{
+       fd_set fds;
+       struct timeval timeout;
+       static time_t last_t;
+       time_t t;
 
-               if ( *temp )            /* If non-empty line, save to history */
-                       add_history (temp);
-       
-               strncpy( line, temp, 1023 ); /* Maximum size of (pstring)line. Null is guarranteed. */
-#else 
-               /* display a prompt */
-               DEBUG(0,("smb: %s> ", cur_dir));
-               dbgflush( );
+       t = time(NULL);
+
+       if (t - last_t < 5) return;
+
+       last_t = t;
+
+ again:
+       FD_ZERO(&fds);
+       FD_SET(cli->fd,&fds);
+
+       timeout.tv_sec = 0;
+       timeout.tv_usec = 0;
+       sys_select_intr(cli->fd+1,&fds,&timeout);
+               
+       /* We deliberately use receive_smb instead of
+          client_receive_smb as we want to receive
+          session keepalives and then drop them here.
+       */
+       if (FD_ISSET(cli->fd,&fds)) {
+               receive_smb(cli->fd,cli->inbuf,0);
+               goto again;
+       }
+      
+       cli_chkpath(cli, "\\");
+}
+
+
+/****************************************************************************
+process commands on stdin
+****************************************************************************/
+static void process_stdin(void)
+{
+       char *ptr;
+
+       while (1) {
+               fstring tok;
+               fstring the_prompt;
+               char *cline;
+               pstring line;
+               int i;
                
-               wait_keyboard();
+               /* display a prompt */
+               slprintf(the_prompt, sizeof(the_prompt)-1, "smb: %s> ", cur_dir);
+               cline = smb_readline(the_prompt, readline_callback, completion_fn);
+                       
+               if (!cline) break;
                
-               /* and get a response */
-               if (!fgets(line,1000,stdin))
-                       break;
-#endif
+               pstrcpy(line, cline);
 
                /* special case - first char is ! */
                if (*line == '!') {
@@ -1866,14 +2212,14 @@ static void process_stdin(void)
       
                /* and get the first part of the command */
                ptr = line;
-               if (!next_token(&ptr,tok,NULL,sizeof(tok))) continue;
+               if (!next_token_nr(&ptr,tok,NULL,sizeof(tok))) continue;
 
                if ((i = process_tok(tok)) >= 0) {
                        commands[i].fn();
                } else if (i == -2) {
-                       DEBUG(0,("%s: command abbreviation ambiguous\n",tok));
+                       d_printf("%s: command abbreviation ambiguous\n",tok);
                } else {
-                       DEBUG(0,("%s: command not found\n",tok));
+                       d_printf("%s: command not found\n",tok);
                }
        }
 }
@@ -1882,13 +2228,12 @@ static void process_stdin(void)
 /***************************************************** 
 return a connection to a server
 *******************************************************/
-struct cli_state *do_connect(char *server, char *share)
+struct cli_state *do_connect(const char *server, const char *share)
 {
        struct cli_state *c;
        struct nmb_name called, calling;
-       char *server_n;
+       const char *server_n;
        struct in_addr ip;
-       extern struct in_addr ipzero;
        fstring servicename;
        char *sharename;
        
@@ -1897,7 +2242,7 @@ struct cli_state *do_connect(char *server, char *share)
        sharename = servicename;
        if (*sharename == '\\') {
                server = sharename+2;
-               sharename = strchr(server,'\\');
+               sharename = strchr_m(server,'\\');
                if (!sharename) return NULL;
                *sharename = 0;
                sharename++;
@@ -1905,29 +2250,31 @@ struct cli_state *do_connect(char *server, char *share)
 
        server_n = server;
        
-       ip = ipzero;
+       zero_ip(&ip);
 
        make_nmb_name(&calling, global_myname, 0x0);
        make_nmb_name(&called , server, name_type);
 
  again:
-       ip = ipzero;
+       zero_ip(&ip);
        if (have_ip) ip = dest_ip;
 
        /* have to open a new connection */
-       if (!(c=cli_initialise(NULL)) || (cli_set_port(c, port) == 0) ||
+       if (!(c=cli_initialise(NULL)) || (cli_set_port(c, port) != port) ||
            !cli_connect(c, server_n, &ip)) {
-               DEBUG(0,("Connection to %s failed\n", server_n));
+               d_printf("Connection to %s failed\n", server_n);
                return NULL;
        }
 
+       c->protocol = max_protocol;
+       c->use_kerberos = use_kerberos;
+
        if (!cli_session_request(c, &calling, &called)) {
                char *p;
-               DEBUG(0,("session request to %s failed (%s)\n", 
-                        called.name, cli_errstr(c)));
+               d_printf("session request to %s failed (%s)\n", 
+                        called.name, cli_errstr(c));
                cli_shutdown(c);
-               free(c);
-               if ((p=strchr(called.name, '.'))) {
+               if ((p=strchr_m(called.name, '.'))) {
                        *p = 0;
                        goto again;
                }
@@ -1941,9 +2288,8 @@ struct cli_state *do_connect(char *server, char *share)
        DEBUG(4,(" session request ok\n"));
 
        if (!cli_negprot(c)) {
-               DEBUG(0,("protocol negotiation failed\n"));
+               d_printf("protocol negotiation failed\n");
                cli_shutdown(c);
-               free(c);
                return NULL;
        }
 
@@ -1959,35 +2305,29 @@ struct cli_state *do_connect(char *server, char *share)
                               password, strlen(password),
                               workgroup)) {
                /* if a password was not supplied then try again with a null username */
-               if (password[0] || !username[0] || 
+               if (password[0] || !username[0] || use_kerberos ||
                    !cli_session_setup(c, "", "", 0, "", 0, workgroup)) { 
-                       DEBUG(0,("session setup failed: %s\n", cli_errstr(c)));
+                       d_printf("session setup failed: %s\n", cli_errstr(c));
                        cli_shutdown(c);
-                       free(c);
                        return NULL;
                }
-               DEBUG(0,("Anonymous login successful\n"));
+               d_printf("Anonymous login successful\n");
        }
 
-       /*
-        * These next two lines are needed to emulate
-        * old client behaviour for people who have
-        * scripts based on client output.
-        * QUESTION ? Do we want to have a 'client compatibility
-        * mode to turn these on/off ? JRA.
-        */
-
-       if (*c->server_domain || *c->server_os || *c->server_type)
+       if (*c->server_domain) {
                DEBUG(1,("Domain=[%s] OS=[%s] Server=[%s]\n",
                        c->server_domain,c->server_os,c->server_type));
+       } else if (*c->server_os || *c->server_type){
+               DEBUG(1,("OS=[%s] Server=[%s]\n",
+                        c->server_os,c->server_type));
+       }               
        
        DEBUG(4,(" session setup ok\n"));
 
        if (!cli_send_tconX(c, sharename, "?????",
                            password, strlen(password)+1)) {
-               DEBUG(0,("tree connect failed: %s\n", cli_errstr(c)));
+               d_printf("tree connect failed: %s\n", cli_errstr(c));
                cli_shutdown(c);
-               free(c);
                return NULL;
        }
 
@@ -2000,23 +2340,25 @@ struct cli_state *do_connect(char *server, char *share)
 /****************************************************************************
   process commands from the client
 ****************************************************************************/
-static BOOL process(char *base_directory)
+static int process(char *base_directory)
 {
+       int rc = 0;
+
        cli = do_connect(desthost, service);
        if (!cli) {
-               return(False);
+               return 1;
        }
 
        if (*base_directory) do_cd(base_directory);
        
        if (cmdstr) {
-               process_command_string(cmdstr);
+               rc = process_command_string(cmdstr);
        } else {
                process_stdin();
        }
   
        cli_shutdown(cli);
-       return(True);
+       return rc;
 }
 
 /****************************************************************************
@@ -2024,34 +2366,35 @@ usage on the program
 ****************************************************************************/
 static void usage(char *pname)
 {
-  DEBUG(0,("Usage: %s service <password> [options]", pname));
-
-  DEBUG(0,("\nVersion %s\n",VERSION));
-  DEBUG(0,("\t-s smb.conf           pathname to smb.conf file\n"));
-  DEBUG(0,("\t-O socket_options     socket options to use\n"));
-  DEBUG(0,("\t-R name resolve order use these name resolution services only\n"));
-  DEBUG(0,("\t-M host               send a winpopup message to the host\n"));
-  DEBUG(0,("\t-i scope              use this NetBIOS scope\n"));
-  DEBUG(0,("\t-N                    don't ask for a password\n"));
-  DEBUG(0,("\t-n netbios name.      Use this name as my netbios name\n"));
-  DEBUG(0,("\t-d debuglevel         set the debuglevel\n"));
-  DEBUG(0,("\t-P                    connect to service as a printer\n"));
-  DEBUG(0,("\t-p port               connect to the specified port\n"));
-  DEBUG(0,("\t-l log basename.      Basename for log/debug files\n"));
-  DEBUG(0,("\t-h                    Print this help message.\n"));
-  DEBUG(0,("\t-I dest IP            use this IP to connect to\n"));
-  DEBUG(0,("\t-E                    write messages to stderr instead of stdout\n"));
-  DEBUG(0,("\t-U username           set the network username\n"));
-  DEBUG(0,("\t-L host               get a list of shares available on a host\n"));
-  DEBUG(0,("\t-t terminal code      terminal i/o code {sjis|euc|jis7|jis8|junet|hex}\n"));
-  DEBUG(0,("\t-m max protocol       set the max protocol level\n"));
-  DEBUG(0,("\t-A filename           get the credentials from a file\n"));
-  DEBUG(0,("\t-W workgroup          set the workgroup name\n"));
-  DEBUG(0,("\t-T<c|x>IXFqgbNan      command line tar\n"));
-  DEBUG(0,("\t-D directory          start from directory\n"));
-  DEBUG(0,("\t-c command string     execute semicolon separated commands\n"));
-  DEBUG(0,("\t-b xmit/send buffer   changes the transmit/send buffer (default: 65520)\n"));
-  DEBUG(0,("\n"));
+  d_printf("Usage: %s service <password> [options]", pname);
+
+  d_printf("\nVersion %s\n",VERSION);
+  d_printf("\t-s smb.conf           pathname to smb.conf file\n");
+  d_printf("\t-O socket_options     socket options to use\n");
+  d_printf("\t-R name resolve order use these name resolution services only\n");
+  d_printf("\t-M host               send a winpopup message to the host\n");
+  d_printf("\t-i scope              use this NetBIOS scope\n");
+  d_printf("\t-N                    don't ask for a password\n");
+  d_printf("\t-n netbios name.      Use this name as my netbios name\n");
+  d_printf("\t-d debuglevel         set the debuglevel\n");
+  d_printf("\t-P                    connect to service as a printer\n");
+  d_printf("\t-p port               connect to the specified port\n");
+  d_printf("\t-l log basename.      Basename for log/debug files\n");
+  d_printf("\t-h                    Print this help message.\n");
+  d_printf("\t-I dest IP            use this IP to connect to\n");
+  d_printf("\t-E                    write messages to stderr instead of stdout\n");
+  d_printf("\t-k                    use kerberos (active directory) authentication\n");
+  d_printf("\t-U username           set the network username\n");
+  d_printf("\t-L host               get a list of shares available on a host\n");
+  d_printf("\t-t terminal code      terminal i/o code {sjis|euc|jis7|jis8|junet|hex}\n");
+  d_printf("\t-m max protocol       set the max protocol level\n");
+  d_printf("\t-A filename           get the credentials from a file\n");
+  d_printf("\t-W workgroup          set the workgroup name\n");
+  d_printf("\t-T<c|x>IXFqgbNan      command line tar\n");
+  d_printf("\t-D directory          start from directory\n");
+  d_printf("\t-c command string     execute semicolon separated commands\n");
+  d_printf("\t-b xmit/send buffer   changes the transmit/send buffer (default: 65520)\n");
+  d_printf("\n");
 }
 
 
@@ -2162,21 +2505,21 @@ static int do_message_op(void)
        struct in_addr ip;
        struct nmb_name called, calling;
 
-       ip = ipzero;
+        zero_ip(&ip);
 
        make_nmb_name(&calling, global_myname, 0x0);
        make_nmb_name(&called , desthost, name_type);
 
-       ip = ipzero;
+        zero_ip(&ip);
        if (have_ip) ip = dest_ip;
 
-       if (!(cli=cli_initialise(NULL)) || !cli_connect(cli, desthost, &ip)) {
-               DEBUG(0,("Connection to %s failed\n", desthost));
+       if (!(cli=cli_initialise(NULL)) || (cli_set_port(cli, port) != port) || !cli_connect(cli, desthost, &ip)) {
+               d_printf("Connection to %s failed\n", desthost);
                return 1;
        }
 
        if (!cli_session_request(cli, &calling, &called)) {
-               DEBUG(0,("session request failed\n"));
+               d_printf("session request failed\n");
                cli_shutdown(cli);
                return 1;
        }
@@ -2196,16 +2539,17 @@ static int do_message_op(void)
        fstring base_directory;
        char *pname = argv[0];
        int opt;
-       extern FILE *dbf;
        extern char *optarg;
        extern int optind;
+       int old_debug;
        pstring query_host;
        BOOL message = False;
        extern char tar_type;
-       static pstring servicesf = CONFIGFILE;
        pstring term_code;
        pstring new_name_resolve_order;
+       pstring logfile;
        char *p;
+       int rc = 0;
 
 #ifdef KANJI
        pstrcpy(term_code, KANJI);
@@ -2219,11 +2563,8 @@ static int do_message_op(void)
        *new_name_resolve_order = 0;
 
        DEBUGLEVEL = 2;
-
-#ifdef HAVE_LIBREADLINE
-       /* Allow conditional parsing of the ~/.inputrc file. */
-       rl_readline_name = "smbclient";
-#endif    
+       AllowDebugChange = False;
        setup_logging(pname,True);
 
        /*
@@ -2234,15 +2575,15 @@ static int do_message_op(void)
 
        for (opt = 1; opt < argc; opt++) {
                if (strcmp(argv[opt], "-E") == 0)
-                       dbf = stderr;
+                       dbf = x_stderr;
                else if(strncmp(argv[opt], "-s", 2) == 0) {
                        if(argv[opt][2] != '\0')
-                               pstrcpy(servicesf, &argv[opt][2]);
+                               pstrcpy(dyn_CONFIGFILE, &argv[opt][2]);
                        else if(argv[opt+1] != NULL) {
                                /*
                                 * At least one more arg left.
                                 */
-                               pstrcpy(servicesf, argv[opt+1]);
+                               pstrcpy(dyn_CONFIGFILE, argv[opt+1]);
                        } else {
                                usage(pname);
                                exit(1);
@@ -2250,17 +2591,15 @@ static int do_message_op(void)
                }
        }
 
-       TimeInit();
-       charset_initialise();
-
        in_client = True;   /* Make sure that we tell lp_load we are */
 
-       if (!lp_load(servicesf,True,False,False)) {
-               fprintf(stderr, "Can't load %s - run testparm to debug it\n", servicesf);
+       old_debug = DEBUGLEVEL;
+       if (!lp_load(dyn_CONFIGFILE,True,False,False)) {
+               fprintf(stderr, "%s: Can't load %s - run testparm to debug it\n",
+                       prog_name, dyn_CONFIGFILE);
        }
+       DEBUGLEVEL = old_debug;
        
-       codepage_initialise(lp_client_code_page());
-
 #ifdef WITH_SSL
        sslutil_init(0);
 #endif
@@ -2277,11 +2616,11 @@ static int do_message_op(void)
                /* modification to support userid%passwd syntax in the USER var
                   25.Aug.97, jdblair@uab.edu */
 
-               if ((p=strchr(username,'%'))) {
+               if ((p=strchr_m(username,'%'))) {
                        *p = 0;
                        pstrcpy(password,p+1);
                        got_pass = True;
-                       memset(strchr(getenv("USER"),'%')+1,'X',strlen(password));
+                       memset(strchr_m(getenv("USER"),'%')+1,'X',strlen(password));
                }
                strupper(username);
        }
@@ -2311,7 +2650,13 @@ static int do_message_op(void)
                usage(pname);
                exit(1);
        }
-  
+
+       /* FIXME: At the moment, if the user should happen to give the
+        * options ahead of the service name (in standard Unix
+        * fashion) then smbclient just spits out the usage message
+        * with no explanation of what in particular was wrong.  Is
+        * there any reason we can't just parse out the service name
+        * and password after running getopt?? -- mbp */
        if (*argv[1] != '-') {
                pstrcpy(service,argv[1]);  
                /* Convert any '/' characters in the service name to '\' characters */
@@ -2321,7 +2666,7 @@ static int do_message_op(void)
                
                if (count_chars(service,'\\') < 3) {
                        usage(pname);
-                       printf("\n%s: Not enough '\\' characters in service\n",service);
+                       d_printf("\n%s: Not enough '\\' characters in service\n",service);
                        exit(1);
                }
 
@@ -2335,10 +2680,10 @@ static int do_message_op(void)
        }
 
        while ((opt = 
-               getopt(argc, argv,"s:O:R:M:i:Nn:d:Pp:l:hI:EU:L:t:m:W:T:D:c:b:A:")) != EOF) {
+               getopt(argc, argv,"s:O:R:M:i:Nn:d:Pp:l:hI:EU:L:t:m:W:T:D:c:b:A:k")) != EOF) {
                switch (opt) {
                case 's':
-                       pstrcpy(servicesf, optarg);
+                       pstrcpy(dyn_CONFIGFILE, optarg);
                        break;
                case 'O':
                        pstrcpy(user_socket_options,optarg);
@@ -2377,7 +2722,8 @@ static int do_message_op(void)
                        port = atoi(optarg);
                        break;
                case 'l':
-                       slprintf(debugf,sizeof(debugf)-1, "%s.client",optarg);
+                       slprintf(logfile,sizeof(logfile)-1, "%s.client",optarg);
+                       lp_set_logfile(logfile);
                        break;
                case 'h':
                        usage(pname);
@@ -2386,45 +2732,46 @@ static int do_message_op(void)
                case 'I':
                        {
                                dest_ip = *interpret_addr2(optarg);
-                               if (zero_ip(dest_ip))
+                               if (is_zero_ip(dest_ip))
                                        exit(1);
                                have_ip = True;
                        }
                        break;
                case 'E':
-                       dbf = stderr;
+                       display_set_stderr();
+                       dbf = x_stderr;
                        break;
                case 'U':
                        {
                                char *lp;
                                pstrcpy(username,optarg);
-                               if ((lp=strchr(username,'%'))) {
+                               if ((lp=strchr_m(username,'%'))) {
                                        *lp = 0;
                                        pstrcpy(password,lp+1);
                                        got_pass = True;
-                                       memset(strchr(optarg,'%')+1,'X',strlen(password));
+                                       memset(strchr_m(optarg,'%')+1,'X',strlen(password));
                                }
                        }
                        break;
 
                case 'A':
                        {
-                               FILE *auth;
+                               XFILE *auth;
                                fstring buf;
                                uint16 len = 0;
                                char *ptr, *val, *param;
                                
-                               if ((auth=sys_fopen(optarg, "r")) == NULL)
+                               if ((auth=x_fopen(optarg, O_RDONLY, 0)) == NULL)
                                {
                                        /* fail if we can't open the credentials file */
-                                       DEBUG(0,("ERROR: Unable to open credentials file!\n"));
+                                       d_printf("ERROR: Unable to open credentials file!\n");
                                        exit (-1);
                                }
                                 
-                               while (!feof(auth))
+                               while (!x_feof(auth))
                                {  
                                        /* get a line from the file */
-                                       if (!fgets (buf, sizeof(buf), auth))
+                                       if (!x_fgets(buf, sizeof(buf), auth))
                                                continue;
                                        len = strlen(buf);
                                        
@@ -2439,7 +2786,7 @@ static int do_message_op(void)
                                        /* break up the line into parameter & value.
                                           will need to eat a little whitespace possibly */
                                        param = buf;
-                                       if (!(ptr = strchr (buf, '=')))
+                                       if (!(ptr = strchr_m (buf, '=')))
                                                continue;
                                        val = ptr+1;
                                        *ptr = '\0';
@@ -2455,10 +2802,11 @@ static int do_message_op(void)
                                        }
                                        else if (strwicmp("username", param) == 0)
                                                pstrcpy(username, val);
-                                               
+                                       else if (strwicmp("domain", param) == 0)
+                                               pstrcpy(workgroup,val);
                                        memset(buf, 0, sizeof(buf));
                                }
-                               fclose(auth);
+                               x_fclose(auth);
                        }
                        break;
 
@@ -2472,7 +2820,7 @@ static int do_message_op(void)
                        pstrcpy(term_code, optarg);
                        break;
                case 'm':
-                       /* no longer supported */
+                       max_protocol = interpret_protocol(optarg, max_protocol);
                        break;
                case 'W':
                        pstrcpy(workgroup,optarg);
@@ -2488,11 +2836,19 @@ static int do_message_op(void)
                        break;
                case 'c':
                        cmdstr = optarg;
-                       got_pass = True;
                        break;
                case 'b':
                        io_bufsize = MAX(1, atoi(optarg));
                        break;
+               case 'k':
+#ifdef HAVE_KRB5
+                       use_kerberos = True;
+                       got_pass = True;
+#else
+                       d_printf("No kerberos support compiled in\n");
+                       exit(1);
+#endif
+                       break;
                default:
                        usage(pname);
                        exit(1);
@@ -2504,9 +2860,6 @@ static int do_message_op(void)
        if(*new_name_resolve_order)
                lp_set_name_resolve_order(new_name_resolve_order);
 
-       if (*term_code)
-               interpret_coding_system(term_code);
-
        if (!tar_type && !*query_host && !*service && !message) {
                usage(pname);
                exit(1);
@@ -2515,10 +2868,12 @@ static int do_message_op(void)
        DEBUG( 3, ( "Client started (version %s).\n", VERSION ) );
 
        if (tar_type) {
+               if (cmdstr)
+                       process_command_string(cmdstr);
                return do_tar_op(base_directory);
        }
 
-       if ((p=strchr(query_host,'#'))) {
+       if ((p=strchr_m(query_host,'#'))) {
                *p = 0;
                p++;
                sscanf(p, "%x", &name_type);
@@ -2531,10 +2886,10 @@ static int do_message_op(void)
        if (message) {
                return do_message_op();
        }
-
-       if (!process(base_directory)) {
-               return(1);
+       
+       if (process(base_directory)) {
+               return 1;
        }
 
-       return(0);
+       return rc;
 }