Try and fix the buildfarm by using getpwnam(root) instead
[ira/wip.git] / source3 / auth / token_util.c
index 977baa9b234ffc7a962573d39f3c48acc3954bdf..45b0fe2938956b87a88c4a0542ac3f032b11a6d5 100644 (file)
@@ -1,4 +1,4 @@
-/* 
+/*
  *  Unix SMB/CIFS implementation.
  *  Authentication utility functions
  *  Copyright (C) Andrew Tridgell 1992-1998
  *  it under the terms of the GNU General Public License as published by
  *  the Free Software Foundation; either version 3 of the License, or
  *  (at your option) any later version.
- *  
+ *
  *  This program is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  *  GNU General Public License for more details.
- *  
+ *
  *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *  along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 /* functions moved from auth/auth_util.c to minimize linker deps */
  Check for a SID in an NT_USER_TOKEN
 ****************************************************************************/
 
-BOOL nt_token_check_sid ( const DOM_SID *sid, const NT_USER_TOKEN *token )
+bool nt_token_check_sid ( const DOM_SID *sid, const NT_USER_TOKEN *token )
 {
        int i;
-       
+
        if ( !sid || !token )
                return False;
-       
+
        for ( i=0; i<token->num_sids; i++ ) {
                if ( sid_equal( sid, &token->user_sids[i] ) )
                        return True;
@@ -46,11 +45,11 @@ BOOL nt_token_check_sid ( const DOM_SID *sid, const NT_USER_TOKEN *token )
        return False;
 }
 
-BOOL nt_token_check_domain_rid( NT_USER_TOKEN *token, uint32 rid ) 
+bool nt_token_check_domain_rid( NT_USER_TOKEN *token, uint32 rid )
 {
        DOM_SID domain_sid;
 
-       /* if we are a domain member, the get the domain SID, else for 
+       /* if we are a domain member, the get the domain SID, else for
           a DC or standalone server, use our own SID */
 
        if ( lp_server_role() == ROLE_DOMAIN_MEMBER ) {
@@ -60,12 +59,12 @@ BOOL nt_token_check_domain_rid( NT_USER_TOKEN *token, uint32 rid )
                                 "SID for domain [%s]\n", lp_workgroup()));
                        return False;
                }
-       } 
+       }
        else
                sid_copy( &domain_sid, get_global_sam_sid() );
 
        sid_append_rid( &domain_sid, rid );
-       
+
        return nt_token_check_sid( &domain_sid, token );\
 }
 
@@ -78,26 +77,49 @@ BOOL nt_token_check_domain_rid( NT_USER_TOKEN *token, uint32 rid )
 
 NT_USER_TOKEN *get_root_nt_token( void )
 {
-       static NT_USER_TOKEN *token = NULL;
+       struct nt_user_token *token, *for_cache;
        DOM_SID u_sid, g_sid;
        struct passwd *pw;
-       
-       if ( token )
-               return token;
+       void *cache_data;
 
-       if ( !(pw = sys_getpwnam( "root" )) ) {
-               DEBUG(0,("get_root_nt_token: getpwnam\"root\") failed!\n"));
+       cache_data = memcache_lookup_talloc(
+               NULL, SINGLETON_CACHE_TALLOC,
+               data_blob_string_const_null("root_nt_token"));
+
+       if (cache_data != NULL) {
+               return talloc_get_type_abort(
+                       cache_data, struct nt_user_token);
+       }
+
+#if defined(DEVELOPER)
+       if ( !(pw = sys_getpwnam("root")) ) {
+               DEBUG(0,("get_root_nt_token: sys_getpwnam(\"root\") failed!\n"));
                return NULL;
        }
-       
-       /* get the user and primary group SIDs; although the 
+#else
+       if ( !(pw = sys_getpwuid(0)) ) {
+               DEBUG(0,("get_root_nt_token: sys_getpwuid(0) failed!\n"));
+               return NULL;
+       }
+#endif
+
+       /* get the user and primary group SIDs; although the
           BUILTIN\Administrators SId is really the one that matters here */
-          
+
        uid_to_sid(&u_sid, pw->pw_uid);
        gid_to_sid(&g_sid, pw->pw_gid);
 
-       token = create_local_nt_token(NULL, &u_sid, False,
+       token = create_local_nt_token(talloc_autofree_context(), &u_sid, False,
                                      1, &global_sid_Builtin_Administrators);
+
+       token->privileges = se_disk_operators;
+
+       for_cache = token;
+
+       memcache_add_talloc(
+               NULL, SINGLETON_CACHE_TALLOC,
+               data_blob_string_const_null("root_nt_token"), &for_cache);
+
        return token;
 }
 
@@ -129,22 +151,22 @@ NTSTATUS add_aliases(const DOM_SID *domain_sid,
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("pdb_enum_alias_memberships failed: %s\n",
                           nt_errstr(status)));
-               TALLOC_FREE(tmp_ctx);
-               return status;
+               goto done;
        }
 
        for (i=0; i<num_aliases; i++) {
                DOM_SID alias_sid;
                sid_compose(&alias_sid, domain_sid, aliases[i]);
-               if (!add_sid_to_array_unique(token, &alias_sid,
-                                       &token->user_sids,
-                                       &token->num_sids)) {
+               status = add_sid_to_array_unique(token, &alias_sid,
+                                                &token->user_sids,
+                                                &token->num_sids);
+               if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(0, ("add_sid_to_array failed\n"));
-                       TALLOC_FREE(tmp_ctx);
-                       return NT_STATUS_NO_MEMORY;
+                       goto done;
                }
        }
 
+done:
        TALLOC_FREE(tmp_ctx);
        return NT_STATUS_OK;
 }
@@ -152,118 +174,170 @@ NTSTATUS add_aliases(const DOM_SID *domain_sid,
 /*******************************************************************
 *******************************************************************/
 
-static NTSTATUS add_builtin_administrators( struct nt_user_token *token )
+static NTSTATUS add_builtin_administrators(struct nt_user_token *token,
+                                          const DOM_SID *dom_sid)
 {
        DOM_SID domadm;
+       NTSTATUS status;
 
        /* nothing to do if we aren't in a domain */
-       
+
        if ( !(IS_DC || lp_server_role()==ROLE_DOMAIN_MEMBER) ) {
                return NT_STATUS_OK;
        }
-       
+
        /* Find the Domain Admins SID */
-       
+
        if ( IS_DC ) {
                sid_copy( &domadm, get_global_sam_sid() );
        } else {
-               if ( !secrets_fetch_domain_sid( lp_workgroup(), &domadm ) )
-                       return NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
+               sid_copy(&domadm, dom_sid);
        }
        sid_append_rid( &domadm, DOMAIN_GROUP_RID_ADMINS );
-       
+
        /* Add Administrators if the user beloongs to Domain Admins */
-       
+
        if ( nt_token_check_sid( &domadm, token ) ) {
-               if (!add_sid_to_array(token, &global_sid_Builtin_Administrators,
-                                        &token->user_sids, &token->num_sids)) {
-                       return NT_STATUS_NO_MEMORY;
+               status = add_sid_to_array(token,
+                                         &global_sid_Builtin_Administrators,
+                                         &token->user_sids, &token->num_sids);
+       if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
        }
-       
+
        return NT_STATUS_OK;
 }
 
+/**
+ * Create the requested BUILTIN if it doesn't already exist.  This requires
+ * winbindd to be running.
+ *
+ * @param[in] rid BUILTIN rid to create
+ * @return Normal NTSTATUS return.
+ */
+static NTSTATUS create_builtin(uint32 rid)
+{
+       NTSTATUS status = NT_STATUS_OK;
+       DOM_SID sid;
+       gid_t gid;
+
+       if (!sid_compose(&sid, &global_sid_Builtin, rid)) {
+               return NT_STATUS_NO_SUCH_ALIAS;
+       }
+
+       if (!sid_to_gid(&sid, &gid)) {
+               if (!lp_winbind_nested_groups() || !winbind_ping()) {
+                       return NT_STATUS_PROTOCOL_UNREACHABLE;
+               }
+               status = pdb_create_builtin_alias(rid);
+       }
+       return status;
+}
+
+/**
+ * Add sid as a member of builtin_sid.
+ *
+ * @param[in] builtin_sid      An existing builtin group.
+ * @param[in] dom_sid          sid to add as a member of builtin_sid.
+ * @return Normal NTSTATUS return
+ */
+static NTSTATUS add_sid_to_builtin(const DOM_SID *builtin_sid,
+                                  const DOM_SID *dom_sid)
+{
+       NTSTATUS status = NT_STATUS_OK;
+
+       if (!dom_sid || !builtin_sid) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       status = pdb_add_aliasmem(builtin_sid, dom_sid);
+
+       if (NT_STATUS_EQUAL(status, NT_STATUS_MEMBER_IN_ALIAS)) {
+               DEBUG(5, ("add_sid_to_builtin %s is already a member of %s\n",
+                         sid_string_dbg(dom_sid),
+                         sid_string_dbg(builtin_sid)));
+               return NT_STATUS_OK;
+       }
+
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(4, ("add_sid_to_builtin %s could not be added to %s: "
+                         "%s\n", sid_string_dbg(dom_sid),
+                         sid_string_dbg(builtin_sid), nt_errstr(status)));
+       }
+       return status;
+}
+
 /*******************************************************************
 *******************************************************************/
 
-static NTSTATUS create_builtin_users( void )
+NTSTATUS create_builtin_users(const DOM_SID *dom_sid)
 {
        NTSTATUS status;
        DOM_SID dom_users;
 
-       status = pdb_create_builtin_alias( BUILTIN_ALIAS_RID_USERS );
+       status = create_builtin(BUILTIN_ALIAS_RID_USERS);
        if ( !NT_STATUS_IS_OK(status) ) {
-               DEBUG(0,("create_builtin_users: Failed to create Users\n"));
+               DEBUG(5,("create_builtin_users: Failed to create Users\n"));
                return status;
        }
-       
+
        /* add domain users */
-       if ((IS_DC || (lp_server_role() == ROLE_DOMAIN_MEMBER)) 
-               && secrets_fetch_domain_sid(lp_workgroup(), &dom_users))
+       if ((IS_DC || (lp_server_role() == ROLE_DOMAIN_MEMBER))
+               && sid_compose(&dom_users, dom_sid, DOMAIN_GROUP_RID_USERS))
        {
-               sid_append_rid(&dom_users, DOMAIN_GROUP_RID_USERS );
-               status = pdb_add_aliasmem( &global_sid_Builtin_Users, &dom_users);
-               if ( !NT_STATUS_IS_OK(status) ) {
-                       DEBUG(0,("create_builtin_administrators: Failed to add Domain Users to"
-                               " Users\n"));
-                       return status;
-               }
+               status = add_sid_to_builtin(&global_sid_Builtin_Users,
+                                           &dom_users);
        }
-                       
-       return NT_STATUS_OK;
-}              
+
+       return status;
+}
 
 /*******************************************************************
 *******************************************************************/
 
-static NTSTATUS create_builtin_administrators( void )
+NTSTATUS create_builtin_administrators(const DOM_SID *dom_sid)
 {
        NTSTATUS status;
        DOM_SID dom_admins, root_sid;
        fstring root_name;
-       enum lsa_SidType type;          
+       enum lsa_SidType type;
        TALLOC_CTX *ctx;
-       BOOL ret;
+       bool ret;
 
-       status = pdb_create_builtin_alias( BUILTIN_ALIAS_RID_ADMINS );
+       status = create_builtin(BUILTIN_ALIAS_RID_ADMINS);
        if ( !NT_STATUS_IS_OK(status) ) {
-               DEBUG(0,("create_builtin_administrators: Failed to create Administrators\n"));
+               DEBUG(5,("create_builtin_administrators: Failed to create Administrators\n"));
                return status;
        }
-       
+
        /* add domain admins */
-       if ((IS_DC || (lp_server_role() == ROLE_DOMAIN_MEMBER)) 
-               && secrets_fetch_domain_sid(lp_workgroup(), &dom_admins))
+       if ((IS_DC || (lp_server_role() == ROLE_DOMAIN_MEMBER))
+               && sid_compose(&dom_admins, dom_sid, DOMAIN_GROUP_RID_ADMINS))
        {
-               sid_append_rid(&dom_admins, DOMAIN_GROUP_RID_ADMINS);
-               status = pdb_add_aliasmem( &global_sid_Builtin_Administrators, &dom_admins );
-               if ( !NT_STATUS_IS_OK(status) ) {
-                       DEBUG(0,("create_builtin_administrators: Failed to add Domain Admins"
-                               " Administrators\n"));
+               status = add_sid_to_builtin(&global_sid_Builtin_Administrators,
+                                           &dom_admins);
+               if (!NT_STATUS_IS_OK(status)) {
                        return status;
                }
        }
-                       
+
        /* add root */
        if ( (ctx = talloc_init("create_builtin_administrators")) == NULL ) {
                return NT_STATUS_NO_MEMORY;
        }
        fstr_sprintf( root_name, "%s\\root", get_global_sam_name() );
-       ret = lookup_name( ctx, root_name, 0, NULL, NULL, &root_sid, &type );
+       ret = lookup_name(ctx, root_name, LOOKUP_NAME_DOMAIN, NULL, NULL,
+                         &root_sid, &type);
        TALLOC_FREE( ctx );
 
        if ( ret ) {
-               status = pdb_add_aliasmem( &global_sid_Builtin_Administrators, &root_sid );
-               if ( !NT_STATUS_IS_OK(status) ) {
-                       DEBUG(0,("create_builtin_administrators: Failed to add root"
-                               " Administrators\n"));
-                       return status;
-               }
+               status = add_sid_to_builtin(&global_sid_Builtin_Administrators,
+                                           &root_sid);
        }
-       
-       return NT_STATUS_OK;
-}              
+
+       return status;
+}
 
 
 /*******************************************************************
@@ -272,7 +346,7 @@ static NTSTATUS create_builtin_administrators( void )
 
 struct nt_user_token *create_local_nt_token(TALLOC_CTX *mem_ctx,
                                            const DOM_SID *user_sid,
-                                           BOOL is_guest,
+                                           bool is_guest,
                                            int num_groupsids,
                                            const DOM_SID *groupsids)
 {
@@ -280,52 +354,64 @@ struct nt_user_token *create_local_nt_token(TALLOC_CTX *mem_ctx,
        int i;
        NTSTATUS status;
        gid_t gid;
+       DOM_SID dom_sid;
 
-       DEBUG(10, ("Create local NT token for %s\n", sid_string_static(user_sid)));
+       DEBUG(10, ("Create local NT token for %s\n",
+                  sid_string_dbg(user_sid)));
 
-       if (!(result = TALLOC_ZERO_P(mem_ctx, NT_USER_TOKEN))) {
+       if (!(result = TALLOC_ZERO_P(mem_ctx, struct nt_user_token))) {
                DEBUG(0, ("talloc failed\n"));
                return NULL;
        }
 
        /* Add the user and primary group sid */
 
-       if (!add_sid_to_array(result, user_sid,
-                        &result->user_sids, &result->num_sids)) {
+       status = add_sid_to_array(result, user_sid,
+                                 &result->user_sids, &result->num_sids);
+       if (!NT_STATUS_IS_OK(status)) {
                return NULL;
        }
 
        /* For guest, num_groupsids may be zero. */
        if (num_groupsids) {
-               if (!add_sid_to_array(result, &groupsids[0],
-                                &result->user_sids, &result->num_sids)) {
+               status = add_sid_to_array(result, &groupsids[0],
+                                         &result->user_sids,
+                                         &result->num_sids);
+               if (!NT_STATUS_IS_OK(status)) {
                        return NULL;
                }
        }
-                        
+
        /* Add in BUILTIN sids */
-       
-       if (!add_sid_to_array(result, &global_sid_World,
-                        &result->user_sids, &result->num_sids)) {
+
+       status = add_sid_to_array(result, &global_sid_World,
+                                 &result->user_sids, &result->num_sids);
+       if (!NT_STATUS_IS_OK(status)) {
                return NULL;
        }
-       if (!add_sid_to_array(result, &global_sid_Network,
-                        &result->user_sids, &result->num_sids)) {
+       status = add_sid_to_array(result, &global_sid_Network,
+                                 &result->user_sids, &result->num_sids);
+       if (!NT_STATUS_IS_OK(status)) {
                return NULL;
        }
 
        if (is_guest) {
-               if (!add_sid_to_array(result, &global_sid_Builtin_Guests,
-                                &result->user_sids, &result->num_sids)) {
+               status = add_sid_to_array(result, &global_sid_Builtin_Guests,
+                                         &result->user_sids,
+                                         &result->num_sids);
+               if (!NT_STATUS_IS_OK(status)) {
                        return NULL;
                }
        } else {
-               if (!add_sid_to_array(result, &global_sid_Authenticated_Users,
-                                &result->user_sids, &result->num_sids)) {
+               status = add_sid_to_array(result,
+                                         &global_sid_Authenticated_Users,
+                                         &result->user_sids,
+                                         &result->num_sids);
+               if (!NT_STATUS_IS_OK(status)) {
                        return NULL;
                }
        }
-       
+
        /* Now the SIDs we got from authentication. These are the ones from
         * the info3 struct or from the pdb_enum_group_memberships, depending
         * on who authenticated the user.
@@ -333,67 +419,81 @@ struct nt_user_token *create_local_nt_token(TALLOC_CTX *mem_ctx,
         * first group sid as primary above. */
 
        for (i=1; i<num_groupsids; i++) {
-               if (!add_sid_to_array_unique(result, &groupsids[i],
-                                       &result->user_sids, &result->num_sids)) {
+               status = add_sid_to_array_unique(result, &groupsids[i],
+                                                &result->user_sids,
+                                                &result->num_sids);
+               if (!NT_STATUS_IS_OK(status)) {
                        return NULL;
                }
        }
-       
+
        /* Deal with the BUILTIN\Administrators group.  If the SID can
-          be resolved then assume that the add_aliasmem( S-1-5-32 ) 
+          be resolved then assume that the add_aliasmem( S-1-5-32 )
           handled it. */
 
-       if ( !sid_to_gid( &global_sid_Builtin_Administrators, &gid ) ) {
-               /* We can only create a mapping if winbind is running 
-                  and the nested group functionality has been enabled */
-                  
-               if ( lp_winbind_nested_groups() && winbind_ping() ) {
-                       become_root();
-                       status = create_builtin_administrators( );
+       if (!sid_to_gid(&global_sid_Builtin_Administrators, &gid)) {
+
+               become_root();
+               if (!secrets_fetch_domain_sid(lp_workgroup(), &dom_sid)) {
+                       status = NT_STATUS_OK;
+                       DEBUG(3, ("Failed to fetch domain sid for %s\n",
+                                 lp_workgroup()));
+               } else {
+                       status = create_builtin_administrators(&dom_sid);
+               }
+               unbecome_root();
+
+               if (NT_STATUS_EQUAL(status, NT_STATUS_PROTOCOL_UNREACHABLE)) {
+                       /* Add BUILTIN\Administrators directly to token. */
+                       status = add_builtin_administrators(result, &dom_sid);
                        if ( !NT_STATUS_IS_OK(status) ) {
-                               DEBUG(2,("create_local_nt_token: Failed to create BUILTIN\\Administrators group!\n"));
-                               /* don't fail, just log the message */
+                               DEBUG(3, ("Failed to check for local "
+                                         "Administrators membership (%s)\n",
+                                         nt_errstr(status)));
                        }
-                       unbecome_root();
+               } else if (!NT_STATUS_IS_OK(status)) {
+                       DEBUG(2, ("WARNING: Failed to create "
+                                 "BUILTIN\\Administrators group!  Can "
+                                 "Winbind allocate gids?\n"));
                }
-               else {
-                       status = add_builtin_administrators( result );
-                       if ( !NT_STATUS_IS_OK(status) ) {
-                               /* just log a complaint but do not fail */
-                               DEBUG(3,("create_local_nt_token: failed to check for local Administrators"
-                                       " membership (%s)\n", nt_errstr(status)));
-                       }                       
-               }               
        }
 
        /* Deal with the BUILTIN\Users group.  If the SID can
-          be resolved then assume that the add_aliasmem( S-1-5-32 ) 
+          be resolved then assume that the add_aliasmem( S-1-5-32 )
           handled it. */
 
-       if ( !sid_to_gid( &global_sid_Builtin_Users, &gid ) ) {
-               /* We can only create a mapping if winbind is running 
-                  and the nested group functionality has been enabled */
-                  
-               if ( lp_winbind_nested_groups() && winbind_ping() ) {
-                       become_root();
-                       status = create_builtin_users( );
-                       if ( !NT_STATUS_IS_OK(status) ) {
-                               DEBUG(2,("create_local_nt_token: Failed to create BUILTIN\\Users group!\n"));
-                               /* don't fail, just log the message */
-                       }
-                       unbecome_root();
+       if (!sid_to_gid(&global_sid_Builtin_Users, &gid)) {
+
+               become_root();
+               if (!secrets_fetch_domain_sid(lp_workgroup(), &dom_sid)) {
+                       status = NT_STATUS_OK;
+                       DEBUG(3, ("Failed to fetch domain sid for %s\n",
+                                 lp_workgroup()));
+               } else {
+                       status = create_builtin_users(&dom_sid);
+               }
+               unbecome_root();
+
+               if (!NT_STATUS_EQUAL(status, NT_STATUS_PROTOCOL_UNREACHABLE) &&
+                   !NT_STATUS_IS_OK(status))
+               {
+                       DEBUG(2, ("WARNING: Failed to create BUILTIN\\Users group! "
+                                 "Can Winbind allocate gids?\n"));
                }
        }
 
        /* Deal with local groups */
-       
+
        if (lp_winbind_nested_groups()) {
 
+               become_root();
+
                /* Now add the aliases. First the one from our local SAM */
 
                status = add_aliases(get_global_sam_sid(), result);
 
                if (!NT_STATUS_IS_OK(status)) {
+                       unbecome_root();
                        TALLOC_FREE(result);
                        return NULL;
                }
@@ -403,10 +503,13 @@ struct nt_user_token *create_local_nt_token(TALLOC_CTX *mem_ctx,
                status = add_aliases(&global_sid_Builtin, result);
 
                if (!NT_STATUS_IS_OK(status)) {
+                       unbecome_root();
                        TALLOC_FREE(result);
                        return NULL;
                }
-       } 
+
+               unbecome_root();
+       }
 
 
        get_privileges_for_sids(&result->privileges, result->user_sids,
@@ -421,21 +524,21 @@ struct nt_user_token *create_local_nt_token(TALLOC_CTX *mem_ctx,
 void debug_nt_user_token(int dbg_class, int dbg_lev, NT_USER_TOKEN *token)
 {
        size_t     i;
-       
+
        if (!token) {
                DEBUGC(dbg_class, dbg_lev, ("NT user token: (NULL)\n"));
                return;
        }
-       
+
        DEBUGC(dbg_class, dbg_lev,
               ("NT user token of user %s\n",
-               sid_string_static(&token->user_sids[0]) ));
+               sid_string_dbg(&token->user_sids[0]) ));
        DEBUGADDC(dbg_class, dbg_lev,
                  ("contains %lu SIDs\n", (unsigned long)token->num_sids));
        for (i = 0; i < token->num_sids; i++)
                DEBUGADDC(dbg_class, dbg_lev,
-                         ("SID[%3lu]: %s\n", (unsigned long)i, 
-                          sid_string_static(&token->user_sids[i])));
+                         ("SID[%3lu]: %s\n", (unsigned long)i,
+                          sid_string_dbg(&token->user_sids[i])));
 
        dump_se_priv( dbg_class, dbg_lev, &token->privileges );
 }
@@ -455,7 +558,7 @@ void debug_unix_user_token(int dbg_class, int dbg_lev, uid_t uid, gid_t gid,
                  ("Primary group is %ld and contains %i supplementary "
                   "groups\n", (long int)gid, n_groups));
        for (i = 0; i < n_groups; i++)
-               DEBUGADDC(dbg_class, dbg_lev, ("Group[%3i]: %ld\n", i, 
+               DEBUGADDC(dbg_class, dbg_lev, ("Group[%3i]: %ld\n", i,
                        (long int)groups[i]));
 }