selftest: ignore empty lines in knownfailures

[ira/wip.git] / selftest / Subunit / Filter.pm

diff --git a/selftest/Subunit/Filter.pm b/selftest/Subunit/Filter.pm
index 443baeb7ddb8d70944e16318c2e5177274331977..3c226958bdc3628b988070d25ff277fe49f8ac24 100644 (file)
--- a/selftest/Subunit/Filter.pm
+++ b/selftest/Subunit/Filter.pm
@@ -15,6 +15,7 @@ sub read_test_regexes($)
        while (<LF>) { 
                chomp; 
                next if (/^#/);
+               next if (/^$/);
                if (/^(.*?)([ \t]+)\#([\t ]*)(.*?)$/) {
                        push (@ret, [$1, $4]);
                } else {
@@ -54,7 +55,11 @@ sub report_time($$)
 sub output_msg($$)
 {
        my ($self, $msg) = @_;
-       print $msg;
+       unless(defined($self->{output})) {
+               print $msg;
+       } else {
+               $self->{output}.=$msg;
+       }
 }
 
 sub start_test($$)
@@ -65,6 +70,10 @@ sub start_test($$)
                $testname = $self->{prefix}.$testname;
        }
 
+       if ($self->{strip_ok_output}) {
+               $self->{output} = "";
+       }
+
        Subunit::start_test($testname);
 }
 
@@ -87,6 +96,17 @@ sub end_test($$$$$)
                $reason .= $xfail_reason;
        }
 
+       if ($result eq "fail" or $result eq "failure") {
+               $self->{fail_added}++;
+       }
+
+       if ($self->{strip_ok_output}) {
+               unless ($result eq "success" or $result eq "xfail" or $result eq "skip") {
+                       print $self->{output}
+               }
+       }
+       $self->{output} = undef;
+
        Subunit::end_test($testname, $result, $reason);
 }
 
@@ -100,16 +120,18 @@ sub start_testsuite($;$)
 {
        my ($self, $name) = @_;
        Subunit::start_testsuite($name);
+       $self->{fail_added} = 0;
        $self->{xfail_added} = 0;
 }
 
 sub end_testsuite($$;$)
 {
        my ($self, $name, $result, $reason) = @_;
-       if ($self->{xfail_added} and ($result eq "fail" or $result eq "failure")) {
+       if ($self->{fail_added} == 0 and $self->{xfail_added} and
+           ($result eq "fail" or $result eq "failure")) {
                $result = "xfail";
        }
-               
+
        Subunit::end_testsuite($name, $result, $reason);
 }
 
@@ -120,11 +142,12 @@ sub testsuite_count($$)
 }
 
 sub new {
-       my ($class, $prefix, $expected_failures) = @_;
+       my ($class, $prefix, $expected_failures, $strip_ok_output) = @_;
 
        my $self = { 
                prefix => $prefix,
                expected_failures => $expected_failures,
+               strip_ok_output => $strip_ok_output,
                xfail_added => 0,
        };
        bless($self, $class);