pidl - Remove "Py_RETURN_NONE" compatibility code
[ira/wip.git] / pidl / lib / Parse / Pidl / Samba4 / Python.pm
index 4c598b3ca0da5f45bbcb414cd5e6f4bd0a35401a..781d640cabdc69e51d074651a5aaa6e77285bf05 100644 (file)
@@ -9,7 +9,7 @@ use Exporter;
 @ISA = qw(Exporter);
 
 use strict;
-use Parse::Pidl qw(warning fatal);
+use Parse::Pidl qw(warning fatal error);
 use Parse::Pidl::Typelist qw(hasType resolveType getType mapTypeName expandAlias);
 use Parse::Pidl::Util qw(has_property ParseExpr unmake_str);
 use Parse::Pidl::NDR qw(GetPrevLevel GetNextLevel ContainsDeferred is_charset_array);
@@ -24,7 +24,8 @@ sub new($) {
        my ($class) = @_;
        my $self = { res => "", res_hdr => "", tabs => "", constants => {},
                     module_methods => [], module_objects => [], ready_types => [],
-                                readycode => [] };
+                                module_imports => [], type_imports => {},
+                                patch_type_calls => [], readycode => [] };
        bless($self, $class);
 }
 
@@ -38,7 +39,9 @@ sub pidl($$)
 {
        my ($self, $d) = @_;
        if ($d) {
-               $self->{res} .= $self->{tabs};
+               if ((!($d =~ /^#/))) {
+                       $self->{res} .= $self->{tabs};
+               }
                $self->{res} .= $d;
        }
        $self->{res} .= "\n";
@@ -56,6 +59,15 @@ sub deindent($)
        $self->{tabs} = substr($self->{tabs}, 0, -1);
 }
 
+sub PrettifyTypeName($$)
+{
+       my ($name, $basename) = @_;
+
+       $name =~ s/^$basename\_//;
+
+       return $name;
+}
+
 sub Import
 {
        my $self = shift;
@@ -63,7 +75,8 @@ sub Import
        foreach (@imports) {
                $_ = unmake_str($_);
                s/\.idl$//;
-               $self->pidl_hdr("#include \"librpc/gen_ndr/py_$_\.h\"\n");
+               $self->pidl_hdr("#include \"librpc/gen_ndr/$_\.h\"\n");
+               $self->register_module_import($_);
        }
 }
 
@@ -182,7 +195,7 @@ sub PythonStruct($$$$$$)
                        $self->pidl("static PyObject *py_$name\_get_$e->{NAME}(PyObject *obj, void *closure)");
                        $self->pidl("{");
                        $self->indent;
-                       $self->pidl("$cname *object = py_talloc_get_ptr(obj);");
+                       $self->pidl("$cname *object = ($cname *)py_talloc_get_ptr(obj);");
                        $self->pidl("PyObject *py_$e->{NAME};");
                        $self->ConvertObjectToPython("py_talloc_get_mem_ctx(obj)", $env, $e, $varname, "py_$e->{NAME}", "return NULL;");
                        $self->pidl("return py_$e->{NAME};");
@@ -193,7 +206,7 @@ sub PythonStruct($$$$$$)
                        $self->pidl("static int py_$name\_set_$e->{NAME}(PyObject *py_obj, PyObject *value, void *closure)");
                        $self->pidl("{");
                        $self->indent;
-                       $self->pidl("$cname *object = py_talloc_get_ptr(py_obj);");
+                       $self->pidl("$cname *object = ($cname *)py_talloc_get_ptr(py_obj);");
                        my $mem_ctx = "py_talloc_get_mem_ctx(py_obj)";
                        my $l = $e->{LEVELS}[0];
                        my $nl = GetNextLevel($e, $l);
@@ -221,14 +234,10 @@ sub PythonStruct($$$$$$)
                $self->pidl("");
        }
 
-       $self->pidl("static PyObject *py_$name\_new(PyTypeObject *self, PyObject *args, PyObject *kwargs)");
+       $self->pidl("static PyObject *py_$name\_new(PyTypeObject *type, PyObject *args, PyObject *kwargs)");
        $self->pidl("{");
        $self->indent;
-       $self->pidl("char *kwlist[] = {NULL};");
-       $self->pidl("$cname *ret = talloc_zero(NULL, $cname);");
-       $self->pidl("if (!PyArg_ParseTupleAndKeywords(args, kwargs, \"\", kwlist))");
-       $self->pidl("\treturn NULL;");
-       $self->pidl("return py_talloc_import(&$name\_Type, ret);");
+       $self->pidl("return py_talloc_new($cname, type);");
        $self->deindent;
        $self->pidl("}");
        $self->pidl("");
@@ -241,7 +250,7 @@ sub PythonStruct($$$$$$)
                $self->pidl("static PyObject *py_$name\_ndr_pack(PyObject *py_obj)");
                $self->pidl("{");
                $self->indent;
-               $self->pidl("$cname *object = py_talloc_get_ptr(py_obj);");
+               $self->pidl("$cname *object = ($cname *)py_talloc_get_ptr(py_obj);");
                $self->pidl("DATA_BLOB blob;");
                $self->pidl("enum ndr_err_code err;");
                $self->pidl("err = ndr_push_struct_blob(&blob, py_talloc_get_mem_ctx(py_obj), NULL, object, (ndr_push_flags_fn_t)ndr_push_$name);");
@@ -260,7 +269,7 @@ sub PythonStruct($$$$$$)
                $self->pidl("static PyObject *py_$name\_ndr_unpack(PyObject *py_obj, PyObject *args)");
                $self->pidl("{");
                $self->indent;
-               $self->pidl("$cname *object = py_talloc_get_ptr(py_obj);");
+               $self->pidl("$cname *object = ($cname *)py_talloc_get_ptr(py_obj);");
                $self->pidl("DATA_BLOB blob;");
                $self->pidl("enum ndr_err_code err;");
                $self->pidl("if (!PyArg_ParseTuple(args, \"s#:__ndr_unpack__\", &blob.data, &blob.length))");
@@ -274,7 +283,7 @@ sub PythonStruct($$$$$$)
                $self->deindent;
                $self->pidl("}");
                $self->pidl("");
-               $self->pidl("return Py_None;");
+               $self->pidl("Py_RETURN_NONE;");
                $self->deindent;
                $self->pidl("}");
                $self->pidl("");
@@ -283,36 +292,27 @@ sub PythonStruct($$$$$$)
                $self->indent;
                $self->pidl("{ \"__ndr_pack__\", (PyCFunction)py_$name\_ndr_pack, METH_NOARGS, \"S.pack() -> blob\\nNDR pack\" },");
                $self->pidl("{ \"__ndr_unpack__\", (PyCFunction)py_$name\_ndr_unpack, METH_VARARGS, \"S.unpack(blob) -> None\\nNDR unpack\" },");
-               $self->deindent;
-               $self->pidl("#ifdef ".uc("py_$name\_extra_methods"));
-               $self->pidl("\t" .uc("py_$name\_extra_methods"));
-               $self->pidl("#endif");
-               $self->indent;
                $self->pidl("{ NULL, NULL, 0, NULL }");
                $self->deindent;
                $self->pidl("};");
                $self->pidl("");
        }
 
-       $self->pidl_hdr("PyAPI_DATA(PyTypeObject) $name\_Type;\n");
-       $self->pidl_hdr("#define $name\_Check(op) PyObject_TypeCheck(op, &$name\_Type)\n");
-       $self->pidl_hdr("#define $name\_CheckExact(op) ((op)->ob_type == &$name\_Type)\n");
-       $self->pidl_hdr("\n");
-       $self->pidl("#ifndef ".uc("py_$name\_repr"));
-       $self->pidl("#define ".uc("py_$name\_repr") . " py_talloc_default_repr");
-       $self->pidl("#endif");
+       $self->pidl_hdr("staticforward PyTypeObject $name\_Type;\n");
        $self->pidl("");
-       my $docstring = ($self->DocString($d, $name) or "NULL");
+       my $docstring = $self->DocString($d, $name);
        my $typeobject = "$name\_Type";
-       $self->pidl("PyTypeObject $typeobject = {");
+       $self->pidl("static PyTypeObject $typeobject = {");
        $self->indent;
        $self->pidl("PyObject_HEAD_INIT(NULL) 0,");
        $self->pidl(".tp_name = \"$modulename.$prettyname\",");
        $self->pidl(".tp_basicsize = sizeof(py_talloc_Object),");
        $self->pidl(".tp_dealloc = py_talloc_dealloc,");
        $self->pidl(".tp_getset = $getsetters,");
-       $self->pidl(".tp_repr = ".uc("py_$name\_repr").",");
-       $self->pidl(".tp_doc = $docstring,");
+       $self->pidl(".tp_repr = py_talloc_default_repr,");
+       if ($docstring) {
+               $self->pidl(".tp_doc = $docstring,");
+       }
        $self->pidl(".tp_methods = $py_methods,");
        $self->pidl(".tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_BASETYPE,");
        $self->pidl(".tp_new = py_$name\_new,");
@@ -414,7 +414,7 @@ sub PythonFunctionUnpackOut($$$)
        } elsif (defined($fn->{RETURN_TYPE}) and $fn->{RETURN_TYPE} eq "WERROR") {
                $self->handle_werror("r->out.result", "NULL", undef);
        } elsif (defined($fn->{RETURN_TYPE})) {
-               my $conv = $self->ConvertObjectToPythonData("r", $fn->{RETURN_TYPE}, "r->out.result");
+               my $conv = $self->ConvertObjectToPythonData("r", $fn->{RETURN_TYPE}, "r->out.result", $fn);
                if ($result_size > 1) {
                        $self->pidl("PyTuple_SetItem(result, $i, $conv);");
                } else {
@@ -487,7 +487,7 @@ sub PythonFunctionPackIn($$$)
                next unless (grep(/in/,@{$e->{DIRECTION}}));
                if ($metadata_args->{in}->{$e->{NAME}}) {
                        my $py_var = "py_".$metadata_args->{in}->{$e->{NAME}};
-                       $self->pidl("PY_CHECK_TYPE(PyList, $py_var, $fail);");
+                       $self->pidl("PY_CHECK_TYPE(&PyList_Type, $py_var, $fail);");
                        my $val = "PyList_Size($py_var)";
                        if ($e->{LEVELS}[0]->{TYPE} eq "POINTER") {
                                $self->pidl("r->in.$e->{NAME} = talloc_ptrtype(r, r->in.$e->{NAME});");
@@ -573,11 +573,7 @@ sub PythonType($$$$)
 
        if ($actual_ctype->{TYPE} eq "STRUCT") {
                my $typeobject;
-               my $fn_name = $d->{NAME};
-
-               $fn_name =~ s/^$interface->{NAME}_//;
-               $fn_name =~ s/^$basename\_//;
-
+               my $fn_name = PrettifyTypeName($d->{NAME}, $basename);
 
                if ($d->{TYPE} eq "STRUCT") {
                        $typeobject = $self->PythonStruct($modulename, $fn_name, $d->{NAME}, mapTypeName($d), $d);
@@ -631,11 +627,6 @@ sub Interface($$$)
 {
        my($self,$interface,$basename) = @_;
 
-       $self->pidl_hdr("#ifndef _HEADER_PYTHON_$interface->{NAME}\n");
-       $self->pidl_hdr("#define _HEADER_PYTHON_$interface->{NAME}\n\n");
-
-       $self->pidl_hdr("\n");
-
        if (has_property($interface, "pyhelper")) {
                $self->pidl("#include \"".unmake_str($interface->{PROPERTIES}->{pyhelper})."\"\n");
        }
@@ -649,7 +640,7 @@ sub Interface($$$)
        }
 
        if (defined $interface->{PROPERTIES}->{uuid}) {
-               $self->pidl_hdr("PyAPI_DATA(PyTypeObject) $interface->{NAME}_InterfaceType;\n");
+               $self->pidl_hdr("staticforward PyTypeObject $interface->{NAME}_InterfaceType;\n");
                $self->pidl("");
 
                my @fns = ();
@@ -669,7 +660,6 @@ sub Interface($$$)
                }
 
                $self->pidl("const struct PyNdrRpcMethodDef py_ndr_$interface->{NAME}\_methods[] = {");
-               $self->pidl_hdr("extern const struct PyNdrRpcMethodDef py_ndr_$interface->{NAME}\_methods[];");
                $self->indent;
                foreach my $d (@fns) {
                        my ($infn, $outfn, $callfn, $prettyname, $docstring, $opnum) = @$d;
@@ -680,92 +670,13 @@ sub Interface($$$)
                $self->pidl("};");
                $self->pidl("");
 
-               $self->pidl("static PyObject *interface_$interface->{NAME}_new(PyTypeObject *self, PyObject *args, PyObject *kwargs)");
+               $self->pidl("static PyObject *interface_$interface->{NAME}_new(PyTypeObject *type, PyObject *args, PyObject *kwargs)");
                $self->pidl("{");
                $self->indent;
-               $self->pidl("dcerpc_InterfaceObject *ret;");
-               $self->pidl("const char *binding_string;");
-               $self->pidl("struct cli_credentials *credentials;");
-               $self->pidl("struct loadparm_context *lp_ctx = NULL;");
-               $self->pidl("PyObject *py_lp_ctx = Py_None, *py_credentials = Py_None, *py_basis = Py_None;");
-               $self->pidl("TALLOC_CTX *mem_ctx = NULL;");
-               $self->pidl("struct event_context *event_ctx;");
-               $self->pidl("NTSTATUS status;");
-               $self->pidl("");
-               $self->pidl("const char *kwnames[] = {");
-               $self->indent;
-               $self->pidl("\"binding\", \"lp_ctx\", \"credentials\", \"basis_connection\", NULL");
-               $self->deindent;
-               $self->pidl("};");
-               $self->pidl("extern struct loadparm_context *lp_from_py_object(PyObject *py_obj);");
-               $self->pidl("extern struct cli_credentials *cli_credentials_from_py_object(PyObject *py_obj);");
-               $self->pidl("");
-               $self->pidl("if (!PyArg_ParseTupleAndKeywords(args, kwargs, \"s|OOO:$interface->{NAME}\", discard_const_p(char *, kwnames), &binding_string, &py_lp_ctx, &py_credentials, &py_basis)) {");
-               $self->indent;
-               $self->pidl("return NULL;");
-               $self->deindent;
-               $self->pidl("}");
-               $self->pidl("");
-               $self->pidl("lp_ctx = lp_from_py_object(py_lp_ctx);");
-               $self->pidl("if (lp_ctx == NULL) {");
-               $self->indent;
-               $self->pidl("PyErr_SetString(PyExc_TypeError, \"Expected loadparm context\");");
-               $self->pidl("return NULL;");
-               $self->deindent;
-               $self->pidl("}");
-               $self->pidl("");
-
-               $self->pidl("status = dcerpc_init(lp_ctx);");
-               $self->pidl("if (!NT_STATUS_IS_OK(status)) {");
-               $self->indent;
-               $self->pidl("PyErr_SetNTSTATUS(status);");
-               $self->pidl("return NULL;");
-               $self->deindent;
-               $self->pidl("}");
-
-               $self->pidl("credentials = cli_credentials_from_py_object(py_credentials);");
-               $self->pidl("if (credentials == NULL) {");
-               $self->indent;
-               $self->pidl("PyErr_SetString(PyExc_TypeError, \"Expected credentials\");");
-               $self->pidl("return NULL;");
-               $self->deindent;
-               $self->pidl("}");
-
-               $self->pidl("ret = PyObject_New(dcerpc_InterfaceObject, &$interface->{NAME}_InterfaceType);");
-               $self->pidl("");
-               $self->pidl("event_ctx = event_context_init(mem_ctx);");
-               $self->pidl("");
-
-               $self->pidl("if (py_basis != Py_None) {");
-               $self->indent;
-               $self->pidl("struct dcerpc_pipe *base_pipe;");
-               $self->pidl("");
-               $self->pidl("if (!PyObject_TypeCheck(py_basis, &dcerpc_InterfaceType)) {");
-               $self->indent;
-               $self->pidl("PyErr_SetString(PyExc_ValueError, \"basis_connection must be a DCE/RPC connection\");");
-               $self->pidl("talloc_free(mem_ctx);");
-               $self->pidl("return NULL;");
-               $self->deindent;
-               $self->pidl("}");
-               $self->pidl("");
-               $self->pidl("base_pipe = ((dcerpc_InterfaceObject *)py_basis)->pipe;");
-               $self->pidl("");
-               $self->pidl("status = dcerpc_secondary_context(base_pipe, &ret->pipe, &ndr_table_$interface->{NAME});");
-               $self->deindent;
-               $self->pidl("} else {");
-               $self->indent;
-               $self->pidl("status = dcerpc_pipe_connect(NULL, &ret->pipe, binding_string, ");
-               $self->pidl("             &ndr_table_$interface->{NAME}, credentials, event_ctx, lp_ctx);");
-               $self->deindent;
-               $self->pidl("}");
-               $self->handle_ntstatus("status", "NULL", "mem_ctx");
-
-               $self->pidl("ret->pipe->conn->flags |= DCERPC_NDR_REF_ALLOC;");
-
-               $self->pidl("return (PyObject *)ret;");
+               $self->pidl("return py_dcerpc_interface_init_helper(type, args, kwargs, &ndr_table_$interface->{NAME});");
                $self->deindent;
                $self->pidl("}");
-               
+       
                $self->pidl("");
 
                my $signature = 
@@ -783,7 +694,7 @@ sub Interface($$$)
                        $docstring = $signature;
                }
 
-               $self->pidl("PyTypeObject $interface->{NAME}_InterfaceType = {");
+               $self->pidl("static PyTypeObject $interface->{NAME}_InterfaceType = {");
                $self->indent;
                $self->pidl("PyObject_HEAD_INIT(NULL) 0,");
                $self->pidl(".tp_name = \"$basename.$interface->{NAME}\",");
@@ -802,7 +713,6 @@ sub Interface($$$)
        }
 
        $self->pidl_hdr("\n");
-       $self->pidl_hdr("#endif /* _HEADER_NDR_$interface->{NAME} */\n");
 }
 
 sub register_module_method($$$$$)
@@ -819,6 +729,8 @@ sub register_module_typeobject($$$)
        $self->register_module_object($name, "(PyObject *)$py_name");
 
        $self->check_ready_type($py_name);
+
+       $self->register_patch_type_call($name, $py_name);
 }
 
 sub check_ready_type($$)
@@ -827,6 +739,44 @@ sub check_ready_type($$)
        push (@{$self->{ready_types}}, $py_name) unless (grep(/^$py_name$/,@{$self->{ready_types}}));
 }
 
+sub register_module_import($$)
+{
+       my ($self, $basename) = @_;
+
+       push (@{$self->{module_imports}}, $basename) unless (grep(/^$basename$/,@{$self->{module_imports}}));
+}
+
+sub use_type_variable($$)
+{
+       my ($self, $orig_ctype) = @_;
+       # FIXME: Have a global lookup table for types that look different on the 
+       # wire than they are named in C?
+       if ($orig_ctype->{NAME} eq "dom_sid2") {
+               $orig_ctype->{NAME} = "dom_sid";
+       }
+       my $ctype = resolveType($orig_ctype);
+       unless (defined($ctype->{BASEFILE})) {
+               return undef;
+       }
+       # If this is an external type, make sure we do the right imports.
+       if (($ctype->{BASEFILE} ne $self->{BASENAME})) {
+               $self->register_module_import($ctype->{BASEFILE});
+               unless (defined($self->{type_imports}->{$ctype->{NAME}})) {
+                       $self->{type_imports}->{$ctype->{NAME}} = $ctype->{BASEFILE};
+               }
+               return "$ctype->{NAME}_Type";
+       }
+       return "&$ctype->{NAME}_Type";
+}
+
+sub register_patch_type_call($$$)
+{
+       my ($self, $typename, $cvar) = @_;
+
+       push(@{$self->{patch_type_calls}}, [$typename, $cvar]);
+
+}
+
 sub register_module_readycode($$)
 {
        my ($self, $code) = @_;
@@ -844,36 +794,44 @@ sub register_module_object($$$)
 sub assign($$$)
 {
        my ($self, $dest, $src) = @_;
-       if ($dest =~ /^\&/) {
+       if ($dest =~ /^\&/ and $src eq "NULL") {
+               $self->pidl("memset($dest, 0, sizeof(" . get_value_of($dest) . "));");
+       } elsif ($dest =~ /^\&/) {
                $self->pidl("memcpy($dest, $src, sizeof(" . get_value_of($dest) . "));");
        } else {
                $self->pidl("$dest = $src;");
        }
 }
 
-sub ConvertObjectFromPythonData($$$$$$)
+sub ConvertObjectFromPythonData($$$$$$;$)
 {
-       my ($self, $mem_ctx, $cvar, $ctype, $target, $fail) = @_;
+       my ($self, $mem_ctx, $cvar, $ctype, $target, $fail, $location) = @_;
 
-       die("undef type for $cvar") unless(defined($ctype));
+       fatal($location, "undef type for $cvar") unless(defined($ctype));
 
        $ctype = resolveType($ctype);
 
        my $actual_ctype = $ctype;
-       if ($ctype->{TYPE} eq "TYPEDEF") {
-               $actual_ctype = $ctype->{DATA};
+       if ($actual_ctype->{TYPE} eq "TYPEDEF") {
+               $actual_ctype = $actual_ctype->{DATA};
        }
 
        if ($actual_ctype->{TYPE} eq "ENUM" or $actual_ctype->{TYPE} eq "BITMAP" or 
                $actual_ctype->{TYPE} eq "SCALAR" and (
                expandAlias($actual_ctype->{NAME}) =~ /^(u?int[0-9]*|hyper|NTTIME|time_t|NTTIME_hyper|NTTIME_1sec|dlong|udlong|udlongr)$/)) {
-               $self->pidl("PY_CHECK_TYPE(PyInt, $cvar, $fail);");
+               $self->pidl("PY_CHECK_TYPE(&PyInt_Type, $cvar, $fail);");
                $self->pidl("$target = PyInt_AsLong($cvar);");
                return;
        }
 
        if ($actual_ctype->{TYPE} eq "STRUCT" or $actual_ctype->{TYPE} eq "INTERFACE") {
-               $self->pidl("PY_CHECK_TYPE($ctype->{NAME}, $cvar, $fail);");
+               my $ctype_name = $self->use_type_variable($ctype);
+               unless (defined ($ctype_name)) {
+                       error($location, "Unable to determine origin of type `" . mapTypeName($ctype) . "'");
+                       $self->pidl("PyErr_SetString(PyExc_TypeError, \"Can not convert C Type " . mapTypeName($ctype) . " to Python\");");
+                       return;
+               }
+               $self->pidl("PY_CHECK_TYPE($ctype_name, $cvar, $fail);");
                $self->assign($target, "py_talloc_get_ptr($cvar)");
                return;
        }
@@ -915,7 +873,7 @@ sub ConvertObjectFromPythonData($$$$$$)
                return;
        }
 
-       fatal($ctype, "unknown type $actual_ctype->{TYPE} for ".mapTypeName($ctype) . ": $cvar");
+       fatal($location, "unknown type `$actual_ctype->{TYPE}' for ".mapTypeName($ctype) . ": $cvar");
 
 }
 
@@ -950,12 +908,12 @@ sub ConvertObjectFromPythonLevel($$$$$$$$)
                }
 
                if (is_charset_array($e, $l)) {
-                       $self->pidl("PY_CHECK_TYPE(PyUnicode, $py_var, $fail);");
+                       $self->pidl("PY_CHECK_TYPE(&PyUnicode_Type, $py_var, $fail);");
                        # FIXME: Use Unix charset setting rather than utf-8
                        $self->pidl($var_name . " = PyString_AsString(PyUnicode_AsEncodedString($py_var, \"utf-8\", \"ignore\"));");
                } else {
                        my $counter = "$e->{NAME}_cntr_$l->{LEVEL_INDEX}";
-                       $self->pidl("PY_CHECK_TYPE(PyList, $py_var, $fail);");
+                       $self->pidl("PY_CHECK_TYPE(&PyList_Type, $py_var, $fail);");
                        $self->pidl("{");
                        $self->indent;
                        $self->pidl("int $counter;");
@@ -975,7 +933,7 @@ sub ConvertObjectFromPythonLevel($$$$$$$$)
                if (not Parse::Pidl::Typelist::is_scalar($l->{DATA_TYPE})) {
                        $var_name = get_pointer_to($var_name);
                }
-               $self->ConvertObjectFromPythonData($mem_ctx, $py_var, $l->{DATA_TYPE}, $var_name, $fail);
+               $self->ConvertObjectFromPythonData($mem_ctx, $py_var, $l->{DATA_TYPE}, $var_name, $fail, $e->{ORIGINAL});
        } elsif ($l->{TYPE} eq "SWITCH") {
                $var_name = get_pointer_to($var_name);
                my $switch = ParseExpr($l->{SWITCH_IS}, $env, $e);
@@ -983,7 +941,7 @@ sub ConvertObjectFromPythonLevel($$$$$$$$)
        } elsif ($l->{TYPE} eq "SUBCONTEXT") {
                $self->ConvertObjectFromPythonLevel($env, $mem_ctx, $py_var, $e, GetNextLevel($e, $l), $var_name, $fail);
        } else {
-               die("unknown level type $l->{TYPE}");
+               fatal($e->{ORIGINAL}, "unknown level type $l->{TYPE}");
        }
 }
 
@@ -1023,26 +981,26 @@ sub ConvertScalarToPython($$$)
        }
 
        # Not yet supported
-       if ($ctypename eq "string_array") { return "PyCObject_FromVoidPtr($cvar)"; }
+       if ($ctypename eq "string_array") { return "PyCObject_FromTallocPtr($cvar)"; }
        if ($ctypename eq "ipv4address") { return "PyString_FromString($cvar)"; }
        if ($ctypename eq "pointer") {
-               return "PyCObject_FromVoidPtr($cvar, talloc_free)";
+               return "PyCObject_FromTallocPtr($cvar)";
        }
 
        die("Unknown scalar type $ctypename");
 }
 
-sub ConvertObjectToPythonData($$$$$)
+sub ConvertObjectToPythonData($$$$$;$)
 {
-       my ($self, $mem_ctx, $ctype, $cvar) = @_;
+       my ($self, $mem_ctx, $ctype, $cvar, $location) = @_;
 
        die("undef type for $cvar") unless(defined($ctype));
 
        $ctype = resolveType($ctype);
 
        my $actual_ctype = $ctype;
-       if ($ctype->{TYPE} eq "TYPEDEF") {
-               $actual_ctype = $ctype->{DATA};
+       if ($actual_ctype->{TYPE} eq "TYPEDEF") {
+               $actual_ctype = $actual_ctype->{DATA};
        } 
        
        if ($actual_ctype->{TYPE} eq "ENUM") {
@@ -1054,10 +1012,15 @@ sub ConvertObjectToPythonData($$$$$)
        } elsif ($actual_ctype->{TYPE} eq "UNION") {
                fatal($ctype, "union without discriminant: " . mapTypeName($ctype) . ": $cvar");
        } elsif ($actual_ctype->{TYPE} eq "STRUCT" or $actual_ctype->{TYPE} eq "INTERFACE") {
-               return "py_talloc_import_ex(&$ctype->{NAME}_Type, $mem_ctx, $cvar)";
+               my $ctype_name = $self->use_type_variable($ctype);
+               unless (defined($ctype_name)) {
+                       error($location, "Unable to determine origin of type `" . mapTypeName($ctype) . "'");
+                       return "NULL"; # FIXME!
+               }
+               return "py_talloc_reference_ex($ctype_name, $mem_ctx, $cvar)";
        }
 
-       fatal($ctype, "unknown type $actual_ctype->{TYPE} for ".mapTypeName($ctype) . ": $cvar");
+       fatal($location, "unknown type $actual_ctype->{TYPE} for ".mapTypeName($ctype) . ": $cvar");
 }
 
 sub fail_on_null($$$)
@@ -1137,12 +1100,12 @@ sub ConvertObjectToPythonLevel($$$$$$)
                if (not Parse::Pidl::Typelist::is_scalar($l->{DATA_TYPE})) {
                        $var_name = get_pointer_to($var_name);
                }
-               my $conv = $self->ConvertObjectToPythonData($mem_ctx, $l->{DATA_TYPE}, $var_name);
+               my $conv = $self->ConvertObjectToPythonData($mem_ctx, $l->{DATA_TYPE}, $var_name, $e->{ORIGINAL});
                $self->pidl("$py_var = $conv;");
        } elsif ($l->{TYPE} eq "SUBCONTEXT") {
                $self->ConvertObjectToPythonLevel($mem_ctx, $env, $e, GetNextLevel($e, $l), $var_name, $py_var, $fail);
        } else {
-               die("Unknown level type $l->{TYPE} $var_name");
+               fatal($e->{ORIGINAL}, "Unknown level type $l->{TYPE} $var_name");
        }
 }
 
@@ -1156,23 +1119,18 @@ sub ConvertObjectToPython($$$$$$)
 sub Parse($$$$$)
 {
     my($self,$basename,$ndr,$ndr_hdr,$hdr) = @_;
-    
-    my $py_hdr = $hdr;
-    $py_hdr =~ s/ndr_([^\/]+)$/py_$1/g;
 
-    $self->pidl_hdr("/* header auto-generated by pidl */\n\n");
-       
-    $self->pidl("
+       $self->{BASENAME} = $basename;
+
+    $self->pidl_hdr("
 /* Python wrapper functions auto-generated by pidl */
-#include \"includes.h\"
 #include <Python.h>
+#include \"includes.h\"
 #include \"librpc/rpc/dcerpc.h\"
 #include \"lib/talloc/pytalloc.h\"
 #include \"librpc/rpc/pyrpc.h\"
-#include \"lib/events/events.h\"
 #include \"$hdr\"
 #include \"$ndr_hdr\"
-#include \"$py_hdr\"
 
 ");
 
@@ -1187,7 +1145,7 @@ sub Parse($$$$$)
                my ($fn_name, $pyfn_name, $flags, $doc) = @$_;
                $self->pidl("{ \"$fn_name\", (PyCFunction)$pyfn_name, $flags, $doc },");
        }
-       
+
        $self->pidl("{ NULL, NULL, 0, NULL }");
        $self->deindent;
        $self->pidl("};");
@@ -1198,8 +1156,28 @@ sub Parse($$$$$)
        $self->pidl("{");
        $self->indent;
        $self->pidl("PyObject *m;");
+       foreach (@{$self->{module_imports}}) {
+               $self->pidl("PyObject *dep_$_;");
+       }
        $self->pidl("");
 
+       foreach (@{$self->{module_imports}}) {
+               $self->pidl("dep_$_ = PyImport_ImportModule(\"samba.dcerpc.$_\");");
+               $self->pidl("if (dep_$_ == NULL)");
+               $self->pidl("\treturn;");
+               $self->pidl("");
+       }
+
+       foreach (keys %{$self->{type_imports}}) {
+               my $basefile = $self->{type_imports}->{$_};
+               $self->pidl_hdr("static PyTypeObject *$_\_Type;\n");
+               my $pretty_name = PrettifyTypeName($_, $basefile);
+               $self->pidl("$_\_Type = (PyTypeObject *)PyObject_GetAttrString(dep_$basefile, \"$pretty_name\");");
+               $self->pidl("if ($_\_Type == NULL)");
+               $self->pidl("\treturn;");
+               $self->pidl("");
+       }
+
        foreach (@{$self->{ready_types}}) {
                $self->pidl("if (PyType_Ready($_) < 0)");
                $self->pidl("\treturn;");
@@ -1207,6 +1185,13 @@ sub Parse($$$$$)
 
        $self->pidl($_) foreach (@{$self->{readycode}});
 
+       foreach (@{$self->{patch_type_calls}}) {
+               my ($typename, $cvar) = @$_;
+               $self->pidl("#ifdef PY_".uc($typename)."_PATCH");
+               $self->pidl("PY_".uc($typename)."_PATCH($cvar);");
+               $self->pidl("#endif");
+       }
+
        $self->pidl("");
 
        $self->pidl("m = Py_InitModule3(\"$basename\", $basename\_methods, \"$basename DCE/RPC\");");
@@ -1221,7 +1206,7 @@ sub Parse($$$$$)
                } elsif ($cvar =~ /^".*"$/) {
                        $py_obj = "PyString_FromString($cvar)";
                } else {
-                       $py_obj = $self->ConvertObjectToPythonData("NULL", expandAlias($ctype), $cvar);
+                       $py_obj = $self->ConvertObjectToPythonData("NULL", expandAlias($ctype), $cvar, undef);
                }
 
                $self->pidl("PyModule_AddObject(m, \"$name\", $py_obj);");
@@ -1233,10 +1218,14 @@ sub Parse($$$$$)
                $self->pidl("PyModule_AddObject(m, \"$object_name\", $c_name);");
        }
 
+       $self->pidl("#ifdef PY_MOD_".uc($basename)."_PATCH");
+       $self->pidl("PY_MOD_".uc($basename)."_PATCH(m);");
+       $self->pidl("#endif");
+
        $self->pidl("");
        $self->deindent;
        $self->pidl("}");
-    return ($self->{res_hdr}, $self->{res});
+    return ($self->{res_hdr} . $self->{res});
 }
 
 1;