rtp_player_dialog: Route audio for a stream to left/right speaker in RTP player

Column 'Play' added to player. Double click on a stream in the column changes
audio routing for the stream.
When soundcard supports only one channel, there are Mute/Play option. When
soundcard supports two or more channels, there are Mute/L/L+R/R options.
Muted channel is drawn with dotted line.

Change-Id: If120c902195da46f98a1663c589f20c6a1da0ba7
Reviewed-on: https://code.wireshark.org/review/35687
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-smb2: add support for SMB2_FILE_NORMALIZED_NAME_INFO

Change-Id: I58d9db510181c5872be14e9feb4f35c2e6e41a39
Reviewed-on: https://code.wireshark.org/review/35595
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

packet-dcerpc-netlogon: relax the data model for netlogon_auth_key

This is a change into the correct direction and allows decryption
even if DCERPC security context multiplexing is not used.

The final design is added as comment, which would make it possible
to do decryption in all cases allowed by the protocol.

Change-Id: Ided40e0028967f2a047bf2722e627800ca77054d
Reviewed-on: https://code.wireshark.org/review/35680
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Netlink: stop hiding packet_netlink_data pointer

The underlying netlink dissector sets up a data structure to help maintain
information about this netlink packet. It gets passed through the familiy
specific netlink dissectors private data structures to reappear when
support funtions of the underlying netlink dissector are needed. In the
mean time a copy of data (the value 'encoding' to be precise) in this
structure is also maintained in these familiy specific netlink dissectors,
adding to the confusion.
This change is to make the underlying netlink dissector data structure
a normal part of the function interfaces, so that it is present without
being dependant on another private data structure.
This change is a first step towards removing the unnessesary copy of the
encoding value.

Change-Id: I69e78a2b15e58e149e82e89c19e519ef041ee6b1
Reviewed-on: https://code.wireshark.org/review/35688
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

NSIS: Make the licensing page match reality.

The NSIS licensing page is centered around making the user agree to
a EULA. We don't have one of those. Replace the "you must accept" and
"I agree" text with something more neutral.

We could alternatively omit with the licensing page altogether, but
the GPL is an important aspect of the project and deserves some sort
of mention.

Bug: 1115
Change-Id: I5fd5beac2188b61a90c2842de7d7547aa815ff4f
Reviewed-on: https://code.wireshark.org/review/35624
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Docs: Ensure that the API reference has the proper permissions.

Set our file permissions before building the wsar_html_zip target.

Change-Id: I660bf87891a0c8bbebfd497984617bd1d294bf10
Reviewed-on: https://code.wireshark.org/review/35685
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Docbook: Fix some file permissions.

Make the release notes and some PNGs non-executable.

Change-Id: Iecd52e782258f6d7a485138f8f965b7dce52a0dc
Reviewed-on: https://code.wireshark.org/review/35689
Reviewed-by: Gerald Combs <gerald@wireshark.org>

NSIS: Build Unicode installers / uninstallers.

Recent versions of NSIS have deprecated ANSI installers, so enable
Unicode.

Change-Id: I263568f83b7f96871e056ba590db300b23dbdc80
Reviewed-on: https://code.wireshark.org/review/35681
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>

AUTHORS: remove newlines.

The text is used in a Qt widget that handles the newlines itself.
The change makes the text appear with a better look in the about
dialog.

Change-Id: I1dc9fdd1f401384f4ce2d6c2c0764adaa810a654
Reviewed-on: https://code.wireshark.org/review/35662
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Dario Lombardo <lomato@gmail.com>

dcerpc-netlogon: fix compilation with older gcrypt versions.

GCRY_CIPHER_MODE_CFB8 has been introduced in gcrypt 1.8.0:
https://abi-laboratory.pro/?view=changelog&l=libgcrypt&v=1.8.0

Add conditional compilation code for older versions.

Change-Id: I756cc118fce261a6e1a580f4a6a244c8ff0b381f
Reviewed-on: https://code.wireshark.org/review/35678
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Dario Lombardo <lomato@gmail.com>

BGP: update Well-known Communities

Update the well-known communities as defined by
https://www.iana.org/assignments/bgp-well-known-communities/bgp-well-known-communities.xhtml

Communities for expired drafts has been ignored.

Change-Id: I3dedea2bdaad8feda3c7f1d9886092d4c02d6f95
Reviewed-on: https://code.wireshark.org/review/35602
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

TFTP Header End Fix

Change-Id: I70d66bb49384f2eac865a81ffc23b76362c37191
Reviewed-on: https://code.wireshark.org/review/35578
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

NL80211: Remove global variable m_pinfo from dissector

The Netlink 80211 dissector has a global variable to pass the pinfo pointer
to dissection routines that need it. Replace this by properly passing it to
the functions via a new private data structure, akin other netlink dissectors.

Change-Id: Ie08e370b65f7068c01cc93100657e3b8baa5fd63
Reviewed-on: https://code.wireshark.org/review/35657
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

case-sensitive: Fix casing for PCAP and WinSparkle

CMake is unable to find PCAP and WinSparkle under Windows
when using case sensitive folders.

Change-Id: I30ba4073afc6089b08cef3c010b09c257362929b
Reviewed-on: https://code.wireshark.org/review/35505
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

debian: remove double spaces.

Change-Id: Ifee8b32bbde5947944c6f3a30b5245d173beea09
Reviewed-on: https://code.wireshark.org/review/35661
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Qt: Don't plot zero values in I/O scatter plots

We don't currently distinguish between missing and zero values in I/O
graphs. This can be problematic in scatter plots since the plot points
tend to show up as chartjunk which overwhelms the X axis. In plain,
non-calculated plots assume that zero values mean "missing" and omit
those points.

Describe this in the User's Guide, but comment the text out for now
pending a full update to the I/O Graph section.

Switch to title case in our default graphs. Make the TCP Errors graph
red by default.

Change-Id: I92dcbf05f58ae0b7b7734fa8dfc342424bbea114
Reviewed-on: https://code.wireshark.org/review/35645
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-smb2: handle SMB2_CHANNEL_RDMA_V1_INVALIDATE for read

Change-Id: I96045fb2b07d8bae26360558f34dd6de3442ecd0
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35594
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-smb-direct: move Flags into data_tree.

Change-Id: I919994c084d4f5702b0a6d504c8cd5a8b716498b
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35596
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-dcerpc-netlogon: implement NETLOGON_FLAG_AES decryption

Change-Id: I2ff05f528fe8c3ab6f5407c0289064b62f3f0202
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35593
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-dcerpc-netlogon: remove STRONGKEY related processing from get_seal_key()

This won't be needed for NETLOGON_FLAG_AES.

Change-Id: I668bca15ed13e5a2767fa3e39c5cad0d510a8f5d
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35592
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-dcerpc-netlogon: split out prepare_decryption_cipher[_strong]()

Change-Id: Ie63c2d0311be058c5694245d8576ea75d7e6bc14
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35591
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-dcerpc-netlogon: split out uncrypt_sequence_strong()

Change-Id: Ie58377b319632c74ad61c2df42e690466b5c5608
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35590
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-dcerpc-netlogon: use the correct NETLOGON_FLAG_AES flag

See [MS-NRPC] 3.1.4.2 Netlogon Negotiable Options, it's
flag W: Supports Advanced Encryption Standard (AES) encryption (128 bit in
8-bit CFB mode) and SHA2 hashing ...

Change-Id: I4b677e1ca1c3b3b9bc47ccc412380cc18659fd5d
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35589
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-dcerpc-netlogon: fix the build with DEBUG_NETLOGON

Change-Id: Iab70f2847343f934864cf205569fe64cf9e98d9b
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-on: https://code.wireshark.org/review/35588
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

UDP: Add a filter for payload.

A filter for payload makes it easier to exoprt it.

Change-Id: I0732c60c7fac37283fcbe6508d5e27bcd3c603fd
Reviewed-on: https://code.wireshark.org/review/35519
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

rtp_player: Player is able to set start of audio play by double click

Patch adds ability to set start of audio play by double clicking on waveform.
Patch fixes unreported issue with placing waveform at incorrect place when switched relative/absolute time mode (check/uncheck Time of Day).

Change-Id: Ib8ce24aea870e2443e033afbb6d6e9fbcf222431
Reviewed-on: https://code.wireshark.org/review/35621
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

rtp_analysis_dialog: Improved codec recognition during saving of audio to .au

I found that when codec is negotiated to nonstandard payload id, it was
reported as unsupported even was supported. Patch fixes it.

Change-Id: I4eb14fc22f83eb42300fc67baee8456dff65d191
Reviewed-on: https://code.wireshark.org/review/35575
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

NAS 5GS: add missing R15 bits in 5GS network feature support IE

Bug: 16310
Change-Id: I52a3e8bbe6ae89c227cd0eee58bb46ba37eceeb6
Reviewed-on: https://code.wireshark.org/review/35676
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

voip_calls_dialog/voip_calls: Fix for duplicated entries after retap

Issue seen from 2.6:
1) Open pcap with any VoIP call
2) Open Telephony->VoIP calls
3) Select one or more calls
4) Press Flow Sequence - sequence is shown
5) Close Flow Sequence
6) Press Play Streams - Play dialog is shown
7) Close Play dialog
8) Press Flow Sequence - sequence is shown, but all entries are duplicated

If you repeat 6-7 multiple times, all entries are shown multiple times in 8

Patch adds missing clear of graph_analysis before retaping the stream.
Tested on master, but should be backported to as many stable branches as possible.

Change-Id: I9793f6e874defde2f377732d78689e957df71b33
Reviewed-on: https://code.wireshark.org/review/35672
Petri-Dish: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Qt: don't use monospace fonts for licence dialog.

Authors and licence dialogs were using monospace fonts to resemble
GTK interface. Authors is not monospace anymore. Not using monospace
for license dialog makes the text look more similar to other dialogs
and more readable.

Change-Id: I5a62f0993d579af5b1db7dea351d9a10175a069d
Reviewed-on: https://code.wireshark.org/review/35663
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>

wsutil: Replace disallowed filename characters to '-'

Revert the removal of replacing disallowed filename characters in
create_tempfile() to allow this characters in extcap interface names.

This is a regression from g2925fb08.

Change-Id: I833d1d19080c9c688dcaf076a840f55ef31e457d
Reviewed-on: https://code.wireshark.org/review/35669
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

NSIS: Don't package .pdb files.

We run `windeployqt ... --pdbs` at build time, which means that we need
to be careful not to include them in the NSIS package. Switch from using
wildcards ("File ...\*") to using separate "File" commands for each file.

Simplify the PDB Zip package command while we're here.

Bug: 16307
Change-Id: Ibd9bcbdfdc216f1f6a067baf711bbc184845143f
Reviewed-on: https://code.wireshark.org/review/35670
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>

USB MSC: Dissect subclass and protocol codes

Change-Id: I7a818a11352e437a9492f896557c3348abe33c95
Reviewed-on: https://code.wireshark.org/review/35668
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Get rid of %debug, so protobuf_lang.y can be processed by Berkeley YACC.

If somebody wants to debug the parser, they can add it if necessary in
their version.

Bug: 16306
Change-Id: I00e5924058d9401176e3fab40833932dc5757e6a
Reviewed-on: https://code.wireshark.org/review/35665
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

USB Audio: Fix Feature Unit Descriptor dissection

Properly calculate the number of logical channels in the cluster.
Report expert info if number of channels does not turn into integer.

Bug: 16305
Change-Id: I028f3f00912629351641ef9297864ea832629cf0
Reviewed-on: https://code.wireshark.org/review/35656
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

voip_calls_dialog: avoiding of 'remove_tap_listener(): no listener ...' warning

When voip_calls_dialog is opened and then closed, mentioned warning is shown
because voip_calls_remove_all_tap_listeners is called twice in two different
methods. Removing of the call from one of method is not possible therefore
I introduced variable which tracks whether voip_calls_remove_all_tap_listeners
was already called or not.

Change-Id: Ic3c206cb7baf6612958d383880af296af019ffd8
Reviewed-on: https://code.wireshark.org/review/35660
Petri-Dish: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jim Young <jim.young.ws@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

IPv4: Fix incorrect expert info for IGMP TTL

IGMP uses TTL = 1 for the network control block. The code assumes
a certain registered multicast destination address always carries
traffic for that protocol, which isn't true. For example mDNS
usually uses a TTL of 255 but IGMP Membership reports use a TTL
of 1 for the same destination address.

The end result is that IGMP traffic to mDNS multicast destination
shows a confusing and incorrect "TTL != 255 for the Local Network
Control Block" expert info.

Rename the "ttl" variable for clarity.

Change-Id: I693306cd6531aa250a6f5884a6731a2ea254bf2a
Reviewed-on: https://code.wireshark.org/review/35639
Reviewed-by: João Valverde <j@v6e.pt>
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

[Automatic update for 2020-01-05]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I871629b91d38be26bfe448bf90dfbb47a97acdfa
Reviewed-on: https://code.wireshark.org/review/35652
Reviewed-by: Gerald Combs <gerald@wireshark.org>

SIP: authorization validation segfault on missing fields

Fix for segfaults caused by missing username and or realm fields when validating SIP authorization.

Change-Id: Ia418f2a7f036ef706fcd6e4a766ea43098a6883d
Reviewed-on: https://code.wireshark.org/review/35644
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Try this - it might be clearer.

It doesn't contain the text "please do not report it", so nobody will
think it's a warning not to report the problem, it just says "don't call
it a crash".

Change-Id: I9ce71e6a1cc37446a08e44da64c8411166844f75
Reviewed-on: https://code.wireshark.org/review/35649
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Rewrite the "please submit" message a bit.

Say "as a bug" upfront, and clarify that "please do not report it as
such" doesn't mean "please do not report this at all" (even though we
say "please report this" earlier), it means "please do not report this
as being a crash".

Change-Id: I2656c4c13e90fcf41d00a4b6ab3c2f2998f55fd6
Reviewed-on: https://code.wireshark.org/review/35647
Reviewed-by: Guy Harris <guy@alum.mit.edu>

tools: Make compress-pngs a standard utility.

Switch from using `find` to find PNGs to simply accepting a list of
files as arguments.

Pass long arguments to some compressors.

Change-Id: I37884049026fea714d0dd30b08496744c6272379
Reviewed-on: https://code.wireshark.org/review/35646
Reviewed-by: Gerald Combs <gerald@wireshark.org>

IPv4: Fix indentation (use spaces)

Change-Id: Ie89c3c958567182c1f5fe66cff23522e797a3e78
Reviewed-on: https://code.wireshark.org/review/35640
Reviewed-by: João Valverde <j@v6e.pt>

gtpv2: added IE Monitoring Event Information

Change-Id: Icf02c5715c2eda01fc86d5a71a209983b2f5df68
Reviewed-on: https://code.wireshark.org/review/35603
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

WSUG: Note that you can edit packet ranges.

Note that you can edit the packet ranges shown in the Packet Lengths
dialog.

Change-Id: I23170de175e5b7cf5545240b3e4c8be716ce2c27
Reviewed-on: https://code.wireshark.org/review/35638
Reviewed-by: Gerald Combs <gerald@wireshark.org>

WSDG: More translation updates.

Update the Transifex URL and describe how its resources are organized.

Change-Id: Icc03ff57da73c0a60da0ea1e7ff19d6ecffae3a1
Reviewed-on: https://code.wireshark.org/review/35637
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Qt: Update translations.

We added wireshark_es.ts in gd832145366 / change 35620. Sync up with
Transifex by running `tools/update-tx`.

Change-Id: I3e565cbc227b124e79bc759ab6a6a095fed8ce5d
Reviewed-on: https://code.wireshark.org/review/35635
Reviewed-by: Gerald Combs <gerald@wireshark.org>

WSUG: Add a Packet Lengths dialog section.

Add a section for the Packet Lengths window. Use title case for the
column headers. Fix a button name and other issues elsewhere.

Change-Id: I339d56aa169158e0788acd02a897729205e9f50e
Reviewed-on: https://code.wireshark.org/review/35615
Reviewed-by: Gerald Combs <gerald@wireshark.org>

WSDG: Miscellaneous updates.

Add a note about case sensitive directories on Windows.

Recommend the "winflexbison3" Chocolatey package.

Update our list of Linux distributions.

Change-Id: I4676453941a66de71215d6ce6cf7057623c92fec
Reviewed-on: https://code.wireshark.org/review/35622
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Gerald Combs <gerald@wireshark.org>

packet-iec104: Use pinfo->match_uint instead of port number from configuration

Dissector port number is used to determine the direction.
It will not work with Decode As when port number from the configuration
is used. It is better to use the actual dissector port from pinfo->match_uint.

Change-Id: I156728a66ed0cf0fe536da8d9ae958c8c4e0b361
Reviewed-on: https://code.wireshark.org/review/35632
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Qt: Add Spanish (es) translation assets.

Add an initial "es" Qt translation file and an accompanying flag image.
The image came from

https://en.wikipedia.org/wiki/File:Flag_of_Spain.svg

and is in the public domain.

(We already had a debian/po/es.po.)

Change-Id: I5378ad2cbffb2267389fc8ae6af6d591071e0144
Reviewed-on: https://code.wireshark.org/review/35620
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

GSM RLC/MAC: dissect Mobile Identity in Packet Paging Request

Before this patch, Mobile Identity was displayed as an array:

PACKET_PAGING_REQUEST (34) (downlink)
  1000 10.. = MESSAGE_TYPE (DL): PACKET_PAGING_REQUEST (34)
  .... ..00 = PAGE_MODE: Normal Paging (0)
  0... .... = Exist_PERSISTENCE_LEVEL: 0
  .0.. .... = Exist_NLN: 0
  ..1. .... = Repeated_Page_info Exist: 1
  Repeated_Page_info
    ...1 .... = Repeated_Page_info:  (Union)
    u.Page_req_RR
      .... 1... = Page_request_for_RR_conn:  (Union)
      u.Mobile_Identity
        .... .100  0... .... = Length_of_Mobile_Identity_contents: 8
        .001 0100  1... .... = Mobile_Identity_contents: 41
        .001 0011  0... .... = Mobile_Identity_contents: 38
        .001 0010  0... .... = Mobile_Identity_contents: 36
        .000 0000  0... .... = Mobile_Identity_contents: 0
        .000 0000  0... .... = Mobile_Identity_contents: 0
        .000 0000  0... .... = Mobile_Identity_contents: 0
        .000 0000  0... .... = Mobile_Identity_contents: 0
        .001 0010  0... .... = Mobile_Identity_contents: 36
      .00. .... = CHANNEL_NEEDED: 0
      ...0 .... = Exist_eMLPP_PRIORITY: 0

after this patch:

      u.Mobile_Identity
        .... .100  0... .... = Length_of_Mobile_Identity_contents: 8
        0010 .... = Identity Digit 1: 2
        .... 1... = Odd/even indication: Odd number of identity digits
        .... .001 = Mobile Identity Type: IMSI (1)
        IMSI: 262420000000042
        [Association IMSI: 262420000000042]
            Mobile Country Code (MCC): Germany (262)
            Mobile Network Code (MNC): Vodafone GmbH (42)
      .00. .... = CHANNEL_NEEDED: 0
      ...0 .... = Exist_eMLPP_PRIORITY: 0

Achieved by calling de_mid() on an octet-aligned buffer.

Change-Id: Ia77e388f9ac18e4ecda27eeb3e04ce1bd978a3a5
Reviewed-on: https://code.wireshark.org/review/35625
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>

make-manuf.py: Add "of" to the general terms list.

Add "of" to the list of general terms to remove when shortening.

Change-Id: Idbfea2d502a89d668ba2f170bf3450cfcbb91fe5
Reviewed-on: https://code.wireshark.org/review/35627
Reviewed-by: Gerald Combs <gerald@wireshark.org>

BER: fix ber.error.bits_unknown display

Before the changes done in v3.1.0rc0-431-gc2ac157ac0 and
v3.1.0rc0-458-g37b91eedd6 the expert info was only displayed
if at least 1 unknown bit was set to 1. Restore this behavior.

Bug: 16301
Change-Id: I3bea0992d6727154ef07d40ac18a7b012d3c1da4
Reviewed-on: https://code.wireshark.org/review/35612
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>

BGP: Support for drafts Tunnel Encapsulation and Segment Routing

Add support for BGP Tunnel Encapsulation Attribute
(draft-ietf-idr-tunnel-encaps-15) and Advertising Segment
Routing Policies in BGP (draft-ietf-idr-segment-routing-te-policy-08).

Due to missing pcap file(s) most of the Segment List Sub-TLVs
are still missing.

Bug: 16294
Change-Id: I0d7524934d5c5f2458a3f9a68e1e49c95a030c32
Reviewed-on: https://code.wireshark.org/review/35587
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Happy New Year 2020

Change-Id: Ic569e499d40def9397203510a121ff17a495ba9a
Reviewed-on: https://code.wireshark.org/review/35616
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>

WSUG: Update the Capture Properties dialog section.

Change-Id: Ib7ee22076c63fc1be339d4c1b586b73490a3a950
Reviewed-on: https://code.wireshark.org/review/35541
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>

HTTP: Fix dissection of data following the HTTP Upgrade response

When a HTTP response includes HTTP headers and a subset of data for the
subdissector in the same frame, be sure to skip the HTTP headers for
reassembly of the latter data. Otherwise the HTTP headers will be
misinterpreted as the subprotocol (for example, WebSocket).

Bug: 16274
Change-Id: Ida6f6f2f7d0c463be2d498bfde5e8a9cd11a4b25
Reviewed-on: https://code.wireshark.org/review/35536
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

LPP: upgrade dissector to 37.355 v15.0.0

3GPP decided to transfer the specification from 36.355 to 37.355 now that it
covers NR also. 37.355 v15.0.0 is equivalent to 36.355 v15.5.0.

Change-Id: I63aba21f55861ffd8a5c0adbd307b0453482baaa
Reviewed-on: https://code.wireshark.org/review/35613
Petri-Dish: Pascal Quantin <pascal@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>

Guides: Update some of the MaxMind text.

Update the User's Guide to match MaxMind's upcoming database access
changes:

https://blog.maxmind.com/2019/12/18/significant-changes-to-accessing-and-using-geolite2-databases/

Add a Win64 link to the Developer's Guide.

Change-Id: Iaaaaedeb81616f026c542c6f2d8559a3a0084f95
Reviewed-on: https://code.wireshark.org/review/35610
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>

GSM A RR: Fix wrong description for Access Technologies Request presence field

Reference: 3GPP TS 44.018 version 13.3.2 Release 13, section 10.5.2.16

Change-Id: I813275d5fb3e87485b855770c97e566d6c2288ed
Reviewed-on: https://code.wireshark.org/review/35605
Reviewed-by: Pascal Quantin <pascal@wireshark.org>

SIP: RFC8688 Rejected Status Code

Add support for RFC8688 A Session Initiation Protocol (SIP) Response
Code for Rejected Calls

Change-Id: I8471e62f9a428c731100940301d70af66095606b
Reviewed-on: https://code.wireshark.org/review/35601
Reviewed-by: Pascal Quantin <pascal@wireshark.org>

codecs API: Added description of API usage

Added API description clarifies when bytes/samples are used. New variable names
proposed and all existing codecs are adapted to it. Change is just renaming...

Change-Id: I75dba64a49eb3f4369ec7160cb793dda4b44c810
Reviewed-on: https://code.wireshark.org/review/35576
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>

GSM A RR: Fix typos in PS IR field

Change-Id: I521633fe2533983e403eb694b544c377d4b3ae9f
Reviewed-on: https://code.wireshark.org/review/35597
Reviewed-by: Vadim Yanitskiy <axilirator@gmail.com>
Reviewed-by: Pascal Quantin <pascal@wireshark.org>

make-manuf.py: Fix a shortening error.

Handle cases where we might shorten a name (e.g. "ZAO") down to
nothing.

Change-Id: I5ecb9592d2ecd8225d0ed459ef16885214af5da4
Reviewed-on: https://code.wireshark.org/review/35584
Reviewed-by: Gerald Combs <gerald@wireshark.org>

[Automatic update for 2019-12-29]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: Iedf3b088beab75195cbf442854b1cae4d675db95
Reviewed-on: https://code.wireshark.org/review/35580
Reviewed-by: Gerald Combs <gerald@wireshark.org>

make-manuf.py: Handle more business types and other fixes.

Move our business types and general terms to a list and add more. Only
convert all upper case names to title case. Remove double quotes when
shortening names.

Change-Id: I31e9799986542270350b8c2436929f293de4e36c
Reviewed-on: https://code.wireshark.org/review/35577
Reviewed-by: Gerald Combs <gerald@wireshark.org>

netlink: changes to match Linux kernel v5.4 netlink interface

Changes consist of:
- Addition of new enum values
- Header file references now point to kernel sources
- Dissection of few more fields
- Fixes to some dissections

Change-Id: I4cda045153ab0971b0b09ce59a7363238fe627ee
Reviewed-on: https://code.wireshark.org/review/35571
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>

netlink: update 802.11 related netlink messages Linux kernel v5.4

Taking the Linux kernel v5.4 uapi/linux/nl80211.h file:
- Sort the enums in the generation script according to the header file
  to make incremental maintenance easier.
- Add listing of all additional enums found in the header file.
- Update the generated netlink dissector code for 802.11.

Change-Id: I9d2dc09d58d8f252d4746e662e4133d47a7525c5
Reviewed-on: https://code.wireshark.org/review/35570
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Qt: Use a neutral tone in an error message.

Don't yell at the user.

Change-Id: Ibedb0a1bf7ea13feeaf6fe4f2c78bd7f3d1e65b8
Reviewed-on: https://code.wireshark.org/review/35572
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>

ieee802.11ax: Fix spelling mistakes in HE Capabilities Supported HE-MCS.

Change-Id: Ifcf041eb70bd68564d326b94868a45efab86a71f
Reviewed-on: https://code.wireshark.org/review/35568
Reviewed-by: Richard Sharpe <realrichardsharpe@gmail.com>
Petri-Dish: Richard Sharpe <realrichardsharpe@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Find the line ending using tvb_find_line_end().

tvb_find_line_end(), unlike a tvb_find_guint8() looking for an LF,
returns a length that *doesn't* include the line ending, *regardless* of
whether the line ends with CR-LF or just LF, so the query string we
extract is just the query, without any of the line ending.

Update some comments while we're at it to note that the "next_offset"
pointer argument to tvb_find_line_end() and tvb_find_line_end_unquoted()
can be NULL, in which case the offset *past* the line ending isn't
returned.  (We pass tvb_find_line_end() NULL in the aforementioned call,
because, in that particular case, we don't care about the next line.)

Change-Id: I1c9746e32c61a79f8cb636d577a2e14a07ecab17
Reviewed-on: https://code.wireshark.org/review/35566
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Lemon: Squelch an unused parameter warning.

Fixes

... tools\lemon\lemon.c(1630,14): warning C4100: 'argc': unreferenced formal parameter ...

Change-Id: I5cddbbed025e246ddebe9189edbe6fbeea883a7d
Reviewed-on: https://code.wireshark.org/review/35522
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>

Cleanly fetch the query string.

Use tvb_get_string_enc(), because it guarantees null termination, unlike
tvb_memdup(), and use ENC_ASCII|ENC_NA as the encoding, to convert
non-ASCII characters to Unicode REPLACEMENT CHARACTER (there is *no*
standard for the encoding of WHOIS texts other than "ASCII"; we use
ENC_ASCII|ENC_NA elsewhere).

Bug: 16298
Change-Id: I6b7ff2a1af3997e8426ca07bea1ce68fe9cbc9c6
Reviewed-on: https://code.wireshark.org/review/35564
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

SMB2: display oplock/lease break packets properly

Changed display of SMB2 oplock/lease break packets:
using proper Notification/Acknowledgment/Response naming notation and
explicitly indicate Oplock/Lease type of packets.
According to [MS-SMB2] 2.2.23, 2.2.24 and 2.2.25

Bug: 16296
Change-Id: I04c8b34116aec850b917fd47f6333fb56a1ec934
Reviewed-on: https://code.wireshark.org/review/35560
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>

Qt: Create directories recursively

Bug: 16143
Change-Id: Ibdd888157919315775637eb639158ea2e6cb26f0
Reviewed-on: https://code.wireshark.org/review/35561
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

rtcp: Extend AVB RTCP (IEEE1733) to decode AS Timestamp and Sequence Id

AS Timestamp and Sequence Id are not decoded in AVP RTCP (IEEE17333) packets.

This adds a unsigned 32 bit field for AS Timestamp and a unsigned 64 bit
field for Sequence Id to the rtcp dissector.

Change-Id: I9f47001d60985b90d0f4a67ca1b1188ceba45923
Reviewed-on: https://code.wireshark.org/review/35537
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>

whois: add query string to info column.

Keep track of it in the conversation to reuse the string in the
answer as well.

Bug: 16291
Change-Id: I1be6efe4456867b9e33ba15ca06d039a6fb9fed0
Reviewed-on: https://code.wireshark.org/review/35551
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Michael Mann <mmann78@netscape.net>

USB CDC: Match subordinate interfaces with master

CDC Data interfaces are linked with Communications and CDC Control
interfaces via Union Functional Descriptors. Store subordinate to master
interface connection during descriptor dissection and use that
information to determine if CDC Data is Ethernet or not.

Bug: 14587
Change-Id: I442262186319969303af9ac3a7c17aad19cecab8
Reviewed-on: https://code.wireshark.org/review/35496
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Additional styles for IO Graph

This patch adds the styles Cross, Plus and Circle to IO Graph.

Change-Id: I72ff0134cd34a7e9b88a3e9c6a685526a0bca1db
Reviewed-on: https://code.wireshark.org/review/35555
Petri-Dish: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Jim Young <jim.young.ws@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Qt: Fix the Capture File Properties dropped format.

Fixup the formatting for the "Dropped packets" portion of the Capture
File Properties dialog. Fix a couple of other issues flagged by clang.

Change-Id: Ia1fad4bee37525a1a0cc25849abe34a0495f1ac8
Reviewed-on: https://code.wireshark.org/review/35552
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>

pgsql: add GSS Encode Request message

Bug: 16280
Change-Id: Ia1106858aae6d4221042cf13b3fad3ed14e270af
Reviewed-on: https://code.wireshark.org/review/35534
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Revert "Qt: Fix dangling delete for sequence diagramm"

This reverts commit aa2145982f3aec7320f33d201a17d0fdbea2a6c0.

Each of the three delete calls added to the deconstructor
SequenceDialog::~SequenceDialog() results in Wireshark
crashing when the Flow dialog is closed.

Bug: 16260
Change-Id: Iecbd5dcc16be6eb451b8920b22ca2b9ccef7c7b0
Reviewed-on: https://code.wireshark.org/review/35521
Petri-Dish: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>

[Automatic update for 2019-12-22]

Update manuf, services enterprise numbers, translations, and other items.

Change-Id: I8aede9c3248cea1b3cee5b5e35a8ddbc44271263
Reviewed-on: https://code.wireshark.org/review/35546
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Note the lack of character-encoding indications in the protocol.

Change-Id: Ie0306f9f9c0ef127bd61f702996029acaacbe220
Reviewed-on: https://code.wireshark.org/review/35545
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Show answers a line at a time, after the request frame and time delta.

Long responses are *really* hard to read if you make them one single
string item.  Show it a line at a time, as we do with many other
text-oriented protocols.

Change-Id: Ie2e81dabeba728ed34772d7015c52b0b047904e8
Reviewed-on: https://code.wireshark.org/review/35544
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

UI: Fix compilation with Qt 5.14

Change-Id: I8adae4609ff2857cb12bc803839ebb2c6afbd264
Reviewed-on: https://code.wireshark.org/review/35517
Petri-Dish: Roland Knall <rknall@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Gerald Combs <gerald@wireshark.org>

log3gpp: invert check with use of offset.

n is used to address the buffers, but the check condition
follows its use. Fix the code by inverting the two of them

Bug: 16283
Change-Id: I7cba868979982946f99cfe787a7b5f86d2db1b70
Reviewed-on: https://code.wireshark.org/review/35538
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

802.11: Use the pseudo-header PHY to determine whether it's DMG.

It's the responsibility of code that processes radio metadata (file
readers in libwiretap or dissectors in libwireshark) to set the PHY
correctly, even if it has to infer it from the frequency.  The 802.11
dissector should just check the PHY.

Change-Id: Ie6aa73a062c7538cbe2e994fb6a6a2a1e9ac978d
Reviewed-on: https://code.wireshark.org/review/35533
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Guy Harris <guy@alum.mit.edu>

test: fix extcap_name fixture and skip test.

dpauxmon relies on libnl that is linux specific. Skip the test
for other platforms.
Fix skip message while here.

Change-Id: I744d83d0a56e41e1c32e45ade8ca0d9dd29876e1
Reviewed-on: https://code.wireshark.org/review/35525
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Tested-by: Dario Lombardo <lomato@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

Expand the frequency range for the DMG PHY.

Apparently, at least in some regulatory domains, the DMG PHY now goes
above 66 GHz or may do so in the future; the new/future top appears to
be 71 GHz.

Change-Id: I1ee3f9cff177eed269ccc8318b5c952dbeb526ff
Reviewed-on: https://code.wireshark.org/review/35529
Reviewed-by: Guy Harris <guy@alum.mit.edu>

There's a macro to test for 802.11ad frequencies; use it.

The range doesn't start at 60 GHz, it starts at 57 GHz; this fixes that,
and leaves it open to future fixes.

Change-Id: I51d7188f50479bf542babe0f6677638e8a683314
Reviewed-on: https://code.wireshark.org/review/35524
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Use g_file_open_tmp within create_tempfile

Much better to use a known library than create it ourselves.

Also remove get_tempfile_path as it's not used.

Bug: 15992
Change-Id: I17b9bd879e8bdb540f79db83c6c138f8ee724764
Reviewed-on: https://code.wireshark.org/review/34420
Reviewed-by: Tomasz Moń <desowin@gmail.com>
Petri-Dish: Tomasz Moń <desowin@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@gmail.com>

wcp: skip buffer too long.

Fix overflow WCP buffer error.
Slight change in integer increments while here, to improve
readability.

Bug: 16276
Change-Id: Icadd0d051676e6eeeec1569d7c4b269e461a986a
Reviewed-on: https://code.wireshark.org/review/35461
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

TeamSpeak3 DNS: Change defalt port to 0 as it's not IANA registered.

Change-Id: I493a9b3db7b9621d52b31740267e34f7e14487de
Reviewed-on: https://code.wireshark.org/review/35520
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-vnc.c : Fix parse h264 packet error

According to 'CCC-TS-010_ Virtual Networking Computing (VNC).pdf'
Table 31: VA H.264 Encoding within a Framebuffer Update Message
The h264 encoding format should be:
h264 nbytes (4B)
h264 slice type (4B)
h264 width (4B)
h264 height (4B)
...

Change-Id: Ic3bc7ac6723fed68243ec0359791a0d329662ca4
Reviewed-on: https://code.wireshark.org/review/35518
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

DCERPC: add DRIVER_INFO_8 decoding for DCE/RPC spoolss dissector

Guenther

Change-Id: Iea53cf5eaaa76cb9be961fa39355b866d35e247e
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-on: https://code.wireshark.org/review/35488
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

DCERPC: Fix DRIVER_INFO_7 defines in DCE/RPC spoolss dissector

Guenther

Change-Id: I54fc0668ea1146860beabed6628334ed4f369bf0
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-on: https://code.wireshark.org/review/35487
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

CMake: Create a DocBook stamp file for Visual Studio.

Create user-guide.xml-stamp and developer-guide.xml-stamp when building
under Visual Studio. Fixes

C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(231,5): warning MSB8064: Custom build for item "C:\buildbot\builders\wireshark-master-32\windows-2019-x86\build\cmbuild\CMakeFiles\8721ce5c0a51a8e0d8e35fd55fbe2e6e\user-guide.hhp.rule" succeeded, but specified dependency "c:\buildbot\builders\wireshark-master-32\windows-2019-x86\build\cmbuild\docbook\user-guide.xml-stamp" does not exist. This may cause incremental build to work incorrectly. [C:\buildbot\builders\wireshark-master-32\windows-2019-x86\build\cmbuild\docbook\user_guide_chm.vcxproj]

when building the user_guide_chm target.

Change-Id: Ia224823841b4d3def3436f9f3a48b759694ffb37
Reviewed-on: https://code.wireshark.org/review/35509
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

DCERPC: implement GetPrinterDriverPackagePath in DCE/RPC spoolss dissector

Guenther

Change-Id: I62392e0df5aa2ce8cc7e16d0318d1d1288df2599
Signed-off-by: Guenther Deschner <gd@samba.org>
Reviewed-on: https://code.wireshark.org/review/35486
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>