gd/samba/.git
12 years agor16719: Automatically chase referrals, support LDAP fast bind exended operation
Günther Deschner [Fri, 30 Jun 2006 23:07:17 +0000 (23:07 +0000)]
r16719: Automatically chase referrals, support LDAP fast bind exended operation
and LDAP domain scope control.

Guenther
(This used to be commit 6df2a39110a3ae9d2729907472bad30f48896c86)

12 years agor16717: patch from Bjoern Jacke to fix compiler warnings on AIX
Stefan Metzmacher [Fri, 30 Jun 2006 21:52:16 +0000 (21:52 +0000)]
r16717: patch from Bjoern Jacke to fix compiler warnings on AIX

metze
(This used to be commit a558abb40d9a0bcce568a336ce7e9f4ae5e066db)

12 years agor16713: BUG 3904: fix broken smbwrapper compile
Gerald Carter [Fri, 30 Jun 2006 15:57:35 +0000 (15:57 +0000)]
r16713: BUG 3904: fix broken smbwrapper compile
(This used to be commit 9ae1d016d44492327d180fe5e629f3a81ddfe6e4)

12 years agor16701: Fix segv when adding a printer caused by not initializing the
Gerald Carter [Thu, 29 Jun 2006 22:37:32 +0000 (22:37 +0000)]
r16701: Fix segv when adding a printer caused by not initializing the
realm name in ads_init() in nt_printer_publish().
(This used to be commit a25e75e78db092b3992dfc6f7e2737023d43e2c3)

12 years agor16696: Fix the multiple-outstanding write and trans client
Jeremy Allison [Thu, 29 Jun 2006 21:30:58 +0000 (21:30 +0000)]
r16696: Fix the multiple-outstanding write and trans client
signing bug.
Jeremy.
(This used to be commit 3b7fbe856cea7cbb5bf91844f94f221be0a2c627)

12 years agor16687: Fix bugs #3901, #3902, #3903 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 18:01:25 +0000 (18:01 +0000)]
r16687: Fix bugs #3901, #3902, #3903 reported by jason@ncac.gwu.edu.
Jeremy
(This used to be commit c4896b17faa6802f18cc1cec7fcc6168bde2eef0)

12 years agor16685: Fix bug #3901 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:11:14 +0000 (17:11 +0000)]
r16685: Fix bug #3901 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit d48655d9c0b31d15327655140c021de29873d2c5)

12 years agor16683: Fix bug #3900 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:07:21 +0000 (17:07 +0000)]
r16683: Fix bug #3900 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 8c7e40f2a469df34aff0e63270a78e669d240b59)

12 years agor16681: Fix bug #3899 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:05:18 +0000 (17:05 +0000)]
r16681: Fix bug #3899 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 1cd9a0ef834f8062500d1aea6183e147fc5e42f4)

12 years agor16678: Fix bug #3898 reported by jason@ncac.gwu.edu.
Jeremy Allison [Thu, 29 Jun 2006 17:03:19 +0000 (17:03 +0000)]
r16678: Fix bug #3898 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 5c5ea3152f8dbdfd7717b65e035191ffed3ec548)

12 years agor16676: .o generates other warnings, use the Solaris trick with .po.o also for AIX.
Volker Lendecke [Thu, 29 Jun 2006 16:34:15 +0000 (16:34 +0000)]
r16676: .o generates other warnings, use the Solaris trick with .po.o also for AIX.

Fix a configure.in output line

Volker
(This used to be commit 1a80266d77bb95edaa221c14652b2c6fa9932ab6)

12 years agor16665: Fix a couple of bugs I discovered now I've looked
Jeremy Allison [Thu, 29 Jun 2006 00:48:44 +0000 (00:48 +0000)]
r16665: Fix a couple of bugs I discovered now I've looked
closer at the wins server code. Firstly, it needs
to do the searches on the SELF_NAMES correctly,
secondly it needs to flush the in-memory cache
out before returning the 1b names - else it might
get duplicates returned if many 1b queries are
done in quick succession. Jerry, I hate to say
this but you might want to consider this for 3.0.23....
Jeremy.
(This used to be commit b36b9befbbc4ac318168b7788d3722710ecbf10f)

12 years agor16663: Fix coverity #301, memleak in error path.
Jeremy Allison [Thu, 29 Jun 2006 00:04:47 +0000 (00:04 +0000)]
r16663: Fix coverity #301, memleak in error path.
Jeremy.
(This used to be commit dfdb4ce89155dc1528b455252751616cc2c6708c)

12 years agor16661: Fix from jason@ncac.gwu.edu for bug #3875,
Jeremy Allison [Wed, 28 Jun 2006 22:33:10 +0000 (22:33 +0000)]
r16661: Fix from jason@ncac.gwu.edu for bug #3875,
bad cast warning.
Jeremy.
(This used to be commit d60e6e0abc17361fe180d6723b970552dc377741)

12 years agor16656: Fix #3894 and #3895 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:56:03 +0000 (21:56 +0000)]
r16656: Fix #3894 and #3895 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit ddf35ad69201cf9a0aa45ff25e17eddef60d75ad)

12 years agor16654: Fix bug #3893 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:52:56 +0000 (21:52 +0000)]
r16654: Fix bug #3893 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 787539489897e79d43eb1833db6f5969b130c934)

12 years agor16652: Fix bug #3891 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:42:20 +0000 (21:42 +0000)]
r16652: Fix bug #3891 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 9b0df8d008bc5574526d68628f351eb4dbf98e8a)

12 years agor16650: Fix bug #3890 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:38:43 +0000 (21:38 +0000)]
r16650: Fix bug #3890 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 590b58cb507e5a6e459ff0c975beb9056336f233)

12 years agor16648: Fix bug #3889 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 21:35:46 +0000 (21:35 +0000)]
r16648: Fix bug #3889 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 2eefe9b6f52e64927c0ae23adce111a42d821206)

12 years agor16646: Fix bug #3888 reported by Jason Mader <jason@ncac.gwu.edu>.
Jeremy Allison [Wed, 28 Jun 2006 21:33:52 +0000 (21:33 +0000)]
r16646: Fix bug #3888 reported by Jason Mader <jason@ncac.gwu.edu>.
Jeremy.
(This used to be commit 433d7a1bc91ff479934a256ff84e6866e16d1f85)

12 years agor16644: Fix bug #3887 reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 21:30:21 +0000 (21:30 +0000)]
r16644: Fix bug #3887 reported by jason@ncac.gwu.edu
by converting the lookup_XX functions to correctly
return SID_NAME_TYPE enums.
Jeremy.
(This used to be commit ee2b2d96b60c668e37592c79e86c2fd851e15f69)

12 years agor16642: Fix show-stopper bug #3876. Double-free in wins
Jeremy Allison [Wed, 28 Jun 2006 20:39:07 +0000 (20:39 +0000)]
r16642: Fix show-stopper bug #3876. Double-free in wins
server code. Jerry please merge for 3.0.23.
Jeremy.
(This used to be commit d354b430ff0473764db8ea492a68d10946dadc23)

12 years agor16640: Fix bug #3886 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 18:56:45 +0000 (18:56 +0000)]
r16640: Fix bug #3886 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 76cc25a37e145fb48a8a81df37e790690b5dceac)

12 years agor16638: Fix bug #3885, reported by jason@ncac.gwu.edu. Use
Jeremy Allison [Wed, 28 Jun 2006 18:46:47 +0000 (18:46 +0000)]
r16638: Fix bug #3885, reported by jason@ncac.gwu.edu. Use
the correct enumerated type in the macro.
Jeremy.
(This used to be commit 63ad19f71c6b9474042f4ea9d5859e2849a73da8)

12 years agor16636: Fix bug #3884 reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 18:22:21 +0000 (18:22 +0000)]
r16636: Fix bug #3884 reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit 7580eb947cdeb786be00efa5da727e32b28c99d6)

12 years agor16634: Fix bug #3883 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 18:18:23 +0000 (18:18 +0000)]
r16634: Fix bug #3883 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit d04462f1d8cf009985b9112f093306a64689af64)

12 years agor16632: Fix bug #3882 reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 18:16:33 +0000 (18:16 +0000)]
r16632: Fix bug #3882 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 6b39f53e43572fe29fc037a36328387a0b1bb423)

12 years agor16630: Fix bug #3881, reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 17:58:47 +0000 (17:58 +0000)]
r16630: Fix bug #3881, reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit ec0a47b94c12b64d351ca8e6bdd467578528f3da)

12 years agor16628: Fix bug #3880, reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 17:56:10 +0000 (17:56 +0000)]
r16628: Fix bug #3880, reported by jason@ncac.gwu.edu
by ensuring we return the correct enum for sid
type, not a uint32.
Jeremy.
(This used to be commit 98a5e20ff4ceacda65dcc0ce5498ed4ffde520f8)

12 years agor16626: Fix bug #3878. Reported by jason@ncac.gwu.edu.
Jeremy Allison [Wed, 28 Jun 2006 17:26:48 +0000 (17:26 +0000)]
r16626: Fix bug #3878. Reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 4c3019eb99d0a18a33ef1fa90d01b9c99c0b25c3)

12 years agor16624: Fix bug #3877, reported by jason@ncac.gwu.edu
Jeremy Allison [Wed, 28 Jun 2006 17:11:06 +0000 (17:11 +0000)]
r16624: Fix bug #3877, reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit 1f52b8b40619679242da663f5e5e7836d547f0a2)

12 years agor16616: Klocwork #2025. Stop null deref. I actually don't
Jeremy Allison [Wed, 28 Jun 2006 05:00:09 +0000 (05:00 +0000)]
r16616: Klocwork #2025. Stop null deref. I actually don't
think this can happen in real life but the code is
too complicated to be sure....
Jerry please merge this for 3.0.23.
Jeremy.
(This used to be commit 1e5042d4c0d1a0d0a5cfbcb0d47815e1510ee52a)

12 years agor16614: Klocwork #2012. memleak on error path.
Jeremy Allison [Wed, 28 Jun 2006 04:56:23 +0000 (04:56 +0000)]
r16614: Klocwork #2012. memleak on error path.
Jeremy.
(This used to be commit 58b9adb849854610e7167e8aa02a02bd15b0bf00)

12 years agor16612: Klocwork fix #2011. memleak on error path.
Jeremy Allison [Wed, 28 Jun 2006 04:51:23 +0000 (04:51 +0000)]
r16612: Klocwork fix #2011. memleak on error path.
Jeremy.
(This used to be commit b4e9475d2ac65f72cab0d5c8276da27cf1aeb791)

12 years agor16610: Subtle one from Klocwork #2076. If multiple flags
Jeremy Allison [Wed, 28 Jun 2006 04:43:19 +0000 (04:43 +0000)]
r16610: Subtle one from Klocwork #2076. If multiple flags
are set in a winbindd request it might overwrite existing
state->response.extra_data.data values without freeing.
Jeremy.
(This used to be commit 4e7262c81ad2945048cb8d0789af032a05008988)

12 years agor16608: Klocwork #2035. Null deref (bit of a stretch... :-).
Jeremy Allison [Wed, 28 Jun 2006 04:30:51 +0000 (04:30 +0000)]
r16608: Klocwork #2035. Null deref (bit of a stretch... :-).
Jeremy.
(This used to be commit 7d7a98208b1b514da60486fcbbb7b6d04df4ffac)

12 years agor16606: Klocwork #1990. Malloc the correct size.
Jeremy Allison [Wed, 28 Jun 2006 04:27:43 +0000 (04:27 +0000)]
r16606: Klocwork #1990. Malloc the correct size.
Jeremy.
(This used to be commit d1a1c4e092877a6ea0f98eed2a37a96d42c36323)

12 years agor16603: Klockwork #2028. Fix null deref on error path.
Jeremy Allison [Wed, 28 Jun 2006 02:22:28 +0000 (02:22 +0000)]
r16603: Klockwork #2028. Fix null deref on error path.
Jeremy.
(This used to be commit 067feef34388e93ded8db7fd3b4a6a4b752a3059)

12 years agor16601: Klocwork #2038. Fix memleak on error path.
Jeremy Allison [Wed, 28 Jun 2006 02:12:53 +0000 (02:12 +0000)]
r16601: Klocwork #2038. Fix memleak on error path.
Jeremy.
(This used to be commit 934dddb2fa9fb60a87c0b0be81db97f2b59c7cb0)

12 years agor16599: Make it clear to Klocwork we're not dereferencing. Issue #2026.
Jeremy Allison [Wed, 28 Jun 2006 02:02:26 +0000 (02:02 +0000)]
r16599: Make it clear to Klocwork we're not dereferencing. Issue #2026.
Jeremy.
(This used to be commit 9402bf0d4cc6d04283ed69a6dedac7767df84626)

12 years agor16597: Klocwork #2006. Fix possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 01:59:04 +0000 (01:59 +0000)]
r16597: Klocwork #2006. Fix possible null deref.
Jeremy.
(This used to be commit 9b73385d6b90c7806d8ccfc1f2354ede761fad61)

12 years agor16595: Klocwork #2067. Fix possible memleak on error exit.
Jeremy Allison [Wed, 28 Jun 2006 01:56:41 +0000 (01:56 +0000)]
r16595: Klocwork #2067. Fix possible memleak on error exit.
Jeremy.
(This used to be commit 1d21a3dec9ea061ce900ad1223f7c2a43c064600)

12 years agor16593: Make the invarient explicit to Klocwork. Bug #2023.
Jeremy Allison [Wed, 28 Jun 2006 01:52:01 +0000 (01:52 +0000)]
r16593: Make the invarient explicit to Klocwork. Bug #2023.
Jeremy.
(This used to be commit 720a9172050beb158a25fbb826676ba19cdcef20)

12 years agor16591: Belt and braces approach to shut Klocwork up - bug #2001.
Jeremy Allison [Wed, 28 Jun 2006 01:25:29 +0000 (01:25 +0000)]
r16591: Belt and braces approach to shut Klocwork up - bug #2001.
Jeremy.
(This used to be commit d5c1028498de0346b7a35cc132b8081e04e639cc)

12 years agor16589: Fix Klocwork #1999. Although it should be impossible to
Jeremy Allison [Wed, 28 Jun 2006 01:21:54 +0000 (01:21 +0000)]
r16589: Fix Klocwork #1999. Although it should be impossible to
get duplicate OID's returned in the oids_out list it is
still good programming practice to clear out a malloc'ed
string before re-writing it (especially in a loop).
Jeremy
(This used to be commit ae02c05bfca46eb6a8ba25b124c18a358a759cb5)

12 years agor16587: Fix Klocwork #1987. Memleak on reusing x_dbf.
Jeremy Allison [Wed, 28 Jun 2006 01:11:17 +0000 (01:11 +0000)]
r16587: Fix Klocwork #1987. Memleak on reusing x_dbf.
Jeremy.
(This used to be commit 16b0617cb0f91fbe1ce53dcb601fe5ed9e51bddf)

12 years agor16585: Fix Klocwork #1976. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 01:00:48 +0000 (01:00 +0000)]
r16585: Fix Klocwork #1976. Possible null deref.
Jeremy.
(This used to be commit a912ef0d9724373966e77f9e8928be462de8df4a)

12 years agor16582: Fix Klocwork #1997 and all generic class of problems
Jeremy Allison [Wed, 28 Jun 2006 00:50:14 +0000 (00:50 +0000)]
r16582: Fix Klocwork #1997 and all generic class of problems
where we don't correctly check the return from memdup.
Jeremy.
(This used to be commit ce14daf51c7ee2f9c68c77f7f4674e6f0e35c9ca)

12 years agor16581: Fix Klocwork #2017. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 00:07:53 +0000 (00:07 +0000)]
r16581: Fix Klocwork #2017. Possible null deref.
Jeremy.
(This used to be commit 6967fd4cefa84a7b7b5e14467bfa8152907d55c9)

12 years agor16579: Fix Klocwork #2016. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 00:05:53 +0000 (00:05 +0000)]
r16579: Fix Klocwork #2016. Possible null deref.
Jeremy.
(This used to be commit f6d5bae4a105eee1b1d5b1aaa70a675705345d9e)

12 years agor16576: Fix Klocwork #2015. Possible null deref.
Jeremy Allison [Wed, 28 Jun 2006 00:01:28 +0000 (00:01 +0000)]
r16576: Fix Klocwork #2015. Possible null deref.
Jeremy.
(This used to be commit 9cbfaf62a3c4bb7d2e594e412449506ab0af4063)

12 years agor16570: Corrected the copyright notice. I had requested and received permission
Christopher R. Hertel [Tue, 27 Jun 2006 17:58:55 +0000 (17:58 +0000)]
r16570: Corrected the copyright notice.  I had requested and received permission
from my management at the University to release under my own copyright.
My mistake for entering the wrong info.
(This used to be commit c65ebeb02810fb4039555c55779ec62a4a8de564)

12 years agor16554: Sorry, just had to change this. Don't use int when
Jeremy Allison [Tue, 27 Jun 2006 03:59:34 +0000 (03:59 +0000)]
r16554: Sorry, just had to change this. Don't use int when
you're passing a BOOL parameter, don't use "clever"
code in while statement - make things easier and
clearer to understand when triggering something
with an if.
Jeremy.
(This used to be commit b1fc2d8b99e0402c0e8fe954d9f9563dc4dc2812)

12 years agor16552: Fix bug 3849.
Derrell Lipman [Tue, 27 Jun 2006 03:07:02 +0000 (03:07 +0000)]
r16552: Fix bug 3849.

Added a next_token_no_ltrim() function which does not strip leading separator
characters.  The new function is used only where really necessary, even though
it could reasonably be used in many more places, to avoid superfluous code
changes.

Derrell
(This used to be commit d90061aa933f7d8c81973918657dd72cbc88bab5)

12 years agor16550: Fix bug 3866. Thanks for the report!
Derrell Lipman [Tue, 27 Jun 2006 02:30:58 +0000 (02:30 +0000)]
r16550: Fix bug 3866.  Thanks for the report!

Although I've never met a computer or compiler that produced pointers to
functions which are a different size than pointers to data, I suppose they
probably exist.  Assigning a pointer to a function is technically illegal in C
anyway.

Change casts of the option_value based on the option_name to use of variable
argument lists.

For binary compatibility, I've maintained but deprecated the old behavior of
debug_stderr (which expected to be passed a NULL or non-NULL pointer) and
added a new option debug_to_stderr which properly expects a boolean (int)
parameter.

Derrell
(This used to be commit c1b4c510530ca3118d1eccb9615a8cad732c7373)

12 years agor16548: Fix bug #3867 reported by jason@ncac.gwu.edu.
Jeremy Allison [Tue, 27 Jun 2006 01:03:58 +0000 (01:03 +0000)]
r16548: Fix bug #3867 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 2b8d72f09c6d79d5d41421545b538da573adcd9d)

12 years agor16546: Fix bug #3865 reported by jason@ncac.gwu.edu.
Jeremy Allison [Tue, 27 Jun 2006 00:55:08 +0000 (00:55 +0000)]
r16546: Fix bug #3865 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit be888a3cda637149c3183418c6e721c6fef1b652)

12 years agor16544: Fix bug #3864 reported by jason@ncac.gwu.edu.
Jeremy Allison [Tue, 27 Jun 2006 00:49:14 +0000 (00:49 +0000)]
r16544: Fix bug #3864 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 16e42b446bea171c3ad848aefaa92c7404aade42)

12 years agor16542: Fix #3863, reported by jason@ncac.gwu.edu
Jeremy Allison [Tue, 27 Jun 2006 00:42:24 +0000 (00:42 +0000)]
r16542: Fix #3863, reported by jason@ncac.gwu.edu
Jeremy.
(This used to be commit cde8323fdc4d4ddaa30e8c59bec89dc130fe26a6)

12 years agor16541: Fix #3862 reported by jason@ncac.gwu.edu.
Jeremy Allison [Tue, 27 Jun 2006 00:15:00 +0000 (00:15 +0000)]
r16541: Fix #3862 reported by jason@ncac.gwu.edu.
Jeremy.
(This used to be commit 09e11dcb2304eec9656e76c24921c82f4a870914)

12 years agor16537: Fix for bug #3858, all files in a directory not
Jeremy Allison [Mon, 26 Jun 2006 23:36:03 +0000 (23:36 +0000)]
r16537: Fix for bug #3858, all files in a directory not
being deleted when hide unreadable set to true.

Here's the scoop.

This one is really interesting. The pattern of deleting a directory is to do a
findfirst to get the first part of the list, then for each name returned it
does a open/set delete on close/close -> thus deleting the file. Then it does a
findnext with the last file name THAT IT JUST DELETED ! Now we can handle this
in the findnext in the case where hide unreadable is set to false as we look
back in our cache of names and just seek to the right point. The bug is
actually fixed in the first hunk of this patch - the one that removes the
is_visible_file() check after SearchDir returns false. We don't actually need
it and in this case it's causing the delete to be aborted because it can't find
the name (doh ! it was just deleted). We don't need it as SearchDir is only
ever called from findnext, and findnext should only ever be returning names we
gave it.

The rest of the patch are the debugs I used to find
the problem but they're generically useful.

Phew - that one took a while to track down.....

Jerry, please merge for 3.0.23 final.

Jeremy.
(This used to be commit cd048cb775f0a8525fc19aa463db07c477521f5b)

12 years agor16528: Self-confidence is plummeting. How could one person goof
Gerald Carter [Mon, 26 Jun 2006 20:18:28 +0000 (20:18 +0000)]
r16528: Self-confidence is plummeting.  How could one person goof
the same change 3 times......

Fix pam_winbind compilation again.
(This used to be commit f3d2bbf0d222794bbb39b51a0f19167c6e8add1a)

12 years agor16521: Fix different extended_dn handling for win2k/2k3 (thanks to Frederic
Günther Deschner [Mon, 26 Jun 2006 16:14:40 +0000 (16:14 +0000)]
r16521: Fix different extended_dn handling for win2k/2k3 (thanks to Frederic
Brin at Novell).

Guenther
(This used to be commit f19f781e15da98cfaa94c71fc455fe095dac7b4d)

12 years agor16510: fix from Nicholas Brealey <nick@brealey.org> for building pam_winbind.so
Gerald Carter [Sun, 25 Jun 2006 12:22:12 +0000 (12:22 +0000)]
r16510: fix from Nicholas Brealey <nick@brealey.org> for building pam_winbind.so
(This used to be commit 4490fbdfc27eab02bf0140d3ffb70402858423e1)

12 years agor16490: Fix a memleak and two typos
Volker Lendecke [Sat, 24 Jun 2006 09:41:27 +0000 (09:41 +0000)]
r16490: Fix a memleak and two typos
(This used to be commit 8cf364e602eea408fd9cd6acd12f2b72971361ae)

12 years agor16486: fix RedHat init scripts to rely on OS provided killproc() function
Gerald Carter [Fri, 23 Jun 2006 14:39:40 +0000 (14:39 +0000)]
r16486: fix RedHat init scripts to rely on OS provided killproc() function
(This used to be commit 164cdf69f395236ffef9ecc202543d53b5eda2da)

12 years agor16484: Bugzilla 3805. Only define _ABS if it is not already defined.
James Peach [Fri, 23 Jun 2006 06:19:45 +0000 (06:19 +0000)]
r16484: Bugzilla 3805. Only define _ABS if it is not already defined.
(This used to be commit 09fb20f4fe26a5ec82e2f296bf033ab0864af669)

12 years agor16483: Turn off some useless MIPSPro warnings be default.
James Peach [Fri, 23 Jun 2006 06:00:16 +0000 (06:00 +0000)]
r16483: Turn off some useless MIPSPro warnings be default.
(This used to be commit a22bf28bcab6ef3c4addaf57fdeb2020625ead0e)

12 years agor16482: Fix bugzilla 3801 by forcing MIPSPro warning 1035 to be an error.
James Peach [Fri, 23 Jun 2006 05:28:34 +0000 (05:28 +0000)]
r16482: Fix bugzilla 3801 by forcing MIPSPro warning 1035 to be an error.
(This used to be commit 2131ddd7a13f078be471d327c8d73300facf8def)

12 years agor16480: (Ugly) workaround before the set_dc_type_flags & friends cleanup:
Günther Deschner [Fri, 23 Jun 2006 01:17:33 +0000 (01:17 +0000)]
r16480: (Ugly) workaround before the set_dc_type_flags & friends cleanup:

When trying to login using krb5 with a trusted domain account, we
need to make sure that our and the remote domain are AD.

Guenther
(This used to be commit 5853525f111c0ab6a97b081d5964f778e7c36565)

12 years agor16479: When dcip_to_name failed to get the name of the ip in saf_servername we
Günther Deschner [Thu, 22 Jun 2006 23:56:20 +0000 (23:56 +0000)]
r16479: When dcip_to_name failed to get the name of the ip in saf_servername we
cannot put saf_name in the failed conn cache as it's uninitialized.
Store saf_servername (the ip) in that case.

Volker, please check.

Guenther
(This used to be commit 098a87f492f69caeb523478a7ebcd0e3f636497d)

12 years agor16478: small cleanup to make pam_winbind.so build and iniparser
Gerald Carter [Thu, 22 Jun 2006 22:00:43 +0000 (22:00 +0000)]
r16478: small cleanup to make pam_winbind.so build and iniparser
include directory like other parts of the build files.
(This used to be commit 0fca41efde36d535a274b983e032c1def33f081e)

12 years agor16475: destroy talloc ctx when we weren't able to collect onlinestatus
Günther Deschner [Thu, 22 Jun 2006 20:33:42 +0000 (20:33 +0000)]
r16475: destroy talloc ctx when we weren't able to collect onlinestatus
messages.

Guenther
(This used to be commit d6b52e818109e6eb5a3df1bbc127c333e819141d)

12 years agor16474: There is no point in figuring out lockout policies if we do not allow
Günther Deschner [Thu, 22 Jun 2006 20:31:02 +0000 (20:31 +0000)]
r16474: There is no point in figuring out lockout policies if we do not allow
offline logons at all.

Guenther
(This used to be commit dfbe555c69b3272bcff1d76a699aae2bdb85bdaf)

12 years agor16473: There is no point in calling set_dc_type_and_flags() before each
Günther Deschner [Thu, 22 Jun 2006 20:07:08 +0000 (20:07 +0000)]
r16473: There is no point in calling set_dc_type_and_flags() before each
pam_auth login (when using kerberos).

Guenther
(This used to be commit 520777f7946e55b1437df138e529fdc053362d16)

12 years agor16471: Bug reported by Vitaly Protsko <villy@sft.ru> in 3.0.23rc1.
Gerald Carter [Thu, 22 Jun 2006 19:47:44 +0000 (19:47 +0000)]
r16471: Bug reported by Vitaly Protsko <villy@sft.ru> in 3.0.23rc1.
Add missing automatic add of the Administrators SID in the absence
of winbindd and precense of Domain Admins SID in the user's token.
(This used to be commit ce7846d6f19f63ca99179b75e6f2195cc593795f)

12 years agor16470: remove ntlm_auth_proto.h and passwd_proto.h in 'make clean
Gerald Carter [Thu, 22 Jun 2006 19:42:38 +0000 (19:42 +0000)]
r16470: remove ntlm_auth_proto.h and passwd_proto.h in 'make clean
(This used to be commit 8421d1b080dd65d1459cc66f0bd4e20fed5d0385)

12 years agor16458: Increase debuglevel of cli_rpc_pipe_close().
Günther Deschner [Thu, 22 Jun 2006 08:52:01 +0000 (08:52 +0000)]
r16458: Increase debuglevel of cli_rpc_pipe_close().

Guenther
(This used to be commit 840ac23ec007df445892d851144d6458c4e06a6b)

12 years agor16453: Fix another memleak.
Günther Deschner [Wed, 21 Jun 2006 23:46:07 +0000 (23:46 +0000)]
r16453: Fix another memleak.

Guenther
(This used to be commit 49fb1a3ebc44602302c347195752891bf28c7037)

12 years agor16452: Fix memleak in the CLDAP processing (found by valgrind).
Günther Deschner [Wed, 21 Jun 2006 23:43:33 +0000 (23:43 +0000)]
r16452: Fix memleak in the CLDAP processing (found by valgrind).

Guenther
(This used to be commit 479dec68459df606ff566ac86eb3b4bbbd2ca77a)

12 years agor16435: Add in the uid info that Jerry needs into the
Jeremy Allison [Wed, 21 Jun 2006 02:31:12 +0000 (02:31 +0000)]
r16435: Add in the uid info that Jerry needs into the
share_mode struct. Allows us to know the unix
uid of the opener of the file/directory. Needed
for info level queries on open files.
Jeremy.
(This used to be commit d929323d6f513902381369d77bcd7b714346d713)

12 years agor16433: Fix Coverity #300 (triggered by a Klockwork bugfix
Jeremy Allison [Wed, 21 Jun 2006 00:17:14 +0000 (00:17 +0000)]
r16433: Fix Coverity #300 (triggered by a Klockwork bugfix
I think). If a alloc fails just return NT_STATUS_NO_MEMORY,
don't go to "done" label and deref pointers.
Jeremy.
(This used to be commit 490c7c84674860ecd9daa24341edb427b9fe0aa5)

12 years agor16429: Fix final 4 Klocwork bugs we're going to fix before
Jeremy Allison [Tue, 20 Jun 2006 20:43:05 +0000 (20:43 +0000)]
r16429: Fix final 4 Klocwork bugs we're going to fix before
release - #785, #786, #787, #788.
Jeremy.
(This used to be commit 9017547cccadeecb80f3db58a43838dc656fce2f)

12 years agor16427: Fix bug # 3848. Thanks to Wilco Baan Hofman for testing the release candidate!
Volker Lendecke [Tue, 20 Jun 2006 20:05:39 +0000 (20:05 +0000)]
r16427: Fix bug # 3848. Thanks to Wilco Baan Hofman for testing the release candidate!

Volker
(This used to be commit adf2dcce09ae29a8c1677b25e1cd5f022b804d01)

12 years agor16426: Klocwork #1544, #1545, #1546, #1549, #1550, #1552, #1553, #1554
Jeremy Allison [Tue, 20 Jun 2006 19:21:14 +0000 (19:21 +0000)]
r16426: Klocwork #1544, #1545, #1546, #1549, #1550, #1552, #1553, #1554
Jeremy.
(This used to be commit e71cc6647a2eaba0eac95b6abb40745e45db72a4)

12 years agor16424: Fix possible null deref and a memory leak found by
Jeremy Allison [Tue, 20 Jun 2006 19:06:57 +0000 (19:06 +0000)]
r16424: Fix possible null deref and a memory leak found by
examining Klockwork #1519. get_printer_subkeys()
could return zero without initializing it's return
pointer arg. Fixed this. Added free of subkey pointer
return in registry/reg_printing.c (interesting that
neithe Coverity or Klocwork found this one).
Jeremy.
(This used to be commit 4fbeae1a3ac3499e5d9f566655cbafccd9d691cb)

12 years agor16422: winbindd_demote_client isn't used and generates
Jeremy Allison [Tue, 20 Jun 2006 18:30:24 +0000 (18:30 +0000)]
r16422: winbindd_demote_client isn't used and generates
a Klocwork issue (#1844). Remove it
Jeremy.
(This used to be commit e83c3e0a65edeb423d964488e219e30d023b13e8)

12 years agor16420: Fix Klocwork #1674. Null deref.
Jeremy Allison [Tue, 20 Jun 2006 18:14:33 +0000 (18:14 +0000)]
r16420: Fix Klocwork #1674. Null deref.
Jeremy.
(This used to be commit f5dddf339ee3a867e21f34a81bd0b33195b7397d)

12 years agor16415: Also delete object files from iniparser.
Günther Deschner [Tue, 20 Jun 2006 12:20:11 +0000 (12:20 +0000)]
r16415: Also delete object files from iniparser.

Guenther
(This used to be commit 4e1816855a8f86d1228c44b39126fbfb3cb893c0)

12 years agor16411: Fix compilation of vfs_afsacl, thanks to Greszler Szilard for trying
Volker Lendecke [Tue, 20 Jun 2006 11:06:09 +0000 (11:06 +0000)]
r16411: Fix compilation of vfs_afsacl, thanks to Greszler Szilard for trying
(This used to be commit 601643a4608cdccf33277cef8900c4da61712268)

12 years agor16409: Fix Klocwork ID's.
Volker Lendecke [Tue, 20 Jun 2006 09:16:53 +0000 (09:16 +0000)]
r16409: Fix Klocwork ID's.

1177

In reg_perfcount.c: 1200 1202 1203 1204
In regfio.c: 1243 1245 1246 1247 1251

Jerry, the reg_perfcount and regfio.c ones, can you take a look please? This
is really your code, and I'm not sure I did the right thing to return an
error.

smbcacls.c: 1377
srv_eventlog_nt.c: 1415 1416 1417
srv_lsa_nt.c: 1420 1421
srv_netlog_nt.c: 1429
srv_samr_nt: 1458 1459 1460

Volker

Volker
(This used to be commit d6547d12b1c9f9454876665a5bdb010f46b9f5ff)

12 years agor16397: Fix Klocwork #11767 and drasticly simplify the
Jeremy Allison [Tue, 20 Jun 2006 02:38:28 +0000 (02:38 +0000)]
r16397: Fix Klocwork #11767 and drasticly simplify the
logic in smbd/process.c. All interested (Volker,
Jerry, James etc). PLEASE REVIEW THIS CHANGE.
The logic should be identical but *much* easier
to follow and change (and shouldn't confuse Klockwork :-).
Jeremy.
(This used to be commit d357f8b33594472ffa78d0a112accccc2a8b1fe7)

12 years agor16396: Klocwork #1170. Null deref.
Jeremy Allison [Tue, 20 Jun 2006 01:32:50 +0000 (01:32 +0000)]
r16396: Klocwork #1170. Null deref.
Jeremy.
(This used to be commit 220627ab70977a9a26dc0e010f73195c2c87ec96)

12 years agor16393: Klocwork #1164. Null deref.
Jeremy Allison [Tue, 20 Jun 2006 01:27:39 +0000 (01:27 +0000)]
r16393: Klocwork #1164. Null deref.
Jeremy.
(This used to be commit c9a4ce51ed85686a35f350f4681b95d68adebbd6)

12 years agor16392: Klockwork #1168. Protect against null deref.
Jeremy Allison [Tue, 20 Jun 2006 01:25:31 +0000 (01:25 +0000)]
r16392: Klockwork #1168. Protect against null deref.
Jeremy.
(This used to be commit cab256d72a91f59432e28e9623c10384d9ca2b5e)

12 years agor16390: Klocwork #604 - ensure if NULL pointer we assert
Jeremy Allison [Tue, 20 Jun 2006 01:20:38 +0000 (01:20 +0000)]
r16390: Klocwork #604 - ensure if NULL pointer we assert
if len != 0.
Jeremy.
(This used to be commit e99cedfb0cabe3863797c8bd4594ee0826022d2e)

12 years agor16388: Klocwork #320. Null deref.
Jeremy Allison [Tue, 20 Jun 2006 01:12:44 +0000 (01:12 +0000)]
r16388: Klocwork #320. Null deref.
Jeremy.
(This used to be commit ceea8e21006bd6bae9e203a672f82e4d066bba28)

12 years agor16386: Klockwork #lots. Ensure talloc_get_type_abort aborts
Jeremy Allison [Tue, 20 Jun 2006 01:08:57 +0000 (01:08 +0000)]
r16386: Klockwork #lots. Ensure talloc_get_type_abort aborts
if handed a NULL pointer, not returns NULL.
Jeremy.
(This used to be commit d47ec4dc25bffa6f605c0f6fa1d9c046dbc520a7)

12 years agor16383: Klocwork #1086. No null deref.
Jeremy Allison [Tue, 20 Jun 2006 01:03:04 +0000 (01:03 +0000)]
r16383: Klocwork #1086. No null deref.
Jeremy.
(This used to be commit 7b68a2acfc583d1559c02461cab13419185bcd74)

12 years agor16381: Now samu can't be null don't check it on set. Klockwork
Jeremy Allison [Tue, 20 Jun 2006 01:00:39 +0000 (01:00 +0000)]
r16381: Now samu can't be null don't check it on set. Klockwork
related fix.
Jeremy.
(This used to be commit 2e5a88147826113f78ee0d8845c704692942cebf)