From 2b60936d91268688db8344dfee68766b6494c604 Mon Sep 17 00:00:00 2001 From: Tim Beale Date: Thu, 14 Feb 2019 14:37:16 +1300 Subject: [PATCH] selftest: Avoid hard-coding client IP address We implicitly assume the client IP used by selftest is always 127.0.0.11. Add an iface entry for the client to make this a little more explicit. Signed-off-by: Tim Beale Reviewed-by: Andrew Bartlett --- selftest/target/Samba.pm | 1 + selftest/target/Samba4.pm | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/selftest/target/Samba.pm b/selftest/target/Samba.pm index 8e8723c0b88..fdba45504bc 100644 --- a/selftest/target/Samba.pm +++ b/selftest/target/Samba.pm @@ -400,6 +400,7 @@ sub get_interface($) $interfaces{"localnt4dc9"} = 9; # 11-16 used by selftest.pl for client interfaces + $interfaces{"client"} = 11; $interfaces{"addc_no_nss"} = 17; $interfaces{"addc_no_ntlm"} = 18; diff --git a/selftest/target/Samba4.pm b/selftest/target/Samba4.pm index 84b7fa9dc03..de7307d95c8 100755 --- a/selftest/target/Samba4.pm +++ b/selftest/target/Samba4.pm @@ -333,12 +333,13 @@ sub write_ldb_file($$$) sub add_wins_config($$) { my ($self, $privatedir) = @_; + my $client_ip = Samba::get_ipv4_addr("client"); return $self->write_ldb_file("$privatedir/wins_config.ldb", " dn: name=TORTURE_11,CN=PARTNERS objectClass: wreplPartner name: TORTURE_11 -address: 127.0.0.11 +address: $client_ip pullInterval: 0 pushChangeCount: 0 type: 0x3 -- 2.34.1