7 years agos3: fix wrong invocations of talloc_realloc
Björn Jacke [Sat, 8 Sep 2012 23:59:39 +0000 (01:59 +0200)]
s3: fix wrong invocations of talloc_realloc

7 years agoselftest/knownfail: we pass some samba3.smb2.durable-* tests now
Stefan Metzmacher [Thu, 9 Aug 2012 13:27:50 +0000 (15:27 +0200)]
selftest/knownfail: we pass some samba3.smb2.durable-* tests now


Autobuild-User(master): Stefan Metzmacher <>
Autobuild-Date(master): Sat Sep  8 23:18:39 CEST 2012 on sn-devel-104

7 years agos3:vfs_default: add basic support for durable handle request and reconnect
Michael Adam [Fri, 8 Jun 2012 15:54:19 +0000 (17:54 +0200)]
s3:vfs_default: add basic support for durable handle request and reconnect

We only grant durable handles for CIFS/SMB2 only access,
that means "kernel oplocks", "kernel share modes" and "posix locking"
need to be set to "no".

For now we also don't grant durable handles if delete on close
is active on the handle.

Pair-Programmed-With: Stefan Metzmacher <>
Pair-Programmed-With: Volker Lendecke <>

7 years agos3: introduce a new share config option "durable handles" defaulting to "yes"
Michael Adam [Thu, 6 Sep 2012 12:23:26 +0000 (14:23 +0200)]
s3: introduce a new share config option "durable handles" defaulting to "yes"

This is in order to be able to turn durable handles off and on on a per share

Note: This is only used in combination with:

kernel share modes = no
kernel oplocks = no
posix locking = no

Which means CIFS/SMB2 only access.

Signed-off-by: Stefan Metzmacher <>
7 years agos3:smbd: make fd_open() public
Michael Adam [Mon, 11 Jun 2012 11:05:37 +0000 (13:05 +0200)]
s3:smbd: make fd_open() public

7 years agos3:smbd: don't set kernel flock if "kernel share modes = no"
Michael Adam [Sat, 8 Sep 2012 08:52:28 +0000 (10:52 +0200)]
s3:smbd: don't set kernel flock if "kernel share modes = no"

Signed-off-by: Stefan Metzmacher <>
Autobuild-User(master): Stefan Metzmacher <>
Autobuild-Date(master): Sat Sep  8 13:05:05 CEST 2012 on sn-devel-104

7 years agos3: add an option "kernel share modes" to be able to switch off using kernel flocks
Michael Adam [Sat, 8 Sep 2012 08:47:51 +0000 (10:47 +0200)]
s3: add an option "kernel share modes" to be able to switch off using kernel flocks

Signed-off-by: Stefan Metzmacher <>
7 years agoloadparm: remove remnants of removed option "share modes"
Michael Adam [Sat, 8 Sep 2012 08:43:19 +0000 (10:43 +0200)]
loadparm: remove remnants of removed option "share modes"

(This completes commit d0878b3b8179b1cf061e1058bacbe670363b51c6)

Signed-off-by: Stefan Metzmacher <>
7 years agoselftest/Samba3: don't explicitly set 'server max protocol'
Stefan Metzmacher [Fri, 18 May 2012 08:43:18 +0000 (10:43 +0200)]
selftest/Samba3: don't explicitly set 'server max protocol'


Autobuild-User(master): Stefan Metzmacher <>
Autobuild-Date(master): Sat Sep  8 05:15:00 CEST 2012 on sn-devel-104

7 years agodocs-xml: change "server max protocol" to "SMB3"
Stefan Metzmacher [Sun, 3 Jun 2012 21:09:33 +0000 (23:09 +0200)]
docs-xml: change "server max protocol" to "SMB3"


7 years agos3:param: change "server max protocol" to "SMB3"
Stefan Metzmacher [Sun, 3 Jun 2012 21:04:44 +0000 (23:04 +0200)]
s3:param: change "server max protocol" to "SMB3"


7 years agos3:smbd: add basic support for durable handle v2 request and reconnect
Michael Adam [Fri, 15 Jun 2012 11:37:26 +0000 (13:37 +0200)]
s3:smbd: add basic support for durable handle v2 request and reconnect

This does not yet cover persistent handle support which is also
negotiated through these create request blobs.

Pair-Programmed-With: Stefan Metzmacher <>

7 years agos3:smbd: add basic support for durable handle request and reconnect
Michael Adam [Fri, 8 Jun 2012 15:54:19 +0000 (17:54 +0200)]
s3:smbd: add basic support for durable handle request and reconnect

Pair-Programmed-With: Stefan Metzmacher <>
Pair-Programmed-With: Volker Lendecke <>

7 years agos3:smbd: initial durable handle support: special treatment of durable handles in...
Michael Adam [Fri, 3 Aug 2012 14:47:57 +0000 (16:47 +0200)]
s3:smbd: initial durable handle support: special treatment of durable handles in close

Pair-Programmed-With: Stefan Metzmacher <>

7 years agos3:vfs: add durable VFS operations
Michael Adam [Tue, 4 Sep 2012 16:04:11 +0000 (18:04 +0200)]
s3:vfs: add durable VFS operations

This allows a VFS module to implement durable handles in different ways.

Pair-Programmed-With: Stefan Metzmacher <>

7 years agos3:smbd: add disconnected checks to the open code.
Stefan Metzmacher [Sat, 4 Aug 2012 13:30:11 +0000 (15:30 +0200)]
s3:smbd: add disconnected checks to the open code.

(delay_for_batch_oplocks, open_mode_check, and delay_for_exclusive_oplocks)

Pair-Programmed-With: Michael Adam <>

7 years agos3:smbd: also close durable file handles in a tdis
Michael Adam [Fri, 3 Aug 2012 14:38:38 +0000 (16:38 +0200)]
s3:smbd: also close durable file handles in a tdis

Pair-Programmed-With: Stefan Metzmacher <>

7 years agos3:locking: add brl_mark_disconnected() and brl_reconnect_disconnected()
Stefan Metzmacher [Sat, 30 Jun 2012 19:48:43 +0000 (21:48 +0200)]
s3:locking: add brl_mark_disconnected() and brl_reconnect_disconnected()

Pair-Programmed-With: Michael Adam <>

7 years agos3:locking: add mark_share_mode_disconnected()
Stefan Metzmacher [Fri, 3 Aug 2012 14:31:32 +0000 (16:31 +0200)]
s3:locking: add mark_share_mode_disconnected()

Pair-Programmed-With: Michael Adam <>

7 years agos3:smbXsrv_open: add smb2srv_open_recreate() to support durable handles
Stefan Metzmacher [Mon, 18 Jun 2012 10:46:15 +0000 (12:46 +0200)]
s3:smbXsrv_open: add smb2srv_open_recreate() to support durable handles


7 years agos3:smbXsrv.idl: add properties for durable handles to smbXsrv_open_global0
Stefan Metzmacher [Fri, 29 Jun 2012 07:34:56 +0000 (09:34 +0200)]
s3:smbXsrv.idl: add properties for durable handles to smbXsrv_open_global0

Pair-Programmed-With: Michael Adam <>


7 years agos3:quota: don't add the string '"' into the argument list
Björn Jacke [Fri, 7 Sep 2012 22:30:59 +0000 (00:30 +0200)]
s3:quota: don't add the string '"' into the argument list

this is not used to quote or anything else. This is mainly
causing work for the script writer who has to remove the
quote stings again :-)

Autobuild-User(master): Björn Jacke <>
Autobuild-Date(master): Sat Sep  8 03:13:13 CEST 2012 on sn-devel-104

7 years agodoc: improve quotacommand man page docu
Björn Jacke [Fri, 7 Sep 2012 21:41:12 +0000 (23:41 +0200)]
doc: improve quotacommand man page docu

7 years agos3: Fix a panic when shutting down
Volker Lendecke [Fri, 17 Aug 2012 10:22:17 +0000 (12:22 +0200)]
s3: Fix a panic when shutting down

When a client disconnects while we have aio open, there is no close
request that cleans up. We can't send out the replies anymore, so
just drop the aio requests that are pending.

Found using the new python lib writing multiple files simultaneously

TODO: check tdis and logoff

Signed-off-by: Stefan Metzmacher <>
Autobuild-User(master): Stefan Metzmacher <>
Autobuild-Date(master): Sat Sep  8 01:27:34 CEST 2012 on sn-devel-104

7 years agos3:lib: use includes.h with cbuf and srprs
Gregor Beck [Thu, 6 Sep 2012 09:52:58 +0000 (11:52 +0200)]
s3:lib: use includes.h with cbuf and srprs

hopefully fixes build on hpux

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: simplify durable-open.file-position test to only use one I/O and...
Michael Adam [Fri, 7 Sep 2012 15:36:56 +0000 (17:36 +0200)]
s4:torture:smb2: simplify durable-open.file-position test to only use one I/O and one handle

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: change the durable-open.file-position test to use one connection...
Michael Adam [Fri, 7 Sep 2012 15:23:46 +0000 (17:23 +0200)]
s4:torture:smb2: change the durable-open.file-position test to use one connection only

And do a tcp disconnect followed by a session reconnect instead
of immediately using the already opened second connection.

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: fix durable-v2-open.reopen2 to pass against windows
Michael Adam [Fri, 7 Sep 2012 14:12:39 +0000 (16:12 +0200)]
s4:torture:smb2: fix durable-v2-open.reopen2 to pass against windows

The DH2Q response blob is not sent upon successful durable handle v2 reconnect.

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: simplify the durable-v2.reopen2 test (using only one i/o struct)
Michael Adam [Fri, 7 Sep 2012 13:44:42 +0000 (15:44 +0200)]
s4:torture:smb2: simplify the durable-v2.reopen2 test (using only one i/o struct)

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: simplify the durable-v2-open.reopen1 test
Michael Adam [Fri, 7 Sep 2012 13:36:33 +0000 (15:36 +0200)]
s4:torture:smb2: simplify the durable-v2-open.reopen1 test

only use one smb2_create i/o struct and store the create GUID centrally

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: in the durable-v2-reopen1 test, use a minimal request
Michael Adam [Fri, 7 Sep 2012 13:33:54 +0000 (15:33 +0200)]
s4:torture:smb2: in the durable-v2-reopen1 test, use a minimal request

don't copy the old request, but only set the necessary fields

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: fix cut'n'paste error in the durable-v2-open.reopen2 test
Michael Adam [Fri, 7 Sep 2012 12:29:05 +0000 (14:29 +0200)]
s4:torture:smb2: fix cut'n'paste error in the durable-v2-open.reopen2 test

Signed-off-by: Stefan Metzmacher <>
7 years agos4:torture:smb2: fix name of test file in the durable-open.alloc-size test
Michael Adam [Fri, 7 Sep 2012 08:50:48 +0000 (10:50 +0200)]
s4:torture:smb2: fix name of test file in the durable-open.alloc-size test

Signed-off-by: Stefan Metzmacher <>
7 years agowaf: add tests for NFS quota stuff
Björn Jacke [Fri, 7 Sep 2012 18:41:58 +0000 (20:41 +0200)]
waf: add tests for NFS quota stuff

Autobuild-User(master): Björn Jacke <>
Autobuild-Date(master): Fri Sep  7 22:21:55 CEST 2012 on sn-devel-104

7 years agowaf: add test for HAVE_DQB_FSOFTLIMIT
Björn Jacke [Fri, 7 Sep 2012 18:02:03 +0000 (20:02 +0200)]
waf: add test for HAVE_DQB_FSOFTLIMIT

7 years agowaf: make checks for different XFS flavours
Björn Jacke [Fri, 7 Sep 2012 17:49:25 +0000 (19:49 +0200)]
waf: make checks for different XFS flavours

7 years agos3:autoconf: look for irix xfs only when if we didn't find the Linux one before
Björn Jacke [Fri, 7 Sep 2012 17:28:12 +0000 (19:28 +0200)]
s3:autoconf: look for irix xfs only when if we didn't find the Linux one before

7 years agos3:sysquota_nfs: fix build on Tru64 et alii
Björn Jacke [Fri, 7 Sep 2012 15:35:41 +0000 (17:35 +0200)]
s3:sysquota_nfs: fix build on Tru64 et alii

the old Unix world put the struct rquota directly into the getquota_rslt
struct, the new Unix world puts a getquota_rslt_u union in between and they
decided to rename the status struct member.

7 years agorpcserver: fix useless declaration warning
Björn Jacke [Fri, 7 Sep 2012 14:19:52 +0000 (16:19 +0200)]
rpcserver: fix useless declaration warning

issues by irix compiler

7 years agos3:sysquota-test: include ufs/ufs/quota.h only when found
Björn Jacke [Fri, 7 Sep 2012 13:59:16 +0000 (15:59 +0200)]
s3:sysquota-test: include ufs/ufs/quota.h only when found

7 years agobuild: define _BSD_TYPES on IRIX to have types like u_short
Björn Jacke [Fri, 7 Sep 2012 13:56:15 +0000 (15:56 +0200)]
build: define _BSD_TYPES on IRIX to have types like u_short

why the hell do IRIX systems headers like quota.h use types that are available
only with such a define...?

7 years agos3:quota: clean up and consolidate the xfs quota checks and defines
Björn Jacke [Fri, 7 Sep 2012 11:13:49 +0000 (13:13 +0200)]
s3:quota: clean up and consolidate the xfs quota checks and defines

Autobuild-User(master): Björn Jacke <>
Autobuild-Date(master): Fri Sep  7 15:59:46 CEST 2012 on sn-devel-104

7 years agos3:sysquota_xfs: fix logic so that we actually use this module on Linux
Björn Jacke [Thu, 6 Sep 2012 15:00:54 +0000 (17:00 +0200)]
s3:sysquota_xfs: fix logic so that we actually use this module on Linux

7 years agos3:sysquota_xfs: check and include the right fs header file for xfs quotas
Björn Jacke [Thu, 6 Sep 2012 15:26:55 +0000 (17:26 +0200)]
s3:sysquota_xfs: check and include the right fs header file for xfs quotas

7 years agos3-smbd: Remove OSF1 support from old (pre-sysquotas) code
Björn Jacke [Thu, 6 Sep 2012 14:35:20 +0000 (16:35 +0200)]
s3-smbd: Remove OSF1 support from old (pre-sysquotas) code

"recent" Tru64 releases had QUOTACTL_4B support

7 years agowaf: add check for BSD_STYLE_STATVFS
Björn Jacke [Thu, 6 Sep 2012 14:15:04 +0000 (16:15 +0200)]
waf: add check for BSD_STYLE_STATVFS

a leftover from bug #8777

7 years agos3-smbldap: make smbldap public library and maintain its ABI
Alexander Bokovoy [Thu, 6 Sep 2012 14:43:42 +0000 (17:43 +0300)]
s3-smbldap: make smbldap public library and maintain its ABI

Autobuild-User(master): Alexander Bokovoy <>
Autobuild-Date(master): Fri Sep  7 14:14:30 CEST 2012 on sn-devel-104

7 years agos3-smbldap: use smbldap_ prefixed functions
Alexander Bokovoy [Thu, 6 Sep 2012 15:53:00 +0000 (18:53 +0300)]
s3-smbldap: use smbldap_ prefixed functions

7 years agos3-smbldap: use smbldap_ prefix for all functions
Alexander Bokovoy [Thu, 6 Sep 2012 15:52:03 +0000 (18:52 +0300)]
s3-smbldap: use smbldap_ prefix for all functions

7 years agos3-waf: avoid exporting init symbols from statically linked modules
Alexander Bokovoy [Thu, 30 Aug 2012 16:09:14 +0000 (19:09 +0300)]
s3-waf: avoid exporting init symbols from statically linked modules

WAF builds with and without AD DC affect list of statically linked
modules that are added into libpdb. This makes impossible to have
ABI for libpdb that does not depend on configured features.

By making init functions from statically linked modules to have local
scope in shared libraries, we avoid unwarranted ABI changes.

Additionally, pdb_samba_dsdb imports IDMAP subsystem of source4/ as
it is not a shared library. Making its symbols private as well.

Finally, in order to have the filtering of symbols work, libpdb
has to be public library.

7 years agos4-torture: dns torture test depends on AD DC build
Alexander Bokovoy [Thu, 6 Sep 2012 12:29:13 +0000 (15:29 +0300)]
s4-torture: dns torture test depends on AD DC build

7 years agos3-passdb: convert pdb_ipa to use secrets wrappers
Alexander Bokovoy [Wed, 5 Sep 2012 15:50:08 +0000 (18:50 +0300)]
s3-passdb: convert pdb_ipa to use secrets wrappers

7 years agos3-passdb: convert pdb_ldap to use secrets wrappers
Alexander Bokovoy [Wed, 5 Sep 2012 15:49:39 +0000 (18:49 +0300)]
s3-passdb: convert pdb_ldap to use secrets wrappers

7 years agos3-passdb: wrap secrets.tdb accessors used by PDB modules
Alexander Bokovoy [Wed, 5 Sep 2012 12:56:37 +0000 (15:56 +0300)]
s3-passdb: wrap secrets.tdb accessors used by PDB modules

PDB modules store domain sid and guid in secrets.tdb to cooperate
with other parts of smbd. If PDB module is built outside Samba
source code it has to be linked against internal libsecrets.

Wrap required secrets_* calls to avoid direct linking. libpdb
is linked against libsecrets by itself and this is enough.

7 years agowafsamba/samba_abi: allow negative matches in abi_match
Alexander Bokovoy [Thu, 30 Aug 2012 15:46:23 +0000 (18:46 +0300)]
wafsamba/samba_abi: allow negative matches in abi_match

abi_match keyword for samba libraries allows to selectively
apply ABI versions. implied !sym to be used to
say 'all symbols but this one' but the actual demotion
of !sym to the local scope was not implemented.

Now abi_match='!sym' properly moves symbol to a local scope.

7 years filter out symbols not needed for ABI
Alexander Bokovoy [Thu, 23 Aug 2012 15:45:54 +0000 (18:45 +0300)] filter out symbols not needed for ABI

gdb does not allow to print definitions of certain section names
and special symbols used for dynamic loading machinery:


Please note the space before the pattern, it is needed to avoid
hungry matches of valid symbols with these as substrings (foo_init,
for example).

Without this patch gdb on Fedora 18 breaks when attempting to print
function and struct signature.

7 years agowafsamba/samba_abi: fix signature parsing for structures
Alexander Bokovoy [Thu, 23 Aug 2012 15:44:01 +0000 (18:44 +0300)]
wafsamba/samba_abi: fix signature parsing for structures

Signature parsing for structure objects was broken. Existing regexp
was greedingly cutting off additional curly brackets that belonged to
the first and last structure member.

7 years agowaf: Fix bug #8801 - build s3fs manpages.
Andreas Schneider [Thu, 6 Sep 2012 14:10:08 +0000 (16:10 +0200)]
waf: Fix bug #8801 - build s3fs manpages.

Autobuild-User(master): Andreas Schneider <>
Autobuild-Date(master): Fri Sep  7 12:30:08 CEST 2012 on sn-devel-104

7 years agowaf: Rename nmblookup manpage to nmblookup4.
Andreas Schneider [Thu, 6 Sep 2012 13:26:37 +0000 (15:26 +0200)]
waf: Rename nmblookup manpage to nmblookup4.

7 years agodocs: Remove old tdb manpages.
Andreas Schneider [Thu, 6 Sep 2012 14:18:01 +0000 (16:18 +0200)]
docs: Remove old tdb manpages.

They are part of lib/tdb/manpages/ now.

7 years agodocs: Remove old ldb manpages.
Andreas Schneider [Wed, 5 Sep 2012 18:46:05 +0000 (20:46 +0200)]
docs: Remove old ldb manpages.

The ldb manpages can be found in lib/ldb/man/.

7 years agowaf: Create catalog file for manpage generation.
Andreas Schneider [Thu, 6 Sep 2012 10:14:46 +0000 (12:14 +0200)]
waf: Create catalog file for manpage generation.

7 years agowafsamba: Add a CONFIGURE_FILE option.
Andreas Schneider [Thu, 6 Sep 2012 10:14:34 +0000 (12:14 +0200)]
wafsamba: Add a CONFIGURE_FILE option.

7 years agowafsamba: Add support for manpages in SAMBA_MODULE.
Andreas Schneider [Wed, 5 Sep 2012 15:37:19 +0000 (17:37 +0200)]
wafsamba: Add support for manpages in SAMBA_MODULE.

7 years agoselftest/knownfail: samba3.smb2.durable-open.alloc-size fails currently
Stefan Metzmacher [Fri, 7 Sep 2012 06:54:08 +0000 (08:54 +0200)]
selftest/knownfail: samba3.smb2.durable-open.alloc-size fails currently


Autobuild-User(master): Stefan Metzmacher <>
Autobuild-Date(master): Fri Sep  7 10:47:29 CEST 2012 on sn-devel-104

7 years agos4:torture:smb2: add a test for alloc size behaviour under durable reconnect
Michael Adam [Thu, 6 Sep 2012 22:53:38 +0000 (00:53 +0200)]
s4:torture:smb2: add a test for alloc size behaviour under durable reconnect

Pair-Programmed-With: Stefan Metzmacher <>

7 years agoparam: remove unused define FN_LOCAL_PARM_CHAR()
Michael Adam [Thu, 6 Sep 2012 10:43:47 +0000 (12:43 +0200)]
param: remove unused define FN_LOCAL_PARM_CHAR()

Signed-off-by: Stefan Metzmacher <>
7 years agoFree protect_ids in secret_store_domain_guid() as the caller of fetch_secrets() must...
Michele Baldessari [Fri, 7 Sep 2012 00:32:11 +0000 (17:32 -0700)]
Free protect_ids in secret_store_domain_guid() as the caller of fetch_secrets() must free the result in order to not leak memory.

Signed-off-by: Jeremy Allison <>
Autobuild-User(master): Jeremy Allison <>
Autobuild-Date(master): Fri Sep  7 04:11:43 CEST 2012 on sn-devel-104

7 years agoselftest/knownfail: samba3.smb2.durable-v2-open.reopen{1,2} fails currently
Stefan Metzmacher [Thu, 6 Sep 2012 10:18:05 +0000 (12:18 +0200)]
selftest/knownfail: samba3.smb2.durable-v2-open.reopen{1,2} fails currently


Autobuild-User(master): Stefan Metzmacher <>
Autobuild-Date(master): Fri Sep  7 02:12:22 CEST 2012 on sn-devel-104

7 years agos4:torture/smb2: add smb2.durable-v2-open.reopen{1,2} tests
Stefan Metzmacher [Thu, 6 Sep 2012 09:51:12 +0000 (11:51 +0200)]
s4:torture/smb2: add smb2.durable-v2-open.reopen{1,2} tests

They show that only the content of the DH2C request matches and
all other values in the SMB2 Create request are ignored.


7 years agos4:torture/smb2: check that the server should ignore the fname in a DHnC request
Stefan Metzmacher [Thu, 6 Sep 2012 10:38:54 +0000 (12:38 +0200)]
s4:torture/smb2: check that the server should ignore the fname in a DHnC request


7 years agos4:torture/smb2: don't expect a DHnQ response in a DHnC request
Stefan Metzmacher [Thu, 6 Sep 2012 09:49:42 +0000 (11:49 +0200)]
s4:torture/smb2: don't expect a DHnQ response in a DHnC request

This is fixed in Windows 2012 and matches the [MS-SMB2] documentation


7 years agos4 dns: Make debug output less noisy
Kai Blin [Thu, 6 Sep 2012 20:53:32 +0000 (22:53 +0200)]
s4 dns: Make debug output less noisy

Autobuild-User(master): Kai Blin <>
Autobuild-Date(master): Fri Sep  7 00:31:56 CEST 2012 on sn-devel-104

7 years agos4 dns: Check if signing user is allowed to update records
Kai Blin [Thu, 6 Sep 2012 20:40:56 +0000 (22:40 +0200)]
s4 dns: Check if signing user is allowed to update records

This should fix bug #9142

7 years agofileserver:sysquotas: remove wrong cast
Björn Jacke [Thu, 6 Sep 2012 12:17:25 +0000 (14:17 +0200)]
fileserver:sysquotas: remove wrong cast

Autobuild-User(master): Björn Jacke <>
Autobuild-Date(master): Thu Sep  6 17:16:30 CEST 2012 on sn-devel-104

7 years agos3:quota: don't force the block size to 512
Björn Jacke [Thu, 6 Sep 2012 08:23:50 +0000 (10:23 +0200)]
s3:quota: don't force the block size to 512

there is no point in forcing the block size to 512 when curblocks is 1. This
will only lead to false quota reporting. See bug #3272

7 years agos3-smbd: Remove remaining references to removed OS support in old-style quota code
Andrew Bartlett [Mon, 3 Sep 2012 03:16:38 +0000 (13:16 +1000)]
s3-smbd: Remove remaining references to removed OS support in old-style quota code

Signed-off-by: Björn Jacke <>
Autobuild-User(master): Björn Jacke <>
Autobuild-Date(master): Thu Sep  6 10:47:18 CEST 2012 on sn-devel-104

7 years agos3-smbd: Remove IRIX support from old (pre-sysquotas) code
Andrew Bartlett [Mon, 3 Sep 2012 02:20:53 +0000 (12:20 +1000)]
s3-smbd: Remove IRIX support from old (pre-sysquotas) code

This should be essentially dead code, as while it is possible to disable sysquotas, the sysquotas has since 2003 supported the 4A varient used on IRIX.

Andrew Bartlett

Signed-off-by: Björn Jacke <>
7 years agos3-smbd: Remove HPUX support from old (pre-sysquotas) code
Andrew Bartlett [Sun, 2 Sep 2012 16:20:05 +0000 (02:20 +1000)]
s3-smbd: Remove HPUX support from old (pre-sysquotas) code

This should be essentially dead code, as while it is possible to disable sysquotas, the sysquotas has since 2003 supported the 4A varient used on HPUX.

Andrew Bartlett

Signed-off-by: Björn Jacke <>
7 years agos3-smbd: Remove BSD support from old (pre-sysquotas) code
Andrew Bartlett [Sun, 2 Sep 2012 15:51:59 +0000 (01:51 +1000)]
s3-smbd: Remove BSD support from old (pre-sysquotas) code

This is essentially dead code, as while it is possible to disable
sysquotas, the default for BSD is now to use sysquotas with the
addition of 4B support via the recent Darwin patch by James Peach.

NFS support has been in sysquotas for quite some time now.

Andrew Bartlett

Signed-off-by: Björn Jacke <>
7 years agos3-smbd: Remove Linux support from old (pre-sysquotas) code
Andrew Bartlett [Sun, 2 Sep 2012 15:41:27 +0000 (01:41 +1000)]
s3-smbd: Remove Linux support from old (pre-sysquotas) code

This is essentially dead code, as while it is possible to disable sysquotas, the default
for Linux has been to use sysquotas for quite some time now.

Andrew Bartlett

Signed-off-by: Björn Jacke <>
7 years agos3-configure: Only use sysquotas by default
Andrew Bartlett [Sun, 2 Sep 2012 17:08:54 +0000 (03:08 +1000)]
s3-configure: Only use sysquotas by default

We now only use old quota code if --with-quotas=yes and there is no
sysquotas support for this platform.

This also removes --with-sys-quotas as an option, instead being the
first choice if --with-quotas=yes or --with-quotas=auto

sysquotas have been our preferred quota mechanism since 2003.

Andrew Bartlett

Signed-off-by: Björn Jacke <>
7 years agobuild: Remove Unicos support (quota in particular)
Andrew Bartlett [Wed, 13 Jun 2012 02:20:07 +0000 (12:20 +1000)]
build: Remove Unicos support (quota in particular)

Unicos machines are long gone now (Cray now make Linux compute nodes),
so remove the quota support.

Andrew Bartlett

Signed-off-by: Björn Jacke <>
7 years agobuild: Do not compile lib/sysquotas*.c files as part of configure
Andrew Bartlett [Mon, 4 Jun 2012 20:39:28 +0000 (06:39 +1000)]
build: Do not compile lib/sysquotas*.c files as part of configure

Instead, use the tests in tests/sysquotas.c.

It is better that we see any compile failures, and then expand the
tests than 'automatically' disable the support.  Users can always use
--without-quotas if the quotas code does not work on their system.

Andrew Bartlett

Signed-off-by: Björn Jacke <>
7 years agos3: Fix 64-bit warnings in vfs_media_harmony
Volker Lendecke [Wed, 5 Sep 2012 08:15:48 +0000 (10:15 +0200)]
s3: Fix 64-bit warnings in vfs_media_harmony

7 years agosysquota: we need to list nfs4 as a separate fs name for the sys_get_nfs_quota backend
Björn Jacke [Thu, 6 Sep 2012 05:58:00 +0000 (07:58 +0200)]
sysquota: we need to list nfs4 as a separate fs name for the sys_get_nfs_quota backend

at least the Linux kernel up to 3.5.0 lists NFSv4 aѕ nfs4 and not as nfs

7 years agoselftest: Test configure stage of dlz_bind9
Andrew Bartlett [Thu, 6 Sep 2012 05:22:17 +0000 (15:22 +1000)]
selftest: Test configure stage of dlz_bind9

Autobuild-User(master): Andrew Bartlett <>
Autobuild-Date(master): Thu Sep  6 09:07:11 CEST 2012 on sn-devel-104

7 years agoselftest: Add tests for the dlz_bind9 module
Andrew Bartlett [Thu, 6 Sep 2012 04:26:57 +0000 (14:26 +1000)]
selftest: Add tests for the dlz_bind9 module

This will help ensure that we do not break the fundemental loading etc.

From here, it should be easy to extend this to more comprehensive tests.

Andrew Bartlett

7 years Only replicate DNS zones if the source DC had DNS zones
Andrew Bartlett [Thu, 6 Sep 2012 00:37:18 +0000 (10:37 +1000)] Only replicate DNS zones if the source DC had DNS zones

This avoid folks needing to specify --dns-backend=NONE

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <>
Autobuild-Date(master): Thu Sep  6 04:48:55 CEST 2012 on sn-devel-104

7 years agos3-printing: Restrict printing=cups to systems with cups development headers at build...
Andrew Bartlett [Wed, 5 Sep 2012 05:03:31 +0000 (15:03 +1000)]
s3-printing: Restrict printing=cups to systems with cups development headers at build time

This means that instead of failing due to the default commandline values not being quite correct
that we clearly fail at loadparm and testparm time when parsing the printing= line.

Andrew Bartlett

7 years agoFree protect_ids in secret_store_domain_sid() as the caller of fetch_secrets() must...
Michele Baldessari [Wed, 5 Sep 2012 17:56:06 +0000 (10:56 -0700)]
Free protect_ids in secret_store_domain_sid() as the caller of fetch_secrets() must free the result in order to not leak memory.
Signed-off-by: Jeremy Allison <>
Autobuild-User(master): Jeremy Allison <>
Autobuild-Date(master): Wed Sep  5 22:20:45 CEST 2012 on sn-devel-104

7 years agoAdd "backup_intent" bool to files_struct.
Jeremy Allison [Wed, 5 Sep 2012 17:46:51 +0000 (10:46 -0700)]
Add "backup_intent" bool to files_struct.

Not used right now but I need this in the VFS to implement open for
backup/restore later and don't want to break the ABI once 4.0.0

7 years agoRemove an unncessary FTRUNCATE call in the open path. We can rely on O_TRUC.
Jeremy Allison [Wed, 5 Sep 2012 17:46:16 +0000 (10:46 -0700)]
Remove an unncessary FTRUNCATE call in the open path. We can rely on O_TRUC.

Suggested by Volker.

7 years agos4 dns: Allow configuring signed updates
Kai Blin [Tue, 4 Sep 2012 23:27:00 +0000 (01:27 +0200)]
s4 dns: Allow configuring signed updates

Autobuild-User(master): Kai Blin <>
Autobuild-Date(master): Wed Sep  5 20:42:46 CEST 2012 on sn-devel-104

7 years agos4 dns: Make sure to remember incoming tkey name
Kai Blin [Tue, 4 Sep 2012 23:26:16 +0000 (01:26 +0200)]
s4 dns: Make sure to remember incoming tkey name

7 years agos4 dns: Verify incoming TSIG signatures
Kai Blin [Wed, 5 Sep 2012 06:34:49 +0000 (08:34 +0200)]
s4 dns: Verify incoming TSIG signatures

7 years agos4 dns: Handle GSS-TSIG signature creation
Kai Blin [Wed, 5 Sep 2012 06:34:04 +0000 (08:34 +0200)]
s4 dns: Handle GSS-TSIG signature creation

7 years agos4 dns: When we got a TKEY, we need to remember which key to use for signing
Kai Blin [Wed, 5 Sep 2012 06:29:38 +0000 (08:29 +0200)]
s4 dns: When we got a TKEY, we need to remember which key to use for signing

7 years agos4 dns: TKEY record needs to remember incoming algorithm
Kai Blin [Wed, 5 Sep 2012 06:27:28 +0000 (08:27 +0200)]
s4 dns: TKEY record needs to remember incoming algorithm

Samba3 (and older windows versions) use, win7 (and the RFC) use gss-tsig

7 years agos4 dns: Move dns_find_tkey to an extra file
Kai Blin [Wed, 5 Sep 2012 06:24:52 +0000 (08:24 +0200)]
s4 dns: Move dns_find_tkey to an extra file