gd/samba-autobuild/.git
7 years agoAdd systemd service files.
Andreas Schneider [Thu, 27 Oct 2011 15:11:19 +0000 (17:11 +0200)]
Add systemd service files.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Fri Oct 28 11:34:27 CEST 2011 on sn-devel-104

7 years agos4:librpc/dcerpc_smb2: fix smb2_write_callback()
Stefan Metzmacher [Thu, 27 Oct 2011 20:55:17 +0000 (22:55 +0200)]
s4:librpc/dcerpc_smb2: fix smb2_write_callback()

The should use smb2_write_recv() to get the result.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Oct 28 09:55:48 CEST 2011 on sn-devel-104

7 years agos4:librpc/dcerpc_smb: fix smb_write_callback()
Stefan Metzmacher [Thu, 27 Oct 2011 20:55:17 +0000 (22:55 +0200)]
s4:librpc/dcerpc_smb: fix smb_write_callback()

The should use smb_raw_write_recv() to get the result.

metze

7 years agos4:torture:smb2: avoid leaking tree connects up to the main function from the durable...
Michael Adam [Thu, 27 Oct 2011 22:11:08 +0000 (00:11 +0200)]
s4:torture:smb2: avoid leaking tree connects up to the main function from the durable_open test

The tree connects are handed in from the calling wrapper.
Those that are freed and reconnected inside the test function
can not be freed in the wrapper and stick to the torture_context
until this is released in the main function.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Fri Oct 28 02:37:25 CEST 2011 on sn-devel-104

7 years agos4:torture:smb2: fix a nasty double free error.
Michael Adam [Thu, 27 Oct 2011 22:05:44 +0000 (00:05 +0200)]
s4:torture:smb2: fix a nasty double free error.

This error manifested itself in sporadic "talloc_free with references" error.

7 years agos4:torture:smb2: fix a comment
Michael Adam [Thu, 27 Oct 2011 11:06:32 +0000 (13:06 +0200)]
s4:torture:smb2: fix a comment

7 years agos4:torture:smb2: be leass leaky in wrap_simple_2smb2_test()
Michael Adam [Wed, 26 Oct 2011 20:48:29 +0000 (22:48 +0200)]
s4:torture:smb2: be leass leaky in wrap_simple_2smb2_test()

7 years agos3-ctdb: Fix ctdb_read_req
Volker Lendecke [Thu, 27 Oct 2011 13:21:29 +0000 (15:21 +0200)]
s3-ctdb: Fix ctdb_read_req

If a complete request has come in already before we consumed it, the
ctdb_packet_fd_read_sync will block indefinitely. So always try packet_handler
first and only if that fails due to insufficient data, read from the socket.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Oct 27 22:12:05 CEST 2011 on sn-devel-104

7 years agos3-ctdb: Add debug to ctdb_processes_exist
Volker Lendecke [Wed, 26 Oct 2011 15:51:09 +0000 (17:51 +0200)]
s3-ctdb: Add debug to ctdb_processes_exist

7 years agos3: Use serverids_exist in parse_share_modes
Volker Lendecke [Wed, 26 Oct 2011 11:43:07 +0000 (13:43 +0200)]
s3: Use serverids_exist in parse_share_modes

This is the main reason for the preceding commits. We need to reduce the number
of round-trips to ctdb when checking the locking record entries for existence.
Using the plural version of process_exists gets the number of round-trips to
ctdb for process_exists down to 1.

7 years agos3: Add serverids_exist
Volker Lendecke [Wed, 26 Oct 2011 11:36:56 +0000 (13:36 +0200)]
s3: Add serverids_exist

7 years agos3: Add processes_exist
Volker Lendecke [Wed, 26 Oct 2011 10:18:21 +0000 (12:18 +0200)]
s3: Add processes_exist

7 years agos3-ctdb: Make ctdbd_process_exists use ctdbd_processes_exist
Volker Lendecke [Wed, 26 Oct 2011 09:36:21 +0000 (11:36 +0200)]
s3-ctdb: Make ctdbd_process_exists use ctdbd_processes_exist

Not strictly necessary, but more code exercise is good

7 years agos3-ctdb: Add ctdb_processes_exist
Volker Lendecke [Sun, 23 Oct 2011 19:38:54 +0000 (21:38 +0200)]
s3-ctdb: Add ctdb_processes_exist

This sends out a number of process_exists controls in parallel and collects the
replies as they come in.

7 years agos3-ctdb: Allow ctdb_read_req to read any reqid
Volker Lendecke [Wed, 26 Oct 2011 08:58:25 +0000 (10:58 +0200)]
s3-ctdb: Allow ctdb_read_req to read any reqid

7 years agos3-ctdb: Don't hand out 0 as reqid
Volker Lendecke [Wed, 26 Oct 2011 08:56:32 +0000 (10:56 +0200)]
s3-ctdb: Don't hand out 0 as reqid

0 will be used as a wildcard reqid in ctdb_read_req

7 years agos3: Use talloc_tos() in parse_share_modes()
Volker Lendecke [Wed, 26 Oct 2011 11:54:55 +0000 (13:54 +0200)]
s3: Use talloc_tos() in parse_share_modes()

7 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sun, 23 Oct 2011 18:56:08 +0000 (20:56 +0200)]
s3: Fix some nonempty blank lines

7 years agos3: Fix some type-punned warnings
Volker Lendecke [Fri, 21 Oct 2011 10:04:59 +0000 (12:04 +0200)]
s3: Fix some type-punned warnings

7 years agos4:wscript - install the two missing files "dlz_bind9.so" and "named.conf.dlz"
Geza Gemes [Tue, 25 Oct 2011 19:47:24 +0000 (21:47 +0200)]
s4:wscript - install the two missing files "dlz_bind9.so" and "named.conf.dlz"

Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Oct 27 20:27:32 CEST 2011 on sn-devel-104

7 years agos4:repl_meta_data LDB module - don't intercept the partition LDB module referrals
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 13:57:45 +0000 (15:57 +0200)]
s4:repl_meta_data LDB module - don't intercept the partition LDB module referrals

Reviewed-by: abartlet
7 years agos4:repl_meta_data LDB module - rename operation - do not overwrite error messages
Matthias Dieter Wallnöfer [Fri, 14 Oct 2011 07:51:04 +0000 (09:51 +0200)]
s4:repl_meta_data LDB module - rename operation - do not overwrite error messages

"ldb_error" could overwrite possibly useful error messages.

Reviewed-by: abartlet
7 years agos4:repl_meta_data LDB module - remove pointless debug messages
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 14:02:10 +0000 (16:02 +0200)]
s4:repl_meta_data LDB module - remove pointless debug messages

These are displayed when an object just doesn't exist!

Reviewed-by: abartlet
7 years agos4:repl_meta_data LDB module - always return the original LDB result codes on failure
Matthias Dieter Wallnöfer [Fri, 14 Oct 2011 07:27:56 +0000 (09:27 +0200)]
s4:repl_meta_data LDB module - always return the original LDB result codes on failure

And add "ldb_operr()" before the "return ret" to point out the position
where it failed (for "add_time_element" and "add_uint64_element")

Reworked after a suggestion by abartlet.

7 years agos4:repl_meta_data LDB module - "dsdb_search_module_dn" already checks if len(res...
Matthias Dieter Wallnöfer [Fri, 14 Oct 2011 07:25:56 +0000 (09:25 +0200)]
s4:repl_meta_data LDB module - "dsdb_search_module_dn" already checks if len(res) == 1

No need to perform an additional check here. As a return value we should
always give back the original error code and not generate a new one (to
let the caller know what is going on).

Reviewed-by: abartlet
7 years agos4:ldap.py - fix up the dSHeuristics test to check for the right behaviour
Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 07:51:18 +0000 (09:51 +0200)]
s4:ldap.py - fix up the dSHeuristics test to check for the right behaviour

Reviewed-by: abartlet
7 years agos4:objectclass_attrs LDB module - implement the dSHeuristics length checks correctly
Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 06:48:08 +0000 (08:48 +0200)]
s4:objectclass_attrs LDB module - implement the dSHeuristics length checks correctly

Consider bug #8489

Reviewed-by: abartlet
7 years agos4:ldap.py - we test the creation of secrets already in the "systemOnly" testcase
Matthias Dieter Wallnöfer [Thu, 13 Oct 2011 06:21:31 +0000 (08:21 +0200)]
s4:ldap.py - we test the creation of secrets already in the "systemOnly" testcase

Reviewed-by: abartlet
7 years agos4:ldap.py - enhance and fix up the object class test
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 06:53:17 +0000 (08:53 +0200)]
s4:ldap.py - enhance and fix up the object class test

Also address the problem described in bug #8486.

Reviewed-by: abartlet
7 years agos4:objectclass LDB module - objectclass modify op. - remove superflous "talloc_strdup"
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:17:33 +0000 (20:17 +0200)]
s4:objectclass LDB module - objectclass modify op. - remove superflous "talloc_strdup"

We are adding strings embedded in the schema structure which is basically
global and lives longer than the request - hence no duplication needed.

Reviewed-by: abartlet
7 years agos4:objectclass LDB module - objectclass modify operations
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 15:58:37 +0000 (17:58 +0200)]
s4:objectclass LDB module - objectclass modify operations

According to bug #8486 the modification to direct related structural
object classes is possible (equal, child, parent).

Reviewed-by: abartlet
7 years agos4:objectclass LDB module - forbid to add unrelated objectclasses
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:33:53 +0000 (20:33 +0200)]
s4:objectclass LDB module - forbid to add unrelated objectclasses

E.g. unsatisfied abstract objectclasses, additional top-most structural
classes

Reviewed-by: abartlet
7 years agos4:objectclass LDB module - "objectclass_add" - small optimisation
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 07:29:08 +0000 (09:29 +0200)]
s4:objectclass LDB module - "objectclass_add" - small optimisation

This saves us from doing one "ldb_msg_find_element".

Reviewed-by: abartlet
7 years agos4:objectclass LDB module - "check_rodc_ntdsdsa_add"
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 18:34:17 +0000 (20:34 +0200)]
s4:objectclass LDB module - "check_rodc_ntdsdsa_add"

For convention use "ldb_attr_cmp()".

Reviewed-by: abartlet
7 years agos4:objectclass LDB module - update copyright
Matthias Dieter Wallnöfer [Wed, 12 Oct 2011 17:49:31 +0000 (19:49 +0200)]
s4:objectclass LDB module - update copyright

Reviewed-by: abartlet
7 years agos4:password_hash LDB module - fix compiler warning due to unsatisfied "switch"
Matthias Dieter Wallnöfer [Wed, 26 Oct 2011 08:04:11 +0000 (10:04 +0200)]
s4:password_hash LDB module - fix compiler warning due to unsatisfied "switch"

Bail out on other LDB request types (only add and modify allowed).

7 years agos4:ldap.py - fix up the UTF8 tests
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 11:03:44 +0000 (13:03 +0200)]
s4:ldap.py - fix up the UTF8 tests

Reviewed-by: abartlet
7 years agos4:ldap.py - reactivate some assertions in "test_all"
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:54:23 +0000 (12:54 +0200)]
s4:ldap.py - reactivate some assertions in "test_all"

There should always be one result on both s4 and Windows.

Reviewed-by: abartlet
7 years agos4:torture/ldap/basic.c - fix a typo
Matthias Dieter Wallnöfer [Sat, 22 Oct 2011 10:34:42 +0000 (12:34 +0200)]
s4:torture/ldap/basic.c - fix a typo

Reviewed-by: abartlet
7 years agoldb:common/ldb_modules.c - fix a typo in comment
Matthias Dieter Wallnöfer [Thu, 20 Oct 2011 20:29:43 +0000 (22:29 +0200)]
ldb:common/ldb_modules.c - fix a typo in comment

Reviewed-by: abartlet
7 years agos4-torture: Add a user creation check.
Andreas Schneider [Mon, 26 Sep 2011 15:48:01 +0000 (17:48 +0200)]
s4-torture: Add a user creation check.

This adds a patch which creates a non-privileged user and then tries to
create a new user as the non-privileged user.

Pretty simple test but it found #8509.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Oct 27 18:51:14 CEST 2011 on sn-devel-104

7 years agos4-torture: Add a samr privilege check.
Andreas Schneider [Thu, 15 Sep 2011 06:54:44 +0000 (08:54 +0200)]
s4-torture: Add a samr privilege check.

This is the first part which checks if a deleted user is propagated
correctly to all daemons and caches with user information are emtpy.

7 years agos4-torture: Add torture_delete_testuser().
Andreas Schneider [Fri, 23 Sep 2011 14:57:25 +0000 (16:57 +0200)]
s4-torture: Add torture_delete_testuser().

7 years agos4-torture: Add domain_handle to test_join struct.
Andreas Schneider [Fri, 23 Sep 2011 14:56:59 +0000 (16:56 +0200)]
s4-torture: Add domain_handle to test_join struct.

7 years agos3-build: Add .clang_complete.
Andreas Schneider [Thu, 15 Sep 2011 15:26:18 +0000 (17:26 +0200)]
s3-build: Add .clang_complete.

7 years agos3:rpc_client: remove references to auth_ntlmssp_state
Stefan Metzmacher [Thu, 27 Oct 2011 12:50:37 +0000 (14:50 +0200)]
s3:rpc_client: remove references to auth_ntlmssp_state

metze

Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu Oct 27 16:40:15 CEST 2011 on sn-devel-104

7 years agos3: Enable uid wrapper.
Andreas Schneider [Thu, 27 Oct 2011 10:01:09 +0000 (12:01 +0200)]
s3: Enable uid wrapper.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Thu Oct 27 15:06:58 CEST 2011 on sn-devel-104

7 years agoreplace: Add don't include unistd.h directly and add uid_wrapper.
Andreas Schneider [Sat, 8 Oct 2011 10:10:20 +0000 (12:10 +0200)]
replace: Add don't include unistd.h directly and add uid_wrapper.

7 years agos3: Include uid_wrapper where it is missing.
Andreas Schneider [Fri, 7 Oct 2011 17:00:29 +0000 (19:00 +0200)]
s3: Include uid_wrapper where it is missing.

7 years agoInclude uid_wrapper correctly.
Andreas Schneider [Thu, 27 Oct 2011 10:00:53 +0000 (12:00 +0200)]
Include uid_wrapper correctly.

7 years agos3-waf: Don't link uid_wrapper more than once.
Andreas Schneider [Fri, 7 Oct 2011 14:01:13 +0000 (16:01 +0200)]
s3-waf: Don't link uid_wrapper more than once.

The uid_wrapper is linked in globally by default if enabled.

7 years agonsswitch: Disable uid_wrapper in libwbclient.
Andreas Schneider [Fri, 7 Oct 2011 19:06:57 +0000 (21:06 +0200)]
nsswitch: Disable uid_wrapper in libwbclient.

This way we don't have to link against it in the autoconf build.

7 years agouid_wrapper: Add uwrap_setresgid().
Andreas Schneider [Sat, 8 Oct 2011 08:52:02 +0000 (10:52 +0200)]
uid_wrapper: Add uwrap_setresgid().

7 years agouid_wrapper: Fix build on UNIX platforms.
Andreas Schneider [Sat, 8 Oct 2011 08:08:37 +0000 (10:08 +0200)]
uid_wrapper: Fix build on UNIX platforms.

7 years agouid_wrapper: Handle euid and egid 0.
Andreas Schneider [Fri, 7 Oct 2011 16:58:58 +0000 (18:58 +0200)]
uid_wrapper: Handle euid and egid 0.

7 years agouid_wrapper: Make sure we have initialized the wrapper.
Andreas Schneider [Fri, 7 Oct 2011 16:02:33 +0000 (18:02 +0200)]
uid_wrapper: Make sure we have initialized the wrapper.

7 years agouid_wrapper: Fix prototypes.
Andreas Schneider [Fri, 7 Oct 2011 16:06:53 +0000 (18:06 +0200)]
uid_wrapper: Fix prototypes.

7 years agoreplace: Add checks for setreuid and setregid.
Andreas Schneider [Sat, 8 Oct 2011 08:47:57 +0000 (10:47 +0200)]
replace: Add checks for setreuid and setregid.

7 years agoreplace: Make sure we compile without uid_wrapper.
Andreas Schneider [Fri, 7 Oct 2011 16:05:43 +0000 (18:05 +0200)]
replace: Make sure we compile without uid_wrapper.

7 years agos3-netlogon: Fix setting the machinge account password.
Andreas Schneider [Thu, 27 Oct 2011 09:21:08 +0000 (11:21 +0200)]
s3-netlogon: Fix setting the machinge account password.

This bug has been found with uid wrapper.

7 years agoFactor out the code checking if a parent should override DELETE_ACCESS into a function.
Jeremy Allison [Wed, 26 Oct 2011 19:41:18 +0000 (12:41 -0700)]
Factor out the code checking if a parent should override DELETE_ACCESS into a function.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 26 23:15:05 CEST 2011 on sn-devel-104

7 years agoRemove another level of indentation - deal with !NT_STATUS_OK individually.
Jeremy Allison [Wed, 26 Oct 2011 18:00:11 +0000 (11:00 -0700)]
Remove another level of indentation - deal with !NT_STATUS_OK individually.

7 years agoAdd early return on stat open without O_CREAT if file doesn't exist.
Jeremy Allison [Wed, 26 Oct 2011 19:08:51 +0000 (12:08 -0700)]
Add early return on stat open without O_CREAT if file doesn't exist.
Reduces one level of indentation.

7 years agos3:libsmb: make use of map_nt_error_from_unix_common() in clitrans.c
Stefan Metzmacher [Wed, 26 Oct 2011 13:47:21 +0000 (15:47 +0200)]
s3:libsmb: make use of map_nt_error_from_unix_common() in clitrans.c

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 17:53:15 CEST 2011 on sn-devel-104

7 years agos3:libsmb: avoid using smb_flg2 in cli_trans.c
Stefan Metzmacher [Wed, 26 Oct 2011 13:46:33 +0000 (15:46 +0200)]
s3:libsmb: avoid using smb_flg2 in cli_trans.c

metze

7 years agos3:libsmb: replace smb_size - 4 with MIN_SMB_SIZE in clitrans.c
Stefan Metzmacher [Wed, 26 Oct 2011 13:44:52 +0000 (15:44 +0200)]
s3:libsmb: replace  smb_size - 4 with MIN_SMB_SIZE in clitrans.c

metze

7 years agos3:libsmb: use 'tevent_' instead of 'event_' in clitrans.c
Stefan Metzmacher [Wed, 26 Oct 2011 13:43:08 +0000 (15:43 +0200)]
s3:libsmb: use 'tevent_' instead of 'event_' in clitrans.c

metze

7 years agos3:libsmb: make use of smb_buffer_oob() in clitrans.c
Stefan Metzmacher [Wed, 26 Oct 2011 13:41:34 +0000 (15:41 +0200)]
s3:libsmb: make use of smb_buffer_oob() in clitrans.c

metze

7 years agos3:libsmb: use smb_len_nbt() in clitrans.c
Stefan Metzmacher [Wed, 26 Oct 2011 13:41:02 +0000 (15:41 +0200)]
s3:libsmb: use smb_len_nbt() in clitrans.c

metze

7 years agos3:include: implement trans_oob() as wrapper to smb_buffer_oob()
Stefan Metzmacher [Wed, 26 Oct 2011 12:23:48 +0000 (14:23 +0200)]
s3:include: implement trans_oob() as wrapper to smb_buffer_oob()

metze

7 years agolibcli/smb: add smb_buffer_oob() helper
Stefan Metzmacher [Wed, 26 Oct 2011 12:20:53 +0000 (14:20 +0200)]
libcli/smb: add smb_buffer_oob() helper

A copy of trans_oob().

metze

7 years agos3-netapi: remove pointless use_memory_krb5_ccache.
Günther Deschner [Wed, 26 Oct 2011 09:46:36 +0000 (11:46 +0200)]
s3-netapi: remove pointless use_memory_krb5_ccache.

This breaks the ABI.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Oct 26 13:23:58 CEST 2011 on sn-devel-104

7 years agolibcli/smb: merge NEGOTIATE_SECURITY_* flags to smb_constants.h
Stefan Metzmacher [Wed, 26 Oct 2011 07:28:10 +0000 (09:28 +0200)]
libcli/smb: merge NEGOTIATE_SECURITY_* flags to smb_constants.h

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Oct 26 11:27:12 CEST 2011 on sn-devel-104

7 years agos3:lib: make_unix_date3() is the same as pull_dos_date3()
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date3() is the same as pull_dos_date3()

Except for a 'void *' vs. 'uint8_t *'.

As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.

metze

7 years agos3:lib: make_unix_date2() is the same as pull_dos_date2()
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date2() is the same as pull_dos_date2()

Except for a 'void *' vs. 'uint8_t *'.

As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.

metze

7 years agos3:lib: make_unix_date() is the same as pull_dos_date()
Stefan Metzmacher [Wed, 26 Oct 2011 06:54:11 +0000 (08:54 +0200)]
s3:lib: make_unix_date() is the same as pull_dos_date()

Except for a 'void *' vs. 'uint8_t *'.

As a first step let make_unix_date() call pull_dos_date(),
so that we he the logic only once. We can fix the callers
later.

metze

7 years agos3-util: dbwrap_tool: fix fetch_string function
Björn Baumbach [Wed, 19 Oct 2011 08:54:53 +0000 (10:54 +0200)]
s3-util: dbwrap_tool: fix fetch_string function

We do not want truncated strings.

Signed-off-by: Michael Adam <obnox@samba.org>
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Oct 26 04:17:05 CEST 2011 on sn-devel-104

7 years agos3:net registry check: fix a case where automatic and read only mode take the wrong...
Gregor Beck [Thu, 20 Oct 2011 15:38:06 +0000 (17:38 +0200)]
s3:net registry check: fix a case where automatic and read only mode take the wrong action

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos3:net registry check: do not silently replace separators
Gregor Beck [Thu, 20 Oct 2011 15:36:10 +0000 (17:36 +0200)]
s3:net registry check: do not silently replace separators

Signed-off-by: Michael Adam <obnox@samba.org>
7 years agos4:torture:smb2: fix broken indentation/formatting in torture_smb2_connection()
Michael Adam [Sun, 23 Oct 2011 20:17:03 +0000 (22:17 +0200)]
s4:torture:smb2: fix broken indentation/formatting in torture_smb2_connection()

this was not readable well

7 years agotalloc: fix a comment typo
Michael Adam [Sun, 23 Oct 2011 14:57:07 +0000 (16:57 +0200)]
talloc: fix a comment typo

7 years agoSecond attempt to fix bug #8384 - Windows XP clients seem to crash smbd process every...
Jeremy Allison [Tue, 25 Oct 2011 22:31:48 +0000 (15:31 -0700)]
Second attempt to fix bug #8384 - Windows XP clients seem to crash smbd process every once in a while.

Don't just use the first entry in back_channels as a talloc context
to allocate a long-lived chan entry on - must be NULL. It's already
correctly deleted when the last reference goes away.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed Oct 26 02:42:35 CEST 2011 on sn-devel-104

7 years agos3:smb2cli_base: make use of [_]smb_[set]len_tcp()
Stefan Metzmacher [Tue, 25 Oct 2011 13:47:10 +0000 (15:47 +0200)]
s3:smb2cli_base: make use of [_]smb_[set]len_tcp()

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 25 19:30:43 CEST 2011 on sn-devel-104

7 years agos3:smb2cli_base: make use of map_nt_error_from_unix_common()
Stefan Metzmacher [Tue, 25 Oct 2011 12:56:38 +0000 (14:56 +0200)]
s3:smb2cli_base: make use of map_nt_error_from_unix_common()

metze

7 years agos3:lib/errmap_unix: map EPIPE to NT_STATUS_CONNECTION_DISCONNECTED
Stefan Metzmacher [Tue, 25 Oct 2011 13:12:05 +0000 (15:12 +0200)]
s3:lib/errmap_unix: map EPIPE to NT_STATUS_CONNECTION_DISCONNECTED

This lets map_nt_error_from_unix() return the same value as
map_nt_error_from_unix_common().

There are no callers relying on NT_STATUS_PIPE_BROKEN.

metze

7 years agos3:libsmb: s/event_context/tevent_context/ in async_smb.[ch]
Stefan Metzmacher [Tue, 25 Oct 2011 12:26:17 +0000 (14:26 +0200)]
s3:libsmb: s/event_context/tevent_context/ in async_smb.[ch]

metze

7 years agos3:lib/addrchange.h: include libreplace headers before others
Stefan Metzmacher [Tue, 25 Oct 2011 13:53:41 +0000 (15:53 +0200)]
s3:lib/addrchange.h: include libreplace headers before others

Also we typically don't use an explicit "lib/replace/" prefix.

metze

7 years agobuild: always include tevent with <tevent.h>
Andrew Bartlett [Tue, 25 Oct 2011 00:26:52 +0000 (11:26 +1100)]
build: always include tevent with <tevent.h>

This ensures we do the right thing if we are built against the system
tevent.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agobuild: always include talloc with <talloc.h>
Andrew Bartlett [Tue, 25 Oct 2011 00:23:54 +0000 (11:23 +1100)]
build: always include talloc with <talloc.h>

This ensures we do the right thing if we are built against the system
talloc.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agotorture: Remove unused smbiconv
Andrew Bartlett [Sun, 23 Oct 2011 23:05:19 +0000 (10:05 +1100)]
torture: Remove unused smbiconv

smbiconv is not used in any test script, and has only had changes
since being introduced by Jelmer to keep it building.

It is also not installed on the system. I have also checked with
Jelmer, who approved the removal.

Andrew Bartlett

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3-libsmbclient: make some functions static in testsuite code.
Günther Deschner [Tue, 25 Oct 2011 10:38:41 +0000 (12:38 +0200)]
s3-libsmbclient: make some functions static in testsuite code.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Tue Oct 25 17:57:25 CEST 2011 on sn-devel-104

7 years agos3:libsmb: make use of map_nt_error_from_unix_common() in async_smb.c
Stefan Metzmacher [Mon, 24 Oct 2011 22:49:08 +0000 (00:49 +0200)]
s3:libsmb: make use of map_nt_error_from_unix_common() in async_smb.c

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Oct 25 03:21:06 CEST 2011 on sn-devel-104

7 years agos3:libsmb: use HDR_* defines in cli_state_dispatch_smb1()
Stefan Metzmacher [Mon, 24 Oct 2011 16:13:09 +0000 (18:13 +0200)]
s3:libsmb: use HDR_* defines in cli_state_dispatch_smb1()

metze

7 years agos3:libsmb: make use of smb_[set]len_nbt() in async_smb.c
Stefan Metzmacher [Mon, 24 Oct 2011 15:51:17 +0000 (17:51 +0200)]
s3:libsmb: make use of smb_[set]len_nbt() in async_smb.c

metze

7 years agos3:libsmb: use HDR_* defines in cli_pull_raw_error()
Stefan Metzmacher [Mon, 24 Oct 2011 15:47:50 +0000 (17:47 +0200)]
s3:libsmb: use HDR_* defines in cli_pull_raw_error()

metze

7 years agolibcli/smb: move smb_signing.[ch] to the toplevel
Stefan Metzmacher [Mon, 24 Oct 2011 14:50:19 +0000 (16:50 +0200)]
libcli/smb: move smb_signing.[ch] to the toplevel

metze

7 years agos3:libsmb/smb_signing: make use of HDR_* defines
Stefan Metzmacher [Mon, 24 Oct 2011 07:39:16 +0000 (09:39 +0200)]
s3:libsmb/smb_signing: make use of HDR_* defines

metze

7 years agos3:libsmb/smb_signing: make use of smb_len_nbt()
Stefan Metzmacher [Mon, 24 Oct 2011 07:39:16 +0000 (09:39 +0200)]
s3:libsmb/smb_signing: make use of smb_len_nbt()

metze

7 years agos3:libsmb/smb_signing: avoid usage of smb_ss_field
Stefan Metzmacher [Mon, 24 Oct 2011 07:30:47 +0000 (09:30 +0200)]
s3:libsmb/smb_signing: avoid usage of smb_ss_field

metze

7 years agos4:libcli: rename smb_signing.h to smb_raw_signing.h in the install directory
Stefan Metzmacher [Mon, 24 Oct 2011 15:12:51 +0000 (17:12 +0200)]
s4:libcli: rename smb_signing.h to smb_raw_signing.h in the install directory

metze