gd/samba-autobuild/.git
8 months agoreplace: Fix "make test" to actually test libreplace
Andrew Bartlett [Sun, 5 May 2019 22:23:49 +0000 (10:23 +1200)]
replace: Fix "make test" to actually test libreplace

Found by Joe Guo during preperation for automated code coverage output.

In order to allow the Makefile wrapper to work we need to rename the
test directory to tests.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
8 months agobuild: Remove build of replacetort
Andrew Bartlett [Mon, 6 May 2019 03:32:12 +0000 (15:32 +1200)]
build: Remove build of replacetort

This is built close to the code it tests in lib/replace/wscript_build as
replace_testsuite.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
8 months agoselftest: correcting empty attribute usage in requests
Aaron Haslett [Thu, 28 Mar 2019 02:54:06 +0000 (15:54 +1300)]
selftest: correcting empty attribute usage in requests

Many parts of Samba use an empty attribute list in requests expecting
all attributes to be returned in the response, which is incorrect.  This
patch corrects the instances found by current CI tests.  Static analysis
and debugging will need to be done before changing ildap to the correct
semantics.

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Garming Sam <garming@samba.org>
Autobuild-Date(master): Mon May  6 05:45:55 UTC 2019 on sn-devel-184

8 months agoldap: test for empty attributes list
Aaron Haslett [Wed, 20 Mar 2019 06:17:07 +0000 (19:17 +1300)]
ldap: test for empty attributes list

Test for LDAP request with an empty attribute list.  LDB responds with
no attributes, but LDAP responds with all attributes.  Fix is attached
to the bug below but we can't push it upstream until we've found all
instances of incorrect empty attribute list usage in Samba.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13852

Signed-off-by: Aaron Haslett <aaronhaslett@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolib util debug: Increase format buffer to 4KiB
Gary Lockyer [Wed, 17 Apr 2019 22:23:22 +0000 (10:23 +1200)]
lib util debug: Increase format buffer to 4KiB

Increase the debug line buffer to 4KiB, the existing size of 1KiB is too
small for dsdbChange JSON audit messages.  These messages were then
split across multipe lines causing issues in log ingestion tools
expecting single line messages.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=13902

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Gary Lockyer <gary@samba.org>
Autobuild-Date(master): Mon May  6 01:18:22 UTC 2019 on sn-devel-184

8 months ago.gitlab-ci.yml: add docker tag back for private jobs
Joe Guo [Wed, 1 May 2019 23:04:05 +0000 (11:04 +1200)]
.gitlab-ci.yml: add docker tag back for private jobs

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sun May  5 23:22:54 UTC 2019 on sn-devel-184

8 months ago.gitlab-ci.yml: rm abs path in artifacts
Joe Guo [Wed, 1 May 2019 23:05:23 +0000 (11:05 +1200)]
.gitlab-ci.yml: rm abs path in artifacts

According to doc: https://docs.gitlab.com/ee/user/project/pipelines/job_artifacts.html#defining-artifacts-in-gitlab-ciyml
all paths in artifacts must be relative to the cloned repo, so this line
actually never worked.

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agobootstrap: add lcov to generate code coverage report
Joe Guo [Fri, 3 May 2019 02:21:24 +0000 (14:21 +1200)]
bootstrap: add lcov to generate code coverage report

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agosmbd: Use "ISDOT" in reply_setatr
Volker Lendecke [Mon, 15 Apr 2019 20:31:40 +0000 (22:31 +0200)]
smbd: Use "ISDOT" in reply_setatr

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Fri May  3 23:45:55 UTC 2019 on sn-devel-184

8 months agolibcli: Align integer types
Volker Lendecke [Fri, 12 Apr 2019 13:03:26 +0000 (15:03 +0200)]
libcli: Align integer types

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agolibcli: Remove an unnecessary #include
Volker Lendecke [Fri, 12 Apr 2019 13:03:12 +0000 (15:03 +0200)]
libcli: Remove an unnecessary #include

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agosmbd: Use a struct initializer
Volker Lendecke [Thu, 25 Apr 2019 19:03:35 +0000 (21:03 +0200)]
smbd: Use a struct initializer

With -O3 this saves 32 bytes of .text

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agosmbd: Make "check_access()" static to trans2.c
Volker Lendecke [Sun, 14 Apr 2019 09:41:49 +0000 (11:41 +0200)]
smbd: Make "check_access()" static to trans2.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agosmbd: Use smbd_check_access_rights in reply_setatr()
Volker Lendecke [Sun, 14 Apr 2019 09:39:31 +0000 (11:39 +0200)]
smbd: Use smbd_check_access_rights in reply_setatr()

That was the only caller of check_access outside of trans2.c, and it
passed an explicit NULL for fsp. Use the lower-level call, so we can
make check_access() static to trans2.c

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agos3: modules: ceph: use current working directory instead of share path
Robert Sander [Thu, 2 May 2019 18:20:44 +0000 (11:20 -0700)]
s3: modules: ceph: use current working directory instead of share path

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13918

Signed-off-by: Robert Sander <r.sander@heinlein-support.de>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu May  2 19:34:11 UTC 2019 on sn-devel-184

8 months agosmbd: implement SMB_FILE_NORMALIZED_NAME_INFORMATION handling
Stefan Metzmacher [Thu, 25 Apr 2019 12:57:33 +0000 (14:57 +0200)]
smbd: implement SMB_FILE_NORMALIZED_NAME_INFORMATION handling

Windows 10 (1803 and higher) support and use
SMB_FILE_NORMALIZED_NAME_INFORMATION calls over the network. As a
fallback (in case the server don't support it) the client traverses all
path components, which is very expensive.

Implementing SMB_FILE_NORMALIZED_NAME_INFORMATION is very cheap for us
as the open already went through unix_convert() and we have the
information the client is asking for.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed May  1 18:33:00 UTC 2019 on sn-devel-184

8 months agos4:torture/smb2: add smb2.getinfo.normalized test
Stefan Metzmacher [Thu, 25 Apr 2019 12:57:02 +0000 (14:57 +0200)]
s4:torture/smb2: add smb2.getinfo.normalized test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agos4:libcli/raw: add RAW_FILEINFO_NORMALIZED_NAME_INFORMATION support
Stefan Metzmacher [Thu, 25 Apr 2019 10:12:34 +0000 (12:12 +0200)]
s4:libcli/raw: add RAW_FILEINFO_NORMALIZED_NAME_INFORMATION support

This is supported over the wire in SMB 3.1.1 on starting with
Windows 10 1803.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agosmbd: allow case insensitive opens of named streams
Stefan Metzmacher [Thu, 25 Apr 2019 15:30:43 +0000 (17:30 +0200)]
smbd: allow case insensitive opens of named streams

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agos4:torture/smb2: add smb2.stream.names3 test
Stefan Metzmacher [Mon, 29 Apr 2019 12:53:13 +0000 (14:53 +0200)]
s4:torture/smb2: add smb2.stream.names3 test

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13919

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agoscript/attr_count_read: load and correlate all data
Douglas Bagnall [Sun, 31 Mar 2019 03:07:57 +0000 (16:07 +1300)]
script/attr_count_read: load and correlate all data

This changes script/attr_count_read to take the samba private directory
as an argument and load all the databases at once, printing them as
one big table. It isn't extremely clear what it all means, but it
*tries* to tell you.

With --plot, it will attempt to load matplotlib and plot the number of
requested attributes against the number returned, with colour
of each point indicating its relative frequency. It is a scatterplot
that wants to be a heatmap.

With --no-casefold, you can get an extra confusing table where,
for instance, something repeatedly asks for "attributeId" which is not
accounted for, while in a completely different row an unrequested
"attributeID" is found many times over.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May  1 06:46:36 UTC 2019 on sn-devel-184

8 months agodsdb/modules: a module to count attribute searches and results
Douglas Bagnall [Thu, 28 Mar 2019 03:07:48 +0000 (16:07 +1300)]
dsdb/modules: a module to count attribute searches and results

The dsdb module stack can turn a simple search request into a
complicated tree of sub-queries that include attributes not originally
asked for and excluding those that were. The corresponding replies
might contain unrequested attributes or (for good reasons, according
to some module) hide requested ones. The entire stack is there to
meddle and that is what is does. Except *this* module. It just counts.
To understand dsdb performance it helps to have some idea what
requests and replies are flying too and fro. This module, when
inserted anywhere in the stack, counts the requests and replies
passing through and the attributes they contain. This data is stored
in on-disk tdbs in the private/debug directory.

The module is not loaded by default. To load it you need to patch the
source4/dsdb/samdb/ldb_modules/samba_dsdb.c and put "count_attrs"
somewhere in the module lists in the samba_dsdb_init() function. For
example, to examine the traffic between repl_meta_data and
group_audit_log, you would do something like this around line 316:

          "subtree_delete",
          "repl_meta_data",
  +       "count_attrs",
          "group_audit_log",
          "encrypted_secrets",

and recompile. Samba will then write to a number of tdb files in the
debug directory as requests and replies pass through. A simple script
is included to read these files. Doing this:

./script/attr_count_read st/ad_dc/private/debug/debug/attr_counts_not_found.tdb

will print a table showing how often various attritbutes were
requested but not found (from the point of view of the module).

A more sophisticated version of the script is coming in the next
commit, but this one is included first because in its simplicity it
documents the storage format reasonably well. The tdb keys are
attribute names, and the values are uint32_t in machine native order.

When the module is included in the stack there will be a very small
decrease in performance.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agopytests: slightly better errors in Testcase.insta_creds()
Douglas Bagnall [Thu, 18 Apr 2019 01:37:27 +0000 (13:37 +1200)]
pytests: slightly better errors in Testcase.insta_creds()

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agopytests: try ldap.modify_order with normal user
Douglas Bagnall [Thu, 18 Apr 2019 01:39:58 +0000 (13:39 +1200)]
pytests: try ldap.modify_order with normal user

We run the tests again, trying to modify as a normal user rather than
Administrator.

It turns out that we do not always return the same error code as
Windows, but in all these tests both Windows and Samba always return
some kind of error (as you might hope).

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agodsdb pytests: test the effect of reordering modify requests
Douglas Bagnall [Fri, 12 Apr 2019 12:23:26 +0000 (00:23 +1200)]
dsdb pytests: test the effect of reordering modify requests

Do we interpret these the same way as Windows? In many cases, no.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos4/tests.py: shorten lines with common path
Douglas Bagnall [Fri, 12 Apr 2019 12:21:29 +0000 (00:21 +1200)]
s4/tests.py: shorten lines with common path

A small step

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agodsdb/pytest/ldap: use idiomatic 'e' for exceptions
Douglas Bagnall [Fri, 12 Apr 2019 03:51:05 +0000 (15:51 +1200)]
dsdb/pytest/ldap: use idiomatic 'e' for exceptions

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agodsdb/pytest/ldap: revive commented out test for attr size range
Douglas Bagnall [Fri, 12 Apr 2019 04:09:55 +0000 (16:09 +1200)]
dsdb/pytest/ldap: revive commented out test for attr size range

The test was presumably commented out because we fail it, and
known-failing it would have hidden the attr-too-short tests that it
was bundled with. If we disentangle them we can knwn-fail it, which
serves as a TODO list.

(passes against WIN2012R2).

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months ago.gitlab-ci.yml: keep samba-ci-private tag only for private jobs
Joe Guo [Wed, 1 May 2019 03:18:31 +0000 (15:18 +1200)]
.gitlab-ci.yml: keep samba-ci-private tag only for private jobs

This will help us give the legacy 'private' tag, used in branches
under maintenance, more resources without those jobs running on the
normal production runners (therefore avoiding the additional cost for
the 90% of builds that are for master).

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
8 months agos4:samdb: Make sure value is initialized with 0
Andreas Schneider [Tue, 30 Apr 2019 14:23:17 +0000 (16:23 +0200)]
s4:samdb: Make sure value is initialized with 0

Found by csbuild.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May  1 05:02:22 UTC 2019 on sn-devel-184

8 months agolib:torture: Fix size type in torture macro
Andreas Schneider [Tue, 30 Apr 2019 12:23:52 +0000 (14:23 +0200)]
lib:torture: Fix size type in torture macro

Found by csbuild.
https://gitlab.com/samba-team/devel/samba/-/jobs/204481431

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos4/replmd delete: optimise attribute preservation with binary search
Douglas Bagnall [Tue, 30 Apr 2019 22:41:41 +0000 (10:41 +1200)]
s4/replmd delete: optimise attribute preservation with binary search

When we get here it is very likely that the attribute will not be
preserved, as the preserved ones should have had the flag set, but we
still end up loking through the whole list to confirm. With a binary
search, we end up looking at ~5 attributes to confirm.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos4/replmd: delete checks flag before laborious search
Douglas Bagnall [Tue, 30 Apr 2019 22:35:46 +0000 (10:35 +1200)]
s4/replmd: delete checks flag before laborious search

Most (perhaps all) attributes that are in the "must not remove" list also
have the PRESERVEONDELETE bit set, and checking bits is much cheaper
than a linear search involving strcasecmp. If we check the bit first
we save work.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agosmbd: Move deadtime default to parameter definition and man page
Christof Schmitt [Mon, 29 Apr 2019 18:01:44 +0000 (11:01 -0700)]
smbd: Move deadtime default to parameter definition and man page

The code has a default of one week (10080 minutes) if the parameter is
set to 0. Make this the public default of the parameter, instead of
hiding it in the code. This change also has the code match the
documentation that setting this parameter to 0 disables the check.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agotraffic: load dns query from file and write stats to file
Joe Guo [Tue, 26 Mar 2019 04:48:39 +0000 (17:48 +1300)]
traffic: load dns query from file and write stats to file

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed May  1 01:10:42 UTC 2019 on sn-devel-184

8 months agotraffic: define kerberos_state to simplify code
Joe Guo [Tue, 26 Mar 2019 06:50:35 +0000 (19:50 +1300)]
traffic: define kerberos_state to simplify code

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
8 months agotraffic: make code more pythonic
Joe Guo [Sun, 24 Mar 2019 23:59:44 +0000 (12:59 +1300)]
traffic: make code more pythonic

Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
8 months agotraffic_replay: Avoid Exception if no packet rate is specified
Tim Beale [Wed, 10 Apr 2019 01:12:30 +0000 (13:12 +1200)]
traffic_replay: Avoid Exception if no packet rate is specified

traffic_replay would throw an exception if you didn't specify some sort
of packet rate. We can avoid this by using --scale-traffic=1.0 as the
default if nothing else was specified.

 script/traffic_replay model.txt $SERVER.$REALM --duration=10
   --fixed-password=blahblah12# -U$USERNAME%$PASSWORD
INFO 2019-04-10 01:03:01,809 pid:47755 script/traffic_replay #280: Using
the specified model file to generate conversations
Traceback (most recent call last):
  File "script/traffic_replay", line 438, in <module>
    main()
  File "script/traffic_replay", line 293, in main
    opts.conversation_persistence)
  File "bin/python/samba/emulate/traffic.py", line 1295, in
generate_conversation_sequences
    target_packets = int(packet_rate * duration)
TypeError: unsupported operand type(s) for *: 'NoneType' and 'float'

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
8 months agotraffic_replay: Assign users to groups by default
Tim Beale [Wed, 10 Apr 2019 00:55:26 +0000 (12:55 +1200)]
traffic_replay: Assign users to groups by default

The traffic_replay script has a myriad of options, but by default when
it creates user accounts it does not assign these users to any groups
(you have to specify extra options to do that). This isn't really a fair
test of samba performance, because it's unlikely that real world setups
will have users that are in no groups (other than the default ones).

This patch changes the default behaviour so that it will assign the new
users to groups automatically, if no other group options were
specified.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
8 months agolib:crypto: Remove unused SHA256 and HMAC SHA256
Andreas Schneider [Thu, 11 Oct 2018 16:36:00 +0000 (18:36 +0200)]
lib:crypto: Remove unused SHA256 and HMAC SHA256

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agoauth:gensec: Add return code for netsec_do_sign()
Andreas Schneider [Tue, 4 Dec 2018 08:22:03 +0000 (09:22 +0100)]
auth:gensec: Add return code for netsec_do_sign()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agoauth:gensec: Use GnuTLS SHA256 HMAC for schannel
Andreas Schneider [Thu, 11 Oct 2018 12:51:18 +0000 (14:51 +0200)]
auth:gensec: Use GnuTLS SHA256 HMAC for schannel

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Use smb2_signing_key for smb2_signing_check_pdu()
Andreas Schneider [Thu, 14 Mar 2019 16:42:34 +0000 (17:42 +0100)]
libcli:smb: Use smb2_signing_key for smb2_signing_check_pdu()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Use smb2_signing_key for smb2_signing_sign_pdu()
Andreas Schneider [Wed, 13 Mar 2019 18:34:23 +0000 (19:34 +0100)]
libcli:smb: Use smb2_signing_key for smb2_signing_sign_pdu()

This caches the gnutls hmac handle in the struct so we only allocate it
once.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Add smb2_signing_key_destructor()
Andreas Schneider [Wed, 13 Mar 2019 17:56:05 +0000 (18:56 +0100)]
libcli:smb: Add smb2_signing_key_destructor()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos3:smbd: Start to use the smb2_signing_key structure
Andreas Schneider [Wed, 13 Mar 2019 17:07:17 +0000 (18:07 +0100)]
s3:smbd: Start to use the smb2_signing_key structure

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos3:librpc: Add smb2_signing_key to smbXsrv.idl
Andreas Schneider [Wed, 13 Mar 2019 15:45:47 +0000 (16:45 +0100)]
s3:librpc: Add smb2_signing_key to smbXsrv.idl

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos3:librpc: Rename the data blobs for keys in smbXsrv.idl
Andreas Schneider [Wed, 13 Mar 2019 15:44:53 +0000 (16:44 +0100)]
s3:librpc: Rename the data blobs for keys in smbXsrv.idl

The original names will be used with a new structure to cache mac and
cipher handles for gnutls later.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Use 'struct smb2_signing_key' in smbXcli_base.c
Andreas Schneider [Mon, 4 Mar 2019 15:59:51 +0000 (16:59 +0100)]
libcli:smb: Use 'struct smb2_signing_key' in smbXcli_base.c

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Introduce a structure for the smb2_singing_key
Andreas Schneider [Mon, 4 Mar 2019 15:53:39 +0000 (16:53 +0100)]
libcli:smb: Introduce a structure for the smb2_singing_key

This also adds a new function to validate the structure.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Use GnuTLS SHA256 HMAC in smb2_signing_check_pdu()
Andreas Schneider [Thu, 14 Mar 2019 16:22:57 +0000 (17:22 +0100)]
libcli:smb: Use GnuTLS SHA256 HMAC in smb2_signing_check_pdu()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Use GnuTLS SHA256 HMAC in smb2_signing_sign_pdu()
Andreas Schneider [Thu, 14 Mar 2019 16:22:22 +0000 (17:22 +0100)]
libcli:smb: Use GnuTLS SHA256 HMAC in smb2_signing_sign_pdu()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:smb: Use GnuTLS SHA256 HMAC in smb2_key_derivation()
Andreas Schneider [Wed, 10 Oct 2018 13:47:37 +0000 (15:47 +0200)]
libcli:smb: Use GnuTLS SHA256 HMAC in smb2_key_derivation()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:auth: Add return code for netlogon_creds_init_hmac_sha256()
Andreas Schneider [Tue, 4 Dec 2018 08:13:31 +0000 (09:13 +0100)]
libcli:auth: Add return code for netlogon_creds_init_hmac_sha256()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolibcli:auth: Use GnuTLS SHA256 HMAC for credentials
Andreas Schneider [Wed, 10 Oct 2018 13:37:18 +0000 (15:37 +0200)]
libcli:auth: Use GnuTLS SHA256 HMAC for credentials

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos4:libcli:smb2: Use GnuTLS SHA256 HMAC for signing
Andreas Schneider [Thu, 11 Oct 2018 16:23:12 +0000 (18:23 +0200)]
s4:libcli:smb2: Use GnuTLS SHA256 HMAC for signing

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos4:utils: Use gnutls SHA256 in oLschema2ldif
Andreas Schneider [Thu, 11 Oct 2018 16:29:11 +0000 (18:29 +0200)]
s4:utils: Use gnutls SHA256 in oLschema2ldif

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos3:modules: Use GnuTLS SHA256 in vfs_acl_common
Andreas Schneider [Thu, 11 Oct 2018 12:43:24 +0000 (14:43 +0200)]
s3:modules: Use GnuTLS SHA256 in vfs_acl_common

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agowaf: Remove unused GNUTLS defines
Andreas Schneider [Wed, 10 Oct 2018 12:50:34 +0000 (14:50 +0200)]
waf: Remove unused GNUTLS defines

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agowaf: Move check for gnutls_aead_cipher_init to main gnutls wscript
Andreas Schneider [Wed, 10 Oct 2018 12:44:44 +0000 (14:44 +0200)]
waf: Move check for gnutls_aead_cipher_init to main gnutls wscript

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agowaf: Add check for gnutls_x509_crt_set_subject_unique_id()
Andreas Schneider [Mon, 29 Apr 2019 09:05:07 +0000 (11:05 +0200)]
waf: Add check for gnutls_x509_crt_set_subject_unique_id()

This is used by the GnuTLS backupkey implementation.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agowaf: Move gnutls_pkcs7_get_embedded_data_oid to main gnutls file
Andreas Schneider [Wed, 10 Oct 2018 12:38:24 +0000 (14:38 +0200)]
waf: Move gnutls_pkcs7_get_embedded_data_oid to main gnutls file

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agowaf: Remove configure steps from source4/lib/tls
Andreas Schneider [Wed, 10 Oct 2018 12:34:24 +0000 (14:34 +0200)]
waf: Remove configure steps from source4/lib/tls

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos4:rpc_server: Remove obsolete gcrypt init
Andreas Schneider [Wed, 10 Oct 2018 12:49:47 +0000 (14:49 +0200)]
s4:rpc_server: Remove obsolete gcrypt init

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agos3:tls: Remove #ifdef for GnuTLS
Andreas Schneider [Wed, 10 Oct 2018 12:24:51 +0000 (14:24 +0200)]
s3:tls: Remove #ifdef for GnuTLS

This is a requirement now.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agowaf: Add mandatory requirement for GnuTLS >= 3.2.0
Andreas Schneider [Wed, 10 Oct 2018 12:20:11 +0000 (14:20 +0200)]
waf: Add mandatory requirement for GnuTLS >= 3.2.0

We plan to move to GnuTLS for crypto in Samba, this is the first step to
make it mandatory and to require a version which is in LTS
distributions.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agolib:util: Sync memory.h with replace.h
Andreas Schneider [Mon, 3 Dec 2018 14:37:03 +0000 (15:37 +0100)]
lib:util: Sync memory.h with replace.h

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months agoreplace: Add ZERO_ARRAY_LEN() macro
Andreas Schneider [Mon, 3 Dec 2018 14:32:55 +0000 (15:32 +0100)]
replace: Add ZERO_ARRAY_LEN() macro

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
8 months ago.gitlab-ci.yml: Allow overriding the default image using a variable
Samuel Cabrero [Thu, 25 Apr 2019 11:12:42 +0000 (13:12 +0200)]
.gitlab-ci.yml: Allow overriding the default image using a variable

This way one can run all tests in a different container without having
to modify the gitlab ci file, just setting the SAMBA_CI_CONTAINER_IMAGE
variable in the gitlab's GUI.

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
8 months agogitlab-ci: Update for building new containers
Andreas Schneider [Tue, 30 Apr 2019 12:12:55 +0000 (14:12 +0200)]
gitlab-ci: Update for building new containers

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Tue Apr 30 18:48:18 UTC 2019 on sn-devel-184

8 months agobootstrap: Only install required packages on openSUSE
Andreas Schneider [Tue, 30 Apr 2019 07:59:15 +0000 (09:59 +0200)]
bootstrap: Only install required packages on openSUSE

This should reduce the amount of packages installed. And make building
the image much faster!

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 months agobootstrap: Only install required packages on Fedora
Andreas Schneider [Tue, 30 Apr 2019 08:10:24 +0000 (10:10 +0200)]
bootstrap: Only install required packages on Fedora

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
8 months agowafsamba: Add compiler check for missing field initializer check
Christof Schmitt [Mon, 29 Apr 2019 20:07:08 +0000 (13:07 -0700)]
wafsamba: Add compiler check for missing field initializer check

The commit cf79ee15

    wafsamba: Enable warnings for missing field initializer

enabled a compiler check for warnings about missing initializers for all
developer builds. This fails with older compilers, e.g. gcc on RHEL7.
Add a waf check around adding the compiler option to avoid the failure
with older compilers.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
8 months agocredentials: Workaround krb5_cc_remove_cred not implemented in MIT kerberos
Samuel Cabrero [Wed, 27 Mar 2019 16:12:09 +0000 (17:12 +0100)]
credentials: Workaround krb5_cc_remove_cred not implemented in MIT kerberos

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Mon Apr 29 19:15:48 UTC 2019 on sn-devel-184

8 months agocredentials: Initialize krb5 client to retrieve creds from ccache
Samuel Cabrero [Wed, 27 Mar 2019 16:07:05 +0000 (17:07 +0100)]
credentials: Initialize krb5 client to retrieve creds from ccache

MIT kerberos require krb5_creds.client to be initialized to match
krb5_creds.server with the cached credentials.

Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agoselftests: Place credential cache file inside environment directory
Samuel Cabrero [Wed, 27 Mar 2019 16:05:20 +0000 (17:05 +0100)]
selftests: Place credential cache file inside environment directory

Pair-Programmed-With: Andreas Schneider <asn@samba.org>
Signed-off-by: Samuel Cabrero <scabrero@suse.de>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
8 months agowaf: only set mandatory to False if not already set by the caller
Ralph Boehme [Fri, 29 Mar 2019 17:18:27 +0000 (18:18 +0100)]
waf: only set mandatory to False if not already set by the caller

There are a bunch of callers that call find_program with mandatory=True,
we should not overwrite this when explicity passed, eg:

  ctx.find_program('objcopy', var='OBJCOPY', mandatory=True)

  conf.SAMBA_CHECK_PERL(mandatory=True)
    -> conf.find_program('perl', var='PERL', mandatory=mandatory)

With this patch we only change the default from False to True, but allow
callers to choose specific behaviour.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Apr 29 17:07:02 UTC 2019 on sn-devel-184

8 months agogitlab-ci: Install missing krb5-kdc package on Ubuntu/Debian
Andreas Schneider [Mon, 29 Apr 2019 08:51:33 +0000 (10:51 +0200)]
gitlab-ci: Install missing krb5-kdc package on Ubuntu/Debian

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agowafsamba: Enable warnings for missing field initializer
Andreas Schneider [Thu, 13 Dec 2018 10:41:56 +0000 (11:41 +0100)]
wafsamba: Enable warnings for missing field initializer

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agos3:libsmb: Fix C99 initializer in cli_smb2_fnum.c
Andreas Schneider [Tue, 23 Apr 2019 09:03:27 +0000 (11:03 +0200)]
s3:libsmb: Fix C99 initializer in cli_smb2_fnum.c

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agos4:dsdb: Use C99 initializer in dsdb util_trusts
Andreas Schneider [Mon, 14 Jan 2019 12:07:28 +0000 (13:07 +0100)]
s4:dsdb: Use C99 initializer in dsdb util_trusts

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agos3:lib: Use correct C99 initializer for 'struct flock' in messages_dgm
Andreas Schneider [Mon, 14 Jan 2019 11:20:35 +0000 (12:20 +0100)]
s3:lib: Use correct C99 initializer for 'struct flock' in messages_dgm

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agolib:audit_logging: Use C99 initializer for server_id in audit_logging
Andreas Schneider [Mon, 14 Jan 2019 12:24:24 +0000 (13:24 +0100)]
lib:audit_logging: Use C99 initializer for server_id in audit_logging

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agos3:utils: use struct initializer in async-tracker long_options
Ralph Boehme [Mon, 29 Apr 2019 09:32:35 +0000 (11:32 +0200)]
s3:utils: use struct initializer in async-tracker long_options

s3:utils: use struct initializer in async-tracker long_options

The previous initializer list was missing a NULL as last element. Using struct
initializers instead for correct initialisation.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
8 months agoRevert "lib/replace: define NAME_MAX for platforms that don't have it"
Günther Deschner [Thu, 25 Apr 2019 12:49:48 +0000 (14:49 +0200)]
Revert "lib/replace: define NAME_MAX for platforms that don't have it"

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

This reverts commit e3c894fb6b87df8aa56e29ef3b16ae1ef456a875.

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Apr 26 13:03:05 UTC 2019 on sn-devel-184

8 months agos3/vfs_glusterfs_fuse: Dynamically determine NAME_MAX
Anoop C S [Thu, 25 Apr 2019 11:12:01 +0000 (16:42 +0530)]
s3/vfs_glusterfs_fuse: Dynamically determine NAME_MAX

This allows the vfs_glusterfs_fuse build to complete on AIX.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agos3/vfs_glusterfs: Dynamically determine NAME_MAX
Anoop C S [Thu, 25 Apr 2019 11:11:53 +0000 (16:41 +0530)]
s3/vfs_glusterfs: Dynamically determine NAME_MAX

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13872

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agogitlab-ci: Remove Ubuntu 14.04
Andreas Schneider [Thu, 25 Apr 2019 06:05:56 +0000 (08:05 +0200)]
gitlab-ci: Remove Ubuntu 14.04

Ubuntu 14.04 a compiler which complains about valid C99 code and also it
doesn't offer GnuTLS >= 3.2 which we require to move to GnuTLS.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Apr 25 16:52:57 UTC 2019 on sn-devel-184

8 months agogitlab-ci: Enable fedora29 and update generated dists
Andreas Schneider [Wed, 17 Apr 2019 06:54:52 +0000 (08:54 +0200)]
gitlab-ci: Enable fedora29 and update generated dists

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu Apr 25 11:46:23 UTC 2019 on sn-devel-184

8 months agobootstrap: Add glusterfs and cephfs packages
Andreas Schneider [Thu, 25 Apr 2019 08:23:45 +0000 (10:23 +0200)]
bootstrap: Add glusterfs and cephfs packages

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agobootstrap: Add missing packages for XFS quota support
Andreas Schneider [Thu, 25 Apr 2019 09:10:15 +0000 (11:10 +0200)]
bootstrap: Add missing packages for XFS quota support

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agobootstrap: Add missing packages on RPM distributions
Andreas Schneider [Thu, 25 Apr 2019 08:14:44 +0000 (10:14 +0200)]
bootstrap: Add missing packages on RPM distributions

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agobootstrap: Fix dnf commands
Andreas Schneider [Tue, 23 Apr 2019 09:40:07 +0000 (11:40 +0200)]
bootstrap: Fix dnf commands

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agos4:heimdal: Disable format truncation warnings
Andreas Schneider [Tue, 26 Mar 2019 20:14:13 +0000 (21:14 +0100)]
s4:heimdal: Disable format truncation warnings

We build that code and do not treat warnings as errors anyway,
so just disable format truncation.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agos3:modules: Fix size types
Andreas Schneider [Tue, 23 Apr 2019 10:57:02 +0000 (12:57 +0200)]
s3:modules: Fix size types

error: assuming signed overflow does not occur when simplifying
conditional to constant [-Werror=strict-overflow]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
8 months agoautobuild: Build also Samba AD with MIT Kerberos
Andreas Schneider [Tue, 23 Apr 2019 16:10:04 +0000 (18:10 +0200)]
autobuild: Build also Samba AD with MIT Kerberos

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
9 months agowscript: Remove checks for shm_open and shmget
Christof Schmitt [Wed, 24 Apr 2019 17:16:30 +0000 (10:16 -0700)]
wscript: Remove checks for shm_open and shmget

Commit 74a16a1094278 "s3:smbprofile: Replace sysv shmem with tdb"
removed the usage of the shared memory segment for profiling data. As
there are no other users of shared memory segments, remove the configure
check for these functions.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Apr 25 00:54:16 UTC 2019 on sn-devel-184

9 months agos3-mdssvc: add a comment to mds_init()
Ralph Boehme [Tue, 12 Mar 2019 14:43:57 +0000 (15:43 +0100)]
s3-mdssvc: add a comment to mds_init()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Wed Apr 24 19:32:12 UTC 2019 on sn-devel-184

9 months agos3-mdssvc: make mds_ctx_destructor_cb static
Ralph Boehme [Tue, 12 Mar 2019 14:29:48 +0000 (15:29 +0100)]
s3-mdssvc: make mds_ctx_destructor_cb static

This is only used in this compilation unit.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
9 months agos3-mdssvc: add missing call to g_cancellable_new()
Ralph Boehme [Tue, 12 Mar 2019 14:27:25 +0000 (15:27 +0100)]
s3-mdssvc: add missing call to g_cancellable_new()

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Noel Power <npower@samba.org>