gd/samba-autobuild/.git
16 years agor13388: Report a more helpful error with malformed file options of
James Peach [Wed, 8 Feb 2006 05:14:48 +0000 (05:14 +0000)]
r13388: Report a more helpful error with malformed file options of
the form //server/share (ie. remote path missing).
(This used to be commit 443677f58d4ba8d6aa2963ca5848d3e717ee2cac)

16 years agor13387: Make sure smbcli_parse_unc reports a failure for strings of
James Peach [Wed, 8 Feb 2006 05:13:11 +0000 (05:13 +0000)]
r13387: Make sure smbcli_parse_unc reports a failure for strings of
the form //server. Make sure failure cases are well-defined.
(This used to be commit e0020df66bf38873eaaacb95cadac55e17f432be)

16 years agor13381: Test the SamLogonEx SamLogon call in the schannel test. This is only
Andrew Bartlett [Tue, 7 Feb 2006 23:49:35 +0000 (23:49 +0000)]
r13381: Test the SamLogonEx SamLogon call in the schannel test.  This is only
available under schannel, and performs a netlogon authentication.

Andrew Bartlett
(This used to be commit 561a690915f9d3ca2fbb76f16c47cf2f6be1b825)

16 years agor13380: Drop the socket, then try SAMR operations secured with netlogon on the new...
Andrew Bartlett [Tue, 7 Feb 2006 23:30:50 +0000 (23:30 +0000)]
r13380: Drop the socket, then try SAMR operations secured with netlogon on the new socket.

We should also test netlogon operations, but there are issues with
what state is expected to be stored (far more than we currently do).

Andrew Bartlett
(This used to be commit 39ddba0d0dc4475f9f7c5b7aa19ffff42c9fd1f5)

16 years agor13374: new revision of the snprintf replace code
Simo Sorce [Tue, 7 Feb 2006 00:50:38 +0000 (00:50 +0000)]
r13374: new revision of the snprintf replace code

still missing a configure test to make us
substitute our snprintf to system one when
the system one does not have positional parameters support
(This used to be commit 398f989d6580587eb1fa4fec0b1ed858b5cbe8e1)

16 years agor13373: Implement the -p option for smbtorture.
James Peach [Mon, 6 Feb 2006 23:01:17 +0000 (23:01 +0000)]
r13373: Implement the -p option for smbtorture.
(This used to be commit fc17a50b48189c60af60b9163695b48c6b87c5c7)

16 years agor13372: fixes ... still no joy
Simo Sorce [Mon, 6 Feb 2006 22:55:34 +0000 (22:55 +0000)]
r13372: fixes ... still no joy
(This used to be commit 0e2cca9153619d646b90f32620905ab66b017c6a)

16 years agor13370: Added deltest21 - pull the rug out from a connection by socket
Jeremy Allison [Mon, 6 Feb 2006 19:43:24 +0000 (19:43 +0000)]
r13370: Added deltest21 - pull the rug out from a connection by socket
close after setting delete on close flag.
Jeremy.
(This used to be commit fbea18e78f8a3c6dbb36aa935b7044c0fcf61da4)

16 years agor13369: let's have a way to show the samba4 version through ejs
Simo Sorce [Mon, 6 Feb 2006 18:29:57 +0000 (18:29 +0000)]
r13369: let's have a way to show the samba4 version through ejs
and use it in provisioning to fullfill rfc 3045 requirements
(This used to be commit 3fb9571a76481560304a826fc945983d52123299)

16 years agor13362: Rename variables for better consistency.
James Peach [Mon, 6 Feb 2006 04:06:55 +0000 (04:06 +0000)]
r13362: Rename variables for better consistency.
(This used to be commit dc20bb0ddc0824fc458e7fc4a9bce5059f4fc0d5)

16 years agor13361: initial implementation of the vlv control
Simo Sorce [Mon, 6 Feb 2006 01:21:17 +0000 (01:21 +0000)]
r13361: initial implementation of the vlv control
seem still buggy, can't make w2k3 to like it yet
(This used to be commit e1318383e91f6f6db39e3e3c9946fbb089753947)

16 years agor13360: Fix crash bug when 0 results are returned on the internal base search
Simo Sorce [Mon, 6 Feb 2006 00:39:05 +0000 (00:39 +0000)]
r13360: Fix crash bug when 0 results are returned on the internal base search
(This used to be commit fbee725ae87efbcf5887c923d55d7cb0d05476a6)

16 years agor13359: make sure we don't look at s[-1]
Stefan Metzmacher [Mon, 6 Feb 2006 00:27:02 +0000 (00:27 +0000)]
r13359: make sure we don't look at s[-1]

metze
(This used to be commit 24c6e2f73175befa33f9758634e3ee183916e387)

16 years agor13358: removed some unused functions and make some local functions static
Andrew Tridgell [Sun, 5 Feb 2006 23:13:44 +0000 (23:13 +0000)]
r13358: removed some unused functions and make some local functions static
(This used to be commit a73b76a36a70703738945d42795da6cf90c85105)

16 years agor13357: more docs
Simo Sorce [Sun, 5 Feb 2006 21:59:50 +0000 (21:59 +0000)]
r13357: more docs
(This used to be commit 5af9086deafc88aa1f9256cc0090592ecbd62203)

16 years agor13356: test utf8 usernames
Simo Sorce [Sun, 5 Feb 2006 21:25:18 +0000 (21:25 +0000)]
r13356: test utf8 usernames
(This used to be commit 7ddec83a602372765711bff7207657b73922aaea)

16 years agor13355: check controls are correctly exported
Simo Sorce [Sun, 5 Feb 2006 20:57:15 +0000 (20:57 +0000)]
r13355: check controls are correctly exported
(This used to be commit 07fa55db32dcb93bfb4406baca0cfba31d3bc189)

16 years agor13354: Add tests to check that controls work properly
Simo Sorce [Sun, 5 Feb 2006 20:48:27 +0000 (20:48 +0000)]
r13354: Add tests to check that controls work properly
Fix asq module, add a second_stage_init to register with rootdse
Fix asq control ldap parsing routines (this was nasty to find out)
(This used to be commit 933a80397d137f7d5b79c82a068d62bb6928ef47)

16 years agor13353: Fix a crash bug in rootdse when we do not pass in credentials
Simo Sorce [Sun, 5 Feb 2006 18:18:29 +0000 (18:18 +0000)]
r13353: Fix a crash bug in rootdse when we do not pass in credentials
a plain ldbsearch would just crash

Fix kludge_acl, not passing on the second stage registration
phase to other modules

Simo
(This used to be commit bec99c5cb65d8c32fd4f636ed2f5383fb1b39830)

16 years agor13352: Integrate Patch to support the ManageDSAIT control
Simo Sorce [Sun, 5 Feb 2006 17:28:27 +0000 (17:28 +0000)]
r13352: Integrate Patch to support the ManageDSAIT control
from Pete Rowley <prowley@redhat.com>
(This used to be commit bf20a848fda1607ca1b0d84791c299c0035793a1)

16 years agor13349: In the end I could not use ldb_caseless_cmp
Simo Sorce [Sat, 4 Feb 2006 18:30:30 +0000 (18:30 +0000)]
r13349: In the end I could not use ldb_caseless_cmp
in attrib_handler.c functions

remove it again

Simo
(This used to be commit 513ff499071e6cb5e608a82430718021f72997bd)

16 years agor13348: Put a reminder for now.
Simo Sorce [Sat, 4 Feb 2006 16:46:40 +0000 (16:46 +0000)]
r13348: Put a reminder for now.
Until we do not have an internal utf8 compliant
casefloding function we cannot pass this test
in the non-samba build
(This used to be commit 5d93c1eeba8f64784294f3aabcaefa4aaf798355)

16 years agor13347: - Now we compare values with an optimized utf8
Simo Sorce [Sat, 4 Feb 2006 16:44:27 +0000 (16:44 +0000)]
r13347: - Now we compare values with an optimized utf8
safe function if the user provides an utf8
compliant casefold function to ldb.

- Fix toupper_m and tolower_m to not crash if
the case tables are not found

- Let load_case_table() search into the correct
directory in the search tree for the case
tables so that we can test utf8

Simo
(This used to be commit e12f070958eb3c144beb81c5cb878db122249021)

16 years agor13346: use private proto header files for the torture tests
Stefan Metzmacher [Sat, 4 Feb 2006 14:08:24 +0000 (14:08 +0000)]
r13346: use private proto header files for the torture tests

metze
(This used to be commit 67837dbd2bcff8ec1917ba02884ee2eaa0776b46)

16 years agor13345: let us replicate with NT4sp6a
Stefan Metzmacher [Sat, 4 Feb 2006 13:54:30 +0000 (13:54 +0000)]
r13345: let us replicate with NT4sp6a

I don't yet know what the extra data in the start_association call mean...

This also let w2k use WREPL_REPL_INFORM messages to us, but w2k3 doesn't
it do it yet...

metze
(This used to be commit 02d6dfa1da754857c28125392a561cfde0087c48)

16 years agor13344: Trust SASL to have subtle distinctions between NULL and zero-length
Andrew Bartlett [Sat, 4 Feb 2006 11:19:09 +0000 (11:19 +0000)]
r13344: Trust SASL to have subtle distinctions between NULL and zero-length
responses...

Also trust OpenLDAP to be pedantic about it, breaking connections to AD.

In any case, we now get this 'right' (by nasty overloading hacks, but
hey), and we can now use system-supplied OpenLDAP libs and SASL/GSSAPI
to talk to Samba4.

Andrew Bartlett
(This used to be commit 0cbe18211a95f811b51865bc0e8729e9a302ad25)

16 years agor13342: Make the GSSAPI SASL mech actually work, by (shock horror) reading the spec.
Andrew Bartlett [Sat, 4 Feb 2006 09:53:50 +0000 (09:53 +0000)]
r13342: Make the GSSAPI SASL mech actually work, by (shock horror) reading the spec.

GSSAPI differs from GSS-SPNEGO in an additional 3 packets, negotiating
a buffer size and what integrity protection/privacy should be used.

I worked off draft-ietf-sasl-gssapi-03, and this works against Win2k3.

I'm doing this in the hope that Apple clients as well as SASL-based
LDAP tools may get a bit further.

I still can't get ldapsearch to work, it fails with the ever-helpful
'Local error'.

Andrew Bartlett
(This used to be commit 3e462897754b30306c1983af2d137329dd937ad6)

16 years agor13341: Trivial.
Andrew Bartlett [Sat, 4 Feb 2006 09:50:02 +0000 (09:50 +0000)]
r13341: Trivial.
(This used to be commit b986278b367a6693f69a06e07ca90f8b5a23a0c0)

16 years agor13340: The gensec_init() needs to be after the popt processing, as it
Andrew Bartlett [Sat, 4 Feb 2006 09:49:33 +0000 (09:49 +0000)]
r13340: The gensec_init() needs to be after the popt processing, as it
disables modules based on parametric options.

Andrew Bartlett
(This used to be commit db32a81f3ea661e2308cccca8d6a251a3d57337e)

16 years agor13339: Propogate more error infomation into the error packet and reformat the
Andrew Bartlett [Sat, 4 Feb 2006 09:48:22 +0000 (09:48 +0000)]
r13339: Propogate more error infomation into the error packet and reformat the
code a little.  This also fixes a segfault when we didn't fill in the
error message.

Andrew Bartlett
(This used to be commit 3be01a4ac7efe8d161910e8339bfe42584c0db86)

16 years agor13336: Doh! We actually never optimized for the ascii case.
Simo Sorce [Sat, 4 Feb 2006 08:55:35 +0000 (08:55 +0000)]
r13336: Doh! We actually never optimized for the ascii case.
In the 3.0 branches it is fixed this but we missed it for samba4
(This used to be commit baccb3c9147e161a6d2cbe371a60bf2ddcc0585c)

16 years agor13335: Fix the build and add an utf8 safe ldb_hadler_fold function
Simo Sorce [Sat, 4 Feb 2006 07:57:57 +0000 (07:57 +0000)]
r13335: Fix the build and add an utf8 safe ldb_hadler_fold function
based on ldb_casefold
(This used to be commit 6104f900863c688707809d42c5429a42d654d5fb)

16 years agor13334: Add comments describing what these functions do.
Andrew Bartlett [Sat, 4 Feb 2006 07:56:30 +0000 (07:56 +0000)]
r13334: Add comments describing what these functions do.

We still need many more, but it is a start...

Andrew Bartlett
(This used to be commit b2bda127f681dc1e2003c86159a85fa613373f16)

16 years agor13333: revert previous commit I will use ldb_caseless_cmp in attrib_handlers
Simo Sorce [Sat, 4 Feb 2006 06:57:28 +0000 (06:57 +0000)]
r13333: revert previous commit I will use ldb_caseless_cmp in attrib_handlers
to correctly support utf8 comparisons

add an ldb_attr_Casefold function for attribute names and use it
instead of casefold in the right places
(This used to be commit 3b4eb2413bbce059dde69f35c03cdc3cc2ba85c5)

16 years agor13328: After the attribute name check cleanup it turned up ldb_caseless_cmp()
Simo Sorce [Sat, 4 Feb 2006 05:59:48 +0000 (05:59 +0000)]
r13328: After the attribute name check cleanup it turned up ldb_caseless_cmp()
was used just in one places and by mistake, as there we should have
been using ldb_attr_cmp()

Remove ldb_caseless_cmp() ... going on with the cleanup and utf8 compliance
effort.

Simo.
(This used to be commit afda68d7bf655a9145648856d29e6e64b9f21aa3)

16 years agor13325: let samba register it's own utf8 aware functions in ldb
Simo Sorce [Sat, 4 Feb 2006 01:27:47 +0000 (01:27 +0000)]
r13325: let samba register it's own utf8 aware functions in ldb
(This used to be commit 12faf556833807d3f2aa4360c54e10583ac77fed)

16 years agor13324: From now on check attribute names obey rfc2251
Simo Sorce [Sat, 4 Feb 2006 00:38:48 +0000 (00:38 +0000)]
r13324: From now on check attribute names obey rfc2251
Also add a way to provide utf8 compliant functions
by registering them with ldb_set_utf8_fns()

Next comes code to register samba internal utf8 functions.

Simo.
(This used to be commit ac9b8a41ffca8e06c5e849d544d3203a665b8e0d)

16 years agor13321: Bind to each interface and to the 0.0.0.0 interface on the KDC. This
Andrew Bartlett [Fri, 3 Feb 2006 23:19:00 +0000 (23:19 +0000)]
r13321: Bind to each interface and to the 0.0.0.0 interface on the KDC.  This
was pointed out by Maurice Massar.  It ensures we get the addresses
for the krb5_mk_priv() correct (otherwise an MIT kpasswdd fails over
localhost).

Also never run the KDC unless we are a DC.

Andrew Bartlett
(This used to be commit c17007918459678004a009ccaa50fb85e8b6a739)

16 years agor13320: Fix kpasswd's use of the local HDB. /dev/null was a bad idea, we want
Andrew Bartlett [Fri, 3 Feb 2006 23:07:58 +0000 (23:07 +0000)]
r13320: Fix kpasswd's use of the local HDB.  /dev/null was a bad idea, we want
'no filename' instead.

Andrew Bartlett
(This used to be commit 7de385dca4c40e98a40ef1e769826de8bff64323)

16 years agor13317: Create a new function messaging_client_init() which can be used when
Andrew Bartlett [Fri, 3 Feb 2006 22:30:30 +0000 (22:30 +0000)]
r13317: Create a new function messaging_client_init() which can be used when
we don't have a server messaging context.  We should replace the
datagram messages with stream sockets in this case, so we don't have
to create a unique socket.

Andrew Bartlett
(This used to be commit fd974fb64792f8f6c532b01d2a2e012be18eef7e)

16 years agor13307: docs
Simo Sorce [Fri, 3 Feb 2006 15:58:41 +0000 (15:58 +0000)]
r13307: docs
(This used to be commit e56630d1f8688ff3ff334893a4bc49dff8e36fe2)

16 years agor13297: It's a good thing the shipment of function headers tridge
Jeremy Allison [Fri, 3 Feb 2006 02:07:22 +0000 (02:07 +0000)]
r13297: It's a good thing the shipment of function headers tridge
sent me arrived on time... :-).
Refactor this code to make it comprehensible. Tested
against W2K3 SP 1 and W2K SP 4. Test 19 is different
from what I thought. Turns out delete on close on
"open" of a directory (not create) does have an
effect - even if not reported in the flag bit.
trige please test against Vista (my XP box is
refusing to serve at the moment - have to reinstall).

Jeremy.
(This used to be commit 2b708e26185bfc0a909a33e74e67dd2101c3bbbe)

16 years agor13289: Check the tree is not NULL
Simo Sorce [Wed, 1 Feb 2006 20:48:05 +0000 (20:48 +0000)]
r13289: Check the tree is not NULL
Thanks to Aaron J. Seigo <aseigo@kde.org> for spotting this
(This used to be commit 4b5c0493e2276a9eba1bada7c4bac99999a465e2)

16 years agor13283: added two optimisations to the tdb transactions code. The first is to
Andrew Tridgell [Wed, 1 Feb 2006 10:50:26 +0000 (10:50 +0000)]
r13283: added two optimisations to the tdb transactions code. The first is to
more agressively coalesce entries in the linked list of the undo
log. The second is to ensure that writes during a transaction into the
hash table don't cause the size of the undo log linked list to grow.

These optimisations don't affect Samba much, but they make a huge
difference to the use of ldb in kde
(This used to be commit a37d9434d1fa181fd3d060ad032ee4ec5135fc52)

16 years agor13282: Indentation, and ensure we handle the talloc_free in the right place
Andrew Bartlett [Wed, 1 Feb 2006 10:04:55 +0000 (10:04 +0000)]
r13282: Indentation, and ensure we handle the talloc_free in the right place
all the time.

Andrew Bartlett
(This used to be commit 2aa9fefbb30959f29e9d5a79c4880f33a747b68c)

16 years agor13281: Use TALLOC_CTX * not a void *, and use tmp_ctx as the name for consistancy.
Andrew Bartlett [Wed, 1 Feb 2006 10:04:11 +0000 (10:04 +0000)]
r13281: Use TALLOC_CTX * not a void *, and use tmp_ctx as the name for consistancy.

(I was chasing ghosts in this code, and decided to do a cleanup while
I was there).

Andrew Bartlett
(This used to be commit c05f6be09a0cffdd0b87483f5b3751cc3f96e7f5)

16 years agor13280: Tidy up formatting.
James Peach [Wed, 1 Feb 2006 06:05:08 +0000 (06:05 +0000)]
r13280: Tidy up formatting.
(This used to be commit 531995000df77a54a4f2d7734e1ad33cd7cda37a)

16 years agor13278: remove a silly strcasecmp() replacement
Andrew Tridgell [Wed, 1 Feb 2006 05:24:19 +0000 (05:24 +0000)]
r13278: remove a silly strcasecmp() replacement
(This used to be commit 6ec71ffbc141df398aff3e11c45e35e15192c66f)

16 years agor13277: print a useful error message when test 17 fails
Andrew Tridgell [Wed, 1 Feb 2006 05:22:44 +0000 (05:22 +0000)]
r13277: print a useful error message when test 17 fails
(This used to be commit 70ad98b05136da0cdbd91b8374ac9709abfcadeb)

16 years agor13276: start to work towards the BASE-DELETE test passing. This change
Andrew Tridgell [Wed, 1 Feb 2006 05:20:54 +0000 (05:20 +0000)]
r13276: start to work towards the BASE-DELETE test passing. This change
ensures that we give the right error code to opens that are denied due
to the file having delete pending set
(This used to be commit c5b709fae66f9135e5c0e2eeb2e25dd8837b64de)

16 years agor13275: With a liberal sprinkling of smb_raw_exit this
Jeremy Allison [Wed, 1 Feb 2006 04:41:54 +0000 (04:41 +0000)]
r13275: With a liberal sprinkling of smb_raw_exit this
now passes for me for W2K and W2K3... booting the XP
box to test it...
Jeremy.
(This used to be commit 0133ba78c15b10e925f4e26e163656aa7cd11476)

16 years agor13272: Re-arrange so all the normal tests we can pass come first.
Jeremy Allison [Wed, 1 Feb 2006 04:09:02 +0000 (04:09 +0000)]
r13272: Re-arrange so all the normal tests we can pass come first.
Jeremy.
(This used to be commit 0b61a8df3c1b5b1a73bf6afd0404871286d3a2fc)

16 years agor13271: Do the same tests with directories.
Jeremy Allison [Wed, 1 Feb 2006 03:36:04 +0000 (03:36 +0000)]
r13271: Do the same tests with directories.
Jeremy.
(This used to be commit 7986af2ece2e707ee3d98dadb37af9fc5126d138)

16 years agor13270: Add tests for even more insane delete-on-close semantics.
Jeremy Allison [Wed, 1 Feb 2006 02:30:57 +0000 (02:30 +0000)]
r13270: Add tests for even more insane delete-on-close semantics.
Jeremy.
(This used to be commit ae0851ce667c0559e786c3a83389ccfddce1a813)

16 years agor13269: ${prefix} is a special case in the autoconf/build system, and should
Andrew Bartlett [Wed, 1 Feb 2006 01:38:39 +0000 (01:38 +0000)]
r13269: ${prefix} is a special case in the autoconf/build system, and should
be escaped as \${prefix}, otherwise it evaluates too early as "NONE".

Andrew Bartlett
(This used to be commit 6b42029de99011986c1fa7bfd5833dbbbf476206)

16 years agor13268: fixed typo noticed by Aaron Seigo
Andrew Tridgell [Tue, 31 Jan 2006 23:37:56 +0000 (23:37 +0000)]
r13268: fixed typo noticed by Aaron Seigo
(This used to be commit a49d024f3d4866655d4436a5c42b3c228374594b)

16 years agor13265: Clarify how delegation works with the remote RPC backend.
Andrew Bartlett [Tue, 31 Jan 2006 22:58:50 +0000 (22:58 +0000)]
r13265: Clarify how delegation works with the remote RPC backend.

Andrew Bartlett
(This used to be commit 75489ac8bced0f9e7ab28739fd6b26ab12cfa585)

16 years agor13264: Move declaration before code.
James Peach [Tue, 31 Jan 2006 22:41:53 +0000 (22:41 +0000)]
r13264: Move declaration before code.
(This used to be commit 6e55241a843f80cc513d06266b54b38ce48c51ed)

16 years agor13263: Check whether open(2) will accept the O_DIRECT flag. This should fix the
James Peach [Tue, 31 Jan 2006 21:56:12 +0000 (21:56 +0000)]
r13263: Check whether open(2) will accept the O_DIRECT flag. This should fix the
build on NetBSD.
(This used to be commit 7354de62a7fbf3921dfcb0bd865e89bdf1ef5bcd)

16 years agor13258: Fix the talloc heirachy for ldb_tdb.
Andrew Bartlett [Tue, 31 Jan 2006 11:16:43 +0000 (11:16 +0000)]
r13258: Fix the talloc heirachy for ldb_tdb.

In the return value res->msgs, msgs was not a child of res, in the
indexed path.  Instead, it hung directly off the ldb, which was
sometimes a long-term context.

Also remove unused parameters.

Found by --leak-report-full

Andrew Bartlett
(This used to be commit 29cb5af827c459758997c80dca034d471bb92449)

16 years agor13256: Free temporary memory on error cases, and try to clean up what's left
Andrew Bartlett [Tue, 31 Jan 2006 10:03:44 +0000 (10:03 +0000)]
r13256: Free temporary memory on error cases, and try to clean up what's left
earlier.

Move gendb_search() to use talloc_vasprintf() and steal only the parts
actually being used for the results.

Andrew Bartlett
(This used to be commit 53efb3e3e980c768e0aee216ccd8dc3e14707246)

16 years agor13255: New CIFS dd client for use in performance testing. The guts of this is
James Peach [Tue, 31 Jan 2006 06:09:18 +0000 (06:09 +0000)]
r13255: New CIFS dd client for use in performance testing. The guts of this is
in client/cifsdd*, which implements a minimal implementation of dd. The
IO path is careful to always perform IO at the requested block size.

There is a very basic test suite in script/tests/test_cifsdd.sh which
covers local and remote IO at a variety of block sizes.

Added to lib/util_str.c is a small set of conv_str_*() functions to
convert strings to the corresponding type.

smbcli_parse_unc is modified to insert NULL terminators after its
hostname and sharename parameters. This allows it to correctly parse a
path of the form //foo/share/path/file.
(This used to be commit cd2f94a65817bfae20ac21b730a2c42d8e581ab3)

16 years agor13253: More work to ensure that we don't keep data on long-term contexts.
Andrew Bartlett [Tue, 31 Jan 2006 03:20:18 +0000 (03:20 +0000)]
r13253: More work to ensure that we don't keep data on long-term contexts.

Andrew Bartlett
(This used to be commit 35517573ff807339f96573e58bdec29073be9594)

16 years agor13252: Cleanup, both in code, comments and talloc use:
Andrew Bartlett [Tue, 31 Jan 2006 03:15:16 +0000 (03:15 +0000)]
r13252: Cleanup, both in code, comments and talloc use:

In particular, I've used the --leak-report-full option to smbd to
track down memory that shouldn't be on a long-term context.  This is
now talloc_free()ed much earlier.

Andrew Bartlett
(This used to be commit c6eb74f42989d62c82d2a219251837b09df8491c)

16 years agor13250: I missed a couple of talloc_free()'s
Andrew Bartlett [Tue, 31 Jan 2006 02:01:52 +0000 (02:01 +0000)]
r13250: I missed a couple of talloc_free()'s

Andrew Bartlett
(This used to be commit 3570a62876dcd656b328bf8c2c1be617ae9a8fd7)

16 years agor13249: Check for alloca.h. popt needs this.
James Peach [Tue, 31 Jan 2006 01:53:21 +0000 (01:53 +0000)]
r13249: Check for alloca.h. popt needs this.
(This used to be commit 08bdaa8e106caeab675aaca5124f0e59fa20cc8c)

16 years agor13248: Revert revision 13071. It turns out that sys/param.h can be implicitly
James Peach [Tue, 31 Jan 2006 01:51:31 +0000 (01:51 +0000)]
r13248: Revert revision 13071. It turns out that sys/param.h can be implicitly
included from other headers. In this case, undeffing MIN and MAX is a
really bad idea because the subsequent include of sys/param.h will do
nothing because of its include guards.
(This used to be commit 8aa8be93b09cfbd176455738dfd305047030fd50)

16 years agor13247: Try to make better use of talloc in the auth/ and auth/gensec code.
Andrew Bartlett [Tue, 31 Jan 2006 01:50:54 +0000 (01:50 +0000)]
r13247: Try to make better use of talloc in the auth/ and auth/gensec code.
We don't want temporary memory hanging around on the long-term
contexts.

Andrew Bartlett
(This used to be commit 85b3f6ebddfb655fdd08d1799752e562a6ff9cb1)

16 years agor13246: Print winbindd pipe location correctly.
Andrew Bartlett [Tue, 31 Jan 2006 01:49:56 +0000 (01:49 +0000)]
r13246: Print winbindd pipe location correctly.

Andrew Bartlett
(This used to be commit fc045b42c24d9bfb10b9f98f38c771df4abcdee0)

16 years agor13245: Don't segfault if we don't have a credentials structure on this gensec
Andrew Bartlett [Tue, 31 Jan 2006 01:48:07 +0000 (01:48 +0000)]
r13245: Don't segfault if we don't have a credentials structure on this gensec
context.

Andrew Bartlett
(This used to be commit 1e840aa43679ceccb2a3afc694a5de0828147e8c)

16 years agor13244: Allow control of the location of the Samba3-compatible winbindd pipe
Andrew Bartlett [Tue, 31 Jan 2006 00:48:57 +0000 (00:48 +0000)]
r13244: Allow control of the location of the Samba3-compatible winbindd pipe
in Samba4.  This allows us to start winbindd by default, including in
'make test'.

This is via a new 'winbindd socket directory' parameter for utilities
linked against loadparm, as well as a --with-winbindd-socket-dir
option to configure (setting the default and the value for simple
clients).

I hope to add basic winbindd tests, to ensure continued correct
operation, but at least now I don't have to manually change my 'server
services' line.

The other problem with the hard-coded /tmp/.winbind is that RedHat has
moved this in Fedora (to /var/run I think).  For this reason, this
functionality should probably be ported to Samba3 as well.

The default for Samba4 is PREFIX/var/run/winbind_pipe.

I have also re-added the paranoia checks from Samba3 for correct
permissions on the socket directory.

Andrew Bartlett
(This used to be commit 8866aa06ffc3896094c878e9c07b40c03826d9a7)

16 years agor13243: Bring __FUNCTION__ checks across from Samba 3.
James Peach [Tue, 31 Jan 2006 00:00:10 +0000 (00:00 +0000)]
r13243: Bring __FUNCTION__ checks across from Samba 3.
(This used to be commit 92eec049628a79f8d9496c6d199d6de0238e7940)

16 years agor13242: cc-1009 cc: WARNING File = librpc/idl/nbt.idl, Line = 579
James Peach [Mon, 30 Jan 2006 23:43:17 +0000 (23:43 +0000)]
r13242: cc-1009 cc: WARNING File = librpc/idl/nbt.idl, Line = 579
cc-1009 cc: WARNING File = librpc/idl/nbt.idl, Line = 580
  A "/*" appears inside a comment.
(This used to be commit 53ac5a2fb251c04dab2b92cd8a9df8005e340e3a)

16 years agor13241: Work around missing AS_HELP_STRING definition in autoconf 2.57. Fix
James Peach [Mon, 30 Jan 2006 23:09:21 +0000 (23:09 +0000)]
r13241: Work around missing AS_HELP_STRING definition in autoconf 2.57. Fix
from Brad Hards <bradh@frogmouth.net>.
(This used to be commit 3ade52398a345cc50c1bf52298e36ab1804b00ec)

16 years agor13240: Make the test scripts use the new smb.conf location (in PREFIX/etc).
Andrew Bartlett [Mon, 30 Jan 2006 22:23:17 +0000 (22:23 +0000)]
r13240: Make the test scripts use the new smb.conf location (in PREFIX/etc).

Andrew Bartlett
(This used to be commit ea0a53d6795488ed530c3436343587595221cb78)

16 years agor13239: Silly little patch: make the order of declaration match the order of use.
Andrew Bartlett [Mon, 30 Jan 2006 22:22:37 +0000 (22:22 +0000)]
r13239: Silly little patch:  make the order of declaration match the order of use.
(This used to be commit 2b605cf22c7567e1171bf73cbbd37a5f0c1a4274)

16 years agor13228: revert more stuff from 13208
Stefan Metzmacher [Mon, 30 Jan 2006 08:12:35 +0000 (08:12 +0000)]
r13228: revert more stuff from 13208

metze
(This used to be commit 6c7065463fded629febd03efb2943d24cac74fda)

16 years agor13227: revert some more stuff from 13208
Stefan Metzmacher [Mon, 30 Jan 2006 07:59:53 +0000 (07:59 +0000)]
r13227: revert some more stuff from 13208

metze
(This used to be commit 03a0363850b7b38fc3621dfde38504d66156e728)

16 years agor13226: remove empty file
Stefan Metzmacher [Mon, 30 Jan 2006 07:58:45 +0000 (07:58 +0000)]
r13226: remove empty file

metze>
(This used to be commit b8a6792a43c3d41ceccd16046c9794e701c6acc1)

16 years agor13225: Enable full compiler warnings for developer mode on IRIX.
James Peach [Mon, 30 Jan 2006 05:24:59 +0000 (05:24 +0000)]
r13225: Enable full compiler warnings for developer mode on IRIX.
(This used to be commit 2aefbcb47272536d8c2229f8b199f7cd7da7d890)

16 years agor13210: Revert my named pipes patch until it passes not just 'make quicktest' but
Jelmer Vernooij [Sat, 28 Jan 2006 20:08:03 +0000 (20:08 +0000)]
r13210: Revert my named pipes patch until it passes not just 'make quicktest' but
also 'make test'
(This used to be commit e3d0676aee84e96e5c87bed4cd0cde75a4191953)

16 years agor13208: Clearly separate named pipes from the IPC$ NTVFS type.
Jelmer Vernooij [Sat, 28 Jan 2006 12:58:38 +0000 (12:58 +0000)]
r13208: Clearly separate named pipes from the IPC$ NTVFS type.

This allows the easy addition of additional named pipes and removes the
circular dependencies between the CIFS, RPC and RAP servers.

Simple tests for a custom named pipe included.
(This used to be commit 898d15acbd18e3b302a856c847e08c22c5024792)

16 years agor13207: Use the new API for using/not using kerbeors in hdb-ldb.c
Andrew Bartlett [Sat, 28 Jan 2006 12:19:20 +0000 (12:19 +0000)]
r13207: Use the new API for using/not using kerbeors in hdb-ldb.c

Update the rootdse module to use the new schema.

Andrew Bartlett
(This used to be commit b0b150d08ac39ed486071487826da2e306db6a0b)

16 years agor13206: This patch finally re-adds a -k option that works reasonably.
Andrew Bartlett [Sat, 28 Jan 2006 12:15:24 +0000 (12:15 +0000)]
r13206: This patch finally re-adds a -k option that works reasonably.

From here we can add tests to Samba for kerberos, forcing it on and
off.  In the process, I also remove the dependency of credentials on
GENSEC.

This also picks up on the idea of bringing 'set_boolean' into general
code from jpeach's cifsdd patch.

Andrew Bartlett
(This used to be commit 1ac7976ea6e3ad6184c911de5df624c44e7c5228)

16 years agor13205: Add another useful comment.
Andrew Bartlett [Sat, 28 Jan 2006 12:01:39 +0000 (12:01 +0000)]
r13205: Add another useful comment.

Andrew Bartlett
(This used to be commit 78d634047f41466e4bf169e727f730d776949b33)

16 years agor13204: Remove extra newline we don't need.
Andrew Bartlett [Sat, 28 Jan 2006 11:58:35 +0000 (11:58 +0000)]
r13204: Remove extra newline we don't need.

Andrew Bartlett
(This used to be commit 765caa14b340f5111c07eda99fd2bd4c000dd7c7)

16 years agor13203: Make this comment clearer.
Andrew Bartlett [Sat, 28 Jan 2006 11:57:33 +0000 (11:57 +0000)]
r13203: Make this comment clearer.

Andrew Bartlett
(This used to be commit 8e2b461669d2d4d5a789da66b5049ecbddd8fd15)

16 years agor13189: suggest a couple of dev libs before compiling.
Simo Sorce [Fri, 27 Jan 2006 18:16:53 +0000 (18:16 +0000)]
r13189: suggest a couple of dev libs before compiling.
(This used to be commit 9be094f7f45d996c37d3b25963643d0a8f710de5)

16 years agor13186: Remove assumption that callers that specify -1 actually mean sizeof(pstring)
Jelmer Vernooij [Fri, 27 Jan 2006 13:29:47 +0000 (13:29 +0000)]
r13186: Remove assumption that callers that specify -1 actually mean sizeof(pstring)
(This used to be commit da72f47226f9c514deb75bc6e69548c240822eb5)

16 years agor13182: Add first bits of browsing testsuite.
Jelmer Vernooij [Fri, 27 Jan 2006 13:10:24 +0000 (13:10 +0000)]
r13182: Add first bits of browsing testsuite.
(This used to be commit 841fb3d4e764dc7ae8222ad7cb69dc6244035ea2)

16 years agor13181: Fix standalone ldb build
Jelmer Vernooij [Fri, 27 Jan 2006 05:10:20 +0000 (05:10 +0000)]
r13181: Fix standalone ldb build
(This used to be commit e9059ea0c56c1fd9886eb038df5455efe11962f8)

16 years agor13180: Add note about smb.conf location
Jelmer Vernooij [Fri, 27 Jan 2006 04:57:40 +0000 (04:57 +0000)]
r13180: Add note about smb.conf location
(This used to be commit 13bcc90fde9fcce6cf7c785d7e47522c42f71c53)

16 years agor13179: Add note about removing the optional password argument to smbclient.
Jelmer Vernooij [Fri, 27 Jan 2006 04:42:40 +0000 (04:42 +0000)]
r13179: Add note about removing the optional password argument to smbclient.
(This used to be commit 7bd2947286533ab9708a31c7c94972d3adf8faa6)

16 years agor13170: Remove some dependencies on -1 implying the size of pstring
Jelmer Vernooij [Thu, 26 Jan 2006 22:22:26 +0000 (22:22 +0000)]
r13170: Remove some dependencies on -1 implying the size of pstring
(This used to be commit f7c28d31481f6479f258cd878d173cbc42ed9de0)

16 years agor13169: Fix typo (noticed by Jeroen Keiren)
Jelmer Vernooij [Thu, 26 Jan 2006 22:16:38 +0000 (22:16 +0000)]
r13169: Fix typo (noticed by Jeroen Keiren)
(This used to be commit d5714f7284fce5dc8ed6bdeed394dac4fad3d1e2)

16 years agor13167: handle cotrols' reply even in error
Simo Sorce [Thu, 26 Jan 2006 16:42:25 +0000 (16:42 +0000)]
r13167: handle cotrols' reply even in error
(This used to be commit b9d1d02f381cf81883c9f22a1702319f5fce6eb8)

16 years agor13166: Patches form Brad Hards
Simo Sorce [Thu, 26 Jan 2006 16:37:37 +0000 (16:37 +0000)]
r13166: Patches form Brad Hards
(This used to be commit 335050b30d832f529fb8fdd4f96e4bb3de93f38c)

16 years agor13163: as we don't import the raw magic configure vars for
Stefan Metzmacher [Thu, 26 Jan 2006 12:59:55 +0000 (12:59 +0000)]
r13163: as we don't import the raw magic configure vars for
libdir, datadir, sysconfdir,localstatedir into our Makefile
we need to expand them in configure

I'll maybe rework this later but for now this works

metze
(This used to be commit 615b82f7c73ff52ab62489ec635aefecf2b2f04c)

16 years agor13161: Remove optional password as second parameter. Improve return values a bit.
Jelmer Vernooij [Thu, 26 Jan 2006 11:48:45 +0000 (11:48 +0000)]
r13161: Remove optional password as second parameter. Improve return values a bit.
(This used to be commit 94dd559755d1c114588fb6b1353749cf96706269)

16 years agor13160: Fix some of the smbclient testsuite (after failures on the buildfarm)
Jelmer Vernooij [Thu, 26 Jan 2006 11:47:45 +0000 (11:47 +0000)]
r13160: Fix some of the smbclient testsuite (after failures on the buildfarm)
(This used to be commit 765991ab486188bce76332b00194efbd6cbb3e01)