From: Tim Beale Date: Mon, 28 Jan 2019 01:11:09 +0000 (+1300) Subject: tests: Remove redundant credentials from auth_log tests X-Git-Tag: talloc-2.2.0~197 X-Git-Url: http://git.samba.org/samba.git/?p=gd%2Fsamba-autobuild%2F.git;a=commitdiff_plain;h=3ce28f918cedaf37b4ebc7b80d243030b41c20bb tests: Remove redundant credentials from auth_log tests The LDB connection in these tests is to the direct sam.ldb file on disk, so the credentials are not actually needed (and in fact, weren't event initialized correctly). These tests always need to run on the DC itself (i.e. :local testenv) because they use ncalrpc connections. Signed-off-by: Tim Beale Reviewed-by: Andrew Bartlett --- diff --git a/python/samba/tests/auth_log_netlogon.py b/python/samba/tests/auth_log_netlogon.py index 83ffd33c1a6..36920eeef34 100644 --- a/python/samba/tests/auth_log_netlogon.py +++ b/python/samba/tests/auth_log_netlogon.py @@ -47,12 +47,9 @@ class AuthLogTestsNetLogon(samba.tests.auth_log_base.AuthLogTestBase): def setUp(self): super(AuthLogTestsNetLogon, self).setUp() self.lp = samba.tests.env_loadparm() - self.creds = Credentials() - self.session = system_session() self.ldb = SamDB( session_info=self.session, - credentials=self.creds, lp=self.lp) self.domain = os.environ["DOMAIN"] diff --git a/python/samba/tests/auth_log_netlogon_bad_creds.py b/python/samba/tests/auth_log_netlogon_bad_creds.py index 3b699bb6505..bd8b497cd88 100644 --- a/python/samba/tests/auth_log_netlogon_bad_creds.py +++ b/python/samba/tests/auth_log_netlogon_bad_creds.py @@ -49,12 +49,9 @@ class AuthLogTestsNetLogonBadCreds(samba.tests.auth_log_base.AuthLogTestBase): def setUp(self): super(AuthLogTestsNetLogonBadCreds, self).setUp() self.lp = samba.tests.env_loadparm() - self.creds = Credentials() - self.session = system_session() self.ldb = SamDB( session_info=self.session, - credentials=self.creds, lp=self.lp) self.domain = os.environ["DOMAIN"] diff --git a/python/samba/tests/auth_log_samlogon.py b/python/samba/tests/auth_log_samlogon.py index eeb64df41eb..4959543937e 100644 --- a/python/samba/tests/auth_log_samlogon.py +++ b/python/samba/tests/auth_log_samlogon.py @@ -47,12 +47,9 @@ class AuthLogTestsSamLogon(samba.tests.auth_log_base.AuthLogTestBase): def setUp(self): super(AuthLogTestsSamLogon, self).setUp() self.lp = samba.tests.env_loadparm() - self.creds = Credentials() - self.session = system_session() self.ldb = SamDB( session_info=self.session, - credentials=self.creds, lp=self.lp) self.domain = os.environ["DOMAIN"]