ldb_dn: don't free a known NULL pointer
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 8 Feb 2019 02:49:56 +0000 (15:49 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 13 Feb 2019 03:15:15 +0000 (04:15 +0100)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
lib/ldb/common/ldb_dn.c

index f053e815ad49d44f337a916f2095cd5d586e3113..a2122a8a80ae883847f3af17e75696a53cee5191 100644 (file)
@@ -325,12 +325,9 @@ static bool ldb_dn_explode(struct ldb_dn *dn)
                return true;
        }
 
-       /* make sure we free this if allocated previously before replacing */
-       LDB_FREE(dn->components);
-       dn->comp_num = 0;
-
        LDB_FREE(dn->ext_components);
        dn->ext_comp_num = 0;
+       dn->comp_num = 0;
 
        /* in the common case we have 3 or more components */
        /* make sure all components are zeroed, other functions depend on it */