dsdb: give a better error message and return code on failed password change

Change-Id: I064a7e192caccbb5acc17ba385f1625425c176d1
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
index 8cecf79e020df847be5c5b8b1ec773cae10ef4dc..0ad0ea37ed70a8cd0d47050fa05a48c3c1d2f87e 100644 (file)
--- a/source4/dsdb/common/util.c
+++ b/source4/dsdb/common/util.c
@@ -2174,7 +2174,12 @@ NTSTATUS samdb_set_password(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
        } else if (ret == LDB_ERR_NO_SUCH_OBJECT) {
                /* don't let the caller know if an account doesn't exist */
                status = NT_STATUS_WRONG_PASSWORD;
+       } else if (ret == LDB_ERR_INSUFFICIENT_ACCESS_RIGHTS) {
+               status = NT_STATUS_ACCESS_DENIED;
        } else if (ret != LDB_SUCCESS) {
+               DEBUG(1, ("Failed to set password on %s: %s\n",
+                         ldb_dn_get_linearized(msg->dn),
+                         ldb_errstring(ldb)));
                status = NT_STATUS_UNSUCCESSFUL;
        }